core_validation.cpp revision 5a8cba534d14ce341ba7a2100a542e93f0e3033c
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 41825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski//#include <memory> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 46dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes#include <tuple> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 63b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 69c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine#define LOGCONSOLE(...) \ 70c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine { \ 71c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf(__VA_ARGS__); \ 72c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf("\n"); \ 73c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 77414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 78d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 79d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 86b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 88e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 893f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 9856a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu VkInstance instance; 99b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski unique_ptr<INSTANCE_STATE> instance_state; 100b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski 10156a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu 1025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 10694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 108cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski unordered_set<VkQueue> queues; // All queues under given device 109cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Vector indices correspond to queueFamilyIndex 110cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski vector<unique_ptr<VkQueueFamilyProperties>> queue_family_properties; 1115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 114cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> samplerMap; 1152c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis unordered_map<VkImageView, unique_ptr<VkImageViewCreateInfo>> imageViewMap; 1166d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis unordered_map<VkImage, unique_ptr<IMAGE_NODE>> imageMap; 1172f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis unordered_map<VkBufferView, unique_ptr<VkBufferViewCreateInfo>> bufferViewMap; 1188718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis unordered_map<VkBuffer, unique_ptr<BUFFER_NODE>> bufferMap; 1195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1208d6a38de0389036581ada119e548180c614fe0efChris Forbes unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 122397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 123cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 12557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; 1265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 13272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 13304861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_NODE>> frameBufferMap; 1345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 137918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1386c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 141b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 142b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 143f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkPhysicalDeviceFeatures physical_device_features; 144cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski unique_ptr<PHYSICAL_DEVICE_STATE> physical_device_state; 145b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 147b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski : instance_state(nullptr), report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), 148825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski device_extensions(), device(VK_NULL_HANDLE), phys_dev_properties{}, phys_dev_mem_props{}, physical_device_features{}, 149cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski physical_device_state(nullptr){}; 1505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 152b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 153b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 154b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 155e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 156f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 157e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 162e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 168e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 182b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 183b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 184b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 185b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 186b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 187b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 189b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 190b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 191b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 192b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 193b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 194b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 253b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 254593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 2552c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis// Return ImageViewCreateInfo ptr for specified imageView or else NULL 256a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkImageViewCreateInfo *getImageViewData(const layer_data *dev_data, VkImageView image_view) { 2572c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_it = dev_data->imageViewMap.find(image_view); 2582c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (iv_it == dev_data->imageViewMap.end()) { 2592c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return nullptr; 2602c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis } 2612c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return iv_it->second.get(); 2622c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis} 2639a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis// Return sampler node ptr for specified sampler or else NULL 264a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSAMPLER_NODE *getSamplerNode(const layer_data *dev_data, VkSampler sampler) { 2652c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto sampler_it = dev_data->samplerMap.find(sampler); 2662c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (sampler_it == dev_data->samplerMap.end()) { 2679a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return nullptr; 2689a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis } 2699a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return sampler_it->second.get(); 2709a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis} 2716d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis// Return image node ptr for specified image or else NULL 272a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisIMAGE_NODE *getImageNode(const layer_data *dev_data, VkImage image) { 2736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_it = dev_data->imageMap.find(image); 2746d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_it == dev_data->imageMap.end()) { 2756d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return nullptr; 2766d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis } 2776d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return img_it->second.get(); 2786d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis} 2798718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis// Return buffer node ptr for specified buffer or else NULL 280a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisBUFFER_NODE *getBufferNode(const layer_data *dev_data, VkBuffer buffer) { 2812c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 2822c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (buff_it == dev_data->bufferMap.end()) { 2838718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return nullptr; 2848718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis } 2858718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return buff_it->second.get(); 2868718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis} 287b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis// Return swapchain node for specified swapchain or else NULL 288a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { 289b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); 290b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swp_it == dev_data->device_extensions.swapchainMap.end()) { 291b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis return nullptr; 292b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis } 2933f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis return swp_it->second.get(); 294b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis} 295170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis// Return swapchain for specified image or else NULL 296a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { 297170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); 298170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { 299170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return VK_NULL_HANDLE; 300170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis } 301170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return img_it->second; 302170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis} 3032f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis// Return buffer node ptr for specified buffer or else NULL 304a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkBufferViewCreateInfo *getBufferViewInfo(const layer_data *my_data, VkBufferView buffer_view) { 3052f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis auto bv_it = my_data->bufferViewMap.find(buffer_view); 3062f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis if (bv_it == my_data->bufferViewMap.end()) { 3072f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return nullptr; 3082f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis } 3092f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return bv_it->second.get(); 3102f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis} 3118718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis 31266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesFENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { 31366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->fenceMap.find(fence); 31466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->fenceMap.end()) { 31566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 31666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 31766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 31866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 31966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3209556936067fd0c4eb74c4a13631bc163b154faedTobin EhlisEVENT_NODE *getEventNode(layer_data *dev_data, VkEvent event) { 3219556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto it = dev_data->eventMap.find(event); 3229556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (it == dev_data->eventMap.end()) { 3239556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return nullptr; 3249556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 3259556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return &it->second; 3269556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis} 3279556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis 328ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin EhlisQUERY_POOL_NODE *getQueryPoolNode(layer_data *dev_data, VkQueryPool query_pool) { 329ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto it = dev_data->queryPoolMap.find(query_pool); 330ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (it == dev_data->queryPoolMap.end()) { 331ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return nullptr; 332ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 333ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return &it->second; 334ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis} 335ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis 33666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesQUEUE_NODE *getQueueNode(layer_data *dev_data, VkQueue queue) { 33766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->queueMap.find(queue); 33866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->queueMap.end()) { 33966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 34066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 34166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 34266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 34366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3445e92f3cfdca6a52a3dcefd053c41f728bd036cebChris ForbesSEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { 3455e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes auto it = dev_data->semaphoreMap.find(semaphore); 3465e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes if (it == dev_data->semaphoreMap.end()) { 3475e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return nullptr; 3485e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes } 3495e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return &it->second; 3505e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes} 3515e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes 3528d6a38de0389036581ada119e548180c614fe0efChris ForbesCOMMAND_POOL_NODE *getCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { 3538d6a38de0389036581ada119e548180c614fe0efChris Forbes auto it = dev_data->commandPoolMap.find(pool); 3548d6a38de0389036581ada119e548180c614fe0efChris Forbes if (it == dev_data->commandPoolMap.end()) { 3558d6a38de0389036581ada119e548180c614fe0efChris Forbes return nullptr; 3568d6a38de0389036581ada119e548180c614fe0efChris Forbes } 3578d6a38de0389036581ada119e548180c614fe0efChris Forbes return &it->second; 3588d6a38de0389036581ada119e548180c614fe0efChris Forbes} 3598d6a38de0389036581ada119e548180c614fe0efChris Forbes 36094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 3615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 3625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 3636d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, VkImage(handle)); 3646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_node) 3656d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return &img_node->mem; 3665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 3698718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buff_node = getBufferNode(my_data, VkBuffer(handle)); 3708718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buff_node) 3718718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return &buff_node->mem; 3725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 3785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 3815121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 38272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 3835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 3870a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 3880a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 3890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 390e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 39183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 3925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 3945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 3955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 39783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 39883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 39983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 40083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 4015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 406249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 407249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// an error will be flagged if usage is not correct 40859b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlisstatic bool ValidateImageUsageFlags(layer_data *dev_data, IMAGE_NODE const *image_node, VkFlags desired, VkBool32 strict, 409249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis char const *func_name, char const *usage_string) { 410249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis return validate_usage_flags(dev_data, image_node->createInfo.usage, desired, strict, 411249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis reinterpret_cast<const uint64_t &>(image_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 412249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "image", func_name, usage_string); 413249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis} 414249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 415249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// Helper function to validate usage flags for buffers 416ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 417ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// an error will be flagged if usage is not correct 41859b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlisstatic bool ValidateBufferUsageFlags(layer_data *dev_data, BUFFER_NODE const *buffer_node, VkFlags desired, VkBool32 strict, 419ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis char const *func_name, char const *usage_string) { 420ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return validate_usage_flags(dev_data, buffer_node->createInfo.usage, desired, strict, 421ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 422ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "buffer", func_name, usage_string); 423ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 424ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 4255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 4265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 42757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin EhlisDEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { 42857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_it = dev_data->memObjMap.find(mem); 42957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_it == dev_data->memObjMap.end()) { 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis return mem_it->second.get(); 4335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); 4405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 441cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given bound_object_handle, bound to given mem allocation, verify that the range for the bound object is valid 442f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateMemoryIsValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t bound_object_handle, 443f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis const char *functionName) { 444f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 445f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 446f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (!mem_info->bound_ranges[bound_object_handle].valid) { 447f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 448f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 449f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "%s: Cannot read invalid memory 0x%" PRIx64 ", please fill the memory before using.", functionName, 450f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis reinterpret_cast<uint64_t &>(mem)); 451f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 452f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 453f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return false; 454f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 455f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given image_node 456f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// If mem is special swapchain key, then verify that image_node valid member is true 457f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else verify that the image's bound memory range is valid 458f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateImageMemoryIsValid(layer_data *dev_data, IMAGE_NODE *image_node, const char *functionName) { 459f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (image_node->mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 460f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (!image_node->valid) { 46158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 462f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis reinterpret_cast<uint64_t &>(image_node->mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 463414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 464f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis functionName, reinterpret_cast<uint64_t &>(image_node->image)); 4655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 467f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateMemoryIsValid(dev_data, image_node->mem, reinterpret_cast<uint64_t &>(image_node->image), functionName); 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 4705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 471f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer_node, verify that the range it's bound to is valid 472f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateBufferMemoryIsValid(layer_data *dev_data, BUFFER_NODE *buffer_node, const char *functionName) { 473f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateMemoryIsValid(dev_data, buffer_node->mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), functionName); 474f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 475f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For the given memory allocation, set the range bound by the given handle object to the valid param value 476f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetMemoryValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, bool valid) { 477f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 478f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 479f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis mem_info->bound_ranges[handle].valid = valid; 480f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 481f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 482f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given image node 483f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// If mem is special swapchain key, then set entire image_node to valid param value 484f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else set the image's bound memory range to valid param value 485f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetImageMemoryValid(layer_data *dev_data, IMAGE_NODE *image_node, bool valid) { 486f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (image_node->mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 487f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis image_node->valid = valid; 4885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 489f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetMemoryValid(dev_data, image_node->mem, reinterpret_cast<uint64_t &>(image_node->image), valid); 4905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 492f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer node set the buffer's bound memory range to valid param value 493f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetBufferMemoryValid(layer_data *dev_data, BUFFER_NODE *buffer_node, bool valid) { 494f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetMemoryValid(dev_data, buffer_node->mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), valid); 495f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 4965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 4975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 498e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 499e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 50083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 5035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 50657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 5075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 508de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb); 5095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 51072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 5115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 51272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 513c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 5145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 5185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 519ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 52056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given sampler and command buffer node 52156f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlisvoid AddCommandBufferBindingSampler(GLOBAL_CB_NODE *cb_node, SAMPLER_NODE *sampler_node) { 52256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis sampler_node->cb_bindings.insert(cb_node); 52356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(sampler_node->sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}); 52456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis} 52556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis 52656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given image node and command buffer node 527c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlisvoid AddCommandBufferBindingImage(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_NODE *img_node) { 528ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Skip validation if this image was created through WSI 529ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (img_node->mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 530ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 531ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, img_node->mem); 532ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 533de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb_node->commandBuffer); 534ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 535ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->memObjs.insert(img_node->mem); 536ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 537bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(img_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); 538ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 539ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update cb binding for image 540ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis img_node->cb_bindings.insert(cb_node); 541ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 542ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 543ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// Create binding link between given buffer node and command buffer node 544c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlisvoid AddCommandBufferBindingBuffer(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_NODE *buff_node) { 545ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 546ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, buff_node->mem); 547ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 548de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb_node->commandBuffer); 549ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 550ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->memObjs.insert(buff_node->mem); 551bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 552ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 553ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update cb binding for buffer 554ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis buff_node->cb_bindings.insert(cb_node); 555ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 556ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 557400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 558400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 55972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 560c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 561c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 56257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 5635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 564de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pInfo->command_buffer_bindings.erase(pCBNode->commandBuffer); 5655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 567c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 572400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 573400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 574400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 5755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 578e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 57983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 580de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size_t cmdBufRefCount = pMemObjInfo->command_buffer_bindings.size(); 581de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size_t objRefCount = pMemObjInfo->obj_bindings.size(); 5825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 583de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if ((pMemObjInfo->command_buffer_bindings.size()) != 0) { 58483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 58583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 58683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to free memory object 0x%" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 58783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " references", 58883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 5895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 591de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (cmdBufRefCount > 0 && pMemObjInfo->command_buffer_bindings.size() > 0) { 592de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto cb : pMemObjInfo->command_buffer_bindings) { 59358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 594de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 595414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%p still has a reference to mem obj 0x%" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 5965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 598de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemObjInfo->command_buffer_bindings.clear(); 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 601de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (objRefCount > 0 && pMemObjInfo->obj_bindings.size() > 0) { 602de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto obj : pMemObjInfo->obj_bindings) { 603896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 604414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, 605896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 6065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 608de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemObjInfo->obj_bindings.clear(); 6095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 613e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 61483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 61657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 6175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 618ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO: Verify against Valid Use section 619ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Clear any CB bindings for completed CBs 620ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO : Is there a better place to do this? 621ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 622ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller assert(pInfo->object != VK_NULL_HANDLE); 623ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // clear_cmd_buf_and_mem_references removes elements from 624de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis // pInfo->command_buffer_bindings -- this copy not needed in c++14, 625ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // and probably not needed in practice in c++11 626de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis auto bindings = pInfo->command_buffer_bindings; 627ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (auto cb : bindings) { 628ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 629ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller clear_cmd_buf_and_mem_references(dev_data, cb); 6305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 631ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 6325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 633ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Now verify that no references to this mem obj remain and remove bindings 634de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (pInfo->command_buffer_bindings.size() || pInfo->obj_bindings.size()) { 635ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call |= reportMemReferencesAndCleanUp(dev_data, pInfo); 6365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 637ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Delete mem obj info 638ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->memObjMap.erase(dev_data->memObjMap.find(mem)); 639ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } else if (VK_NULL_HANDLE != mem) { 640ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // The request is to free an invalid, non-zero handle 641ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 642ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 643ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem), __LINE__, 644ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller MEMTRACK_INVALID_MEM_OBJ, 645ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "MEM", "Request to delete memory object 0x%" 646ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller PRIxLEAST64 " not present in memory Object Map", 647ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem)); 6485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 6505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 6535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 6545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 6555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 6565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 6575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 6585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 6595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 660e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: 661e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis return "descriptor set"; 662e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: 663e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis return "buffer"; 6649556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: 6659556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return "event"; 666ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: 667ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return "query pool"; 668a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: 669a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis return "pipeline"; 67056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: 67156f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis return "sampler"; 6725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 6735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 6745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 679c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 6805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 6810a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 6825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 68383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 68494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 68594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 68657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = getMemObjInfo(dev_data, *pMemBinding); 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 68894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 690c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 6915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 692de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (!pMemObjInfo->obj_bindings.erase({handle, type})) { 69383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 69458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 695414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 696414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 6975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 6985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 704b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was ever bound to this image 705694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlisbool ValidateMemoryIsBoundToImage(const layer_data *dev_data, const IMAGE_NODE *image_node, const char *api_name) { 706b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 707b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == (static_cast<uint32_t>(image_node->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { 708b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == image_node->mem) { 709b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 710694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis reinterpret_cast<const uint64_t &>(image_node->image), __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 711694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis "%s: VkImage object 0x%" PRIxLEAST64 " used without first calling vkBindImageMemory.", api_name, 712694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis reinterpret_cast<const uint64_t &>(image_node->image)); 713b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 714b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 715b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 716b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 717b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 718b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was bound to this buffer 719694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlisbool ValidateMemoryIsBoundToBuffer(const layer_data *dev_data, const BUFFER_NODE *buffer_node, const char *api_name) { 720b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 72112e3a5f6e672b103f705424595ffe3c4687492ceTobin Ehlis if (0 == (static_cast<uint32_t>(buffer_node->createInfo.flags) & VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) { 722b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == buffer_node->mem) { 723b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 724694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer), __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 725694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis "%s: VkBuffer object 0x%" PRIxLEAST64 " used without first calling vkBindBufferMemory.", api_name, 726694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer)); 727b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 728b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 729b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 730b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 731b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 7325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 7335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 7345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 7355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 7365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 73794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 73894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 73983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 7415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 7425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 74383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 74483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 7455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 74694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 7472e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 74857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 7492e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pMemInfo) { 75057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = getMemObjInfo(dev_data, *pMemBinding); 7512e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pPrevBinding != NULL) { 75283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 75383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, 75483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 75583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis ") which has already been bound to mem object 0x%" PRIxLEAST64, 75683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 7572e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis } else { 758de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->obj_bindings.insert({handle, type}); 7592e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // For image objects, make sure default memory state is correctly set 7602e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO : What's the best/correct way to handle this? 7612e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 7626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, VkImage(handle)); 7636d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 7646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo ici = image_node->createInfo; 7652e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 7662e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO:: More memory state transition stuff. 7675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7702e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 7715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 7785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 7795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 7805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 7815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 7820a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 7830a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 7840a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 78583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = VK_FALSE; 7865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 7875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 78883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = clear_object_binding(dev_data, handle, type); 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 7912e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 79257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 7932e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pInfo) { 794de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pInfo->obj_bindings.insert({handle, type}); 7952e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // Need to set mem binding for this object 7962e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 7975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 8005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 802caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis// For handle of given object type, return memory binding 803caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlisstatic bool get_mem_for_type(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 804caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis bool skip_call = false; 8055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 806caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis switch (type) { 807caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 808caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis *mem = getImageNode(dev_data, VkImage(handle))->mem; 809caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 810caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 811caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis *mem = getBufferNode(dev_data, VkBuffer(handle))->mem; 812caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 813caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis default: 814caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis assert(0); 8155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 816caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis if (!*mem) { 817caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 818caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis "MEM", "Trying to get mem binding for %s object 0x%" PRIxLEAST64 819caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis " but binding is NULL. Has memory been bound to this object?", 820caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis object_type_to_string(type), handle); 821caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis } 822caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis return skip_call; 823caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis} 824caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 8260a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 82858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 83358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 83558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 83658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 84357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = (*ii).second.get(); 8445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 84657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)mem_info); 84758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 84857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(mem_info->mem)); 84958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 850c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 851de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->command_buffer_bindings.size() + mem_info->obj_bindings.size()); 852de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (0 != mem_info->alloc_info.allocationSize) { 853de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&mem_info->alloc_info, "MEM(INFO): "); 85458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 863de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->obj_bindings.size()); 864de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->obj_bindings.size() > 0) { 865de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto obj : mem_info->obj_bindings) { 86658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 867414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 874de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->command_buffer_bindings.size()); 875de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->command_buffer_bindings.size() > 0) { 876de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto cb : mem_info->command_buffer_bindings) { 87758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 878414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB 0x%p", cb); 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8840a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 88572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 89372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 89472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 90272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 905414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has CB 0x%p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 907c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 909c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 911414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 9945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 10025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 10795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 10805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 10815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 10825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 10955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 10965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 10995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 11005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 11015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 11025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 11035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 11085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 11305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 11315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11399ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11409ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11469ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 11479ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11499ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 11509ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11529ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 11539ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 11559ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 11569ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11579ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11599ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 11609ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11619ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11639ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 11649ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11659ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11679ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 11689ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 11699ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 11719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 11725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 11739ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 11749ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 11759ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 11769ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 11779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 11789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 11839ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 11849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 11869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 11879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 11909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 11919ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 11949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 12009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 12019ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 12029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 12039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 12049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 12059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 120637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 120737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 120837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 120937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 121037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 121137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 121237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 121337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 121437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 12155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12217c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 122237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 12237c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12247c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 122737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 122837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 122937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 123037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 123137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12387c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 12397c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 124037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 12417c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12427c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12437c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 12447c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 12457c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 12467c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12477c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 12495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 12507c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 12515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 12525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 12537c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 12555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 12567c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 125837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 125937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 126037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 126137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 126237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 126337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 126437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 126537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 126637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 12675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 126837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 126937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 12735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 127437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 12755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 12765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 12775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 12785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 12795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 12805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 12815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 128437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 12905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 13005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 13025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 13055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 13215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1325cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1326cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1327cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1328cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1329cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1330cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1331cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1332cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1333cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1343c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1344c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1345c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1346c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1347c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1348c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1349c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1350c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1351c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1352c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1353c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1354c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1355c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1356c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 13615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1364b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1365fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1369031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1370031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1371031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1372031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1373031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1374031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1375031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1376031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1377031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1378031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1379031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1380031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1381031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1382031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 13845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1399edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 14003a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> *out, 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1402b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1404031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1442b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1443fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 14443a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes (*out)[std::make_pair(location + offset, component)] = v; 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14513a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::map<location_t, interface_var> collect_interface_by_location( 14523a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes shader_module const *src, spirv_inst_iter entrypoint, 14533a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes spv::StorageClass sinterface, bool is_array_of_verts) { 14543a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1459b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 14805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 14815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1482b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1483b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1484b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1485b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 149181264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 14925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1496c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15023a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> out; 15033a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15091d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1516b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 15297c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1535b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1536fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 15413a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes collect_interface_block_members(src, &out, blocks, is_array_of_verts, id, type, is_patch); 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15453a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15463a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15493a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<uint32_t, interface_var>> collect_interface_by_input_attachment_index( 15503a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 15513a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 15523a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15533a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<uint32_t, interface_var>> out; 1554745d49409296f060402b57950384caadb636a2b2Chris Forbes 1555745d49409296f060402b57950384caadb636a2b2Chris Forbes for (auto insn : *src) { 1556745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.opcode() == spv::OpDecorate) { 1557745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.word(2) == spv::DecorationInputAttachmentIndex) { 1558745d49409296f060402b57950384caadb636a2b2Chris Forbes auto attachment_index = insn.word(3); 1559745d49409296f060402b57950384caadb636a2b2Chris Forbes auto id = insn.word(1); 1560745d49409296f060402b57950384caadb636a2b2Chris Forbes 1561745d49409296f060402b57950384caadb636a2b2Chris Forbes if (accessible_ids.count(id)) { 1562745d49409296f060402b57950384caadb636a2b2Chris Forbes auto def = src->get_def(id); 1563745d49409296f060402b57950384caadb636a2b2Chris Forbes assert(def != src->end()); 1564745d49409296f060402b57950384caadb636a2b2Chris Forbes 1565745d49409296f060402b57950384caadb636a2b2Chris Forbes if (def.opcode() == spv::OpVariable && insn.word(3) == spv::StorageClassUniformConstant) { 1566e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes auto num_locations = get_locations_consumed_by_type(src, def.word(1), false); 1567e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes for (unsigned int offset = 0; offset < num_locations; offset++) { 1568e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes interface_var v; 1569e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.id = id; 1570e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.type_id = def.word(1); 1571e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.offset = offset; 1572e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_patch = false; 1573e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_block_member = false; 1574e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes out.emplace_back(attachment_index + offset, v); 1575e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes } 1576745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1577745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1578745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1579745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1580745d49409296f060402b57950384caadb636a2b2Chris Forbes } 15813a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15823a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 1583745d49409296f060402b57950384caadb636a2b2Chris Forbes} 1584745d49409296f060402b57950384caadb636a2b2Chris Forbes 15853a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<descriptor_slot_t, interface_var>> collect_interface_by_descriptor_slot( 15863a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 15873a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16073a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<descriptor_slot_t, interface_var>> out; 16083a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 16165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 16175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1621b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1622b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1623fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 1624cefd4dd8e03c5dae11a05d04a03cb856190358e0Chris Forbes out.emplace_back(std::make_pair(set, binding), v); 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16273a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16283a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1631edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1632031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1634031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16373a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, producer_stage->arrayed_output); 16383a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, consumer_stage->arrayed_input); 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1651edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1652080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1653031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1654031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1659edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1661031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1662031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1667fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1668fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1669fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1670fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 16710f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1672fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1673fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 167437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1675edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 16779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 16789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 16799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16830f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1684edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 16850f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1686f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 16870f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 16880f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 16890f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 16900f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 16910f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 16920f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 16945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 17075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 17125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 17185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 172431c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 172531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 172631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 172731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1730f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 17345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 174631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 174731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 174831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 174931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1752f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 17705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 1780f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes case spv::OpTypeImage: 1781f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes return get_fundamental_type(src, insn.word(2)); 1782f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1793edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1804edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1817edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18213a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, false); 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1826c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1827c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1828c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1829c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1830c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1831c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 18361730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes bool used = false; 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 18441730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes if (!used && log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1845080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18491730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = false; 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1852edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1864edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 18679ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 18689ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 18741730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = true; 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1882edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 18838da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis spirv_inst_iter entrypoint, VkRenderPassCreateInfo const *rpci, 18848da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis uint32_t subpass_index) { 1885025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 18868da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis auto subpass = rpci->pSubpasses[subpass_index]; 18878da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis for (auto i = 0u; i < subpass.colorAttachmentCount; ++i) { 1888d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis uint32_t attachment = subpass.pColorAttachments[i].attachment; 1889d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (attachment == VK_ATTACHMENT_UNUSED) 1890d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis continue; 1891d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (rpci->pAttachments[attachment].format != VK_FORMAT_UNDEFINED) { 1892d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis color_attachments[i] = rpci->pAttachments[attachment].format; 1893025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1894025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1895025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19003a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, false); 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1902025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 1903025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1905025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 1906025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 1907025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 1908025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 1909025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1911025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 1912edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1914025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "FS writes to output location %d with no matching attachment", it_a->first.first)) { 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1917025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1918025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 1919edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1920025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", it_b->first)) { 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1923025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1925025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 1926025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1930edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1932025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "Attachment %d of type `%s` does not match FS output type of `%s`", it_b->first, 1933025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 1934025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 1940025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1941025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 19573a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::unordered_set<uint32_t> mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint) { 19583a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> ids; 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 19685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 196981264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 19835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 19925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 19955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 19985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 19995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 20005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 20035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 20055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 20075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 20085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 20145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 20165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 20175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 20195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 20205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 20215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 20245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 20255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 20265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 20305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 20315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 20325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 20335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 20345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 20405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 20435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 2049c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 20505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 20515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 2055c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 20565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 20575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20643a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 20653a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return ids; 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2068edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 2069416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, 20705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 20715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 20755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 20775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 20805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 2089416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis for (auto const &range : *push_constant_ranges) { 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 2094edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2095080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 20985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 21005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 2108edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2109080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 21115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 21125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2123edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 2124416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, shader_module const *src, 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 21275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 2131416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_block_against_pipeline(report_data, push_constant_ranges, src, 2132416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis src->get_def(def_insn.word(1)), stage); 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2139fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 2140fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 21414a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 214437083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2146416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis if (slot.first >= pipelineLayout->set_layouts.size()) 214737083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 21485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2149416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis return pipelineLayout->set_layouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 21505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 21535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 21555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 21585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 21595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2161e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2164e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 21655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2166e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2170e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2171e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 21723d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 21733d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 21743d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 2175414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2177e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 21785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 218116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic PIPELINE_NODE *getPipeline(layer_data const *my_data, VkPipeline pipeline) { 2182ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 2183ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 2184ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2186ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 21875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 218916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic RENDER_PASS_NODE *getRenderPass(layer_data const *my_data, VkRenderPass renderpass) { 219016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto it = my_data->renderPassMap.find(renderpass); 219116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (it == my_data->renderPassMap.end()) { 219216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return nullptr; 219316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 219416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return it->second; 219516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes} 219616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 219704861caca7eb93a5241b164e8480bb93c826902cTobin Ehlisstatic FRAMEBUFFER_NODE *getFramebuffer(const layer_data *my_data, VkFramebuffer framebuffer) { 2198f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto it = my_data->frameBufferMap.find(framebuffer); 2199f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (it == my_data->frameBufferMap.end()) { 2200f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return nullptr; 2201f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes } 220204861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis return it->second.get(); 2203f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes} 2204f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes 2205e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehliscvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { 220611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto it = my_data->descriptorSetLayoutMap.find(dsLayout); 220711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (it == my_data->descriptorSetLayoutMap.end()) { 220811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return nullptr; 220911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 221011f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return it->second; 221111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes} 221211f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 22134a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { 22144a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto it = my_data->pipelineLayoutMap.find(pipeLayout); 22154a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (it == my_data->pipelineLayoutMap.end()) { 22164a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return nullptr; 22174a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes } 22184a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return &it->second; 22194a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes} 22204a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes 2221e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2222e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2226e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2229e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 22305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2233e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 2234e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 22353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 22363d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 22373d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 22383d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 2239ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2240ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2241ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 22423d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22433d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 22443d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 224545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 224645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 22473d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22483d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 22493d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22503d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 22513d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22523d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 22533d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 225445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 225545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 22563d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22573d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 22583d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 225945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 226045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 22613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22623d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 22633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22643d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 22653d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22663d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 22673d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 22693d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22703d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 22715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 22723d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 22775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 22785ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski// If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 22805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 22815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 22835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 22845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 2285e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis // Check potential NULL cases first to avoid nullptr issues later 2286e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pPrimary == nullptr) { 2287e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pSecondary == nullptr) { 2288e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return true; 2289e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 2290e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2291e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } else if (pSecondary == nullptr) { 2292e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2293e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 229506e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 229606e963555b0df747c98c43816c16647349d21001Mark Young return true; 22975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 229806e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 229906e963555b0df747c98c43816c16647349d21001Mark Young return true; 23005ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else { // Format and sample count must match 23015ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 23025ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return true; 23035ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 23045ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return false; 23055ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 23085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 23095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 23105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 23135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2315a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// TODO : Scrub verify_renderpass_compatibility() and validateRenderPassCompatibility() and unify them and/or share code 23168da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis// For given primary RenderPass object and secondry RenderPassCreateInfo, verify that they're compatible 2317a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPassCreateInfo *primaryRPCI, 23188da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI, string &errorMsg) { 23195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2320c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 23225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 23235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 23275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 23285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 23295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 23305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 23315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 23335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 23345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 23355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2336c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 23385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 23415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 23425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 23435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2344c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2350fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2351fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2352fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2353fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2354fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2355c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2356fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2357fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2358fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2359fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2360fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 23615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 23645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 23655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 23665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 23675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2368c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 23705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 23765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2378397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2379397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2380397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 238169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis PIPELINE_LAYOUT_NODE const *pipeline_layout, const uint32_t layoutIndex, 238269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis string &errorMsg) { 2383416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto num_sets = pipeline_layout->set_layouts.size(); 23849b5d124aff50234cb0450e1b805baef577c90d83Tobin Ehlis if (layoutIndex >= num_sets) { 2385c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 238669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorStr << "VkPipelineLayout (" << pipeline_layout->layout << ") only contains " << num_sets 238769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " 238869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << layoutIndex; 23895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2392416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto layout_node = pipeline_layout->set_layouts[layoutIndex]; 2393397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 23945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2397edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2398e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 23995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 24015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 24035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 24045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2405edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 24065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 24075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 24085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 24095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 24105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 24115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 24125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2413e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 24145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 24205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2422edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 24231b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 24245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 24255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24261b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 24271b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 24287b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 24297b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 24305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 24317b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 24327b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 24337b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 24347b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 24357b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 24367b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 24377b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 24385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 24415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 24425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 24435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 24445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 24455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 24465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 24475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 24485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 24495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 24505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 24555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 245967d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER || 246067d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 246335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 246435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 246535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 246635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 246735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 246835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 246935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 247035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 247135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 247235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 24735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 24765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 24775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 24785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 24795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 24805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 24815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 24825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 24835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 24855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 24865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 24875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 24885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 24895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 24905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 24915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 249367d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE || 249467d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 24965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 24975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 25015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 25025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 25035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 25045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 25055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25084110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2509a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 25104110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2511080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2512a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2513a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2514a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2515a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2516a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2517a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2518a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2519a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2520a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2521a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 252269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 252369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2524e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2525a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2526a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2527a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2528a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2529a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2530a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2531a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2532a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2533a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2534a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2535a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2536a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2537a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2538a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2539a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2540a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2541a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2542a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 25434110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2544a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2545a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2546a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 25474110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2548a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2549a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2550a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 25514110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2552a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2553a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2554a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 25554110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2556a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2557a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2558a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2559a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 25604110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2561a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2562a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2563a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2564a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 25654110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2566a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2567a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2568a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 25694110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2570a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2571a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2572a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 25734110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2574a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2575a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2576a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2577a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 25784110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2579a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2580a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2581a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2582a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 25834110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2584a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2585a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2586a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2587a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 25884110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2589a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2590a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2591a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2592a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 25934110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2594a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2595a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2596a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 25974110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2598a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2599a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2600a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 26014110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2602a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2603a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2604a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 26054110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2606a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2607a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2608a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 26094110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2610a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2611a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2612a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 26134110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2614a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2615a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2616a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 26174110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2618a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2619a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2620a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 26214110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2622a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2623a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2624a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 26254110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2626a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2627a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2628a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2629a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 26304110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2631a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2632a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2633a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 26344110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2635a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2636a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2637a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2638a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 26394110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2640a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2641a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2642a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2643a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 26444110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2645a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2646a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2647a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 26484110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2649a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2650a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2651a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2652e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2653a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2654a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2655a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2656a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2657a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2658a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2659a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2660a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2661b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2662b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbesstatic uint32_t descriptor_type_to_reqs(shader_module const *module, uint32_t type_id) { 26632aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto type = module->get_def(type_id); 26642aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 26652aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes while (true) { 26662aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (type.opcode()) { 26672aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeArray: 26682aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeSampledImage: 26692aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(2)); 26702aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 26712aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypePointer: 26722aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(3)); 26732aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 26742aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeImage: { 26752aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto dim = type.word(3); 26762aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto arrayed = type.word(5); 26772aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto msaa = type.word(6); 26782aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 26792aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (dim) { 26802aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim1D: 2681488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_1D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_1D; 26822aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim2D: 26832aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return (msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE) | 2684488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes (arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_2D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_2D); 26852aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim3D: 26862aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return DESCRIPTOR_REQ_VIEW_TYPE_3D; 26872aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::DimCube: 2688488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_CUBE_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_CUBE; 26892aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes default: // subpass, buffer, etc. 26902aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 26912aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 26922aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 26932aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes default: 26942aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 26952aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 26962aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 2697b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes} 2698b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2699b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2700ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbesstatic bool validate_pipeline_shader_stage(debug_report_data *report_data, 2701ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes VkPipelineShaderStageCreateInfo const *pStage, 2702ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes PIPELINE_NODE *pipeline, 2703ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes shader_module **out_module, 2704ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes spirv_inst_iter *out_entrypoint, 270569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 2706ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unordered_map<VkShaderModule, 2707ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unique_ptr<shader_module>> const &shaderModuleMap) { 2708e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 270969f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 271069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 2711557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_specialization_offsets(report_data, pStage); 271278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 271378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 271478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 271578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2716557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2717080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 271878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 271978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2720e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 272178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 272278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 272378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 272478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2725557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 272678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 272778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 27283a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto accessible_ids = mark_accessible_ids(module, entrypoint); 272978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 273078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 27313a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto descriptor_uses = collect_interface_by_descriptor_slot(report_data, module, accessible_ids); 273278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 27332e0eca3d6fad72a29ae072e3895e29a2d2d66476Tobin Ehlis auto pipelineLayout = pipeline->pipeline_layout; 2734ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 273578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 2736416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_usage(report_data, &pipelineLayout.push_constant_ranges, module, accessible_ids, pStage->stage); 273778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 273878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 273978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 274078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 2741b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes auto & reqs = pipeline->active_slots[use.first.first][use.first.second]; 2742b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes reqs = descriptor_req(reqs | descriptor_type_to_reqs(module, use.second.type_id)); 274378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2744fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 2745c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis const auto &binding = get_descriptor_binding(&pipelineLayout, use.first); 274678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 274778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 274878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2749557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2750080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 275178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 275278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2753e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 275478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 275578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2756557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 275778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 275878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 275978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 276078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2761fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 276278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2763e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 276478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2765edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2766fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2767557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2768fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2769fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2770fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2771fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 277278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2773e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 277478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 277578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2776557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2777fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 277878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 277978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2780fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 278278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 278378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 278478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 278578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2786c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes /* validate use of input attachments against subpass structure */ 2787c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (pStage->stage == VK_SHADER_STAGE_FRAGMENT_BIT) { 27883a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto input_attachment_uses = collect_interface_by_input_attachment_index(report_data, module, accessible_ids); 2789c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2790c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto rpci = pipeline->render_pass_ci.ptr(); 2791c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto subpass = pipeline->graphicsPipelineCI.subpass; 2792c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2793c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes for (auto use : input_attachment_uses) { 2794c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto input_attachments = rpci->pSubpasses[subpass].pInputAttachments; 2795c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto index = (input_attachments && use.first < rpci->pSubpasses[subpass].inputAttachmentCount) ? 2796c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes input_attachments[use.first].attachment : VK_ATTACHMENT_UNUSED; 2797c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2798c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (index == VK_ATTACHMENT_UNUSED) { 2799c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2800c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes SHADER_CHECKER_MISSING_INPUT_ATTACHMENT, "SC", 2801c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes "Shader consumes input attachment index %d but not provided in subpass", 2802c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes use.first)) { 2803c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes pass = false; 2804c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2805c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2806eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes else if (get_format_type(rpci->pAttachments[index].format) != 2807eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes get_fundamental_type(module, use.second.type_id)) { 2808eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2809eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes SHADER_CHECKER_INPUT_ATTACHMENT_TYPE_MISMATCH, "SC", 2810eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes "Subpass input attachment %u format of %s does not match type used in shader `%s`", 2811eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes use.first, string_VkFormat(rpci->pAttachments[index].format), 2812eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes describe_type(module, use.second.type_id).c_str())) { 2813eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes pass = false; 2814eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2815eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2816c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2817c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2818c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 281978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 282078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 282178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 282278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2823a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2824a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2825e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_NODE *pPipeline, 282669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 282769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 28286660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 28295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 28305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 28315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 28335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 28345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 28355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 28365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2837e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 28385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 28406660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 284178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2842e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 284369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 284469f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 28455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 28485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2850e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 28515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2854e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 28555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 28585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 28595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 28615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 28625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 28635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 28665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 28675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2868e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2869031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2870031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 28715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 28735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28768da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis if (shaders[fragment_stage]) { 2877e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 28788da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis pPipeline->render_pass_ci.ptr(), pCreateInfo->subpass); 28795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 28825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 28835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2884e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_NODE *pPipeline, VkPhysicalDeviceFeatures const *enabledFeatures, 288569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 28866660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 288703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 288803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 288903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 289003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 2891e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 289269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 289303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 28945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 2895a682b1c533d9a492243b363c6585c4f03bcd87aaTobin Ehliscvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { 2896104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis auto set_it = my_data->setMap.find(set); 2897104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis if (set_it == my_data->setMap.end()) { 28985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 28995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2900104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return set_it->second; 29015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 29037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 29047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 29057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 29067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 29077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 29087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2909e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 29107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 29111abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 29121abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis &activeSetBindingsPairs, 29131abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const char *function) { 2914e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 2915a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2916dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes cvdescriptorset::DescriptorSet *set_node = std::get<0>(set_bindings_pair); 2917cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 2918dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (!set_node->ValidateDrawState(std::get<1>(set_bindings_pair), *std::get<2>(set_bindings_pair), 2919397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 2920cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 2921397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 2922cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2923cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2924e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski "DS 0x%" PRIxLEAST64 " encountered the following validation error at %s() time: %s", 2925e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski reinterpret_cast<const uint64_t &>(set), function, err_str.c_str()); 2926cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 2927dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes set_node->GetStorageUpdates(std::get<1>(set_bindings_pair), &pCB->updateBuffers, &pCB->updateImages); 29285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 29305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2932eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 2933ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic VkSampleCountFlagBits getNumSamples(PIPELINE_NODE const *pipe) { 2934ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 2935ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 2936eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 2937eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2938eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 2939eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2940eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2941b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbesstatic void list_bits(std::ostream& s, uint32_t bits) { 2942b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes for (int i = 0; i < 32 && bits; i++) { 2943b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits & (1 << i)) { 2944b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << i; 2945b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes bits &= ~(1 << i); 2946b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits) { 2947b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << ","; 2948b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 2949b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 2950b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 2951b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes} 2952b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 2953eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 295429d196e071b2dc1db47702085469396f2b956820Chris Forbesstatic bool validatePipelineDrawtimeState(layer_data const *my_data, 295529d196e071b2dc1db47702085469396f2b956820Chris Forbes LAST_BOUND_STATE const &state, 295629d196e071b2dc1db47702085469396f2b956820Chris Forbes const GLOBAL_CB_NODE *pCB, 295729d196e071b2dc1db47702085469396f2b956820Chris Forbes PIPELINE_NODE const *pPipeline) { 2958eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 295929d196e071b2dc1db47702085469396f2b956820Chris Forbes 296029d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify Vtx binding 296129d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pPipeline->vertexBindingDescriptions.size() > 0) { 296229d196e071b2dc1db47702085469396f2b956820Chris Forbes for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { 2963312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis auto vertex_binding = pPipeline->vertexBindingDescriptions[i].binding; 2964312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (vertex_binding + 1)) || 2965312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis (pCB->currentDrawData.buffers[vertex_binding] == VK_NULL_HANDLE)) { 2966312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis skip_call |= log_msg( 2967312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 2968312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 2969312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "The Pipeline State Object (0x%" PRIxLEAST64 ") expects that this Command Buffer's vertex binding Index %u " 2970312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "should be set via vkCmdBindVertexBuffers. This is because VkVertexInputBindingDescription struct " 2971312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "at index " PRINTF_SIZE_T_SPECIFIER " of pVertexBindingDescriptions has a binding value of %u.", 29725c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis (uint64_t)state.pipeline_node->pipeline, vertex_binding, i, vertex_binding); 297329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 297429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 297529d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 297629d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pCB->currentDrawData.buffers.empty()) { 297729d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 29785c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29795c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 29805c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 29815c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline_node->pipeline); 298229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 298329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 298429d196e071b2dc1db47702085469396f2b956820Chris Forbes // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 298529d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip check if rasterization is disabled or there is no viewport. 298629d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((!pPipeline->graphicsPipelineCI.pRasterizationState || 298729d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 298829d196e071b2dc1db47702085469396f2b956820Chris Forbes pPipeline->graphicsPipelineCI.pViewportState) { 298929d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 299029d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 2991b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 299229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynViewport) { 2993b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredViewportsMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->viewportCount) - 1; 2994b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingViewportMask = ~pCB->viewportMask & requiredViewportsMask; 2995b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingViewportMask) { 2996b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 2997b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic viewport(s) "; 2998b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingViewportMask); 2999b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << " are used by PSO, but were not provided via calls to vkCmdSetViewport()."; 3000b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3001b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3002b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 300329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 300429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3005b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 300629d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynScissor) { 3007b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredScissorMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->scissorCount) - 1; 3008b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingScissorMask = ~pCB->scissorMask & requiredScissorMask; 3009b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingScissorMask) { 3010b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 3011b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic scissor(s) "; 3012b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingScissorMask); 3013b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << " are used by PSO, but were not provided via calls to vkCmdSetScissor()."; 3014b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3015b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3016b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 301729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 301829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 301929d196e071b2dc1db47702085469396f2b956820Chris Forbes } 302029d196e071b2dc1db47702085469396f2b956820Chris Forbes 302129d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify that any MSAA request in PSO matches sample# in bound FB 302229d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip the check if rasterization is disabled. 302329d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pPipeline->graphicsPipelineCI.pRasterizationState || 302429d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 302529d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 302629d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->activeRenderPass) { 302729d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkRenderPassCreateInfo *render_pass_info = pCB->activeRenderPass->pCreateInfo; 302829d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 302929d196e071b2dc1db47702085469396f2b956820Chris Forbes uint32_t i; 303029d196e071b2dc1db47702085469396f2b956820Chris Forbes 303129d196e071b2dc1db47702085469396f2b956820Chris Forbes const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 303229d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 303329d196e071b2dc1db47702085469396f2b956820Chris Forbes (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 303429d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3035eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3036ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 3037eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 3038414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 3039eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 3040eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 3041ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 304229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3043eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 304476957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes unsigned subpass_num_samples = 0; 30450a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 304629d196e071b2dc1db47702085469396f2b956820Chris Forbes for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 304776957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pColorAttachments[i].attachment; 304876957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (attachment != VK_ATTACHMENT_UNUSED) 304976957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 305029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 30510a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 305276957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (subpass_desc->pDepthStencilAttachment && 305376957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 305476957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pDepthStencilAttachment->attachment; 305576957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 305629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3057eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 30580dc3fd4e57b8531638781daa01a2fb5d1048a6fbJamie Madill if (subpass_num_samples && static_cast<unsigned>(pso_num_samples) != subpass_num_samples) { 305929d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3060eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3061ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 3062414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 3063414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 3064ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 3065ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 3066eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 306729d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 306829d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 306929d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 307029d196e071b2dc1db47702085469396f2b956820Chris Forbes "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 307129d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 3072eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3073eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3074528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // Verify that PSO creation renderPass is compatible with active renderPass 3075528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (pCB->activeRenderPass) { 3076528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis std::string err_string; 3077a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != pPipeline->graphicsPipelineCI.renderPass) && 3078a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(my_data, pCB->activeRenderPass->pCreateInfo, pPipeline->render_pass_ci.ptr(), 3079528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis err_string)) { 3080528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with 3081528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis skip_call |= 3082528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3083528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 3084528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " 3085528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 3086528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), reinterpret_cast<uint64_t &>(pPipeline), 3087528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); 3088528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 3089528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 309029d196e071b2dc1db47702085469396f2b956820Chris Forbes // TODO : Add more checks here 309129d196e071b2dc1db47702085469396f2b956820Chris Forbes 3092eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 3093eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 3094eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 30955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 3096aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlisstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *cb_node, const bool indexedDraw, 3097e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski const VkPipelineBindPoint bindPoint, const char *function) { 3098e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 3099aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis auto const &state = cb_node->lastBound[bindPoint]; 31005c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis PIPELINE_NODE *pPipe = state.pipeline_node; 310122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 310222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 310322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 310422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 310522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 310622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 310722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 310822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 310922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 31103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 31117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3112aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result = validate_draw_state_flags(my_data, cb_node, pPipe, indexedDraw); 31137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 311569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (VK_NULL_HANDLE != state.pipeline_layout.layout) { 311622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 311769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = pPipe->pipeline_layout; 3118169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes 311922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 31201abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 31211abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis activeSetBindingsPairs; 3122dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes for (auto & setBindingPair : pPipe->active_slots) { 312322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 312422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 312522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 312622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 312722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 3128414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 312922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 313069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], &pipeline_layout, setIndex, 313169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString)) { 313269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis // Set is bound but not compatible w/ overlapping pipeline_layout from PSO 313371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); 313422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 313522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 313622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 3137414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 3138414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 313969b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis reinterpret_cast<uint64_t &>(setHandle), setIndex, reinterpret_cast<uint64_t &>(pipeline_layout.layout), 314069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString.c_str()); 314122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 314222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 314371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis cvdescriptorset::DescriptorSet *pSet = state.boundDescriptorSets[setIndex]; 3144aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Gather active bindings 3145aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis std::unordered_set<uint32_t> bindings; 3146aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : setBindingPair.second) { 3147aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis bindings.insert(binding.first); 3148aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis } 3149aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Bind this set and its active descriptor resources to the command buffer 3150aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis pSet->BindCommandBuffer(cb_node, bindings); 315122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 3152aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis activeSetBindingsPairs.push_back(std::make_tuple(pSet, setBindingPair.second, &state.dynamicOffsets[setIndex])); 315322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 315422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 3155397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 3156aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : bindings) { 3157aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 315822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 315922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 3160397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 3161414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 316222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 3163397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 3164fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 31655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 316822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 316922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 3170aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, cb_node, activeSetBindingsPairs, function); 317122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 3172eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 3173eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 317429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3175aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validatePipelineDrawtimeState(my_data, state, cb_node, pPipe); 3176eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 31775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 31785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3180a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 3181a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 3182a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 3183a27508babf63d50aea75883a3702979193c23683Mark Young 3184a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 3185a27508babf63d50aea75883a3702979193c23683Mark Young if ((VK_FALSE == my_data->phys_dev_properties.features.wideLines) && (1.0f != lineWidth)) { 3186a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 3187a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 3188a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 3189a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 3190a27508babf63d50aea75883a3702979193c23683Mark Young } else { 3191a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 3192a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 3193a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 3194a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 3195a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 3196a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 3197a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 3198a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 3199a27508babf63d50aea75883a3702979193c23683Mark Young } 3200a27508babf63d50aea75883a3702979193c23683Mark Young } 3201a27508babf63d50aea75883a3702979193c23683Mark Young 3202a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 3203a27508babf63d50aea75883a3702979193c23683Mark Young} 3204a27508babf63d50aea75883a3702979193c23683Mark Young 32055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 3206e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 3207e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 320883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 32095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 32135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 32145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 32155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 32165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 32175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 32185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 321983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 322083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 322183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 32225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 32235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 322483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 32255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 32275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 32285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 32305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 32325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 32335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 323683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 323783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 323883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 32395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3243b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 32443d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 324526c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3246c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 324706811df0256552cd7da9d7297672af377463fc4aMark Mueller // Quoting the spec: "If [the independent blend] feature is not enabled, the VkPipelineColorBlendAttachmentState 324806811df0256552cd7da9d7297672af377463fc4aMark Mueller // settings for all color attachments must be identical." VkPipelineColorBlendAttachmentState contains 324906811df0256552cd7da9d7297672af377463fc4aMark Mueller // only attachment state, so memcmp is best suited for the comparison 325006811df0256552cd7da9d7297672af377463fc4aMark Mueller if (memcmp(static_cast<const void *>(pAttachments), static_cast<const void *>(&pAttachments[i]), 325106811df0256552cd7da9d7297672af377463fc4aMark Mueller sizeof(pAttachments[0]))) { 325283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 325383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INDEPENDENT_BLEND, "DS", 325483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: If independent blend feature not " 325583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "enabled, all elements of pAttachments must be identical"); 325606811df0256552cd7da9d7297672af377463fc4aMark Mueller break; 3257c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 32585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3261b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 326383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 32645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 32665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 327183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 32725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3278a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 32805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 328116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(my_data, pPipeline->graphicsPipelineCI.renderPass); 328216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass && 328316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeline->graphicsPipelineCI.subpass >= renderPass->pCreateInfo->subpassCount) { 328483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 328583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 328683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is out of range for this renderpass (0..%u)", 328783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.subpass, renderPass->pCreateInfo->subpassCount - 1); 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3290e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->phys_dev_properties.features, 329169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 329283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = true; 32935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 329452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 329552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 329652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 329752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 329883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 329983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 330083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 330183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 330252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 330352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 330452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 33055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 33065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 330783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 33085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 33105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 33135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 331483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 331583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 331683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 33175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 33195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 33205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 332383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 332483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 332583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 33265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3330ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3331ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 333283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 333383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 333483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 333583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology for tessellation pipelines"); 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3337ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3338ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 33395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 334083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 334183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 334283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 334383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 334483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology is only valid for tessellation pipelines"); 33455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3346ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 334783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 334883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 334983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: " 335083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 335183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3352ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3353ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 335483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 335583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 335683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 335783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used with patchControlPoints value %u." 335883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " patchControlPoints should be >0 and <=32.", 335983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 33605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3362a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3363a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3364a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 336583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 336683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3367a27508babf63d50aea75883a3702979193c23683Mark Young } 3368a27508babf63d50aea75883a3702979193c23683Mark Young } 33695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 33705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 33725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 337345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 337583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 337683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 337783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "and scissors are dynamic PSO must include " 337883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 338183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 338283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 338383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 338483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 338583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3388e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3389e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 33915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 33925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 339383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 339483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 339583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 339683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 339783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 339883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetViewport().", 339983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 340583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 340683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 340783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 340883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 340983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetScissor().", 341083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 341583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3422ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3423ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 34245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 34265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 34295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 3431e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin EhlisDESCRIPTOR_POOL_NODE *getPoolNode(const layer_data *dev_data, const VkDescriptorPool pool) { 3432bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis auto pool_it = dev_data->descriptorPoolMap.find(pool); 3433bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis if (pool_it == dev_data->descriptorPoolMap.end()) { 34345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3436bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis return pool_it->second; 34375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3439e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3440e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 34425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3444e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 34455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 34505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 34545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 34555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 34565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 34585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 34595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 34605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 34615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 34635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3467fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 34685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3469fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 34705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3472fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 34735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 34745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3475fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 34765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3478fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3479e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 348183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 34821d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 34835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 34845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 34885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3489e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 34905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 349283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 349383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 349483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 349583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 349783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 3498fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 349983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 3500fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3501fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3502fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3503fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 350683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35084a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 35094a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 35104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 35114a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 35124a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35134a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35144a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 35154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 35164a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 35184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 35214a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35234a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 35244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 35254a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35264a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 35274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35284a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35294a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 35304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 35314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 35334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 35344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 35354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 35364a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 35374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 35384a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35394a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 35414a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 35424a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 35434a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 35444a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35454a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35464a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 35474a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35484a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 35504a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 35514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 35534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 35544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 35554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 35565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 35575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 35604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 35614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 35624a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 35634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 35644a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 35664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 35755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 35764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 35774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 35784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 35794a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 35804a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 35814a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 35834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 35845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 35855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35864a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 35875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36006d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, image); 36016d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!img_node) 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 36066d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (sub_data->second.size() >= (img_node->createInfo.arrayLayers * img_node->createInfo.mipLevels + 1)) { 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 36265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 36275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 36295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 363308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 363608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 363708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 363808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 363908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 364308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 364508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 364608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 36527068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 36537068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 36547068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 365508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 365908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 366008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 366108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 366208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 366308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 366408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 366708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 366808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 36695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 367008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 367108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 367208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 367308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 367608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 367808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 36822c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_data = getImageViewData(dev_data, imageView); 36832c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis assert(iv_data); 36842c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImage &image = iv_data->image; 36852c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImageSubresourceRange &subRange = iv_data->subresourceRange; 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 3692915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // TODO: If ImageView was created with depth or stencil, transition both layouts as 3693915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // the aspectMask is ignored and both are used. Verify that the extra implicit layout 3694915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // is OK for descriptor set layout validation 3695038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski if (subRange.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 3696038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski if (vk_format_is_depth_and_stencil(iv_data->format)) { 3697038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski sub.aspectMask |= (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); 3698038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 3699038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3707e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3708e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3709e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3710e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3715414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 37195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 37205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 3721414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer.", 37225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 37235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3727f80bf38f4fb3f177b3e1be11b7b1c5edcdbf7d9bChris Forbes 3728e6651096ed8f07840447783c66827cc16d659a49Tobin Ehlis// Remove set from setMap and delete the set 37299dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 37309dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 37319dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 37329dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3739c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3740cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 37419dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3743f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 37505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 3751de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // TODO: validate flags 3752de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3753de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (auto ds : pPool->sets) { 3754de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis freeDescriptorSet(my_data, ds); 3755de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis } 3756de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->sets.clear(); 3757de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // Reset available count for each type and available sets for this pool 3758de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 3759de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 37605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3761de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableSets = pPool->maxSets; 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 37655121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 37665121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 37675121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 376872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 376972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3770414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37735121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 37745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3778400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 37825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3787e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3793e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3795e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3796e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 3797d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && 3798d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 38115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 38125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 38205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 38245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3836a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool addCmd(layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 383783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 3838a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(my_data, pCB->createInfo.commandPool); 3839a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (pPool) { 3840a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].queueFlags; 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 38425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 38545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 385583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 38655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 387983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 388383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 38937651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis case CMD_END: 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 390083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 39017651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else { 390283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 390983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39119822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis// Tie the VK_OBJECT to the cmd buffer which includes: 39129822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis// Add object_binding to cmd buffer 39139822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis// Add cb_binding to object 39149822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlisstatic void addCommandBufferBinding(std::unordered_set<GLOBAL_CB_NODE *> *cb_bindings, VK_OBJECT obj, GLOBAL_CB_NODE *cb_node) { 39159822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis cb_bindings->insert(cb_node); 39169822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis cb_node->object_bindings.insert(obj); 39179822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis} 3918bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis// For a given object, if cb_node is in that objects cb_bindings, remove cb_node 3919bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlisstatic void removeCommandBufferBinding(layer_data *dev_data, VK_OBJECT const *object, GLOBAL_CB_NODE *cb_node) { 3920bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis switch (object->type) { 3921bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 392264d375f52e2011964e196710ca78b0d4d68b20d0Dustin Graves auto img_node = getImageNode(dev_data, reinterpret_cast<const VkImage &>(object->handle)); 3923bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis if (img_node) 3924bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis img_node->cb_bindings.erase(cb_node); 3925bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 3926bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 3927bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 392864d375f52e2011964e196710ca78b0d4d68b20d0Dustin Graves auto buf_node = getBufferNode(dev_data, reinterpret_cast<const VkBuffer &>(object->handle)); 3929bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis if (buf_node) 3930bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis buf_node->cb_bindings.erase(cb_node); 3931bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 3932bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 39339822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 3934e9941022f1933b7300a4a7f52187dba446aca7a9Mark Lobodzinski auto evt_node = getEventNode(dev_data, reinterpret_cast<const VkEvent &>(object->handle)); 39359822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis if (evt_node) 39369822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis evt_node->cb_bindings.erase(cb_node); 39379822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis break; 39389822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis } 3939ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 3940e9941022f1933b7300a4a7f52187dba446aca7a9Mark Lobodzinski auto qp_node = getQueryPoolNode(dev_data, reinterpret_cast<const VkQueryPool &>(object->handle)); 3941ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (qp_node) 3942ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis qp_node->cb_bindings.erase(cb_node); 3943ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis break; 3944ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 3945a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 3946e9941022f1933b7300a4a7f52187dba446aca7a9Mark Lobodzinski auto pipe_node = getPipeline(dev_data, reinterpret_cast<const VkPipeline &>(object->handle)); 3947a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis if (pipe_node) 3948a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis pipe_node->cb_bindings.erase(cb_node); 3949a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis break; 3950a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 3951a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 3952a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis auto set_node = getSetNode(dev_data, reinterpret_cast<const VkDescriptorSet &>(object->handle)); 3953a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis if (set_node) 3954a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis set_node->RemoveBoundCommandBuffer(cb_node); 3955a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 3956a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 395756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 395856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis auto sampler_node = getSamplerNode(dev_data, reinterpret_cast<const VkSampler &>(object->handle)); 395956f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis if (sampler_node) 396056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis sampler_node->cb_bindings.erase(cb_node); 396156f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 396256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 3963bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis default: 3964bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis assert(0); // unhandled object type 3965bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 3966bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis} 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 3969400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 3970400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 3972b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 39735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 39815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 3983b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask = 0; 3984b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask = 0; 398593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 398672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 398772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 398872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 398993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 3991ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 3994e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis pCB->broken_bindings.clear(); 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 3997c7e6bc41aa9c6e5a677b138b9459b252cd3bedf2Mark Lobodzinski pCB->writeEventsBeforeWait.clear(); 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 4002abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 40055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 40075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 4008bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 4009bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 4010bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 4011bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 40125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 40137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 40147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 4015400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 4016b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 4017d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.clear(); 401893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 4019bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis // Remove object bindings 4020bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis for (auto obj : pCB->object_bindings) { 4021bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis removeCommandBufferBinding(dev_data, &obj, pCB); 4022bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 4023a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis pCB->object_bindings.clear(); 402493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 402593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 4026d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 4027d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis if (fb_node) 4028b6fe8da9537ef985960fd1d32b83c952b422f00bTobin Ehlis fb_node->cb_bindings.erase(pCB); 402993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 403093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 40317003b38da5cc27a063af3c45080f3a35438283eeTobin Ehlis pCB->activeFramebuffer = VK_NULL_HANDLE; 40325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 40375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 4038ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 4039ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 40401afd60fa23eaee2000e232efd5d05a64224a91dcTony Barbour pCB->status |= CBSTATUS_ALL; 40415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 40435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 40445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 40455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 4046ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 4047ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 40525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 40535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 40555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 40613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 40625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 40645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 40655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 40675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 40735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 40745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 4085e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 408683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 40885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 40895c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis PIPELINE_NODE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_node; 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 409383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 409483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 409583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 409683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 409783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis .c_str()); 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 410083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 41015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 41045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 41055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 4107414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "Cmds in CB 0x%p", (void *)cb); 41085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 41095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 41105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 41115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4112414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 41135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 41165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4119e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 412083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 41215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 412283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 41235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 412483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= printPipeline(my_data, cb); 412583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 41265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 41295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 4130e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4131e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 4135414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 4136ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 41425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 4143e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4144e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4155b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 4156d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4157b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 41585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 416189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 416289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4178b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 417956a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 4180b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 4181b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4183b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 4184b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 4185b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 4186b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 4187825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski 4188b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski instance_data->instance_state = unique_ptr<INSTANCE_STATE>(new INSTANCE_STATE()); 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 419589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 41965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 41975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 41985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 41995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 42015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 42035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4204b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 42055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 42065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 42075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 42085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 42095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 42105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 42155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4217373469f006399d6b5204ee05db3b56beb168b36fMark Youngstatic void checkDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 42225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4230838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski// Verify that queue family has been properly requested 4231838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinskibool ValidateRequestedQueueFamilyProperties(layer_data *dev_data, const VkDeviceCreateInfo *create_info) { 4232838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski bool skip_call = false; 4233838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // First check is app has actually requested queueFamilyProperties 4234838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski if (!dev_data->physical_device_state) { 4235838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4236838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", 4237838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid call to vkCreateDevice() w/o first calling vkEnumeratePhysicalDevices()."); 4238838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else if (QUERY_DETAILS != dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 4239838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // TODO: This is not called out as an invalid use in the spec so make more informative recommendation. 4240838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 4241838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, 4242838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "DL", "Call to vkCreateDevice() w/o first calling vkGetPhysicalDeviceQueueFamilyProperties()."); 4243838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else { 4244838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // Check that the requested queue properties are valid 4245838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski for (uint32_t i = 0; i < create_info->queueCreateInfoCount; i++) { 4246838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski uint32_t requestedIndex = create_info->pQueueCreateInfos[i].queueFamilyIndex; 4247838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski if (dev_data->queue_family_properties.size() <= 4248838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski requestedIndex) { // requested index is out of bounds for this physical device 4249838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg( 4250838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 4251838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4252838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). Invalid queueFamilyIndex %u requested.", requestedIndex); 4253838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else if (create_info->pQueueCreateInfos[i].queueCount > 4254838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski dev_data->queue_family_properties[requestedIndex]->queueCount) { 4255838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= 4256838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4257838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4258838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). QueueFamilyIndex %u only has %u queues, but " 4259838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "requested queueCount is %u.", 4260838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski requestedIndex, dev_data->queue_family_properties[requestedIndex]->queueCount, 4261838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski create_info->pQueueCreateInfos[i].queueCount); 4262838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4263838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4264838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4265838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski return skip_call; 4266838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski} 4267838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 4268f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski// Verify that features have been queried and that they are available 4269838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinskistatic bool ValidateRequestedFeatures(layer_data *dev_data, const VkPhysicalDeviceFeatures *requested_features) { 4270f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4271f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 4272825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski VkBool32 *actual = reinterpret_cast<VkBool32 *>(&(dev_data->physical_device_features)); 4273825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski const VkBool32 *requested = reinterpret_cast<const VkBool32 *>(requested_features); 4274f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO : This is a nice, compact way to loop through struct, but a bad way to report issues 4275f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Need to provide the struct member name with the issue. To do that seems like we'll 4276f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // have to loop through each struct member which should be done w/ codegen to keep in synch. 4277f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t errors = 0; 4278f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t total_bools = sizeof(VkPhysicalDeviceFeatures) / sizeof(VkBool32); 4279f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < total_bools; i++) { 4280f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (requested[i] > actual[i]) { 4281f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Add index to struct member name helper to be able to include a feature name 4282838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4283f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4284f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "DL", "While calling vkCreateDevice(), requesting feature #%u in VkPhysicalDeviceFeatures struct, " 4285f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "which is not available on this device.", 4286f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski i); 4287f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski errors++; 4288f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4289f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4290838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski if (errors && (UNCALLED == dev_data->physical_device_state->vkGetPhysicalDeviceFeaturesState)) { 4291f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // If user didn't request features, notify them that they should 4292f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Verify this against the spec. I believe this is an invalid use of the API and should return an error 4293838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4294cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4295cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "DL", "You requested features that are unavailable on this device. You should first query feature " 4296cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "availability by calling vkGetPhysicalDeviceFeatures()."); 4297f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4298f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return skip_call; 4299f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 4300f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 430189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 430289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 430356a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 4304f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4305f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 4306f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Check that any requested features are available 4307f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (pCreateInfo->pEnabledFeatures) { 4308f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski skip_call |= ValidateRequestedFeatures(my_instance_data, pCreateInfo->pEnabledFeatures); 4309f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4310838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= ValidateRequestedQueueFamilyProperties(my_instance_data, pCreateInfo); 4311f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 43121d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller if (skip_call) { 43131d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller return VK_ERROR_VALIDATION_FAILED_EXT; 43141d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller } 43151d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 43175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 43195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 43205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 432156a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 43275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 43285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 43305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 43315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 43325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4334b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 43355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 43365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 43395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 43406c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 43415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 4343373469f006399d6b5204ee05db3b56beb168b36fMark Young checkDeviceRegisterExtensions(pCreateInfo, *pDevice); 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4345b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 43475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4348b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 43495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4350b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 43515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 43525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4353b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4355b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 43565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4357b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4358b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4359b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 43605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 43625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 43645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 43675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 436889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 43695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 43705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 43715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 43725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4373b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 43745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 43755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 43765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 4377f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 43785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 4379f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 4380f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 4381a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 4382a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 4383a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 4384fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 43855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 43875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 43885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 43895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 43911344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 43921344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4393b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 439403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 439583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4396b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 43985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 43995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 44005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 44010a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 44020a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 440458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4405400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 44065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 440757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis pInfo = (*ii).second.get(); 4408de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (pInfo->alloc_info.allocationSize != 0) { 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 441083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 441183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 441283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, "MEM", 441383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 441483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 44165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4420b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 44215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 4423414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 44245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 44255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 442683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 44275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 44285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 44305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 44315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 44325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 44335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 44395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 44405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4441971020aec6166f20a12a833ebd003e0193f4160aChris Forbesstatic bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 4442e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 44475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4448414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 44505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4454856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4455856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4456856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4457971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4458414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4459856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4460414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4461414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4462414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4463856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4464856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4465856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4466856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4467971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4468414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4469856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4470856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4471856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4472856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 44755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 447939d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 4480a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Loop through bound objects and increment their in_use counts 4481a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// For any unknown objects, flag an error 4482a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlisstatic bool ValidateAndIncrementBoundObjects(layer_data const *dev_data, GLOBAL_CB_NODE const *cb_node) { 4483a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis bool skip_call = false; 4484a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 4485a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis switch (obj.type) { 4486a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 4487a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis auto set_node = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(obj.handle)); 4488a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis if (!set_node) { 4489a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis skip_call |= 4490a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 4491a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis obj.handle, __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 4492a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis "Cannot submit cmd buffer using deleted descriptor set 0x%" PRIx64 ".", obj.handle); 4493a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } else { 4494a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis set_node->in_use.fetch_add(1); 4495a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4496a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4497a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 449856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 449956f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis auto sampler_node = getSamplerNode(dev_data, reinterpret_cast<VkSampler &>(obj.handle)); 450056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis if (!sampler_node) { 450156f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 450256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis obj.handle, __LINE__, DRAWSTATE_INVALID_SAMPLER, "DS", 450356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis "Cannot submit cmd buffer using deleted sampler 0x%" PRIx64 ".", obj.handle); 450456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } else { 450556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis sampler_node->in_use.fetch_add(1); 450656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 450756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 450856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 4509a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis default: 4510a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : Merge handling of other objects types into this code 4511a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4512a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4513a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4514a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis return skip_call; 4515a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4516a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis 45175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 45189a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlisstatic bool validateAndIncrementResources(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { 4519e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4520a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 45219a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis cb_node->in_use.fetch_add(1); 45229a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis dev_data->globalInFlightCmdBuffers.insert(cb_node->commandBuffer); 4523a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4524a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First Increment for all "generic" objects bound to cmd buffer, followed by special-case objects below 45259a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= ValidateAndIncrementBoundObjects(dev_data, cb_node); 4526a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : We should be able to remove the NULL look-up checks from the code below as long as 4527a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // all the corresponding cases are verified to cause CB_INVALID state and the CB_INVALID state 4528a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // should then be flagged prior to calling this function 45299a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 45319a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 45328718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 45339a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 45345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4535414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 45365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45378718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->in_use.fetch_add(1); 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45419a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->events) { 45429a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto event_node = getEventNode(dev_data, event); 45439556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (!event_node) { 45445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 45459a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4547414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted event 0x%" PRIx64 ".", reinterpret_cast<uint64_t &>(event)); 45485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45499556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->in_use.fetch_add(1); 45505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45529a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 45539a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto event_node = getEventNode(dev_data, event); 45549556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) 45559556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->write_in_use++; 4556c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 45575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 45585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4560b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4561b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 45627d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: untangle this. 4563b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4564b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4565b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4566b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4567b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4568b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4569b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4570b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4571b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4572414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4573414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4574b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4575b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4576b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4577b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4578b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4579b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4580b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 45817d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes 45827d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: nuke this completely. 4583b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4584b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4585b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4586b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4587b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4588b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4589b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4590b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4591b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4592b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4593a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Decrement in-use count for objects bound to command buffer 4594a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlisstatic void DecrementBoundResources(layer_data const *dev_data, GLOBAL_CB_NODE const *cb_node) { 4595a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 4596a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis switch (obj.type) { 4597a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 4598a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis auto set_node = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(obj.handle)); 4599a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis set_node->in_use.fetch_sub(1); 4600a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4601a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 460256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 460356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis auto sampler_node = getSamplerNode(dev_data, reinterpret_cast<VkSampler &>(obj.handle)); 460456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis sampler_node->in_use.fetch_sub(1); 460556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 460656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 4607a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis default: 4608a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : Merge handling of other objects types into this code 4609a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4610a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4611a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4612a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4613da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 46149867daedbf52debc77d6568162ee21e071699b80Chris Forbesstatic bool RetireWorkOnQueue(layer_data *dev_data, QUEUE_NODE *pQueue, uint64_t seq) 46159867daedbf52debc77d6568162ee21e071699b80Chris Forbes{ 46169867daedbf52debc77d6568162ee21e071699b80Chris Forbes bool skip_call = false; // TODO: extract everything that might fail to precheck 46179867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unordered_map<VkQueue, uint64_t> otherQueueSeqs; 46189867daedbf52debc77d6568162ee21e071699b80Chris Forbes 46199867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll this queue forward, one submission at a time. 46209867daedbf52debc77d6568162ee21e071699b80Chris Forbes while (pQueue->seq < seq) { 46219867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & submission = pQueue->submissions.front(); 46229867daedbf52debc77d6568162ee21e071699b80Chris Forbes 46239867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & wait : submission.waitSemaphores) { 46249867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, wait.semaphore); 4625da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_sub(1); 46269867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & lastSeq = otherQueueSeqs[wait.queue]; 46279867daedbf52debc77d6568162ee21e071699b80Chris Forbes lastSeq = std::max(lastSeq, wait.seq); 4628da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 4629cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 46309867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & semaphore : submission.signalSemaphores) { 46319867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 46329867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_sub(1); 46339867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4634cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 46359867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto cb : submission.cbs) { 46369a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto cb_node = getCBNode(dev_data, cb); 4637a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First perform decrement on general case bound objects 46389a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis DecrementBoundResources(dev_data, cb_node); 46399a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 46409867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto buffer : drawDataElement.buffers) { 46419867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto buffer_node = getBufferNode(dev_data, buffer); 46429867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (buffer_node) { 46439867daedbf52debc77d6568162ee21e071699b80Chris Forbes buffer_node->in_use.fetch_sub(1); 46449867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 46459867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4646da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 46479a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->events) { 46489867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto eventNode = dev_data->eventMap.find(event); 46499867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (eventNode != dev_data->eventMap.end()) { 46509867daedbf52debc77d6568162ee21e071699b80Chris Forbes eventNode->second.in_use.fetch_sub(1); 46519867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 46529867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 46539a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 46549867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto eventNode = dev_data->eventMap.find(event); 46559867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (eventNode != dev_data->eventMap.end()) { 46569867daedbf52debc77d6568162ee21e071699b80Chris Forbes eventNode->second.write_in_use--; 46579867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 46589867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 46599a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto queryStatePair : cb_node->queryToStateMap) { 46609867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 46619867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 46629a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto eventStagePair : cb_node->eventToStageMap) { 46639867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 4664da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 46650a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 46669867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= cleanInFlightCmdBuffer(dev_data, cb); 46679867daedbf52debc77d6568162ee21e071699b80Chris Forbes removeInFlightCmdBuffer(dev_data, cb); 46680a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 46699867daedbf52debc77d6568162ee21e071699b80Chris Forbes 46709867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pFence = getFenceNode(dev_data, submission.fence); 46719867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 46729867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->state = FENCE_RETIRED; 46730a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 46749867daedbf52debc77d6568162ee21e071699b80Chris Forbes 46759867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.pop_front(); 46769867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->seq++; 4677b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 46789867daedbf52debc77d6568162ee21e071699b80Chris Forbes 46799867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll other queues forward to the highest seq we saw a wait for 46809867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto qs : otherQueueSeqs) { 46819867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, getQueueNode(dev_data, qs.first), qs.second); 4682d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 46835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46849867daedbf52debc77d6568162ee21e071699b80Chris Forbes return skip_call; 46859867daedbf52debc77d6568162ee21e071699b80Chris Forbes} 4686651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4687651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4688651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// Submit a fence to a queue, delimiting previous fences and previous untracked 4689651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// work by it. 4690651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void 46919867daedbf52debc77d6568162ee21e071699b80Chris ForbesSubmitFence(QUEUE_NODE *pQueue, FENCE_NODE *pFence, uint64_t submitCount) 4692651d92815dfff917308137bb67aacccc4f60df86Chris Forbes{ 4693cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_INFLIGHT; 46949867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = pQueue->queue; 46959867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.second = pQueue->seq + pQueue->submissions.size() + submitCount; 4696b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4697b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4698e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 47005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 47015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 47025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 47035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 470427c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4705414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 47065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 47075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 471283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 47130a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 47140a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 471583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 471683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis 0, __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 471783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "CB 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 471883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "set, but has been submitted 0x%" PRIxLEAST64 " times.", 471983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 47200a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 47215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 47225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 47235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 47245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 4725e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto obj : pCB->broken_bindings) { 4726e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *type_str = object_type_to_string(obj.type); 4727e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis // Descriptor sets are a special case that can be either destroyed or updated to invalidated a CB 4728e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *cause_str = 4729e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis (obj.type == VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT) ? "destroyed or updated" : "destroyed"; 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 473183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 47325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 47335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4734e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because bound %s 0x%" PRIxLEAST64 4735e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis " was %s.", 4736e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), type_str, obj.handle, cause_str); 47375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 473983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 47415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4742414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You must call vkEndCommandBuffer() on CB 0x%" PRIxLEAST64 " before this call to vkQueueSubmit()!", 47435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 47445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 474683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 47475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47497bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Validate that queueFamilyIndices of primary command buffers match this queue 47507bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Secondary command buffers were previously validated in vkCmdExecuteCommands(). 47517bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinskistatic bool validateQueueFamilyIndices(layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkQueue queue) { 47527bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski bool skip_call = false; 47537bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto pPool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 47547bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto queue_node = getQueueNode(dev_data, queue); 47557bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 47567bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (pPool && queue_node && (pPool->queueFamilyIndex != queue_node->queueFamilyIndex)) { 47577bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 47587bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 47597bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkQueueSubmit: Primary command buffer 0x%" PRIxLEAST64 47607bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d is being submitted on queue 0x%" PRIxLEAST64 " from queue family %d.", 47617bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), pPool->queueFamilyIndex, 47627bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(queue), queue_node->queueFamilyIndex); 47637bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 47647bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 47657bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski return skip_call; 47667bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski} 47677bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 4768da8f07baf262972eb3e719fa07b073c180dff157Chris Forbesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 47695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 477083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4771a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4772a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 4773a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // on device 477483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferSimultaneousUse(dev_data, pCB); 4775a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 477683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pCB); 4777a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 47785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 47795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 47805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 478183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pSubCB); 47824c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 47834c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 47845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4786414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 4788414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 47894c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 47905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 47925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4795a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 479683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pCB); 4797a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 479883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 47995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 480181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbesstatic bool 4802651d92815dfff917308137bb67aacccc4f60df86Chris ForbesValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) 480381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes{ 480483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 480581c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4806651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4807cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_INFLIGHT) { 480883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 480983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 481083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); 4811a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 481281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4813cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes else if (pFence->state == FENCE_RETIRED) { 481483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 481583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 481683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 481783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 481883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence)); 4819a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 48205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 482181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 482283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 482381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes} 482481c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4825651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 482681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL 482781c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 482883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 482981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 483081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 483181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 483281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4833651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 4834651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 483583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 483681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 483783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 4838d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 4839d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes } 4840d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes 48411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 48421344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 48431344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 4844651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4845651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // Mark the fence in-use. 4846651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 48479867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, std::max(1u, submitCount)); 4848651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4849651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 48505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 48515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 48539867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<SEMAPHORE_WAIT> semaphore_waits; 48549867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<VkSemaphore> semaphore_signals; 48555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 485601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pWaitSemaphores[i]; 485701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 485801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 485901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 48609867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 48619867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 48629867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 48639867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 48649867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 486501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 48661344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 486783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 48681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 48691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4870414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 48711344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 48721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 48735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 487601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pSignalSemaphores[i]; 487701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 487801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 487901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 488083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 48811344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 48821344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4883414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 4884414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 48851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 48869867daedbf52debc77d6568162ee21e071699b80Chris Forbes reinterpret_cast<uint64_t &>(pSemaphore->signaler.first)); 48871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 48889867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 48899867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 489001a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = true; 4891da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_add(1); 48929867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 48931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 48940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 48955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4896651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4897da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes std::vector<VkCommandBuffer> cbs; 4898da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 48995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 4900971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 490183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateCmdBufImageLayouts(dev_data, pCBNode); 49021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 4903da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(submit->pCommandBuffers[i]); 4904651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto secondaryCmdBuffer : pCBNode->secondaryCommandBuffers) { 4905da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(secondaryCmdBuffer); 4906651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4907651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 49081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 490983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBufferState(dev_data, pCBNode); 49107bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= validateQueueFamilyIndices(dev_data, pCBNode, queue); 49111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 49121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 491383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(); 49141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 49151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 491683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 49171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 4918d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto &function : pCBNode->queryUpdates) { 491983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 4920d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 49211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4923da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 49249867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(cbs, semaphore_waits, semaphore_signals, 49259867daedbf52debc77d6568162ee21e071699b80Chris Forbes submit_idx == submitCount - 1 ? fence : VK_NULL_HANDLE); 49269867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 49279867daedbf52debc77d6568162ee21e071699b80Chris Forbes 49289867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !submitCount) { 49299867daedbf52debc77d6568162ee21e071699b80Chris Forbes // If no submissions, but just dropping a fence on the end of the queue, 49309867daedbf52debc77d6568162ee21e071699b80Chris Forbes // record an empty submission with just the fence, so we can determine 49319867daedbf52debc77d6568162ee21e071699b80Chris Forbes // its completion. 49329867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 49339867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 49349867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 49359867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 49365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49379867daedbf52debc77d6568162ee21e071699b80Chris Forbes 4938b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 493983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 49405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 49415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 49435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 494589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 494689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 49475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 4950b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 49515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 49520a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 49535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 495689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 495789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 49585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 49625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 49635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 49645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 49655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 49665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4967b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 496874243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller bool skip_call = freeMemObjInfo(my_data, device, mem, false); 49690a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 49700a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 4971b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 497274243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller if (!skip_call) { 497374243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 497474243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller } 49755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4977f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// Validate that given Map memory range is valid. This means that the memory should not already be mapped, 4978f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// and that the size of the map range should be: 4979f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 1. Not zero 4980f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 2. Within the size of the memory allocation 4981f57fc64ac43691ad98e1713886b345465573070aTobin Ehlisstatic bool ValidateMapMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 498283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 49835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 498583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 498683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 498783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 49885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 49915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 499257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = mem_element->second.get(); 49935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 4994de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.size != 0) { 499583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 499683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 499783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 49985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 50015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 5002de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (offset >= mem_info->alloc_info.allocationSize) { 500383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 500483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 500583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 500683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, 5007de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis offset, mem_info->alloc_info.allocationSize, mem_info->alloc_info.allocationSize); 50085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5010de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if ((offset + size) > mem_info->alloc_info.allocationSize) { 501183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 501257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 501357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 501457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64, offset, 5015de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size + offset, mem_info->alloc_info.allocationSize); 50165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 501983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5022e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 502357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 502457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5025de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.offset = offset; 5026de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = size; 50275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5030e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 503183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 503257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 503357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5034de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (!mem_info->mem_range.size) { 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 503683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 503783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 503883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 50395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5040de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = 0; 50415f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 50425f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski free(mem_info->shadow_copy_base); 50435f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy_base = 0; 50445f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 504783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 50485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50505f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski// Guard value for pad data 50515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 50525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50535f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinskistatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, 50545f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski void **ppData) { 505557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 505657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5057de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->p_driver_data = *ppData; 5058de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis uint32_t index = mem_info->alloc_info.memoryTypeIndex; 5059b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 50605f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 50615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 50625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 50635f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski size = mem_info->alloc_info.allocationSize - offset; 50645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50655f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_pad_size = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 50665f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(mem_info->shadow_pad_size, 50675f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment) == 0); 50685f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Ensure start of mapped region reflects hardware alignment constraints 50695f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t map_alignment = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 50705f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 50715f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // From spec: (ppData - offset) must be aligned to at least limits::minMemoryMapAlignment. 50725f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t start_offset = offset % map_alignment; 50735f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Data passed to driver will be wrapped by a guardband of data to detect over- or under-writes. 50745f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy_base = malloc(2 * mem_info->shadow_pad_size + size + map_alignment + start_offset); 50755f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 50765f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 50775f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski reinterpret_cast<char *>((reinterpret_cast<uintptr_t>(mem_info->shadow_copy_base) + map_alignment) & 50785f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ~(map_alignment - 1)) + start_offset; 50795f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(reinterpret_cast<uintptr_t>(mem_info->shadow_copy) + mem_info->shadow_pad_size - start_offset, 50805f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski map_alignment) == 0); 50815f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 50825f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memset(mem_info->shadow_copy, NoncoherentMemoryFillValue, 2 * mem_info->shadow_pad_size + size); 50835f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski *ppData = static_cast<char *>(mem_info->shadow_copy) + mem_info->shadow_pad_size; 50845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50875f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 5088a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 50899867daedbf52debc77d6568162ee21e071699b80Chris Forbes// a fence being waited on should not already be signaled and 5090a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 509149f6132af865afd5b7f413c91125971ac97c135aChris Forbesstatic inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { 509283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 50939b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes 509449f6132af865afd5b7f413c91125971ac97c135aChris Forbes auto pFence = getFenceNode(dev_data, fence); 50959b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes if (pFence) { 5096cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_UNSIGNALED) { 509783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 509883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 509983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 510083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "acquire next image.", 510183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 51025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 510483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 51055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5106a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 510789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 510889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 51095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5110e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 5112b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 51135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 511449f6132af865afd5b7f413c91125971ac97c135aChris Forbes skip_call |= verifyWaitFenceState(dev_data, pFences[i], "vkWaitForFences"); 51155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5116b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 51175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 51185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5119a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 51205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 5121414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 51225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5123b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 51245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 51255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 51269867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (uint32_t i = 0; i < fenceCount; i++) { 51279867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 51289867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence->signaler.first != VK_NULL_HANDLE) { 51299867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, 51309867daedbf52debc77d6568162ee21e071699b80Chris Forbes getQueueNode(dev_data, pFence->signaler.first), 51319867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.second); 51329867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 51339867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 51375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 5138b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 51395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5140e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 51415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 51425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 514589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 51465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 514783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5148b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 514983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); 5150b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5151a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 515283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 515383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5154a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 515583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 5156b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 51589867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pFence = getFenceNode(dev_data, fence); 51599867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence->signaler.first != VK_NULL_HANDLE) { 51609867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, 51619867daedbf52debc77d6568162ee21e071699b80Chris Forbes getQueueNode(dev_data, pFence->signaler.first), 51629867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.second); 51639867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 51645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5165b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5166e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 51675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 51685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 51695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 517189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5172b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 51735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 5175b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5176b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5177b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5178b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5179b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5180b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 51818988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes pQNode->queue = *pQueue; 51827bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski pQNode->queueFamilyIndex = queueFamilyIndex; 51839867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQNode->seq = 0; 5184b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 51855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 518789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 51885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 5189e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 51909867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 51919867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 51929867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, pQueue, pQueue->seq + pQueue->submissions.size()); 51939867daedbf52debc77d6568162ee21e071699b80Chris Forbes lock.unlock(); 5194e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 51955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 51965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 51975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 51985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 520089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 5201e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 52025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5203b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52049867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & queue : dev_data->queueMap) { 52059867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); 52065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5207b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5208e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 52095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 52105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 52115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 521489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 52155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 521683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5217b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 52191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 5220cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (fence_pair->second.state == FENCE_INFLIGHT) { 522183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 522283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", "Fence 0x%" PRIx64 " is in use.", 522383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence)); 52241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 52265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5227b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 52281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 522983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 52305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 52315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 523389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 523489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 52355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5236e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5237e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 52385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 52395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 52405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 52415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 52425c2563284eeaaa37c12558fd541e2416fe618a38Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5243414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete semaphore 0x%" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 52445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 52465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5247e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5248e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 52495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 525189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 52525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5254b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52559556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 52569556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 5257e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (event_node->in_use.load()) { 5258ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis skip_call |= log_msg( 5259ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 5260833764b21e2893b6ea057fe211c220ec6a83d09cTobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5261ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis "Cannot delete event 0x%" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 5262e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 52639556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis // Any bound cmd buffers are now invalid 52649556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis invalidateCommandBuffers(event_node->cb_bindings, 52659556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}); 52669556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis dev_data->eventMap.erase(event); 52679556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 5268e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5269e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (!skip_call) 5270e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 52715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 527389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 527489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 5275ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5276d71203a8c706f522fca32399d5459a031250b83cTobin Ehlis // TODO : Add detection for an in-flight queryPool 5277ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5278ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto qp_node = getQueryPoolNode(dev_data, queryPool); 5279ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (qp_node) { 5280ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis // Any bound cmd buffers are now invalid 5281ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis invalidateCommandBuffers(qp_node->cb_bindings, 5282ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}); 5283ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis dev_data->queryPoolMap.erase(queryPool); 5284ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 5285e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5286e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 52875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 528989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 529089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 529189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 52925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 5294b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 5296971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 52975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 52985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 52995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5301e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 53035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 53045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 53055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 53065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5307ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5308ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5309ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5310ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5311971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5312ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5313ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5314ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5315ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5316414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 5317ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5318ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5319ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5320ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5321ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5322ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5323ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5324ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5325ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5326ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5327ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5328ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5329ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5330971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5331ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5332ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5333ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 53345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5336414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 53375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 53385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5339ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5340ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 53415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5343414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 53445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5345ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5346ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5347ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5348ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5349414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 5350ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5351ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 53525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5355b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 53575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 53595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5362e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5363e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53648718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 53658718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 53665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 5368414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 53695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 53708718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node->in_use.load()) { 53715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 53725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5373414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 53775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5379825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if given ranges intersect, else false 5380825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Prereq : For both ranges, range->end - range->start > 0. This case should have already resulted 5381825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// in an error so not checking that here 5382825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// pad_ranges bool indicates a linear and non-linear comparison which requires padding 5383825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// In the case where padding is required, if an alias is encountered then a validation error is reported and skip_call 5384825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// may be set by the callback function so caller should merge in skip_call value if padding case is possible. 53857dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, MEMORY_RANGE const *range2, bool *skip_call) { 53867dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call = false; 5387825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_start = range1->start; 5388825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_end = range1->end; 5389825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_start = range2->start; 5390825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_end = range2->end; 5391825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkDeviceSize pad_align = 1; 5392825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5393825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis pad_align = dev_data->phys_dev_properties.properties.limits.bufferImageGranularity; 5394825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5395825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_end & ~(pad_align - 1)) < (r2_start & ~(pad_align - 1))) 5396825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 5397825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_start & ~(pad_align - 1)) > (r2_end & ~(pad_align - 1))) 5398825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 539947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5400825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5401825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // In linear vs. non-linear case, it's an error to alias 5402825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_linear_str = range1->linear ? "Linear" : "Non-linear"; 5403825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_type_str = range1->image ? "image" : "buffer"; 5404825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_linear_str = range2->linear ? "linear" : "non-linear"; 5405825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_type_str = range2->image ? "image" : "buffer"; 5406825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto obj_type = range1->image ? VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT : VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT; 54077dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call |= 5408825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, range1->handle, 0, MEMTRACK_INVALID_ALIASING, 5409825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis "MEM", "%s %s 0x%" PRIx64 " is aliased with %s %s 0x%" PRIx64 5410825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis " which is in violation of the Buffer-Image Granularity section of the Vulkan specification.", 5411825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis r1_linear_str, r1_type_str, range1->handle, r2_linear_str, r2_type_str, range2->handle); 541247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 5413825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Ranges intersect 5414825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return true; 541547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 5416623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis// Simplified rangesIntersect that calls above function to check range1 for intersection with offset & end addresses 5417cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, VkDeviceSize offset, VkDeviceSize end) { 5418825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Create a local MEMORY_RANGE struct to wrap offset/size 5419825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis MEMORY_RANGE range_wrap; 5420825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Synch linear with range1 to avoid padding and potential validation error case 5421825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.linear = range1->linear; 5422825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.start = offset; 5423cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis range_wrap.end = end; 5424825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool tmp_bool; 54257dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis return rangesIntersect(dev_data, range1, &range_wrap, &tmp_bool); 5426825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5427cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given mem_info, set all ranges valid that intersect [offset-end] range 5428cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// TODO : For ranges where there is no alias, we may want to create new buffer ranges that are valid 5429cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic void SetMemRangesValid(layer_data const *dev_data, DEVICE_MEM_INFO *mem_info, VkDeviceSize offset, VkDeviceSize end) { 5430cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis bool tmp_bool = false; 5431cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis MEMORY_RANGE map_range; 5432cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.linear = true; 5433cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.start = offset; 5434cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.end = end; 5435cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto &handle_range_pair : mem_info->bound_ranges) { 54367dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &handle_range_pair.second, &map_range, &tmp_bool)) { 5437cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : WARN here if tmp_bool true? 5438cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis handle_range_pair.second.valid = true; 5439cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5440cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5441cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis} 5442825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Object with given handle is being bound to memory w/ given mem_info struct. 5443825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Track the newly bound memory range with given memoryOffset 5444825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Also scan any previous ranges, track aliased ranges with new range, and flag an error if a linear 5445825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// and non-linear range incorrectly overlap. 5446825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if an error is flagged and the user callback returns "true", otherwise false 5447825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates an image object, otherwise handle is for a buffer 5448825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_linear indicates a buffer or linear image 5449825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic bool InsertMemoryRange(layer_data const *dev_data, uint64_t handle, DEVICE_MEM_INFO *mem_info, VkDeviceSize memoryOffset, 5450825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements memRequirements, bool is_image, bool is_linear) { 5451825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool skip_call = false; 54525360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis MEMORY_RANGE range; 5453825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5454825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.image = is_image; 545547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 5456825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.linear = is_linear; 5457f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis range.valid = mem_info->global_valid; 5458825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.memory = mem_info->mem; 545947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 5460825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.size = memRequirements.size; 546147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 54625360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis range.aliases.clear(); 54635360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Update Memory aliasing 54645360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Save aliase ranges so we can copy into final map entry below. Can't do it in loop b/c we don't yet have final ptr. If we 54655360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // inserted into map before loop to get the final ptr, then we may enter loop when not needed & we check range against itself 54665360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis std::unordered_set<MEMORY_RANGE *> tmp_alias_ranges; 5467825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto &obj_range_pair : mem_info->bound_ranges) { 5468825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto check_range = &obj_range_pair.second; 54695360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis bool intersection_error = false; 54707dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &range, check_range, &intersection_error)) { 5471825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis skip_call |= intersection_error; 5472825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.aliases.insert(check_range); 54735360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_alias_ranges.insert(check_range); 5474825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5475825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 54765360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis mem_info->bound_ranges[handle] = std::move(range); 54775360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis for (auto tmp_range : tmp_alias_ranges) { 54785360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_range->aliases.insert(&mem_info->bound_ranges[handle]); 54795360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis } 5480825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (is_image) 5481825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.insert(handle); 5482825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis else 5483825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.insert(handle); 5484825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5485825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return skip_call; 548647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 548747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 54889f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertImageMemoryRange(layer_data const *dev_data, VkImage image, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5489825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs, bool is_linear) { 54909f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(image), mem_info, mem_offset, mem_reqs, true, is_linear); 5491825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5492825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 54939f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertBufferMemoryRange(layer_data const *dev_data, VkBuffer buffer, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5494825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs) { 54959f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(buffer), mem_info, mem_offset, mem_reqs, false, true); 5496825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5497825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5498825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Remove MEMORY_RANGE struct for give handle from bound_ranges of mem_info 5499825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates if handle is for image or buffer 5500825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// This function will also remove the handle-to-index mapping from the appropriate 5501825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// map and clean up any aliases for range being removed. 5502825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info, bool is_image) { 5503825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto erase_range = &mem_info->bound_ranges[handle]; 5504825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto alias_range : erase_range->aliases) { 5505825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis alias_range->aliases.erase(erase_range); 550647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 55075360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis erase_range->aliases.clear(); 5508825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_ranges.erase(handle); 5509825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (is_image) 5510825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.erase(handle); 5511825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis else 5512825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.erase(handle); 551347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 551447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5515825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveBufferMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, false); } 5516825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5517825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveImageMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, true); } 5518825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 551989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 552089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 55215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5522b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55235a758b24bbcdad37a5ccf41c3581c289acf11c2dTobin Ehlis if (!validateIdleBuffer(dev_data, buffer)) { 5524e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Clean up memory binding and range information for buffer 5525e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 5526e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (buff_node) { 5527e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Any bound cmd buffers are now invalid 5528e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis invalidateCommandBuffers(buff_node->cb_bindings, 5529e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis {reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 5530e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto mem_info = getMemObjInfo(dev_data, buff_node->mem); 5531e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (mem_info) { 5532825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis RemoveBufferMemoryRange(reinterpret_cast<uint64_t &>(buffer), mem_info); 5533e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5534e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 5535e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->bufferMap.erase(buff_node->buffer); 5536e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5537b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 553947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 554289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 554389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5545e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5546e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 55485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5551e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5552e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 555589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5558e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 555999df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis auto img_node = getImageNode(dev_data, image); 556099df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis if (img_node) { 556199df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis // Any bound cmd buffers are now invalid 556299df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis invalidateCommandBuffers(img_node->cb_bindings, 556399df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis {reinterpret_cast<uint64_t &>(img_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); 556447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory mapping, bindings and range references for image 556599df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, img_node->mem); 556657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5567825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis RemoveImageMemoryRange(reinterpret_cast<uint64_t &>(image), mem_info); 556847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 556947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 557058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 557199df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis dev_data->imageMap.erase(img_node->image); 55725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 55745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 55755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 55775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 55795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5580e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5581e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 55825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55844261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinskistatic bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, 55854261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski const char *funcName) { 55864261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski bool skip_call = false; 5587de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (((1 << mem_info->alloc_info.memoryTypeIndex) & memory_type_bits) == 0) { 5588de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis skip_call = log_msg( 5589de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5590de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, MEMTRACK_INVALID_MEM_TYPE, "MT", 5591de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " 5592de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "type (0x%X) of this memory object 0x%" PRIx64 ".", 5593de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, memory_type_bits, mem_info->alloc_info.memoryTypeIndex, reinterpret_cast<const uint64_t &>(mem_info->mem)); 55944261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski } 55954261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski return skip_call; 55964261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski} 55974261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski 559889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 559989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 560058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5602b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 56049f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis uint64_t buffer_handle = reinterpret_cast<uint64_t &>(buffer); 560583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 56068718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 56078718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 560994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 56104bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->mem = mem; 56114bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memOffset = memoryOffset; 56124bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memSize = memRequirements.size; 561347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 561447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 561557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 561657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 56179f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertBufferMemoryRange(dev_data, buffer, mem_info, memoryOffset, memRequirements); 561883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "BindBufferMemory"); 561947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 562047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 56212c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 56222c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 562383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 56242c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 56252c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5626414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5627414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 56282c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 56292c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 56302c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 5631ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 56322c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 5633ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const VkBufferUsageFlagBits usage_list[3] = { 5634ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static_cast<VkBufferUsageFlagBits>(VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT), 5635ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, 5636ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_STORAGE_BUFFER_BIT}; 5637ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *memory_type[3] = {"texel", 5638ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "uniform", 5639ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "storage"}; 5640ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *offset_name[3] = { 5641ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minTexelBufferOffsetAlignment", 5642ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minUniformBufferOffsetAlignment", 5643ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minStorageBufferOffsetAlignment" 5644ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 5645ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5646ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Keep this one fresh! 5647ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller const VkDeviceSize offset_requirement[3] = { 5648ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment, 5649ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, 5650ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment 5651ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 56528718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; 5653ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5654ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (int i = 0; i < 3; i++) { 5655ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (usage & usage_list[i]) { 5656ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (vk_safe_modulo(memoryOffset, offset_requirement[i]) != 0) { 5657ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call |= 5658ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 5659ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5660ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "vkBindBufferMemory(): %s memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5661ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "device limit %s 0x%" PRIxLEAST64, 5662ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller memory_type[i], memoryOffset, offset_name[i], offset_requirement[i]); 5663ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 56642c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 56652c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 56665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56670a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5668b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 566983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 567058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 56715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 567589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 567689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 56775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 56795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 56805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 56815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 568389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 568489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 56855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 56875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 56885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 56895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5690593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 569189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 569289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 5693e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 56945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 56955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 56965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 569889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 569989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5700918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5701918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5702b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5703918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5704b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5705918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5706918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 57075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 570989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 571089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 5711a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5712e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Add detection for in-flight pipeline 5713e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5714a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis auto pipe_node = getPipeline(dev_data, pipeline); 5715a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis if (pipe_node) { 5716a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis // Any bound cmd buffers are now invalid 5717a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis invalidateCommandBuffers(pipe_node->cb_bindings, 5718a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}); 5719a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis dev_data->pipelineMap.erase(pipeline); 5720a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 5721e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5722e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 57235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 572589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 572689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 57276792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5728e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 57296792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis dev_data->pipelineLayoutMap.erase(pipelineLayout); 5730e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis lock.unlock(); 5731e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5732e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 57335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 573589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 573689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 573756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 573856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis // TODO : Add detection for in-flight sampler 573956f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 574056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis auto sampler_node = getSamplerNode(dev_data, sampler); 574156f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis if (sampler_node) { 574256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis // Any bound cmd buffers are now invalid 574356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis invalidateCommandBuffers(sampler_node->cb_bindings, 574456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis {reinterpret_cast<uint64_t &>(sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}); 574556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis dev_data->samplerMap.erase(sampler); 574656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 574756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis lock.unlock(); 574856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis dev_data->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 57495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 575189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 575289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 5753e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 57545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 57555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 57565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 575889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 575989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 5760e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 57615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 57625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 57635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5764bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 5765bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 5766bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 5767bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 5768a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbesstatic bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 5769bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5770bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 5771bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 5772bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 5773bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 5774bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 5775bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 5776bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 5777414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use.", action, 5778bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 5779bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5780bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5781bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5782bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 5783a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 5784bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 5785a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action) { 5786bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5787a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 5788a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 5789a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 5790bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5791bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5792bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5793bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 57945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5795a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic void clearCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool) { 5796a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 5797a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 5798a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes } 5799a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes} 5800a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 580189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 580289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 58035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5805b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5806c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 58075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 58089f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 58095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 58109f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 58119f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis skip_call |= checkCommandBufferInFlight(dev_data, cb_node, "free"); 5812c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 5813c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 5814c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 5815c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes if (skip_call) 5816c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes return; 5817c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 5818c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 5819c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes for (uint32_t i = 0; i < commandBufferCount; i++) { 58209f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 5821c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes // Delete CB information structure, and remove from commandBufferMap 58229f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 58239f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 58245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 58259f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis resetCB(dev_data, cb_node->commandBuffer); 58269f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb_node->commandBuffer); 58279f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; 58285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 5831c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes pPool->commandBuffers.remove(pCommandBuffers[i]); 58325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58330a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 5834b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5835e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5836e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 58375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 583989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 584089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 584189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 58425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 58455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5847b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 58485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 58495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 58505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 585489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 585589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 58565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 58595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5860b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 58615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 58625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 586789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 586889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 58695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 587083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5871b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 58725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 5873a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 587483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "destroy command pool with"); 58755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 587683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 58775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 58789f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandBufferMap 5879a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 5880a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cb : pPool->commandBuffers) { 5881a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 58829f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, cb); 5883d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // Remove references to this cb_node prior to delete 5884d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // TODO : Need better solution here, resetCB? 58857165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski for (auto obj : cb_node->object_bindings) { 58867165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski removeCommandBufferBinding(dev_data, &obj, cb_node); 58877165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski } 5888d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis for (auto framebuffer : cb_node->framebuffers) { 5889d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 5890d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis if (fb_node) 5891d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis fb_node->cb_bindings.erase(cb_node); 5892d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis } 58939f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb); // Remove this command buffer 58949f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; // delete CB info structure 5895a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes } 5896a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->commandPoolMap.erase(commandPool); 5897a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes lock.unlock(); 5898e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5899e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 59005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 590289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 590389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 59045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 590583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5906400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 59071ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 5908a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 590983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with"); 59101ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 5911a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes 591283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 59135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5915a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 59185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 59191ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.lock(); 5920a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 5921a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmdBuffer : pPool->commandBuffers) { 5922a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes resetCB(dev_data, cmdBuffer); 59235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59241ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 59255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 592989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 59305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 593183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5932b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 59335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 5934df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 5935090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence && pFence->state == FENCE_INFLIGHT) { 593683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 593783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 593883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is in use.", reinterpret_cast<const uint64_t &>(pFences[i])); 59395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5941b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5942090da73358f71ba026e2474a822fecf55267d166Chris Forbes 594383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 5944090da73358f71ba026e2474a822fecf55267d166Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 5945090da73358f71ba026e2474a822fecf55267d166Chris Forbes 5946090da73358f71ba026e2474a822fecf55267d166Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 5947090da73358f71ba026e2474a822fecf55267d166Chris Forbes 5948090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (result == VK_SUCCESS) { 5949090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.lock(); 5950090da73358f71ba026e2474a822fecf55267d166Chris Forbes for (uint32_t i = 0; i < fenceCount; ++i) { 5951090da73358f71ba026e2474a822fecf55267d166Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 5952090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence) { 5953090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->state = FENCE_UNSIGNALED; 5954090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 5955090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 5956090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.unlock(); 5957090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 5958090da73358f71ba026e2474a822fecf55267d166Chris Forbes 59595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5962e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis// For given cb_nodes, invalidate them and track object causing invalidation 5963e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlisvoid invalidateCommandBuffers(std::unordered_set<GLOBAL_CB_NODE *> cb_nodes, VK_OBJECT obj) { 5964e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto cb_node : cb_nodes) { 5965e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->state = CB_INVALID; 5966e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->broken_bindings.push_back(obj); 5967e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis } 5968e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis} 5969e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis 597089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 597189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5973b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5974d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 5975d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis if (fb_node) { 5976e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis invalidateCommandBuffers(fb_node->cb_bindings, 5977e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis {reinterpret_cast<uint64_t &>(fb_node->framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}); 5978d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis dev_data->frameBufferMap.erase(fb_node->framebuffer); 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5980b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 59825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 598489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 598589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 59865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5987e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 59885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 59897bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes // TODO: leaking all the guts of the renderpass node here! 5990e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5991e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 59925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 599489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 599589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 59965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 599747892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 599847892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 59995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6001b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 6003b5e51047540e12567fbf674b23fe75ca86ca0371Tobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_NODE>(new BUFFER_NODE(*pBuffer, pCreateInfo)))); 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60088c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateBufferView(layer_data *dev_data, const VkBufferViewCreateInfo *pCreateInfo) { 60098c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 60108c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young BUFFER_NODE *buf_node = getBufferNode(dev_data, pCreateInfo->buffer); 60118c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young // If this isn't a sparse buffer, it needs to have memory backing it at CreateBufferView time 6012b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (buf_node) { 6013b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buf_node, "vkCreateBufferView()"); 6014cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 6015cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 601659b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, buf_node, 6017b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, 6018b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski false, "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 6019b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 60208c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 60218c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 60228c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young 602389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 602489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 60255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60268c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 60278c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateBufferView(dev_data, pCreateInfo); 60288c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 60298c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 60308c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 60315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 60325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 60338c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 60342f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis dev_data->bufferViewMap[*pView] = unique_ptr<VkBufferViewCreateInfo>(new VkBufferViewCreateInfo(*pCreateInfo)); 60358c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 60365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 604089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 604189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 60425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 604347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 604447892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 60455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6047b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 60485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 60495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 60505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 605129e9a148072b1015633a102470f0cf706a9e2e55Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, unique_ptr<IMAGE_NODE>(new IMAGE_NODE(*pImage, pCreateInfo)))); 60525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 60535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 60545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 60555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 6060b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 60615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 60636d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 60665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 60675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 60685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 60696d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->levelCount = image_node->createInfo.mipLevels - range->baseMipLevel; 60705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 60736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->layerCount = image_node->createInfo.arrayLayers - range->baseArrayLayer; 60745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 60795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 60805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 60815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 6082b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 60866d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 60876d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 60885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 60896d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *levels = image_node->createInfo.mipLevels - range.baseMipLevel; 60905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 60926d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *layers = image_node->createInfo.arrayLayers - range.baseArrayLayer; 60935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60978c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo) { 60988c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 60998c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young IMAGE_NODE *image_node = getImageNode(dev_data, pCreateInfo->image); 6100b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (image_node) { 61015a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour skip_call |= ValidateImageUsageFlags( 61025a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour dev_data, image_node, VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | 61035a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 61045a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour false, "vkCreateImageView()", 61055a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT|DEPTH_STENCIL_ATTACHMENT|INPUT_ATTACHMENT]_BIT"); 6106b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski // If this isn't a sparse image, it needs to have memory backing it at CreateImageView time 6107b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_node, "vkCreateImageView()"); 6108bb6624cb996175d8945190886a200e720b3871efChris Forbes } 61098c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 61108c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6111bb6624cb996175d8945190886a200e720b3871efChris Forbes 61128c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic inline void PostCallRecordCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo, VkImageView *pView) { 61138c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young dev_data->imageViewMap[*pView] = unique_ptr<VkImageViewCreateInfo>(new VkImageViewCreateInfo(*pCreateInfo)); 61148c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[*pView].get()->subresourceRange, pCreateInfo->image); 61158c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6116bb6624cb996175d8945190886a200e720b3871efChris Forbes 61178c07a094dc9cc4afb6b62181f341c12b9e969041Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 61188c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 61198c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61208c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 61218c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateImageView(dev_data, pCreateInfo); 61228c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 61238c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 61248c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 61258c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 61265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 61278c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 61288c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young PostCallRecordCreateImageView(dev_data, pCreateInfo, pView); 61298c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6131bb6624cb996175d8945190886a200e720b3871efChris Forbes 61325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 613589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 613689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 61375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 61395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6140b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6141a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 61428988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes fence_node.fence = *pFence; 6143a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 6144cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 615089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 615189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 61525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 61545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 615889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 616489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 617189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61773d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 61783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 61793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 61803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 61813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 61823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 61833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 61843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 61853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 61863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 61873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 61883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 61893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 61903d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 61913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 61923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 61933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 61943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 61953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 61963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 61973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 619889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 619989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 620089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 620189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 62025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 62035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 620883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 62095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 62105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 62115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6214b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 62155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 6217ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6218ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 62198da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis pPipeNode[i]->render_pass_ci.initialize(getRenderPass(dev_data, pCreateInfos[i].renderPass)->pCreateInfo); 6220c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis pPipeNode[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 622167220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 622283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 62235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 622583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6226b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6229b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6234b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 62375188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 62385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6239b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 624589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 624689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 624789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 624889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 62495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 625083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 62535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 62545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6257b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 62585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 62605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 62625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6263ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 6264c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis pPipeNode[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 6265ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 62665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 626883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= !validate_compute_pipeline(dev_data->report_data, pPipeNode[i], &dev_data->phys_dev_properties.features, 626983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->shaderModuleMap); 627083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis // skip_call |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 62715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 627383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6274b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6277b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 62795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 62805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6282b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 62855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 62865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 62875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6288b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 62905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 629489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 629589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6299b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6300cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 630589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 630689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 630789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 63115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 6312b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6313cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = 6314cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis new cvdescriptorset::DescriptorSetLayout(dev_data->report_data, pCreateInfo, *pSetLayout); 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63199e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 63209e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 63219e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 63229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 63239e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 632483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 63259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 63269e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 63279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 63289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 63299e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 633083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 63319e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 63329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with offset %u and size %u that " 63339e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 63349e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset, size, maxPushConstantsSize); 63359e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 633683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 633783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 633883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 633983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset, size, maxPushConstantsSize); 63409e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 634183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 634283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 63439e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 63449e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 63459e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 63469e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 63479e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 634883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 63499e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 63509e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 63519e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 63529e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, size); 63539e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 635483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 63559e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 63569e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 63579e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 63589e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 63599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 636083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 636183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 63629e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 63639e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 63649e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 63659e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 63669e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 636783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 636883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 636983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 637083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, index, offset); 63719e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 637283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 637383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 637483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 637583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset); 63769e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 637783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 637883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 63799e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 63805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 638183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 63825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 638489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 638589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 638683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 63875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63889e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 63895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 63905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 639183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 639283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 63939e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 639483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 639583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 63969e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 63979e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 63989e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 639983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 64009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t i, j; 64019e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 64029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 64039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 64049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 64059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 64069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 64079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 640883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 6409a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 64109e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 64119e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 64129e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz i, minA, maxA, j, minB, maxB); 64139e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 64149e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 64155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6417f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 641883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 6419f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 6420f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 64215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 64225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6423b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 642569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis plNode.layout = *pPipelineLayout; 6426416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts.resize(pCreateInfo->setLayoutCount); 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 6428416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); 64295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6430416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges.resize(pCreateInfo->pushConstantRangeCount); 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 6432416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges[i] = pCreateInfo->pPushConstantRanges[i]; 64335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 643889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 643989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 644089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 64435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 64445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6446414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 64475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 64505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 64515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 64525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 64535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 64545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6456b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 646589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 646689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 64675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 64695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6470b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 64725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64752c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// Ensure the pool contains enough descriptors and descriptor sets to satisfy 6476789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// an allocation request. Fills common_data with the total number of descriptors of each type required, 6477789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// as well as DescriptorSetLayout ptrs used for later update. 64787f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlisstatic bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 64797f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData *common_data) { 64807e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All state checks for AllocateDescriptorSets is done in single function 6481e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehlis return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); 64827e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis} 64837e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Allocation state was good and call down chain was made so update state based on allocating descriptor sets 64847e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlisstatic void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 64857f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis VkDescriptorSet *pDescriptorSets, 64867f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis const cvdescriptorset::AllocateDescriptorSetsData *common_data) { 64877e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All the updates are contained in a single cvdescriptorset function 64882c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, 6489b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis &dev_data->setMap, dev_data); 64902c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes} 64912c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 649289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 649389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6495b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64967f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); 64977f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); 6498b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6499d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 65007e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis if (skip_call) 65015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6502d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 65046511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6506b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 65077f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); 6508b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6512cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Verify state before freeing DescriptorSets 6513cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6514cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6515cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skip_call = false; 6516cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // First make sure sets being destroyed are not currently in-use 6517cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6518cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); 6519cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6520cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_node = getPoolNode(dev_data, pool); 6521cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis if (pool_node && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_node->createInfo.flags)) { 6522cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Can't Free from a NON_FREE pool 6523cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6524cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis reinterpret_cast<uint64_t &>(pool), __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 6525cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 6526cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 6527cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6528cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis return skip_call; 6529cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 6530cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Sets have been removed from the pool so update underlying state 6531cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6532cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6533cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_state = getPoolNode(dev_data, pool); 6534cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Update available descriptor sets in pool 6535cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableSets += count; 6536cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6537cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 6538cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 6539cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis auto set_state = dev_data->setMap[descriptor_sets[i]]; 6540cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis uint32_t type_index = 0, descriptor_count = 0; 6541cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t j = 0; j < set_state->GetBindingCount(); ++j) { 6542cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis type_index = static_cast<uint32_t>(set_state->GetTypeFromIndex(j)); 6543cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis descriptor_count = set_state->GetDescriptorCountFromIndex(j); 6544cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; 6545cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6546cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis freeDescriptorSet(dev_data, set_state); 6547cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->sets.erase(set_state); 6548cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6549cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 65505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 655189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 655289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 65535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6555b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 655683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6557b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6558e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 655983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 65605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6563b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6564cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6565b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65696b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// TODO : This is a Proof-of-concept for core validation architecture 65706b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// Really we'll want to break out these functions to separate files but 65716b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// keeping it all together here to prove out design 65726b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() 65736b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 65746b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 65756b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 65766b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // First thing to do is perform map look-ups. 65776b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets 65786b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // so we can't just do a single map look-up up-front, but do them individually in functions below 65796b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis 65806b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Now make call(s) that validate state, but don't perform state updates in this function 65816b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the 65826b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // namespace which will parse params and make calls into specific class instances 6583104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, 6584104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis descriptorCopyCount, pDescriptorCopies); 65856b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 65866b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() 65876b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 65886b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 65896b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 6590104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 65916b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 65926b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 65935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 659489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 659589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 659689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 65976b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Only map look-up at top level is for device-level layer_data 65985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6599b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66006b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 66016b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 6602b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66036b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis if (!skip_call) { 66045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 66055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 66066b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis lock.lock(); 66076b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Since UpdateDescriptorSets() is void, nothing to check prior to updating state 66086b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 66096b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 66105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 661389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 661489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 66155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 66175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6618b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6619cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, pCreateInfo->commandPool); 6620cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes 6621cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (pPool) { 662272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 66235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 6624cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes pPool->commandBuffers.push_back(pCommandBuffer[i]); 66255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 66265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 66275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 66285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 66295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 66305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 66315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66330a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6634b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 663989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 664089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 664183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 66425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6643b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 66455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 66465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 66475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 6648a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 664983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 6650a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6651a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 6652414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Calling vkBeginCommandBuffer() on active CB 0x%p before it has completed. " 6653a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 6654a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 66555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6656a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 66575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 66585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 66595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 66605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 666183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 66625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 66635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6664414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 66655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 66665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6668400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 666983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 66705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6672414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 66735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 66745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6675400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 667683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 667783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 667883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 667983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 668083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "valid framebuffer parameter is specified.", 668183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 6684f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = getFramebuffer(dev_data, pInfo->framebuffer); 6685f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (framebuffer) { 6686a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((framebuffer->createInfo.renderPass != pInfo->renderPass) && 6687a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(dev_data, framebuffer->renderPassCreateInfo.ptr(), 6688a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis getRenderPass(dev_data, pInfo->renderPass)->pCreateInfo, 6689a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis errorString)) { 6690400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 669183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 6692a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6693a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 6694a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 6695a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command " 6696a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 6697a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 6698a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<void *>(commandBuffer), reinterpret_cast<const uint64_t &>(pInfo->renderPass), 6699a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<const uint64_t &>(pInfo->framebuffer), 6700a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(framebuffer->createInfo.renderPass), errorString.c_str()); 67015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 6703b6fe8da9537ef985960fd1d32b83c952b422f00bTobin Ehlis framebuffer->cb_bindings.insert(pCB); 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6708b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 671083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 671183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 671283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 671383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 671483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 671583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "support precise occlusion queries.", 671683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 672016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pInfo->renderPass); 672116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 672216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (pInfo->subpass >= renderPass->pCreateInfo->subpassCount) { 672383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 672483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 672583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 672683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 672783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "that is less than the number of subpasses (%d).", 672883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (void *)commandBuffer, pInfo->subpass, renderPass->pCreateInfo->subpassCount); 67295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 673483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 67355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6737414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Cannot call Begin on CB (0x%" PRIxLEAST64 67385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 67395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 67407651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else if (CB_RECORDED == pCB->state || (CB_INVALID == pCB->state && CMD_END == pCB->cmds.back().type)) { 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 6742cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 6743cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 674483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 67455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6747414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 6748414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 67495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 67505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 67515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 67535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 67555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 67565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 67575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 67595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 6760888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 6761888e1d268098177fde4a2263e3d7b7cc415f1debMark Young if ((pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 6762888e1d268098177fde4a2263e3d7b7cc415f1debMark Young (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 676316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeRenderPass = getRenderPass(dev_data, pCB->beginInfo.pInheritanceInfo->renderPass); 6764888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->activeSubpass = pCB->beginInfo.pInheritanceInfo->subpass; 6765888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->framebuffers.insert(pCB->beginInfo.pInheritanceInfo->framebuffer); 6766888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 67675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 676983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 677083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 677183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB 0x%p!", (void *)commandBuffer); 67725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6773b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 677483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 67755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6778400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 67795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 678289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 678383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 67845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 67855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6786b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6789fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 6790fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 6791fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 679283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 6793fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 679483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); 67955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 679683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 679783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 679883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 679983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(query.pool), query.index); 68005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 680283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6803b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 6805b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 68065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 68075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 68085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 68095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 68145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6815b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 681989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 682089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6821bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 68225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6823b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 6826cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 6827cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 6828bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6829bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6830414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 6831bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 6832bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 68335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6834a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, pCB, "reset"); 6835b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6836bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 68375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 68385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6840b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6841a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes dev_data->globalInFlightCmdBuffers.erase(commandBuffer); 68425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 6843b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 684793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 684889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 684989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 685083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 68515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6852b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 685583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 685783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 68585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 68595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 6860414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 6861ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass->renderPass); 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 68665c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_node = pPN; 68675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 68683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 68695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 687083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 687183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 687283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 68735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6874a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis addCommandBufferBinding(&getPipeline(dev_data, pipeline)->cb_bindings, 6875a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}, pCB); 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6877b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 687883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 68805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 688289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 688389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 688483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6886b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 688983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 6891b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask |= ((1u<<viewportCount) - 1u) << firstViewport; 68925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6893b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 689483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 68965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 689889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 689989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 690083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6902b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 690583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 6907b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask |= ((1u<<scissorCount) - 1u) << firstScissor; 69085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6909b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 691083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 69125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 691489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 6915a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 69165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6917b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6920a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 69215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 6922a27508babf63d50aea75883a3702979193c23683Mark Young 69235c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis PIPELINE_NODE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_node; 6924a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 6925a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 6926a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 6927386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 6928a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 6929a27508babf63d50aea75883a3702979193c23683Mark Young } else { 6930a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 6931a27508babf63d50aea75883a3702979193c23683Mark Young } 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6933b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6934a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 69355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 693889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 693989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 694083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6942b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 694583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6948b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 694983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 69525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 695489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 695583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6957b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 696083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 69613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 69625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6963b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 696483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 69665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 696889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 696989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 697083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6972b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 697583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 69765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 69775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6978b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 697983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 69815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 698389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 698489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 698583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6987b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 699083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 69915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 69925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6993b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 699483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 69965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 699889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 699989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 700083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7002b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 700583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 70065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 70075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7008b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 700983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 701389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 701489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 701583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7017b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 702083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7023b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 702483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 702889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 702989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 703089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 703189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 703283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7034b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7038787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7039787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7040787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7041787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 7042dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { 704372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 7044dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); 7045dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes } 704671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 704769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = getPipelineLayout(dev_data, layout); 7048787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7049397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7050787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 705169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_layout = *pipeline_layout; 705271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pSet; 705383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 705483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 705583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_NONE, "DS", "DS 0x%" PRIxLEAST64 " bound on pipeline %s", 705683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7057397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 705883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 705983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 706083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 706183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "DS 0x%" PRIxLEAST64 706283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 706383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7064787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7065787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 706669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, pipeline_layout, i + firstSet, errorString)) { 706783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 706883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 706983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 707083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 707183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 707283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 7073787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7074dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7075dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes auto setDynamicDescriptorCount = pSet->GetDynamicDescriptorCount(); 7076dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7077dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); 7078dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7079dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (setDynamicDescriptorCount) { 7080787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7081dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { 708283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 7083787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7084787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7085787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7086414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 7087787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7088787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7089397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 7090787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7091787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7092787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7093787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7094397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 7095397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7096787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7097787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7098b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 709983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7100787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7101787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7102787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7103787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7104414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 7105787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7106b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 7107787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7108787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7109397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7110787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7111787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7112b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 711383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7114787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7115787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7116787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7117787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7118414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 7119787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7120b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 71215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7122787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 71235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7125dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7126dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = 7127dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, 7128dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); 7129787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7130dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes totalDynamicDescriptors += setDynamicDescriptorCount; 7131dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 71325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7134787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 713583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 713683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 713783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS 0x%" PRIxLEAST64 " that doesn't exist!", 713883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 71395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 714083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 714172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 714272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 714372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 714472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 714571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], 714669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pipeline_layout, i, errorString)) { 714783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 714872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 714972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 715072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 7151414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DescriptorSetDS 0x%" PRIxLEAST64 7152414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 715372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 715472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 715572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 715672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 715772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 715872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 715972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 716072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 716169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, pipeline_layout, lastSetIndex, errorString)) { 716271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto old_set = oldFinalBoundSet->GetSet(); 716383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 716472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 716571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, 7166414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DescriptorSetDS 0x%" PRIxLEAST64 7167414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 716872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 7169414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 717071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis reinterpret_cast<uint64_t &>(old_set), lastSetIndex, 717172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 717272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 717372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 71745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7177787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7178787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 717983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 718083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 718183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 718283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 718383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 718483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7185787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 71865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 718783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 71885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7190b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 719183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 71925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 71935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 71945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 719689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 719789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 719883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 71995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7200593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 7201b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7202b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 7203ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 72049f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7205ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7206b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7207ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7208f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7209ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 72109f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 721183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 72125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 72135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 72145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 72155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 72165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 72175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 72185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 72195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 72205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 72215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 72225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 72235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 722583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 722683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 722783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 722883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis offset, string_VkIndexType(indexType)); 72295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72309f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->status |= CBSTATUS_INDEX_BUFFER_BOUND; 7231ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7232ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 72335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7234b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 723583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 72375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 72405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 72415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 72425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 72435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 72455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 72465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7249e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 72505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 725189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 725289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 725389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 725483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7256593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 7257b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7258b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 72599f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 72609f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 7261593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 7262ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, pBuffers[i]); 7263ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7264b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7265ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7266f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7267ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 72689f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 72695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72709f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis addCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 72719f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis updateResourceTracking(cb_node, firstBinding, bindingCount, pBuffers); 72725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 727383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7275b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 727683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 72785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7280b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 7281e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 72825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 72837a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 72847a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 72852c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_data = getImageViewData(dev_data, imageView); 72862c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (!iv_data) 72875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 7288249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 7289249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, iv_data->image); 7290249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(img_node); 7291e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7292f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, img_node, true); 7293e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 72957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 72967a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 72977a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 7298ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7299ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7300e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7301f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, buff_node, true); 7302e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 73047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 73055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 73075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 730989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 731089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 731183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7313b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 731683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 73175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 7318e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDraw"); 731983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 73205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 732183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 73225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7323414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW]++); 732483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 732583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 73265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 73275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 732883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 73295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7330b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 733183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 733589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 733689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 73375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 733983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7340b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 734383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 7345e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexed"); 734683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 73475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 734883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 734983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 735083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 735183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 735283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 73535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 73545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 735583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 73565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7357b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 735883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 73605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 73615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 736389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 736489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 73655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 736683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7367b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7368ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7369ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7370ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7371ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7372b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndirect()"); 7373c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7374ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 7375ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDIRECT]++; 7376e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndirect"); 7377ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 73785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 737983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 738083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 738183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 738283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 738383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7384ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 73855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7386b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndirect()"); 7387ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7388ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 73895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7390b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 739183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 73935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 739589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 739689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 739783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7399b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7400ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7401ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7402ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7403ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7404b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndexedIndirect()"); 7405c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7406ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 7407ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDEXED_INDIRECT]++; 7408e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 7409e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexedIndirect"); 7410ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 74115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 741283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 74135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7414414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting DS state:", 74155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 741683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 741783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7418ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 74195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7420b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndexedIndirect()"); 7421ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7422ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 74235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7424b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 742583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 74275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 742989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 743083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7432b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7435e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatch"); 743683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 743783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 743883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7440b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 744183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 74435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 744589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 744689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 744783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7449b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7450ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7451ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7452ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7453b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (cb_node && buff_node) { 7454b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDispatchIndirect()"); 7455c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7456e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 7457e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatchIndirect"); 7458ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 7459ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 7460b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdDispatchIndirect()"); 74615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7462b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 746383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 74655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 746789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 746889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 746983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7471b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7472ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 74739f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7474ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 7475ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7476ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && src_buff_node && dst_buff_node) { 7477b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 7478b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyBuffer()"); 7479ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffers and cmd buffer 7480c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 7481c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 7482ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 748359b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyBuffer()", 7484ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 748559b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyBuffer()", 7486ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7487ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7488ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7489f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 7490ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 74919f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7492593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7493f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 7494e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 74969f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7497593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 749883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 7499b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBuffer()"); 7500ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7501ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Param_checker will flag errors on invalid objects, just assert here as debugging aid 7502ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 75035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7504b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 750583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 750927e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifySourceImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage srcImage, 751027e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout srcImageLayout) { 7511e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 75155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 751727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, srcImage, sub, node)) { 751827e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 75195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 75225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 75235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 75245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 75265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 75275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 75285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 75315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 753207b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // TODO : Can we deal with image node from the top of call tree and avoid map look-up here? 753307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis auto image_node = getImageNode(dev_data, srcImage); 753407b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis if (image_node->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 753507b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 753607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 753707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 753807b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 753907b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 75485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 755027e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifyDestImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage destImage, 755127e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout destImageLayout) { 7552e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 75535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 75555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 75565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 75575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 755827e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, destImage, sub, node)) { 755927e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 75645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 75655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 75675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 75685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 757207b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis auto image_node = getImageNode(dev_data, destImage); 757307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis if (image_node->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 757407b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 757507b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 757607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 757707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 757807b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7589f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Test elements of a VkExtent3D structure against alignment constraints contained in another VkExtent3D structure 7590f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool IsExtentAligned(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkExtent3D *extent, 7591f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski VkExtent3D *granularity) { 7592f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool valid = true; 7593f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski auto pPool = getCommandPoolNode(dev_data, cb_node->createInfo.commandPool); 7594f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (pPool) { 7595f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski granularity = &dev_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].minImageTransferGranularity; 7596f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if ((vk_safe_modulo(extent->depth, granularity->depth) != 0) || (vk_safe_modulo(extent->width, granularity->width) != 0) || 7597f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski (vk_safe_modulo(extent->height, granularity->height) != 0)) { 7598f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski valid = false; 7599f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7600f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7601f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return valid; 7602f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7603f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7604f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkOffset3D structure against a queue family's Image Transfer Granularity values 7605f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool CheckItgOffset(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkOffset3D *offset, const uint32_t i, 7606f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski const char *function, const char *member) { 7607f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 7608f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski VkExtent3D granularity = {}; 7609f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski VkExtent3D extent = {}; 7610f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski extent.width = static_cast<uint32_t>(abs(offset->x)); 7611f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski extent.height = static_cast<uint32_t>(abs(offset->y)); 7612f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski extent.depth = static_cast<uint32_t>(abs(offset->z)); 7613f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (IsExtentAligned(dev_data, cb_node, &extent, &granularity) == false) { 7614f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= log_msg( 7615f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7616f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) must respect this command buffer's " 7617f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski "queue family image transfer granularity (w=%d, h=%d, d=%d).", 7618f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski function, i, member, offset->x, offset->y, offset->z, granularity.width, granularity.height, granularity.depth); 7619f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7620f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7621f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7622f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7623f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkExtent3D structure against a queue family's Image Transfer Granularity values 7624f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool CheckItgExtent(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkExtent3D *extent, const uint32_t i, 7625f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski const char *function, const char *member) { 7626f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 7627f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski VkExtent3D granularity = {}; 7628f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (IsExtentAligned(dev_data, cb_node, extent, &granularity) == false) { 7629f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7630f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 7631f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) must respect this command buffer's " 7632f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski "queue family image transfer granularity (w=%d, h=%d, z=%d).", 7633f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski function, i, member, extent->width, extent->height, extent->depth, granularity.width, granularity.height, 7634f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski granularity.depth); 7635f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7636f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7637f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7638f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7639f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a uint32_t width or stride value against a queue family's Image Transfer Granularity width value 7640f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool CheckItgInt(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const uint32_t value, const uint32_t i, 7641f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski const char *function, const char *member) { 7642f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 7643f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski VkExtent3D granularity = {}; 7644f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski VkExtent3D extent = {}; 7645f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski extent.width = value; 7646f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (IsExtentAligned(dev_data, cb_node, &extent, &granularity) == false) { 7647f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7648f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 7649f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski "%s: pRegion[%d].%s (%d) must respect this command buffer's queue family image transfer granularity %d).", 7650f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski function, i, member, extent.width, granularity.width); 7651f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7652f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7653f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7654f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7655f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a VkDeviceSize value against a queue family's Image Transfer Granularity width value 7656f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool CheckItgSize(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkDeviceSize value, const uint32_t i, 7657f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski const char *function, const char *member) { 7658f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 7659f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski VkExtent3D *granularity; 7660f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski auto pPool = getCommandPoolNode(dev_data, cb_node->createInfo.commandPool); 7661f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (pPool) { 7662f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski granularity = &dev_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].minImageTransferGranularity; 7663f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (vk_safe_modulo(value, granularity->width) != 0) { 7664f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7665f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 7666f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski "%s: pRegion[%d].%s (%" PRIdLEAST64 7667f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski ") must respect this command buffer's queue family image transfer granularity %d).", 7668f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski function, i, member, value, granularity->width); 7669f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7670f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7671f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7672f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7673f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7674f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkImageCopy structure 7675f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 7676f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski const VkImageCopy *region, const uint32_t i, 7677f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski const char *function) { 7678f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 7679f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= CheckItgOffset(dev_data, cb_node, ®ion->srcOffset, i, function, "srcOffset"); 7680f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= CheckItgOffset(dev_data, cb_node, ®ion->dstOffset, i, function, "dstOffset"); 7681f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= CheckItgExtent(dev_data, cb_node, ®ion->extent, i, function, "extent"); 7682f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7683f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7684f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7685f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkBufferImageCopy structure 7686f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyBufferImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 7687f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski const VkBufferImageCopy *region, const uint32_t i, 7688f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski const char *function) { 7689f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 7690f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= CheckItgSize(dev_data, cb_node, region->bufferOffset, i, function, "bufferOffset"); 7691f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= CheckItgInt(dev_data, cb_node, region->bufferRowLength, i, function, "bufferRowLength"); 7692f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= CheckItgInt(dev_data, cb_node, region->bufferImageHeight, i, function, "bufferImageHeight"); 7693f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= CheckItgOffset(dev_data, cb_node, ®ion->imageOffset, i, function, "imageOffset"); 7694f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= CheckItgExtent(dev_data, cb_node, ®ion->imageExtent, i, function, "imageExtent"); 7695f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7696f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7697f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 769889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 769989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 770089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 770183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 77025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7703b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7704249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 77059f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7706249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 7707249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7708249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 7709b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdCopyImage()"); 7710b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdCopyImage()"); 7711249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 7712c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 7713c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 7714249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 771559b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_img_node, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyImage()", 7716ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 771759b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_img_node, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyImage()", 7718ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7719f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis std::function<bool()> function = [=]() { return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdCopyImage()"); }; 77209f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7721593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7722f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 7723e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 77259f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7726593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 772783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGE, "vkCmdCopyImage()"); 7728b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImage()"); 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 773027e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].srcSubresource, srcImageLayout); 773127e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].dstSubresource, dstImageLayout); 7732f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip_call |= ValidateCopyImageTransferGranularityRequirements(dev_data, cb_node, &pRegions[i], i, "vkCmdCopyImage()"); 77335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7734249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 7735249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 77365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7737b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 773883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 77405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 77415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7743eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski// Validate that an image's sampleCount matches the requirement for a specific API call 7744eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinskistatic inline bool ValidateImageSampleCount(layer_data *dev_data, IMAGE_NODE *image_node, VkSampleCountFlagBits sample_count, 7745eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski const char *location) { 7746eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski bool skip = false; 7747eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski if (image_node->createInfo.samples != sample_count) { 7748eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 7749eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski reinterpret_cast<uint64_t &>(image_node->image), 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 7750eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski "%s for image 0x%" PRIxLEAST64 " was created with a sample count of %s but must be %s.", location, 7751eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski reinterpret_cast<uint64_t &>(image_node->image), 7752eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski string_VkSampleCountFlagBits(image_node->createInfo.samples), string_VkSampleCountFlagBits(sample_count)); 7753eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski } 7754eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski return skip; 7755eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski} 7756eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski 775789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 775889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 775989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 776083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 77615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7762b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7763593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 77649f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7765249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 7766249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7767249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 7768eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, src_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): srcImage"); 7769eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, dst_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): dstImage"); 7770b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdBlitImage()"); 7771b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdBlitImage()"); 7772249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 7773c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 7774c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 7775249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 777659b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_img_node, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdBlitImage()", 7777ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 777859b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_img_node, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdBlitImage()", 7779ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7780f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis std::function<bool()> function = [=]() { return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdBlitImage()"); }; 77819f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7782593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7783f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 7784e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 77869f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7787593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 778883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); 7789b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBlitImage()"); 7790249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 7791249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7793b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 779483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 77965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 77975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 779989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 780089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 780189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 780283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 78035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7804b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7805593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 78069f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7807ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 7808249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7809249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_buff_node && dst_img_node) { 7810eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, dst_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyBufferToImage(): dstImage"); 7811b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); 7812b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdCopyBufferToImage()"); 7813c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 7814c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 781559b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 7816ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 781759b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_img_node, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 7818ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7819e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7820f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 7821e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 78239f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7824f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis function = [=]() { return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); }; 78259f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7826593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 782783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 7828b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBufferToImage()"); 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 783027e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].imageSubresource, dstImageLayout); 7831f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip_call |= 7832f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, &pRegions[i], i, "vkCmdCopyBufferToImage()"); 78335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7834ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7835ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 78365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7837b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 783883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 78395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 78405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 78415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 784389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 784489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 784589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 784683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 78475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7848b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7849593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 78509f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7851249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 7852ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7853249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_buff_node) { 7854eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, src_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyImageToBuffer(): srcImage"); 7855b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdCopyImageToBuffer()"); 7856b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyImageToBuffer()"); 7857249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between buffer/image and cmd buffer 7858c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 7859c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 7860249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC image & DST buffer have correct usage flags set 786159b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_img_node, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 7862ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 786359b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 7864ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7865e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7866f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdCopyImageToBuffer()"); 7867e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 78689f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7869593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7870f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 7871e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 78739f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7874593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 787583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 7876b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImageToBuffer()"); 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 787827e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].imageSubresource, srcImageLayout); 7879f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip_call |= 7880f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, &pRegions[i], i, "CmdCopyImageToBuffer"); 78815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7882ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7883ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 78845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7885b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 788683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 78875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 78895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 789189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 789289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 789383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 78945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7895b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7896593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 78979f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7898ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7899ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 7900b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdUpdateBuffer()"); 7901ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 7902c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 7903ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 790459b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 7905ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7906e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7907f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 7908e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 79109f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7911593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 791283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 7913b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyUpdateBuffer()"); 7914ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7915ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7917b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 791883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 79195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 79205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 792289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 792389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 792483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 79255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7926b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7927593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 79289f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7929ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7930ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 7931b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdFillBuffer()"); 7932ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 7933c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 7934ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 793559b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdFillBuffer()", 7936ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7937e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7938f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 7939e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 79419f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7942593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 794383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 7944b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyFillBuffer()"); 7945ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7946ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7948b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 794983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 795389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 795489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 795589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 795683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7958b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 796183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 79635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 79655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 79665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 79685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 79695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 797083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 797183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 797283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 797383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 797483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(commandBuffer)); 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7976b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments()"); 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 7981ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->pCreateInfo; 79825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 79835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 79855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 79865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 7987e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 79885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 79895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 7990e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7994e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 799583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 79975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 79985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 79995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 80005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 80055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 800683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 80075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 80085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 80105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 80125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 80135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 80145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8018b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 801983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 80205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 802389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 802489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 802589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 802683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8028b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8030249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 80319f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8032249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, image); 8033249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && img_node) { 8034b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, img_node, "vkCmdClearColorImage()"); 8035c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, img_node); 8036e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8037f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, img_node, true); 8038e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 80409f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8041593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 804283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 8043b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearColorImage()"); 8044249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8045249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 80465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8047b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 804883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 80505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 805289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 805389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 805489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 805589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 805683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8058b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8060249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 80619f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8062249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, image); 8063249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && img_node) { 8064b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, img_node, "vkCmdClearDepthStencilImage()"); 8065c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, img_node); 8066e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8067f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, img_node, true); 8068e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 80709f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8071593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 807283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 8073b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearDepthStencilImage()"); 8074249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8075249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 80765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8077b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 807883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 80795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 80805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 80815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 808389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 808489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 808589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 808683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8088b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8089593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 80909f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8091249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 8092249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 8093249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 8094b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdResolveImage()"); 8095b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdResolveImage()"); 8096249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 8097c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 8098c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 8099e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8100f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdResolveImage()"); 8101593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 81029f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8103593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8104f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 8105e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 81065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 81079f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8108593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 810983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 8110b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdResolveImage()"); 8111249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8112249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 81135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8114b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 811583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 81175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 81185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8120b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8121b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8122b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8123b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8124b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8125b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8126b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8127b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8128b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8129b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8130b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8131b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8132b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 813389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 813489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 813583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 81365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8137b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 814083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 814183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 8142ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 8143ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8144ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8145ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 8146ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8147ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 81485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8149c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8150c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8151c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8152b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8153b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8154b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 81555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8156b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 815783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 816189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 816289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 816383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 81645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8165b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 816883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 816983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 8170ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 8171ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8172ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8173ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 8174ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8175ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 81765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8177c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8178c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8179c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8180b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8181b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8182b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 81835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8184b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 818583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 81875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8189e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8190e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 81915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 81925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 8193e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 81955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 81965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 81985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 81995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 82005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 82015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 82025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 82035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 82045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 82065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 82075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 82085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 82095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 82105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 82115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 821208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 821308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 82145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 82155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 82175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 82185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 82195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 82205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 82235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 82255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 82295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 8232e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 82335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 82345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 82375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 82385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 82405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 82415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 82425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 82435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 82445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 82535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 8254e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8255e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 8256e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 8257e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 82585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 826043986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 82625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 82635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8264577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 82696044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 82715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 82725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 82735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 82745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 82755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 82775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 82785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 82795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 82805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 82815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82826044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 82865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 82915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8293e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8294e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 8295e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 82975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 82985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 82995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 83005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 83035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 83045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 83055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 83085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 83095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 83135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 83165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 83175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 83185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 83215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 83225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 83265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 83305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 83315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 83325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8334577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 83355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 83365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 83405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 83415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8345e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8346e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 8347e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 8348e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 8349e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 83515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 83525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 8353ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 83575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 83626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 83636d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 83655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 83666d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 83695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 83705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 83745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 83755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 83765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 83805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 83815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 83835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 83895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 8391b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 8392b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 83935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 83955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 83975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 83985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 8400b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 84085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 84105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84166d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 84171d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 84181d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 84195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 84206d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 84216d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis format = image_data->createInfo.format; 84226d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis arrayLayers = image_data->createInfo.arrayLayers; 84236d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis mipLevels = image_data->createInfo.mipLevels; 84245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 84255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 8426170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); 8427170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (imageswap_data) { 8428b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); 8429b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 8430b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis format = swapchain_data->createInfo.imageFormat; 8431b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis arrayLayers = swapchain_data->createInfo.imageArrayLayers; 84325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 84335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 84345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 8438c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis auto aspect_mask = mem_barrier->subresourceRange.aspectMask; 8439c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (vk_format_is_depth_or_stencil(format)) { 8440c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (vk_format_is_depth_and_stencil(format)) { 8441c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) && !(aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 8442c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8443c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", 8444c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "%s: Image is a depth and stencil format and thus must " 8445c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have either one or both of VK_IMAGE_ASPECT_DEPTH_BIT and " 8446c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 8447c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8448c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8449c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else if (vk_format_is_depth_only(format)) { 8450c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT)) { 8451c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8452c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth-only format and thus must " 8453c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_DEPTH_BIT set.", 8454c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8455c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8456c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else { // stencil-only case 8457a968f468c0aafdf33b7af68fb8e7961e37e32f7fTobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 8458c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8459c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a stencil-only format and thus must " 8460c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_STENCIL_BIT set.", 8461c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8462c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8463c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8464c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else { // image is a color format 8465c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT)) { 8466c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8467c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a color format and thus must " 8468c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_COLOR_BIT set.", 8469c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8470c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 84715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8472f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 8473f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8474f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 8475f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 84765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 84785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 84795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 84805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 84815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 84825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8483f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 8484f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8485f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 8486f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 84875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 84895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 84995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 85005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 85065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 85085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8509b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 85105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8511b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 85145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 85155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 85165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 8517b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 85185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85208718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, mem_barrier->buffer); 85218718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 85220c6dd4dd7c7e444efc979299f8f445fb4fc4febeChris Forbes auto buffer_size = buffer_node->memSize; 85235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 852494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 852594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 852694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 8527414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ".", 852894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 852994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 85305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 853194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 853294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8533414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 8534414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 853594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 853694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 853794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 85425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85442ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 8545b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 8546b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 8547b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 8548b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 85492ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 8550b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8551b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 8552b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 85532ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 8554b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 8555b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 8556b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 85579556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto global_event_data = getEventNode(dev_data, event); 85589556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (!global_event_data) { 8559b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 856027c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 856127c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 85622ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 8563b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 85649556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis stageMask |= global_event_data->stageMask; 8565b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8566b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8567b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8568c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // TODO: Need to validate that host_bit is only set if set event is called 8569c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // but set event can be called at any time. 8570c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { 8571c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8572c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine DRAWSTATE_INVALID_EVENT, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " 85734261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "using srcStageMask 0x%X which must be the bitwise " 8574c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "OR of the stageMask parameters used in calls to " 8575c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " 85764261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "used with vkSetEvent but instead is 0x%X.", 8577c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine sourceStageMask, stageMask); 8578b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8579b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 8580b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8581b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 858289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 858389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 858489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 858589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 858689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 858783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 85885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8589b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 85905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85922ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 85935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 8594ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, pEvents[i]); 8595ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8596ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8597ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<const uint64_t &>(pEvents[i]), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, 8598ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis pCB); 8599ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8600ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 8601c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->waitedEvents.insert(pEvents[i]); 86025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 86035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8604b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 86052ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 8606b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 860883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 86095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 861083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 861283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 861383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 86145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8617b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 861883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 86205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 862489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 862589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 862689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 862789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 862889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 862983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 86305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8631b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 863483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 863583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 863683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8640b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 864183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8647d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { 8648d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8649d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8650d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (pCB) { 8651d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryToStateMap[object] = value; 8652d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8653d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 8654d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data != dev_data->queueMap.end()) { 8655d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[object] = value; 8656d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8657d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 8658d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8659d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 866089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 866189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 866283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8664b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 86685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 86705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 86715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 867283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 8673ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8674ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 86755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8676b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 867783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 86785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 86795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 868189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 868283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 86835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8684b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 86885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 868983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 86905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8691414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 86925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 86935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 86955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8696c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 8697d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 86985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 869983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 87005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 870183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 87025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8703ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8704ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 87055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8706b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 870783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 87085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 87095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 871189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 871289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 871383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 87145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8715b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 87165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 87195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 87205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 8721c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); 8722d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 87235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 872583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 87265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 872783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 87285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 872983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 8730ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8731ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 87325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8733b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 873483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 87355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 87365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8738d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { 8739d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool skip_call = false; 8740d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 8741d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 8742d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data == dev_data->queueMap.end()) 8743d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 8744d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (uint32_t i = 0; i < queryCount; i++) { 8745d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine QueryObject query = {queryPool, firstQuery + i}; 8746d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto query_data = queue_data->second.queryToStateMap.find(query); 8747d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool fail = false; 8748d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (query_data != queue_data->second.queryToStateMap.end()) { 8749d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!query_data->second) { 8750d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8751d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8752d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8753d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto global_query_data = dev_data->queryToStateMap.find(query); 8754d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (global_query_data != dev_data->queryToStateMap.end()) { 8755d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!global_query_data->second) { 8756d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8757d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8758d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8759d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8760d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8761d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8762d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (fail) { 8763d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8764d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine DRAWSTATE_INVALID_QUERY, "DS", 8765d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 8766d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); 8767d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8768d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8769d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return skip_call; 8770d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8771d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 877289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 877389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 877489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 877583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8777b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8778ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 87799f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8780ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8781ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8782b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyQueryPoolResults()"); 8783ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8784c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8785ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 878659b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8787ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8788e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8789f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8790e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 87929f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8793d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::function<bool(VkQueue)> queryUpdate = 8794ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::bind(validateQuery, std::placeholders::_1, cb_node, queryPool, queryCount, firstQuery); 8795ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->queryUpdates.push_back(queryUpdate); 8796ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node->state == CB_RECORDING) { 8797ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 879983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 88005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8801b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyQueryPoolResults()"); 8802ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8803ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, cb_node); 8804ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8805ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 88065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8807b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 880883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 88095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 88105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 88115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 881389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 881489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 881589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 881683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8818b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 88195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 88215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 882283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 882483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 882783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 88289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 882983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 883083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 88319e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 88329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 8833a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 88344a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(dev_data, layout); 883515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 883615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // contained in the pipeline ranges. 883715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Build a {start, end} span list for ranges with matching stage flags. 883815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis const auto &ranges = pipeline_layout->push_constant_ranges; 883915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct span { 884015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t start; 884115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t end; 884215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis }; 884315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span> spans; 884415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.reserve(ranges.size()); 884515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (const auto &iter : ranges) { 884615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (iter.stageFlags == stageFlags) { 884715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.push_back({iter.offset, iter.offset + iter.size}); 884815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 884915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 885015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (spans.size() == 0) { 885115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There were no ranges that matched the stageFlags. 885215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 885315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 885415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 885515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 885615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis (uint32_t)stageFlags, (uint64_t)layout); 88579e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 885815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Sort span list by start value. 885915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct comparer { 886015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool operator()(struct span i, struct span j) { return i.start < j.start; } 886115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } my_comparer; 886215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::sort(spans.begin(), spans.end(), my_comparer); 886315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis 886415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Examine two spans at a time. 886515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator current = spans.begin(); 886615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator next = current + 1; 886715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis while (next != spans.end()) { 886815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (current->end < next->start) { 886915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There is a gap; cannot coalesce. Move to the next two spans. 887015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++current; 887115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++next; 887215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } else { 887315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce the two spans. The start of the next span 887415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // is within the current span, so pick the larger of 887515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // the end values to extend the current span. 887615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Then delete the next span and set next to the span after it. 887715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis current->end = max(current->end, next->end); 887815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis next = spans.erase(next); 88799e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 88809e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 8881a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 888215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Now we can check if the incoming range is within any of the spans. 888315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool contained_in_a_range = false; 888415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (uint32_t i = 0; i < spans.size(); ++i) { 888515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 888615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis contained_in_a_range = true; 888715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis break; 8888a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 88899e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 889015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (!contained_in_a_range) { 889115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 889215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 889315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Push constant range [%d, %d) " 889415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "with stageFlags = 0x%" PRIx32 " " 889515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 889615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 889715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8899b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 890083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 890489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 890589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 890683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8908b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 8912c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 8913d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 891583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 89165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 891783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 89185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8920b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 892183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89256600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinskistatic bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, 89266600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag) { 89276600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 89286600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 89296600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t attach = 0; attach < count; attach++) { 89306600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { 89316600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Attachment counts are verified elsewhere, but prevent an invalid access 89326600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment < fbci->attachmentCount) { 89336600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; 89346600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VkImageViewCreateInfo *ivci = getImageViewData(dev_data, *image_view); 89356600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ivci != nullptr) { 89366600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageCreateInfo *ici = &getImageNode(dev_data, ivci->image)->createInfo; 89376600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ici != nullptr) { 89386600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if ((ici->usage & usage_flag) == 0) { 89396600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 89406600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_USAGE, "DS", 89416600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " 89426600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "IMAGE_USAGE flags (%s).", 89436600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag)); 89446600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 89456600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 89466600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 89476600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 89486600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 89496600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 89506600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 89516600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 89526600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 8953d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// Validate VkFramebufferCreateInfo which includes: 8954d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// 1. attachmentCount equals renderPass attachmentCount 89555ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 2. corresponding framebuffer and renderpass attachments have matching formats 89565ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 3. corresponding framebuffer and renderpass attachments have matching sample counts 89575ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 4. fb attachments only have a single mip level 89585ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 5. fb attachment dimensions are each at least as large as the fb 89595ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 6. fb attachments use idenity swizzle 89605ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 7. fb attachments used by renderPass for color/input/ds have correct usage bit set 89616fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis// 8. fb dimensions are within physical device limits 8962d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlisstatic bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 89636600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 89646600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 8965d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis auto rp_node = getRenderPass(dev_data, pCreateInfo->renderPass); 8966d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rp_node) { 8967d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis const VkRenderPassCreateInfo *rpci = rp_node->pCreateInfo; 8968d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rpci->attachmentCount != pCreateInfo->attachmentCount) { 8969d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= log_msg( 8970d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 8971d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 8972d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount of %u of " 8973d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "renderPass (0x%" PRIxLEAST64 ") being used to create Framebuffer.", 8974d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis pCreateInfo->attachmentCount, rpci->attachmentCount, reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 89755ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } else { 897641ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis // attachmentCounts match, so make sure corresponding attachment details line up 89775ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageView *image_views = pCreateInfo->pAttachments; 89785ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 89795ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis VkImageViewCreateInfo *ivci = getImageViewData(dev_data, image_views[i]); 89805ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ivci->format != rpci->pAttachments[i].format) { 89815ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis skip_call |= log_msg( 89825ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 89835ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 89845ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not match " 89855ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "the format of " 89865ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "%s used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 89875ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis i, string_VkFormat(ivci->format), string_VkFormat(rpci->pAttachments[i].format), 89885ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 89895ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 89905ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageCreateInfo *ici = &getImageNode(dev_data, ivci->image)->createInfo; 89915ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ici->samples != rpci->pAttachments[i].samples) { 899241ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis skip_call |= log_msg( 899341ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 899441ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 899541ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match " 899641ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "the %s samples used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 899741ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), 899841ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 89995ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 90005ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify that view only has a single mip level 90015ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ivci->subresourceRange.levelCount != 1) { 90026fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 90036fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis __LINE__, DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 90046fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u " 90056fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "but only a single mip level (levelCount == 1) is allowed when creating a Framebuffer.", 90066fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis i, ivci->subresourceRange.levelCount); 90075ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 90085ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const uint32_t mip_level = ivci->subresourceRange.baseMipLevel; 9009aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_width = max(1u, ici->extent.width >> mip_level); 9010aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_height = max(1u, ici->extent.height >> mip_level); 9011aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis if ((ivci->subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || 9012aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis (mip_height < pCreateInfo->height)) { 9013aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis skip_call |= 90146fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9015aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9016aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions smaller " 9017aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "than the corresponding " 9018aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "framebuffer dimensions. Attachment dimensions must be at least as large. Here are the respective " 9019aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "dimensions for " 9020aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "attachment #%u, framebuffer:\n" 9021aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "width: %u, %u\n" 9022aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "height: %u, %u\n" 9023aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "layerCount: %u, %u\n", 9024aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis i, ivci->subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, 9025aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis pCreateInfo->height, ivci->subresourceRange.layerCount, pCreateInfo->layers); 90265ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 9027aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis if (((ivci->components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.r != VK_COMPONENT_SWIZZLE_R)) || 9028aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis ((ivci->components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.g != VK_COMPONENT_SWIZZLE_G)) || 9029aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis ((ivci->components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.b != VK_COMPONENT_SWIZZLE_B)) || 9030aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis ((ivci->components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.a != VK_COMPONENT_SWIZZLE_A))) { 9031da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis skip_call |= log_msg( 90326fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9033da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9034da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All framebuffer " 9035da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "attachments must have been created with the identity swizzle. Here are the actual swizzle values:\n" 9036da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "r swizzle = %s\n" 9037da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "g swizzle = %s\n" 9038da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "b swizzle = %s\n" 9039da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "a swizzle = %s\n", 9040da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis i, string_VkComponentSwizzle(ivci->components.r), string_VkComponentSwizzle(ivci->components.g), 9041da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis string_VkComponentSwizzle(ivci->components.b), string_VkComponentSwizzle(ivci->components.a)); 90425ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 90435ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 9044d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } 90455ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify correct attachment usage flags 90466600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { 90476600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify input attachments: 90486600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, 90496600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pInputAttachments, pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT); 90506600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify color attachments: 90516600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, 90526600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pColorAttachments, pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); 90536600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify depth/stencil attachments: 90546600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { 90556600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, 90566600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); 90576600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 90586600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 9059d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } else { 9060d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= 9061d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 9062d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9063d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): Attempt to create framebuffer with invalid renderPass (0x%" PRIxLEAST64 ").", 9064d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 90656600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 90666fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis // Verify FB dimensions are within physical device limits 90676fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis if ((pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) || 90686fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) || 90696fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers)) { 90706fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 90716fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 90726fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo dimensions exceed physical device limits. " 90736fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "Here are the respective dimensions: requested, device max:\n" 90746fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "width: %u, %u\n" 90756fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "height: %u, %u\n" 90766fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "layerCount: %u, %u\n", 90776fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, 90786fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, 90796fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers); 90806fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis } 90816600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 90826600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 90836600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 908464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object 908564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Return true if an error is encountered and callback returns true to skip call down chain 908664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// false indicates that call down chain should proceed 908764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlisstatic bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 908864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis // TODO : Verify that renderPass FB is created with is compatible with FB 908964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = false; 9090d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); 909164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return skip_call; 909264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis} 909364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 909454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis// CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object 909554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlisstatic void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { 909654e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis // Shadow create info and store in map 909776f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis std::unique_ptr<FRAMEBUFFER_NODE> fb_node( 9098d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis new FRAMEBUFFER_NODE(fb, pCreateInfo, dev_data->renderPassMap[pCreateInfo->renderPass]->pCreateInfo)); 909976f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis 910054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 910154e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 910254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis auto view_data = getImageViewData(dev_data, view); 910354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis if (!view_data) { 910454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis continue; 910554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 910654e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 9107249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis fb_info.mem = getImageNode(dev_data, view_data->image)->mem; 910854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis fb_info.image = view_data->image; 910976f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis fb_node->attachments.push_back(fb_info); 911054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 911176f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis dev_data->frameBufferMap[fb] = std::move(fb_node); 911254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis} 911354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis 911489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 911589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 911689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 91175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 911864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 911964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); 912064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.unlock(); 912164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 912264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis if (skip_call) 912364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 912464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 912564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 91266600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 91275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 912864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.lock(); 912954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); 913054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis lock.unlock(); 91315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 91335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9135e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 9136e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 91375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 91385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 9139e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 91405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 91435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 91445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 91455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 9146e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 91475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 9149e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 91505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9151e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 91525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9154e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 9155e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 9156e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 91575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 91591d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 91605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 91615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 91625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 91635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 91667655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen // If no dependency exits an implicit dependency still might. If not, throw an error. 91675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 91687655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 91697655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { 91705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 91715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 91735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 9174e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 91755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 91795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9181e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 9182e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 91835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 91845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 91855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 91875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 9188e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 91895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 91915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 9192e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 91935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9194e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 91955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 91965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 91975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 91985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 92005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 92015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 9202e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 92035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 92045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 9205e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 92065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 92075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9209e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 92115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 92135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 92145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 92175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 92205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 92215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 92225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 92255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 92265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 92275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9229f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic bool ValidateDependencies(const layer_data *my_data, FRAMEBUFFER_NODE const * framebuffer, 923016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes RENDER_PASS_NODE const * renderPass) { 9231e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 923204861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = &framebuffer->createInfo; 923316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pCreateInfo = renderPass->pCreateInfo; 923416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto const & subpass_to_node = renderPass->subpassToNode; 92355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 92375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 92385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 92395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 92405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 92415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 92425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 92435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 92455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 92465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92482c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto view_data_i = getImageViewData(my_data, viewi); 92492c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto view_data_j = getImageViewData(my_data, viewj); 92502c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (!view_data_i || !view_data_j) { 92515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 92525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92532c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (view_data_i->image == view_data_j->image && 92542c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis isRegionOverlapping(view_data_i->subresourceRange, view_data_j->subresourceRange)) { 92555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 92565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 92575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 92585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92596d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data_i = getImageNode(my_data, view_data_i->image); 92606d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data_j = getImageNode(my_data, view_data_j->image); 92616d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!image_data_i || !image_data_j) { 92625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 92635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data_i->mem == image_data_j->mem && isRangeOverlapping(image_data_i->memOffset, image_data_i->memSize, 92656d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_data_j->memOffset, image_data_j->memSize)) { 92665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 92675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 92685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 92725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 92735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 92745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 92755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 92765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 92785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 92795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 92805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 92825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 92835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 92855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 92865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 92875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 92911c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 92925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 92935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 92941c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 92955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 92965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 929793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 929893fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 92995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 93005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 93015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 93055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 930693fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 930793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 93085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 93095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93121c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 93135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 93175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93201c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 93211c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 93221c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 93231c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 93241c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 93251c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 93261c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 93271c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 933593fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pInputAttachments[j].attachment; 933693fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 933793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 934293fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pColorAttachments[j].attachment; 934393fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 934493fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 93495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 93515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 93585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 93595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9364be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 9365be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 9366be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 9367be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 9368be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 9369be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 9370be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 9371be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 9372be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 9373be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 9374be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 9375be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 9376be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 9377be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9378be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 9379be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 9380be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 9381be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 9382be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 93835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9384e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 9385e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 938777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis // Track when we're observing the first use of an attachment 938877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis std::vector<bool> attach_first_use(pCreateInfo->attachmentCount, true); 93895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 93920ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes auto attach_index = subpass.pColorAttachments[j].attachment; 93930ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes if (attach_index == VK_ATTACHMENT_UNUSED) 93940ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes continue; 93950ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes 9396c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pColorAttachments[j].layout) { 9397c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 9398c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* This is ideal. */ 9399c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9400c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9401c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9402c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 9403c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints? 9404c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 9405c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 9406c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9407c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9408c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 9409c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9410c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9411c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 9412c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 9413c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9414c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9415c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 9416c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pColorAttachments[j].layout)); 94175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9418c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 941977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 942077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pColorAttachments[j].layout, 942177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 942277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 942377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 94245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9425c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 9426cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes switch (subpass.pDepthStencilAttachment->layout) { 9427cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 9428cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 9429cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* These are ideal. */ 9430cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 9431cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9432cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9433cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 9434cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * other constraints? GENERAL can be better than doing a bunch 9435cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * of transitions. 9436cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes */ 9437cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 9438cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 94395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9440cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "GENERAL layout for depth attachment may not give optimal performance."); 9441cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 9442cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9443cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes default: 9444cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* No other layouts are acceptable */ 9445cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 9446cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9447cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9448cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL, " 9449cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "DEPTH_STENCIL_READ_ONLY_OPTIMAL or GENERAL.", 94505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 94515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9452cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9453be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 945477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 945577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pDepthStencilAttachment->layout, 945677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 945777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 945877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 945977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 946077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 946177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 946277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_index == VK_ATTACHMENT_UNUSED) 946377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis continue; 946477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis 9465c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pInputAttachments[j].layout) { 9466c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 9467c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: 9468c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* These are ideal. */ 9469c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9470c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9471c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9472c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal. TODO: reconsider this warning based on 9473c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints. 9474c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 9475c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 9476c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9477c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9478c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 9479c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9480c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9481c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 9482c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* No other layouts are acceptable */ 9483c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9484c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9485c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 9486c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pInputAttachments[j].layout)); 948777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 9488c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 948977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 949077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pInputAttachments[j].layout, 949177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 949277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 949377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 94945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9499e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 9500e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 9501e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 95035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 95045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 95055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 95095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 95105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 95125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 95135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 95145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 95165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 95175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 95185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 95215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 95235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 95275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9528918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 95295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 953089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 953189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 953289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9534e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9535b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9536b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 9537b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 9538b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 9539b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 9540b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9541b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 9542b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 9543b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes skip_call |= log_msg(my_data->report_data, 9544b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 9545b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes VkDebugReportObjectTypeEXT(0), 0, 9546b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", "SPIR-V module not valid: %s", 9547b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes diag && diag->error ? diag->error : "(no error text)"); 95485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9550b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 9551b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 9552b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9553e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 95545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 95555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 9559b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 9560918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 95615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 95635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95654f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { 95664f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 95674f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { 95684f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95694f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 95704f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: %s attachment %d cannot be greater than the total number of attachments %d.", 95714f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski type, attachment, attachment_count); 95724f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 95734f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 95744f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 95754f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 9576805ec497391f6bc513f7653ba6d535c509b54062Chris Forbesstatic bool IsPowerOfTwo(unsigned x) { 9577805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes return x && !(x & (x-1)); 9578805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes} 9579805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 95804f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { 95814f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 95824f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 95834f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 95844f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 95854f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= 95864f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_RENDERPASS, "DS", 95884f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 95894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 95904f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 95914f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pPreserveAttachments[j]; 95924f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment == VK_ATTACHMENT_UNUSED) { 95934f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 95944f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski __LINE__, DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 95954f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED.", j); 95964f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } else { 95974f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); 95984f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 95994f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 96006a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 96016a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes auto subpass_performs_resolve = subpass.pResolveAttachments && std::any_of( 96026a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes subpass.pResolveAttachments, subpass.pResolveAttachments + subpass.colorAttachmentCount, 96036a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes [](VkAttachmentReference ref) { return ref.attachment != VK_ATTACHMENT_UNUSED; }); 96046a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 9605805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes unsigned sample_count = 0; 9606805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 96074f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 96084f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment; 96094f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pResolveAttachments) { 96104f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pResolveAttachments[j].attachment; 96114f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); 96126a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 96136a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED && 96146a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes pCreateInfo->pAttachments[attachment].samples != VK_SAMPLE_COUNT_1_BIT) { 96156a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 96166a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 96176a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "CreateRenderPass: Subpass %u requests multisample resolve into attachment %u, " 96186a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "which must have VK_SAMPLE_COUNT_1_BIT but has %s", 96196a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes i, attachment, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples)); 96206a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 96214f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 96224f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pColorAttachments[j].attachment; 96234f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); 96246a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 9625805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 9626805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 9627805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9628dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes if (subpass_performs_resolve && 9629dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes pCreateInfo->pAttachments[attachment].samples == VK_SAMPLE_COUNT_1_BIT) { 9630dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 9631dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9632dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u " 9633dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "which has VK_SAMPLE_COUNT_1_BIT", 9634dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes i, attachment); 9635dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes } 96366a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 96374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9638dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 96394f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 96404f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 96414f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); 9642805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9643805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 9644805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 9645805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 96464f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9647dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 96484f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 96494f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pInputAttachments[j].attachment; 96504f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); 96514f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9652805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9653805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (sample_count && !IsPowerOfTwo(sample_count)) { 9654805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 9655805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9656805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "CreateRenderPass: Subpass %u attempts to render to " 9657805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "attachments with inconsistent sample counts", 9658805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes i); 9659805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 96604f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 96614f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 96624f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 96634f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 966489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 96654f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { 9666e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 96684f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 96694f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::unique_lock<std::mutex> lock(global_lock); 96704f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 96714f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 96724f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with 96734f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // ValidateLayouts. 96744f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); 9675ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes lock.unlock(); 96764f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 96774f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (skip_call) { 96784f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 96794f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 96804f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 9681ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 9682ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes 96835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 96844f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski lock.lock(); 96854f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 96864f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 96874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 96884f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 96894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 96945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 96955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 96965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 96985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 96995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 97005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 97025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 97035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 97045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 97055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 97105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 97115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 97135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 97155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 97175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 97185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 97205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 97235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 97245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 97255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 97265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 97295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 97335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 97345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9737cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes 9738cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes auto render_pass = new RENDER_PASS_NODE(localRPCI); 973998cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 9740cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 9741cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 974287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 974387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 974487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 974587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 974687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 974787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 974887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 97491a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_load_op = desc.stencilLoadOp; 97501a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_store_op = desc.stencilStoreOp; 975187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 9752cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->attachments.push_back(pass_info); 975387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 975487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 9755cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 97566600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; 975787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 975887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 975987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 97604f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pColorAttachments[j].attachment; 97614f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 97624f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 97634f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 97640d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 976587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 976687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 976787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 97684f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 97694f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 97704f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 977124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 977287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 9773a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 9774a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 97754f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 97764f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, true)); 97774f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 977824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 9779a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 978087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 978187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 97824f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski dev_data->renderPassMap[*pRenderPass] = render_pass; 97835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97864f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 97885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 97897bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes for (auto renderPass : my_data->renderPassMap) { 97907bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass.second->pCreateInfo; 97915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 97945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 97955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 97965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 98095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 98107bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes delete renderPass.second; 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 98135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9815e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbesstatic bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 9816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 981804861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]->createInfo; 98195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 98205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 98235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 98262c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto image_data = getImageViewData(dev_data, image_view); 98272c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis assert(image_data); 98282c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImage &image = image_data->image; 98292c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->subresourceRange; 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 98365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 98375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 98385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 98395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9843c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes if (newNode.layout != VK_IMAGE_LAYOUT_UNDEFINED && 9844c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes newNode.layout != node.layout) { 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9847c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", 9848c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "You cannot start a render pass using attachment %u " 9849c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "where the render pass initial layout is %s and the previous " 9850c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "known layout of the attachment is %s. The layouts must match, or " 9851c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "the render pass initial layout for the attachment must be " 9852c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "VK_IMAGE_LAYOUT_UNDEFINED", 98531c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9861628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbesstatic void TransitionAttachmentRefLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, 9862628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes FRAMEBUFFER_NODE *pFramebuffer, 9863628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes VkAttachmentReference ref) 9864628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes{ 9865628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (ref.attachment != VK_ATTACHMENT_UNUSED) { 9866628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = pFramebuffer->createInfo.pAttachments[ref.attachment]; 9867628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes SetLayout(dev_data, pCB, image_view, ref.layout); 9868628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes } 9869628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes} 9870628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes 987127ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbesstatic void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, 9872e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 987316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 987416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 987616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 9877e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 9878e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 98795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9880e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 988116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkSubpassDescription &subpass = renderPass->pCreateInfo->pSubpasses[subpass_index]; 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 9883628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pInputAttachments[j]); 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 9886628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pColorAttachments[j]); 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9888628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (subpass.pDepthStencilAttachment) { 9889628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, *subpass.pDepthStencilAttachment); 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9893e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 9894e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 98995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 99015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9903f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 990416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 990516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 99065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 990716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 990816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->pCreateInfo; 9909e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 9910e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 99115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9912e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 9914628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = framebuffer->createInfo.pAttachments[i]; 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9919e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 9920885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 992104861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = &getFramebuffer(my_data, pRenderPassBegin->framebuffer)->createInfo; 9922885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 9923885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 9924885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 9925885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 9926885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 9927885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9928885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 9929885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 9930885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 9931885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 9932885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 9933885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 9934885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 9935885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 9936885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 9937885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 99381a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the 99391a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// [load|store]Op flag must be checked 99401a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. 99411a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinskitemplate <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { 9942a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski if (color_depth_op != op && stencil_op != op) { 9943a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return false; 9944a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski } 99451a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_color_depth_load_op = !vk_format_is_stencil_only(format); 99461a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; 9947a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski 9948a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return (((check_color_depth_load_op == true) && (color_depth_op == op)) || 9949a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski ((check_stencil_load_op == true) && (stencil_op == op))); 99501a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski} 99511a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski 995289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 995389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 995483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9956b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 995816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = pRenderPassBegin ? getRenderPass(dev_data, pRenderPassBegin->renderPass) : nullptr; 9959f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = pRenderPassBegin ? getFramebuffer(dev_data, pRenderPassBegin->framebuffer) : nullptr; 99605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 996116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 99626de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis uint32_t clear_op_size = 0; // Make sure pClearValues is at least as large as last LOAD_OP_CLEAR 996316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeFramebuffer = pRenderPassBegin->framebuffer; 996416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes for (size_t i = 0; i < renderPass->attachments.size(); ++i) { 9965f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 99661a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = renderPass->pCreateInfo->pAttachments[renderPass->attachments[i].attachment].format; 99671a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 99681a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 99691a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_CLEAR)) { 997092bc0680357019834b7529148ab6d73353ce02c7Mark Lobodzinski clear_op_size = static_cast<uint32_t>(i) + 1; 997116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 9972f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), true); 997316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 997416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 997516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 99761a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 99771a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 99781a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { 997916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 9980f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), false); 998116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 998216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 998316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 99841a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 99851a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 99861a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_LOAD)) { 998716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 9988f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageNode(dev_data, fb_info.image), 9989f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 999016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 999116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 999216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 999316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass->attachment_first_read[renderPass->attachments[i].attachment]) { 999416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 9995f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageNode(dev_data, fb_info.image), 9996f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 999716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 999816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 99995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100016de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis if (clear_op_size > pRenderPassBegin->clearValueCount) { 100026de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis skip_call |= 100036de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 100046de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis reinterpret_cast<uint64_t &>(renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 100056de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but there must " 100066de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "be at least %u " 100076de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "entries in pClearValues array to account for the highest index attachment in renderPass 0x%" PRIx64 100086de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u. Note that the pClearValues array " 100096de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "is indexed by attachment number so even if some pClearValues entries between 0 and %u correspond to " 100106de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "attachments that aren't cleared they will be ignored.", 100116de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), 100126de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis clear_op_size, clear_op_size - 1); 100133d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis } 1001483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 1001583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= VerifyFramebufferAndRenderPassLayouts(dev_data, pCB, pRenderPassBegin); 1001683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 1001783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateDependencies(dev_data, framebuffer, renderPass); 1001883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 1001983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 100208168af0c4c5b12708d5ddbeb6ce513207d01f0e4Chris Forbes pCB->activeRenderPass = renderPass; 100215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 100225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 100235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 100245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 1002593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.insert(pRenderPassBegin->framebuffer); 100265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 10027b6fe8da9537ef985960fd1d32b83c952b422f00bTobin Ehlis framebuffer->cb_bindings.insert(pCB); 10028ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes 10029ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes // transition attachments to the correct layouts for the first subpass 10030ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 100315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1003283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 1003383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 1003483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10037b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1003883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 100395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 100405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1004389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 1004483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 100455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10046b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 100475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 100485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 1004983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 1005083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 100515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 100525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 1005327ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 1005483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 100555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10056b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1005783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 100585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 100595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1006189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 1006283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 100635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10064b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1006558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes auto pCB = getCBNode(dev_data, commandBuffer); 1006658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes if (pCB) { 1006758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes RENDER_PASS_NODE* pRPNode = pCB->activeRenderPass; 10068e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pCB->activeFramebuffer); 10069ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (pRPNode) { 1007087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 10071e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 100721a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = pRPNode->pCreateInfo->pAttachments[pRPNode->attachments[i].attachment].format; 100731a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 100741a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, VK_ATTACHMENT_STORE_OP_STORE)) { 1007558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 10076f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), true); 1007758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1007858c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1007958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 100801a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 100811a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, 100821a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_STORE_OP_DONT_CARE)) { 1008358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 10084f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), false); 1008558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1008658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1008758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 100885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1009183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 1009283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 1009383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 10094f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); 1009558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeRenderPass = nullptr; 1009658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeSubpass = 0; 1009758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeFramebuffer = VK_NULL_HANDLE; 100985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10099b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1010083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 101015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 101025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10104a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, uint32_t primaryAttach, 10105a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis uint32_t secondaryAttach, const char *msg) { 101065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 101075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10108a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Secondary Cmd Buffer 0x%" PRIx64 " which has a render pass " 10109a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "that is not compatible with the Primary Cmd Buffer current render pass. " 10110a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Attachment %u is not compatible with %u: %s", 10111a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), primaryAttach, secondaryAttach, msg); 101125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10114a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10115a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, uint32_t primaryAttach, 10116a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkCommandBuffer secondaryBuffer, VkRenderPassCreateInfo const *secondaryPassCI, 10117e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 101185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10119a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->attachmentCount <= primaryAttach) { 101205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 101215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10122a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (secondaryPassCI->attachmentCount <= secondaryAttach) { 101235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 101245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 101265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 101275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 10129a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10130a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The first is unused while the second is not."); 101315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 101325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 10134a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10135a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The second is unused while the first is not."); 101365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 101375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10138a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].format != secondaryPassCI->pAttachments[secondaryAttach].format) { 10139a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10140a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different formats."); 101415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10142a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].samples != secondaryPassCI->pAttachments[secondaryAttach].samples) { 10143a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10144a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different samples."); 101455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10146a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (is_multi && primaryPassCI->pAttachments[primaryAttach].flags != secondaryPassCI->pAttachments[secondaryAttach].flags) { 10147a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10148a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different flags."); 101495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 101515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10153a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10154a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10155a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI, const int subpass, bool is_multi) { 101565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10157a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &primary_desc = primaryPassCI->pSubpasses[subpass]; 10158a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &secondary_desc = secondaryPassCI->pSubpasses[subpass]; 101595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 101605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 101615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 101625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 101635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 101645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 101665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 101675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10168a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_input_attach, secondaryBuffer, 10169a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_input_attach, is_multi); 101705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 101725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 101735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 101745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 101755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 101765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 101785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 101795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10180a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_color_attach, secondaryBuffer, 10181a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_color_attach, is_multi); 101825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 101835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 101845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 101855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 101875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 101885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10189a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_resolve_attach, 10190a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_resolve_attach, is_multi); 101915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 101935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 101945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 101955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 101975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 101985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10199a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_depthstencil_attach, 10200a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_depthstencil_attach, is_multi); 102015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 102025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10204a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// Verify that given renderPass CreateInfo for primary and secondary command buffers are compatible. 10205a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// This function deals directly with the CreateInfo, there are overloaded versions below that can take the renderPass handle and 10206a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// will then feed into this function 10207a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10208a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10209a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI) { 102105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10211a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis 10212a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->subpassCount != secondaryPassCI->subpassCount) { 102135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 102145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10215a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 10216a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u that is incompatible with the primary Cmd Buffer 0x%" PRIx64 10217a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u.", 10218a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), secondaryPassCI->subpassCount, 10219a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(primaryBuffer), primaryPassCI->subpassCount); 10220a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } else { 10221a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis for (uint32_t i = 0; i < primaryPassCI->subpassCount; ++i) { 10222a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primaryPassCI, secondaryBuffer, secondaryPassCI, i, 10223a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis primaryPassCI->subpassCount > 1); 10224a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 102255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 102275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10229e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 10230e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 102315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 102325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 102335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 102345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10235c5b97dda856ff837638b3ebb7e231d5507c495a3Chris Forbes VkFramebuffer primary_fb = pCB->activeFramebuffer; 102365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 102375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 102385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 102395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 102401af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 102411af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 102421af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis " which has a framebuffer 0x%" PRIx64 102431af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis " that is not the same as the primaryCB's current active framebuffer 0x%" PRIx64 ".", 102441af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), reinterpret_cast<uint64_t &>(secondary_fb), 102451af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(primary_fb)); 102465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10247e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto fb = getFramebuffer(dev_data, secondary_fb); 10248e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!fb) { 102495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 102505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10251414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10252414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 102535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 102545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 102555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10256a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis auto cb_renderpass = getRenderPass(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 10257a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (cb_renderpass->renderPass != fb->createInfo.renderPass) { 10258a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->renderPassCreateInfo.ptr(), secondaryBuffer, 10259a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis cb_renderpass->pCreateInfo); 10260a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 102615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 102635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10265e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 1026683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 102675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 102685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 102695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 102705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 102715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 102725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 102735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 102745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 1027583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 102765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 102775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10278414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10279414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 102805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 102815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 102825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 102855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 102885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 102895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 1029083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 102915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 102925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10293414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10294414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 10295414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 102965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 102975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 102985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103007bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 103017bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto primary_pool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 103027bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto secondary_pool = getCommandPoolNode(dev_data, pSubCB->createInfo.commandPool); 103037bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (primary_pool && secondary_pool && (primary_pool->queueFamilyIndex != secondary_pool->queueFamilyIndex)) { 103047bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 103057bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 103067bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkCmdExecuteCommands(): Primary command buffer 0x%" PRIxLEAST64 103077bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d has secondary command buffer 0x%" PRIxLEAST64 " created in queue family %d.", 103087bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), primary_pool->queueFamilyIndex, 103097bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), secondary_pool->queueFamilyIndex); 103107bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 103117bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 1031283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 103135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1031589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1031689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 1031783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 103185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10319b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 103205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 103215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 103225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 103235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 103245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 103255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 1032683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 103275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 103285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10329414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 103305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 103315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 1033283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 1033383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 1033483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 1033583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 1033683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (void *)pCommandBuffers[i], i); 103375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 10338a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis auto secondary_rp_node = getRenderPass(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 103395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 1034083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 103415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 103425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 10343414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 103445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 10345ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 103465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 103475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 10348a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (pCB->activeRenderPass->renderPass != secondary_rp_node->renderPass) { 1034983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->pCreateInfo, 10350a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis pCommandBuffers[i], secondary_rp_node->pCreateInfo); 10351a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 103521af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match active FB from primaryCB 1035383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 103545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 103561af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // secondaryCB must have been created w/ RP compatible w/ primaryCB active renderpass 10357a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != secondary_rp_node->renderPass) && 10358a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->pCreateInfo, secondary_rp_node->pCreateInfo, 10359a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis errorString)) { 1036083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 103615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 103625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 10363414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 10364414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 103655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 10366ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 103675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 1037083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 1037183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pSubCB); 103725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 103735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 103745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 103755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 1037683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 103775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 103785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10379414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to simultaneously execute CB 0x%" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 103805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 103815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 103825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 103845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 1038583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 103865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 103875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10388414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 103895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 10390414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 1039183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "set, even though it does.", 103925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 103935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 103945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10396b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 1039783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 103985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 103995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 104005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 10401414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 104025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 104035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 104045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 104055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 104075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 104085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 10409d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine for (auto &function : pSubCB->queryUpdates) { 10410d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine pCB->queryUpdates.push_back(function); 10411d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine } 104125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1041383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 1041483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 104155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10416b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1041783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 104195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10421b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis// For any image objects that overlap mapped memory, verify that their layouts are PREINIT or GENERAL 10422cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool ValidateMapImageLayouts(VkDevice device, DEVICE_MEM_INFO const *mem_info, VkDeviceSize offset, 10423623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis VkDeviceSize end_offset) { 10424e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 104255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10426cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // Iterate over all bound image ranges and verify that for any that overlap the 10427cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // map ranges, the layouts are VK_IMAGE_LAYOUT_PREINITIALIZED or VK_IMAGE_LAYOUT_GENERAL 10428cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : This can be optimized if we store ranges based on starting address and early exit when we pass our range 10429cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto image_handle : mem_info->bound_images) { 10430cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis auto img_it = mem_info->bound_ranges.find(image_handle); 10431cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (img_it != mem_info->bound_ranges.end()) { 10432623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis if (rangesIntersect(dev_data, &img_it->second, offset, end_offset)) { 10433b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis std::vector<VkImageLayout> layouts; 10434825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (FindLayouts(dev_data, VkImage(image_handle), layouts)) { 10435b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis for (auto layout : layouts) { 10436b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 10437b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis skip_call |= 10438b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 10439b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 10440b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 10441b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis string_VkImageLayout(layout)); 10442b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10443b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10444b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10445b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10446b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 104475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1045189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1045289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 104535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 104545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10455e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 104565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10457b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10458cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 10459cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (mem_info) { 10460f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis // TODO : This could me more fine-grained to track just region that is valid 10461f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis mem_info->global_valid = true; 10462623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis auto end_offset = (VK_WHOLE_SIZE == size) ? mem_info->alloc_info.allocationSize - 1 : offset + size - 1; 10463623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem_info, offset, end_offset); 10464cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : Do we need to create new "bound_range" for the mapped range? 10465623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis SetMemRangesValid(dev_data, mem_info, offset, end_offset); 10466cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[mem_info->alloc_info.memoryTypeIndex].propertyFlags & 10467b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 104685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 104695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 104705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 10471414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 104725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10474f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis skip_call |= ValidateMapMemRange(dev_data, mem, offset, size); 10475b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 104765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10477e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 104797c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis if (VK_SUCCESS == result) { 104807c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.lock(); 10481cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : What's the point of this range? See comment on creating new "bound_range" above, which may replace this 104827c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis storeMemRanges(dev_data, mem, offset, size); 104835f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski initializeAndTrackMemory(dev_data, mem, offset, size, ppData); 104847c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.unlock(); 104857c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis } 104865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1049089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 104915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1049283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 104935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10494b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1049583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= deleteMemRanges(my_data, mem); 10496b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1049783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 104985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 104995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10502e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 10503e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1050483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 105055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 1050657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 1050757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 10508de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.offset > pMemRanges[i].offset) { 1050983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 1051057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1051157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1051257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 1051357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 10514de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_info->mem_range.offset)); 105155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105164b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller 10517de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis const uint64_t my_dataTerminus = (mem_info->mem_range.size == VK_WHOLE_SIZE) 10518de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis ? mem_info->alloc_info.allocationSize 10519de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis : (mem_info->mem_range.offset + mem_info->mem_range.size); 105204b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller if (pMemRanges[i].size != VK_WHOLE_SIZE && (my_dataTerminus < (pMemRanges[i].offset + pMemRanges[i].size))) { 1052183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1052283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1052383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1052483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER ") exceeds the Memory Object's upper-bound " 1052583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 1052683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), static_cast<size_t>(my_dataTerminus)); 105275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1053083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 105315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105339e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinskistatic bool ValidateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 10534e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1053583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 105365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 1053757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 1053857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 105395f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 105405f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 105415f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 105425f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski : (mem_info->alloc_info.allocationSize - pMemRanges[i].offset); 105435f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 105445f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = 0; j < mem_info->shadow_pad_size; ++j) { 105455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1054683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1054783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1054883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 105495f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski "Memory underflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 105505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105525f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = (size + mem_info->shadow_pad_size); j < (2 * mem_info->shadow_pad_size + size); ++j) { 105535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1055483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1055583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1055683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1055783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 105585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105605f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(mem_info->p_driver_data, static_cast<void *>(data + mem_info->shadow_pad_size), (size_t)(size)); 105615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1056483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 105655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105675f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinskistatic void CopyNoncoherentMemoryFromDriver(layer_data *my_data, uint32_t memory_range_count, 105685f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski const VkMappedMemoryRange *mem_ranges) { 105699e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski for (uint32_t i = 0; i < memory_range_count; ++i) { 105709e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski auto mem_info = getMemObjInfo(my_data, mem_ranges[i].memory); 105715f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info && mem_info->shadow_copy) { 105725f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 105735f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 105745f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski : (mem_info->alloc_info.allocationSize - mem_ranges[i].offset); 105755f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 105765f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(data + mem_info->shadow_pad_size, mem_info->p_driver_data, (size_t)(size)); 105779e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 105789e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 105799e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski} 105809e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski 1058189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1058289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 105835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1058483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 105855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 105865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10587b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 105889e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski skip_call |= ValidateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 1058983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 10590b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1059183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 105925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 105935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 105955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1059789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1059889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 105995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1060083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 106015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 106025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10603b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1060483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 10605b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1060683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 106075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 106089e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski // Update our shadow copy with modified driver data 106099e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski CopyNoncoherentMemoryFromDriver(my_data, memRangeCount, pMemRanges); 106105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 106125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1061489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 106155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 106165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1061783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 10618b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 106196d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 106206d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 1062194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1062247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 1062383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 106245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 10625b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1062694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 10627b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1062847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 1062947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 1063057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 1063157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 106329f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertImageMemoryRange(dev_data, image, mem_info, memoryOffset, memRequirements, 10633825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis image_node->createInfo.tiling == VK_IMAGE_TILING_LINEAR); 1063483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "vkBindImageMemory"); 1063547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 1063647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 106370a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10638b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1063983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 1064094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 10641b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 106426d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = mem; 106436d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memOffset = memoryOffset; 106446d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memSize = memRequirements.size; 10645b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1064694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1064794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1064894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1064994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 10650414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 1065194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 106525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 106545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1065689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 106573ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 106583ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 106595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10660b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 106619556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 106629556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 106639556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->needsSignaled = false; 106649556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->stageMask = VK_PIPELINE_STAGE_HOST_BIT; 106659556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node->write_in_use) { 106663ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 106673ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10668414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 106693ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 106703ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 106713ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 10672b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 106736fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 106746fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 106756fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 106766fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 106776fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 106786fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 106796fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 106806fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 106816fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 106823ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 106833ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 106845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 106855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1068889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 106895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 106905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10691e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10692b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10693651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 10694651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 10695651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 106964b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 10697651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= ValidateFenceForSubmit(dev_data, pFence); 10698651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 106999867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 107009867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, bindInfoCount); 107014b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 10702651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 107031344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 107041344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 107055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 107061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 107071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 107081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 107091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 107105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 107125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 107151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 107161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 107171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 107185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10719e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 107205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107221344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 107231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 107241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 107251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 107265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10727e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 107285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107309867daedbf52debc77d6568162ee21e071699b80Chris Forbes 107319867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT> semaphore_waits; 107329867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore> semaphore_signals; 107331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 1073401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; 1073501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1073601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1073701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 107389867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 107399867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 107409867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 107419867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 107429867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 1074301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 107441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 107451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 107465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 107471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10748414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 107491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 107501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 107515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107541344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 1075501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; 1075601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1075701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1075801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 107595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 107605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 107611344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10762414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 107631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 107641344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 107655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107669867daedbf52debc77d6568162ee21e071699b80Chris Forbes else { 107679867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 107689867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 107699867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaled = true; 107709867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 107719867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 107729867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 107735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107759867daedbf52debc77d6568162ee21e071699b80Chris Forbes 107769867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 107779867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits, 107789867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals, 107799867daedbf52debc77d6568162ee21e071699b80Chris Forbes bindIdx == bindInfoCount - 1 ? fence : VK_NULL_HANDLE); 107805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107819867daedbf52debc77d6568162ee21e071699b80Chris Forbes 107829867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !bindInfoCount) { 107839867daedbf52debc77d6568162ee21e071699b80Chris Forbes // No work to do, just dropping a fence in the queue by itself. 107849867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 107859867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 107869867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 107879867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 107889867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 107899867daedbf52debc77d6568162ee21e071699b80Chris Forbes 107900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10791b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 107925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10793e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 107945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 107955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 107975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1079989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 1080089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 108015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 108025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 108035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 10804b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 108055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 108069867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.first = VK_NULL_HANDLE; 108079867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.second = 0; 108081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 108095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 108105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 108125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1081589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 108165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 108175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 108185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 10819b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 108205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 108215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 10822293ecfc5e69ed3978a8c04518166d828294870a4Tony Barbour dev_data->eventMap[*pEvent].write_in_use = 0; 108235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 108245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 108265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1082889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 1082989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 1083089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 108315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 108325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 108335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 10835b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 108363f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo)); 108375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 108405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1084289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1084389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 108445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1084583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 108465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10847b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10848b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, swapchain); 10849b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 10850b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data->images.size() > 0) { 10851b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis for (auto swapchain_image : swapchain_data->images) { 108525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 108535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 108545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 108555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 108565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 108575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 108585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 108615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1086283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 1086383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis clear_object_binding(dev_data, (uint64_t)swapchain_image, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1086494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 108655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 108685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10869b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1087083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 108715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 108725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1087489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1087589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 108765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 108775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 108785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 108805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 108815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 108825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 10883b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 108845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 10885b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_node = getSwapchainNode(dev_data, swapchain); 10886b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_node && !swapchain_node->images.empty()) { 108870801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 108880801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 108890801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 108905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 108915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 108925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 108935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 10894414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 108955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 108965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 108975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 109005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 109015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 109025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 109036d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis // Add imageMap entries for each swapchain image 109046d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo image_ci = {}; 109056d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.mipLevels = 1; 109066d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 109076d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.usage = swapchain_node->createInfo.imageUsage; 109086d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.format = swapchain_node->createInfo.imageFormat; 1090941ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis image_ci.samples = VK_SAMPLE_COUNT_1_BIT; 109106d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; 109116d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; 109126d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; 1091329e9a148072b1015633a102470f0cf706a9e2e55Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_NODE>(new IMAGE_NODE(pSwapchainImages[i], &image_ci)); 1091494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 109156d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->valid = false; 109166d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 109175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 109185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 109195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 109205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 109215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 109225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 109255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1092789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 109285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 109295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 109305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109316c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes std::lock_guard<std::mutex> lock(global_lock); 109326c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 109336c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 109346c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && !pSemaphore->signaled) { 109356c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 109366c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 109376c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 109386c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 109396c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); 109405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109416c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 10942249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 109436c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 109446c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 109456c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (swapchain_data && pPresentInfo->pImageIndices[i] < swapchain_data->images.size()) { 109466c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkImage image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 10947f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis skip_call |= ValidateImageMemoryIsValid(dev_data, getImageNode(dev_data, image), "vkQueuePresentKHR()"); 109486c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes vector<VkImageLayout> layouts; 109496c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (FindLayouts(dev_data, image, layouts)) { 109506c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (auto layout : layouts) { 109516c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 109526c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 109535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 109545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 109555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 109565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 109575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 109585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109646c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (skip_call) { 109656c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 109666c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 109676c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 109686c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkResult result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 109696c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 109706c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (result != VK_ERROR_VALIDATION_FAILED_EXT) { 109716c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // Semaphore waits occur before error generation, if the call reached 109726c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // the ICD. (Confirm?) 109736c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 109746c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 109759867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore) { 109769867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 109776c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes pSemaphore->signaled = false; 109786c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 109796c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 109809867daedbf52debc77d6568162ee21e071699b80Chris Forbes 109819867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Note: even though presentation is directed to a queue, there is no 109829867daedbf52debc77d6568162ee21e071699b80Chris Forbes // direct ordering between QP and subsequent work, so QP (and its 109839867daedbf52debc77d6568162ee21e071699b80Chris Forbes // semaphore waits) /never/ participate in any completion proof. 109846c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 109851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 109865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 109875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1098989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 1099089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 109915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1099283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 109931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 10994b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10995f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 10996f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore && pSemaphore->signaled) { 1099783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 1099883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 1099983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 110005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11001f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11002f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pFence = getFenceNode(dev_data, fence); 11003f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 1100483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 110055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11006b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 110071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 1100883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 11009f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 11010f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11011f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes VkResult result = 110125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 11013f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11014f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.lock(); 11015f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { 11016f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 11017f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pFence->state = FENCE_INFLIGHT; 110189867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = VK_NULL_HANDLE; // ANI isn't on a queue, so this can't participate in a completion proof. 11019f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 11020f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11021f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore 11022f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore) { 11023f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pSemaphore->signaled = true; 110249867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 11025f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 110265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11027f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.unlock(); 110281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 110295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 110305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11032f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark LobodzinskiVKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount, 11033f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkPhysicalDevice *pPhysicalDevices) { 1103483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 11035f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 11036f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (my_data->instance_state) { 11037f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // For this instance, flag when vkEnumeratePhysicalDevices goes to QUERY_COUNT and then QUERY_DETAILS 11038f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11039f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_COUNT; 11040f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11041f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (UNCALLED == my_data->instance_state->vkEnumeratePhysicalDevicesState) { 11042f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Flag warning here. You can call this without having queried the count, but it may not be 11043f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // robust on platforms with multiple physical devices. 1104483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 11045f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11046f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call sequence has vkEnumeratePhysicalDevices() w/ non-NULL pPhysicalDevices. You should first " 11047f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "call vkEnumeratePhysicalDevices() w/ NULL pPhysicalDevices to query pPhysicalDeviceCount."); 11048f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state 11049cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else if (my_data->instance_state->physical_devices_count != *pPhysicalDeviceCount) { 11050f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Having actual count match count from app is not a requirement, so this can be a warning 1105183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11052f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11053f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call to vkEnumeratePhysicalDevices() w/ pPhysicalDeviceCount value %u, but actual count " 11054f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "supported by this instance is %u.", 11055cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski *pPhysicalDeviceCount, my_data->instance_state->physical_devices_count); 11056f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11057f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_DETAILS; 11058f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 1105983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 11060f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11061f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11062f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkResult result = 11063f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_dispatch_table->EnumeratePhysicalDevices(instance, pPhysicalDeviceCount, pPhysicalDevices); 11064f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11065cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski my_data->instance_state->physical_devices_count = *pPhysicalDeviceCount; 11066f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { // Save physical devices 11067f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) { 11068f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(pPhysicalDevices[i]), layer_data_map); 11069cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state = unique_ptr<PHYSICAL_DEVICE_STATE>(new PHYSICAL_DEVICE_STATE()); 11070f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Init actual features for each physical device 11071f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_dispatch_table->GetPhysicalDeviceFeatures(pPhysicalDevices[i], 11072f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski &phy_dev_data->physical_device_features); 11073f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11074f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11075f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return result; 11076f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11077f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, 11078f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski DEVLIMITS_INVALID_INSTANCE, "DL", "Invalid instance (0x%" PRIxLEAST64 ") passed into vkEnumeratePhysicalDevices().", 11079f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski (uint64_t)instance); 11080f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11081f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11082f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 11083f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 11084cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiVKAPI_ATTR void VKAPI_CALL 11085cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiGetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, 11086cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VkQueueFamilyProperties *pQueueFamilyProperties) { 11087cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski bool skip_call = false; 11088cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); 11089cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (phy_dev_data->physical_device_state) { 11090cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (NULL == pQueueFamilyProperties) { 11091cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_COUNT; 11092cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11093cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 11094cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Verify that for each physical device, this function is called first with NULL pQueueFamilyProperties ptr in order to 11095cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // get count 11096cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (UNCALLED == phy_dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 11097cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11098cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11099cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call sequence has vkGetPhysicalDeviceQueueFamilyProperties() w/ non-NULL " 11100cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "pQueueFamilyProperties. You should first call vkGetPhysicalDeviceQueueFamilyProperties() w/ " 11101cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "NULL pQueueFamilyProperties to query pCount."); 11102cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11103cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Then verify that pCount that is passed in on second call matches what was returned 11104cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (phy_dev_data->physical_device_state->queueFamilyPropertiesCount != *pCount) { 11105cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 11106cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // TODO: this is not a requirement of the Valid Usage section for vkGetPhysicalDeviceQueueFamilyProperties, so 11107cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // provide as warning 11108cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11109cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11110cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call to vkGetPhysicalDeviceQueueFamilyProperties() w/ pCount value %u, but actual count " 11111cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "supported by this physicalDevice is %u.", 11112cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski *pCount, phy_dev_data->physical_device_state->queueFamilyPropertiesCount); 11113cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11114cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; 11115cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11116cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (skip_call) { 11117cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 11118cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11119cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(physicalDevice, pCount, 11120cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski pQueueFamilyProperties); 11121cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (NULL == pQueueFamilyProperties) { 11122cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state->queueFamilyPropertiesCount = *pCount; 11123cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11124cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { // Save queue family properties 11125cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->queue_family_properties.reserve(*pCount); 11126cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski for (uint32_t i = 0; i < *pCount; i++) { 11127cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->queue_family_properties.emplace_back(new VkQueueFamilyProperties(pQueueFamilyProperties[i])); 11128cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11129cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11130cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 11131cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11132cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 11133cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 11134cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski __LINE__, DEVLIMITS_INVALID_PHYSICAL_DEVICE, "DL", 11135cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Invalid physicalDevice (0x%" PRIxLEAST64 ") passed into vkGetPhysicalDeviceQueueFamilyProperties().", 11136cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski (uint64_t)physicalDevice); 11137cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11138cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski} 11139cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 1114089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1114189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 1114289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 111435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 111445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 111455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 111465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 11147b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 11148c34ab18ac7c064590a1020a8db4b6abf5a8d3a18Mark Lobodzinski res = layer_create_msg_callback(my_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); 111495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 111515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1115389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 1115489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 1115589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 111565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 111575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 111585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 11159b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 111605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 111615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1116389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1116489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 1116589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 111665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 111675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 111685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 111695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11171a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11172a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 11173a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11174a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11175a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11176a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11177a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 11178a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11179a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11180a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11181a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11182a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 11183a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 11184a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 11185a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11186a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return VK_ERROR_LAYER_NOT_PRESENT; 11187a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11188a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 1118989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 1119089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 1119189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 11192a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 1119308939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 11194a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 11195a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 11196a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 11197a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu dispatch_key key = get_dispatch_key(physicalDevice); 11198a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu layer_data *my_data = get_my_data_ptr(key, layer_data_map); 11199a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 1120008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1120108939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1120280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 112037ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 112047ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 112057ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1120680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 1120780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1120809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1120909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 1121009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1121189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 1121280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 1121380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 1121480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 1121580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1121680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 112175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1121809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 1121909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 1122009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 1122109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 112225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 112235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 112245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 112265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 112275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 112285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 112295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 112305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1123389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 112347ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 112353f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 112363f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 112373f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 112383f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 112397ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 112407ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 112415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112427ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 112435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 112455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 112467ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 112477ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 112487ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 112495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 112515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 112525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 112535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 112545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1125508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1125680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 112577ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 112587ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 112597ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 112607ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 112617ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 112627ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 112637ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 112647ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 112657ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 11266f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski { "vkEnumeratePhysicalDevices", reinterpret_cast<PFN_vkVoidFunction>(EnumeratePhysicalDevices) }, 11267cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski { "vkGetPhysicalDeviceQueueFamilyProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceQueueFamilyProperties) }, 112687ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 11269a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, 11270a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, 11271a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, 112727ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 112737ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 112747ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 112757ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 112767ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 112777ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 112787ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 112797ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 112807ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 112817ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 112827ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 112837ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1128480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1128580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1128680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1128780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1128880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 11289593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, 11290593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, 11291593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, 11292593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, 11293593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, 11294593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, 11295593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, 11296593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, 11297593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, 11298593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, 11299593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, 11300593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, 11301593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, 11302593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, 11303593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, 11304593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, 11305593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, 11306593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, 11307593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, 11308593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, 11309593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, 11310593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, 11311593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, 11312593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, 11313593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, 11314593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, 11315593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, 11316593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, 11317593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, 11318593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, 11319593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, 11320593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, 11321593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, 11322593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, 11323593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, 11324593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, 11325593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, 11326593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, 11327593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, 11328593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, 11329593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, 11330593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, 11331593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, 11332593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, 11333593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, 11334593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, 11335593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, 11336593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, 11337593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, 11338593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, 11339593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, 11340593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, 11341593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, 11342593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, 11343593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, 11344593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, 11345593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, 11346593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, 11347593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, 11348593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, 11349593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, 11350593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, 11351593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, 11352593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, 11353593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, 11354593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, 11355593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, 11356593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, 11357593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, 11358593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, 11359593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, 11360593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, 11361593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, 11362593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, 11363593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, 11364593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, 11365593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, 11366593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, 11367593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, 11368593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, 11369593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, 11370593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, 11371593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, 11372593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, 11373593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, 11374593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, 11375593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, 11376593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, 11377593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, 11378593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, 11379593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, 11380593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, 11381593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, 11382593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, 11383593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, 11384593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, 11385593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, 11386593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, 11387593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, 11388593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, 11389593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, 11390593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, 11391593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, 11392593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, 11393593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, 11394593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, 11395593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, 11396593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, 11397593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, 11398593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, 11399593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, 11400593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, 11401593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, 11402593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, 11403593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, 11404593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, 1140580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1140680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1140780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1140880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1140980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1141080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1141180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1141280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1141380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1141480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1141509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1141609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1141709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1141809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1141909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1142009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1142109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1142209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1142309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1142409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1142509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1142609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 1142709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 114283f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 114293f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 114303f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 114313f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 114323f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1143309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1143409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1143509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1143609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1143709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1143809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1143909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 1144009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1144109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 11442d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 11443d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11444d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 11445d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11446d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11447d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 11448d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1144989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 11450d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11451d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11452d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 11453d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 11454d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 11455d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1145689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 11457d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11458d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11459d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 11460d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 11461d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1146289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 11463d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11464d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11465a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu// loader-layer interface v0, just wrappers since there is only a layer 11466d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1146708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1146808939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 11469a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); 1147008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1147108939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1147208939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1147308939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 11474a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); 1147508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1147608939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1147708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1147808939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 11479a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 11480a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 11481a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); 11482d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11483d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11484d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 11485d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 11486d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 11487a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 11488a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 11489a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 11490d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11491d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11492d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1149389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 11494d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11495d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11496d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 1149789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1149808939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 11499