core_validation.cpp revision 5ca3c071afc98f9144f489b74aa3affaa93633b0
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 45dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes#include <tuple> 465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 62b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 68c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine#define LOGCONSOLE(...) \ 69c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine { \ 70c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf(__VA_ARGS__); \ 71c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf("\n"); \ 72c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 76414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 7771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis// TODO : CB really needs it's own class and files so this is just temp code until that happens 7871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin EhlisGLOBAL_CB_NODE::~GLOBAL_CB_NODE() { 7971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis for (uint32_t i=0; i<VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 8071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis // Make sure that no sets hold onto deleted CB binding 8171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis for (auto set : lastBound[i].uniqueBoundSets) { 8271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->RemoveBoundCommandBuffer(this); 8371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } 8471511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } 8571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis} 8671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis 87d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 88d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 95b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track command pools and their command buffers 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct CMD_POOL_INFO { 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPoolCreateFlags createFlags; 995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queueFamilyIndex; 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 104e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 1053f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 1075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 1105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 1115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 11456a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu VkInstance instance; 11556a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu 1165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 12094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 122b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski unordered_set<VkQueue> queues; // all queues under given device 1235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 126cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> samplerMap; 1272c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis unordered_map<VkImageView, unique_ptr<VkImageViewCreateInfo>> imageViewMap; 1286d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis unordered_map<VkImage, unique_ptr<IMAGE_NODE>> imageMap; 1292f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis unordered_map<VkBufferView, unique_ptr<VkBufferViewCreateInfo>> bufferViewMap; 1308718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis unordered_map<VkBuffer, unique_ptr<BUFFER_NODE>> bufferMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap; 1335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 134397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 135cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 13757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; 1385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 14472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 1455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFramebuffer, FRAMEBUFFER_NODE> frameBufferMap; 1465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 149918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1506c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 153b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 154b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 155b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 15794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), device_extensions(), 158a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis device(VK_NULL_HANDLE), phys_dev_properties{}, phys_dev_mem_props{} {}; 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 161b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 162b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 163b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 164e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 165f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 166e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 171e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 177e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 191b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 192b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 193b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 194b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 195b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 196b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 198b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 199b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 200b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 201b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 202b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 203b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 262b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 263593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 2642c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis// Return ImageViewCreateInfo ptr for specified imageView or else NULL 265a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkImageViewCreateInfo *getImageViewData(const layer_data *dev_data, VkImageView image_view) { 2662c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_it = dev_data->imageViewMap.find(image_view); 2672c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (iv_it == dev_data->imageViewMap.end()) { 2682c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return nullptr; 2692c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis } 2702c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return iv_it->second.get(); 2712c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis} 2729a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis// Return sampler node ptr for specified sampler or else NULL 273a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSAMPLER_NODE *getSamplerNode(const layer_data *dev_data, VkSampler sampler) { 2742c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto sampler_it = dev_data->samplerMap.find(sampler); 2752c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (sampler_it == dev_data->samplerMap.end()) { 2769a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return nullptr; 2779a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis } 2789a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return sampler_it->second.get(); 2799a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis} 2806d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis// Return image node ptr for specified image or else NULL 281a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisIMAGE_NODE *getImageNode(const layer_data *dev_data, VkImage image) { 2826d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_it = dev_data->imageMap.find(image); 2836d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_it == dev_data->imageMap.end()) { 2846d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return nullptr; 2856d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis } 2866d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return img_it->second.get(); 2876d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis} 2888718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis// Return buffer node ptr for specified buffer or else NULL 289a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisBUFFER_NODE *getBufferNode(const layer_data *dev_data, VkBuffer buffer) { 2902c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 2912c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (buff_it == dev_data->bufferMap.end()) { 2928718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return nullptr; 2938718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis } 2948718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return buff_it->second.get(); 2958718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis} 296b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis// Return swapchain node for specified swapchain or else NULL 297a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { 298b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); 299b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swp_it == dev_data->device_extensions.swapchainMap.end()) { 300b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis return nullptr; 301b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis } 3023f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis return swp_it->second.get(); 303b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis} 304170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis// Return swapchain for specified image or else NULL 305a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { 306170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); 307170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { 308170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return VK_NULL_HANDLE; 309170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis } 310170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return img_it->second; 311170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis} 3122f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis// Return buffer node ptr for specified buffer or else NULL 313a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkBufferViewCreateInfo *getBufferViewInfo(const layer_data *my_data, VkBufferView buffer_view) { 3142f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis auto bv_it = my_data->bufferViewMap.find(buffer_view); 3152f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis if (bv_it == my_data->bufferViewMap.end()) { 3162f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return nullptr; 3172f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis } 3182f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return bv_it->second.get(); 3192f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis} 3208718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis 32166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesFENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { 32266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->fenceMap.find(fence); 32366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->fenceMap.end()) { 32466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 32566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 32666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 32766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 32866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 32966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesQUEUE_NODE *getQueueNode(layer_data *dev_data, VkQueue queue) { 33066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->queueMap.find(queue); 33166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->queueMap.end()) { 33266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 33366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 33466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 33566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 33666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3375e92f3cfdca6a52a3dcefd053c41f728bd036cebChris ForbesSEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { 3385e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes auto it = dev_data->semaphoreMap.find(semaphore); 3395e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes if (it == dev_data->semaphoreMap.end()) { 3405e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return nullptr; 3415e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes } 3425e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return &it->second; 3435e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes} 3445e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes 34594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 3465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 3475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 3486d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, VkImage(handle)); 3496d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_node) 3506d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return &img_node->mem; 3515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 3548718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buff_node = getBufferNode(my_data, VkBuffer(handle)); 3558718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buff_node) 3568718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return &buff_node->mem; 3575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 3635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 3665121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 36772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 3685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 3695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 3705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 3715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 3720a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 3730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 3740a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 375e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 376e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 3785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 3805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 3815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 3825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 383414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for images 3915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls image info and then sends actual vs. desired usage off to helper above where 3925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3930a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_image_usage_flags(layer_data *dev_data, VkImage image, VkFlags desired, VkBool32 strict, 39494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 395e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3966d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, image); 3976d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 3986d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis skipCall = validate_usage_flags(dev_data, image_node->createInfo.usage, desired, strict, (uint64_t)image, 3995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "image", func_name, usage_string); 4005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls buffer info and then sends actual vs. desired usage off to helper above where 4065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 4070a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_buffer_usage_flags(layer_data *dev_data, VkBuffer buffer, VkFlags desired, VkBool32 strict, 40894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 409e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4108718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 4118718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 4128718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis skipCall = validate_usage_flags(dev_data, buffer_node->createInfo.usage, desired, strict, (uint64_t)buffer, 4135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "buffer", func_name, usage_string); 4145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 42057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin EhlisDEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { 42157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_it = dev_data->memObjMap.find(mem); 42257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_it == dev_data->memObjMap.end()) { 4235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis return mem_it->second.get(); 4265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); 4335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 435e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 436e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImage image = VK_NULL_HANDLE) { 4375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4386d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, image); 4396d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node && !image_node->valid) { 44058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 442414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 4435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObj = getMemObjInfo(dev_data, mem); 4475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 44858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 450414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid memory 0x%" PRIx64 ", please fill the memory before using.", functionName, 4515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 4525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 4555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 4585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4596d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 4606d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 4616d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->valid = valid; 4625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 46457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObj = getMemObjInfo(dev_data, mem); 4655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 4665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 4675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 473e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 474e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 475e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 4785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 48157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 4825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 483de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemInfo->commandBufferBindings.insert(cb); 4845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 48572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 4865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 48772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 488c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 4895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 494400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 495400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 49672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 497c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 498c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 49957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 5005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 501400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis pInfo->commandBufferBindings.erase(pCBNode->commandBuffer); 5025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 504c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 5055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 5075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 509400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 510400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 511400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 5125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 515e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 516e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 517de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes size_t cmdBufRefCount = pMemObjInfo->commandBufferBindings.size(); 518896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes size_t objRefCount = pMemObjInfo->objBindings.size(); 5195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 520de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if ((pMemObjInfo->commandBufferBindings.size()) != 0) { 52158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 523414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempting to free memory object 0x%" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 5245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " references", 5255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 5265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 528de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (cmdBufRefCount > 0 && pMemObjInfo->commandBufferBindings.size() > 0) { 529de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pMemObjInfo->commandBufferBindings) { 53058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 531de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 532414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%p still has a reference to mem obj 0x%" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 5335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 535de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemObjInfo->commandBufferBindings.clear(); 5365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 538896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (objRefCount > 0 && pMemObjInfo->objBindings.size() > 0) { 539896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pMemObjInfo->objBindings) { 540896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 541414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, 542896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 5435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 545896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemObjInfo->objBindings.clear(); 5465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 550e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemObjInfo(layer_data *my_data, void *object, VkDeviceMemory mem) { 551e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = my_data->memObjMap.find(mem); 5535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != my_data->memObjMap.end()) { 5545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap.erase(item); 5555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 558414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Request to delete memory object 0x%" PRIxLEAST64 " not present in memory Object Map", (uint64_t)mem); 5595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 563e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 564e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 56657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 5675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize == 0 && !internal) { 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section 57058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 572414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempting to free memory associated with a Persistent Image, 0x%" PRIxLEAST64 ", " 5735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this should not be explicitly freed\n", 5745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem); 5755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear any CB bindings for completed CBs 5775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is there a better place to do this? 5785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(pInfo->object != VK_NULL_HANDLE); 580de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // clear_cmd_buf_and_mem_references removes elements from 581de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // pInfo->commandBufferBindings -- this copy not needed in c++14, 582de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // and probably not needed in practice in c++11 583de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes auto bindings = pInfo->commandBufferBindings; 584de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : bindings) { 585a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 586de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 5875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify that no references to this mem obj remain and remove bindings 591de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() || pInfo->objBindings.size()) { 59258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= reportMemReferencesAndCleanUp(dev_data, pInfo); 5935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete mem obj info 59558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= deleteMemObjInfo(dev_data, object, mem); 5965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 6025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 6035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 6055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 6065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 6075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 6095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 6155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 616c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 6175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 6180a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 6195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 620e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 62194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 62294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 62357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = getMemObjInfo(dev_data, *pMemBinding); 6245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 62594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 6265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 627c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 6285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 629896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (!pMemObjInfo->objBindings.erase({handle, type})) { 6305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 63158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 632414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 633414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 6345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 6355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 6425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 6435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 6445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 6455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 64694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 64794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 648e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 65258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 653414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 6545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 6562e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 65757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 6582e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pMemInfo) { 65957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = getMemObjInfo(dev_data, *pMemBinding); 6602e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pPrevBinding != NULL) { 6612e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6622e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, 6632e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis "MEM", "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 6642e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis ") which has already been bound to mem object 0x%" PRIxLEAST64, 6652e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 6662e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis } else { 6672e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis pMemInfo->objBindings.insert({handle, type}); 6682e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // For image objects, make sure default memory state is correctly set 6692e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO : What's the best/correct way to handle this? 6702e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 6716d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, VkImage(handle)); 6726d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 6736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo ici = image_node->createInfo; 6742e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 6752e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO:: More memory state transition stuff. 6765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6792e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 6805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 6885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 6905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 6910a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 6920a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 6930a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 6940a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes bool skipCall = VK_FALSE; 6955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6970a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, handle, type); 6985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 7002e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 70157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 7022e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pInfo) { 7032e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis pInfo->objBindings.insert({handle, type}); 7042e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // Need to set mem binding for this object 7052e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 7065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given Object, get 'mem' obj that it's bound to or NULL if no binding 7120a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool get_mem_binding_from_object(layer_data *dev_data, const uint64_t handle, 71394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis const VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 714e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 7155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 71694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 71794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 71894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *mem = *pMemBinding; 7195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 721414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Trying to get mem binding for object 0x%" PRIxLEAST64 " but no such object in %s list", handle, 7225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type)); 7235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 7280a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 7295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 73058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 73558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 73758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 73858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 7425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 74557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = (*ii).second.get(); 7465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 74857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)mem_info); 74958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 75057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(mem_info->mem)); 75158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 752c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 75357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->commandBufferBindings.size() + mem_info->objBindings.size()); 75457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (0 != mem_info->allocInfo.allocationSize) { 75557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&mem_info->allocInfo, "MEM(INFO): "); 75658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 7615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 76557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->objBindings.size()); 76657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->objBindings.size() > 0) { 76757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis for (auto obj : mem_info->objBindings) { 76858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 769414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 7705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 7755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 77657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->commandBufferBindings.size()); 77757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->commandBufferBindings.size() > 0) { 77857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis for (auto cb : mem_info->commandBufferBindings) { 77958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 780414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB 0x%p", cb); 7815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7860a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 78772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 7885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 79572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 79672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 7975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 7995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 80472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 8055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 807414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has CB 0x%p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 8085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 809c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 811c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 8125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 813414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 8145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 8195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 8225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 8265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 8305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 8335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 8425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 8445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 8455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 8485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 8525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 8575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 8845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 8855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 8935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 10025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10419ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10429ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10489ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 10499ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10519ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 10529ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10549ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 10559ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 10579ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 10589ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10599ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 10619ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 10629ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10639ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 10659ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 10669ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10679ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10699ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 10709ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 10719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 10739ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 10759ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 10769ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 10779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 10789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 10799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 10809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 10815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10829ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 10859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 10869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 10889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 10899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 10929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 10939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 10969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11019ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 11029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 11039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 11049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 11059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 11069ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11079ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 110837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 110937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 111037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 111137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 111237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 111337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 111437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 111537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 111637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11237c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 112437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 11257c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11267c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 112937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 113037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 113137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 113237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 113337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11407c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 11417c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 114237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 11437c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11447c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11457c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 11467c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 11477c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 11487c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11497c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11527c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 11557c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 11565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 11587c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 11595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 116037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 116137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 116237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 116337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 116437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 116537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 116637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 116737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 116837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 11695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 117037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 117137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 11725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 117637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 11775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 11785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 11825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 11835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 118637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 11875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 12035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 12045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 12065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 12105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 12115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 12125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 12145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 12155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1227cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1228cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1229cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1230cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1231cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1232cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1233cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1234cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1235cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 12385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1245c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1246c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1247c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1248c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1249c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1250c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1251c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1252c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1253c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1254c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1255c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1256c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1257c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1258c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 12595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 12655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1266b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1267fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 12685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1271031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1272031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1273031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1274031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1275031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1276031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1277031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1278031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1279031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1280031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1281031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1282031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1283031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1284031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 12905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1301edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 13025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1304b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 13055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1306031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 13215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1344b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1345fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1353edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_location(shader_module const *src, spirv_inst_iter entrypoint, 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1360b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 13615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 13655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 13695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1383b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1384b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1385b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1386b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 139281264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1397c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14081d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1415b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 14287c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1434b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1435fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 1440edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_block_members(src, out, blocks, is_array_of_verts, id, type, is_patch); 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1446edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_descriptor_slot(debug_report_data *report_data, shader_module const *src, 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<descriptor_slot_t, interface_var> &out) { 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 14745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 14755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto existing_it = out.find(std::make_pair(set, binding)); 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (existing_it != out.end()) { 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* conflict within spv image */ 1480edef66e03ed509994449d598f4fadea1a487d41bChris Forbes log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis insn.word(2), insn.word(1), storage_class_name(insn.word(3)), existing_it->first.first, 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis existing_it->first.second); 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1490b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1491b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1492fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(set, binding)] = v; 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1498edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1499031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1501031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1507edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, outputs, producer_stage->arrayed_output); 1508edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, inputs, consumer_stage->arrayed_input); 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1521edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1522080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1523031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1524031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1529edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1531031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1532031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1537fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1538fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1539fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1540fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 15410f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1542fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1543fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 154437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1545edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 15479ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 15489ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 15499ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15530f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1554edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 15550f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1556f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 15570f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 15580f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 15590f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 15600f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 15610f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15620f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 15725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 15835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 159431c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 159531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 159631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 159731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1600f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 161631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 161731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 161831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 161931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1622f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 16325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1660edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1671edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1684edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 16855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1689edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, inputs, false); 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1694c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1695c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1696c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1697c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1698c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1699c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 17075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 17085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 1711edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1712080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1718edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1730edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 17339ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 17349ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1748edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoint, RENDER_PASS_NODE const *rp, uint32_t subpass) { 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 1751025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 1752025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes for (auto i = 0u; i < rp->subpassColorFormats[subpass].size(); i++) { 1753025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (rp->subpassColorFormats[subpass][i] != VK_FORMAT_UNDEFINED) { 1754025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes color_attachments[i] = rp->subpassColorFormats[subpass][i]; 1755025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1756025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1757025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1762edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, outputs, false); 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1764025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 1765025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1767025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 1768025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 1769025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 1770025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 1771025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1773025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 1774edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1776025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "FS writes to output location %d with no matching attachment", it_a->first.first)) { 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1779025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1780025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 1781edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1782025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", it_b->first)) { 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1785025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1787025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 1788025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1792edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1794025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "Attachment %d of type `%s` does not match FS output type of `%s`", it_b->first, 1795025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 1796025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 1802025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1803025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 183081264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 1910c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 1916c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1927edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &range : *pushConstantRanges) { 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 1953edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1954080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 19575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 1967edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1968080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 19695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1982edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 19835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, shader_module const *src, 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 1990edef66e03ed509994449d598f4fadea1a487d41bChris Forbes pass &= validate_push_constant_block_against_pipeline(report_data, pushConstantRanges, src, 1991080afef66a53dbdd085698b713697296458edfd9Chris Forbes src->get_def(def_insn.word(1)), stage); 19925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1998fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 1999fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 20004a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 200337083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 200578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (slot.first >= pipelineLayout->descriptorSetLayouts.size()) 200637083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2008f54d085ac836f3b0a2b62f6b401f759e586f0ea7Chris Forbes return pipelineLayout->setLayouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 20145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 20165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 20175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 20195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2020e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 20215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2023e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2025e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2029e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2030e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 20313d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 20323d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 20333d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 2034414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2036e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 204016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic PIPELINE_NODE *getPipeline(layer_data const *my_data, VkPipeline pipeline) { 2041ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 2042ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 2043ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2045ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 204816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic RENDER_PASS_NODE *getRenderPass(layer_data const *my_data, VkRenderPass renderpass) { 204916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto it = my_data->renderPassMap.find(renderpass); 205016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (it == my_data->renderPassMap.end()) { 205116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return nullptr; 205216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 205316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return it->second; 205416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes} 205516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 2056f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic FRAMEBUFFER_NODE *getFramebuffer(layer_data *my_data, VkFramebuffer framebuffer) { 2057f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto it = my_data->frameBufferMap.find(framebuffer); 2058f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (it == my_data->frameBufferMap.end()) { 2059f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return nullptr; 2060f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes } 2061f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return &it->second; 2062f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes} 2063f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes 2064e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehliscvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { 206511f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto it = my_data->descriptorSetLayoutMap.find(dsLayout); 206611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (it == my_data->descriptorSetLayoutMap.end()) { 206711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return nullptr; 206811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 206911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return it->second; 207011f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes} 207111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 20724a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { 20734a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto it = my_data->pipelineLayoutMap.find(pipeLayout); 20744a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (it == my_data->pipelineLayoutMap.end()) { 20754a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return nullptr; 20764a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes } 20774a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return &it->second; 20784a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes} 20794a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes 2080e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2081e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2085e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2088e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2092e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 2093e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 20943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 20953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 20963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 20973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 2098ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2099ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2100ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 21013d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21023d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 21033d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 210445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 210545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 21063d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 21083d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21093d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 21103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 21123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 211345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 211445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 21153d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21163d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 21173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 211845824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 211945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 21203d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 21223d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21233d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 21243d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 21263d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21273d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 21283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 21313d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 21375ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski// If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 2144e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis // Check potential NULL cases first to avoid nullptr issues later 2145e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pPrimary == nullptr) { 2146e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pSecondary == nullptr) { 2147e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return true; 2148e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 2149e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2150e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } else if (pSecondary == nullptr) { 2151e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2152e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 21535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 215406e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 215506e963555b0df747c98c43816c16647349d21001Mark Young return true; 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 215706e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 215806e963555b0df747c98c43816c16647349d21001Mark Young return true; 21595ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else { // Format and sample count must match 21605ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 21615ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return true; 21625ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 21635ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return false; 21645ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } 21655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2175e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis// For given primary and secondary RenderPass objects, verify that they're compatible 2176528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlisstatic bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPass primaryRP, const VkRenderPass secondaryRP, 21775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string &errorMsg) { 217816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto primary_render_pass = getRenderPass(my_data, primaryRP); 217916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto secondary_render_pass = getRenderPass(my_data, secondaryRP); 218016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 218116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!primary_render_pass) { 2182c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << primaryRP << ")"; 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 218616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 218716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 218816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!secondary_render_pass) { 2189c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << secondaryRP << ")"; 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Trivial pass case is exact same RP 21955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRP == secondaryRP) { 21965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 219816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *primaryRPCI = primary_render_pass->pCreateInfo; 219916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *secondaryRPCI = secondary_render_pass->pCreateInfo; 22005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2201c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 22035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 22045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 22085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 22095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 22105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 22115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 22125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 22145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2217c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2225c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2231fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2232fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2233fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2234fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2235fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2236c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2237fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2238fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2239fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2240fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2241fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 22425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 22435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2249c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2259397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2260397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2261397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 2262397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis const VkPipelineLayout layout, const uint32_t layoutIndex, string &errorMsg) { 22634a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(my_data, layout); 22644a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (!pipeline_layout) { 2265c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkPipelineLayout (" << layout << ")"; 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22704a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (layoutIndex >= pipeline_layout->descriptorSetLayouts.size()) { 2271c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22724a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes errorStr << "VkPipelineLayout (" << layout << ") only contains " << pipeline_layout->descriptorSetLayouts.size() 22734a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes << " setLayouts corresponding to sets 0-" << pipeline_layout->descriptorSetLayouts.size() - 1 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << ", but you're attempting to bind set to index " << layoutIndex; 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22784a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto layout_node = pipeline_layout->setLayouts[layoutIndex]; 2279397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 22805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2283edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2284e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 22855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 22895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 22905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2291edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 22925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 22955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 22965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 22975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 22985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2299e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 23005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2308edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 23091b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 23105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23121b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 23131b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 23147b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 23157b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 23165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 23177b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 23187b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 23197b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 23207b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 23217b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 23227b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 23237b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 23245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 23275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 23285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 23295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 23305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 23315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 23335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 23345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 23355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 23365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 23415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER; 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 234835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 234935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 235035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 235135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 235235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 235335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 235435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 235535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 235635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 235735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 23585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 23595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 23615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 23625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 23635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 23645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 23655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 23675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 23685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 23705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 23715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 23725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 23735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 23745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 23765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 23785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; 23795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 23815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 23855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 23865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 23885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 23895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23924110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2393a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 23944110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2395080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2396a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2397a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2398a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2399a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2400a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2401a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2402a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2403a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2404a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2405a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 240669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 240769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2408e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2409a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2410a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2411a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2412a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2413a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2414a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2415a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2416a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2417a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2418a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2419a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2420a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2421a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2422a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2423a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2424a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2425a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2426a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 24274110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2428a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2429a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2430a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 24314110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2432a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2433a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2434a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 24354110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2436a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2437a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2438a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 24394110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2440a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2441a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2442a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2443a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 24444110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2445a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2446a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2447a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2448a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 24494110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2450a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2451a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2452a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 24534110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2454a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2455a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2456a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 24574110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2458a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2459a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2460a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2461a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 24624110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2463a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2464a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2465a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2466a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 24674110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2468a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2469a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2470a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2471a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 24724110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2473a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2474a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2475a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2476a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 24774110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2478a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2479a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2480a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 24814110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2482a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2483a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2484a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 24854110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2486a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2487a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2488a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 24894110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2490a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2491a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2492a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 24934110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2494a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2495a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2496a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 24974110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2498a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2499a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2500a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 25014110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2502a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2503a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2504a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 25054110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2506a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2507a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2508a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 25094110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2510a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2511a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2512a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2513a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 25144110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2515a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2516a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2517a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 25184110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2519a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2520a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2521a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2522a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 25234110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2524a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2525a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2526a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2527a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 25284110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2529a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2530a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2531a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 25324110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2533a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2534a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2535a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2536e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2537a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2538a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2539a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2540a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2541a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2542a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2543a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2544a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2545ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbesstatic bool validate_pipeline_shader_stage(debug_report_data *report_data, 2546ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes VkPipelineShaderStageCreateInfo const *pStage, 2547ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes PIPELINE_NODE *pipeline, 2548ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes shader_module **out_module, 2549ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes spirv_inst_iter *out_entrypoint, 255069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 2551ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unordered_map<VkShaderModule, 2552ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unique_ptr<shader_module>> const &shaderModuleMap) { 2553e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 255469f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 255569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 2556557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_specialization_offsets(report_data, pStage); 255778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 255878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 255978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 256078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2561557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2562080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 256378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 256478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2565e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 256678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 256778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 256878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 256978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2570557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 257178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 257278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 257378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 257478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 257578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 257678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 257778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::map<descriptor_slot_t, interface_var> descriptor_uses; 2578557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes collect_interface_by_descriptor_slot(report_data, module, accessible_ids, descriptor_uses); 257978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2580ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes auto pipelineLayout = pipeline->pipelineLayout; 2581ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 258278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 2583557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_push_constant_usage(report_data, &pipelineLayout->pushConstantRanges, 258478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes module, accessible_ids, pStage->stage); 258578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 258678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 258778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 258878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 258978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 259078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2591fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 25924110a6be7a8a287d459475926985f71c27d01298Chris Forbes const auto & binding = get_descriptor_binding(pipelineLayout, use.first); 259378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 259478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 259578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2596557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2597080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 259878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 259978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2600e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 260178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 260278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2603557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 260478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 260578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 260678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 260778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2608fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 260978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2610e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 261178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2612edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2613fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2614557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2615fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2616fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2617fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2618fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 261978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2620e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 262178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 262278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2623557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2624fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 262578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 262678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2627fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2628e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 262978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 263078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 263178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 263278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 263478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 263578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2637a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2638a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2639e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_NODE *pPipeline, 264069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 264169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 26426660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 26435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 26455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 26475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 26485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 26495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 26505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2651e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 26525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 26546660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 265578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2656e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 265769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 265869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 26595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 26625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2664e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 26655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2668e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 26695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 26735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 26755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 26765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 26775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 26805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 26815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2682e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2683031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2684031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 26855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 26875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26907c7400aa231c3dbb21e51158adebb83d5f528130Chris Forbes if (shaders[fragment_stage] && pPipeline->renderPass) { 2691e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 26927c7400aa231c3dbb21e51158adebb83d5f528130Chris Forbes pPipeline->renderPass, pCreateInfo->subpass); 26935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 26965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2698e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_NODE *pPipeline, VkPhysicalDeviceFeatures const *enabledFeatures, 269969f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 27006660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 270103857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 270203857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 270303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 270403857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 2705e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 270669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 270703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 27085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 2709a682b1c533d9a492243b363c6585c4f03bcd87aaTobin Ehliscvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { 2710104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis auto set_it = my_data->setMap.find(set); 2711104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis if (set_it == my_data->setMap.end()) { 27125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 27135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2714104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return set_it->second; 27155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 27167a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 27177a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 27187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 27197a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 27207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 27217a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 27227a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2723e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 27247a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 2725dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes const vector<std::tuple<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>, 2726dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t> const *>> &activeSetBindingsPairs) { 2727e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 2728a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2729dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes cvdescriptorset::DescriptorSet *set_node = std::get<0>(set_bindings_pair); 2730cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 2731dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (!set_node->ValidateDrawState(std::get<1>(set_bindings_pair), *std::get<2>(set_bindings_pair), 2732397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 2733cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 2734397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 2735cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2736cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2737414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " encountered the following validation error at draw time: %s", 2738cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), err_str.c_str()); 2739cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 2740dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes set_node->GetStorageUpdates(std::get<1>(set_bindings_pair), &pCB->updateBuffers, &pCB->updateImages); 27415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 27435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 27445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2745eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 2746ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic VkSampleCountFlagBits getNumSamples(PIPELINE_NODE const *pipe) { 2747ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 2748ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 2749eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 2750eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2751eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 2752eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2753eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2754eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 275529d196e071b2dc1db47702085469396f2b956820Chris Forbesstatic bool validatePipelineDrawtimeState(layer_data const *my_data, 275629d196e071b2dc1db47702085469396f2b956820Chris Forbes LAST_BOUND_STATE const &state, 275729d196e071b2dc1db47702085469396f2b956820Chris Forbes const GLOBAL_CB_NODE *pCB, 275829d196e071b2dc1db47702085469396f2b956820Chris Forbes PIPELINE_NODE const *pPipeline) { 2759eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 276029d196e071b2dc1db47702085469396f2b956820Chris Forbes 276129d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify Vtx binding 276229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pPipeline->vertexBindingDescriptions.size() > 0) { 276329d196e071b2dc1db47702085469396f2b956820Chris Forbes for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { 276429d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 276529d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 276629d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 276729d196e071b2dc1db47702085469396f2b956820Chris Forbes "The Pipeline State Object (0x%" PRIxLEAST64 276829d196e071b2dc1db47702085469396f2b956820Chris Forbes ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 276929d196e071b2dc1db47702085469396f2b956820Chris Forbes " should be set via vkCmdBindVertexBuffers.", 277029d196e071b2dc1db47702085469396f2b956820Chris Forbes (uint64_t)state.pipeline, i); 277129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 277229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 277329d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 277429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pCB->currentDrawData.buffers.empty()) { 277529d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 277629d196e071b2dc1db47702085469396f2b956820Chris Forbes 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 277729d196e071b2dc1db47702085469396f2b956820Chris Forbes "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 277829d196e071b2dc1db47702085469396f2b956820Chris Forbes ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 277929d196e071b2dc1db47702085469396f2b956820Chris Forbes (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline); 278029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 278129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 278229d196e071b2dc1db47702085469396f2b956820Chris Forbes // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 278329d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip check if rasterization is disabled or there is no viewport. 278429d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((!pPipeline->graphicsPipelineCI.pRasterizationState || 278529d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 278629d196e071b2dc1db47702085469396f2b956820Chris Forbes pPipeline->graphicsPipelineCI.pViewportState) { 278729d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 278829d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 278929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynViewport) { 279029d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->viewports.size() != pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 279129d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 279229d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 279329d196e071b2dc1db47702085469396f2b956820Chris Forbes "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 279429d196e071b2dc1db47702085469396f2b956820Chris Forbes ", but PSO viewportCount is %u. These counts must match.", 279529d196e071b2dc1db47702085469396f2b956820Chris Forbes pCB->viewports.size(), pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 279629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 279729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 279829d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynScissor) { 279929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->scissors.size() != pPipeline->graphicsPipelineCI.pViewportState->scissorCount) { 280029d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 280129d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 280229d196e071b2dc1db47702085469396f2b956820Chris Forbes "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 280329d196e071b2dc1db47702085469396f2b956820Chris Forbes ", but PSO scissorCount is %u. These counts must match.", 280429d196e071b2dc1db47702085469396f2b956820Chris Forbes pCB->scissors.size(), pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 280529d196e071b2dc1db47702085469396f2b956820Chris Forbes } 280629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 280729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 280829d196e071b2dc1db47702085469396f2b956820Chris Forbes 280929d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify that any MSAA request in PSO matches sample# in bound FB 281029d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip the check if rasterization is disabled. 281129d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pPipeline->graphicsPipelineCI.pRasterizationState || 281229d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 281329d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 281429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->activeRenderPass) { 281529d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkRenderPassCreateInfo *render_pass_info = pCB->activeRenderPass->pCreateInfo; 281629d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 281729d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits subpass_num_samples = VkSampleCountFlagBits(0); 281829d196e071b2dc1db47702085469396f2b956820Chris Forbes uint32_t i; 281929d196e071b2dc1db47702085469396f2b956820Chris Forbes 282029d196e071b2dc1db47702085469396f2b956820Chris Forbes const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 282129d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 282229d196e071b2dc1db47702085469396f2b956820Chris Forbes (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 282329d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 2824eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2825ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 2826eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 2827414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 2828eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 2829eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 2830ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 283129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 2832eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 283329d196e071b2dc1db47702085469396f2b956820Chris Forbes for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 283429d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits samples; 2835eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 283629d196e071b2dc1db47702085469396f2b956820Chris Forbes if (subpass_desc->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) 283729d196e071b2dc1db47702085469396f2b956820Chris Forbes continue; 2838eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 283929d196e071b2dc1db47702085469396f2b956820Chris Forbes samples = render_pass_info->pAttachments[subpass_desc->pColorAttachments[i].attachment].samples; 284029d196e071b2dc1db47702085469396f2b956820Chris Forbes if (subpass_num_samples == static_cast<VkSampleCountFlagBits>(0)) { 284129d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = samples; 284229d196e071b2dc1db47702085469396f2b956820Chris Forbes } else if (subpass_num_samples != samples) { 284329d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = static_cast<VkSampleCountFlagBits>(-1); 284429d196e071b2dc1db47702085469396f2b956820Chris Forbes break; 2845eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 284629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 284729d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((subpass_desc->pDepthStencilAttachment != NULL) && 284829d196e071b2dc1db47702085469396f2b956820Chris Forbes (subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 284929d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSampleCountFlagBits samples = 2850eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young render_pass_info->pAttachments[subpass_desc->pDepthStencilAttachment->attachment].samples; 285129d196e071b2dc1db47702085469396f2b956820Chris Forbes if (subpass_num_samples == static_cast<VkSampleCountFlagBits>(0)) 285229d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = samples; 285329d196e071b2dc1db47702085469396f2b956820Chris Forbes else if (subpass_num_samples != samples) 285429d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = static_cast<VkSampleCountFlagBits>(-1); 285529d196e071b2dc1db47702085469396f2b956820Chris Forbes } 2856eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 285729d196e071b2dc1db47702085469396f2b956820Chris Forbes if (((subpass_desc->colorAttachmentCount > 0) || (subpass_desc->pDepthStencilAttachment != NULL)) && 285829d196e071b2dc1db47702085469396f2b956820Chris Forbes (pso_num_samples != subpass_num_samples)) { 285929d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 2860eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2861ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 2862414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 2863414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 2864ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 2865ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 2866eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 286729d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 286829d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 286929d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 287029d196e071b2dc1db47702085469396f2b956820Chris Forbes "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 287129d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 2872eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2873eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2874528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // Verify that PSO creation renderPass is compatible with active renderPass 2875528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (pCB->activeRenderPass) { 2876528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis std::string err_string; 2877528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (!verify_renderpass_compatibility(my_data, pCB->activeRenderPass->renderPass, pPipeline->graphicsPipelineCI.renderPass, 2878528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis err_string)) { 2879528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with 2880528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis skip_call |= 2881528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2882528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 2883528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " 2884528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 2885528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), reinterpret_cast<uint64_t &>(pPipeline), 2886528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); 2887528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 2888528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 288929d196e071b2dc1db47702085469396f2b956820Chris Forbes // TODO : Add more checks here 289029d196e071b2dc1db47702085469396f2b956820Chris Forbes 2891eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 2892eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2893eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 28945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 2895e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, const bool indexedDraw, 2896e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipelineBindPoint bindPoint) { 2897e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 28987a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto const &state = pCB->lastBound[bindPoint]; 28997a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, state.pipeline); 290022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 290122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 290222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 290322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 290422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 290522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 290622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 290722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 290822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 29093d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 29107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 29117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 29127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 29135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 291422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (state.pipelineLayout) { 291522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 2916169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes auto pipelineLayout = (bindPoint == VK_PIPELINE_BIND_POINT_GRAPHICS) ? pPipe->graphicsPipelineCI.layout : pPipe->computePipelineCI.layout; 2917169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes 291822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2919dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes vector<std::tuple<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>, std::vector<uint32_t> const *>> activeSetBindingsPairs; 2920dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes for (auto & setBindingPair : pPipe->active_slots) { 292122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 292222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 292322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 292422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 292522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 2926414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 292722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 292871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], 2929169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes pipelineLayout, setIndex, errorString)) { 293022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Set is bound but not compatible w/ overlapping pipelineLayout from PSO 293171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); 293222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 293322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 293422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 2935414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 2936414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 2937169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes (uint64_t)setHandle, setIndex, (uint64_t)pipelineLayout, errorString.c_str()); 293822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 293922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 294071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis cvdescriptorset::DescriptorSet *pSet = state.boundDescriptorSets[setIndex]; 294122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 2942dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes activeSetBindingsPairs.push_back(std::make_tuple(pSet, setBindingPair.second, 2943dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes &state.dynamicOffsets[setIndex])); 294422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 294522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 2946397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 294722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis for (auto binding : setBindingPair.second) { 2948397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 294922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 295022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2951397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2952414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 295322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 2954397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 2955fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 29565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 295922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 296022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 296122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, pCB, activeSetBindingsPairs); 296222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 2963eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2964eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 296529d196e071b2dc1db47702085469396f2b956820Chris Forbes if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 296629d196e071b2dc1db47702085469396f2b956820Chris Forbes result |= validatePipelineDrawtimeState(my_data, state, pCB, pPipe); 2967eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 29685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 29695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2971a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 2972a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 2973a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 2974a27508babf63d50aea75883a3702979193c23683Mark Young 2975a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 2976a27508babf63d50aea75883a3702979193c23683Mark Young if ((VK_FALSE == my_data->phys_dev_properties.features.wideLines) && (1.0f != lineWidth)) { 2977a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 2978a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 2979a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 2980a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 2981a27508babf63d50aea75883a3702979193c23683Mark Young } else { 2982a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 2983a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 2984a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 2985a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 2986a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 2987a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 2988a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 2989a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 2990a27508babf63d50aea75883a3702979193c23683Mark Young } 2991a27508babf63d50aea75883a3702979193c23683Mark Young } 2992a27508babf63d50aea75883a3702979193c23683Mark Young 2993a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 2994a27508babf63d50aea75883a3702979193c23683Mark Young} 2995a27508babf63d50aea75883a3702979193c23683Mark Young 29965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 2997e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 2998e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 2999e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 30005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 30025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 30045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 30055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 30065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 30075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 30085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 30095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 30105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 30135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 30145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 30155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 30195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 30205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 30215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 30235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 30245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 30275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 30305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3034b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 30353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 303626c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3037c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 3038c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski if ((pAttachments[0].blendEnable != pAttachments[i].blendEnable) || 3039c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcColorBlendFactor != pAttachments[i].srcColorBlendFactor) || 3040c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstColorBlendFactor != pAttachments[i].dstColorBlendFactor) || 3041c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorBlendOp != pAttachments[i].colorBlendOp) || 3042c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcAlphaBlendFactor != pAttachments[i].srcAlphaBlendFactor) || 3043c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstAlphaBlendFactor != pAttachments[i].dstAlphaBlendFactor) || 3044c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].alphaBlendOp != pAttachments[i].alphaBlendOp) || 3045c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorWriteMask != pAttachments[i].colorWriteMask)) { 3046c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski skipCall |= 3047c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3048c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski DRAWSTATE_INDEPENDENT_BLEND, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " 3049c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski "enabled, all elements of pAttachments must be identical"); 3050c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 30515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3054b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 30555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 30565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 30595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 30605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 30625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 30635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 30645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 30675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 30685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3071a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 30725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 30735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 307416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(my_data, pPipeline->graphicsPipelineCI.renderPass); 307516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass && 307616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeline->graphicsPipelineCI.subpass >= renderPass->pCreateInfo->subpassCount) { 30775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 30795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "is out of range for this renderpass (0..%u)", 308016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeline->graphicsPipelineCI.subpass, renderPass->pCreateInfo->subpassCount - 1); 30815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3083e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->phys_dev_properties.features, 308469f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 3085e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall = true; 30865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 308752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 308852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 308952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 309052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 309152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 309252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 309352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 309452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 309552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 309652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 309752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 30985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 31035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 31065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 31075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 31095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 31105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 31125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 31135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 31165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 31185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 31195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 31215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 31225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3123ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3124ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 31255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 31285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology for tessellation pipelines"); 31295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3130ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3131ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 31325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 31335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology is only valid for tessellation pipelines"); 31375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3138ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 3139ca546210846c65808717f8875deae39bd227c240Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3140ca546210846c65808717f8875deae39bd227c240Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 3141ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "Invalid Pipeline CreateInfo State: " 3142ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 3143ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3144ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3145ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 31465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology used with patchControlPoints value %u." 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " patchControlPoints should be >0 and <=32.", 3151ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 31525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3154a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3155a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3156a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 3157a27508babf63d50aea75883a3702979193c23683Mark Young skipCall |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 3158a27508babf63d50aea75883a3702979193c23683Mark Young pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3159a27508babf63d50aea75883a3702979193c23683Mark Young } 3160a27508babf63d50aea75883a3702979193c23683Mark Young } 31615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 31625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 31635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 31645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 316545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 31665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 31695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and scissors are dynamic PSO must include " 31705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 31715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 31725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 31735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 3176ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 3177ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 31795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3180e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3181e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 31825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 31835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 31845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 31855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 31885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 31895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetViewport().", 31905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 31915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 31945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 31955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 31965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 31995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 32005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetScissor().", 32015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 32025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 32075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 32125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3213ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3214ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 32155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 32175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 32205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 3222e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin EhlisDESCRIPTOR_POOL_NODE *getPoolNode(const layer_data *dev_data, const VkDescriptorPool pool) { 3223bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis auto pool_it = dev_data->descriptorPoolMap.find(pool); 3224bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis if (pool_it == dev_data->descriptorPoolMap.end()) { 32255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 32265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3227bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis return pool_it->second; 32285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3230e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3231e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3235e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 32365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 32395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 32405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 32455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 32495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 32505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 32515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 32545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3258fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3260fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 32615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3263fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 32645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3266fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3269fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3270e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 32715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 3272e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 32731d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 32775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3280e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 32815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3288e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 3289fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 3290fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis skipCall |= log_msg( 3291fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3292fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3293fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3294fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 32955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32994a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 33004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 33014a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 33024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 33034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33044a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 33064a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 33074a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 33084a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 33094a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33114a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 33124a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 33134a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 33144a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 33154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 33164a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 33184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 33194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 33204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 33214a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 33224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33234a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 33244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 33254a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 33264a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 33274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 33284a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 33294a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 33324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 33334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 33344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 33354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33364a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 33384a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 33394a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 33404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 33414a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 33424a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33434a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 33444a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 33454a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 33464a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 33475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 33504a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 33514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 33524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 33534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 33544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 33554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 33565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 33574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 33585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 33604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 33615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 33665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 33674a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 33684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 33694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 33704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 33714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 33724a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 33735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 33744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 33774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 33835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 33845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 33855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 33916d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, image); 33926d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!img_node) 33935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 33945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 33955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 33976d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (sub_data->second.size() >= (img_node->createInfo.arrayLayers * img_node->createInfo.mipLevels + 1)) { 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 33995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 34015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 34155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 34175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 34185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 342408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 34255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 34265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 342708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 342808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 342908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 343008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 34315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 343408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 343608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 343708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 34425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 34437068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 34447068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 34457068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 344608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 34475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 345008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 345108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 345208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 345308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 345408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 345508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 34565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 345808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 345908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 34605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 346108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 346208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 346308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 346408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 34655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 346708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 34685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 346908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 34705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 34732c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_data = getImageViewData(dev_data, imageView); 34742c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis assert(iv_data); 34752c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImage &image = iv_data->image; 34762c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImageSubresourceRange &subRange = iv_data->subresourceRange; 34775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 34785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 34795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 34825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 34835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 34845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 34895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3490e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3491e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3492e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3493e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 34945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 34955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3498414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 34995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 35025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 35035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 3504414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer.", 35055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 35095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3510f80bf38f4fb3f177b3e1be11b7b1c5edcdbf7d9bChris Forbes 3511e6651096ed8f07840447783c66827cc16d659a49Tobin Ehlis// Remove set from setMap and delete the set 35129dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 35139dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 35149dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 35159dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 35165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 35175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 35185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 35195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 35205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 35215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3522c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3523cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 35249dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 35255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3526f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 35325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 35335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPool) { 35355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 3537414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unable to find pool node for pool 0x%" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t)pool); 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: validate flags 3540397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3541cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : pPool->sets) { 35429dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 3543cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 3544f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis pPool->sets.clear(); 3545e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis // Reset available count for each type and available sets for this pool 35465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 35475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 35485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3549e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis pPool->availableSets = pPool->maxSets; 35505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 35545121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 35555121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 35565121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 355772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 355872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3559414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 35605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 35615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35625121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 35635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 35665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3567400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 35745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3576e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 35775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 35785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3582e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 35835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3584e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3585e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 3586d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && 3587d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3625e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool addCmd(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 3626e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 36275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = my_data->commandPoolMap.find(pCB->createInfo.commandPool); 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != my_data->commandPoolMap.end()) { 3629b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pool_data->second.queueFamilyIndex].queueFlags; 36305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 36525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 36535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 36575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 36595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 36605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 36615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 36625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 36675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 36685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 36785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 36827651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis case CMD_END: 36835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 36907651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else { 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 3702400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 3703400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 3705b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 371893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 371972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 372072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 372172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 372271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->RemoveBoundCommandBuffer(pCB); 372372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 372472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 372572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 372693c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 3728ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedSets.clear(); 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->updatedSets.clear(); 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedFramebuffers.clear(); 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 3736c7e6bc41aa9c6e5a677b138b9459b252cd3bedf2Mark Lobodzinski pCB->writeEventsBeforeWait.clear(); 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 3741abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 3747bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 3748bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 3749bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 3750bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 37515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 37527a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 37537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 3754400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 3755b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 3756d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.clear(); 375793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 375893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 375993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 3760f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto fbNode = getFramebuffer(dev_data, framebuffer); 3761f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (fbNode) 3762f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes fbNode->referencingCmdBuffers.erase(pCB->commandBuffer); 376393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 376493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 37657003b38da5cc27a063af3c45080f3a35438283eeTobin Ehlis pCB->activeFramebuffer = VK_NULL_HANDLE; 37665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 3772ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 3773ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 37745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 37755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 3780ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 3781ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 37825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 37953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 37965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 38115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 3819e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 3820e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 38225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 382372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 38245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 3829ca546210846c65808717f8875deae39bd227c240Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 3830ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 3831ca546210846c65808717f8875deae39bd227c240Tobin Ehlis .c_str()); 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3841414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "Cmds in CB 0x%p", (void *)cb); 38425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 3846414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3853e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 3854e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= printPipeline(my_data, cb); 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 3864e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3865e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 3869414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 3870ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 3877e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3878e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 38795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3889b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 3890d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 3891b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 389589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 389689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3912b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 391356a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 3914b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 3915b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3917b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 3918b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 3919b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3921b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 392989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3938b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 39415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 39485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 397289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 397389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 397456a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 398056a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 39815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3993b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 39996c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4004b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 40055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4007b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 40085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4009b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 40105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4012b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 40135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4014b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 40155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4016b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4017b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4018b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 40195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 402789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 40285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4032b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 40335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 4036f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 40375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 4038f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 4039f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 4040a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 4041a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 4042a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 4043fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 40445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 40455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 40465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 40501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 40511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4052b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 405303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 4054e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4055b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 40600a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 40610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 40625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 406358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4064400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 40655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 406657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis pInfo = (*ii).second.get(); 40675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, 4072414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 4073414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 40745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4079b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 40805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 4082414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 4085e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 40865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 40895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 40935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 40965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 40995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4100971020aec6166f20a12a833ebd003e0193f4160aChris Forbesstatic bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 4101e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 41025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 41035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 41045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 41055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4107414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 41085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 41095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 41115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 41125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4113856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4114856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4115856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4116971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4117414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4118856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4119414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4120414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4121414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4122856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4123856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4124856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4125856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4126971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4127414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4128856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4129856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4130856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4131856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 413839d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 4140651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic bool validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB, std::vector<VkSemaphore> const &semaphores) { 4141e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 41425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 41448718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 41458718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4148414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41508718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->in_use.fetch_add(1); 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 415472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 415572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 415671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis if (!my_data->setMap.count(set->GetSet())) { 415772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 415872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 415972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 4160414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted descriptor set 0x%" PRIx64 ".", (uint64_t)(set)); 416172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 416271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->in_use.fetch_add(1); 416372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4166651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto semaphore : semaphores) { 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode == my_data->semaphoreMap.end()) { 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 4172414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted semaphore 0x%" PRIx64 ".", reinterpret_cast<uint64_t &>(semaphore)); 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_add(1); 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 41785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode == my_data->eventMap.end()) { 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 41815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4183414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted event 0x%" PRIx64 ".", reinterpret_cast<uint64_t &>(event)); 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_add(1); 41865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4188c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine for (auto event : pCB->writeEventsBeforeWait) { 4189c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine auto eventNode = my_data->eventMap.find(event); 4190c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine eventNode->second.write_in_use++; 4191c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4195b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4196b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 4197b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4198b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4199b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4200b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4201b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4202b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4203b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4204b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4205b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4206414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4207414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4208b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4209b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4210b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4211b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4212b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4213b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4214b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4215b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4216b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4217b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4218b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4219b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4220b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4221b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4222b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4223b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4224b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4225651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void decrementResources(layer_data *my_data, CB_SUBMISSION *submission) { 4226651d92815dfff917308137bb67aacccc4f60df86Chris Forbes GLOBAL_CB_NODE *pCB = getCBNode(my_data, submission->cb); 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 42298718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 42308718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 42318718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->in_use.fetch_sub(1); 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 423572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 423672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 423771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->in_use.fetch_sub(1); 42385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4240651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto semaphore : submission->semaphores) { 42415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 42425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode != my_data->semaphoreMap.end()) { 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_sub(1); 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 42485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode != my_data->eventMap.end()) { 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_sub(1); 42505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4252c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine for (auto event : pCB->writeEventsBeforeWait) { 4253c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine auto eventNode = my_data->eventMap.find(event); 4254c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (eventNode != my_data->eventMap.end()) { 4255c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine eventNode->second.write_in_use--; 4256c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 4257c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 42585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 42595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 42605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto eventStagePair : pCB->eventToStageMap) { 42625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 42635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4265a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// For fenceCount fences in pFences, mark fence signaled, decrement in_use, and call 4266a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// decrementResources for all priorFences and cmdBuffers associated with fence. 4267b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 4268b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4269ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis std::vector<std::pair<VkFence, FENCE_NODE *>> fence_pairs; 42705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 4271accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes auto pFence = getFenceNode(my_data, pFences[i]); 4272cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (!pFence || pFence->state != FENCE_INFLIGHT) 4273cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes continue; 4274cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 4275cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_pairs.emplace_back(pFences[i], pFence); 4276cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_RETIRED; 4277cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 4278accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes decrementResources(my_data, static_cast<uint32_t>(pFence->priorFences.size()), 4279accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes pFence->priorFences.data()); 4280accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes for (auto & submission : pFence->submissions) { 4281651d92815dfff917308137bb67aacccc4f60df86Chris Forbes decrementResources(my_data, &submission); 4282651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= cleanInFlightCmdBuffer(my_data, submission.cb); 4283651d92815dfff917308137bb67aacccc4f60df86Chris Forbes removeInFlightCmdBuffer(my_data, submission.cb); 42845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4285accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes pFence->submissions.clear(); 4286accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes pFence->priorFences.clear(); 42875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4288ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis for (auto fence_pair : fence_pairs) { 42896bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis for (auto queue : fence_pair.second->queues) { 4290df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pQueue = getQueueNode(my_data, queue); 4291df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes if (pQueue) { 42926bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto last_fence_data = 4293df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes std::find(pQueue->lastFences.begin(), pQueue->lastFences.end(), fence_pair.first); 4294df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes if (last_fence_data != pQueue->lastFences.end()) 4295df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes pQueue->lastFences.erase(last_fence_data); 42966bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis } 4297bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4298be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine for (auto& fence_data : my_data->fenceMap) { 4299be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine auto prior_fence_data = 4300be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine std::find(fence_data.second.priorFences.begin(), fence_data.second.priorFences.end(), fence_pair.first); 4301be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine if (prior_fence_data != fence_data.second.priorFences.end()) 4302be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine fence_data.second.priorFences.erase(prior_fence_data); 4303be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine } 4304bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4305b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4307a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Decrement in_use for all outstanding cmd buffers that were submitted on this queue 4308b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, VkQueue queue) { 4309b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 43105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 43115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 4312651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto & submission : queue_data->second.untrackedSubmissions) { 4313651d92815dfff917308137bb67aacccc4f60df86Chris Forbes decrementResources(my_data, &submission); 4314651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= cleanInFlightCmdBuffer(my_data, submission.cb); 4315651d92815dfff917308137bb67aacccc4f60df86Chris Forbes removeInFlightCmdBuffer(my_data, submission.cb); 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4317651d92815dfff917308137bb67aacccc4f60df86Chris Forbes queue_data->second.untrackedSubmissions.clear(); 4318b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(my_data, static_cast<uint32_t>(queue_data->second.lastFences.size()), 4319b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine queue_data->second.lastFences.data()); 43200a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4321b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 43220a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 43230a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 4324b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This function merges command buffer tracking between queues when there is a semaphore dependency 4325b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// between them (see below for details as to how tracking works). When this happens, the prior 4326b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// fences from the signaling queue are merged into the wait queue as well as any untracked command 4327b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers. 4328e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 43290a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 43300a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 43310a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 43320a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 43330a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto other_queue_data = dev_data->queueMap.find(other_queue); 43340a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue_data == dev_data->queueMap.end() || other_queue_data == dev_data->queueMap.end()) { 43350a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 43360a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4337ca32a764ef85a255c97531164bffb073553de105Jamie Madill for (auto fenceInner : other_queue_data->second.lastFences) { 4338ca32a764ef85a255c97531164bffb073553de105Jamie Madill queue_data->second.lastFences.push_back(fenceInner); 43396bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto fence_node = dev_data->fenceMap.find(fenceInner); 43406bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis if (fence_node != dev_data->fenceMap.end()) { 43416bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis fence_node->second.queues.insert(other_queue_data->first); 43426bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis } 43430a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 43444b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // TODO: Stealing the untracked CBs out of the signaling queue isn't really 43454b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // correct. A subsequent submission + wait, or a QWI on that queue, or 43464b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // another semaphore dependency to a third queue may /all/ provide 43474b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // suitable proof that the work we're stealing here has completed on the 43484b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // device, but we've lost that information by moving the tracking between 43494b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // queues. 43500a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence != VK_NULL_HANDLE) { 43510a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 43520a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence_data == dev_data->fenceMap.end()) { 43530a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 43540a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4355651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto cmdbuffer : other_queue_data->second.untrackedSubmissions) { 4356651d92815dfff917308137bb67aacccc4f60df86Chris Forbes fence_data->second.submissions.push_back(cmdbuffer); 43570a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4358651d92815dfff917308137bb67aacccc4f60df86Chris Forbes other_queue_data->second.untrackedSubmissions.clear(); 43590a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 4360651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto cmdbuffer : other_queue_data->second.untrackedSubmissions) { 4361651d92815dfff917308137bb67aacccc4f60df86Chris Forbes queue_data->second.untrackedSubmissions.push_back(cmdbuffer); 43620a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4363651d92815dfff917308137bb67aacccc4f60df86Chris Forbes other_queue_data->second.untrackedSubmissions.clear(); 43645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4365b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto eventStagePair : other_queue_data->second.eventToStageMap) { 4366b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[eventStagePair.first] = eventStagePair.second; 4367b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 4368d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto queryStatePair : other_queue_data->second.queryToStateMap) { 4369d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[queryStatePair.first] = queryStatePair.second; 4370d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 43715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4373b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This is the core function for tracking command buffers. There are two primary ways command 4374b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers are tracked. When submitted they are stored in the command buffer list associated 4375b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// with a fence or the untracked command buffer list associated with a queue if no fence is used. 4376b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Each queue also stores the last fence that was submitted onto the queue. This allows us to 4377b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// create a linked list of fences and their associated command buffers so if one fence is 4378b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on, prior fences on that queue are also considered to have been waited on. When a fence is 4379b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on (either via a queue, device or fence), we free the cmd buffers for that fence and 4380b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// recursively call with the prior fences. 4381651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4382651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4383651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// Submit a fence to a queue, delimiting previous fences and previous untracked 4384651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// work by it. 4385651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void 4386651d92815dfff917308137bb67aacccc4f60df86Chris ForbesSubmitFence(QUEUE_NODE *pQueue, FENCE_NODE *pFence) 4387651d92815dfff917308137bb67aacccc4f60df86Chris Forbes{ 4388651d92815dfff917308137bb67aacccc4f60df86Chris Forbes assert(!pFence->priorFences.size()); 4389651d92815dfff917308137bb67aacccc4f60df86Chris Forbes assert(!pFence->submissions.size()); 4390651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4391651d92815dfff917308137bb67aacccc4f60df86Chris Forbes std::swap(pFence->priorFences, pQueue->lastFences); 4392651d92815dfff917308137bb67aacccc4f60df86Chris Forbes std::swap(pFence->submissions, pQueue->untrackedSubmissions); 4393651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4394651d92815dfff917308137bb67aacccc4f60df86Chris Forbes pFence->queues.insert(pQueue->queue); 4395cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_INFLIGHT; 4396651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4397651d92815dfff917308137bb67aacccc4f60df86Chris Forbes pQueue->lastFences.push_back(pFence->fence); 4398b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4399b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4400b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic void markCommandBuffersInFlight(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 4401b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VkFence fence) { 4402b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine auto queue_data = my_data->queueMap.find(queue); 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 44045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 44055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 44065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 4407b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Add cmdBuffers to the global set and increment count 4408b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, submit->pCommandBuffers[i]); 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 44105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(secondaryCmdBuffer); 4411b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pSubCB = getCBNode(my_data, secondaryCmdBuffer); 4412b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pSubCB->in_use.fetch_add(1); 44135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 4415b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_add(1); 44165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4421e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 44225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 44235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 44245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 44255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 44265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 442727c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4428414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 44295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 44305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 44325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 44360a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 44370a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 44380a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 44390a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4440414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 4441414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "set, but has been submitted 0x%" PRIxLEAST64 " times.", 44420a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 44430a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 44475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 44485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool causeReported = false; 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedSets.empty()) { 44505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 44515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->destroyedSets) 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4457414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) destroyed: %s", 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 44605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->updatedSets.empty()) { 44635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 44645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->updatedSets) 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4470414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) updated: %s", 44725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedFramebuffers.empty()) { 44765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream fb_string; 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto fb : pCB->destroyedFramebuffers) 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_string << " " << fb; 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4483414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because it had the following " 44845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "referenced framebuffers destroyed: %s", 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), fb_string.str().c_str()); 44865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This is defensive programming to make sure an error is 44895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // flagged if we hit this INVALID cmd buffer case and none of the 44905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // above cases are hit. As the number of INVALID cases grows, this 44915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // code should be updated to seemlessly handle all the cases. 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!causeReported) { 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4496414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid due to an unknown cause. Validation " 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "should " 44985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "be improved to report the exact cause.", 44995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer)); 45005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 45035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4505414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You must call vkEndCommandBuffer() on CB 0x%" PRIxLEAST64 " before this call to vkQueueSubmit()!", 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 45075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4512651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, std::vector<VkSemaphore> const &semaphores) { 45135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 4514651d92815dfff917308137bb67aacccc4f60df86Chris Forbes bool skipCall = validateAndIncrementResources(dev_data, pCB, semaphores); 45155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 45165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 4517651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skipCall |= validateAndIncrementResources(dev_data, dev_data->commandBufferMap[secondaryCmdBuffer], semaphores); 45185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 45194c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 45204c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 45215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 45225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4523414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 4525414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 45264c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 45275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 45285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pCB); 45335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 45345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // on device 45355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferSimultaneousUse(dev_data, pCB); 45365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 453981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbesstatic bool 4540651d92815dfff917308137bb67aacccc4f60df86Chris ForbesValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) 454181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes{ 4542e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 454381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4544651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4545cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_INFLIGHT) { 4546a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4547651d92815dfff917308137bb67aacccc4f60df86Chris Forbes (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 4548651d92815dfff917308137bb67aacccc4f60df86Chris Forbes "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); 4549a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 455081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4551cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes else if (pFence->state == FENCE_RETIRED) { 4552a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4553651d92815dfff917308137bb67aacccc4f60df86Chris Forbes reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4554414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 4555651d92815dfff917308137bb67aacccc4f60df86Chris Forbes reinterpret_cast<uint64_t &>(pFence->fence)); 4556a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 45575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 455881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 455981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes return skipCall; 456081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes} 456181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4562651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 456381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL 456481c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 456581c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes bool skipCall = false; 456681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 456781c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 456881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 456981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4570651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 4571651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 4572651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skipCall |= ValidateFenceForSubmit(dev_data, pFence); 457381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4574d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes if (skipCall) { 4575d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 4576d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes } 4577d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes 45781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 45791344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 45801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 4581651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4582651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // Mark the fence in-use. 4583651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4584651d92815dfff917308137bb67aacccc4f60df86Chris Forbes SubmitFence(pQueue, pFence); 4585651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4586651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4587651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // If a fence is supplied, all the command buffers for this call will be 4588651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // delimited by that fence. Otherwise, they go in the untracked portion of 4589651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // the queue, and may end up being delimited by a fence supplied in a 4590651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // subsequent submission. 4591651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto & submitTarget = pFence ? pFence->submissions : pQueue->untrackedSubmissions; 4592651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 45935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 45940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 45955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 45965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 45975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 45985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 45990a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pWaitSemaphores[i]; 460041bb23666442c59912c630f85db04ce1a052f3efTobin Ehlis semaphoreList.push_back(semaphore); 46011344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 46021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 46031344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 46041344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 46051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 46061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 46071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4608414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 46091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 46101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkQueue &other_queue = dev_data->semaphoreMap[semaphore].queue; 46121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 46131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 46141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis processed_other_queues.insert(other_queue); 46151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 46190a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pSignalSemaphores[i]; 46201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 46211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis semaphoreList.push_back(semaphore); 46221344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 46231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 46241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 46251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4626414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 4627414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 46281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 46291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(dev_data->semaphoreMap[semaphore].queue)); 46301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 46311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 46321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].queue = queue; 46331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46340a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 46355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4636651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4637651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // TODO: just add one submission per VkSubmitInfo! 46385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 4639971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 4640971020aec6166f20a12a833ebd003e0193f4160aChris Forbes skipCall |= ValidateCmdBufImageLayouts(dev_data, pCBNode); 46411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 4642651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4643651d92815dfff917308137bb67aacccc4f60df86Chris Forbes submitTarget.emplace_back(pCBNode->commandBuffer, semaphoreList); 4644651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto secondaryCmdBuffer : pCBNode->secondaryCommandBuffers) { 4645651d92815dfff917308137bb67aacccc4f60df86Chris Forbes submitTarget.emplace_back(secondaryCmdBuffer, semaphoreList); 4646651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4647651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 46481344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 4649651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skipCall |= validatePrimaryCommandBufferState(dev_data, pCBNode, semaphoreList); 46501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 46511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 46521344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(); 46531344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46541344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 46551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(queue); 46561344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 4657d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto &function : pCBNode->queryUpdates) { 4658d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skipCall |= function(queue); 4659d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 46601344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4663b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine markCommandBuffersInFlight(dev_data, queue, submitCount, pSubmits, fence); 4664b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4665e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 46665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 46675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 467189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 467289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 46735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 46755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 4676b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 46775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 46780a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 46795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 468289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 468389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 46845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 46875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 46885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 46905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 46915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 46925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4693b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 4694e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves freeMemObjInfo(my_data, device, mem, false); 46950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 46960a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 4697b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 46985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4701e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 4702e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 47035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 47057c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 47065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 47075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 47085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 47115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 471257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = mem_element->second.get(); 47135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 471457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->memRange.size != 0) { 47155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 47165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 4717414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 47185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 47215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 472257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (offset >= mem_info->allocInfo.allocationSize) { 47235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 47245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 472557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 472657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, 472757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis offset, mem_info->allocInfo.allocationSize, mem_info->allocInfo.allocationSize); 47285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 473057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if ((offset + size) > mem_info->allocInfo.allocationSize) { 473157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis skipCall = 473257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 473357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 473457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64, offset, 473557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis size + offset, mem_info->allocInfo.allocationSize); 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4742e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 474357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 474457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 474557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->memRange.offset = offset; 474657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->memRange.size = size; 47475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4750e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 4751e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 475257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 475357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 475457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (!mem_info->memRange.size) { 47555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 47565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 47575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 4758414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 47595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 476057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->memRange.size = 0; 476157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->pData) { 476257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis free(mem_info->pData); 476357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pData = 0; 47645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 47675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 47705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4771b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 477257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 477357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 477457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pDriverData = *ppData; 477557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis uint32_t index = mem_info->allocInfo.memoryTypeIndex; 4776b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 477757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pData = 0; 47785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 478057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis size = mem_info->allocInfo.allocationSize; 47815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 478357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pData = malloc(2 * convSize); 478457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis memset(mem_info->pData, NoncoherentMemoryFillValue, 2 * convSize); 478557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis *ppData = static_cast<char *>(mem_info->pData) + (convSize / 2); 47865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4789a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 4790a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// a fence being waited on should not already be signalled and 4791a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 479249f6132af865afd5b7f413c91125971ac97c135aChris Forbesstatic inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { 4793e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 47949b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes 479549f6132af865afd5b7f413c91125971ac97c135aChris Forbes auto pFence = getFenceNode(dev_data, fence); 47969b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes if (pFence) { 4797cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_UNSIGNALED) { 4798cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4799cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4800cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 4801cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes "acquire next image.", 4802cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes apiCall, reinterpret_cast<uint64_t &>(fence)); 48035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 48065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4807a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 480889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 480989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 48105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4811e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 4813b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 481549f6132af865afd5b7f413c91125971ac97c135aChris Forbes skip_call |= verifyWaitFenceState(dev_data, pFences[i], "vkWaitForFences"); 48165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4817b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 48185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 48195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 4820a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 48215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 4822414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 48235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 4824b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 48265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 4827b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, fenceCount, pFences); 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 48305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 48315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 4832b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 48335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4834e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 483989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 48405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 48425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 4843b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 484449f6132af865afd5b7f413c91125971ac97c135aChris Forbes skipCall = verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); 4845b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4846a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 48485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 4849a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 48505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 4851e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4852b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 48535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 4854b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skipCall |= decrementResources(dev_data, 1, &fence); 48555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4856b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4857e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 486289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 4863b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 48645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 4866b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 4867b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 4868b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 4869b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 4870b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 4871b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 48728988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes pQNode->queue = *pQueue; 4873b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 4874b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 48755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 487789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 48785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 4879e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4880b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 4881e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 48845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 488789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 4888e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4890b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 4892b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 48935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 4895b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4896e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 48995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 49005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 490289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 49035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 4905b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 49061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 49071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 4908cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (fence_pair->second.state == FENCE_INFLIGHT) { 49091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 49101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 4911cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes "Fence 0x%" PRIx64 " is in use.", (uint64_t)(fence)); 49121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 49131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 49145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4915b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 49161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 49175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 49185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 49195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 492189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 492289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 49235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 4925b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 49265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 49275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 49285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 49305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 4931414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete semaphore 0x%" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 49345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 49365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 493889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 49395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 4941b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto event_data = dev_data->eventMap.find(event); 49435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data != dev_data->eventMap.end()) { 49445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data->second.in_use.load()) { 49455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg( 49465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 49475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4948414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete event 0x%" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap.erase(event_data); 49515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4952b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 49535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 49565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 495889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 495989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 49625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 49635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 496589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 496689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 496789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 49685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 4970b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 49715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 4972971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 49735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 49745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 49755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4977e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 49785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 49795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 49805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 49815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 49825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 4983ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 4984ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 4985ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 4986ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 4987971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 4988ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 4989ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 4990ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4991ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 4992414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 4993ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 4994ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 4995ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 4996ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 4997ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4998ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4999ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5000ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5001ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5002ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5003ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5004ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5005ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5006971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5007ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5008ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5009ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 50105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 50115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5012414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 50135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 50145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5015ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5016ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 50175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 50185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5019414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5021ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5022ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5023ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5024ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5025414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 5026ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5027ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 50285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5031b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 50325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 50335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 50365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5038e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5039e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 50408718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 50418718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 50425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 50435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 5044414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 50468718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node->in_use.load()) { 50475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 50485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5049414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 50505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 50535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 505547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 505647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 505747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 505847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 5059414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Buffer 0x%" PRIx64 " is aliased with image 0x%" PRIx64, object_handle, 506047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 506147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } else { 506247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 5063414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Image 0x%" PRIx64 " is aliased with buffer 0x%" PRIx64, object_handle, 506447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 506547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 506647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 506747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 506847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 506947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 507047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski bool skip_call = false; 507147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 507247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (auto range : ranges) { 507347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) < 507447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 507547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 507647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) > 507747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 507847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 507947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 508047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 508147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return skip_call; 508247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 508347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 508447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic MEMORY_RANGE insert_memory_ranges(uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 508547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges) { 508647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski MEMORY_RANGE range; 508747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 508847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.memory = mem; 508947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 509047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 509147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.push_back(range); 509247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return range; 509347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 509447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 509547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic void remove_memory_ranges(uint64_t handle, VkDeviceMemory mem, vector<MEMORY_RANGE> &ranges) { 509647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (uint32_t item = 0; item < ranges.size(); item++) { 509747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((ranges[item].handle == handle) && (ranges[item].memory == mem)) { 509847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.erase(ranges.begin() + item); 509947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski break; 510047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 510147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 510247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 510347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 510489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 510589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 51065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5107e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5108b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5109e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!validateIdleBuffer(dev_data, buffer) && !skipCall) { 5110b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 5112b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 51135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 511447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory binding and range information for buffer 51158718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 51168718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buff_it != dev_data->bufferMap.end()) { 511757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, buff_it->second.get()->mem); 511857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 511957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis remove_memory_ranges(reinterpret_cast<uint64_t &>(buffer), buff_it->second.get()->mem, mem_info->bufferRanges); 512047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 512147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 51228718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis dev_data->bufferMap.erase(buff_it); 512347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 51245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 512689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 512789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 51285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 5130b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 51315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 51325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 51335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 513789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 51385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5139e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 514047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (!skipCall) { 51415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 514247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5144b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 514547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &imageEntry = dev_data->imageMap.find(image); 514647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (imageEntry != dev_data->imageMap.end()) { 514747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory mapping, bindings and range references for image 51486d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, imageEntry->second.get()->mem); 514957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 51506d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis remove_memory_ranges(reinterpret_cast<uint64_t &>(image), imageEntry->second.get()->mem, mem_info->imageRanges); 515147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 515257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->image = VK_NULL_HANDLE; 515347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 515458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 515547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski dev_data->imageMap.erase(imageEntry); 51565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 51585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 51605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 51615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 51635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51664261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinskistatic bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, 51674261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski const char *funcName) { 51684261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski bool skip_call = false; 51694261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski if (((1 << mem_info->allocInfo.memoryTypeIndex) & memory_type_bits) == 0) { 51704261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 51714261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, MEMTRACK_INVALID_MEM_TYPE, "MT", 51724261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " 51734261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "type (0x%X) of this memory object 0x%" PRIx64 ".", 51744261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski funcName, memory_type_bits, mem_info->allocInfo.memoryTypeIndex, 51754261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski reinterpret_cast<const uint64_t &>(mem_info->mem)); 51764261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski } 51774261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski return skip_call; 51784261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski} 51794261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski 518089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 518189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 518258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5184b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 51855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 51865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 5187e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = 518894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 51898718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 51908718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 51918718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->mem = mem; 51925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 519394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 519447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 519547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 519657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 519757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 519847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 519957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis insert_memory_ranges(buffer_handle, mem, memoryOffset, memRequirements, mem_info->bufferRanges); 520057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis skipCall |= validate_memory_range(dev_data, mem_info->imageRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 52014261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski skipCall |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "BindBufferMemory"); 520247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 520347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 52042c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 52052c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 52062c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52072c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 52082c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5209414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5210414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 52112c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 52122c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 52132c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52142c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 52158718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; 52162c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & (VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT)) { 5217b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment) != 0) { 52182c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52192c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 52202c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5221414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5222414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minTexelBufferOffsetAlignment 0x%" PRIxLEAST64, 5223b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment); 52242c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52252c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52262c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT) { 5227b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 5228b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 52292c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52302c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 52312c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 5232414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5233414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 5234b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 52352c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52362c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52372c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_STORAGE_BUFFER_BIT) { 5238b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 5239b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 52402c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52412c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 52422c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 5243414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5244414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 5245b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 52462c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52472c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52490a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5250b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5251e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 525258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 52535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 525789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 525889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 52595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 52615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 52625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 52635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 526589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 526689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 52675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 52695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 52705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 52715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5272593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 527389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 527489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 52755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 52765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 52775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 528089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 528189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5282918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5283918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5284b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5285918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5286b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5287918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5288918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 52895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 529189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 529289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 52945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 529789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 529889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 52995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 53005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 53015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 53025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 530489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 530589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 53065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 53075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 53085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 531089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 531189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 53135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 53145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 53155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 531789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 531889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 53205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 53225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5323bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 5324bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 5325bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 5326bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 5327bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 5328bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5329bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 5330bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 5331bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 5332bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 5333bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 5334bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 5335bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 5336414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use.", action, 5337bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 5338bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } else { // Secondary CB w/o primary in-flight, remove from in-flight 5339bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 5340bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5341bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5342bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5343bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 5344bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 5345bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBuffersInFlight(layer_data *dev_data, const VkCommandPool commandPool, const char *action) { 5346bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5347bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto pool_data = dev_data->commandPoolMap.find(commandPool); 5348bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (pool_data != dev_data->commandPoolMap.end()) { 5349bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto cmd_buffer : pool_data->second.commandBuffers) { 5350bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 5351bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 5352bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5353bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5354bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5355bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5356bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 53575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 535889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 535989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5363b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 5365bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto cb_pair = dev_data->commandBufferMap.find(pCommandBuffers[i]); 5366bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, cb_pair->second, "free"); 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 5368bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (cb_pair != dev_data->commandBufferMap.end()) { 53695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 5370bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis resetCB(dev_data, (*cb_pair).second->commandBuffer); 5371bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis delete (*cb_pair).second; 5372bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->commandBufferMap.erase(cb_pair); 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 53765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]); 53775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53780a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 5379b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 53825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 538589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 538689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 538789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5393b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 53955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 540089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 540189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 54055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5406b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 541389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 541489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 54155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5417b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 5419bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis VkBool32 result = checkAndClearCommandBuffersInFlight(dev_data, commandPool, "destroy command pool with"); 54205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap 542141051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes auto pool_it = dev_data->commandPoolMap.find(commandPool); 542241051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes if (pool_it != dev_data->commandPoolMap.end()) { 542341051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes for (auto cb : pool_it->second.commandBuffers) { 542441051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 542541051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes auto del_cb = dev_data->commandBufferMap.find(cb); 542641051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes delete del_cb->second; // delete CB info structure 542772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer 54285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap.erase(commandPool); 54315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5432b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5434f90830842fdd43e8f1834f2eb76bda28eef435b8Tony Barbour if (result) 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 54385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 544189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 544289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 54435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5446400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 5447bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (checkAndClearCommandBuffersInFlight(dev_data, commandPool, "reset command pool with")) 54485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 54515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 54525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 54545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5455b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 54575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 54585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*it)); 54595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 54605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 546589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 54665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 54685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5469b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 5471df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 5472df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes if (pFence) { 5473cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_INFLIGHT) { 5474a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= 5475a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 5476a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 5477cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes "Fence 0x%" PRIx64 " is in use.", reinterpret_cast<const uint64_t &>(pFences[i])); 54785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5479cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_UNSIGNALED; 5480cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 5481cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes // TODO: these should really have already been enforced on 5482cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes // INFLIGHT->RETIRED transition. 5483cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->queues.clear(); 5484cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->priorFences.clear(); 54855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5487b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 54895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 54905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 549389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 549489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 54955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5496b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(framebuffer); 54985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 54995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : fbNode->second.referencingCmdBuffers) { 55005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cbNode = dev_data->commandBufferMap.find(cb); 55015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cbNode != dev_data->commandBufferMap.end()) { 55025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set CB as invalid and record destroyed framebuffer 55035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->state = CB_INVALID; 55045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->destroyedFramebuffers.insert(framebuffer); 55055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5507f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes delete [] fbNode->second.createInfo.pAttachments; 5508f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes dev_data->frameBufferMap.erase(fbNode); 55095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5510b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 55125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 551489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 551589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 55165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 5518b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 55205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 552289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 552389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 55245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 552547892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 552647892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 55275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5529b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 55318718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_NODE>(new BUFFER_NODE(pCreateInfo)))); 55325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 553689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 553789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 55385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5541b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55422f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis dev_data->bufferViewMap[*pView] = unique_ptr<VkBufferViewCreateInfo>(new VkBufferViewCreateInfo(*pCreateInfo)); 55435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 55450a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_buffer_usage_flags(dev_data, pCreateInfo->buffer, 5546e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 55485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 555289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 555389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 555547892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 555647892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5559b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 55615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 55625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 55636d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, unique_ptr<IMAGE_NODE>(new IMAGE_NODE(pCreateInfo)))); 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 55665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 5572b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 55735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55746d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 55756d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 55775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 55785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 55795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 55805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 55816d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->levelCount = image_node->createInfo.mipLevels - range->baseMipLevel; 55825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 55856d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->layerCount = image_node->createInfo.arrayLayers - range->baseArrayLayer; 55865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 55915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 55925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 55935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 5594b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 55955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 55975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 55986d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 55996d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 56005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 56016d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *levels = image_node->createInfo.mipLevels - range.baseMipLevel; 56025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 56046d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *layers = image_node->createInfo.arrayLayers - range.baseArrayLayer; 56055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 560989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 561089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 5611bb6624cb996175d8945190886a200e720b3871efChris Forbes bool skipCall = false; 5612bb6624cb996175d8945190886a200e720b3871efChris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 56135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5614bb6624cb996175d8945190886a200e720b3871efChris Forbes { 5615bb6624cb996175d8945190886a200e720b3871efChris Forbes // Validate that img has correct usage flags set 5616bb6624cb996175d8945190886a200e720b3871efChris Forbes std::lock_guard<std::mutex> lock(global_lock); 5617bb6624cb996175d8945190886a200e720b3871efChris Forbes skipCall |= validate_image_usage_flags(dev_data, pCreateInfo->image, 5618bb6624cb996175d8945190886a200e720b3871efChris Forbes VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 5619bb6624cb996175d8945190886a200e720b3871efChris Forbes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 5620bb6624cb996175d8945190886a200e720b3871efChris Forbes false, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 5621bb6624cb996175d8945190886a200e720b3871efChris Forbes } 5622bb6624cb996175d8945190886a200e720b3871efChris Forbes 5623bb6624cb996175d8945190886a200e720b3871efChris Forbes if (!skipCall) { 5624bb6624cb996175d8945190886a200e720b3871efChris Forbes result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 5625bb6624cb996175d8945190886a200e720b3871efChris Forbes } 5626bb6624cb996175d8945190886a200e720b3871efChris Forbes 56275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5628b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 56292c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis dev_data->imageViewMap[*pView] = unique_ptr<VkImageViewCreateInfo>(new VkImageViewCreateInfo(*pCreateInfo)); 56302c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[*pView].get()->subresourceRange, pCreateInfo->image); 56315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5632bb6624cb996175d8945190886a200e720b3871efChris Forbes 56335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 563689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 563789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 56385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 56405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5641b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5642a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 56438988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes fence_node.fence = *pFence; 5644a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 5645cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; 56465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 565189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 565289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 56535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 56555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 565989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 56605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 56625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 566589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 56665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 56685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 567289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 56735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 56755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 56793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 56803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 56813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 56823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 56833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 56843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 56853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 56863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 56873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 56883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 56893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 56903d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 56913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 56923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 56933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 56943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 56953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 56963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 56973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 56983d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 569989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 570089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 570189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 570289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 57035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 57045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 57055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 57065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 57075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 57085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 5709e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 57105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 57115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 57125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5715b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 57165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 5718ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5719ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 572016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeNode[i]->renderPass = getRenderPass(dev_data, pCreateInfos[i].renderPass); 57214a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes pPipeNode[i]->pipelineLayout = getPipelineLayout(dev_data, pCreateInfos[i].layout); 572267220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 57235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 57245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5726e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 5727b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 57295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5730b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 57315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 57335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5735b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57385188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 57395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5740b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 574689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 574789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 574889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 574989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 57505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 5751e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 57525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 57545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 57555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5758b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 57595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 57615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 57635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5764ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 57654a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes pPipeNode[i]->pipelineLayout = getPipelineLayout(dev_data, pCreateInfos[i].layout); 5766ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 57675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 5769396244fbebb3dca48be8e37a828fb1034f8c410cChris Forbes skipCall |= !validate_compute_pipeline(dev_data->report_data, pPipeNode[i], 5770396244fbebb3dca48be8e37a828fb1034f8c410cChris Forbes &dev_data->phys_dev_properties.features, 5771396244fbebb3dca48be8e37a828fb1034f8c410cChris Forbes dev_data->shaderModuleMap); 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5775e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 5776b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5779b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 57805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 57825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 57835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5784b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 57885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 57895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5790b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 57925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 579689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 579789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 57985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 58005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5801b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5802cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 58035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 580789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 580889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 580989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 58105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 58125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 58135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 5814b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5815cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = 5816cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis new cvdescriptorset::DescriptorSetLayout(dev_data->report_data, pCreateInfo, *pSetLayout); 58175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58219e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 58229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 58239e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 58249e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 58259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 58265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 58279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 58289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 58299e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 58309e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 58319e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 58329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 58339e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58349e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with offset %u and size %u that " 58359e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 58369e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset, size, maxPushConstantsSize); 58379e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 58389e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58399e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 58409e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 58419e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, offset, size, maxPushConstantsSize); 58429e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 58439e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58449e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 58459e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58469e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58479e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 58489e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 58499e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 58509e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 58519e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58529e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 58539e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 58549e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, size); 58559e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 58569e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 58579e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58589e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 58599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 58609e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 58619e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 58629e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58639e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 58649e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58659e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58669e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 58679e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 58689e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 58699e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58709e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 58719e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "offset %u. Offset must be a multiple of 4.", 58729e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset); 58739e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 58749e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58759e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 58769e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "offset %u. Offset must be a multiple of 4.", 58779e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, offset); 58789e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 58799e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58809e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 58819e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 58845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 588689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 588789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 58885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 58895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58909e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 58915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 58925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 58939e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 58949e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 58959e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 58969e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58979e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 58989e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58999e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 59019e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (!skipCall) { 59029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t i, j; 59039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 59049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 59059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 59069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 59079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 59089e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 59099e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 59109e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 5911a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 59129e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 59139e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 59149e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz i, minA, maxA, j, minB, maxB); 59159e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59169e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5919f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 5920f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes if (skipCall) 5921f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 5922f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 59235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 59245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5925b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 59275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); 5928f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes plNode.setLayouts.resize(pCreateInfo->setLayoutCount); 59295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 59305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; 5931addeafba8720251f59f73dc2200bd512ae498bd5Chris Forbes plNode.setLayouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); 59325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); 59345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 59355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; 59365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 594189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 594289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 594389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 59445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 59465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 59475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 59485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 5949414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 59505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 59515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 59535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 59545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 59555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 59565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 59575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5959b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 59635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 59645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 596889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 596989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 59705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5973b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59782c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// Ensure the pool contains enough descriptors and descriptor sets to satisfy 5979789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// an allocation request. Fills common_data with the total number of descriptors of each type required, 5980789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// as well as DescriptorSetLayout ptrs used for later update. 59817f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlisstatic bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 59827f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData *common_data) { 59837e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All state checks for AllocateDescriptorSets is done in single function 5984e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehlis return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); 59857e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis} 59867e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Allocation state was good and call down chain was made so update state based on allocating descriptor sets 59877e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlisstatic void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 59887f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis VkDescriptorSet *pDescriptorSets, 59897f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis const cvdescriptorset::AllocateDescriptorSetsData *common_data) { 59907e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All the updates are contained in a single cvdescriptorset function 59912c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, 5992b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis &dev_data->setMap, dev_data); 59932c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes} 59942c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 599589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 599689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 59975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5998b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 59997f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); 60007f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); 6001b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6002d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 60037e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis if (skip_call) 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6005d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 60065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 60076511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 60085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6009b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 60107f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); 6011b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6015cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Verify state before freeing DescriptorSets 6016cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6017cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6018cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skip_call = false; 6019cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // First make sure sets being destroyed are not currently in-use 6020cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6021cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); 6022cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6023cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_node = getPoolNode(dev_data, pool); 6024cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis if (pool_node && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_node->createInfo.flags)) { 6025cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Can't Free from a NON_FREE pool 6026cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6027cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis reinterpret_cast<uint64_t &>(pool), __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 6028cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 6029cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 6030cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6031cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis return skip_call; 6032cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 6033cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Sets have been removed from the pool so update underlying state 6034cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6035cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6036cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_state = getPoolNode(dev_data, pool); 6037cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Update available descriptor sets in pool 6038cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableSets += count; 6039cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6040cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 6041cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 6042cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis auto set_state = dev_data->setMap[descriptor_sets[i]]; 6043cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis uint32_t type_index = 0, descriptor_count = 0; 6044cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t j = 0; j < set_state->GetBindingCount(); ++j) { 6045cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis type_index = static_cast<uint32_t>(set_state->GetTypeFromIndex(j)); 6046cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis descriptor_count = set_state->GetDescriptorCountFromIndex(j); 6047cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; 6048cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6049cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis freeDescriptorSet(dev_data, set_state); 6050cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->sets.erase(set_state); 6051cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6052cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 60535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 605489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 605589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 60565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6058b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6059cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skipCall = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6060b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6061e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 60625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 60635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6065b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6066cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6067b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60716b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// TODO : This is a Proof-of-concept for core validation architecture 60726b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// Really we'll want to break out these functions to separate files but 60736b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// keeping it all together here to prove out design 60746b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() 60756b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 60766b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 60776b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 60786b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // First thing to do is perform map look-ups. 60796b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets 60806b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // so we can't just do a single map look-up up-front, but do them individually in functions below 60816b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis 60826b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Now make call(s) that validate state, but don't perform state updates in this function 60836b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the 60846b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // namespace which will parse params and make calls into specific class instances 6085104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, 6086104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis descriptorCopyCount, pDescriptorCopies); 60876b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 60886b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() 60896b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 60906b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 60916b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 6092104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 60936b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 60946b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 60955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 609689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 609789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 609889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 60996b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Only map look-up at top level is for device-level layer_data 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6101b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61026b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 61036b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 6104b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 61056b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis if (!skip_call) { 61065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 61075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 61086b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis lock.lock(); 61096b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Since UpdateDescriptorSets() is void, nothing to check prior to updating state 61106b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 61116b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 61125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 611589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 611689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 61175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 61195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6120b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 612172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto const &cp_it = dev_data->commandPoolMap.find(pCreateInfo->commandPool); 612272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cp_it != dev_data->commandPoolMap.end()) { 612372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 61245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 612572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cp_it->second.commandBuffers.push_back(pCommandBuffer[i]); 61265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 61275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 61285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 61295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 61315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 61325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61340a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6135b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 614089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 614189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 6142e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 61435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6144b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 61485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 6149a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 6150a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= 6151a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6152a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 6153414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Calling vkBeginCommandBuffer() on active CB 0x%p before it has completed. " 6154a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 6155a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6157a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6165414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6169400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 61715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6173414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6176400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 61775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 61785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, 6180414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 61815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "valid framebuffer parameter is specified.", 61825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 6185f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = getFramebuffer(dev_data, pInfo->framebuffer); 6186f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (framebuffer) { 6187f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes VkRenderPass fbRP = framebuffer->createInfo.renderPass; 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, fbRP, pInfo->renderPass, errorString)) { 6189400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 61905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 61925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 61945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command " 6195414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 6196414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 61975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer), (uint64_t)(pInfo->renderPass), 61985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->framebuffer), (uint64_t)(fbRP), errorString.c_str()); 61995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 6201f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes framebuffer->referencingCmdBuffers.insert(pCB->commandBuffer); 62025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6206b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 62095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 62105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6211414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "support precise occlusion queries.", 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 62155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 621816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pInfo->renderPass); 621916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 622016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (pInfo->subpass >= renderPass->pCreateInfo->subpassCount) { 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 62235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6224414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 62255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that is less than the number of subpasses (%d).", 622616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes (void *)commandBuffer, pInfo->subpass, renderPass->pCreateInfo->subpassCount); 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6235414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Cannot call Begin on CB (0x%" PRIxLEAST64 62365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 62375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 62387651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else if (CB_RECORDED == pCB->state || (CB_INVALID == pCB->state && CMD_END == pCB->cmds.back().type)) { 62395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 62405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6244414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 6245414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 62485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 62505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 62525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 62535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 62545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 62555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 6257888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 6258888e1d268098177fde4a2263e3d7b7cc415f1debMark Young if ((pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 6259888e1d268098177fde4a2263e3d7b7cc415f1debMark Young (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 626016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeRenderPass = getRenderPass(dev_data, pCB->beginInfo.pInheritanceInfo->renderPass); 6261888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->activeSubpass = pCB->beginInfo.pInheritanceInfo->subpass; 6262888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->framebuffers.insert(pCB->beginInfo.pInheritanceInfo->framebuffer); 6263888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 62645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 6268414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB 0x%p!", (void *)commandBuffer); 62695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6270b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6271e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) { 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6275400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 627989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 6280e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 62825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6283b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 62855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6286fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 6287fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 6288fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 6289fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop skipCall |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 6290fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 62917651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); 62925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 62935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 62945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 6295414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(query.pool), query.index); 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6299e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6300b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 6302b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 63065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 63115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6312b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 631689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 631789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6318bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 63195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6320b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 63235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 6324bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6325bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6326414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 6327bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 6328bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 63295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6330bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, pCB, "reset"); 6331b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6332bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 63335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 63355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6336b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 63375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 6338b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 634293c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 634389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 634489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 6345e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6347b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 63525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 63535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 63545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 6355414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 6356ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass->renderPass); 63575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 636172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 63633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 63665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 6367414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6370b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6371e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 63735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 637589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 637689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 6377e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6379b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 63835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 63845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 63855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 63865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6387b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6388e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 63895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 63905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 639289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 639389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 6394e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6396b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 64005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 64015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 64025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 64035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6404b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6405e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 640989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 6410a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 64115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6412b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6415a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 64165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 6417a27508babf63d50aea75883a3702979193c23683Mark Young 6418a27508babf63d50aea75883a3702979193c23683Mark Young PIPELINE_NODE *pPipeTrav = getPipeline(dev_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 6419a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 6420a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 6421a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 6422386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 6423a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 6424a27508babf63d50aea75883a3702979193c23683Mark Young } else { 6425a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 6426a27508babf63d50aea75883a3702979193c23683Mark Young } 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6428b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6429a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 64305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 643389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 643489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 6435e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6437b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6443b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6444e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 64465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 64475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 644989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 6450e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6452b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 64563d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6458b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6459e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 646389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 646489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 6465e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6467b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 64725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6473b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6474e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 64765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 647889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 647989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 6480e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6482b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6488b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6489e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 649389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 649489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 6495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6497b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 65015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6503b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6504e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 65065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 650889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 650989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 6510e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6512b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6518b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6519e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 65215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 652389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 652489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 652589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 652689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 6527e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 65285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6529b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 6533787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 6534787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 6535787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 6536787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 6537dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { 653872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 6539dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); 6540dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes } 654171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 6542787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 6543397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 6544787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 654571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pSet); 65469d17becd811b49e1ecf91a02eee22f9cf7cbc026Tobin Ehlis pSet->BindCommandBuffer(pCB); 654772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipelineLayout = layout; 654871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pSet; 6549787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 6550787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6551414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DS 0x%" PRIxLEAST64 " bound on pipeline %s", 6552787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 6553397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 6554787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 6555787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 6556787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 6557414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 6558787f29d93dee194c015789cf61c079504c980572Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 6559787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 6560787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6561787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 6562787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, layout, i + firstSet, errorString)) { 6563787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6564e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6565e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 6566e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 6567414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 6568e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 6569787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6570dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6571dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes auto setDynamicDescriptorCount = pSet->GetDynamicDescriptorCount(); 6572dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6573dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); 6574dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6575dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (setDynamicDescriptorCount) { 6576787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 6577dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { 6578787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= 6579787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6580787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6581787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 6582414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 6583787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 6584787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 6585397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 6586787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 6587787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 6588787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 6589787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 6590397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 6591397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 6592787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6593787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6594b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 6595787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 6596787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6597787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6598787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 6599787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6600414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 6601787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6602b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 6603787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6604787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 6605397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 6606787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6607787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6608b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 6609787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 6610787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6611787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6612787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 6613787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6614414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 6615787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6616b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 66175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6618787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 66195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6621dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6622dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = 6623dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, 6624dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); 6625787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 6626dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes totalDynamicDescriptors += setDynamicDescriptorCount; 6627dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 66285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6630787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 6631787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6632787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6633414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS 0x%" PRIxLEAST64 " that doesn't exist!", 6634787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 66355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 663672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 663772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 663872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 663972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 664072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 664171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], 664271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis layout, i, errorString)) { 664372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg( 664472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 664572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 664672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 6647414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DescriptorSetDS 0x%" PRIxLEAST64 6648414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 664972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 665072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 665172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 665272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 665372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 665472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 665572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 665672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 665771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, layout, lastSetIndex, errorString)) { 665871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto old_set = oldFinalBoundSet->GetSet(); 665972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= 666072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 666171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, 6662414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DescriptorSetDS 0x%" PRIxLEAST64 6663414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 666472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 6665414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 666671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis reinterpret_cast<uint64_t &>(old_set), lastSetIndex, 666772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 666872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 666972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 66705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6673787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 6674787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 6675787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6676787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 6677787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 6678787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 6679787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 6680787f29d93dee194c015789cf61c079504c980572Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 6681787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 66845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6686b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6687e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 66885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 66895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 669289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 669389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 6694e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 66955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6696593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 6697b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 67000a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 670172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 670272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6703e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindIndexBuffer()"); }; 670472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 6705593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 67105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 67115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 67135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 67145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 67195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 67205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 6721414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 67225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkIndexType(indexType)); 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6724593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->status |= CBSTATUS_INDEX_BUFFER_BOUND; 67255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6726b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6727e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 67285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 67295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 67335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 67345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 67355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 67375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 67385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6741e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 67425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 674389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 674489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 674589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 6746e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6748593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 6749b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6750593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 6751593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6752593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 6753593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory mem; 6754593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)pBuffers[i], VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 6755593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 6756e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindVertexBuffers()"); }; 675772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6759593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis addCmd(dev_data, cb_data->second, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 6760593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis updateResourceTracking(cb_data->second, firstBinding, bindingCount, pBuffers); 67615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 67635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6764b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6765e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 67665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 67675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6769b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 6770e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 67715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 67727a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 67737a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 67742c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_data = getImageViewData(dev_data, imageView); 67752c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (!iv_data) 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 67772c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis VkImage image = iv_data->image; 67787a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 67797a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skip_call |= 67800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 6781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 67827a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 6783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 67847a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 67857a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 67867a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 67877a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 67887a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 67890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skip_call |= get_mem_binding_from_object(dev_data, (uint64_t)buffer, 67907a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 6791e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 67927a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true); 6793e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 67947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 67957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 67965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 680089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 680189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 6802e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6804b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 68085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 6809e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 68107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 6814414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW]++); 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 68205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6821b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6822e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 68245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 682689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 682789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 68295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6830e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6831b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 6836e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 68377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 68405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 6841414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 68425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6843e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6848b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6849e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 68515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 68525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 685489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 685589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6857e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6858b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 68620a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndirect"); 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 68675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDIRECT]++; 6868e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 68697a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 68725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 6873414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6875e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6880b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6881e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 68835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 688589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 688689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 6887e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6889b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 68915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 68925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 68930a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 68945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndexedIndirect"); 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 68985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED_INDIRECT]++; 6899e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 69007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 69025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 6904414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting DS state:", 69055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6907e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 69085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 69095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); 69115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6912b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6913e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 69155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 691789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 6918e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6920b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 692322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 69247a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 69275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6928b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6929e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 69315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 693389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 693489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 6935e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6937b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 69395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 69400a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 69415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDispatchIndirect"); 69425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 694422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 69457a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6949b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6950e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 69525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 695489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 695589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 6956e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6958b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6959593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 6960593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &src_mem); 6961593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyBuffer"); 6962593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &dst_mem); 6963593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 6964593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyBuffer"); 6965593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 6966593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 6967593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 6968593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 6969593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 697072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 697172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6972593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyBuffer()"); }; 697372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 6974593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 6975593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true); 6976e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 69775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 697872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 6979593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 6980593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 6981593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyBuffer"); 69825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6983b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6984e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 69865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageSubresourceLayers subLayers, 6989e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout srcImageLayout) { 6990e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 69915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 69935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 69945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 69955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 69965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, srcImage, sub, node)) { 699908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 70005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 70015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 70035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 70055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 70065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 70075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 70085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 70095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 70135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 70165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 70175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7027e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageSubresourceLayers subLayers, 7028e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout destImageLayout) { 7029e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, destImage, sub, node)) { 703808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 70395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 70405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 70425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 70435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 70445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 70465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 70475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 70505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 70525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 70535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 70555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 70585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 70595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 70605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 706589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 706689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 706789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 7068e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7070b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7071593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 7073593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7074593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyImage"); 7075593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7076593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7077593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyImage"); 7078593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 7079593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 7080593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 7081593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7082593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 708372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7084e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7085593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyImage()", srcImage); 7086593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 7087593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->validate_functions.push_back(function); 7088593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7089593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7090e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 70915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 709272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7093593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7094593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYIMAGE, "vkCmdCopyImage()"); 7095593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyImage"); 70965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 70975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].srcSubresource, srcImageLayout); 70985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].dstSubresource, dstImageLayout); 70995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7101b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7102e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 71055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 710789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 710889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 710989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 7110e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7112b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7113593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 71145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 7115593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7116593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdBlitImage"); 7117593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7118593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7119593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdBlitImage"); 7120593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 7121593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 7122593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 7123593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7124593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7125593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 712672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7127e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7128593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdBlitImage()", srcImage); 7129593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 7130593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->validate_functions.push_back(function); 7131593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7132593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7133e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 71345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 713572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7136593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7137593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_BLITIMAGE, "vkCmdBlitImage()"); 7138593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdBlitImage"); 71395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7140b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7141e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 71435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 71445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 714689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 714789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 714889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7149e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7151b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7152593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory dst_mem, src_mem; 7153593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7154593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyBufferToImage"); 7155593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7156593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &src_mem); 7157593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyBufferToImage"); 7158593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that src buff & dst image have correct usage flags set 7159593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyBufferToImage()", 7160593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 7161593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyBufferToImage()", 7162593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 716372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 716472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7165e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7166593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7167e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 71685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 716972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7170593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyBufferToImage()"); }; 717172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7172593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7173593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 7174593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyBufferToImage"); 71755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 71765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].imageSubresource, dstImageLayout); 71775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7179b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7180e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 71825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 71835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 718589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 718689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 718789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7188e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7190b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7191593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 7192593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7193593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyImageToBuffer"); 7194593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7195593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &dst_mem); 7196593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyImageToBuffer"); 7197593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that dst buff & src image have correct usage flags set 7198593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyImageToBuffer()", 7199593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 7200593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyImageToBuffer()", 7201593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7202593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 720372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 720472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7205e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7206593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyImageToBuffer()", srcImage); 7207e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 720872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7209593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7210593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true); 7211e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 721372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7214593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7215593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 7216593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyImageToBuffer"); 72175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 72185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].imageSubresource, srcImageLayout); 72195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7221b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7222e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 72245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 72255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 722789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 722889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 7229e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7231b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 72335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 72340a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7235593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdUpdateBuffer"); 7236593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that dst buff has correct usage flags set 7237593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdUpdateBuffer()", 7238593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7239593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7240593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 724172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7242e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 72435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7244e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 724672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7247593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7248593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 7249593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyUpdateBuffer"); 72505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7251b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7252e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 72545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 725689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 725789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 7258e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7260b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 72625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 72630a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7264593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdFillBuffer"); 7265593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that dst buff has correct usage flags set 7266593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdFillBuffer()", 7267593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7268593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7269593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 727072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7271e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 72725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7273e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 727572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7276593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7277593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 7278593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyFillBuffer"); 72795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7280b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7281e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 72835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 728589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 728689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 728789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 7288e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7290b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 72945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 72955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 72965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 72975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 72985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 72995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 73005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 73015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 73025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 73035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 73045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 73055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandBuffer)); 73075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); 73095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 73125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 7313ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->pCreateInfo; 73145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 73175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 73185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 7319e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 73205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 73215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 7322e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 73235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7326e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 73275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 73285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 73295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 73305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 73315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 73325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 73355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 73365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 73375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 73395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 73405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 73425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 73435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 73455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 73465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7350b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7351e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 73535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 735589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 735689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 735789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 7358e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7360b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 73625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73630a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7364593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearColorImage"); 7365593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 736672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7367e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 73685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7369e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 737172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7372593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7373593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 7374593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdClearColorImage"); 73755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7376b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7377e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 73795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 738189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 738289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 738389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 738489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 7385e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7387b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 73895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7391593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearDepthStencilImage"); 7392593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 739372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7394e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 73955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7396e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 739872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7399593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7400593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 7401593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdClearDepthStencilImage"); 74025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7403b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7404e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 74065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 74075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 740989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 741089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 741189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 7412e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7414b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7415593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 7416593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7417593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdResolveImage"); 7418593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7419593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7420593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdResolveImage"); 742172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 742272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7423e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7424593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdResolveImage()", srcImage); 7425593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 7426593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->validate_functions.push_back(function); 7427593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7428593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7429e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 743172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7432593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7433593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 7434593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdResolveImage"); 74355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7436b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7437e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7442b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7443b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7444b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 7445b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 7446b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 7447b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7448b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 7449b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 7450b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 7451b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7452b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 7453b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 7454b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 745589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 745689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7457e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7459b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 74635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 74645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7465c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 7466c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 7467c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 7468b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7469b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 7470b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7472b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7473e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 74755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 747789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 747889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7479e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7481b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 74855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 74865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7487c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 7488c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 7489c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 7490b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7491b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 7492b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7494b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 74975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7499e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7500e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 75015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 75025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 7503e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 75045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 75055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 75085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 75095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 75105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 75135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 75185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 75195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 75205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 752208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 752308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 75245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 75275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 75285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 75295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 75305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 75315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 75325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 75355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 75395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 7542e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 75475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 75485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 75505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 75525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 75535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 75545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 75575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 75595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 7564e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7565e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 7566e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 7567e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 75685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 757043986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7574577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 75796044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 75895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75926044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 75935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 75945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 75955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 75965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 75975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7603e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7604e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 7605e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 76085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 76095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 76105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 76135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 76145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 76155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 76185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 76195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 76225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 76235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 76335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 76375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 76405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 76415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7644577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 76505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 76515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7655e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7656e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 7657e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 7658e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 7659e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 7663ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 76675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 76685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 76715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 76726d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 76736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 76745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 76755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 76766d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 76775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 76785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 76805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 76815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 76825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 76845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 76855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 76865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 76895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 76995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 77005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 7701b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 7702b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 77035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 77045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 77055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 77065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 77085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 77095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 7710b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 77115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 77165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 77185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 77205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 77215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 77235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 77245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77266d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 77271d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 77281d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 77306d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 77316d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis format = image_data->createInfo.format; 77326d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis arrayLayers = image_data->createInfo.arrayLayers; 77336d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis mipLevels = image_data->createInfo.mipLevels; 77345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 7736170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); 7737170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (imageswap_data) { 7738b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); 7739b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 7740b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis format = swapchain_data->createInfo.imageFormat; 7741b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis arrayLayers = swapchain_data->createInfo.imageArrayLayers; 77425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 77485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 77495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 77505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 77515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 77535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 77545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 77555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 77565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7757f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 7758f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 7759f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 7760f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 77615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 77635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 77645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 77655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 77665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 77675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7768f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 7769f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 7770f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 7771f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 77725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 77745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 77755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 77775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 77905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 7794b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 7796b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 77975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 77995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 78005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 78015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 7802b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 78035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78058718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, mem_barrier->buffer); 78068718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 78078718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkDeviceSize buffer_size = 78088718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis (buffer_node->createInfo.sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO) ? buffer_node->createInfo.size : 0; 78095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 781094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 781194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 781294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 7813414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ".", 781494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 781594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 78165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 781794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 781894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7819414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 7820414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 782194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 782294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 782394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 78245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 78285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78302ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 7831b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 7832b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 7833b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 7834b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 78352ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 7836b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 7837b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 7838b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 78392ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 7840b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 7841b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 7842b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 78432ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto global_event_data = dev_data->eventMap.find(event); 7844b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (global_event_data == dev_data->eventMap.end()) { 7845b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 784627c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 784727c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 78482ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 7849b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 7850b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= global_event_data->second.stageMask; 7851b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7852b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7853b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7854c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // TODO: Need to validate that host_bit is only set if set event is called 7855c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // but set event can be called at any time. 7856c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { 7857c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7858c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine DRAWSTATE_INVALID_EVENT, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " 78594261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "using srcStageMask 0x%X which must be the bitwise " 7860c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "OR of the stageMask parameters used in calls to " 7861c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " 78624261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "used with vkSetEvent but instead is 0x%X.", 7863c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine sourceStageMask, stageMask); 7864b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7865b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 7866b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 7867b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 786889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 786989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 787089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 787189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 787289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 7873e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7875b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 78765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78782ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 78795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 7880c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->waitedEvents.insert(pEvents[i]); 78815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 78825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7883b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 78842ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 7885b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 78865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 78875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 78905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 78925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 78945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 78955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7896b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7897e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 78995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 790389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 790489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 790589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 790689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 790789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 7908e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7910b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 79145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 79155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7919b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7920e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 79225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7926d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { 7927d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7928d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 7929d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (pCB) { 7930d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryToStateMap[object] = value; 7931d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 7932d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 7933d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data != dev_data->queueMap.end()) { 7934d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[object] = value; 7935d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 7936d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 7937d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 7938d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 793989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 794089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 7941e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7943b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 79485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7953b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7954e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 79565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 795889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 7959e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7961b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 79655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 79665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7968414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 79695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 79705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 79725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7973c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 7974d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 79765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7981b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7982e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 79845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 798689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 798789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 7988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7990b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 79955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 7996c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); 7997d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 79985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 80055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8006b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8007e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8011d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { 8012d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool skip_call = false; 8013d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 8014d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 8015d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data == dev_data->queueMap.end()) 8016d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 8017d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (uint32_t i = 0; i < queryCount; i++) { 8018d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine QueryObject query = {queryPool, firstQuery + i}; 8019d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto query_data = queue_data->second.queryToStateMap.find(query); 8020d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool fail = false; 8021d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (query_data != queue_data->second.queryToStateMap.end()) { 8022d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!query_data->second) { 8023d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8024d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8025d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8026d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto global_query_data = dev_data->queryToStateMap.find(query); 8027d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (global_query_data != dev_data->queryToStateMap.end()) { 8028d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!global_query_data->second) { 8029d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8030d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8031d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8032d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8033d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8034d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8035d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (fail) { 8036d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8037d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine DRAWSTATE_INVALID_QUERY, "DS", 8038d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 8039d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); 8040d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8041d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8042d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return skip_call; 8043d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8044d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 804589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 804689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 804789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 8048e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8050b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 805203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 805472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 80560a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 805772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8058e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 8060e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 806272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyQueryPoolResults"); 80655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that DST buffer has correct usage flags set 80660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 80675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 80685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 8070d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::function<bool(VkQueue)> queryUpdate = 8071d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::bind(validateQuery, std::placeholders::_1, pCB, queryPool, queryCount, firstQuery); 8072d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 80735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 80755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 80775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); 80795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8080b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8081e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 80835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 80845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 808689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 808789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 808889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 80895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 80905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8091b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 80965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 80985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 81019e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 81029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 81049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 81059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 8106a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 81074a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(dev_data, layout); 81084a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (!pipeline_layout) { 81099e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8110a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Pipeline Layout 0x%" PRIx64 " not found.", 81119e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz (uint64_t)layout); 81129e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 8113a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 8114a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // contained in the pipeline ranges. 8115a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Build a {start, end} span list for ranges with matching stage flags. 81164a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes const auto &ranges = pipeline_layout->pushConstantRanges; 8117a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz struct span { 8118a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz uint32_t start; 8119a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz uint32_t end; 8120a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz }; 8121a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span> spans; 8122a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz spans.reserve(ranges.size()); 8123a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz for (const auto &iter : ranges) { 8124a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (iter.stageFlags == stageFlags) { 8125a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz spans.push_back({iter.offset, iter.offset + iter.size}); 81269e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 81279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 8128a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (spans.size() == 0) { 8129a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // There were no ranges that matched the stageFlags. 8130a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8131a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", 8132a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 8133a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 8134a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz (uint32_t)stageFlags, (uint64_t)layout); 8135a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } else { 8136a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Sort span list by start value. 8137a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz struct comparer { 8138a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz bool operator()(struct span i, struct span j) { return i.start < j.start; } 8139a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } my_comparer; 8140a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::sort(spans.begin(), spans.end(), my_comparer); 8141a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 8142a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Examine two spans at a time. 8143a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span>::iterator current = spans.begin(); 8144a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span>::iterator next = current + 1; 8145a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz while (next != spans.end()) { 8146a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (current->end < next->start) { 8147a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // There is a gap; cannot coalesce. Move to the next two spans. 8148a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz ++current; 8149a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz ++next; 8150a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } else { 8151a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Coalesce the two spans. The start of the next span 8152a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // is within the current span, so pick the larger of 8153a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // the end values to extend the current span. 8154a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Then delete the next span and set next to the span after it. 8155a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz current->end = max(current->end, next->end); 8156a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz next = spans.erase(next); 8157a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8158a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8159a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 8160a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Now we can check if the incoming range is within any of the spans. 8161a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz bool contained_in_a_range = false; 8162a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz for (uint32_t i = 0; i < spans.size(); ++i) { 8163a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 8164a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz contained_in_a_range = true; 8165a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz break; 8166a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8167a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8168a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (!contained_in_a_range) { 8169a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8170a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz __LINE__, DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", 8171a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "vkCmdPushConstants() Push constant range [%d, %d) " 8172a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "with stageFlags = 0x%" PRIx32 " " 8173a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 8174a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 8175a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 81769e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 81775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8178b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 81795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 81805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 81815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 818389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 818489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 8185e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8187b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 8191c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 8192d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 81935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 81955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 81965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8199b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8200e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 82015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 82025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82046600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinskistatic bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, 82056600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag) { 82066600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 82076600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 82086600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t attach = 0; attach < count; attach++) { 82096600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { 82106600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Attachment counts are verified elsewhere, but prevent an invalid access 82116600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment < fbci->attachmentCount) { 82126600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; 82136600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VkImageViewCreateInfo *ivci = getImageViewData(dev_data, *image_view); 82146600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ivci != nullptr) { 82156600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageCreateInfo *ici = &getImageNode(dev_data, ivci->image)->createInfo; 82166600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ici != nullptr) { 82176600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if ((ici->usage & usage_flag) == 0) { 82186600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 82196600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_USAGE, "DS", 82206600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " 82216600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "IMAGE_USAGE flags (%s).", 82226600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag)); 82236600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82246600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82256600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82266600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82276600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82286600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82296600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 82306600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 82316600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 82326600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinskistatic bool ValidateAttachmentImageUsage(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 82336600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 82346600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 82356600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkRenderPassCreateInfo *rpci = getRenderPass(dev_data, pCreateInfo->renderPass)->pCreateInfo; 82366600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (rpci != nullptr) { 82376600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { 82386600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify input attachments: 82396600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, 82406600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pInputAttachments, pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT); 82416600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify color attachments: 82426600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, 82436600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pColorAttachments, pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); 82446600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify depth/stencil attachments: 82456600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { 82466600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, 82476600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); 82486600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82496600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82506600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82516600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 82526600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 82536600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 825489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 825589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 825689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 82576600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 82586600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 8259e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis // TODO : Verify that renderPass FB is created with is compatible with FB 82605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 82616600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 82626600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= ValidateAttachmentImageUsage(dev_data, pCreateInfo); 82636600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (skip_call == false) { 82646600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 82656600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 82675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 8268b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 8269fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes 8270fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto & fbNode = dev_data->frameBufferMap[*pFramebuffer]; 8271fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo = *pCreateInfo; 82725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 8273fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto attachments = new VkImageView[pCreateInfo->attachmentCount]; 8274fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes memcpy(attachments, 8275fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->pAttachments, 8276fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->attachmentCount * sizeof(VkImageView)); 8277fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo.pAttachments = attachments; 82785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 82805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 82812c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto view_data = getImageViewData(dev_data, view); 82822c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (!view_data) { 82835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 82862c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis get_mem_binding_from_object(dev_data, (uint64_t)(view_data->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis &fb_info.mem); 82882c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis fb_info.image = view_data->image; 8289fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.attachments.push_back(fb_info); 82905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8295e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 8296e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 82975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 82985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 8299e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 83005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 83015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 83035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 83045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 83055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 8306e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 83075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8309e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 83105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8311e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8314e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 8315e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 8316e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 83175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 83185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 83191d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 83205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 83225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 83255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 83267655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen // If no dependency exits an implicit dependency still might. If not, throw an error. 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 83287655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 83297655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { 83305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 83325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 83335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 8334e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 83355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 83395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8341e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 8342e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 83445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 83465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 8348e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 83515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 8352e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8354e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 83575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 8362e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 8365e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 83665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8369e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 83705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 83745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 83805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 83815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 83855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8389f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic bool ValidateDependencies(const layer_data *my_data, FRAMEBUFFER_NODE const * framebuffer, 839016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes RENDER_PASS_NODE const * renderPass) { 8391e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 8392f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes const VkFramebufferCreateInfo *pFramebufferInfo = &framebuffer->createInfo; 839316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pCreateInfo = renderPass->pCreateInfo; 839416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto const & subpass_to_node = renderPass->subpassToNode; 83955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 83975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 83985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 84005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 84025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 84035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 84055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84082c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto view_data_i = getImageViewData(my_data, viewi); 84092c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto view_data_j = getImageViewData(my_data, viewj); 84102c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (!view_data_i || !view_data_j) { 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84132c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (view_data_i->image == view_data_j->image && 84142c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis isRegionOverlapping(view_data_i->subresourceRange, view_data_j->subresourceRange)) { 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 84165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 84175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 84185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84196d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data_i = getImageNode(my_data, view_data_i->image); 84206d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data_j = getImageNode(my_data, view_data_j->image); 84216d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!image_data_i || !image_data_j) { 84225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 84235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84246d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data_i->mem == image_data_j->mem && isRangeOverlapping(image_data_i->memOffset, image_data_i->memSize, 84256d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_data_j->memOffset, image_data_j->memSize)) { 84265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 84275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 84285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 84325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 84335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 84345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 84355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 84385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 84395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 84405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 84425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 84455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 84465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 84475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 84511c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 84541c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 84565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 84575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 84585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 84595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 84635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 84645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 84655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 84665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 84675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84681c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 84695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 84715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 84725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 84735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 84745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 84755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84761c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 84771c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 84781c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 84791c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 84801c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 84811c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 84821c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 84831c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 84845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 84875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 84895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pInputAttachments[j].attachment; 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 84955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 84965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pColorAttachments[j].attachment; 84975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 85025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 85075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 85085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 85105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 85115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 85155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8516be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 8517be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 8518be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 8519be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 8520be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 8521be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 8522be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 8523be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 8524be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 8525be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 8526be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 8527be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 8528be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 8529be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 8530be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 8531be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8532be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8533be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 8534be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 85355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8536e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 8537e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 85415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 85425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 85455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 85465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 85475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85504d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 85545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8556be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 8557be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pInputAttachments[j].layout, attach_index, 8558be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis pCreateInfo->pAttachments[attach_index]); 85595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 85615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 85625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 85635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 85645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 85655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 85675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85684d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 85715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8574be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pColorAttachments[j].attachment; 8575be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pColorAttachments[j].layout, attach_index, 8576be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis pCreateInfo->pAttachments[attach_index]); 85775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 85795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 85825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 85835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 85855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 85874d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 85905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8593be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 8594be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pDepthStencilAttachment->layout, 8595be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 85965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8601e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 8602e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 8603e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 86045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 86065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 86095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 86105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 86145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 86185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 86205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 86255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 86295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8630918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 86315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 863289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 863389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 863489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 8636e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 8637b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8638b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 8639b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 8640b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 8641b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 8642b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8643b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 8644b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 8645b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes skip_call |= log_msg(my_data->report_data, 8646b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 8647b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes VkDebugReportObjectTypeEXT(0), 0, 8648b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", "SPIR-V module not valid: %s", 8649b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes diag && diag->error ? diag->error : "(no error text)"); 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8652b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 8653b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 8654b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8655e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 8661b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 8662918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 86655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86674f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { 86684f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 86694f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { 86704f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86714f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 86724f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: %s attachment %d cannot be greater than the total number of attachments %d.", 86734f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski type, attachment, attachment_count); 86744f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 86754f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 86764f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 86774f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 86784f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { 86794f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 86804f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 86814f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 86824f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 86834f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= 86844f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86854f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_RENDERPASS, "DS", 86864f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 86874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 86884f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 86894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pPreserveAttachments[j]; 86904f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment == VK_ATTACHMENT_UNUSED) { 86914f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 86924f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski __LINE__, DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 86934f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED.", j); 86944f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } else { 86954f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); 86964f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 86974f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 86984f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 86994f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment; 87004f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pResolveAttachments) { 87014f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pResolveAttachments[j].attachment; 87024f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); 87034f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 87044f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pColorAttachments[j].attachment; 87054f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); 87064f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 87074f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 87084f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 87094f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); 87104f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 87114f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 87124f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pInputAttachments[j].attachment; 87134f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); 87144f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 87154f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 87164f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 87174f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 87184f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 871989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 87204f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { 87214f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 8722e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 87235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 87244f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 87254f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::unique_lock<std::mutex> lock(global_lock); 87264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 87274f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 87284f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with 87294f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // ValidateLayouts. 87304f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); 87314f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 87324f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (skip_call) { 87334f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 87344f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 87354f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 87364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski lock.unlock(); 87374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (skip_call == false) { 87384f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 87395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 87414f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski lock.lock(); 87424f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 87434f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 87444f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 87454f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 87464f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge in tracking of renderpass from shader_checker 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 87495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 87535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 87545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 87565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 87585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 87605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 87615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 87625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 87635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 87725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 87735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 87755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 87775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 87825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 87845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 87935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 87945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8795cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes 8796cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes auto render_pass = new RENDER_PASS_NODE(localRPCI); 879798cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 8798cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 8799cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 880087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 880187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 880287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 880387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 880487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 880587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 880687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 88071a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_load_op = desc.stencilLoadOp; 88081a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_store_op = desc.stencilStoreOp; 880987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 8810cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->attachments.push_back(pass_info); 881187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 881287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 8813cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 88146600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; 881587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 881687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 881787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 88184f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pColorAttachments[j].attachment; 88194f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 88204f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 88214f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 88220d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 882387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 882487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 882587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 88264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 88274f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 88284f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 882924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 883087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 8831a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 8832a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 88334f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 88344f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, true)); 88354f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 883624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 8837a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 883887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 883987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 88404f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski dev_data->renderPassMap[*pRenderPass] = render_pass; 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 88435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88444f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 88455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 88465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 88475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.size() <= 0) 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->renderPassMap.begin(); ii != my_data->renderPassMap.end(); ++ii) { 88505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = (*ii).second->pCreateInfo; 88515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 88525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 88535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 88555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 88565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 88575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 88595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 88615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 88645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 88675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 88705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 88735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8875e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbesstatic bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 8876e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 88785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer].createInfo; 88795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 88805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 88825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 88835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 88855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 88862c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto image_data = getImageViewData(dev_data, image_view); 88872c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis assert(image_data); 88882c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImage &image = image_data->image; 88892c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->subresourceRange; 88905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 88915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 88945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 88955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 88965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (newNode.layout != node.layout) { 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using attachment %i " 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "where the " 8908d6c1882c31a88ae01b94f3135679f739287be31aKarl Schultz "initial layout is %s and the layout of the attachment at the " 89091c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine "start of the render pass is %s. The layouts must match.", 89101c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 89165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 891827ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbesstatic void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, 8919e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 892016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 892116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 892316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 8924e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 8925e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 89265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8927e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 8928e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes const VkFramebufferCreateInfo &framebufferInfo = framebuffer->createInfo; 892916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkSubpassDescription &subpass = renderPass->pCreateInfo->pSubpasses[subpass_index]; 89305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pInputAttachments[j].attachment]; 89325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pInputAttachments[j].layout); 89335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pColorAttachments[j].attachment]; 89365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pColorAttachments[j].layout); 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pDepthStencilAttachment->attachment]; 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pDepthStencilAttachment->layout); 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8944e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 8945e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 89475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 89495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 89505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8954f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 895516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 895616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 895816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 895916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->pCreateInfo; 8960e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 8961e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 89625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8963e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 89645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 8965e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes const VkImageView &image_view = framebuffer->createInfo.pAttachments[i]; 89665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8970e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 8971885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 8972885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 8973885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 8974885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 8975885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 8976885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 8977885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 8978885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8979885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 8980885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 8981885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 8982885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 8983885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 8984885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 8985885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 8986885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 8987885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 8988885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 89891a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the 89901a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// [load|store]Op flag must be checked 89911a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. 89921a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinskitemplate <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { 89931a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_color_depth_load_op = !vk_format_is_stencil_only(format); 89941a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; 89951a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski // For now, having either the color/depth op OR the stencil op will make the memory valid. They may need to be tracked separately 89961a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool failed = ((check_stencil_load_op && (stencil_op != op)) && (check_color_depth_load_op && (color_depth_op != op))); 89971a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski return !failed; 89981a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski} 89991a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski 900089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 900189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 9002e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9004b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 900616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = pRenderPassBegin ? getRenderPass(dev_data, pRenderPassBegin->renderPass) : nullptr; 9007f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = pRenderPassBegin ? getFramebuffer(dev_data, pRenderPassBegin->framebuffer) : nullptr; 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 900916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 90103d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis uint32_t clear_op_count = 0; 901116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeFramebuffer = pRenderPassBegin->framebuffer; 901216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes for (size_t i = 0; i < renderPass->attachments.size(); ++i) { 9013f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 90141a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = renderPass->pCreateInfo->pAttachments[renderPass->attachments[i].attachment].format; 90151a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 90161a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 90171a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_CLEAR)) { 90183d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis ++clear_op_count; 901916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 902016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 902116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 902216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 902316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 90241a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 90251a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 90261a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { 902716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 902816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 902916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 903016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 903116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 90321a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 90331a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 90341a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_LOAD)) { 903516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 903616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 903716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 903816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 903916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 904016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass->attachment_first_read[renderPass->attachments[i].attachment]) { 904116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 904216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 904316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 904416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90473d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis if (clear_op_count > pRenderPassBegin->clearValueCount) { 90483d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis skipCall |= log_msg( 90493d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 90503d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis reinterpret_cast<uint64_t &>(renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 90513d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but the actual number " 90523d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis "of attachments in renderPass 0x%" PRIx64 " that use VK_ATTACHMENT_LOAD_OP_CLEAR is %u. The clearValueCount " 90531a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski "must therefore be greater than or equal to %u.", 90543d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis pRenderPassBegin->clearValueCount, reinterpret_cast<uint64_t &>(renderPass), clear_op_count, clear_op_count); 90553d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis } 9056e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 9057e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes skipCall |= VerifyFramebufferAndRenderPassLayouts(dev_data, pCB, pRenderPassBegin); 9058ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 9059e5f0c7b48d7b8020aa0877ad216aac257f9e4212Tobin Ehlis skipCall |= ValidateDependencies(dev_data, framebuffer, renderPass); 906016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeRenderPass = renderPass; 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 90625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 90635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 906793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.insert(pRenderPassBegin->framebuffer); 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 9069e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes framebuffer->referencingCmdBuffers.insert(pCB->commandBuffer); 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 907216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 907316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 90745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9076b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9077e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 90785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 90795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 908289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 9083e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 90845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9085b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 90865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 90875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 90885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 90905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 90915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 909227ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 90935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 90945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9095b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9096e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 90975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 90985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 910089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 9101e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 91025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9103b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 910458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes auto pCB = getCBNode(dev_data, commandBuffer); 910558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes if (pCB) { 910658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes RENDER_PASS_NODE* pRPNode = pCB->activeRenderPass; 9107e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pCB->activeFramebuffer); 9108ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (pRPNode) { 910987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 9110e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 91111a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = pRPNode->pCreateInfo->pAttachments[pRPNode->attachments[i].attachment].format; 91121a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 91131a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, VK_ATTACHMENT_STORE_OP_STORE)) { 911458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 911558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 911658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 911758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 911858c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 91191a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 91201a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, 91211a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_STORE_OP_DONT_CARE)) { 912258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 912358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 912458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 912558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 912658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 91275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 913058c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 913158c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 913258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 9133f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); 913458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeRenderPass = nullptr; 913558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeSubpass = 0; 913658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeFramebuffer = VK_NULL_HANDLE; 91375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9138b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9139e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 91405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91435121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, 91445121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes RENDER_PASS_NODE const *primaryPass, uint32_t primaryAttach, uint32_t secondaryAttach, 9145e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *msg) { 91465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9148414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a render pass 0x%" PRIx64 9149414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current render pass 0x%" PRIx64 "." 915081264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom "Attachment %" PRIu32 " is not compatible with %" PRIu32 ". %s", 91515121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes (void *)secondaryBuffer, (uint64_t)(secondaryPass->renderPass), (uint64_t)(primaryPass->renderPass), primaryAttach, secondaryAttach, 91525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis msg); 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91555121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, RENDER_PASS_NODE const *primaryPass, 91565121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes uint32_t primaryAttach, VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, 9157e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 91595121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->attachmentCount <= primaryAttach) { 91605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 91615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91625121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (secondaryPass->pCreateInfo->attachmentCount <= secondaryAttach) { 91635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 91665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 91695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The first is unused while the second is not."); 91715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 91745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The second is unused while the first is not."); 91765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91785121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->pAttachments[primaryAttach].format != 91795121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].format) { 91805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different formats."); 91825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91835121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->pAttachments[primaryAttach].samples != 91845121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].samples) { 91855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different samples."); 91875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (is_multi && 91895121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes primaryPass->pCreateInfo->pAttachments[primaryAttach].flags != 91905121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].flags) { 91915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different flags."); 91935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91975121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, RENDER_PASS_NODE const *primaryPass, 91985121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, const int subpass, 9199e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool is_multi) { 92005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 92015121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes const VkSubpassDescription &primary_desc = primaryPass->pCreateInfo->pSubpasses[subpass]; 92025121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes const VkSubpassDescription &secondary_desc = secondaryPass->pCreateInfo->pSubpasses[subpass]; 92035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 92045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 92055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 92065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 92075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 92085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 92115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_input_attach, secondaryBuffer, 92135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_input_attach, is_multi); 92145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 92165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 92175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 92185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 92195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 92205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 92225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 92235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_color_attach, secondaryBuffer, 92255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_color_attach, is_multi); 92265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 92275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 92285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 92295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 92315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 92325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_resolve_attach, secondaryBuffer, 92345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_resolve_attach, is_multi); 92355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 92375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 92385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 92395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 92415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 92425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_depthstencil_attach, secondaryBuffer, 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_depthstencil_attach, is_multi); 92455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9248e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9249e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass) { 92505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 92515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early exit if renderPass objects are identical (and therefore compatible) 92525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryPass == secondaryPass) 92535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 925416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto primary_render_pass = getRenderPass(dev_data, primaryPass); 925516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto secondary_render_pass = getRenderPass(dev_data, secondaryPass); 925616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!primary_render_pass) { 92575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 92585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9260414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid current Cmd Buffer 0x%p which has invalid render pass 0x%" PRIx64 ".", 92615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)primaryBuffer, (uint64_t)(primaryPass)); 92625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 926416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!secondary_render_pass) { 92655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 92665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9268414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%p which has invalid render pass 0x%" PRIx64 ".", 92695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass)); 92705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 927216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (primary_render_pass->pCreateInfo->subpassCount != secondary_render_pass->pCreateInfo->subpassCount) { 92735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9275414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a render pass 0x%" PRIx64 9276414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current render pass 0x%" PRIx64 "." 92775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "They have a different number of subpasses.", 92785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass)); 92795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 928116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto subpassCount = primary_render_pass->pCreateInfo->subpassCount; 928216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes for (uint32_t i = 0; i < subpassCount; ++i) { 928316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primary_render_pass, secondaryBuffer, 928416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes secondary_render_pass, i, subpassCount > 1); 92855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9289e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 9290e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 92915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 92925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 92935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9295c5b97dda856ff837638b3ebb7e231d5507c495a3Chris Forbes VkFramebuffer primary_fb = pCB->activeFramebuffer; 92965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 92975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 92985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 92995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9301414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a framebuffer 0x%" PRIx64 9302414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current framebuffer 0x%" PRIx64 ".", 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 93045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9305e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto fb = getFramebuffer(dev_data, secondary_fb); 9306e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!fb) { 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 93085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9309414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9310414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 93125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9314e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->createInfo.renderPass, 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryBuffer, pSubCB->beginInfo.pInheritanceInfo->renderPass); 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9320e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 93215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 93225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 93235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9333414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9334414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 93375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 93435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9348414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9349414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 9350414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 93515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 935889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 935989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 9360e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9362b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 93675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 93685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9372414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 93745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 93755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 93765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9377414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 93785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 93795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 93805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 93815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 93825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 9385414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 9387ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 93885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 93895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 9390ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes skipCall |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->renderPass, pCommandBuffers[i], 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass); 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 93935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 9395ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->renderPass, 93965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass, errorString)) { 93975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 9400414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 9401414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 94025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 9403ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 94045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 94065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 94075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 94085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 94095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 94105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 94115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 9412414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) references framebuffer (0x%" PRIxLEAST64 9413414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") that does not match framebuffer (0x%" PRIxLEAST64 ") in active renderpass (0x%" PRIxLEAST64 ").", 94145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 9415ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass->renderPass); 94165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 94205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 94215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pSubCB); 94225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 94235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 94245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 94255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 94265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 94275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 94285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9429414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to simultaneously execute CB 0x%" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 94305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 94315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 94325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 94345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 94355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 94365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9438414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 94395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 9440414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 94415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, even though it does.", 94425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 94435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 94445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9446b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 94475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 94485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 94495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 94505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 9451414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 94525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 94535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 94545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 94555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 94575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 94585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 94595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 94615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 94625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9463b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9464e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 94655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 94665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9468e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 9469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 94705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 947157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 947257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if ((mem_info) && (mem_info->image != VK_NULL_HANDLE)) { 94735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 947457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (FindLayouts(dev_data, mem_info->image, layouts)) { 94755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 94765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 94775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 94785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 94815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 948889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 948989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 94905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 94915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9492e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 94935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9494b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 949503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 949657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObj = getMemObjInfo(dev_data, mem); 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 94985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 9499b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & 9500b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 95015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 95035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 9504414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 95055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 950958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 9510b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9512e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 95135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 95147c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis if (VK_SUCCESS == result) { 951503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 95167c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.lock(); 95177c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis storeMemRanges(dev_data, mem, offset, size); 95187c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 95197c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.unlock(); 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 95217c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis } 95225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 952689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 95275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9528e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9530b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= deleteMemRanges(my_data, mem); 9532b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9533e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 95345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 95355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9538e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 9539e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9540e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 954257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 954357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 954457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->memRange.offset > pMemRanges[i].offset) { 954557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis skipCall |= 954657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 954757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 954857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 954957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 955057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_info->memRange.offset)); 95515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95524b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller 95534b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller const uint64_t my_dataTerminus = 955457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (mem_info->memRange.size == VK_WHOLE_SIZE) ? mem_info->allocInfo.allocationSize : 955557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (mem_info->memRange.offset + mem_info->memRange.size); 95564b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller if (pMemRanges[i].size != VK_WHOLE_SIZE && (my_dataTerminus < (pMemRanges[i].offset + pMemRanges[i].size))) { 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 95585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 95595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 95605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") exceeds the Memory Object's upper-bound " 95615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 95625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 95634b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller static_cast<size_t>(my_dataTerminus)); 95645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 95685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9570e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 9571e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9572e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 957457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 957557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 957657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->pData) { 957757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis VkDeviceSize size = mem_info->memRange.size; 95785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 957957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis char *data = static_cast<char *>(mem_info->pData); 95805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 95815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 95825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 95835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 9584414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, 95855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 95865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 95895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 95905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 9592414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, 95935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 95945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 959657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis memcpy(mem_info->pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 95975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 96015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 960389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 960489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 96055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9606e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 96075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 96085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9609b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 96105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 96115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 9612b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9613e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 96145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 96155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 96175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 961989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 962089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 96215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9622e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 96235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 96245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9625b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 96265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 9627b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9628e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 96305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 96325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 963489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 96355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 96365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9637e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 9638b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 96396d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 96406d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 964194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 964247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 964394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 96445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 9645b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 964694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 9647b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 964847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 964947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 965057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 965157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 965247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 965357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis insert_memory_ranges(image_handle, mem, memoryOffset, memRequirements, mem_info->imageRanges); 965457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis skipCall |= validate_memory_range(dev_data, mem_info->bufferRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 96554261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski skipCall |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "vkBindImageMemory"); 965647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 965747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 96580a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 9659b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 966094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!skipCall) { 966194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 9662b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 966357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis dev_data->memObjMap[mem].get()->image = image; 96646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = mem; 96656d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memOffset = memoryOffset; 96666d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memSize = memRequirements.size; 9667b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 966894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 966994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 967094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 967194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 9672414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 967394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 967889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 96793ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 96803ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9682b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 96833ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis auto event_node = dev_data->eventMap.find(event); 96843ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node != dev_data->eventMap.end()) { 96853ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.needsSignaled = false; 96863ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.stageMask = VK_PIPELINE_STAGE_HOST_BIT; 9687c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (event_node->second.write_in_use) { 96883ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 96893ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9690414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 96913ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 96923ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 96933ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 9694b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 96956fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 96966fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 96976fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 96986fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 96996fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 97006fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 97016fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 97026fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 97036fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 97043ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 97053ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 971089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 97115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 97125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9713e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9714b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 9715651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 9716651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 9717651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 97184b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 9719651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= ValidateFenceForSubmit(dev_data, pFence); 9720651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 9721a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence != VK_NULL_HANDLE) { 9722651d92815dfff917308137bb67aacccc4f60df86Chris Forbes SubmitFence(pQueue, pFence); 97234b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 9724651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 97251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 97261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 97281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 97291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 97301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 97311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9733e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 97345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 97371344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 97381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 97391344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 97405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9741e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 97425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 97451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 97461344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 97471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 97485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9749e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97521344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 97531344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pWaitSemaphores[i]; 97541344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 97551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 97561344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 97571344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 97581344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 97595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 97601344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9761414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 97621344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 97631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 97681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pSignalSemaphores[i]; 97691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 97701344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 97715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 97725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 97731344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9774414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 97751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 97761344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 97775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97820a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 9783b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 97845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9785e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 979189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 979289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 97955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 9796b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 97981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 97990a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 980689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 98085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 98095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 9810b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 9813293ecfc5e69ed3978a8c04518166d828294870a4Tony Barbour dev_data->eventMap[*pEvent].write_in_use = 0; 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 98155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 981989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 982089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 982189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 98235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 9826b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 98273f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo)); 98285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 983389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 983489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 98365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 98375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9838b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 9839b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, swapchain); 9840b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 9841b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data->images.size() > 0) { 9842b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis for (auto swapchain_image : swapchain_data->images) { 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 98525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98530a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, (uint64_t)swapchain_image, 98540801763633180d277d26a90343464bd11646056fTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 985594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9860b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 986589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 986689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 98675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 98715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 98725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 98735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 9874b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 9876b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_node = getSwapchainNode(dev_data, swapchain); 9877b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_node && !swapchain_node->images.empty()) { 98780801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 98790801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 98800801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 9885414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 98885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 98946d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis // Add imageMap entries for each swapchain image 98956d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo image_ci = {}; 98966d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.mipLevels = 1; 98976d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 98986d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.usage = swapchain_node->createInfo.imageUsage; 98996d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.format = swapchain_node->createInfo.imageFormat; 99006d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; 99016d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; 99026d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; 99036d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_NODE>(new IMAGE_NODE(&image_ci)); 990494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 99056d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->valid = false; 99066d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 99075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 99085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 99095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 99105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 99115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 99125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 991789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 99185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 99195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 99205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99216c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes std::lock_guard<std::mutex> lock(global_lock); 99226c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 99236c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 99246c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && !pSemaphore->signaled) { 99256c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 99266c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 99276c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 99286c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 99296c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); 99305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99316c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 99326c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkDeviceMemory mem; 99336c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 99346c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 99356c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (swapchain_data && pPresentInfo->pImageIndices[i] < swapchain_data->images.size()) { 99366c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkImage image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 993703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 99386c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 99390a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 99406c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= validate_memory_is_valid(dev_data, mem, "vkQueuePresentKHR()", image); 994103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 99426c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes vector<VkImageLayout> layouts; 99436c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (FindLayouts(dev_data, image, layouts)) { 99446c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (auto layout : layouts) { 99456c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 99466c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 99485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99586c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (skip_call) { 99596c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 99606c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 99616c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 99626c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkResult result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 99636c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 99646c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (result != VK_ERROR_VALIDATION_FAILED_EXT) { 99656c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // Semaphore waits occur before error generation, if the call reached 99666c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // the ICD. (Confirm?) 99676c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 99686c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 99696c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && pSemaphore->signaled) { 99706c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes pSemaphore->signaled = false; 99716c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 99726c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 99736c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 99741344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 997889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 997989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 99821344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 9983b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 9984f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 9985f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore && pSemaphore->signaled) { 9986f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 9987f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9988f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9990f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 9991f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pFence = getFenceNode(dev_data, fence); 9992f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 9993f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes skipCall |= ValidateFenceForSubmit(dev_data, pFence); 99945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9995b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 99961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 9997f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (skipCall) 9998f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 9999f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10000f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes VkResult result = 100015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 10002f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10003f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.lock(); 10004f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { 10005f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 10006f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pFence->state = FENCE_INFLIGHT; 10007f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 10008f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10009f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore 10010f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore) { 10011f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pSemaphore->signaled = true; 10012f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 100135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10014f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.unlock(); 100151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 100165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1001989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1002089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 1002189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 100225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 100235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 100245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 10026b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 10027c34ab18ac7c064590a1020a8db4b6abf5a8d3a18Mark Lobodzinski res = layer_create_msg_callback(my_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); 100285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 100305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1003289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 1003389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 1003489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 100365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 100375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10038b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 100395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 100405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1004289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1004389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 1004489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 100455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 100465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 100475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 100485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10050a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10051a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 10052a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 10053a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 10054a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 10055a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10056a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 10057a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 10058a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 10059a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 10060a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10061a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 10062a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 10063a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 10064a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 10065a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return VK_ERROR_LAYER_NOT_PRESENT; 10066a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 10067a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 1006889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 1006989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 1007089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 10071a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 1007208939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 10073a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 10074a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 10075a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 10076a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu dispatch_key key = get_dispatch_key(physicalDevice); 10077a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu layer_data *my_data = get_my_data_ptr(key, layer_data_map); 10078a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 1007908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1008008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1008180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 100827ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 100837ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 100847ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1008580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 1008680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1008709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1008809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 1008909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1009089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 1009180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 1009280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 1009380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 1009480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1009580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 100965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1009709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 1009809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 1009909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 1010009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 101015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 101025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 101035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 101055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 101065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 101075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 101085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 101095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1011289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 101137ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 101143f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 101153f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 101163f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 101173f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 101187ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 101197ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 101205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101217ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 101225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 101245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 101257ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 101267ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 101277ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 101285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 101305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 101315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 101325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 101335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1013408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1013580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 101367ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 101377ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 101387ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 101397ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 101407ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 101417ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 101427ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 101437ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 101447ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 101457ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 10146a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, 10147a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, 10148a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, 101497ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 101507ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 101517ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 101527ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 101537ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 101547ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 101557ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 101567ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 101577ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 101587ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 101597ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 101607ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1016180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1016280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1016380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1016480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1016580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 10166593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, 10167593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, 10168593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, 10169593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, 10170593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, 10171593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, 10172593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, 10173593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, 10174593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, 10175593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, 10176593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, 10177593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, 10178593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, 10179593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, 10180593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, 10181593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, 10182593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, 10183593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, 10184593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, 10185593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, 10186593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, 10187593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, 10188593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, 10189593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, 10190593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, 10191593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, 10192593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, 10193593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, 10194593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, 10195593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, 10196593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, 10197593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, 10198593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, 10199593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, 10200593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, 10201593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, 10202593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, 10203593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, 10204593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, 10205593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, 10206593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, 10207593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, 10208593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, 10209593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, 10210593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, 10211593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, 10212593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, 10213593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, 10214593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, 10215593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, 10216593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, 10217593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, 10218593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, 10219593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, 10220593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, 10221593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, 10222593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, 10223593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, 10224593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, 10225593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, 10226593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, 10227593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, 10228593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, 10229593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, 10230593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, 10231593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, 10232593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, 10233593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, 10234593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, 10235593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, 10236593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, 10237593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, 10238593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, 10239593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, 10240593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, 10241593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, 10242593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, 10243593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, 10244593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, 10245593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, 10246593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, 10247593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, 10248593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, 10249593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, 10250593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, 10251593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, 10252593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, 10253593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, 10254593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, 10255593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, 10256593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, 10257593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, 10258593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, 10259593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, 10260593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, 10261593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, 10262593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, 10263593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, 10264593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, 10265593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, 10266593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, 10267593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, 10268593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, 10269593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, 10270593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, 10271593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, 10272593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, 10273593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, 10274593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, 10275593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, 10276593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, 10277593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, 10278593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, 10279593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, 10280593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, 10281593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, 1028280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1028380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1028480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1028580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1028680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1028780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1028880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1028980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1029080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1029180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1029209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1029309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1029409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1029509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1029609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1029709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1029809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1029909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1030009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1030109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1030209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1030309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 1030409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 103053f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 103063f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 103073f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 103083f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 103093f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1031009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1031109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1031209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1031309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1031409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1031509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1031609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 1031709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1031809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 10319d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 10320d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10321d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 10322d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10323d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10324d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 10325d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1032689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 10327d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10328d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10329d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10330d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 10331d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 10332d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1033389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10334d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10335d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10336d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10337d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 10338d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1033989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 10340d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10341d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10342a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu// loader-layer interface v0, just wrappers since there is only a layer 10343d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1034408939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1034508939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 10346a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); 1034708939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1034808939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1034908939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1035008939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 10351a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); 1035208939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1035308939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1035408939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1035508939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 10356a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 10357a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 10358a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); 10359d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10360d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10361d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 10362d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 10363d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 10364a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 10365a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 10366a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 10367d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10368d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10369d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1037089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 10371d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10372d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10373d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 1037489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1037508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 10376