core_validation.cpp revision 672a7ee979486eaec10f96063f0455e8c2a02595
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_map> 465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_set> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_config.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_logging.h" 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) printf(__VA_ARGS__) 715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 79b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track command pools and their command buffers 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct CMD_POOL_INFO { 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPoolCreateFlags createFlags; 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queueFamilyIndex; 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool 855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 88e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE *> swapchainMap; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 10294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 104b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski unordered_set<VkQueue> queues; // all queues under given device 1055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 1085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap; 1095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImageView, VkImageViewCreateInfo> imageViewMap; 1105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, IMAGE_NODE> imageMap; 1115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBufferView, VkBufferViewCreateInfo> bufferViewMap; 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBuffer, BUFFER_NODE> bufferMap; 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap; 1155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 1165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSet, SET_NODE *> setMap; 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSetLayout, LAYOUT_NODE *> descriptorSetLayoutMap; 1185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 11958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis unordered_map<VkDeviceMemory, DEVICE_MEM_INFO> memObjMap; 1205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 12672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 1275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFramebuffer, FRAMEBUFFER_NODE> frameBufferMap; 1285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 131918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1326c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 135b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 136b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 137b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 13994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), device_extensions(), 140a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis device(VK_NULL_HANDLE), phys_dev_properties{}, phys_dev_mem_props{} {}; 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 143b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 144b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 145b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_global_layers[] = {{ 147f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 1485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 1495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 1535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(createInfo.ppEnabledLayerNames[i], cv_global_layers[0].layerName)) { 1545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cv_global_layers[0].layerName); 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t len() { return *it >> 16; } 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t const &word(unsigned n) { return it[n]; } 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 1935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 1945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 1955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 234b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 23503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 23603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - start of direct pull 23794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 24094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->imageMap.find(VkImage(handle)); 24194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->imageMap.end()) 24294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 24694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->bufferMap.find(VkBuffer(handle)); 24794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->bufferMap.end()) 24894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 2555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - end section 2575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 2585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate layer_data *get_my_data_ptr<layer_data>(void *data_key, std::unordered_map<void *, layer_data *> &data_map); 2595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 26172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *, const VkCommandBuffer); 26272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 26303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 2645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 2655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 2665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 2675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 2680a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 2690a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 2700a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 271e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 272e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 2735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 2745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 2755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 2765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 2775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 2785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 2795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s %#" PRIxLEAST64 2805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 2815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 2825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 2845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for images 2875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls image info and then sends actual vs. desired usage off to helper above where 2885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 2890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_image_usage_flags(layer_data *dev_data, VkImage image, VkFlags desired, VkBool32 strict, 29094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 291e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 29294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 29394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 2940a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, image_node->second.createInfo.usage, desired, strict, (uint64_t)image, 2955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "image", func_name, usage_string); 2965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 2985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 3015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls buffer info and then sends actual vs. desired usage off to helper above where 3025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3030a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_buffer_usage_flags(layer_data *dev_data, VkBuffer buffer, VkFlags desired, VkBool32 strict, 30494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 305e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 30694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const buffer_node = dev_data->bufferMap.find(buffer); 30794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 3080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, buffer_node->second.createInfo.usage, desired, strict, (uint64_t)buffer, 3095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "buffer", func_name, usage_string); 3105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 3155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 31658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic DEVICE_MEM_INFO *get_mem_obj_info(layer_data *dev_data, const VkDeviceMemory mem) { 31758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto item = dev_data->memObjMap.find(mem); 31858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (item != dev_data->memObjMap.end()) { 3195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return &(*item).second; 3205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 3225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 3265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 3275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 3285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&my_data->memObjMap[mem].allocInfo, pAllocateInfo, sizeof(VkMemoryAllocateInfo)); 3305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Update for real hardware, actually process allocation info structures 3315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].allocInfo.pNext = NULL; 3325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].object = object; 3335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].mem = mem; 33458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis my_data->memObjMap[mem].image = VK_NULL_HANDLE; 3355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.offset = 0; 3365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.size = 0; 3375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pData = 0; 3385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pDriverData = 0; 3395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].valid = false; 3405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 342e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImage image = VK_NULL_HANDLE) { 3445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 34594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 34694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end() && !image_node->second.valid) { 34758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 3485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 3495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid swapchain image %" PRIx64 ", please fill the memory before using.", 3505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 3515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 3545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 35558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 3565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 3575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid memory %" PRIx64 ", please fill the memory before using.", functionName, 3585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 3595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 3625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 3655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 36694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 36794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 36894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.valid = valid; 3695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 3725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 3735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 3745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 380e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 381e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 382e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 38858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 3895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 390de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemInfo->commandBufferBindings.insert(cb); 3915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 39272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 39472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 395c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 401400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 402400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 40372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 404c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 405c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 40620b3e28d96ae4f3cbd4535e53eb68521d31bb91bChris Forbes DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 4075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 408400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis pInfo->commandBufferBindings.erase(pCBNode->commandBuffer); 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 411c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 4125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 4145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 416400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 417400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 418400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 422e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 423e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 424de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes size_t cmdBufRefCount = pMemObjInfo->commandBufferBindings.size(); 425896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes size_t objRefCount = pMemObjInfo->objBindings.size(); 4265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 427de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if ((pMemObjInfo->commandBufferBindings.size()) != 0) { 42858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory object %#" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " references", 4325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 4335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 435de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (cmdBufRefCount > 0 && pMemObjInfo->commandBufferBindings.size() > 0) { 436de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pMemObjInfo->commandBufferBindings) { 43758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 438de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 439de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes "Command Buffer %p still has a reference to mem obj %#" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 4405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 442de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemObjInfo->commandBufferBindings.clear(); 4435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 445896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (objRefCount > 0 && pMemObjInfo->objBindings.size() > 0) { 446896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pMemObjInfo->objBindings) { 447896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 4485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_FREED_MEM_REF, "MEM", "VK Object %#" PRIxLEAST64 " still has a reference to mem obj %#" PRIxLEAST64, 449896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 4505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 452896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemObjInfo->objBindings.clear(); 4535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 457e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemObjInfo(layer_data *my_data, void *object, VkDeviceMemory mem) { 458e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = my_data->memObjMap.find(mem); 4605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != my_data->memObjMap.end()) { 4615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap.erase(item); 4625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 4655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Request to delete memory object %#" PRIxLEAST64 " not present in memory Object Map", (uint64_t)mem); 4665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 470e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 471e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 47358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 4745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 4755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize == 0 && !internal) { 4765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section 47758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory associated with a Persistent Image, %#" PRIxLEAST64 ", " 4805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this should not be explicitly freed\n", 4815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem); 4825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear any CB bindings for completed CBs 4845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is there a better place to do this? 4855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(pInfo->object != VK_NULL_HANDLE); 487de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // clear_cmd_buf_and_mem_references removes elements from 488de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // pInfo->commandBufferBindings -- this copy not needed in c++14, 489de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // and probably not needed in practice in c++11 490de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes auto bindings = pInfo->commandBufferBindings; 491de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : bindings) { 492a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 493de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 4945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify that no references to this mem obj remain and remove bindings 498de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() || pInfo->objBindings.size()) { 49958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= reportMemReferencesAndCleanUp(dev_data, pInfo); 5005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete mem obj info 50258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= deleteMemObjInfo(dev_data, object, mem); 5035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 5095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 5105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 5115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 5125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 5135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 5145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 5155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 5165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 5175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 5185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 5225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 523c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 5245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 5250a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 5265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 527e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 52894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 52994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 53094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = get_mem_obj_info(dev_data, *pMemBinding); 5315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 53294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 5335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 534c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 5355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 536896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (!pMemObjInfo->objBindings.erase({handle, type})) { 5375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 53858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 5395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "While trying to clear mem binding for %s obj %#" PRIxLEAST64 5405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", unable to find that object referenced by mem obj %#" PRIxLEAST64, 5415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 5425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 5495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 5505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 5515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 5525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 55394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 55494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 555e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 5575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 5585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 55958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 5605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(%#" PRIxLEAST64 ") to NULL", apiName, handle); 5615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 56294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 56394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 5645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 56558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, 5664f085d96e1f9ba7cba58b480ae64a8546c9a00eeChris Forbes "MEM", "In %s, attempting to update Binding of %s Obj(%#" PRIxLEAST64 ") that's not in global list", 5675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), apiName, handle); 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // non-null case so should have real mem obj 57058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 5715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 57294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = get_mem_obj_info(dev_data, *pMemBinding); 5735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPrevBinding != NULL) { 5745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 57558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 5775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to bind memory (%#" PRIxLEAST64 ") to object (%#" PRIxLEAST64 5785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") which has already been bound to mem object %#" PRIxLEAST64, 5795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 5805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 581896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemInfo->objBindings.insert({handle, type}); 5825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For image objects, make sure default memory state is correctly set 5835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What's the best/correct way to handle this? 5845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 58594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(VkImage(handle)); 58694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 58794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkImageCreateInfo ici = image_node->second.createInfo; 58894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 58994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // TODO:: More memory state transition stuff. 59094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 5915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 5945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 6025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 6035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 6055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 6060a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 6070a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 6080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 6090a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes bool skipCall = VK_FALSE; 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6120a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, handle, type); 6135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 61594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 6165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 61758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, "MEM", 6185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to update Binding of Obj(%#" PRIxLEAST64 ") that's not in global list()", apiName, handle); 61994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 62094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // non-null case so should have real mem obj 62194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 62294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pInfo) { 62394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis pInfo->objBindings.insert({handle, type}); 62494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Need to set mem binding for this object 62594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 62694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 6275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given Object, get 'mem' obj that it's bound to or NULL if no binding 6330a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool get_mem_binding_from_object(layer_data *dev_data, const uint64_t handle, 63494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis const VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 635e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 63794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 63894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 63994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *mem = *pMemBinding; 6405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 6425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Trying to get mem binding for object %#" PRIxLEAST64 " but no such object in %s list", handle, 6435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type)); 6445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 6490a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 65058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 6515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 65358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 6545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 6555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 65858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 6595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 66058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 66158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 6625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 6635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 6655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 6665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 6685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 6695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at %p===", (void *)pInfo); 67258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: %#" PRIxLEAST64, (uint64_t)(pInfo->mem)); 67458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 675c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 676de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size() + pInfo->objBindings.size()); 6775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (0 != pInfo->allocInfo.allocationSize) { 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&pInfo->allocInfo, "MEM(INFO): "); 67958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 6815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 6845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 688896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pInfo->objBindings.size()); 689896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (pInfo->objBindings.size() > 0) { 690896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pInfo->objBindings) { 69158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 692896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT %" PRIu64, obj.handle); 6935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 6985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 699de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size()); 700de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() > 0) { 701de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pInfo->commandBufferBindings) { 70258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 703de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB %p", cb); 7045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7090a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 71072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 7115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 7135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 71872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 71972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 7205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 7225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 7245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 72772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 7285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 730a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " CB Info (%p) has CB %p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 7315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 732c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 7335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 734c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 7355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 736c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Mem obj %" PRIu64, (uint64_t)obj); 7375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 7425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 7445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 7455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 7465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 7475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 7485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 7495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 7505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 7515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 7525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 7535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 7545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 7555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 7565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 7575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 7595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 7605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 7615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 7635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 7645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 7655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 7665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 7675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 7685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 7695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 7705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 7715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 7735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 7745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 7755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 7775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 7785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 7795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 7805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 7815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 7825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 7835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 7845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 7855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 7865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 7875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 7885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 7915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 7925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 7935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 7945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 7955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 7965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 7975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 7985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 7995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 8005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 8025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 8035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 8045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 8055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 8075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 8085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 8095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 8115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 8125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 8135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 8145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 8155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 8165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 8175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 8195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 8225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 8265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 8305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 8335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 8425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 8445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 8455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 8485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 8525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 8575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 8845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 8855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool shader_is_spirv(VkShaderModuleCreateInfo const *pCreateInfo) { 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t *words = (uint32_t *)pCreateInfo->pCode; 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t sizeInWords = pCreateInfo->codeSize / sizeof(uint32_t); 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Just validate that the header makes sense. */ 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return sizeInWords >= 5 && words[0] == spv::MagicNumber && words[1] == spv::Version; 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9749ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 9759ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 9819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 9829ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 9849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 9859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 9879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 9889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 9909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 9919ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 9929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 9949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 9959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 9969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 9989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 9999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 10039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 10049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 10069ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 10089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 10099ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 10109ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 10119ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 10129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 10139ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10159ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 10189ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 10199ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 10219ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 10229ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10239ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 10259ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 10269ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10289ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 10299ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10339ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10349ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 10359ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 10369ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 10379ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 10389ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 10399ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10409ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 104137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 104237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 104337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 104437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 104537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 104637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 104737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 104837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 104937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10567c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 105737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 10587c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 10597c755c8aca6857046df9516d8336416165969cb9Chris Forbes 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 106237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 106337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 106437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 106537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 106637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10737c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 10747c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 107537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 10767c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 10777c755c8aca6857046df9516d8336416165969cb9Chris Forbes 10787c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 10797c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 10807c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 10817c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 10827c755c8aca6857046df9516d8336416165969cb9Chris Forbes 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10857c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 10887c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 10895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 10917c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 10925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 109337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 109437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 109537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 109637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 109737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 109837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 109937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 110037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 110137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 11025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 110337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 110437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 11085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 110937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 111937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 11305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 11495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 11555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 11565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 11595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1160cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1161cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1162cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1163cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1164cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1165cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1166cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1167cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1168cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 11695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 11715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 11725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1178c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1179c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1180c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1181c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1182c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1183c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1184c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1185c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1186c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1187c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1188c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1189c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1190c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1191c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 11935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 11945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1199b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1200fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 12035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1204031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1205031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1206031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1207031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1208031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1209031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1210031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1211031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1212031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1213031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1214031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1215031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1216031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1217031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 12305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12346c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_block_members(layer_data *my_data, shader_module const *src, 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1237b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 12385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1239031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 12495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 12505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 12515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 12535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 12555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 12675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 12685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 12735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 12745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 12755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 12765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1277b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1278fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 12795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 12805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12866c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_location(layer_data *my_data, shader_module const *src, spirv_inst_iter entrypoint, 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 12905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1293b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 12985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 12995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 13025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 13065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1316b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1317b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1318b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1319b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 132581264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 13295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1330c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13411d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1348b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 13605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 13617c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 13655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1367b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1368fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 13695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 1373b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes collect_interface_block_members(my_data, src, out, blocks, is_array_of_verts, id, type, is_patch); 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13796c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_descriptor_slot(layer_data *my_data, shader_module const *src, 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<descriptor_slot_t, interface_var> &out) { 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 13845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto existing_it = out.find(std::make_pair(set, binding)); 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (existing_it != out.end()) { 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* conflict within spv image */ 1413080afef66a53dbdd085698b713697296458edfd9Chris Forbes log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis insn.word(2), insn.word(1), storage_class_name(insn.word(3)), existing_it->first.first, 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis existing_it->first.second); 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1423b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1424b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1425fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(set, binding)] = v; 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14316c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_interface_between_stages(layer_data *my_data, shader_module const *producer, 1432031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1434031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1440031261d21af8907953dd763398ce9a23e65b8749Chris Forbes collect_interface_by_location(my_data, producer, producer_entrypoint, spv::StorageClassOutput, outputs, producer_stage->arrayed_output); 1441031261d21af8907953dd763398ce9a23e65b8749Chris Forbes collect_interface_by_location(my_data, consumer, consumer_entrypoint, spv::StorageClassInput, inputs, consumer_stage->arrayed_input); 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1454080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1455080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1456031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1457031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1462080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1464031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1465031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1470fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1471fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1472fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1473fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 14740f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1475fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1476fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 147737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1478080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 14809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 14819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 14829ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14860f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 14870f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 14880f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1489f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 14900f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 14910f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 14920f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 14930f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 14940f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 14950f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 152731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 152831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 152931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 153031c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1533f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 15445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 15455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 15465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 154931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 155031c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 155131c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 155231c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 15535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 15545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1555f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 15585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 15595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 15605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 15615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 15725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 15825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 15835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15936c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_consistency(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi) { 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1604080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16176c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_against_vs_inputs(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi, 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16226c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, vs, entrypoint, spv::StorageClassInput, inputs, false); 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1627c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1628c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1629c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1630c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1631c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1632c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 1644080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1645080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 16605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1663080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 16669ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 16679ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16816c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_fs_outputs_against_render_pass(layer_data *my_data, shader_module const *fs, 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoint, RENDER_PASS_NODE const *rp, uint32_t subpass) { 16835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const std::vector<VkFormat> &color_formats = rp->subpassColorFormats[subpass]; 16845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 16855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 16885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16896c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, fs, entrypoint, spv::StorageClassOutput, outputs, false); 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = outputs.begin(); 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = 0; 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk attachment list and outputs together -- this is a little overpowered since attachments 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are currently dense, but the parallel with matching between shader stages is nice. 16965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && it != outputs.end()) || attachment < color_formats.size()) { 16995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == color_formats.size() || (it != outputs.end() && it->first.first < attachment)) { 1700080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "FS writes to output location %d with no matching attachment", it->first.first)) { 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (it == outputs.end() || it->first.first > attachment) { 1707080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", attachment)) { 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 17125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned output_type = get_fundamental_type(fs, it->second.type_id); 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned att_type = get_format_type(color_formats[attachment]); 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1718080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d of type `%s` does not match FS output type of `%s`", attachment, 17219ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(color_formats[attachment]), 17229ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(fs, it->second.type_id).c_str())) { 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 17525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 175681264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 17705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 18305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 1836c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 1842c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18536c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_block_against_pipeline(layer_data *my_data, 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &range : *pushConstantRanges) { 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 1879080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1880080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 1893080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1894080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19086c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_usage(layer_data *my_data, 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, shader_module const *src, 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 1916080afef66a53dbdd085698b713697296458edfd9Chris Forbes pass &= validate_push_constant_block_against_pipeline(my_data, pushConstantRanges, src, 1917080afef66a53dbdd085698b713697296458edfd9Chris Forbes src->get_def(def_insn.word(1)), stage); 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipelineLayout verify that the setLayout at slot.first 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// has the requested binding at slot.second 192678be5018e238bd464b1f1c55138df277c0c18922Chris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(layer_data *my_data, PIPELINE_LAYOUT_NODE *pipelineLayout, descriptor_slot_t slot) { 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 192937083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 193178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (slot.first >= pipelineLayout->descriptorSetLayouts.size()) 193237083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 193478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto const layout_node = my_data->descriptorSetLayoutMap[pipelineLayout->descriptorSetLayouts[slot.first]]; 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingIt = layout_node->bindingToIndexMap.find(slot.second); 193714fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis if ((bindingIt == layout_node->bindingToIndexMap.end()) || (layout_node->createInfo.pBindings == NULL)) 193837083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 194014fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis assert(bindingIt->second < layout_node->createInfo.bindingCount); 194137083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return &layout_node->createInfo.pBindings[bindingIt->second]; 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1953e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 1956e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 19575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1958e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 1962e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 1963e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 19643d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 19653d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 19663d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 19673d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 19685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1969e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic PIPELINE_NODE *getPipeline(layer_data *my_data, const VkPipeline pipeline) { 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) { 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->pipelineMap[pipeline]; 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1980e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 1981e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 19835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 1985e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 1992e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 1993e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 19943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 19953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 19963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 19973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 1998ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 1999ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2000ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 20013d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20023d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 20033d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 200445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 200545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 20063d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 20083d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20093d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 20103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 20123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 201345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 201445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 20153d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20163d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 20173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 201845824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 201945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 20203d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 20223d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20233d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 20243d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 20263d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20273d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 20283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 20305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 20313d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 20335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If both AttachmentReference arrays have requested index, check their corresponding AttachementDescriptions 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 20405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 20435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 204506e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 204606e963555b0df747c98c43816c16647349d21001Mark Young return true; 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 204806e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 204906e963555b0df747c98c43816c16647349d21001Mark Young return true; 20505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // format and sample count must match 20515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 20535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 20545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 20555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 20565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 20585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 20595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give primary and secondary RenderPass objects, verify that they're compatible 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_renderpass_compatibility(layer_data *my_data, const VkRenderPass primaryRP, const VkRenderPass secondaryRP, 20635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string &errorMsg) { 20645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.find(primaryRP) == my_data->renderPassMap.end()) { 2065c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << primaryRP << ")"; 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 20685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 20695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (my_data->renderPassMap.find(secondaryRP) == my_data->renderPassMap.end()) { 2070c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 20715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << secondaryRP << ")"; 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Trivial pass case is exact same RP 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRP == secondaryRP) { 20775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 20785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *primaryRPCI = my_data->renderPassMap[primaryRP]->pCreateInfo; 20805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI = my_data->renderPassMap[secondaryRP]->pCreateInfo; 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2082c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 20895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 20945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2098c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2106c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2112fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2113fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2114fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2115fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2116fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2117c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2118fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2119fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2120fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2121fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2122fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 21275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2130c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex] 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const SET_NODE *pSet, const VkPipelineLayout layout, 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t layoutIndex, string &errorMsg) { 2143ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes auto pipeline_layout_it = my_data->pipelineLayoutMap.find(layout); 2144ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (pipeline_layout_it == my_data->pipelineLayoutMap.end()) { 2145c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkPipelineLayout (" << layout << ")"; 21475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2150ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (layoutIndex >= pipeline_layout_it->second.descriptorSetLayouts.size()) { 2151c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2152ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes errorStr << "VkPipelineLayout (" << layout << ") only contains " << pipeline_layout_it->second.descriptorSetLayouts.size() 2153ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes << " setLayouts corresponding to sets 0-" << pipeline_layout_it->second.descriptorSetLayouts.size() - 1 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << ", but you're attempting to bind set to index " << layoutIndex; 21555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get the specific setLayout from PipelineLayout that overlaps this set 2159ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes LAYOUT_NODE *pLayoutNode = my_data->descriptorSetLayoutMap[pipeline_layout_it->second.descriptorSetLayouts[layoutIndex]]; 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t descriptorCount = pLayoutNode->descriptorTypes.size(); 21645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (descriptorCount != pSet->pLayout->descriptorTypes.size()) { 2165c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors."; 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; // trivial fail case 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now need to check set against corresponding pipelineLayout to verify compatibility 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (size_t i = 0; i < descriptorCount; ++i) { 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to verify that layouts are identically defined 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // do we also need to check immutable samplers? 21775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) { 2178c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "descriptor " << i << " for descriptorSet being bound is type '" 21805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) 21815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout is type '" 21825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'"; 21835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) { 2187c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] 21895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i]; 21905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2198e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_specialization_offsets(layer_data *my_data, VkPipelineShaderStageCreateInfo const *info) { 2199e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 22005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 22025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 22045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 22055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 22065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 22075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 22085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 22095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 22105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 22115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 22125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2214e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool descriptor_type_match(layer_data *my_data, shader_module const *module, uint32_t type_id, 22241b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22271b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 22281b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 22297b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 22307b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 22315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 22327b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 22337b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 22347b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 22357b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22367b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 22377b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 22387b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 22425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 22435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 22495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 22505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 22605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER; 22615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 226335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 226435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 226535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 226635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 226735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 226835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 226935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 227035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 227135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 227235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 22735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 22775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 22805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 22815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 22835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 22855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 22865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 22885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 22895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 22905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 22915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 22955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 22965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 23005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 23015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 23035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 23045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2307e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool require_feature(layer_data *my_data, VkBool32 feature, char const *feature_name) { 2308a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 2309080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2310080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2311a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2312a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2313a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2314a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2315a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2316a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2317a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2318a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2319a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2320a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2321e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_shader_capabilities(layer_data *my_data, shader_module const *src) { 2322e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2323a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2324b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto enabledFeatures = &my_data->phys_dev_properties.features; 2325a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2326a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2327a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2328a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2329a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2330a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2331a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2332a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2333a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2334a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2335a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2336a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2337a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2338a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2339a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2340a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2341a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 2342a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->geometryShader, "geometryShader"); 2343a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2344a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2345a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 2346a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->tessellationShader, "tessellationShader"); 2347a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2348a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2349a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 2350a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2351a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2352a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2353a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 2354a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderInt64, "shaderInt64"); 2355a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2356a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2357a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2358a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 2359a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2360a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2361a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2362a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2363a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 2364a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2365a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2366a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2367a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 2368a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2369a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2370a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2371a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 2372a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2373a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2374a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2375a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2376a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 2377a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2378a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2379a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2380a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2381a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 2382a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2383a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2384a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2385a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2386a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 2387a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2388a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2389a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2390a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2391a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 2392a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2393a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2394a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2395a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 2396a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2397a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2398a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2399a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 2400a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2401a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2402a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2403a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 2404a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2405a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2406a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2407a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 2408a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2409a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2410a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2411a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 2412a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2413a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2414a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2415a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 2416a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2417a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2418a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2419a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 2420a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2421a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2422a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2423a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 2424a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageExtendedFormats, 2425a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2426a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2427a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2428a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 2429a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2430a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2431a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2432a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 2433a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2434a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2435a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2436a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2437a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 2438a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2439a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2440a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2441a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2442a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 2443a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->multiViewport, "multiViewport"); 2444a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2445a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2446a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 2447080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2448a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2449a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2450a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2451e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2452a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2453a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2454a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2455a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2456a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2457a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2458a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2459a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2460e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_pipeline_shader_stage(layer_data *dev_data, VkPipelineShaderStageCreateInfo const *pStage, 2461e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves PIPELINE_NODE *pipeline, PIPELINE_LAYOUT_NODE *pipelineLayout, 2462e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves shader_module **out_module, spirv_inst_iter *out_entrypoint) { 2463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 246478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto module = *out_module = dev_data->shaderModuleMap[pStage->module].get(); 246578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_specialization_offsets(dev_data, pStage); 246678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 246778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 246878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 246978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2470080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2471080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 247278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 247378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2474e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 247578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 247678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 247778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 247878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 247978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_shader_capabilities(dev_data, module); 248078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 248178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 248278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 248378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 248478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 248578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 248678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::map<descriptor_slot_t, interface_var> descriptor_uses; 248778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes collect_interface_by_descriptor_slot(dev_data, module, accessible_ids, descriptor_uses); 248878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 248978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 249078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_push_constant_usage(dev_data, &pipelineLayout->pushConstantRanges, 249178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes module, accessible_ids, pStage->stage); 249278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 249378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 249478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 249578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 249678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 249778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 249878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the matching binding */ 249978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto binding = get_descriptor_binding(dev_data, pipelineLayout, use.first); 250078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 250178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 250278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2503080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2504080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 250578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 250678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2507e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 250878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 250978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 251078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 251178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 251278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 251378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 251478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 251578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 251678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 251778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2518e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 251978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 252078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (!descriptor_type_match(dev_data, module, use.second.type_id, binding->descriptorType, /*out*/ required_descriptor_count)) { 2521080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2522080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 252378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Type mismatch on descriptor slot " 252478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "%u.%u (used as type `%s`) but " 252578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "descriptor of type %s", 252678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 252778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 252878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2529e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 253078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 253178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2532080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2533080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 253478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 253578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 253678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 253778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes binding->descriptorCount)) { 2538e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 253978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 254078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 254178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 254278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 254378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 254478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 254578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 254678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2547a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2548a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2549e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_capture_pipeline_shader_state(layer_data *my_data, PIPELINE_NODE *pPipeline) { 2550ca546210846c65808717f8875deae39bd227c240Tobin Ehlis auto pCreateInfo = reinterpret_cast<VkGraphicsPipelineCreateInfo const *>(&pPipeline->graphicsPipelineCI); 25515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 25525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 25535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 25555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 25565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 25575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 25585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2559e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 25605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 256178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto pipelineLayout = pCreateInfo->layout != VK_NULL_HANDLE ? &my_data->pipelineLayoutMap[pCreateInfo->layout] : nullptr; 256278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 25635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 2564ca546210846c65808717f8875deae39bd227c240Tobin Ehlis VkPipelineShaderStageCreateInfo const *pStage = 2565ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<VkPipelineShaderStageCreateInfo const *>(&pCreateInfo->pStages[i]); 256678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 256778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_pipeline_shader_stage(my_data, pStage, pPipeline, pipelineLayout, 256878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes &shaders[stage_id], &entrypoints[stage_id]); 25695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 25725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 257409042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_vi_consistency(my_data, vi); 25755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 257809042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_vi_against_vs_inputs(my_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 25795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 25825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 25835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 25855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 25865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 25875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 25905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 25915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2592031261d21af8907953dd763398ce9a23e65b8749Chris Forbes pass &= validate_interface_between_stages(my_data, 2593031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2594031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 25955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 25975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 260078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto rp = pCreateInfo->renderPass != VK_NULL_HANDLE ? my_data->renderPassMap[pCreateInfo->renderPass] : nullptr; 260178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 26025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[fragment_stage] && rp) { 260309042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_fs_outputs_against_render_pass(my_data, shaders[fragment_stage], entrypoints[fragment_stage], rp, 260409042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pCreateInfo->subpass); 26055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 26085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2610e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_compute_pipeline(layer_data *my_data, PIPELINE_NODE *pPipeline) { 2611ca546210846c65808717f8875deae39bd227c240Tobin Ehlis auto pCreateInfo = reinterpret_cast<VkComputePipelineCreateInfo const *>(&pPipeline->computePipelineCI); 261203857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 261303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes auto pipelineLayout = pCreateInfo->layout != VK_NULL_HANDLE ? &my_data->pipelineLayoutMap[pCreateInfo->layout] : nullptr; 261403857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 261503857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 261603857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 261703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 261803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes return validate_pipeline_shader_stage(my_data, &pCreateInfo->stage, pPipeline, pipelineLayout, 261903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes &module, &entrypoint); 262003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 262103857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 26225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 26235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic SET_NODE *getSetNode(layer_data *my_data, const VkDescriptorSet set) { 26245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->setMap.find(set) == my_data->setMap.end()) { 26255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 26265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->setMap[set]; 26285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2629a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2630a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given Layout Node and binding, return index where that binding begins 2631a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingStartIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2632a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2633a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2634a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2635a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2636a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2637a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2638a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex; 2639a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2640a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2641a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given layout node and binding, return last index that is updated 2642a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingEndIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2643a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2644a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2645a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2646a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2647a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2648a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2649a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex - 1; 2650a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2651a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 26527a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 26537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 26547a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 26557a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 26567a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 26577a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 26587a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2659e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 26607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 26617a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis const vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> &activeSetBindingsPairs) { 2662e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 26635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 26655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dynOffsetIndex = 0; 26665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize bufferSize = 0; 2667a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2668a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis SET_NODE *set_node = set_bindings_pair.first; 2669a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis LAYOUT_NODE *layout_node = set_node->pLayout; 2670a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto binding : set_bindings_pair.second) { 2671a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t startIdx = getBindingStartIndex(layout_node, binding); 2672a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t endIdx = getBindingEndIndex(layout_node, binding); 2673a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = startIdx; i <= endIdx; ++i) { 2674e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // We did check earlier to verify that set was updated, but now make sure given slot was updated 2675e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // TODO : Would be better to store set# that set is bound to so we can report set.binding[index] not updated 26769bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis // For immutable sampler w/o combined image, don't need to update 26779bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis if ((set_node->pLayout->createInfo.pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) && 26789bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis (set_node->pLayout->createInfo.pBindings[i].descriptorCount != 0) && 26799bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis (set_node->pLayout->createInfo.pBindings[i].pImmutableSamplers)) { 26809bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis // Nothing to do here 26819bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis } else if (!set_node->pDescriptorUpdates[i]) { 2682e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2683e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2684e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2685e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "DS %#" PRIxLEAST64 " bound and active but it never had binding %u updated. It is now being used to draw so " 2686e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "this will result in undefined behavior.", 2687e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), binding); 2688e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else { 2689e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis switch (set_node->pDescriptorUpdates[i]->sType) { 2690e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 2691e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS = (VkWriteDescriptorSet *)set_node->pDescriptorUpdates[i]; 2692dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young 2693dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young // Verify uniform and storage buffers actually are bound to valid memory at draw time. 2694dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if ((pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) || 2695dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 2696dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) || 2697e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 2698e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2699dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young auto buffer_node = dev_data->bufferMap.find(pWDS->pBufferInfo[j].buffer); 2700dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (buffer_node == dev_data->bufferMap.end()) { 2701dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2702dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2703dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2704dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_INVALID_BUFFER, "DS", 2705dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 ") %s (%#" PRIxLEAST64 ") at index #%u" 2706dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young " is not defined! Has vkCreateBuffer been called?", 2707dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), 2708dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young string_VkDescriptorType(pWDS->descriptorType), 2709dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), i); 2710dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } else { 2711dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young auto mem_entry = dev_data->memObjMap.find(buffer_node->second.mem); 2712dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (mem_entry == dev_data->memObjMap.end()) { 2713e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2714e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2715e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2716dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_INVALID_BUFFER, "DS", 2717dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 ") %s (%#" PRIxLEAST64 ") at index" 2718dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young " #%u, has no memory bound to it!", 2719dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), 2720dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young string_VkDescriptorType(pWDS->descriptorType), 2721dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), i); 2722e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 27235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2724dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young // If it's a dynamic buffer, make sure the offsets are within the buffer. 2725dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if ((pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 2726dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 2727dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young bufferSize = dev_data->bufferMap[pWDS->pBufferInfo[j].buffer].createInfo.size; 2728dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young uint32_t dynOffset = 2729dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].dynamicOffsets[dynOffsetIndex]; 2730dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (pWDS->pBufferInfo[j].range == VK_WHOLE_SIZE) { 2731dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if ((dynOffset + pWDS->pBufferInfo[j].offset) > bufferSize) { 2732dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young result |= log_msg( 2733dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2734dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2735dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2736dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, "DS", 2737dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 ") bound as set #%u has range of " 2738dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VK_WHOLE_SIZE but dynamic offset %#" PRIxLEAST32 ". " 2739dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "combined with offset %#" PRIxLEAST64 " oversteps its buffer (%#" PRIxLEAST64 2740dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young ") which has a size of %#" PRIxLEAST64 ".", 2741dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), i, dynOffset, 2742dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young pWDS->pBufferInfo[j].offset, 2743dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 2744dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2745dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } else if ((dynOffset + pWDS->pBufferInfo[j].offset + pWDS->pBufferInfo[j].range) > 2746dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young bufferSize) { 2747dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young result |= 2748dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2749dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2750dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2751dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, "DS", 2752dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 2753dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young ") bound as set #%u has dynamic offset %#" PRIxLEAST32 ". " 2754dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "Combined with offset %#" PRIxLEAST64 " and range %#" PRIxLEAST64 2755dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young " from its update, this oversteps its buffer " 2756dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "(%#" PRIxLEAST64 ") which has a size of %#" PRIxLEAST64 ".", 2757dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), i, dynOffset, 2758dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young pWDS->pBufferInfo[j].offset, pWDS->pBufferInfo[j].range, 2759dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 2760dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2761dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young dynOffsetIndex++; 2762dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2763e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2764dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2765dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { 2766e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2767e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateImages.insert(pWDS->pImageInfo[j].imageView); 2768e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2769e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { 2770e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2771e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis assert(dev_data->bufferViewMap.find(pWDS->pTexelBufferView[j]) != dev_data->bufferViewMap.end()); 2772e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateBuffers.insert(dev_data->bufferViewMap[pWDS->pTexelBufferView[j]].buffer); 2773e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2774e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 2775e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 2776e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2777e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateBuffers.insert(pWDS->pBufferInfo[j].buffer); 27785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2780e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis i += pWDS->descriptorCount; // Advance i to end of this set of descriptors (++i at end of for loop will move 1 2781e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // index past last of these descriptors) 2782e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis break; 2783e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis default: // Currently only shadowing Write update nodes so shouldn't get here 2784e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis assert(0); 2785e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis continue; 27865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 27925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 27937a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// TODO : This is a temp function that naively updates bound storage images and buffers based on which descriptor sets are bound. 27947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// When validate_and_update_draw_state() handles computer shaders so that active_slots is correct for compute pipelines, this 27957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// function can be killed and validate_and_update_draw_state() used instead 27967a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlisstatic void update_shader_storage_images_and_buffers(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 27977a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkWriteDescriptorSet *pWDS = nullptr; 27987a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis SET_NODE *pSet = nullptr; 27997a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For the bound descriptor sets, pull off any storage images and buffers 28007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // This may be more than are actually updated depending on which are active, but for now this is a stop-gap for compute 28017a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // pipelines 28027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto set : pCB->lastBound[VK_PIPELINE_BIND_POINT_COMPUTE].uniqueBoundSets) { 28037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Get the set node 28047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pSet = getSetNode(dev_data, set); 28057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For each update in the set 28067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto pUpdate : pSet->pDescriptorUpdates) { 28077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // If it's a write update to STORAGE type capture image/buffer being updated 28087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pUpdate && (pUpdate->sType == VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET)) { 28097a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pWDS = reinterpret_cast<VkWriteDescriptorSet *>(pUpdate); 28107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { 28117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.insert(pWDS->pImageInfo[j].imageView); 28137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { 28157a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28167a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.insert(dev_data->bufferViewMap[pWDS->pTexelBufferView[j]].buffer); 28177a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 28197a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 28207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28217a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.insert(pWDS->pBufferInfo[j].buffer); 28227a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28237a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28247a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28257a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28267a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28277a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis} 28285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 2830e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, const bool indexedDraw, 2831e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipelineBindPoint bindPoint) { 2832e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 28337a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto const &state = pCB->lastBound[bindPoint]; 28347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, state.pipeline); 28353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 28367a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 28377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 28387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 28395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 28405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Currently only performing next check if *something* was bound (non-zero last bound) 28415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There is probably a better way to gate when this check happens, and to know if something *should* have been bound 28425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // We should have that check separately and then gate this check based on that check 28435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipe) { 284472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (state.pipelineLayout) { 28455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString; 28465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2847a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> activeSetBindingsPairs; 2848a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto setBindingPair : pPipe->active_slots) { 2849a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t setIndex = setBindingPair.first; 28505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If valid set is not bound throw an error 285172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 28525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 28535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 28545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkPipeline %#" PRIxLEAST64 " uses set #%u but that set is not bound.", 28555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPipe->pipeline, setIndex); 285672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, my_data->setMap[state.boundDescriptorSets[setIndex]], 28575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipe->graphicsPipelineCI.layout, setIndex, errorString)) { 28585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set is bound but not compatible w/ overlapping pipelineLayout from PSO 285972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet setHandle = my_data->setMap[state.boundDescriptorSets[setIndex]]->set; 28605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg( 28615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 28625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 28635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 28645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") bound as set #%u is not compatible with overlapping VkPipelineLayout %#" PRIxLEAST64 " due to: %s", 28655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, setIndex, (uint64_t)pPipe->graphicsPipelineCI.layout, errorString.c_str()); 28667a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 28675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Pull the set node 286872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis SET_NODE *pSet = my_data->setMap[state.boundDescriptorSets[setIndex]]; 28695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 2870a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis activeSetBindingsPairs.push_back(std::make_pair(pSet, setBindingPair.second)); 28719bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 28729bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 28739bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis if (!pSet->pUpdateStructs && !pSet->pLayout->immutableSamplerCount) { 28745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 28755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pSet->set, __LINE__, 28765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 28775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS %#" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 28785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this will result in undefined behavior.", 28795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSet->set); 28805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28837a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 28847a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, pCB, activeSetBindingsPairs); 28857a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28867a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) { 28877a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Verify Vtx binding 28887a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pPipe->vertexBindingDescriptions.size() > 0) { 28897a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (size_t i = 0; i < pPipe->vertexBindingDescriptions.size(); i++) { 28907a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 28917a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 28927a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 28937a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "The Pipeline State Object (%#" PRIxLEAST64 28947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 28957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis " should be set via vkCmdBindVertexBuffers.", 28967a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (uint64_t)state.pipeline, i); 28977a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28997a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else { 29007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (!pCB->currentDrawData.buffers.empty()) { 29017a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 29027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Vertex buffers are bound to command buffer (%#" PRIxLEAST64 29047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (%#" PRIxLEAST64 ").", 29057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline); 29065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 29097a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Skip check if rasterization is disabled or there is no viewport. 29107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if ((!pPipe->graphicsPipelineCI.pRasterizationState || 291145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 29127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pPipe->graphicsPipelineCI.pViewportState) { 2913e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT); 2914e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR); 29157a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (dynViewport) { 29167a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) { 29177a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 29197a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 29207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ", but PSO viewportCount is %u. These counts must match.", 29217a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount); 29227a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29237a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29247a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (dynScissor) { 29257a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) { 29267a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29277a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 29287a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 29297a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ", but PSO scissorCount is %u. These counts must match.", 29307a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount); 29317a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 29375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2939a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 2940a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 2941a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 2942a27508babf63d50aea75883a3702979193c23683Mark Young 2943a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 2944a27508babf63d50aea75883a3702979193c23683Mark Young if ((VK_FALSE == my_data->phys_dev_properties.features.wideLines) && (1.0f != lineWidth)) { 2945a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 2946a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 2947a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 2948a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 2949a27508babf63d50aea75883a3702979193c23683Mark Young } else { 2950a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 2951a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 2952a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 2953a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 2954a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 2955a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 2956a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 2957a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 2958a27508babf63d50aea75883a3702979193c23683Mark Young } 2959a27508babf63d50aea75883a3702979193c23683Mark Young } 2960a27508babf63d50aea75883a3702979193c23683Mark Young 2961a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 2962a27508babf63d50aea75883a3702979193c23683Mark Young} 2963a27508babf63d50aea75883a3702979193c23683Mark Young 29645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 2965e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 2966e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 2967e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 29685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 29705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 29725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 29735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 29745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 29755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 29765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 29775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 29785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 29815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 29825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 29835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 29845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 29875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 29885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 29895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 29915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 29925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 29955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 29985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3002b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 30033d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 300426c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3005c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 3006c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski if ((pAttachments[0].blendEnable != pAttachments[i].blendEnable) || 3007c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcColorBlendFactor != pAttachments[i].srcColorBlendFactor) || 3008c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstColorBlendFactor != pAttachments[i].dstColorBlendFactor) || 3009c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorBlendOp != pAttachments[i].colorBlendOp) || 3010c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcAlphaBlendFactor != pAttachments[i].srcAlphaBlendFactor) || 3011c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstAlphaBlendFactor != pAttachments[i].dstAlphaBlendFactor) || 3012c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].alphaBlendOp != pAttachments[i].alphaBlendOp) || 3013c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorWriteMask != pAttachments[i].colorWriteMask)) { 3014c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski skipCall |= 3015c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3016c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski DRAWSTATE_INDEPENDENT_BLEND, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " 3017c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski "enabled, all elements of pAttachments must be identical"); 3018c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 30195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3022b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 30235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 30245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 30275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 30285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 30305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 30315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 30325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 30355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 30365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3039a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 30405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 30415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 30425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = my_data->renderPassMap.find(pPipeline->graphicsPipelineCI.renderPass); 30435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != my_data->renderPassMap.end() && 30445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass >= rp_data->second->pCreateInfo->subpassCount) { 30455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 30475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "is out of range for this renderpass (0..%u)", 30485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass, rp_data->second->pCreateInfo->subpassCount - 1); 30495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30516c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data, pPipeline)) { 3052e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall = true; 30535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 305452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 305552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 305652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 305752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 305852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 305952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 306052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 306152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 306252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 306352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 306452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 30655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 30665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 30675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 30705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 30725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 30735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 30745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 30775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 30795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 30805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 30815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 30825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 30835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 30865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 30885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 30895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3090ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3091ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 30925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 30945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 30955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology for tessellation pipelines"); 30965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3097ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3098ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology is only valid for tessellation pipelines"); 31045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3105ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 3106ca546210846c65808717f8875deae39bd227c240Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3107ca546210846c65808717f8875deae39bd227c240Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 3108ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "Invalid Pipeline CreateInfo State: " 3109ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 3110ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3111ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3112ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 31135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology used with patchControlPoints value %u." 31175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " patchControlPoints should be >0 and <=32.", 3118ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 31195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3121a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3122a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3123a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 3124a27508babf63d50aea75883a3702979193c23683Mark Young skipCall |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 3125a27508babf63d50aea75883a3702979193c23683Mark Young pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3126a27508babf63d50aea75883a3702979193c23683Mark Young } 3127a27508babf63d50aea75883a3702979193c23683Mark Young } 31285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 31295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 31305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 31315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 313245824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 31335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 31345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 31365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and scissors are dynamic PSO must include " 31375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 31385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 31395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 31405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 3143ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 3144ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 31465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3147e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3148e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 31495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 31515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 31525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 31555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 31565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetViewport().", 31575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 31585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 31615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 31625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 31635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 31665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetScissor().", 31685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 31745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 31775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 31785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 31795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3180ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3181ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 31825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 31845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipeline, return number of MSAA samples, or one if MSAA disabled 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkSampleCountFlagBits getNumSamples(layer_data *my_data, const VkPipeline pipeline) { 31885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipe = my_data->pipelineMap[pipeline]; 3189ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pMultisampleState && 3190ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->graphicsPipelineCI.pMultisampleState->sType)) { 3191ca546210846c65808717f8875deae39bd227c240Tobin Ehlis return pPipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 31925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_SAMPLE_COUNT_1_BIT; 31945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state related to the PSO 3197e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePipelineState(layer_data *my_data, const GLOBAL_CB_NODE *pCB, const VkPipelineBindPoint pipelineBindPoint, 3198e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipeline pipeline) { 3199e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 32005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { 32015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that any MSAA request in PSO matches sample# in bound FB 32025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip the check if rasterization is disabled. 32035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = my_data->pipelineMap[pipeline]; 32045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 320545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 32065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline); 32075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 32085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 32095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits)0; 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 32125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32136f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young const VkPipelineColorBlendStateCreateInfo *pColorBlendState = pPipeline->graphicsPipelineCI.pColorBlendState; 32146f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young if ((pColorBlendState != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 32156f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young (pColorBlendState->attachmentCount != pSD->colorAttachmentCount)) { 32166f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 32176f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young reinterpret_cast<const uint64_t &>(pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 32186f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 32196f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young "count %u but subpass color attachment count %u! These must be the same.", 32206f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young pCB->activeSubpass, pColorBlendState->attachmentCount, pSD->colorAttachmentCount); 32216f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young } 32226f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young 32235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pSD->colorAttachmentCount; i++) { 32245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits samples; 32255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) 32275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 32285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples; 32305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) { 32315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 32325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (subpassNumSamples != samples) { 32335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 32345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 32385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples; 32395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) 32405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else if (subpassNumSamples != samples) 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 32435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 324504826a08000a815c3d7949348c7dfcaac277d7c9Dominik Witczak if ((pSD->colorAttachmentCount > 0 || pSD->pDepthStencilAttachment) && 324604826a08000a815c3d7949348c7dfcaac277d7c9Dominik Witczak psoNumSamples != subpassNumSamples) { 32470292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 32480292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young (uint64_t)pipeline, __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 32490292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 32500292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!", 32510292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young (uint64_t)pipeline, psoNumSamples, (uint64_t)pCB->activeRenderPass, subpassNumSamples); 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass 32555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify and flag error as appropriate 32565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add more checks here 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Validate non-gfx pipeline updates 32615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32620292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young return skipCall; 32635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 32665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic DESCRIPTOR_POOL_NODE *getPoolNode(layer_data *my_data, const VkDescriptorPool pool) { 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) { 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 32715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorPoolMap[pool]; 32735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic LAYOUT_NODE *getLayoutNode(layer_data *my_data, const VkDescriptorSetLayout layout) { 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.find(layout) == my_data->descriptorSetLayoutMap.end()) { 32775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorSetLayoutMap[layout]; 32805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3282e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3283e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3287e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 32915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 32925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 32935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 32975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 33015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 33035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 33045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 33065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 33105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 33115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex; 33135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 33165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 33175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 33195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex + count - 1; 33205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3323e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, 3324e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 33255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 3326e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 33271d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 33305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 33325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3335e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 33405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 33415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 33425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 33445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set first stageFlags as reference and verify that all other updates match it 33455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex]; 33465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = startIndex; i <= endIndex; i++) { 33475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->descriptorTypes[i] != actualType) { 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 33515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 33525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i])); 33535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->stageFlags[i] != refStageFlags) { 33555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 33565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS", 33585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!", 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis refStageFlags, pLayout->stageFlags[i]); 33605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Determine the update type, allocate a new struct of that type, shadow the given pUpdate 3367e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// struct into the pNewNode param. Return true if error condition encountered and callback signals early exit. 33685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 3369e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool shadowUpdateNode(layer_data *my_data, const VkDevice device, GENERIC_HEADER *pUpdate, GENERIC_HEADER **pNewNode) { 3370e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 33725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCopyDescriptorSet *pCDS = NULL; 33735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdate->sType) { 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = new VkWriteDescriptorSet; 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pWDS; 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet)); 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 33825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 33835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 33845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount]; 33855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo)); 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pImageInfo = info; 33875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBufferView *info = new VkBufferView[pWDS->descriptorCount]; 33915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView)); 33925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pTexelBufferView = info; 33935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 33945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 33955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount]; 33995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo)); 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pBufferInfo = info; 34015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3403e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS = new VkCopyDescriptorSet; 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pCDS; 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet)); 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 34155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), pUpdate->sType)) 3417e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 34185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that pNext for the end of shadow copy is NULL 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (*pNewNode)->pNext = NULL; 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given sampler is valid 3425e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSampler(const layer_data *my_data, const VkSampler *pSampler, const bool immutable) { 3426e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 34275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->sampleMap.find(*pSampler); 34285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->sampleMap.end()) { 34295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!immutable) { 34305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 34315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 34325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 34345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // immutable 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 34375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable " 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "sampler %#" PRIxLEAST64, 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the sampler? 34435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34474a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 34484a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 34494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 34504a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 34514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 34544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 34554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 34564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 34574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 34604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 34614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 34624a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 34634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 34644a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34654a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 34664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 34674a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 34684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 34694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 34704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 34724a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 34734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 34744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 34754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 34764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 34774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34794a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 34804a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 34814a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 34824a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 34834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34844a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34854a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 34864a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 34874a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 34884a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 34894a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 34904a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34914a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 34924a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 34934a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 34944a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 34955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 34984a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 34994a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 35004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 35014a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 35024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 35034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 35054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35084a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 35095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 35145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 35154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 35164a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 35174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 35184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 35194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 35204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 35215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 35224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 35235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 35245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35254a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 35265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 35335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 35375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 35405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt == my_data->imageMap.end()) 35415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 35435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 35445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 35455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data->second.size() >= (imgIt->second.createInfo.arrayLayers * imgIt->second.createInfo.mipLevels + 1)) { 35465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 35475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 35495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 35505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 35525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 35535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 35545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 35605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 35615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 35625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 35635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 35665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 357208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 35745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 357508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 357608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 357708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 357808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 358208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 35835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 358408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 358508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 35865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 35875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 35917068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 35927068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 35937068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 359408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 359808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 359908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 360008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 360108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 360208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 360308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 360608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 360708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 360908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 361008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 361108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 361208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 361508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 361708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_view_data = dev_data->imageViewMap.find(imageView); 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_view_data != dev_data->imageViewMap.end()); 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_view_data->second.image; 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_view_data->second.subresourceRange; 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 36265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 36275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 36295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 36305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given imageView is valid 3637e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateImageView(const layer_data *my_data, const VkImageView *pImageView, const VkImageLayout imageLayout) { 3638e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto ivIt = my_data->imageViewMap.find(*pImageView); 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ivIt == my_data->imageViewMap.end()) { 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that imageLayout is compatible with aspectMask and image format 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageAspectFlags aspectMask = ivIt->second.subresourceRange.aspectMask; 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = ivIt->second.image; 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Check here in case we have a bad image 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFormat format = VK_FORMAT_MAX_ENUM; 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 36525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt != my_data->imageMap.end()) { 36535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = (*imgIt).second.createInfo.format; 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Also need to check the swapchains. 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchainIt = my_data->device_extensions.imageToSwapchainMap.find(image); 36575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchainIt != my_data->device_extensions.imageToSwapchainMap.end()) { 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR swapchain = swapchainIt->second; 36595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_nodeIt = my_data->device_extensions.swapchainMap.find(swapchain); 36605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_nodeIt != my_data->device_extensions.swapchainMap.end()) { 36615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SWAPCHAIN_NODE *pswapchain_node = swapchain_nodeIt->second; 36625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = pswapchain_node->createInfo.imageFormat; 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (format == VK_FORMAT_MAX_ENUM) { 36675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 36685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 36695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 36705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " in imageView %#" PRIxLEAST64, 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, (uint64_t)*pImageView); 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3673e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool ds = vk_format_is_depth_or_stencil(format); 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (imageLayout) { 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Only Color bit must be set 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { 36785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 36835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must NOT be DS 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ds) { 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a color format.", 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, string_VkFormat(format)); 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Depth or stencil bit must be set, but both must NOT be set 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) { 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) { 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // both must NOT be set 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 "" 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that has both STENCIL and DEPTH aspects set", 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Neither were set 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have STENCIL or DEPTH aspect set.", 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView); 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must be DS 37205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ds) { 37215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a depth/stencil format.", 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView, string_VkFormat(format)); 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // anything to check for other layouts? 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferView is valid 3739e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateBufferView(const layer_data *my_data, const VkBufferView *pBufferView) { 3740e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferViewMap.find(*pBufferView); 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferViewMap.end()) { 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT, 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView, __LINE__, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS", 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView); 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferInfo is valid 3754e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateBufferInfo(const layer_data *my_data, const VkDescriptorBufferInfo *pBufferInfo) { 3755e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer); 37575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferMap.end()) { 37585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 37605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer, __LINE__, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS", 37615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer); 37635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 37655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3769e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateUpdateContents(const layer_data *my_data, const VkWriteDescriptorSet *pWDS, 3770e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkDescriptorSetLayoutBinding *pLayoutBinding) { 3771e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied 37735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampler *pSampler = NULL; 3774e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool immutable = false; 37755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For given update type, verify that update contents are correct 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable); 37815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayoutBinding->pImmutableSamplers) { 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pWDS->pImageInfo[i].sampler); 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (immutable) { 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", but previous update(s) from this " 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either " 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, (uint64_t)*pSampler); 37965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i > 0 && !immutable) { 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this " 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either " 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i); 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3807e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves immutable = true; 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pLayoutBinding->pImmutableSamplers[i]); 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, pSampler, immutable); 38115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Intentionally fall through here to also validate image stuff 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout); 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: 38225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i])); 38245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i])); 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3841e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3842e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3843e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3844e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s() on descriptor set %" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 38545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 38555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "Cannot call %s() on descriptor set %" PRIxLEAST64 " that is in use by a command buffer.", 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void invalidateBoundCmdBuffers(layer_data *dev_data, const SET_NODE *pSet) { 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Flag any CBs this set is bound to as INVALID 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : pSet->boundCmdBuffers) { 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cb_node = dev_data->commandBufferMap.find(cb); 38655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_node != dev_data->commandBufferMap.end()) { 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cb_node->second->state = CB_INVALID; 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// update DS mappings based on write and copy update arrays 3871e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool dsUpdate(layer_data *my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pWDS, 3872e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pCDS) { 3873e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = NULL; 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSetLayoutCreateInfo *pLayoutCI = NULL; 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate Write updates 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 38795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorWriteCount; i++) { 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSet ds = pWDS[i].dstSet; 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = my_data->setMap[ds]; 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 3883e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateIdleDescriptorSet(my_data, ds, "VkUpdateDescriptorSets")) == true) 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If set is bound to any cmdBuffers, mark them invalid 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pSet); 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pUpdate = (GENERIC_HEADER *)&pWDS[i]; 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayout = pSet->pLayout; 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify valid update struct 3890e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == true) { 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t binding = 0, endIndex = 0; 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = pWDS[i].dstBinding; 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingToIndex = pLayout->bindingToIndexMap.find(binding); 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that layout being updated has the binding being updated 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (bindingToIndex == pLayout->bindingToIndexMap.end()) { 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor Set %" PRIu64 " does not have binding to match " 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "update binding %u for update type " 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s!", 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), binding, string_VkStructureType(pUpdate->sType)); 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Next verify that update falls within size of given binding 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pLayout, binding) < endIndex) { 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pLayout->createInfo; 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 39135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 39145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), binding, DSstr.c_str()); 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // TODO : should we skip update on a type mismatch or force it? 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t startIndex; 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 39185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layout bindings match w/ update, now verify that update type 39195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // & stageFlags are the same for entire update 3920e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == false) { 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The update is within bounds and consistent, but need to 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // make sure contents make sense as well 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((skipCall = validateUpdateContents(my_data, &pWDS[i], 3924e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves &pLayout->createInfo.pBindings[bindingToIndex->second])) == false) { 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update is good. Save the update info 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new update struct for this set's shadow copy 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pNewNode = NULL; 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode); 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()"); 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert shadow node into LL of updates for this set 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pSet->pUpdateStructs; 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = pNewNode; 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update appropriate descriptor(s) to point to new Update node 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = startIndex; j <= endIndex; j++) { 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(j < pSet->descriptorCount); 39413a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates[j] = pNewNode; 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now validate copy updates 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorCopyCount; ++i) { 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSrcSet = NULL, *pDstSet = NULL; 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL; 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0; 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each copy make sure that update falls within given layout and that types match 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcSet = my_data->setMap[pCDS[i].srcSet]; 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet = my_data->setMap[pCDS[i].dstSet]; 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 3958e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateIdleDescriptorSet(my_data, pDstSet->set, "VkUpdateDescriptorSets")) == true) 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pDstSet); 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcLayout = pSrcSet->pLayout; 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstLayout = pDstSet->pLayout; 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src binding is valid for src set layout 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->bindingToIndexMap.find(pCDS[i].srcBinding) == pSrcLayout->bindingToIndexMap.end()) { 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has srcBinding %u " 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].srcBinding, (uint64_t)pSrcLayout->layout, pSrcLayout->createInfo.bindingCount - 1); 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pDstLayout->bindingToIndexMap.find(pCDS[i].dstBinding) == pDstLayout->bindingToIndexMap.end()) { 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has dstBinding %u " 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].dstBinding, (uint64_t)pDstLayout->layout, pDstLayout->createInfo.bindingCount - 1); 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 39815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) { 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pSrcLayout->createInfo; 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].srcBinding, DSstr.c_str()); 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) { 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pDstLayout->createInfo; 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].dstBinding, DSstr.c_str()); 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pCDS[i].descriptorCount; ++j) { 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For copy just make sure that the types match and then perform the update 40075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->descriptorTypes[srcStartIndex + j] != pDstLayout->descriptorTypes[dstStartIndex + j]) { 40085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 40095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 40105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update index %u, update count #%u, has src update descriptor type %s " 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that does not match overlapping dest descriptor type of %s!", 40125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, j + 1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex + j]), 40135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex + j])); 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // point dst descriptor at corresponding src descriptor 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This may be a hole. I believe copy should be its own copy, 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // otherwise a subsequent write update to src will incorrectly affect the copy 40183a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pDstSet->pDescriptorUpdates[j + dstStartIndex] = pSrcSet->pDescriptorUpdates[j + srcStartIndex]; 40195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet->pUpdateStructs = pSrcSet->pUpdateStructs; 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4028a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// Verify that given pool has descriptors that are being requested for allocation. 4029a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// NOTE : Calls to this function should be wrapped in mutex 4030e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_descriptor_availability_in_pool(layer_data *dev_data, DESCRIPTOR_POOL_NODE *pPoolNode, uint32_t count, 4031e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkDescriptorSetLayout *pSetLayouts) { 4032e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4033a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t i = 0; 4034a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t j = 0; 4035a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 4036a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Track number of descriptorSets allowable in this pool 4037a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski if (pPoolNode->availableSets < count) { 4038a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 4039a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski reinterpret_cast<uint64_t &>(pPoolNode->pool), __LINE__, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 4040a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski "Unable to allocate %u descriptorSets from pool %#" PRIxLEAST64 4041a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptorSets remaining.", 4042a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski count, reinterpret_cast<uint64_t &>(pPoolNode->pool), pPoolNode->availableSets); 4043a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } else { 4044a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets -= count; 4045a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } 4046a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; ++i) { 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pSetLayouts[i]); 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 40525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i], __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 40535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 40545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i]); 40555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pLayout->createInfo.bindingCount; ++j) { 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) { 40615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 40625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pLayout->layout, __LINE__, 40635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 40645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 4065a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptors of this type remaining.", 40665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBindings[j].descriptorType), 40675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]); 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Decrement available descriptors of this type 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount; 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the shadowed update node for this Set 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void freeShadowUpdateTree(SET_NODE *pSet) { 40805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pShadowUpdate = pSet->pUpdateStructs; 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = NULL; 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pFreeUpdate = pShadowUpdate; 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the descriptor mappings as they will now be invalid 40843a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates.clear(); 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pShadowUpdate) { 40865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeUpdate = pShadowUpdate; 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pShadowUpdate = (GENERIC_HEADER *)pShadowUpdate->pNext; 40885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 40895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pFreeUpdate->sType) { 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = (VkWriteDescriptorSet *)pFreeUpdate; 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 40935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 40945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 40955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 40965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 40975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pImageInfo; 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 40995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 41005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 41015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pTexelBufferView; 41025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 41045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 41055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 41075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pBufferInfo; 41085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 41105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 41145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 41165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(0); 41175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeUpdate; 41205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 41245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 41265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 41275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 41285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 41295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = (*ii).second->pSets; 41305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pFreeSet = pSet; 41315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeSet = pSet; 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Freeing layouts handled in deleteLayouts() function 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free Update shadow struct tree 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pFreeSet); 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeSet; 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 41425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteLayouts(layer_data *my_data) { 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.size() <= 0) 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorSetLayoutMap.begin(); ii != my_data->descriptorSetLayoutMap.end(); ++ii) { 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = (*ii).second; 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->createInfo.pBindings) { 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings[i].pImmutableSamplers; 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings; 41565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pLayout; 41585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorSetLayoutMap.clear(); 41605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Currently clearing a set is removing all previous updates to that set 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Validate if this is correct clearing behavior 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorSet(layer_data *my_data, VkDescriptorSet set) { 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = getSetNode(my_data, set); 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSet) { 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Return error 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pSet); 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPool) { 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 41785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t)pool); 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: validate flags 418251db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free SET_NODE 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = pPool->pSets; 418451db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis SET_NODE *pFreeSet = pSet; 41855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 41865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorSet(my_data, pSet->set); 418751db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis my_data->setMap.erase(pSet->set); 418851db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis pFreeSet = pSet; 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 419051db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis delete pFreeSet; 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 419251db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis pPool->pSets = nullptr; 4193e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis // Reset available count for each type and available sets for this pool 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 41955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 41965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4197e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis pPool->availableSets = pPool->maxSets; 41985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *my_data, const VkCommandBuffer cb) { 42035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->commandBufferMap.count(cb) == 0) { 420472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 420572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 420672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 42075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 42085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->commandBufferMap[cb]; 42105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 4215400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 42175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 42225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4224e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4230e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 4232e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 4233e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && cmd_type != CMD_EXECUTECOMMANDS) { 42355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 42385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 42395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 42425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 42485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 42515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 42525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 42555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 42595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 42605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 42635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 42645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 42675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 42685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 4272e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool addCmd(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 4273e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 42745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = my_data->commandPoolMap.find(pCB->createInfo.commandPool); 42755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != my_data->commandPoolMap.end()) { 4276b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pool_data->second.queueFamilyIndex].queueFlags; 42775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 42805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 42815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 42825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 42835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 42845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 42855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 42865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 42875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 42885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 42895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 42905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 42915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 42925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 42945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 42955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 42965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 42975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 42995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 43005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 43075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 43085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 43105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 43115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 43125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 43135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 43145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 43185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 43195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 43255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 43265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 43275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 43285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 43295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 43315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 43355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 43365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 43375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 43395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 43405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 43415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 43425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 4347400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 4348400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 43495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 4350b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 43515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 43525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 43535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 43555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 43565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 43575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 43585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 43595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 43605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 43615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 43625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 436393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 436472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 436572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 436672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 4367400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis auto set_node = dev_data->setMap.find(set); 4368400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (set_node != dev_data->setMap.end()) { 436972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis set_node->second->boundCmdBuffers.erase(pCB->commandBuffer); 437072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 437172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 437272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 437372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 437493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 43755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 43765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 43775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 43785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 437972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedFence = VK_NULL_HANDLE; 438072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedQueue = VK_NULL_HANDLE; 43815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedSets.clear(); 43825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->updatedSets.clear(); 43835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedFramebuffers.clear(); 43845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 43855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->semaphores.clear(); 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 43875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 43885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 43895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 4391abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 43925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 43935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 43945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 43955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 43965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 4397bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 4398bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 4399bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 4400bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 44015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 44027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 44037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 4404400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 4405b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 440693c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 440793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 440893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 440993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski auto fbNode = dev_data->frameBufferMap.find(framebuffer); 441093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski if (fbNode != dev_data->frameBufferMap.end()) { 441193c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski fbNode->second.referencingCmdBuffers.erase(pCB->commandBuffer); 441293c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 441393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 441493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 441593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 44165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 44205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 44215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 4422ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 4423ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 44245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 44255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 44275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 44285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 44295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 4430ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 4431ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 44325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 44335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 44395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 44405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 44425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 44453d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 44485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 44515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 44545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 44575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 44605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 44615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 4469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 4470e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 44725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 447372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 44755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 44765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 4479ca546210846c65808717f8875deae39bd227c240Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 4480ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 4481ca546210846c65808717f8875deae39bd227c240Tobin Ehlis .c_str()); 44825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 44885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 44895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 44905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 44915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_NONE, "DS", "Cmds in CB %p", (void *)cb); 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", " CMD#%" PRIu64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 45005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4503e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 4504e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 45055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= printPipeline(my_data, cb); 45095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 45135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 4514e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4515e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 45165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 45175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 45195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")", apiName, 45205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass); 45215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 45235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 4527e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4528e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 45315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 45325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 45345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 45355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 45375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4539b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 4540d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4541b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 45425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 45475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 45485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 45505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 45515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 45525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 45535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 45545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 45565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 45575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 45595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 45605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4562b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 4563b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 4564b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 45655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4566b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 4567b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 4568b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 45695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4570b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 45735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 45795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 45805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 45815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 45825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 45835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 45845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 45855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 45865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4587b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 45885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 45905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 45915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 45925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 45935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 45965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 45975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 45985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 46015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 46025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 46035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 46045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 46065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 46085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 46095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 46105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 46115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 46125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 46135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 46145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 46175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 46185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 46225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 46235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 46245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 46265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 46275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 46285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(NULL, "vkCreateDevice"); 46295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 46305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 46315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 46345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 46355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 46375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 46385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4641b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 46425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 46435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 46445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 46465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 46475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 46486c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 46495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 46515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 46525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4653b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 46545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 46555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4656b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 46575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4658b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 46595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 46605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4661b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 46625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4663b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 46645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4665b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4666b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4667b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 46685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 46705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 46755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 46765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 46775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 46785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 46795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 46805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4681b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 46825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 46835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 46845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 46855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 46865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteLayouts(dev_data); 46875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 46885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 46905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 46915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 46925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 46931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 46941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4695b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 469603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 4697e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4698b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 47005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 47015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 47025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 47030a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 47040a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 47055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 470658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4707400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 47085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 47105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 47115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 47125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 47135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 47145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, 47155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mem Object %" PRIu64 " has not been freed. You should clean up this memory by calling " 47165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkFreeMemory(%" PRIu64 ") prior to vkDestroyDevice().", 47175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 47185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4722b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 47235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 47255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fprintf(stderr, "Device: %p, key: %p\n", device, key); 47265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 47275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 4728e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 47295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 47325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 47335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 47345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 47355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 47395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 47415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 47425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 47435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 47465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 47475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_global_layers), cv_global_layers, pCount, pProperties); 47485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Why does this exist - can we just use global? 47515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_device_layers[] = {{ 4752f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 47535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 47545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 47565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *pLayerName, uint32_t *pCount, 47575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkExtensionProperties *pProperties) { 47585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayerName == NULL) { 47595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(physicalDevice); 47605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 47615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 47625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(0, NULL, pCount, pProperties); 47645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 47685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 47695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* draw_state physical device layers are the same as global */ 47705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_device_layers), cv_device_layers, pCount, pProperties); 47715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 47745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 47755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4776e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) { 4777e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 47785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 47795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 47805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 47815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 47825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 47835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 47845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image %" PRIu64 ".", 47865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 47895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 47905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4791856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4792856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4793856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4794856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4795856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "Cannot submit cmd buffer using image (%" PRIx64 ") [sub-resource: array layer %u, mip level %u], " 4796856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4797856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.arrayLayer, 4798856ecb404bc959ddb877c150c9caa0649055b9cbMark Young cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4799856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4800856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4801856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4802856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4803856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4804856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "Cannot submit cmd buffer using image (%" PRIx64 ") with layout %s when " 4805856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4806856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4807856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4808856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 48095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 48115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 481539d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 48165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 4817e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB) { 4818e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 48205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 48215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 48225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 48235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 48245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted buffer %" PRIu64 ".", (uint64_t)(buffer)); 48265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_add(1); 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 483172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 483272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 483372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 483472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode == my_data->setMap.end()) { 483572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 483672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 483772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 483872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Cannot submit cmd buffer using deleted descriptor set %" PRIu64 ".", (uint64_t)(set)); 483972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 484072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_add(1); 484172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 48425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 48455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 48465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode == my_data->semaphoreMap.end()) { 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 48485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 48495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 48505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted semaphore %" PRIu64 ".", reinterpret_cast<uint64_t &>(semaphore)); 48515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_add(1); 48535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 48565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 48575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode == my_data->eventMap.end()) { 48585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 48595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 48605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 48615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted event %" PRIu64 ".", reinterpret_cast<uint64_t &>(event)); 48625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_add(1); 48645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4869b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4870b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 4871b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4872b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4873b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4874b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4875b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4876b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4877b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4878b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4879b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4880b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine "Cannot get query results on queryPool %" PRIu64 4881b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine " with index %d which was guarded by unsignaled event %" PRIu64 ".", 4882b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4883b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4884b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4885b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4886b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4887b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4888b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4889b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4890b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4891b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4892b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4893b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4894b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4895b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4896b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4897b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4898b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4899e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, VkCommandBuffer cmdBuffer) { 49005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 49015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 49025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 49035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 49045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != my_data->bufferMap.end()) { 49055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_sub(1); 49065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 490972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 491072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 491172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 491272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode != my_data->setMap.end()) { 491372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_sub(1); 491472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 49155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 49185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 49195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode != my_data->semaphoreMap.end()) { 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_sub(1); 49215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 49245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 49255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode != my_data->eventMap.end()) { 49265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_sub(1); 49275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 49305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 49315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto eventStagePair : pCB->eventToStageMap) { 49335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 49345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4936a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// For fenceCount fences in pFences, mark fence signaled, decrement in_use, and call 4937a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// decrementResources for all priorFences and cmdBuffers associated with fence. 4938b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 4939b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 49405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 49415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(pFences[i]); 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end() || !fence_data->second.needsSignaled) 4943b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 49445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = false; 49455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_sub(1); 49461d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill decrementResources(my_data, static_cast<uint32_t>(fence_data->second.priorFences.size()), 49471d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill fence_data->second.priorFences.data()); 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : fence_data->second.cmdBuffers) { 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 4950b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= cleanInFlightCmdBuffer(my_data, cmdBuffer); 4951b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine removeInFlightCmdBuffer(my_data, cmdBuffer); 49525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4954b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4956a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Decrement in_use for all outstanding cmd buffers that were submitted on this queue 4957b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, VkQueue queue) { 4958b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 49595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : queue_data->second.untrackedCmdBuffers) { 49625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 4963b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= cleanInFlightCmdBuffer(my_data, cmdBuffer); 4964b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine removeInFlightCmdBuffer(my_data, cmdBuffer); 49655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 4967b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(my_data, static_cast<uint32_t>(queue_data->second.lastFences.size()), 4968b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine queue_data->second.lastFences.data()); 49690a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4970b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 49710a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 49720a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 4973b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This function merges command buffer tracking between queues when there is a semaphore dependency 4974b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// between them (see below for details as to how tracking works). When this happens, the prior 4975b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// fences from the signaling queue are merged into the wait queue as well as any untracked command 4976b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers. 4977e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 49780a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 49790a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 49800a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49810a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 49820a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto other_queue_data = dev_data->queueMap.find(other_queue); 49830a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue_data == dev_data->queueMap.end() || other_queue_data == dev_data->queueMap.end()) { 49840a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 49850a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4986ca32a764ef85a255c97531164bffb073553de105Jamie Madill for (auto fenceInner : other_queue_data->second.lastFences) { 4987ca32a764ef85a255c97531164bffb073553de105Jamie Madill queue_data->second.lastFences.push_back(fenceInner); 49880a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49890a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence != VK_NULL_HANDLE) { 49900a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 49910a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence_data == dev_data->fenceMap.end()) { 49920a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 49930a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 49950a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 49960a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49970a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 49980a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 49990a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 50000a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.untrackedCmdBuffers.push_back(cmdbuffer); 50010a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50020a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 50035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5004b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto eventStagePair : other_queue_data->second.eventToStageMap) { 5005b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[eventStagePair.first] = eventStagePair.second; 5006b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 50075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5009b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This is the core function for tracking command buffers. There are two primary ways command 5010b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers are tracked. When submitted they are stored in the command buffer list associated 5011b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// with a fence or the untracked command buffer list associated with a queue if no fence is used. 5012b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Each queue also stores the last fence that was submitted onto the queue. This allows us to 5013b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// create a linked list of fences and their associated command buffers so if one fence is 5014b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on, prior fences on that queue are also considered to have been waited on. When a fence is 5015b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on (either via a queue, device or fence), we free the cmd buffers for that fence and 5016b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// recursively call with the prior fences. 5017e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void trackCommandBuffers(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 5018e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkFence fence) { 50195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 50210a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine vector<VkFence> prior_fences; 50225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(fence); 50235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end()) { 50245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 50255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5026abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine fence_data->second.cmdBuffers.clear(); 50275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50280a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine prior_fences = queue_data->second.lastFences; 50290a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.clear(); 50300a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.push_back(fence); 50310a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : queue_data->second.untrackedCmdBuffers) { 50320a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 50335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50360a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.priorFences = prior_fences; 50375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = true; 50385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.queue = queue; 50395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_add(1); 50405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(secondaryCmdBuffer); 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(submit->pCommandBuffers[i]); 50475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 50505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(secondaryCmdBuffer); 50565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(submit->pCommandBuffers[i]); 50585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5062b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 5063b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 5064b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic void markCommandBuffersInFlight(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 5065b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VkFence fence) { 5066b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine auto queue_data = my_data->queueMap.find(queue); 50675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 5071b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Add cmdBuffers to the global set and increment count 5072b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, submit->pCommandBuffers[i]); 50735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(secondaryCmdBuffer); 5075b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pSubCB = getCBNode(my_data, secondaryCmdBuffer); 5076b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pSubCB->in_use.fetch_add(1); 50775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 5079b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_add(1); 50805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5085e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 50865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 50875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 50885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 50895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 50905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 509127c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 509227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Command Buffer %#" PRIx64 " is already in use and is not marked for simultaneous use.", 50935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 50945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 50965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 50995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 51000a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 51010a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 51020a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 51030a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 51040a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 51050a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis "set, but has been submitted %#" PRIxLEAST64 " times.", 51060a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 51070a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 51085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 51095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 51105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 51125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool causeReported = false; 51135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedSets.empty()) { 51145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 51155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->destroyedSets) 51165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 51175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 51225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) destroyed: %s", 51235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 51245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 51255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->updatedSets.empty()) { 51275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 51285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->updatedSets) 51295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 51305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) updated: %s", 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 51375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 51385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedFramebuffers.empty()) { 51405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream fb_string; 51415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto fb : pCB->destroyedFramebuffers) 51425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_string << " " << fb; 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid because it had the following " 51485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "referenced framebuffers destroyed: %s", 51495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), fb_string.str().c_str()); 51505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 51515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This is defensive programming to make sure an error is 51535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // flagged if we hit this INVALID cmd buffer case and none of the 51545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // above cases are hit. As the number of INVALID cases grows, this 51555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // code should be updated to seemlessly handle all the cases. 51565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!causeReported) { 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 51585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid due to an unknown cause. Validation " 51615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "should " 51625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "be improved to report the exact cause.", 51635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer)); 51645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 51695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", 51705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 51715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 51745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5176e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 51775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 5178e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = validateAndIncrementResources(dev_data, pCB); 51795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 51805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 51815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndIncrementResources(dev_data, dev_data->commandBufferMap[secondaryCmdBuffer]); 51825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 51835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->primaryCommandBuffer != pCB->commandBuffer) { 51845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 51855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 51865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "CB %#" PRIxLEAST64 " was submitted with secondary buffer %#" PRIxLEAST64 51875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 51885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "primary cmd buffer %#" PRIxLEAST64 ".", 51895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 51905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 51915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pCB); 51955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 51965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // on device 51975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferSimultaneousUse(dev_data, pCB); 51985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 51995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 52025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 5203e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 520472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = NULL; 52055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 52065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5207b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that fence is not in use 5209a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence != VK_NULL_HANDLE) { 5210a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis dev_data->fenceMap[fence].queue = queue; 5211a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if ((submitCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 5212a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 5213a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 5214a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "Fence %#" PRIx64 " is already in use by another submission.", (uint64_t)(fence)); 5215a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 5216a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!dev_data->fenceMap[fence].needsSignaled) { 5217a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 5218a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 5219a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 5220a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence)); 5221a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 52225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 52241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 52251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 5226b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Update cmdBuffer-related data structs and mark fence in-use 5227b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine trackCommandBuffers(dev_data, queue, submitCount, pSubmits, fence); 52285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 52290a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 52305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 52315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 52325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 52335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 52340a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pWaitSemaphores[i]; 523541bb23666442c59912c630f85db04ce1a052f3efTobin Ehlis semaphoreList.push_back(semaphore); 52361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 52371344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 52381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 52391344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 52401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 52411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 52421344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 52431344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 52441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 52451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52461344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkQueue &other_queue = dev_data->semaphoreMap[semaphore].queue; 52471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 52481344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 52491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis processed_other_queues.insert(other_queue); 52501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 52540a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pSignalSemaphores[i]; 52551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 52561344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis semaphoreList.push_back(semaphore); 52571344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 52581344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 52591344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 52601344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 52611344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Queue %#" PRIx64 " is signaling semaphore %#" PRIx64 52621344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has already been signaled but not waited on by queue %#" PRIx64 ".", 52631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 52641344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(dev_data->semaphoreMap[semaphore].queue)); 52651344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 52661344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 52671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].queue = queue; 52681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52690a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 52705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 52725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]); 527372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 52741344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 52751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->semaphores = semaphoreList; 52761344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 52771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedFence = fence; 52781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedQueue = queue; 52791344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= validatePrimaryCommandBufferState(dev_data, pCBNode); 52801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 52811344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 52821344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(); 52831344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52841344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 52851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(queue); 52861344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5290b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine markCommandBuffersInFlight(dev_data, queue, submitCount, pSubmits, fence); 5291b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5292e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 52945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 529803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 52995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 53005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 53015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 53035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 5304b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 53055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 53060a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 53075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 53115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 53155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 53165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 53175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 53185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 53205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5321b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5322e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves freeMemObjInfo(my_data, device, mem, false); 53230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 53240a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 5325b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 53275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5329e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 5330e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 53315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 53335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: a size of 0 is not listed as an invalid use in the spec, should it be? 53345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 53375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 53425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.size != 0) { 53435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object %#" PRIxLEAST64, (uint64_t)mem); 53465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 53495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 53505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (offset >= mem_element->second.allocInfo.allocationSize) { 53515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 53535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 53545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.allocInfo.allocationSize, mem_element->second.allocInfo.allocationSize); 53555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 53575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((offset + size) > mem_element->second.allocInfo.allocationSize) { 53585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 53615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size + offset, mem_element->second.allocInfo.allocationSize); 53625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 53665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5368e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 53695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MemRange new_range; 53725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.offset = offset; 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.size = size; 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange = new_range; 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5378e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 5379e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_element->second.memRange.size) { 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 53845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj %#" PRIxLEAST64, (uint64_t)mem); 53875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange.size = 0; 53895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 53905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis free(mem_element->second.pData); 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 53925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 53955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5399b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 5400b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto mem_element = dev_data->memObjMap.find(mem); 5401b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (mem_element != dev_data->memObjMap.end()) { 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pDriverData = *ppData; 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t index = mem_element->second.allocInfo.memoryTypeIndex; 5404b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 54055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 54075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size = mem_element->second.allocInfo.allocationSize; 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 54115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = malloc(2 * convSize); 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(mem_element->second.pData, NoncoherentMemoryFillValue, 2 * convSize); 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppData = static_cast<char *>(mem_element->second.pData) + (convSize / 2); 54145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 5418a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 5419a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// a fence being waited on should not already be signalled and 5420a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 5421a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlisstatic inline bool verifyWaitFenceState(VkDevice device, VkFence fence, const char *apiCall) { 54225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5423e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFenceInfo = my_data->fenceMap.find(fence); 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceInfo != my_data->fenceMap.end()) { 5426e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!pFenceInfo->second.firstTimeFlag) { 5427a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!pFenceInfo->second.needsSignaled) { 54285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 54295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 54315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s specified fence %#" PRIxLEAST64 " already in SIGNALED state.", apiCall, (uint64_t)fence); 54325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pFenceInfo->second.queue && !pFenceInfo->second.swapchain) { // Checking status of unsubmitted fence 54345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s called for fence %#" PRIxLEAST64 " which has not been submitted on a Queue or during " 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "acquire next image.", 54385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5441e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pFenceInfo->second.firstTimeFlag = false; 54425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5446a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 54475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 54485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 54495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5450e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 54515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 5452b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 5454a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skip_call |= verifyWaitFenceState(device, pFences[i], "vkWaitForFences"); 54555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5456b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 54585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5459a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 54605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 54615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5463b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 54645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 54655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 5466b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, fenceCount, pFences); 54675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 54695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 5471b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5473e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 54745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetFenceStatus(VkDevice device, VkFence fence) { 54795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 54815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5482b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5483a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall = verifyWaitFenceState(device, fence, "vkGetFenceStatus"); 5484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5485a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 54875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 5488a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 54895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 5490e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 5491b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 54925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5493b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skipCall |= decrementResources(dev_data, 1, &fence); 54945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5495b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5496e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 54975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5501b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5502b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 55035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 5505b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5506b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5507b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5508b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5509b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5510b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 5511b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 5512b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 55135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueWaitIdle(VkQueue queue) { 55165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 5517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 5518b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 5519e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 55205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 55225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDeviceWaitIdle(VkDevice device) { 5526e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5528b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 5530b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 55315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 5533b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5534e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 55355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 55415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5543b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 55451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 55461344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair->second.in_use.load()) { 55471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 55481344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 55491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", (uint64_t)(fence)); 55501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 55511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5553b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55541344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 55555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 55605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 55615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 5563b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 55665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 55685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete semaphore %" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 55705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 55725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 55745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 55775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5579b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto event_data = dev_data->eventMap.find(event); 55815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data != dev_data->eventMap.end()) { 55825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data->second.in_use.load()) { 55835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg( 55845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 55855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 55865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete event %" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 55875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap.erase(event_data); 55895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5590b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 55925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 55935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 55945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 55975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 55985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 55995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 56005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 56015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkGetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 56045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 56055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryResultFlags flags) { 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = nullptr; 5609b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 56115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB = getCBNode(dev_data, cmdBuffer); 56125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 56135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 56145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5616e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 56175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 56185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 56195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 56205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 56215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5622ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5623ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5624ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5625ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5626ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 5627ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5628ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5629ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5630ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5631ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 " with index %d which is in flight.", 5632ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5633ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5634ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5635ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5636ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5637ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5638ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5639ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5640ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5641ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5642ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5643ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5644ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5645ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 5646ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5647ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5648ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 56495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 56505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5651ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 56525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 56535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5654ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5655ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 56565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 56575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 56585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 56595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5660ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5661ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5662ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5663ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5664ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 5665ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5666ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 56675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5670b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 56725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 56735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 56745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 56755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5677e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5678e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 56795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 56805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 56815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 56825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 56835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 56845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 56855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data->second.in_use.load()) { 56865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 56875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 56885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 56895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 56925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 56955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks *pAllocator) { 56965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5697e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5698b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5699e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!validateIdleBuffer(dev_data, buffer) && !skipCall) { 5700b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 5702b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 57035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.erase(buffer); 57055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 57085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 57095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 5711b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 57125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 57135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 57145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 57155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 57195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5720e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5721e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 57225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 57235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5724b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 57255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& entry = dev_data->imageMap.find(image); 57265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (entry != dev_data->imageMap.end()) { 572758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Clear any memory mapping for this image 572894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto mem_entry = dev_data->memObjMap.find(entry->second.mem); 572958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (mem_entry != dev_data->memObjMap.end()) 573058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis mem_entry->second.image = VK_NULL_HANDLE; 573158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 573258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 57335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.erase(entry); 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 57365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 57375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 57385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 57395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 574303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 5744e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 5745e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkDebugReportObjectTypeEXT object_type) { 57465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 574758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 57485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Buffer %" PRIx64 " is alised with image %" PRIx64, object_handle, 57495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 57505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 575158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 57525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Image %" PRIx64 " is alised with buffer %" PRIx64, object_handle, 57535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 57545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5757e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 5758e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkDebugReportObjectTypeEXT object_type) { 5759e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 576058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 57615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto range : ranges) { 5762b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) < 5763b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (new_range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 57645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 5765b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) > 5766b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (new_range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 57675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 576858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 57695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 57715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5773e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_buffer_image_aliasing(layer_data *dev_data, uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 5774e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges, 5775e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const vector<MEMORY_RANGE> &other_ranges, VkDebugReportObjectTypeEXT object_type) { 57765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMORY_RANGE range; 57775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.handle = handle; 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.memory = mem; 57795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.start = memoryOffset; 57805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.end = memoryOffset + memRequirements.size - 1; 578158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis ranges.push_back(range); 578258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return validate_memory_range(dev_data, other_ranges, range, object_type); 57835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 57865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 578758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5789b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 57905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 57915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 5792e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = 579394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 579494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto buffer_node = dev_data->bufferMap.find(buffer); 579594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 579694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis buffer_node->second.mem = mem; 57975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 579894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 579958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, buffer_handle, mem, memoryOffset, memRequirements, 580058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].bufferRanges, dev_data->memObjMap[mem].imageRanges, 580158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 58022c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 58032c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 58042c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58052c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 58062c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 58072c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be an integer multiple of the " 58082c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "VkMemoryRequirements::alignment value %#" PRIxLEAST64 58092c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 58102c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 58112c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58122c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 581394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].createInfo.usage; 58142c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & (VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT)) { 5815b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment) != 0) { 58162c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58172c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 58182c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 58192c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 58202c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minTexelBufferOffsetAlignment %#" PRIxLEAST64, 5821b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment); 58222c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58232c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58242c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT) { 5825b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 5826b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 58272c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58282c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 58292c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 58302c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 58312c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minUniformBufferOffsetAlignment %#" PRIxLEAST64, 5832b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 58332c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58342c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58352c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_STORAGE_BUFFER_BIT) { 5836b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 5837b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 58382c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58392c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 58402c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 58412c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 58422c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minStorageBufferOffsetAlignment %#" PRIxLEAST64, 5843b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 58442c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58452c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58470a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5848b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5849e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 585058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 58515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 58575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 58595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 58605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 58615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 58655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 58675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 58685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 58695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 58715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 58735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 58745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 58755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 58765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5880918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5881918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5882b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5883918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5884b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5885918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5886918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 58875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 58915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 58925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 58935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 58975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 58985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 58995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 59045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 59055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 59105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 59125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 59175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 59195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5921bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 5922bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 5923bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 5924bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 5925bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 5926bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5927bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 5928bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 5929bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 5930bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 5931bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 5932bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 5933bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 5934bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis "Attempt to %s command buffer (%#" PRIxLEAST64 ") which is in use.", action, 5935bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 5936bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } else { // Secondary CB w/o primary in-flight, remove from in-flight 5937bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 5938bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5939bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5940bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5941bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 5942bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 5943bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBuffersInFlight(layer_data *dev_data, const VkCommandPool commandPool, const char *action) { 5944bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5945bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto pool_data = dev_data->commandPoolMap.find(commandPool); 5946bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (pool_data != dev_data->commandPoolMap.end()) { 5947bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto cmd_buffer : pool_data->second.commandBuffers) { 5948bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 5949bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 5950bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5951bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5952bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5953bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5954bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 59555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 59585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5961b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 5963bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto cb_pair = dev_data->commandBufferMap.find(pCommandBuffers[i]); 5964bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, cb_pair->second, "free"); 59655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 5966bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (cb_pair != dev_data->commandBufferMap.end()) { 59675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 5968bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis resetCB(dev_data, (*cb_pair).second->commandBuffer); 5969bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis delete (*cb_pair).second; 5970bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->commandBufferMap.erase(cb_pair); 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]); 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 597603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 59770a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 5979b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 59825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 59835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 59865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 59875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool *pCommandPool) { 59885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 59915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5993b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 59955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 59965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 60015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 60055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 6006b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 60075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 60085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 60135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 60155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 6017b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 60185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 6019bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis VkBool32 result = checkAndClearCommandBuffersInFlight(dev_data, commandPool, "destroy command pool with"); 60205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap 60215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) { 60225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 60235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb != dev_data->commandPoolMap[commandPool].commandBuffers.end();) { 6024400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, *poolCb); 60255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto del_cb = dev_data->commandBufferMap.find(*poolCb); 60265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*del_cb).second; // delete CB info structure 602772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer 60285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.erase( 60295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb); // Remove CB reference from commandPoolMap's list 60305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap.erase(commandPool); 60335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6034b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6036f90830842fdd43e8f1834f2eb76bda28eef435b8Tony Barbour if (result) 60375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 60385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 60405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 60415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 60445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 60455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 60475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 6048400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 6049bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (checkAndClearCommandBuffersInFlight(dev_data, commandPool, "reset command pool with")) 60505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 60515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 60535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 60545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 60565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6057b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 60585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 60595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 60605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*it)); 60615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 60625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 60685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 60705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 6071b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 60725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 60735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = dev_data->fenceMap.find(pFences[i]); 60745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != dev_data->fenceMap.end()) { 6075a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_item->second.needsSignaled = true; 6076a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence_item->second.in_use.load()) { 6077a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= 6078a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 6079a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 6080a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", reinterpret_cast<const uint64_t &>(pFences[i])); 60815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6084b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 60865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 60875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 60925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6093b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 60945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(framebuffer); 60955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 60965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : fbNode->second.referencingCmdBuffers) { 60975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cbNode = dev_data->commandBufferMap.find(cb); 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cbNode != dev_data->commandBufferMap.end()) { 60995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set CB as invalid and record destroyed framebuffer 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->state = CB_INVALID; 61015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->destroyedFramebuffers.insert(framebuffer); 61025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6104f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes delete [] fbNode->second.createInfo.pAttachments; 6105f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes dev_data->frameBufferMap.erase(fbNode); 61065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6107b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 61085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 61095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 61125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 61135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 6115b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 61175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 611947892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 612047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 61215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 612247892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 612347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 61245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6126b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 612894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->bufferMap[*pBuffer].createInfo = *pCreateInfo; 61295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap[*pBuffer].in_use.store(0); 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 61355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 61385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6139b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap[*pView] = VkBufferViewCreateInfo(*pCreateInfo); 614103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 61425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 61435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 61440a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_buffer_usage_flags(dev_data, pCreateInfo->buffer, 6145e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 61485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 615247892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 615347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 61545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 615547892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 615647892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 61575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6159b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[*pImage].createInfo = *pCreateInfo; 61645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 6172b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 61735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 61765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 61775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 61785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 61805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 61815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->levelCount = image_node_it->second.createInfo.mipLevels - range->baseMipLevel; 61825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 61855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->layerCount = image_node_it->second.createInfo.arrayLayers - range->baseArrayLayer; 61865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 61915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 61925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 61935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 6194b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 61955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 61975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 61985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 61995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 62005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = image_node_it->second.createInfo.mipLevels - range.baseMipLevel; 62025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = image_node_it->second.createInfo.arrayLayers - range.baseArrayLayer; 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 62105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 62115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6214b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 62155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageViewCreateInfo localCI = VkImageViewCreateInfo(*pCreateInfo); 62165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &localCI.subresourceRange, pCreateInfo->image); 62175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap[*pView] = localCI; 621803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 62195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that img has correct usage flags set 62200a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_image_usage_flags(dev_data, pCreateInfo->image, 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 6223e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves false, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 62255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6234b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6235a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 6236a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 6237a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.needsSignaled = true; 62385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 6239a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.firstTimeFlag = true; 6240a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.needsSignaled = false; 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6242a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.in_use.store(0); 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 62485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 62495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 62505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 62525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 62625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 62635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 62655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 62695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 62705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62753d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 62763d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 62773d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 62783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 62793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 62803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 62813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 62823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 62833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 62843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 62853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 62863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 62873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 62883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 62893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 62903d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 62913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 62923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 62933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 62943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 62953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 63005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 6306e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 63095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6312b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 6315ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6316ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 63175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 63185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6320e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6321b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 63235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6324b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 63255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 63275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 63285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6329b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63325188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 63335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6334b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 63415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 63425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 63435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 63445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 6345e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 63485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6352b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 63555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 63575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6358ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 6359ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 63635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6365e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6366b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6369b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 63705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 63735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6374b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 63795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6380b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 63875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 63885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 63905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6391b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 63925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 63935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 63985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 63995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 64005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 64025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 64035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 64045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pNewNode = new LAYOUT_NODE; 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 64065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSetLayout, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 64085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()")) 64095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo)); 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->createInfo.pBindings = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount]; 64135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)pNewNode->createInfo.pBindings, pCreateInfo->pBindings, 64145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sizeof(VkDescriptorSetLayoutBinding) * pCreateInfo->bindingCount); 64155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // g++ does not like reserve with size 0 64165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->bindingCount) 64175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap.reserve(pCreateInfo->bindingCount); 64185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t totalCount = 0; 64195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 64205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pNewNode->bindingToIndexMap.emplace(pCreateInfo->pBindings[i].binding, i).second) { 64215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 64225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)*pSetLayout, __LINE__, 64235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LAYOUT, "DS", "duplicated binding number in " 64245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSetLayoutBinding")) 64255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap[pCreateInfo->pBindings[i].binding] = i; 64285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis totalCount += pCreateInfo->pBindings[i].descriptorCount; 64305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pBindings[i].pImmutableSamplers) { 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampler **ppIS = (VkSampler **)&pNewNode->createInfo.pBindings[i].pImmutableSamplers; 64325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppIS = new VkSampler[pCreateInfo->pBindings[i].descriptorCount]; 64335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(*ppIS, pCreateInfo->pBindings[i].pImmutableSamplers, 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pBindings[i].descriptorCount * sizeof(VkSampler)); 64359bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis pNewNode->immutableSamplerCount += pCreateInfo->pBindings[i].descriptorCount; 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->layout = *pSetLayout; 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->startIndex = 0; 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (totalCount > 0) { 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes.resize(totalCount); 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags.resize(totalCount); 64435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset = 0; 64445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t j = 0; 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorType dType; 64465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 64475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dType = pCreateInfo->pBindings[i].descriptorType; 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pCreateInfo->pBindings[i].descriptorCount; j++) { 64495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes[offset + j] = dType; 64505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags[offset + j] = pCreateInfo->pBindings[i].stageFlags; 64515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 64525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 64535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->dynamicDescriptorCount++; 64545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset += j; 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = pNewNode->startIndex + totalCount - 1; 64595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // no descriptors 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = 0; 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Put new node at Head of global Layer list 6463b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = pNewNode; 64655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validatePushConstantSize(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *caller_name) { 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 6472b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((offset + size) > dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize) { 64735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 6476b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis caller_name, offset, size, dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize); 64775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 64885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()"); 64895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pCreateInfo->pPushConstantRanges[i].size == 0) || ((pCreateInfo->pPushConstantRanges[i].size & 0x3) != 0)) { 64905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constant index %u with " 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "size %u. Size must be greater than zero and a multiple of 4.", 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCreateInfo->pPushConstantRanges[i].size); 64955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if ranges overlap 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 64995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6500b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 65015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge capture of the setLayouts per pipeline 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; 65065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); 65085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPool *pDescriptorPool) { 65185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 65225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 65235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool %#" PRIxLEAST64, 65245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 65255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 65275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 65285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 65295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 65315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6533b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 65345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 65355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 65385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 65445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 65465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6547b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 65485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 65495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 6555e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 65565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6558b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that requested descriptorSets are available in pool 65605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 65615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPoolNode) { 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 65635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 65645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 65655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool); 65665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Make sure pool has all the available descriptors before calling down chain 65675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->descriptorSetCount, 65685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->pSetLayouts); 65695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6570b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 65725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 65745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6575b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 65765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 65775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode) { 65785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pAllocateInfo->descriptorSetCount == 0) { 65795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 65805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->descriptorSetCount, __LINE__, DRAWSTATE_NONE, "DS", 65815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "AllocateDescriptorSets called with 0 count"); 65825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) { 65845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 65855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", "Created Descriptor Set %#" PRIxLEAST64, 65865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i]); 65875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new set node and add to head of pool nodes 65885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pNewNode = new SET_NODE; 65895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 65905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 65915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 65925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_OUT_OF_MEMORY, "DS", 6593ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()")) { 6594b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6596ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 65975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Pool should store a total count of each type of Descriptor available 65995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When descriptors are allocated, decrement the count and validate here 66005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that the count doesn't go below 0. One reset/free need to bump count back up. 66015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert set at head of Set LL for this pool 66025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pPoolNode->pSets; 66035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->in_use.store(0); 66045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->pSets = pNewNode; 66055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]); 66065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 66075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 66085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pAllocateInfo->pSetLayouts[i], 66095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 66105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 66115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " specified in vkAllocateDescriptorSets() call", 6612ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis (uint64_t)pAllocateInfo->pSetLayouts[i])) { 6613b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6615ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 66165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pLayout = pLayout; 66185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pool = pAllocateInfo->descriptorPool; 66195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->set = pDescriptorSets[i]; 66205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorCount = (pLayout->createInfo.bindingCount != 0) ? pLayout->endIndex + 1 : 0; 66215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pNewNode->descriptorCount) { 6622656b1a5d2165c66fd4af21d070243d387cd4ac56Karl Schultz pNewNode->pDescriptorUpdates.resize(pNewNode->descriptorCount); 66235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->setMap[pDescriptorSets[i]] = pNewNode; 66255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6628b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 66345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 6635e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 66365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6638b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6640ce62d9f596fa03529c4961ab715473a0e9254e0eMark Mueller skipCall |= validateIdleDescriptorSet(dev_data, pDescriptorSets[i], "vkFreeDescriptorSets"); 66415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool); 66425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) { 66435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can't Free from a NON_FREE pool 66445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 66455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 66465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 66475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 66485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6649b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6650e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 66515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 66535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6654b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6655a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6656a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Update available descriptor sets in pool 6657a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets += count; 6658a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6659a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // For each freed descriptor add it back into the pool as available 66605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 66615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking 66625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(dev_data, pSet); 66635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = pSet->pLayout; 66645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 66655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pLayout->createInfo.bindingCount; ++j) { 66665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 66675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 66685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount; 66695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6671b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any other clean-up or book-keeping to do here? 66745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 66785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 66795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 6680e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // dsUpdate will return true only if a bailout error occurs, so we want to call down tree when update returns false 66815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6682b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6683e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool rtn = dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies); 6684b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!rtn) { 66865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 66875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 66885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 66925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 66935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 66955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6696b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 669772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto const &cp_it = dev_data->commandPoolMap.find(pCreateInfo->commandPool); 669872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cp_it != dev_data->commandPoolMap.end()) { 669972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 670172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cp_it->second.commandBuffers.push_back(pCommandBuffer[i]); 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 67055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 671003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 67110a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 6713b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 67195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 6720e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6722b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 67245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 67265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 6727a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 6728a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= 6729a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6730a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 6731a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "Calling vkBeginCommandBuffer() on active CB %p before it has completed. " 6732a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 6733a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 67345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6735a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 67375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 67385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 67395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 67435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must have inheritance info.", 67445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6747400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 67485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 67495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 67515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify a valid renderpass parameter.", 67525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6754400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 67555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 67565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command Buffers (%p) may perform better if a " 67595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "valid framebuffer parameter is specified.", 67605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 67635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(pInfo->framebuffer); 67645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 67655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass fbRP = fbNode->second.createInfo.renderPass; 67665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, fbRP, pInfo->renderPass, errorString)) { 6767400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 67685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 67695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 67705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 67725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command " 67735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Buffer (%p) renderPass (%#" PRIxLEAST64 ") is incompatible w/ framebuffer " 67745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") w/ render pass (%#" PRIxLEAST64 ") due to: %s", 67755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer), (uint64_t)(pInfo->renderPass), 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->framebuffer), (uint64_t)(fbRP), errorString.c_str()); 67775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 67795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fbNode->second.referencingCmdBuffers.insert(pCB->commandBuffer); 67805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6784b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 67855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 67865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 67875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 67885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 67895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must not have " 67905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 67915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "support precise occlusion queries.", 67925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 67965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = dev_data->renderPassMap.find(pInfo->renderPass); 67975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != dev_data->renderPassMap.end() && rp_data->second && rp_data->second->pCreateInfo) { 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->subpass >= rp_data->second->pCreateInfo->subpassCount) { 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 68005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 68015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must has a subpass index (%d) " 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that is less than the number of subpasses (%d).", 68045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)commandBuffer, pInfo->subpass, rp_data->second->pCreateInfo->subpassCount); 68055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Cannot call Begin on CB (%#" PRIxLEAST64 68145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 68165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (CB_RECORDED == pCB->state) { 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 68185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 68195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 68225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Call to vkBeginCommandBuffer() on command buffer (%#" PRIxLEAST64 68235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") attempts to implicitly reset cmdBuffer created from command pool (%#" PRIxLEAST64 68245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 68255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 68265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 68305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 68315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 68325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 68335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 68345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void *)commandBuffer); 68405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6841b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6842e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) { 68435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6846400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer) { 6851e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6854b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 68585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()"); 68595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Ending command buffer with in progress query: queryPool %" PRIu64 ", index %d", 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(query.pool), query.index); 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6867e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6868b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 6870b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 68715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 68725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 68735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 68755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6880b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6886bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6888b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 68915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 6892bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6893bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6894bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis "Attempt to reset command buffer (%#" PRIxLEAST64 ") created from command pool (%#" PRIxLEAST64 6895bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 6896bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6898bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, pCB, "reset"); 6899b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6900bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 69025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 69035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6904b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 69055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 6906b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 69075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 691093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 691103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 69125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : For any vkCmdBind* calls that include an object which has mem bound to it, 69135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// need to account for that mem now having binding to given commandBuffer 69145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 69155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 69165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 6917e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6919b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 69235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 69245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 69275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Incorrectly binding compute pipeline (%#" PRIxLEAST64 ") during active RenderPass (%#" PRIxLEAST64 ")", 69285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass); 69295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 693372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 69345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 69353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline); 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 69395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 69415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6943b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6944e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 69495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 6950e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6952b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 69565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 69585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 69595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6960b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6961e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 69635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 69665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 6967e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6969b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 69735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 69745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 69755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 69765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6977b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6978e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 69805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 6983a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 69845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6985b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6988a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 6990a27508babf63d50aea75883a3702979193c23683Mark Young 6991a27508babf63d50aea75883a3702979193c23683Mark Young PIPELINE_NODE *pPipeTrav = getPipeline(dev_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 6992a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 6993a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 6994a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 6995a27508babf63d50aea75883a3702979193c23683Mark Young "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH" 6996a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 6997a27508babf63d50aea75883a3702979193c23683Mark Young } else { 6998a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 6999a27508babf63d50aea75883a3702979193c23683Mark Young } 70005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7001b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7002a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 70035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 7008e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7010b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7016b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7017e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 7023e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7025b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 70293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7031b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7032e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 7038e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7040b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 70445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7046b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7047e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 70495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 7053e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7055b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 70595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 70605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7061b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7062e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 7068e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7070b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 70745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 70755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7076b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7077e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 70795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 7083e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7085b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 70895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 70905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7091b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7092e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 70945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 70985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 70995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t *pDynamicOffsets) { 7100e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7102b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7106787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7107787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7108787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7109787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 711072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) 711172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 711272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 7113787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7114787f29d93dee194c015789cf61c079504c980572Tobin Ehlis SET_NODE *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7115787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 711672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pDescriptorSets[i]); 7117787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pSet->boundCmdBuffers.insert(commandBuffer); 711872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipelineLayout = layout; 711972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pDescriptorSets[i]; 7120787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 7121787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7122787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_NONE, "DS", "DS %#" PRIxLEAST64 " bound on pipeline %s", 7123787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7124787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!pSet->pUpdateStructs && (pSet->descriptorCount != 0)) { 7125787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 7126787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7127787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 7128787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "DS %#" PRIxLEAST64 7129787f29d93dee194c015789cf61c079504c980572Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 7130787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7131787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7132787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 7133787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, layout, i + firstSet, errorString)) { 7134787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7135787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7136787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 7137787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping layout in " 7138787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "pipelineLayout due to: %s", 7139787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, errorString.c_str()); 7140787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7141787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->dynamicDescriptorCount) { 7142787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7143787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if ((totalDynamicDescriptors + pSet->pLayout->dynamicDescriptorCount) > dynamicOffsetCount) { 7144787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= 7145787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7146787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7147787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7148787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u (%#" PRIxLEAST64 7149787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7150787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7151787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->pLayout->dynamicDescriptorCount, 7152787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7153787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7154787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7155787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7156787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t d = 0; d < pSet->descriptorCount; d++) { 7157787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7158787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7159787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7160b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 7161787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7162787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7163787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7164787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7165787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7166787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minUniformBufferOffsetAlignment %#" PRIxLEAST64, 7167787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7168b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 7169787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7170787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7171787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7172787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7173787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7174b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 7175787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7176787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7177787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7178787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7179787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7180787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minStorageBufferOffsetAlignment %#" PRIxLEAST64, 7181787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7182b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 71835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7184787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 71855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7187787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7188787f29d93dee194c015789cf61c079504c980572Tobin Ehlis totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount; 71895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7191787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 7192787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7193787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7194787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", 7195787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 71965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 719772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 719872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 719972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 720072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 720172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 720272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility( 720372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data, dev_data->setMap[pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i]], layout, i, 720472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis errorString)) { 720572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg( 720672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 720772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 720872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 720972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "DescriptorSetDS %#" PRIxLEAST64 721072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 721172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 721272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 721372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 721472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 721572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 721672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 721772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 721872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 721972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, 72205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorString)) { 722172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= 722272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 722372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)oldFinalBoundSet, __LINE__, 722472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis DRAWSTATE_NONE, "DS", "DescriptorSetDS %#" PRIxLEAST64 722572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u is incompatible with set %#" PRIxLEAST64 722672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 722772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 722872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)oldFinalBoundSet, lastSetIndex, 722972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 723072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 723172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 72325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7235787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7236787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 7237787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7238787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 7239787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7240787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 7241787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 7242787f29d93dee194c015789cf61c079504c980572Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7243787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7244787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Save dynamicOffsets bound to this CB 7245787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < dynamicOffsetCount; i++) { 7246e576798e0a38a7d941b6202d784ad705024e9fdcTobin Ehlis pCB->lastBound[pipelineBindPoint].dynamicOffsets.emplace_back(pDynamicOffsets[i]); 7247787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 72485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 72505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7252b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7253e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 72555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 72565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 72595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 7260e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7262b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 726303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 72645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 72655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 72660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 726772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 726872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7269e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindIndexBuffer()"); }; 727072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 72715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 72735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 72775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 72785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 72795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 72805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 72815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 72825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 72835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 72845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 72855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 72865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 72875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 72885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 72905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkIndexType(indexType)); 72945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND; 72965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7297b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7298e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 73005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 73035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 73045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 73055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 73085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 73095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7312e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 73135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bindingCount, const VkBuffer *pBuffers, 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkDeviceSize *pOffsets) { 7317e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7319b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 732003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 73215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 73225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)pBuffers[i], VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 732472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 732572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7326e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindVertexBuffers()"); }; 732772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 73285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 73315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 73325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 73355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTracking(pCB, firstBinding, bindingCount, pBuffers); 73365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 73375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7339b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7340e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 73425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7344b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 7345e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 73465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 73477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 73487a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 73497a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto iv_data = dev_data->imageViewMap.find(imageView); 73507a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (iv_data == dev_data->imageViewMap.end()) 73515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 73527a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkImage image = iv_data->second.image; 73537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 73547a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skip_call |= 73550a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7356e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 73577a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7358e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73597a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 73607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 73617a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 73627a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 73637a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 73640a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skip_call |= get_mem_binding_from_object(dev_data, (uint64_t)buffer, 73657a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7366e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 73677a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true); 7368e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73697a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 73707a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 73715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 73735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 73765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstVertex, uint32_t firstInstance) { 7377e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7379b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 73835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 7384e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 73857a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 73865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 73875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 73885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 73895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++); 73905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7391e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 73925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 73935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 73955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7396b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7397e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 73995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 74025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 74035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 74045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7405e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 7406b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 74105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 7411e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 74127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 74155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 74165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 74175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7418e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 74195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 74225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7423b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7424e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 74265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 74275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 74305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 74315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7432e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 7433b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 743403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 74355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 74365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 74375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 74380a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndirect"); 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 74415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 74445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDIRECT]++; 7445e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 74467a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 74495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 74505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 74515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7452e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 74535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); 74565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7457b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7458e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 74605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 74635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 7464e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7466b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 746703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 74685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 74695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 74705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 74710a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 74725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndexedIndirect"); 74735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 74745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 74775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED_INDIRECT]++; 7478e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 74797a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 74825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 74835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", 74845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 74855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7486e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 74875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); 74905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7491b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7492e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 7497e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7499b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Re-enable validate_and_update_draw_state() when it supports compute shaders 7503e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 75047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 75057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 75067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 75085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 75095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7510b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7511e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 75135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 7517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7519b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 752003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 75225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 75245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDispatchIndirect"); 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75287a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Re-enable validate_and_update_draw_state() when it supports compute shaders 7529e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 75307a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 75317a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 75327a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); 75355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7536b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7537e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 75395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferCopy *pRegions) { 7543e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7545b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 754603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 754872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75500a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 755172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7552e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBuffer()"); }; 755372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 75545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 75565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 75570a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 755872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7559e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7561e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 756372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 75645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 75670a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 75685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 75690a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 75705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer"); 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7577b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7578e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7582e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageSubresourceLayers subLayers, 7583e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout srcImageLayout) { 7584e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 75895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 75925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, srcImage, sub, node)) { 759308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 75945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 75975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 75995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 76025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 76035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 76085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 76095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 76105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 76115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 76145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 76155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7621e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageSubresourceLayers subLayers, 7622e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout destImageLayout) { 7623e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 76295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, destImage, sub, node)) { 763208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 76335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 76345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 76405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 76415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 76445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 76475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 76485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 76525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 76545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 7662e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 76635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7664b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 766503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 766772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 76685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 76690a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 767072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7671e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImage()", srcImage); }; 767272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 76735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 76755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 76760a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 767772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7678e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7680e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 76815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 768272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 76850a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 76865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 76870a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 76885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 76895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE, "vkCmdCopyImage()"); 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage"); 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].srcSubresource, srcImageLayout); 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].dstSubresource, dstImageLayout); 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7699b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7700e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 77015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 77025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 77035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 77065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 7708e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7710b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 771103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 771372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 77145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 77150a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 771672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7717e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBlitImage()", srcImage); }; 771872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 77215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 77220a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 772372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7724e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7726e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 772872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 77310a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 77330a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 77345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE, "vkCmdBlitImage()"); 77395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage"); 77405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7741b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7742e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 77455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 77485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage dstImage, VkImageLayout dstImageLayout, 77495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7750e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7752b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 775303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 775572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 77560a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 775772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7758e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 77595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7760e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 776272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 77655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 77660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 776772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7768e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBufferToImage()"); }; 776972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 77725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src buff & dst image have correct usage flags set 77730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 77745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 77750a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 77775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 77815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage"); 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].imageSubresource, dstImageLayout); 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7786b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7787e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 77895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 77905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout srcImageLayout, VkBuffer dstBuffer, 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7795e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7797b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 779803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 780072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78010a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 780272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7803e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7804e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImageToBuffer()", srcImage); 7805e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 780672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 78095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78100a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 781172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7812e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7814e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 781672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 78195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff & src image have correct usage flags set 78200a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 78215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 78220a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 78235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 78245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 78285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer"); 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 78305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].imageSubresource, srcImageLayout); 78315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7833b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7834e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 78365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 78375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 78405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 7841e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7843b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 784403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 784672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 78480a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 784972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7850e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7852e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 785472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdUpdateBuffer"); 78575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 78580a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 78595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 78605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 78645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer"); 78655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7866b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7867e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 78695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 78725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 7873e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7875b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 787603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 787872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 78800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 788172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7882e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7884e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 788672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdFillBuffer"); 78895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 78900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 78915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdFillBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 78925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 78965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer"); 78975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7898b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7899e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 79015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 79045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *pAttachments, uint32_t rectCount, 79055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearRect *pRects) { 7906e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7908b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 79125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 79145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 79155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 79175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 79185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 79195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 79205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 79225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 79235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 79245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandBuffer)); 79255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); 79275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 79305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 79315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 79325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 79335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 79355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 79365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 7937e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 79385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 79395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 7940e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 79415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 79425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7944e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 79485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 79535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 79545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 79585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 79615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 79635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7968b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7969e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 79715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout, const VkClearColorValue *pColor, 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 7976e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7978b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 797903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 79815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 798272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 79830a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 798472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7985e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 79865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7987e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 798972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearColorImage"); 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage"); 79975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7998b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7999e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 80055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 80065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange *pRanges) { 8007e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8009b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 801003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 80125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 801372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80140a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 801572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8016e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 8018e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 802072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearDepthStencilImage"); 80235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 80275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage"); 80285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8029b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8030e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 80365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 80375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 8038e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8040b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 804103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 804272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 80440a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 804572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8046e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdResolveImage()", srcImage); }; 804772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 80505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 80510a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 805272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8053e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 8055e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 805772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 80605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 80645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage"); 80655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8066b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8067e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 80695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 80705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8072b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8073b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8074b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8075b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8076b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8077b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8078b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8079b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8080b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8081b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8082b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8083b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8084b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 80855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 80865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8087e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8089b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 80935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 80945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8095b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8096b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8097b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 80985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8099b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8100e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 81025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 81055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8106e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8108b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 81125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 81135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8114b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8115b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8116b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 81175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8118b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8119e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 81215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8123e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8124e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 81255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 81265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 8127e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 81285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 81295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 81305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 81325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 81335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 81345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 81355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 81365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 81375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 81385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 81405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 81415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 81425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 81435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 81445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 81455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 814608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 814708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 81485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 81495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 81515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 81525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 81535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 81545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 81555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 81565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 81575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 81635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 8166e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 81675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 81685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 81695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 81715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 81725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 81735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 81745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 81755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 81765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 81775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 81785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 81815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 81835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 81865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 81875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 8188e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8189e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 8190e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 8191e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 81925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & !(required_bit | optional_bits)) { 81955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 81965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 81995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 82005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 82036044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 82055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 82065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 82075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 82085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 82095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 82115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 82125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 82135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 82145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 82155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82166044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 82185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 82195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 82205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 82255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8227e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8228e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 8229e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 82305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 82315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 82325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 82335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 82345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 82375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 82385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 82395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 82425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 82435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 82505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 82515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 82555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 82565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 82605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 82645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 82675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 82695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 82705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 82745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 82755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 82775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8279e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8280e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 8281e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 8282e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 8283e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 82865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) { 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 82905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 82915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 82925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 82955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 82975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 82985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 82995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 83005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data->second.createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 83015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 83035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 83045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 83065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 83075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 83085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 83095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 83105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 83135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 83145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 83165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 83175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 83205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 83215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 83225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 8325b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 8326b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 83305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 83315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 83325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 83335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 8334b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 83355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 83405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 83425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 83445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 83485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 83511d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 83521d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = image_data->second.createInfo.format; 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = image_data->second.createInfo.arrayLayers; 83575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = image_data->second.createInfo.mipLevels; 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imageswap_data = dev_data->device_extensions.imageToSwapchainMap.find(mem_barrier->image); 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageswap_data != dev_data->device_extensions.imageToSwapchainMap.end()) { 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(imageswap_data->second); 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = swapchain_data->second->createInfo.imageFormat; 83655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = swapchain_data->second->createInfo.imageArrayLayers; 83665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 83745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 83755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 83805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8381f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 8382f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8383f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 8384f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 83855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 83895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 83915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8392f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 8393f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8394f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 8395f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 83985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 84005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 84025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 84085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 84175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8418b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 84195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8420b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 84215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 84235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 84245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 84255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 8426b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 84275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = dev_data->bufferMap.find(mem_barrier->buffer); 84305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != dev_data->bufferMap.end()) { 8431672a7ee979486eaec10f96063f0455e8c2a02595Karl Schultz VkDeviceSize buffer_size = (buffer_data->second.createInfo.sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO) 8432672a7ee979486eaec10f96063f0455e8c2a02595Karl Schultz ? buffer_data->second.createInfo.size 8433672a7ee979486eaec10f96063f0455e8c2a02595Karl Schultz : 0; 84345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 843594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 843694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 843794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 843894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 " which is not less than total size %" PRIu64 ".", 843994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 844094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 84415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 844294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 844394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 844494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 " and size %" PRIu64 844594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis " whose sum is greater than total size %" PRIu64 ".", 844694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 844794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 844894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84552ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 8456b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 8457b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 8458b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 8459b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 84602ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 8461b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8462b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 8463b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 84642ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 8465b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 8466b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 8467b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 84682ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto global_event_data = dev_data->eventMap.find(event); 8469b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (global_event_data == dev_data->eventMap.end()) { 8470b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 847127c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 847227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 84732ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 8474b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 8475b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= global_event_data->second.stageMask; 8476b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8477b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8478b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8479b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (sourceStageMask != stageMask) { 8480b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= 8481b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 848227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes DRAWSTATE_INVALID_EVENT, "DS", 8483b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "Submitting cmdbuffer with call to VkCmdWaitEvents using srcStageMask 0x%x which must be the bitwise OR of the " 8484b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "stageMask parameters used in calls to vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if used with vkSetEvent.", 8485b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine sourceStageMask); 8486b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8487b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 8488b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8489b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 84945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 8495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 84965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8497b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 84995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85002ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 85025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.push_back(pEvents[i]); 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8505b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 85062ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 8507b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 85085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 85105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 85145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 85155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8518b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8519e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 85205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 85215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 85265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 85275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 85285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 85295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 8530e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8532b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 85335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 85365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 85375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8541b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8542e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 8550e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8552b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 85565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 85575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 85585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 85595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 85615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8562b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8563e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 85645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 85655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 8568e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8570b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 85715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 85745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 85755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 85765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool %" PRIu64 ", index %d", 85785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 85795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 85835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 85855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 85875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8589b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8590e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 85925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 85955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 8596e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8598b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 86025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 86035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 86045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 0; 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 86105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8613b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8614e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 86205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 8621e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8623b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 862503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 862772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 86285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 86290a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 863072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8631e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 86325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 8633e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 863572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyQueryPoolResults"); 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that DST buffer has correct usage flags set 86390a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 86415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->queryToStateMap[query]) { 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 86475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Requesting a copy from query to buffer with invalid query: queryPool %" PRIu64 ", index %d", 86495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); 86585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8659b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8660e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 86625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 86675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const void *pValues) { 86685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8670b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 86755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 86775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8679b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((offset + size) > dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize) { 86805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, offset, size, "vkCmdPushConstants()"); 86815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if push constant update doesn't align with range 8683b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 86845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 86865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 8690e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8692b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 86965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 86975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 86995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 87015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8703b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8704e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 87055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 87065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 87095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 87105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer *pFramebuffer) { 87115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 87125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 87135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 87145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 8715b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 8716fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes 8717fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto & fbNode = dev_data->frameBufferMap[*pFramebuffer]; 8718fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo = *pCreateInfo; 87195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 8720fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto attachments = new VkImageView[pCreateInfo->attachmentCount]; 8721fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes memcpy(attachments, 8722fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->pAttachments, 8723fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->attachmentCount * sizeof(VkImageView)); 8724fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo.pAttachments = attachments; 87255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 87275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 87285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data = dev_data->imageViewMap.find(view); 87295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data == dev_data->imageViewMap.end()) { 87305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 87315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 87330a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(view_data->second.image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 87345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis &fb_info.mem); 87355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_info.image = view_data->second.image; 8736fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.attachments.push_back(fb_info); 87375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 87405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8742e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 8743e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 87445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 87455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 8746e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 87495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 8753e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 87545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8756e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8758e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8761e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 8762e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 8763e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 87661d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 87725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 87735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error. 87745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 87755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) { 87773da84689683bb257cc0f64953966666d19321119Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but only an implicit one is specified.", 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass, dependent_subpasses[k]); 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 87845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 87855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 8786e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8793e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 8794e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 87955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 87965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 87975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 87995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 8800e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 88035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 8804e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8806e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 88075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 88085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 88095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 88105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 8814e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 88165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 8817e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8821e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 88225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 88295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 88375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 88395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8841e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateDependencies(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin, 8842e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node) { 8843e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 88455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pCreateInfo = my_data->renderPassMap.at(pRenderPassBegin->renderPass)->pCreateInfo; 88465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 88475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 88505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 88515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 88525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 88535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 88555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 88565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 88575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_i = my_data->imageViewMap.find(viewi); 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_j = my_data->imageViewMap.find(viewj); 88615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i == my_data->imageViewMap.end() || view_data_j == my_data->imageViewMap.end()) { 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i->second.image == view_data_j->second.image && 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRegionOverlapping(view_data_i->second.subresourceRange, view_data_j->second.subresourceRange)) { 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 88675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_i = my_data->imageMap.find(view_data_i->second.image); 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_j = my_data->imageMap.find(view_data_j->second.image); 88725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i == my_data->imageMap.end() || image_data_j == my_data->imageMap.end()) { 88735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i->second.mem == image_data_j->second.mem && 88765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(image_data_i->second.memOffset, image_data_i->second.memSize, image_data_j->second.memOffset, 88775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_data_j->second.memSize)) { 88785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 88795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 88805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 88845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 88855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 88865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 88875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 88905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 88915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 88945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 89031c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89061c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 89165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 89175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 89185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 89195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89201c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 89215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 89255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 89265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 89275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89281c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 89291c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 89301c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 89311c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 89321c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 89331c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 89341c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 89351c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 89365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pInputAttachments[j].attachment; 89445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 89475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pColorAttachments[j].attachment; 89495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 89545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 89595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 89605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 89645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8969e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 8970e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 89765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 89775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 89785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 89795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 89805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 89815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 89825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89834d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 89855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 89865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 89875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 89915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 89925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 89935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 89945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 89955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 89965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 89975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89984d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 90015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 90025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 90105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 90125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 90144d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 90175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 90185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 90235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9025e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 9026e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 9027e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 90335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 90345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 90365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 90385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 90445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 90475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9054918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 90555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 90585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderModule *pShaderModule) { 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9060e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!shader_is_spirv(pCreateInfo)) { 90625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 90635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* dev */ 0, __LINE__, SHADER_CHECKER_NON_SPIRV_SHADER, "SC", "Shader is not SPIR-V"); 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9066e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 9072b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 9073918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 90745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 90765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 90795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 90805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass *pRenderPass) { 9081e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 90825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9083b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 90845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create DAG 90855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 90865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 90875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 90885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 9090e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) { 9091b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 90925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 90935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9094b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 90955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 90965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 9097b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 90985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge in tracking of renderpass from shader_checker 90995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 91005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 91015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 91025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 91035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 91045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 91055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 91075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 91085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 91095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 91115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 91125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 91135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 91145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 91155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 91165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 91185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 91195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 91205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 91225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 91235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 91245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 91265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 91275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 91285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 91295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 91325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 91335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 91345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 91355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 91385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 91395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 91435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 91445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 91455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE(localRPCI); 91475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency; 91485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->subpassToNode = subpass_to_node; 914987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 915087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 915187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 915287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 915387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 915487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 915587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 915687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 915787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachments.push_back(pass_info); 915887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 915987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 916087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, bool> &attachment_first_read = dev_data->renderPassMap[*pRenderPass]->attachment_first_read; 916187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = 916287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachment_first_layout; 916387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 916487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 9165b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 9166b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 9167b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9168b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine "Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 9169b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine } 91700d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 91710d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment = subpass.pPreserveAttachments[j]; 91720d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount) { 91730d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 91740d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 91750d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Preserve attachment %d cannot be greater than the total number of attachments %d.", 91760d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 91770d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 91780d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 917987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 91800d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment; 91810d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (subpass.pResolveAttachments) { 91820d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pResolveAttachments[j].attachment; 91830d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount && attachment != VK_ATTACHMENT_UNUSED) { 91840d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 91850d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 91860d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 91870d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 91880d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine continue; 91890d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 91900d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 91910d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pColorAttachments[j].attachment; 919224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 919324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 919424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 919524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 919624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 919724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 919824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 919987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 920087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 920187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 920287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 920387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 920487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 920587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 920624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 920724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 920824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 920924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Depth stencil attachment %d cannot be greater than the total number of attachments %d.", 921024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 921124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 921224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 921387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 921487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 921587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 921687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 921787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 9218a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 9219a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 922024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 922124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 922224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 922324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Input attachment %d cannot be greater than the total number of attachments %d.", 922424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 922524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 922624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 9227a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine if (attachment_first_read.count(attachment)) 9228a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine continue; 9229a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_read.insert(std::make_pair(attachment, true)); 9230a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 9231a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 923287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 923387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 9234b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 92355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 92375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 92395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 92405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.size() <= 0) 92415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 92425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->renderPassMap.begin(); ii != my_data->renderPassMap.end(); ++ii) { 92435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = (*ii).second->pCreateInfo; 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 92455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 92465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 92485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 92495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 92505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 92515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 92525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 92535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 92545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 92555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 92565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 92575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 92605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 92625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 92635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 92645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 92665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9268e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 9269e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 92705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 92715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 92725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 92735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer].createInfo; 92745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 92755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 92775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 92785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 92805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 92815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageViewMap.find(image_view); 92825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_data != dev_data->imageViewMap.end()); 92835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_data->second.image; 92845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->second.subresourceRange; 92855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 92865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 92875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 92885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 92895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 92915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 92925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 92935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 92945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 92955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 92965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 92975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (newNode.layout != node.layout) { 92995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 93005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using attachment %i " 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "where the " 9303d6c1882c31a88ae01b94f3135679f739287be31aKarl Schultz "initial layout is %s and the layout of the attachment at the " 93041c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine "start of the render pass is %s. The layouts must match.", 93051c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 93065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9313e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, 9314e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 93175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 93205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 93225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 93235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pRenderPassInfo->pSubpasses[subpass_index]; 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pInputAttachments[j].attachment]; 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pInputAttachments[j].layout); 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pColorAttachments[j].attachment]; 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pColorAttachments[j].layout); 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 93375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pDepthStencilAttachment->attachment]; 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pDepthStencilAttachment->layout); 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9342e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 9343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 93485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9352e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 93585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 93675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 93685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9371e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 9372885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 9373885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 9374885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 9375885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 9376885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 9377885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 9378885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 9379885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9380885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 9381885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 9382885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 9383885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 9384885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 9385885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 9386885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 9387885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 9388885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 9389885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 9392e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 93935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9394b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 93955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 93965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 93975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassBegin && pRenderPassBegin->renderPass) { 939887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGE 939987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 940087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 940187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 940287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->fb = pRenderPassBegin->framebuffer; 940372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 940487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 940587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 940687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_CLEAR) { 940772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9408e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 9410e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 94115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 941272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 941487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkImageLayout &attachment_layout = pRPNode->attachment_first_layout[pRPNode->attachments[i].attachment]; 94155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL || 94165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 94175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 94185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 94195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, (uint64_t)(pRenderPassBegin->renderPass), __LINE__, 94205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_LAYOUT, "MEM", "Cannot clear attachment %d with invalid first layout %d.", 942187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->attachments[i].attachment, attachment_layout); 94225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 942387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_DONT_CARE) { 942472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9425e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 9427e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 94285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 942972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 943187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_LOAD) { 943272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9433e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 94355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 943672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 943987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachment_first_read[pRPNode->attachments[i].attachment]) { 944072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9441e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 94435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 944472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 9450e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 94515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin); 94525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 94535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data != dev_data->renderPassMap.end()) { 94545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateDependencies(dev_data, pRenderPassBegin, render_pass_data->second->subpassToNode); 94555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 94575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 94585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 94595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = pRenderPassBegin->renderPass; 94605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 94615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 94625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 94635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 946493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.insert(pRenderPassBegin->framebuffer); 94655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 946693c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski dev_data->frameBufferMap[pRenderPassBegin->framebuffer].referencingCmdBuffers.insert(pCB->commandBuffer); 94675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 94685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 94695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 94715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9473b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9474e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 94755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 94765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 9480e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9482b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 94835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 94845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 94855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 94865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 94885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 94895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 949072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline) { 949172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, 949272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 94935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 94955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9496b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9497e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 94985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 94995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer) { 9502e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9504b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 950503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 950672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 950772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 950887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(cb_data->second->activeRenderPass); 950987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 951087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 951187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 951287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 951387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_STORE) { 951472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9515e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 95165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 9517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 95185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 951972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 952187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_DONT_CARE) { 952272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9523e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 9525e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 95265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 952772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 95345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 95365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 95375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 95385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 95395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo); 95405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 95425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9543b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9544e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 95455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 95465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9548e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 9549e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkRenderPass primaryPass, uint32_t primaryAttach, uint32_t secondaryAttach, 9550e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *msg) { 95515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 95535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 95545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 955581264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom "Attachment %" PRIu32 " is not compatible with %" PRIu32 ". %s", 95565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass), primaryAttach, secondaryAttach, 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis msg); 95585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9560e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9561e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t primaryAttach, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 9562e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 95635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 95645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 95655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 95665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->attachmentCount <= primaryAttach) { 95675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 95685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data->second->pCreateInfo->attachmentCount <= secondaryAttach) { 95705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 95715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 95735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 95745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 95765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 95775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The first is unused while the second is not."); 95785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 95795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 95815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 95825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The second is unused while the first is not."); 95835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 95845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].format != 95865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].format) { 95875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 95885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different formats."); 95895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].samples != 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].samples) { 95925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 95935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different samples."); 95945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (is_multi && 95965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_data->second->pCreateInfo->pAttachments[primaryAttach].flags != 95975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].flags) { 95985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 95995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different flags."); 96005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9604e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9605e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, const int subpass, 9606e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool is_multi) { 96075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 96085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 96095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 96105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &primary_desc = primary_data->second->pCreateInfo->pSubpasses[subpass]; 96115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &secondary_desc = secondary_data->second->pCreateInfo->pSubpasses[subpass]; 96125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 96135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 96145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 96155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 96165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 96175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 96195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 96205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_input_attach, secondaryBuffer, 96225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_input_attach, is_multi); 96235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 96255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 96265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 96275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 96285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 96315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 96325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_color_attach, secondaryBuffer, 96345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_color_attach, is_multi); 96355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 96365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 96375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 96385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 96405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 96415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_resolve_attach, secondaryBuffer, 96435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_resolve_attach, is_multi); 96445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 96475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 96485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 96505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 96515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_depthstencil_attach, secondaryBuffer, 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_depthstencil_attach, is_multi); 96545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9657e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9658e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass) { 96595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 96605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early exit if renderPass objects are identical (and therefore compatible) 96615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryPass == secondaryPass) 96625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 96645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 96655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data == dev_data->renderPassMap.end() || primary_data->second == nullptr) { 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid current Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 96705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)primaryBuffer, (uint64_t)(primaryPass)); 96715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data == dev_data->renderPassMap.end() || secondary_data->second == nullptr) { 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 96785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass)); 96795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->subpassCount != secondary_data->second->pCreateInfo->subpassCount) { 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 96855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 96865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "They have a different number of subpasses.", 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass)); 96885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_multi = primary_data->second->pCreateInfo->subpassCount > 1; 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < primary_data->second->pCreateInfo->subpassCount; ++i) { 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis validateSubpassCompatibility(dev_data, primaryBuffer, primaryPass, secondaryBuffer, secondaryPass, i, is_multi); 96945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9698e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 9699e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 97005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 97025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 970493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski VkFramebuffer primary_fb = dev_data->renderPassMap[pCB->activeRenderPass]->fb; 97055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a framebuffer %" PRIx64 97115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current framebuffer %" PRIx64 ".", 97125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 97135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fb_data = dev_data->frameBufferMap.find(secondary_fb); 97155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fb_data == dev_data->frameBufferMap.end()) { 97165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid framebuffer %" PRIx64 ".", 97205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 97215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb_data->second.createInfo.renderPass, 97245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryBuffer, pSubCB->beginInfo.pInheritanceInfo->renderPass); 97255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9729e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 97335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 97345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 97375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 97385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 97395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 97405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 ". Pipeline statistics is being queried so the command " 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 97465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 97525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 97535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 97545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 97585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 "of type %d but a query of that type has been started on " 97595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "secondary Cmd Buffer %p.", 97605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 97615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 97625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 97685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 9769e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 97705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9771b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 97725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 97735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 97745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 97755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 97765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 97775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 97785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", 97825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 97835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 97845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers " 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 97885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 97895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 97905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 97915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 97945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) executed within render pass (%#" PRIxLEAST64 97955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 97965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass); 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass, pCommandBuffers[i], 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass); 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, pCB->activeRenderPass, 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass, errorString)) { 98065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 98095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) w/ render pass (%#" PRIxLEAST64 98105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") is incompatible w/ primary command buffer (%p) w/ render pass (%#" PRIxLEAST64 ") due to: %s", 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass, errorString.c_str()); 98135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 98155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 98165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 98185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 98215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) references framebuffer (%#" PRIxLEAST64 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does not match framebuffer (%#" PRIxLEAST64 ") in active renderpass (%#" PRIxLEAST64 ").", 98235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass); 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 98295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pSubCB); 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 98385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to simultaneously execute CB %#" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 98395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%#" PRIxLEAST64 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, even though it does.", 98515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 98525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 98535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9855b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") cannot be submitted with a query in " 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 98645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 98665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 98675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 98715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9872b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9873e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 98745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9877e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 9878e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 98795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 988058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto mem_data = dev_data->memObjMap.find(mem); 988158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if ((mem_data != dev_data->memObjMap.end()) && (mem_data->second.image != VK_NULL_HANDLE)) { 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 988358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (FindLayouts(dev_data, mem_data->second.image, layouts)) { 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 98885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 98995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9901e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9903b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 990403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 990558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 99065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 99075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 9908b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & 9909b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 99105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 99115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 99125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj %#" PRIxLEAST64, (uint64_t)mem); 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis storeMemRanges(dev_data, mem, offset, size); 99185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 991958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 9920b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 99215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9922e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 99235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 992403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 9925b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 99265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 9927b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 99285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 99295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 993303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 99345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUnmapMemory(VkDevice device, VkDeviceMemory mem) { 99355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9936e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 99375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9938b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 99395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= deleteMemRanges(my_data, mem); 9940b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9941e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 99425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 99435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9946e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 9947e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9948e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.offset > pMemRanges[i].offset) { 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 99565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 99585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_element->second.memRange.offset)); 99595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_element->second.memRange.size != VK_WHOLE_SIZE) && 99615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((mem_element->second.memRange.offset + mem_element->second.memRange.size) < 99625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pMemRanges[i].offset + pMemRanges[i].size))) { 99635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 99645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 99655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 99665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") exceeds the Memory Object's upper-bound " 99675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 99685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 99695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<size_t>(mem_element->second.memRange.offset + mem_element->second.memRange.size)); 99705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 99745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9976e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 9977e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9978e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 99795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 99815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 99825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 99835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize size = mem_element->second.memRange.size; 99845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 99855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char *data = static_cast<char *>(mem_element->second.pData); 99865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 99875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 99885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 99905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 99915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 99925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 99955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 99965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 99975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 99985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 99995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 100005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(mem_element->second.pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 100035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 100075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 100105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 100115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10012e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10015b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 100165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 100175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 10018b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 10019e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 100205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 100215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 100265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10028e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10031b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 100325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 10033b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 10034e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 100365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 100405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 100425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 10045b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1004694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 1004794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 1004894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1004909df2b6afd74a6494aa530ba23a80ba69abc79dfDustin Graves uint64_t image_handle = reinterpret_cast<uint64_t&>(image); 1005094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 100515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 10052b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1005394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 10054b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1005558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, image_handle, mem, memoryOffset, memRequirements, 1005658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].imageRanges, dev_data->memObjMap[mem].bufferRanges, 1005758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 100580a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10059b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1006094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!skipCall) { 1006194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 10062b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1006394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->memObjMap[mem].image = image; 1006494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.mem = mem; 1006594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memOffset = memoryOffset; 1006694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memSize = memRequirements.size; 10067b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1006894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1006994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1007094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1007194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 1007294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis "vkBindImageMemory: Cannot find invalid image %" PRIx64 ", has it already been deleted?", 1007394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 100745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkSetEvent(VkDevice device, VkEvent event) { 100793ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 100803ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 100815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10082b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 100833ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis auto event_node = dev_data->eventMap.find(event); 100843ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node != dev_data->eventMap.end()) { 100853ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.needsSignaled = false; 100863ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.stageMask = VK_PIPELINE_STAGE_HOST_BIT; 100873ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node->second.in_use.load()) { 100883ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 100893ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 100903ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis "Cannot call vkSetEvent() on event %" PRIxLEAST64 " that is already in use by a command buffer.", 100913ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 100923ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 100933ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 10094b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 100956fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 100966fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 100976fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 100986fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 100996fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 101006fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 101016fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 101026fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101036fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101043ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 101053ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 101065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 101105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 101115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 101125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10113e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10114b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 101154b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 10116a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence != VK_NULL_HANDLE) { 10117a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis dev_data->fenceMap[fence].queue = queue; 10118a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if ((bindInfoCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 10119a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skip_call |= 10120a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 10121a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 10122a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "Fence %#" PRIx64 " is already in use by another submission.", reinterpret_cast<uint64_t &>(fence)); 10123a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 10124a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!dev_data->fenceMap[fence].needsSignaled) { 10125a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skip_call |= 10126a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 10127a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 10128a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 10129a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence)); 10130a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 101314b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 101321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 101331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 101345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 101351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 101361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 101371344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 101381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 101395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10140e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 101415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101431344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 101441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 101451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 101461344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 101475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10148e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 101495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 101521344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 101531344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 101541344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 101555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10156e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 101575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101591344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 101601344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pWaitSemaphores[i]; 101611344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 101621344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 101631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 101641344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 101651344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 101665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 101671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 101681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "vkQueueBindSparse: Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 101691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 101701344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 101715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101741344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 101751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pSignalSemaphores[i]; 101761344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 101771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 101785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 101795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 101801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 101811344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "vkQueueBindSparse: Queue %#" PRIx64 " is signaling semaphore %#" PRIx64 101821344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 101831344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 101845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 101865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10190b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 101915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10192e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 101935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 101945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 101995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 102005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 102025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 10203b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 102051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 102060a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 102075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 102085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 102135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 102145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 102165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 10217b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 102195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 102205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 102215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 102265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 102275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR *pSwapchain) { 102285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 102305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 102320801763633180d277d26a90343464bd11646056fTobin Ehlis SWAPCHAIN_NODE *psc_node = new SWAPCHAIN_NODE(pCreateInfo); 10233b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102340801763633180d277d26a90343464bd11646056fTobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = psc_node; 102355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 102415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 102425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 102445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10245b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 102465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain); 102475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 102485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data->second->images.size() > 0) { 102495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto swapchain_image : swapchain_data->second->images) { 102505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 102515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 102525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 102535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 102545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 102555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 102565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 102595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102600a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, (uint64_t)swapchain_image, 102610801763633180d277d26a90343464bd11646056fTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1026294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 102635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete swapchain_data->second; 102665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 102675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10268b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 102695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 102705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 102715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 102745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 102755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 102775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 102795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 102805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 102815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 10282b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 102840801763633180d277d26a90343464bd11646056fTobin Ehlis auto swapchain_node = dev_data->device_extensions.swapchainMap[swapchain]; 102850801763633180d277d26a90343464bd11646056fTobin Ehlis if (!swapchain_node->images.empty()) { 102860801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 102870801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 102880801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 102895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 102905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 102915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 102925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 102935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkGetSwapchainInfoKHR(%" PRIu64 102945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 102955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 102965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 102995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 103005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 103015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 1030294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 1030394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.mipLevels = 1; 1030494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 1030594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.usage = swapchain_node->createInfo.imageUsage; 1030694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.valid = false; 1030794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 103085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 103095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 103105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 103115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 103125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 103135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 103195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 103205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 103215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 103225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPresentInfo) { 10324b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 103255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 103261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = pPresentInfo->pWaitSemaphores[i]; 103271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 103281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 103291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 103301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 103311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 103321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 103331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 103341344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 103351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 103361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 103375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103390801763633180d277d26a90343464bd11646056fTobin Ehlis VkDeviceMemory mem; 103405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 103415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]); 103425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && 103435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) { 103445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]]; 1034503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 103460801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= 103470a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 103480801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= validate_memory_is_valid(dev_data, mem, "vkQueuePresentKHR()", image); 1034903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 103505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkImageLayout> layouts; 103515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindLayouts(dev_data, image, layouts)) { 103525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 103535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 103545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 103555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 103565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 103575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 103585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 103595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 103605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 103685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 103691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 103705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 103745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 103755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 103765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 103775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 103781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 10379b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 103801657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak if (semaphore != VK_NULL_HANDLE && 103811657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 103821344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 103835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 103841344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 103855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 103865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 103885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = dev_data->fenceMap.find(fence); 103905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data != dev_data->fenceMap.end()) { 103915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.swapchain = swapchain; 103925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10393b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 103941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 103955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) { 103965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = 103975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 103985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 104045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 104055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 104065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 104075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 104085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 104095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 10410b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 104115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis res = layer_create_msg_callback(my_data->report_data, pCreateInfo, pAllocator, pMsgCallback); 104125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 104145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, 104175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT msgCallback, 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator) { 104195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 104205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 104215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10422b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 104235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 104245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 104275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 104285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 104295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 104305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 104315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 104325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 104355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 104365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 104375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 104385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 104395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueSubmit")) 104405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueSubmit; 104415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkWaitForFences")) 104425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkWaitForFences; 104435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetFenceStatus")) 104445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetFenceStatus; 104455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueWaitIdle")) 104465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueWaitIdle; 104475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDeviceWaitIdle")) 104485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDeviceWaitIdle; 104495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceQueue")) 104505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceQueue; 104515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 104525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 104535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 104545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 104555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFence")) 104565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFence; 104575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetFences")) 104585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetFences; 104595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySemaphore")) 104605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySemaphore; 104615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyEvent")) 104625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyEvent; 104635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyQueryPool")) 104645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyQueryPool; 104655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBuffer")) 104665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBuffer; 104675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBufferView")) 104685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBufferView; 104695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImage")) 104705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImage; 104715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImageView")) 104725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImageView; 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyShaderModule")) 104745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyShaderModule; 104755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipeline")) 104765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipeline; 104775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipelineLayout")) 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineLayout; 104795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySampler")) 104805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySampler; 104815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorSetLayout")) 104825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorSetLayout; 104835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorPool")) 104845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorPool; 104855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFramebuffer")) 104865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFramebuffer; 104875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyRenderPass")) 104885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyRenderPass; 104895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBuffer")) 104905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBuffer; 104915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBufferView")) 104925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBufferView; 104935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImage")) 104945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImage; 104955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImageView")) 104965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImageView; 104975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFence")) 104985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFence; 104995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "CreatePipelineCache")) 105005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineCache; 105015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "DestroyPipelineCache")) 105025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineCache; 105035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "GetPipelineCacheData")) 105045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetPipelineCacheData; 105055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "MergePipelineCaches")) 105065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMergePipelineCaches; 105075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateGraphicsPipelines")) 105085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateGraphicsPipelines; 105095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateComputePipelines")) 105105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateComputePipelines; 105115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSampler")) 105125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSampler; 105135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorSetLayout")) 105145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorSetLayout; 105155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreatePipelineLayout")) 105165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineLayout; 105175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorPool")) 105185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorPool; 105195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetDescriptorPool")) 105205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetDescriptorPool; 105215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateDescriptorSets")) 105225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateDescriptorSets; 105235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeDescriptorSets")) 105245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeDescriptorSets; 105255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUpdateDescriptorSets")) 105265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUpdateDescriptorSets; 105275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateCommandPool")) 105285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateCommandPool; 105295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyCommandPool")) 105305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyCommandPool; 105315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandPool")) 105325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandPool; 105335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateQueryPool")) 105345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateQueryPool; 105355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateCommandBuffers")) 105365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateCommandBuffers; 105375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeCommandBuffers")) 105385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeCommandBuffers; 105395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBeginCommandBuffer")) 105405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBeginCommandBuffer; 105415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEndCommandBuffer")) 105425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEndCommandBuffer; 105435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandBuffer")) 105445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandBuffer; 105455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindPipeline")) 105465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindPipeline; 105475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetViewport")) 105485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetViewport; 105495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetScissor")) 105505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetScissor; 105515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetLineWidth")) 105525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetLineWidth; 105535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBias")) 105545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBias; 105555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetBlendConstants")) 105565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetBlendConstants; 105575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBounds")) 105585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBounds; 105595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilCompareMask")) 105605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilCompareMask; 105615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilWriteMask")) 105625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilWriteMask; 105635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilReference")) 105645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilReference; 105655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindDescriptorSets")) 105665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindDescriptorSets; 105675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindVertexBuffers")) 105685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindVertexBuffers; 105695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindIndexBuffer")) 105705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindIndexBuffer; 105715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDraw")) 105725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDraw; 105735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexed")) 105745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexed; 105755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndirect")) 105765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndirect; 105775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexedIndirect")) 105785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexedIndirect; 105795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatch")) 105805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatch; 105815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatchIndirect")) 105825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatchIndirect; 105835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBuffer")) 105845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBuffer; 105855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImage")) 105865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImage; 105875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBlitImage")) 105885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBlitImage; 105895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBufferToImage")) 105905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBufferToImage; 105915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImageToBuffer")) 105925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImageToBuffer; 105935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdUpdateBuffer")) 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdUpdateBuffer; 105955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdFillBuffer")) 105965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdFillBuffer; 105975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearColorImage")) 105985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearColorImage; 105995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearDepthStencilImage")) 106005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearDepthStencilImage; 106015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearAttachments")) 106025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearAttachments; 106035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResolveImage")) 106045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResolveImage; 106055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetEvent")) 106065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetEvent; 106075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetEvent")) 106085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetEvent; 106095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWaitEvents")) 106105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWaitEvents; 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPipelineBarrier")) 106125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPipelineBarrier; 106135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginQuery")) 106145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginQuery; 106155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndQuery")) 106165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndQuery; 106175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetQueryPool")) 106185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetQueryPool; 106195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyQueryPoolResults")) 106205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyQueryPoolResults; 106215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPushConstants")) 106225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPushConstants; 106235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWriteTimestamp")) 106245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWriteTimestamp; 106255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFramebuffer")) 106265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFramebuffer; 106275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateShaderModule")) 106285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateShaderModule; 106295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateRenderPass")) 106305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateRenderPass; 106315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginRenderPass")) 106325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginRenderPass; 106335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdNextSubpass")) 106345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdNextSubpass; 106355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndRenderPass")) 106365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndRenderPass; 106375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdExecuteCommands")) 106385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdExecuteCommands; 106395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkSetEvent")) 106405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkSetEvent; 106415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkMapMemory")) 106425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMapMemory; 1064303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 106445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUnmapMemory")) 106455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUnmapMemory; 106465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateMemory")) 106475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateMemory; 106485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeMemory")) 106495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeMemory; 106505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFlushMappedMemoryRanges")) 106515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFlushMappedMemoryRanges; 106525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkInvalidateMappedMemoryRanges")) 106535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkInvalidateMappedMemoryRanges; 106545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindBufferMemory")) 106555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindBufferMemory; 106565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetBufferMemoryRequirements")) 106575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetBufferMemoryRequirements; 106585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetImageMemoryRequirements")) 106595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetImageMemoryRequirements; 106605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 106615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetQueryPoolResults")) 106625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetQueryPoolResults; 106635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindImageMemory")) 106645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindImageMemory; 106655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueBindSparse")) 106665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueBindSparse; 106675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSemaphore")) 106685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSemaphore; 106695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateEvent")) 106705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateEvent; 106715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev == NULL) 106735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 106745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 106765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 106775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->device_extensions.wsi_enabled) { 106795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSwapchainKHR")) 106805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSwapchainKHR; 106815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySwapchainKHR")) 106825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySwapchainKHR; 106835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetSwapchainImagesKHR")) 106845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetSwapchainImagesKHR; 106855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAcquireNextImageKHR")) 106865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAcquireNextImageKHR; 106875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueuePresentKHR")) 106885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueuePresentKHR; 106895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 106925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 106935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 106945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 106955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 106965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 107005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetInstanceProcAddr")) 107015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetInstanceProcAddr; 107025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 107035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 107045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateInstance")) 107055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateInstance; 107065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDevice")) 107075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDevice; 107085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 107095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 107105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties")) 107115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceLayerProperties; 107125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties")) 107135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceExtensionProperties; 107145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties")) 107155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceLayerProperties; 107165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties")) 107175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceExtensionProperties; 107185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (instance == NULL) 107205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkVoidFunction fptr; 107235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 107255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 107265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 107275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fptr) 107285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return fptr; 107295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 107315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 107325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 107345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10735