core_validation.cpp revision a9a689bef49d3e7e4c3e814099009f6bf2747ddf
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 45dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes#include <tuple> 465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 62b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 68c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine#define LOGCONSOLE(...) \ 69c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine { \ 70c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf(__VA_ARGS__); \ 71c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf("\n"); \ 72c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 76414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 7771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis// TODO : CB really needs it's own class and files so this is just temp code until that happens 7871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin EhlisGLOBAL_CB_NODE::~GLOBAL_CB_NODE() { 7971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis for (uint32_t i=0; i<VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 8071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis // Make sure that no sets hold onto deleted CB binding 8171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis for (auto set : lastBound[i].uniqueBoundSets) { 8271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->RemoveBoundCommandBuffer(this); 8371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } 8471511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } 8571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis} 8671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis 87d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 88d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 95b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 97e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 983f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; 995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 1045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 10756a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu VkInstance instance; 10856a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu 1095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 11394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 115b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski unordered_set<VkQueue> queues; // all queues under given device 1165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 119cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> samplerMap; 1202c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis unordered_map<VkImageView, unique_ptr<VkImageViewCreateInfo>> imageViewMap; 1216d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis unordered_map<VkImage, unique_ptr<IMAGE_NODE>> imageMap; 1222f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis unordered_map<VkBufferView, unique_ptr<VkBufferViewCreateInfo>> bufferViewMap; 1238718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis unordered_map<VkBuffer, unique_ptr<BUFFER_NODE>> bufferMap; 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1258d6a38de0389036581ada119e548180c614fe0efChris Forbes unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; 1265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 127397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 128cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 13057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 13772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 13804861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_NODE>> frameBufferMap; 1395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 142918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1436c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 146b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 147b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 148b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 15094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), device_extensions(), 151a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis device(VK_NULL_HANDLE), phys_dev_properties{}, phys_dev_mem_props{} {}; 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 154b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 155b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 156b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 157e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 158f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 159e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 164e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 170e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 184b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 185b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 186b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 187b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 188b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 189b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 191b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 192b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 193b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 194b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 195b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 196b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 255b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 256593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 2572c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis// Return ImageViewCreateInfo ptr for specified imageView or else NULL 258a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkImageViewCreateInfo *getImageViewData(const layer_data *dev_data, VkImageView image_view) { 2592c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_it = dev_data->imageViewMap.find(image_view); 2602c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (iv_it == dev_data->imageViewMap.end()) { 2612c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return nullptr; 2622c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis } 2632c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return iv_it->second.get(); 2642c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis} 2659a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis// Return sampler node ptr for specified sampler or else NULL 266a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSAMPLER_NODE *getSamplerNode(const layer_data *dev_data, VkSampler sampler) { 2672c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto sampler_it = dev_data->samplerMap.find(sampler); 2682c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (sampler_it == dev_data->samplerMap.end()) { 2699a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return nullptr; 2709a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis } 2719a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return sampler_it->second.get(); 2729a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis} 2736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis// Return image node ptr for specified image or else NULL 274a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisIMAGE_NODE *getImageNode(const layer_data *dev_data, VkImage image) { 2756d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_it = dev_data->imageMap.find(image); 2766d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_it == dev_data->imageMap.end()) { 2776d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return nullptr; 2786d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis } 2796d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return img_it->second.get(); 2806d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis} 2818718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis// Return buffer node ptr for specified buffer or else NULL 282a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisBUFFER_NODE *getBufferNode(const layer_data *dev_data, VkBuffer buffer) { 2832c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 2842c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (buff_it == dev_data->bufferMap.end()) { 2858718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return nullptr; 2868718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis } 2878718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return buff_it->second.get(); 2888718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis} 289b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis// Return swapchain node for specified swapchain or else NULL 290a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { 291b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); 292b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swp_it == dev_data->device_extensions.swapchainMap.end()) { 293b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis return nullptr; 294b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis } 2953f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis return swp_it->second.get(); 296b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis} 297170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis// Return swapchain for specified image or else NULL 298a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { 299170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); 300170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { 301170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return VK_NULL_HANDLE; 302170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis } 303170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return img_it->second; 304170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis} 3052f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis// Return buffer node ptr for specified buffer or else NULL 306a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkBufferViewCreateInfo *getBufferViewInfo(const layer_data *my_data, VkBufferView buffer_view) { 3072f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis auto bv_it = my_data->bufferViewMap.find(buffer_view); 3082f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis if (bv_it == my_data->bufferViewMap.end()) { 3092f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return nullptr; 3102f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis } 3112f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return bv_it->second.get(); 3122f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis} 3138718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis 31466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesFENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { 31566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->fenceMap.find(fence); 31666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->fenceMap.end()) { 31766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 31866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 31966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 32066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 32166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 32266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesQUEUE_NODE *getQueueNode(layer_data *dev_data, VkQueue queue) { 32366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->queueMap.find(queue); 32466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->queueMap.end()) { 32566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 32666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 32766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 32866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 32966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3305e92f3cfdca6a52a3dcefd053c41f728bd036cebChris ForbesSEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { 3315e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes auto it = dev_data->semaphoreMap.find(semaphore); 3325e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes if (it == dev_data->semaphoreMap.end()) { 3335e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return nullptr; 3345e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes } 3355e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return &it->second; 3365e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes} 3375e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes 3388d6a38de0389036581ada119e548180c614fe0efChris ForbesCOMMAND_POOL_NODE *getCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { 3398d6a38de0389036581ada119e548180c614fe0efChris Forbes auto it = dev_data->commandPoolMap.find(pool); 3408d6a38de0389036581ada119e548180c614fe0efChris Forbes if (it == dev_data->commandPoolMap.end()) { 3418d6a38de0389036581ada119e548180c614fe0efChris Forbes return nullptr; 3428d6a38de0389036581ada119e548180c614fe0efChris Forbes } 3438d6a38de0389036581ada119e548180c614fe0efChris Forbes return &it->second; 3448d6a38de0389036581ada119e548180c614fe0efChris Forbes} 3458d6a38de0389036581ada119e548180c614fe0efChris Forbes 34694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 3475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 3485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 3496d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, VkImage(handle)); 3506d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_node) 3516d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return &img_node->mem; 3525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 3558718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buff_node = getBufferNode(my_data, VkBuffer(handle)); 3568718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buff_node) 3578718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return &buff_node->mem; 3585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 3645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 3675121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 36872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 3695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 3705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 3715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 3725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 3730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 3740a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 3750a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 376e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 377e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 3805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 3815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 3825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 3835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 384414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 3875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for images 3925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls image info and then sends actual vs. desired usage off to helper above where 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3940a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_image_usage_flags(layer_data *dev_data, VkImage image, VkFlags desired, VkBool32 strict, 39594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 396e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3976d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, image); 3986d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 3996d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis skipCall = validate_usage_flags(dev_data, image_node->createInfo.usage, desired, strict, (uint64_t)image, 4005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "image", func_name, usage_string); 4015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 4065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls buffer info and then sends actual vs. desired usage off to helper above where 4075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 4080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_buffer_usage_flags(layer_data *dev_data, VkBuffer buffer, VkFlags desired, VkBool32 strict, 40994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 410e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4118718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 4128718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 4138718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis skipCall = validate_usage_flags(dev_data, buffer_node->createInfo.usage, desired, strict, (uint64_t)buffer, 4145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "buffer", func_name, usage_string); 4155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 4205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 42157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin EhlisDEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { 42257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_it = dev_data->memObjMap.find(mem); 42357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_it == dev_data->memObjMap.end()) { 4245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis return mem_it->second.get(); 4275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); 4345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 436e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 437e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImage image = VK_NULL_HANDLE) { 4385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4396d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, image); 4406d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node && !image_node->valid) { 44158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 443414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 4455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObj = getMemObjInfo(dev_data, mem); 4485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 44958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 451414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid memory 0x%" PRIx64 ", please fill the memory before using.", functionName, 4525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 4535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 4595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4606d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 4616d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 4626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->valid = valid; 4635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 46557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObj = getMemObjInfo(dev_data, mem); 4665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 4675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 4735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 474e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 475e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 476e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 48257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 4835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 484de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemInfo->commandBufferBindings.insert(cb); 4855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 48672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 4875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 48872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 489c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 4905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 495400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 496400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 49772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 498c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 499c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 50057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 5015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 502400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis pInfo->commandBufferBindings.erase(pCBNode->commandBuffer); 5035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 505c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 5065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 5085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 510400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 511400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 512400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 5135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 516e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 518de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes size_t cmdBufRefCount = pMemObjInfo->commandBufferBindings.size(); 519896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes size_t objRefCount = pMemObjInfo->objBindings.size(); 5205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 521de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if ((pMemObjInfo->commandBufferBindings.size()) != 0) { 52258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 524414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempting to free memory object 0x%" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 5255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " references", 5265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 5275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 529de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (cmdBufRefCount > 0 && pMemObjInfo->commandBufferBindings.size() > 0) { 530de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pMemObjInfo->commandBufferBindings) { 53158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 532de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 533414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%p still has a reference to mem obj 0x%" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 5345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 536de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemObjInfo->commandBufferBindings.clear(); 5375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 539896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (objRefCount > 0 && pMemObjInfo->objBindings.size() > 0) { 540896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pMemObjInfo->objBindings) { 541896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 542414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, 543896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 5445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 546896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemObjInfo->objBindings.clear(); 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 551e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemObjInfo(layer_data *my_data, void *object, VkDeviceMemory mem) { 552e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = my_data->memObjMap.find(mem); 5545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != my_data->memObjMap.end()) { 5555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap.erase(item); 5565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 559414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Request to delete memory object 0x%" PRIxLEAST64 " not present in memory Object Map", (uint64_t)mem); 5605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 564e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 565e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 56757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize == 0 && !internal) { 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section 57158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 573414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempting to free memory associated with a Persistent Image, 0x%" PRIxLEAST64 ", " 5745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this should not be explicitly freed\n", 5755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem); 5765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear any CB bindings for completed CBs 5785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is there a better place to do this? 5795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(pInfo->object != VK_NULL_HANDLE); 581de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // clear_cmd_buf_and_mem_references removes elements from 582de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // pInfo->commandBufferBindings -- this copy not needed in c++14, 583de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // and probably not needed in practice in c++11 584de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes auto bindings = pInfo->commandBufferBindings; 585de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : bindings) { 586a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 587de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 5885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify that no references to this mem obj remain and remove bindings 592de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() || pInfo->objBindings.size()) { 59358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= reportMemReferencesAndCleanUp(dev_data, pInfo); 5945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete mem obj info 59658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= deleteMemObjInfo(dev_data, object, mem); 5975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 6035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 6055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 6065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 6075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 6095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 6125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 6165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 617c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 6185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 6190a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 6205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 621e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 62294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 62394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 62457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = getMemObjInfo(dev_data, *pMemBinding); 6255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 62694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 6275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 628c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 6295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 630896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (!pMemObjInfo->objBindings.erase({handle, type})) { 6315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 63258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 633414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 634414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 6355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 6365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 6435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 6445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 6455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 6465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 64794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 64894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 649e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 65358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 654414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 6555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 6572e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 65857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 6592e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pMemInfo) { 66057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = getMemObjInfo(dev_data, *pMemBinding); 6612e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pPrevBinding != NULL) { 6622e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6632e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, 6642e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis "MEM", "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 6652e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis ") which has already been bound to mem object 0x%" PRIxLEAST64, 6662e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 6672e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis } else { 6682e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis pMemInfo->objBindings.insert({handle, type}); 6692e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // For image objects, make sure default memory state is correctly set 6702e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO : What's the best/correct way to handle this? 6712e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 6726d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, VkImage(handle)); 6736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 6746d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo ici = image_node->createInfo; 6752e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 6762e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO:: More memory state transition stuff. 6775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6802e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 6815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 6885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 6905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 6915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 6920a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 6930a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 6940a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 6950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes bool skipCall = VK_FALSE; 6965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6980a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, handle, type); 6995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 7012e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 70257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 7032e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pInfo) { 7042e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis pInfo->objBindings.insert({handle, type}); 7052e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // Need to set mem binding for this object 7062e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given Object, get 'mem' obj that it's bound to or NULL if no binding 7130a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool get_mem_binding_from_object(layer_data *dev_data, const uint64_t handle, 71494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis const VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 715e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 7165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 71794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 71894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 71994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *mem = *pMemBinding; 7205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 722414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Trying to get mem binding for object 0x%" PRIxLEAST64 " but no such object in %s list", handle, 7235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type)); 7245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 7290a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 7305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 73158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 73658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 73858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 73958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 7415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 74657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = (*ii).second.get(); 7475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 74957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)mem_info); 75058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 75157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(mem_info->mem)); 75258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 753c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 75457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->commandBufferBindings.size() + mem_info->objBindings.size()); 75557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (0 != mem_info->allocInfo.allocationSize) { 75657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&mem_info->allocInfo, "MEM(INFO): "); 75758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 7595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 76657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->objBindings.size()); 76757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->objBindings.size() > 0) { 76857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis for (auto obj : mem_info->objBindings) { 76958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 770414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 7715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 77757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->commandBufferBindings.size()); 77857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->commandBufferBindings.size() > 0) { 77957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis for (auto cb : mem_info->commandBufferBindings) { 78058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 781414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB 0x%p", cb); 7825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7870a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 78872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 7915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 79672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 79772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 7985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 8005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 8025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 80572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 808414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has CB 0x%p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 8095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 810c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 8115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 812c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 8135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 814414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 8155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 8225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 8265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 8305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 8335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 8425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 8445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 8455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 8485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 8525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 8575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 8845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 8855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 8935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 9945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 10025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10429ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10439ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10499ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 10509ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10529ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 10539ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10559ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 10569ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 10589ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 10599ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10609ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 10629ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 10639ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10649ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 10669ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 10679ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10689ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10709ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 10719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 10729ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 10749ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 10769ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 10779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 10789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 10799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 10809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 10819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 10825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10839ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 10869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 10879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 10899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 10909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10919ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 10939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 10949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 10979ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11019ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 11039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 11049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 11059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 11069ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 11079ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 110937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 111037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 111137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 111237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 111337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 111437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 111537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 111637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 111737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11247c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 112537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 11267c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11277c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 113037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 113137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 113237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 113337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 113437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11417c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 11427c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 114337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 11447c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11457c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11467c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 11477c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 11487c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 11497c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11507c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11537c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 11567c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 11597c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 11605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 116137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 116237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 116337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 116437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 116537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 116637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 116737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 116837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 116937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 11705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 117137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 117237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 117737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 11785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 11825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 11835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 11845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 118737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 11885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 11935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 12035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 12045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 12055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 12085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 12115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 12125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 12135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 12155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1228cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1229cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1230cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1231cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1232cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1233cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1234cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1235cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1236cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1246c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1247c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1248c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1249c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1250c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1251c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1252c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1253c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1254c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1255c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1256c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1257c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1258c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1259c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 12655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1267b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1268fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 12715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1272031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1273031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1274031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1275031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1276031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1277031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1278031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1279031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1280031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1281031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1282031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1283031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1284031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1285031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 12905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 12985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1302edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1305b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 13065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1307031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 13215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1345b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1346fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1354edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_location(shader_module const *src, spirv_inst_iter entrypoint, 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 13605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1361b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1384b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1385b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1386b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1387b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 139381264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1398c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14091d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1416b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 14297c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1435b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1436fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 1441edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_block_members(src, out, blocks, is_array_of_verts, id, type, is_patch); 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1447edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_descriptor_slot(debug_report_data *report_data, shader_module const *src, 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<descriptor_slot_t, interface_var> &out) { 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 14745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 14755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto existing_it = out.find(std::make_pair(set, binding)); 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (existing_it != out.end()) { 14805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* conflict within spv image */ 1481edef66e03ed509994449d598f4fadea1a487d41bChris Forbes log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis insn.word(2), insn.word(1), storage_class_name(insn.word(3)), existing_it->first.first, 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis existing_it->first.second); 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1491b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1492b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1493fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(set, binding)] = v; 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1499edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1500031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1502031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1508edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, outputs, producer_stage->arrayed_output); 1509edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, inputs, consumer_stage->arrayed_input); 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1522edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1523080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1524031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1525031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1530edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1532031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1533031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1538fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1539fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1540fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1541fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 15420f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1543fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1544fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 154537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1546edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 15489ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 15499ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 15509ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15540f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1555edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 15560f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1557f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 15580f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 15590f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 15600f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 15610f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 15620f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15630f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 15825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 159531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 159631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 159731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 159831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1601f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 16165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 161731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 161831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 161931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 162031c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 16225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1623f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1661edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 16715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1672edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1685edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 16885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1690edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, inputs, false); 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 16945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1695c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1696c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1697c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1698c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1699c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1700c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 17075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 17085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 1712edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1713080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1719edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1731edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 17349ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 17359ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1749edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoint, RENDER_PASS_NODE const *rp, uint32_t subpass) { 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 1752025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 1753025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes for (auto i = 0u; i < rp->subpassColorFormats[subpass].size(); i++) { 1754025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (rp->subpassColorFormats[subpass][i] != VK_FORMAT_UNDEFINED) { 1755025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes color_attachments[i] = rp->subpassColorFormats[subpass][i]; 1756025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1757025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1758025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1763edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, outputs, false); 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1765025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 1766025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1768025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 1769025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 1770025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 1771025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 1772025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1774025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 1775edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1777025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "FS writes to output location %d with no matching attachment", it_a->first.first)) { 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1780025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1781025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 1782edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1783025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", it_b->first)) { 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1786025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1788025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 1789025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1793edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1795025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "Attachment %d of type `%s` does not match FS output type of `%s`", it_b->first, 1796025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 1797025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 1803025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1804025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 18305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 183181264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 1911c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 1917c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1928edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 19325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &range : *pushConstantRanges) { 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 1954edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1955080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 1968edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1969080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1983edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, shader_module const *src, 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 1991edef66e03ed509994449d598f4fadea1a487d41bChris Forbes pass &= validate_push_constant_block_against_pipeline(report_data, pushConstantRanges, src, 1992080afef66a53dbdd085698b713697296458edfd9Chris Forbes src->get_def(def_insn.word(1)), stage); 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1999fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 2000fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 20014a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 200437083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 200678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (slot.first >= pipelineLayout->descriptorSetLayouts.size()) 200737083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2009f54d085ac836f3b0a2b62f6b401f759e586f0ea7Chris Forbes return pipelineLayout->setLayouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 20175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 20195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 20205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2021e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2024e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2026e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2030e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2031e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 20323d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 20333d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 20343d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 2035414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2037e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 204116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic PIPELINE_NODE *getPipeline(layer_data const *my_data, VkPipeline pipeline) { 2042ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 2043ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 2044ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2046ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 204916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic RENDER_PASS_NODE *getRenderPass(layer_data const *my_data, VkRenderPass renderpass) { 205016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto it = my_data->renderPassMap.find(renderpass); 205116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (it == my_data->renderPassMap.end()) { 205216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return nullptr; 205316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 205416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return it->second; 205516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes} 205616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 205704861caca7eb93a5241b164e8480bb93c826902cTobin Ehlisstatic FRAMEBUFFER_NODE *getFramebuffer(const layer_data *my_data, VkFramebuffer framebuffer) { 2058f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto it = my_data->frameBufferMap.find(framebuffer); 2059f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (it == my_data->frameBufferMap.end()) { 2060f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return nullptr; 2061f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes } 206204861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis return it->second.get(); 2063f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes} 2064f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes 2065e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehliscvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { 206611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto it = my_data->descriptorSetLayoutMap.find(dsLayout); 206711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (it == my_data->descriptorSetLayoutMap.end()) { 206811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return nullptr; 206911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 207011f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return it->second; 207111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes} 207211f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 20734a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { 20744a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto it = my_data->pipelineLayoutMap.find(pipeLayout); 20754a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (it == my_data->pipelineLayoutMap.end()) { 20764a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return nullptr; 20774a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes } 20784a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return &it->second; 20794a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes} 20804a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes 2081e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2082e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2086e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2089e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2093e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 2094e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 20953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 20963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 20973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 20983d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 2099ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2100ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2101ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 21023d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21033d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 21043d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 210545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 210645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 21073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21083d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 21093d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 21113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 21133d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 211445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 211545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 21163d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 21183d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 211945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 212045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 21213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21223d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 21233d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21243d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 21253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21263d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 21273d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 21293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21303d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 21323d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 21385ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski// If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 2145e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis // Check potential NULL cases first to avoid nullptr issues later 2146e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pPrimary == nullptr) { 2147e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pSecondary == nullptr) { 2148e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return true; 2149e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 2150e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2151e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } else if (pSecondary == nullptr) { 2152e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2153e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 215506e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 215606e963555b0df747c98c43816c16647349d21001Mark Young return true; 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 215806e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 215906e963555b0df747c98c43816c16647349d21001Mark Young return true; 21605ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else { // Format and sample count must match 21615ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 21625ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return true; 21635ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 21645ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return false; 21655ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2176e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis// For given primary and secondary RenderPass objects, verify that they're compatible 2177528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlisstatic bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPass primaryRP, const VkRenderPass secondaryRP, 21785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string &errorMsg) { 217916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto primary_render_pass = getRenderPass(my_data, primaryRP); 218016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto secondary_render_pass = getRenderPass(my_data, secondaryRP); 218116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 218216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!primary_render_pass) { 2183c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << primaryRP << ")"; 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 218716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 218816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 218916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!secondary_render_pass) { 2190c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << secondaryRP << ")"; 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Trivial pass case is exact same RP 21965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRP == secondaryRP) { 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 219916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *primaryRPCI = primary_render_pass->pCreateInfo; 220016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *secondaryRPCI = secondary_render_pass->pCreateInfo; 22015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2202c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 22045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 22055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 22095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 22105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 22115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 22125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 22145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 22175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2218c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2226c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2232fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2233fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2234fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2235fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2236fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2237c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2238fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2239fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2240fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2241fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2242fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 22435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 22495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2250c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2260397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2261397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2262397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 2263397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis const VkPipelineLayout layout, const uint32_t layoutIndex, string &errorMsg) { 22644a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(my_data, layout); 22654a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (!pipeline_layout) { 2266c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkPipelineLayout (" << layout << ")"; 22685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22714a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (layoutIndex >= pipeline_layout->descriptorSetLayouts.size()) { 2272c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22734a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes errorStr << "VkPipelineLayout (" << layout << ") only contains " << pipeline_layout->descriptorSetLayouts.size() 22744a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes << " setLayouts corresponding to sets 0-" << pipeline_layout->descriptorSetLayouts.size() - 1 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << ", but you're attempting to bind set to index " << layoutIndex; 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22794a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto layout_node = pipeline_layout->setLayouts[layoutIndex]; 2280397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 22815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2284edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2285e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 22865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 22885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 22905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 22915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2292edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 22955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 22965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 22975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 22985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 22995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2300e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 23015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2309edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 23101b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 23125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23131b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 23141b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 23157b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 23167b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 23175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 23187b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 23197b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 23207b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 23217b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 23227b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 23237b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 23247b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 23255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 23285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 23295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 23305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 23315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 23335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 23345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 23355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 23365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 23375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 23425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER; 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 234935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 235035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 235135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 235235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 235335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 235435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 235535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 235635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 235735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 235835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 23595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 23605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 23625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 23635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 23645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 23655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 23665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 23685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 23695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 23715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 23725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 23735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 23745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 23755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 23775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 23795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; 23805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 23825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 23865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 23875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 23895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 23905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23934110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2394a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 23954110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2396080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2397a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2398a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2399a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2400a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2401a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2402a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2403a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2404a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2405a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2406a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 240769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 240869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2409e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2410a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2411a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2412a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2413a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2414a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2415a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2416a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2417a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2418a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2419a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2420a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2421a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2422a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2423a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2424a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2425a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2426a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2427a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 24284110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2429a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2430a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2431a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 24324110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2433a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2434a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2435a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 24364110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2437a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2438a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2439a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 24404110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2441a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2442a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2443a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2444a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 24454110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2446a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2447a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2448a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2449a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 24504110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2451a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2452a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2453a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 24544110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2455a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2456a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2457a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 24584110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2459a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2460a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2461a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2462a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 24634110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2464a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2465a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2466a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2467a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 24684110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2469a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2470a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2471a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2472a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 24734110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2474a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2475a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2476a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2477a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 24784110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2479a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2480a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2481a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 24824110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2483a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2484a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2485a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 24864110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2487a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2488a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2489a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 24904110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2491a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2492a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2493a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 24944110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2495a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2496a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2497a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 24984110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2499a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2500a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2501a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 25024110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2503a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2504a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2505a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 25064110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2507a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2508a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2509a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 25104110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2511a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2512a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2513a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2514a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 25154110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2516a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2517a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2518a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 25194110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2520a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2521a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2522a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2523a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 25244110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2525a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2526a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2527a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2528a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 25294110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2530a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2531a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2532a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 25334110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2534a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2535a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2536a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2537e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2538a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2539a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2540a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2541a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2542a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2543a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2544a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2545a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2546ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbesstatic bool validate_pipeline_shader_stage(debug_report_data *report_data, 2547ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes VkPipelineShaderStageCreateInfo const *pStage, 2548ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes PIPELINE_NODE *pipeline, 2549ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes shader_module **out_module, 2550ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes spirv_inst_iter *out_entrypoint, 255169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 2552ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unordered_map<VkShaderModule, 2553ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unique_ptr<shader_module>> const &shaderModuleMap) { 2554e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 255569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 255669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 2557557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_specialization_offsets(report_data, pStage); 255878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 255978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 256078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 256178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2562557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2563080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 256478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 256578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2566e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 256778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 256878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 256978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 257078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2571557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 257278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 257378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 257478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 257578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 257678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 257778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 257878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::map<descriptor_slot_t, interface_var> descriptor_uses; 2579557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes collect_interface_by_descriptor_slot(report_data, module, accessible_ids, descriptor_uses); 258078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2581ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes auto pipelineLayout = pipeline->pipelineLayout; 2582ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 258378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 2584557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_push_constant_usage(report_data, &pipelineLayout->pushConstantRanges, 258578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes module, accessible_ids, pStage->stage); 258678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 258778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 258878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 258978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 259078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 259178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2592fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 25934110a6be7a8a287d459475926985f71c27d01298Chris Forbes const auto & binding = get_descriptor_binding(pipelineLayout, use.first); 259478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 259578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 259678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2597557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2598080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 259978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 260078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2601e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 260278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 260378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2604557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 260578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 260678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 260778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 260878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2609fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 261078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2611e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 261278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2613edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2614fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2615557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2616fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2617fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2618fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2619fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 262078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2621e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 262278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 262378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2624557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2625fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 262678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 262778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2628fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2629e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 263078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 263178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 263278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 263378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 263578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 263678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2638a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2639a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2640e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_NODE *pPipeline, 264169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 264269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 26436660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 26445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 26465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 26485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 26495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 26505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 26515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2652e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 26535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 26556660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 265678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2657e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 265869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 265969f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 26605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 26635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2665e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 26665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2669e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 26705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 26745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 26765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 26775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 26785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 26815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 26825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2683e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2684031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2685031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 26865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 26885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26917c7400aa231c3dbb21e51158adebb83d5f528130Chris Forbes if (shaders[fragment_stage] && pPipeline->renderPass) { 2692e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 26937c7400aa231c3dbb21e51158adebb83d5f528130Chris Forbes pPipeline->renderPass, pCreateInfo->subpass); 26945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 26975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2699e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_NODE *pPipeline, VkPhysicalDeviceFeatures const *enabledFeatures, 270069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 27016660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 270203857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 270303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 270403857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 270503857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 2706e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 270769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 270803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 27095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 2710a682b1c533d9a492243b363c6585c4f03bcd87aaTobin Ehliscvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { 2711104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis auto set_it = my_data->setMap.find(set); 2712104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis if (set_it == my_data->setMap.end()) { 27135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 27145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2715104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return set_it->second; 27165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 27177a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 27187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 27197a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 27207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 27217a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 27227a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 27237a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2724e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 27257a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 2726dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes const vector<std::tuple<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>, 2727dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t> const *>> &activeSetBindingsPairs) { 2728e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 2729a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2730dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes cvdescriptorset::DescriptorSet *set_node = std::get<0>(set_bindings_pair); 2731cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 2732dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (!set_node->ValidateDrawState(std::get<1>(set_bindings_pair), *std::get<2>(set_bindings_pair), 2733397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 2734cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 2735397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 2736cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2737cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2738414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " encountered the following validation error at draw time: %s", 2739cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), err_str.c_str()); 2740cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 2741dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes set_node->GetStorageUpdates(std::get<1>(set_bindings_pair), &pCB->updateBuffers, &pCB->updateImages); 27425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 27445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 27455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2746eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 2747ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic VkSampleCountFlagBits getNumSamples(PIPELINE_NODE const *pipe) { 2748ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 2749ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 2750eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 2751eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2752eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 2753eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2754eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2755eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 275629d196e071b2dc1db47702085469396f2b956820Chris Forbesstatic bool validatePipelineDrawtimeState(layer_data const *my_data, 275729d196e071b2dc1db47702085469396f2b956820Chris Forbes LAST_BOUND_STATE const &state, 275829d196e071b2dc1db47702085469396f2b956820Chris Forbes const GLOBAL_CB_NODE *pCB, 275929d196e071b2dc1db47702085469396f2b956820Chris Forbes PIPELINE_NODE const *pPipeline) { 2760eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 276129d196e071b2dc1db47702085469396f2b956820Chris Forbes 276229d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify Vtx binding 276329d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pPipeline->vertexBindingDescriptions.size() > 0) { 276429d196e071b2dc1db47702085469396f2b956820Chris Forbes for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { 276529d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 276629d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 276729d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 276829d196e071b2dc1db47702085469396f2b956820Chris Forbes "The Pipeline State Object (0x%" PRIxLEAST64 276929d196e071b2dc1db47702085469396f2b956820Chris Forbes ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 277029d196e071b2dc1db47702085469396f2b956820Chris Forbes " should be set via vkCmdBindVertexBuffers.", 277129d196e071b2dc1db47702085469396f2b956820Chris Forbes (uint64_t)state.pipeline, i); 277229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 277329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 277429d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 277529d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pCB->currentDrawData.buffers.empty()) { 277629d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 277729d196e071b2dc1db47702085469396f2b956820Chris Forbes 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 277829d196e071b2dc1db47702085469396f2b956820Chris Forbes "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 277929d196e071b2dc1db47702085469396f2b956820Chris Forbes ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 278029d196e071b2dc1db47702085469396f2b956820Chris Forbes (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline); 278129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 278229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 278329d196e071b2dc1db47702085469396f2b956820Chris Forbes // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 278429d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip check if rasterization is disabled or there is no viewport. 278529d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((!pPipeline->graphicsPipelineCI.pRasterizationState || 278629d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 278729d196e071b2dc1db47702085469396f2b956820Chris Forbes pPipeline->graphicsPipelineCI.pViewportState) { 278829d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 278929d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 279029d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynViewport) { 279129d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->viewports.size() != pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 279229d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 279329d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 279429d196e071b2dc1db47702085469396f2b956820Chris Forbes "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 279529d196e071b2dc1db47702085469396f2b956820Chris Forbes ", but PSO viewportCount is %u. These counts must match.", 279629d196e071b2dc1db47702085469396f2b956820Chris Forbes pCB->viewports.size(), pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 279729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 279829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 279929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynScissor) { 280029d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->scissors.size() != pPipeline->graphicsPipelineCI.pViewportState->scissorCount) { 280129d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 280229d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 280329d196e071b2dc1db47702085469396f2b956820Chris Forbes "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 280429d196e071b2dc1db47702085469396f2b956820Chris Forbes ", but PSO scissorCount is %u. These counts must match.", 280529d196e071b2dc1db47702085469396f2b956820Chris Forbes pCB->scissors.size(), pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 280629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 280729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 280829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 280929d196e071b2dc1db47702085469396f2b956820Chris Forbes 281029d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify that any MSAA request in PSO matches sample# in bound FB 281129d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip the check if rasterization is disabled. 281229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pPipeline->graphicsPipelineCI.pRasterizationState || 281329d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 281429d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 281529d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->activeRenderPass) { 281629d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkRenderPassCreateInfo *render_pass_info = pCB->activeRenderPass->pCreateInfo; 281729d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 281829d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits subpass_num_samples = VkSampleCountFlagBits(0); 281929d196e071b2dc1db47702085469396f2b956820Chris Forbes uint32_t i; 282029d196e071b2dc1db47702085469396f2b956820Chris Forbes 282129d196e071b2dc1db47702085469396f2b956820Chris Forbes const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 282229d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 282329d196e071b2dc1db47702085469396f2b956820Chris Forbes (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 282429d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 2825eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2826ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 2827eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 2828414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 2829eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 2830eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 2831ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 283229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 2833eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 283429d196e071b2dc1db47702085469396f2b956820Chris Forbes for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 283529d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits samples; 2836eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 283729d196e071b2dc1db47702085469396f2b956820Chris Forbes if (subpass_desc->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) 283829d196e071b2dc1db47702085469396f2b956820Chris Forbes continue; 2839eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 284029d196e071b2dc1db47702085469396f2b956820Chris Forbes samples = render_pass_info->pAttachments[subpass_desc->pColorAttachments[i].attachment].samples; 284129d196e071b2dc1db47702085469396f2b956820Chris Forbes if (subpass_num_samples == static_cast<VkSampleCountFlagBits>(0)) { 284229d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = samples; 284329d196e071b2dc1db47702085469396f2b956820Chris Forbes } else if (subpass_num_samples != samples) { 284429d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = static_cast<VkSampleCountFlagBits>(-1); 284529d196e071b2dc1db47702085469396f2b956820Chris Forbes break; 2846eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 284729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 284829d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((subpass_desc->pDepthStencilAttachment != NULL) && 284929d196e071b2dc1db47702085469396f2b956820Chris Forbes (subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 285029d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSampleCountFlagBits samples = 2851eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young render_pass_info->pAttachments[subpass_desc->pDepthStencilAttachment->attachment].samples; 285229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (subpass_num_samples == static_cast<VkSampleCountFlagBits>(0)) 285329d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = samples; 285429d196e071b2dc1db47702085469396f2b956820Chris Forbes else if (subpass_num_samples != samples) 285529d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = static_cast<VkSampleCountFlagBits>(-1); 285629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 2857eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 285829d196e071b2dc1db47702085469396f2b956820Chris Forbes if (((subpass_desc->colorAttachmentCount > 0) || (subpass_desc->pDepthStencilAttachment != NULL)) && 285929d196e071b2dc1db47702085469396f2b956820Chris Forbes (pso_num_samples != subpass_num_samples)) { 286029d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 2861eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2862ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 2863414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 2864414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 2865ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 2866ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 2867eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 286829d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 286929d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 287029d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 287129d196e071b2dc1db47702085469396f2b956820Chris Forbes "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 287229d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 2873eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2874eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2875528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // Verify that PSO creation renderPass is compatible with active renderPass 2876528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (pCB->activeRenderPass) { 2877528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis std::string err_string; 2878528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (!verify_renderpass_compatibility(my_data, pCB->activeRenderPass->renderPass, pPipeline->graphicsPipelineCI.renderPass, 2879528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis err_string)) { 2880528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with 2881528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis skip_call |= 2882528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2883528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 2884528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " 2885528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 2886528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), reinterpret_cast<uint64_t &>(pPipeline), 2887528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); 2888528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 2889528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 289029d196e071b2dc1db47702085469396f2b956820Chris Forbes // TODO : Add more checks here 289129d196e071b2dc1db47702085469396f2b956820Chris Forbes 2892eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 2893eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2894eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 28955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 2896e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, const bool indexedDraw, 2897e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipelineBindPoint bindPoint) { 2898e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 28997a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto const &state = pCB->lastBound[bindPoint]; 29007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, state.pipeline); 290122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 290222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 290322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 290422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 290522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 290622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 290722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 290822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 290922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 29103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 29117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 29127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 29137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 29145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 291522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (state.pipelineLayout) { 291622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 2917169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes auto pipelineLayout = (bindPoint == VK_PIPELINE_BIND_POINT_GRAPHICS) ? pPipe->graphicsPipelineCI.layout : pPipe->computePipelineCI.layout; 2918169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes 291922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2920dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes vector<std::tuple<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>, std::vector<uint32_t> const *>> activeSetBindingsPairs; 2921dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes for (auto & setBindingPair : pPipe->active_slots) { 292222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 292322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 292422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 292522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 292622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 2927414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 292822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 292971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], 2930169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes pipelineLayout, setIndex, errorString)) { 293122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Set is bound but not compatible w/ overlapping pipelineLayout from PSO 293271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); 293322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 293422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 293522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 2936414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 2937414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 2938169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes (uint64_t)setHandle, setIndex, (uint64_t)pipelineLayout, errorString.c_str()); 293922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 294022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 294171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis cvdescriptorset::DescriptorSet *pSet = state.boundDescriptorSets[setIndex]; 294222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 2943dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes activeSetBindingsPairs.push_back(std::make_tuple(pSet, setBindingPair.second, 2944dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes &state.dynamicOffsets[setIndex])); 294522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 294622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 2947397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 294822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis for (auto binding : setBindingPair.second) { 2949397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 295022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 295122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2952397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2953414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 295422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 2955397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 2956fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 29575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 296022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 296122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 296222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, pCB, activeSetBindingsPairs); 296322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 2964eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2965eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 296629d196e071b2dc1db47702085469396f2b956820Chris Forbes if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 296729d196e071b2dc1db47702085469396f2b956820Chris Forbes result |= validatePipelineDrawtimeState(my_data, state, pCB, pPipe); 2968eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 29695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 29705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2972a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 2973a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 2974a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 2975a27508babf63d50aea75883a3702979193c23683Mark Young 2976a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 2977a27508babf63d50aea75883a3702979193c23683Mark Young if ((VK_FALSE == my_data->phys_dev_properties.features.wideLines) && (1.0f != lineWidth)) { 2978a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 2979a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 2980a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 2981a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 2982a27508babf63d50aea75883a3702979193c23683Mark Young } else { 2983a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 2984a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 2985a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 2986a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 2987a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 2988a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 2989a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 2990a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 2991a27508babf63d50aea75883a3702979193c23683Mark Young } 2992a27508babf63d50aea75883a3702979193c23683Mark Young } 2993a27508babf63d50aea75883a3702979193c23683Mark Young 2994a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 2995a27508babf63d50aea75883a3702979193c23683Mark Young} 2996a27508babf63d50aea75883a3702979193c23683Mark Young 29975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 2998e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 2999e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 3000e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 30015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 30035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 30055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 30065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 30075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 30085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 30095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 30105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 30115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 30145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 30155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 30165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 30205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 30215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 30225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 30245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 30255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 30285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 30315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3035b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 30363d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 303726c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3038c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 3039c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski if ((pAttachments[0].blendEnable != pAttachments[i].blendEnable) || 3040c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcColorBlendFactor != pAttachments[i].srcColorBlendFactor) || 3041c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstColorBlendFactor != pAttachments[i].dstColorBlendFactor) || 3042c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorBlendOp != pAttachments[i].colorBlendOp) || 3043c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcAlphaBlendFactor != pAttachments[i].srcAlphaBlendFactor) || 3044c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstAlphaBlendFactor != pAttachments[i].dstAlphaBlendFactor) || 3045c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].alphaBlendOp != pAttachments[i].alphaBlendOp) || 3046c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorWriteMask != pAttachments[i].colorWriteMask)) { 3047c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski skipCall |= 3048c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3049c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski DRAWSTATE_INDEPENDENT_BLEND, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " 3050c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski "enabled, all elements of pAttachments must be identical"); 3051c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 30525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3055b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 30565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 30575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 30605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 30615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 30635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 30645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 30655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 30685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 30695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3072a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 30735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 30745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 307516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(my_data, pPipeline->graphicsPipelineCI.renderPass); 307616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass && 307716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeline->graphicsPipelineCI.subpass >= renderPass->pCreateInfo->subpassCount) { 30785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 30805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "is out of range for this renderpass (0..%u)", 308116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeline->graphicsPipelineCI.subpass, renderPass->pCreateInfo->subpassCount - 1); 30825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3084e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->phys_dev_properties.features, 308569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 3086e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall = true; 30875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 308852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 308952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 309052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 309152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 309252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 309352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 309452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 309552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 309652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 309752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 309852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 31025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 31045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 31065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 31075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 31085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 31105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 31115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 31135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 31165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 31175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 31195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 31205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 31225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 31235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3124ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3125ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 31265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 31295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology for tessellation pipelines"); 31305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3131ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3132ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 31335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 31345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology is only valid for tessellation pipelines"); 31385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3139ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 3140ca546210846c65808717f8875deae39bd227c240Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3141ca546210846c65808717f8875deae39bd227c240Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 3142ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "Invalid Pipeline CreateInfo State: " 3143ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 3144ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3145ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3146ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 31475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology used with patchControlPoints value %u." 31515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " patchControlPoints should be >0 and <=32.", 3152ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3155a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3156a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3157a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 3158a27508babf63d50aea75883a3702979193c23683Mark Young skipCall |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 3159a27508babf63d50aea75883a3702979193c23683Mark Young pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3160a27508babf63d50aea75883a3702979193c23683Mark Young } 3161a27508babf63d50aea75883a3702979193c23683Mark Young } 31625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 31635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 31645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 31655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 316645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 31685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 31705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and scissors are dynamic PSO must include " 31715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 31725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 31735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 31745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 3177ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 3178ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 31805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3181e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3182e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 31835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 31845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 31855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 31895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 31905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetViewport().", 31915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 31925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 31955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 31965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 31975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 32005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 32015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetScissor().", 32025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 32035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 32085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 32125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 32135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3214ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3215ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 32165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 32185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 32215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 3223e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin EhlisDESCRIPTOR_POOL_NODE *getPoolNode(const layer_data *dev_data, const VkDescriptorPool pool) { 3224bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis auto pool_it = dev_data->descriptorPoolMap.find(pool); 3225bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis if (pool_it == dev_data->descriptorPoolMap.end()) { 32265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 32275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3228bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis return pool_it->second; 32295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3231e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3232e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3236e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 32375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 32405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 32465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 32505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 32515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 32535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 32555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3259fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 32605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3261fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3264fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 32665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3267fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3270fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3271e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 32725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 3273e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 32741d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 32805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3281e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3289e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 3290fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 3291fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis skipCall |= log_msg( 3292fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3293fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3294fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3295fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 33014a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 33024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 33034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 33044a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33064a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 33074a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 33084a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 33094a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 33104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33114a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33124a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 33134a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 33144a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 33154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 33164a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 33174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 33194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 33204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 33214a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 33224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 33234a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 33254a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 33264a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 33274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 33284a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 33294a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 33304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 33334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 33344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 33354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 33364a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33384a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 33394a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 33404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 33414a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 33424a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 33434a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33444a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 33454a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 33464a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 33474a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 33505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 33514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 33524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 33534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 33544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 33554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 33564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 33575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 33584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 33605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 33614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 33675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 33684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 33694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 33704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 33714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 33724a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 33734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 33754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 33784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 33845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 33855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 33915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 33926d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, image); 33936d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!img_node) 33945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 33955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 33986d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (sub_data->second.size() >= (img_node->createInfo.arrayLayers * img_node->createInfo.mipLevels + 1)) { 33995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 34155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 34175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 34185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 342508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 34265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 34275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 342808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 342908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 343008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 343108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 34325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 343508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 343708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 343808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 34425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 34435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 34447068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 34457068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 34467068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 344708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 345108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 345208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 345308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 345408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 345508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 345608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 34575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 345908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 346008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 34615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 346208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 346308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 346408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 346508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 34665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 346808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 34695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 347008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 34742c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_data = getImageViewData(dev_data, imageView); 34752c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis assert(iv_data); 34762c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImage &image = iv_data->image; 34772c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImageSubresourceRange &subRange = iv_data->subresourceRange; 34785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 34795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 34825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 34835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 34845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 34855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 34905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3491e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3492e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3493e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3494e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 34955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 34985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3499414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 35035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 3505414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer.", 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 35105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3511f80bf38f4fb3f177b3e1be11b7b1c5edcdbf7d9bChris Forbes 3512e6651096ed8f07840447783c66827cc16d659a49Tobin Ehlis// Remove set from setMap and delete the set 35139dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 35149dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 35159dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 35169dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 35175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 35185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 35195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 35205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 35215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 35225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3523c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3524cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 35259dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 35265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3527f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 35335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 35355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPool) { 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 35375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 3538414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unable to find pool node for pool 0x%" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t)pool); 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: validate flags 3541397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3542cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : pPool->sets) { 35439dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 3544cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 3545f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis pPool->sets.clear(); 3546e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis // Reset available count for each type and available sets for this pool 35475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 35485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 35495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3550e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis pPool->availableSets = pPool->maxSets; 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 35555121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 35565121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 35575121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 355872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 355972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3560414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 35615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 35625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35635121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 35665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3568400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 35755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3577e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 35785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3583e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 35845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3585e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3586e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 3587d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && 3588d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 35935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3626a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool addCmd(layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 3627e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3628a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(my_data, pCB->createInfo.commandPool); 3629a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (pPool) { 3630a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].queueFlags; 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 36525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 36535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 36575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 36595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 36605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 36615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 36625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 36675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 36685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 36695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 36735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 36785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 36837651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis case CMD_END: 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 36917651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else { 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 3703400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 3704400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 3706b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 371993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 372072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 372172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 372272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 372371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->RemoveBoundCommandBuffer(pCB); 372472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 372572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 372672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 372793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 3729ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedSets.clear(); 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->updatedSets.clear(); 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedFramebuffers.clear(); 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 3737c7e6bc41aa9c6e5a677b138b9459b252cd3bedf2Mark Lobodzinski pCB->writeEventsBeforeWait.clear(); 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 3742abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 3748bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 3749bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 3750bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 3751bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 37537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 37547a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 3755400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 3756b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 3757d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.clear(); 375893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 375993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 376093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 3761f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto fbNode = getFramebuffer(dev_data, framebuffer); 3762f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (fbNode) 3763f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes fbNode->referencingCmdBuffers.erase(pCB->commandBuffer); 376493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 376593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 37667003b38da5cc27a063af3c45080f3a35438283eeTobin Ehlis pCB->activeFramebuffer = VK_NULL_HANDLE; 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 3773ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 3774ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 37755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 3781ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 3782ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 37963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 38115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 38125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 3820e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 3821e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 382472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 3830ca546210846c65808717f8875deae39bd227c240Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 3831ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 3832ca546210846c65808717f8875deae39bd227c240Tobin Ehlis .c_str()); 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3842414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "Cmds in CB 0x%p", (void *)cb); 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 3847414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3854e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 3855e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= printPipeline(my_data, cb); 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 3865e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3866e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 3870414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 3871ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 3878e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3879e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3890b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 3891d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 3892b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 389689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 389789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3913b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 391456a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 3915b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 3916b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3918b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 3919b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 3920b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3922b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 393089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3939b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 39415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 39485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 397389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 397489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 397556a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 398156a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3994b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 40006c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4005b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 40075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4008b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 40095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4010b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 40125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4013b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4015b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4017b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4018b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4019b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 402889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 40325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4033b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 4037f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 40385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 4039f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 4040f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 4041a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 4042a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 4043a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 4044fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 40455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 40465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 40511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 40521344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4053b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 405403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 4055e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4056b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 40610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 40620a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 40635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 406458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4065400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 40665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 406757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis pInfo = (*ii).second.get(); 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, 4073414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 4074414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4080b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 4083414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 4086e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 40885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 40935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 40945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 40975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 40995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 41005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4101971020aec6166f20a12a833ebd003e0193f4160aChris Forbesstatic bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 4102e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 41035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 41045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 41055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 41075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4108414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 41095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 41105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 41125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 41135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4114856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4115856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4116856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4117971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4118414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4119856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4120414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4121414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4122414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4123856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4124856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4125856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4126856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4127971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4128414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4129856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4130856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4131856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4132856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 413939d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 4141da8f07baf262972eb3e719fa07b073c180dff157Chris Forbesstatic bool validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB) { 4142e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 41458718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 41468718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4149414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41518718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->in_use.fetch_add(1); 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 415572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 415672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 415771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis if (!my_data->setMap.count(set->GetSet())) { 415872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 415972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 416072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 4161414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted descriptor set 0x%" PRIx64 ".", (uint64_t)(set)); 416272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 416371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->in_use.fetch_add(1); 416472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode == my_data->eventMap.end()) { 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4173414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted event 0x%" PRIx64 ".", reinterpret_cast<uint64_t &>(event)); 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_add(1); 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4178c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine for (auto event : pCB->writeEventsBeforeWait) { 4179c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine auto eventNode = my_data->eventMap.find(event); 4180c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine eventNode->second.write_in_use++; 4181c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4185b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4186b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 4187b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4188b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4189b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4190b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4191b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4192b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4193b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4194b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4195b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4196414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4197414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4198b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4199b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4200b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4201b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4202b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4203b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4204b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4205b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4206b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4207b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4208b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4209b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4210b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4211b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4212b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4213b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4214b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4215651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void decrementResources(layer_data *my_data, CB_SUBMISSION *submission) { 4216da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto cb : submission->cbs) { 4217da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto pCB = getCBNode(my_data, cb); 4218da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto drawDataElement : pCB->drawData) { 4219da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto buffer : drawDataElement.buffers) { 4220da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto buffer_node = getBufferNode(my_data, buffer); 4221da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes if (buffer_node) { 4222da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes buffer_node->in_use.fetch_sub(1); 4223da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4226da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 4227da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto set : pCB->lastBound[i].uniqueBoundSets) { 4228da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes set->in_use.fetch_sub(1); 4229da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 42305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4231da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto event : pCB->events) { 4232da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto eventNode = my_data->eventMap.find(event); 4233da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes if (eventNode != my_data->eventMap.end()) { 4234da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes eventNode->second.in_use.fetch_sub(1); 4235da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 42365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4237da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto event : pCB->writeEventsBeforeWait) { 4238da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto eventNode = my_data->eventMap.find(event); 4239da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes if (eventNode != my_data->eventMap.end()) { 4240da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes eventNode->second.write_in_use--; 4241da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 42425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4243da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto queryStatePair : pCB->queryToStateMap) { 4244da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 4245da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 4246da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto eventStagePair : pCB->eventToStageMap) { 4247da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 4248c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 4249c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 4250da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 4251da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto semaphore : submission->semaphores) { 4252da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto pSemaphore = getSemaphoreNode(my_data, semaphore); 4253da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes if (pSemaphore) { 4254da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_sub(1); 4255da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4258a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// For fenceCount fences in pFences, mark fence signaled, decrement in_use, and call 4259a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// decrementResources for all priorFences and cmdBuffers associated with fence. 4260b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 4261b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4262ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis std::vector<std::pair<VkFence, FENCE_NODE *>> fence_pairs; 42635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 4264accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes auto pFence = getFenceNode(my_data, pFences[i]); 4265cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (!pFence || pFence->state != FENCE_INFLIGHT) 4266cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes continue; 4267cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 4268cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_pairs.emplace_back(pFences[i], pFence); 4269cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_RETIRED; 4270cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 4271accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes decrementResources(my_data, static_cast<uint32_t>(pFence->priorFences.size()), 4272accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes pFence->priorFences.data()); 4273accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes for (auto & submission : pFence->submissions) { 4274651d92815dfff917308137bb67aacccc4f60df86Chris Forbes decrementResources(my_data, &submission); 4275da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto cb : submission.cbs) { 4276da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes skip_call |= cleanInFlightCmdBuffer(my_data, cb); 4277da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes removeInFlightCmdBuffer(my_data, cb); 4278da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4280accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes pFence->submissions.clear(); 4281accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes pFence->priorFences.clear(); 42825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4283ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis for (auto fence_pair : fence_pairs) { 42846bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis for (auto queue : fence_pair.second->queues) { 4285df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pQueue = getQueueNode(my_data, queue); 4286df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes if (pQueue) { 42876bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto last_fence_data = 4288df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes std::find(pQueue->lastFences.begin(), pQueue->lastFences.end(), fence_pair.first); 4289df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes if (last_fence_data != pQueue->lastFences.end()) 4290df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes pQueue->lastFences.erase(last_fence_data); 42916bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis } 4292bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4293be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine for (auto& fence_data : my_data->fenceMap) { 4294be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine auto prior_fence_data = 4295be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine std::find(fence_data.second.priorFences.begin(), fence_data.second.priorFences.end(), fence_pair.first); 4296be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine if (prior_fence_data != fence_data.second.priorFences.end()) 4297be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine fence_data.second.priorFences.erase(prior_fence_data); 4298be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine } 4299bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4300b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4302a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Decrement in_use for all outstanding cmd buffers that were submitted on this queue 4303b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, VkQueue queue) { 4304b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 4307651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto & submission : queue_data->second.untrackedSubmissions) { 4308651d92815dfff917308137bb67aacccc4f60df86Chris Forbes decrementResources(my_data, &submission); 4309da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto cb : submission.cbs) { 4310da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes skip_call |= cleanInFlightCmdBuffer(my_data, cb); 4311da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes removeInFlightCmdBuffer(my_data, cb); 4312da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 43135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4314651d92815dfff917308137bb67aacccc4f60df86Chris Forbes queue_data->second.untrackedSubmissions.clear(); 4315b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(my_data, static_cast<uint32_t>(queue_data->second.lastFences.size()), 4316b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine queue_data->second.lastFences.data()); 43170a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4318b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 43190a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 43200a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 4321b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This function merges command buffer tracking between queues when there is a semaphore dependency 4322b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// between them (see below for details as to how tracking works). When this happens, the prior 4323b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// fences from the signaling queue are merged into the wait queue as well as any untracked command 4324b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers. 4325e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 43260a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 43270a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 43280a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4329a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes auto pQueue = getQueueNode(dev_data, queue); 4330a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes auto pOtherQueue = getQueueNode(dev_data, other_queue); 4331a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes if (!pQueue || !pOtherQueue) { 43320a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 43330a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4334a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto fenceInner : pOtherQueue->lastFences) { 4335a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pQueue->lastFences.push_back(fenceInner); 4336a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes auto pFenceInner = getFenceNode(dev_data, fenceInner); 4337a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes if (pFenceInner) 4338a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pFenceInner->queues.insert(other_queue); 43390a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 43404b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // TODO: Stealing the untracked CBs out of the signaling queue isn't really 43414b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // correct. A subsequent submission + wait, or a QWI on that queue, or 43424b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // another semaphore dependency to a third queue may /all/ provide 43434b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // suitable proof that the work we're stealing here has completed on the 43444b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // device, but we've lost that information by moving the tracking between 43454b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // queues. 4346a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes auto pFence = getFenceNode(dev_data, fence); 4347a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes if (pFence) { 4348a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto submission : pOtherQueue->untrackedSubmissions) { 4349a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pFence->submissions.push_back(submission); 43500a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4351a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pOtherQueue->untrackedSubmissions.clear(); 43520a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 4353a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto submission : pOtherQueue->untrackedSubmissions) { 4354a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pQueue->untrackedSubmissions.push_back(submission); 43550a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4356a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pOtherQueue->untrackedSubmissions.clear(); 43575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4358a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto eventStagePair : pOtherQueue->eventToStageMap) { 4359a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pQueue->eventToStageMap[eventStagePair.first] = eventStagePair.second; 4360b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 4361a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto queryStatePair : pOtherQueue->queryToStateMap) { 4362a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pQueue->queryToStateMap[queryStatePair.first] = queryStatePair.second; 4363d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 43645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4366b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This is the core function for tracking command buffers. There are two primary ways command 4367b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers are tracked. When submitted they are stored in the command buffer list associated 4368b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// with a fence or the untracked command buffer list associated with a queue if no fence is used. 4369b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Each queue also stores the last fence that was submitted onto the queue. This allows us to 4370b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// create a linked list of fences and their associated command buffers so if one fence is 4371b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on, prior fences on that queue are also considered to have been waited on. When a fence is 4372b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on (either via a queue, device or fence), we free the cmd buffers for that fence and 4373b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// recursively call with the prior fences. 4374651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4375651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4376651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// Submit a fence to a queue, delimiting previous fences and previous untracked 4377651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// work by it. 4378651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void 4379651d92815dfff917308137bb67aacccc4f60df86Chris ForbesSubmitFence(QUEUE_NODE *pQueue, FENCE_NODE *pFence) 4380651d92815dfff917308137bb67aacccc4f60df86Chris Forbes{ 4381651d92815dfff917308137bb67aacccc4f60df86Chris Forbes assert(!pFence->priorFences.size()); 4382651d92815dfff917308137bb67aacccc4f60df86Chris Forbes assert(!pFence->submissions.size()); 4383651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4384651d92815dfff917308137bb67aacccc4f60df86Chris Forbes std::swap(pFence->priorFences, pQueue->lastFences); 4385651d92815dfff917308137bb67aacccc4f60df86Chris Forbes std::swap(pFence->submissions, pQueue->untrackedSubmissions); 4386651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4387651d92815dfff917308137bb67aacccc4f60df86Chris Forbes pFence->queues.insert(pQueue->queue); 4388cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_INFLIGHT; 4389651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4390651d92815dfff917308137bb67aacccc4f60df86Chris Forbes pQueue->lastFences.push_back(pFence->fence); 4391b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4392b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4393b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic void markCommandBuffersInFlight(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 4394b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VkFence fence) { 4395a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes auto pQueue = getQueueNode(my_data, queue); 4396a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes if (pQueue) { 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 43985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 43995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 4400b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Add cmdBuffers to the global set and increment count 4401b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, submit->pCommandBuffers[i]); 4402a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(secondaryCmdBuffer); 4404b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pSubCB = getCBNode(my_data, secondaryCmdBuffer); 4405b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pSubCB->in_use.fetch_add(1); 44065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 4408b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_add(1); 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4414e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 44165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 44175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 442027c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4421414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 44225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 44235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 44255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 44285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 44290a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 44300a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 44310a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 44320a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4433414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 4434414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "set, but has been submitted 0x%" PRIxLEAST64 " times.", 44350a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 44360a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 44385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 44395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 44405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 44415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool causeReported = false; 44425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedSets.empty()) { 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->destroyedSets) 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4450414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 44515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) destroyed: %s", 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->updatedSets.empty()) { 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 44575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->updatedSets) 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4463414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 44645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) updated: %s", 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedFramebuffers.empty()) { 44695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream fb_string; 44705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto fb : pCB->destroyedFramebuffers) 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_string << " " << fb; 44725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4476414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because it had the following " 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "referenced framebuffers destroyed: %s", 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), fb_string.str().c_str()); 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This is defensive programming to make sure an error is 44825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // flagged if we hit this INVALID cmd buffer case and none of the 44835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // above cases are hit. As the number of INVALID cases grows, this 44845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // code should be updated to seemlessly handle all the cases. 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!causeReported) { 44865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 44875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4489414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid due to an unknown cause. Validation " 44905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "should " 44915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "be improved to report the exact cause.", 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer)); 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4498414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You must call vkEndCommandBuffer() on CB 0x%" PRIxLEAST64 " before this call to vkQueueSubmit()!", 44995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 45005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4505da8f07baf262972eb3e719fa07b073c180dff157Chris Forbesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 4507da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes bool skipCall = validateAndIncrementResources(dev_data, pCB); 45085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 45095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 45105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 4511da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes skipCall |= validateAndIncrementResources(dev_data, pSubCB); 45124c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 45134c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 45145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 45155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4516414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 45175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 4518414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 45194c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 45205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 45215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 45225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pCB); 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 45275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // on device 45285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferSimultaneousUse(dev_data, pCB); 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 453281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbesstatic bool 4533651d92815dfff917308137bb67aacccc4f60df86Chris ForbesValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) 453481c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes{ 4535e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 453681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4537651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4538cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_INFLIGHT) { 4539a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4540651d92815dfff917308137bb67aacccc4f60df86Chris Forbes (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 4541651d92815dfff917308137bb67aacccc4f60df86Chris Forbes "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); 4542a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 454381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4544cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes else if (pFence->state == FENCE_RETIRED) { 4545a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4546651d92815dfff917308137bb67aacccc4f60df86Chris Forbes reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4547414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 4548651d92815dfff917308137bb67aacccc4f60df86Chris Forbes reinterpret_cast<uint64_t &>(pFence->fence)); 4549a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 45505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 455181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 455281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes return skipCall; 455381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes} 455481c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4555651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 455681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL 455781c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 455881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes bool skipCall = false; 455981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 456081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 456181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 456281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4563651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 4564651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 4565651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skipCall |= ValidateFenceForSubmit(dev_data, pFence); 456681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4567d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes if (skipCall) { 4568d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 4569d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes } 4570d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes 45711344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 45721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 45731344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 4574651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4575651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // Mark the fence in-use. 4576651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4577651d92815dfff917308137bb67aacccc4f60df86Chris Forbes SubmitFence(pQueue, pFence); 4578651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4579651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4580651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // If a fence is supplied, all the command buffers for this call will be 4581651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // delimited by that fence. Otherwise, they go in the untracked portion of 4582651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // the queue, and may end up being delimited by a fence supplied in a 4583651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // subsequent submission. 4584651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto & submitTarget = pFence ? pFence->submissions : pQueue->untrackedSubmissions; 4585651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 45865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 45870a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 45885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 45905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 45915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 459201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pWaitSemaphores[i]; 459301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 459441bb23666442c59912c630f85db04ce1a052f3efTobin Ehlis semaphoreList.push_back(semaphore); 459501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 459601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 459701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 4598da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_add(1); 45991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 46001344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 46011344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 46021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4603414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 46041344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 46051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 460601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkQueue other_queue = pSemaphore->queue; 46071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 46081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 46091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis processed_other_queues.insert(other_queue); 46101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 461401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pSignalSemaphores[i]; 461501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 461601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 46171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis semaphoreList.push_back(semaphore); 461801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 46191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 46201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 46211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4622414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 4623414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 46241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 4625da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes reinterpret_cast<uint64_t &>(pSemaphore->queue)); 46261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 462701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = true; 462801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->queue = queue; 4629da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_add(1); 46301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46310a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 46325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4633651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4634da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes std::vector<VkCommandBuffer> cbs; 4635da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 4637971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 4638971020aec6166f20a12a833ebd003e0193f4160aChris Forbes skipCall |= ValidateCmdBufImageLayouts(dev_data, pCBNode); 46391344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 4640da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(submit->pCommandBuffers[i]); 4641651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto secondaryCmdBuffer : pCBNode->secondaryCommandBuffers) { 4642da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(secondaryCmdBuffer); 4643651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4644651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 46451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 4646da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes skipCall |= validatePrimaryCommandBufferState(dev_data, pCBNode); 46471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 46481344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 46491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(); 46501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 46521344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(queue); 46531344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 4654d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto &function : pCBNode->queryUpdates) { 4655d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skipCall |= function(queue); 4656d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 46571344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4659da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 4660da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes submitTarget.emplace_back(cbs, semaphoreList); 46615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4662b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine markCommandBuffersInFlight(dev_data, queue, submitCount, pSubmits, fence); 4663b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4664e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 46655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 46665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 467089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 467189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 46725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 4675b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 46765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 46770a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 46785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 468189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 468289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 46835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 46865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 46875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 46885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 46905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 46915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4692b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 4693e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves freeMemObjInfo(my_data, device, mem, false); 46940a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 46950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 4696b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 46975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 46985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4700e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 4701e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 47025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 47047c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 47055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 47065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 47075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 47105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 471157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = mem_element->second.get(); 47125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 471357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->memRange.size != 0) { 47145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 47155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 4716414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 47175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 47205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 472157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (offset >= mem_info->allocInfo.allocationSize) { 47225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 47235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 472457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 472557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, 472657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis offset, mem_info->allocInfo.allocationSize, mem_info->allocInfo.allocationSize); 47275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 472957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if ((offset + size) > mem_info->allocInfo.allocationSize) { 473057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis skipCall = 473157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 473257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 473357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64, offset, 473457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis size + offset, mem_info->allocInfo.allocationSize); 47355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 47395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4741e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 474257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 474357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 474457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->memRange.offset = offset; 474557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->memRange.size = size; 47465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4749e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 4750e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 475157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 475257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 475357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (!mem_info->memRange.size) { 47545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 47555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 47565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 4757414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 47585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 475957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->memRange.size = 0; 476057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->pData) { 476157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis free(mem_info->pData); 476257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pData = 0; 47635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 47665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 47695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4770b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 477157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 477257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 477357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pDriverData = *ppData; 477457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis uint32_t index = mem_info->allocInfo.memoryTypeIndex; 4775b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 477657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pData = 0; 47775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 477957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis size = mem_info->allocInfo.allocationSize; 47805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 478257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pData = malloc(2 * convSize); 478357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis memset(mem_info->pData, NoncoherentMemoryFillValue, 2 * convSize); 478457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis *ppData = static_cast<char *>(mem_info->pData) + (convSize / 2); 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4788a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 4789a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// a fence being waited on should not already be signalled and 4790a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 479149f6132af865afd5b7f413c91125971ac97c135aChris Forbesstatic inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { 4792e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 47939b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes 479449f6132af865afd5b7f413c91125971ac97c135aChris Forbes auto pFence = getFenceNode(dev_data, fence); 47959b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes if (pFence) { 4796cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_UNSIGNALED) { 4797cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4798cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4799cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 4800cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes "acquire next image.", 4801cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes apiCall, reinterpret_cast<uint64_t &>(fence)); 48025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 48055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4806a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 480789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 480889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 48095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4810e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 4812b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 481449f6132af865afd5b7f413c91125971ac97c135aChris Forbes skip_call |= verifyWaitFenceState(dev_data, pFences[i], "vkWaitForFences"); 48155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4816b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 48175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 48185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 4819a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 48205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 4821414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 48225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 4823b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 48245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 4826b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, fenceCount, pFences); 48275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 48305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 4831b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 48325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4833e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 483889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 48395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 48415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 4842b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 484349f6132af865afd5b7f413c91125971ac97c135aChris Forbes skipCall = verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); 4844b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4845a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 48465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 4848a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 48495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 4850e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4851b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 4853b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skipCall |= decrementResources(dev_data, 1, &fence); 48545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4855b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4856e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 486189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 4862b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 48635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 4865b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 4866b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 4867b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 4868b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 4869b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 4870b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 48718988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes pQNode->queue = *pQueue; 4872b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 4873b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 48745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 487689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 48775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 4878e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4879b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 4880e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 48835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 488689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 4887e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4889b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 4891b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 48925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 4894b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4895e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 48985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 490189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 49025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 4904b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 49051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 49061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 4907cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (fence_pair->second.state == FENCE_INFLIGHT) { 49081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 49091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 4910cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes "Fence 0x%" PRIx64 " is in use.", (uint64_t)(fence)); 49111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 49121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 49135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4914b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 49151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 49165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 49175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 49185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 492089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 492189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 4924b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 49255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 49265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 49275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 49285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 4930414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete semaphore 0x%" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 49315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 49335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 49355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 493789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 49385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 4940b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 49415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto event_data = dev_data->eventMap.find(event); 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data != dev_data->eventMap.end()) { 49435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data->second.in_use.load()) { 49445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg( 49455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 49465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4947414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete event 0x%" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap.erase(event_data); 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4951b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 49525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 49535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 495789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 495889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 49595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 49625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 496489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 496589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 496689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 49675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 4969b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 49705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 4971971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 49725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 49735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 49745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4976e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 49775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 49785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 49795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 49805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 49815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 4982ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 4983ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 4984ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 4985ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 4986971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 4987ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 4988ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 4989ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4990ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 4991414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 4992ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 4993ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 4994ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 4995ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 4996ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4997ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4998ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4999ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5000ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5001ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5002ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5003ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5004ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5005971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5006ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5007ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5008ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 50095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 50105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5011414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 50125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 50135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5014ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5015ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 50165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 50175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5018414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 50195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5020ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5021ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5022ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5023ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5024414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 5025ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5026ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 50275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5030b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 50315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 50325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 50335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5037e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5038e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 50398718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 50408718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 50415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 50425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 5043414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 50445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 50458718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node->in_use.load()) { 50465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 50475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5048414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 50495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 50525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 505447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 505547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 505647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 505747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 5058414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Buffer 0x%" PRIx64 " is aliased with image 0x%" PRIx64, object_handle, 505947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 506047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } else { 506147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 5062414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Image 0x%" PRIx64 " is aliased with buffer 0x%" PRIx64, object_handle, 506347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 506447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 506547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 506647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 506747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 506847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 506947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski bool skip_call = false; 507047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 507147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (auto range : ranges) { 507247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) < 507347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 507447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 507547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) > 507647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 507747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 507847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 507947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 508047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return skip_call; 508147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 508247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 508347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic MEMORY_RANGE insert_memory_ranges(uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 508447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges) { 508547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski MEMORY_RANGE range; 508647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 508747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.memory = mem; 508847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 508947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 509047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.push_back(range); 509147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return range; 509247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 509347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 509447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic void remove_memory_ranges(uint64_t handle, VkDeviceMemory mem, vector<MEMORY_RANGE> &ranges) { 509547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (uint32_t item = 0; item < ranges.size(); item++) { 509647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((ranges[item].handle == handle) && (ranges[item].memory == mem)) { 509747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.erase(ranges.begin() + item); 509847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski break; 509947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 510047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 510147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 510247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 510389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 510489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 51055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5106e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5107b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5108e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!validateIdleBuffer(dev_data, buffer) && !skipCall) { 5109b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 51105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 5111b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 51125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 511347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory binding and range information for buffer 51148718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 51158718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buff_it != dev_data->bufferMap.end()) { 511657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, buff_it->second.get()->mem); 511757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 511857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis remove_memory_ranges(reinterpret_cast<uint64_t &>(buffer), buff_it->second.get()->mem, mem_info->bufferRanges); 511947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 512047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 51218718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis dev_data->bufferMap.erase(buff_it); 512247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 51235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 512589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 512689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 51275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 5129b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 51305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 51315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 51325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 51335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 513689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 51375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5138e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 513947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (!skipCall) { 51405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 514147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 51425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5143b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 514447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &imageEntry = dev_data->imageMap.find(image); 514547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (imageEntry != dev_data->imageMap.end()) { 514647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory mapping, bindings and range references for image 51476d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, imageEntry->second.get()->mem); 514857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 51496d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis remove_memory_ranges(reinterpret_cast<uint64_t &>(image), imageEntry->second.get()->mem, mem_info->imageRanges); 515047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 515157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->image = VK_NULL_HANDLE; 515247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 515358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 515447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski dev_data->imageMap.erase(imageEntry); 51555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 51585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 51605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 51625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51654261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinskistatic bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, 51664261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski const char *funcName) { 51674261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski bool skip_call = false; 51684261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski if (((1 << mem_info->allocInfo.memoryTypeIndex) & memory_type_bits) == 0) { 51694261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 51704261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, MEMTRACK_INVALID_MEM_TYPE, "MT", 51714261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " 51724261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "type (0x%X) of this memory object 0x%" PRIx64 ".", 51734261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski funcName, memory_type_bits, mem_info->allocInfo.memoryTypeIndex, 51744261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski reinterpret_cast<const uint64_t &>(mem_info->mem)); 51754261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski } 51764261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski return skip_call; 51774261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski} 51784261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski 517989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 518089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 518158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5183b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 51845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 51855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 5186e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = 518794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 51888718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 51898718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 51908718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->mem = mem; 51915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 519294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 519347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 519447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 519557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 519657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 519747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 519857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis insert_memory_ranges(buffer_handle, mem, memoryOffset, memRequirements, mem_info->bufferRanges); 519957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis skipCall |= validate_memory_range(dev_data, mem_info->imageRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 52004261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski skipCall |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "BindBufferMemory"); 520147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 520247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 52032c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 52042c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 52052c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52062c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 52072c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5208414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5209414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 52102c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 52112c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 52122c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52132c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 52148718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; 52152c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & (VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT)) { 5216b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment) != 0) { 52172c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52182c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 52192c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5220414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5221414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minTexelBufferOffsetAlignment 0x%" PRIxLEAST64, 5222b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment); 52232c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52242c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52252c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT) { 5226b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 5227b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 52282c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52292c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 52302c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 5231414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5232414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 5233b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 52342c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52352c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52362c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_STORAGE_BUFFER_BIT) { 5237b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 5238b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 52392c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52402c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 52412c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 5242414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5243414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 5244b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 52452c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52462c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52480a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5249b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5250e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 525158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 52525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 525689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 525789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 52585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 52605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 52615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 52625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 526489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 526589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 52665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 52685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 52695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 52705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5271593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 527289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 527389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 52745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 52755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 52765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 527989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 528089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5281918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5282918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5283b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5284918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5285b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5286918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5287918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 52885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 529089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 529189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 52925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 529689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 529789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 52985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 52995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 53005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 53015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 530389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 530489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 53055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 53065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 53075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 530989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 531089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 53115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 53135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 53145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 531689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 531789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 53185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 53205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5322bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 5323bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 5324bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 5325bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 5326a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbesstatic bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 5327bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5328bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 5329bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 5330bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 5331bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 5332bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 5333bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 5334bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 5335414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use.", action, 5336bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 5337bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5338bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5339bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5340bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 5341a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 5342bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 5343a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action) { 5344bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5345a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 5346a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 5347a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 5348bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5349bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5350bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5351bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 53525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5353a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic void clearCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool) { 5354a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 5355a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 5356a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes } 5357a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes} 5358a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 535989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 536089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 53615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5363b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5364c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 53655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 5366bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto cb_pair = dev_data->commandBufferMap.find(pCommandBuffers[i]); 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 5368bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (cb_pair != dev_data->commandBufferMap.end()) { 5369a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, cb_pair->second, "free"); 5370c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 5371c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 5372c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes lock.unlock(); 5373c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 5374c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes if (skip_call) 5375c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes return; 5376c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 5377c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 5378c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 5379c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes lock.lock(); 5380c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 5381c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes for (uint32_t i = 0; i < commandBufferCount; i++) { 5382c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes auto cb_pair = dev_data->commandBufferMap.find(pCommandBuffers[i]); 5383c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes // Delete CB information structure, and remove from commandBufferMap 5384c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes if (cb_pair != dev_data->commandBufferMap.end()) { 5385a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes dev_data->globalInFlightCmdBuffers.erase(cb_pair->first); 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 53877bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes resetCB(dev_data, cb_pair->second->commandBuffer); 53887bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes delete cb_pair->second; 5389bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->commandBufferMap.erase(cb_pair); 53905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 5393c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes pPool->commandBuffers.remove(pCommandBuffers[i]); 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 5396b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 539989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 540089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 540189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 54055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5407b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 54105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 541489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 541589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 54165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 54195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5420b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 54225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 542789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 542889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 54295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5431b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 5433a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 5434a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes skipCall |= checkCommandBuffersInFlight(dev_data, pPool, "destroy command pool with"); 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5436b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5438a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (skipCall) 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5441a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 5442a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes 5443a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes lock.lock(); 5444a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap 5445a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 5446a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cb : pPool->commandBuffers) { 5447a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 5448a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto del_cb = dev_data->commandBufferMap.find(cb); 5449a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes delete del_cb->second; // delete CB info structure 5450a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer 5451a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes } 5452a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->commandPoolMap.erase(commandPool); 5453a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes lock.unlock(); 54545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 545689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 545789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 54585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5460400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 54611ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 5462a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 5463a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes skipCall |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with"); 54641ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 5465a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes 5466a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (skipCall) 54675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5469a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 54725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 54731ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.lock(); 5474a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 5475a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmdBuffer : pPool->commandBuffers) { 5476a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes resetCB(dev_data, cmdBuffer); 54775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54781ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 54795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 548389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 54845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5486b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 5488df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 5489090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence && pFence->state == FENCE_INFLIGHT) { 5490090da73358f71ba026e2474a822fecf55267d166Chris Forbes skipCall |= 5491a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 5492a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 5493cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes "Fence 0x%" PRIx64 " is in use.", reinterpret_cast<const uint64_t &>(pFences[i])); 54945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5496b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5497090da73358f71ba026e2474a822fecf55267d166Chris Forbes 5498090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (skipCall) 5499090da73358f71ba026e2474a822fecf55267d166Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 5500090da73358f71ba026e2474a822fecf55267d166Chris Forbes 5501090da73358f71ba026e2474a822fecf55267d166Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 5502090da73358f71ba026e2474a822fecf55267d166Chris Forbes 5503090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (result == VK_SUCCESS) { 5504090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.lock(); 5505090da73358f71ba026e2474a822fecf55267d166Chris Forbes for (uint32_t i = 0; i < fenceCount; ++i) { 5506090da73358f71ba026e2474a822fecf55267d166Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 5507090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence) { 5508090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->state = FENCE_UNSIGNALED; 5509090da73358f71ba026e2474a822fecf55267d166Chris Forbes // TODO: these should really have already been enforced on 5510090da73358f71ba026e2474a822fecf55267d166Chris Forbes // INFLIGHT->RETIRED transition. 5511090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->queues.clear(); 5512090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->priorFences.clear(); 5513090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 5514090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 5515090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.unlock(); 5516090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 5517090da73358f71ba026e2474a822fecf55267d166Chris Forbes 55185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 552189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 552289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 55235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5524b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(framebuffer); 55265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 552704861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis for (auto cb : fbNode->second->referencingCmdBuffers) { 55285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cbNode = dev_data->commandBufferMap.find(cb); 55295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cbNode != dev_data->commandBufferMap.end()) { 55305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set CB as invalid and record destroyed framebuffer 55315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->state = CB_INVALID; 55325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->destroyedFramebuffers.insert(framebuffer); 55335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5535f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes dev_data->frameBufferMap.erase(fbNode); 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5537b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 554189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 554289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 55435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 5545b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 55477bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes // TODO: leaking all the guts of the renderpass node here! 55485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 555089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 555189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 555347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 555447892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 55555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5557b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 55598718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_NODE>(new BUFFER_NODE(pCreateInfo)))); 55605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 556489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 556589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 55665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 55685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5569b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55702f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis dev_data->bufferViewMap[*pView] = unique_ptr<VkBufferViewCreateInfo>(new VkBufferViewCreateInfo(*pCreateInfo)); 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 55725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 55730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_buffer_usage_flags(dev_data, pCreateInfo->buffer, 5574e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, 55755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 558089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 558189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 55825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 558347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 558447892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 55855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5587b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 55895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 55905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 55916d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, unique_ptr<IMAGE_NODE>(new IMAGE_NODE(pCreateInfo)))); 55925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 55935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 55945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 55955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 5600b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 56015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56026d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 56036d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 56045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 56055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 56075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 56096d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->levelCount = image_node->createInfo.mipLevels - range->baseMipLevel; 56105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 56136d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->layerCount = image_node->createInfo.arrayLayers - range->baseArrayLayer; 56145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 56195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 56205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 56215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 5622b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 56235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 56255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 56266d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 56276d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 56285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 56296d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *levels = image_node->createInfo.mipLevels - range.baseMipLevel; 56305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 56326d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *layers = image_node->createInfo.arrayLayers - range.baseArrayLayer; 56335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 563789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 563889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 5639bb6624cb996175d8945190886a200e720b3871efChris Forbes bool skipCall = false; 5640bb6624cb996175d8945190886a200e720b3871efChris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 56415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5642bb6624cb996175d8945190886a200e720b3871efChris Forbes { 5643bb6624cb996175d8945190886a200e720b3871efChris Forbes // Validate that img has correct usage flags set 5644bb6624cb996175d8945190886a200e720b3871efChris Forbes std::lock_guard<std::mutex> lock(global_lock); 5645bb6624cb996175d8945190886a200e720b3871efChris Forbes skipCall |= validate_image_usage_flags(dev_data, pCreateInfo->image, 5646bb6624cb996175d8945190886a200e720b3871efChris Forbes VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 5647bb6624cb996175d8945190886a200e720b3871efChris Forbes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 5648bb6624cb996175d8945190886a200e720b3871efChris Forbes false, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 5649bb6624cb996175d8945190886a200e720b3871efChris Forbes } 5650bb6624cb996175d8945190886a200e720b3871efChris Forbes 5651bb6624cb996175d8945190886a200e720b3871efChris Forbes if (!skipCall) { 5652bb6624cb996175d8945190886a200e720b3871efChris Forbes result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 5653bb6624cb996175d8945190886a200e720b3871efChris Forbes } 5654bb6624cb996175d8945190886a200e720b3871efChris Forbes 56555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5656b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 56572c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis dev_data->imageViewMap[*pView] = unique_ptr<VkImageViewCreateInfo>(new VkImageViewCreateInfo(*pCreateInfo)); 56582c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[*pView].get()->subresourceRange, pCreateInfo->image); 56595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5660bb6624cb996175d8945190886a200e720b3871efChris Forbes 56615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 566489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 566589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 56665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 56685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5669b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5670a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 56718988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes fence_node.fence = *pFence; 5672a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 5673cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; 56745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 567989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 568089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 56815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 56835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 568789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 56885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 56905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 569389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 56945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 56965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 570089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 57015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 57035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57063d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 57073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 57083d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 57093d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 57103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 57113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 57123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 57133d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 57143d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 57153d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 57163d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 57173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 57183d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 57193d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 57203d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 57213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 57223d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 57233d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 57243d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 57253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 57263d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 572789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 572889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 572989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 573089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 57315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 57325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 57335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 57355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 57365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 5737e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 57385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 57395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 57405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5743b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 57445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 5746ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5747ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 574816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeNode[i]->renderPass = getRenderPass(dev_data, pCreateInfos[i].renderPass); 57494a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes pPipeNode[i]->pipelineLayout = getPipelineLayout(dev_data, pCreateInfos[i].layout); 575067220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 57515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 57525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5754e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 5755b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 57575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5758b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 57595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 57615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 57625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5763b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57665188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 57675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5768b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 57705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 577489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 577589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 577689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 577789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 5779e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 57805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 57825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 57835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5786b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 57875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 57895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 57915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5792ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 57934a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes pPipeNode[i]->pipelineLayout = getPipelineLayout(dev_data, pCreateInfos[i].layout); 5794ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 57955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 5797396244fbebb3dca48be8e37a828fb1034f8c410cChris Forbes skipCall |= !validate_compute_pipeline(dev_data->report_data, pPipeNode[i], 5798396244fbebb3dca48be8e37a828fb1034f8c410cChris Forbes &dev_data->phys_dev_properties.features, 5799396244fbebb3dca48be8e37a828fb1034f8c410cChris Forbes dev_data->shaderModuleMap); 58005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 58015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5803e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 5804b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 58055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 58065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5807b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 58085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 58095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 58105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 58115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5812b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 58135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 58145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 58155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 58165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 58175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5818b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 58195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 58205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 582489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 582589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 58265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 58285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5829b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5830cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 58315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 583589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 583689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 583789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 58385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 58405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 58415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 5842b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5843cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = 5844cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis new cvdescriptorset::DescriptorSetLayout(dev_data->report_data, pCreateInfo, *pSetLayout); 58455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58499e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 58509e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 58519e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 58529e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 58539e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 58545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 58559e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 58569e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 58579e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 58589e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 58599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 58609e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 58619e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58629e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with offset %u and size %u that " 58639e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 58649e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset, size, maxPushConstantsSize); 58659e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 58669e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58679e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 58689e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 58699e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, offset, size, maxPushConstantsSize); 58709e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 58719e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58729e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 58739e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58749e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58759e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 58769e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 58779e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 58789e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 58799e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58809e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 58819e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 58829e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, size); 58839e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 58849e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 58859e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58869e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 58879e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 58889e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 58899e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 58909e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58919e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 58929e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58939e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58949e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 58959e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 58969e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 58979e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58989e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 58999e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "offset %u. Offset must be a multiple of 4.", 59009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset); 59019e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 59029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 59039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 59049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "offset %u. Offset must be a multiple of 4.", 59059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, offset); 59069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 59079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 59089e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 59099e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 59125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 591489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 591589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 59175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59189e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 59195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 59205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 59219e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 59229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 59239e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 59249e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 59259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 59269e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 59299e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (!skipCall) { 59309e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t i, j; 59319e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 59329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 59339e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 59349e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 59359e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 59369e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 59379e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 59389e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 5939a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 59409e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 59419e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 59429e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz i, minA, maxA, j, minB, maxB); 59439e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59449e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5947f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 5948f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes if (skipCall) 5949f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 5950f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 59515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 59525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5953b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 59555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); 5956f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes plNode.setLayouts.resize(pCreateInfo->setLayoutCount); 59575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 59585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; 5959addeafba8720251f59f73dc2200bd512ae498bd5Chris Forbes plNode.setLayouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); 59605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 59635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; 59645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 596989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 597089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 597189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 59765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 5977414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 59815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 59825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 59835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 59845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 59855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5987b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 59895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 59915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 59925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 599689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 599789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 59985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6001b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 60035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60062c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// Ensure the pool contains enough descriptors and descriptor sets to satisfy 6007789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// an allocation request. Fills common_data with the total number of descriptors of each type required, 6008789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// as well as DescriptorSetLayout ptrs used for later update. 60097f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlisstatic bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 60107f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData *common_data) { 60117e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All state checks for AllocateDescriptorSets is done in single function 6012e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehlis return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); 60137e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis} 60147e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Allocation state was good and call down chain was made so update state based on allocating descriptor sets 60157e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlisstatic void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 60167f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis VkDescriptorSet *pDescriptorSets, 60177f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis const cvdescriptorset::AllocateDescriptorSetsData *common_data) { 60187e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All the updates are contained in a single cvdescriptorset function 60192c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, 6020b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis &dev_data->setMap, dev_data); 60212c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes} 60222c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 602389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 602489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 60255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6026b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 60277f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); 60287f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); 6029b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6030d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 60317e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis if (skip_call) 60325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6033d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 60345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 60356511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 60365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6037b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 60387f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); 6039b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6043cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Verify state before freeing DescriptorSets 6044cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6045cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6046cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skip_call = false; 6047cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // First make sure sets being destroyed are not currently in-use 6048cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6049cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); 6050cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6051cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_node = getPoolNode(dev_data, pool); 6052cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis if (pool_node && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_node->createInfo.flags)) { 6053cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Can't Free from a NON_FREE pool 6054cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6055cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis reinterpret_cast<uint64_t &>(pool), __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 6056cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 6057cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 6058cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6059cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis return skip_call; 6060cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 6061cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Sets have been removed from the pool so update underlying state 6062cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6063cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6064cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_state = getPoolNode(dev_data, pool); 6065cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Update available descriptor sets in pool 6066cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableSets += count; 6067cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6068cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 6069cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 6070cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis auto set_state = dev_data->setMap[descriptor_sets[i]]; 6071cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis uint32_t type_index = 0, descriptor_count = 0; 6072cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t j = 0; j < set_state->GetBindingCount(); ++j) { 6073cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis type_index = static_cast<uint32_t>(set_state->GetTypeFromIndex(j)); 6074cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis descriptor_count = set_state->GetDescriptorCountFromIndex(j); 6075cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; 6076cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6077cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis freeDescriptorSet(dev_data, set_state); 6078cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->sets.erase(set_state); 6079cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6080cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 60815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 608289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 608389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 60845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6086b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6087cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skipCall = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6088b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6089e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 60905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 60915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 60925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6093b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6094cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6095b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60996b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// TODO : This is a Proof-of-concept for core validation architecture 61006b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// Really we'll want to break out these functions to separate files but 61016b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// keeping it all together here to prove out design 61026b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() 61036b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 61046b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 61056b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 61066b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // First thing to do is perform map look-ups. 61076b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets 61086b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // so we can't just do a single map look-up up-front, but do them individually in functions below 61096b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis 61106b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Now make call(s) that validate state, but don't perform state updates in this function 61116b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the 61126b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // namespace which will parse params and make calls into specific class instances 6113104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, 6114104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis descriptorCopyCount, pDescriptorCopies); 61156b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 61166b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() 61176b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 61186b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 61196b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 6120104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 61216b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 61226b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 61235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 612489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 612589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 612689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 61276b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Only map look-up at top level is for device-level layer_data 61285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6129b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61306b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 61316b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 6132b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 61336b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis if (!skip_call) { 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 61355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 61366b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis lock.lock(); 61376b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Since UpdateDescriptorSets() is void, nothing to check prior to updating state 61386b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 61396b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 61405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 614389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 614489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6148b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6149cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, pCreateInfo->commandPool); 6150cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes 6151cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (pPool) { 615272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 61535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 6154cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes pPool->commandBuffers.push_back(pCommandBuffer[i]); 61555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 61575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61630a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6164b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 616989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 617089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 6171e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6173b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 61765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 61775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 6178a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 6179a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= 6180a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6181a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 6182414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Calling vkBeginCommandBuffer() on active CB 0x%p before it has completed. " 6183a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 6184a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 61855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6186a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 61875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 61895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 61905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 61915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6194414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 61955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6198400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 61995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 62005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6202414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 62035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6205400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, 6209414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 62105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "valid framebuffer parameter is specified.", 62115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 6214f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = getFramebuffer(dev_data, pInfo->framebuffer); 6215f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (framebuffer) { 6216f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes VkRenderPass fbRP = framebuffer->createInfo.renderPass; 62175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, fbRP, pInfo->renderPass, errorString)) { 6218400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 62195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 62235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command " 6224414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 6225414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 62265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer), (uint64_t)(pInfo->renderPass), 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->framebuffer), (uint64_t)(fbRP), errorString.c_str()); 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 6230f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes framebuffer->referencingCmdBuffers.insert(pCB->commandBuffer); 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6235b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 62365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 62375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 62385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 62395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6240414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "support precise occlusion queries.", 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 624716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pInfo->renderPass); 624816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 624916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (pInfo->subpass >= renderPass->pCreateInfo->subpassCount) { 62505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 62525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6253414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 62545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that is less than the number of subpasses (%d).", 625516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes (void *)commandBuffer, pInfo->subpass, renderPass->pCreateInfo->subpassCount); 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 62615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6264414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Cannot call Begin on CB (0x%" PRIxLEAST64 62655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 62665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 62677651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else if (CB_RECORDED == pCB->state || (CB_INVALID == pCB->state && CMD_END == pCB->cmds.back().type)) { 62685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 6269cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 6270cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 62715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6274414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 6275414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 62775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 62805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 62825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 62835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 62855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 62865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 6287888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 6288888e1d268098177fde4a2263e3d7b7cc415f1debMark Young if ((pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 6289888e1d268098177fde4a2263e3d7b7cc415f1debMark Young (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 629016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeRenderPass = getRenderPass(dev_data, pCB->beginInfo.pInheritanceInfo->renderPass); 6291888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->activeSubpass = pCB->beginInfo.pInheritanceInfo->subpass; 6292888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->framebuffers.insert(pCB->beginInfo.pInheritanceInfo->framebuffer); 6293888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 62945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 6298414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB 0x%p!", (void *)commandBuffer); 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6300b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6301e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) { 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6305400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 63065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 630989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 6310e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 63125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6313b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6316fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 6317fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 6318fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 6319fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop skipCall |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 6320fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 63217651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); 63225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 63235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 63245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 6325414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 63265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(query.pool), query.index); 63275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6329e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6330b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 6332b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 63335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 63345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 63355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 63365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 63375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 63385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 63415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6342b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 634689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 634789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6348bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6350b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 6353cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 6354cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 6355bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6356bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6357414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 6358bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 6359bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6361a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, pCB, "reset"); 6362b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6363bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 63665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6367b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6368a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes dev_data->globalInFlightCmdBuffers.erase(commandBuffer); 63695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 6370b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 637493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 637589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 637689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 6377e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6379b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 63835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 63845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 63855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 63865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 6387414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 6388ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass->renderPass); 63895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 63925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 639372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 63945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 63953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 63965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 63985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 6399414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 64005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6402b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6403e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 640789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 640889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 6409e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6411b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 64155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 64165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 64175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 64185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6419b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6420e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 64225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 642489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 642589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 6426e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6428b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 64325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 64335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 64355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6436b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6437e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 644189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 6442a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 64435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6444b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6447a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 6449a27508babf63d50aea75883a3702979193c23683Mark Young 6450a27508babf63d50aea75883a3702979193c23683Mark Young PIPELINE_NODE *pPipeTrav = getPipeline(dev_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 6451a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 6452a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 6453a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 6454386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 6455a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 6456a27508babf63d50aea75883a3702979193c23683Mark Young } else { 6457a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 6458a27508babf63d50aea75883a3702979193c23683Mark Young } 64595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6460b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6461a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 64635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 646589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 646689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 6467e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6469b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 64735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6475b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6476e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 648189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 6482e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 64883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 64895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6490b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6491e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 649589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 649689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 6497e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6499b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6505b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6506e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 65085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 651089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 651189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 6512e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6514b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 65185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 65195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6520b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6521e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 65225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 65235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 652589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 652689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 6527e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 65285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6529b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 65335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 65345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6535b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6536e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 65375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 65385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 654089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 654189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 6542e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 65435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6544b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 65485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 65495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6550b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6551e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 65525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 65535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 655589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 655689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 655789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 655889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 6559e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 65605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6561b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 6565787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 6566787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 6567787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 6568787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 6569dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { 657072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 6571dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); 6572dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes } 657371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 6574787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 6575397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 6576787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 657771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pSet); 65789d17becd811b49e1ecf91a02eee22f9cf7cbc026Tobin Ehlis pSet->BindCommandBuffer(pCB); 657972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipelineLayout = layout; 658071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pSet; 6581787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 6582787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6583414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DS 0x%" PRIxLEAST64 " bound on pipeline %s", 6584787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 6585397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 6586787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 6587787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 6588787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 6589414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 6590787f29d93dee194c015789cf61c079504c980572Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 6591787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 6592787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6593787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 6594787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, layout, i + firstSet, errorString)) { 6595787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6596e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6597e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 6598e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 6599414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 6600e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 6601787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6602dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6603dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes auto setDynamicDescriptorCount = pSet->GetDynamicDescriptorCount(); 6604dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6605dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); 6606dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6607dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (setDynamicDescriptorCount) { 6608787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 6609dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { 6610787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= 6611787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6612787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6613787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 6614414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 6615787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 6616787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 6617397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 6618787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 6619787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 6620787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 6621787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 6622397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 6623397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 6624787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6625787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6626b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 6627787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 6628787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6629787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6630787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 6631787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6632414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 6633787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6634b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 6635787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6636787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 6637397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 6638787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6639787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6640b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 6641787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 6642787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6643787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6644787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 6645787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6646414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 6647787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6648b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 66495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6650787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 66515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6653dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6654dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = 6655dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, 6656dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); 6657787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 6658dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes totalDynamicDescriptors += setDynamicDescriptorCount; 6659dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 66605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6662787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 6663787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6664787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6665414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS 0x%" PRIxLEAST64 " that doesn't exist!", 6666787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 66675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 666872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 666972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 667072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 667172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 667272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 667371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], 667471511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis layout, i, errorString)) { 667572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg( 667672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 667772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 667872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 6679414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DescriptorSetDS 0x%" PRIxLEAST64 6680414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 668172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 668272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 668372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 668472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 668572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 668672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 668772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 668872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 668971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, layout, lastSetIndex, errorString)) { 669071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto old_set = oldFinalBoundSet->GetSet(); 669172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= 669272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 669371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, 6694414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DescriptorSetDS 0x%" PRIxLEAST64 6695414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 669672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 6697414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 669871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis reinterpret_cast<uint64_t &>(old_set), lastSetIndex, 669972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 670072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 670172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6705787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 6706787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 6707787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6708787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 6709787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 6710787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 6711787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 6712787f29d93dee194c015789cf61c079504c980572Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 6713787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 67145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6718b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6719e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 67205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 67225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 672489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 672589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 6726e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6728593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 6729b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 67320a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 673372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 673472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6735e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindIndexBuffer()"); }; 673672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 6737593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 67385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 67395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 67425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 67435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 67445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 67455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 67465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 67475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 67485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 67495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 67515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 67525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 6753414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 67545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkIndexType(indexType)); 67555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6756593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->status |= CBSTATUS_INDEX_BUFFER_BOUND; 67575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6758b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6759e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 67605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 67615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 67645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 67655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 67665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 67675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 67695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 67705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6773e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 67745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 677589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 677689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 677789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 6778e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6780593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 6781b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6782593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 6783593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6784593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 6785593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory mem; 6786593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)pBuffers[i], VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 6787593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 6788e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindVertexBuffers()"); }; 678972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 67905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6791593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis addCmd(dev_data, cb_data->second, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 6792593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis updateResourceTracking(cb_data->second, firstBinding, bindingCount, pBuffers); 67935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 67955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6796b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6797e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6801b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 6802e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 68047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 68057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 68062c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_data = getImageViewData(dev_data, imageView); 68072c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (!iv_data) 68085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 68092c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis VkImage image = iv_data->image; 68107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 68117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skip_call |= 68120a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 6813e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 68147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 6815e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 68167a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 68177a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 68187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 68197a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 68207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 68210a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skip_call |= get_mem_binding_from_object(dev_data, (uint64_t)buffer, 68227a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 6823e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 68247a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true); 6825e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 68267a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 68277a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 68305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 683289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 683389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 6834e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6836b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 68405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 6841e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 68427a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 6846414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW]++); 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6848e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 68525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6853b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6854e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 685889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 685989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6862e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6863b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 68675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 6868e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 68697a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 68725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 6873414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6875e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6880b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6881e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 68835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 688689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 688789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 68885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6889e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6890b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 68925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 68935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 68940a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndirect"); 68965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 68995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDIRECT]++; 6900e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 69017a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 69035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 69045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 6905414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6907e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 69085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 69095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); 69115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6912b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6913e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 69155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 691789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 691889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 6919e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6921b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 69235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 69245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 69250a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndexedIndirect"); 69275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 69305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED_INDIRECT]++; 6931e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 69327a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 69345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 6936414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting DS state:", 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 69385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6939e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 69415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); 69435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6944b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6945e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 694989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 6950e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6952b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 695522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 69567a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 69585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 69595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6960b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6961e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 69635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 696589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 696689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 6967e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6969b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 69715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 69720a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 69735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDispatchIndirect"); 69745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 697622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 69777a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); 69805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6981b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6982e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 69845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 698689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 698789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 6988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6990b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6991593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 6992593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &src_mem); 6993593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyBuffer"); 6994593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &dst_mem); 6995593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 6996593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyBuffer"); 6997593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 6998593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 6999593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 7000593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 7001593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 700272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 700372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7004593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyBuffer()"); }; 700572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7006593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7007593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true); 7008e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 70095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 701072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7011593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7012593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 7013593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyBuffer"); 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7015b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7016e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7020e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageSubresourceLayers subLayers, 7021e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout srcImageLayout) { 7022e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 70285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 70295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, srcImage, sub, node)) { 703108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 70385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 70395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 70405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 70445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 70465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 70475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 70485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 70495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 70525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 70535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7059e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageSubresourceLayers subLayers, 7060e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout destImageLayout) { 7061e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 70625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 70675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 70685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, destImage, sub, node)) { 707008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 70745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 70755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 70765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 70775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 70785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 70795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 70825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 70835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 70845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 70855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 70865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 70875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 70895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 70905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 70915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 70925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 70955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 709789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 709889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 709989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 7100e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7102b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7103593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 7105593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7106593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyImage"); 7107593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7108593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7109593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyImage"); 7110593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 7111593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 7112593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 7113593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7114593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 711572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7116e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7117593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyImage()", srcImage); 7118593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 7119593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->validate_functions.push_back(function); 7120593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7121593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7122e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 71235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 712472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7125593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7126593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYIMAGE, "vkCmdCopyImage()"); 7127593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyImage"); 71285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 71295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].srcSubresource, srcImageLayout); 71305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].dstSubresource, dstImageLayout); 71315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7133b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7134e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 71365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 71375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 713989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 714089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 714189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 7142e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7144b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7145593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 71465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 7147593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7148593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdBlitImage"); 7149593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7150593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7151593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdBlitImage"); 7152593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 7153593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 7154593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 7155593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7156593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7157593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 715872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7159e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7160593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdBlitImage()", srcImage); 7161593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 7162593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->validate_functions.push_back(function); 7163593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7164593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7165e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 71665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 716772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7168593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7169593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_BLITIMAGE, "vkCmdBlitImage()"); 7170593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdBlitImage"); 71715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7172b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7173e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 71755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 71765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 717889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 717989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 718089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7181e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7183b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7184593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory dst_mem, src_mem; 7185593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7186593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyBufferToImage"); 7187593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7188593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &src_mem); 7189593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyBufferToImage"); 7190593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that src buff & dst image have correct usage flags set 7191593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyBufferToImage()", 7192593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 7193593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyBufferToImage()", 7194593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 719572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 719672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7197e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7198593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7199e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 720172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7202593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyBufferToImage()"); }; 720372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7204593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7205593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 7206593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyBufferToImage"); 72075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 72085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].imageSubresource, dstImageLayout); 72095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7211b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7212e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 72145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 72155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 721789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 721889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 721989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7220e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7222b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7223593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 7224593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7225593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyImageToBuffer"); 7226593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7227593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &dst_mem); 7228593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyImageToBuffer"); 7229593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that dst buff & src image have correct usage flags set 7230593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyImageToBuffer()", 7231593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 7232593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyImageToBuffer()", 7233593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7234593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 723572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 723672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7237e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7238593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyImageToBuffer()", srcImage); 7239e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 724072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7241593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7242593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true); 7243e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 724572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7246593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7247593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 7248593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyImageToBuffer"); 72495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 72505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].imageSubresource, srcImageLayout); 72515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7253b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7254e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 72565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 72575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 725989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 726089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 7261e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7263b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 72655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 72660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7267593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdUpdateBuffer"); 7268593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that dst buff has correct usage flags set 7269593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdUpdateBuffer()", 7270593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7271593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7272593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 727372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7274e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 72755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7276e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 727872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7279593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7280593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 7281593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyUpdateBuffer"); 72825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7283b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7284e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 72865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 728889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 728989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 7290e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7292b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 72945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 72950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7296593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdFillBuffer"); 7297593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that dst buff has correct usage flags set 7298593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdFillBuffer()", 7299593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7300593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7301593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 730272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7303e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 73045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7305e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 730772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7308593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7309593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 7310593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyFillBuffer"); 73115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7312b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7313e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 731789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 731889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 731989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 7320e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7322b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 73265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 73275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 73285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 73295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 73305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 73315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 73325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 73355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 73365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 73375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandBuffer)); 73395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 7345ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->pCreateInfo; 73465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 73475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 73495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 73505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 7351e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 73525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 73535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 7354e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 73555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7358e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 73595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 73605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 73615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 73625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 73635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 73645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 73665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 73675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 73685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 73695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 73715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 73725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 73735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 73745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 73755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 73765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 73775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 73785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7382b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7383e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 73855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 738789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 738889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 738989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 7390e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7392b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 73945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7396593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearColorImage"); 7397593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 739872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7399e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7401e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 740372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7404593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7405593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 7406593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdClearColorImage"); 74075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7408b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7409e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 74115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 741389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 741489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 741589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 741689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 7417e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7419b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 74215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 74220a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7423593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearDepthStencilImage"); 7424593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 742572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7426e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7428e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 743072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7431593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7432593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 7433593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdClearDepthStencilImage"); 74345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7435b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7436e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 74385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 744189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 744289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 744389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 7444e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7446b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7447593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 7448593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7449593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdResolveImage"); 7450593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7451593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7452593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdResolveImage"); 745372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 745472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7455e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7456593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdResolveImage()", srcImage); 7457593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 7458593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->validate_functions.push_back(function); 7459593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7460593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7461e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 746372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7464593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7465593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 7466593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdResolveImage"); 74675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7468b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 74725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7474b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7475b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7476b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 7477b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 7478b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 7479b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7480b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 7481b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 7482b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 7483b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7484b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 7485b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 7486b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 748789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 748889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7489e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7491b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 74955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 74965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7497c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 7498c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 7499c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 7500b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7501b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 7502b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 75035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7504b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7505e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 750989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 751089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7511e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7513b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 75185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7519c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 7520c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 7521c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 7522b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7523b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 7524b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7526b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7527e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 75295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7531e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7532e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 7535e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 75365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 75375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 75385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 75465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 75485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 75505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 75525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 75535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 755408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 755508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 75565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 75595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 75615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 75645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 75655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 75675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 7574e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 75895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 75945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 75955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 7596e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7597e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 7598e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 7599e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 760243986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 76035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 76045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7606577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 76085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 76116044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 76135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 76145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 76155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 76195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 76205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 76215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 76225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 76235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76246044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 76295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7635e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7636e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 7637e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 76405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 76415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 76475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 76505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 76515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 76545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 76555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 76595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 76635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 76685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 76695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 76725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 76735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 76745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7676577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 76775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 76785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 76825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7687e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7688e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 7689e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 7690e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 7691e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 7695ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 76995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 77005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 77035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 77046d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 77056d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 77065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 77086d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 77095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 77105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 77115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 77125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 77135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 77145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 77155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 77165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 77175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 77185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 77205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 77215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 77225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 77235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 77245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 77285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 77305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 77315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 7733b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 7734b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 77365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 77385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 77395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 77405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 77415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 7742b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 77485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 77505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 77525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 77535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 77555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 77565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 77575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77586d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 77591d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 77601d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 77615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 77626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 77636d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis format = image_data->createInfo.format; 77646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis arrayLayers = image_data->createInfo.arrayLayers; 77656d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis mipLevels = image_data->createInfo.mipLevels; 77665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 77675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 7768170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); 7769170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (imageswap_data) { 7770b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); 7771b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 7772b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis format = swapchain_data->createInfo.imageFormat; 7773b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis arrayLayers = swapchain_data->createInfo.imageArrayLayers; 77745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 77755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 77815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 77865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7789f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 7790f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 7791f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 7792f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 77965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 77975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 77985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 77995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7800f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 7801f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 7802f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 7803f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 78045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 78065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 78075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 78085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 78095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 78105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 78155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 78165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 78175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 78185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 78205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 78225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 78235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 7826b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 7828b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 78315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 78325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 78335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 7834b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78378718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, mem_barrier->buffer); 78388718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 78398718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkDeviceSize buffer_size = 78408718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis (buffer_node->createInfo.sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO) ? buffer_node->createInfo.size : 0; 78415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 784294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 784394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 784494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 7845414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ".", 784694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 784794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 78485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 784994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 785094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7851414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 7852414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 785394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 785494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 785594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 78565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 78605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78622ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 7863b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 7864b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 7865b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 7866b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 78672ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 7868b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 7869b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 7870b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 78712ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 7872b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 7873b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 7874b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 78752ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto global_event_data = dev_data->eventMap.find(event); 7876b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (global_event_data == dev_data->eventMap.end()) { 7877b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 787827c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 787927c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 78802ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 7881b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 7882b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= global_event_data->second.stageMask; 7883b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7884b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7885b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7886c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // TODO: Need to validate that host_bit is only set if set event is called 7887c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // but set event can be called at any time. 7888c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { 7889c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7890c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine DRAWSTATE_INVALID_EVENT, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " 78914261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "using srcStageMask 0x%X which must be the bitwise " 7892c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "OR of the stageMask parameters used in calls to " 7893c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " 78944261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "used with vkSetEvent but instead is 0x%X.", 7895c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine sourceStageMask, stageMask); 7896b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7897b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 7898b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 7899b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 790089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 790189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 790289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 790389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 790489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 7905e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7907b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79102ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 79115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 7912c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->waitedEvents.insert(pEvents[i]); 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 79145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7915b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 79162ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 7917b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 79185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 79195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 79205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 79225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 79245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7928b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7929e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 79315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 793589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 793689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 793789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 793889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 793989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 7940e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7942b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7951b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7952e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 79545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7958d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { 7959d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7960d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 7961d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (pCB) { 7962d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryToStateMap[object] = value; 7963d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 7964d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 7965d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data != dev_data->queueMap.end()) { 7966d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[object] = value; 7967d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 7968d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 7969d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 7970d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 797189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 797289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 7973e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7975b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 79815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 79825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 79845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7985b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7986e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 79885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 799089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 7991e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7993b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 79975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 79985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8000414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8005c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 8006d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 80075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8013b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8014e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 80165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 801889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 801989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 8020e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8022b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 80265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 80275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 8028c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); 8029d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 80305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 80355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 80375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8038b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8039e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 80415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8043d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { 8044d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool skip_call = false; 8045d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 8046d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 8047d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data == dev_data->queueMap.end()) 8048d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 8049d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (uint32_t i = 0; i < queryCount; i++) { 8050d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine QueryObject query = {queryPool, firstQuery + i}; 8051d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto query_data = queue_data->second.queryToStateMap.find(query); 8052d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool fail = false; 8053d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (query_data != queue_data->second.queryToStateMap.end()) { 8054d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!query_data->second) { 8055d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8056d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8057d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8058d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto global_query_data = dev_data->queryToStateMap.find(query); 8059d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (global_query_data != dev_data->queryToStateMap.end()) { 8060d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!global_query_data->second) { 8061d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8062d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8063d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8064d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8065d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8066d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8067d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (fail) { 8068d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8069d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine DRAWSTATE_INVALID_QUERY, "DS", 8070d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 8071d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); 8072d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8073d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8074d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return skip_call; 8075d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8076d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 807789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 807889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 807989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 8080e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8082b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 808403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 808672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 80880a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 808972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8090e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 8092e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 809472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyQueryPoolResults"); 80975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that DST buffer has correct usage flags set 80980a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 80995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 81005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 81015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 8102d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::function<bool(VkQueue)> queryUpdate = 8103d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::bind(validateQuery, std::placeholders::_1, pCB, queryPool, queryCount, firstQuery); 8104d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 81055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 81065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 81075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 81085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 81095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); 81115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8112b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8113e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 81155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 81165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 811889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 811989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 812089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 81215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 81225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8123b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 81275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 81285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 81295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 81305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 81339e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 81349e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81359e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 81369e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 81379e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 8138a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 81394a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(dev_data, layout); 81404a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (!pipeline_layout) { 81419e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8142a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Pipeline Layout 0x%" PRIx64 " not found.", 81439e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz (uint64_t)layout); 81449e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 8145a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 8146a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // contained in the pipeline ranges. 8147a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Build a {start, end} span list for ranges with matching stage flags. 81484a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes const auto &ranges = pipeline_layout->pushConstantRanges; 8149a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz struct span { 8150a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz uint32_t start; 8151a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz uint32_t end; 8152a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz }; 8153a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span> spans; 8154a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz spans.reserve(ranges.size()); 8155a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz for (const auto &iter : ranges) { 8156a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (iter.stageFlags == stageFlags) { 8157a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz spans.push_back({iter.offset, iter.offset + iter.size}); 81589e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 81599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 8160a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (spans.size() == 0) { 8161a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // There were no ranges that matched the stageFlags. 8162a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8163a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", 8164a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 8165a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 8166a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz (uint32_t)stageFlags, (uint64_t)layout); 8167a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } else { 8168a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Sort span list by start value. 8169a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz struct comparer { 8170a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz bool operator()(struct span i, struct span j) { return i.start < j.start; } 8171a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } my_comparer; 8172a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::sort(spans.begin(), spans.end(), my_comparer); 8173a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 8174a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Examine two spans at a time. 8175a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span>::iterator current = spans.begin(); 8176a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span>::iterator next = current + 1; 8177a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz while (next != spans.end()) { 8178a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (current->end < next->start) { 8179a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // There is a gap; cannot coalesce. Move to the next two spans. 8180a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz ++current; 8181a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz ++next; 8182a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } else { 8183a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Coalesce the two spans. The start of the next span 8184a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // is within the current span, so pick the larger of 8185a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // the end values to extend the current span. 8186a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Then delete the next span and set next to the span after it. 8187a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz current->end = max(current->end, next->end); 8188a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz next = spans.erase(next); 8189a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8190a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8191a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 8192a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Now we can check if the incoming range is within any of the spans. 8193a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz bool contained_in_a_range = false; 8194a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz for (uint32_t i = 0; i < spans.size(); ++i) { 8195a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 8196a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz contained_in_a_range = true; 8197a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz break; 8198a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8199a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8200a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (!contained_in_a_range) { 8201a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8202a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz __LINE__, DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", 8203a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "vkCmdPushConstants() Push constant range [%d, %d) " 8204a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "with stageFlags = 0x%" PRIx32 " " 8205a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 8206a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 8207a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 82089e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 82095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8210b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 82115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 82125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 82135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 821589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 821689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 8217e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 82185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8219b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 82205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 8223c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 8224d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 82255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 82295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8231b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8232e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 82335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 82345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82366600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinskistatic bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, 82376600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag) { 82386600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 82396600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 82406600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t attach = 0; attach < count; attach++) { 82416600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { 82426600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Attachment counts are verified elsewhere, but prevent an invalid access 82436600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment < fbci->attachmentCount) { 82446600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; 82456600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VkImageViewCreateInfo *ivci = getImageViewData(dev_data, *image_view); 82466600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ivci != nullptr) { 82476600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageCreateInfo *ici = &getImageNode(dev_data, ivci->image)->createInfo; 82486600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ici != nullptr) { 82496600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if ((ici->usage & usage_flag) == 0) { 82506600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 82516600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_USAGE, "DS", 82526600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " 82536600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "IMAGE_USAGE flags (%s).", 82546600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag)); 82556600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82566600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82576600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82586600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82596600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82606600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 82616600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 82626600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 82636600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 8264d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// Validate VkFramebufferCreateInfo which includes: 8265d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// 1. attachmentCount equals renderPass attachmentCount 82665ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 2. corresponding framebuffer and renderpass attachments have matching formats 82675ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 3. corresponding framebuffer and renderpass attachments have matching sample counts 82685ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 4. fb attachments only have a single mip level 82695ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 5. fb attachment dimensions are each at least as large as the fb 82705ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 6. fb attachments use idenity swizzle 82715ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 7. fb attachments used by renderPass for color/input/ds have correct usage bit set 82726fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis// 8. fb dimensions are within physical device limits 8273d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlisstatic bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 82746600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 82756600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 8276d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis auto rp_node = getRenderPass(dev_data, pCreateInfo->renderPass); 8277d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rp_node) { 8278d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis const VkRenderPassCreateInfo *rpci = rp_node->pCreateInfo; 8279d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rpci->attachmentCount != pCreateInfo->attachmentCount) { 8280d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= log_msg( 8281d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 8282d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 8283d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount of %u of " 8284d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "renderPass (0x%" PRIxLEAST64 ") being used to create Framebuffer.", 8285d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis pCreateInfo->attachmentCount, rpci->attachmentCount, reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 82865ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } else { 828741ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis // attachmentCounts match, so make sure corresponding attachment details line up 82885ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageView *image_views = pCreateInfo->pAttachments; 82895ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 82905ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis VkImageViewCreateInfo *ivci = getImageViewData(dev_data, image_views[i]); 82915ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ivci->format != rpci->pAttachments[i].format) { 82925ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis skip_call |= log_msg( 82935ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 82945ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 82955ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not match " 82965ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "the format of " 82975ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "%s used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 82985ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis i, string_VkFormat(ivci->format), string_VkFormat(rpci->pAttachments[i].format), 82995ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 83005ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 83015ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageCreateInfo *ici = &getImageNode(dev_data, ivci->image)->createInfo; 83025ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ici->samples != rpci->pAttachments[i].samples) { 830341ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis skip_call |= log_msg( 830441ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 830541ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 830641ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match " 830741ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "the %s samples used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 830841ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), 830941ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 83105ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 83115ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify that view only has a single mip level 83125ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ivci->subresourceRange.levelCount != 1) { 83136fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 83146fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis __LINE__, DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 83156fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u " 83166fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "but only a single mip level (levelCount == 1) is allowed when creating a Framebuffer.", 83176fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis i, ivci->subresourceRange.levelCount); 83185ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 83195ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const uint32_t mip_level = ivci->subresourceRange.baseMipLevel; 8320aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_width = max(1u, ici->extent.width >> mip_level); 8321aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_height = max(1u, ici->extent.height >> mip_level); 8322aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis if ((ivci->subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || 8323aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis (mip_height < pCreateInfo->height)) { 8324aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis skip_call |= 83256fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 8326aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 8327aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions smaller " 8328aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "than the corresponding " 8329aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "framebuffer dimensions. Attachment dimensions must be at least as large. Here are the respective " 8330aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "dimensions for " 8331aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "attachment #%u, framebuffer:\n" 8332aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "width: %u, %u\n" 8333aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "height: %u, %u\n" 8334aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "layerCount: %u, %u\n", 8335aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis i, ivci->subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, 8336aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis pCreateInfo->height, ivci->subresourceRange.layerCount, pCreateInfo->layers); 83375ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 8338aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis if (((ivci->components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.r != VK_COMPONENT_SWIZZLE_R)) || 8339aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis ((ivci->components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.g != VK_COMPONENT_SWIZZLE_G)) || 8340aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis ((ivci->components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.b != VK_COMPONENT_SWIZZLE_B)) || 8341aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis ((ivci->components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.a != VK_COMPONENT_SWIZZLE_A))) { 8342da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis skip_call |= log_msg( 83436fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 8344da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 8345da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All framebuffer " 8346da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "attachments must have been created with the identity swizzle. Here are the actual swizzle values:\n" 8347da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "r swizzle = %s\n" 8348da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "g swizzle = %s\n" 8349da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "b swizzle = %s\n" 8350da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "a swizzle = %s\n", 8351da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis i, string_VkComponentSwizzle(ivci->components.r), string_VkComponentSwizzle(ivci->components.g), 8352da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis string_VkComponentSwizzle(ivci->components.b), string_VkComponentSwizzle(ivci->components.a)); 83535ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 83545ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 8355d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } 83565ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify correct attachment usage flags 83576600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { 83586600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify input attachments: 83596600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, 83606600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pInputAttachments, pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT); 83616600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify color attachments: 83626600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, 83636600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pColorAttachments, pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); 83646600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify depth/stencil attachments: 83656600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { 83666600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, 83676600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); 83686600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 83696600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 8370d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } else { 8371d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= 8372d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 8373d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 8374d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): Attempt to create framebuffer with invalid renderPass (0x%" PRIxLEAST64 ").", 8375d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 83766600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 83776fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis // Verify FB dimensions are within physical device limits 83786fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis if ((pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) || 83796fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) || 83806fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers)) { 83816fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 83826fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 83836fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo dimensions exceed physical device limits. " 83846fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "Here are the respective dimensions: requested, device max:\n" 83856fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "width: %u, %u\n" 83866fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "height: %u, %u\n" 83876fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "layerCount: %u, %u\n", 83886fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, 83896fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, 83906fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers); 83916fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis } 83926600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 83936600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 83946600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 839564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object 839664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Return true if an error is encountered and callback returns true to skip call down chain 839764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// false indicates that call down chain should proceed 839864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlisstatic bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 839964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis // TODO : Verify that renderPass FB is created with is compatible with FB 840064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = false; 8401d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); 840264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return skip_call; 840364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis} 840464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 840554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis// CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object 840654e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlisstatic void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { 840754e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis // Shadow create info and store in map 840876f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis std::unique_ptr<FRAMEBUFFER_NODE> fb_node( 840976f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis new FRAMEBUFFER_NODE(pCreateInfo, dev_data->renderPassMap[pCreateInfo->renderPass]->pCreateInfo)); 841076f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis 841154e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 841254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 841354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis auto view_data = getImageViewData(dev_data, view); 841454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis if (!view_data) { 841554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis continue; 841654e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 841754e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 841854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis get_mem_binding_from_object(dev_data, (uint64_t)(view_data->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 841954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis &fb_info.mem); 842054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis fb_info.image = view_data->image; 842176f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis fb_node->attachments.push_back(fb_info); 842254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 842376f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis dev_data->frameBufferMap[fb] = std::move(fb_node); 842454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis} 842554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis 842689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 842789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 842889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 84295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 843064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 843164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); 843264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.unlock(); 843364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 843464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis if (skip_call) 843564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 843664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 843764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 84386600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 84395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 844064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.lock(); 844154e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); 844254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis lock.unlock(); 84435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 84455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8447e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 8448e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 8451e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 84565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 84575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 8458e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 84595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8461e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 84645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8466e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 8467e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 8468e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 84695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 84705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 84711d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 84725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 84735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 84745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 84755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 84765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 84775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 84787655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen // If no dependency exits an implicit dependency still might. If not, throw an error. 84795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 84807655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 84817655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { 84825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 84835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 84845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 84855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 8486e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 84875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8493e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 8494e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 84955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 84965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 84975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 84995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 8500e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 8504e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8506e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 85075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 85085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 85105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 85135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 8514e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 85155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 85165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 8517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 85185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 85195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8521e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 85225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 85255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 85265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 85295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 85325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 85335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 85345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 85375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8541f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic bool ValidateDependencies(const layer_data *my_data, FRAMEBUFFER_NODE const * framebuffer, 854216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes RENDER_PASS_NODE const * renderPass) { 8543e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 854404861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = &framebuffer->createInfo; 854516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pCreateInfo = renderPass->pCreateInfo; 854616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto const & subpass_to_node = renderPass->subpassToNode; 85475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 85485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 85505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 85515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 85525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 85545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 85555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 85565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 85575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 85585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 85595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85602c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto view_data_i = getImageViewData(my_data, viewi); 85612c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto view_data_j = getImageViewData(my_data, viewj); 85622c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (!view_data_i || !view_data_j) { 85635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 85645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85652c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (view_data_i->image == view_data_j->image && 85662c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis isRegionOverlapping(view_data_i->subresourceRange, view_data_j->subresourceRange)) { 85675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 85685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 85695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 85705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85716d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data_i = getImageNode(my_data, view_data_i->image); 85726d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data_j = getImageNode(my_data, view_data_j->image); 85736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!image_data_i || !image_data_j) { 85745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 85755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85766d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data_i->mem == image_data_j->mem && isRangeOverlapping(image_data_i->memOffset, image_data_i->memSize, 85776d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_data_j->memOffset, image_data_j->memSize)) { 85785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 85795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 85855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 85865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 85875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 85905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 85925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 85945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 85975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 85985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 86031c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 86045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 86061c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 86095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 86105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 86175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 86185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86201c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 86255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86281c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 86291c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 86301c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 86311c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 86321c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 86331c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 86341c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 86351c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 86415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pInputAttachments[j].attachment; 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 86475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pColorAttachments[j].attachment; 86495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 86515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 86535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 86555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 86605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 86615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 86625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 86675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8668be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 8669be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 8670be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 8671be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 8672be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 8673be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 8674be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 8675be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 8676be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 8677be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 8678be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 8679be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 8680be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 8681be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 8682be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 8683be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8684be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8685be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 8686be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8688e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 8689e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 86905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 86925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 86935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 86945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 86955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 86965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 86975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 86985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 86995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 87005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 87015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87024d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 87045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 87055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 87065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8708be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 8709be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pInputAttachments[j].layout, attach_index, 8710be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis pCreateInfo->pAttachments[attach_index]); 87115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 87135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 87145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 87155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 87165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 87175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 87185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 87195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87204d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 87225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 87235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 87245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8726be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pColorAttachments[j].attachment; 8727be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pColorAttachments[j].layout, attach_index, 8728be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis pCreateInfo->pAttachments[attach_index]); 87295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 87315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 87325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 87335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 87345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 87355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 87365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 87375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 87394d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 87415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 87425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 87435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8745be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 8746be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pDepthStencilAttachment->layout, 8747be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8753e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 8754e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 8755e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 87565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 87585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 87615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 87625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 87635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 87665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 87725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 87745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 87755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 87775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8782918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 878489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 878589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 878689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 8788e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 8789b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8790b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 8791b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 8792b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 8793b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 8794b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8795b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 8796b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 8797b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes skip_call |= log_msg(my_data->report_data, 8798b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 8799b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes VkDebugReportObjectTypeEXT(0), 0, 8800b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", "SPIR-V module not valid: %s", 8801b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes diag && diag->error ? diag->error : "(no error text)"); 88025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8804b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 8805b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 8806b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8807e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 88085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 88095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 88115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 8813b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 8814918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88194f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { 88204f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 88214f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { 88224f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88234f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 88244f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: %s attachment %d cannot be greater than the total number of attachments %d.", 88254f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski type, attachment, attachment_count); 88264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88274f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 88284f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 88294f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 88304f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { 88314f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 88324f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 88334f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 88344f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 88354f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= 88364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_RENDERPASS, "DS", 88384f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 88394f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88404f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 88414f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pPreserveAttachments[j]; 88424f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment == VK_ATTACHMENT_UNUSED) { 88434f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 88444f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski __LINE__, DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 88454f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED.", j); 88464f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } else { 88474f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); 88484f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88494f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88504f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 88514f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment; 88524f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pResolveAttachments) { 88534f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pResolveAttachments[j].attachment; 88544f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); 88554f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88564f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pColorAttachments[j].attachment; 88574f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); 88584f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88594f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 88604f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 88614f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); 88624f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88634f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 88644f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pInputAttachments[j].attachment; 88654f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); 88664f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88674f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88684f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 88694f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 88704f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 887189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 88724f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { 8873e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 88754f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 88764f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::unique_lock<std::mutex> lock(global_lock); 88774f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 88784f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 88794f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with 88804f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // ValidateLayouts. 88814f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); 8882ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes lock.unlock(); 88834f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 88844f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (skip_call) { 88854f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 88864f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 88874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 8888ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 8889ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes 88905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 88914f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski lock.lock(); 88924f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 88934f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 88944f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 88954f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 88964f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 89065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 89165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 89175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 89185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 89205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 89215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 89255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 89265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 89275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 89305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 89315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 89325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 89335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 89365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 89435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8944cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes 8945cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes auto render_pass = new RENDER_PASS_NODE(localRPCI); 894698cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 8947cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 8948cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 894987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 895087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 895187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 895287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 895387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 895487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 895587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 89561a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_load_op = desc.stencilLoadOp; 89571a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_store_op = desc.stencilStoreOp; 895887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 8959cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->attachments.push_back(pass_info); 896087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 896187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 8962cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 89636600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; 896487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 896587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 896687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 89674f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pColorAttachments[j].attachment; 89684f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 89694f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 89704f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 89710d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 897287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 897387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 897487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 89754f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 89764f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 89774f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 897824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 897987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 8980a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 8981a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 89824f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 89834f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, true)); 89844f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 898524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 8986a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 898787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 898887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 89894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski dev_data->renderPassMap[*pRenderPass] = render_pass; 89905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 89925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89934f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 89945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 89955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 89967bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes for (auto renderPass : my_data->renderPassMap) { 89977bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass.second->pCreateInfo; 89985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 89995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 90005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 90015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 90025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 90095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 90105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 90115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 90145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 90177bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes delete renderPass.second; 90185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9022e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbesstatic bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 9023e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 90245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 902504861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]->createInfo; 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 90275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 90295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 90332c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto image_data = getImageViewData(dev_data, image_view); 90342c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis assert(image_data); 90352c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImage &image = image_data->image; 90362c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->subresourceRange; 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 90385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 90445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 90475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 90485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (newNode.layout != node.layout) { 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 90525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using attachment %i " 90545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "where the " 9055d6c1882c31a88ae01b94f3135679f739287be31aKarl Schultz "initial layout is %s and the layout of the attachment at the " 90561c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine "start of the render pass is %s. The layouts must match.", 90571c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 90585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 906527ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbesstatic void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, 9066e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 906716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 906816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 90695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 907016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 9071e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 9072e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 90735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9074e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 907504861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo &framebufferInfo = framebuffer->createInfo; 907616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkSubpassDescription &subpass = renderPass->pCreateInfo->pSubpasses[subpass_index]; 90775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 90785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pInputAttachments[j].attachment]; 90795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pInputAttachments[j].layout); 90805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 90825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pColorAttachments[j].attachment]; 90835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pColorAttachments[j].layout); 90845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 90865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pDepthStencilAttachment->attachment]; 90875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pDepthStencilAttachment->layout); 90885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9091e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 9092e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 90935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 90945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 90965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 90975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9101f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 910216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 910316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 91045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 910516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 910616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->pCreateInfo; 9107e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 9108e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 91095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9110e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 91115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 9112e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes const VkImageView &image_view = framebuffer->createInfo.pAttachments[i]; 91135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 91145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9117e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 9118885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 911904861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = &getFramebuffer(my_data, pRenderPassBegin->framebuffer)->createInfo; 9120885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 9121885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 9122885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 9123885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 9124885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 9125885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9126885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 9127885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 9128885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 9129885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 9130885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 9131885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 9132885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 9133885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 9134885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 9135885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 91361a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the 91371a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// [load|store]Op flag must be checked 91381a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. 91391a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinskitemplate <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { 9140a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski if (color_depth_op != op && stencil_op != op) { 9141a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return false; 9142a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski } 91431a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_color_depth_load_op = !vk_format_is_stencil_only(format); 91441a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; 9145a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski 9146a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return (((check_color_depth_load_op == true) && (color_depth_op == op)) || 9147a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski ((check_stencil_load_op == true) && (stencil_op == op))); 91481a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski} 91491a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski 915089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 915189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 9152e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9154b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 91555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 915616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = pRenderPassBegin ? getRenderPass(dev_data, pRenderPassBegin->renderPass) : nullptr; 9157f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = pRenderPassBegin ? getFramebuffer(dev_data, pRenderPassBegin->framebuffer) : nullptr; 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 915916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 91603d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis uint32_t clear_op_count = 0; 916116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeFramebuffer = pRenderPassBegin->framebuffer; 916216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes for (size_t i = 0; i < renderPass->attachments.size(); ++i) { 9163f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 91641a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = renderPass->pCreateInfo->pAttachments[renderPass->attachments[i].attachment].format; 91651a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 91661a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 91671a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_CLEAR)) { 91683d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis ++clear_op_count; 916916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 917016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 917116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 917216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 917316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 91741a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 91751a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 91761a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { 917716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 917816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 917916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 918016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 918116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 91821a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 91831a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 91841a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_LOAD)) { 918516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 918616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 918716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 918816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 918916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 919016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass->attachment_first_read[renderPass->attachments[i].attachment]) { 919116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 919216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 919316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 919416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 91955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91973d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis if (clear_op_count > pRenderPassBegin->clearValueCount) { 91983d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis skipCall |= log_msg( 91993d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 92003d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis reinterpret_cast<uint64_t &>(renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 92013d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but the actual number " 92023d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis "of attachments in renderPass 0x%" PRIx64 " that use VK_ATTACHMENT_LOAD_OP_CLEAR is %u. The clearValueCount " 92031a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski "must therefore be greater than or equal to %u.", 92043d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis pRenderPassBegin->clearValueCount, reinterpret_cast<uint64_t &>(renderPass), clear_op_count, clear_op_count); 92053d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis } 9206e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 9207e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes skipCall |= VerifyFramebufferAndRenderPassLayouts(dev_data, pCB, pRenderPassBegin); 9208ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 9209e5f0c7b48d7b8020aa0877ad216aac257f9e4212Tobin Ehlis skipCall |= ValidateDependencies(dev_data, framebuffer, renderPass); 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 92115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 92128168af0c4c5b12708d5ddbeb6ce513207d01f0e4Chris Forbes pCB->activeRenderPass = renderPass; 92135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 92145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 92155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 92165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 921793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.insert(pRenderPassBegin->framebuffer); 92185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 9219e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes framebuffer->referencingCmdBuffers.insert(pCB->commandBuffer); 92205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 92215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 922216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 922316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 92245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9226b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9227e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 92285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 92295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 923289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 9233e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 92345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9235b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 92375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 92385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 92395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 92405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 92415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 924227ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 92435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9245b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9246e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 92485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 925089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 9251e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 92525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9253b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 925458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes auto pCB = getCBNode(dev_data, commandBuffer); 925558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes if (pCB) { 925658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes RENDER_PASS_NODE* pRPNode = pCB->activeRenderPass; 9257e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pCB->activeFramebuffer); 9258ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (pRPNode) { 925987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 9260e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 92611a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = pRPNode->pCreateInfo->pAttachments[pRPNode->attachments[i].attachment].format; 92621a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 92631a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, VK_ATTACHMENT_STORE_OP_STORE)) { 926458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 926558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 926658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 926758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 926858c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 92691a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 92701a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, 92711a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_STORE_OP_DONT_CARE)) { 927258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 927358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 927458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 927558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 927658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 92775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 928058c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 928158c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 928258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 9283f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); 928458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeRenderPass = nullptr; 928558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeSubpass = 0; 928658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeFramebuffer = VK_NULL_HANDLE; 92875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9288b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9289e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 92915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92935121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, 92945121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes RENDER_PASS_NODE const *primaryPass, uint32_t primaryAttach, uint32_t secondaryAttach, 9295e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *msg) { 92965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9298414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a render pass 0x%" PRIx64 9299414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current render pass 0x%" PRIx64 "." 930081264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom "Attachment %" PRIu32 " is not compatible with %" PRIu32 ". %s", 93015121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes (void *)secondaryBuffer, (uint64_t)(secondaryPass->renderPass), (uint64_t)(primaryPass->renderPass), primaryAttach, secondaryAttach, 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis msg); 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93055121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, RENDER_PASS_NODE const *primaryPass, 93065121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes uint32_t primaryAttach, VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, 9307e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 93085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 93095121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->attachmentCount <= primaryAttach) { 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93125121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (secondaryPass->pCreateInfo->attachmentCount <= secondaryAttach) { 93135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 93145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 93205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The first is unused while the second is not."); 93215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The second is unused while the first is not."); 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93285121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->pAttachments[primaryAttach].format != 93295121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].format) { 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different formats."); 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93335121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->pAttachments[primaryAttach].samples != 93345121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].samples) { 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different samples."); 93375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (is_multi && 93395121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes primaryPass->pCreateInfo->pAttachments[primaryAttach].flags != 93405121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].flags) { 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 93425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different flags."); 93435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93475121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, RENDER_PASS_NODE const *primaryPass, 93485121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, const int subpass, 9349e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool is_multi) { 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 93515121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes const VkSubpassDescription &primary_desc = primaryPass->pCreateInfo->pSubpasses[subpass]; 93525121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes const VkSubpassDescription &secondary_desc = secondaryPass->pCreateInfo->pSubpasses[subpass]; 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 93585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_input_attach, secondaryBuffer, 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_input_attach, is_multi); 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 93675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 93685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 93725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_color_attach, secondaryBuffer, 93755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_color_attach, is_multi); 93765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 93785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 93795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 93815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 93825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_resolve_attach, secondaryBuffer, 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_resolve_attach, is_multi); 93855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 93875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 93885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 93895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_depthstencil_attach, secondaryBuffer, 93945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_depthstencil_attach, is_multi); 93955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9398e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9399e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass) { 94005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 94015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early exit if renderPass objects are identical (and therefore compatible) 94025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryPass == secondaryPass) 94035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 940416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto primary_render_pass = getRenderPass(dev_data, primaryPass); 940516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto secondary_render_pass = getRenderPass(dev_data, secondaryPass); 940616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!primary_render_pass) { 94075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 94085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9410414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid current Cmd Buffer 0x%p which has invalid render pass 0x%" PRIx64 ".", 94115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)primaryBuffer, (uint64_t)(primaryPass)); 94125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 941416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!secondary_render_pass) { 94155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 94165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9418414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%p which has invalid render pass 0x%" PRIx64 ".", 94195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass)); 94205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 942216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (primary_render_pass->pCreateInfo->subpassCount != secondary_render_pass->pCreateInfo->subpassCount) { 94235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9425414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a render pass 0x%" PRIx64 9426414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current render pass 0x%" PRIx64 "." 94275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "They have a different number of subpasses.", 94285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass)); 94295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 943116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto subpassCount = primary_render_pass->pCreateInfo->subpassCount; 943216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes for (uint32_t i = 0; i < subpassCount; ++i) { 943316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primary_render_pass, secondaryBuffer, 943416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes secondary_render_pass, i, subpassCount > 1); 94355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9439e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 9440e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 94415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 94425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 94435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9445c5b97dda856ff837638b3ebb7e231d5507c495a3Chris Forbes VkFramebuffer primary_fb = pCB->activeFramebuffer; 94465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 94475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 94485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 94495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9451414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a framebuffer 0x%" PRIx64 9452414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current framebuffer 0x%" PRIx64 ".", 94535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 94545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9455e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto fb = getFramebuffer(dev_data, secondary_fb); 9456e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!fb) { 94575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 94585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9459414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9460414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 94615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 94625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9464e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->createInfo.renderPass, 94655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryBuffer, pSubCB->beginInfo.pInheritanceInfo->renderPass); 94665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9470e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 94715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 94725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 94735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 94745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 94755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 94765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 94775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 94785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 94815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9483414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9484414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 94855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 94865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 94905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 94935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 94945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 94955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 94965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9498414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9499414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 9500414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 95015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 95035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 950889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 950989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 9510e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9512b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 95155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 95165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 95175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 95185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 95195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9522414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 95235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 95255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 95265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9527414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 95285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 95295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 95305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 95315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 95325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 95345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 9535414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 95365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 9537ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 95385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 95395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 9540ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes skipCall |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->renderPass, pCommandBuffers[i], 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass); 95425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 95435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 9545ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->renderPass, 95465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass, errorString)) { 95475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 95485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 95495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 9550414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 9551414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 95525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 9553ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 95545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 95565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 95585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 95595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 95605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 95615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 9562414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) references framebuffer (0x%" PRIxLEAST64 9563414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") that does not match framebuffer (0x%" PRIxLEAST64 ") in active renderpass (0x%" PRIxLEAST64 ").", 95645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 9565ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass->renderPass); 95665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 95705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 95715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pSubCB); 95725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 95735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 95745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 95755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 95765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 95775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 95785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9579414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to simultaneously execute CB 0x%" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 95805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 95815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 95825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 95845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 95855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 95865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 95875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9588414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 95895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 9590414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, even though it does.", 95925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 95935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 95945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9596b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 95975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 95985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 95995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 96005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 9601414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 96025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 96035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 96045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 96055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 96075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 96085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 96095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 96115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 96125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9613b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9614e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 96155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 96165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9618e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 9619e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 96205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 962157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 962257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if ((mem_info) && (mem_info->image != VK_NULL_HANDLE)) { 96235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 962457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (FindLayouts(dev_data, mem_info->image, layouts)) { 96255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 96265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 96275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 96285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 96305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 96315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 963889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 963989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 96405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 96415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9642e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 96435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9644b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 964503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 964657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObj = getMemObjInfo(dev_data, mem); 96475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 96485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 9649b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & 9650b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 96515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 96525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 9654414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 96555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 96585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 965958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 9660b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 96615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9662e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 96635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 96647c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis if (VK_SUCCESS == result) { 966503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 96667c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.lock(); 96677c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis storeMemRanges(dev_data, mem, offset, size); 96687c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 96697c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.unlock(); 96705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 96717c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis } 96725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 967689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9678e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 96795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9680b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= deleteMemRanges(my_data, mem); 9682b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9683e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 96855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9688e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 9689e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9690e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 969257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 969357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 969457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->memRange.offset > pMemRanges[i].offset) { 969557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis skipCall |= 969657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 969757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 969857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 969957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 970057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_info->memRange.offset)); 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97024b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller 97034b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller const uint64_t my_dataTerminus = 970457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (mem_info->memRange.size == VK_WHOLE_SIZE) ? mem_info->allocInfo.allocationSize : 970557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (mem_info->memRange.offset + mem_info->memRange.size); 97064b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller if (pMemRanges[i].size != VK_WHOLE_SIZE && (my_dataTerminus < (pMemRanges[i].offset + pMemRanges[i].size))) { 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 97105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") exceeds the Memory Object's upper-bound " 97115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 97125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 97134b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller static_cast<size_t>(my_dataTerminus)); 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 97185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9720e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 9721e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9722e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 97235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 972457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 972557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 972657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->pData) { 972757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis VkDeviceSize size = mem_info->memRange.size; 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 972957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis char *data = static_cast<char *>(mem_info->pData); 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 97335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 9734414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 97395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 97405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 97415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 9742414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 974657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis memcpy(mem_info->pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 97475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 975389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 975489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9756e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9759b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 97605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 97615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 9762b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9763e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 976989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 977089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 97715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9772e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 97735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9775b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 97765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 9777b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9778e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 97805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 978489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9787e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 9788b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 97896d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 97906d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 979194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 979247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 979394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 97945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 9795b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 979694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 9797b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 979847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 979947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 980057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 980157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 980247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 980357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis insert_memory_ranges(image_handle, mem, memoryOffset, memRequirements, mem_info->imageRanges); 980457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis skipCall |= validate_memory_range(dev_data, mem_info->bufferRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 98054261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski skipCall |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "vkBindImageMemory"); 980647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 980747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 98080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 9809b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 981094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!skipCall) { 981194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 9812b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 981357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis dev_data->memObjMap[mem].get()->image = image; 98146d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = mem; 98156d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memOffset = memoryOffset; 98166d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memSize = memRequirements.size; 9817b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 981894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 981994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 982094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 982194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 9822414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 982394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 982889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 98293ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 98303ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9832b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 98333ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis auto event_node = dev_data->eventMap.find(event); 98343ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node != dev_data->eventMap.end()) { 98353ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.needsSignaled = false; 98363ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.stageMask = VK_PIPELINE_STAGE_HOST_BIT; 9837c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (event_node->second.write_in_use) { 98383ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 98393ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9840414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 98413ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 98423ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 98433ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 9844b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 98456fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 98466fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 98476fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 98486fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 98496fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 98506fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 98516fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 98526fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 98536fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 98543ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 98553ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 986089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9863e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9864b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 9865651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 9866651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 9867651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 98684b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 9869651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= ValidateFenceForSubmit(dev_data, pFence); 9870651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 9871a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence != VK_NULL_HANDLE) { 9872651d92815dfff917308137bb67aacccc4f60df86Chris Forbes SubmitFence(pQueue, pFence); 98734b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 9874651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 98751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 98761344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 98775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 98781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 98791344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 98801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 98811344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9883e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98861344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 98871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 98881344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 98891344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9891e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 98951344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 98961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 98971344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9899e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 99005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 990301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; 990401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 990501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 990601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 990701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 99081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 99091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 99105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 99111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9912414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 99131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 99141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 991901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; 992001a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 992101a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 992201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 99235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 99245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 99251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9926414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 99271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 99281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 99295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 993001a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = true; 99315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99340a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 9935b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 99365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9937e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 99385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 99395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 994389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 994489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 99455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 9948b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 99501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 99510a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 995889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 99595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 99615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 9962b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 99635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 99645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 9965293ecfc5e69ed3978a8c04518166d828294870a4Tony Barbour dev_data->eventMap[*pEvent].write_in_use = 0; 99665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 99675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 997189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 997289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 997389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 99745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 99765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 9978b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 99793f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo)); 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 998589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 998689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 99875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9990b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 9991b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, swapchain); 9992b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 9993b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data->images.size() > 0) { 9994b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis for (auto swapchain_image : swapchain_data->images) { 99955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 99965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 99975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 99985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 99995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 100005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 100015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 100045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100050a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, (uint64_t)swapchain_image, 100060801763633180d277d26a90343464bd11646056fTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1000794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 100085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 100115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10012b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 100135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 100145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 100155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1001789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1001889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 100195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 100215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 100235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 100245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 10026b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 10028b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_node = getSwapchainNode(dev_data, swapchain); 10029b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_node && !swapchain_node->images.empty()) { 100300801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 100310801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 100320801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 100335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 100345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 100365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 10037414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 100385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 100395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 100405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 100435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 100445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 100455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 100466d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis // Add imageMap entries for each swapchain image 100476d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo image_ci = {}; 100486d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.mipLevels = 1; 100496d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 100506d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.usage = swapchain_node->createInfo.imageUsage; 100516d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.format = swapchain_node->createInfo.imageFormat; 1005241ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis image_ci.samples = VK_SAMPLE_COUNT_1_BIT; 100536d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; 100546d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; 100556d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; 100566d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_NODE>(new IMAGE_NODE(&image_ci)); 1005794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 100586d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->valid = false; 100596d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 100605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 100615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 100625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 100635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 100645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 100655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1007089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 100715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 100725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 100735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100746c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes std::lock_guard<std::mutex> lock(global_lock); 100756c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 100766c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 100776c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && !pSemaphore->signaled) { 100786c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 100796c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100806c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 100816c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 100826c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); 100835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100846c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 100856c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkDeviceMemory mem; 100866c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 100876c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 100886c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (swapchain_data && pPresentInfo->pImageIndices[i] < swapchain_data->images.size()) { 100896c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkImage image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 1009003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 100916c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 100920a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 100936c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= validate_memory_is_valid(dev_data, mem, "vkQueuePresentKHR()", image); 1009403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 100956c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes vector<VkImageLayout> layouts; 100966c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (FindLayouts(dev_data, image, layouts)) { 100976c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (auto layout : layouts) { 100986c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 100996c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 101005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 101015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 101025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 101035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 101045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 101055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101116c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (skip_call) { 101126c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 101136c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 101146c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 101156c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkResult result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 101166c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 101176c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (result != VK_ERROR_VALIDATION_FAILED_EXT) { 101186c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // Semaphore waits occur before error generation, if the call reached 101196c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // the ICD. (Confirm?) 101206c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 101216c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 101226c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && pSemaphore->signaled) { 101236c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes pSemaphore->signaled = false; 101246c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 101256c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 101266c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 101271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 101285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1013189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 1013289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 101335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 101345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 101351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 10136b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10137f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 10138f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore && pSemaphore->signaled) { 10139f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 10140f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10141f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 101425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10143f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10144f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pFence = getFenceNode(dev_data, fence); 10145f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 10146f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes skipCall |= ValidateFenceForSubmit(dev_data, pFence); 101475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10148b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 101491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 10150f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (skipCall) 10151f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 10152f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10153f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes VkResult result = 101545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 10155f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10156f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.lock(); 10157f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { 10158f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 10159f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pFence->state = FENCE_INFLIGHT; 10160f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 10161f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10162f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore 10163f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore) { 10164f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pSemaphore->signaled = true; 10165f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 101665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10167f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.unlock(); 101681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 101695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1017289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1017389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 1017489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 101755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 101765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 101775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 101785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 10179b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 10180c34ab18ac7c064590a1020a8db4b6abf5a8d3a18Mark Lobodzinski res = layer_create_msg_callback(my_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); 101815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 101835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1018589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 1018689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 1018789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 101885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 101895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 101905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10191b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 101925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 101935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1019589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1019689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 1019789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 101985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 101995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 102005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 102015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10203a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10204a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 10205a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 10206a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 10207a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 10208a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10209a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 10210a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 10211a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 10212a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 10213a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10214a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 10215a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 10216a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 10217a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 10218a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return VK_ERROR_LAYER_NOT_PRESENT; 10219a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 10220a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 1022189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 1022289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 1022389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 10224a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 1022508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 10226a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 10227a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 10228a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 10229a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu dispatch_key key = get_dispatch_key(physicalDevice); 10230a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu layer_data *my_data = get_my_data_ptr(key, layer_data_map); 10231a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 1023208939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1023308939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1023480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 102357ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 102367ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 102377ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1023880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 1023980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1024009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1024109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 1024209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1024389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 1024480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 1024580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 1024680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 1024780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1024880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 102495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1025009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 1025109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 1025209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 1025309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 102545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 102555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 102565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 102585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 102595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 102605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 102615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 102625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1026589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 102667ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 102673f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 102683f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 102693f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 102703f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 102717ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 102727ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 102735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102747ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 102755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 102775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 102787ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 102797ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 102807ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 102815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 102835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 102845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 102855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 102865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1028708939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1028880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 102897ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 102907ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 102917ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 102927ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 102937ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 102947ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 102957ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 102967ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 102977ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 102987ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 10299a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, 10300a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, 10301a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, 103027ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 103037ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 103047ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 103057ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 103067ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 103077ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 103087ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 103097ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 103107ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 103117ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 103127ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 103137ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1031480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1031580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1031680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1031780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1031880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 10319593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, 10320593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, 10321593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, 10322593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, 10323593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, 10324593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, 10325593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, 10326593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, 10327593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, 10328593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, 10329593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, 10330593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, 10331593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, 10332593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, 10333593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, 10334593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, 10335593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, 10336593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, 10337593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, 10338593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, 10339593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, 10340593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, 10341593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, 10342593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, 10343593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, 10344593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, 10345593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, 10346593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, 10347593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, 10348593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, 10349593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, 10350593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, 10351593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, 10352593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, 10353593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, 10354593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, 10355593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, 10356593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, 10357593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, 10358593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, 10359593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, 10360593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, 10361593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, 10362593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, 10363593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, 10364593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, 10365593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, 10366593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, 10367593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, 10368593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, 10369593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, 10370593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, 10371593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, 10372593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, 10373593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, 10374593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, 10375593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, 10376593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, 10377593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, 10378593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, 10379593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, 10380593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, 10381593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, 10382593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, 10383593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, 10384593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, 10385593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, 10386593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, 10387593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, 10388593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, 10389593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, 10390593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, 10391593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, 10392593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, 10393593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, 10394593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, 10395593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, 10396593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, 10397593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, 10398593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, 10399593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, 10400593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, 10401593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, 10402593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, 10403593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, 10404593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, 10405593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, 10406593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, 10407593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, 10408593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, 10409593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, 10410593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, 10411593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, 10412593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, 10413593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, 10414593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, 10415593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, 10416593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, 10417593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, 10418593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, 10419593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, 10420593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, 10421593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, 10422593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, 10423593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, 10424593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, 10425593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, 10426593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, 10427593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, 10428593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, 10429593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, 10430593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, 10431593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, 10432593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, 10433593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, 10434593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, 1043580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1043680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1043780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1043880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1043980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1044080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1044180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1044280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1044380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1044480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1044509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1044609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1044709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1044809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1044909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1045009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1045109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1045209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1045309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1045409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1045509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1045609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 1045709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 104583f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 104593f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 104603f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 104613f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 104623f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1046309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1046409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1046509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1046609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1046709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1046809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1046909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 1047009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1047109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 10472d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 10473d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10474d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 10475d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10476d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10477d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 10478d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1047989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 10480d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10481d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10482d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10483d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 10484d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 10485d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1048689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10487d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10488d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10489d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10490d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 10491d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1049289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 10493d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10494d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10495a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu// loader-layer interface v0, just wrappers since there is only a layer 10496d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1049708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1049808939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 10499a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); 1050008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1050108939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1050208939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1050308939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 10504a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); 1050508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1050608939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1050708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1050808939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 10509a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 10510a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 10511a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); 10512d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10513d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10514d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 10515d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 10516d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 10517a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 10518a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 10519a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 10520d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10521d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10522d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1052389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 10524d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10525d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10526d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 1052789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1052808939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 10529