core_validation.cpp revision c2a5a36d03bbe52f5854a5884346e4a84115e259
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 41825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski//#include <memory> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 46dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes#include <tuple> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 63b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 69c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine#define LOGCONSOLE(...) \ 70c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine { \ 71c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf(__VA_ARGS__); \ 72c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf("\n"); \ 73c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 77414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 78d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 79d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 86888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// 2nd special memory handle used to flag object as unbound from memory 87888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic const VkDeviceMemory MEMORY_UNBOUND = VkDeviceMemory(~((uint64_t)(0)) - 1); 88b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 90e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 91c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young bool wsi_display_swapchain_enabled; 923f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstruct instance_layer_data { 100d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkInstance instance = VK_NULL_HANDLE; 101d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes unique_ptr<INSTANCE_STATE> instance_state = nullptr; 102d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes debug_report_data *report_data = nullptr; 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1049172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes VkLayerInstanceDispatchTable dispatch_table; 1059172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes 106f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes unordered_map<VkPhysicalDevice, PHYSICAL_DEVICE_STATE> physical_device_map; 107747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes unordered_map<VkSurfaceKHR, SURFACE_STATE> surface_map; 108747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 109747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool surfaceExtensionEnabled = false; 110747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool displayExtensionEnabled = false; 111747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_ANDROID_KHR 112747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool androidSurfaceExtensionEnabled = false; 113747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 114747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_MIR_KHR 115747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool mirSurfaceExtensionEnabled = false; 116747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 117747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WAYLAND_KHR 118747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool waylandSurfaceExtensionEnabled = false; 119747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 120747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WIN32_KHR 121747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool win32SurfaceExtensionEnabled = false; 122747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 123747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XCB_KHR 124747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool xcbSurfaceExtensionEnabled = false; 125747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 126747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XLIB_KHR 127747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool xlibSurfaceExtensionEnabled = false; 128747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 129f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes}; 130f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes 131f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstruct layer_data { 132f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes debug_report_data *report_data = nullptr; 1334a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkLayerDispatchTable dispatch_table; 134f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes unique_ptr<INSTANCE_STATE> instance_state = nullptr; 13594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 136d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes devExts device_extensions = {}; 137cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski unordered_set<VkQueue> queues; // All queues under given device 1385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 141cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> samplerMap; 14279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis unordered_map<VkImageView, unique_ptr<IMAGE_VIEW_STATE>> imageViewMap; 1431facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis unordered_map<VkImage, unique_ptr<IMAGE_STATE>> imageMap; 14439267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis unordered_map<VkBufferView, unique_ptr<BUFFER_VIEW_STATE>> bufferViewMap; 1458718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis unordered_map<VkBuffer, unique_ptr<BUFFER_NODE>> bufferMap; 1464c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis unordered_map<VkPipeline, PIPELINE_STATE *> pipelineMap; 1478d6a38de0389036581ada119e548180c614fe0efChris Forbes unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; 148a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_STATE *> descriptorPoolMap; 149397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 150cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 15257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; 1535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 15972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 160c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_STATE>> frameBufferMap; 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 163127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis unordered_map<VkRenderPass, unique_ptr<RENDER_PASS_STATE>> renderPassMap; 164918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 165d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkDevice device = VK_NULL_HANDLE; 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 167f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *instance_data = nullptr; // from device to enclosing instance 16807a464bd7fec9583f346b8c4b8d43c88d2e9ffa4Chris Forbes 169f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes VkPhysicalDeviceFeatures enabled_features = {}; 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 171d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes PHYS_DEV_PROPERTIES_NODE phys_dev_properties = {}; 172d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkPhysicalDeviceMemoryProperties phys_dev_mem_props = {}; 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 175b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 176b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 177f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstatic unordered_map<void *, instance_layer_data *> instance_layer_data_map; 178b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 179e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 180f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 181e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 186e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 192e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 206b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 207b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 208b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 209b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 210b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 211b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 213b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 214b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 215b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 216b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 217b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 218b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 277b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 278593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 27979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis// Return IMAGE_VIEW_STATE ptr for specified imageView or else NULL 28079fde938178535f598e030a0e9d19a0cb61b72e0Tobin EhlisIMAGE_VIEW_STATE *getImageViewState(const layer_data *dev_data, VkImageView image_view) { 2812c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_it = dev_data->imageViewMap.find(image_view); 2822c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (iv_it == dev_data->imageViewMap.end()) { 2832c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return nullptr; 2842c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis } 2852c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return iv_it->second.get(); 2862c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis} 2879a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis// Return sampler node ptr for specified sampler or else NULL 288a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSAMPLER_NODE *getSamplerNode(const layer_data *dev_data, VkSampler sampler) { 2892c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto sampler_it = dev_data->samplerMap.find(sampler); 2902c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (sampler_it == dev_data->samplerMap.end()) { 2919a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return nullptr; 2929a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis } 2939a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return sampler_it->second.get(); 2949a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis} 2956d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis// Return image node ptr for specified image or else NULL 2961facd2c91911508b9fb61f54a56269841299f663Tobin EhlisIMAGE_STATE *getImageState(const layer_data *dev_data, VkImage image) { 2976d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_it = dev_data->imageMap.find(image); 2986d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_it == dev_data->imageMap.end()) { 2996d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return nullptr; 3006d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis } 3016d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return img_it->second.get(); 3026d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis} 3038718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis// Return buffer node ptr for specified buffer or else NULL 304a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisBUFFER_NODE *getBufferNode(const layer_data *dev_data, VkBuffer buffer) { 3052c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 3062c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (buff_it == dev_data->bufferMap.end()) { 3078718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return nullptr; 3088718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis } 3098718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return buff_it->second.get(); 3108718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis} 311b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis// Return swapchain node for specified swapchain or else NULL 312a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { 313b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); 314b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swp_it == dev_data->device_extensions.swapchainMap.end()) { 315b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis return nullptr; 316b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis } 3173f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis return swp_it->second.get(); 318b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis} 319170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis// Return swapchain for specified image or else NULL 320a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { 321170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); 322170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { 323170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return VK_NULL_HANDLE; 324170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis } 325170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return img_it->second; 326170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis} 3272f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis// Return buffer node ptr for specified buffer or else NULL 32839267c0c27b8f032f05a6747eb02d4508247fdc1Tobin EhlisBUFFER_VIEW_STATE *getBufferViewState(const layer_data *my_data, VkBufferView buffer_view) { 3292f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis auto bv_it = my_data->bufferViewMap.find(buffer_view); 3302f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis if (bv_it == my_data->bufferViewMap.end()) { 3312f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return nullptr; 3322f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis } 3332f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return bv_it->second.get(); 3342f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis} 3358718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis 33666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesFENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { 33766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->fenceMap.find(fence); 33866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->fenceMap.end()) { 33966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 34066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 34166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 34266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 34366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3449556936067fd0c4eb74c4a13631bc163b154faedTobin EhlisEVENT_NODE *getEventNode(layer_data *dev_data, VkEvent event) { 3459556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto it = dev_data->eventMap.find(event); 3469556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (it == dev_data->eventMap.end()) { 3479556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return nullptr; 3489556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 3499556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return &it->second; 3509556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis} 3519556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis 352ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin EhlisQUERY_POOL_NODE *getQueryPoolNode(layer_data *dev_data, VkQueryPool query_pool) { 353ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto it = dev_data->queryPoolMap.find(query_pool); 354ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (it == dev_data->queryPoolMap.end()) { 355ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return nullptr; 356ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 357ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return &it->second; 358ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis} 359ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis 36066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesQUEUE_NODE *getQueueNode(layer_data *dev_data, VkQueue queue) { 36166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->queueMap.find(queue); 36266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->queueMap.end()) { 36366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 36466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 36566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 36666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 36766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3685e92f3cfdca6a52a3dcefd053c41f728bd036cebChris ForbesSEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { 3695e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes auto it = dev_data->semaphoreMap.find(semaphore); 3705e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes if (it == dev_data->semaphoreMap.end()) { 3715e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return nullptr; 3725e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes } 3735e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return &it->second; 3745e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes} 3755e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes 3768d6a38de0389036581ada119e548180c614fe0efChris ForbesCOMMAND_POOL_NODE *getCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { 3778d6a38de0389036581ada119e548180c614fe0efChris Forbes auto it = dev_data->commandPoolMap.find(pool); 3788d6a38de0389036581ada119e548180c614fe0efChris Forbes if (it == dev_data->commandPoolMap.end()) { 3798d6a38de0389036581ada119e548180c614fe0efChris Forbes return nullptr; 3808d6a38de0389036581ada119e548180c614fe0efChris Forbes } 3818d6a38de0389036581ada119e548180c614fe0efChris Forbes return &it->second; 3828d6a38de0389036581ada119e548180c614fe0efChris Forbes} 3833bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes 384f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris ForbesPHYSICAL_DEVICE_STATE *getPhysicalDeviceState(instance_layer_data *instance_data, VkPhysicalDevice phys) { 385f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes auto it = instance_data->physical_device_map.find(phys); 386f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes if (it == instance_data->physical_device_map.end()) { 3873bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes return nullptr; 3883bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes } 3893bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes return &it->second; 3903bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes} 3913bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes 392747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesSURFACE_STATE *getSurfaceState(instance_layer_data *instance_data, VkSurfaceKHR surface) { 393747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes auto it = instance_data->surface_map.find(surface); 394747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (it == instance_data->surface_map.end()) { 395747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return nullptr; 396747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 397747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return &it->second; 398747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 399747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 400888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// Return ptr to bound memory for given handle of specified type and set sparse param to indicate if binding is sparse 401888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic VkDeviceMemory *GetObjectMemBinding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type, bool *sparse) { 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 4041facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(my_data, VkImage(handle)); 4051facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis *sparse = image_state->createInfo.flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT; 4061facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) 4071facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return &image_state->mem; 4085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 4118718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buff_node = getBufferNode(my_data, VkBuffer(handle)); 412888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis *sparse = buff_node->createInfo.flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT; 4138718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buff_node) 4148718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return &buff_node->mem; 4155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 4165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 4185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 4215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 422888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// Overloaded version of above function that doesn't care about sparse bool 423888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic VkDeviceMemory *GetObjectMemBinding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 424888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool sparse; 425888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis return GetObjectMemBinding(my_data, handle, type, &sparse); 426888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis} 42772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 4285121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 42972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 4325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 4335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 4340a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 4350a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 4360a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 437e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 43883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 4405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 4425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 4435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 44483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 44583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 44683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 44783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 4485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 4505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 453249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 454249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// an error will be flagged if usage is not correct 4551facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic bool ValidateImageUsageFlags(layer_data *dev_data, IMAGE_STATE const *image_state, VkFlags desired, VkBool32 strict, 456249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis char const *func_name, char const *usage_string) { 4571facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return validate_usage_flags(dev_data, image_state->createInfo.usage, desired, strict, 4581facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis reinterpret_cast<const uint64_t &>(image_state->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 459249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "image", func_name, usage_string); 460249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis} 461249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 462249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// Helper function to validate usage flags for buffers 463ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 464ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// an error will be flagged if usage is not correct 46559b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlisstatic bool ValidateBufferUsageFlags(layer_data *dev_data, BUFFER_NODE const *buffer_node, VkFlags desired, VkBool32 strict, 466ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis char const *func_name, char const *usage_string) { 467ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return validate_usage_flags(dev_data, buffer_node->createInfo.usage, desired, strict, 468ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 469ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "buffer", func_name, usage_string); 470ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 471ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 4735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 47457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin EhlisDEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { 47557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_it = dev_data->memObjMap.find(mem); 47657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_it == dev_data->memObjMap.end()) { 4775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis return mem_it->second.get(); 4805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); 4875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 488dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis 489dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis// Helper function to print lowercase string of object type 490dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis// TODO: Unify string helper functions, this should really come out of a string helper if not there already 491dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 492dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis switch (type) { 493dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 494dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "image"; 495dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 496dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "buffer"; 4977e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: 4987e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "image view"; 4997e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: 5007e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "buffer view"; 501dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 502dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "swapchain"; 503dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: 504dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "descriptor set"; 505dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: 5066f62283faa835f7fd302771a3a693d1aafff4652Tobin Ehlis return "framebuffer"; 507dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: 508dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "event"; 509dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: 510dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "query pool"; 5117e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: 5127e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "descriptor pool"; 5137e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: 5147e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "command pool"; 515dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: 516dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "pipeline"; 517dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: 518dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "sampler"; 5197e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: 5207e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "renderpass"; 5217e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: 5227e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "device memory"; 523eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT: 524eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis return "semaphore"; 525dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis default: 526dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "unknown"; 527dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis } 528dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis} 529dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis 530cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given bound_object_handle, bound to given mem allocation, verify that the range for the bound object is valid 531f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateMemoryIsValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t bound_object_handle, 532dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *functionName) { 533f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 534f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 535f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (!mem_info->bound_ranges[bound_object_handle].valid) { 536f48a83f5b5548cd46a12770c7542ff902537ad3eKarl Schultz return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 537ea8e85ade623a09c601d939622cbd7740d8d66c9Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", 538dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis "%s: Cannot read invalid region of memory allocation 0x%" PRIx64 " for bound %s object 0x%" PRIx64 539dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis ", please fill the memory before using.", 540dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis functionName, reinterpret_cast<uint64_t &>(mem), object_type_to_string(type), bound_object_handle); 541f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 542f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 543f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return false; 544f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 5451facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis// For given image_state 5461facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis// If mem is special swapchain key, then verify that image_state valid member is true 547f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else verify that the image's bound memory range is valid 5481facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic bool ValidateImageMemoryIsValid(layer_data *dev_data, IMAGE_STATE *image_state, const char *functionName) { 5491facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state->mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5501facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (!image_state->valid) { 551f48a83f5b5548cd46a12770c7542ff902537ad3eKarl Schultz return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5521facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis reinterpret_cast<uint64_t &>(image_state->mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", 553414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 5541facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis functionName, reinterpret_cast<uint64_t &>(image_state->image)); 5555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5571facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateMemoryIsValid(dev_data, image_state->mem, reinterpret_cast<uint64_t &>(image_state->image), 558dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, functionName); 5595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 5615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 562f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer_node, verify that the range it's bound to is valid 563f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateBufferMemoryIsValid(layer_data *dev_data, BUFFER_NODE *buffer_node, const char *functionName) { 564dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return ValidateMemoryIsValid(dev_data, buffer_node->mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), 565dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, functionName); 566f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 567f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For the given memory allocation, set the range bound by the given handle object to the valid param value 568f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetMemoryValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, bool valid) { 569f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 570f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 571f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis mem_info->bound_ranges[handle].valid = valid; 572f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 573f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 574f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given image node 5751facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis// If mem is special swapchain key, then set entire image_state to valid param value 576f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else set the image's bound memory range to valid param value 5771facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic void SetImageMemoryValid(layer_data *dev_data, IMAGE_STATE *image_state, bool valid) { 5781facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state->mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5791facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->valid = valid; 5805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5811facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetMemoryValid(dev_data, image_state->mem, reinterpret_cast<uint64_t &>(image_state->image), valid); 5825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 584f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer node set the buffer's bound memory range to valid param value 585f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetBufferMemoryValid(layer_data *dev_data, BUFFER_NODE *buffer_node, bool valid) { 586f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetMemoryValid(dev_data, buffer_node->mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), valid); 587f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 5885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 5895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 590e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 591e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 59283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 5955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 59857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 600de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb); 6015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 60272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 6035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 60472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 605c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 6065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 611ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 61256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given sampler and command buffer node 61356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlisvoid AddCommandBufferBindingSampler(GLOBAL_CB_NODE *cb_node, SAMPLER_NODE *sampler_node) { 61456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis sampler_node->cb_bindings.insert(cb_node); 61556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(sampler_node->sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}); 61656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis} 61756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis 61856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given image node and command buffer node 6191facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisvoid AddCommandBufferBindingImage(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_STATE *image_state) { 620ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Skip validation if this image was created through WSI 6211facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state->mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 622ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 6231facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, image_state->mem); 624ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 625de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb_node->commandBuffer); 626ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 6271facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis cb_node->memObjs.insert(image_state->mem); 628ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 629f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis // Now update cb binding for image 6301facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(image_state->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); 6311facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->cb_bindings.insert(cb_node); 632ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 633ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 634ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 63503ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis// Create binding link between given image view node and its image with command buffer node 63603ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlisvoid AddCommandBufferBindingImageView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_VIEW_STATE *view_state) { 63703ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis // First add bindings for imageView 63803ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis view_state->cb_bindings.insert(cb_node); 63903ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis cb_node->object_bindings.insert( 64003ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis {reinterpret_cast<uint64_t &>(view_state->image_view), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}); 6411facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, view_state->create_info.image); 64203ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis // Add bindings for image within imageView 6431facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 6441facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, image_state); 64503ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis } 64603ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis} 64703ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis 648ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// Create binding link between given buffer node and command buffer node 649c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlisvoid AddCommandBufferBindingBuffer(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_NODE *buff_node) { 650ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 651ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, buff_node->mem); 652ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 653de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb_node->commandBuffer); 654ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 655ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->memObjs.insert(buff_node->mem); 656bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 657ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 658ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update cb binding for buffer 659ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis buff_node->cb_bindings.insert(cb_node); 660ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 661ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 66277b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis// Create binding link between given buffer view node and its buffer with command buffer node 66377b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlisvoid AddCommandBufferBindingBufferView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_VIEW_STATE *view_state) { 66477b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis // First add bindings for bufferView 66577b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis view_state->cb_bindings.insert(cb_node); 66677b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis cb_node->object_bindings.insert( 66777b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis {reinterpret_cast<uint64_t &>(view_state->buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}); 66877b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis auto buffer_node = getBufferNode(dev_data, view_state->create_info.buffer); 66977b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis // Add bindings for buffer within bufferView 67077b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis if (buffer_node) { 67177b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buffer_node); 67277b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis } 67377b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis} 67477b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis 675400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 676400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 67772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 678c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 679c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 68057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 6815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 682de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pInfo->command_buffer_bindings.erase(pCBNode->commandBuffer); 6835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 685c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 6865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 6885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 690400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 691400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 692400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 6935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6951cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis// For given MemObjInfo, report Obj & CB bindings. Clear any object bindings. 6961cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlisstatic bool ReportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 69783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 698de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size_t cmdBufRefCount = pMemObjInfo->command_buffer_bindings.size(); 699de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size_t objRefCount = pMemObjInfo->obj_bindings.size(); 7005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 701de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if ((pMemObjInfo->command_buffer_bindings.size()) != 0) { 70283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 70383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 70483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to free memory object 0x%" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 70583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " references", 70683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 709de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (cmdBufRefCount > 0 && pMemObjInfo->command_buffer_bindings.size() > 0) { 710de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto cb : pMemObjInfo->command_buffer_bindings) { 71158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 712de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 713414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%p still has a reference to mem obj 0x%" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 7145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 716de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemObjInfo->command_buffer_bindings.clear(); 7175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 719de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (objRefCount > 0 && pMemObjInfo->obj_bindings.size() > 0) { 720de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto obj : pMemObjInfo->obj_bindings) { 721896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 722414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, 723896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 7241cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis // Clear mem binding for bound objects 7251cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis switch (obj.type) { 7261cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 7271facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, reinterpret_cast<VkImage &>(obj.handle)); 7281facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis assert(image_state); // Any destroyed images should already be removed from bindings 7291facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->mem = MEMORY_UNBOUND; 7301cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis break; 7311cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } 7321cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 7331cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis auto buff_node = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); 7341cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis assert(buff_node); // Any destroyed buffers should already be removed from bindings 735888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis buff_node->mem = MEMORY_UNBOUND; 7361cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis break; 7371cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } 7381cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis default: 7391cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis // Should only have buffer or image objects bound to memory 7401cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis assert(0); 7411cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } 7425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 744de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemObjInfo->obj_bindings.clear(); 7455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 749e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 75083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 75257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 7535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 754ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO: Verify against Valid Use section 755ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Clear any CB bindings for completed CBs 756ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO : Is there a better place to do this? 757ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 758ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller assert(pInfo->object != VK_NULL_HANDLE); 759ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // clear_cmd_buf_and_mem_references removes elements from 760de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis // pInfo->command_buffer_bindings -- this copy not needed in c++14, 761ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // and probably not needed in practice in c++11 762de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis auto bindings = pInfo->command_buffer_bindings; 763ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (auto cb : bindings) { 764ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 765ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller clear_cmd_buf_and_mem_references(dev_data, cb); 7665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 767ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 7681cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis // Now check for any remaining references to this mem obj and remove bindings 769de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (pInfo->command_buffer_bindings.size() || pInfo->obj_bindings.size()) { 7701cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis skip_call |= ReportMemReferencesAndCleanUp(dev_data, pInfo); 7715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 772ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Delete mem obj info 773ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->memObjMap.erase(dev_data->memObjMap.find(mem)); 774ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } else if (VK_NULL_HANDLE != mem) { 775ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // The request is to free an invalid, non-zero handle 776ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 777ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 778ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem), __LINE__, 779ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller MEMTRACK_INVALID_MEM_OBJ, 780ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "MEM", "Request to delete memory object 0x%" 781ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller PRIxLEAST64 " not present in memory Object Map", 782ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem)); 7835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 7885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 789c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 7910a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 7925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 79383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 794888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis VkDeviceMemory *pMemBinding = GetObjectMemBinding(dev_data, handle, type); 79594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 79657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = getMemObjInfo(dev_data, *pMemBinding); 7975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 79894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 7995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 800c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 802de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (!pMemObjInfo->obj_bindings.erase({handle, type})) { 80383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 80458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 805414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 806414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 8075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 8085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 8125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 814888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// For given mem object, verify that it is not null or UNBOUND, if it is, report error. Return skip value. 815888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisbool VerifyBoundMemoryIsValid(const layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, const char *api_name, 816888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis const char *type_name) { 817888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool result = false; 818888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis if (VK_NULL_HANDLE == mem) { 819888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, 820888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 821888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound. Memory should be bound by calling " 822888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "vkBind%sMemory().", 823888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, type_name, handle, type_name); 824888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis } else if (MEMORY_UNBOUND == mem) { 825888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, 826888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 827888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound and previously bound memory was freed. " 828888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "Memory must not be freed prior to this operation.", 829888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, type_name, handle); 830888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis } 831888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis return result; 832888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis} 833888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis 834b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was ever bound to this image 8351facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisbool ValidateMemoryIsBoundToImage(const layer_data *dev_data, const IMAGE_STATE *image_state, const char *api_name) { 836b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 8371facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (0 == (static_cast<uint32_t>(image_state->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { 8381facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis result = VerifyBoundMemoryIsValid(dev_data, image_state->mem, reinterpret_cast<const uint64_t &>(image_state->image), 839888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, "Image"); 840b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 841b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 842b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 843b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 844b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was bound to this buffer 845694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlisbool ValidateMemoryIsBoundToBuffer(const layer_data *dev_data, const BUFFER_NODE *buffer_node, const char *api_name) { 846b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 84712e3a5f6e672b103f705424595ffe3c4687492ceTobin Ehlis if (0 == (static_cast<uint32_t>(buffer_node->createInfo.flags) & VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) { 848888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis result = VerifyBoundMemoryIsValid(dev_data, buffer_node->mem, reinterpret_cast<const uint64_t &>(buffer_node->buffer), 849888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, "Buffer"); 850b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 851b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 852b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 853b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 8575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 859888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic bool SetMemBinding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, VkDebugReportObjectTypeEXT type, 860888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis const char *apiName) { 86183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 86483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 86583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 867888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool sparse = false; 868888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis VkDeviceMemory *mem_binding = GetObjectMemBinding(dev_data, handle, type, &sparse); 869888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis assert(mem_binding); 870888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 871888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis if (mem_info) { 872888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis DEVICE_MEM_INFO *prev_binding = getMemObjInfo(dev_data, *mem_binding); 873888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis if (prev_binding) { 874888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis skip_call |= 875888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 876888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 877888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 878888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis ") which has already been bound to mem object 0x%" PRIxLEAST64, 879888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis apiName, reinterpret_cast<uint64_t &>(mem), handle, reinterpret_cast<uint64_t &>(prev_binding->mem)); 880888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis } else if ((*mem_binding == MEMORY_UNBOUND) && (!sparse)) { 881888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis skip_call |= 882888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 883888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 884888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 885888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis ") which was previous bound to memory that has since been freed. Memory bindings are immutable in " 886888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "Vulkan so this attempt to bind to new memory is not allowed.", 887888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis apiName, reinterpret_cast<uint64_t &>(mem), handle); 8882e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis } else { 889888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis mem_info->obj_bindings.insert({handle, type}); 8902e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // For image objects, make sure default memory state is correctly set 8912e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO : What's the best/correct way to handle this? 8922e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 8931facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto const image_state = getImageState(dev_data, VkImage(handle)); 8941facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 8951facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis VkImageCreateInfo ici = image_state->createInfo; 8962e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 8972e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO:: More memory state transition stuff. 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 901888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis *mem_binding = mem; 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 9130a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 9140a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 9150a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 91683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = VK_FALSE; 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 91983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = clear_object_binding(dev_data, handle, type); 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 921888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis VkDeviceMemory *pMemBinding = GetObjectMemBinding(dev_data, handle, type); 9222e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 92357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 9242e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pInfo) { 925de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pInfo->obj_bindings.insert({handle, type}); 9262e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // Need to set mem binding for this object 9272e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 933caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis// For handle of given object type, return memory binding 934caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlisstatic bool get_mem_for_type(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 935caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis bool skip_call = false; 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 937caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis switch (type) { 938caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 9391facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis *mem = getImageState(dev_data, VkImage(handle))->mem; 940caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 941caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 942caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis *mem = getBufferNode(dev_data, VkBuffer(handle))->mem; 943caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 944caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis default: 945caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis assert(0); 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 947caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis if (!*mem) { 948caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 949caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis "MEM", "Trying to get mem binding for %s object 0x%" PRIxLEAST64 950caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis " but binding is NULL. Has memory been bound to this object?", 951caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis object_type_to_string(type), handle); 952caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis } 953caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis return skip_call; 954caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis} 955caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 9570a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 95958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 96458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 96658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 96758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 97457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = (*ii).second.get(); 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 97757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)mem_info); 97858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 97957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(mem_info->mem)); 98058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 981c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 982de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->command_buffer_bindings.size() + mem_info->obj_bindings.size()); 983de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (0 != mem_info->alloc_info.allocationSize) { 984de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&mem_info->alloc_info, "MEM(INFO): "); 98558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 98858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 994de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->obj_bindings.size()); 995de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->obj_bindings.size() > 0) { 996de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto obj : mem_info->obj_bindings) { 99758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 998414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 1005de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->command_buffer_bindings.size()); 1006de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->command_buffer_bindings.size() > 0) { 1007de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto cb : mem_info->command_buffer_bindings) { 100858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1009414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB 0x%p", cb); 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10150a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 101672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 102472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 102572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 103372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 1036414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has CB 0x%p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1038c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 1040c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 1042414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 10775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 10785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 10795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 10805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 10815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 10825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 10895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 10925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 10935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 10955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 10965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 10995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 11005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 11015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 11025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 11035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 11085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 11305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 11315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 11465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 11475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 11485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 11555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 11595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 11615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 11625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 11635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 11655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 11665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 11675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 11685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 11695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 11705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 11715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 11775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 11785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 11845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 11855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 11865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 11875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 11885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 11895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 11935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 11945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 11995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 12005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 12045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 12055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 12105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 12115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 12125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 12135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 12145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 12305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 12315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 12385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 12475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 12495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 12505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 12525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 12565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 12585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 12595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 12655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 12685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12709ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 12719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 12735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 12745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 12765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 12779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 12789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 12809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 12819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 12839ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 12849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 12869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 12879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 12909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 12919ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 12959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 12989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 12999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 13009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 13029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 13049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 13059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 13069ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 13079ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 13089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 13099ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13119ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 13149ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 13159ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 13179ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 13189ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 13199ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 13219ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 13229ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13249ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 13259ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13299ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 13309ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 13319ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 13329ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 13339ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 13349ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 13359ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 13369ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 133737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 133837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 133937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 134037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 134137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 134237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 134337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 134437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 134537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13527c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 135337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 13547c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 13557c755c8aca6857046df9516d8336416165969cb9Chris Forbes 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 135837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 135937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 136037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 136137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 136237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13697c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 13707c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 137137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 13727c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 13737c755c8aca6857046df9516d8336416165969cb9Chris Forbes 13747c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 13757c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 13767c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 13777c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 13787c755c8aca6857046df9516d8336416165969cb9Chris Forbes 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 13817c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 13847c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 13877c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 138937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 139037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 139137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 139237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 139337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 139437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 139537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 139637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 139737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 139937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 140037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 140537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 141537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1456cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1457cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1458cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1459cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1460cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1461cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1462cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1463cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1464cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1474c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1475c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1476c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1477c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1478c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1479c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1480c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1481c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1482c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1483c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1484c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1485c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1486c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1487c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 14925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1495b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1496fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1500031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1501031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1502031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1503031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1504031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1505031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1506031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1507031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1508031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1509031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1510031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1511031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1512031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1513031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1530edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 15313a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> *out, 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1533b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1535031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 15445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 15465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 15585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 15595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 15605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 15725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1573b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1574fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 15753a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes (*out)[std::make_pair(location + offset, component)] = v; 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15823a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::map<location_t, interface_var> collect_interface_by_location( 15833a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes shader_module const *src, spirv_inst_iter entrypoint, 15843a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes spv::StorageClass sinterface, bool is_array_of_verts) { 15853a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1590b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1613b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1614b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1615b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1616b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 16175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 162281264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1627c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 16325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16333a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> out; 16343a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16401d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1647b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 16607c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1666b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1667fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 16715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 16723a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes collect_interface_block_members(src, &out, blocks, is_array_of_verts, id, type, is_patch); 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16763a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16773a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16803a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<uint32_t, interface_var>> collect_interface_by_input_attachment_index( 16813a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 16823a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 16833a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16843a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<uint32_t, interface_var>> out; 1685745d49409296f060402b57950384caadb636a2b2Chris Forbes 1686745d49409296f060402b57950384caadb636a2b2Chris Forbes for (auto insn : *src) { 1687745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.opcode() == spv::OpDecorate) { 1688745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.word(2) == spv::DecorationInputAttachmentIndex) { 1689745d49409296f060402b57950384caadb636a2b2Chris Forbes auto attachment_index = insn.word(3); 1690745d49409296f060402b57950384caadb636a2b2Chris Forbes auto id = insn.word(1); 1691745d49409296f060402b57950384caadb636a2b2Chris Forbes 1692745d49409296f060402b57950384caadb636a2b2Chris Forbes if (accessible_ids.count(id)) { 1693745d49409296f060402b57950384caadb636a2b2Chris Forbes auto def = src->get_def(id); 1694745d49409296f060402b57950384caadb636a2b2Chris Forbes assert(def != src->end()); 1695745d49409296f060402b57950384caadb636a2b2Chris Forbes 1696745d49409296f060402b57950384caadb636a2b2Chris Forbes if (def.opcode() == spv::OpVariable && insn.word(3) == spv::StorageClassUniformConstant) { 1697e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes auto num_locations = get_locations_consumed_by_type(src, def.word(1), false); 1698e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes for (unsigned int offset = 0; offset < num_locations; offset++) { 1699e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes interface_var v; 1700e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.id = id; 1701e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.type_id = def.word(1); 1702e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.offset = offset; 1703e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_patch = false; 1704e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_block_member = false; 1705e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes out.emplace_back(attachment_index + offset, v); 1706e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes } 1707745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1708745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1709745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1710745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1711745d49409296f060402b57950384caadb636a2b2Chris Forbes } 17123a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 17133a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 1714745d49409296f060402b57950384caadb636a2b2Chris Forbes} 1715745d49409296f060402b57950384caadb636a2b2Chris Forbes 17163a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<descriptor_slot_t, interface_var>> collect_interface_by_descriptor_slot( 17173a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 17183a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 17345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17383a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<descriptor_slot_t, interface_var>> out; 17393a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1752b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1753b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1754fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 1755cefd4dd8e03c5dae11a05d04a03cb856190358e0Chris Forbes out.emplace_back(std::make_pair(set, binding), v); 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17583a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 17593a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1762edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1763031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1765031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17683a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, producer_stage->arrayed_output); 17693a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, consumer_stage->arrayed_input); 17705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1782edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1783080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1784031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1785031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1790edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1792031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1793031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1798fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1799fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1800fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1801fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 18020f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1803fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1804fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 180537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1806edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 18089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 18099ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 18109ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18140f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1815edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 18160f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1817f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 18180f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 18190f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 18200f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 18210f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 18220f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 18230f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 185531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 185631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 185731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 185831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1861f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 187731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 187831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 187931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 188031c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1883f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 1911f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes case spv::OpTypeImage: 1912f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes return get_fundamental_type(src, insn.word(2)); 1913f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1924edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 19265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 19325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1935edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1948edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19523a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, false); 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1957c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1958c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1959c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1960c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1961c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1962c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 19671730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes bool used = false; 19685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 19751730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes if (!used && log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1976080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19801730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = false; 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1983edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 19844b5890faffa54a735782a6b0a628a991ddc86944Mike Weiblen __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Vertex shader consumes input at location %d but not provided", 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 19925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1995edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 19974b5890faffa54a735782a6b0a628a991ddc86944Mike Weiblen "Attribute type of `%s` at location %d does not match vertex shader input type of `%s`", 19989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 19999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 20005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 20051730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = true; 20065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 20075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2013edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 20148da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis spirv_inst_iter entrypoint, VkRenderPassCreateInfo const *rpci, 20158da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis uint32_t subpass_index) { 2016025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 20178da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis auto subpass = rpci->pSubpasses[subpass_index]; 20188da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis for (auto i = 0u; i < subpass.colorAttachmentCount; ++i) { 2019d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis uint32_t attachment = subpass.pColorAttachments[i].attachment; 2020d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (attachment == VK_ATTACHMENT_UNUSED) 2021d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis continue; 2022d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (rpci->pAttachments[attachment].format != VK_FORMAT_UNDEFINED) { 2023d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis color_attachments[i] = rpci->pAttachments[attachment].format; 2024025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 2025025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 2026025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 20305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20313a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, false); 20325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2033025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 2034025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2036025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 2037025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 2038025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 2039025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 2040025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2042025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 2043edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 2045025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "FS writes to output location %d with no matching attachment", it_a->first.first)) { 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2048025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 2049025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 2050edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2051025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", it_b->first)) { 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2054025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 20555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 2056025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 2057025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 20585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 2061edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 2063025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "Attachment %d of type `%s` does not match FS output type of `%s`", it_b->first, 2064025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 2065025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 2071025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 2072025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 20775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 20805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 20883a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::unordered_set<uint32_t> mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint) { 20893a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> ids; 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 20945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 210081264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 21035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 21065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 21115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 21125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 21155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 21165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 21175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 21185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 21195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 21205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 21225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 21275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 21465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 21475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 21485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 21495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 21505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 21515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 21525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 21535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 21555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 21585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 21595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 21645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 21655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 21775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 21785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 2180c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 21815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 21825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 2186c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 21875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 21885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21953a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 21963a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return ids; 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2199edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 2200416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, 22015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 22025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 22035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 22045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 22065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 22075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 22085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 22105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 22115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 22125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 22145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 22175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 2220416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis for (auto const &range : *push_constant_ranges) { 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 2225edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2226080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 22305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 22315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 22355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 2239edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2240080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 22415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 22425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 22435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2254edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 2255416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, shader_module const *src, 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 22605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 22615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 2262416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_block_against_pipeline(report_data, push_constant_ranges, src, 2263416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis src->get_def(def_insn.word(1)), stage); 22645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 22685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2270fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 2271fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 22724a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { 22735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 227537083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2277416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis if (slot.first >= pipelineLayout->set_layouts.size()) 227837083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2280416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis return pipelineLayout->set_layouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 22815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 22845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 22865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 22885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 22895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 22905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 22915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2292e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2295e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 22965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2297e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 22985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2301e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2302e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 23033d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 23043d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 23053d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 2306414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2308e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 23095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 23124c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic PIPELINE_STATE *getPipelineState(layer_data const *my_data, VkPipeline pipeline) { 2313ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 2314ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 2315ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 23165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2317ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 23185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2320127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlisstatic RENDER_PASS_STATE *getRenderPassState(layer_data const *my_data, VkRenderPass renderpass) { 232116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto it = my_data->renderPassMap.find(renderpass); 232216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (it == my_data->renderPassMap.end()) { 232316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return nullptr; 232416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 2325fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes return it->second.get(); 232616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes} 232716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 2328c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic FRAMEBUFFER_STATE *getFramebufferState(const layer_data *my_data, VkFramebuffer framebuffer) { 2329f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto it = my_data->frameBufferMap.find(framebuffer); 2330f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (it == my_data->frameBufferMap.end()) { 2331f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return nullptr; 2332f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes } 233304861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis return it->second.get(); 2334f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes} 2335f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes 2336e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehliscvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { 233711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto it = my_data->descriptorSetLayoutMap.find(dsLayout); 233811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (it == my_data->descriptorSetLayoutMap.end()) { 233911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return nullptr; 234011f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 234111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return it->second; 234211f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes} 234311f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 2344c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlisstatic PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { 23454a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto it = my_data->pipelineLayoutMap.find(pipeLayout); 23464a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (it == my_data->pipelineLayoutMap.end()) { 23474a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return nullptr; 23484a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes } 23494a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return &it->second; 23504a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes} 23514a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes 2352e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 23534c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool isDynamic(const PIPELINE_STATE *pPipeline, const VkDynamicState state) { 23545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 23555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 23565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2357e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 23585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2360e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 23615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 23644c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe, bool indexedDraw) { 23659c4006684a13db43f0dbc8d0015a9ef34872ca09Chris Forbes bool result = false; 2366ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2367ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2368ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 23693d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23703d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 23713d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 237245824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 237345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 23743d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23753d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 23763d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 23773d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 23783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 23803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 238145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 238245824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 23833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 23853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 238645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 238745824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 23883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 23903d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 23923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 23943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 23953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 23963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 23985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 23993d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 24005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 24015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 24045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 24055ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski// If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions 24065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 24075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 24085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 24095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 24105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 24115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 2412e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis // Check potential NULL cases first to avoid nullptr issues later 2413e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pPrimary == nullptr) { 2414e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pSecondary == nullptr) { 2415e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return true; 2416e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 2417e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2418e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } else if (pSecondary == nullptr) { 2419e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2420e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 24215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 242206e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 242306e963555b0df747c98c43816c16647349d21001Mark Young return true; 24245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 242506e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 242606e963555b0df747c98c43816c16647349d21001Mark Young return true; 24275ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else { // Format and sample count must match 24285ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 24295ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return true; 24305ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 24315ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return false; 24325ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } 24335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 24345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 24355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 24365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 24375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 24385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 24405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2442a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// TODO : Scrub verify_renderpass_compatibility() and validateRenderPassCompatibility() and unify them and/or share code 24438da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis// For given primary RenderPass object and secondry RenderPassCreateInfo, verify that they're compatible 2444a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPassCreateInfo *primaryRPCI, 24458da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI, string &errorMsg) { 24465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2447c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 24485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 24495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 24505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 24545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 24555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 24565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 24575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 24585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 24595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 24605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 24615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 24625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2463c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 24645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 24655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 24685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 24695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 24705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2471c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 24725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 24735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2477fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2478fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2479fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2480fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2481fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2482c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2483fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2484fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2485fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2486fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2487fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 24885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 24895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 24905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 24915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 24925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 24935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 24945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2495c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 24965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 24975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 25035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2505397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2506397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2507397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 250869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis PIPELINE_LAYOUT_NODE const *pipeline_layout, const uint32_t layoutIndex, 250969b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis string &errorMsg) { 2510416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto num_sets = pipeline_layout->set_layouts.size(); 25119b5d124aff50234cb0450e1b805baef577c90d83Tobin Ehlis if (layoutIndex >= num_sets) { 2512c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 251369b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorStr << "VkPipelineLayout (" << pipeline_layout->layout << ") only contains " << num_sets 251469b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " 251569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << layoutIndex; 25165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 25175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 25185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2519416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto layout_node = pipeline_layout->set_layouts[layoutIndex]; 2520397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 25215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2524edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2525e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 25265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 25285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 25305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 25315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2532edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 25335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 25345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 25355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 25365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 25375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 25385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 25395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2540e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 25415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 25475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2549edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 25501b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 25515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 25525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25531b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 25541b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 25557b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 25567b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 25575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 25587b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 25597b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 25607b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 25617b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 25627b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 25637b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 25647b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 25655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 25685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 25695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 25705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 25715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 25725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 25735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 25745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 25755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 25765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 25775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 25825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 25835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 258667d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER || 258767d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 25885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 259035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 259135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 259235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 259335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 259435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 259535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 259635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 259735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 259835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 259935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 26005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 26015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 26035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 26045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 26055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 26065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 26075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 26085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 26095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 26105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 26125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 26135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 26145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 26155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 26165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 26175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 26185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 262067d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE || 262167d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 26225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 26235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 26245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 26285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 26295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 26305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 26315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 26325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26354110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2636a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 26374110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2638080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2639a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2640a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2641a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2642a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2643a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2644a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2645a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2646a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2647a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2648a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 264969f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 265069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2651e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2652a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2653a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2654a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2655a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2656a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2657a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2658a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2659a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2660a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2661a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2662a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2663a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2664a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2665a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2666a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2667a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2668a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2669a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 26704110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2671a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2672a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2673a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 26744110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2675a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2676a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2677a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 26784110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2679a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2680a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2681a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 26824110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2683a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2684a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2685a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2686a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 26874110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2688a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2689a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2690a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2691a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 26924110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2693a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2694a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2695a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 26964110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2697a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2698a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2699a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 27004110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2701a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2702a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2703a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2704a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 27054110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2706a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2707a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2708a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2709a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 27104110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2711a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2712a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2713a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2714a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 27154110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2716a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2717a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2718a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2719a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 27204110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2721a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2722a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2723a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 27244110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2725a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2726a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2727a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 27284110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2729a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2730a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2731a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 27324110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2733a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2734a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2735a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 27364110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2737a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2738a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2739a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 27404110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2741a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2742a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2743a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 27444110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2745a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2746a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2747a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 27484110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2749a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2750a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2751a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 27524110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2753a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2754a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2755a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2756a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 27574110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2758a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2759a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2760a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 27614110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2762a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2763a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2764a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2765a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 27664110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2767a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2768a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2769a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2770a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 27714110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2772a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2773a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2774a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 27754110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2776a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2777a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2778a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2779e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2780a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2781a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2782a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2783a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2784a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2785a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2786a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2787a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2788b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2789b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbesstatic uint32_t descriptor_type_to_reqs(shader_module const *module, uint32_t type_id) { 27902aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto type = module->get_def(type_id); 27912aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 27922aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes while (true) { 27932aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (type.opcode()) { 27942aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeArray: 27952aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeSampledImage: 27962aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(2)); 27972aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 27982aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypePointer: 27992aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(3)); 28002aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 28012aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeImage: { 28022aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto dim = type.word(3); 28032aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto arrayed = type.word(5); 28042aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto msaa = type.word(6); 28052aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 28062aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (dim) { 28072aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim1D: 2808488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_1D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_1D; 28092aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim2D: 28102aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return (msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE) | 2811488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes (arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_2D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_2D); 28122aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim3D: 28132aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return DESCRIPTOR_REQ_VIEW_TYPE_3D; 28142aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::DimCube: 2815488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_CUBE_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_CUBE; 281628db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes case spv::DimSubpassData: 281728db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes return msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE; 281828db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes default: // buffer, etc. 28192aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 28202aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 28212aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 28222aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes default: 28232aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 28242aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 28252aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 2826b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes} 2827b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 28284c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool 28294c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisvalidate_pipeline_shader_stage(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *pStage, 28304c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pipeline, shader_module **out_module, spirv_inst_iter *out_entrypoint, 28314c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis VkPhysicalDeviceFeatures const *enabledFeatures, 28324c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis std::unordered_map<VkShaderModule, std::unique_ptr<shader_module>> const &shaderModuleMap) { 2833e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 283469f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 283569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 283678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 283778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 283878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 283978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2840557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2841080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 284278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 284378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 28440cfa9c3a1747749777581684536218f83c3977a9Chris Forbes return false; // no point continuing beyond here, any analysis is just going to be garbage. 284578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 284678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 284778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 284878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2849557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 285078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 285178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 28523a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto accessible_ids = mark_accessible_ids(module, entrypoint); 285378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 285478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 28553a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto descriptor_uses = collect_interface_by_descriptor_slot(report_data, module, accessible_ids); 285678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 28572e0eca3d6fad72a29ae072e3895e29a2d2d66476Tobin Ehlis auto pipelineLayout = pipeline->pipeline_layout; 2858ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 28590cfa9c3a1747749777581684536218f83c3977a9Chris Forbes pass &= validate_specialization_offsets(report_data, pStage); 2860416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_usage(report_data, &pipelineLayout.push_constant_ranges, module, accessible_ids, pStage->stage); 286178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 286278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 286378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 286478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 2865b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes auto & reqs = pipeline->active_slots[use.first.first][use.first.second]; 2866b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes reqs = descriptor_req(reqs | descriptor_type_to_reqs(module, use.second.type_id)); 286778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2868fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 2869c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis const auto &binding = get_descriptor_binding(&pipelineLayout, use.first); 287078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 287178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 287278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2873557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2874080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 287578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 287678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2877e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 287878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 287978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2880557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 288178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 288278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 288378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 288478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2885fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 288678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2887e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 288878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2889edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2890fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2891557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2892fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2893fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2894fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2895fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 289678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2897e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 289878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 289978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2900557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2901fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 290278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 290378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2904fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2905e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 290678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 290778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 290878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 290978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2910c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes /* validate use of input attachments against subpass structure */ 2911c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (pStage->stage == VK_SHADER_STAGE_FRAGMENT_BIT) { 29123a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto input_attachment_uses = collect_interface_by_input_attachment_index(report_data, module, accessible_ids); 2913c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2914c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto rpci = pipeline->render_pass_ci.ptr(); 2915c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto subpass = pipeline->graphicsPipelineCI.subpass; 2916c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2917c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes for (auto use : input_attachment_uses) { 2918c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto input_attachments = rpci->pSubpasses[subpass].pInputAttachments; 2919c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto index = (input_attachments && use.first < rpci->pSubpasses[subpass].inputAttachmentCount) ? 2920c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes input_attachments[use.first].attachment : VK_ATTACHMENT_UNUSED; 2921c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2922c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (index == VK_ATTACHMENT_UNUSED) { 2923c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2924c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes SHADER_CHECKER_MISSING_INPUT_ATTACHMENT, "SC", 2925c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes "Shader consumes input attachment index %d but not provided in subpass", 2926c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes use.first)) { 2927c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes pass = false; 2928c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2929c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2930eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes else if (get_format_type(rpci->pAttachments[index].format) != 2931eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes get_fundamental_type(module, use.second.type_id)) { 2932eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2933eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes SHADER_CHECKER_INPUT_ATTACHMENT_TYPE_MISMATCH, "SC", 2934eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes "Subpass input attachment %u format of %s does not match type used in shader `%s`", 2935eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes use.first, string_VkFormat(rpci->pAttachments[index].format), 2936eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes describe_type(module, use.second.type_id).c_str())) { 2937eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes pass = false; 2938eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2939eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2940c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2941c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2942c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 294378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 294478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 294578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 294678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2947a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2948a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 29494c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool 29504c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisvalidate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_STATE *pPipeline, 29514c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis VkPhysicalDeviceFeatures const *enabledFeatures, 29524c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const &shaderModuleMap) { 29536660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 29545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 29555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 29565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 29585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 29595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 29605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 29615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2962e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 29635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 29656660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 296678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2967e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 296869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 296969f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 29705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2972d5365427feb4a6c16371ecb651afa37b89dabd96Chris Forbes // if the shader stages are no good individually, cross-stage validation is pointless. 2973b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes if (!pass) 2974b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes return false; 2975b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes 29765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 29775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2979e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 29805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2983e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 29845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 29875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 29885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 29905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 29915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 29925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 29955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 29965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2997e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2998031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2999031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 30005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 30025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30058da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis if (shaders[fragment_stage]) { 3006e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 30078da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis pPipeline->render_pass_ci.ptr(), pCreateInfo->subpass); 30085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 30115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 30125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30134c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_STATE *pPipeline, 30144c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis VkPhysicalDeviceFeatures const *enabledFeatures, 30154c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const &shaderModuleMap) { 30166660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 301703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 301803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 301903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 302003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 3021e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 302269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 302303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 30245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 3025a682b1c533d9a492243b363c6585c4f03bcd87aaTobin Ehliscvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { 3026104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis auto set_it = my_data->setMap.find(set); 3027104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis if (set_it == my_data->setMap.end()) { 30285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 30295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3030104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return set_it->second; 30315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 30327a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 30337a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 30347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 30357a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 30367a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 30377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 30387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 3039e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 30407a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 30411abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 30421abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis &activeSetBindingsPairs, 30431abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const char *function) { 3044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 3045a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 3046dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes cvdescriptorset::DescriptorSet *set_node = std::get<0>(set_bindings_pair); 3047cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 3048dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (!set_node->ValidateDrawState(std::get<1>(set_bindings_pair), *std::get<2>(set_bindings_pair), 3049397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 3050cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 3051397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 3052cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 3053cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 3054e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski "DS 0x%" PRIxLEAST64 " encountered the following validation error at %s() time: %s", 3055e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski reinterpret_cast<const uint64_t &>(set), function, err_str.c_str()); 3056cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 3057dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes set_node->GetStorageUpdates(std::get<1>(set_bindings_pair), &pCB->updateBuffers, &pCB->updateImages); 30585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 30605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 30615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3062eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 30634c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic VkSampleCountFlagBits getNumSamples(PIPELINE_STATE const *pipe) { 3064ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 3065ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 3066eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 3067eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3068eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 3069eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 3070eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 3071b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbesstatic void list_bits(std::ostream& s, uint32_t bits) { 3072b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes for (int i = 0; i < 32 && bits; i++) { 3073b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits & (1 << i)) { 3074b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << i; 3075b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes bits &= ~(1 << i); 3076b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits) { 3077b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << ","; 3078b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 3079b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 3080b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 3081b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes} 3082b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 3083eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 30844c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool validatePipelineDrawtimeState(layer_data const *my_data, LAST_BOUND_STATE const &state, const GLOBAL_CB_NODE *pCB, 30854c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE const *pPipeline) { 3086eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 308729d196e071b2dc1db47702085469396f2b956820Chris Forbes 308829d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify Vtx binding 308929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pPipeline->vertexBindingDescriptions.size() > 0) { 309029d196e071b2dc1db47702085469396f2b956820Chris Forbes for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { 3091312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis auto vertex_binding = pPipeline->vertexBindingDescriptions[i].binding; 3092312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (vertex_binding + 1)) || 3093312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis (pCB->currentDrawData.buffers[vertex_binding] == VK_NULL_HANDLE)) { 3094312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis skip_call |= log_msg( 3095312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3096312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 3097312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "The Pipeline State Object (0x%" PRIxLEAST64 ") expects that this Command Buffer's vertex binding Index %u " 3098312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "should be set via vkCmdBindVertexBuffers. This is because VkVertexInputBindingDescription struct " 3099312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "at index " PRINTF_SIZE_T_SPECIFIER " of pVertexBindingDescriptions has a binding value of %u.", 31004c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis (uint64_t)state.pipeline_state->pipeline, vertex_binding, i, vertex_binding); 310129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 310229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 310329d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 310429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pCB->currentDrawData.buffers.empty()) { 310529d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 31065c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 31075c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 31085c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 31094c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline_state->pipeline); 311029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 311129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 311229d196e071b2dc1db47702085469396f2b956820Chris Forbes // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 311329d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip check if rasterization is disabled or there is no viewport. 311429d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((!pPipeline->graphicsPipelineCI.pRasterizationState || 311529d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 311629d196e071b2dc1db47702085469396f2b956820Chris Forbes pPipeline->graphicsPipelineCI.pViewportState) { 311729d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 311829d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 3119b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 312029d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynViewport) { 3121b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredViewportsMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->viewportCount) - 1; 3122b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingViewportMask = ~pCB->viewportMask & requiredViewportsMask; 3123b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingViewportMask) { 3124b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 3125b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic viewport(s) "; 3126b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingViewportMask); 3127b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << " are used by PSO, but were not provided via calls to vkCmdSetViewport()."; 3128b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3129b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3130b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 313129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 313229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3133b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 313429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynScissor) { 3135b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredScissorMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->scissorCount) - 1; 3136b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingScissorMask = ~pCB->scissorMask & requiredScissorMask; 3137b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingScissorMask) { 3138b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 3139b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic scissor(s) "; 3140b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingScissorMask); 3141b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << " are used by PSO, but were not provided via calls to vkCmdSetScissor()."; 3142b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3143b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3144b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 314529d196e071b2dc1db47702085469396f2b956820Chris Forbes } 314629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 314729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 314829d196e071b2dc1db47702085469396f2b956820Chris Forbes 314929d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify that any MSAA request in PSO matches sample# in bound FB 315029d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip the check if rasterization is disabled. 315129d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pPipeline->graphicsPipelineCI.pRasterizationState || 315229d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 315329d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 315429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->activeRenderPass) { 3155fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const render_pass_info = pCB->activeRenderPass->createInfo.ptr(); 315629d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 315729d196e071b2dc1db47702085469396f2b956820Chris Forbes uint32_t i; 315829d196e071b2dc1db47702085469396f2b956820Chris Forbes 315929d196e071b2dc1db47702085469396f2b956820Chris Forbes const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 316029d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 316129d196e071b2dc1db47702085469396f2b956820Chris Forbes (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 316229d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3163eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3164ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 3165eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 3166414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 3167eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 3168eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 3169ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 317029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3171eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 317276957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes unsigned subpass_num_samples = 0; 31730a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 317429d196e071b2dc1db47702085469396f2b956820Chris Forbes for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 317576957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pColorAttachments[i].attachment; 317676957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (attachment != VK_ATTACHMENT_UNUSED) 317776957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 317829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 31790a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 318076957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (subpass_desc->pDepthStencilAttachment && 318176957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 318276957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pDepthStencilAttachment->attachment; 318376957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 318429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3185eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 31860dc3fd4e57b8531638781daa01a2fb5d1048a6fbJamie Madill if (subpass_num_samples && static_cast<unsigned>(pso_num_samples) != subpass_num_samples) { 318729d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3188eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3189ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 3190414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 3191414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 3192ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 3193ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 3194eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 319529d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 319629d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 319729d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 319829d196e071b2dc1db47702085469396f2b956820Chris Forbes "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 319929d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 3200eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3201eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3202528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // Verify that PSO creation renderPass is compatible with active renderPass 3203528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (pCB->activeRenderPass) { 3204528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis std::string err_string; 3205a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != pPipeline->graphicsPipelineCI.renderPass) && 3206fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes !verify_renderpass_compatibility(my_data, pCB->activeRenderPass->createInfo.ptr(), pPipeline->render_pass_ci.ptr(), 3207528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis err_string)) { 3208528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with 3209528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis skip_call |= 3210528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3211528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 3212528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " 3213528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 3214528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), reinterpret_cast<uint64_t &>(pPipeline), 3215528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); 3216528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 3217c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes 3218c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes if (pPipeline->graphicsPipelineCI.subpass != pCB->activeSubpass) { 3219c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes skip_call |= 3220c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3221c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes reinterpret_cast<uint64_t const &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 3222c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes "Pipeline was built for subpass %u but used in subpass %u", pPipeline->graphicsPipelineCI.subpass, 3223c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes pCB->activeSubpass); 3224c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes } 3225528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 322629d196e071b2dc1db47702085469396f2b956820Chris Forbes // TODO : Add more checks here 322729d196e071b2dc1db47702085469396f2b956820Chris Forbes 3228eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 3229eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 3230eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 32315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 3232aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlisstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *cb_node, const bool indexedDraw, 3233e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski const VkPipelineBindPoint bindPoint, const char *function) { 3234e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 3235aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis auto const &state = cb_node->lastBound[bindPoint]; 32364c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pPipe = state.pipeline_state; 323722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 323822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 323922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 324022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 324122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 324222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 324322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 324422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 324522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 32463d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 32477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3248aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result = validate_draw_state_flags(my_data, cb_node, pPipe, indexedDraw); 32497a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 32505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 325169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (VK_NULL_HANDLE != state.pipeline_layout.layout) { 325222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 325369b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = pPipe->pipeline_layout; 3254169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes 325522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 32561abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 32571abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis activeSetBindingsPairs; 3258dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes for (auto & setBindingPair : pPipe->active_slots) { 325922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 326022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 326122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 326222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 326322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 3264414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 326522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 326669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], &pipeline_layout, setIndex, 326769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString)) { 326869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis // Set is bound but not compatible w/ overlapping pipeline_layout from PSO 326971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); 327022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 327122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 327222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 3273414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 3274414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 327569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis reinterpret_cast<uint64_t &>(setHandle), setIndex, reinterpret_cast<uint64_t &>(pipeline_layout.layout), 327669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString.c_str()); 327722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 327822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 327971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis cvdescriptorset::DescriptorSet *pSet = state.boundDescriptorSets[setIndex]; 3280aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Gather active bindings 3281aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis std::unordered_set<uint32_t> bindings; 3282aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : setBindingPair.second) { 3283aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis bindings.insert(binding.first); 3284aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis } 3285aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Bind this set and its active descriptor resources to the command buffer 3286aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis pSet->BindCommandBuffer(cb_node, bindings); 328722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 3288aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis activeSetBindingsPairs.push_back(std::make_tuple(pSet, setBindingPair.second, &state.dynamicOffsets[setIndex])); 328922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 329022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 3291397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 3292aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : bindings) { 3293aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 329422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 329522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 3296397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 3297414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 329822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 3299397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 3300fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 33015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 330422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 330522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 3306aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, cb_node, activeSetBindingsPairs, function); 330722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 3308eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 3309eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 331029d196e071b2dc1db47702085469396f2b956820Chris Forbes if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3311aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validatePipelineDrawtimeState(my_data, state, cb_node, pPipe); 3312eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 33135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3316a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 3317a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 3318a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 3319a27508babf63d50aea75883a3702979193c23683Mark Young 3320a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 3321f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if ((VK_FALSE == my_data->enabled_features.wideLines) && (1.0f != lineWidth)) { 3322a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 3323a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 3324a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 3325a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 3326a27508babf63d50aea75883a3702979193c23683Mark Young } else { 3327a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 3328a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 3329a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 3330a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 3331a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 3332a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 3333a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 3334a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 3335a27508babf63d50aea75883a3702979193c23683Mark Young } 3336a27508babf63d50aea75883a3702979193c23683Mark Young } 3337a27508babf63d50aea75883a3702979193c23683Mark Young 3338a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 3339a27508babf63d50aea75883a3702979193c23683Mark Young} 3340a27508babf63d50aea75883a3702979193c23683Mark Young 33415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 33424c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_STATE *> pPipelines, 3343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 334483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 33455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33464c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pPipeline = pPipelines[pipelineIndex]; 33475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 33505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 33515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 33524c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pBasePipeline = nullptr; 33535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 33545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 335583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 335683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 335783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 33585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 336083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 33615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 33665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 33684c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pBasePipeline = getPipelineState(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 33695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 337283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 337383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 337483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3379f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!my_data->enabled_features.independentBlend) { 33803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 338126c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3382c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 338306811df0256552cd7da9d7297672af377463fc4aMark Mueller // Quoting the spec: "If [the independent blend] feature is not enabled, the VkPipelineColorBlendAttachmentState 338406811df0256552cd7da9d7297672af377463fc4aMark Mueller // settings for all color attachments must be identical." VkPipelineColorBlendAttachmentState contains 338506811df0256552cd7da9d7297672af377463fc4aMark Mueller // only attachment state, so memcmp is best suited for the comparison 338606811df0256552cd7da9d7297672af377463fc4aMark Mueller if (memcmp(static_cast<const void *>(pAttachments), static_cast<const void *>(&pAttachments[i]), 338706811df0256552cd7da9d7297672af377463fc4aMark Mueller sizeof(pAttachments[0]))) { 338883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 338983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INDEPENDENT_BLEND, "DS", 339083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: If independent blend feature not " 339183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "enabled, all elements of pAttachments must be identical"); 339206811df0256552cd7da9d7297672af377463fc4aMark Mueller break; 3393c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 33945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3397f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!my_data->enabled_features.logicOp && 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 339983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3406a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 3409127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = getRenderPassState(my_data, pPipeline->graphicsPipelineCI.renderPass); 3410fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes if (renderPass && pPipeline->graphicsPipelineCI.subpass >= renderPass->createInfo.subpassCount) { 341183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 341283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 341383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is out of range for this renderpass (0..%u)", 3414fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes pPipeline->graphicsPipelineCI.subpass, renderPass->createInfo.subpassCount - 1); 34155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3417f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->enabled_features, 341869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 341983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = true; 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 342152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 342252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 342352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 342452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 342583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 342683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 342783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 342883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 342952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 343052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 343152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 34325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 343483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 34375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 344183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 344283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 344383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 34445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 34465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 34475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 345083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 345183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 345283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 34535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 34555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 34565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3457ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3458ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 345983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 346083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 346183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 346283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology for tessellation pipelines"); 34635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3464ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3465ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 34665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 346783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 346883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 346983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 347083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 347183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology is only valid for tessellation pipelines"); 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3473ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 347483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 347583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 347683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: " 347783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 347883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3479ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3480ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 348183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 348283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 348383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 348483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used with patchControlPoints value %u." 348583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " patchControlPoints should be >0 and <=32.", 348683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 34875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3489a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3490a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3491a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 349283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 349383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3494a27508babf63d50aea75883a3702979193c23683Mark Young } 3495a27508babf63d50aea75883a3702979193c23683Mark Young } 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 34985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 34995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 350045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 350283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 350383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 350483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "and scissors are dynamic PSO must include " 350583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 350883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 350983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 351083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 351183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 351283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 35135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3515e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3516e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 35175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 35185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 35195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 352083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 352183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 352283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 352383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 352483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 352583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetViewport().", 352683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 353283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 353383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 353483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 353583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 353683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetScissor().", 353783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35415dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes 35425dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes // If rasterization is not disabled, and subpass uses a depth/stencil 35435dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes // attachment, pDepthStencilState must be a pointer to a valid structure 3544fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto subpass_desc = renderPass ? &renderPass->createInfo.pSubpasses[pPipeline->graphicsPipelineCI.subpass] : nullptr; 35455dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes if (subpass_desc && subpass_desc->pDepthStencilAttachment && 35465dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 35475dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes if (!pPipeline->graphicsPipelineCI.pDepthStencilState) { 35485dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 35495dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 35505dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "Invalid Pipeline CreateInfo State: " 35515dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "pDepthStencilState is NULL when rasterization is enabled and subpass uses a " 35525dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "depth/stencil attachment"); 35535dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes } 35545dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes } 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 355683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 35575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 35605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 35615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 35625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3563ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3564ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 3572a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin EhlisDESCRIPTOR_POOL_STATE *getDescriptorPoolState(const layer_data *dev_data, const VkDescriptorPool pool) { 3573bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis auto pool_it = dev_data->descriptorPoolMap.find(pool); 3574bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis if (pool_it == dev_data->descriptorPoolMap.end()) { 35755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 35765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3577bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis return pool_it->second; 35785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3580e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3581e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 35835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 35845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3585e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 35865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 35875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 36005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3608fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3610fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3613fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3616fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3619fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3620e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 362283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 36231d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 36265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 36275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 36295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3630e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 363383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 363483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 363583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 363683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 363883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 3639fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 364083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 3641fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3642fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3643fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3644fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 364783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 36504a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 36514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 36524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 36534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 36544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 36564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 36574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 36584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 36594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 36604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 36624a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 36634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 36644a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 36654a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 36664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36674a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 36684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 36694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 36704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 36714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 36724a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 36744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 36754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 36764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 36774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 36784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 36794a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 36804a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36814a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 36824a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 36834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 36844a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 36854a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 36864a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36874a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 36884a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 36894a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 36904a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 36914a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 36924a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36934a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 36944a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 36954a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 36964a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 37004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 37014a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 37024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 37034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 37044a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 37054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 37074a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 37104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 37174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 37184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 37194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 37204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 37214a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 37224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 37235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 37244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 37274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 37411facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(my_data, image); 37421facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (!image_state) 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 37471facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (sub_data->second.size() >= (image_state->createInfo.arrayLayers * image_state->createInfo.mipLevels + 1)) { 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 37515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 37535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 37545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 37555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 37565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 37595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 37635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 37645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 37655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 37665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 37695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 377408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 37755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 377708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 377808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 377908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 378008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 37815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 378408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 378608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 378708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 37937068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 37947068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 37957068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 379608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 380008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 380108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 380208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 380308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 380408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 380508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 380808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 380908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 381108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 381208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 381308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 381408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 381708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 381908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 38205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 382379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, imageView); 382479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis assert(view_state); 382512d5600c2f9e32343016fd944432ba95df370797Tobin Ehlis auto image = view_state->create_info.image; 382679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 3833915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // TODO: If ImageView was created with depth or stencil, transition both layouts as 3834915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // the aspectMask is ignored and both are used. Verify that the extra implicit layout 3835915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // is OK for descriptor set layout validation 3836038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski if (subRange.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 383779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (vk_format_is_depth_and_stencil(view_state->create_info.format)) { 3838038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski sub.aspectMask |= (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); 3839038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 3840038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 38425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3848e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3849e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 38500dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlisstatic bool validateIdleDescriptorSet(const layer_data *dev_data, VkDescriptorSet set, std::string func_str) { 38510dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis if (dev_data->instance_state->disabled.idle_descriptor_set) 38520dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis return false; 3853e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 38540dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis auto set_node = dev_data->setMap.find(set); 38550dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis if (set_node == dev_data->setMap.end()) { 38560dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3858414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38611c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis // TODO : This covers various error cases so should pass error enum into this function and use passed in enum here 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 38631c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis skip_call |= 38640dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 38651c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis (uint64_t)(set), __LINE__, VALIDATION_ERROR_00919, "DS", 38661c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer. %s", 38671c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis func_str.c_str(), (uint64_t)(set), validation_error_map[VALIDATION_ERROR_00919]); 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3872f80bf38f4fb3f177b3e1be11b7b1c5edcdbf7d9bChris Forbes 3873e6651096ed8f07840447783c66827cc16d659a49Tobin Ehlis// Remove set from setMap and delete the set 38749dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 38759dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 38769dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 38779dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 38795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3884c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3885cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 38869dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3888f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 3895a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *pPool = getDescriptorPoolState(my_data, pool); 3896de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // TODO: validate flags 3897de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3898de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (auto ds : pPool->sets) { 3899de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis freeDescriptorSet(my_data, ds); 3900de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis } 3901de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->sets.clear(); 3902de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // Reset available count for each type and available sets for this pool 3903de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 3904de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3906de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableSets = pPool->maxSets; 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 39105121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 39115121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 39125121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 391372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 391472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3915414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39185121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 39195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3923400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3932e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3938e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3940e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3941e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 3942d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && 3943d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 39485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 39735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3981a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool addCmd(layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 398283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 3983a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(my_data, pCB->createInfo.commandPool); 3984a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (pPool) { 3985a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].queueFlags; 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 400083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 40055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 40075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 40085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 40095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 40105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 40125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 40135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 40155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 40185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 40195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 402483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 402883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 40325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 40335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 40375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 40387651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis case CMD_END: 40395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 40415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 404583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 40467651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else { 404783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 40515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 40525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 40535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 405483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 40555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40567e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// For given object struct return a ptr of BASE_NODE type for its wrapping struct 40577e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin EhlisBASE_NODE *GetStateStructPtrFromObject(layer_data *dev_data, VK_OBJECT object_struct) { 40587e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis BASE_NODE *base_ptr = nullptr; 40597e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis switch (object_struct.type) { 40607e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 40617e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(object_struct.handle)); 40627e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40637e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40647e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 40657e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getSamplerNode(dev_data, reinterpret_cast<VkSampler &>(object_struct.handle)); 40667e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40677e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40687e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 40697e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(object_struct.handle)); 40707e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40717e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40727e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 40734c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis base_ptr = getPipelineState(dev_data, reinterpret_cast<VkPipeline &>(object_struct.handle)); 4074bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 4075bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 4076bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 40777e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(object_struct.handle)); 40787e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40797e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40807e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { 40817e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(object_struct.handle)); 40827e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40837e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40847e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 40851facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis base_ptr = getImageState(dev_data, reinterpret_cast<VkImage &>(object_struct.handle)); 40867e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40877e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40887e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { 40897e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(object_struct.handle)); 4090bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 4091bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 40929822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 40937e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getEventNode(dev_data, reinterpret_cast<VkEvent &>(object_struct.handle)); 40949822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis break; 40959822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis } 40967e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { 4097a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis base_ptr = getDescriptorPoolState(dev_data, reinterpret_cast<VkDescriptorPool &>(object_struct.handle)); 4098ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis break; 4099ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 41007e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { 41017e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(object_struct.handle)); 4102a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis break; 4103a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 41047e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { 4105c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis base_ptr = getFramebufferState(dev_data, reinterpret_cast<VkFramebuffer &>(object_struct.handle)); 4106a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4107a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 41087e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { 4109127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis base_ptr = getRenderPassState(dev_data, reinterpret_cast<VkRenderPass &>(object_struct.handle)); 41107e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 41117e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 41127e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { 41137e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(object_struct.handle)); 411456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 411556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 4116bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis default: 41177e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis // TODO : Any other objects to be handled here? 41187e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis assert(0); 41197e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 4120bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 41217e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return base_ptr; 41227e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis} 41237e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis 41247e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// Tie the VK_OBJECT to the cmd buffer which includes: 41257e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// Add object_binding to cmd buffer 41267e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// Add cb_binding to object 41277e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlisstatic void addCommandBufferBinding(std::unordered_set<GLOBAL_CB_NODE *> *cb_bindings, VK_OBJECT obj, GLOBAL_CB_NODE *cb_node) { 41287e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis cb_bindings->insert(cb_node); 41297e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis cb_node->object_bindings.insert(obj); 41307e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis} 41317e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// For a given object, if cb_node is in that objects cb_bindings, remove cb_node 41327e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlisstatic void removeCommandBufferBinding(layer_data *dev_data, VK_OBJECT const *object, GLOBAL_CB_NODE *cb_node) { 41337e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis BASE_NODE *base_obj = GetStateStructPtrFromObject(dev_data, *object); 41347e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis if (base_obj) 41357e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj->cb_bindings.erase(cb_node); 4136bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis} 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 4139400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 4140400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 41415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 4142b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 4153b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask = 0; 4154b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask = 0; 415593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 415672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 415772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 415872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 415993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 41605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 4161ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 41625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 4164e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis pCB->broken_bindings.clear(); 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 4167c7e6bc41aa9c6e5a677b138b9459b252cd3bedf2Mark Lobodzinski pCB->writeEventsBeforeWait.clear(); 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 4172abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 4178bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 4179bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 4180bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 4181bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 41837a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 41847a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 4185400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 4186b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 4187d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.clear(); 418893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 4189bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis // Remove object bindings 4190bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis for (auto obj : pCB->object_bindings) { 4191bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis removeCommandBufferBinding(dev_data, &obj, pCB); 4192bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 4193a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis pCB->object_bindings.clear(); 419493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 419593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 4196c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto fb_state = getFramebufferState(dev_data, framebuffer); 4197c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis if (fb_state) 4198c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis fb_state->cb_bindings.erase(pCB); 419993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 420093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 42017003b38da5cc27a063af3c45080f3a35438283eeTobin Ehlis pCB->activeFramebuffer = VK_NULL_HANDLE; 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 42064c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe) { 42075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 4208ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 4209ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 42101afd60fa23eaee2000e232efd5d05a64224a91dcTony Barbour pCB->status |= CBSTATUS_ALL; 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 42155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 4216ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 4217ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 42225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 42253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 42295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 42355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 42375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 42385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 42405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 42415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 42455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 4249e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 425083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 42515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 42525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 42534c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_state; 42545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 42555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 425783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 425883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 425983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 426083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 426183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis .c_str()); 42625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 426483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 42655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 42685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 42695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 42705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 4271414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "Cmds in CB 0x%p", (void *)cb); 42725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 42735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 42745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 42755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4276414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 42775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 42805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4283e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 428483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 42855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 428683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 42875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 428883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= printPipeline(my_data, cb); 428983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 42905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 42935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 4294e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4295e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 42965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 42975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 4299414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 4300ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 4307e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4308e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 43105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 43115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 43125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 43135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 43145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 43175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4319f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstatic void init_core_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 4320d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4321b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4325747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesstatic void checkInstanceRegisterExtensions(const VkInstanceCreateInfo *pCreateInfo, instance_layer_data *instance_data) { 4326747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 4327747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SURFACE_EXTENSION_NAME)) 4328747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->surfaceExtensionEnabled = true; 4329747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_EXTENSION_NAME)) 4330747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->displayExtensionEnabled = true; 4331747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_ANDROID_KHR 4332747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_ANDROID_SURFACE_EXTENSION_NAME)) 4333747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->androidSurfaceExtensionEnabled = true; 4334747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4335747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_MIR_KHR 4336747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_MIR_SURFACE_EXTENSION_NAME)) 4337747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->mirSurfaceExtensionEnabled = true; 4338747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4339747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WAYLAND_KHR 4340747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME)) 4341747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->waylandSurfaceExtensionEnabled = true; 4342747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4343747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WIN32_KHR 4344747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_WIN32_SURFACE_EXTENSION_NAME)) 4345747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->win32SurfaceExtensionEnabled = true; 4346747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4347747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XCB_KHR 4348747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_XCB_SURFACE_EXTENSION_NAME)) 4349747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->xcbSurfaceExtensionEnabled = true; 4350747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4351747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XLIB_KHR 4352747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_XLIB_SURFACE_EXTENSION_NAME)) 4353747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->xlibSurfaceExtensionEnabled = true; 4354747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4355747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 4356747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 4357747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 435889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 435989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 43605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 43615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 43635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 43645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 43655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 43665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 43675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 43695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 43705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 43725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 43735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 43745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4375f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), instance_layer_data_map); 437656a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 43779172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes layer_init_instance_dispatch_table(*pInstance, &instance_data->dispatch_table, fpGetInstanceProcAddr); 43785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43799172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->report_data = debug_report_create_instance( 43809172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes &instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, pCreateInfo->ppEnabledExtensionNames); 4381747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes checkInstanceRegisterExtensions(pCreateInfo, instance_data); 4382b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 4383825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski 4384b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski instance_data->instance_state = unique_ptr<INSTANCE_STATE>(new INSTANCE_STATE()); 43855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 43885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 439189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 43925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 43935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 43945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 43955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 43969172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_layer_data *instance_data = get_my_data_ptr(key, instance_layer_data_map); 43979172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.DestroyInstance(instance, pAllocator); 43985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4399b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 44005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 44019172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes while (instance_data->logging_callback.size() > 0) { 44029172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes VkDebugReportCallbackEXT callback = instance_data->logging_callback.back(); 44039172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes layer_destroy_msg_callback(instance_data->report_data, callback, pAllocator); 44049172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->logging_callback.pop_back(); 44055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44079172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes layer_debug_report_destroy_instance(instance_data->report_data); 44085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4411373469f006399d6b5204ee05db3b56beb168b36fMark Youngstatic void checkDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 44125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 44135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 44145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 44165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 4417c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_extensions.wsi_display_swapchain_enabled = false; 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 44205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 44215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 4422c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_SWAPCHAIN_EXTENSION_NAME) == 0) 4423c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_extensions.wsi_display_swapchain_enabled = true; 44245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4427838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski// Verify that queue family has been properly requested 4428f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesbool ValidateRequestedQueueFamilyProperties(instance_layer_data *instance_data, VkPhysicalDevice gpu, const VkDeviceCreateInfo *create_info) { 4429838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski bool skip_call = false; 44304b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes auto physical_device_state = getPhysicalDeviceState(instance_data, gpu); 4431838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // First check is app has actually requested queueFamilyProperties 44324b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (!physical_device_state) { 44334b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4434838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", 4435838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid call to vkCreateDevice() w/o first calling vkEnumeratePhysicalDevices()."); 44364b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes } else if (QUERY_DETAILS != physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 4437838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // TODO: This is not called out as an invalid use in the spec so make more informative recommendation. 44384b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 4439838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, 4440838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "DL", "Call to vkCreateDevice() w/o first calling vkGetPhysicalDeviceQueueFamilyProperties()."); 4441838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else { 4442838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // Check that the requested queue properties are valid 4443838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski for (uint32_t i = 0; i < create_info->queueCreateInfoCount; i++) { 4444838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski uint32_t requestedIndex = create_info->pQueueCreateInfos[i].queueFamilyIndex; 44457d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes if (requestedIndex >= physical_device_state->queue_family_properties.size()) { 4446838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg( 44474b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 4448838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4449838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). Invalid queueFamilyIndex %u requested.", requestedIndex); 4450838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else if (create_info->pQueueCreateInfos[i].queueCount > 44517d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes physical_device_state->queue_family_properties[requestedIndex].queueCount) { 4452838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= 44534b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4454838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4455838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). QueueFamilyIndex %u only has %u queues, but " 4456838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "requested queueCount is %u.", 44577d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes requestedIndex, physical_device_state->queue_family_properties[requestedIndex].queueCount, 4458838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski create_info->pQueueCreateInfos[i].queueCount); 4459838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4460838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4461838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4462838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski return skip_call; 4463838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski} 4464838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 4465f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski// Verify that features have been queried and that they are available 4466f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstatic bool ValidateRequestedFeatures(instance_layer_data *dev_data, VkPhysicalDevice phys, const VkPhysicalDeviceFeatures *requested_features) { 4467f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4468f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 44693bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes auto phys_device_state = getPhysicalDeviceState(dev_data, phys); 44703bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes const VkBool32 *actual = reinterpret_cast<VkBool32 *>(&phys_device_state->features); 4471825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski const VkBool32 *requested = reinterpret_cast<const VkBool32 *>(requested_features); 4472f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO : This is a nice, compact way to loop through struct, but a bad way to report issues 4473f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Need to provide the struct member name with the issue. To do that seems like we'll 4474f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // have to loop through each struct member which should be done w/ codegen to keep in synch. 4475f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t errors = 0; 4476f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t total_bools = sizeof(VkPhysicalDeviceFeatures) / sizeof(VkBool32); 4477f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < total_bools; i++) { 4478f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (requested[i] > actual[i]) { 4479f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Add index to struct member name helper to be able to include a feature name 4480838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4481f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4482f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "DL", "While calling vkCreateDevice(), requesting feature #%u in VkPhysicalDeviceFeatures struct, " 4483f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "which is not available on this device.", 4484f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski i); 4485f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski errors++; 4486f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4487f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 44883bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes if (errors && (UNCALLED == phys_device_state->vkGetPhysicalDeviceFeaturesState)) { 4489f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // If user didn't request features, notify them that they should 4490f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Verify this against the spec. I believe this is an invalid use of the API and should return an error 4491838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4492cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4493cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "DL", "You requested features that are unavailable on this device. You should first query feature " 4494cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "availability by calling vkGetPhysicalDeviceFeatures()."); 4495f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4496f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return skip_call; 4497f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 4498f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 449989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 450089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 4501f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), instance_layer_data_map); 4502f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4503f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 4504f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Check that any requested features are available 4505f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (pCreateInfo->pEnabledFeatures) { 45063bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes skip_call |= ValidateRequestedFeatures(my_instance_data, gpu, pCreateInfo->pEnabledFeatures); 4507f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 45084b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes skip_call |= ValidateRequestedQueueFamilyProperties(my_instance_data, gpu, pCreateInfo); 4509f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 45101d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller if (skip_call) { 45111d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller return VK_ERROR_VALIDATION_FAILED_EXT; 45121d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller } 45131d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller 45145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 45155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 45175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 45185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 451956a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 45205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 45215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 45225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 45255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 45285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4532b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 45335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 45345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4535c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis // Copy instance state into this device's layer_data struct 4536c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis my_device_data->instance_state = unique_ptr<INSTANCE_STATE>(new INSTANCE_STATE(*(my_instance_data->instance_state))); 453707a464bd7fec9583f346b8c4b8d43c88d2e9ffa4Chris Forbes my_device_data->instance_data = my_instance_data; 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 45394a0754042cf090e131e9e769d8a3633c228625beChris Forbes layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr); 45406c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 45415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 4543373469f006399d6b5204ee05db3b56beb168b36fMark Young checkDeviceRegisterExtensions(pCreateInfo, *pDevice); 45445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 45459172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes my_instance_data->dispatch_table.GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 45479172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes my_instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4548b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 45499172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes my_instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties( 4550b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 45515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 45525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4553f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes my_device_data->enabled_features = *pCreateInfo->pEnabledFeatures; 45545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4555f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes memset(&my_device_data->enabled_features, 0, sizeof(VkPhysicalDeviceFeatures)); 45565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4557b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 45589172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes my_instance_data->dispatch_table.GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4559b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 45605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 45625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 456789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 45685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 45695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 45705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4572b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 45735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 4574fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes dev_data->renderPassMap.clear(); 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 4576f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 45775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 4578f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 4579f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 4580a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 4581a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 4582a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 4583fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 45845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 45855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 45865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 45875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 45885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 45901344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 45911344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4592b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 459303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 459483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4595b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 45965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 45975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 45985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 45995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 46000a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 46010a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 46025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 460358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4604400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 46055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 460657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis pInfo = (*ii).second.get(); 4607de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (pInfo->alloc_info.allocationSize != 0) { 46085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 460983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 461083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 461183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, "MEM", 461283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 461383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 46145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 46155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4619b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 46205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 4622414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 46235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 462483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 46254a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyDevice(device, pAllocator); 46265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 46284a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyDevice(device, pAllocator); 46295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 46305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 46315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 46345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 46375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4638971020aec6166f20a12a833ebd003e0193f4160aChris Forbesstatic bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 4639e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 46405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 46415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 46425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 46435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 46445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4645414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 46465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 46475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 46485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 46495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 46505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4651856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4652856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4653856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4654971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4655414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4656856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4657414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4658414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4659414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4660856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4661856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4662856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4663856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4664971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4665414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4666856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4667856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4668856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4669856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 46705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 46725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 46755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 467639d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 4677a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Loop through bound objects and increment their in_use counts 4678a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// For any unknown objects, flag an error 46792f8cbf3b166e175174877a59929902e005953d6dTobin Ehlisstatic bool ValidateAndIncrementBoundObjects(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { 4680162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis bool skip = false; 4681162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis DRAW_STATE_ERROR error_code = DRAWSTATE_NONE; 4682162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis BASE_NODE *base_obj = nullptr; 4683a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 4684a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis switch (obj.type) { 4685a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 4686162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(obj.handle)); 4687162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_DESCRIPTOR_SET; 4688a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4689a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 469056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 4691162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getSamplerNode(dev_data, reinterpret_cast<VkSampler &>(obj.handle)); 4692162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_SAMPLER; 469356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 469456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 46952f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 4696162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(obj.handle)); 4697162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_QUERY_POOL; 46982f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46992f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 47002f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 47014c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis base_obj = getPipelineState(dev_data, reinterpret_cast<VkPipeline &>(obj.handle)); 4702162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_PIPELINE; 47032f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 47042f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 47052f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 4706162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); 4707162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_BUFFER; 47082f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 47092f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 47107e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { 47117e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(obj.handle)); 47127e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_BUFFER_VIEW; 47137e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 47147e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 47152f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 47161facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis base_obj = getImageState(dev_data, reinterpret_cast<VkImage &>(obj.handle)); 4717162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_IMAGE; 47182f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 47192f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 47207e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { 47217e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(obj.handle)); 47227e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_IMAGE_VIEW; 47237e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 47247e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 47252f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 4726162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getEventNode(dev_data, reinterpret_cast<VkEvent &>(obj.handle)); 4727162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_EVENT; 47282f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 47292f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 47307e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { 4731a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis base_obj = getDescriptorPoolState(dev_data, reinterpret_cast<VkDescriptorPool &>(obj.handle)); 47327e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_DESCRIPTOR_POOL; 47337e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 47347e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 47357e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { 47367e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(obj.handle)); 47377e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_COMMAND_POOL; 47387e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 47397e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 47407e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { 4741c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis base_obj = getFramebufferState(dev_data, reinterpret_cast<VkFramebuffer &>(obj.handle)); 47427e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_FRAMEBUFFER; 47437e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 47447e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 47457e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { 4746127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis base_obj = getRenderPassState(dev_data, reinterpret_cast<VkRenderPass &>(obj.handle)); 47477e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_RENDERPASS; 47487e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 47497e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 47507e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { 47517e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(obj.handle)); 47527e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_DEVICE_MEMORY; 47537e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 47547e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 4755a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis default: 4756a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : Merge handling of other objects types into this code 4757a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4758a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4759162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis if (!base_obj) { 4760162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis skip |= 4761162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj.type, obj.handle, __LINE__, error_code, "DS", 4762162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis "Cannot submit cmd buffer using deleted %s 0x%" PRIx64 ".", object_type_to_string(obj.type), obj.handle); 4763162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis } else { 4764162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj->in_use.fetch_add(1); 4765162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis } 4766a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4767162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis return skip; 4768a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4769a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis 47705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 47719a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlisstatic bool validateAndIncrementResources(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { 4772e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4773a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 47749a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis cb_node->in_use.fetch_add(1); 47759a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis dev_data->globalInFlightCmdBuffers.insert(cb_node->commandBuffer); 4776a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4777a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First Increment for all "generic" objects bound to cmd buffer, followed by special-case objects below 47789a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= ValidateAndIncrementBoundObjects(dev_data, cb_node); 4779a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : We should be able to remove the NULL look-up checks from the code below as long as 4780a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // all the corresponding cases are verified to cause CB_INVALID state and the CB_INVALID state 4781a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // should then be flagged prior to calling this function 47829a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 47835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 47849a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 47858718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 47869a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4788414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 47895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47908718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->in_use.fetch_add(1); 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47949a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 47959a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto event_node = getEventNode(dev_data, event); 47969556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) 47979556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->write_in_use++; 4798c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 47995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4802b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4803b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 48047d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: untangle this. 4805b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4806b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4807b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4808b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4809b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4810b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4811b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4812b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4813b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4814414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4815414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4816b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4817b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4818b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4819b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4820b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4821b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4822b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 48237d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes 48247d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: nuke this completely. 4825b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4826b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4827b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4828b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4829b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4830b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4831b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4832b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4833b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4834b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4835a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Decrement in-use count for objects bound to command buffer 48362f8cbf3b166e175174877a59929902e005953d6dTobin Ehlisstatic void DecrementBoundResources(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { 483700e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis BASE_NODE *base_obj = nullptr; 4838a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 48397e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = GetStateStructPtrFromObject(dev_data, obj); 484000e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis if (base_obj) { 484100e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj->in_use.fetch_sub(1); 484200e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis } 4843a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4844a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4845da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 48469867daedbf52debc77d6568162ee21e071699b80Chris Forbesstatic bool RetireWorkOnQueue(layer_data *dev_data, QUEUE_NODE *pQueue, uint64_t seq) 48479867daedbf52debc77d6568162ee21e071699b80Chris Forbes{ 48489867daedbf52debc77d6568162ee21e071699b80Chris Forbes bool skip_call = false; // TODO: extract everything that might fail to precheck 48499867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unordered_map<VkQueue, uint64_t> otherQueueSeqs; 48509867daedbf52debc77d6568162ee21e071699b80Chris Forbes 48519867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll this queue forward, one submission at a time. 48529867daedbf52debc77d6568162ee21e071699b80Chris Forbes while (pQueue->seq < seq) { 48539867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & submission = pQueue->submissions.front(); 48549867daedbf52debc77d6568162ee21e071699b80Chris Forbes 48559867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & wait : submission.waitSemaphores) { 48569867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, wait.semaphore); 4857da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_sub(1); 48589867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & lastSeq = otherQueueSeqs[wait.queue]; 48599867daedbf52debc77d6568162ee21e071699b80Chris Forbes lastSeq = std::max(lastSeq, wait.seq); 4860da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 4861cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 48629867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & semaphore : submission.signalSemaphores) { 48639867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 48649867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_sub(1); 48659867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4866cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 48679867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto cb : submission.cbs) { 48689a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto cb_node = getCBNode(dev_data, cb); 4869a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First perform decrement on general case bound objects 48709a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis DecrementBoundResources(dev_data, cb_node); 48719a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 48729867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto buffer : drawDataElement.buffers) { 48739867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto buffer_node = getBufferNode(dev_data, buffer); 48749867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (buffer_node) { 48759867daedbf52debc77d6568162ee21e071699b80Chris Forbes buffer_node->in_use.fetch_sub(1); 48769867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 48779867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4878da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 48799a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 48809867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto eventNode = dev_data->eventMap.find(event); 48819867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (eventNode != dev_data->eventMap.end()) { 48829867daedbf52debc77d6568162ee21e071699b80Chris Forbes eventNode->second.write_in_use--; 48839867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 48849867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 48859a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto queryStatePair : cb_node->queryToStateMap) { 48869867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 48879867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 48889a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto eventStagePair : cb_node->eventToStageMap) { 48899867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 4890da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 48910a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 48929867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= cleanInFlightCmdBuffer(dev_data, cb); 48939867daedbf52debc77d6568162ee21e071699b80Chris Forbes removeInFlightCmdBuffer(dev_data, cb); 48940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 48959867daedbf52debc77d6568162ee21e071699b80Chris Forbes 48969867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pFence = getFenceNode(dev_data, submission.fence); 48979867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 48989867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->state = FENCE_RETIRED; 48990a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49009867daedbf52debc77d6568162ee21e071699b80Chris Forbes 49019867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.pop_front(); 49029867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->seq++; 4903b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 49049867daedbf52debc77d6568162ee21e071699b80Chris Forbes 49059867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll other queues forward to the highest seq we saw a wait for 49069867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto qs : otherQueueSeqs) { 49079867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, getQueueNode(dev_data, qs.first), qs.second); 4908d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 49095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49109867daedbf52debc77d6568162ee21e071699b80Chris Forbes return skip_call; 49119867daedbf52debc77d6568162ee21e071699b80Chris Forbes} 4912651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4913651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4914651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// Submit a fence to a queue, delimiting previous fences and previous untracked 4915651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// work by it. 4916651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void 49179867daedbf52debc77d6568162ee21e071699b80Chris ForbesSubmitFence(QUEUE_NODE *pQueue, FENCE_NODE *pFence, uint64_t submitCount) 4918651d92815dfff917308137bb67aacccc4f60df86Chris Forbes{ 4919cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_INFLIGHT; 49209867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = pQueue->queue; 49219867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.second = pQueue->seq + pQueue->submissions.size() + submitCount; 4922b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4923b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4924e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 49255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 49265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 49275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 49285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 493027c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4931414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 49335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 49355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 493775b0d6603382dcb3e3de24c11ea6e4aa2ef8b4d2Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const char *call_source) { 4938c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis bool skip = false; 4939c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis if (dev_data->instance_state->disabled.command_buffer_state) 4940c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis return skip; 49410a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 49420a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 4943c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4944c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4945c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis "CB 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 4946c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis "set, but has been submitted 0x%" PRIxLEAST64 " times.", 4947c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 49480a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 49515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 49525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 4953e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto obj : pCB->broken_bindings) { 4954e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *type_str = object_type_to_string(obj.type); 4955e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis // Descriptor sets are a special case that can be either destroyed or updated to invalidated a CB 4956e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *cause_str = 4957e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis (obj.type == VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT) ? "destroyed or updated" : "destroyed"; 49585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4959c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis skip |= 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4962e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because bound %s 0x%" PRIxLEAST64 4963e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis " was %s.", 4964e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), type_str, obj.handle, cause_str); 49655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 4967c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4968c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4969c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis "You must call vkEndCommandBuffer() on CB 0x%" PRIxLEAST64 " before this call to %s!", 4970c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), call_source); 49715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4973c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis return skip; 49745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49767bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Validate that queueFamilyIndices of primary command buffers match this queue 49777bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Secondary command buffers were previously validated in vkCmdExecuteCommands(). 49787bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinskistatic bool validateQueueFamilyIndices(layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkQueue queue) { 49797bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski bool skip_call = false; 49807bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto pPool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 49817bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto queue_node = getQueueNode(dev_data, queue); 49827bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 49837bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (pPool && queue_node && (pPool->queueFamilyIndex != queue_node->queueFamilyIndex)) { 49847bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 49857bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 49867bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkQueueSubmit: Primary command buffer 0x%" PRIxLEAST64 49877bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d is being submitted on queue 0x%" PRIxLEAST64 " from queue family %d.", 49887bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), pPool->queueFamilyIndex, 49897bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(queue), queue_node->queueFamilyIndex); 49907bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 49917bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 49927bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski return skip_call; 49937bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski} 49947bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 4995da8f07baf262972eb3e719fa07b073c180dff157Chris Forbesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 49965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 499783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4998a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4999a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 5000a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // on device 500183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferSimultaneousUse(dev_data, pCB); 5002a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 500383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pCB); 5004a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 50055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 50065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 50075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 500883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pSubCB); 50094c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 50104c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 50115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 50125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 5013414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 50145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 5015414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 50164c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 50175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 50185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 50195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5022a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 502375b0d6603382dcb3e3de24c11ea6e4aa2ef8b4d2Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pCB, "vkQueueSubmit()"); 5024a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 502583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 50265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 502881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbesstatic bool 5029651d92815dfff917308137bb67aacccc4f60df86Chris ForbesValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) 503081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes{ 503183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 503281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 5033651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 5034cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_INFLIGHT) { 503583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 503683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 503783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); 5038a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 503981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 5040cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes else if (pFence->state == FENCE_RETIRED) { 504183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 504283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 504383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 504483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 504583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence)); 5046a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 50475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 504881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 504983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 505081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes} 505181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 5052651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 505381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL 505481c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 505583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 505681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 505781c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 505881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 505981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 5060651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 5061651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 506283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 506381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 506483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 5065d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 5066d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes } 5067d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes 50681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 50691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 50701344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 5071651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 5072651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // Mark the fence in-use. 5073651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 50749867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, std::max(1u, submitCount)); 5075651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 5076651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 50775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 50785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50809867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<SEMAPHORE_WAIT> semaphore_waits; 50819867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<VkSemaphore> semaphore_signals; 50825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 508301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pWaitSemaphores[i]; 508401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 508501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 508601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 50879867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 50889867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 50899867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 50909867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 50919867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 509201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 50931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 509483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 50951344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 50961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 5097414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 50981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 50991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 51005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 510301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pSignalSemaphores[i]; 510401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 510501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 510601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 510783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 51081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 51091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 5110414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 5111414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 51121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 51139867daedbf52debc77d6568162ee21e071699b80Chris Forbes reinterpret_cast<uint64_t &>(pSemaphore->signaler.first)); 51141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 51159867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 51169867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 511701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = true; 5118da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_add(1); 51199867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 51201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 51210a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 51225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5123651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 5124da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes std::vector<VkCommandBuffer> cbs; 5125da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 51265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 5127971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 512883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateCmdBufImageLayouts(dev_data, pCBNode); 51291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 5130da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(submit->pCommandBuffers[i]); 5131651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto secondaryCmdBuffer : pCBNode->secondaryCommandBuffers) { 5132da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(secondaryCmdBuffer); 5133651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 5134651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 51351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 513683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBufferState(dev_data, pCBNode); 51377bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= validateQueueFamilyIndices(dev_data, pCBNode, queue); 5138ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis // Potential early exit here as bad object state may crash in delayed function calls 5139ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis if (skip_call) 5140ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis return result; 51411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 51421344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 514383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(); 51441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 51451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 514683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 51471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 5148d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto &function : pCBNode->queryUpdates) { 514983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 5150d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 51511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 51525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5153da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 51549867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(cbs, semaphore_waits, semaphore_signals, 51559867daedbf52debc77d6568162ee21e071699b80Chris Forbes submit_idx == submitCount - 1 ? fence : VK_NULL_HANDLE); 51569867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 51579867daedbf52debc77d6568162ee21e071699b80Chris Forbes 51589867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !submitCount) { 51599867daedbf52debc77d6568162ee21e071699b80Chris Forbes // If no submissions, but just dropping a fence on the end of the queue, 51609867daedbf52debc77d6568162ee21e071699b80Chris Forbes // record an empty submission with just the fence, so we can determine 51619867daedbf52debc77d6568162ee21e071699b80Chris Forbes // its completion. 51629867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 51639867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 51649867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 51659867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51679867daedbf52debc77d6568162ee21e071699b80Chris Forbes 5168b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 516983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 51704a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.QueueSubmit(queue, submitCount, pSubmits, fence); 51715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 51735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 517589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 517689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 51775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51784a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = my_data->dispatch_table.AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 51795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 5180b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 51815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 51820a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 51835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 51845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 518689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 518789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 51885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 51915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 51925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 51935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 51945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 51955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 51965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5197b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 519874243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller bool skip_call = freeMemObjInfo(my_data, device, mem, false); 51990a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 52000a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 5201b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 520274243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller if (!skip_call) { 52034a0754042cf090e131e9e769d8a3633c228625beChris Forbes my_data->dispatch_table.FreeMemory(device, mem, pAllocator); 520474243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller } 52055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5207f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// Validate that given Map memory range is valid. This means that the memory should not already be mapped, 5208f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// and that the size of the map range should be: 5209f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 1. Not zero 5210f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 2. Within the size of the memory allocation 5211f57fc64ac43691ad98e1713886b345465573070aTobin Ehlisstatic bool ValidateMapMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 521283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 52135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 521583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 521683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 521783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 52185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 52215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 522257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = mem_element->second.get(); 52235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 5224de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.size != 0) { 522583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 522683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 522783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 52285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 52315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 5232de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (offset >= mem_info->alloc_info.allocationSize) { 523383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 523483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 523583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 523683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, 5237de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis offset, mem_info->alloc_info.allocationSize, mem_info->alloc_info.allocationSize); 52385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5240de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if ((offset + size) > mem_info->alloc_info.allocationSize) { 524183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 524257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 524357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 524457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64, offset, 5245de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size + offset, mem_info->alloc_info.allocationSize); 52465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 524983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 52505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5252e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 525357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 525457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5255de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.offset = offset; 5256de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = size; 52575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5260e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 526183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 526257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 526357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5264de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (!mem_info->mem_range.size) { 52655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 526683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 526783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 526883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 52695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5270de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = 0; 52715f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 52725f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski free(mem_info->shadow_copy_base); 52735f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy_base = 0; 52745f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 52755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 527783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 52785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52805f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski// Guard value for pad data 52815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 52825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52835f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinskistatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, 52845f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski void **ppData) { 528557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 528657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5287de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->p_driver_data = *ppData; 5288de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis uint32_t index = mem_info->alloc_info.memoryTypeIndex; 5289b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 52905f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 52915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 52925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 52935f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski size = mem_info->alloc_info.allocationSize - offset; 52945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52955f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_pad_size = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 52965f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(mem_info->shadow_pad_size, 52975f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment) == 0); 52985f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Ensure start of mapped region reflects hardware alignment constraints 52995f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t map_alignment = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 53005f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 53015f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // From spec: (ppData - offset) must be aligned to at least limits::minMemoryMapAlignment. 53025f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t start_offset = offset % map_alignment; 53035f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Data passed to driver will be wrapped by a guardband of data to detect over- or under-writes. 53046e17c244b21ce43ac57404a00a0d844039eed363Mark Lobodzinski mem_info->shadow_copy_base = malloc(static_cast<size_t>(2 * mem_info->shadow_pad_size + size + map_alignment + start_offset)); 53055f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 53065f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 53075f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski reinterpret_cast<char *>((reinterpret_cast<uintptr_t>(mem_info->shadow_copy_base) + map_alignment) & 53085f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ~(map_alignment - 1)) + start_offset; 53095f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(reinterpret_cast<uintptr_t>(mem_info->shadow_copy) + mem_info->shadow_pad_size - start_offset, 53105f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski map_alignment) == 0); 53115f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 53126e17c244b21ce43ac57404a00a0d844039eed363Mark Lobodzinski memset(mem_info->shadow_copy, NoncoherentMemoryFillValue, static_cast<size_t>(2 * mem_info->shadow_pad_size + size)); 53135f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski *ppData = static_cast<char *>(mem_info->shadow_copy) + mem_info->shadow_pad_size; 53145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53175f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 5318a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 53199867daedbf52debc77d6568162ee21e071699b80Chris Forbes// a fence being waited on should not already be signaled and 5320a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 532149f6132af865afd5b7f413c91125971ac97c135aChris Forbesstatic inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { 532283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 53239b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes 532449f6132af865afd5b7f413c91125971ac97c135aChris Forbes auto pFence = getFenceNode(dev_data, fence); 53259b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes if (pFence) { 5326cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_UNSIGNALED) { 532783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 532883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 532983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 533083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "acquire next image.", 533183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 53325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 533483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 53355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5336a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 5337b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbesstatic bool RetireFence(layer_data *dev_data, VkFence fence) { 5338b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes auto pFence = getFenceNode(dev_data, fence); 5339b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes if (pFence->signaler.first != VK_NULL_HANDLE) { 5340b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes /* Fence signaller is a queue -- use this as proof that prior operations 5341b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes * on that queue have completed. 5342b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes */ 5343b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes return RetireWorkOnQueue(dev_data, 5344b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes getQueueNode(dev_data, pFence->signaler.first), 5345b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes pFence->signaler.second); 5346b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes } 5347d4513979120463171eb479cdded9336eb9944da1Chris Forbes else { 5348d4513979120463171eb479cdded9336eb9944da1Chris Forbes /* Fence signaller is the WSI. We're not tracking what the WSI op 5349d4513979120463171eb479cdded9336eb9944da1Chris Forbes * actually /was/ in CV yet, but we need to mark the fence as retired. 5350d4513979120463171eb479cdded9336eb9944da1Chris Forbes */ 5351d4513979120463171eb479cdded9336eb9944da1Chris Forbes pFence->state = FENCE_RETIRED; 5352d4513979120463171eb479cdded9336eb9944da1Chris Forbes return false; 5353d4513979120463171eb479cdded9336eb9944da1Chris Forbes } 5354b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes} 5355b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes 535689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 535789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 53585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5359e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 5361b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 536349f6132af865afd5b7f413c91125971ac97c135aChris Forbes skip_call |= verifyWaitFenceState(dev_data, pFences[i], "vkWaitForFences"); 53645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5365b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5368a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 53694a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.WaitForFences(device, fenceCount, pFences, waitAll, timeout); 5370414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 53715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5372b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 53759867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (uint32_t i = 0; i < fenceCount; i++) { 5376b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes skip_call |= RetireFence(dev_data, pFences[i]); 53779867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 53785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 53815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 5382b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5384e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 53855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 538989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 53905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 539183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5392b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 539383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); 5394b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5395a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 539683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 539783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5398a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 53994a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.GetFenceStatus(device, fence); 5400b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 54015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5402d4513979120463171eb479cdded9336eb9944da1Chris Forbes skip_call |= RetireFence(dev_data, fence); 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5404b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5405e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 541089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5411b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54134a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 5414b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5415b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5416b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5417b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5418b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5419b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 54208988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes pQNode->queue = *pQueue; 54217bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski pQNode->queueFamilyIndex = queueFamilyIndex; 54229867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQNode->seq = 0; 5423b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 542689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 54275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 5428e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 54299867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 54309867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 54319867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, pQueue, pQueue->seq + pQueue->submissions.size()); 54329867daedbf52debc77d6568162ee21e071699b80Chris Forbes lock.unlock(); 5433e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 54345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54354a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.QueueWaitIdle(queue); 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 543989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 5440e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 54415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5442b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54439867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & queue : dev_data->queueMap) { 54449867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5446b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5447e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 54485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54494a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.DeviceWaitIdle(device); 54505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 545389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 54545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 545583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5456b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54571344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 54581344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 5459cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (fence_pair->second.state == FENCE_INFLIGHT) { 546083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 546183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", "Fence 0x%" PRIx64 " is in use.", 546283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence)); 54631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 54641344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 54655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5466b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 546883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 54694a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyFence(device, fence, pAllocator); 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5472eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis// For given obj node, if it is use, flag a validation error and return callback result, else return false 54731803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlisbool ValidateObjectNotInUse(const layer_data *dev_data, BASE_NODE *obj_node, VK_OBJECT obj_struct, 54741803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis UNIQUE_VALIDATION_ERROR_CODE error_code) { 54757626815e3c23be98681f3fcf733ee938022af612Tobin Ehlis if (dev_data->instance_state->disabled.object_in_use) 54767626815e3c23be98681f3fcf733ee938022af612Tobin Ehlis return false; 5477eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5478eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (obj_node->in_use.load()) { 5479eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_struct.type, obj_struct.handle, __LINE__, 54801803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis error_code, "DS", "Cannot delete %s 0x%" PRIx64 " that is currently in use by a command buffer. %s", 54811803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis object_type_to_string(obj_struct.type), obj_struct.handle, validation_error_map[error_code]); 5482eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis } 5483eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis return skip; 5484eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis} 5485eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis 548689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 548789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 54885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5489eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5490e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5491eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis auto sema_node = getSemaphoreNode(dev_data, semaphore); 5492eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (sema_node) { 5493eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, sema_node, 54941803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis {reinterpret_cast<uint64_t &>(semaphore), VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT}, 54951803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis VALIDATION_ERROR_00199); 54965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5497eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (!skip) { 5498eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->semaphoreMap.erase(semaphore); 5499eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis lock.unlock(); 55004a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroySemaphore(device, semaphore, pAllocator); 550199d938c90c2f000ee73fb13513dacf84ffa5651fMark Mueller } 55025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 550489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 55055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5506eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5507b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55089556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 55099556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 5510eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}; 55111803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, event_node, obj_struct, VALIDATION_ERROR_00213); 55129556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis // Any bound cmd buffers are now invalid 5513eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(event_node->cb_bindings, obj_struct); 55149556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 5515f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5516f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->eventMap.erase(event); 5517f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 55184a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyEvent(device, event, pAllocator); 5519f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 55205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 552289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 552389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 5524ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5525eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5526ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5527ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto qp_node = getQueryPoolNode(dev_data, queryPool); 5528ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (qp_node) { 5529eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}; 55301803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, qp_node, obj_struct, VALIDATION_ERROR_01012); 5531ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis // Any bound cmd buffers are now invalid 5532eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(qp_node->cb_bindings, obj_struct); 5533ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 5534f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5535f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->queryPoolMap.erase(queryPool); 5536f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 55374a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyQueryPool(device, queryPool, pAllocator); 5538f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 554189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 554289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 554389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 5546b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 5548971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5553e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 55555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5559ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5560ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5561ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5562ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5563971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5564ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5565ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5566ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5567ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5568414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 5569ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5570ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5571ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5572ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5573ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5574ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5575ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5576ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5577ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5578ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5579ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5580ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5581ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5582971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5583ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5584ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5585ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 55865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 55875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5588414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 55895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 55905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5591ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5592ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 55935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 55945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5595414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 55965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5597ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5598ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5599ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5600ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5601414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 5602ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5603ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 56045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5607b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 56095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 56104a0754042cf090e131e9e769d8a3633c228625beChris Forbes return dev_data->dispatch_table.GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, flags); 56115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5613e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5614e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 56158718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 56168718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 56175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 56185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 5619414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 56205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 56218718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node->in_use.load()) { 56225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 56235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5624414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 56255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 56285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5630825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if given ranges intersect, else false 5631825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Prereq : For both ranges, range->end - range->start > 0. This case should have already resulted 5632825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// in an error so not checking that here 5633825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// pad_ranges bool indicates a linear and non-linear comparison which requires padding 5634825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// In the case where padding is required, if an alias is encountered then a validation error is reported and skip_call 5635825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// may be set by the callback function so caller should merge in skip_call value if padding case is possible. 56367dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, MEMORY_RANGE const *range2, bool *skip_call) { 56377dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call = false; 5638825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_start = range1->start; 5639825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_end = range1->end; 5640825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_start = range2->start; 5641825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_end = range2->end; 5642825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkDeviceSize pad_align = 1; 5643825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5644825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis pad_align = dev_data->phys_dev_properties.properties.limits.bufferImageGranularity; 5645825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5646825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_end & ~(pad_align - 1)) < (r2_start & ~(pad_align - 1))) 5647825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 5648825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_start & ~(pad_align - 1)) > (r2_end & ~(pad_align - 1))) 5649825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 565047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5651825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5652825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // In linear vs. non-linear case, it's an error to alias 5653825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_linear_str = range1->linear ? "Linear" : "Non-linear"; 5654825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_type_str = range1->image ? "image" : "buffer"; 5655825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_linear_str = range2->linear ? "linear" : "non-linear"; 5656825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_type_str = range2->image ? "image" : "buffer"; 5657825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto obj_type = range1->image ? VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT : VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT; 56587dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call |= 5659825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, range1->handle, 0, MEMTRACK_INVALID_ALIASING, 5660825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis "MEM", "%s %s 0x%" PRIx64 " is aliased with %s %s 0x%" PRIx64 5661825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis " which is in violation of the Buffer-Image Granularity section of the Vulkan specification.", 5662825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis r1_linear_str, r1_type_str, range1->handle, r2_linear_str, r2_type_str, range2->handle); 566347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 5664825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Ranges intersect 5665825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return true; 566647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 5667623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis// Simplified rangesIntersect that calls above function to check range1 for intersection with offset & end addresses 5668cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, VkDeviceSize offset, VkDeviceSize end) { 5669825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Create a local MEMORY_RANGE struct to wrap offset/size 5670825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis MEMORY_RANGE range_wrap; 5671825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Synch linear with range1 to avoid padding and potential validation error case 5672825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.linear = range1->linear; 5673825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.start = offset; 5674cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis range_wrap.end = end; 5675825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool tmp_bool; 56767dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis return rangesIntersect(dev_data, range1, &range_wrap, &tmp_bool); 5677825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5678cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given mem_info, set all ranges valid that intersect [offset-end] range 5679cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// TODO : For ranges where there is no alias, we may want to create new buffer ranges that are valid 5680cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic void SetMemRangesValid(layer_data const *dev_data, DEVICE_MEM_INFO *mem_info, VkDeviceSize offset, VkDeviceSize end) { 5681cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis bool tmp_bool = false; 5682cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis MEMORY_RANGE map_range; 5683cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.linear = true; 5684cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.start = offset; 5685cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.end = end; 5686cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto &handle_range_pair : mem_info->bound_ranges) { 56877dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &handle_range_pair.second, &map_range, &tmp_bool)) { 5688cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : WARN here if tmp_bool true? 5689cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis handle_range_pair.second.valid = true; 5690cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5691cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5692cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis} 5693825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Object with given handle is being bound to memory w/ given mem_info struct. 5694825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Track the newly bound memory range with given memoryOffset 5695825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Also scan any previous ranges, track aliased ranges with new range, and flag an error if a linear 5696825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// and non-linear range incorrectly overlap. 5697825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if an error is flagged and the user callback returns "true", otherwise false 5698825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates an image object, otherwise handle is for a buffer 5699825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_linear indicates a buffer or linear image 5700825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic bool InsertMemoryRange(layer_data const *dev_data, uint64_t handle, DEVICE_MEM_INFO *mem_info, VkDeviceSize memoryOffset, 5701825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements memRequirements, bool is_image, bool is_linear) { 5702825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool skip_call = false; 57035360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis MEMORY_RANGE range; 5704825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5705825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.image = is_image; 570647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 5707825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.linear = is_linear; 5708f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis range.valid = mem_info->global_valid; 5709825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.memory = mem_info->mem; 571047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 5711825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.size = memRequirements.size; 571247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 57135360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis range.aliases.clear(); 57145360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Update Memory aliasing 57155360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Save aliase ranges so we can copy into final map entry below. Can't do it in loop b/c we don't yet have final ptr. If we 57165360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // inserted into map before loop to get the final ptr, then we may enter loop when not needed & we check range against itself 57175360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis std::unordered_set<MEMORY_RANGE *> tmp_alias_ranges; 5718825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto &obj_range_pair : mem_info->bound_ranges) { 5719825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto check_range = &obj_range_pair.second; 57205360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis bool intersection_error = false; 57217dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &range, check_range, &intersection_error)) { 5722825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis skip_call |= intersection_error; 5723825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.aliases.insert(check_range); 57245360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_alias_ranges.insert(check_range); 5725825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5726825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 57275360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis mem_info->bound_ranges[handle] = std::move(range); 57285360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis for (auto tmp_range : tmp_alias_ranges) { 57295360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_range->aliases.insert(&mem_info->bound_ranges[handle]); 57305360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis } 5731825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (is_image) 5732825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.insert(handle); 5733825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis else 5734825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.insert(handle); 5735825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5736825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return skip_call; 573747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 573847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 57399f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertImageMemoryRange(layer_data const *dev_data, VkImage image, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5740825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs, bool is_linear) { 57419f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(image), mem_info, mem_offset, mem_reqs, true, is_linear); 5742825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5743825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 57449f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertBufferMemoryRange(layer_data const *dev_data, VkBuffer buffer, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5745825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs) { 57469f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(buffer), mem_info, mem_offset, mem_reqs, false, true); 5747825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5748825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5749825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Remove MEMORY_RANGE struct for give handle from bound_ranges of mem_info 5750825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates if handle is for image or buffer 5751825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// This function will also remove the handle-to-index mapping from the appropriate 5752825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// map and clean up any aliases for range being removed. 5753825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info, bool is_image) { 5754825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto erase_range = &mem_info->bound_ranges[handle]; 5755825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto alias_range : erase_range->aliases) { 5756825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis alias_range->aliases.erase(erase_range); 575747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 57585360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis erase_range->aliases.clear(); 5759825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_ranges.erase(handle); 57601cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis if (is_image) { 5761825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.erase(handle); 57621cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } else { 5763825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.erase(handle); 57641cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } 576547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 576647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5767825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveBufferMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, false); } 5768825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5769825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveImageMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, true); } 5770825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 577189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 577289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5774b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 57755a758b24bbcdad37a5ccf41c3581c289acf11c2dTobin Ehlis if (!validateIdleBuffer(dev_data, buffer)) { 5776e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Clean up memory binding and range information for buffer 5777e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 5778e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (buff_node) { 5779e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Any bound cmd buffers are now invalid 5780e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis invalidateCommandBuffers(buff_node->cb_bindings, 5781e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis {reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 5782e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto mem_info = getMemObjInfo(dev_data, buff_node->mem); 5783e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (mem_info) { 5784825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis RemoveBufferMemoryRange(reinterpret_cast<uint64_t &>(buffer), mem_info); 5785e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5786e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 5787e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->bufferMap.erase(buff_node->buffer); 5788e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5789b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57904a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyBuffer(device, buffer, pAllocator); 579147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 57925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57948e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlisstatic bool PreCallValidateDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE **buffer_view_state, 57958e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis VK_OBJECT *obj_struct) { 57967626815e3c23be98681f3fcf733ee938022af612Tobin Ehlis if (dev_data->instance_state->disabled.destroy_buffer_view) 57977626815e3c23be98681f3fcf733ee938022af612Tobin Ehlis return false; 57988e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis bool skip = false; 57998e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis *buffer_view_state = getBufferViewState(dev_data, buffer_view); 5800f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis if (*buffer_view_state) { 58018e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}; 58021803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *buffer_view_state, *obj_struct, VALIDATION_ERROR_00701); 58038e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis } 58048e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis return skip; 58058e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis} 58068e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis 58078e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlisstatic void PostCallRecordDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE *buffer_view_state, 58088e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis VK_OBJECT obj_struct) { 58098e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis // Any bound cmd buffers are now invalid 58108e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis invalidateCommandBuffers(buffer_view_state->cb_bindings, obj_struct); 5811c6f1a9ab8d9bee0a805a298c9d28f5e81f8877b5Tobin Ehlis dev_data->bufferViewMap.erase(buffer_view); 58128e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis} 58138e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis 581489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 581589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 58165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5817f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis // Common data objects used pre & post call 58188e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis BUFFER_VIEW_STATE *buffer_view_state = nullptr; 58198e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis VK_OBJECT obj_struct; 5820a123662876eebfa844faa65ae3f071d3d77618ebTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 58218e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis // Validate state before calling down chain, update common data if we'll be calling down chain 58228e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis bool skip = PreCallValidateDestroyBufferView(dev_data, bufferView, &buffer_view_state, &obj_struct); 582338e26abbaa884eb48bfec4ddb4e0ae2c90634e06Tobin Ehlis if (!skip) { 582438e26abbaa884eb48bfec4ddb4e0ae2c90634e06Tobin Ehlis lock.unlock(); 58254a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyBufferView(device, bufferView, pAllocator); 58268e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis lock.lock(); 58278e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis PostCallRecordDestroyBufferView(dev_data, bufferView, buffer_view_state, obj_struct); 58285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58311facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic bool PreCallValidateDestroyImage(layer_data *dev_data, VkImage image, IMAGE_STATE **image_state, VK_OBJECT *obj_struct) { 58322a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis if (dev_data->instance_state->disabled.destroy_image) 58332a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis return false; 5834f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis bool skip = false; 58351facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis *image_state = getImageState(dev_data, image); 58362a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis if (*image_state) { 58372a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}; 58382a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *image_state, *obj_struct, VALIDATION_ERROR_00743); 5839f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis } 58402a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis return skip; 58412a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis} 5842f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis 58431facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic void PostCallRecordDestroyImage(layer_data *dev_data, VkImage image, IMAGE_STATE *image_state, VK_OBJECT obj_struct) { 58442a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis invalidateCommandBuffers(image_state->cb_bindings, obj_struct); 58452a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis // Clean up memory mapping, bindings and range references for image 58462a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, image_state->mem); 58472a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis if (mem_info) { 58482a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis RemoveImageMemoryRange(obj_struct.handle, mem_info); 58492a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis clear_object_binding(dev_data, obj_struct.handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 58502a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis } 58512a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis // Remove image from imageMap 58522a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis dev_data->imageMap.erase(image); 58532a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis 58542a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis const auto &sub_entry = dev_data->imageSubresourceMap.find(image); 58552a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis if (sub_entry != dev_data->imageSubresourceMap.end()) { 58562a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis for (const auto &pair : sub_entry->second) { 58572a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 58585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58592a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis dev_data->imageSubresourceMap.erase(sub_entry); 58602a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis } 58612a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis} 58622a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis 58632a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin EhlisVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 58642a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58651facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis IMAGE_STATE *image_state = nullptr; 58662a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis VK_OBJECT obj_struct; 58672a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 58682a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis bool skip = PreCallValidateDestroyImage(dev_data, image, &image_state, &obj_struct); 58692a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis if (!skip) { 5870f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis lock.unlock(); 58714a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyImage(device, image, pAllocator); 58722a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis lock.lock(); 58732a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis PostCallRecordDestroyImage(dev_data, image, image_state, obj_struct); 58745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58774261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinskistatic bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, 58784261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski const char *funcName) { 58794261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski bool skip_call = false; 5880de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (((1 << mem_info->alloc_info.memoryTypeIndex) & memory_type_bits) == 0) { 5881de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis skip_call = log_msg( 5882de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5883de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, MEMTRACK_INVALID_MEM_TYPE, "MT", 5884de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " 5885de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "type (0x%X) of this memory object 0x%" PRIx64 ".", 5886de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, memory_type_bits, mem_info->alloc_info.memoryTypeIndex, reinterpret_cast<const uint64_t &>(mem_info->mem)); 58874261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski } 58884261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski return skip_call; 58894261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski} 58904261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski 589189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 589289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 589358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5895b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 58965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 58979f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis uint64_t buffer_handle = reinterpret_cast<uint64_t &>(buffer); 5898888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool skip_call = SetMemBinding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 58998718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 59008718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 59015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 59024a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.GetBufferMemoryRequirements(device, buffer, &memRequirements); 59034bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->mem = mem; 59044bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memOffset = memoryOffset; 59054bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memSize = memRequirements.size; 590647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 590747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 590857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 590957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 59109f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertBufferMemoryRange(dev_data, buffer, mem_info, memoryOffset, memRequirements); 591183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "BindBufferMemory"); 591247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 591347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 59142c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 59152c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 591683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 59172c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 59182c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5919414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5920414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 59212c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 59222c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 59232c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 5924ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 59252c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 5926ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const VkBufferUsageFlagBits usage_list[3] = { 5927ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static_cast<VkBufferUsageFlagBits>(VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT), 5928ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, 5929ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_STORAGE_BUFFER_BIT}; 5930ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *memory_type[3] = {"texel", 5931ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "uniform", 5932ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "storage"}; 5933ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *offset_name[3] = { 5934ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minTexelBufferOffsetAlignment", 5935ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minUniformBufferOffsetAlignment", 5936ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minStorageBufferOffsetAlignment" 5937ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 5938ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5939ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Keep this one fresh! 5940ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller const VkDeviceSize offset_requirement[3] = { 5941ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment, 5942ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, 5943ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment 5944ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 59458718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; 5946ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5947ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (int i = 0; i < 3; i++) { 5948ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (usage & usage_list[i]) { 5949ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (vk_safe_modulo(memoryOffset, offset_requirement[i]) != 0) { 5950ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call |= 5951ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 5952ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5953ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "vkBindBufferMemory(): %s memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5954ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "device limit %s 0x%" PRIxLEAST64, 5955ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller memory_type[i], memoryOffset, offset_name[i], offset_requirement[i]); 5956ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 59572c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59582c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59600a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5961b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 596283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 59634a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.BindBufferMemory(device, buffer, mem, memoryOffset); 59645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 596889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 596989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 59705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 59734a0754042cf090e131e9e769d8a3633c228625beChris Forbes my_data->dispatch_table.GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 597689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 597789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 59814a0754042cf090e131e9e769d8a3633c228625beChris Forbes my_data->dispatch_table.GetImageMemoryRequirements(device, image, pMemoryRequirements); 59825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5983593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 5984f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlisstatic bool PreCallValidateDestroyImageView(layer_data *dev_data, VkImageView image_view, IMAGE_VIEW_STATE **image_view_state, 5985f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis VK_OBJECT *obj_struct) { 5986f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis if (dev_data->instance_state->disabled.destroy_image_view) 5987f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis return false; 5988f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis bool skip = false; 5989f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis *image_view_state = getImageViewState(dev_data, image_view); 5990f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis if (*image_view_state) { 5991f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(image_view), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}; 59921803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *image_view_state, *obj_struct, VALIDATION_ERROR_00776); 5993f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis } 5994f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis return skip; 5995f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis} 5996f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis 5997f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlisstatic void PostCallRecordDestroyImageView(layer_data *dev_data, VkImageView image_view, IMAGE_VIEW_STATE *image_view_state, 5998f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis VK_OBJECT obj_struct) { 5999f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis // Any bound cmd buffers are now invalid 6000f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis invalidateCommandBuffers(image_view_state->cb_bindings, obj_struct); 6001f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis dev_data->imageViewMap.erase(image_view); 6002f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis} 6003f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis 600489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 600589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 6006d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6007f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis // Common data objects used pre & post call 6008f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis IMAGE_VIEW_STATE *image_view_state = nullptr; 6009f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis VK_OBJECT obj_struct; 6010a123662876eebfa844faa65ae3f071d3d77618ebTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 6011f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis bool skip = PreCallValidateDestroyImageView(dev_data, imageView, &image_view_state, &obj_struct); 6012d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis if (!skip) { 6013d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis lock.unlock(); 60144a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyImageView(device, imageView, pAllocator); 6015f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis lock.lock(); 6016f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis PostCallRecordDestroyImageView(dev_data, imageView, image_view_state, obj_struct); 6017d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis } 60185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 602089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 602189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 6022918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6023918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 6024b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6025918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 6026b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6027918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 60284a0754042cf090e131e9e769d8a3633c228625beChris Forbes my_data->dispatch_table.DestroyShaderModule(device, shaderModule, pAllocator); 60295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60314c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool PreCallValidateDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE **pipeline_state, 60328bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis VK_OBJECT *obj_struct) { 60338bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis if (dev_data->instance_state->disabled.destroy_pipeline) 60348bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis return false; 60358bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis bool skip = false; 60364c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis *pipeline_state = getPipelineState(dev_data, pipeline); 60378bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis if (*pipeline_state) { 60388bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}; 60391803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *pipeline_state, *obj_struct, VALIDATION_ERROR_00555); 60408bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis } 60418bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis return skip; 60428bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis} 60438bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis 60444c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic void PostCallRecordDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE *pipeline_state, 60458bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis VK_OBJECT obj_struct) { 60468bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis // Any bound cmd buffers are now invalid 60478bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis invalidateCommandBuffers(pipeline_state->cb_bindings, obj_struct); 60488bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis dev_data->pipelineMap.erase(pipeline); 60498bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis} 60508bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis 605189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 605289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 6053a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60544c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pipeline_state = nullptr; 60558bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis VK_OBJECT obj_struct; 6056e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 60578bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis bool skip = PreCallValidateDestroyPipeline(dev_data, pipeline, &pipeline_state, &obj_struct); 6058f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 6059f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 60604a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyPipeline(device, pipeline, pAllocator); 60618bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis lock.lock(); 60628bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis PostCallRecordDestroyPipeline(dev_data, pipeline, pipeline_state, obj_struct); 6063f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 606689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 606789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 60686792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6069e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 60706792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis dev_data->pipelineLayoutMap.erase(pipelineLayout); 6071e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis lock.unlock(); 6072e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 60734a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyPipelineLayout(device, pipelineLayout, pAllocator); 60745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 607689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 607789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 607856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6079eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 608056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 608156f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis auto sampler_node = getSamplerNode(dev_data, sampler); 608256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis if (sampler_node) { 6083eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}; 60841803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, sampler_node, obj_struct, VALIDATION_ERROR_00837); 608556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis // Any bound cmd buffers are now invalid 6086eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(sampler_node->cb_bindings, obj_struct); 608756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 6088f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 6089f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->samplerMap.erase(sampler); 6090f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 60914a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroySampler(device, sampler, pAllocator); 6092f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 60935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 609589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 609689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 6097e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 60994a0754042cf090e131e9e769d8a3633c228625beChris Forbes ->dispatch_table.DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6102c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlisstatic bool PreCallValidateDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool pool, 6103a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE **desc_pool_state, VK_OBJECT *obj_struct) { 6104c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis if (dev_data->instance_state->disabled.destroy_descriptor_pool) 6105c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis return false; 6106c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis bool skip = false; 6107a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis *desc_pool_state = getDescriptorPoolState(dev_data, pool); 6108c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis if (*desc_pool_state) { 6109c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(pool), VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT}; 61101803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *desc_pool_state, *obj_struct, VALIDATION_ERROR_00901); 6111c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis } 6112c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis return skip; 6113c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis} 6114c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis 6115c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlisstatic void PostCallRecordDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool descriptorPool, 6116a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *desc_pool_state, VK_OBJECT obj_struct) { 6117c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis // Any bound cmd buffers are now invalid 6118c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis invalidateCommandBuffers(desc_pool_state->cb_bindings, obj_struct); 6119c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis // Free sets that were in this pool 6120c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis for (auto ds : desc_pool_state->sets) { 6121c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis freeDescriptorSet(dev_data, ds); 6122c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis } 6123c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis dev_data->descriptorPoolMap.erase(descriptorPool); 6124c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis} 6125c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis 612689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 612789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 6128c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6129a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *desc_pool_state = nullptr; 6130c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis VK_OBJECT obj_struct; 6131c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 6132c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis bool skip = PreCallValidateDestroyDescriptorPool(dev_data, descriptorPool, &desc_pool_state, &obj_struct); 6133c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis if (!skip) { 6134c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis lock.unlock(); 6135c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis dev_data->dispatch_table.DestroyDescriptorPool(device, descriptorPool, pAllocator); 6136c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis lock.lock(); 6137c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis PostCallRecordDestroyDescriptorPool(dev_data, descriptorPool, desc_pool_state, obj_struct); 6138c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis } 61395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6140bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 6141bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 6142bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 6143bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 6144a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbesstatic bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 6145bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 6146bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 6147bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 6148bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 6149bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 6150bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 6151bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6152bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6153414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use.", action, 6154bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 6155bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6156bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6157bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 6158bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 6159a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 6160bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 6161a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action) { 6162bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 6163a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 6164a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 6165a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 6166bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6167bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6168bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 6169bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6171a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic void clearCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool) { 6172a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 6173a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 6174a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes } 6175a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes} 6176a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 617789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 617889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 6181b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6182c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 61835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 61849f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 61855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 61869f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 61879f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis skip_call |= checkCommandBufferInFlight(dev_data, cb_node, "free"); 6188c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 6189c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 6190c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 6191c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes if (skip_call) 6192c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes return; 6193c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 6194c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 6195c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes for (uint32_t i = 0; i < commandBufferCount; i++) { 61969f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 6197c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes // Delete CB information structure, and remove from commandBufferMap 61989f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 61999f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 62005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 62019f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis resetCB(dev_data, cb_node->commandBuffer); 62029f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb_node->commandBuffer); 62039f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 6207c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes pPool->commandBuffers.remove(pCommandBuffers[i]); 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62090a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6210b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6211e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 62124a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 621589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 621689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 621789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 62185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62204a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6223b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 62255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 62265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 623089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 623189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62344a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 62355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 6236b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6237eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis QUERY_POOL_NODE *qp_node = &dev_data->queryPoolMap[*pQueryPool]; 6238eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis qp_node->createInfo = *pCreateInfo; 62395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 624489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 624589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 624783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6248b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 62495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 6250a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 625183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "destroy command pool with"); 62525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 625383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 62545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 62559f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandBufferMap 6256a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 6257a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cb : pPool->commandBuffers) { 6258a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 62599f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, cb); 6260d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // Remove references to this cb_node prior to delete 6261d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // TODO : Need better solution here, resetCB? 62627165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski for (auto obj : cb_node->object_bindings) { 62637165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski removeCommandBufferBinding(dev_data, &obj, cb_node); 62647165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski } 6265d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis for (auto framebuffer : cb_node->framebuffers) { 6266c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto fb_state = getFramebufferState(dev_data, framebuffer); 6267c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis if (fb_state) 6268c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis fb_state->cb_bindings.erase(cb_node); 6269d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis } 62709f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb); // Remove this command buffer 62719f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; // delete CB info structure 6272a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes } 6273a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->commandPoolMap.erase(commandPool); 6274a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes lock.unlock(); 6275e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 62764a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyCommandPool(device, commandPool, pAllocator); 62775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 627989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 628089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 628283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6283400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 62841ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 6285a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 628683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with"); 62871ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 6288a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes 628983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 62905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 62915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62924a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.ResetCommandPool(device, commandPool, flags); 62935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 62955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62961ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.lock(); 6297a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 6298a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmdBuffer : pPool->commandBuffers) { 6299a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes resetCB(dev_data, cmdBuffer); 63005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63011ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 630689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 630883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6309b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 6311df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 6312090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence && pFence->state == FENCE_INFLIGHT) { 631383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 631483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 631583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is in use.", reinterpret_cast<const uint64_t &>(pFences[i])); 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6318b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6319090da73358f71ba026e2474a822fecf55267d166Chris Forbes 632083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 6321090da73358f71ba026e2474a822fecf55267d166Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 6322090da73358f71ba026e2474a822fecf55267d166Chris Forbes 63234a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.ResetFences(device, fenceCount, pFences); 6324090da73358f71ba026e2474a822fecf55267d166Chris Forbes 6325090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (result == VK_SUCCESS) { 6326090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.lock(); 6327090da73358f71ba026e2474a822fecf55267d166Chris Forbes for (uint32_t i = 0; i < fenceCount; ++i) { 6328090da73358f71ba026e2474a822fecf55267d166Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 6329090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence) { 6330090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->state = FENCE_UNSIGNALED; 6331090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6332090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6333090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.unlock(); 6334090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6335090da73358f71ba026e2474a822fecf55267d166Chris Forbes 63365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6339e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis// For given cb_nodes, invalidate them and track object causing invalidation 6340e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlisvoid invalidateCommandBuffers(std::unordered_set<GLOBAL_CB_NODE *> cb_nodes, VK_OBJECT obj) { 6341e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto cb_node : cb_nodes) { 6342e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->state = CB_INVALID; 6343e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->broken_bindings.push_back(obj); 6344e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis } 6345e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis} 6346e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis 6347c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic bool PreCallValidateDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, 6348c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis FRAMEBUFFER_STATE **framebuffer_state, VK_OBJECT *obj_struct) { 6349728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis if (dev_data->instance_state->disabled.destroy_framebuffer) 6350728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis return false; 6351728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis bool skip = false; 6352c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis *framebuffer_state = getFramebufferState(dev_data, framebuffer); 6353728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis if (*framebuffer_state) { 6354728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}; 6355728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *framebuffer_state, *obj_struct, VALIDATION_ERROR_00422); 6356728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis } 6357728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis return skip; 6358728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis} 6359728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis 6360c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic void PostCallRecordDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, FRAMEBUFFER_STATE *framebuffer_state, 6361728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis VK_OBJECT obj_struct) { 6362728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis invalidateCommandBuffers(framebuffer_state->cb_bindings, obj_struct); 6363728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis dev_data->frameBufferMap.erase(framebuffer); 6364728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis} 6365728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis 636689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 636789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6369c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis FRAMEBUFFER_STATE *framebuffer_state = nullptr; 6370728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis VK_OBJECT obj_struct; 6371b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6372728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis bool skip = PreCallValidateDestroyFramebuffer(dev_data, framebuffer, &framebuffer_state, &obj_struct); 6373728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis if (!skip) { 6374728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis lock.unlock(); 6375728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis dev_data->dispatch_table.DestroyFramebuffer(device, framebuffer, pAllocator); 6376728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis lock.lock(); 6377728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis PostCallRecordDestroyFramebuffer(dev_data, framebuffer, framebuffer_state, obj_struct); 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63810ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlisstatic bool PreCallValidateDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE **rp_state, 63820ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis VK_OBJECT *obj_struct) { 63830ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis if (dev_data->instance_state->disabled.destroy_renderpass) 63840ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis return false; 63850ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis bool skip = false; 63860ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis *rp_state = getRenderPassState(dev_data, render_pass); 63870ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis if (*rp_state) { 63880ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(render_pass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}; 63890ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *rp_state, *obj_struct, VALIDATION_ERROR_00393); 63900ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis } 63910ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis return skip; 63920ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis} 63930ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis 63940ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlisstatic void PostCallRecordDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE *rp_state, 63950ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis VK_OBJECT obj_struct) { 63960ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis invalidateCommandBuffers(rp_state->cb_bindings, obj_struct); 63970ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis dev_data->renderPassMap.erase(render_pass); 63980ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis} 63990ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis 640089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 640189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 64025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64030ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis RENDER_PASS_STATE *rp_state = nullptr; 64040ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis VK_OBJECT obj_struct; 6405e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 64060ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis bool skip = PreCallValidateDestroyRenderPass(dev_data, renderPass, &rp_state, &obj_struct); 6407a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis if (!skip) { 6408a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis lock.unlock(); 64094a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator); 64100ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis lock.lock(); 64110ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis PostCallRecordDestroyRenderPass(dev_data, renderPass, rp_state, obj_struct); 6412a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis } 64135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 641589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 641689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 64175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64184f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00658 64194f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00666 64204f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00667 64214f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00668 64224f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00669 64234a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 64245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6426b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 6428b5e51047540e12567fbf674b23fe75ca86ca0371Tobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_NODE>(new BUFFER_NODE(*pBuffer, pCreateInfo)))); 64295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64338c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateBufferView(layer_data *dev_data, const VkBufferViewCreateInfo *pCreateInfo) { 64348c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 64358c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young BUFFER_NODE *buf_node = getBufferNode(dev_data, pCreateInfo->buffer); 64368c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young // If this isn't a sparse buffer, it needs to have memory backing it at CreateBufferView time 6437b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (buf_node) { 6438b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buf_node, "vkCreateBufferView()"); 6439cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 6440cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 644159b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, buf_node, 6442b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, 6443b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski false, "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 6444b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 64458c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 64468c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 64478c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young 644889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 644989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 64505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64518c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 64528c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateBufferView(dev_data, pCreateInfo); 64538c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 64548c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 64558c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 64564a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateBufferView(device, pCreateInfo, pAllocator, pView); 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 64588c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 645939267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis dev_data->bufferViewMap[*pView] = unique_ptr<BUFFER_VIEW_STATE>(new BUFFER_VIEW_STATE(*pView, pCreateInfo)); 64608c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 646589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 646689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 64675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 646847892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 64694a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateImage(device, pCreateInfo, pAllocator, pImage); 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6472b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64731facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis IMAGE_LAYOUT_NODE image_state; 64741facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state.layout = pCreateInfo->initialLayout; 64751facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state.format = pCreateInfo->format; 64761facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, unique_ptr<IMAGE_STATE>(new IMAGE_STATE(*pImage, pCreateInfo)))); 64775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 64791facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_state; 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 6485b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64871facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 64881facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 64895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 64905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 64941facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis range->levelCount = image_state->createInfo.mipLevels - range->baseMipLevel; 64955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 64981facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis range->layerCount = image_state->createInfo.arrayLayers - range->baseArrayLayer; 64995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 65065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 6507b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 65085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 65111facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 65121facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 65141facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis *levels = image_state->createInfo.mipLevels - range.baseMipLevel; 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 65171facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis *layers = image_state->createInfo.arrayLayers - range.baseArrayLayer; 65185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65228c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo) { 65238c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 65241facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis IMAGE_STATE *image_state = getImageState(dev_data, pCreateInfo->image); 65251facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 65265a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour skip_call |= ValidateImageUsageFlags( 65271facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis dev_data, image_state, VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | 65281facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 65295a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour false, "vkCreateImageView()", 65305a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT|DEPTH_STENCIL_ATTACHMENT|INPUT_ATTACHMENT]_BIT"); 6531b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski // If this isn't a sparse image, it needs to have memory backing it at CreateImageView time 65321facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCreateImageView()"); 6533bb6624cb996175d8945190886a200e720b3871efChris Forbes } 65348c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 65358c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6536bb6624cb996175d8945190886a200e720b3871efChris Forbes 653779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlisstatic inline void PostCallRecordCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo, VkImageView view) { 653879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis dev_data->imageViewMap[view] = unique_ptr<IMAGE_VIEW_STATE>(new IMAGE_VIEW_STATE(view, pCreateInfo)); 653979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[view].get()->create_info.subresourceRange, pCreateInfo->image); 65408c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6541bb6624cb996175d8945190886a200e720b3871efChris Forbes 65428c07a094dc9cc4afb6b62181f341c12b9e969041Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 65438c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 65448c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65458c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 65468c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateImageView(dev_data, pCreateInfo); 65478c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 65488c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 65498c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 65504a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateImageView(device, pCreateInfo, pAllocator, pView); 65515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65528c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 655379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis PostCallRecordCreateImageView(dev_data, pCreateInfo, *pView); 65548c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 65555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6556bb6624cb996175d8945190886a200e720b3871efChris Forbes 65575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 656089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 656189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65634a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateFence(device, pCreateInfo, pAllocator, pFence); 65645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6565b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6566a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 65678988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes fence_node.fence = *pFence; 6568a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 6569cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; 65705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 657589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 657689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 65775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65784a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 65795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 658389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 65845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65854a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyPipelineCache(device, pipelineCache, pAllocator); 65865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 658989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 65905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65914a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 65925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 659689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 65975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65984a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 65995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66023d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 66034c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisvoid set_pipeline_state(PIPELINE_STATE *pPipe) { 66043d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 66053d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 66063d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 66073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 66083d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 66093d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 66103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 66113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 66123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 66133d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 66143d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 66153d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 66163d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 66173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 66183d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 66193d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 66203d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 66213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 66223d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 662389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 662489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 662589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 662689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 66275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 66285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 66295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 66304c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_STATE struct 66315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 66325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 663383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 66345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 66354c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis vector<PIPELINE_STATE *> pPipeState(count); 66365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6639b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 66424c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i] = new PIPELINE_STATE; 66434c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i]->initGraphicsPipeline(&pCreateInfos[i]); 6644127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis pPipeState[i]->render_pass_ci.initialize(getRenderPassState(dev_data, pCreateInfos[i].renderPass)->createInfo.ptr()); 6645c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlis pPipeState[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 664667220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 66474c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis skip_call |= verifyPipelineCreateState(dev_data, device, pPipeState, i); 66485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 665083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6651b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66524a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = 66534a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); 6654b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 66555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 66564c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i]->pipeline = pPipelines[i]; 66574c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis dev_data->pipelineMap[pPipeState[i]->pipeline] = pPipeState[i]; 66585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6659b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 66624c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis delete pPipeState[i]; 66635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6664b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 667089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 667189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 667289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 667389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 66745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 667583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 66784c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis vector<PIPELINE_STATE *> pPipeState(count); 66795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6682b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 66845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 66874c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i] = new PIPELINE_STATE; 66884c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i]->initComputePipeline(&pCreateInfos[i]); 6689c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlis pPipeState[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 66904c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis // memcpy(&pPipeState[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 66915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 66934c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis skip_call |= !validate_compute_pipeline(dev_data->report_data, pPipeState[i], &dev_data->enabled_features, 669483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->shaderModuleMap); 66954c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis // skip_call |= verifyPipelineCreateState(dev_data, device, pPipeState[i]); 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 669883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6699b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67004a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = 67014a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); 6702b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 67044c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i]->pipeline = pPipelines[i]; 67054c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis dev_data->pipelineMap[pPipeState[i]->pipeline] = pPipeState[i]; 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6707b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 67105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 67114c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis delete pPipeState[i]; 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6713b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 671989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 672089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67224a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateSampler(device, pCreateInfo, pAllocator, pSampler); 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6724b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6725cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 67265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 673089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 673189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 673289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 67335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67344a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 67355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 6737b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6738cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = 6739cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis new cvdescriptorset::DescriptorSetLayout(dev_data->report_data, pCreateInfo, *pSetLayout); 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67449e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 67459e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 67469e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 67479e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 67480dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis if (dev_data->instance_state->disabled.push_constant_range) 67490dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis return false; 67509e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 675183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 67529e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 67539e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 67541c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis // TODO : This check combines VALIDATION_ERROR_00877 & 880, need to break out separately 67559e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 67569e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 67579e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 675883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 67599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 67601c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis VALIDATION_ERROR_00877, "DS", "%s call has push constants index %u with offset %u and size %u that " 67611c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis "exceeds this device's maxPushConstantSize of %u. %s", 67621c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis caller_name, index, offset, size, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00877]); 67639e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 676483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 676583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 676683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 676783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset, size, maxPushConstantsSize); 67689e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 676983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 677083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 67719e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 67729e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 67739e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 67741c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis // TODO : This check combines VALIDATION_ERROR_00878 & 879, need to break out separately 67759e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 67769e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 67771c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 67781c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis VALIDATION_ERROR_00878, "DS", "%s call has push constants index %u with " 67791c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis "size %u. Size must be greater than zero and a multiple of 4. %s", 67801c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis caller_name, index, size, validation_error_map[VALIDATION_ERROR_00878]); 67819e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 678283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 67839e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 67849e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 67859e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 67869e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 67879e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 678883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 678983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 67909e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 67919e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 67929e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 67939e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 67949e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 679583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 679683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 679783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 679883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, index, offset); 67999e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 680083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 680183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 680283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 680383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset); 68049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 680583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 680683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 68079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 68085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 680983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 681289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 681389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 681483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68161c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis // TODO : Add checks for VALIDATION_ERRORS 865-871 68179e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 681807a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz uint32_t i, j; 68195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 682083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 682183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 68229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 682383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 682483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 68259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 68269e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 682707a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz if (skip_call) 682807a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz return VK_ERROR_VALIDATION_FAILED_EXT; 682907a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz 68309e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 683107a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz // There's no explicit Valid Usage language against this, so issue a warning instead of an error. 683207a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 683307a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 683407a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 683507a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 683607a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 683707a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 683807a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 683907a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz skip_call |= 684007a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 684107a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 684207a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 684307a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz i, minA, maxA, j, minB, maxB); 68449e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6847f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 68484a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 68495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6850b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 68515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 685269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis plNode.layout = *pPipelineLayout; 6853416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts.resize(pCreateInfo->setLayoutCount); 68545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 6855416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6857416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges.resize(pCreateInfo->pushConstantRangeCount); 68585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 6859416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges[i] = pCreateInfo->pPushConstantRanges[i]; 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 686589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 686689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 686789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 68685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68694a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 68705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 68715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6872414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 68735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6875a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *pNewNode = new DESCRIPTOR_POOL_STATE(*pDescriptorPool, pCreateInfo); 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 6879a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_STATE in vkCreateDescriptorPool()")) 68805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6882b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 68835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 689189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 689289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 68937286e20c06011d3c6fa7edfbdbadd42bb6e8cc35Tobin Ehlis // TODO : Add checks for VALIDATION_ERROR_00928 68945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68954a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.ResetDescriptorPool(device, descriptorPool, flags); 68965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6897b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 68985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 68995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69022c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// Ensure the pool contains enough descriptors and descriptor sets to satisfy 6903789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// an allocation request. Fills common_data with the total number of descriptors of each type required, 6904789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// as well as DescriptorSetLayout ptrs used for later update. 69057f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlisstatic bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 69067f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData *common_data) { 69070dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis if (dev_data->instance_state->disabled.allocate_descriptor_sets) 69080dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis return false; 69097e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All state checks for AllocateDescriptorSets is done in single function 6910e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehlis return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); 69117e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis} 69127e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Allocation state was good and call down chain was made so update state based on allocating descriptor sets 69137e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlisstatic void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 69147f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis VkDescriptorSet *pDescriptorSets, 69157f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis const cvdescriptorset::AllocateDescriptorSetsData *common_data) { 69167e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All the updates are contained in a single cvdescriptorset function 69172c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, 6918b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis &dev_data->setMap, dev_data); 69192c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes} 69202c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 692189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 692289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 69235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6924b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69257f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); 69267f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); 6927b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6928d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 69297e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis if (skip_call) 69305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6931d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 69324a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 69336511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 69345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6935b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 69367f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); 6937b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 69385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6941cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Verify state before freeing DescriptorSets 6942cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6943cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 69440dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis if (dev_data->instance_state->disabled.free_descriptor_sets) 69450dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis return false; 6946cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skip_call = false; 6947cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // First make sure sets being destroyed are not currently in-use 6948cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6949cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); 6950cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6951a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *pool_state = getDescriptorPoolState(dev_data, pool); 6952a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis if (pool_state && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_state->createInfo.flags)) { 6953cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Can't Free from a NON_FREE pool 6954cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 69551c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis reinterpret_cast<uint64_t &>(pool), __LINE__, VALIDATION_ERROR_00922, "DS", 6956cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 69571c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT. %s", 69581c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis validation_error_map[VALIDATION_ERROR_00922]); 6959cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6960cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis return skip_call; 6961cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 6962cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Sets have been removed from the pool so update underlying state 6963cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6964cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6965a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *pool_state = getDescriptorPoolState(dev_data, pool); 6966cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Update available descriptor sets in pool 6967cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableSets += count; 6968cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6969cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 6970cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 6971cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis auto set_state = dev_data->setMap[descriptor_sets[i]]; 6972cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis uint32_t type_index = 0, descriptor_count = 0; 6973cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t j = 0; j < set_state->GetBindingCount(); ++j) { 6974cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis type_index = static_cast<uint32_t>(set_state->GetTypeFromIndex(j)); 6975cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis descriptor_count = set_state->GetDescriptorCountFromIndex(j); 6976cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; 6977cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6978cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis freeDescriptorSet(dev_data, set_state); 6979cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->sets.erase(set_state); 6980cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6981cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 69825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 698389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 698489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 69865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6987b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 698883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6989b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6990e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 699183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 69925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 69934a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 69945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6995b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6996cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6997b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70016b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// TODO : This is a Proof-of-concept for core validation architecture 70026b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// Really we'll want to break out these functions to separate files but 70036b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// keeping it all together here to prove out design 70046b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() 70056b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 70066b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 70076b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 7008793fead81a7a480b5609b36121dc5ddd31d7e9dfTobin Ehlis if (dev_data->instance_state->disabled.update_descriptor_sets) 7009793fead81a7a480b5609b36121dc5ddd31d7e9dfTobin Ehlis return false; 70106b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // First thing to do is perform map look-ups. 70116b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets 70126b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // so we can't just do a single map look-up up-front, but do them individually in functions below 70136b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis 70146b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Now make call(s) that validate state, but don't perform state updates in this function 70156b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the 70166b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // namespace which will parse params and make calls into specific class instances 7017104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, 7018104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis descriptorCopyCount, pDescriptorCopies); 70196b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 70206b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() 70216b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 70226b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 70236b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 7024104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 70256b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 70266b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 702889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 702989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 703089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 70316b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Only map look-up at top level is for device-level layer_data 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 7033b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70346b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 70356b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 7036b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 70376b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis if (!skip_call) { 70384a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 70394a0754042cf090e131e9e769d8a3633c228625beChris Forbes pDescriptorCopies); 70406b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis lock.lock(); 70416b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Since UpdateDescriptorSets() is void, nothing to check prior to updating state 70426b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 70436b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 70445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 704789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 704889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 70495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 70504a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 7052b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7053cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, pCreateInfo->commandPool); 7054cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes 7055cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (pPool) { 705672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 7058cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes pPool->commandBuffers.push_back(pCommandBuffer[i]); 70595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 70605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 70625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70670a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 7068b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7073883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis// Add bindings between the given cmd buffer & framebuffer and the framebuffer's children 7074c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic void AddFramebufferBinding(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, FRAMEBUFFER_STATE *fb_state) { 70750245b74a083d2cb3b083571deb0fe13b4ab428a4Tobin Ehlis addCommandBufferBinding(&fb_state->cb_bindings, 70760245b74a083d2cb3b083571deb0fe13b4ab428a4Tobin Ehlis {reinterpret_cast<uint64_t &>(fb_state->framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}, 70770245b74a083d2cb3b083571deb0fe13b4ab428a4Tobin Ehlis cb_state); 7078883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis for (auto attachment : fb_state->attachments) { 7079883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis auto view_state = attachment.view_state; 7080883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis if (view_state) { 708103ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis AddCommandBufferBindingImageView(dev_data, cb_state, view_state); 7082883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis } 7083127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto rp_state = getRenderPassState(dev_data, fb_state->createInfo.renderPass); 7084883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis if (rp_state) { 7085883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis addCommandBufferBinding( 7086883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis &rp_state->cb_bindings, 7087883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis {reinterpret_cast<uint64_t &>(rp_state->renderPass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}, cb_state); 7088883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis } 7089883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis } 7090883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis} 7091883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis 709289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 709389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 709483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7096b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 7098f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); 7099f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node) { 71005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 7101a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 710283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 7103a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 7104a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 7105414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Calling vkBeginCommandBuffer() on active CB 0x%p before it has completed. " 7106a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 7107a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 71085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7109f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis clear_cmd_buf_and_mem_references(dev_data, cb_node); 7110f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 71115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 71125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 71135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 711483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 71155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 71165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 7117414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 71185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 71195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 71205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 7121400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 712283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 71235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 71245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 7125414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 71265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 71275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7128400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 712983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 713083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 713183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 713283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 713383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "valid framebuffer parameter is specified.", 713483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 71355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 71365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 7137c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = getFramebufferState(dev_data, pInfo->framebuffer); 7138f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (framebuffer) { 7139a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((framebuffer->createInfo.renderPass != pInfo->renderPass) && 7140a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(dev_data, framebuffer->renderPassCreateInfo.ptr(), 7141127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis getRenderPassState(dev_data, pInfo->renderPass)->createInfo.ptr(), 7142a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis errorString)) { 7143400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 714483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7145a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7146a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 7147a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 7148a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command " 7149a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 7150a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 7151a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<void *>(commandBuffer), reinterpret_cast<const uint64_t &>(pInfo->renderPass), 7152a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<const uint64_t &>(pInfo->framebuffer), 7153a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(framebuffer->createInfo.renderPass), errorString.c_str()); 71545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7155883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis // Connect this framebuffer and its children to this cmdBuffer 7156883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis AddFramebufferBinding(dev_data, cb_node, framebuffer); 71575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 7161f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes dev_data->enabled_features.occlusionQueryPrecise == VK_FALSE) && 71625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 716383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 716483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 716583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 716683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 716783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 716883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "support precise occlusion queries.", 716983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 71705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 7173127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = getRenderPassState(dev_data, pInfo->renderPass); 717416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 7175fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes if (pInfo->subpass >= renderPass->createInfo.subpassCount) { 717683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 717783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 717883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 717983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 718083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "that is less than the number of subpasses (%d).", 7181fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes (void *)commandBuffer, pInfo->subpass, renderPass->createInfo.subpassCount); 71825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7186f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (CB_RECORDING == cb_node->state) { 718783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 71885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 71895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 7190414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Cannot call Begin on CB (0x%" PRIxLEAST64 71915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 71925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 7193f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis } else if (CB_RECORDED == cb_node->state || (CB_INVALID == cb_node->state && CMD_END == cb_node->cmds.back().type)) { 7194f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis VkCommandPool cmdPool = cb_node->createInfo.commandPool; 7195cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 7196cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 719783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 71985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 71995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 7200414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 7201414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 72025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 72035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 72045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 72065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 7208f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->state = CB_RECORDING; 7209f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->beginInfo = *pBeginInfo; 7210f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node->beginInfo.pInheritanceInfo) { 7211f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->inheritanceInfo = *(cb_node->beginInfo.pInheritanceInfo); 7212f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->beginInfo.pInheritanceInfo = &cb_node->inheritanceInfo; 7213888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 7214f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 7215f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis (cb_node->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 7216127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis cb_node->activeRenderPass = getRenderPassState(dev_data, cb_node->beginInfo.pInheritanceInfo->renderPass); 7217f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpass = cb_node->beginInfo.pInheritanceInfo->subpass; 7218f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->framebuffers.insert(cb_node->beginInfo.pInheritanceInfo->framebuffer); 7219888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 72205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 722283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 722383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 722483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB 0x%p!", (void *)commandBuffer); 72255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7226b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 722783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 72285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 72295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72304a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.BeginCommandBuffer(commandBuffer, pBeginInfo); 7231400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 72325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 72335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 723589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 723683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 72385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7239b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7242fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 7243fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 7244fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 724583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 7246fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 724783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); 72485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 724983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 725083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 725183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 725283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(query.pool), query.index); 72535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 725583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7256b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 72574a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.EndCommandBuffer(commandBuffer); 7258b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 72595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 72605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 72625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 72635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 72645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 72675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7268b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 72695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 72705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 727289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 727389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 7274bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 72755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7276b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 7279cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 7280cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 7281bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 7282bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 7283414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 7284bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 7285bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 72865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7287a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, pCB, "reset"); 7288b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7289bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 72905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 72914a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.ResetCommandBuffer(commandBuffer, flags); 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 7293b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 7294a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes dev_data->globalInFlightCmdBuffers.erase(commandBuffer); 72955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 7296b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 72975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 72995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 730093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 730189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 730289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 730383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7305b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 730883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 73095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 731083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 73115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 73125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 7313414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 7314ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass->renderPass); 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73174c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pPN = getPipelineState(dev_data, pipeline); 73185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 73194c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_state = pPN; 73205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 73213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 73225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 732383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 732483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 732583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 73265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73274c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis addCommandBufferBinding(&getPipelineState(dev_data, pipeline)->cb_bindings, 7328a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}, pCB); 73295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7330b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 733183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73324a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 733589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 733689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 733783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7339b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 734283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 7343b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask |= ((1u<<viewportCount) - 1u) << firstViewport; 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7345b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 734683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73474a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 73485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 735089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 735189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 735283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7354b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 735783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 7358b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask |= ((1u<<scissorCount) - 1u) << firstScissor; 73595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7360b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 736183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73624a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 73635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 736589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 7366a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 73675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7368b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7371a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 73725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 7373a27508babf63d50aea75883a3702979193c23683Mark Young 73744c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_state; 7375a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 7376a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 7377a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 7378386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 7379a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 7380a27508babf63d50aea75883a3702979193c23683Mark Young } else { 7381a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 7382a27508babf63d50aea75883a3702979193c23683Mark Young } 73835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7384b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7385a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 73864a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetLineWidth(commandBuffer, lineWidth); 73875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 738989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 739089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 739183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7393b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 739683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 73975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 73985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7399b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 740083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74014a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor); 74025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 740489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 740583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7407b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 741083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 74113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 74125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7413b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 741483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74154a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetBlendConstants(commandBuffer, blendConstants); 74165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 741889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 741989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 742083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7422b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 742583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 74265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 74275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7428b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 742983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74304a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 74315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 743389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 743489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 743583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7437b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 744083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 74415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 74425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7443b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 744483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74454a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 74465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 744889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 744989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 745083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7452b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 745583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 74565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 74575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7458b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 745983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74604a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 74615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 746389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 746489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 746583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7467b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 747083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 74725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7473b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 747483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74754a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetStencilReference(commandBuffer, faceMask, reference); 74765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 747889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 747989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 748089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 748189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 748283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7488787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7489787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7490787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7491787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 7492dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { 749372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 7494dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); 7495dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes } 749671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 7497c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlis auto pipeline_layout = getPipelineLayout(dev_data, layout); 7498787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7499397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7500787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 750169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_layout = *pipeline_layout; 750271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pSet; 750383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 750483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 750583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_NONE, "DS", "DS 0x%" PRIxLEAST64 " bound on pipeline %s", 750683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7507397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 750883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 750983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 751083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 751183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "DS 0x%" PRIxLEAST64 751283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 751383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7514787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7515787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 751669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, pipeline_layout, i + firstSet, errorString)) { 751783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 751883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 751983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 752083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 752183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 752283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 7523787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7524dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7525dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes auto setDynamicDescriptorCount = pSet->GetDynamicDescriptorCount(); 7526dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7527dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); 7528dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7529dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (setDynamicDescriptorCount) { 7530787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7531dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { 753283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 7533787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7534787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7535787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7536414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 7537787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7538787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7539397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 7540787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7541787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7542787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7543787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7544397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 7545397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7546787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7547787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7548b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 754983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7550787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7551787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7552787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7553787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7554414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 7555787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7556b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 7557787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7558787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7559397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7560787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7561787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7562b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 756383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7564787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7565787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7566787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7567787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7568414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 7569787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7570b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7572787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7575dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7576dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = 7577dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, 7578dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); 7579787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7580dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes totalDynamicDescriptors += setDynamicDescriptorCount; 7581dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7584787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 758583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 758683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 758783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS 0x%" PRIxLEAST64 " that doesn't exist!", 758883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 75895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 759083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 759172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 759272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 759372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 759472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 759571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], 759669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pipeline_layout, i, errorString)) { 759783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 759872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 759972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 760072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 7601414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DescriptorSetDS 0x%" PRIxLEAST64 7602414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 760372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 760472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 760572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 760672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 760772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 760872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 760972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 761072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 761169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, pipeline_layout, lastSetIndex, errorString)) { 761271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto old_set = oldFinalBoundSet->GetSet(); 761383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 761472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 761571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, 7616414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DescriptorSetDS 0x%" PRIxLEAST64 7617414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 761872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 7619414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 762071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis reinterpret_cast<uint64_t &>(old_set), lastSetIndex, 762172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 762272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 762372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 76245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7627787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7628787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 762983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 763083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 763183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 763283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 763383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 763483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7635787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 763783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 76385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7640b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 764183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76424a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 76434a0754042cf090e131e9e769d8a3633c228625beChris Forbes pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 76445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 764689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 764789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 764883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7650593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 7651b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7652b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 7653ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 76549f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7655ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7656b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7657ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7658f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7659ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 76609f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 766183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 76635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 76685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 76695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 76715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 76725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 767583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 767683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 767783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 767883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis offset, string_VkIndexType(indexType)); 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76809f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->status |= CBSTATUS_INDEX_BUFFER_BOUND; 7681ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7682ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7684b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 768583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76864a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 76875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7699e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 77005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 770189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 770289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 770389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 770483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 77055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7706593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 7707b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7708b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 77099f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 77109f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 7711593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 7712ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, pBuffers[i]); 7713ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7714b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7715ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7716f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7717ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 77189f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77209f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis addCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 77219f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis updateResourceTracking(cb_node, firstBinding, bindingCount, pBuffers); 77225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 772383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 77245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7725b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 772683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77274a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 77285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7730b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 7731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 77337a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 77347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 773579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, imageView); 773679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state) 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 7738249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 77391facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, view_state->create_info.image); 77401facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis assert(image_state); 7741e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 77421facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, image_state, true); 7743e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77447a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 77457a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 77467a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 77477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 7748ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7749ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7750e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7751f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, buff_node, true); 7752e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 77547a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 77555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 77575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 775989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 776089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 776183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 77625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7763b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 77645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 776683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 77675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 7768e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDraw"); 776983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 77705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 777183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 77725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7773414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW]++); 777483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 777583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 77775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 777883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7780b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 778183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77824a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 778589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 778689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 778983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7790b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 779383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 7795e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexed"); 779683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 77975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 779883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 779983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 780083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 780183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 780283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 78035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 78045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 780583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 78065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7807b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 780883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 78094a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance); 78105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 781289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 781389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 78145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 781583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7816b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7817ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7818ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7819ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7820ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7821b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndirect()"); 7822c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7823ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 7824ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDIRECT]++; 7825e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndirect"); 7826ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 782883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 782983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 783083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 783183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 783283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7833ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 78345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7835b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndirect()"); 7836ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7837ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 78385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7839b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 784083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 78414a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 78425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 784489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 784589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 784683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 78475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7848b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7849ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7850ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7851ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7852ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7853b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndexedIndirect()"); 7854c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7855ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 7856ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDEXED_INDIRECT]++; 7857e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 7858e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexedIndirect"); 7859ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 78605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 786183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 78625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7863414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting DS state:", 78645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 786583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 786683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7867ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 78685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7869b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndexedIndirect()"); 7870ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7871ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 78725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7873b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 787483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 78754a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 78765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 787889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 787983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 78805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7881b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 78825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7884e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatch"); 788583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 788683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 788783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7889b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 789083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 78914a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDispatch(commandBuffer, x, y, z); 78925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 789489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 789589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 789683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 78975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7898b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7899ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7900ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7901ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7902b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (cb_node && buff_node) { 7903b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDispatchIndirect()"); 7904c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7905e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 7906e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatchIndirect"); 7907ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 7908ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 7909b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdDispatchIndirect()"); 79105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7911b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 791283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 79134a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDispatchIndirect(commandBuffer, buffer, offset); 79145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 791689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 791789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 791883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 79195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7920b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7921ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 79229f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7923ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 7924ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7925ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && src_buff_node && dst_buff_node) { 7926b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 7927b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyBuffer()"); 7928ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffers and cmd buffer 7929c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 7930c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 7931ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 793259b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyBuffer()", 7933ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 793459b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyBuffer()", 7935ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7936ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7937ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7938f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 7939ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 79409f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7941593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7942f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 7943e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 79459f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7946593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 794783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 7948b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBuffer()"); 7949ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7950ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Param_checker will flag errors on invalid objects, just assert here as debugging aid 7951ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7953b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 795483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 79554a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 79565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 795827e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifySourceImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage srcImage, 795927e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout srcImageLayout) { 7960e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 79615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 79635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 79655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 796627e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, srcImage, sub, node)) { 796727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 79685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 79695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 79715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 79725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 79735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 79765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 798107b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // TODO : Can we deal with image node from the top of call tree and avoid map look-up here? 79821facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, srcImage); 79831facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 798407b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 798507b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 798607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 798707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 798807b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 79895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 79935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 79975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 799927e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifyDestImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage destImage, 800027e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout destImageLayout) { 8001e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 80055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 80065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 800727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, destImage, sub, node)) { 800827e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 80105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 80125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 80135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 80145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 80155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 80165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 80175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 80205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 80211facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, destImage); 80221facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 802307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 802407b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 802507b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 802607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 802707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 80285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 80305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 80365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80389ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test if two VkExtent3D structs are equivalent 80399ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentEqual(const VkExtent3D *extent, const VkExtent3D *other_extent) { 80409ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano bool result = true; 80419ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((extent->width != other_extent->width) || (extent->height != other_extent->height) || 80429ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano (extent->depth != other_extent->depth)) { 80439ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano result = false; 80449ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 80459ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return result; 80469ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 80479ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 80489ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Returns the image extent of a specific subresource. 80491facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic inline VkExtent3D GetImageSubresourceExtent(const IMAGE_STATE *img, const VkImageSubresourceLayers *subresource) { 80509ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t mip = subresource->mipLevel; 80519ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D extent = img->createInfo.extent; 805290b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.width = std::max(1U, extent.width >> mip); 805390b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.height = std::max(1U, extent.height >> mip); 805490b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.depth = std::max(1U, extent.depth >> mip); 80559ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return extent; 80569ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 80579ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 80589ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test if the extent argument has all dimensions set to 0. 80599ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentZero(const VkExtent3D *extent) { 80609ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return ((extent->width == 0) && (extent->height == 0) && (extent->depth == 0)); 80619ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 80629ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 80639ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Returns the image transfer granularity for a specific image scaled by compressed block size if necessary. 80641facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic inline VkExtent3D GetScaledItg(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const IMAGE_STATE *img) { 80659ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // Default to (0, 0, 0) granularity in case we can't find the real granularity for the physical device. 80669ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = { 0, 0, 0 }; 8067f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski auto pPool = getCommandPoolNode(dev_data, cb_node->createInfo.commandPool); 8068f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (pPool) { 80699ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity = dev_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].minImageTransferGranularity; 80709ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_format_is_compressed(img->createInfo.format)) { 80719ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano auto block_size = vk_format_compressed_block_size(img->createInfo.format); 80729ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity.width *= block_size.width; 80739ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity.height *= block_size.height; 8074f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8075f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 80769ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return granularity; 80779ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 80789ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 80799ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test elements of a VkExtent3D structure against alignment constraints contained in another VkExtent3D structure 80809ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentAligned(const VkExtent3D *extent, const VkExtent3D *granularity) { 80819ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano bool valid = true; 80829ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((vk_safe_modulo(extent->depth, granularity->depth) != 0) || (vk_safe_modulo(extent->width, granularity->width) != 0) || 80839ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano (vk_safe_modulo(extent->height, granularity->height) != 0)) { 80849ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano valid = false; 80859ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 8086f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return valid; 8087f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8088f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8089f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkOffset3D structure against a queue family's Image Transfer Granularity values 80909ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgOffset(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkOffset3D *offset, 80919ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const VkExtent3D *granularity, const uint32_t i, const char *function, const char *member) { 8092f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 80939ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D offset_extent = {}; 80949ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.width = static_cast<uint32_t>(abs(offset->x)); 80959ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.height = static_cast<uint32_t>(abs(offset->y)); 80969ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.depth = static_cast<uint32_t>(abs(offset->z)); 80979ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(granularity)) { 80989ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is (0, 0, 0), then the offset must always be (0, 0, 0) 80999ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(&offset_extent) == false) { 81009ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81019ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 81029ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) must be (x=0, y=0, z=0) " 81039ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", 81049ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, offset->x, offset->y, offset->z); 81059ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 81069ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } else { 81079ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is not (0, 0, 0), then the offset dimensions must always be even 81089ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // integer multiples of the image transfer granularity. 81099ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentAligned(&offset_extent, granularity) == false) { 81109ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81119ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 81129ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) dimensions must be even integer " 81139ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "multiples of this command buffer's queue family image transfer granularity (w=%d, h=%d, d=%d).", 81149ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, offset->x, offset->y, offset->z, granularity->width, granularity->height, 81159ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity->depth); 81169ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 8117f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8118f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8119f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8120f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8121f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkExtent3D structure against a queue family's Image Transfer Granularity values 81229ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgExtent(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkExtent3D *extent, 81239ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const VkOffset3D *offset, const VkExtent3D *granularity, const VkExtent3D *subresource_extent, 81249ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function, const char *member) { 8125f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 81269ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(granularity)) { 81279ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is (0, 0, 0), then the extent must always match the image 81289ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // subresource extent. 81299ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentEqual(extent, subresource_extent) == false) { 81309ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81319ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 81329ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d) " 81339ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", 81349ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, extent->width, extent->height, extent->depth, subresource_extent->width, 81359ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano subresource_extent->height, subresource_extent->depth); 81369ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 81379ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } else { 81389ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is not (0, 0, 0), then the extent dimensions must always be even 81399ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // integer multiples of the image transfer granularity or the offset + extent dimensions must always match the image 81409ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // subresource extent dimensions. 81419ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D offset_extent_sum = {}; 81429ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.width = static_cast<uint32_t>(abs(offset->x)) + extent->width; 81439ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.height = static_cast<uint32_t>(abs(offset->y)) + extent->height; 81449ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.depth = static_cast<uint32_t>(abs(offset->z)) + extent->depth; 81459ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((IsExtentAligned(extent, granularity) == false) && (IsExtentEqual(&offset_extent_sum, subresource_extent) == false)) { 81469ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= 81479ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8148f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 81499ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) dimensions must be even integer multiples of this command buffer's " 81509ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "queue family image transfer granularity (w=%d, h=%d, d=%d) or offset (x=%d, y=%d, z=%d) + " 81519ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "extent (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d).", 81529ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, extent->width, extent->height, extent->depth, granularity->width, granularity->height, 81539ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity->depth, offset->x, offset->y, offset->z, extent->width, extent->height, extent->depth, 81549ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano subresource_extent->width, subresource_extent->height, subresource_extent->depth); 81559ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 8156f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8157f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8158f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8159f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8160f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a uint32_t width or stride value against a queue family's Image Transfer Granularity width value 81619ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgInt(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const uint32_t value, 81629ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t granularity, const uint32_t i, const char *function, const char *member) { 8163f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 81649ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_safe_modulo(value, granularity) != 0) { 8165f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8166f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 81679ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (%d) must be an even integer multiple of this command buffer's queue family image " 81689ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "transfer granularity width (%d).", 81699ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, value, granularity); 8170f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8171f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8172f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8173f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8174f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a VkDeviceSize value against a queue family's Image Transfer Granularity width value 81759ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgSize(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkDeviceSize value, 81769ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t granularity, const uint32_t i, const char *function, const char *member) { 8177f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 81789ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_safe_modulo(value, granularity) != 0) { 81799ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81809ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 81819ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (%" PRIdLEAST64 81829ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano ") must be an even integer multiple of this command buffer's queue family image transfer " 81839ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "granularity width (%d).", 81849ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, value, granularity); 8185f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8186f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8187f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8188f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8189f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkImageCopy structure 8190f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 81911facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis const IMAGE_STATE *img, const VkImageCopy *region, 81929ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function) { 8193f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 81949ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); 81959ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->srcOffset, &granularity, i, function, "srcOffset"); 81969ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->dstOffset, &granularity, i, function, "dstOffset"); 81979ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->dstSubresource); 81989ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgExtent(dev_data, cb_node, ®ion->extent, ®ion->dstOffset, &granularity, &subresource_extent, i, function, 81999ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "extent"); 8200f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8201f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8202f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8203f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkBufferImageCopy structure 8204f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyBufferImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 82051facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis const IMAGE_STATE *img, const VkBufferImageCopy *region, 82069ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function) { 8207f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 82089ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); 82099ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgSize(dev_data, cb_node, region->bufferOffset, granularity.width, i, function, "bufferOffset"); 82109ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgInt(dev_data, cb_node, region->bufferRowLength, granularity.width, i, function, "bufferRowLength"); 82119ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgInt(dev_data, cb_node, region->bufferImageHeight, granularity.width, i, function, "bufferImageHeight"); 82129ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->imageOffset, &granularity, i, function, "imageOffset"); 82139ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->imageSubresource); 82149ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgExtent(dev_data, cb_node, ®ion->imageExtent, ®ion->imageOffset, &granularity, &subresource_extent, i, 82159ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, "imageExtent"); 8216f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8217f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8218f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 821989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 822089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 822189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 822283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8224b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8225249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 82269f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 82271facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto src_image_state = getImageState(dev_data, srcImage); 82281facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto dst_image_state = getImageState(dev_data, dstImage); 82291facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_image_state && dst_image_state) { 82301facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdCopyImage()"); 82311facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdCopyImage()"); 8232249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 82331facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); 82341facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); 8235249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 82361facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyImage()", 8237ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 82381facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyImage()", 8239ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 82401facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis std::function<bool()> function = [=]() { 82411facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdCopyImage()"); 82421facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis }; 82439f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8244593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 82451facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, dst_image_state, true); 8246e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 82489f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8249593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 825083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGE, "vkCmdCopyImage()"); 8251b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImage()"); 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 825327e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].srcSubresource, srcImageLayout); 825427e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].dstSubresource, dstImageLayout); 82551facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateCopyImageTransferGranularityRequirements(dev_data, cb_node, dst_image_state, &pRegions[i], i, 82569ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "vkCmdCopyImage()"); 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8258249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8259249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 82605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8261b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 826283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 82634a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, 82644a0754042cf090e131e9e769d8a3633c228625beChris Forbes pRegions); 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8267eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski// Validate that an image's sampleCount matches the requirement for a specific API call 82681facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic inline bool ValidateImageSampleCount(layer_data *dev_data, IMAGE_STATE *image_state, VkSampleCountFlagBits sample_count, 8269eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski const char *location) { 8270eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski bool skip = false; 82711facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state->createInfo.samples != sample_count) { 8272eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 82731facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis reinterpret_cast<uint64_t &>(image_state->image), 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 8274eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski "%s for image 0x%" PRIxLEAST64 " was created with a sample count of %s but must be %s.", location, 82751facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis reinterpret_cast<uint64_t &>(image_state->image), 82761facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis string_VkSampleCountFlagBits(image_state->createInfo.samples), string_VkSampleCountFlagBits(sample_count)); 8277eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski } 8278eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski return skip; 8279eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski} 8280eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski 828189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 828289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 828389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 828483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8286b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8287593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 82889f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 82891facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto src_image_state = getImageState(dev_data, srcImage); 82901facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto dst_image_state = getImageState(dev_data, dstImage); 82911facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_image_state && dst_image_state) { 82921facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageSampleCount(dev_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): srcImage"); 82931facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageSampleCount(dev_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): dstImage"); 82941facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdBlitImage()"); 82951facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdBlitImage()"); 8296249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 82971facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); 82981facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); 8299249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 83001facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdBlitImage()", 8301ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 83021facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdBlitImage()", 8303ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 83041facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis std::function<bool()> function = [=]() { 83051facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdBlitImage()"); 83061facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis }; 83079f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8308593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 83091facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, dst_image_state, true); 8310e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 83115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 83129f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8313593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 831483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); 8315b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBlitImage()"); 8316249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8317249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 83185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8319b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 832083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 83214a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, 83224a0754042cf090e131e9e769d8a3633c228625beChris Forbes pRegions, filter); 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 832589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 832689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 832789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 832883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8330b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8331593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 83329f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8333ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 83341facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto dst_image_state = getImageState(dev_data, dstImage); 83351facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_buff_node && dst_image_state) { 83361facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= 83371facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis ValidateImageSampleCount(dev_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyBufferToImage(): dstImage"); 8338b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); 83391facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdCopyBufferToImage()"); 8340c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 83411facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); 834259b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 8343ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 83441facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 8345ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 8346e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 83471facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, dst_image_state, true); 8348e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 83509f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8351f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis function = [=]() { return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); }; 83529f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8353593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 835483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 8355b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBufferToImage()"); 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 835727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].imageSubresource, dstImageLayout); 83581facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, dst_image_state, &pRegions[i], i, 83599ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "vkCmdCopyBufferToImage()"); 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8361ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8362ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8364b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 836583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 83664a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions); 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 836989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 837089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 837189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 837283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8374b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8375593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 83769f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 83771facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto src_image_state = getImageState(dev_data, srcImage); 8378ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 83791facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_image_state && dst_buff_node) { 83801facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= 83811facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis ValidateImageSampleCount(dev_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyImageToBuffer(): srcImage"); 83821facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdCopyImageToBuffer()"); 8383b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyImageToBuffer()"); 8384249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between buffer/image and cmd buffer 83851facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); 8386c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8387249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC image & DST buffer have correct usage flags set 83881facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 8389ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 839059b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8391ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8392e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 83931facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdCopyImageToBuffer()"); 8394e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 83959f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8396593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8397f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8398e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 84009f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8401593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 840283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 8403b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImageToBuffer()"); 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 840527e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].imageSubresource, srcImageLayout); 84061facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, src_image_state, &pRegions[i], i, 84079ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "CmdCopyImageToBuffer"); 84085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8409ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8410ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8412b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 841383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84144a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions); 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 841789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 841889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 841983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 84205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8421b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8422593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 84239f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8424ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8425ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8426b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdUpdateBuffer()"); 8427ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8428c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8429ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 843059b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8431ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8432e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8433f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8434e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 84355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 84369f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8437593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 843883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 8439b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyUpdateBuffer()"); 8440ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8441ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 84425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8443b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 844483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84454a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 84465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 844889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 844989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 845083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 84515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8452b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8453593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 84549f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8455ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8456ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8457b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdFillBuffer()"); 8458ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8459c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8460ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 846159b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdFillBuffer()", 8462ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8464f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8465e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 84665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 84679f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8468593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 846983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 8470b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyFillBuffer()"); 8471ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8472ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 84735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8474b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 847583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84764a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 84775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 847989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 848089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 848189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 848283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 84835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 84855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 84865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 848783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 84895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 84945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 849583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 8496a1a137ec383fef3881f86d4c202b1de56a91edf0Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(commandBuffer), 8497a1a137ec383fef3881f86d4c202b1de56a91edf0Chris Forbes 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 849883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 849983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 850083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(commandBuffer)); 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8502b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments()"); 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 85065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 8507fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->createInfo.ptr(); 85085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 85115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 85131710af939cd452f3c02e93f598f20e5e12eb6c3bChris Forbes if (attachment->colorAttachment >= pSD->colorAttachmentCount) { 851483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 851521a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 85165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 85171710af939cd452f3c02e93f598f20e5e12eb6c3bChris Forbes "vkCmdClearAttachments() color attachment index %d out of range for active subpass %d; ignored", 85185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 85195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8520dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes else if (pSD->pColorAttachments[attachment->colorAttachment].attachment == VK_ATTACHMENT_UNUSED) { 8521dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes skip_call |= log_msg( 852221a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 8523dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 8524dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes "vkCmdClearAttachments() color attachment index %d is VK_ATTACHMENT_UNUSED; ignored", 8525dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes attachment->colorAttachment); 8526dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes } 85275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 85285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 85295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 85305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 853283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 853321a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 85345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 85357386605ae0fe78241c997605a843bdc9a5499e2bChris Forbes "vkCmdClearAttachments() depth/stencil clear with no depth/stencil attachment in subpass; ignored"); 85365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8540b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 854183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 85424a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 854589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 854689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 854789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 854883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8550b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 85515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8552249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 85539f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 85541facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 85551facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && image_state) { 85561facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCmdClearColorImage()"); 85571facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, image_state); 8558e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 85591facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, image_state, true); 8560e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 85615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 85629f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8563593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 856483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 8565b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearColorImage()"); 8566249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8567249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 85685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8569b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 857083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 85714a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 857489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 857589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 857689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 857789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 857883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 85795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8580b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8582249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 85839f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 85841facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 85851facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && image_state) { 85861facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCmdClearDepthStencilImage()"); 85871facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, image_state); 8588e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 85891facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, image_state, true); 8590e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 85929f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8593593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 859483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 8595b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearDepthStencilImage()"); 8596249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8597249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 85985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8599b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 860083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 86014a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges); 86025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 860489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 860589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 860689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 860783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8609b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8610593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 86119f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 86121facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto src_image_state = getImageState(dev_data, srcImage); 86131facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto dst_image_state = getImageState(dev_data, dstImage); 86141facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_image_state && dst_image_state) { 86151facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdResolveImage()"); 86161facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdResolveImage()"); 8617249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 86181facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); 86191facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); 8620e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 86211facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdResolveImage()"); 8622593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 86239f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8624593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 86251facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, dst_image_state, true); 8626e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 86289f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8629593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 863083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 8631b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdResolveImage()"); 8632249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8633249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8635b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 863683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 86374a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, 86384a0754042cf090e131e9e769d8a3633c228625beChris Forbes pRegions); 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8641b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8642b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8643b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8644b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8645b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8646b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8647b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8648b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8649b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8650b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8651b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8652b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8653b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 865489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 865589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 865683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8658b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 866183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 866283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 8663ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 8664ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8665ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8666ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 8667ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8668ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8670c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8671c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8672c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8673b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8674b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8675b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 86765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8677b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 867883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 86794a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetEvent(commandBuffer, event, stageMask); 86805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 868289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 868389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 868483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8686b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 868983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 869083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 8691ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 8692ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8693ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8694ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 8695ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8696ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 86975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8698c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8699c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8700c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8701b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8702b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8703b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 87045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8705b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 870683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 87074a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdResetEvent(commandBuffer, event, stageMask); 87085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8710e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 87125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 87135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 8714e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 87155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 87165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 87175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 87195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 87205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 87215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 87225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 87235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 87245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 87255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 87275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 87285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 87295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 87305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 87315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 87325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 873308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 873408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 87355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 87365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 87385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 87395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 87405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 87425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 87435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 87445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 87465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 8753e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 87545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 87555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 87565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 87585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 87615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 87625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 87635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 87735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 87745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 8775e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8776e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 8777e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 8778e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 878143986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 87825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 87845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8785577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 87865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 87906044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 87935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 87945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 87955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 87965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 87995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 88005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 88015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 88025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88036044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 88055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 88065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 88075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 88085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 88095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8814e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8815e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 8816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 88195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 88215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 88245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 88295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 88305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 88375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 88395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 88435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 88445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 88475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 885008d0512735df3d7ee6d2b085e4a2fbcac9d990c2Tony Barbour case VK_IMAGE_LAYOUT_PRESENT_SRC_KHR: { 885108d0512735df3d7ee6d2b085e4a2fbcac9d990c2Tony Barbour skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_MEMORY_READ_BIT, 0, type); 885208d0512735df3d7ee6d2b085e4a2fbcac9d990c2Tony Barbour break; 885308d0512735df3d7ee6d2b085e4a2fbcac9d990c2Tony Barbour } 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 88555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 88565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 88575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8859577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 88615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8870e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8871e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 8872e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 8873e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 8874e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 88765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 88775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 8878ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 88795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 88825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 88835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 88865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 88871facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_data = getImageState(dev_data, mem_barrier->image); 88886d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 88895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 88905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 88916d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 88945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 88955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 88965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 89065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 8916b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 8917b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 89185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 89195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 89205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 89215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 8925b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 89265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 8931d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour if (mem_barrier->oldLayout != mem_barrier->newLayout) { 8932d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour skip_call |= 8933d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 8934d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour skip_call |= 8935d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 8936d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour } 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89431facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_data = getImageState(dev_data, mem_barrier->image); 89441d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 89451d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 89476d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 89486d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis format = image_data->createInfo.format; 89496d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis arrayLayers = image_data->createInfo.arrayLayers; 89506d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis mipLevels = image_data->createInfo.mipLevels; 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 8953170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); 8954170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (imageswap_data) { 8955b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); 8956b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 8957b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis format = swapchain_data->createInfo.imageFormat; 8958b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis arrayLayers = swapchain_data->createInfo.imageArrayLayers; 89595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 89605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 89615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 8965c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis auto aspect_mask = mem_barrier->subresourceRange.aspectMask; 8966c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (vk_format_is_depth_or_stencil(format)) { 8967c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (vk_format_is_depth_and_stencil(format)) { 8968c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) && !(aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 8969c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8970c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", 8971c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "%s: Image is a depth and stencil format and thus must " 8972c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have either one or both of VK_IMAGE_ASPECT_DEPTH_BIT and " 8973c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 8974c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8975c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8976c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else if (vk_format_is_depth_only(format)) { 8977c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT)) { 8978c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8979c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth-only format and thus must " 8980c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_DEPTH_BIT set.", 8981c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8982c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8983c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else { // stencil-only case 8984a968f468c0aafdf33b7af68fb8e7961e37e32f7fTobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 8985c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8986c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a stencil-only format and thus must " 8987c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_STENCIL_BIT set.", 8988c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8989c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8990c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8991c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else { // image is a color format 8992c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT)) { 8993c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8994c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a color format and thus must " 8995c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_COLOR_BIT set.", 8996c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8997c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 89985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8999f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 9000f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 9001f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 9002f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 90095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9010f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 9011f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 9012f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 9013f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 90145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 90175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 90185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 90255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 90275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 90335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 9036b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 9038b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 9044b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90478718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, mem_barrier->buffer); 90488718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 90490c6dd4dd7c7e444efc979299f8f445fb4fc4febeChris Forbes auto buffer_size = buffer_node->memSize; 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 905194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 905294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 905394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 9054414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ".", 905594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 905694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 905894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 905994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9060414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 9061414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 906294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 906394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 906494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90712ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 9072b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 9073b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 9074b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 9075b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 90762ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 9077b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 9078b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 9079b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 90802ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 9081b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 9082b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 9083b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 90849556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto global_event_data = getEventNode(dev_data, event); 90859556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (!global_event_data) { 9086b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 908727c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 908827c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 90892ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 9090b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 90919556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis stageMask |= global_event_data->stageMask; 9092b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 9093b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 9094b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 9095c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // TODO: Need to validate that host_bit is only set if set event is called 9096c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // but set event can be called at any time. 9097c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { 9098c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9099c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine DRAWSTATE_INVALID_EVENT, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " 91004261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "using srcStageMask 0x%X which must be the bitwise " 9101c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "OR of the stageMask parameters used in calls to " 9102c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " 91034261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "used with vkSetEvent but instead is 0x%X.", 9104c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine sourceStageMask, stageMask); 9105b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 9106b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 9107b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 9108b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 910989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 911089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 911189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 911289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 911389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 911483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 91155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9116b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 91175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 91185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 91192ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 91205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 9121ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, pEvents[i]); 9122ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 9123ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 9124ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<const uint64_t &>(pEvents[i]), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, 9125ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis pCB); 9126ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 9127ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 9128c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->waitedEvents.insert(pEvents[i]); 91295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 91305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9131b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 91322ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 9133b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 91345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 913583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 91365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 913783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 91385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 913983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 914083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 91435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9144b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 914583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 91464a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 91474a0754042cf090e131e9e769d8a3633c228625beChris Forbes memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, 91484a0754042cf090e131e9e769d8a3633c228625beChris Forbes imageMemoryBarrierCount, pImageMemoryBarriers); 91495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 915189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 915289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 915389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 915489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 915589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 915683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 91575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9158b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 91595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 91605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 916183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 916283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 916383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 91665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9167b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 916883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 91694a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, memoryBarrierCount, 91704a0754042cf090e131e9e769d8a3633c228625beChris Forbes pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, 91714a0754042cf090e131e9e769d8a3633c228625beChris Forbes imageMemoryBarrierCount, pImageMemoryBarriers); 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9174d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { 9175d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9176d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 9177d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (pCB) { 9178d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryToStateMap[object] = value; 9179d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9180d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 9181d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data != dev_data->queueMap.end()) { 9182d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[object] = value; 9183d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9184d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 9185d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 9186d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 918789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 918889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 918983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 91905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9191b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 91925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 91935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 91945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 91955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 91965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 91975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 91985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 919983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 9200ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9201ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 92025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9203b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 920483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 92054a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBeginQuery(commandBuffer, queryPool, slot, flags); 92065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 920889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 920983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9211b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 92125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 92135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 92145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 92155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 921683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 92175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9218414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 92195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 92205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 92215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 92225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9223c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 9224d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 92255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 922683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 92275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 922883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 92295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9230ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9231ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 92325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9233b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 923483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 92354a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdEndQuery(commandBuffer, queryPool, slot); 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 923889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 923989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 924083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 92415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9242b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 92435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 92455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 92465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 9248c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); 9249d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 92505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 925283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 92535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 925483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 92555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 925683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 9257ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9258ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 92595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9260b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 926183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 92624a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 92635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9265d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { 9266d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool skip_call = false; 9267d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 9268d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 9269d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data == dev_data->queueMap.end()) 9270d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 9271d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (uint32_t i = 0; i < queryCount; i++) { 9272d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine QueryObject query = {queryPool, firstQuery + i}; 9273d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto query_data = queue_data->second.queryToStateMap.find(query); 9274d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool fail = false; 9275d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (query_data != queue_data->second.queryToStateMap.end()) { 9276d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!query_data->second) { 9277d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 9278d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9279d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 9280d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto global_query_data = dev_data->queryToStateMap.find(query); 9281d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (global_query_data != dev_data->queryToStateMap.end()) { 9282d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!global_query_data->second) { 9283d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 9284d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9285d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 9286d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 9287d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9288d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9289d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (fail) { 9290d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9291d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine DRAWSTATE_INVALID_QUERY, "DS", 9292d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 9293d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); 9294d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9295d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9296d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return skip_call; 9297d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 9298d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 929989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 930089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 930189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 930283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9304b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 9305ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 93069f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 9307ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 9308ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 9309b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyQueryPoolResults()"); 9310ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 9311c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 9312ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 931359b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 9314ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 9315e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 9316f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 9317e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 93199f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 9320d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::function<bool(VkQueue)> queryUpdate = 9321ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::bind(validateQuery, std::placeholders::_1, cb_node, queryPool, queryCount, firstQuery); 9322ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->queryUpdates.push_back(queryUpdate); 9323ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node->state == CB_RECORDING) { 9324ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 932683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9328b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyQueryPoolResults()"); 9329ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9330ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, cb_node); 9331ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 9332ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9334b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 933583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 93364a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, dstOffset, 93374a0754042cf090e131e9e769d8a3633c228625beChris Forbes stride, flags); 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 934089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 934189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 934289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 934383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9345b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 93485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 934983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 935183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 935483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 93559e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 935683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 935783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 93589e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 93599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 9360a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 9361c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlis auto pipeline_layout = getPipelineLayout(dev_data, layout); 936215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 936315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // contained in the pipeline ranges. 936415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Build a {start, end} span list for ranges with matching stage flags. 936515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis const auto &ranges = pipeline_layout->push_constant_ranges; 936615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct span { 936715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t start; 936815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t end; 936915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis }; 937015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span> spans; 937115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.reserve(ranges.size()); 937215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (const auto &iter : ranges) { 937315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (iter.stageFlags == stageFlags) { 937415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.push_back({iter.offset, iter.offset + iter.size}); 937515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 937615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 937715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (spans.size() == 0) { 937815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There were no ranges that matched the stageFlags. 937915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 938015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 938115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 938215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 938315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis (uint32_t)stageFlags, (uint64_t)layout); 93849e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 938515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Sort span list by start value. 938615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct comparer { 938715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool operator()(struct span i, struct span j) { return i.start < j.start; } 938815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } my_comparer; 938915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::sort(spans.begin(), spans.end(), my_comparer); 939015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis 939115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Examine two spans at a time. 939215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator current = spans.begin(); 939315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator next = current + 1; 939415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis while (next != spans.end()) { 939515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (current->end < next->start) { 939615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There is a gap; cannot coalesce. Move to the next two spans. 939715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++current; 939815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++next; 939915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } else { 940015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce the two spans. The start of the next span 940115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // is within the current span, so pick the larger of 940215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // the end values to extend the current span. 940315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Then delete the next span and set next to the span after it. 940415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis current->end = max(current->end, next->end); 940515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis next = spans.erase(next); 94069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 94079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 9408a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 940915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Now we can check if the incoming range is within any of the spans. 941015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool contained_in_a_range = false; 941115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (uint32_t i = 0; i < spans.size(); ++i) { 941215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 941315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis contained_in_a_range = true; 941415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis break; 9415a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 94169e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 941715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (!contained_in_a_range) { 941815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 941915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 942015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Push constant range [%d, %d) " 942115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "with stageFlags = 0x%" PRIx32 " " 942215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 942315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 942415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 94255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9426b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 942783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 94284a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 94295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 943189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 943289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 943383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 94345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9435b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 94365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 94385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 9439c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 9440d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 94415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 944283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 94435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 944483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 94455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9447b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 944883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 94494a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 94505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 94526600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinskistatic bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, 94536600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag) { 94546600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 94556600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 94566600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t attach = 0; attach < count; attach++) { 94576600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { 94586600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Attachment counts are verified elsewhere, but prevent an invalid access 94596600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment < fbci->attachmentCount) { 94606600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; 946179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, *image_view); 946279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (view_state) { 94631facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis const VkImageCreateInfo *ici = &getImageState(dev_data, view_state->create_info.image)->createInfo; 94646600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ici != nullptr) { 94656600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if ((ici->usage & usage_flag) == 0) { 94666600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 94676600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_USAGE, "DS", 94686600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " 94696600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "IMAGE_USAGE flags (%s).", 94706600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag)); 94716600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 94726600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 94736600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 94746600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 94756600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 94766600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 94776600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 94786600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 94796600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 9480d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// Validate VkFramebufferCreateInfo which includes: 9481d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// 1. attachmentCount equals renderPass attachmentCount 94825ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 2. corresponding framebuffer and renderpass attachments have matching formats 94835ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 3. corresponding framebuffer and renderpass attachments have matching sample counts 94845ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 4. fb attachments only have a single mip level 94855ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 5. fb attachment dimensions are each at least as large as the fb 94865ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 6. fb attachments use idenity swizzle 94875ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 7. fb attachments used by renderPass for color/input/ds have correct usage bit set 94886fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis// 8. fb dimensions are within physical device limits 9489d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlisstatic bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 94906600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 94916600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 9492127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto rp_state = getRenderPassState(dev_data, pCreateInfo->renderPass); 9493127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if (rp_state) { 9494127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis const VkRenderPassCreateInfo *rpci = rp_state->createInfo.ptr(); 9495d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rpci->attachmentCount != pCreateInfo->attachmentCount) { 9496d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= log_msg( 9497d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 9498d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 9499d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount of %u of " 9500d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "renderPass (0x%" PRIxLEAST64 ") being used to create Framebuffer.", 9501d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis pCreateInfo->attachmentCount, rpci->attachmentCount, reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 95025ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } else { 950341ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis // attachmentCounts match, so make sure corresponding attachment details line up 95045ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageView *image_views = pCreateInfo->pAttachments; 95055ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 950679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, image_views[i]); 950712d5600c2f9e32343016fd944432ba95df370797Tobin Ehlis auto &ivci = view_state->create_info; 950879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (ivci.format != rpci->pAttachments[i].format) { 95095ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis skip_call |= log_msg( 95105ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 95115ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 95125ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not match " 95135ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "the format of " 95145ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "%s used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 951579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, string_VkFormat(ivci.format), string_VkFormat(rpci->pAttachments[i].format), 95165ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 95175ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 95181facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis const VkImageCreateInfo *ici = &getImageState(dev_data, ivci.image)->createInfo; 95195ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ici->samples != rpci->pAttachments[i].samples) { 952041ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis skip_call |= log_msg( 952141ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 952241ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 952341ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match " 952441ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "the %s samples used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 952541ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), 952641ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 95275ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 95285ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify that view only has a single mip level 952979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (ivci.subresourceRange.levelCount != 1) { 95306fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 95316fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis __LINE__, DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 95326fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u " 95336fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "but only a single mip level (levelCount == 1) is allowed when creating a Framebuffer.", 953479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, ivci.subresourceRange.levelCount); 95355ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 953679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const uint32_t mip_level = ivci.subresourceRange.baseMipLevel; 9537aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_width = max(1u, ici->extent.width >> mip_level); 9538aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_height = max(1u, ici->extent.height >> mip_level); 953979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if ((ivci.subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || 9540aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis (mip_height < pCreateInfo->height)) { 9541aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis skip_call |= 95426fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9543aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9544aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions smaller " 9545aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "than the corresponding " 9546aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "framebuffer dimensions. Attachment dimensions must be at least as large. Here are the respective " 9547aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "dimensions for " 9548aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "attachment #%u, framebuffer:\n" 9549aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "width: %u, %u\n" 9550aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "height: %u, %u\n" 9551aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "layerCount: %u, %u\n", 955279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, ivci.subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, 955379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis pCreateInfo->height, ivci.subresourceRange.layerCount, pCreateInfo->layers); 95545ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 955579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (((ivci.components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.r != VK_COMPONENT_SWIZZLE_R)) || 955679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.g != VK_COMPONENT_SWIZZLE_G)) || 955779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.b != VK_COMPONENT_SWIZZLE_B)) || 955879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.a != VK_COMPONENT_SWIZZLE_A))) { 9559da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis skip_call |= log_msg( 95606fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9561da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9562da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All framebuffer " 9563da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "attachments must have been created with the identity swizzle. Here are the actual swizzle values:\n" 9564da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "r swizzle = %s\n" 9565da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "g swizzle = %s\n" 9566da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "b swizzle = %s\n" 9567da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "a swizzle = %s\n", 956879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, string_VkComponentSwizzle(ivci.components.r), string_VkComponentSwizzle(ivci.components.g), 956979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis string_VkComponentSwizzle(ivci.components.b), string_VkComponentSwizzle(ivci.components.a)); 95705ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 95715ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 9572d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } 95735ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify correct attachment usage flags 95746600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { 95756600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify input attachments: 95766600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, 95776600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pInputAttachments, pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT); 95786600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify color attachments: 95796600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, 95806600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pColorAttachments, pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); 95816600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify depth/stencil attachments: 95826600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { 95836600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, 95846600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); 95856600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 95866600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 9587d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } else { 9588d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= 9589d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 9590d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9591d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): Attempt to create framebuffer with invalid renderPass (0x%" PRIxLEAST64 ").", 9592d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 95936600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 95946fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis // Verify FB dimensions are within physical device limits 95956fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis if ((pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) || 95966fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) || 95976fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers)) { 95986fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 95996fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 96006fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo dimensions exceed physical device limits. " 96016fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "Here are the respective dimensions: requested, device max:\n" 96026fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "width: %u, %u\n" 96036fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "height: %u, %u\n" 96046fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "layerCount: %u, %u\n", 96056fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, 96066fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, 96076fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers); 96086fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis } 96096600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 96106600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 96116600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 961264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object 961364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Return true if an error is encountered and callback returns true to skip call down chain 961464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// false indicates that call down chain should proceed 961564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlisstatic bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 961664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis // TODO : Verify that renderPass FB is created with is compatible with FB 961764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = false; 9618d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); 961964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return skip_call; 962064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis} 962164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 962254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis// CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object 962354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlisstatic void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { 962454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis // Shadow create info and store in map 9625c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis std::unique_ptr<FRAMEBUFFER_STATE> fb_state( 9626c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis new FRAMEBUFFER_STATE(fb, pCreateInfo, dev_data->renderPassMap[pCreateInfo->renderPass]->createInfo.ptr())); 962776f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis 962854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 962954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 963079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, view); 963179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state) { 963254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis continue; 963354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 963454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 96351facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis fb_info.mem = getImageState(dev_data, view_state->create_info.image)->mem; 9636883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis fb_info.view_state = view_state; 963779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis fb_info.image = view_state->create_info.image; 9638c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis fb_state->attachments.push_back(fb_info); 963954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 9640c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis dev_data->frameBufferMap[fb] = std::move(fb_state); 964154e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis} 964254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis 964389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 964489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 964589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 964764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 964864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); 964964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.unlock(); 965064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 965164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis if (skip_call) 965264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 965364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 96544a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 96556600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 96565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 965764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.lock(); 965854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); 965954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis lock.unlock(); 96605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 96625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9664e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 9665e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 9668e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 96705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 96715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 96725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 9675e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 9678e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 96795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9680e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96838860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool CheckDependencyExists(const layer_data *dev_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 9684e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 9685e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 96865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 96881d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 96895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 96945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 96957655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen // If no dependency exits an implicit dependency still might. If not, throw an error. 96965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 96977655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 96987655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { 96998860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 97005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 97025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 9703e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 97045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97108860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool CheckPreserved(const layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 9711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 97125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 97135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 97155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 97165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 9717e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 97185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 97205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 9721e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9723e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 97245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 97255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 97268860b85a52096f9f9b28616bc37feed505497a54Chris Forbes result |= CheckPreserved(dev_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 97295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 9731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 97335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 9734e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9738e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 97395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97408860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 97425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 97545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 97565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9758c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic bool ValidateDependencies(const layer_data *dev_data, FRAMEBUFFER_STATE const *framebuffer, 9759127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis RENDER_PASS_STATE const *renderPass) { 9760e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9761fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const pFramebufferInfo = framebuffer->createInfo.ptr(); 9762fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const pCreateInfo = renderPass->createInfo.ptr(); 976316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto const & subpass_to_node = renderPass->subpassToNode; 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 97665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 97675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 97685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 97695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 97705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 97715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 97725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 97735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 97745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 97755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 97765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97778860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto view_state_i = getImageViewState(dev_data, viewi); 97788860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto view_state_j = getImageViewState(dev_data, viewj); 977979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state_i || !view_state_j) { 97805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 97815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 978279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_ci_i = view_state_i->create_info; 978379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_ci_j = view_state_j->create_info; 978479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (view_ci_i.image == view_ci_j.image && isRegionOverlapping(view_ci_i.subresourceRange, view_ci_j.subresourceRange)) { 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 97885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97891facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_data_i = getImageState(dev_data, view_ci_i.image); 97901facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_data_j = getImageState(dev_data, view_ci_j.image); 97916d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!image_data_i || !image_data_j) { 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97946d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data_i->mem == image_data_j->mem && isRangeOverlapping(image_data_i->memOffset, image_data_i->memSize, 97956d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_data_j->memOffset, image_data_j->memSize)) { 97965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98068860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 98085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 98095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 98105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98138860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 98155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 98165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 98211c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 98235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 98241c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 982793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 982893fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 98295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 983693fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 983793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 98385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 98395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98421c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98501c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 98511c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 98521c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 98538860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98548860b85a52096f9f9b28616bc37feed505497a54Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", 98558860b85a52096f9f9b28616bc37feed505497a54Chris Forbes "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", attachment, i); 98561c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 986493fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pInputAttachments[j].attachment; 986593fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 986693fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 98678860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 987193fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pColorAttachments[j].attachment; 987293fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 987393fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 98748860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 98758860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 98785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 98798860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 98808860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 98888860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckPreserved(dev_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9893be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 9894be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 9895be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 9896be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 9897be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 9898be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 9899be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 9900be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 9901be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 9902be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 9903be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 9904be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 9905be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 9906be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9907be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 9908be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 9909be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 9910be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 9911be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 99125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99138860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool ValidateLayouts(const layer_data *dev_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 9914e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 991677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis // Track when we're observing the first use of an attachment 991777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis std::vector<bool> attach_first_use(pCreateInfo->attachmentCount, true); 99185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 99195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 99205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 99210ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes auto attach_index = subpass.pColorAttachments[j].attachment; 99220ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes if (attach_index == VK_ATTACHMENT_UNUSED) 99230ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes continue; 99240ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes 9925c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pColorAttachments[j].layout) { 9926c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 9927c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* This is ideal. */ 9928c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9929c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9930c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9931c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 9932c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints? 9933c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 99348860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 99358860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9936c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 9937c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9938c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9939c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 99408860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 99418860b85a52096f9f9b28616bc37feed505497a54Chris Forbes __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9942c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 9943c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pColorAttachments[j].layout)); 99445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9945c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 994677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 99478860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pColorAttachments[j].layout, 994877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 994977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 995077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9952c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 9953cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes switch (subpass.pDepthStencilAttachment->layout) { 9954cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 9955cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 9956cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* These are ideal. */ 9957cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 9958cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9959cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9960cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 9961cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * other constraints? GENERAL can be better than doing a bunch 9962cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * of transitions. 9963cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes */ 99648860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 99658860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9966cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "GENERAL layout for depth attachment may not give optimal performance."); 9967cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 9968cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9969cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes default: 9970cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* No other layouts are acceptable */ 99718860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 99728860b85a52096f9f9b28616bc37feed505497a54Chris Forbes __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9973cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL, " 9974cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "DEPTH_STENCIL_READ_ONLY_OPTIMAL or GENERAL.", 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 99765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9977cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9978be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 997977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 99808860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pDepthStencilAttachment->layout, 998177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 998277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 998377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 998477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 998577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 998677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 998777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_index == VK_ATTACHMENT_UNUSED) 998877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis continue; 998977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis 9990c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pInputAttachments[j].layout) { 9991c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 9992c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: 9993c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* These are ideal. */ 9994c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9995c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9996c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9997c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal. TODO: reconsider this warning based on 9998c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints. 9999c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 100008860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 100018860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 10002c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 10003c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 10004c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 10005c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 10006c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* No other layouts are acceptable */ 100078860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10008c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 10009c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 10010c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pInputAttachments[j].layout)); 1001177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 10012c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 1001377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 100148860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pInputAttachments[j].layout, 1001577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 1001677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 1001777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 100185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 100215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100238860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool CreatePassDAG(const layer_data *dev_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 10024e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 10025e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 100265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 100285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 100315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 1003266a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL || dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 1003366a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes if (dependency.srcSubpass == dependency.dstSubpass) { 1003466a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes skip_call |= 100358860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 1003666a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 1003766a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes } 1003866a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes 1003966a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes // We don't want to add edges to the DAG for dependencies to/from 1004066a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes // VK_SUBPASS_EXTERNAL. We don't use them for anything, and their 1004166a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes // presence complicates other code. 1004266a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes continue; 1004366a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes } else if (dependency.srcSubpass > dependency.dstSubpass) { 100448860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 100455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 100465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 100475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 100485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 100495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1005066a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes 1005166a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 1005266a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 100535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 100555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10056918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 100575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1005889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 1005989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 1006089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 100618860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10062e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10063b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 10064b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 10065b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 10066b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 10067b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 10068b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 10069b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 10070b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 100718860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= 100728860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 100738860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VkDebugReportObjectTypeEXT(0), 0, __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 100748860b85a52096f9f9b28616bc37feed505497a54Chris Forbes "SPIR-V module not valid: %s", diag && diag->error ? diag->error : "(no error text)"); 100755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10077b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 10078b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 10079b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 10080e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 100815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 100825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100834a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult res = dev_data->dispatch_table.CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 100845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 10086b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 100878860b85a52096f9f9b28616bc37feed505497a54Chris Forbes dev_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 100885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 100905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100924f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { 100934f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 100944f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { 100954f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 100964f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 100974f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: %s attachment %d cannot be greater than the total number of attachments %d.", 100984f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski type, attachment, attachment_count); 100994f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 101004f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 101014f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 101024f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 10103805ec497391f6bc513f7653ba6d535c509b54062Chris Forbesstatic bool IsPowerOfTwo(unsigned x) { 10104805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes return x && !(x & (x-1)); 10105805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes} 10106805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 101074f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { 101084f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 101094f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 101104f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 101114f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 101124f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= 101134f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 101144f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_RENDERPASS, "DS", 101154f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 101164f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 101174f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 101184f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pPreserveAttachments[j]; 101194f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment == VK_ATTACHMENT_UNUSED) { 101204f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 101214f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski __LINE__, DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 101224f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED.", j); 101234f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } else { 101244f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); 101254f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 101264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 101276a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 101286a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes auto subpass_performs_resolve = subpass.pResolveAttachments && std::any_of( 101296a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes subpass.pResolveAttachments, subpass.pResolveAttachments + subpass.colorAttachmentCount, 101306a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes [](VkAttachmentReference ref) { return ref.attachment != VK_ATTACHMENT_UNUSED; }); 101316a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 10132805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes unsigned sample_count = 0; 10133805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 101344f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 101354f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment; 101364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pResolveAttachments) { 101374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pResolveAttachments[j].attachment; 101384f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); 101396a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 101406a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED && 101416a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes pCreateInfo->pAttachments[attachment].samples != VK_SAMPLE_COUNT_1_BIT) { 101426a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 101436a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 101446a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "CreateRenderPass: Subpass %u requests multisample resolve into attachment %u, " 101456a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "which must have VK_SAMPLE_COUNT_1_BIT but has %s", 101466a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes i, attachment, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples)); 101476a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 101484f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 101494f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pColorAttachments[j].attachment; 101504f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); 101516a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 10152805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 10153805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 10154805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 10155dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes if (subpass_performs_resolve && 10156dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes pCreateInfo->pAttachments[attachment].samples == VK_SAMPLE_COUNT_1_BIT) { 10157dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 10158dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 10159dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u " 10160dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "which has VK_SAMPLE_COUNT_1_BIT", 10161dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes i, attachment); 10162dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes } 101636a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 101644f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 10165dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 101664f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 101674f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 101684f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); 10169805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 10170805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 10171805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 10172805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 101734f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 10174dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 101754f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 101764f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pInputAttachments[j].attachment; 101774f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); 101784f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 10179805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 10180805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (sample_count && !IsPowerOfTwo(sample_count)) { 10181805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 10182805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 10183805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "CreateRenderPass: Subpass %u attempts to render to " 10184805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "attachments with inconsistent sample counts", 10185805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes i); 10186805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 101874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 101884f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 101894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 101904f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 1019189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 101924f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { 10193e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 101945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 101954f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 101964f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::unique_lock<std::mutex> lock(global_lock); 101974f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 101984f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 101994f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with 102004f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // ValidateLayouts. 102014f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); 10202ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes lock.unlock(); 102034f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 102044f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (skip_call) { 102054f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 102064f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 102074f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 102084a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 10209ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes 102105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 102114f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski lock.lock(); 102124f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 102134f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 102144f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 102154f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 102164f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 10217127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto render_pass = unique_ptr<RENDER_PASS_STATE>(new RENDER_PASS_STATE(pCreateInfo)); 1021898cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 10219cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 10220cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 10221db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes 1022287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 10223cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 102246600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; 1022587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 1022687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 1022787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 102284f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pColorAttachments[j].attachment; 102294f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 102304f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 102314f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 102320d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 1023387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 1023487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 1023587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 102364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 102374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 102384f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 1023924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 1024087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 10241a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 10242a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 102434f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 102444f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, true)); 102454f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 1024624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 10247a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 1024887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 10249db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes 10250fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes dev_data->renderPassMap[*pRenderPass] = std::move(render_pass); 102515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102544f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 10255e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbesstatic bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 10256e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10257127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto const pRenderPassInfo = getRenderPassState(dev_data, pRenderPassBegin->renderPass)->createInfo.ptr(); 1025848a43d923a7b126a78770bd209d63902ffa0520aChris Forbes auto const & framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]->createInfo; 102595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 102605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 102615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 102625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 102635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 102655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 1026679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, image_view); 1026779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis assert(view_state); 1026879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImage &image = view_state->create_info.image; 1026979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; 102705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 102715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 102725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 102735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 102745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 102755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 102765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 102775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 102785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 102795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 102805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 102815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 102825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10283c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes if (newNode.layout != VK_IMAGE_LAYOUT_UNDEFINED && 10284c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes newNode.layout != node.layout) { 102855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 102865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10287c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", 10288c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "You cannot start a render pass using attachment %u " 10289c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "where the render pass initial layout is %s and the previous " 10290c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "known layout of the attachment is %s. The layouts must match, or " 10291c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "the render pass initial layout for the attachment must be " 10292c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "VK_IMAGE_LAYOUT_UNDEFINED", 102931c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 102945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 102995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10301c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic void TransitionAttachmentRefLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, FRAMEBUFFER_STATE *pFramebuffer, 10302c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis VkAttachmentReference ref) { 10303628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (ref.attachment != VK_ATTACHMENT_UNUSED) { 10304628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = pFramebuffer->createInfo.pAttachments[ref.attachment]; 10305628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes SetLayout(dev_data, pCB, image_view, ref.layout); 10306628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes } 10307628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes} 10308628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes 1030927ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbesstatic void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, 10310e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 10311127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = getRenderPassState(dev_data, pRenderPassBegin->renderPass); 1031216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 103135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 1031416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 10315c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = getFramebufferState(dev_data, pRenderPassBegin->framebuffer); 10316e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 103175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10318e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 10319fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const &subpass = renderPass->createInfo.pSubpasses[subpass_index]; 103205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 10321628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pInputAttachments[j]); 103225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 10324628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pColorAttachments[j]); 103255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10326628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (subpass.pDepthStencilAttachment) { 10327628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, *subpass.pDepthStencilAttachment); 103285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103318860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool validatePrimaryCommandBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 10332e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 103335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 103348860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 103355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 103365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 103375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 103395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10341f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 10342127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = getRenderPassState(dev_data, pRenderPassBegin->renderPass); 1034316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 103445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 1034516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 10346fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->createInfo.ptr(); 10347c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = getFramebufferState(dev_data, pRenderPassBegin->framebuffer); 10348e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 103495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10350e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 103515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 10352628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = framebuffer->createInfo.pAttachments[i]; 103535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 103545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103578860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool VerifyRenderAreaBounds(const layer_data *dev_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 10358885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 10359c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = 10360c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis &getFramebufferState(dev_data, pRenderPassBegin->framebuffer)->createInfo; 10361885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 10362885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 10363885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 10364885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 10365885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 103668860b85a52096f9f9b28616bc37feed505497a54Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10367885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 10368885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 10369885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 10370885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 10371885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 10372885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 10373885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 10374885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 10375885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 10376885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 103771a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the 103781a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// [load|store]Op flag must be checked 103791a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. 103801a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinskitemplate <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { 10381a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski if (color_depth_op != op && stencil_op != op) { 10382a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return false; 10383a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski } 103841a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_color_depth_load_op = !vk_format_is_stencil_only(format); 103851a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; 10386a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski 10387a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return (((check_color_depth_load_op == true) && (color_depth_op == op)) || 10388a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski ((check_stencil_load_op == true) && (stencil_op == op))); 103891a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski} 103901a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski 1039189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1039289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 1039383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 103945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10395b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10396f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); 10397127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = pRenderPassBegin ? getRenderPassState(dev_data, pRenderPassBegin->renderPass) : nullptr; 10398c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = pRenderPassBegin ? getFramebufferState(dev_data, pRenderPassBegin->framebuffer) : nullptr; 10399f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node) { 1040016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 104016de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis uint32_t clear_op_size = 0; // Make sure pClearValues is at least as large as last LOAD_OP_CLEAR 10402f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeFramebuffer = pRenderPassBegin->framebuffer; 104036e17c244b21ce43ac57404a00a0d844039eed363Mark Lobodzinski for (uint32_t i = 0; i < renderPass->createInfo.attachmentCount; ++i) { 10404f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 10405fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto pAttachment = &renderPass->createInfo.pAttachments[i]; 10406db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, 10407db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilLoadOp, 104081a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_CLEAR)) { 1040992bc0680357019834b7529148ab6d73353ce02c7Mark Lobodzinski clear_op_size = static_cast<uint32_t>(i) + 1; 1041016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 104111facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), true); 1041216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 1041316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10414f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 10415db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, 10416db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilLoadOp, 104171a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { 1041816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 104191facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), false); 1042016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 1042116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10422f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 10423db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, 10424db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilLoadOp, 104251a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_LOAD)) { 1042616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 104271facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageState(dev_data, fb_info.image), 10428f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 1042916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10430f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 1043116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 10432db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes if (renderPass->attachment_first_read[i]) { 1043316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 104341facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageState(dev_data, fb_info.image), 10435f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 1043616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10437f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 104385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104406de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis if (clear_op_size > pRenderPassBegin->clearValueCount) { 104416de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis skip_call |= 104426de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 1044377aa75f997ecb8c39c815d79042d1553c08a9b85Tobin Ehlis reinterpret_cast<uint64_t &>(renderPass), __LINE__, VALIDATION_ERROR_00442, "DS", 104446de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but there must " 104456de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "be at least %u " 104466de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "entries in pClearValues array to account for the highest index attachment in renderPass 0x%" PRIx64 104476de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u. Note that the pClearValues array " 104486de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "is indexed by attachment number so even if some pClearValues entries between 0 and %u correspond to " 1044977aa75f997ecb8c39c815d79042d1553c08a9b85Tobin Ehlis "attachments that aren't cleared they will be ignored. %s", 104506de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), 1045177aa75f997ecb8c39c815d79042d1553c08a9b85Tobin Ehlis clear_op_size, clear_op_size - 1, validation_error_map[VALIDATION_ERROR_00442]); 104523d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis } 1045383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 10454f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= VerifyFramebufferAndRenderPassLayouts(dev_data, cb_node, pRenderPassBegin); 10455f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBeginRenderPass"); 1045683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateDependencies(dev_data, framebuffer, renderPass); 10457f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, cb_node, "vkCmdBeginRenderPass"); 10458f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 10459f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPass = renderPass; 104605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 10461f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPassBeginInfo = *pRenderPassBegin; 10462f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpass = 0; 10463f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpassContents = contents; 10464f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->framebuffers.insert(pRenderPassBegin->framebuffer); 10465883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis // Connect this framebuffer and its children to this cmdBuffer 10466883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis AddFramebufferBinding(dev_data, cb_node, framebuffer); 10467ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes // transition attachments to the correct layouts for the first subpass 10468f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis TransitionSubpassLayouts(dev_data, cb_node, &cb_node->activeRenderPassBeginInfo, cb_node->activeSubpass); 104695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1047083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 1047183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 1047283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10475b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1047683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 104774a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1048189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 1048283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 104835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 104855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 104865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 1048783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 1048883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 1048983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 1049080281691386b37385846f21b38e8c9d4b12cc74eChris Forbes 10491fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto subpassCount = pCB->activeRenderPass->createInfo.subpassCount; 1049280281691386b37385846f21b38e8c9d4b12cc74eChris Forbes if (pCB->activeSubpass == subpassCount - 1) { 1049380281691386b37385846f21b38e8c9d4b12cc74eChris Forbes skip_call |= 1049480281691386b37385846f21b38e8c9d4b12cc74eChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 1049580281691386b37385846f21b38e8c9d4b12cc74eChris Forbes reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SUBPASS_INDEX, "DS", 1049680281691386b37385846f21b38e8c9d4b12cc74eChris Forbes "vkCmdNextSubpass(): Attempted to advance beyond final subpass"); 1049780281691386b37385846f21b38e8c9d4b12cc74eChris Forbes } 104985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10499b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1050096ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1050196ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes if (skip_call) 1050296ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes return; 1050396ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 105044a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdNextSubpass(commandBuffer, contents); 1050596ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1050696ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes if (pCB) { 1050796ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes lock.lock(); 1050896ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes pCB->activeSubpass++; 1050996ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes pCB->activeSubpassContents = contents; 1051096ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 1051196ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes } 105125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1051489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 1051583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 105165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10517b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1051858c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes auto pCB = getCBNode(dev_data, commandBuffer); 1051958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes if (pCB) { 10520127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis RENDER_PASS_STATE *rp_state = pCB->activeRenderPass; 10521c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = getFramebufferState(dev_data, pCB->activeFramebuffer); 10522127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if (rp_state) { 10523127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if (pCB->activeSubpass != rp_state->createInfo.subpassCount - 1) { 1052402a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes skip_call |= 1052502a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 1052602a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SUBPASS_INDEX, "DS", 1052702a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes "vkCmdEndRenderPass(): Called before reaching final subpass"); 1052802a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes } 1052902a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes 10530127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis for (size_t i = 0; i < rp_state->createInfo.attachmentCount; ++i) { 10531e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 10532127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto pAttachment = &rp_state->createInfo.pAttachments[i]; 10533db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, 10534db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilStoreOp, VK_ATTACHMENT_STORE_OP_STORE)) { 1053558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 105361facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), true); 1053758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1053858c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1053958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 10540db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, 10541db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilStoreOp, 105421a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_STORE_OP_DONT_CARE)) { 1054358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 105441facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), false); 1054558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1054658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1054758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 105485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1055183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 1055283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 1055383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 105540e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes } 105550e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes lock.unlock(); 105560e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 105570e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes if (skip_call) 105580e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes return; 105590e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 105604a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdEndRenderPass(commandBuffer); 105610e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 105620e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes if (pCB) { 105630e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes lock.lock(); 10564f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); 1056558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeRenderPass = nullptr; 1056658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeSubpass = 0; 1056758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeFramebuffer = VK_NULL_HANDLE; 105685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10571a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, uint32_t primaryAttach, 10572a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis uint32_t secondaryAttach, const char *msg) { 105735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 105745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10575a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Secondary Cmd Buffer 0x%" PRIx64 " which has a render pass " 10576a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "that is not compatible with the Primary Cmd Buffer current render pass. " 10577a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Attachment %u is not compatible with %u: %s", 10578a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), primaryAttach, secondaryAttach, msg); 105795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10581a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10582a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, uint32_t primaryAttach, 10583a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkCommandBuffer secondaryBuffer, VkRenderPassCreateInfo const *secondaryPassCI, 10584e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 105855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10586a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->attachmentCount <= primaryAttach) { 105875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 105885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10589a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (secondaryPassCI->attachmentCount <= secondaryAttach) { 105905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 105915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 105935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 10596a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10597a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The first is unused while the second is not."); 105985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 105995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 10601a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10602a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The second is unused while the first is not."); 106035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 106045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10605a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].format != secondaryPassCI->pAttachments[secondaryAttach].format) { 10606a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10607a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different formats."); 106085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10609a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].samples != secondaryPassCI->pAttachments[secondaryAttach].samples) { 10610a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10611a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different samples."); 106125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10613a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (is_multi && primaryPassCI->pAttachments[primaryAttach].flags != secondaryPassCI->pAttachments[secondaryAttach].flags) { 10614a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10615a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different flags."); 106165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 106185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10620a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10621a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10622a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI, const int subpass, bool is_multi) { 106235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10624a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &primary_desc = primaryPassCI->pSubpasses[subpass]; 10625a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &secondary_desc = secondaryPassCI->pSubpasses[subpass]; 106265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 106275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 106285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 106295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 106305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 106315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 106335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 106345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10635a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_input_attach, secondaryBuffer, 10636a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_input_attach, is_multi); 106375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 106395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 106405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 106415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 106425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 106435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 106455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 106465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10647a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_color_attach, secondaryBuffer, 10648a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_color_attach, is_multi); 106495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 106505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 106515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 106525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 106545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 106555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10656a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_resolve_attach, 10657a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_resolve_attach, is_multi); 106585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 106605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 106615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 106625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 106645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 106655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10666a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_depthstencil_attach, 10667a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_depthstencil_attach, is_multi); 106685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 106695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10671a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// Verify that given renderPass CreateInfo for primary and secondary command buffers are compatible. 10672a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// This function deals directly with the CreateInfo, there are overloaded versions below that can take the renderPass handle and 10673a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// will then feed into this function 10674a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10675a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10676a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI) { 106775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10678a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis 10679a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->subpassCount != secondaryPassCI->subpassCount) { 106805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 106815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10682a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 10683a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u that is incompatible with the primary Cmd Buffer 0x%" PRIx64 10684a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u.", 10685a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), secondaryPassCI->subpassCount, 10686a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(primaryBuffer), primaryPassCI->subpassCount); 10687a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } else { 10688a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis for (uint32_t i = 0; i < primaryPassCI->subpassCount; ++i) { 10689a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primaryPassCI, secondaryBuffer, secondaryPassCI, i, 10690a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis primaryPassCI->subpassCount > 1); 10691a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 106925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 106945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10696e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 10697e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 106985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 106995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 107005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 107015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10702c5b97dda856ff837638b3ebb7e231d5507c495a3Chris Forbes VkFramebuffer primary_fb = pCB->activeFramebuffer; 107035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 107045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 107055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 107065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 107071af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 107081af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 107091af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis " which has a framebuffer 0x%" PRIx64 107101af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis " that is not the same as the primaryCB's current active framebuffer 0x%" PRIx64 ".", 107111af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), reinterpret_cast<uint64_t &>(secondary_fb), 107121af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(primary_fb)); 107135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10714c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto fb = getFramebufferState(dev_data, secondary_fb); 10715e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!fb) { 107165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 107175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10718414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10719414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 107205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 107215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 107225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10723127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto cb_renderpass = getRenderPassState(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 10724a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (cb_renderpass->renderPass != fb->createInfo.renderPass) { 10725a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->renderPassCreateInfo.ptr(), secondaryBuffer, 10726fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes cb_renderpass->createInfo.ptr()); 10727a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 107285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 107305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10732e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 1073383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 107345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 107355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 107365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 107375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 107385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 107395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 107405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 107415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 1074283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 107435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 107445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10745414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10746414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 107475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 107485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 107495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 107525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 107555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 107565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 1075783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 107585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 107595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10760414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10761414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 10762414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 107635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 107645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 107655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107677bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 107687bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto primary_pool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 107697bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto secondary_pool = getCommandPoolNode(dev_data, pSubCB->createInfo.commandPool); 107707bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (primary_pool && secondary_pool && (primary_pool->queueFamilyIndex != secondary_pool->queueFamilyIndex)) { 107717bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 107727bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 107737bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkCmdExecuteCommands(): Primary command buffer 0x%" PRIxLEAST64 107747bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d has secondary command buffer 0x%" PRIxLEAST64 " created in queue family %d.", 107757bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), primary_pool->queueFamilyIndex, 107767bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), secondary_pool->queueFamilyIndex); 107777bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 107787bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 1077983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 107805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1078289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1078389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 1078483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 107855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10786b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 107875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 107885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 107895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 107905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 107915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 107925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 1079383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 107945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 107955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10796414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 107975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 107985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 1079983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 1080083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 1080183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 1080283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 1080383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (void *)pCommandBuffers[i], i); 108045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 10805127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto secondary_rp_state = getRenderPassState(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 108065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 1080783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 108085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 108095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 10810414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 108115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 10812ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 108135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 108145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 10815127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if (pCB->activeRenderPass->renderPass != secondary_rp_state->renderPass) { 10816fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes skip_call |= 10817fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->createInfo.ptr(), 10818127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis pCommandBuffers[i], secondary_rp_state->createInfo.ptr()); 10819a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 108201af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match active FB from primaryCB 1082183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 108225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 108241af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // secondaryCB must have been created w/ RP compatible w/ primaryCB active renderpass 10825127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if ((pCB->activeRenderPass->renderPass != secondary_rp_state->renderPass) && 10826fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes !verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->createInfo.ptr(), 10827127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis secondary_rp_state->createInfo.ptr(), errorString)) { 1082883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 108295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 108305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 10831414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 10832414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 108335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 10834ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 108355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 1083883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 1083975b0d6603382dcb3e3de24c11ea6e4aa2ef8b4d2Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pSubCB, "vkCmdExecuteCommands()"); 108405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 108415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 108425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 108435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 1084483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 108455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 108465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10847414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to simultaneously execute CB 0x%" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 108485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 108495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 108505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 108525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 1085383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 108545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 108555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10856414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 108575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 10858414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 1085983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "set, even though it does.", 108605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 108615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 108625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10864f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!pCB->activeQueries.empty() && !dev_data->enabled_features.inheritedQueries) { 1086583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 108665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 108675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 108685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 10869414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 108705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 108715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 108725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 108735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 108755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 108765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 10877d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine for (auto &function : pSubCB->queryUpdates) { 10878d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine pCB->queryUpdates.push_back(function); 10879d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine } 108805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1088183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 1088283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 108835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10884b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1088583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 108864a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 108875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10889b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis// For any image objects that overlap mapped memory, verify that their layouts are PREINIT or GENERAL 10890cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool ValidateMapImageLayouts(VkDevice device, DEVICE_MEM_INFO const *mem_info, VkDeviceSize offset, 10891623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis VkDeviceSize end_offset) { 10892e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 108935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10894cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // Iterate over all bound image ranges and verify that for any that overlap the 10895cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // map ranges, the layouts are VK_IMAGE_LAYOUT_PREINITIALIZED or VK_IMAGE_LAYOUT_GENERAL 10896cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : This can be optimized if we store ranges based on starting address and early exit when we pass our range 10897cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto image_handle : mem_info->bound_images) { 10898cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis auto img_it = mem_info->bound_ranges.find(image_handle); 10899cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (img_it != mem_info->bound_ranges.end()) { 10900623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis if (rangesIntersect(dev_data, &img_it->second, offset, end_offset)) { 10901b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis std::vector<VkImageLayout> layouts; 10902825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (FindLayouts(dev_data, VkImage(image_handle), layouts)) { 10903b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis for (auto layout : layouts) { 10904b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 10905b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis skip_call |= 10906b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 10907b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 10908b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 10909b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis string_VkImageLayout(layout)); 10910b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10911b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10912b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10913b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10914b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 109155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 109175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1091989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1092089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 109215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 109225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10923e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 109245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10925b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10926cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 10927cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (mem_info) { 10928f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis // TODO : This could me more fine-grained to track just region that is valid 10929f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis mem_info->global_valid = true; 10930623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis auto end_offset = (VK_WHOLE_SIZE == size) ? mem_info->alloc_info.allocationSize - 1 : offset + size - 1; 10931623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem_info, offset, end_offset); 10932cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : Do we need to create new "bound_range" for the mapped range? 10933623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis SetMemRangesValid(dev_data, mem_info, offset, end_offset); 10934cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[mem_info->alloc_info.memoryTypeIndex].propertyFlags & 10935b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 109365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 109375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 109385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 10939414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 109405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10942f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis skip_call |= ValidateMapMemRange(dev_data, mem, offset, size); 10943b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 109445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10945e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 109464a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.MapMemory(device, mem, offset, size, flags, ppData); 109477c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis if (VK_SUCCESS == result) { 109487c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.lock(); 10949cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : What's the point of this range? See comment on creating new "bound_range" above, which may replace this 109507c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis storeMemRanges(dev_data, mem, offset, size); 109515f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski initializeAndTrackMemory(dev_data, mem, offset, size, ppData); 109527c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.unlock(); 109537c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis } 109545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 109565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1095889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 109598860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1096083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 109615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10962b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 109638860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= deleteMemRanges(dev_data, mem); 10964b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1096583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 109664a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.UnmapMemory(device, mem); 109675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109708860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool validateMemoryIsMapped(layer_data *dev_data, const char *funcName, uint32_t memRangeCount, 10971e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1097283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 109735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 109748860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto mem_info = getMemObjInfo(dev_data, pMemRanges[i].memory); 1097557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 10976de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.offset > pMemRanges[i].offset) { 1097783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 109788860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1097957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1098057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 1098157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 10982de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_info->mem_range.offset)); 109835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109844b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller 109858860b85a52096f9f9b28616bc37feed505497a54Chris Forbes const uint64_t dev_dataTerminus = (mem_info->mem_range.size == VK_WHOLE_SIZE) 109868860b85a52096f9f9b28616bc37feed505497a54Chris Forbes ? mem_info->alloc_info.allocationSize 109878860b85a52096f9f9b28616bc37feed505497a54Chris Forbes : (mem_info->mem_range.offset + mem_info->mem_range.size); 109888860b85a52096f9f9b28616bc37feed505497a54Chris Forbes if (pMemRanges[i].size != VK_WHOLE_SIZE && (dev_dataTerminus < (pMemRanges[i].offset + pMemRanges[i].size))) { 109898860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 109908860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 109918860b85a52096f9f9b28616bc37feed505497a54Chris Forbes MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 109928860b85a52096f9f9b28616bc37feed505497a54Chris Forbes ") exceeds the Memory Object's upper-bound " 109938860b85a52096f9f9b28616bc37feed505497a54Chris Forbes "(" PRINTF_SIZE_T_SPECIFIER ").", 109948860b85a52096f9f9b28616bc37feed505497a54Chris Forbes funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 109958860b85a52096f9f9b28616bc37feed505497a54Chris Forbes static_cast<size_t>(dev_dataTerminus)); 109965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1099983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 110005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 110028860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool ValidateAndCopyNoncoherentMemoryToDriver(layer_data *dev_data, uint32_t memRangeCount, 11003e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1100483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 110055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 110068860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto mem_info = getMemObjInfo(dev_data, pMemRanges[i].memory); 1100757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 110085f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 110095f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 110105f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 11011d8a53ade6b5501256798a8b4ec0bc14f72adc1faTobin Ehlis : (mem_info->alloc_info.allocationSize - mem_info->mem_range.offset); 110125f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 110135f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = 0; j < mem_info->shadow_pad_size; ++j) { 110145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1101583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 110168860b85a52096f9f9b28616bc37feed505497a54Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1101783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 110185f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski "Memory underflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 110195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110215f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = (size + mem_info->shadow_pad_size); j < (2 * mem_info->shadow_pad_size + size); ++j) { 110225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1102383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 110248860b85a52096f9f9b28616bc37feed505497a54Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1102583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1102683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 110275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110295f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(mem_info->p_driver_data, static_cast<void *>(data + mem_info->shadow_pad_size), (size_t)(size)); 110305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1103383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 110345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 110368860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic void CopyNoncoherentMemoryFromDriver(layer_data *dev_data, uint32_t memory_range_count, 110375f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski const VkMappedMemoryRange *mem_ranges) { 110389e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski for (uint32_t i = 0; i < memory_range_count; ++i) { 110398860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto mem_info = getMemObjInfo(dev_data, mem_ranges[i].memory); 110405f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info && mem_info->shadow_copy) { 110415f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 110425f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 110435f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski : (mem_info->alloc_info.allocationSize - mem_ranges[i].offset); 110445f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 110455f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(data + mem_info->shadow_pad_size, mem_info->p_driver_data, (size_t)(size)); 110469e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 110479e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 110489e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski} 110499e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski 1105089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1105189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 110525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1105383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 110548860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 110555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11056b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 110578860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= ValidateAndCopyNoncoherentMemoryToDriver(dev_data, memRangeCount, pMemRanges); 110588860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= validateMemoryIsMapped(dev_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 11059b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1106083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 110614a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 110625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 110645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1106689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1106789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 110685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1106983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 110708860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 110715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11072b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 110738860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= validateMemoryIsMapped(dev_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 11074b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1107583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 110764a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 110779e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski // Update our shadow copy with modified driver data 110788860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CopyNoncoherentMemoryFromDriver(dev_data, memRangeCount, pMemRanges); 110795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 110815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1108389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 110845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 110855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1108683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 11087b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 110881facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 110891facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 1109094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1109147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 11092888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis skip_call = SetMemBinding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 110935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 11094b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 110954a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.GetImageMemoryRequirements(device, image, &memRequirements); 11096b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1109747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 1109847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 1109957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 1110057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 111019f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertImageMemoryRange(dev_data, image, mem_info, memoryOffset, memRequirements, 111021facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->createInfo.tiling == VK_IMAGE_TILING_LINEAR); 1110383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "vkBindImageMemory"); 1110447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 1110547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 111060a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 11107b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1110883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 111094a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.BindImageMemory(device, image, mem, memoryOffset); 11110b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 111111facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->mem = mem; 111121facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->memOffset = memoryOffset; 111131facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->memSize = memRequirements.size; 11114b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1111594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1111694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1111794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1111894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 11119414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 1112094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 111215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 111235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1112589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 111263ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 111273ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 111285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 11129b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 111309556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 111319556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 111329556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->needsSignaled = false; 111339556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->stageMask = VK_PIPELINE_STAGE_HOST_BIT; 111349556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node->write_in_use) { 111353ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 111363ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 11137414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 111383ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 111393ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 111403ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 11141b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 111426fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 111436fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 111446fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 111456fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 111466fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 111476fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 111486fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 111496fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 111506fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 111513ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 111524a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.SetEvent(device, event); 111535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 111545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 111565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1115789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 111585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 111595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 11160e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 11161b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11162651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 11163651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 11164651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 111654b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 11166651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= ValidateFenceForSubmit(dev_data, pFence); 11167651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 111689867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 111699867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, bindInfoCount); 111704b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 11171651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 111721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 111731344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 111745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 111751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 111761344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 111771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 111781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 111795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 11180e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 111815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111831344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 111841344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 111851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 111861344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 111875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 11188e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 111895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111911344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 111921344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 111931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 111941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 111955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 11196e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 111975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111999867daedbf52debc77d6568162ee21e071699b80Chris Forbes 112009867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT> semaphore_waits; 112019867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore> semaphore_signals; 112021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 1120301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; 1120401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1120501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1120601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 112079867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 112089867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 112099867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 112109867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 112119867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 1121201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 112131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 112141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 112155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 112161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 11217414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 112181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 112191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 112205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 1122401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; 1122501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1122601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1122701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 112285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 112295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 112301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 11231414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 112321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 112331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 112345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112359867daedbf52debc77d6568162ee21e071699b80Chris Forbes else { 112369867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 112379867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 112389867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaled = true; 112399867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 112409867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 112419867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 112425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112449867daedbf52debc77d6568162ee21e071699b80Chris Forbes 112459867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 112469867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits, 112479867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals, 112489867daedbf52debc77d6568162ee21e071699b80Chris Forbes bindIdx == bindInfoCount - 1 ? fence : VK_NULL_HANDLE); 112495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112509867daedbf52debc77d6568162ee21e071699b80Chris Forbes 112519867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !bindInfoCount) { 112529867daedbf52debc77d6568162ee21e071699b80Chris Forbes // No work to do, just dropping a fence in the queue by itself. 112539867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 112549867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 112559867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 112569867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 112579867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 112589867daedbf52debc77d6568162ee21e071699b80Chris Forbes 112590a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 11260b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 112615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11262e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 112634a0754042cf090e131e9e769d8a3633c228625beChris Forbes return dev_data->dispatch_table.QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 112645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 112665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1126889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 1126989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 112705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 112714a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 112725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 11273b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 112745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 112759867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.first = VK_NULL_HANDLE; 112769867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.second = 0; 112771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 112785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 112805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1128389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 112845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 112854a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateEvent(device, pCreateInfo, pAllocator, pEvent); 112865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 11287b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 112885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 11289293ecfc5e69ed3978a8c04518166d828294870a4Tony Barbour dev_data->eventMap[*pEvent].write_in_use = 0; 112905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 112915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 112935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11295d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbesstatic bool PreCallValidateCreateSwapchainKHR(layer_data *dev_data, VkSwapchainCreateInfoKHR const *pCreateInfo, 11296d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes SURFACE_STATE *surface_state, SWAPCHAIN_NODE *old_swapchain_state) { 11297d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes auto most_recent_swapchain = surface_state->swapchain ? surface_state->swapchain : surface_state->old_swapchain; 11298d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes 11299d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (most_recent_swapchain != old_swapchain_state || (surface_state->old_swapchain && surface_state->swapchain)) { 11300d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 11301d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes reinterpret_cast<uint64_t>(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_ALREADY_EXISTS, "DS", 11302d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes "vkCreateSwapchainKHR(): surface has an existing swapchain other than oldSwapchain")) 11303d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes return true; 11304d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes } 11305d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (old_swapchain_state && old_swapchain_state->createInfo.surface != pCreateInfo->surface) { 11306d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 11307d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes reinterpret_cast<uint64_t const &>(pCreateInfo->oldSwapchain), __LINE__, DRAWSTATE_SWAPCHAIN_WRONG_SURFACE, 11308d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes "DS", "vkCreateSwapchainKHR(): pCreateInfo->oldSwapchain's surface is not pCreateInfo->surface")) 11309d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes return true; 11310d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes } 11311d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes 11312d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes return false; 11313d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes} 11314d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes 1131589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 1131689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 1131789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 113185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 11319ddc5201048319558ce66701163a4546ee957af19Chris Forbes auto surface_state = getSurfaceState(dev_data->instance_data, pCreateInfo->surface); 11320ddc5201048319558ce66701163a4546ee957af19Chris Forbes auto old_swapchain_state = getSwapchainNode(dev_data, pCreateInfo->oldSwapchain); 11321ddc5201048319558ce66701163a4546ee957af19Chris Forbes 11322d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (PreCallValidateCreateSwapchainKHR(dev_data, pCreateInfo, surface_state, old_swapchain_state)) 11323d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 11324d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes 113254a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 113265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 113275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 11328b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 11329ddc5201048319558ce66701163a4546ee957af19Chris Forbes auto swapchain_state = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo, *pSwapchain)); 11330ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->swapchain = swapchain_state.get(); 11331ddc5201048319558ce66701163a4546ee957af19Chris Forbes dev_data->device_extensions.swapchainMap[*pSwapchain] = std::move(swapchain_state); 11332ddc5201048319558ce66701163a4546ee957af19Chris Forbes } else { 11333ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->swapchain = nullptr; 113345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11336ddc5201048319558ce66701163a4546ee957af19Chris Forbes // Spec requires that even if CreateSwapchainKHR fails, oldSwapchain behaves as replaced. 11337ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->old_swapchain = old_swapchain_state; 11338ddc5201048319558ce66701163a4546ee957af19Chris Forbes 113395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 113405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 113415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1134289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1134389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 113445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1134583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 113465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11347b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11348b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, swapchain); 11349b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 11350b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data->images.size() > 0) { 11351b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis for (auto swapchain_image : swapchain_data->images) { 113525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 113535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 113545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 113555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 113565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 113575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 113585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 113615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1136283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 1136383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis clear_object_binding(dev_data, (uint64_t)swapchain_image, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1136494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 113655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11367ddc5201048319558ce66701163a4546ee957af19Chris Forbes 11368ddc5201048319558ce66701163a4546ee957af19Chris Forbes auto surface_state = getSurfaceState(dev_data->instance_data, swapchain_data->createInfo.surface); 11369ddc5201048319558ce66701163a4546ee957af19Chris Forbes if (surface_state) { 11370ddc5201048319558ce66701163a4546ee957af19Chris Forbes if (surface_state->swapchain == swapchain_data) 11371ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->swapchain = nullptr; 11372ddc5201048319558ce66701163a4546ee957af19Chris Forbes if (surface_state->old_swapchain == swapchain_data) 11373ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->old_swapchain = nullptr; 11374ddc5201048319558ce66701163a4546ee957af19Chris Forbes } 11375ddc5201048319558ce66701163a4546ee957af19Chris Forbes 113765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 113775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11378b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1137983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 113804a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroySwapchainKHR(device, swapchain, pAllocator); 113815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 113825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1138389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1138489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 113855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 113864a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 113875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 113885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 113895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 113905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 113915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 11392b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 113935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 11394b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_node = getSwapchainNode(dev_data, swapchain); 11395b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_node && !swapchain_node->images.empty()) { 113960801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 113970801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 113980801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 113995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 114005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 114015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 114025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 11403414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 114045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 114055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 114065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 114095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 114105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 114115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 114126d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis // Add imageMap entries for each swapchain image 114136d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo image_ci = {}; 114146d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.mipLevels = 1; 114156d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 114166d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.usage = swapchain_node->createInfo.imageUsage; 114176d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.format = swapchain_node->createInfo.imageFormat; 1141841ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis image_ci.samples = VK_SAMPLE_COUNT_1_BIT; 114196d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; 114206d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; 114216d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; 114221facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_STATE>(new IMAGE_STATE(pSwapchainImages[i], &image_ci)); 114231facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto &image_state = dev_data->imageMap[pSwapchainImages[i]]; 114241facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->valid = false; 114251facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 114265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 114275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 114285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 114295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 114305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 114315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 114345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 114355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1143689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 114375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 114385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 114395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 114406c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes std::lock_guard<std::mutex> lock(global_lock); 114416c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 114426c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 114436c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && !pSemaphore->signaled) { 114446c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 114456c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 114466c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 114476c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 114486c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); 114495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114506c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 11451249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 114526c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 114536c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 11454a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (swapchain_data) { 11455a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (pPresentInfo->pImageIndices[i] >= swapchain_data->images.size()) { 11456a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 11457d17d86d15a733f1ec988956721ea4b7cdfb6771bChris Forbes reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_INVALID_IMAGE, 11458a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "DS", "vkQueuePresentKHR: Swapchain image index too large (%u). There are only %u images in this swapchain.", 11459a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes pPresentInfo->pImageIndices[i], (uint32_t)swapchain_data->images.size()); 11460a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes } 11461a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes else { 11462a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 114631facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 114641facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageMemoryIsValid(dev_data, image_state, "vkQueuePresentKHR()"); 11465a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes 114661facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (!image_state->acquired) { 11467a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 11468a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_IMAGE_NOT_ACQUIRED, 11469a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "DS", "vkQueuePresentKHR: Swapchain image index %u has not been acquired.", 11470a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes pPresentInfo->pImageIndices[i]); 11471a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes } 11472a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes 11473a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes vector<VkImageLayout> layouts; 11474a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (FindLayouts(dev_data, image, layouts)) { 11475a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes for (auto layout : layouts) { 11476a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 11477a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= 11478a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 11479a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 11480a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "Images passed to present must be in layout " 11481a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "VK_IMAGE_LAYOUT_PRESENT_SRC_KHR but is in %s", 11482a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes string_VkImageLayout(layout)); 11483a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes } 114845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 114906c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (skip_call) { 114916c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 114926c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 114936c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 114944a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.QueuePresentKHR(queue, pPresentInfo); 114956c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 114966c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (result != VK_ERROR_VALIDATION_FAILED_EXT) { 114976c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // Semaphore waits occur before error generation, if the call reached 114986c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // the ICD. (Confirm?) 114996c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 115006c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 115019867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore) { 115029867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 115036c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes pSemaphore->signaled = false; 115046c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 115056c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 115069867daedbf52debc77d6568162ee21e071699b80Chris Forbes 11507220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 11508220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // Note: this is imperfect, in that we can get confused about what 11509220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // did or didn't succeed-- but if the app does that, it's confused 11510220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // itself just as much. 11511220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto local_result = pPresentInfo->pResults ? pPresentInfo->pResults[i] : result; 11512220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 11513220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes if (local_result != VK_SUCCESS && local_result != VK_SUBOPTIMAL_KHR) 11514220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes continue; // this present didn't actually happen. 11515220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 11516220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // Mark the image as having been released to the WSI 11517220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 11518220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 115191facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 115201facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->acquired = false; 11521220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes } 11522220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 115239867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Note: even though presentation is directed to a queue, there is no 115249867daedbf52debc77d6568162ee21e071699b80Chris Forbes // direct ordering between QP and subsequent work, so QP (and its 115259867daedbf52debc77d6568162ee21e071699b80Chris Forbes // semaphore waits) /never/ participate in any completion proof. 115266c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 115271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 115285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 115295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 115305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11531c827a5880dc3fabfc7d1a58bb62798649cab1181Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount, 11532c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young const VkSwapchainCreateInfoKHR *pCreateInfos, 11533c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchains) { 11534c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 11535c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young std::unique_lock<std::mutex> lock(global_lock); 11536c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young VkResult result = 115374a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CreateSharedSwapchainsKHR(device, swapchainCount, pCreateInfos, pAllocator, pSwapchains); 11538c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return result; 11539c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young} 11540c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 1154189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 1154289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 115435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1154483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 115451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 11546b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11547449670637ef4214b33018f497cf10daeff9dc85bChris Forbes 11548449670637ef4214b33018f497cf10daeff9dc85bChris Forbes if (fence == VK_NULL_HANDLE && semaphore == VK_NULL_HANDLE) { 11549449670637ef4214b33018f497cf10daeff9dc85bChris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 11550d17d86d15a733f1ec988956721ea4b7cdfb6771bChris Forbes reinterpret_cast<uint64_t &>(device), __LINE__, DRAWSTATE_SWAPCHAIN_NO_SYNC_FOR_ACQUIRE, "DS", 11551449670637ef4214b33018f497cf10daeff9dc85bChris Forbes "vkAcquireNextImageKHR: Semaphore and fence cannot both be VK_NULL_HANDLE. There would be no way " 11552449670637ef4214b33018f497cf10daeff9dc85bChris Forbes "to determine the completion of this operation."); 11553449670637ef4214b33018f497cf10daeff9dc85bChris Forbes } 11554449670637ef4214b33018f497cf10daeff9dc85bChris Forbes 11555f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 11556f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore && pSemaphore->signaled) { 1155783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 1155883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 1155983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 115605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11561f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11562f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pFence = getFenceNode(dev_data, fence); 11563f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 1156483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 115655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11566b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 115671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 1156883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 11569f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 11570f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 115714a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 11572f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11573f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.lock(); 11574f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { 11575f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 11576f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pFence->state = FENCE_INFLIGHT; 115779867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = VK_NULL_HANDLE; // ANI isn't on a queue, so this can't participate in a completion proof. 11578f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 11579f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11580f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore 11581f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore) { 11582f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pSemaphore->signaled = true; 115839867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 11584f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 11585220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 11586220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // Mark the image as acquired. 11587220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto swapchain_data = getSwapchainNode(dev_data, swapchain); 11588220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto image = swapchain_data->images[*pImageIndex]; 115891facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 115901facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->acquired = true; 115915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11592f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.unlock(); 115931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 115945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 115955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 115965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11597f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark LobodzinskiVKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount, 11598f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkPhysicalDevice *pPhysicalDevices) { 1159983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 11600f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 11601b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes if (instance_data->instance_state) { 11602f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // For this instance, flag when vkEnumeratePhysicalDevices goes to QUERY_COUNT and then QUERY_DETAILS 11603f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11604b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes instance_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_COUNT; 11605f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11606b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes if (UNCALLED == instance_data->instance_state->vkEnumeratePhysicalDevicesState) { 11607f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Flag warning here. You can call this without having queried the count, but it may not be 11608f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // robust on platforms with multiple physical devices. 11609b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 11610f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11611f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call sequence has vkEnumeratePhysicalDevices() w/ non-NULL pPhysicalDevices. You should first " 11612f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "call vkEnumeratePhysicalDevices() w/ NULL pPhysicalDevices to query pPhysicalDeviceCount."); 11613f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state 11614b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes else if (instance_data->instance_state->physical_devices_count != *pPhysicalDeviceCount) { 11615f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Having actual count match count from app is not a requirement, so this can be a warning 11616b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11617f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11618f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call to vkEnumeratePhysicalDevices() w/ pPhysicalDeviceCount value %u, but actual count " 11619f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "supported by this instance is %u.", 11620b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes *pPhysicalDeviceCount, instance_data->instance_state->physical_devices_count); 11621f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11622b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes instance_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_DETAILS; 11623f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 1162483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 11625f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11626f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 116279172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes VkResult result = instance_data->dispatch_table.EnumeratePhysicalDevices(instance, pPhysicalDeviceCount, pPhysicalDevices); 11628f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11629b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes instance_data->instance_state->physical_devices_count = *pPhysicalDeviceCount; 116305f270eedee8426a5b556a8a9432dd836d83f7b51Tony Barbour } else if (result == VK_SUCCESS){ // Save physical devices 11631f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) { 116323bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes auto & phys_device_state = instance_data->physical_device_map[pPhysicalDevices[i]]; 116333bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes phys_device_state.phys_device = pPhysicalDevices[i]; 11634f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Init actual features for each physical device 116359172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.GetPhysicalDeviceFeatures(pPhysicalDevices[i], &phys_device_state.features); 11636f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11637f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11638f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return result; 11639f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11640b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, 11641f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski DEVLIMITS_INVALID_INSTANCE, "DL", "Invalid instance (0x%" PRIxLEAST64 ") passed into vkEnumeratePhysicalDevices().", 11642f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski (uint64_t)instance); 11643f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11644f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11645f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 11646f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 11647cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiVKAPI_ATTR void VKAPI_CALL 11648cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiGetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, 11649cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VkQueueFamilyProperties *pQueueFamilyProperties) { 11650cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski bool skip_call = false; 11651f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); 116521f8e18308ae29b5220ce300f0d4dc964bc0941d6Chris Forbes auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); 116534b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (physical_device_state) { 116544b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (!pQueueFamilyProperties) { 116554b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_COUNT; 11656cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11657cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 11658cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Verify that for each physical device, this function is called first with NULL pQueueFamilyProperties ptr in order to 11659cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // get count 116604b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (UNCALLED == physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 116611f8e18308ae29b5220ce300f0d4dc964bc0941d6Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11662cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11663cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call sequence has vkGetPhysicalDeviceQueueFamilyProperties() w/ non-NULL " 11664cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "pQueueFamilyProperties. You should first call vkGetPhysicalDeviceQueueFamilyProperties() w/ " 11665cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "NULL pQueueFamilyProperties to query pCount."); 11666cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11667cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Then verify that pCount that is passed in on second call matches what was returned 116684b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (physical_device_state->queueFamilyPropertiesCount != *pCount) { 11669cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 11670cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // TODO: this is not a requirement of the Valid Usage section for vkGetPhysicalDeviceQueueFamilyProperties, so 11671cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // provide as warning 116721f8e18308ae29b5220ce300f0d4dc964bc0941d6Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11673cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11674cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call to vkGetPhysicalDeviceQueueFamilyProperties() w/ pCount value %u, but actual count " 11675cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "supported by this physicalDevice is %u.", 116764b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes *pCount, physical_device_state->queueFamilyPropertiesCount); 11677cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 116784b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; 11679cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11680cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (skip_call) { 11681cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 11682cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 116839172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(physicalDevice, pCount, pQueueFamilyProperties); 116844b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (!pQueueFamilyProperties) { 116854b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes physical_device_state->queueFamilyPropertiesCount = *pCount; 11686cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11687cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { // Save queue family properties 116887d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes if (physical_device_state->queue_family_properties.size() < *pCount) 116897d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes physical_device_state->queue_family_properties.resize(*pCount); 11690cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski for (uint32_t i = 0; i < *pCount; i++) { 116917d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes physical_device_state->queue_family_properties[i] = pQueueFamilyProperties[i]; 11692cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11693cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11694cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11695cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 116961f8e18308ae29b5220ce300f0d4dc964bc0941d6Chris Forbes log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 11697cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski __LINE__, DEVLIMITS_INVALID_PHYSICAL_DEVICE, "DL", 11698cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Invalid physicalDevice (0x%" PRIxLEAST64 ") passed into vkGetPhysicalDeviceQueueFamilyProperties().", 11699cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski (uint64_t)physicalDevice); 11700cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11701cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski} 11702cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 11703747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbestemplate<typename TCreateInfo, typename FPtr> 11704747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesstatic VkResult CreateSurface(VkInstance instance, TCreateInfo const *pCreateInfo, 11705747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes VkAllocationCallbacks const *pAllocator, VkSurfaceKHR *pSurface, 11706747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes FPtr fptr) 11707747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes{ 11708747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 11709747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11710747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes // Call down the call chain: 11711747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes VkResult result = (instance_data->dispatch_table.*fptr)(instance, pCreateInfo, pAllocator, pSurface); 11712747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11713747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (result == VK_SUCCESS) { 11714747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 11715747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->surface_map[*pSurface] = SURFACE_STATE(*pSurface); 11716747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes lock.unlock(); 11717747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 11718747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11719747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return result; 11720747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11721747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11722747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR void VKAPI_CALL DestroySurfaceKHR(VkInstance instance, VkSurfaceKHR surface, const VkAllocationCallbacks *pAllocator) { 11723747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool skip_call = false; 11724747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 11725747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 11726747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes auto surface_state = getSurfaceState(instance_data, surface); 11727747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11728747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (surface_state) { 11729747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes // TODO: track swapchains created from this surface. 11730747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->surface_map.erase(surface); 11731747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 11732747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes lock.unlock(); 11733747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11734747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!skip_call) { 11735747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes // Call down the call chain: 11736747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->dispatch_table.DestroySurfaceKHR(instance, surface, pAllocator); 11737747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 11738747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11739747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11740747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_ANDROID_KHR 11741747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateAndroidSurfaceKHR(VkInstance instance, const VkAndroidSurfaceCreateInfoKHR *pCreateInfo, 11742747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11743747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateAndroidSurfaceKHR); 11744747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11745747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_ANDROID_KHR 11746747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11747747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_MIR_KHR 11748747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateMirSurfaceKHR(VkInstance instance, const VkMirSurfaceCreateInfoKHR *pCreateInfo, 11749747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11750747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateMirSurfaceKHR); 11751747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11752747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_MIR_KHR 11753747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11754747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WAYLAND_KHR 11755747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateWaylandSurfaceKHR(VkInstance instance, const VkWaylandSurfaceCreateInfoKHR *pCreateInfo, 11756747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11757a9c6cc532ce0ef61d48d1419a96aae51b0e4c64aTobin Ehlis return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWaylandSurfaceKHR); 11758747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11759747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_WAYLAND_KHR 11760747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11761747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WIN32_KHR 11762747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo, 11763747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11764747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWin32SurfaceKHR); 11765747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11766747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_WIN32_KHR 11767747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11768747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XCB_KHR 11769747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateXcbSurfaceKHR(VkInstance instance, const VkXcbSurfaceCreateInfoKHR *pCreateInfo, 11770747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11771747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXcbSurfaceKHR); 11772747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11773747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_XCB_KHR 11774747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11775747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XLIB_KHR 11776747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateXlibSurfaceKHR(VkInstance instance, const VkXlibSurfaceCreateInfoKHR *pCreateInfo, 11777747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11778747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXlibSurfaceKHR); 11779747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11780747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_XLIB_KHR 11781747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11782747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 1178389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1178489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 1178589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 117868860b85a52096f9f9b28616bc37feed505497a54Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 117879172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes VkResult res = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 117885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 11789b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 117908860b85a52096f9f9b28616bc37feed505497a54Chris Forbes res = layer_create_msg_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); 117915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 117925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 117935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 117945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1179589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 1179689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 1179789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 117988860b85a52096f9f9b28616bc37feed505497a54Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 117999172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 11800b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 118018860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_destroy_msg_callback(instance_data->report_data, msgCallback, pAllocator); 118025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 118035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1180489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1180589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 1180689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 118078860b85a52096f9f9b28616bc37feed505497a54Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 118089172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 118095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 118105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11811a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11812a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 11813a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11814a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11815a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11816a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11817a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 11818a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11819a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11820a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11821a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11822a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 11823a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 11824a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 11825a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11826a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return VK_ERROR_LAYER_NOT_PRESENT; 11827a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11828a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 1182989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 1183089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 1183189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 11832a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 1183308939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 11834a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 11835a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 11836a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 118379172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); 118389172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes return instance_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 1183908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1184008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1184180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 118427ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 118437ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 118447ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1184580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 1184680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1184709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1184809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 1184909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 11850747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesstatic PFN_vkVoidFunction 11851747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesintercept_khr_surface_command(const char *name, VkInstance instance); 11852747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 1185389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 1185480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 1185580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 1185680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 1185780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1185880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 118595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1186009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 1186109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 1186209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 1186309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 11864f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 118655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 118664a0754042cf090e131e9e769d8a3633c228625beChris Forbes auto &table = dev_data->dispatch_table; 118674a0754042cf090e131e9e769d8a3633c228625beChris Forbes if (!table.GetDeviceProcAddr) 118684a0754042cf090e131e9e769d8a3633c228625beChris Forbes return nullptr; 118694a0754042cf090e131e9e769d8a3633c228625beChris Forbes return table.GetDeviceProcAddr(dev, funcName); 118705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 118715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1187289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 118737ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 118743f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 118753f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 118763f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 118773f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 11878747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!proc) 11879747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes proc = intercept_khr_surface_command(funcName, instance); 118807ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 118817ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 118825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 118837ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 118845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 118858860b85a52096f9f9b28616bc37feed505497a54Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 118868860b85a52096f9f9b28616bc37feed505497a54Chris Forbes proc = debug_report_get_instance_proc_addr(instance_data->report_data, funcName); 118877ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 118887ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 118895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 118904a0754042cf090e131e9e769d8a3633c228625beChris Forbes auto &table = instance_data->dispatch_table; 118914a0754042cf090e131e9e769d8a3633c228625beChris Forbes if (!table.GetInstanceProcAddr) 118924a0754042cf090e131e9e769d8a3633c228625beChris Forbes return nullptr; 118934a0754042cf090e131e9e769d8a3633c228625beChris Forbes return table.GetInstanceProcAddr(instance, funcName); 118945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1189508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1189680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 118977ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 118987ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 118997ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 119007ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 119017ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 119027ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 119037ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 119047ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 119057ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 11906f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski { "vkEnumeratePhysicalDevices", reinterpret_cast<PFN_vkVoidFunction>(EnumeratePhysicalDevices) }, 11907cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski { "vkGetPhysicalDeviceQueueFamilyProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceQueueFamilyProperties) }, 119087ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 11909a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, 11910a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, 11911a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, 119127ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 119137ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 119147ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 119157ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 119167ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 119177ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 119187ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 119197ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 119207ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 119217ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 119227ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 119237ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1192480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1192580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1192680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1192780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1192880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 11929593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, 11930593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, 11931593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, 11932593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, 11933593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, 11934593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, 11935593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, 11936593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, 11937593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, 11938593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, 11939593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, 11940593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, 11941593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, 11942593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, 11943593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, 11944593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, 11945593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, 11946593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, 11947593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, 11948593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, 11949593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, 11950593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, 11951593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, 11952593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, 11953593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, 11954593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, 11955593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, 11956593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, 11957593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, 11958593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, 11959593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, 11960593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, 11961593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, 11962593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, 11963593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, 11964593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, 11965593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, 11966593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, 11967593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, 11968593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, 11969593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, 11970593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, 11971593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, 11972593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, 11973593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, 11974593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, 11975593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, 11976593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, 11977593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, 11978593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, 11979593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, 11980593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, 11981593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, 11982593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, 11983593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, 11984593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, 11985593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, 11986593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, 11987593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, 11988593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, 11989593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, 11990593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, 11991593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, 11992593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, 11993593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, 11994593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, 11995593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, 11996593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, 11997593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, 11998593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, 11999593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, 12000593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, 12001593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, 12002593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, 12003593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, 12004593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, 12005593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, 12006593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, 12007593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, 12008593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, 12009593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, 12010593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, 12011593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, 12012593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, 12013593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, 12014593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, 12015593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, 12016593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, 12017593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, 12018593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, 12019593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, 12020593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, 12021593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, 12022593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, 12023593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, 12024593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, 12025593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, 12026593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, 12027593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, 12028593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, 12029593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, 12030593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, 12031593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, 12032593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, 12033593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, 12034593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, 12035593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, 12036593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, 12037593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, 12038593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, 12039593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, 12040593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, 12041593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, 12042593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, 12043593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, 12044593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, 1204580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1204680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1204780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1204880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1204980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1205080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1205180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1205280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1205380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1205480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1205509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1205609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1205709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1205809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1205909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1206009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1206109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1206209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1206309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1206409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1206509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1206609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 12067c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young layer_data *dev_data = nullptr; 1206809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 120693f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 12070c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 120713f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 120723f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 120733f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1207409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1207509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1207609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1207709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1207809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1207909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 12080c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (dev_data) { 12081c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (!dev_data->device_extensions.wsi_display_swapchain_enabled) 12082c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return nullptr; 12083c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young } 12084c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 12085c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (!strcmp("vkCreateSharedSwapchainsKHR", name)) 12086c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return reinterpret_cast<PFN_vkVoidFunction>(CreateSharedSwapchainsKHR); 12087c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 1208809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 12089747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 12090747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 12091747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesstatic PFN_vkVoidFunction 12092747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesintercept_khr_surface_command(const char *name, VkInstance instance) { 12093747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes static const struct { 12094747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const char *name; 12095747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes PFN_vkVoidFunction proc; 12096747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool instance_layer_data::*enable; 12097747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } khr_surface_commands[] = { 12098747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_ANDROID_KHR 12099747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateAndroidSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateAndroidSurfaceKHR), 12100747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::androidSurfaceExtensionEnabled}, 12101747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_ANDROID_KHR 12102747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_MIR_KHR 12103747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateMirSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateMirSurfaceKHR), 12104747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::mirSurfaceExtensionEnabled}, 12105747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_MIR_KHR 12106747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WAYLAND_KHR 12107747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateWaylandSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateWaylandSurfaceKHR), 12108747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::waylandSurfaceExtensionEnabled}, 12109747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_WAYLAND_KHR 12110747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WIN32_KHR 12111747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateWin32SurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateWin32SurfaceKHR), 12112747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::win32SurfaceExtensionEnabled}, 12113747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_WIN32_KHR 12114747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XCB_KHR 12115747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateXcbSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateXcbSurfaceKHR), 12116747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::xcbSurfaceExtensionEnabled}, 12117747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_XCB_KHR 12118747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XLIB_KHR 12119747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateXlibSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateXlibSurfaceKHR), 12120747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::xlibSurfaceExtensionEnabled}, 12121747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_XLIB_KHR 12122747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkDestroySurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySurfaceKHR), 12123747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::surfaceExtensionEnabled}, 12124747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes }; 12125747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 12126747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_layer_data *instance_data = nullptr; 12127747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (instance) { 12128747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 12129747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 12130747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 12131747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes for (size_t i = 0; i < ARRAY_SIZE(khr_surface_commands); i++) { 12132747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(khr_surface_commands[i].name, name)) { 12133747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (instance_data && !(instance_data->*(khr_surface_commands[i].enable))) 12134747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return nullptr; 12135747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return khr_surface_commands[i].proc; 12136747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 12137747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 12138747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 12139747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return nullptr; 1214009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1214109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 12142d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 12143d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12144d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 12145d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12146d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 12147d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 12148d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1214989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 12150d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12151d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12152d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 12153d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 12154d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 12155d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1215689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 12157d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12158d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12159d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 12160d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 12161d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1216289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 12163d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12164d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12165a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu// loader-layer interface v0, just wrappers since there is only a layer 12166d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1216708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1216808939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 12169a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); 1217008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1217108939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1217208939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1217308939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 12174a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); 1217508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1217608939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1217708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1217808939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 12179a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 12180a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 12181a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); 12182d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12183d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12184d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 12185d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 12186d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 12187a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 12188a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 12189a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 12190d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12191d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12192d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1219389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 12194d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12195d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12196d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 1219789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1219808939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 12199