core_validation.cpp revision c7255e92ea81e8639dc21388ec2a959bd63319c7
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_map> 465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_set> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_config.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_logging.h" 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) printf(__VA_ARGS__) 715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 79b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track command pools and their command buffers 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct CMD_POOL_INFO { 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPoolCreateFlags createFlags; 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queueFamilyIndex; 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool 855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 88e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE *> swapchainMap; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 10294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 10494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis uint64_t currentFenceId; 105b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski unordered_set<VkQueue> queues; // all queues under given device 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 1095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap; 1105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImageView, VkImageViewCreateInfo> imageViewMap; 1115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, IMAGE_NODE> imageMap; 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBufferView, VkBufferViewCreateInfo> bufferViewMap; 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBuffer, BUFFER_NODE> bufferMap; 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap; 1165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSet, SET_NODE *> setMap; 1185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSetLayout, LAYOUT_NODE *> descriptorSetLayoutMap; 1195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 12058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis unordered_map<VkDeviceMemory, DEVICE_MEM_INFO> memObjMap; 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 12772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 1285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFramebuffer, FRAMEBUFFER_NODE> frameBufferMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 132918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1336c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 136b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 137b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 138b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 14094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), device_extensions(), 141dcf917f7e9b04916caf3f7bb067f7f760d0daa99Chris Forbes currentFenceId(1), device(VK_NULL_HANDLE), phys_dev_properties{}, 142b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis phys_dev_mem_props{} {}; 1435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 145b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 146b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 147b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_global_layers[] = {{ 149f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 1505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 1515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 1555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(createInfo.ppEnabledLayerNames[i], cv_global_layers[0].layerName)) { 1565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cv_global_layers[0].layerName); 1625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t len() { return *it >> 16; } 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t const &word(unsigned n) { return it[n]; } 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 1915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 1925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 1955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 236b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 23703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 23803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - start of direct pull 23994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 24294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->imageMap.find(VkImage(handle)); 24394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->imageMap.end()) 24494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 24894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->bufferMap.find(VkBuffer(handle)); 24994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->bufferMap.end()) 25094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 2545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 2575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - end section 2595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 2605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate layer_data *get_my_data_ptr<layer_data>(void *data_key, std::unordered_map<void *, layer_data *> &data_map); 2615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 26372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *, const VkCommandBuffer); 26472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 26503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 2665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add a fence, creating one if necessary to our list of fences/fenceIds 267e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool add_fence_info(layer_data *my_data, VkFence fence, VkQueue queue, uint64_t *fenceId) { 268e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 2695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *fenceId = my_data->currentFenceId++; 2705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no fence, create an internal fence to track the submissions 2725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 2735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->fenceMap[fence].fenceId = *fenceId; 2745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->fenceMap[fence].queue = queue; 2755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that fence is in UNSIGNALED state 2765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFenceCreateInfo *pFenceCI = &(my_data->fenceMap[fence].createInfo); 2775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceCI->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 2785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 2795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 2805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 2815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence); 2825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 2845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Do we need to create an internal fence here for tracking purposes? 2855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update most recently submitted fence and fenceId for Queue 2875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queueMap[queue].lastSubmittedId = *fenceId; 2885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 2895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Record information when a fence is known to be signalled 2925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void update_fence_tracking(layer_data *my_data, VkFence fence) { 2935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = my_data->fenceMap.find(fence); 2945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != my_data->fenceMap.end()) { 2955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FENCE_NODE *pCurFenceInfo = &(*fence_item).second; 2965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueue queue = pCurFenceInfo->queue; 2975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_item = my_data->queueMap.find(queue); 2985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_item != my_data->queueMap.end()) { 2995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &(*queue_item).second; 3005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pQueueInfo->lastRetiredId < pCurFenceInfo->fenceId) { 3015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pCurFenceInfo->fenceId; 3025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update fence state in fenceCreateInfo structure 3075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFCI = &(my_data->fenceMap[fence].createInfo); 3085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFCI->flags = static_cast<VkFenceCreateFlags>(pFCI->flags | VK_FENCE_CREATE_SIGNALED_BIT); 3095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper routine that updates the fence list for a specific queue to all-retired 3125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void retire_queue_fences(layer_data *my_data, VkQueue queue) { 3135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &my_data->queueMap[queue]; 3145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set queue's lastRetired to lastSubmitted indicating all fences completed 3155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pQueueInfo->lastSubmittedId; 3165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper routine that updates all queues to all-retired 3195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void retire_device_fences(layer_data *my_data, VkDevice device) { 3205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Process each queue for device 3215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add multiple device support 3225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->queueMap.begin(); ii != my_data->queueMap.end(); ++ii) { 3235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set queue's lastRetired to lastSubmitted indicating all fences completed 3245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &(*ii).second; 3255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pQueueInfo->lastSubmittedId; 3265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 3305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 3315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 3325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 3330a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 3340a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 3350a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 336e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 337e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 3395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 3405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 3415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 3425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 3435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 3445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s %#" PRIxLEAST64 3455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 3465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 3475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for images 3525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls image info and then sends actual vs. desired usage off to helper above where 3535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3540a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_image_usage_flags(layer_data *dev_data, VkImage image, VkFlags desired, VkBool32 strict, 35594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 356e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 35794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 35894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 3590a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, image_node->second.createInfo.usage, desired, strict, (uint64_t)image, 3605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "image", func_name, usage_string); 3615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 3665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls buffer info and then sends actual vs. desired usage off to helper above where 3675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3680a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_buffer_usage_flags(layer_data *dev_data, VkBuffer buffer, VkFlags desired, VkBool32 strict, 36994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 370e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const buffer_node = dev_data->bufferMap.find(buffer); 37294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 3730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, buffer_node->second.createInfo.usage, desired, strict, (uint64_t)buffer, 3745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "buffer", func_name, usage_string); 3755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 3805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 38158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic DEVICE_MEM_INFO *get_mem_obj_info(layer_data *dev_data, const VkDeviceMemory mem) { 38258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto item = dev_data->memObjMap.find(mem); 38358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (item != dev_data->memObjMap.end()) { 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return &(*item).second; 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 3875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 3915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 3925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&my_data->memObjMap[mem].allocInfo, pAllocateInfo, sizeof(VkMemoryAllocateInfo)); 3955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Update for real hardware, actually process allocation info structures 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].allocInfo.pNext = NULL; 3975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].object = object; 3985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].mem = mem; 39958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis my_data->memObjMap[mem].image = VK_NULL_HANDLE; 4005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.offset = 0; 4015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.size = 0; 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pData = 0; 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pDriverData = 0; 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].valid = false; 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 407e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 408e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImage image = VK_NULL_HANDLE) { 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 41094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 41194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end() && !image_node->second.valid) { 41258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 4145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid swapchain image %" PRIx64 ", please fill the memory before using.", 4155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 4165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 42058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 4225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid memory %" PRIx64 ", please fill the memory before using.", functionName, 4235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 4245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 4275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 43194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 43294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 43394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.valid = valid; 4345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 43658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 4375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 4385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 4395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 445e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 446e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 447e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 4505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 45358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 4545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 455de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemInfo->commandBufferBindings.insert(cb); 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 45772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 4585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 45972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 460c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 4615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 466400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 467400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 46872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 469c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 470c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 47120b3e28d96ae4f3cbd4535e53eb68521d31bb91bChris Forbes DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 473400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis pInfo->commandBufferBindings.erase(pCBNode->commandBuffer); 4745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 476c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 4775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 481400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 482400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 483400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 4845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 487e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 488e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 489de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes size_t cmdBufRefCount = pMemObjInfo->commandBufferBindings.size(); 490896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes size_t objRefCount = pMemObjInfo->objBindings.size(); 4915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 492de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if ((pMemObjInfo->commandBufferBindings.size()) != 0) { 49358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 4955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory object %#" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 4965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " references", 4975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 4985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 500de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (cmdBufRefCount > 0 && pMemObjInfo->commandBufferBindings.size() > 0) { 501de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pMemObjInfo->commandBufferBindings) { 50258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 503de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 504de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes "Command Buffer %p still has a reference to mem obj %#" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 5055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 507de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemObjInfo->commandBufferBindings.clear(); 5085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 510896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (objRefCount > 0 && pMemObjInfo->objBindings.size() > 0) { 511896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pMemObjInfo->objBindings) { 512896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 5135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_FREED_MEM_REF, "MEM", "VK Object %#" PRIxLEAST64 " still has a reference to mem obj %#" PRIxLEAST64, 514896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 5155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 517896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemObjInfo->objBindings.clear(); 5185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 522e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemObjInfo(layer_data *my_data, void *object, VkDeviceMemory mem) { 523e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = my_data->memObjMap.find(mem); 5255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != my_data->memObjMap.end()) { 5265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap.erase(item); 5275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 5305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Request to delete memory object %#" PRIxLEAST64 " not present in memory Object Map", (uint64_t)mem); 5315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check if fence for given CB is completed 5365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkCBCompleted(layer_data *my_data, const VkCommandBuffer cb, bool *complete) { 53772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(my_data, cb); 538e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *complete = true; 5405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 54272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->lastSubmittedQueue != NULL) { 54372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkQueue queue = pCBNode->lastSubmittedQueue; 5445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &my_data->queueMap[queue]; 54572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->fenceId > pQueueInfo->lastRetiredId) { 5465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)cb, __LINE__, MEMTRACK_NONE, "MEM", 5485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "fence %#" PRIxLEAST64 " for CB %p has not been checked for completion", 54972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCBNode->lastSubmittedFence, cb); 5505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *complete = false; 5515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 557e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 558e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 56058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 5615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 5625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize == 0 && !internal) { 5635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section 56458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 5665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory associated with a Persistent Image, %#" PRIxLEAST64 ", " 5675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this should not be explicitly freed\n", 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem); 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear any CB bindings for completed CBs 5715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is there a better place to do this? 5725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(pInfo->object != VK_NULL_HANDLE); 574de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // clear_cmd_buf_and_mem_references removes elements from 575de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // pInfo->commandBufferBindings -- this copy not needed in c++14, 576de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // and probably not needed in practice in c++11 577de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes auto bindings = pInfo->commandBufferBindings; 578de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : bindings) { 579de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes bool commandBufferComplete = false; 580de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes skipCall |= checkCBCompleted(dev_data, cb, &commandBufferComplete); 5815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (commandBufferComplete) { 582de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 5835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify that no references to this mem obj remain and remove bindings 587de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() || pInfo->objBindings.size()) { 58858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= reportMemReferencesAndCleanUp(dev_data, pInfo); 5895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete mem obj info 59158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= deleteMemObjInfo(dev_data, object, mem); 5925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 5985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 6005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 6015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 6025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 6035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 6055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 6065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 6075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 612c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 6135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 6140a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 6155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 616e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 61794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 61894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 61994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = get_mem_obj_info(dev_data, *pMemBinding); 6205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 62194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 6225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 623c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 6245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 625896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (!pMemObjInfo->objBindings.erase({handle, type})) { 6265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 6285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "While trying to clear mem binding for %s obj %#" PRIxLEAST64 6295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", unable to find that object referenced by mem obj %#" PRIxLEAST64, 6305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 6315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 6385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 6395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 6405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 6415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 64294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 64394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 644e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 64858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 6495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(%#" PRIxLEAST64 ") to NULL", apiName, handle); 6505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 65294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 6535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 65458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, 6554f085d96e1f9ba7cba58b480ae64a8546c9a00eeChris Forbes "MEM", "In %s, attempting to update Binding of %s Obj(%#" PRIxLEAST64 ") that's not in global list", 6565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), apiName, handle); 6575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // non-null case so should have real mem obj 65958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 6605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 66194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = get_mem_obj_info(dev_data, *pMemBinding); 6625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPrevBinding != NULL) { 6635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 66458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 6655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 6665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to bind memory (%#" PRIxLEAST64 ") to object (%#" PRIxLEAST64 6675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") which has already been bound to mem object %#" PRIxLEAST64, 6685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 6695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 670896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemInfo->objBindings.insert({handle, type}); 6715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For image objects, make sure default memory state is correctly set 6725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What's the best/correct way to handle this? 6735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 67494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(VkImage(handle)); 67594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 67694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkImageCreateInfo ici = image_node->second.createInfo; 67794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 67894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // TODO:: More memory state transition stuff. 67994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 6805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 6835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 6915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 6925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 6935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 6945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 6950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 6960a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 6970a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 6980a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes bool skipCall = VK_FALSE; 6995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 7005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 7010a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, handle, type); 7025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 70494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 7055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 70658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, "MEM", 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to update Binding of Obj(%#" PRIxLEAST64 ") that's not in global list()", apiName, handle); 70894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 70994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // non-null case so should have real mem obj 71094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 71194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pInfo) { 71294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis pInfo->objBindings.insert({handle, type}); 71394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Need to set mem binding for this object 71494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 71594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 7165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given Object, get 'mem' obj that it's bound to or NULL if no binding 7220a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool get_mem_binding_from_object(layer_data *dev_data, const uint64_t handle, 72394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis const VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 724e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 72694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 72794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 72894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *mem = *pMemBinding; 7295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 73094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 7315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Trying to get mem binding for object %#" PRIxLEAST64 " but no such object in %s list", handle, 7325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type)); 7335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 7380a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 73958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 74258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 74758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 74958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 75058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 7525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 7545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 7575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at %p===", (void *)pInfo); 76158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: %#" PRIxLEAST64, (uint64_t)(pInfo->mem)); 76358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 764c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 765de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size() + pInfo->objBindings.size()); 7665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (0 != pInfo->allocInfo.allocationSize) { 7675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&pInfo->allocInfo, "MEM(INFO): "); 76858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 7705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 77158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 7735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 777896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pInfo->objBindings.size()); 778896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (pInfo->objBindings.size() > 0) { 779896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pInfo->objBindings) { 78058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 781896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT %" PRIu64, obj.handle); 7825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 7875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 788de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size()); 789de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() > 0) { 790de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pInfo->commandBufferBindings) { 79158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 792de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB %p", cb); 7935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7980a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 79972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 8005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 8025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 80772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 80872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 8095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 8115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 8135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 81672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 8175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " CB Info (%p) has CB %p, fenceId %" PRIx64 ", and fence %#" PRIxLEAST64, 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCBInfo, (void *)pCBInfo->commandBuffer, pCBInfo->fenceId, (uint64_t)pCBInfo->lastSubmittedFence); 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 822c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 824c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 826c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Mem obj %" PRIu64, (uint64_t)obj); 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 8425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 8445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 8455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 8485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 8525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 8575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 8845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 8855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 8935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 10025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool shader_is_spirv(VkShaderModuleCreateInfo const *pCreateInfo) { 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t *words = (uint32_t *)pCreateInfo->pCode; 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t sizeInWords = pCreateInfo->codeSize / sizeof(uint32_t); 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Just validate that the header makes sense. */ 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return sizeInWords >= 5 && words[0] == spv::MagicNumber && words[1] == spv::Version; 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 10425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10649ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10659ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 10729ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10749ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 10759ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 10789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 10809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 10819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10829ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 10849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 10859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 10889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 10899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 10939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 10949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 10969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 10989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 10999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 11009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 11019ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 11029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 11039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 11089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 11099ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 11119ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 11129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11139ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 11159ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 11169ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11189ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 11199ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11239ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11249ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 11259ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 11269ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 11279ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 11289ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 11299ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11309ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 113137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 113237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 113337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 113437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 113537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 113637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 113737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 113837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 113937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11467c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 114737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 11487c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11497c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 115237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 115337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 115437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 115537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 115637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 11605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11637c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 11647c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 116537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 11667c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11677c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11687c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 11697c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 11707c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 11717c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11727c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11757c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 11787c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 11817c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 11825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 118337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 118437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 118537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 118637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 118737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 118837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 118937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 119037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 119137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 119337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 119437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 119937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 12005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 12035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 12045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 12055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 12065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 120937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 12105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 12155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 12305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 12385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 12495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1250cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1251cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1252cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1253cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1254cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1255cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1256cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1257cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1258cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 12595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 12655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1268c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1269c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1270c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1271c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1272c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1273c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1274c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1275c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1276c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1277c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1278c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1279c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1280c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1281c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 12835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 12845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1289b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1290fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1294031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1295031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1296031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1297031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1298031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1299031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1300031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1301031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1302031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1303031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1304031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1305031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1306031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1307031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13246c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_block_members(layer_data *my_data, shader_module const *src, 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1327b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1329031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 13455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 13605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 13655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1367b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1368fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 13695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13766c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_location(layer_data *my_data, shader_module const *src, spirv_inst_iter entrypoint, 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1383b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 13845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1406b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1407b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1408b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1409b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 141581264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1420c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14311d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1438b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 14517c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1457b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1458fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 1463b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes collect_interface_block_members(my_data, src, out, blocks, is_array_of_verts, id, type, is_patch); 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14696c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_descriptor_slot(layer_data *my_data, shader_module const *src, 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<descriptor_slot_t, interface_var> &out) { 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 14745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 14755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 14815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 14925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto existing_it = out.find(std::make_pair(set, binding)); 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (existing_it != out.end()) { 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* conflict within spv image */ 1503080afef66a53dbdd085698b713697296458edfd9Chris Forbes log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis insn.word(2), insn.word(1), storage_class_name(insn.word(3)), existing_it->first.first, 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis existing_it->first.second); 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1513b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1514b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1515fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(set, binding)] = v; 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15216c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_interface_between_stages(layer_data *my_data, shader_module const *producer, 1522031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1524031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1530031261d21af8907953dd763398ce9a23e65b8749Chris Forbes collect_interface_by_location(my_data, producer, producer_entrypoint, spv::StorageClassOutput, outputs, producer_stage->arrayed_output); 1531031261d21af8907953dd763398ce9a23e65b8749Chris Forbes collect_interface_by_location(my_data, consumer, consumer_entrypoint, spv::StorageClassInput, inputs, consumer_stage->arrayed_input); 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1544080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1545080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1546031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1547031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1552080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1554031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1555031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1560fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1561fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1562fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1563fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 15640f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1565fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1566fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 156737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1568080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 15709ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 15719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 15729ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15760f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 15770f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 15780f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1579f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 15800f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 15810f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 15820f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 15830f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 15840f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15850f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 16165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 161731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 161831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 161931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 162031c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 16225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1623f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 16325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 163931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 164031c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 164131c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 164231c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1645f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16836c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_consistency(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi) { 16845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 16855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 16885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1694080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 16965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 16975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17076c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_against_vs_inputs(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi, 17085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17126c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, vs, entrypoint, spv::StorageClassInput, inputs, false); 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1717c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1718c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1719c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1720c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1721c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1722c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 1734080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1735080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1753080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 17569ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 17579ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17716c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_fs_outputs_against_render_pass(layer_data *my_data, shader_module const *fs, 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoint, RENDER_PASS_NODE const *rp, uint32_t subpass) { 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const std::vector<VkFormat> &color_formats = rp->subpassColorFormats[subpass]; 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17796c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, fs, entrypoint, spv::StorageClassOutput, outputs, false); 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = outputs.begin(); 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = 0; 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk attachment list and outputs together -- this is a little overpowered since attachments 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are currently dense, but the parallel with matching between shader stages is nice. 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && it != outputs.end()) || attachment < color_formats.size()) { 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == color_formats.size() || (it != outputs.end() && it->first.first < attachment)) { 1790080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "FS writes to output location %d with no matching attachment", it->first.first)) { 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (it == outputs.end() || it->first.first > attachment) { 1797080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", attachment)) { 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned output_type = get_fundamental_type(fs, it->second.type_id); 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned att_type = get_format_type(color_formats[attachment]); 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1808080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d of type `%s` does not match FS output type of `%s`", attachment, 18119ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(color_formats[attachment]), 18129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(fs, it->second.type_id).c_str())) { 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 18305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 184681264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 1926c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 1932c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19436c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_block_against_pipeline(layer_data *my_data, 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 19575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &range : *pushConstantRanges) { 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 19675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 1969080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1970080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 1983080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1984080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19986c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_usage(layer_data *my_data, 19995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, shader_module const *src, 20005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 20055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 2006080afef66a53dbdd085698b713697296458edfd9Chris Forbes pass &= validate_push_constant_block_against_pipeline(my_data, pushConstantRanges, src, 2007080afef66a53dbdd085698b713697296458edfd9Chris Forbes src->get_def(def_insn.word(1)), stage); 20085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipelineLayout verify that the setLayout at slot.first 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// has the requested binding at slot.second 201678be5018e238bd464b1f1c55138df277c0c18922Chris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(layer_data *my_data, PIPELINE_LAYOUT_NODE *pipelineLayout, descriptor_slot_t slot) { 20175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 201937083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 202178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (slot.first >= pipelineLayout->descriptorSetLayouts.size()) 202237083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 202478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto const layout_node = my_data->descriptorSetLayoutMap[pipelineLayout->descriptorSetLayouts[slot.first]]; 20255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingIt = layout_node->bindingToIndexMap.find(slot.second); 202714fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis if ((bindingIt == layout_node->bindingToIndexMap.end()) || (layout_node->createInfo.pBindings == NULL)) 202837083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 203014fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis assert(bindingIt->second < layout_node->createInfo.bindingCount); 203137083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return &layout_node->createInfo.pBindings[bindingIt->second]; 20325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 20405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2043e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2046e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2048e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2052e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2053e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 20543d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 20553d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 20563d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 20573d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 20585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2059e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 20635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic PIPELINE_NODE *getPipeline(layer_data *my_data, const VkPipeline pipeline) { 20645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) { 20655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->pipelineMap[pipeline]; 20685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2070e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2071e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2075e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2078e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2082e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 2083e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 20843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 20853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 20863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 20873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 2088ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2089ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2090ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 20913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 20933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 209445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 209545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 20963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 20983d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20993d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 21003d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21013d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 21023d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 210345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 210445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 21053d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21063d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 21073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 210845824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 210945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 21103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 21123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21133d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 21143d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21153d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 21163d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 21183d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21193d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 21205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 21213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 21275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If both AttachmentReference arrays have requested index, check their corresponding AttachementDescriptions 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 213506e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 213606e963555b0df747c98c43816c16647349d21001Mark Young return true; 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 213806e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 213906e963555b0df747c98c43816c16647349d21001Mark Young return true; 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // format and sample count must match 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 21485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give primary and secondary RenderPass objects, verify that they're compatible 21525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_renderpass_compatibility(layer_data *my_data, const VkRenderPass primaryRP, const VkRenderPass secondaryRP, 21535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string &errorMsg) { 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.find(primaryRP) == my_data->renderPassMap.end()) { 2155c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << primaryRP << ")"; 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (my_data->renderPassMap.find(secondaryRP) == my_data->renderPassMap.end()) { 2160c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << secondaryRP << ")"; 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Trivial pass case is exact same RP 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRP == secondaryRP) { 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *primaryRPCI = my_data->renderPassMap[primaryRP]->pCreateInfo; 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI = my_data->renderPassMap[secondaryRP]->pCreateInfo; 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2172c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 21795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 21805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 21815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 21825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 21835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 21865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 21875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2188c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2196c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2202fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2203fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2204fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2205fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2206fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2207c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2208fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2209fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2210fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2211fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2212fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 22145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 22175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2220c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex] 22315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const SET_NODE *pSet, const VkPipelineLayout layout, 22325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t layoutIndex, string &errorMsg) { 2233ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes auto pipeline_layout_it = my_data->pipelineLayoutMap.find(layout); 2234ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (pipeline_layout_it == my_data->pipelineLayoutMap.end()) { 2235c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkPipelineLayout (" << layout << ")"; 22375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2240ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (layoutIndex >= pipeline_layout_it->second.descriptorSetLayouts.size()) { 2241c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2242ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes errorStr << "VkPipelineLayout (" << layout << ") only contains " << pipeline_layout_it->second.descriptorSetLayouts.size() 2243ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes << " setLayouts corresponding to sets 0-" << pipeline_layout_it->second.descriptorSetLayouts.size() - 1 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << ", but you're attempting to bind set to index " << layoutIndex; 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get the specific setLayout from PipelineLayout that overlaps this set 2249ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes LAYOUT_NODE *pLayoutNode = my_data->descriptorSetLayoutMap[pipeline_layout_it->second.descriptorSetLayouts[layoutIndex]]; 22505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t descriptorCount = pLayoutNode->descriptorTypes.size(); 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (descriptorCount != pSet->pLayout->descriptorTypes.size()) { 2255c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors."; 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; // trivial fail case 22615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now need to check set against corresponding pipelineLayout to verify compatibility 22635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (size_t i = 0; i < descriptorCount; ++i) { 22645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to verify that layouts are identically defined 22655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor 22665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // do we also need to check immutable samplers? 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) { 2268c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "descriptor " << i << " for descriptorSet being bound is type '" 22705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) 22715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout is type '" 22725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'"; 22735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) { 2277c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i]; 22805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2288e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_specialization_offsets(layer_data *my_data, VkPipelineShaderStageCreateInfo const *info) { 2289e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 22905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 22925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 22955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 22965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 22975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 22985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 22995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 23005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 23015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 23025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 23035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2304e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 23055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool descriptor_type_match(layer_data *my_data, shader_module const *module, uint32_t type_id, 23141b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 23155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 23165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23171b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 23181b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 23197b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 23207b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 23215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 23227b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 23237b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 23247b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 23257b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 23267b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 23277b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 23287b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 23295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 23335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 23345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 23355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 23365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 23375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 23385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 23395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 23405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 23415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 23505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER; 23515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 235335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 235435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 235535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 235635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 235735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 235835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 235935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 236035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 236135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 236235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 23635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 23645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 23665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 23675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 23685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 23695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 23705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 23725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 23735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 23755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 23765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 23775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 23785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 23795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 23815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 23835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; 23845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 23865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 23905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 23915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 23935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 23945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2397e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool require_feature(layer_data *my_data, VkBool32 feature, char const *feature_name) { 2398a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 2399080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2400080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2401a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2402a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2403a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2404a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2405a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2406a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2407a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2408a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2409a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2410a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2411e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_shader_capabilities(layer_data *my_data, shader_module const *src) { 2412e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2413a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2414b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto enabledFeatures = &my_data->phys_dev_properties.features; 2415a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2416a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2417a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2418a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2419a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2420a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2421a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2422a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2423a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2424a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2425a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2426a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2427a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2428a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2429a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2430a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2431a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 2432a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->geometryShader, "geometryShader"); 2433a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2434a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2435a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 2436a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->tessellationShader, "tessellationShader"); 2437a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2438a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2439a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 2440a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2441a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2442a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2443a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 2444a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderInt64, "shaderInt64"); 2445a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2446a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2447a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2448a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 2449a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2450a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2451a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2452a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2453a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 2454a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2455a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2456a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2457a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 2458a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2459a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2460a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2461a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 2462a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2463a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2464a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2465a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2466a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 2467a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2468a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2469a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2470a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2471a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 2472a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2473a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2474a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2475a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2476a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 2477a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2478a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2479a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2480a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2481a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 2482a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2483a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2484a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2485a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 2486a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2487a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2488a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2489a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 2490a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2491a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2492a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2493a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 2494a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2495a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2496a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2497a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 2498a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2499a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2500a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2501a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 2502a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2503a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2504a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2505a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 2506a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2507a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2508a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2509a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 2510a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2511a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2512a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2513a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 2514a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageExtendedFormats, 2515a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2516a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2517a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2518a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 2519a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2520a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2521a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2522a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 2523a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2524a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2525a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2526a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2527a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 2528a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2529a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2530a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2531a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2532a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 2533a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->multiViewport, "multiViewport"); 2534a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2535a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2536a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 2537080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2538a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2539a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2540a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2541e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2542a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2543a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2544a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2545a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2546a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2547a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2548a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2549a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2550e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_pipeline_shader_stage(layer_data *dev_data, VkPipelineShaderStageCreateInfo const *pStage, 2551e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves PIPELINE_NODE *pipeline, PIPELINE_LAYOUT_NODE *pipelineLayout, 2552e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves shader_module **out_module, spirv_inst_iter *out_entrypoint) { 2553e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 255478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto module = *out_module = dev_data->shaderModuleMap[pStage->module].get(); 255578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_specialization_offsets(dev_data, pStage); 255678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 255778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 255878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 255978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2560080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2561080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 256278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 256378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2564e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 256578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 256678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 256778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 256878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 256978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_shader_capabilities(dev_data, module); 257078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 257178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 257278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 257378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 257478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 257578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 257678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::map<descriptor_slot_t, interface_var> descriptor_uses; 257778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes collect_interface_by_descriptor_slot(dev_data, module, accessible_ids, descriptor_uses); 257878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 257978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 258078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_push_constant_usage(dev_data, &pipelineLayout->pushConstantRanges, 258178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes module, accessible_ids, pStage->stage); 258278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 258378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 258478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 258578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 258678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 258778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 258878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the matching binding */ 258978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto binding = get_descriptor_binding(dev_data, pipelineLayout, use.first); 259078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 259178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 259278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2593080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2594080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 259578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 259678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2597e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 259878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 259978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 260078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 260178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 260278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 260378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 260478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 260578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 260678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 260778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2608e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 260978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 261078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (!descriptor_type_match(dev_data, module, use.second.type_id, binding->descriptorType, /*out*/ required_descriptor_count)) { 2611080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2612080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 261378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Type mismatch on descriptor slot " 261478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "%u.%u (used as type `%s`) but " 261578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "descriptor of type %s", 261678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 261778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 261878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2619e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 262078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 262178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2622080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2623080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 262478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 262578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 262678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 262778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes binding->descriptorCount)) { 2628e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 262978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 263078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 263178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 263278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 263478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 263578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2637a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2638a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2639e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_capture_pipeline_shader_state(layer_data *my_data, PIPELINE_NODE *pPipeline) { 2640ca546210846c65808717f8875deae39bd227c240Tobin Ehlis auto pCreateInfo = reinterpret_cast<VkGraphicsPipelineCreateInfo const *>(&pPipeline->graphicsPipelineCI); 26415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 26435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 26455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 26465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 26475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 26485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2649e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 26505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 265178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto pipelineLayout = pCreateInfo->layout != VK_NULL_HANDLE ? &my_data->pipelineLayoutMap[pCreateInfo->layout] : nullptr; 265278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 26535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 2654ca546210846c65808717f8875deae39bd227c240Tobin Ehlis VkPipelineShaderStageCreateInfo const *pStage = 2655ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<VkPipelineShaderStageCreateInfo const *>(&pCreateInfo->pStages[i]); 265678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 265778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_pipeline_shader_stage(my_data, pStage, pPipeline, pipelineLayout, 265878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes &shaders[stage_id], &entrypoints[stage_id]); 26595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 26625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 266409042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_vi_consistency(my_data, vi); 26655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 266809042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_vi_against_vs_inputs(my_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 26695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 26735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 26755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 26765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 26775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 26805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 26815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2682031261d21af8907953dd763398ce9a23e65b8749Chris Forbes pass &= validate_interface_between_stages(my_data, 2683031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2684031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 26855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 26875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 269078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto rp = pCreateInfo->renderPass != VK_NULL_HANDLE ? my_data->renderPassMap[pCreateInfo->renderPass] : nullptr; 269178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 26925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[fragment_stage] && rp) { 269309042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_fs_outputs_against_render_pass(my_data, shaders[fragment_stage], entrypoints[fragment_stage], rp, 269409042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pCreateInfo->subpass); 26955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 26985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2700e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_compute_pipeline(layer_data *my_data, PIPELINE_NODE *pPipeline) { 2701ca546210846c65808717f8875deae39bd227c240Tobin Ehlis auto pCreateInfo = reinterpret_cast<VkComputePipelineCreateInfo const *>(&pPipeline->computePipelineCI); 270203857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 270303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes auto pipelineLayout = pCreateInfo->layout != VK_NULL_HANDLE ? &my_data->pipelineLayoutMap[pCreateInfo->layout] : nullptr; 270403857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 270503857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 270603857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 270703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 270803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes return validate_pipeline_shader_stage(my_data, &pCreateInfo->stage, pPipeline, pipelineLayout, 270903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes &module, &entrypoint); 271003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 271103857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 27125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 27135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic SET_NODE *getSetNode(layer_data *my_data, const VkDescriptorSet set) { 27145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->setMap.find(set) == my_data->setMap.end()) { 27155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 27165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->setMap[set]; 27185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2719a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2720a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given Layout Node and binding, return index where that binding begins 2721a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingStartIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2722a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2723a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2724a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2725a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2726a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2727a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2728a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex; 2729a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2730a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2731a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given layout node and binding, return last index that is updated 2732a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingEndIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2733a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2734a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2735a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2736a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2737a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2738a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2739a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex - 1; 2740a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2741a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 27427a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 27437a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 27447a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 27457a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 27467a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 27477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 27487a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2749e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 27507a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 27517a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis const vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> &activeSetBindingsPairs) { 2752e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 27535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 27555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dynOffsetIndex = 0; 27565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize bufferSize = 0; 2757a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2758a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis SET_NODE *set_node = set_bindings_pair.first; 2759a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis LAYOUT_NODE *layout_node = set_node->pLayout; 2760a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto binding : set_bindings_pair.second) { 2761a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t startIdx = getBindingStartIndex(layout_node, binding); 2762a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t endIdx = getBindingEndIndex(layout_node, binding); 2763a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = startIdx; i <= endIdx; ++i) { 2764e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // We did check earlier to verify that set was updated, but now make sure given slot was updated 2765e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // TODO : Would be better to store set# that set is bound to so we can report set.binding[index] not updated 27669bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis // For immutable sampler w/o combined image, don't need to update 27679bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis if ((set_node->pLayout->createInfo.pBindings[i].descriptorType == VK_DESCRIPTOR_TYPE_SAMPLER) && 27689bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis (set_node->pLayout->createInfo.pBindings[i].descriptorCount != 0) && 27699bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis (set_node->pLayout->createInfo.pBindings[i].pImmutableSamplers)) { 27709bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis // Nothing to do here 27719bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis } else if (!set_node->pDescriptorUpdates[i]) { 2772e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2773e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2774e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2775e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "DS %#" PRIxLEAST64 " bound and active but it never had binding %u updated. It is now being used to draw so " 2776e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "this will result in undefined behavior.", 2777e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), binding); 2778e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else { 2779e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis switch (set_node->pDescriptorUpdates[i]->sType) { 2780e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 2781e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS = (VkWriteDescriptorSet *)set_node->pDescriptorUpdates[i]; 2782dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young 2783dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young // Verify uniform and storage buffers actually are bound to valid memory at draw time. 2784dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if ((pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) || 2785dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 2786dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) || 2787e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 2788e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2789dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young auto buffer_node = dev_data->bufferMap.find(pWDS->pBufferInfo[j].buffer); 2790dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (buffer_node == dev_data->bufferMap.end()) { 2791dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2792dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2793dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2794dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_INVALID_BUFFER, "DS", 2795dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 ") %s (%#" PRIxLEAST64 ") at index #%u" 2796dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young " is not defined! Has vkCreateBuffer been called?", 2797dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), 2798dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young string_VkDescriptorType(pWDS->descriptorType), 2799dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), i); 2800dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } else { 2801dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young auto mem_entry = dev_data->memObjMap.find(buffer_node->second.mem); 2802dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (mem_entry == dev_data->memObjMap.end()) { 2803e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2804e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2805e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2806dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_INVALID_BUFFER, "DS", 2807dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 ") %s (%#" PRIxLEAST64 ") at index" 2808dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young " #%u, has no memory bound to it!", 2809dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), 2810dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young string_VkDescriptorType(pWDS->descriptorType), 2811dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), i); 2812e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 28135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2814dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young // If it's a dynamic buffer, make sure the offsets are within the buffer. 2815dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if ((pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 2816dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 2817dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young bufferSize = dev_data->bufferMap[pWDS->pBufferInfo[j].buffer].createInfo.size; 2818dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young uint32_t dynOffset = 2819dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].dynamicOffsets[dynOffsetIndex]; 2820dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (pWDS->pBufferInfo[j].range == VK_WHOLE_SIZE) { 2821dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if ((dynOffset + pWDS->pBufferInfo[j].offset) > bufferSize) { 2822dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young result |= log_msg( 2823dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2824dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2825dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2826dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, "DS", 2827dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 ") bound as set #%u has range of " 2828dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VK_WHOLE_SIZE but dynamic offset %#" PRIxLEAST32 ". " 2829dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "combined with offset %#" PRIxLEAST64 " oversteps its buffer (%#" PRIxLEAST64 2830dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young ") which has a size of %#" PRIxLEAST64 ".", 2831dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), i, dynOffset, 2832dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young pWDS->pBufferInfo[j].offset, 2833dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 2834dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2835dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } else if ((dynOffset + pWDS->pBufferInfo[j].offset + pWDS->pBufferInfo[j].range) > 2836dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young bufferSize) { 2837dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young result |= 2838dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2839dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2840dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2841dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, "DS", 2842dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 2843dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young ") bound as set #%u has dynamic offset %#" PRIxLEAST32 ". " 2844dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "Combined with offset %#" PRIxLEAST64 " and range %#" PRIxLEAST64 2845dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young " from its update, this oversteps its buffer " 2846dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "(%#" PRIxLEAST64 ") which has a size of %#" PRIxLEAST64 ".", 2847dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), i, dynOffset, 2848dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young pWDS->pBufferInfo[j].offset, pWDS->pBufferInfo[j].range, 2849dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 2850dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2851dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young dynOffsetIndex++; 2852dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2853e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2854dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2855dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { 2856e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2857e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateImages.insert(pWDS->pImageInfo[j].imageView); 2858e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2859e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { 2860e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2861e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis assert(dev_data->bufferViewMap.find(pWDS->pTexelBufferView[j]) != dev_data->bufferViewMap.end()); 2862e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateBuffers.insert(dev_data->bufferViewMap[pWDS->pTexelBufferView[j]].buffer); 2863e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2864e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 2865e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 2866e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2867e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateBuffers.insert(pWDS->pBufferInfo[j].buffer); 28685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2870e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis i += pWDS->descriptorCount; // Advance i to end of this set of descriptors (++i at end of for loop will move 1 2871e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // index past last of these descriptors) 2872e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis break; 2873e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis default: // Currently only shadowing Write update nodes so shouldn't get here 2874e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis assert(0); 2875e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis continue; 28765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 28825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 28837a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// TODO : This is a temp function that naively updates bound storage images and buffers based on which descriptor sets are bound. 28847a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// When validate_and_update_draw_state() handles computer shaders so that active_slots is correct for compute pipelines, this 28857a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// function can be killed and validate_and_update_draw_state() used instead 28867a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlisstatic void update_shader_storage_images_and_buffers(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 28877a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkWriteDescriptorSet *pWDS = nullptr; 28887a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis SET_NODE *pSet = nullptr; 28897a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For the bound descriptor sets, pull off any storage images and buffers 28907a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // This may be more than are actually updated depending on which are active, but for now this is a stop-gap for compute 28917a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // pipelines 28927a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto set : pCB->lastBound[VK_PIPELINE_BIND_POINT_COMPUTE].uniqueBoundSets) { 28937a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Get the set node 28947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pSet = getSetNode(dev_data, set); 28957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For each update in the set 28967a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto pUpdate : pSet->pDescriptorUpdates) { 28977a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // If it's a write update to STORAGE type capture image/buffer being updated 28987a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pUpdate && (pUpdate->sType == VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET)) { 28997a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pWDS = reinterpret_cast<VkWriteDescriptorSet *>(pUpdate); 29007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { 29017a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 29027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.insert(pWDS->pImageInfo[j].imageView); 29037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { 29057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 29067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.insert(dev_data->bufferViewMap[pWDS->pTexelBufferView[j]].buffer); 29077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 29097a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 29107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 29117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.insert(pWDS->pBufferInfo[j].buffer); 29127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29157a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29167a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29177a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis} 29185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 2920e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, const bool indexedDraw, 2921e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipelineBindPoint bindPoint) { 2922e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 29237a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto const &state = pCB->lastBound[bindPoint]; 29247a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, state.pipeline); 29253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 29267a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 29277a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 29287a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 29295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 29305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Currently only performing next check if *something* was bound (non-zero last bound) 29315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There is probably a better way to gate when this check happens, and to know if something *should* have been bound 29325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // We should have that check separately and then gate this check based on that check 29335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipe) { 293472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (state.pipelineLayout) { 29355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString; 29365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2937a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> activeSetBindingsPairs; 2938a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto setBindingPair : pPipe->active_slots) { 2939a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t setIndex = setBindingPair.first; 29405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If valid set is not bound throw an error 294172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 29425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 29445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkPipeline %#" PRIxLEAST64 " uses set #%u but that set is not bound.", 29455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPipe->pipeline, setIndex); 294672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, my_data->setMap[state.boundDescriptorSets[setIndex]], 29475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipe->graphicsPipelineCI.layout, setIndex, errorString)) { 29485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set is bound but not compatible w/ overlapping pipelineLayout from PSO 294972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet setHandle = my_data->setMap[state.boundDescriptorSets[setIndex]]->set; 29505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg( 29515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 29525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 29535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 29545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") bound as set #%u is not compatible with overlapping VkPipelineLayout %#" PRIxLEAST64 " due to: %s", 29555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, setIndex, (uint64_t)pPipe->graphicsPipelineCI.layout, errorString.c_str()); 29567a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 29575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Pull the set node 295872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis SET_NODE *pSet = my_data->setMap[state.boundDescriptorSets[setIndex]]; 29595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 2960a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis activeSetBindingsPairs.push_back(std::make_pair(pSet, setBindingPair.second)); 29619bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 29629bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 29639bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis if (!pSet->pUpdateStructs && !pSet->pLayout->immutableSamplerCount) { 29645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 29655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pSet->set, __LINE__, 29665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 29675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS %#" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 29685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this will result in undefined behavior.", 29695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSet->set); 29705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29737a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 29747a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, pCB, activeSetBindingsPairs); 29757a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29767a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) { 29777a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Verify Vtx binding 29787a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pPipe->vertexBindingDescriptions.size() > 0) { 29797a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (size_t i = 0; i < pPipe->vertexBindingDescriptions.size(); i++) { 29807a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 29817a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29827a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29837a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "The Pipeline State Object (%#" PRIxLEAST64 29847a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 29857a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis " should be set via vkCmdBindVertexBuffers.", 29867a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (uint64_t)state.pipeline, i); 29877a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29897a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else { 29907a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (!pCB->currentDrawData.buffers.empty()) { 29917a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 29927a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29937a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Vertex buffers are bound to command buffer (%#" PRIxLEAST64 29947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (%#" PRIxLEAST64 ").", 29957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline); 29965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29987a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 29997a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Skip check if rasterization is disabled or there is no viewport. 30007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if ((!pPipe->graphicsPipelineCI.pRasterizationState || 300145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 30027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pPipe->graphicsPipelineCI.pViewportState) { 3003e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT); 3004e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR); 30057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (dynViewport) { 30067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) { 30077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 30087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 30097a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 30107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ", but PSO viewportCount is %u. These counts must match.", 30117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount); 30127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 30137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 30147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (dynScissor) { 30157a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) { 30167a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 30177a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 30187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 30197a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ", but PSO scissorCount is %u. These counts must match.", 30207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount); 30217a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 30225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 30275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 30285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 3030e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 3031e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 3032e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 30335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 30355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 30375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 30385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 30395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 30405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 30415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 30425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 30435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 30465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 30475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 30485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 30525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 30535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 30545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 30565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 30575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 30605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 30635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3067b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 30683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 306926c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3070c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 3071c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski if ((pAttachments[0].blendEnable != pAttachments[i].blendEnable) || 3072c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcColorBlendFactor != pAttachments[i].srcColorBlendFactor) || 3073c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstColorBlendFactor != pAttachments[i].dstColorBlendFactor) || 3074c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorBlendOp != pAttachments[i].colorBlendOp) || 3075c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcAlphaBlendFactor != pAttachments[i].srcAlphaBlendFactor) || 3076c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstAlphaBlendFactor != pAttachments[i].dstAlphaBlendFactor) || 3077c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].alphaBlendOp != pAttachments[i].alphaBlendOp) || 3078c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorWriteMask != pAttachments[i].colorWriteMask)) { 3079c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski skipCall |= 3080c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3081c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski DRAWSTATE_INDEPENDENT_BLEND, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " 3082c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski "enabled, all elements of pAttachments must be identical"); 3083c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 30845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3087b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 30885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 30895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 30925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 30935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 30955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 30965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 30975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3104a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 31065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 31075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = my_data->renderPassMap.find(pPipeline->graphicsPipelineCI.renderPass); 31085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != my_data->renderPassMap.end() && 31095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass >= rp_data->second->pCreateInfo->subpassCount) { 31105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 31125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "is out of range for this renderpass (0..%u)", 31135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass, rp_data->second->pCreateInfo->subpassCount - 1); 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31166c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data, pPipeline)) { 3117e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall = true; 31185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 311952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 312052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 312152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 312252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 312352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 312452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 312552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 312652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 312752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 312852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 312952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 31305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 31315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 31325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 31335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 31355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 31375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 31385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 31395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 31415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 31425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 31445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 31455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 31465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 31475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 31485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 31515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 31545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3155ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3156ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 31575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 31605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology for tessellation pipelines"); 31615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3162ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3163ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 31645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 31655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology is only valid for tessellation pipelines"); 31695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3170ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 3171ca546210846c65808717f8875deae39bd227c240Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3172ca546210846c65808717f8875deae39bd227c240Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 3173ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "Invalid Pipeline CreateInfo State: " 3174ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 3175ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3176ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3177ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 31785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology used with patchControlPoints value %u." 31825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " patchControlPoints should be >0 and <=32.", 3183ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 31845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 31885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 31895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 319045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 31915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 31925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 31945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and scissors are dynamic PSO must include " 31955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 31965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 31975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 31985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 32005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 3201ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 3202ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 32035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3205e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3206e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 32075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 32085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 32095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 32125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 32135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 32145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetViewport().", 32155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 32165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 32195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 32205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 32215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 32225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 32235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 32245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 32255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetScissor().", 32265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 32275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 32325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 32355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 32365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 32375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3238ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3239ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 32405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipeline, return number of MSAA samples, or one if MSAA disabled 32455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkSampleCountFlagBits getNumSamples(layer_data *my_data, const VkPipeline pipeline) { 32465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipe = my_data->pipelineMap[pipeline]; 3247ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pMultisampleState && 3248ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->graphicsPipelineCI.pMultisampleState->sType)) { 3249ca546210846c65808717f8875deae39bd227c240Tobin Ehlis return pPipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 32505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_SAMPLE_COUNT_1_BIT; 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state related to the PSO 3255e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePipelineState(layer_data *my_data, const GLOBAL_CB_NODE *pCB, const VkPipelineBindPoint pipelineBindPoint, 3256e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipeline pipeline) { 3257e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 32585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that any MSAA request in PSO matches sample# in bound FB 32605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip the check if rasterization is disabled. 32615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = my_data->pipelineMap[pipeline]; 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 326345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 32645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline); 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 32665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits)0; 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32716f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young const VkPipelineColorBlendStateCreateInfo *pColorBlendState = pPipeline->graphicsPipelineCI.pColorBlendState; 32726f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young if ((pColorBlendState != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 32736f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young (pColorBlendState->attachmentCount != pSD->colorAttachmentCount)) { 32746f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 32756f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young reinterpret_cast<const uint64_t &>(pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 32766f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 32776f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young "count %u but subpass color attachment count %u! These must be the same.", 32786f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young pCB->activeSubpass, pColorBlendState->attachmentCount, pSD->colorAttachmentCount); 32796f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young } 32806f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young 32815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pSD->colorAttachmentCount; i++) { 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits samples; 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples; 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) { 32895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 32905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (subpassNumSamples != samples) { 32915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 32925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples; 32975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else if (subpassNumSamples != samples) 33005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 33015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 330304826a08000a815c3d7949348c7dfcaac277d7c9Dominik Witczak if ((pSD->colorAttachmentCount > 0 || pSD->pDepthStencilAttachment) && 330404826a08000a815c3d7949348c7dfcaac277d7c9Dominik Witczak psoNumSamples != subpassNumSamples) { 33050292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 33060292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young (uint64_t)pipeline, __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 33070292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 33080292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!", 33090292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young (uint64_t)pipeline, psoNumSamples, (uint64_t)pCB->activeRenderPass, subpassNumSamples); 33105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass 33135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify and flag error as appropriate 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add more checks here 33175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Validate non-gfx pipeline updates 33195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33200292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young return skipCall; 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 33245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 33265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic DESCRIPTOR_POOL_NODE *getPoolNode(layer_data *my_data, const VkDescriptorPool pool) { 33275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) { 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorPoolMap[pool]; 33315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic LAYOUT_NODE *getLayoutNode(layer_data *my_data, const VkDescriptorSetLayout layout) { 33345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.find(layout) == my_data->descriptorSetLayoutMap.end()) { 33355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorSetLayoutMap[layout]; 33385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3340e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3341e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 33425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 33435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3345e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 33465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 33505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 33515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 33555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 33565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 33575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 33615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 33685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 33695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 33705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex; 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex + count - 1; 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3381e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, 3382e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 33835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 3384e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 33851d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 33875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3393e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 33945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 33995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3401e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set first stageFlags as reference and verify that all other updates match it 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex]; 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = startIndex; i <= endIndex; i++) { 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->descriptorTypes[i] != actualType) { 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i])); 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->stageFlags[i] != refStageFlags) { 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS", 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!", 34175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis refStageFlags, pLayout->stageFlags[i]); 34185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Determine the update type, allocate a new struct of that type, shadow the given pUpdate 3425e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// struct into the pNewNode param. Return true if error condition encountered and callback signals early exit. 34265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 3427e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool shadowUpdateNode(layer_data *my_data, const VkDevice device, GENERIC_HEADER *pUpdate, GENERIC_HEADER **pNewNode) { 3428e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 34295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 34305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCopyDescriptorSet *pCDS = NULL; 34315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdate->sType) { 34325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = new VkWriteDescriptorSet; 34345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pWDS; 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet)); 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 34425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount]; 34435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo)); 34445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pImageInfo = info; 34455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 34465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 34475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBufferView *info = new VkBufferView[pWDS->descriptorCount]; 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView)); 34505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pTexelBufferView = info; 34515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 34525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 34535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 34545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 34555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 34565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount]; 34575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo)); 34585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pBufferInfo = info; 34595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 34605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3461e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 34625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 34665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS = new VkCopyDescriptorSet; 34675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pCDS; 34685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet)); 34695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 34735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 34745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), pUpdate->sType)) 3475e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 34765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that pNext for the end of shadow copy is NULL 34785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (*pNewNode)->pNext = NULL; 34795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given sampler is valid 3483e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSampler(const layer_data *my_data, const VkSampler *pSampler, const bool immutable) { 3484e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 34855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->sampleMap.find(*pSampler); 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->sampleMap.end()) { 34875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!immutable) { 34885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 34895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 34905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, 34915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 34925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // immutable 34935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 34945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 34955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable " 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "sampler %#" PRIxLEAST64, 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 34985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the sampler? 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 35035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 35064a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 35074a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 35084a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 35094a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35114a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 35124a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 35134a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35144a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 35154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35164a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 35184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 35214a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 35224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35234a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 35244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35254a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35264a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 35274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 35284a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35294a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 35304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 35314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 35324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 35334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 35344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 35354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35364a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 35384a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 35394a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 35404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 35414a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35424a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35434a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 35444a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35454a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35464a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 35474a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 35484a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 35504a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 35514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 35524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 35535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 35545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 35574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 35584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 35594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 35604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 35614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 35625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 35634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 35734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 35744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 35754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 35764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 35774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 35784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 35804a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 35845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt == my_data->imageMap.end()) 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data->second.size() >= (imgIt->second.createInfo.arrayLayers * imgIt->second.createInfo.mipLevels + 1)) { 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 36265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 363008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 363308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 363408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 363508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 363608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 364008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 364208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 364308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 36497068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 36507068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 36517068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 365208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 36535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 365608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 365708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 365808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 365908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 366008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 366108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 36625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 366408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 366508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 366708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 366808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 366908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 367008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 367308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 367508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_view_data = dev_data->imageViewMap.find(imageView); 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_view_data != dev_data->imageViewMap.end()); 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_view_data->second.image; 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_view_data->second.subresourceRange; 36835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given imageView is valid 3695e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateImageView(const layer_data *my_data, const VkImageView *pImageView, const VkImageLayout imageLayout) { 3696e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto ivIt = my_data->imageViewMap.find(*pImageView); 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ivIt == my_data->imageViewMap.end()) { 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that imageLayout is compatible with aspectMask and image format 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageAspectFlags aspectMask = ivIt->second.subresourceRange.aspectMask; 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = ivIt->second.image; 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Check here in case we have a bad image 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFormat format = VK_FORMAT_MAX_ENUM; 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt != my_data->imageMap.end()) { 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = (*imgIt).second.createInfo.format; 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Also need to check the swapchains. 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchainIt = my_data->device_extensions.imageToSwapchainMap.find(image); 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchainIt != my_data->device_extensions.imageToSwapchainMap.end()) { 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR swapchain = swapchainIt->second; 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_nodeIt = my_data->device_extensions.swapchainMap.find(swapchain); 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_nodeIt != my_data->device_extensions.swapchainMap.end()) { 37195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SWAPCHAIN_NODE *pswapchain_node = swapchain_nodeIt->second; 37205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = pswapchain_node->createInfo.imageFormat; 37215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (format == VK_FORMAT_MAX_ENUM) { 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " in imageView %#" PRIxLEAST64, 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, (uint64_t)*pImageView); 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool ds = vk_format_is_depth_or_stencil(format); 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (imageLayout) { 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Only Color bit must be set 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must NOT be DS 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ds) { 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 37505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 37515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a color format.", 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, string_VkFormat(format)); 37535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 37565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 37575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Depth or stencil bit must be set, but both must NOT be set 37585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) { 37595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) { 37605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // both must NOT be set 37615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 "" 37655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that has both STENCIL and DEPTH aspects set", 37665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 37695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Neither were set 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 37745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have STENCIL or DEPTH aspect set.", 37755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView); 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must be DS 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ds) { 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a depth/stencil format.", 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView, string_VkFormat(format)); 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // anything to check for other layouts? 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferView is valid 3797e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateBufferView(const layer_data *my_data, const VkBufferView *pBufferView) { 3798e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferViewMap.find(*pBufferView); 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferViewMap.end()) { 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT, 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView, __LINE__, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS", 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView); 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferInfo is valid 3812e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateBufferInfo(const layer_data *my_data, const VkDescriptorBufferInfo *pBufferInfo) { 3813e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer); 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferMap.end()) { 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer, __LINE__, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS", 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, 38205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer); 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3827e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateUpdateContents(const layer_data *my_data, const VkWriteDescriptorSet *pWDS, 3828e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkDescriptorSetLayoutBinding *pLayoutBinding) { 3829e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampler *pSampler = NULL; 3832e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool immutable = false; 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For given update type, verify that update contents are correct 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable); 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 38425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayoutBinding->pImmutableSamplers) { 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pWDS->pImageInfo[i].sampler); 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (immutable) { 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", but previous update(s) from this " 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either " 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, (uint64_t)*pSampler); 38545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i > 0 && !immutable) { 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this " 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either " 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i); 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3865e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves immutable = true; 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pLayoutBinding->pImmutableSamplers[i]); 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, pSampler, immutable); 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Intentionally fall through here to also validate image stuff 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout); 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 38795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i])); 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i])); 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3899e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3900e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3901e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3902e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s() on descriptor set %" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 39135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "Cannot call %s() on descriptor set %" PRIxLEAST64 " that is in use by a command buffer.", 39145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 39185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void invalidateBoundCmdBuffers(layer_data *dev_data, const SET_NODE *pSet) { 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Flag any CBs this set is bound to as INVALID 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : pSet->boundCmdBuffers) { 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cb_node = dev_data->commandBufferMap.find(cb); 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_node != dev_data->commandBufferMap.end()) { 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cb_node->second->state = CB_INVALID; 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// update DS mappings based on write and copy update arrays 3929e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool dsUpdate(layer_data *my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pWDS, 3930e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pCDS) { 3931e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = NULL; 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSetLayoutCreateInfo *pLayoutCI = NULL; 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate Write updates 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorWriteCount; i++) { 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSet ds = pWDS[i].dstSet; 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = my_data->setMap[ds]; 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 3941e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateIdleDescriptorSet(my_data, ds, "VkUpdateDescriptorSets")) == true) 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If set is bound to any cmdBuffers, mark them invalid 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pSet); 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pUpdate = (GENERIC_HEADER *)&pWDS[i]; 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayout = pSet->pLayout; 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify valid update struct 3948e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == true) { 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t binding = 0, endIndex = 0; 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = pWDS[i].dstBinding; 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingToIndex = pLayout->bindingToIndexMap.find(binding); 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that layout being updated has the binding being updated 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (bindingToIndex == pLayout->bindingToIndexMap.end()) { 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor Set %" PRIu64 " does not have binding to match " 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "update binding %u for update type " 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s!", 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), binding, string_VkStructureType(pUpdate->sType)); 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Next verify that update falls within size of given binding 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pLayout, binding) < endIndex) { 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pLayout->createInfo; 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), binding, DSstr.c_str()); 39735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // TODO : should we skip update on a type mismatch or force it? 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t startIndex; 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layout bindings match w/ update, now verify that update type 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // & stageFlags are the same for entire update 3978e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == false) { 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The update is within bounds and consistent, but need to 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // make sure contents make sense as well 39815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((skipCall = validateUpdateContents(my_data, &pWDS[i], 3982e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves &pLayout->createInfo.pBindings[bindingToIndex->second])) == false) { 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update is good. Save the update info 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new update struct for this set's shadow copy 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pNewNode = NULL; 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode); 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()"); 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert shadow node into LL of updates for this set 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pSet->pUpdateStructs; 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = pNewNode; 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update appropriate descriptor(s) to point to new Update node 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = startIndex; j <= endIndex; j++) { 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(j < pSet->descriptorCount); 39993a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates[j] = pNewNode; 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now validate copy updates 40085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorCopyCount; ++i) { 40095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSrcSet = NULL, *pDstSet = NULL; 40105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL; 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0; 40125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each copy make sure that update falls within given layout and that types match 40135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcSet = my_data->setMap[pCDS[i].srcSet]; 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet = my_data->setMap[pCDS[i].dstSet]; 40155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 4016e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateIdleDescriptorSet(my_data, pDstSet->set, "VkUpdateDescriptorSets")) == true) 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 40185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pDstSet); 40195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcLayout = pSrcSet->pLayout; 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstLayout = pDstSet->pLayout; 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src binding is valid for src set layout 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->bindingToIndexMap.find(pCDS[i].srcBinding) == pSrcLayout->bindingToIndexMap.end()) { 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has srcBinding %u " 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 40285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].srcBinding, (uint64_t)pSrcLayout->layout, pSrcLayout->createInfo.bindingCount - 1); 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pDstLayout->bindingToIndexMap.find(pCDS[i].dstBinding) == pDstLayout->bindingToIndexMap.end()) { 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 40325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has dstBinding %u " 40335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].dstBinding, (uint64_t)pDstLayout->layout, pDstLayout->createInfo.bindingCount - 1); 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout 40385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 40395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 40415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) { 40435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pSrcLayout->createInfo; 40445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 40455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].srcBinding, DSstr.c_str()); 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) { 40515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pDstLayout->createInfo; 40525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 40535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].dstBinding, DSstr.c_str()); 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 40625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pCDS[i].descriptorCount; ++j) { 40645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For copy just make sure that the types match and then perform the update 40655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->descriptorTypes[srcStartIndex + j] != pDstLayout->descriptorTypes[dstStartIndex + j]) { 40665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 40675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update index %u, update count #%u, has src update descriptor type %s " 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that does not match overlapping dest descriptor type of %s!", 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, j + 1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex + j]), 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex + j])); 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // point dst descriptor at corresponding src descriptor 40745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This may be a hole. I believe copy should be its own copy, 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // otherwise a subsequent write update to src will incorrectly affect the copy 40763a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pDstSet->pDescriptorUpdates[j + dstStartIndex] = pSrcSet->pDescriptorUpdates[j + srcStartIndex]; 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet->pUpdateStructs = pSrcSet->pUpdateStructs; 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4086a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// Verify that given pool has descriptors that are being requested for allocation. 4087a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// NOTE : Calls to this function should be wrapped in mutex 4088e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_descriptor_availability_in_pool(layer_data *dev_data, DESCRIPTOR_POOL_NODE *pPoolNode, uint32_t count, 4089e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkDescriptorSetLayout *pSetLayouts) { 4090e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4091a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t i = 0; 4092a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t j = 0; 4093a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 4094a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Track number of descriptorSets allowable in this pool 4095a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski if (pPoolNode->availableSets < count) { 4096a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 4097a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski reinterpret_cast<uint64_t &>(pPoolNode->pool), __LINE__, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 4098a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski "Unable to allocate %u descriptorSets from pool %#" PRIxLEAST64 4099a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptorSets remaining.", 4100a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski count, reinterpret_cast<uint64_t &>(pPoolNode->pool), pPoolNode->availableSets); 4101a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } else { 4102a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets -= count; 4103a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } 4104a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 41055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; ++i) { 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pSetLayouts[i]); 41075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 41085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 41095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 41105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i], __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 41115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 41125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i]); 41135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 41155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pLayout->createInfo.bindingCount; ++j) { 41165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 41175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 41185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) { 41195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 41205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pLayout->layout, __LINE__, 41215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 41225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 4123a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptors of this type remaining.", 41245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBindings[j].descriptorType), 41255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]); 41265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Decrement available descriptors of this type 41275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount; 41285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the shadowed update node for this Set 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void freeShadowUpdateTree(SET_NODE *pSet) { 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pShadowUpdate = pSet->pUpdateStructs; 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = NULL; 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pFreeUpdate = pShadowUpdate; 41415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the descriptor mappings as they will now be invalid 41423a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates.clear(); 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pShadowUpdate) { 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeUpdate = pShadowUpdate; 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pShadowUpdate = (GENERIC_HEADER *)pShadowUpdate->pNext; 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pFreeUpdate->sType) { 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = (VkWriteDescriptorSet *)pFreeUpdate; 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pImageInfo; 41565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 41585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 41595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pTexelBufferView; 41605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 41625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pBufferInfo; 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(0); 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeUpdate; 41785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 41855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 41865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 41875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = (*ii).second->pSets; 41885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pFreeSet = pSet; 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeSet = pSet; 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Freeing layouts handled in deleteLayouts() function 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free Update shadow struct tree 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pFreeSet); 41955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeSet; 41965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 41985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid 42035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 42045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteLayouts(layer_data *my_data) { 42055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.size() <= 0) 42065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 42075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorSetLayoutMap.begin(); ii != my_data->descriptorSetLayoutMap.end(); ++ii) { 42085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = (*ii).second; 42095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->createInfo.pBindings) { 42105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings[i].pImmutableSamplers; 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings; 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pLayout; 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorSetLayoutMap.clear(); 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Currently clearing a set is removing all previous updates to that set 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Validate if this is correct clearing behavior 42225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorSet(layer_data *my_data, VkDescriptorSet set) { 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = getSetNode(my_data, set); 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSet) { 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Return error 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pSet); 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 42335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPool) { 42355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 42365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 42375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t)pool); 42385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 42395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: validate flags 424051db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free SET_NODE 42415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = pPool->pSets; 424251db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis SET_NODE *pFreeSet = pSet; 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorSet(my_data, pSet->set); 424551db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis my_data->setMap.erase(pSet->set); 424651db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis pFreeSet = pSet; 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 424851db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis delete pFreeSet; 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 425051db9745081fb7d5eaf6d00cfe5dcc1f82c1730cTobin Ehlis pPool->pSets = nullptr; 4251e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis // Reset available count for each type and available sets for this pool 42525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 42535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 42545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4255e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis pPool->availableSets = pPool->maxSets; 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 42605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *my_data, const VkCommandBuffer cb) { 42615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->commandBufferMap.count(cb) == 0) { 426272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 426372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 426472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 42655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 42665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->commandBufferMap[cb]; 42685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 42725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 4273400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 42745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 42755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 42775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 42805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4282e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 42835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 42845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 42855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 42865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4288e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 42895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 4290e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 4291e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 42925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && cmd_type != CMD_EXECUTECOMMANDS) { 42935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 42965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 42975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 43005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 43075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 43085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 43105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 43135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 43145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 43175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 43185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 43215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 43255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 43265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 43295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 4330e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool addCmd(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 4331e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 43325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = my_data->commandPoolMap.find(pCB->createInfo.commandPool); 43335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != my_data->commandPoolMap.end()) { 4334b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pool_data->second.queueFamilyIndex].queueFlags; 43355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 43365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 43375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 43395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 43405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 43415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 43425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 43435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 43455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 43475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 43485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 43495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 43525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 43535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 43555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 43565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 43575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 43585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 43595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 43605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 43615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 43625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 43635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 43645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 43655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 43665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 43675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 43685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 43695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 43705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 43715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 43725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 43735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 43765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 43775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 43805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 43815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 43825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 43835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 43845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 43855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 43875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 43895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 43935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 43945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 43955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 43965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 43985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 43995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 44005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 44025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 44045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 4405400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 4406400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 44075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 44085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 44105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 44115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 44125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 44135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 44145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 44165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 44175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 442093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 442172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 442272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 442372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 4424400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis auto set_node = dev_data->setMap.find(set); 4425400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (set_node != dev_data->setMap.end()) { 442672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis set_node->second->boundCmdBuffers.erase(pCB->commandBuffer); 442772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 442872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 442972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 443072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 443193c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 44325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 44335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 443672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->fenceId = 0; 443772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedFence = VK_NULL_HANDLE; 443872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedQueue = VK_NULL_HANDLE; 44395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedSets.clear(); 44405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->updatedSets.clear(); 44415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedFramebuffers.clear(); 44425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->semaphores.clear(); 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 44475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 44485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 4449abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 44505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 44515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 44545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 4455bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 4456bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 4457bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 4458bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 44607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 44617a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 4462400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 4463b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 446493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 446593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 446693c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 446793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski auto fbNode = dev_data->frameBufferMap.find(framebuffer); 446893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski if (fbNode != dev_data->frameBufferMap.end()) { 446993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski fbNode->second.referencingCmdBuffers.erase(pCB->commandBuffer); 447093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 447193c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 447293c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 447393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 4480ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 4481ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 44825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 44835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 44865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 44875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 4488ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 4489ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 44905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 44915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 44985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 45005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 45033d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 45045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 45075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 45095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 45105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 45125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 45135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 45155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 45165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 45185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 45195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 45235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 4527e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 4528e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 453172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 45325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 45335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 45345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 45365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 4537ca546210846c65808717f8875deae39bd227c240Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 4538ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 4539ca546210846c65808717f8875deae39bd227c240Tobin Ehlis .c_str()); 45405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 45475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 45485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 45495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_NONE, "DS", "Cmds in CB %p", (void *)cb); 45505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 45515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 45525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 45535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 45545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", " CMD#%" PRIu64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 45555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 45585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4561e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 4562e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 45635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 45645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= printPipeline(my_data, cb); 45675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 4572e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4573e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 45745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 45775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")", apiName, 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass); 45795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 45815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 45845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 4585e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4586e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 45875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 45885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 45905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 45925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 45935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 45955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4597b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 4598d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4599b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 46005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 46045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 46055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 46065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 46085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 46095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 46105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 46115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 46125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 46145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 46155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 46175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 46185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4620b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 4621b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 4622b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 46235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4624b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 4625b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 4626b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 46275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4628b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 46295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 46315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 46375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 46385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 46395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 46405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 46415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 46425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 46435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 46445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4645b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 46465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 46475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 46485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 46495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 46505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 46515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 46545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 46555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 46565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 46595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 46605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 46615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 46625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 46645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 46665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 46675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 46685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 46695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 46705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 46715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 46725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 46755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 46765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 46805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 46815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 46825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 46845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 46855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 46865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(NULL, "vkCreateDevice"); 46875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 46885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 46925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 46935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 46955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 46965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4699b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 47005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 47015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 47025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 47045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 47055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 47066c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 47075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 47105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4711b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 47125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 47135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4714b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 47155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4716b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 47175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 47185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4719b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 47205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4721b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 47225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4723b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4724b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4725b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 47265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 47285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 47335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 47345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 47355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 47375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4739b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 47415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 47425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 47435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 47445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteLayouts(dev_data); 47455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 47465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 47475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 47485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 47495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 47505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 47511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 47521344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4753b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 475403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 4755e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4756b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 47575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 47585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 47595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 47605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 47610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 47620a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 47635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 476458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4765400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 47665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 47675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 47685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 47695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 47705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 47715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 47725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, 47735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mem Object %" PRIu64 " has not been freed. You should clean up this memory by calling " 47745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkFreeMemory(%" PRIu64 ") prior to vkDestroyDevice().", 47755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 47765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4780b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 47815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 47835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fprintf(stderr, "Device: %p, key: %p\n", device, key); 47845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 4786e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 47885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 47905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 47925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 47935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 47945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 47975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 47995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 48005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 48015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 48045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 48055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_global_layers), cv_global_layers, pCount, pProperties); 48065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Why does this exist - can we just use global? 48095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_device_layers[] = {{ 4810f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 48115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 48125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 48145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *pLayerName, uint32_t *pCount, 48155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkExtensionProperties *pProperties) { 48165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayerName == NULL) { 48175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(physicalDevice); 48185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 48195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 48205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(0, NULL, pCount, pProperties); 48225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 48265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 48275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* draw_state physical device layers are the same as global */ 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_device_layers), cv_device_layers, pCount, pProperties); 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 48325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 48335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4834e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) { 4835e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 48375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 48385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 48395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 48405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 48415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 48425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 48435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image %" PRIu64 ".", 48445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 48455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 48485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4849856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4850856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4851856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4852856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4853856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "Cannot submit cmd buffer using image (%" PRIx64 ") [sub-resource: array layer %u, mip level %u], " 4854856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4855856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.arrayLayer, 4856856ecb404bc959ddb877c150c9caa0649055b9cbMark Young cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4857856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4858856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4859856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4860856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4861856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4862856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "Cannot submit cmd buffer using image (%" PRIx64 ") with layout %s when " 4863856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4864856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4865856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4866856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 48675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 48695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 487339d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 48745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 4875e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB) { 4876e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 48785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 48795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 48805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 48815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 48825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 48835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted buffer %" PRIu64 ".", (uint64_t)(buffer)); 48845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_add(1); 48865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 488972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 489072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 489172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 489272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode == my_data->setMap.end()) { 489372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 489472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 489572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 489672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Cannot submit cmd buffer using deleted descriptor set %" PRIu64 ".", (uint64_t)(set)); 489772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 489872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_add(1); 489972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 49005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 49035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 49045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode == my_data->semaphoreMap.end()) { 49055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 49065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 49075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 49085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted semaphore %" PRIu64 ".", reinterpret_cast<uint64_t &>(semaphore)); 49095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 49105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_add(1); 49115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 49145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 49155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode == my_data->eventMap.end()) { 49165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 49175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 49185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 49195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted event %" PRIu64 ".", reinterpret_cast<uint64_t &>(event)); 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 49215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_add(1); 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 49255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4927e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, VkCommandBuffer cmdBuffer) { 49285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 49305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 49315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != my_data->bufferMap.end()) { 49335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_sub(1); 49345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 493772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 493872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 493972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 494072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode != my_data->setMap.end()) { 494172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_sub(1); 494272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 49435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 49465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 49475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode != my_data->semaphoreMap.end()) { 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_sub(1); 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 49525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 49535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode != my_data->eventMap.end()) { 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_sub(1); 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 49585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 49595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto eventStagePair : pCB->eventToStageMap) { 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 49625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4965e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 49665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 49675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(pFences[i]); 49685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end() || !fence_data->second.needsSignaled) 49695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 49705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = false; 49715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_sub(1); 49721d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill decrementResources(my_data, static_cast<uint32_t>(fence_data->second.priorFences.size()), 49731d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill fence_data->second.priorFences.data()); 49745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : fence_data->second.cmdBuffers) { 49755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 49765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4980e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, VkQueue queue) { 49815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 49825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 49835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : queue_data->second.untrackedCmdBuffers) { 49845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 49855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 49871d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill decrementResources(my_data, static_cast<uint32_t>(queue_data->second.lastFences.size()), 49881d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill queue_data->second.lastFences.data()); 49890a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49900a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 49910a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 4992e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 49930a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 49940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 49950a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49960a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 49970a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto other_queue_data = dev_data->queueMap.find(other_queue); 49980a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue_data == dev_data->queueMap.end() || other_queue_data == dev_data->queueMap.end()) { 49990a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 50000a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 5001ca32a764ef85a255c97531164bffb073553de105Jamie Madill for (auto fenceInner : other_queue_data->second.lastFences) { 5002ca32a764ef85a255c97531164bffb073553de105Jamie Madill queue_data->second.lastFences.push_back(fenceInner); 50030a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50040a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence != VK_NULL_HANDLE) { 50050a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 50060a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence_data == dev_data->fenceMap.end()) { 50070a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 50080a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50090a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 50100a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 50110a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50120a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 50130a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 50140a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 50150a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.untrackedCmdBuffers.push_back(cmdbuffer); 50160a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50170a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 50185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5019b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto eventStagePair : other_queue_data->second.eventToStageMap) { 5020b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[eventStagePair.first] = eventStagePair.second; 5021b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 50225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5024e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void trackCommandBuffers(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 5025e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkFence fence) { 50265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 50275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 50280a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine vector<VkFence> prior_fences; 50295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(fence); 50305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end()) { 50315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 50325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5033abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine fence_data->second.cmdBuffers.clear(); 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50350a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine prior_fences = queue_data->second.lastFences; 50360a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.clear(); 50370a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.push_back(fence); 50380a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : queue_data->second.untrackedCmdBuffers) { 50390a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 50405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 50425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50430a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.priorFences = prior_fences; 50445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = true; 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.queue = queue; 50465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_add(1); 50475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(secondaryCmdBuffer); 50525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(submit->pCommandBuffers[i]); 50545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 50575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(secondaryCmdBuffer); 50635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(submit->pCommandBuffers[i]); 50655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add cmdBuffers to both the global set and queue set 50745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(secondaryCmdBuffer); 50765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.inFlightCmdBuffers.insert(secondaryCmdBuffer); 50775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 50795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.inFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 50805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5085e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 50865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 50875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 50885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 50895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 50905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 509127c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 509227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Command Buffer %#" PRIx64 " is already in use and is not marked for simultaneous use.", 50935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 50945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 50965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 50995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 51000a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 51010a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 51020a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 51030a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 51040a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 51050a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis "set, but has been submitted %#" PRIxLEAST64 " times.", 51060a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 51070a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 51085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 51095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 51105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 51125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool causeReported = false; 51135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedSets.empty()) { 51145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 51155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->destroyedSets) 51165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 51175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 51225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) destroyed: %s", 51235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 51245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 51255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->updatedSets.empty()) { 51275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 51285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->updatedSets) 51295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 51305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) updated: %s", 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 51375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 51385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedFramebuffers.empty()) { 51405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream fb_string; 51415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto fb : pCB->destroyedFramebuffers) 51425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_string << " " << fb; 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid because it had the following " 51485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "referenced framebuffers destroyed: %s", 51495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), fb_string.str().c_str()); 51505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 51515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This is defensive programming to make sure an error is 51535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // flagged if we hit this INVALID cmd buffer case and none of the 51545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // above cases are hit. As the number of INVALID cases grows, this 51555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // code should be updated to seemlessly handle all the cases. 51565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!causeReported) { 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 51585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid due to an unknown cause. Validation " 51615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "should " 51625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "be improved to report the exact cause.", 51635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer)); 51645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 51695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", 51705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 51715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 51745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5176e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 51775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 5178e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = validateAndIncrementResources(dev_data, pCB); 51795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 51805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 51815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndIncrementResources(dev_data, dev_data->commandBufferMap[secondaryCmdBuffer]); 51825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 51835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->primaryCommandBuffer != pCB->commandBuffer) { 51845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 51855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 51865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "CB %#" PRIxLEAST64 " was submitted with secondary buffer %#" PRIxLEAST64 51875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 51885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "primary cmd buffer %#" PRIxLEAST64 ".", 51895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 51905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 51915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pCB); 51955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 51965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // on device 51975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferSimultaneousUse(dev_data, pCB); 51985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 51995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 52025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 5203e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 520472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = NULL; 52055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 52065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5207b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that fence is not in use 52095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((fence != VK_NULL_HANDLE) && (submitCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 52105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 52115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 52125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is already in use by another submission.", (uint64_t)(fence)); 52135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis uint64_t fenceId = 0; 52151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall = add_fence_info(dev_data, fence, queue, &fenceId); 52161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 52171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 52181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 52195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 52200a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 52215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 52225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 52235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 52245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 52250a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pWaitSemaphores[i]; 522641bb23666442c59912c630f85db04ce1a052f3efTobin Ehlis semaphoreList.push_back(semaphore); 52271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 52281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 52291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 52301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 52311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 52321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 52331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 52341344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 52351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 52361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52371344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkQueue &other_queue = dev_data->semaphoreMap[semaphore].queue; 52381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 52391344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 52401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis processed_other_queues.insert(other_queue); 52411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 52450a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pSignalSemaphores[i]; 52461344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 52471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis semaphoreList.push_back(semaphore); 52481344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 52491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 52501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 52511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 52521344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Queue %#" PRIx64 " is signaling semaphore %#" PRIx64 52531344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has already been signaled but not waited on by queue %#" PRIx64 ".", 52541344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 52551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(dev_data->semaphoreMap[semaphore].queue)); 52561344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 52571344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 52581344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].queue = queue; 52591344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52600a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 52615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 52635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]); 526472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 52651344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 52661344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->semaphores = semaphoreList; 52671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 52681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->fenceId = fenceId; 52691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedFence = fence; 52701344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedQueue = queue; 52711344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= validatePrimaryCommandBufferState(dev_data, pCBNode); 52721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 52731344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 52741344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(); 52751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52761344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 52771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(queue); 52781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52791344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update cmdBuffer-related data structs and mark fence in-use 52835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis trackCommandBuffers(dev_data, queue, submitCount, pSubmits, fence); 5284b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5285e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 52865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 52875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 529103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 52925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 52945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 52965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 5297b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 52985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 52990a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 53005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 53045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 53055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 53085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 53095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 53105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 53115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 53135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5314b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5315e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves freeMemObjInfo(my_data, device, mem, false); 53160a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 53170a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 5318b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 53205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5322e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 5323e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 53245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 53265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: a size of 0 is not listed as an invalid use in the spec, should it be? 53275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 53305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 53355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.size != 0) { 53365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object %#" PRIxLEAST64, (uint64_t)mem); 53395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 53425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 53435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (offset >= mem_element->second.allocInfo.allocationSize) { 53445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 53465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 53475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.allocInfo.allocationSize, mem_element->second.allocInfo.allocationSize); 53485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 53505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((offset + size) > mem_element->second.allocInfo.allocationSize) { 53515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 53535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 53545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size + offset, mem_element->second.allocInfo.allocationSize); 53555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 53595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5361e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 53625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MemRange new_range; 53655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.offset = offset; 53665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.size = size; 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange = new_range; 53685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5371e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 5372e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_element->second.memRange.size) { 53765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 53775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj %#" PRIxLEAST64, (uint64_t)mem); 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange.size = 0; 53825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis free(mem_element->second.pData); 53845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 53855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5392b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 5393b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto mem_element = dev_data->memObjMap.find(mem); 5394b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (mem_element != dev_data->memObjMap.end()) { 53955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pDriverData = *ppData; 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t index = mem_element->second.allocInfo.memoryTypeIndex; 5397b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 53995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 54005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 54015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size = mem_element->second.allocInfo.allocationSize; 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 54045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = malloc(2 * convSize); 54055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(mem_element->second.pData, NoncoherentMemoryFillValue, 2 * convSize); 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppData = static_cast<char *>(mem_element->second.pData) + (convSize / 2); 54075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Note: This function assumes that the global lock is held by the calling 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// thread. 5413e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 5414e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 54155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 54165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 54175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 54185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : queryEventsPair.second) { 54195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->eventMap[event].needsSignaled) { 54205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 54215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 54225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 54235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " with index %d which was guarded by unsignaled event %" PRIu64 ".", 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove given cmd_buffer from the global inFlight set. 54325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Also, if given queue is valid, then remove the cmd_buffer from that queues 54335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// inFlightCmdBuffer set. Finally, check all other queues and if given cmd_buffer 54345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// is still in flight on another queue, add it back into the global set. 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Note: This function assumes that the global lock is held by the calling 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// thread. 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkQueue queue) { 54385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Pull it off of global list initially, but if we find it in any other queue list, add it back in 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->queueMap.find(queue) != dev_data->queueMap.end()) { 54415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.erase(cmd_buffer); 54425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto q : dev_data->queues) { 54435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((q != queue) && 54445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dev_data->queueMap[q].inFlightCmdBuffers.find(cmd_buffer) != dev_data->queueMap[q].inFlightCmdBuffers.end())) { 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(cmd_buffer); 54465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 54475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 545103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic inline bool verifyFenceStatus(VkDevice device, VkFence fence, const char *apiCall) { 54535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5454e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 54555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFenceInfo = my_data->fenceMap.find(fence); 54565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceInfo != my_data->fenceMap.end()) { 5457e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!pFenceInfo->second.firstTimeFlag) { 5458e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((pFenceInfo->second.createInfo.flags & VK_FENCE_CREATE_SIGNALED_BIT) && !pFenceInfo->second.firstTimeFlag) { 54595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 54605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 54615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 54625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s specified fence %#" PRIxLEAST64 " already in SIGNALED state.", apiCall, (uint64_t)fence); 54635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pFenceInfo->second.queue && !pFenceInfo->second.swapchain) { // Checking status of unsubmitted fence 54655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 54665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 54675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s called for fence %#" PRIxLEAST64 " which has not been submitted on a Queue or during " 54685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "acquire next image.", 54695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5472e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pFenceInfo->second.firstTimeFlag = false; 54735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 54765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 54795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 54805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5481e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 548203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 5484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= verifyFenceStatus(device, pFences[i], "vkWaitForFences"); 54875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5488b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 54905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 54935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5495b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 54965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 54975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 54985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 549903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis update_fence_tracking(dev_data, pFences[i]); 55015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueue fence_queue = dev_data->fenceMap[pFences[i]].queue; 55035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->fenceMap[pFences[i]].cmdBuffers) { 55045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 55055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, fence_queue); 55065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, fenceCount, pFences); 55095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 55115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 55125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 5513b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5515e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 55165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetFenceStatus(VkDevice device, VkFence fence) { 55215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 55235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 552403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 5525b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = verifyFenceStatus(device, fence, "vkGetFenceStatus"); 5527b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 55295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 5532e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 5533b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 55345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 553503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis update_fence_tracking(dev_data, fence); 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_queue = dev_data->fenceMap[fence].queue; 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->fenceMap[fence].cmdBuffers) { 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 55415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, fence_queue); 55425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, 1, &fence); 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5545b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5546e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5551b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5552b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 5555b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5556b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5557b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5558b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5559b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5560b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 5561b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 556203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 5563b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->lastRetiredId = 0; 5564b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->lastSubmittedId = 0; 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 5566b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueWaitIdle(VkQueue queue) { 55705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, queue); 5572e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 5573b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Iterate over local set since we erase set members as we go in for loop 55755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto local_cb_set = dev_data->queueMap[queue].inFlightCmdBuffers; 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : local_cb_set) { 55775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 55785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, queue); 55795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.clear(); 5581b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5582e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 55835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 558503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5587b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 55885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis retire_queue_fences(dev_data, queue); 5589b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDeviceWaitIdle(VkDevice device) { 5596e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5598b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 56005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, queue); 56015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->queueMap.find(queue) != dev_data->queueMap.end()) { 56025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear all of the queue inFlightCmdBuffers (global set cleared below) 56035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.clear(); 56045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 56075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 5610b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5611e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 56125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 56135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 561403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 56155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5616b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 56175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis retire_device_fences(dev_data, device); 5618b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 56215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 56255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5627b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 56291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 56301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair->second.in_use.load()) { 56311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 56321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 56331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", (uint64_t)(fence)); 56341344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 56351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 56365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5637b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 56395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 56405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 56415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 56445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 56455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 5647b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 56485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 56495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 56505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 56515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 56525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 56535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete semaphore %" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 56545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 56565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 56585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 56615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5663b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto event_data = dev_data->eventMap.find(event); 56655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data != dev_data->eventMap.end()) { 56665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data->second.in_use.load()) { 56675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg( 56685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 56695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 56705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete event %" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 56715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap.erase(event_data); 56735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5674b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 56765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 56775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 56785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 56815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 56825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 56835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 56845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 56855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkGetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 56885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 56895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryResultFlags flags) { 56905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 56925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = nullptr; 5693b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 56955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB = getCBNode(dev_data, cmdBuffer); 56965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 56975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 56985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5700e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 57015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 57025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 57035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 57045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 57055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5706ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5707ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5708ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5709ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5710ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 5711ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5712ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5713ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5714ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5715ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 " with index %d which is in flight.", 5716ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5717ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5718ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5719ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5720ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5721ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5722ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5723ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5724ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5725ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5726ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5727ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5728ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5729ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 5730ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5731ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5732ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 57335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5735ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 57365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 57375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5738ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5739ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 57405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 57435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5744ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5745ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5746ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5747ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5748ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 5749ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5750ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 57515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5754b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 57565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 57575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 57585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 57595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5761e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5762e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 57635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 57645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 57655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 57665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 57675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 57685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data->second.in_use.load()) { 57705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 57715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 57765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 57795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks *pAllocator) { 57805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5782b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!validateIdleBuffer(dev_data, buffer) && !skipCall) { 5784b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 5786b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 57875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.erase(buffer); 57895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 57925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 57935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 5795b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 57965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 57975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 57985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 57995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 58035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5804e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5805e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 58065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 58075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5808b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 58095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& entry = dev_data->imageMap.find(image); 58105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (entry != dev_data->imageMap.end()) { 581158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Clear any memory mapping for this image 581294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto mem_entry = dev_data->memObjMap.find(entry->second.mem); 581358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (mem_entry != dev_data->memObjMap.end()) 581458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis mem_entry->second.image = VK_NULL_HANDLE; 581558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 581658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 58175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.erase(entry); 58185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 58205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 58215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 58225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 58235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 58255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 582703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 5828e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 5829e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkDebugReportObjectTypeEXT object_type) { 58305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 583158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 58325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Buffer %" PRIx64 " is alised with image %" PRIx64, object_handle, 58335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 58345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 583558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 58365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Image %" PRIx64 " is alised with buffer %" PRIx64, object_handle, 58375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 58385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5841e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 5842e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkDebugReportObjectTypeEXT object_type) { 5843e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 584458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 58455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto range : ranges) { 5846b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) < 5847b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (new_range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 58485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 5849b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) > 5850b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (new_range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 58515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 585258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 58535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 58555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5857e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_buffer_image_aliasing(layer_data *dev_data, uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 5858e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges, 5859e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const vector<MEMORY_RANGE> &other_ranges, VkDebugReportObjectTypeEXT object_type) { 58605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMORY_RANGE range; 58615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.handle = handle; 58625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.memory = mem; 58635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.start = memoryOffset; 58645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.end = memoryOffset + memRequirements.size - 1; 586558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis ranges.push_back(range); 586658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return validate_memory_range(dev_data, other_ranges, range, object_type); 58675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 58705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 587158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5873b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 58745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 58755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 5876e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = 587794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 587894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto buffer_node = dev_data->bufferMap.find(buffer); 587994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 588094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis buffer_node->second.mem = mem; 58815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 588294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 588358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, buffer_handle, mem, memoryOffset, memRequirements, 588458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].bufferRanges, dev_data->memObjMap[mem].imageRanges, 588558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 58862c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 58872c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 58882c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58892c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 58902c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 58912c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be an integer multiple of the " 58922c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "VkMemoryRequirements::alignment value %#" PRIxLEAST64 58932c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 58942c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 58952c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58962c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 589794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].createInfo.usage; 58982c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & (VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT)) { 5899b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment) != 0) { 59002c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 59012c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 59022c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 59032c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 59042c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minTexelBufferOffsetAlignment %#" PRIxLEAST64, 5905b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment); 59062c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59072c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59082c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT) { 5909b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 5910b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 59112c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 59122c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 59132c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 59142c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 59152c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minUniformBufferOffsetAlignment %#" PRIxLEAST64, 5916b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 59172c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59182c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59192c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_STORAGE_BUFFER_BIT) { 5920b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 5921b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 59222c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 59232c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 59242c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 59252c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 59262c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minStorageBufferOffsetAlignment %#" PRIxLEAST64, 5927b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 59282c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59292c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59310a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5932b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5933e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 593458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 59355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 59415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 59445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 59455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 59495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 59525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 59535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 59555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 59575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 59595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5964918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5965918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5966b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5967918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5968b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5969918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5970918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 59765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 59815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 59835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 59885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 59895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 59945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 59965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 60015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 60035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6005bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 6006bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 6007bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 6008bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 6009bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 6010bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 6011bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 6012bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 6013bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 6014bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 6015bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 6016bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6017bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6018bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis "Attempt to %s command buffer (%#" PRIxLEAST64 ") which is in use.", action, 6019bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 6020bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } else { // Secondary CB w/o primary in-flight, remove from in-flight 6021bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 6022bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6023bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6024bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 6025bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 6026bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 6027bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBuffersInFlight(layer_data *dev_data, const VkCommandPool commandPool, const char *action) { 6028bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 6029bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto pool_data = dev_data->commandPoolMap.find(commandPool); 6030bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (pool_data != dev_data->commandPoolMap.end()) { 6031bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto cmd_buffer : pool_data->second.commandBuffers) { 6032bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 6033bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 6034bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6035bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6036bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6037bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 6038bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 60395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 60425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 6045b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 60465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 6047bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto cb_pair = dev_data->commandBufferMap.find(pCommandBuffers[i]); 6048bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, cb_pair->second, "free"); 60495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 6050bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (cb_pair != dev_data->commandBufferMap.end()) { 60515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 6052bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis resetCB(dev_data, (*cb_pair).second->commandBuffer); 6053bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis delete (*cb_pair).second; 6054bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->commandBufferMap.erase(cb_pair); 60555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 60585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]); 60595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 606003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 60610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 60625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 6063b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 60665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 60675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 60705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 60715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool *pCommandPool) { 60725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 60755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6077b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 60785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 60795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 60805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 60865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 60895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 6090b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 60915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 60925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 60975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 60995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 6101b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 6103bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis VkBool32 result = checkAndClearCommandBuffersInFlight(dev_data, commandPool, "destroy command pool with"); 61045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap 61055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) { 61065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 61075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb != dev_data->commandPoolMap[commandPool].commandBuffers.end();) { 6108400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, *poolCb); 61095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto del_cb = dev_data->commandBufferMap.find(*poolCb); 61105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*del_cb).second; // delete CB info structure 611172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer 61125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.erase( 61135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb); // Remove CB reference from commandPoolMap's list 61145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap.erase(commandPool); 61175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6118b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 61195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6120f90830842fdd43e8f1834f2eb76bda28eef435b8Tony Barbour if (result) 61215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 61225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 61245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 61255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 61285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 61295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 61315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 6132400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 6133bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (checkAndClearCommandBuffersInFlight(dev_data, commandPool, "reset command pool with")) 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 61355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 61375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 61385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 61405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6141b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 61435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 61445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*it)); 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 61525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 61545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 6155b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 615703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset fence state in fenceCreateInfo structure 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge with code below 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = dev_data->fenceMap.find(pFences[i]); 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != dev_data->fenceMap.end()) { 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate fences in SIGNALED state 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(fence_item->second.createInfo.flags & VK_FENCE_CREATE_SIGNALED_BIT)) { 61645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: I don't see a Valid Usage section for ResetFences. This behavior should be documented there. 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pFences[i], __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted to VkResetFences in UNSIGNALED STATE", (uint64_t)pFences[i]); 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_item->second.createInfo.flags = 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<VkFenceCreateFlags>(fence_item->second.createInfo.flags & ~VK_FENCE_CREATE_SIGNALED_BIT); 61715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->fenceMap[pFences[i]].in_use.load()) { 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 61775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 61785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", reinterpret_cast<const uint64_t &>(pFences[i])); 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6181b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 61825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 61835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 61845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 61895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6190b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(framebuffer); 61925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 61935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : fbNode->second.referencingCmdBuffers) { 61945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cbNode = dev_data->commandBufferMap.find(cb); 61955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cbNode != dev_data->commandBufferMap.end()) { 61965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set CB as invalid and record destroyed framebuffer 61975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->state = CB_INVALID; 61985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->destroyedFramebuffers.insert(framebuffer); 61995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6201f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes delete [] fbNode->second.createInfo.pAttachments; 6202f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes dev_data->frameBufferMap.erase(fbNode); 62035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6204b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 62095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 62105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 6212b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 621647892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 621747892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 62185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 621947892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 622047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6223b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 622594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->bufferMap[*pBuffer].createInfo = *pCreateInfo; 62265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap[*pBuffer].in_use.store(0); 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 62355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6236b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 62375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap[*pView] = VkBufferViewCreateInfo(*pCreateInfo); 623803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 62395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 62405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 62410a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_buffer_usage_flags(dev_data, pCreateInfo->buffer, 6242e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 62455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 624947892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 625047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 625247892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 625347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 62545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6256b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 62585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 62605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[*pImage].createInfo = *pCreateInfo; 62615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 62625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 62635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 62645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 6269b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 62705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 62745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 62755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 62775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->levelCount = image_node_it->second.createInfo.mipLevels - range->baseMipLevel; 62795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 62825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->layerCount = image_node_it->second.createInfo.arrayLayers - range->baseArrayLayer; 62835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 62885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 62895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 62905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 6291b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 62925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 62945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 62955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = image_node_it->second.createInfo.mipLevels - range.baseMipLevel; 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = image_node_it->second.createInfo.arrayLayers - range.baseArrayLayer; 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6311b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 63125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageViewCreateInfo localCI = VkImageViewCreateInfo(*pCreateInfo); 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &localCI.subresourceRange, pCreateInfo->image); 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap[*pView] = localCI; 631503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that img has correct usage flags set 63170a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_image_usage_flags(dev_data, pCreateInfo->image, 63185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 63195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 6320e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves false, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 63215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 63225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 63275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 63285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 63305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6331b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 63325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FENCE_NODE *pFN = &dev_data->fenceMap[*pFence]; 633303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 63345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pFN, 0, sizeof(MT_FENCE_INFO)); 63355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&(pFN->createInfo), pCreateInfo, sizeof(VkFenceCreateInfo)); 63365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 6337e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pFN->firstTimeFlag = true; 63385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 63405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFN->in_use.store(0); 63415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 63475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 63485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 63545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 63555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 63575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 63615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 63635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 63675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 63705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63733d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 63743d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 63753d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 63763d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 63773d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 63783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 63793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 63813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 63833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 63853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 63873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 63883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63903d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 63933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 63945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 63955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 63965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 63985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 63995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 64005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 64015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 64025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 64035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 6404e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 64065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6410b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 6413ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6414ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 64155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 64165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6418e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6419b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 64205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 64215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6422b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 64235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 64255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 64265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6427b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 64285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64305188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6432b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 64335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 6443e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 64465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 64475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6450b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 64535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6456ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 6457ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6464b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 64655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 64665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6467b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6472b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 64735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 64765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 64775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6478b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 64855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 64885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6489b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pNewNode = new LAYOUT_NODE; 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSetLayout, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 65065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()")) 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo)); 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->createInfo.pBindings = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount]; 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)pNewNode->createInfo.pBindings, pCreateInfo->pBindings, 65125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sizeof(VkDescriptorSetLayoutBinding) * pCreateInfo->bindingCount); 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // g++ does not like reserve with size 0 65145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->bindingCount) 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap.reserve(pCreateInfo->bindingCount); 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t totalCount = 0; 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 65185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pNewNode->bindingToIndexMap.emplace(pCreateInfo->pBindings[i].binding, i).second) { 65195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)*pSetLayout, __LINE__, 65215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LAYOUT, "DS", "duplicated binding number in " 65225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSetLayoutBinding")) 65235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap[pCreateInfo->pBindings[i].binding] = i; 65265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis totalCount += pCreateInfo->pBindings[i].descriptorCount; 65285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pBindings[i].pImmutableSamplers) { 65295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampler **ppIS = (VkSampler **)&pNewNode->createInfo.pBindings[i].pImmutableSamplers; 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppIS = new VkSampler[pCreateInfo->pBindings[i].descriptorCount]; 65315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(*ppIS, pCreateInfo->pBindings[i].pImmutableSamplers, 65325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pBindings[i].descriptorCount * sizeof(VkSampler)); 65339bd7be0cd7f78c2e94bfe5815c21fcafcf4c8526Tobin Ehlis pNewNode->immutableSamplerCount += pCreateInfo->pBindings[i].descriptorCount; 65345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->layout = *pSetLayout; 65375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->startIndex = 0; 65385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (totalCount > 0) { 65395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes.resize(totalCount); 65405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags.resize(totalCount); 65415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset = 0; 65425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t j = 0; 65435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorType dType; 65445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 65455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dType = pCreateInfo->pBindings[i].descriptorType; 65465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pCreateInfo->pBindings[i].descriptorCount; j++) { 65475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes[offset + j] = dType; 65485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags[offset + j] = pCreateInfo->pBindings[i].stageFlags; 65495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 65505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 65515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->dynamicDescriptorCount++; 65525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset += j; 65555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = pNewNode->startIndex + totalCount - 1; 65575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // no descriptors 65585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = 0; 65595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Put new node at Head of global Layer list 6561b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = pNewNode; 65635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validatePushConstantSize(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 65685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *caller_name) { 65695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 6570b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((offset + size) > dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize) { 65715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 65725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 65735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 6574b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis caller_name, offset, size, dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize); 65755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 65775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 65805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 65815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 65825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 65845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 65855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 65865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()"); 65875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pCreateInfo->pPushConstantRanges[i].size == 0) || ((pCreateInfo->pPushConstantRanges[i].size & 0x3) != 0)) { 65885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 65895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 65905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constant index %u with " 65915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "size %u. Size must be greater than zero and a multiple of 4.", 65925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCreateInfo->pPushConstantRanges[i].size); 65935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if ranges overlap 65955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 65975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6598b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 65995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge capture of the setLayouts per pipeline 66005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 66015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); 66025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 66035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; 66045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); 66065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 66075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; 66085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 66145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 66155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPool *pDescriptorPool) { 66165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 66185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 66195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 66205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 66215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool %#" PRIxLEAST64, 66225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 66235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 66255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 66265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 66275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 66285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 66295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6631b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 66325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 66335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 66365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 66415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 66425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 66445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6645b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 66465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 66475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 66525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 6653e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 66545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6656b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that requested descriptorSets are available in pool 66585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 66595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPoolNode) { 66605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 66615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 66625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 66635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool); 66645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Make sure pool has all the available descriptors before calling down chain 66655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->descriptorSetCount, 66665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->pSetLayouts); 66675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6668b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 66705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 66725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6673b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 66745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 66755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode) { 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pAllocateInfo->descriptorSetCount == 0) { 66775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 66785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->descriptorSetCount, __LINE__, DRAWSTATE_NONE, "DS", 66795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "AllocateDescriptorSets called with 0 count"); 66805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) { 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", "Created Descriptor Set %#" PRIxLEAST64, 66845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i]); 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new set node and add to head of pool nodes 66865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pNewNode = new SET_NODE; 66875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 66885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 66895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_OUT_OF_MEMORY, "DS", 6691ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()")) { 6692b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6694ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 66955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Pool should store a total count of each type of Descriptor available 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When descriptors are allocated, decrement the count and validate here 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that the count doesn't go below 0. One reset/free need to bump count back up. 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert set at head of Set LL for this pool 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pPoolNode->pSets; 67015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->in_use.store(0); 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->pSets = pNewNode; 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]); 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 67055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pAllocateInfo->pSetLayouts[i], 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " specified in vkAllocateDescriptorSets() call", 6710ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis (uint64_t)pAllocateInfo->pSetLayouts[i])) { 6711b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6713ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 67145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pLayout = pLayout; 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pool = pAllocateInfo->descriptorPool; 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->set = pDescriptorSets[i]; 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorCount = (pLayout->createInfo.bindingCount != 0) ? pLayout->endIndex + 1 : 0; 67195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pNewNode->descriptorCount) { 6720656b1a5d2165c66fd4af21d070243d387cd4ac56Karl Schultz pNewNode->pDescriptorUpdates.resize(pNewNode->descriptorCount); 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->setMap[pDescriptorSets[i]] = pNewNode; 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6726b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 6733e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6736b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6738ce62d9f596fa03529c4961ab715473a0e9254e0eMark Mueller skipCall |= validateIdleDescriptorSet(dev_data, pDescriptorSets[i], "vkFreeDescriptorSets"); 67395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool); 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) { 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can't Free from a NON_FREE pool 67425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 67435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 67445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 67455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 67465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6747b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6748e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 67495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 67505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 67515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6752b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6753a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6754a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Update available descriptor sets in pool 6755a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets += count; 6756a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6757a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // For each freed descriptor add it back into the pool as available 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 67595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking 67605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(dev_data, pSet); 67615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = pSet->pLayout; 67625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 67635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pLayout->createInfo.bindingCount; ++j) { 67645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 67655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 67665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount; 67675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6769b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any other clean-up or book-keeping to do here? 67725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 67775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 6778e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // dsUpdate will return true only if a bailout error occurs, so we want to call down tree when update returns false 67795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6780b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool rtn = dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies); 6782b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!rtn) { 67845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 67855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 67865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 67905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 67915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 67935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6794b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 679572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto const &cp_it = dev_data->commandPoolMap.find(pCreateInfo->commandPool); 679672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cp_it != dev_data->commandPoolMap.end()) { 679772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 679972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cp_it->second.commandBuffers.push_back(pCommandBuffer[i]); 68005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 68015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 68025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 68045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 68055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 68065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 680803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 68090a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 6811b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 6818e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6820b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 68225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 68255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 68265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = checkCBCompleted(dev_data, commandBuffer, &commandBufferComplete); 6827400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!commandBufferComplete) { 68305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 68325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Calling vkBeginCommandBuffer() on active CB %p before it has completed. " 68335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must check CB flag before this call.", 68345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis commandBuffer); 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 68375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 68385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 68405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must have inheritance info.", 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6847400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 68485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 68495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify a valid renderpass parameter.", 68525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6854400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 68555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, 68585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command Buffers (%p) may perform better if a " 68595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "valid framebuffer parameter is specified.", 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(pInfo->framebuffer); 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass fbRP = fbNode->second.createInfo.renderPass; 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, fbRP, pInfo->renderPass, errorString)) { 6867400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 68685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 68705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 68725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command " 68735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Buffer (%p) renderPass (%#" PRIxLEAST64 ") is incompatible w/ framebuffer " 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") w/ render pass (%#" PRIxLEAST64 ") due to: %s", 68755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer), (uint64_t)(pInfo->renderPass), 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->framebuffer), (uint64_t)(fbRP), errorString.c_str()); 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fbNode->second.referencingCmdBuffers.insert(pCB->commandBuffer); 68805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6884b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 68865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 68885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must not have " 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 68915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "support precise occlusion queries.", 68925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 68965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = dev_data->renderPassMap.find(pInfo->renderPass); 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != dev_data->renderPassMap.end() && rp_data->second && rp_data->second->pCreateInfo) { 68985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->subpass >= rp_data->second->pCreateInfo->subpassCount) { 68995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 69005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 69025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must has a subpass index (%d) " 69035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that is less than the number of subpasses (%d).", 69045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)commandBuffer, pInfo->subpass, rp_data->second->pCreateInfo->subpassCount); 69055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 69105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 69135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Cannot call Begin on CB (%#" PRIxLEAST64 69145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 69155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 69165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (CB_RECORDED == pCB->state) { 69175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 69185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 69195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 69225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Call to vkBeginCommandBuffer() on command buffer (%#" PRIxLEAST64 69235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") attempts to implicitly reset cmdBuffer created from command pool (%#" PRIxLEAST64 69245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 69285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 69305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 69315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 69335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 69345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 69355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 69395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void *)commandBuffer); 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6941b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6942e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) { 69435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 69445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6946400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer) { 6951e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6954b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 69585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()"); 69595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 69615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 69625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 69635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Ending command buffer with in progress query: queryPool %" PRIu64 ", index %d", 69645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(query.pool), query.index); 69655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6967e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6968b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 69695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 6970b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 69715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 69725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 69735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 69745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 69755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 69765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6980b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 69815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6986bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 69875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6988b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 69915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 6992bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6993bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6994bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis "Attempt to reset command buffer (%#" PRIxLEAST64 ") created from command pool (%#" PRIxLEAST64 6995bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 6996bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6998bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, pCB, "reset"); 6999b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7000bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 70015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 70025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 70035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 7004b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 70055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 7006b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 70075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 701093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 701103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : For any vkCmdBind* calls that include an object which has mem bound to it, 70135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// need to account for that mem now having binding to given commandBuffer 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 7017e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7019b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Incorrectly binding compute pipeline (%#" PRIxLEAST64 ") during active RenderPass (%#" PRIxLEAST64 ")", 70285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass); 70295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 703372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 70353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline); 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 70395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 70405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7043b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 70465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 7050e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7052b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 70585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 70595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7060b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7061e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 7067e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7069b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 70735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 70745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 70755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 70765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7077b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7078e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 70805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 7083e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7085b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 70895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 70905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7091b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7092e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 70945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 7098e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7100b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 71055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7106b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7107e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 71095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 71105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 7113e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7115b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 71193d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 71205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7121b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7122e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 71245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 7128e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7130b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 71345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 71355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7136b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7137e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 71395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 7143e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7145b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 71495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 71505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7151b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7152e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 71545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 7158e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7160b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 71645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 71655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7166b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7167e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 71695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 7173e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7175b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 71795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 71805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7181b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7182e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 71845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 71885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 71895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t *pDynamicOffsets) { 7190e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7192b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7196787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7197787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7198787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7199787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 720072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) 720172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 720272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 7203787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7204787f29d93dee194c015789cf61c079504c980572Tobin Ehlis SET_NODE *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7205787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 720672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pDescriptorSets[i]); 7207787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pSet->boundCmdBuffers.insert(commandBuffer); 720872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipelineLayout = layout; 720972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pDescriptorSets[i]; 7210787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 7211787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7212787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_NONE, "DS", "DS %#" PRIxLEAST64 " bound on pipeline %s", 7213787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7214787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!pSet->pUpdateStructs && (pSet->descriptorCount != 0)) { 7215787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 7216787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7217787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 7218787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "DS %#" PRIxLEAST64 7219787f29d93dee194c015789cf61c079504c980572Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 7220787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7221787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7222787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 7223787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, layout, i + firstSet, errorString)) { 7224787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7225787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7226787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 7227787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping layout in " 7228787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "pipelineLayout due to: %s", 7229787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, errorString.c_str()); 7230787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7231787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->dynamicDescriptorCount) { 7232787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7233787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if ((totalDynamicDescriptors + pSet->pLayout->dynamicDescriptorCount) > dynamicOffsetCount) { 7234787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= 7235787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7236787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7237787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7238787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u (%#" PRIxLEAST64 7239787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7240787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7241787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->pLayout->dynamicDescriptorCount, 7242787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7243787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7244787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7245787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7246787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t d = 0; d < pSet->descriptorCount; d++) { 7247787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7248787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7249787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7250b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 7251787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7252787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7253787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7254787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7255787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7256787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minUniformBufferOffsetAlignment %#" PRIxLEAST64, 7257787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7258b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 7259787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7260787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7261787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7262787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7263787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7264b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 7265787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7266787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7267787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7268787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7269787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7270787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minStorageBufferOffsetAlignment %#" PRIxLEAST64, 7271787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7272b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 72735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7274787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 72755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7277787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7278787f29d93dee194c015789cf61c079504c980572Tobin Ehlis totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount; 72795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7281787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 7282787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7283787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7284787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", 7285787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 72865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 728772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 728872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 728972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 729072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 729172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 729272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility( 729372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data, dev_data->setMap[pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i]], layout, i, 729472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis errorString)) { 729572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg( 729672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 729772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 729872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 729972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "DescriptorSetDS %#" PRIxLEAST64 730072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 730172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 730272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 730372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 730472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 730572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 730672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 730772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 730872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 730972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, 73105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorString)) { 731172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= 731272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 731372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)oldFinalBoundSet, __LINE__, 731472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis DRAWSTATE_NONE, "DS", "DescriptorSetDS %#" PRIxLEAST64 731572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u is incompatible with set %#" PRIxLEAST64 731672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 731772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 731872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)oldFinalBoundSet, lastSetIndex, 731972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 732072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 732172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 73225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7325787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7326787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 7327787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7328787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 7329787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7330787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 7331787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 7332787f29d93dee194c015789cf61c079504c980572Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7333787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7334787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Save dynamicOffsets bound to this CB 7335787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < dynamicOffsetCount; i++) { 7336e576798e0a38a7d941b6202d784ad705024e9fdcTobin Ehlis pCB->lastBound[pipelineBindPoint].dynamicOffsets.emplace_back(pDynamicOffsets[i]); 7337787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 73395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 73405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7342b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 73455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 73465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 73495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 7350e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7352b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 735303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 73545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 73560a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 735772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 735872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7359e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindIndexBuffer()"); }; 736072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 73615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 73635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 73645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 73675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 73685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 73695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 73705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 73715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 73735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 73745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 73765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 73775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 73805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 73815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 73825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 73835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkIndexType(indexType)); 73845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND; 73865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7387b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7388e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 73905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 73935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 73945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 73955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 73965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 73985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 73995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7402e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 74035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 74055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bindingCount, const VkBuffer *pBuffers, 74065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkDeviceSize *pOffsets) { 7407e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7409b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 741003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 74115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 74125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 74130a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)pBuffers[i], VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 741472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 741572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7416e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindVertexBuffers()"); }; 741772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 74185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 74215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 74225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 74255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTracking(pCB, firstBinding, bindingCount, pBuffers); 74265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 74275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 74285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7429b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7430e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 74325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7434b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 7435e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 74365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 74377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 74387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 74397a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto iv_data = dev_data->imageViewMap.find(imageView); 74407a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (iv_data == dev_data->imageViewMap.end()) 74415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 74427a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkImage image = iv_data->second.image; 74437a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 74447a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skip_call |= 74450a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7446e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7448e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74497a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 74507a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 74517a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 74527a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 74537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 74540a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skip_call |= get_mem_binding_from_object(dev_data, (uint64_t)buffer, 74557a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7456e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74577a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true); 7458e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74597a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 74607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 74615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 74635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 74665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstVertex, uint32_t firstInstance) { 7467e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7469b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 74735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 7474e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 74757a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 74785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 74795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++); 74805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7481e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 74825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 74855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7486b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7487e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 74895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 74925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 7496b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 75005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 7501e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 75027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 75045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 75055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7508e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 75095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 75105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7513b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7514e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 75205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7522e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 7523b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 752403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 75265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 75275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75280a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 75295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndirect"); 75305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDIRECT]++; 7535e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 75367a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 75385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 75395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7542e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); 75465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7547b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7548e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 75505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 75535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 7554e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7556b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 755703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 75595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndexedIndirect"); 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 75675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED_INDIRECT]++; 7568e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 75697a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", 75745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7576e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 75785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7581b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7582e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 7587e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7589b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75927a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Re-enable validate_and_update_draw_state() when it supports compute shaders 7593e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 75947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 75957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 75967a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 75995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7600b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7601e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 76025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 76035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 7607e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 76085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7609b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 761003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 76115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 76125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 76130a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 76145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDispatchIndirect"); 76155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 76187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Re-enable validate_and_update_draw_state() when it supports compute shaders 7619e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 76207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 76217a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 76227a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 76235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 76245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7626b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7627e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 76295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferCopy *pRegions) { 7633e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 76345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7635b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 763603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 76375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 763872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 76400a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 764172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7642e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBuffer()"); }; 764372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 76445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 76470a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 764872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7649e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 76505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7651e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 76525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 765372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 76545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 76570a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 76590a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer"); 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7667b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7668e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 76695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 76705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7672e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageSubresourceLayers subLayers, 7673e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout srcImageLayout) { 7674e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 76775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 76785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 76805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 76815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 76825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, srcImage, sub, node)) { 768308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 76845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 76855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 76875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 76885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 76995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 77005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 77015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 77025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 77045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 77055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 77065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 77095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageSubresourceLayers subLayers, 7712e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout destImageLayout) { 7713e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 77145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 77165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 77175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 77185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 77205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 77215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, destImage, sub, node)) { 772208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 77235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 77245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 77265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 77285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 77305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 77315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 77345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 77365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 77385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 77395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 77405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 77425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 77475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 77505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 77515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 7752e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7754b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 775503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 775772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 77585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 77590a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 776072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7761e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImage()", srcImage); }; 776272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 77655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 77660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 776772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7768e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 77695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7770e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 777272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 77750a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 77770a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE, "vkCmdCopyImage()"); 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage"); 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].srcSubresource, srcImageLayout); 77865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].dstSubresource, dstImageLayout); 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7789b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7790e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 77965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 77975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 7798e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7800b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 780103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 780372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 78050a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 780672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7807e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBlitImage()", srcImage); }; 780872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 78115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78120a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 781372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7814e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 781872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 78210a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 78225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 78230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 78245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE, "vkCmdBlitImage()"); 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage"); 78305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7831b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7832e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 78345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 78385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage dstImage, VkImageLayout dstImageLayout, 78395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7840e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7842b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 784303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 784572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78460a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 784772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7848e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7850e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 785272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 78555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78560a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 785772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7858e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBufferToImage()"); }; 785972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 78625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src buff & dst image have correct usage flags set 78630a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 78645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 78650a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 78665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 78675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 78715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage"); 78725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 78735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].imageSubresource, dstImageLayout); 78745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7876b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7877e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 78795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 78805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 78835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout srcImageLayout, VkBuffer dstBuffer, 78845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7885e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7887b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 788803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 789072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78910a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 789272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7893e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7894e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImageToBuffer()", srcImage); 7895e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 789672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 78995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79000a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 790172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7902e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 79035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7904e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 790672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 79095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff & src image have correct usage flags set 79100a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 79115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 79120a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 79145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 79185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer"); 79195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 79205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].imageSubresource, srcImageLayout); 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7923b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7924e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 79265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 79275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 79305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 7931e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7933b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 793403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 79355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 793672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 79375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 79380a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 793972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7940e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 79415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7942e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 794472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdUpdateBuffer"); 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 79480a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 79545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer"); 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7956b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7957e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 7963e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7965b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 796603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 796872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 79695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 79700a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 797172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7972e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 79735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7974e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 797672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdFillBuffer"); 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 79800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 79815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdFillBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 79825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 79865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer"); 79875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7988b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7989e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *pAttachments, uint32_t rectCount, 79955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearRect *pRects) { 7996e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7998b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 80055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 80065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 80075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 80085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 80105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 80125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 80135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 80145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandBuffer)); 80155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); 80175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 80205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 80225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 80235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 80255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 80265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 8027e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 80285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 8030e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8034e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 80355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 80365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 80375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 80385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 80405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 80425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 80435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 80445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 80455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 80475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 80485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 80505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 80515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 80525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 80535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 80545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8058b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8059e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 80615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 80645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout, const VkClearColorValue *pColor, 80655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 8066e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8068b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 806903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 80715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 807272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 807472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8075e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 8077e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 807972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearColorImage"); 80825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 80865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage"); 80875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8088b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8089e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 80915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 80945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 80955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 80965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange *pRanges) { 8097e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8099b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 810003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 81015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 81025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 810372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 81040a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 810572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8106e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 81075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 8108e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 81095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 811072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 81115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearDepthStencilImage"); 81135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 81145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 81175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage"); 81185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8119b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8120e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 81225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 81235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 81265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 81275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 8128e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8130b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 813103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 813272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 81335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 81340a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 813572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8136e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdResolveImage()", srcImage); }; 813772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 81385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 81405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 81410a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 814272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8143e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 81445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 8145e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 81465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 814772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 81485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 81505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 81515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 81545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage"); 81555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8156b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8157e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 81605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8162b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8163b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8164b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8165b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8166b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8167b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8168b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8169b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8170b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8171b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8172b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8173b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8174b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 81755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 81765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8177e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8179b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 81835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 81845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8185b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8186b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8187b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 81885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8189b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8190e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 81925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 81955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8196e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8198b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 82005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 82015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 82025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 82035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8204b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8205b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8206b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 82075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8208b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8209e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 82105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 82115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8213e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8214e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 82155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 82165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 8217e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 82185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 82195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 82205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 82235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 82245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 82255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 82285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 82305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 82315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 82325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 82335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 82345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 823608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 823708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 82385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 82395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 82415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 82425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 82435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 82445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 82455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 82495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 82535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 8256e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 82585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 82595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 82625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 82645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 82675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 82685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 82715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 82765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 82775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 8278e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8279e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 8280e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 8281e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 82825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & !(required_bit | optional_bits)) { 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 82865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 82905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 82936044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 82955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 82975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 82985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 82995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 83005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 83015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 83035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 83045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 83055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83066044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 83085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 83095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 83105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 83115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8317e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8318e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 8319e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 83205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 83215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 83225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 83285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 83325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 83335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 83365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 83375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 83405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 83415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 83425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 83465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 83515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 83655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8369e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8370e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 8371e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 8372e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 8373e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 83745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 83755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 83765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) { 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 83805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 83815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 83855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 83895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data->second.createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 83915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 83925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 83935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 83945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 83975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 83985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 84005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 84035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 84055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 84105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 8415b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 8416b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 84175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 84185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 84195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 84205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 84215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 84225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 84235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 8424b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 84255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 84305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 84325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 84345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 84355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 84375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 84385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 84395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 84411d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 84421d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 84435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 84445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 84455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = image_data->second.createInfo.format; 84465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = image_data->second.createInfo.arrayLayers; 84475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = image_data->second.createInfo.mipLevels; 84485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imageswap_data = dev_data->device_extensions.imageToSwapchainMap.find(mem_barrier->image); 84515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageswap_data != dev_data->device_extensions.imageToSwapchainMap.end()) { 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(imageswap_data->second); 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = swapchain_data->second->createInfo.imageFormat; 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = swapchain_data->second->createInfo.imageArrayLayers; 84565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 84575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 84585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 84635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 84645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 84655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 84675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 84685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 84695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 84705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8471f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 8472f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8473f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 8474f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 84755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 84775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 84785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 84795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 84805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 84815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8482f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 8483f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8484f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 8485f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 84865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 84895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 84975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 84995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 85025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 85075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8508b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8510b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 85115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 85135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 85145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 85155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 8516b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 85175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = dev_data->bufferMap.find(mem_barrier->buffer); 852094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceSize buffer_size = (buffer_data->second.createInfo.sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO) 852194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis ? buffer_data->second.createInfo.size 852294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : 0; 85235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != dev_data->bufferMap.end()) { 85245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 852594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 852694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 852794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 852894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 " which is not less than total size %" PRIu64 ".", 852994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 853094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 853294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 853394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 853494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 " and size %" PRIu64 853594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis " whose sum is greater than total size %" PRIu64 ".", 853694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 853794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 853894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85452ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 8546b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 8547b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 8548b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 8549b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 85502ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 8551b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8552b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 8553b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 85542ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 8555b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 8556b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 8557b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 85582ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto global_event_data = dev_data->eventMap.find(event); 8559b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (global_event_data == dev_data->eventMap.end()) { 8560b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 856127c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 856227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 85632ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 8564b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 8565b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= global_event_data->second.stageMask; 8566b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8567b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8568b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8569b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (sourceStageMask != stageMask) { 8570b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= 8571b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 857227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes DRAWSTATE_INVALID_EVENT, "DS", 8573b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "Submitting cmdbuffer with call to VkCmdWaitEvents using srcStageMask 0x%x which must be the bitwise OR of the " 8574b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "stageMask parameters used in calls to vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if used with vkSetEvent.", 8575b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine sourceStageMask); 8576b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8577b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 8578b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8579b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 85825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 85835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 8585e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8587b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 85885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85902ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 85925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.push_back(pEvents[i]); 85935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 85945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8595b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 85962ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 8597b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 85985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 86025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 86045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 86065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8608b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8609e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 86135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 86175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 86185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 8620e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8622b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 86285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 86295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 86305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8631b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8632e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 8640e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8642b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 86475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 86495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 86515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8652b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8653e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 86555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 8658e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8660b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 86655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool %" PRIu64 ", index %d", 86685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 86715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 86735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 86755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 86775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8679b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8680e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 86825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 8686e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8688b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 86925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 86935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 86945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 0; 86955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 86985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 87005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 87025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8703b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8704e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 87055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 87065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 87095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 87105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 8711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 87125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8713b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 87145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 871503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 87165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 871772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 87185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 87190a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 872072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8721e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 87225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 8723e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 87245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 872572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 87265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyQueryPoolResults"); 87285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that DST buffer has correct usage flags set 87290a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 87305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 87315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 87325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 87345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 87355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->queryToStateMap[query]) { 87365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 87385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Requesting a copy from query to buffer with invalid query: queryPool %" PRIu64 ", index %d", 87395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 87405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 87435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 87445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 87465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8749b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8750e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 87535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 87565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const void *pValues) { 87585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8760b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 87615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8769b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((offset + size) > dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize) { 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, offset, size, "vkCmdPushConstants()"); 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if push constant update doesn't align with range 8773b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 87745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 87755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 8780e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8782b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 87865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 87895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8793b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8794e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 87955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 87965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 87995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 88005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer *pFramebuffer) { 88015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 88025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 88035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 88045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 8805b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 8806fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes 8807fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto & fbNode = dev_data->frameBufferMap[*pFramebuffer]; 8808fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo = *pCreateInfo; 88095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 8810fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto attachments = new VkImageView[pCreateInfo->attachmentCount]; 8811fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes memcpy(attachments, 8812fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->pAttachments, 8813fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->attachmentCount * sizeof(VkImageView)); 8814fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo.pAttachments = attachments; 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data = dev_data->imageViewMap.find(view); 88195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data == dev_data->imageViewMap.end()) { 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 88230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(view_data->second.image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 88245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis &fb_info.mem); 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_info.image = view_data->second.image; 8826fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.attachments.push_back(fb_info); 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 88305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8832e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 8833e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 8836e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 88375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 88395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 8843e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8846e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8848e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8851e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 8852e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 8853e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 88555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 88561d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 88575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 88595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 88615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error. 88645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) { 88673da84689683bb257cc0f64953966666d19321119Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but only an implicit one is specified.", 88705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass, dependent_subpasses[k]); 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 88725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 88735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 88745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 88755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 8876e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 88775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8883e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 8884e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 88855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 88865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 88875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 88885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 88895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 8890e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 8894e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8896e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 8904e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 89065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 8907e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8911e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 89165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 89195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 89275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 89285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 89295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8931e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateDependencies(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin, 8932e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node) { 8933e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 89345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pCreateInfo = my_data->renderPassMap.at(pRenderPassBegin->renderPass)->pCreateInfo; 89365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 89435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 89445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 89455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 89475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_i = my_data->imageViewMap.find(viewi); 89505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_j = my_data->imageViewMap.find(viewj); 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i == my_data->imageViewMap.end() || view_data_j == my_data->imageViewMap.end()) { 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i->second.image == view_data_j->second.image && 89555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRegionOverlapping(view_data_i->second.subresourceRange, view_data_j->second.subresourceRange)) { 89565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 89585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_i = my_data->imageMap.find(view_data_i->second.image); 89615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_j = my_data->imageMap.find(view_data_j->second.image); 89625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i == my_data->imageMap.end() || image_data_j == my_data->imageMap.end()) { 89635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i->second.mem == image_data_j->second.mem && 89665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(image_data_i->second.memOffset, image_data_i->second.memSize, image_data_j->second.memOffset, 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_data_j->second.memSize)) { 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 89695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 89705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 89745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 89755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 89765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 89775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 89805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 89815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 89825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 89845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 89875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 89885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 89895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 89931c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 89945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89961c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 89975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 89995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 90005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 90015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 90025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 90095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90101c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 90115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 90135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 90145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 90155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 90175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90181c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 90191c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 90201c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 90211c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 90221c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 90231c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 90241c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 90251c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 90295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 90335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pInputAttachments[j].attachment; 90345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 90385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pColorAttachments[j].attachment; 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 90445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 90525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 90535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 90545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9059e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 9060e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 90725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90734d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 90765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 90775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 90815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 90825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 90835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 90855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 90875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90884d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 90915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 90925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 90965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 90975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 90985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 91005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 91015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 91025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 91035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 91044d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 91065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 91075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 91085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 91135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9115e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 9116e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 9117e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 91185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 91195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 91205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 91215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 91235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 91245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 91255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 91265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 91285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 91295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 91305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 91325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 91335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 91345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 91365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 91375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 91395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 91405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9144918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 91455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 91475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 91485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderModule *pShaderModule) { 91495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9150e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 91515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!shader_is_spirv(pCreateInfo)) { 91525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* dev */ 0, __LINE__, SHADER_CHECKER_NON_SPIRV_SHADER, "SC", "Shader is not SPIR-V"); 91545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9156e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 91575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 91605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 9162b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 9163918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 91665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 91695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 91705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass *pRenderPass) { 9171e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9173b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 91745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create DAG 91755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 91765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 91775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 91785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate 91795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 9180e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) { 9181b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 91825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 91835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9184b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 91855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 9187b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 91885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge in tracking of renderpass from shader_checker 91895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 91905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 91915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 91925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 91935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 91945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 91955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 91975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 91985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 91995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 92015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 92025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 92035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 92045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 92055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 92065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 92085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 92095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 92125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 92135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 92145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 92165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 92175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 92185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 92195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 92225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 92235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 92245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 92255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 92285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 92295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 92325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 92335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 92345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 92355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE(localRPCI); 92375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency; 92385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->subpassToNode = subpass_to_node; 923987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 924087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 924187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 924287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 924387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 924487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 924587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 924687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 924787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachments.push_back(pass_info); 924887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 924987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 925087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, bool> &attachment_first_read = dev_data->renderPassMap[*pRenderPass]->attachment_first_read; 925187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = 925287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachment_first_layout; 925387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 925487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 9255b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 9256b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 9257b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9258b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine "Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 9259b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine } 92600d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 92610d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment = subpass.pPreserveAttachments[j]; 92620d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount) { 92630d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 92640d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 92650d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Preserve attachment %d cannot be greater than the total number of attachments %d.", 92660d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 92670d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 92680d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 926987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 92700d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment; 92710d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (subpass.pResolveAttachments) { 92720d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pResolveAttachments[j].attachment; 92730d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount && attachment != VK_ATTACHMENT_UNUSED) { 92740d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 92750d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 92760d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 92770d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 92780d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine continue; 92790d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 92800d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 92810d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pColorAttachments[j].attachment; 928224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 928324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 928424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 928524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 928624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 928724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 928824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 928987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 929087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 929187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 929287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 929387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 929487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 929587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 929624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 929724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 929824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 929924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Depth stencil attachment %d cannot be greater than the total number of attachments %d.", 930024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 930124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 930224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 930387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 930487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 930587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 930687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 930787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 9308a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 9309a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 931024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 931124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 931224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 931324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Input attachment %d cannot be greater than the total number of attachments %d.", 931424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 931524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 931624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 9317a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine if (attachment_first_read.count(attachment)) 9318a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine continue; 9319a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_read.insert(std::make_pair(attachment, true)); 9320a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 9321a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 932287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 932387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 9324b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.size() <= 0) 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->renderPassMap.begin(); ii != my_data->renderPassMap.end(); ++ii) { 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = (*ii).second->pCreateInfo; 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 93375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 93425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 93435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9358e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 9359e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer].createInfo; 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 93675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 93685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 93715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageViewMap.find(image_view); 93725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_data != dev_data->imageViewMap.end()); 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_data->second.image; 93745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->second.subresourceRange; 93755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 93765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 93785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 93795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 93805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 93815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 93825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 93835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 93855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 93875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (newNode.layout != node.layout) { 93895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using attachment %i " 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "where the " 9393d6c1882c31a88ae01b94f3135679f739287be31aKarl Schultz "initial layout is %s and the layout of the attachment at the " 93941c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine "start of the render pass is %s. The layouts must match.", 93951c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 93965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9403e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, 9404e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 94055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 94065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 94075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 94085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 94095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 94105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 94125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 94135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 94145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 94155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 94175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pRenderPassInfo->pSubpasses[subpass_index]; 94185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 94195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pInputAttachments[j].attachment]; 94205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pInputAttachments[j].layout); 94215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 94235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pColorAttachments[j].attachment]; 94245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pColorAttachments[j].layout); 94255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 94275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pDepthStencilAttachment->attachment]; 94285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pDepthStencilAttachment->layout); 94295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9432e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 9433e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 94345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 94355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 94385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9442e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 94435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 94445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 94455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 94465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 94475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 94485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 94505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 94515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 94525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 94535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 94555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 94565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 94575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 94585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9461e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 9462885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 9463885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 9464885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 9465885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 9466885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 9467885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 9468885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 9469885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9470885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 9471885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 9472885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 9473885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 9474885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 9475885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 9476885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 9477885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 9478885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 9479885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 94815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 9482e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 94855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 94865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassBegin && pRenderPassBegin->renderPass) { 948887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGE 948987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 949087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 949187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 949287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->fb = pRenderPassBegin->framebuffer; 949372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 949487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 949587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 949687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_CLEAR) { 949772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9498e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 9500e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 95015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 950272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 950487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkImageLayout &attachment_layout = pRPNode->attachment_first_layout[pRPNode->attachments[i].attachment]; 95055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL || 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 95095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, (uint64_t)(pRenderPassBegin->renderPass), __LINE__, 95105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_LAYOUT, "MEM", "Cannot clear attachment %d with invalid first layout %d.", 951187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->attachments[i].attachment, attachment_layout); 95125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 951387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_DONT_CARE) { 951472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9515e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 95165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 9517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 95185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 951972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 952187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_LOAD) { 952272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9523e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 95255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 952672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 952987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachment_first_read[pRPNode->attachments[i].attachment]) { 953072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9531e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 95325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 953472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 9540e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin); 95425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 95435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data != dev_data->renderPassMap.end()) { 95445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateDependencies(dev_data, pRenderPassBegin, render_pass_data->second->subpassToNode); 95455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 95475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 95485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 95495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = pRenderPassBegin->renderPass; 95505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 95515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 95525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 95535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 955493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.insert(pRenderPassBegin->framebuffer); 95555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 955693c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski dev_data->frameBufferMap[pRenderPassBegin->framebuffer].referencingCmdBuffers.insert(pCB->commandBuffer); 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 95585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 95595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 95615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9563b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9564e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 95655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 95665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 9570e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9572b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 95755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 95765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 95775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 95785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 95795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 958072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline) { 958172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, 958272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 95835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 95855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9586b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9587e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 95885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 95895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer) { 9592e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9594b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 959503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 959672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 959772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 959887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(cb_data->second->activeRenderPass); 959987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 960087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 960187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 960287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 960387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_STORE) { 960472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9605e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 96065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 9607e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 96085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 960972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 96105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 961187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_DONT_CARE) { 961272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9613e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 96145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 9615e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 96165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 961772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 96185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 96245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 96255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 96265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 96275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 96285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo); 96305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 96315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 96325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9633b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9634e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 96355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 96365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9638e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 9639e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkRenderPass primaryPass, uint32_t primaryAttach, uint32_t secondaryAttach, 9640e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *msg) { 96415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 96435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 96445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 964581264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom "Attachment %" PRIu32 " is not compatible with %" PRIu32 ". %s", 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass), primaryAttach, secondaryAttach, 96475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis msg); 96485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9650e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9651e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t primaryAttach, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 9652e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 96545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 96555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 96565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->attachmentCount <= primaryAttach) { 96575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 96585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data->second->pCreateInfo->attachmentCount <= secondaryAttach) { 96605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 96615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 96635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The first is unused while the second is not."); 96685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 96715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The second is unused while the first is not."); 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].format != 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].format) { 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different formats."); 96795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].samples != 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].samples) { 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different samples."); 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (is_multi && 96865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_data->second->pCreateInfo->pAttachments[primaryAttach].flags != 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].flags) { 96885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different flags."); 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9694e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9695e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, const int subpass, 9696e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool is_multi) { 96975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 96985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 96995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 97005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &primary_desc = primary_data->second->pCreateInfo->pSubpasses[subpass]; 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &secondary_desc = secondary_data->second->pCreateInfo->pSubpasses[subpass]; 97025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 97035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 97045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 97055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 97105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_input_attach, secondaryBuffer, 97125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_input_attach, is_multi); 97135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 97155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 97165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 97175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 97185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 97215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_color_attach, secondaryBuffer, 97245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_color_attach, is_multi); 97255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 97265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_resolve_attach, secondaryBuffer, 97335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_resolve_attach, is_multi); 97345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 97375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 97385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 97405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 97415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_depthstencil_attach, secondaryBuffer, 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_depthstencil_attach, is_multi); 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9747e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9748e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass) { 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early exit if renderPass objects are identical (and therefore compatible) 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryPass == secondaryPass) 97525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 97545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data == dev_data->renderPassMap.end() || primary_data->second == nullptr) { 97565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid current Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 97605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)primaryBuffer, (uint64_t)(primaryPass)); 97615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data == dev_data->renderPassMap.end() || secondary_data->second == nullptr) { 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 97685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass)); 97695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->subpassCount != secondary_data->second->pCreateInfo->subpassCount) { 97725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 97755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 97765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "They have a different number of subpasses.", 97775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass)); 97785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_multi = primary_data->second->pCreateInfo->subpassCount > 1; 97815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < primary_data->second->pCreateInfo->subpassCount; ++i) { 97825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis validateSubpassCompatibility(dev_data, primaryBuffer, primaryPass, secondaryBuffer, secondaryPass, i, is_multi); 97845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9788e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 9789e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 97905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 97915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 979493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski VkFramebuffer primary_fb = dev_data->renderPassMap[pCB->activeRenderPass]->fb; 97955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 97965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a framebuffer %" PRIx64 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current framebuffer %" PRIx64 ".", 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fb_data = dev_data->frameBufferMap.find(secondary_fb); 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fb_data == dev_data->frameBufferMap.end()) { 98065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 98095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid framebuffer %" PRIx64 ".", 98105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb_data->second.createInfo.renderPass, 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryBuffer, pSubCB->beginInfo.pInheritanceInfo->renderPass); 98155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9819e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 98205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 98215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 98235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 98285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 98295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 ". Pipeline statistics is being queried so the command " 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 98365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 98395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 "of type %d but a query of that type has been started on " 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "secondary Cmd Buffer %p.", 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 98515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 98525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 98555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 9859e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9861b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 98645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 98655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 98665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 98675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", 98725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 98735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 98745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers " 98775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 98785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 98795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 98805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) executed within render pass (%#" PRIxLEAST64 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass); 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 98885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass, pCommandBuffers[i], 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass); 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 98945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, pCB->activeRenderPass, 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass, errorString)) { 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 98995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) w/ render pass (%#" PRIxLEAST64 99005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") is incompatible w/ primary command buffer (%p) w/ render pass (%#" PRIxLEAST64 ") due to: %s", 99015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 99025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass, errorString.c_str()); 99035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 99055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 99065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 99075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 99085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 99095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 99115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) references framebuffer (%#" PRIxLEAST64 99125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does not match framebuffer (%#" PRIxLEAST64 ") in active renderpass (%#" PRIxLEAST64 ").", 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass); 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 99195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 99205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pSubCB); 99215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 99225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 99235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 99245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 99255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 99265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 99285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to simultaneously execute CB %#" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 99295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 99305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 99315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 99335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 99345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 99355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 99375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%#" PRIxLEAST64 99385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 99395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 99405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, even though it does.", 99415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 99425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 99435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9945b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") cannot be submitted with a query in " 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 99565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 99585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 99605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 99615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9962b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9963e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 99645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 99655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9967e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 9968e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 997058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto mem_data = dev_data->memObjMap.find(mem); 997158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if ((mem_data != dev_data->memObjMap.end()) && (mem_data->second.image != VK_NULL_HANDLE)) { 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 997358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (FindLayouts(dev_data, mem_data->second.image, layouts)) { 99745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 99765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 99775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 99785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 99795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 99855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 99885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9991e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9993b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 999403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 999558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 99965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 99975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 9998b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & 9999b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 100005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 100015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 100025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 100035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj %#" PRIxLEAST64, (uint64_t)mem); 100045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 100075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis storeMemRanges(dev_data, mem, offset, size); 100085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 1000958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 10010b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 100115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10012e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 100135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 1001403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 10015b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 100165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 10017b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 100185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 100195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1002303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 100245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUnmapMemory(VkDevice device, VkDeviceMemory mem) { 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10026e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10028b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= deleteMemRanges(my_data, mem); 10030b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 10031e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 100325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 100335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10036e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 10037e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 10038e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 100405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 100425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.offset > pMemRanges[i].offset) { 100435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 100445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 100455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 100465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 100475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 100485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_element->second.memRange.offset)); 100495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_element->second.memRange.size != VK_WHOLE_SIZE) && 100515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((mem_element->second.memRange.offset + mem_element->second.memRange.size) < 100525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pMemRanges[i].offset + pMemRanges[i].size))) { 100535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 100555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 100565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") exceeds the Memory Object's upper-bound " 100575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 100585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 100595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<size_t>(mem_element->second.memRange.offset + mem_element->second.memRange.size)); 100605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 100645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10066e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 10067e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 10068e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 100705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 100715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 100725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 100735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize size = mem_element->second.memRange.size; 100745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 100755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char *data = static_cast<char *>(mem_element->second.pData); 100765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 100775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 100785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 100805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 100815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 100825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 100855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 100865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 100885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 100895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 100905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(mem_element->second.pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 100935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 100975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 101005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 101015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10102e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 101035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 101045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10105b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 101065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 101075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 10108b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 10109e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 101105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 101115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 101165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 101175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10118e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 101195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 101205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10121b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 101225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 10123b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 10124e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 101255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 101265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 101305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 101325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 101335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10134e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 10135b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1013694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 1013794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 1013894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1013909df2b6afd74a6494aa530ba23a80ba69abc79dfDustin Graves uint64_t image_handle = reinterpret_cast<uint64_t&>(image); 1014094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 101415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 10142b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1014394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 10144b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1014558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, image_handle, mem, memoryOffset, memRequirements, 1014658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].imageRanges, dev_data->memObjMap[mem].bufferRanges, 1014758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 101480a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10149b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1015094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!skipCall) { 1015194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 10152b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1015394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->memObjMap[mem].image = image; 1015494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.mem = mem; 1015594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memOffset = memoryOffset; 1015694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memSize = memRequirements.size; 10157b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1015894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1015994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1016094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1016194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 1016294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis "vkBindImageMemory: Cannot find invalid image %" PRIx64 ", has it already been deleted?", 1016394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 101645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkSetEvent(VkDevice device, VkEvent event) { 101693ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 101703ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 101715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10172b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 101733ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis auto event_node = dev_data->eventMap.find(event); 101743ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node != dev_data->eventMap.end()) { 101753ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.needsSignaled = false; 101763ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.stageMask = VK_PIPELINE_STAGE_HOST_BIT; 101773ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node->second.in_use.load()) { 101783ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 101793ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 101803ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis "Cannot call vkSetEvent() on event %" PRIxLEAST64 " that is already in use by a command buffer.", 101813ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 101823ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 101833ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 10184b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 101856fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 101866fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 101876fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 101886fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 101896fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 101906fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 101916fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 101926fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101936fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101943ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 101953ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 101965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 102005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 102015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 102025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10203e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10204b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 102054b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 102064b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis if ((fence != VK_NULL_HANDLE) && (bindInfoCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 102074b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 1020847c4ec0c3856ae594e26241bf6796785a2150cbfMark Lobodzinski reinterpret_cast<uint64_t &>(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 1020947c4ec0c3856ae594e26241bf6796785a2150cbfMark Lobodzinski "Fence %#" PRIx64 " is already in use by another submission.", reinterpret_cast<uint64_t &>(fence)); 102104b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 102114b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis uint64_t fenceId = 0; 102124b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis skip_call = add_fence_info(dev_data, fence, queue, &fenceId); 102131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 102141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 102155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 102161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 102171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 102181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 102191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 102205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10221e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 102225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 102251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 102261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 102271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 102285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10229e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 102305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 102331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 102341344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 102351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 102365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10237e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 102385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 102411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pWaitSemaphores[i]; 102421344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 102431344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 102441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 102451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 102461344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 102475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 102481344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 102491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "vkQueueBindSparse: Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 102501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 102511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 102525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 102561344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pSignalSemaphores[i]; 102571344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 102581344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 102595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 102605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 102611344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 102621344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "vkQueueBindSparse: Queue %#" PRIx64 " is signaling semaphore %#" PRIx64 102631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 102641344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 102655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102661344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 102675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102700a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10271b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 102725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10273e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 102745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 102755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 102805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 102815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 102835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 10284b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 102861344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 102870a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 102885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 102895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 102945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 102955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 102975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 10298b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 103005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 103015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 103025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 103075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 103085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR *pSwapchain) { 103095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 103105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 103115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 103130801763633180d277d26a90343464bd11646056fTobin Ehlis SWAPCHAIN_NODE *psc_node = new SWAPCHAIN_NODE(pCreateInfo); 10314b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 103150801763633180d277d26a90343464bd11646056fTobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = psc_node; 103165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 103225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 103235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 103245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 103255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10326b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 103275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain); 103285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 103295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data->second->images.size() > 0) { 103305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto swapchain_image : swapchain_data->second->images) { 103315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 103325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 103335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 103345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 103355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 103365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 103375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 103405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103410a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, (uint64_t)swapchain_image, 103420801763633180d277d26a90343464bd11646056fTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1034394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 103445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete swapchain_data->second; 103475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 103485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10349b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 103505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 103515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 103525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 103555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 103565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 103575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 103585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 103605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 103615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 103625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 10363b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 103645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 103650801763633180d277d26a90343464bd11646056fTobin Ehlis auto swapchain_node = dev_data->device_extensions.swapchainMap[swapchain]; 103660801763633180d277d26a90343464bd11646056fTobin Ehlis if (!swapchain_node->images.empty()) { 103670801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 103680801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 103690801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 103705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 103715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 103725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 103735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 103745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkGetSwapchainInfoKHR(%" PRIu64 103755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 103765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 103775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 103805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 103815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 103825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 1038394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 1038494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.mipLevels = 1; 1038594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 1038694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.usage = swapchain_node->createInfo.imageUsage; 1038794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.valid = false; 1038894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 103895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 103905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 103915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 103925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 103935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 103945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 104005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 104015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 104025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 104035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPresentInfo) { 10405b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 104065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 104071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = pPresentInfo->pWaitSemaphores[i]; 104081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 104091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 104101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 104111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 104121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 104131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 104141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 104151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 104161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 104171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104200801763633180d277d26a90343464bd11646056fTobin Ehlis VkDeviceMemory mem; 104215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 104225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]); 104235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && 104245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) { 104255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]]; 1042603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 104270801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= 104280a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 104290801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= validate_memory_is_valid(dev_data, mem, "vkQueuePresentKHR()", image); 1043003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 104315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkImageLayout> layouts; 104325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindLayouts(dev_data, image, layouts)) { 104335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 104345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 104355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 104365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 104375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 104385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 104395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 104405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 104415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 104495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 104501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 104555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 104565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 104575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 104585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 104591344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 10460b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 104611657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak if (semaphore != VK_NULL_HANDLE && 104621657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 104631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 104645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 104651344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 104665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 104675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 104695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = dev_data->fenceMap.find(fence); 104715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data != dev_data->fenceMap.end()) { 104725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.swapchain = swapchain; 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10474b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 104751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) { 104775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 104795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 104855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 104865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 104875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 104885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 104895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 104905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 10491b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 104925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis res = layer_create_msg_callback(my_data->report_data, pCreateInfo, pAllocator, pMsgCallback); 104935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 104955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, 104985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT msgCallback, 104995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator) { 105005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 105015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 105025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10503b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 105045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 105055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 105085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 105095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 105105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 105115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 105125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 105135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 105165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 105175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 105185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 105195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 105205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueSubmit")) 105215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueSubmit; 105225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkWaitForFences")) 105235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkWaitForFences; 105245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetFenceStatus")) 105255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetFenceStatus; 105265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueWaitIdle")) 105275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueWaitIdle; 105285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDeviceWaitIdle")) 105295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDeviceWaitIdle; 105305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceQueue")) 105315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceQueue; 105325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 105335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 105345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 105355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 105365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFence")) 105375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFence; 105385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetFences")) 105395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetFences; 105405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySemaphore")) 105415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySemaphore; 105425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyEvent")) 105435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyEvent; 105445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyQueryPool")) 105455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyQueryPool; 105465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBuffer")) 105475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBuffer; 105485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBufferView")) 105495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBufferView; 105505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImage")) 105515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImage; 105525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImageView")) 105535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImageView; 105545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyShaderModule")) 105555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyShaderModule; 105565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipeline")) 105575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipeline; 105585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipelineLayout")) 105595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineLayout; 105605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySampler")) 105615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySampler; 105625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorSetLayout")) 105635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorSetLayout; 105645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorPool")) 105655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorPool; 105665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFramebuffer")) 105675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFramebuffer; 105685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyRenderPass")) 105695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyRenderPass; 105705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBuffer")) 105715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBuffer; 105725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBufferView")) 105735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBufferView; 105745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImage")) 105755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImage; 105765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImageView")) 105775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImageView; 105785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFence")) 105795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFence; 105805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "CreatePipelineCache")) 105815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineCache; 105825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "DestroyPipelineCache")) 105835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineCache; 105845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "GetPipelineCacheData")) 105855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetPipelineCacheData; 105865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "MergePipelineCaches")) 105875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMergePipelineCaches; 105885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateGraphicsPipelines")) 105895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateGraphicsPipelines; 105905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateComputePipelines")) 105915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateComputePipelines; 105925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSampler")) 105935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSampler; 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorSetLayout")) 105955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorSetLayout; 105965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreatePipelineLayout")) 105975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineLayout; 105985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorPool")) 105995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorPool; 106005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetDescriptorPool")) 106015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetDescriptorPool; 106025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateDescriptorSets")) 106035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateDescriptorSets; 106045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeDescriptorSets")) 106055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeDescriptorSets; 106065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUpdateDescriptorSets")) 106075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUpdateDescriptorSets; 106085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateCommandPool")) 106095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateCommandPool; 106105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyCommandPool")) 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyCommandPool; 106125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandPool")) 106135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandPool; 106145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateQueryPool")) 106155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateQueryPool; 106165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateCommandBuffers")) 106175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateCommandBuffers; 106185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeCommandBuffers")) 106195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeCommandBuffers; 106205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBeginCommandBuffer")) 106215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBeginCommandBuffer; 106225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEndCommandBuffer")) 106235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEndCommandBuffer; 106245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandBuffer")) 106255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandBuffer; 106265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindPipeline")) 106275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindPipeline; 106285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetViewport")) 106295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetViewport; 106305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetScissor")) 106315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetScissor; 106325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetLineWidth")) 106335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetLineWidth; 106345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBias")) 106355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBias; 106365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetBlendConstants")) 106375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetBlendConstants; 106385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBounds")) 106395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBounds; 106405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilCompareMask")) 106415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilCompareMask; 106425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilWriteMask")) 106435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilWriteMask; 106445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilReference")) 106455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilReference; 106465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindDescriptorSets")) 106475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindDescriptorSets; 106485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindVertexBuffers")) 106495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindVertexBuffers; 106505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindIndexBuffer")) 106515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindIndexBuffer; 106525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDraw")) 106535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDraw; 106545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexed")) 106555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexed; 106565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndirect")) 106575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndirect; 106585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexedIndirect")) 106595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexedIndirect; 106605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatch")) 106615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatch; 106625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatchIndirect")) 106635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatchIndirect; 106645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBuffer")) 106655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBuffer; 106665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImage")) 106675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImage; 106685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBlitImage")) 106695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBlitImage; 106705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBufferToImage")) 106715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBufferToImage; 106725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImageToBuffer")) 106735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImageToBuffer; 106745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdUpdateBuffer")) 106755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdUpdateBuffer; 106765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdFillBuffer")) 106775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdFillBuffer; 106785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearColorImage")) 106795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearColorImage; 106805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearDepthStencilImage")) 106815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearDepthStencilImage; 106825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearAttachments")) 106835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearAttachments; 106845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResolveImage")) 106855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResolveImage; 106865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetEvent")) 106875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetEvent; 106885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetEvent")) 106895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetEvent; 106905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWaitEvents")) 106915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWaitEvents; 106925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPipelineBarrier")) 106935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPipelineBarrier; 106945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginQuery")) 106955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginQuery; 106965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndQuery")) 106975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndQuery; 106985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetQueryPool")) 106995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetQueryPool; 107005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyQueryPoolResults")) 107015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyQueryPoolResults; 107025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPushConstants")) 107035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPushConstants; 107045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWriteTimestamp")) 107055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWriteTimestamp; 107065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFramebuffer")) 107075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFramebuffer; 107085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateShaderModule")) 107095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateShaderModule; 107105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateRenderPass")) 107115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateRenderPass; 107125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginRenderPass")) 107135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginRenderPass; 107145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdNextSubpass")) 107155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdNextSubpass; 107165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndRenderPass")) 107175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndRenderPass; 107185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdExecuteCommands")) 107195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdExecuteCommands; 107205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkSetEvent")) 107215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkSetEvent; 107225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkMapMemory")) 107235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMapMemory; 1072403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 107255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUnmapMemory")) 107265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUnmapMemory; 107275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateMemory")) 107285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateMemory; 107295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeMemory")) 107305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeMemory; 107315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFlushMappedMemoryRanges")) 107325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFlushMappedMemoryRanges; 107335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkInvalidateMappedMemoryRanges")) 107345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkInvalidateMappedMemoryRanges; 107355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindBufferMemory")) 107365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindBufferMemory; 107375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetBufferMemoryRequirements")) 107385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetBufferMemoryRequirements; 107395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetImageMemoryRequirements")) 107405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetImageMemoryRequirements; 107415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 107425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetQueryPoolResults")) 107435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetQueryPoolResults; 107445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindImageMemory")) 107455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindImageMemory; 107465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueBindSparse")) 107475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueBindSparse; 107485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSemaphore")) 107495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSemaphore; 107505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateEvent")) 107515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateEvent; 107525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev == NULL) 107545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 107575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 107585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->device_extensions.wsi_enabled) { 107605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSwapchainKHR")) 107615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSwapchainKHR; 107625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySwapchainKHR")) 107635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySwapchainKHR; 107645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetSwapchainImagesKHR")) 107655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetSwapchainImagesKHR; 107665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAcquireNextImageKHR")) 107675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAcquireNextImageKHR; 107685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueuePresentKHR")) 107695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueuePresentKHR; 107705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 107735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 107745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 107755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 107775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 107815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetInstanceProcAddr")) 107825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetInstanceProcAddr; 107835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 107845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 107855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateInstance")) 107865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateInstance; 107875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDevice")) 107885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDevice; 107895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 107905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 107915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties")) 107925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceLayerProperties; 107935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties")) 107945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceExtensionProperties; 107955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties")) 107965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceLayerProperties; 107975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties")) 107985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceExtensionProperties; 107995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (instance == NULL) 108015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 108025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkVoidFunction fptr; 108045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 108065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 108075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 108085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fptr) 108095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return fptr; 108105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 108125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 108135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 108145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 108155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10816