core_validation.cpp revision e4be8c69231df45752686575f22168b6d0fc5687
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 61b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) printf(__VA_ARGS__) 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 71414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 72d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 73d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 80b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track command pools and their command buffers 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct CMD_POOL_INFO { 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPoolCreateFlags createFlags; 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queueFamilyIndex; 855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool 865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 89e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE *> swapchainMap; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 9956a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu VkInstance instance; 10056a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 10594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 107b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski unordered_set<VkQueue> queues; // all queues under given device 1085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 111cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> samplerMap; 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImageView, VkImageViewCreateInfo> imageViewMap; 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, IMAGE_NODE> imageMap; 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBufferView, VkBufferViewCreateInfo> bufferViewMap; 1155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBuffer, BUFFER_NODE> bufferMap; 1165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap; 1185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 119397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 120cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 12258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis unordered_map<VkDeviceMemory, DEVICE_MEM_INFO> memObjMap; 1235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 12972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFramebuffer, FRAMEBUFFER_NODE> frameBufferMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 134918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1356c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 138b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 139b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 140b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 14294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), device_extensions(), 143a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis device(VK_NULL_HANDLE), phys_dev_properties{}, phys_dev_mem_props{} {}; 1445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 146b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 147b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 148b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 149e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 150f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 151e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 156e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 162e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 176b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 177b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 178b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 179b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 180b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 181b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 183b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 184b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 185b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 186b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 187b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 188b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 1925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 1945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 247b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 24803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 24903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - start of direct pull 25094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 25394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->imageMap.find(VkImage(handle)); 25494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->imageMap.end()) 25594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 25994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->bufferMap.find(VkBuffer(handle)); 26094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->bufferMap.end()) 26194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 2655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 2685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - end section 2705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 2715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 2735121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 27472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 27503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 2765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 2775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 2785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 2795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 2800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 2810a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 2820a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 283e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 284e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 2855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 2865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 2875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 2885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 2895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 2905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 291414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 2925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 2935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 2945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 2965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for images 2995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls image info and then sends actual vs. desired usage off to helper above where 3005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3010a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_image_usage_flags(layer_data *dev_data, VkImage image, VkFlags desired, VkBool32 strict, 30294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 303e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 30494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 30594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 3060a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, image_node->second.createInfo.usage, desired, strict, (uint64_t)image, 3075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "image", func_name, usage_string); 3085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 3135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls buffer info and then sends actual vs. desired usage off to helper above where 3145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3150a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_buffer_usage_flags(layer_data *dev_data, VkBuffer buffer, VkFlags desired, VkBool32 strict, 31694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 317e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 31894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const buffer_node = dev_data->bufferMap.find(buffer); 31994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 3200a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, buffer_node->second.createInfo.usage, desired, strict, (uint64_t)buffer, 3215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "buffer", func_name, usage_string); 3225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 3275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 32858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic DEVICE_MEM_INFO *get_mem_obj_info(layer_data *dev_data, const VkDeviceMemory mem) { 32958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto item = dev_data->memObjMap.find(mem); 33058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (item != dev_data->memObjMap.end()) { 3315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return &(*item).second; 3325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 3345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 3385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 3395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 3405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&my_data->memObjMap[mem].allocInfo, pAllocateInfo, sizeof(VkMemoryAllocateInfo)); 3425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Update for real hardware, actually process allocation info structures 3435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].allocInfo.pNext = NULL; 3445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].object = object; 3455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].mem = mem; 34658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis my_data->memObjMap[mem].image = VK_NULL_HANDLE; 3475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.offset = 0; 3485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.size = 0; 3495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pData = 0; 3505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pDriverData = 0; 3515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].valid = false; 3525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 354e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 355e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImage image = VK_NULL_HANDLE) { 3565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 35794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 35894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end() && !image_node->second.valid) { 35958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 3605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 361414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 3625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 3635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 3665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 36758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 3685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 369414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid memory 0x%" PRIx64 ", please fill the memory before using.", functionName, 3705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 3715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 3745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 3775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 37894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 37994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 38094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.valid = valid; 3815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 3915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 392e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 393e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 394e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 3975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 3985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 40058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 4015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 402de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemInfo->commandBufferBindings.insert(cb); 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 40472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 40672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 407c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 4085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 413400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 414400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 41572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 416c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 417c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 41820b3e28d96ae4f3cbd4535e53eb68521d31bb91bChris Forbes DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 420400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis pInfo->commandBufferBindings.erase(pCBNode->commandBuffer); 4215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 423c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 4245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 4265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 428400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 429400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 430400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 434e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 435e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 436de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes size_t cmdBufRefCount = pMemObjInfo->commandBufferBindings.size(); 437896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes size_t objRefCount = pMemObjInfo->objBindings.size(); 4385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 439de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if ((pMemObjInfo->commandBufferBindings.size()) != 0) { 44058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 442414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempting to free memory object 0x%" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 4435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " references", 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 4455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 447de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (cmdBufRefCount > 0 && pMemObjInfo->commandBufferBindings.size() > 0) { 448de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pMemObjInfo->commandBufferBindings) { 44958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 450de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 451414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%p still has a reference to mem obj 0x%" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 4525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 454de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemObjInfo->commandBufferBindings.clear(); 4555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 457896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (objRefCount > 0 && pMemObjInfo->objBindings.size() > 0) { 458896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pMemObjInfo->objBindings) { 459896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 460414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, 461896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 4625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 464896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemObjInfo->objBindings.clear(); 4655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemObjInfo(layer_data *my_data, void *object, VkDeviceMemory mem) { 470e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = my_data->memObjMap.find(mem); 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != my_data->memObjMap.end()) { 4735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap.erase(item); 4745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 477414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Request to delete memory object 0x%" PRIxLEAST64 " not present in memory Object Map", (uint64_t)mem); 4785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 482e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 483e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 48558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 4865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 4875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize == 0 && !internal) { 4885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section 48958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 491414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempting to free memory associated with a Persistent Image, 0x%" PRIxLEAST64 ", " 4925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this should not be explicitly freed\n", 4935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem); 4945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear any CB bindings for completed CBs 4965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is there a better place to do this? 4975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(pInfo->object != VK_NULL_HANDLE); 499de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // clear_cmd_buf_and_mem_references removes elements from 500de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // pInfo->commandBufferBindings -- this copy not needed in c++14, 501de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // and probably not needed in practice in c++11 502de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes auto bindings = pInfo->commandBufferBindings; 503de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : bindings) { 504a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 505de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 5065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify that no references to this mem obj remain and remove bindings 510de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() || pInfo->objBindings.size()) { 51158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= reportMemReferencesAndCleanUp(dev_data, pInfo); 5125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete mem obj info 51458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= deleteMemObjInfo(dev_data, object, mem); 5155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 5215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 5225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 5235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 5245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 5255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 5265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 5275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 5285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 5295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 5305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 5345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 535c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 5365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 5370a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 5385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 539e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 54094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 54194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 54294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = get_mem_obj_info(dev_data, *pMemBinding); 5435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 54494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 5455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 546c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 548896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (!pMemObjInfo->objBindings.erase({handle, type})) { 5495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 55058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 551414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 552414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 5535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 5545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 5615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 5625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 5635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 5645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 56594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 56694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 567e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 57158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 572414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 5735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 57594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 5765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 57758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, 578414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "In %s, attempting to update Binding of %s Obj(0x%" PRIxLEAST64 ") that's not in global list", 5795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), apiName, handle); 5805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // non-null case so should have real mem obj 58258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 5835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 58494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = get_mem_obj_info(dev_data, *pMemBinding); 5855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPrevBinding != NULL) { 5865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 58758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 589414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 590414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") which has already been bound to mem object 0x%" PRIxLEAST64, 5915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 5925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 593896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemInfo->objBindings.insert({handle, type}); 5945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For image objects, make sure default memory state is correctly set 5955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What's the best/correct way to handle this? 5965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 59794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(VkImage(handle)); 59894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 59994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkImageCreateInfo ici = image_node->second.createInfo; 60094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 60194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // TODO:: More memory state transition stuff. 60294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 6035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 6065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 6145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 6155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 6165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 6175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 6180a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 6190a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 6200a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 6210a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes bool skipCall = VK_FALSE; 6225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6240a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, handle, type); 6255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 62794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 6285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 62958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, "MEM", 630414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "In %s, attempting to update Binding of Obj(0x%" PRIxLEAST64 ") that's not in global list()", apiName, handle); 63194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 63294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // non-null case so should have real mem obj 63394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 63494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pInfo) { 63594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis pInfo->objBindings.insert({handle, type}); 63694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Need to set mem binding for this object 63794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 63894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 6395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given Object, get 'mem' obj that it's bound to or NULL if no binding 6450a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool get_mem_binding_from_object(layer_data *dev_data, const uint64_t handle, 64694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis const VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 647e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 64994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 65094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 65194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *mem = *pMemBinding; 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 654414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Trying to get mem binding for object 0x%" PRIxLEAST64 " but no such object in %s list", handle, 6555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type)); 6565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 6610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 66258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 6635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 66558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 6665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 6675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 67058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 6715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 67258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 67358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 6745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 6755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 6775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 6805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 6815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 683414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)pInfo); 68458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 685414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(pInfo->mem)); 68658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 687c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 688de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size() + pInfo->objBindings.size()); 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (0 != pInfo->allocInfo.allocationSize) { 6905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&pInfo->allocInfo, "MEM(INFO): "); 69158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 6935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 6965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 700896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pInfo->objBindings.size()); 701896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (pInfo->objBindings.size() > 0) { 702896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pInfo->objBindings) { 70358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 704414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 7055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 7105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 711de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size()); 712de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() > 0) { 713de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pInfo->commandBufferBindings) { 71458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 715414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB 0x%p", cb); 7165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7210a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 72272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 7235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 73072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 73172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 7325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 7345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 7365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 73972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 742414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has CB 0x%p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 744c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 7455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 746c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 7475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 748414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 7495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 7545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 7565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 7575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 7595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 7605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 7615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 7635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 7645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 7655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 7665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 7675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 7685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 7695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 7705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 7715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 7735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 7745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 7755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 7775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 7785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 7795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 7805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 7815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 7825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 7835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 7845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 7855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 7865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 7875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 7885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 7915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 7925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 7935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 7945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 7955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 7965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 7975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 7985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 7995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 8005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 8025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 8035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 8045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 8055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 8075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 8085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 8095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 8115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 8125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 8135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 8145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 8155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 8165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 8175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 8195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 8225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 8265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 8305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 8335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 8425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 8445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 8455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 8485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 8575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 8845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 8855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 8935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 9799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 9859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 9869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 9889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 9899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 9919ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 9929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 9949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 9959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 9969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 9989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 9999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 10029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 10039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10069ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 10079ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 10089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 10109ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 10129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 10139ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 10149ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 10159ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 10169ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 10179ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10199ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 10229ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 10239ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 10259ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 10269ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10279ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 10299ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 10309ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10329ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 10339ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10379ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10389ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 10399ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 10409ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 10419ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 10429ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 10439ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10449ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 104537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 104637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 104737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 104837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 104937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 105037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 105137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 105237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 105337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10607c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 106137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 10627c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 10637c755c8aca6857046df9516d8336416165969cb9Chris Forbes 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 106637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 106737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 106837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 106937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 107037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10777c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 10787c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 107937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 10807c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 10817c755c8aca6857046df9516d8336416165969cb9Chris Forbes 10827c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 10837c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 10847c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 10857c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 10867c755c8aca6857046df9516d8336416165969cb9Chris Forbes 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10897c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 10927c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 10935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 10957c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 10965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 109737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 109837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 109937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 110037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 110137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 110237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 110337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 110437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 110537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 110737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 110837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 111337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 112337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 11475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 11485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 11495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 11555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 11595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 11605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 11635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1164cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1165cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1166cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1167cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1168cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1169cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1170cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1171cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1172cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 11785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1182c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1183c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1184c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1185c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1186c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1187c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1188c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1189c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1190c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1191c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1192c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1193c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1194c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1195c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 12005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1203b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1204fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 12055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 12065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1208031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1209031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1210031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1211031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1212031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1213031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1214031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1215031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1216031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1217031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1218031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1219031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1220031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1221031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 12305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 12315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1238edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1241b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1243031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 12475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 12505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 12525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 12535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 12555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 12585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 12595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 12655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 12675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 12685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 12715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 12735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 12745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 12765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 12775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 12785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 12795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 12805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1281b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1282fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 12835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 12845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1290edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_location(shader_module const *src, spirv_inst_iter entrypoint, 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1297b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 12985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 13025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 13065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1320b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1321b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1322b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1323b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 132981264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1334c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13451d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1352b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 13605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 13657c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 13695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1371b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1372fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 1377edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_block_members(src, out, blocks, is_array_of_verts, id, type, is_patch); 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1383edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_descriptor_slot(debug_report_data *report_data, shader_module const *src, 13845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<descriptor_slot_t, interface_var> &out) { 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto existing_it = out.find(std::make_pair(set, binding)); 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (existing_it != out.end()) { 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* conflict within spv image */ 1417edef66e03ed509994449d598f4fadea1a487d41bChris Forbes log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis insn.word(2), insn.word(1), storage_class_name(insn.word(3)), existing_it->first.first, 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis existing_it->first.second); 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1427b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1428b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1429fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(set, binding)] = v; 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1435edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1436031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1438031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1444edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, outputs, producer_stage->arrayed_output); 1445edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, inputs, consumer_stage->arrayed_input); 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1458edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1459080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1460031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1461031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1466edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1468031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1469031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1474fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1475fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1476fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1477fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 14780f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1479fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1480fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 148137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1482edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 14849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 14859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 14869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14900f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1491edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 14920f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1493f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 14940f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 14950f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 14960f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 14970f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 14980f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 14990f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 153131c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 153231c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 153331c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 153431c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1537f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 15445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 15455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 15465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 15525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 155331c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 155431c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 155531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 155631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 15585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1559f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 15605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 15615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 15725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 15825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 15835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1597edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1608edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1621edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 16225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1626edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, inputs, false); 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1631c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1632c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1633c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1634c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1635c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1636c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 1648edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1649080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1655edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1667edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 16709ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 16719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1685edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoint, RENDER_PASS_NODE const *rp, uint32_t subpass) { 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 1688025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 1689025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes for (auto i = 0u; i < rp->subpassColorFormats[subpass].size(); i++) { 1690025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (rp->subpassColorFormats[subpass][i] != VK_FORMAT_UNDEFINED) { 1691025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes color_attachments[i] = rp->subpassColorFormats[subpass][i]; 1692025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1693025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1694025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 16985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1699edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, outputs, false); 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1701025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 1702025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1704025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 1705025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 1706025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 1707025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 1708025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1710025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 1711edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1713025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "FS writes to output location %d with no matching attachment", it_a->first.first)) { 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1716025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1717025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 1718edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1719025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", it_b->first)) { 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1722025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1724025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 1725025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1729edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1731025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "Attachment %d of type `%s` does not match FS output type of `%s`", it_b->first, 1732025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 1733025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 17345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 1739025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1740025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 17525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 176781264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 17705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 18305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 1847c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 1853c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1864edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &range : *pushConstantRanges) { 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 1890edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1891080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 1904edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1905080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1919edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, shader_module const *src, 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 19265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 1927edef66e03ed509994449d598f4fadea1a487d41bChris Forbes pass &= validate_push_constant_block_against_pipeline(report_data, pushConstantRanges, src, 1928080afef66a53dbdd085698b713697296458edfd9Chris Forbes src->get_def(def_insn.word(1)), stage); 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1935fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 1936fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 19374110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE *pipelineLayout, descriptor_slot_t slot) { 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 194037083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 194278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (slot.first >= pipelineLayout->descriptorSetLayouts.size()) 194337083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1945f54d085ac836f3b0a2b62f6b401f759e586f0ea7Chris Forbes return pipelineLayout->setLayouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1957e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 1960e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1962e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 1966e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 1967e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 19683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 19693d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 19703d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 1971414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1973e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 1977ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic PIPELINE_NODE *getPipeline(layer_data const *my_data, const VkPipeline pipeline) { 1978ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 1979ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 1980ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1982ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 19835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1985e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 1986e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 1990e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1993e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 1997e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 1998e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 19993d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 20003d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 20013d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 20023d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 2003ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2004ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2005ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 20063d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 20083d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 200945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 201045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 20113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 20133d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20143d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 20153d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20163d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 20173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 201845824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 201945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 20203d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 20223d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 202345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 202445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 20253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20263d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 20273d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 20293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20303d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 20313d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20323d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 20333d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20343d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 20363d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If both AttachmentReference arrays have requested index, check their corresponding AttachementDescriptions 20435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 20485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 20495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 205006e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 205106e963555b0df747c98c43816c16647349d21001Mark Young return true; 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 205306e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 205406e963555b0df747c98c43816c16647349d21001Mark Young return true; 20555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // format and sample count must match 20565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 20575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 20585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 20595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 20615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 20635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 20645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give primary and secondary RenderPass objects, verify that they're compatible 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_renderpass_compatibility(layer_data *my_data, const VkRenderPass primaryRP, const VkRenderPass secondaryRP, 20685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string &errorMsg) { 20695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.find(primaryRP) == my_data->renderPassMap.end()) { 2070c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 20715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << primaryRP << ")"; 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (my_data->renderPassMap.find(secondaryRP) == my_data->renderPassMap.end()) { 2075c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << secondaryRP << ")"; 20775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 20785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Trivial pass case is exact same RP 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRP == secondaryRP) { 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *primaryRPCI = my_data->renderPassMap[primaryRP]->pCreateInfo; 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI = my_data->renderPassMap[secondaryRP]->pCreateInfo; 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2087c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 20895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 20945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 20985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 21005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2103c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 21095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2111c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2117fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2118fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2119fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2120fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2121fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2122c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2123fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2124fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2125fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2126fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2127fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2135c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2145397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2146397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2147397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 2148397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis const VkPipelineLayout layout, const uint32_t layoutIndex, string &errorMsg) { 2149ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes auto pipeline_layout_it = my_data->pipelineLayoutMap.find(layout); 2150ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (pipeline_layout_it == my_data->pipelineLayoutMap.end()) { 2151c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkPipelineLayout (" << layout << ")"; 21535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2156ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (layoutIndex >= pipeline_layout_it->second.descriptorSetLayouts.size()) { 2157c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2158ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes errorStr << "VkPipelineLayout (" << layout << ") only contains " << pipeline_layout_it->second.descriptorSetLayouts.size() 2159ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes << " setLayouts corresponding to sets 0-" << pipeline_layout_it->second.descriptorSetLayouts.size() - 1 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << ", but you're attempting to bind set to index " << layoutIndex; 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2164fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis auto layout_node = my_data->descriptorSetLayoutMap[pipeline_layout_it->second.descriptorSetLayouts[layoutIndex]]; 2165397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2169edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2170e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2177edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 21785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 21795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 21805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 21815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 21825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 21835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2185e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 21865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2194edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 21951b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 21965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21981b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 21991b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 22007b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 22017b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 22025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 22037b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 22047b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 22057b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 22067b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22077b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 22087b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 22097b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 22145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 22175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 22315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER; 22325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 223435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 223535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 223635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 223735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 223835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 223935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 224035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 224135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 224235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 224335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 22495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 22505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 22605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 22615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 22625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 22645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; 22655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 22665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 22715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 22725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 22735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22784110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2279a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 22804110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2281080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2282a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2283a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2284a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2285a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2286a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2287a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2288a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2289a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2290a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2291a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 229269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 229369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2294e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2295a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2296a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2297a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2298a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2299a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2300a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2301a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2302a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2303a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2304a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2305a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2306a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2307a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2308a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2309a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2310a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2311a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2312a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 23134110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2314a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2315a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2316a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 23174110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2318a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2319a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2320a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 23214110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2322a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2323a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2324a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 23254110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2326a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2327a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2328a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2329a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 23304110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2331a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2332a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2333a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2334a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 23354110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2336a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2337a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2338a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 23394110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2340a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2341a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2342a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 23434110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2344a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2345a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2346a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2347a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 23484110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2349a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2350a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2351a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2352a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 23534110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2354a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2355a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2356a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2357a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 23584110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2359a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2360a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2361a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2362a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 23634110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2364a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2365a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2366a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 23674110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2368a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2369a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2370a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 23714110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2372a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2373a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2374a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 23754110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2376a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2377a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2378a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 23794110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2380a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2381a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2382a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 23834110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2384a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2385a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2386a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 23874110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2388a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2389a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2390a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 23914110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2392a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2393a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2394a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 23954110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2396a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2397a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2398a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2399a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 24004110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2401a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2402a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2403a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 24044110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2405a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2406a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2407a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2408a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 24094110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2410a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2411a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2412a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2413a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 24144110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2415a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2416a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2417a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 24184110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2419a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2420a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2421a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2422e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2423a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2424a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2425a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2426a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2427a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2428a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2429a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2430a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2431ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbesstatic bool validate_pipeline_shader_stage(debug_report_data *report_data, 2432ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes VkPipelineShaderStageCreateInfo const *pStage, 2433ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes PIPELINE_NODE *pipeline, 2434ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes shader_module **out_module, 2435ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes spirv_inst_iter *out_entrypoint, 243669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 2437ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unordered_map<VkShaderModule, 2438ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unique_ptr<shader_module>> const &shaderModuleMap) { 2439e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 244069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 244169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 2442557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_specialization_offsets(report_data, pStage); 244378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 244478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 244578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 244678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2447557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2448080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 244978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 245078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2451e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 245278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 245378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 245478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 245578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2456557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 245778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 245878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 245978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 246078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 246178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 246278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 246378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::map<descriptor_slot_t, interface_var> descriptor_uses; 2464557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes collect_interface_by_descriptor_slot(report_data, module, accessible_ids, descriptor_uses); 246578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2466ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes auto pipelineLayout = pipeline->pipelineLayout; 2467ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 246878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 2469557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_push_constant_usage(report_data, &pipelineLayout->pushConstantRanges, 247078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes module, accessible_ids, pStage->stage); 247178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 247278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 247378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 247478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 247578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 247678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2477fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 24784110a6be7a8a287d459475926985f71c27d01298Chris Forbes const auto & binding = get_descriptor_binding(pipelineLayout, use.first); 247978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 248078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 248178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2482557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2483080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 248478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 248578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2486e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 248778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 248878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2489557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 249078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 249178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 249278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 249378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2494fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 249578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2496e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 249778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2498edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2499fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2500557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2501fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2502fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2503fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2504fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 250578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2506e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 250778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 250878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2509557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2510fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 251178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 251278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2513fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2514e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 251578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 251678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 251778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 251878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 251978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 252078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 252178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 252278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2523a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2524a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2525e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_NODE *pPipeline, 252669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 252769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 25286660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 25295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 25305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 25315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 25335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 25345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 25355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 25365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2537e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 25385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 25406660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 254178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2542e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 254369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 254469f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 25455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 25485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2550e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 25515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2554e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 25555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 25585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 25595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 25615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 25625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 25635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 25665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 25675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2568e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2569031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2570031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 25715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 25735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25767c7400aa231c3dbb21e51158adebb83d5f528130Chris Forbes if (shaders[fragment_stage] && pPipeline->renderPass) { 2577e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 25787c7400aa231c3dbb21e51158adebb83d5f528130Chris Forbes pPipeline->renderPass, pCreateInfo->subpass); 25795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 25825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2584e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_NODE *pPipeline, VkPhysicalDeviceFeatures const *enabledFeatures, 258569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 25866660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 258703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 258803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 258903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 259003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 2591e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 259269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 259303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 259403857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 25955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 2596397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic cvdescriptorset::DescriptorSet *getSetNode(layer_data *my_data, const VkDescriptorSet set) { 25975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->setMap.find(set) == my_data->setMap.end()) { 25985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 25995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->setMap[set]; 26015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 26037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 26047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 26057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 26067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 26077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 26087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2609e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 26107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 2611397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis const vector<std::pair<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>>> &activeSetBindingsPairs) { 2612e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 2613a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2614397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *set_node = set_bindings_pair.first; 2615cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 2616397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!set_node->ValidateDrawState(set_bindings_pair.second, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].dynamicOffsets, 2617397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 2618cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 2619397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 2620cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2621cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2622414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " encountered the following validation error at draw time: %s", 2623cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), err_str.c_str()); 2624cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 2625397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis set_node->GetStorageUpdates(set_bindings_pair.second, &pCB->updateBuffers, &pCB->updateImages); 26265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 26285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26297a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// TODO : This is a temp function that naively updates bound storage images and buffers based on which descriptor sets are bound. 2630cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis// When validate_and_update_draw_state() handles compute shaders so that active_slots is correct for compute pipelines, this 26317a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// function can be killed and validate_and_update_draw_state() used instead 26327a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlisstatic void update_shader_storage_images_and_buffers(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 2633397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = nullptr; 26347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For the bound descriptor sets, pull off any storage images and buffers 26357a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // This may be more than are actually updated depending on which are active, but for now this is a stop-gap for compute 26367a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // pipelines 26377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto set : pCB->lastBound[VK_PIPELINE_BIND_POINT_COMPUTE].uniqueBoundSets) { 26387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Get the set node 26397a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pSet = getSetNode(dev_data, set); 2640397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis pSet->GetAllStorageUpdates(&pCB->updateBuffers, &pCB->updateImages); 26417a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 26427a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis} 26435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2644eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 2645ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic VkSampleCountFlagBits getNumSamples(PIPELINE_NODE const *pipe) { 2646ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 2647ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 2648eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 2649eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2650eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 2651eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2652eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2653eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 2654ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic bool validatePipelineDrawtimeState(layer_data const *my_data, const GLOBAL_CB_NODE *pCB, 2655ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes const VkPipelineBindPoint pipelineBindPoint, PIPELINE_NODE const *pPipeline) { 2656eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 2657eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { 2658eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Verify that any MSAA request in PSO matches sample# in bound FB 2659eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Skip the check if rasterization is disabled. 2660eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young if (!pPipeline->graphicsPipelineCI.pRasterizationState || 2661eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 2662ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 2663eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young if (pCB->activeRenderPass) { 2664ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes const VkRenderPassCreateInfo *render_pass_info = pCB->activeRenderPass->pCreateInfo; 2665eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 2666ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VkSampleCountFlagBits subpass_num_samples = VkSampleCountFlagBits(0); 2667eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young uint32_t i; 2668eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2669eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young const VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 2670eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 2671eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 2672eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young skip_call |= 2673eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2674ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 2675eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 2676414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 2677eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 2678eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 2679ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 2680eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2681eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2682eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 2683eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young VkSampleCountFlagBits samples; 2684eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2685eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young if (subpass_desc->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) 2686eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young continue; 2687eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2688eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young samples = render_pass_info->pAttachments[subpass_desc->pColorAttachments[i].attachment].samples; 2689eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young if (subpass_num_samples == static_cast<VkSampleCountFlagBits>(0)) { 2690eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young subpass_num_samples = samples; 2691eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } else if (subpass_num_samples != samples) { 2692eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young subpass_num_samples = static_cast<VkSampleCountFlagBits>(-1); 2693eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young break; 2694eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2695eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2696eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young if ((subpass_desc->pDepthStencilAttachment != NULL) && 2697eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young (subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 2698eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young const VkSampleCountFlagBits samples = 2699eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young render_pass_info->pAttachments[subpass_desc->pDepthStencilAttachment->attachment].samples; 2700eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young if (subpass_num_samples == static_cast<VkSampleCountFlagBits>(0)) 2701eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young subpass_num_samples = samples; 2702eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young else if (subpass_num_samples != samples) 2703eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young subpass_num_samples = static_cast<VkSampleCountFlagBits>(-1); 2704eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2705eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2706eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young if (((subpass_desc->colorAttachmentCount > 0) || (subpass_desc->pDepthStencilAttachment != NULL)) && 2707eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young (pso_num_samples != subpass_num_samples)) { 2708eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young skip_call |= 2709eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2710ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 2711414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 2712414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 2713ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 2714ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 2715eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2716eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } else { 2717eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2718ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 2719414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 2720ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 2721eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2722eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2723eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // TODO : Add more checks here 2724eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } else { 2725eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // TODO : Validate non-gfx pipeline updates 2726eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2727eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 2728eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2729eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 27305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 2731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, const bool indexedDraw, 2732e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipelineBindPoint bindPoint) { 2733e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 27347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto const &state = pCB->lastBound[bindPoint]; 27357a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, state.pipeline); 273622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 273722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 273822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 273922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 274022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 274122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 274222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 274322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 274422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 27453d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 27467a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 27477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 274822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis else { 274922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // First block of code below to validate active sets should eventually 275022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // work for the compute case but currently doesn't so return early for now 275122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // TODO : When active sets in compute shaders are correctly parsed, 275222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // stop returning early here and handle them in top block below 275322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return result; 275422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 27557a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 27565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 275722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // TODO : When Compute shaders are properly parsed, fix this section to validate them as well 275822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (state.pipelineLayout) { 275922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 276022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2761397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis vector<std::pair<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>>> activeSetBindingsPairs; 276222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis for (auto setBindingPair : pPipe->active_slots) { 276322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 276422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 276522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 276622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 276722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 2768414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 276922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 277022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else if (!verify_set_layout_compatibility(my_data, my_data->setMap[state.boundDescriptorSets[setIndex]], 277122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis pPipe->graphicsPipelineCI.layout, setIndex, errorString)) { 277222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Set is bound but not compatible w/ overlapping pipelineLayout from PSO 2773397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis VkDescriptorSet setHandle = my_data->setMap[state.boundDescriptorSets[setIndex]]->GetSet(); 277422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 277522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 277622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 2777414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 2778414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 277922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, setIndex, (uint64_t)pPipe->graphicsPipelineCI.layout, errorString.c_str()); 278022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 278122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 2782397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = my_data->setMap[state.boundDescriptorSets[setIndex]]; 278322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 278422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis activeSetBindingsPairs.push_back(std::make_pair(pSet, setBindingPair.second)); 278522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 278622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 2787397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 278822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis for (auto binding : setBindingPair.second) { 2789397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 279022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 279122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2792397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2793414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 279422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 2795397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 2796fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 27975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 280022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 280122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 280222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, pCB, activeSetBindingsPairs); 280322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 280422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // TODO : If/when compute pipelines/shaders are handled above, code below is only for gfx bind poing 280522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis //if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) { 280622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Verify Vtx binding 280722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (pPipe->vertexBindingDescriptions.size() > 0) { 280822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis for (size_t i = 0; i < pPipe->vertexBindingDescriptions.size(); i++) { 280922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 281022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 281122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 2812414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "The Pipeline State Object (0x%" PRIxLEAST64 281322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 281422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis " should be set via vkCmdBindVertexBuffers.", 281522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)state.pipeline, i); 28165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 281722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 281822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { 281922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (!pCB->currentDrawData.buffers.empty()) { 282022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 282122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 2822414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 2823414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 282422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline); 282522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 282622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 282722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 282822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Skip check if rasterization is disabled or there is no viewport. 282922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((!pPipe->graphicsPipelineCI.pRasterizationState || 283022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (pPipe->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 283122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis pPipe->graphicsPipelineCI.pViewportState) { 283222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis bool dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT); 283322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis bool dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR); 283422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (dynViewport) { 283522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) { 283622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 283722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 283822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 283922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis ", but PSO viewportCount is %u. These counts must match.", 284022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount); 284122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 284222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 284322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (dynScissor) { 284422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) { 284522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 284622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 284722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 284822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis ", but PSO scissorCount is %u. These counts must match.", 284922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount); 28505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 285322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis //} // end of "if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) {" block 2854eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2855eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 2856ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes result |= validatePipelineDrawtimeState(my_data, pCB, bindPoint, pPipe); 2857eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 28585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 28595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 28605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2861a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 2862a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 2863a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 2864a27508babf63d50aea75883a3702979193c23683Mark Young 2865a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 2866a27508babf63d50aea75883a3702979193c23683Mark Young if ((VK_FALSE == my_data->phys_dev_properties.features.wideLines) && (1.0f != lineWidth)) { 2867a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 2868a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 2869a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 2870a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 2871a27508babf63d50aea75883a3702979193c23683Mark Young } else { 2872a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 2873a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 2874a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 2875a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 2876a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 2877a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 2878a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 2879a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 2880a27508babf63d50aea75883a3702979193c23683Mark Young } 2881a27508babf63d50aea75883a3702979193c23683Mark Young } 2882a27508babf63d50aea75883a3702979193c23683Mark Young 2883a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 2884a27508babf63d50aea75883a3702979193c23683Mark Young} 2885a27508babf63d50aea75883a3702979193c23683Mark Young 28865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 2887e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 2888e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 2889e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 28905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 28925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 28945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 28955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 28965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 28975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 28985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 28995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 29005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 29035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 29045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 29055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 29065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 29095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 29105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 29115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 29135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 29145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 29175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 29205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 2924b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 29253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 292626c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 2927c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 2928c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski if ((pAttachments[0].blendEnable != pAttachments[i].blendEnable) || 2929c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcColorBlendFactor != pAttachments[i].srcColorBlendFactor) || 2930c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstColorBlendFactor != pAttachments[i].dstColorBlendFactor) || 2931c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorBlendOp != pAttachments[i].colorBlendOp) || 2932c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcAlphaBlendFactor != pAttachments[i].srcAlphaBlendFactor) || 2933c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstAlphaBlendFactor != pAttachments[i].dstAlphaBlendFactor) || 2934c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].alphaBlendOp != pAttachments[i].alphaBlendOp) || 2935c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorWriteMask != pAttachments[i].colorWriteMask)) { 2936c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski skipCall |= 2937c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 2938c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski DRAWSTATE_INDEPENDENT_BLEND, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " 2939c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski "enabled, all elements of pAttachments must be identical"); 2940c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 29415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2944b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 29455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 29465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 29475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 29495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 29505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 29525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 29535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 29545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 29555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 29575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 29585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2961a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 29625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 29635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 29645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = my_data->renderPassMap.find(pPipeline->graphicsPipelineCI.renderPass); 29655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != my_data->renderPassMap.end() && 29665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass >= rp_data->second->pCreateInfo->subpassCount) { 29675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 29695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "is out of range for this renderpass (0..%u)", 29705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass, rp_data->second->pCreateInfo->subpassCount - 1); 29715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2973e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->phys_dev_properties.features, 297469f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 2975e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall = true; 29765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 297752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 297852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 297952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 298052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 298152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 298252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 298352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 298452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 298552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 298652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 298752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 29885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 29895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 29905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 29915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 29935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 29955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 29965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 29975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 30005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 30025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 30035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 30045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 30055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 30065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 30095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 30115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 30125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3013ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3014ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 30155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 30175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 30185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology for tessellation pipelines"); 30195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3020ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3021ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 30225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 30235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 30255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 30265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology is only valid for tessellation pipelines"); 30275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3028ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 3029ca546210846c65808717f8875deae39bd227c240Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3030ca546210846c65808717f8875deae39bd227c240Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 3031ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "Invalid Pipeline CreateInfo State: " 3032ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 3033ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3034ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3035ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 30365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 30385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 30395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology used with patchControlPoints value %u." 30405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " patchControlPoints should be >0 and <=32.", 3041ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 30425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3044a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3045a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3046a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 3047a27508babf63d50aea75883a3702979193c23683Mark Young skipCall |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 3048a27508babf63d50aea75883a3702979193c23683Mark Young pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3049a27508babf63d50aea75883a3702979193c23683Mark Young } 3050a27508babf63d50aea75883a3702979193c23683Mark Young } 30515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 30525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 30535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 30545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 305545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 30565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 30575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 30595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and scissors are dynamic PSO must include " 30605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 30615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 30625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 30635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 30655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 3066ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 3067ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 30685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 30695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3070e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3071e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 30725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 30735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 30745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 30755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 30765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 30775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 30785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 30795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetViewport().", 30805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 30815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 30845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 30855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 30865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 30875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 30885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 30895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 30905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetScissor().", 30915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 30925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 30975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 30985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 31025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3103ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3104ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 31075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 31105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 31125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic DESCRIPTOR_POOL_NODE *getPoolNode(layer_data *my_data, const VkDescriptorPool pool) { 31135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) { 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorPoolMap[pool]; 31175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3119e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3120e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 31215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 31225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 31235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3124e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 31255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 31265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 31285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 31295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 31305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 31345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 31355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 31365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 31375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 31385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 31395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 31405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 31415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 31425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 31435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3147fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 31485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3149fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3152fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 31545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3155fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 31565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3158fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3159e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 31605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 3161e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 31621d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 31635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 31645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 31655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 31665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 31685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3169e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 31705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 31715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 31725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 31745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 31755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 31765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3177e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 3178fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 3179fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis skipCall |= log_msg( 3180fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3181fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3182fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3183fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 31845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31884a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 31894a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 31904a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 31914a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 31924a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 31934a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 31944a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 31954a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 31964a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 31974a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 31984a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 31994a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 32014a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 32024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 32034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 32044a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 32054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32064a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 32074a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 32084a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 32094a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 32104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 32114a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32124a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 32134a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 32144a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 32154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 32164a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 32174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 32184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 32194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 32214a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 32224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 32234a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 32244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 32254a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32264a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 32274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 32284a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 32294a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 32304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 32314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 32334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 32344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 32354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 32365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 32375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 32385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 32394a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 32404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 32414a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 32424a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 32434a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 32444a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 32455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 32464a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 32475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 32485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 32494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 32505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 32555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 32564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 32574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 32584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 32594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 32604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 32614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 32634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 32645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 32664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 32725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 32735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 32775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 32805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 32815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt == my_data->imageMap.end()) 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data->second.size() >= (imgIt->second.createInfo.arrayLayers * imgIt->second.createInfo.mipLevels + 1)) { 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 32905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 32915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 32925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 32935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 32945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 32955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 33015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 33025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 33035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 33045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 33055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 33065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 33075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 33085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 33095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 331308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 331608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 331708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 331808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 331908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 33205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 332308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 33245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 332508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 332608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 33275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 33305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 33315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 33327068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 33337068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 33347068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 333508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 333908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 334008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 334108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 334208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 334308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 334408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 33455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 334708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 334808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 335008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 335108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 335208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 335308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 33545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 335608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 33575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 335808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_view_data = dev_data->imageViewMap.find(imageView); 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_view_data != dev_data->imageViewMap.end()); 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_view_data->second.image; 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_view_data->second.subresourceRange; 33665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 33675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 33685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 33695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 33705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 33725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 33735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3379e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3380e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3381e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3382e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 33835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 33845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 33855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3387414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 33915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 33925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 3393414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer.", 33945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 33955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3399397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic void invalidateBoundCmdBuffers(layer_data *dev_data, const cvdescriptorset::DescriptorSet *pSet) { 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Flag any CBs this set is bound to as INVALID 3401397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (auto cb : pSet->GetBoundCmdBuffers()) { 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cb_node = dev_data->commandBufferMap.find(cb); 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_node != dev_data->commandBufferMap.end()) { 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cb_node->second->state = CB_INVALID; 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// update DS mappings based on write and copy update arrays 3409e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool dsUpdate(layer_data *my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pWDS, 3410e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pCDS) { 3411e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate Write updates 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorWriteCount; i++) { 34155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSet ds = pWDS[i].dstSet; 3416397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = my_data->setMap[ds]; 34175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 3418e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateIdleDescriptorSet(my_data, ds, "VkUpdateDescriptorSets")) == true) 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If set is bound to any cmdBuffers, mark them invalid 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pSet); 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pUpdate = (GENERIC_HEADER *)&pWDS[i]; 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify valid update struct 3424e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == true) { 34255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3427cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis string error_str; 3428397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->WriteUpdate(my_data->report_data, &pWDS[i], &error_str)) { 34295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 34305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 3431414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkUpdateDescriptorsSets() failed write update for Descriptor Set 0x%" PRIx64 " with error: %s", 3432cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<uint64_t &>(ds), error_str.c_str()); 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now validate copy updates 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorCopyCount; ++i) { 3437397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSrcSet = NULL, *pDstSet = NULL; 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each copy make sure that update falls within given layout and that types match 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcSet = my_data->setMap[pCDS[i].srcSet]; 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet = my_data->setMap[pCDS[i].dstSet]; 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 3442397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if ((skipCall = validateIdleDescriptorSet(my_data, pDstSet->GetSet(), "VkUpdateDescriptorSets")) == true) 34435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pDstSet); 3445cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string error_str; 3446397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pDstSet->CopyUpdate(my_data->report_data, &pCDS[i], pSrcSet, &error_str)) { 3447cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 3448cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(pCDS[i].dstSet), __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 3449414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkUpdateDescriptorsSets() failed copy update from Descriptor Set 0x%" PRIx64 3450414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " to Descriptor Set 0x%" PRIx64 " with error: %s", 3451cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(pCDS[i].srcSet), 3452cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(pCDS[i].dstSet), error_str.c_str()); 34535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3458a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// Verify that given pool has descriptors that are being requested for allocation. 3459a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// NOTE : Calls to this function should be wrapped in mutex 3460e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_descriptor_availability_in_pool(layer_data *dev_data, DESCRIPTOR_POOL_NODE *pPoolNode, uint32_t count, 3461e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkDescriptorSetLayout *pSetLayouts) { 3462e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3463a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t i = 0; 3464a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t j = 0; 3465a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 3466a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Track number of descriptorSets allowable in this pool 3467a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski if (pPoolNode->availableSets < count) { 3468a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 3469a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski reinterpret_cast<uint64_t &>(pPoolNode->pool), __LINE__, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 3470414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unable to allocate %u descriptorSets from pool 0x%" PRIxLEAST64 3471a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptorSets remaining.", 3472a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski count, reinterpret_cast<uint64_t &>(pPoolNode->pool), pPoolNode->availableSets); 3473a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } else { 3474a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets -= count; 3475a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } 3476a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 34775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; ++i) { 3478fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis auto layout_pair = dev_data->descriptorSetLayoutMap.find(pSetLayouts[i]); 3479fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_pair == dev_data->descriptorSetLayoutMap.end()) { 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 34825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i], __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 3483414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unable to find set layout node for layout 0x%" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 34845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i]); 34855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 3487a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis auto &layout_node = layout_pair->second; 3488a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (j = 0; j < layout_node->GetBindingCount(); ++j) { 3489a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis const auto &binding_layout = layout_node->GetDescriptorSetLayoutBindingPtrFromIndex(j); 3490fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis typeIndex = static_cast<uint32_t>(binding_layout->descriptorType); 3491fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis poolSizeCount = binding_layout->descriptorCount; 34925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) { 3493fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis skipCall |= log_msg( 3494fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 3495fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis reinterpret_cast<const uint64_t &>(pSetLayouts[i]), __LINE__, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 3496414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unable to allocate %u descriptors of type %s from pool 0x%" PRIxLEAST64 3497fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis ". This pool only has %d descriptors of this type remaining.", 3498fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis poolSizeCount, string_VkDescriptorType(binding_layout->descriptorType), (uint64_t)pPoolNode->pool, 3499fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex]); 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Decrement available descriptors of this type 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount; 35025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35089dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis// Free the descriptor set, remove it from setMap and invalidate any cmd buffers that it was bound to 35099dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 35109dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis invalidateBoundCmdBuffers(dev_data, descriptor_set); 35119dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 35129dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 35139dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 35145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 35155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 35165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 35175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 35185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 35195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3520c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3521cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 35229dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 35235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3524f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 35255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 35325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPool) { 35335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 3535414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unable to find pool node for pool 0x%" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t)pool); 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: validate flags 3538397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3539cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : pPool->sets) { 35409dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 3541cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 3542f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis pPool->sets.clear(); 3543e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis // Reset available count for each type and available sets for this pool 35445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 35455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 35465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3547e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis pPool->availableSets = pPool->maxSets; 35485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 35525121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 35535121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 35545121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 355572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 355672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3557414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 35595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35605121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 35615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3566400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3575e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 35765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 35775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 35785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3581e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3583e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3584e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 35855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && cmd_type != CMD_EXECUTECOMMANDS) { 35865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 35935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3623e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool addCmd(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 3624e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = my_data->commandPoolMap.find(pCB->createInfo.commandPool); 36265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != my_data->commandPoolMap.end()) { 3627b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pool_data->second.queueFamilyIndex].queueFlags; 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 36295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 36305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 36525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 36535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 36575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 36595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 36605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 36615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 36625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 36695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 36705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 36735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 36785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 3698400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 3699400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 3701b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 371493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 371572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 371672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 371772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 3718400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis auto set_node = dev_data->setMap.find(set); 3719400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (set_node != dev_data->setMap.end()) { 3720397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis set_node->second->RemoveBoundCommandBuffer(pCB->commandBuffer); 372172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 372272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 372372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 372472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 372593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 3727ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 373072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedFence = VK_NULL_HANDLE; 373172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedQueue = VK_NULL_HANDLE; 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedSets.clear(); 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->updatedSets.clear(); 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedFramebuffers.clear(); 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->semaphores.clear(); 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 3742abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 3748bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 3749bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 3750bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 3751bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 37537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 37547a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 3755400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 3756b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 375793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 375893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 375993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 376093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski auto fbNode = dev_data->frameBufferMap.find(framebuffer); 376193c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski if (fbNode != dev_data->frameBufferMap.end()) { 376293c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski fbNode->second.referencingCmdBuffers.erase(pCB->commandBuffer); 376393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 376493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 376593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 376693c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 3773ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 3774ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 37755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 3781ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 3782ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 37963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 38115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 38125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 3820e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 3821e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 382472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 3830ca546210846c65808717f8875deae39bd227c240Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 3831ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 3832ca546210846c65808717f8875deae39bd227c240Tobin Ehlis .c_str()); 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3842414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "Cmds in CB 0x%p", (void *)cb); 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 3847414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3854e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 3855e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= printPipeline(my_data, cb); 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 3865e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3866e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 3870414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 3871ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 3878e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3879e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3890b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 3891d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 3892b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 389689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 389789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3913b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 391456a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 3915b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 3916b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3918b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 3919b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 3920b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3922b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 393089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3939b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 39415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 39485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 397389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 397489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 397556a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 398156a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3994b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 40006c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4005b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 40075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4008b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 40095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4010b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 40125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4013b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4015b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4017b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4018b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4019b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 402889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 40325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4033b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 4037f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 40385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 4039f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 4040f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 4041a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 4042a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 4043a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 4044fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 40455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 40465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 40511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 40521344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4053b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 405403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 4055e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4056b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 40610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 40620a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 40635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 406458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4065400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 40665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 40675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, 4073414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 4074414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4080b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 4083414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 4086e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 40885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 40935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 40945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 40975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 40995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 41005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4101e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) { 4102e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 41035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 41045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 41055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 41075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 41085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 41095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4110414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 41115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 41125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 41145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 41155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4116856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4117856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4118856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4119856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4120414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4121856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4122414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4123414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4124414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4125856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4126856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4127856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4128856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4129856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4130414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4131856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4132856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4133856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4134856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 414139d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 41425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 4143e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB) { 4144e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4151414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_add(1); 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 415772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 415872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 415972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 416072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode == my_data->setMap.end()) { 416172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 416272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 416372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 4164414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted descriptor set 0x%" PRIx64 ".", (uint64_t)(set)); 416572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 416672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_add(1); 416772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode == my_data->semaphoreMap.end()) { 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 4176414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted semaphore 0x%" PRIx64 ".", reinterpret_cast<uint64_t &>(semaphore)); 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_add(1); 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode == my_data->eventMap.end()) { 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 41855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 41865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4187414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted event 0x%" PRIx64 ".", reinterpret_cast<uint64_t &>(event)); 41885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_add(1); 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4195b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4196b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 4197b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4198b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4199b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4200b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4201b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4202b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4203b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4204b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4205b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4206414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4207414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4208b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4209b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4210b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4211b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4212b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4213b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4214b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4215b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4216b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4217b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4218b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4219b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4220b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4221b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4222b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4223b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4224b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4225e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, VkCommandBuffer cmdBuffer) { 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 42295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 42305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != my_data->bufferMap.end()) { 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_sub(1); 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 423572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 423672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 423772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 423872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode != my_data->setMap.end()) { 423972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_sub(1); 424072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 42415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 42455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode != my_data->semaphoreMap.end()) { 42465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_sub(1); 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 42505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 42515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode != my_data->eventMap.end()) { 42525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_sub(1); 42535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 42575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto eventStagePair : pCB->eventToStageMap) { 42595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 42605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4262a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// For fenceCount fences in pFences, mark fence signaled, decrement in_use, and call 4263a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// decrementResources for all priorFences and cmdBuffers associated with fence. 4264b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 4265b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4266ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis std::vector<std::pair<VkFence, FENCE_NODE *>> fence_pairs; 42675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 42685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(pFences[i]); 42695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end() || !fence_data->second.needsSignaled) 4270b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = false; 4272bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine if (fence_data->second.in_use.load()) { 4273ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis fence_pairs.push_back(std::make_pair(fence_data->first, &fence_data->second)); 4274bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine fence_data->second.in_use.fetch_sub(1); 4275bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 42761d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill decrementResources(my_data, static_cast<uint32_t>(fence_data->second.priorFences.size()), 42771d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill fence_data->second.priorFences.data()); 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : fence_data->second.cmdBuffers) { 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 4280b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= cleanInFlightCmdBuffer(my_data, cmdBuffer); 4281b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine removeInFlightCmdBuffer(my_data, cmdBuffer); 42825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 428394601b592f9bf0d1e426e066f565207b2bf42699Michael Lentine fence_data->second.cmdBuffers.clear(); 428494601b592f9bf0d1e426e066f565207b2bf42699Michael Lentine fence_data->second.priorFences.clear(); 42855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4286ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis for (auto fence_pair : fence_pairs) { 42876bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis for (auto queue : fence_pair.second->queues) { 42886bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto queue_pair = my_data->queueMap.find(queue); 42896bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis if (queue_pair != my_data->queueMap.end()) { 42906bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto last_fence_data = 42916bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis std::find(queue_pair->second.lastFences.begin(), queue_pair->second.lastFences.end(), fence_pair.first); 42926bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis if (last_fence_data != queue_pair->second.lastFences.end()) 42936bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis queue_pair->second.lastFences.erase(last_fence_data); 42946bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis } 4295bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4296bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4297b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4299a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Decrement in_use for all outstanding cmd buffers that were submitted on this queue 4300b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, VkQueue queue) { 4301b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : queue_data->second.untrackedCmdBuffers) { 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 4306b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= cleanInFlightCmdBuffer(my_data, cmdBuffer); 4307b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine removeInFlightCmdBuffer(my_data, cmdBuffer); 43085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 4310b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(my_data, static_cast<uint32_t>(queue_data->second.lastFences.size()), 4311b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine queue_data->second.lastFences.data()); 43120a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4313b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 43140a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 43150a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 4316b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This function merges command buffer tracking between queues when there is a semaphore dependency 4317b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// between them (see below for details as to how tracking works). When this happens, the prior 4318b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// fences from the signaling queue are merged into the wait queue as well as any untracked command 4319b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers. 4320e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 43210a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 43220a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 43230a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 43240a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 43250a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto other_queue_data = dev_data->queueMap.find(other_queue); 43260a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue_data == dev_data->queueMap.end() || other_queue_data == dev_data->queueMap.end()) { 43270a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 43280a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4329ca32a764ef85a255c97531164bffb073553de105Jamie Madill for (auto fenceInner : other_queue_data->second.lastFences) { 4330ca32a764ef85a255c97531164bffb073553de105Jamie Madill queue_data->second.lastFences.push_back(fenceInner); 43316bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto fence_node = dev_data->fenceMap.find(fenceInner); 43326bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis if (fence_node != dev_data->fenceMap.end()) { 43336bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis fence_node->second.queues.insert(other_queue_data->first); 43346bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis } 43350a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 43360a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence != VK_NULL_HANDLE) { 43370a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 43380a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence_data == dev_data->fenceMap.end()) { 43390a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 43400a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 43410a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 43420a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 43430a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 43440a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 43450a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 43460a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 43470a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.untrackedCmdBuffers.push_back(cmdbuffer); 43480a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 43490a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 43505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4351b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto eventStagePair : other_queue_data->second.eventToStageMap) { 4352b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[eventStagePair.first] = eventStagePair.second; 4353b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4356b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This is the core function for tracking command buffers. There are two primary ways command 4357b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers are tracked. When submitted they are stored in the command buffer list associated 4358b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// with a fence or the untracked command buffer list associated with a queue if no fence is used. 4359b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Each queue also stores the last fence that was submitted onto the queue. This allows us to 4360b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// create a linked list of fences and their associated command buffers so if one fence is 4361b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on, prior fences on that queue are also considered to have been waited on. When a fence is 4362b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on (either via a queue, device or fence), we free the cmd buffers for that fence and 4363b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// recursively call with the prior fences. 4364e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void trackCommandBuffers(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 4365e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkFence fence) { 43665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 43675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 43680a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine vector<VkFence> prior_fences; 43695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(fence); 43705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end()) { 43715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 43725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4373abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine fence_data->second.cmdBuffers.clear(); 43745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 43750a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine prior_fences = queue_data->second.lastFences; 43760a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.clear(); 43770a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.push_back(fence); 43780a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : queue_data->second.untrackedCmdBuffers) { 43790a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 43805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 43825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43830a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.priorFences = prior_fences; 43845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = true; 43856bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis fence_data->second.queues.insert(queue); 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_add(1); 43875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 43885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 43895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 43915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(secondaryCmdBuffer); 43925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(submit->pCommandBuffers[i]); 43945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 43985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 43995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 44005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 44015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 44025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(secondaryCmdBuffer); 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(submit->pCommandBuffers[i]); 44055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4409b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4410b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4411b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic void markCommandBuffersInFlight(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 4412b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VkFence fence) { 4413b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine auto queue_data = my_data->queueMap.find(queue); 44145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 44165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 44175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 4418b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Add cmdBuffers to the global set and increment count 4419b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, submit->pCommandBuffers[i]); 44205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 44215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(secondaryCmdBuffer); 4422b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pSubCB = getCBNode(my_data, secondaryCmdBuffer); 4423b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pSubCB->in_use.fetch_add(1); 44245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 4426b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_add(1); 44275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4432e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 44335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 443827c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4439414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 44405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 44415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 44470a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 44480a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 44490a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 44500a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4451414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 4452414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "set, but has been submitted 0x%" PRIxLEAST64 " times.", 44530a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 44540a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 44575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool causeReported = false; 44605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedSets.empty()) { 44615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 44625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->destroyedSets) 44635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 44645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4468414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 44695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) destroyed: %s", 44705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->updatedSets.empty()) { 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 44755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->updatedSets) 44765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4481414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 44825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) updated: %s", 44835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 44845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedFramebuffers.empty()) { 44875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream fb_string; 44885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto fb : pCB->destroyedFramebuffers) 44895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_string << " " << fb; 44905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4494414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because it had the following " 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "referenced framebuffers destroyed: %s", 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), fb_string.str().c_str()); 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This is defensive programming to make sure an error is 45005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // flagged if we hit this INVALID cmd buffer case and none of the 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // above cases are hit. As the number of INVALID cases grows, this 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // code should be updated to seemlessly handle all the cases. 45035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!causeReported) { 45045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 45055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4507414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid due to an unknown cause. Validation " 45085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "should " 45095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "be improved to report the exact cause.", 45105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer)); 45115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 45135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 45145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4516414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You must call vkEndCommandBuffer() on CB 0x%" PRIxLEAST64 " before this call to vkQueueSubmit()!", 45175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 45185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4523e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 4525e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = validateAndIncrementResources(dev_data, pCB); 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 45275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 45285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndIncrementResources(dev_data, dev_data->commandBufferMap[secondaryCmdBuffer]); 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 45304c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 45314c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 45325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 45335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4534414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 45355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 4536414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 45374c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 45395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 45405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pCB); 45445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 45455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // on device 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferSimultaneousUse(dev_data, pCB); 45475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 455089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 455189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 4552e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 455372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = NULL; 45545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 45555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 4556b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 45575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that fence is not in use 4558a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence != VK_NULL_HANDLE) { 4559a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if ((submitCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 4560a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4561a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 4562414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(fence)); 4563a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 4564a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!dev_data->fenceMap[fence].needsSignaled) { 4565a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4566a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4567414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 4568a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence)); 4569a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 45705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45711344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 45721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 45731344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 4574b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Update cmdBuffer-related data structs and mark fence in-use 4575b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine trackCommandBuffers(dev_data, queue, submitCount, pSubmits, fence); 45765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 45770a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 45795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 45805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 45815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 45820a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pWaitSemaphores[i]; 458341bb23666442c59912c630f85db04ce1a052f3efTobin Ehlis semaphoreList.push_back(semaphore); 45841344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 45851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 45861344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 45871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 45881344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 45891344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 45901344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4591414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 45921344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 45931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 45941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkQueue &other_queue = dev_data->semaphoreMap[semaphore].queue; 45951344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 45961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 45971344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis processed_other_queues.insert(other_queue); 45981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 45995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 46020a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pSignalSemaphores[i]; 46031344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 46041344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis semaphoreList.push_back(semaphore); 46051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 46061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 46071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 46081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4609414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 4610414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 46111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 46121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(dev_data->semaphoreMap[semaphore].queue)); 46131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 46141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 46151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].queue = queue; 46161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46170a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 46185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 46205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]); 462172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 46221344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 46231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->semaphores = semaphoreList; 46241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 46251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedFence = fence; 46261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedQueue = queue; 46271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= validatePrimaryCommandBufferState(dev_data, pCBNode); 46281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 46291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 46301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(); 46311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 46331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(queue); 46341344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4638b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine markCommandBuffersInFlight(dev_data, queue, submitCount, pSubmits, fence); 4639b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4640e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 46415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 46425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 464603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 464789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 464889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 46495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 46515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 4652b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 46535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 46540a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 46555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 465889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 465989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 46605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 46635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 46645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 46655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 46665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 46675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 46685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4669b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 4670e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves freeMemObjInfo(my_data, device, mem, false); 46710a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 46720a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 4673b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 46755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4677e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 4678e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 46795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 46815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: a size of 0 is not listed as an invalid use in the spec, should it be? 46825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 46835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 46845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 46855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 46885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 46905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.size != 0) { 46915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 46925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 4693414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 46945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 46975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 46985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (offset >= mem_element->second.allocInfo.allocationSize) { 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 47005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 4701414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " with total array size 0x%" PRIx64, offset, 47025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.allocInfo.allocationSize, mem_element->second.allocInfo.allocationSize); 47035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((offset + size) > mem_element->second.allocInfo.allocationSize) { 47065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 47075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 4708414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " with total array size 0x%" PRIx64, offset, 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size + offset, mem_element->second.allocInfo.allocationSize); 47105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 47145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4716e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 47175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 47185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 47195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MemRange new_range; 47205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.offset = offset; 47215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.size = size; 47225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange = new_range; 47235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4726e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 4727e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 47285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 47295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_element->second.memRange.size) { 47315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 47325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 47335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 4734414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 47355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange.size = 0; 47375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis free(mem_element->second.pData); 47395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 47435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 47465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4747b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 4748b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto mem_element = dev_data->memObjMap.find(mem); 4749b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (mem_element != dev_data->memObjMap.end()) { 47505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pDriverData = *ppData; 47515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t index = mem_element->second.allocInfo.memoryTypeIndex; 4752b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 47535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 47545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 47565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size = mem_element->second.allocInfo.allocationSize; 47575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 47595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = malloc(2 * convSize); 47605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(mem_element->second.pData, NoncoherentMemoryFillValue, 2 * convSize); 47615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppData = static_cast<char *>(mem_element->second.pData) + (convSize / 2); 47625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 4766a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 4767a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// a fence being waited on should not already be signalled and 4768a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 4769a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlisstatic inline bool verifyWaitFenceState(VkDevice device, VkFence fence, const char *apiCall) { 47705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4771e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 47725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFenceInfo = my_data->fenceMap.find(fence); 47735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceInfo != my_data->fenceMap.end()) { 4774e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!pFenceInfo->second.firstTimeFlag) { 4775a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!pFenceInfo->second.needsSignaled) { 47765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 47775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 47785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4779414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s specified fence 0x%" PRIxLEAST64 " already in SIGNALED state.", apiCall, (uint64_t)fence); 47805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47816bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis if (pFenceInfo->second.queues.empty() && !pFenceInfo->second.swapchain) { // Checking status of unsubmitted fence 47825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 47835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4784414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "acquire next image.", 47865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4789e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pFenceInfo->second.firstTimeFlag = false; 47905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 47935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4794a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 479589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 479689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 47975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4798e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 47995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 4800b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 4802a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skip_call |= verifyWaitFenceState(device, pFences[i], "vkWaitForFences"); 48035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4804b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 48055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 48065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 4807a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 48085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 4809414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 48105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 4811b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 48125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 48135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 4814b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, fenceCount, pFences); 48155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 48175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 48185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 4819b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 48205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4821e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 482689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 48275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 4830b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 4831a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall = verifyWaitFenceState(device, fence, "vkGetFenceStatus"); 4832b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4833a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 48345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 48355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 4836a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 48375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 4838e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4839b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 48405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 4841b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skipCall |= decrementResources(dev_data, 1, &fence); 48425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4843b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4844e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 484989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 4850b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 48515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 4853b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 4854b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 4855b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 4856b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 4857b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 4858b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 4859b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 4860b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 48615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 486389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 48645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 4865e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4866b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 4867e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 48705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 487389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 4874e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4876b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 4878b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 48795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 4881b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4882e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 48835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 48855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 488889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 48895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 4891b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48921344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 48931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 48941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair->second.in_use.load()) { 48951344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 48961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 4897414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIx64 " is in use by a command buffer.", (uint64_t)(fence)); 48981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 48991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 49005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4901b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 49021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 49035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 49045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 49055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 490789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 490889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 49095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 4911b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 49125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 49135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 49145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 49155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 49165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 4917414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete semaphore 0x%" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 49185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 492489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 49255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 4927b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 49285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto event_data = dev_data->eventMap.find(event); 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data != dev_data->eventMap.end()) { 49305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data->second.in_use.load()) { 49315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg( 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 49335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4934414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete event 0x%" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 49355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap.erase(event_data); 49375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4938b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 49395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 49405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 49415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 494489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 494589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 49465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 49475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 495189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 495289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 495389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 49565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = nullptr; 4957b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 49585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 49595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB = getCBNode(dev_data, cmdBuffer); 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 49625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4964e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 49655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 49665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 49675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 49685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 49695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 4970ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 4971ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 4972ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 4973ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 4974ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 4975ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 4976ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 4977ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4978ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 4979414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 4980ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 4981ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 4982ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 4983ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 4984ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4985ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4986ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4987ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 4988ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 4989ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 4990ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 4991ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 4992ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 4993ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 4994ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 4995ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4996ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 49975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 49985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 4999414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 50005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 50015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5002ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5003ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 50045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 50055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5006414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 50075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5008ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5009ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5010ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5011ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5012414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 5013ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5014ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 50155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5018b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 50195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 50215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 50225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 50235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5025e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5026e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 50275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 50285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 50295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 50305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 5031414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 50325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 50335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data->second.in_use.load()) { 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5036414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 50375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 50405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 504247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 504347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 504447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 504547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 5046414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Buffer 0x%" PRIx64 " is aliased with image 0x%" PRIx64, object_handle, 504747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 504847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } else { 504947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 5050414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Image 0x%" PRIx64 " is aliased with buffer 0x%" PRIx64, object_handle, 505147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 505247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 505347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 505447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 505547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 505647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 505747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski bool skip_call = false; 505847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 505947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (auto range : ranges) { 506047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) < 506147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 506247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 506347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) > 506447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 506547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 506647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 506747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 506847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return skip_call; 506947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 507047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 507147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic MEMORY_RANGE insert_memory_ranges(uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 507247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges) { 507347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski MEMORY_RANGE range; 507447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 507547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.memory = mem; 507647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 507747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 507847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.push_back(range); 507947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return range; 508047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 508147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 508247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic void remove_memory_ranges(uint64_t handle, VkDeviceMemory mem, vector<MEMORY_RANGE> &ranges) { 508347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (uint32_t item = 0; item < ranges.size(); item++) { 508447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((ranges[item].handle == handle) && (ranges[item].memory == mem)) { 508547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.erase(ranges.begin() + item); 508647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski break; 508747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 508847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 508947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 509047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 509189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 509289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 50935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5094e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5095b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5096e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!validateIdleBuffer(dev_data, buffer) && !skipCall) { 5097b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 50985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 5099b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 51005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 510147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory binding and range information for buffer 510247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &bufferEntry = dev_data->bufferMap.find(buffer); 510347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (bufferEntry != dev_data->bufferMap.end()) { 510447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &memEntry = dev_data->memObjMap.find(bufferEntry->second.mem); 510547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (memEntry != dev_data->memObjMap.end()) { 510647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski remove_memory_ranges(reinterpret_cast<uint64_t &>(buffer), bufferEntry->second.mem, memEntry->second.bufferRanges); 510747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 510847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 510947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski dev_data->bufferMap.erase(bufferEntry); 511047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 511389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 511489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 51155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 5117b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 51185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 51195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 51205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 51215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 512489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 51255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5126e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 512747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (!skipCall) { 51285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 512947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 51305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5131b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 513247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &imageEntry = dev_data->imageMap.find(image); 513347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (imageEntry != dev_data->imageMap.end()) { 513447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory mapping, bindings and range references for image 513547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski auto memEntry = dev_data->memObjMap.find(imageEntry->second.mem); 513647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (memEntry != dev_data->memObjMap.end()) { 513747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski remove_memory_ranges(reinterpret_cast<uint64_t &>(image), imageEntry->second.mem, memEntry->second.imageRanges); 513847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 513947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski memEntry->second.image = VK_NULL_HANDLE; 514047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 514158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 514247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski dev_data->imageMap.erase(imageEntry); 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 51455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 51465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 51475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 51485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 51505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 515347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski#if MTMERGESOURCE 515489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 515589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 515658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5158b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 51605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 5161e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = 516294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 516394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto buffer_node = dev_data->bufferMap.find(buffer); 516494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 516594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis buffer_node->second.mem = mem; 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 516794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 516847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 516947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 517047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &memEntry = dev_data->memObjMap.find(mem); 517147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (memEntry != dev_data->memObjMap.end()) { 517247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 517347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski insert_memory_ranges(buffer_handle, mem, memoryOffset, memRequirements, memEntry->second.bufferRanges); 517447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski skipCall |= 517547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski validate_memory_range(dev_data, memEntry->second.imageRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 517647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 517747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 51782c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 51792c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 51802c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 51812c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 51822c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5183414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5184414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 51852c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 51862c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 51872c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 51882c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 518994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].createInfo.usage; 51902c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & (VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT)) { 5191b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment) != 0) { 51922c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 51932c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 51942c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5195414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5196414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minTexelBufferOffsetAlignment 0x%" PRIxLEAST64, 5197b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment); 51982c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 51992c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52002c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT) { 5201b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 5202b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 52032c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52042c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 52052c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 5206414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5207414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 5208b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 52092c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52102c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52112c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_STORAGE_BUFFER_BIT) { 5212b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 5213b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 52142c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 52152c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 52162c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 5217414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5218414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 5219b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 52202c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52212c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 52225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5224b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5225e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 522658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 52275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 523189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 523289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 52335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 52355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 52365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 52375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 523989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 524089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 52415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 52435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 52445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 52455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 524789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 524889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 52495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 52505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 52515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 525489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 525589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5256918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5257918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5258b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5259918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5260b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5261918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5262918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 52635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 526589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 526689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 52675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 52685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 527189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 527289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 52735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 52745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 52755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 527889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 527989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 52805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 52815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 528489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 528589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 52865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 52875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 52885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 529189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 529289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 52945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 52955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5297bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 5298bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 5299bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 5300bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 5301bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 5302bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5303bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 5304bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 5305bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 5306bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 5307bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 5308bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 5309bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 5310414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use.", action, 5311bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 5312bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } else { // Secondary CB w/o primary in-flight, remove from in-flight 5313bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 5314bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5315bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5316bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5317bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 5318bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 5319bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBuffersInFlight(layer_data *dev_data, const VkCommandPool commandPool, const char *action) { 5320bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5321bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto pool_data = dev_data->commandPoolMap.find(commandPool); 5322bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (pool_data != dev_data->commandPoolMap.end()) { 5323bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto cmd_buffer : pool_data->second.commandBuffers) { 5324bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 5325bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 5326bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5327bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5328bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5329bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5330bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 53315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 533289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 533389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 53345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5337b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 5339bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto cb_pair = dev_data->commandBufferMap.find(pCommandBuffers[i]); 5340bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, cb_pair->second, "free"); 53415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 5342bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (cb_pair != dev_data->commandBufferMap.end()) { 53435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 5344bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis resetCB(dev_data, (*cb_pair).second->commandBuffer); 5345bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis delete (*cb_pair).second; 5346bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->commandBufferMap.erase(cb_pair); 53475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 53505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]); 53515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 535203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 53530a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 53545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 5355b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 53585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 53595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 536189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 536289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 536389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 53645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5369b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 53705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 53715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 53725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 537689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 537789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 53785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 53815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5382b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 53845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 538989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 539089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5393b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 5395bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis VkBool32 result = checkAndClearCommandBuffersInFlight(dev_data, commandPool, "destroy command pool with"); 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) { 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 53995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb != dev_data->commandPoolMap[commandPool].commandBuffers.end();) { 5400400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, *poolCb); 54015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto del_cb = dev_data->commandBufferMap.find(*poolCb); 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*del_cb).second; // delete CB info structure 540372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer 54045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.erase( 54055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb); // Remove CB reference from commandPoolMap's list 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap.erase(commandPool); 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5410b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5412f90830842fdd43e8f1834f2eb76bda28eef435b8Tony Barbour if (result) 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 54145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 54165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 54175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 541989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 542089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 54215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 54235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5424400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 5425bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (checkAndClearCommandBuffersInFlight(dev_data, commandPool, "reset command pool with")) 54265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 54295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 54325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5433b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*it)); 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 54385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 544389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 54445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 54465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5447b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 54495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = dev_data->fenceMap.find(pFences[i]); 54505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != dev_data->fenceMap.end()) { 5451a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_item->second.needsSignaled = true; 54526bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis fence_item->second.queues.clear(); 5453a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence_item->second.in_use.load()) { 5454a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= 5455a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 5456a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 5457414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIx64 " is in use by a command buffer.", reinterpret_cast<const uint64_t &>(pFences[i])); 54585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5461b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 54635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 54645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 546789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 546889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 54695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5470b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(framebuffer); 54725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 54735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : fbNode->second.referencingCmdBuffers) { 54745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cbNode = dev_data->commandBufferMap.find(cb); 54755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cbNode != dev_data->commandBufferMap.end()) { 54765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set CB as invalid and record destroyed framebuffer 54775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->state = CB_INVALID; 54785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->destroyedFramebuffers.insert(framebuffer); 54795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5481f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes delete [] fbNode->second.createInfo.pAttachments; 5482f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes dev_data->frameBufferMap.erase(fbNode); 54835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 548889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 548989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 54905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 5492b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 54945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 549689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 549789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 54985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 549947892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 550047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 55015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5503b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 550501f3372271027b700265e5fbdbef5ad9c3b94649Tobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, BUFFER_NODE(pCreateInfo))); 55065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 551089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 551189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 55125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 55145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5515b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap[*pView] = VkBufferViewCreateInfo(*pCreateInfo); 551703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 55195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 55200a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_buffer_usage_flags(dev_data, pCreateInfo->buffer, 5521e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, 55225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 55235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 552889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 552989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 55305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 553147892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 553247892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 55335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5535b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 55385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 553901f3372271027b700265e5fbdbef5ad9c3b94649Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, IMAGE_NODE(pCreateInfo))); 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 55415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 55425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 55435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 5548b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 55555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->levelCount = image_node_it->second.createInfo.mipLevels - range->baseMipLevel; 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 55615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->layerCount = image_node_it->second.createInfo.arrayLayers - range->baseArrayLayer; 55625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 55685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 5570b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 55735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 55745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 55755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 55775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = image_node_it->second.createInfo.mipLevels - range.baseMipLevel; 55785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 55805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = image_node_it->second.createInfo.arrayLayers - range.baseArrayLayer; 55815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 558589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 558689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 5587bb6624cb996175d8945190886a200e720b3871efChris Forbes bool skipCall = false; 5588bb6624cb996175d8945190886a200e720b3871efChris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 55895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5590bb6624cb996175d8945190886a200e720b3871efChris Forbes { 5591bb6624cb996175d8945190886a200e720b3871efChris Forbes // Validate that img has correct usage flags set 5592bb6624cb996175d8945190886a200e720b3871efChris Forbes std::lock_guard<std::mutex> lock(global_lock); 5593bb6624cb996175d8945190886a200e720b3871efChris Forbes skipCall |= validate_image_usage_flags(dev_data, pCreateInfo->image, 5594bb6624cb996175d8945190886a200e720b3871efChris Forbes VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 5595bb6624cb996175d8945190886a200e720b3871efChris Forbes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 5596bb6624cb996175d8945190886a200e720b3871efChris Forbes false, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 5597bb6624cb996175d8945190886a200e720b3871efChris Forbes } 5598bb6624cb996175d8945190886a200e720b3871efChris Forbes 5599bb6624cb996175d8945190886a200e720b3871efChris Forbes if (!skipCall) { 5600bb6624cb996175d8945190886a200e720b3871efChris Forbes result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 5601bb6624cb996175d8945190886a200e720b3871efChris Forbes } 5602bb6624cb996175d8945190886a200e720b3871efChris Forbes 56035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5604b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 56055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageViewCreateInfo localCI = VkImageViewCreateInfo(*pCreateInfo); 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &localCI.subresourceRange, pCreateInfo->image); 56075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap[*pView] = localCI; 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5609bb6624cb996175d8945190886a200e720b3871efChris Forbes 56105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 561389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 561489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 56155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 56175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5618b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5619a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 5620a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 5621a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.needsSignaled = true; 56225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 5623a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.firstTimeFlag = true; 5624a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.needsSignaled = false; 56255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5626a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.in_use.store(0); 56275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 563289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 563389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 56345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 56365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 564089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 56415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 56435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 564689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 56475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 56495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 565389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 56545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 56565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56593d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 56603d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 56613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 56623d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 56633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 56643d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 56653d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 56663d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 56673d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 56683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 56693d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 56703d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 56713d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 56723d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 56733d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 56743d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 56753d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 56763d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 56773d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 56783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 56793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 568089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 568189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 568289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 568389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 56845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 56855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 56865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 56875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 56885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 56895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 5690e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 56915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 56925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 56935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5696b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 5699ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5700ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 57013ce94c3c0281078b41205789567c563991a8737eChris Forbes 57023ce94c3c0281078b41205789567c563991a8737eChris Forbes auto renderpass_it = dev_data->renderPassMap.find(pCreateInfos[i].renderPass); 57033ce94c3c0281078b41205789567c563991a8737eChris Forbes if (renderpass_it != dev_data->renderPassMap.end()) { 57043ce94c3c0281078b41205789567c563991a8737eChris Forbes pPipeNode[i]->renderPass = renderpass_it->second; 57053ce94c3c0281078b41205789567c563991a8737eChris Forbes } 57063ce94c3c0281078b41205789567c563991a8737eChris Forbes 570767220c96300606b517394e25c7aa144dd4601bb6Chris Forbes auto pipeline_layout_it = dev_data->pipelineLayoutMap.find(pCreateInfos[i].layout); 570867220c96300606b517394e25c7aa144dd4601bb6Chris Forbes if (pipeline_layout_it != dev_data->pipelineLayoutMap.end()) { 570967220c96300606b517394e25c7aa144dd4601bb6Chris Forbes pPipeNode[i]->pipelineLayout = &pipeline_layout_it->second; 571067220c96300606b517394e25c7aa144dd4601bb6Chris Forbes } 571167220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 57125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 57135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5715e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 5716b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 57185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5719b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 57205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 57225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 57235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5724b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57275188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 57285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5729b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 57315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 573589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 573689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 573789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 573889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 57395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 5740e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 57435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 57445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5747b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 57485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 57505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 57525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5753ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 575467220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 575567220c96300606b517394e25c7aa144dd4601bb6Chris Forbes auto pipeline_layout_it = dev_data->pipelineLayoutMap.find(pCreateInfos[i].layout); 575667220c96300606b517394e25c7aa144dd4601bb6Chris Forbes if (pipeline_layout_it != dev_data->pipelineLayoutMap.end()) { 575767220c96300606b517394e25c7aa144dd4601bb6Chris Forbes pPipeNode[i]->pipelineLayout = &pipeline_layout_it->second; 575867220c96300606b517394e25c7aa144dd4601bb6Chris Forbes } 5759ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 57605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 57625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 57635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5765e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 5766b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 57685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5769b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 57705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5774b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 57775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 57795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5780b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 57825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 578689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 578789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 57885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 57905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5791b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5792cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 57935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 579789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 579889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 579989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 58005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 58025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 58035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 5804b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5805cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = 5806cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis new cvdescriptorset::DescriptorSetLayout(dev_data->report_data, pCreateInfo, *pSetLayout); 58075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58119e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 58129e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 58139e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 58149e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 58159e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 58165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 58179e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 58189e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 58199e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 58209e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 58219e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 58229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 58239e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58249e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with offset %u and size %u that " 58259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 58269e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset, size, maxPushConstantsSize); 58279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 58289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58299e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 58309e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 58319e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, offset, size, maxPushConstantsSize); 58329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 58339e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58349e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 58359e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58369e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58379e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 58389e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 58399e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 58409e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 58419e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58429e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 58439e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 58449e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, size); 58459e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 58469e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 58479e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58489e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 58499e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 58509e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 58519e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 58529e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58539e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 58549e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58559e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58569e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 58579e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 58589e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 58599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58609e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 58619e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "offset %u. Offset must be a multiple of 4.", 58629e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset); 58639e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 58649e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58659e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 58669e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "offset %u. Offset must be a multiple of 4.", 58679e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, offset); 58689e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 58699e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58709e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 58719e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 58745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 587689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 587789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 58785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 58795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58809e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 58815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 58825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 58839e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 58849e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 58859e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 58869e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58879e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 58889e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58899e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58909e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 58919e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (!skipCall) { 58929e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t i, j; 58939e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 58949e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 58959e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 58969e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 58979e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 58989e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 58999e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 59009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 5901a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 59029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 59039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 59049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz i, minA, maxA, j, minB, maxB); 59059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 59075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5909f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 5910f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes if (skipCall) 5911f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 5912f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 59135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 59145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5915b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 59175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); 5918f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes plNode.setLayouts.resize(pCreateInfo->setLayoutCount); 59195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 59205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; 5921f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes auto set_layout_it = dev_data->descriptorSetLayoutMap.find(pCreateInfo->pSetLayouts[i]); 5922f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes if (set_layout_it != dev_data->descriptorSetLayoutMap.end()) { 5923f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes plNode.setLayouts[i] = set_layout_it->second; 5924f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes } 5925f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes else { 5926f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes plNode.setLayouts[i] = nullptr; 5927f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes } 59285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); 59305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 59315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; 59325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 593789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 593889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 593989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 59405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 59425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 59435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 59445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 5945414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 59465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 59475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 59495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 59505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 59515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 59525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 59535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5955b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 59575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 59595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 59605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 596489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 596589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 59665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 59685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5969b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 597589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 597689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 5977e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5980b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 59815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that requested descriptorSets are available in pool 59825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 59835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPoolNode) { 59845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 59855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 5986414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unable to find pool node for pool 0x%" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 59875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool); 59885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Make sure pool has all the available descriptors before calling down chain 59895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->descriptorSetCount, 59905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->pSetLayouts); 59915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5992b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 59945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 59965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5997b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 59985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 59995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode) { 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pAllocateInfo->descriptorSetCount == 0) { 60015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->descriptorSetCount, __LINE__, DRAWSTATE_NONE, "DS", 60035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "AllocateDescriptorSets called with 0 count"); 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) { 60065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 6007414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)pDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", "Created Descriptor Set 0x%" PRIxLEAST64, 60085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i]); 6009cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis auto layout_pair = dev_data->descriptorSetLayoutMap.find(pAllocateInfo->pSetLayouts[i]); 6010cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis if (layout_pair == dev_data->descriptorSetLayoutMap.end()) { 6011cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6012cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pAllocateInfo->pSetLayouts[i], 6013414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", "Unable to find set layout node for layout 0x%" PRIxLEAST64 6014cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis " specified in vkAllocateDescriptorSets() call", 6015cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis (uint64_t)pAllocateInfo->pSetLayouts[i])) { 6016cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis lock.unlock(); 6017cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6018cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 6019cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 6020bf230ded6e1247603f278c6d1b9b828ddb5fd595Tobin Ehlis // Create new DescriptorSet instance and add to the pool's unordered_set of DescriptorSets 6021397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pNewNode = new cvdescriptorset::DescriptorSet( 6022397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis pDescriptorSets[i], layout_pair->second, &dev_data->bufferMap, &dev_data->memObjMap, &dev_data->bufferViewMap, 6023397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &dev_data->samplerMap, &dev_data->imageViewMap, &dev_data->imageMap, 6024397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &dev_data->device_extensions.imageToSwapchainMap, &dev_data->device_extensions.swapchainMap); 60255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 60265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 60275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6028397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis DRAWSTATE_OUT_OF_MEMORY, "DS", "Out of memory while attempting to allocate " 6029397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis "cvdescriptorset::DescriptorSet in vkAllocateDescriptorSets()")) { 6030b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6032ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 60335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6034cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Insert set into this pool 6035cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis pPoolNode->sets.insert(pNewNode); 60365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->in_use.store(0); 60375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->setMap[pDescriptorSets[i]] = pNewNode; 60385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6041b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 604689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 604789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 6048e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 60495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6051b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 60525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6053ce62d9f596fa03529c4961ab715473a0e9254e0eMark Mueller skipCall |= validateIdleDescriptorSet(dev_data, pDescriptorSets[i], "vkFreeDescriptorSets"); 60545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool); 60555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) { 60565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can't Free from a NON_FREE pool 60575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 60585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 60595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 60605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 60615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6062b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6063e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 60665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6067b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6068a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6069a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Update available descriptor sets in pool 6070a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets += count; 6071a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6072f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 60735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 6074397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking 60755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 6076397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t j = 0; j < pSet->GetBindingCount(); ++j) { 6077397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis typeIndex = static_cast<uint32_t>(pSet->GetTypeFromIndex(j)); 6078397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis poolSizeCount = pSet->GetDescriptorCountFromIndex(j); 60795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount; 60805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60819dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(dev_data, pSet); 6082f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis pPoolNode->sets.erase(pSet); 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6084b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any other clean-up or book-keeping to do here? 60875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 609089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 609189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 609289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 6093e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // dsUpdate will return true only if a bailout error occurs, so we want to call down tree when update returns false 60945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6095b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6096e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool rtn = dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies); 6097b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!rtn) { 60995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 61015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 610489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 610589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 61065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 61085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6109b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 611072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto const &cp_it = dev_data->commandPoolMap.find(pCreateInfo->commandPool); 611172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cp_it != dev_data->commandPoolMap.end()) { 611272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 61135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 611472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cp_it->second.commandBuffers.push_back(pCommandBuffer[i]); 61155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 61165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 61175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 61185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 61195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 61205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 61215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 612303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 61240a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 61255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 6126b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 61275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 613189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 613289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 6133e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6135b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 61375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 61385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 61395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 6140a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 6141a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= 6142a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6143a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 6144414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Calling vkBeginCommandBuffer() on active CB 0x%p before it has completed. " 6145a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 6146a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6148a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 61495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 61505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 61515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 61525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 61535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6156414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 61575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6160400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6164414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6167400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, 6171414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "valid framebuffer parameter is specified.", 61735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 61765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(pInfo->framebuffer); 61775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 61785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass fbRP = fbNode->second.createInfo.renderPass; 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, fbRP, pInfo->renderPass, errorString)) { 6180400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 61815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 61835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 61855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command " 6186414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 6187414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer), (uint64_t)(pInfo->renderPass), 61895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->framebuffer), (uint64_t)(fbRP), errorString.c_str()); 61905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 61925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fbNode->second.referencingCmdBuffers.insert(pCB->commandBuffer); 61935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6197b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 61985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 61995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 62005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6202414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 62035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "support precise occlusion queries.", 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 62095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = dev_data->renderPassMap.find(pInfo->renderPass); 62105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != dev_data->renderPassMap.end() && rp_data->second && rp_data->second->pCreateInfo) { 62115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->subpass >= rp_data->second->pCreateInfo->subpassCount) { 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6215414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 62165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that is less than the number of subpasses (%d).", 62175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)commandBuffer, pInfo->subpass, rp_data->second->pCreateInfo->subpassCount); 62185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 62235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6226414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Cannot call Begin on CB (0x%" PRIxLEAST64 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (CB_RECORDED == pCB->state) { 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6235414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 6236414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 62375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 62385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 62395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 62455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 6248888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 6249888e1d268098177fde4a2263e3d7b7cc415f1debMark Young if ((pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 6250888e1d268098177fde4a2263e3d7b7cc415f1debMark Young (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 6251ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes auto inherited_render_pass_it = dev_data->renderPassMap.find(pCB->beginInfo.pInheritanceInfo->renderPass); 6252ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = inherited_render_pass_it != dev_data->renderPassMap.end() ? inherited_render_pass_it->second : nullptr; 6253888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->activeSubpass = pCB->beginInfo.pInheritanceInfo->subpass; 6254888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->framebuffers.insert(pCB->beginInfo.pInheritanceInfo->framebuffer); 6255888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 6260414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB 0x%p!", (void *)commandBuffer); 62615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6262b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6263e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) { 62645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 62655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6267400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 62685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 627189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 6272e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 62745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6275b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 62775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6278fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 6279fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 6280fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 6281fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop skipCall |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 6282fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 62835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()"); 62855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 62875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 62885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 6289414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 62905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(query.pool), query.index); 62915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6293e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6294b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 6296b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 63005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6306b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 631089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 631189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6312bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6314b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 63175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 6318bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6319bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6320414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 6321bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 6322bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 63235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6324bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, pCB, "reset"); 6325b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6326bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 63275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 63295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6330b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 63315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 6332b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 633693c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 633703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 63385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : For any vkCmdBind* calls that include an object which has mem bound to it, 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// need to account for that mem now having binding to given commandBuffer 63405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 634189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 634289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 6343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6345b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 63525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 6353414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 6354ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass->renderPass); 63555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 63585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 635972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 63613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 6365414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 63665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6368b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6369e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 63705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 63715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 637389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 637489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 6375e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6377b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 63815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 63825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 63835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 63845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6385b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6386e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 63875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 63885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 639089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 639189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 6392e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6394b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 63985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 63995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 64005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 64015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6402b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6403e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 640789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 6408a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 64095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6410b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6413a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 64145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 6415a27508babf63d50aea75883a3702979193c23683Mark Young 6416a27508babf63d50aea75883a3702979193c23683Mark Young PIPELINE_NODE *pPipeTrav = getPipeline(dev_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 6417a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 6418a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 6419a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 6420386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 6421a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 6422a27508babf63d50aea75883a3702979193c23683Mark Young } else { 6423a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 6424a27508babf63d50aea75883a3702979193c23683Mark Young } 64255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6426b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6427a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 64285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 64295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 643189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 643289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 6433e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6435b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6441b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6442e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 64445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 644789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 6448e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6450b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 64543d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6456b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6457e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 64595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 646189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 646289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 6463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6465b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 64695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6471b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6472e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 647689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 647789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 6478e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6480b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 64855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6486b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6487e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 64895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 649189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 649289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 6493e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6495b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 64995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6501b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6502e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 650689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 650789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 6508e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6510b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 65145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6516b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 65185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 65195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 652189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 652289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 652389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 652489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 6525e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 65265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6527b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 6531787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 6532787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 6533787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 6534787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 653572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) 653672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 653772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 6538787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 6539397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 6540787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 654172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pDescriptorSets[i]); 6542397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis pSet->BindCommandBuffer(commandBuffer); 654372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipelineLayout = layout; 654472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pDescriptorSets[i]; 6545787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 6546787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6547414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DS 0x%" PRIxLEAST64 " bound on pipeline %s", 6548787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 6549397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 6550787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 6551787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 6552787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 6553414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 6554787f29d93dee194c015789cf61c079504c980572Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 6555787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 6556787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6557787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 6558787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, layout, i + firstSet, errorString)) { 6559787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6560e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6561e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 6562e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 6563414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 6564e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 6565787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6566397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetDynamicDescriptorCount()) { 6567787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 6568397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if ((totalDynamicDescriptors + pSet->GetDynamicDescriptorCount()) > dynamicOffsetCount) { 6569787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= 6570787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6571787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6572787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 6573414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 6574787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 6575787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 6576397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 6577787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 6578787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 6579787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 6580787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 6581397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 6582397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 6583787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6584787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6585b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 6586787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 6587787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6588787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6589787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 6590787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6591414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 6592787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6593b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 6594787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6595787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 6596397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 6597787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6598787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6599b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 6600787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 6601787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6602787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6603787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 6604787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6605414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 6606787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6607b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 66085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6609787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 66105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6612787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 6613397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis totalDynamicDescriptors += pSet->GetDynamicDescriptorCount(); 66145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6616787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 6617787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6618787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6619414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS 0x%" PRIxLEAST64 " that doesn't exist!", 6620787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 66215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 662272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 662372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 662472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 662572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 662672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 662772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility( 662872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data, dev_data->setMap[pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i]], layout, i, 662972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis errorString)) { 663072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg( 663172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 663272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 663372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 6634414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DescriptorSetDS 0x%" PRIxLEAST64 6635414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 663672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 663772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 663872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 663972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 664072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 664172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 664272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 664372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 664472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, 66455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorString)) { 664672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= 664772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 664872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)oldFinalBoundSet, __LINE__, 6649414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DescriptorSetDS 0x%" PRIxLEAST64 6650414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 665172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 6652414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 665372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)oldFinalBoundSet, lastSetIndex, 665472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 665572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 665672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 66575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6660787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 6661787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 6662787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6663787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 6664787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 6665787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 6666787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 6667787f29d93dee194c015789cf61c079504c980572Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 6668787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6669787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Save dynamicOffsets bound to this CB 6670787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < dynamicOffsetCount; i++) { 6671e576798e0a38a7d941b6202d784ad705024e9fdcTobin Ehlis pCB->lastBound[pipelineBindPoint].dynamicOffsets.emplace_back(pDynamicOffsets[i]); 6672787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 66735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 66755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6677b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6678e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 66795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 66805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 66815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 668389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 668489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 6685e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 66865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6687b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 668803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 66895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 66910a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 669272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 669372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6694e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindIndexBuffer()"); }; 669572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 67015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 67055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 67105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 67115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 67135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 6717414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkIndexType(indexType)); 67195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND; 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6722b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6723e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 67245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 67255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 67285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 67295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 67305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 67335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 67345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6737e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 67385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 673989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 674089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 674189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 6742e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6744b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 674503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 67465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 67475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 67480a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)pBuffers[i], VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 674972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 675072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6751e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindVertexBuffers()"); }; 675272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 67535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 67565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 67575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 67595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 67605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTracking(pCB, firstBinding, bindingCount, pBuffers); 67615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 67635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6764b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6765e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 67665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 67675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6769b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 6770e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 67715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 67727a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 67737a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 67747a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto iv_data = dev_data->imageViewMap.find(imageView); 67757a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (iv_data == dev_data->imageViewMap.end()) 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 67777a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkImage image = iv_data->second.image; 67787a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 67797a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skip_call |= 67800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 6781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 67827a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 6783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 67847a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 67857a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 67867a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 67877a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 67887a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 67890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skip_call |= get_mem_binding_from_object(dev_data, (uint64_t)buffer, 67907a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 6791e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 67927a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true); 6793e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 67947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 67957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 67965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 680089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 680189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 6802e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6804b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 68085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 6809e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 68107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 6814414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW]++); 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 68205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6821b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6822e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 68245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 682689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 682789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 68295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6830e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6831b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 6836e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 68377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 68405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 6841414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 68425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6843e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6848b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6849e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 68515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 68525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 685489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 685589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6857e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6858b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 685903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 68630a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndirect"); 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 68695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDIRECT]++; 6870e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 68717a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 6875414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6877e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6882b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6883e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 688789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 688889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 6889e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6891b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 689203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 68935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 68945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 68960a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndexedIndirect"); 68985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 68995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 69025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED_INDIRECT]++; 6903e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 69047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 6908414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting DS state:", 69095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 69105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6911e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 69125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 69135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); 69155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6916b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6917e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 69195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 692189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 6922e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6924b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 692722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 69287a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 69297a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 69307a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 69335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6934b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6935e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 693989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 694089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 6941e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6943b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 694403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 69455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 69470a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDispatchIndirect"); 69495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 69505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 695222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 69537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 69547a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 69557a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); 69585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6959b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6960e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 69625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 696489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 696589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 6966e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6968b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 696903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 69705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 697172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 69725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 69730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 697472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6975e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBuffer()"); }; 697672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 69775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 698172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6982e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 6984e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 698672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 69875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 69900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 69915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 69920a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 69935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 69945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 69955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer"); 69995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7000b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7001e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 70035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7005e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageSubresourceLayers subLayers, 7006e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout srcImageLayout) { 7007e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 70085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 70105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 70135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, srcImage, sub, node)) { 701608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 70175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 70295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 70315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 70385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 70395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 70425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageSubresourceLayers subLayers, 7045e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout destImageLayout) { 7046e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 70475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 70495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 70505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 70525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 70535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, destImage, sub, node)) { 705508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 70595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 70605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 70625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 70675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 70685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 70705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 70745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 70755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 70765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 70775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 70805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 708289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 708389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 708489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 7085e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7087b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 708803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 70895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 709072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 70915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 70920a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 709372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7094e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImage()", srcImage); }; 709572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 70965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 70985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 70990a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 710072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7101e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 71025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7103e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 710572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 71065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 71080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 71095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 71100a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 71115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 71125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 71135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE, "vkCmdCopyImage()"); 71165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage"); 71175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 71185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].srcSubresource, srcImageLayout); 71195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].dstSubresource, dstImageLayout); 71205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7122b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7123e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 71255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 71265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 712889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 712989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 713089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 7131e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7133b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 713403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 71355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 713672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 71375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 71380a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 713972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7140e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBlitImage()", srcImage); }; 714172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 71425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 71445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 71450a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 714672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7147e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 71485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7149e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 71505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 715172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 71525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 71540a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 71555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 71560a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 71575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 71585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 71595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE, "vkCmdBlitImage()"); 71625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage"); 71635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7164b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7165e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 71675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 71685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 717089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 717189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 717289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7173e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7175b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 717603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 71775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 717872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 71790a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 718072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7181e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 71825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7183e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 71845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 718572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 71865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 71885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 71890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 719072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7191e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBufferToImage()"); }; 719272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 71935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 71955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src buff & dst image have correct usage flags set 71960a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 71975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 71980a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 71995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 72005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 72015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 72045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage"); 72055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 72065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].imageSubresource, dstImageLayout); 72075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7209b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7210e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 72125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 72135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 721589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 721689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 721789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7218e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7220b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 722103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 72225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 722372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 72240a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 722572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7226e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7227e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImageToBuffer()", srcImage); 7228e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 722972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 72305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 72325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 72330a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 723472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7235e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 72365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7237e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 723972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 72405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 72425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff & src image have correct usage flags set 72430a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 72445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 72450a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 72465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 72475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 72485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 72515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer"); 72525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 72535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].imageSubresource, srcImageLayout); 72545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7256b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7257e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 72595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 72605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 726289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 726389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 7264e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7266b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 726703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 72685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 726972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 72705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 72710a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 727272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7273e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7275e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 727772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 72785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdUpdateBuffer"); 72805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 72810a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 72825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 72835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 72845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 72875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer"); 72885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7289b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7290e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 729489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 729589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 7296e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7298b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 729903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 73005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 730172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 73025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 73030a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 730472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7305e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7307e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 730972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 73105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdFillBuffer"); 73125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 73130a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 73145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdFillBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 73195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer"); 73205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7321b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7322e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 73245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 732689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 732789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 732889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 7329e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7331b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 73355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 73365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 73375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 73395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 73405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 73425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 73435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 73455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 73465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 73475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandBuffer)); 73485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); 73505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 73535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 7354ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->pCreateInfo; 73555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 73565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 73585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 73595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 7360e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 73615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 73625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 7363e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 73645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7367e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 73685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 73695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 73705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 73715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 73725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 73735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 73755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 73765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 73775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 73785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 73805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 73815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 73825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 73835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 73845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 73855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 73865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 73875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7391b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7392e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 73945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 739689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 739789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 739889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 7399e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7401b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 740203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 74035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 74045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 740572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 74060a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 740772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7408e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7410e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 741272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 74135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearColorImage"); 74155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 74165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 74195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage"); 74205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7421b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7422e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 74245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 742689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 742789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 742889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 742989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 7430e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7432b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 743303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 74345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 74355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 743672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 74370a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 743872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7439e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7441e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 744372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 74445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearDepthStencilImage"); 74465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 74475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 74505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage"); 74515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7452b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7453e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 74555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 74565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 745889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 745989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 746089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 7461e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7463b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 746403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 746572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 74665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 74670a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 746872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdResolveImage()", srcImage); }; 747072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 74735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 74740a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 747572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7476e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7478e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 748072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 74815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 74835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 74845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 74875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage"); 74885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7489b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7490e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 74925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7495b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7496b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7497b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 7498b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 7499b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 7500b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7501b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 7502b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 7503b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 7504b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7505b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 7506b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 7507b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 750889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 750989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7510e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7512b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7518b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7519b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 7520b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7522b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7523e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 752789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 752889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7529e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7531b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 75355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 75365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7537b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7538b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 7539b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7541b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7542e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7546e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7547e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 75485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 7550e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 75525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 75535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 75555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 75565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 75575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 75595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 75615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 75645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 75655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 75675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 75685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 756908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 757008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 75745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 75785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 7589e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 75925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 75945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 75955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 75975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 75995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 76005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 76045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 76095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 76105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 7611e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7612e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 7613e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 7614e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 761743986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 76185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 76195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 76225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 76235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 76266044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 76295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 76345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 76355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 76375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 76385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76396044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 76415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 76435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 76445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7650e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7651e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 7652e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 76545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 76555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 76575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 76695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 76705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 76735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 76745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 76755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 76785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 76805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 76845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 76875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 76885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 76895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 77005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7702e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7703e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 7704e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 7705e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 7706e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 77085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 77095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 7710ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 77115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 77135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 77145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 77155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 77185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 77205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 77215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 77225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 77235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data->second.createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 77245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 77265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 77275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 77285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 77305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 77315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 77335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 77365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 77385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 77395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 77405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 77455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 77465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 77475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 7748b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 7749b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 77505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 77515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 77525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 77535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 77545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 77555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 77565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 7757b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 77585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 77635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 77655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 77675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 77685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 77705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 77725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 77741d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 77751d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 77775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = image_data->second.createInfo.format; 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = image_data->second.createInfo.arrayLayers; 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = image_data->second.createInfo.mipLevels; 77815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imageswap_data = dev_data->device_extensions.imageToSwapchainMap.find(mem_barrier->image); 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageswap_data != dev_data->device_extensions.imageToSwapchainMap.end()) { 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(imageswap_data->second); 77865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = swapchain_data->second->createInfo.imageFormat; 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = swapchain_data->second->createInfo.imageArrayLayers; 77895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 77905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 77965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 77975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 77985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 78005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 78015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 78025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 78035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7804f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 7805f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 7806f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 7807f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 78085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 78105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 78115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 78125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 78135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 78145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7815f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 7816f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 7817f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 7818f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 78195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 78215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 78225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 78235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 78245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 78305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 78315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 78325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 78335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 78375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 78385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 78405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 7841b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 78425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 7843b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 78445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 78465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 78475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 78485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 7849b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 78505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = dev_data->bufferMap.find(mem_barrier->buffer); 78535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != dev_data->bufferMap.end()) { 7854672a7ee979486eaec10f96063f0455e8c2a02595Karl Schultz VkDeviceSize buffer_size = (buffer_data->second.createInfo.sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO) 7855672a7ee979486eaec10f96063f0455e8c2a02595Karl Schultz ? buffer_data->second.createInfo.size 7856672a7ee979486eaec10f96063f0455e8c2a02595Karl Schultz : 0; 78575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 785894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 785994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 786094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 7861414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ".", 786294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 786394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 78645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 786594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 786694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7867414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 7868414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 786994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 787094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 787194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 78725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 78765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78782ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 7879b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 7880b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 7881b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 7882b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 78832ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 7884b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 7885b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 7886b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 78872ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 7888b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 7889b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 7890b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 78912ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto global_event_data = dev_data->eventMap.find(event); 7892b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (global_event_data == dev_data->eventMap.end()) { 7893b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 789427c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 789527c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 78962ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 7897b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 7898b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= global_event_data->second.stageMask; 7899b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7900b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7901b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7902b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (sourceStageMask != stageMask) { 7903b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= 7904b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 790527c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes DRAWSTATE_INVALID_EVENT, "DS", 7906b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "Submitting cmdbuffer with call to VkCmdWaitEvents using srcStageMask 0x%x which must be the bitwise OR of the " 7907b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "stageMask parameters used in calls to vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if used with vkSetEvent.", 7908b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine sourceStageMask); 7909b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7910b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 7911b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 7912b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 791389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 791489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 791589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 791689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 791789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 7918e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7920b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79232ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 79245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 79255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.push_back(pEvents[i]); 79265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 79275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7928b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 79292ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 7930b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 79315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 79325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 79335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 79355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 79375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7941b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7942e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 794889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 794989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 795089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 795189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 795289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 7953e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7955b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7964b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7965e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 79685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 79695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 797189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 797289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 7973e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7975b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 79815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 79825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 79845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7985b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7986e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 79885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 799089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 7991e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7993b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 79975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 79985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8000414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 80065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 80085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 80105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8012b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8013e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 80155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 801789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 801889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 8019e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8021b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 80255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 80265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 80275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 0; 80285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 80355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8036b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8037e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 804189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 804289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 804389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 8044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8046b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 804803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 805072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 80520a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 805372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8054e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 8056e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 805872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyQueryPoolResults"); 80615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that DST buffer has correct usage flags set 80620a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 80635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 80645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 80675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 80685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->queryToStateMap[query]) { 80695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 80705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 8071414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 80725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 80735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 80775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 80795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); 80815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8082b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8083e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 80855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 80865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 808889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 808989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 809089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 80915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 80925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8093b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 80985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 81005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 81039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 81049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 81069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 81079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 8108a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 81099e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz auto pipeline_layout_it = dev_data->pipelineLayoutMap.find(layout); 81109e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (pipeline_layout_it == dev_data->pipelineLayoutMap.end()) { 81119e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8112a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Pipeline Layout 0x%" PRIx64 " not found.", 81139e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz (uint64_t)layout); 81149e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 8115a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 8116a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // contained in the pipeline ranges. 8117a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Build a {start, end} span list for ranges with matching stage flags. 8118a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz const auto &ranges = pipeline_layout_it->second.pushConstantRanges; 8119a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz struct span { 8120a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz uint32_t start; 8121a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz uint32_t end; 8122a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz }; 8123a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span> spans; 8124a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz spans.reserve(ranges.size()); 8125a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz for (const auto &iter : ranges) { 8126a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (iter.stageFlags == stageFlags) { 8127a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz spans.push_back({iter.offset, iter.offset + iter.size}); 81289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 81299e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 8130a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (spans.size() == 0) { 8131a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // There were no ranges that matched the stageFlags. 8132a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8133a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", 8134a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 8135a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 8136a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz (uint32_t)stageFlags, (uint64_t)layout); 8137a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } else { 8138a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Sort span list by start value. 8139a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz struct comparer { 8140a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz bool operator()(struct span i, struct span j) { return i.start < j.start; } 8141a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } my_comparer; 8142a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::sort(spans.begin(), spans.end(), my_comparer); 8143a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 8144a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Examine two spans at a time. 8145a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span>::iterator current = spans.begin(); 8146a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span>::iterator next = current + 1; 8147a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz while (next != spans.end()) { 8148a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (current->end < next->start) { 8149a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // There is a gap; cannot coalesce. Move to the next two spans. 8150a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz ++current; 8151a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz ++next; 8152a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } else { 8153a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Coalesce the two spans. The start of the next span 8154a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // is within the current span, so pick the larger of 8155a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // the end values to extend the current span. 8156a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Then delete the next span and set next to the span after it. 8157a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz current->end = max(current->end, next->end); 8158a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz next = spans.erase(next); 8159a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8160a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8161a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 8162a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Now we can check if the incoming range is within any of the spans. 8163a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz bool contained_in_a_range = false; 8164a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz for (uint32_t i = 0; i < spans.size(); ++i) { 8165a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 8166a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz contained_in_a_range = true; 8167a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz break; 8168a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8169a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8170a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (!contained_in_a_range) { 8171a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8172a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz __LINE__, DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", 8173a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "vkCmdPushConstants() Push constant range [%d, %d) " 8174a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "with stageFlags = 0x%" PRIx32 " " 8175a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 8176a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 8177a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 81789e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 81795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8180b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 81815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 81825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 81835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 818589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 818689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 8187e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8189b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 81935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 81955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 81965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 81985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8200b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8201e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 82025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 82035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 820589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 820689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 820789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 82085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 82095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 82105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 82115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 8212b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 8213fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes 8214fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto & fbNode = dev_data->frameBufferMap[*pFramebuffer]; 8215fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo = *pCreateInfo; 82165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 8217fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto attachments = new VkImageView[pCreateInfo->attachmentCount]; 8218fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes memcpy(attachments, 8219fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->pAttachments, 8220fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->attachmentCount * sizeof(VkImageView)); 8221fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo.pAttachments = attachments; 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 82245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 82255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data = dev_data->imageViewMap.find(view); 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data == dev_data->imageViewMap.end()) { 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 82285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 82300a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(view_data->second.image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 82315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis &fb_info.mem); 82325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_info.image = view_data->second.image; 8233fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.attachments.push_back(fb_info); 82345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8239e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 8240e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 82415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 82425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 8243e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 82455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 82485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 82495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 8250e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 82515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8253e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 82545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8255e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8258e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 8259e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 8260e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 82625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 82631d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 82645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 82675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 82685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 82695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 82705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error. 82715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 82725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 82735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) { 82743da84689683bb257cc0f64953966666d19321119Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 82755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 82765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but only an implicit one is specified.", 82775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass, dependent_subpasses[k]); 82785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 82805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 82815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 82825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 8283e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8290e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 8291e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 82925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 82935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 82945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 82955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 8297e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 82985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 83005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 8301e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8303e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 83045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 83055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 83065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 83075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 83095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 83105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 8311e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 83135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 8314e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8318e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 83195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 83225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 83265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 83305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 83315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 83345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 83355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 83365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8338e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateDependencies(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin, 8339e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node) { 8340e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 83415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 83425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pCreateInfo = my_data->renderPassMap.at(pRenderPassBegin->renderPass)->pCreateInfo; 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 83445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 83465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 83485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 83515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 83525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_i = my_data->imageViewMap.find(viewi); 83575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_j = my_data->imageViewMap.find(viewj); 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i == my_data->imageViewMap.end() || view_data_j == my_data->imageViewMap.end()) { 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i->second.image == view_data_j->second.image && 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRegionOverlapping(view_data_i->second.subresourceRange, view_data_j->second.subresourceRange)) { 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 83655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_i = my_data->imageMap.find(view_data_i->second.image); 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_j = my_data->imageMap.find(view_data_j->second.image); 83695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i == my_data->imageMap.end() || image_data_j == my_data->imageMap.end()) { 83705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i->second.mem == image_data_j->second.mem && 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(image_data_i->second.memOffset, image_data_i->second.memSize, image_data_j->second.memOffset, 83745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_data_j->second.memSize)) { 83755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 83765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 83815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 83835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 83895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 83915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 83945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 83955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 84001c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 84025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 84031c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 84055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 84085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 84165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84171c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 84185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 84205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 84215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 84225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 84235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 84245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84251c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 84261c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 84271c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 84281c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 84291c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 84301c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 84311c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 84321c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 84335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 84365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 84375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 84385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 84395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 84405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pInputAttachments[j].attachment; 84415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 84445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 84455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pColorAttachments[j].attachment; 84465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 84515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 84565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 84575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 84585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 84595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 84615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 84645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8465be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 8466be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 8467be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 8468be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 8469be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 8470be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 8471be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 8472be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 8473be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 8474be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 8475be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 8476be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 8477be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 8478be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 8479be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 8480be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8481be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8482be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 8483be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 84845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8485e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 8486e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 84875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 84895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 84945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 84955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 84965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 84975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84994d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 85025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8505be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 8506be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pInputAttachments[j].layout, attach_index, 8507be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis pCreateInfo->pAttachments[attach_index]); 85085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 85105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 85115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 85135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 85145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 85165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85174d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 85205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 85215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8523be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pColorAttachments[j].attachment; 8524be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pColorAttachments[j].layout, attach_index, 8525be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis pCreateInfo->pAttachments[attach_index]); 85265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 85285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 85295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 85305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 85325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 85345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 85364d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8542be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 8543be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pDepthStencilAttachment->layout, 8544be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 85455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 85485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8550e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 8551e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 8552e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 85545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 85555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 85565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 85585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 85595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 85605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 85615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 85635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 85645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 85655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 85675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 85685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 85695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 85715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 85745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 85755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 85785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8579918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 858189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 858289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 858389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 8585e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 8586b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8587b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 8588b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 8589b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 8590b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 8591b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8592b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 8593b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 8594b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes skip_call |= log_msg(my_data->report_data, 8595b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 8596b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes VkDebugReportObjectTypeEXT(0), 0, 8597b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", "SPIR-V module not valid: %s", 8598b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes diag && diag->error ? diag->error : "(no error text)"); 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8601b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 8602b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 8603b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8604e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 86065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 8610b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 8611918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 86145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 861689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 861789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 861889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkRenderPass *pRenderPass) { 8619e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 86205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create DAG 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 8624cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes { 8625cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::lock_guard<std::mutex> lock(global_lock); 8626cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 8627cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes // Validate 8628cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 8629cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes if (skip_call) { 8630cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 8631cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes } 86325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge in tracking of renderpass from shader_checker 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 86415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 86495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 86515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 86525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 86535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 86555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 86605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 86615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 86655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 86705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 86715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 86725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 86755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 86765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 86795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 86805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 86815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 86825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8683cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes 8684cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes auto render_pass = new RENDER_PASS_NODE(localRPCI); 868598cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 8686cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 8687cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 868887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 868987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 869087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 869187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 869287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 869387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 869487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 869587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 8696cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->attachments.push_back(pass_info); 869787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 869887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 8699cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 870087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = 8701cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->attachment_first_layout; 870287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 870387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 8704b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 8705b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8706b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 8707b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine "Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 8708b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine } 87090d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 87100d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment = subpass.pPreserveAttachments[j]; 87110d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount) { 87120d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87130d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 87140d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Preserve attachment %d cannot be greater than the total number of attachments %d.", 87150d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 87160d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 87170d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 871887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 87190d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment; 87200d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (subpass.pResolveAttachments) { 87210d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pResolveAttachments[j].attachment; 87220d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount && attachment != VK_ATTACHMENT_UNUSED) { 87230d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87240d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 87250d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 87260d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 87270d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine continue; 87280d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 87290d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 87300d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pColorAttachments[j].attachment; 873124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 873224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 873324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 873424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 873524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 873624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 873724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 873887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 873987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 874087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 874187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 874287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 874387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 874487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 874524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 874624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 874724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 874824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Depth stencil attachment %d cannot be greater than the total number of attachments %d.", 874924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 875024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 875124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 875287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 875387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 875487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 875587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 875687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 8757a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 8758a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 875924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 876024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 876124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 876224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Input attachment %d cannot be greater than the total number of attachments %d.", 876324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 876424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 876524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 8766a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine if (attachment_first_read.count(attachment)) 8767a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine continue; 8768a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_read.insert(std::make_pair(attachment, true)); 8769a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 8770a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 877187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 877287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 8773cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes { 8774cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::lock_guard<std::mutex> lock(global_lock); 8775cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes dev_data->renderPassMap[*pRenderPass] = render_pass; 8776cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes } 87775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 87825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.size() <= 0) 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 87845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->renderPassMap.begin(); ii != my_data->renderPassMap.end(); ++ii) { 87855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = (*ii).second->pCreateInfo; 87865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 87895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 87935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 87945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 87955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 87965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 87975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 87995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 88025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 88045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 88055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 88065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 88085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8810e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 8811e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 88145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer].createInfo; 88165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 88195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 88225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageViewMap.find(image_view); 88245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_data != dev_data->imageViewMap.end()); 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_data->second.image; 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->second.subresourceRange; 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 88295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 88305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 88375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (newNode.layout != node.layout) { 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using attachment %i " 88445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "where the " 8845d6c1882c31a88ae01b94f3135679f739287be31aKarl Schultz "initial layout is %s and the layout of the attachment at the " 88461c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine "start of the render pass is %s. The layouts must match.", 88471c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 88535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8855e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, 8856e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 88575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 88595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 88615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 88645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 88675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pRenderPassInfo->pSubpasses[subpass_index]; 88705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pInputAttachments[j].attachment]; 88725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pInputAttachments[j].layout); 88735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 88755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pColorAttachments[j].attachment]; 88765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pColorAttachments[j].layout); 88775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 88795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pDepthStencilAttachment->attachment]; 88805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pDepthStencilAttachment->layout); 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8884e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 8885e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 88875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 88895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 88905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8894e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 88955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 88965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8913e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 8914885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 8915885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 8916885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 8917885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 8918885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 8919885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 8920885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 8921885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8922885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 8923885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 8924885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 8925885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 8926885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 8927885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 8928885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 8929885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 8930885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 8931885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 893289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 893389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 8934e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8936b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassBegin && pRenderPassBegin->renderPass) { 894087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGE 894187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 894287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 894387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 894487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->fb = pRenderPassBegin->framebuffer; 894572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 894687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 894787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 894887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_CLEAR) { 894972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8950e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 8952e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 895472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 89555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 895687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_DONT_CARE) { 895772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8958e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 89595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 8960e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 89615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 896272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 89635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 896487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_LOAD) { 896572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8966e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 896972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 89705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 897287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachment_first_read[pRPNode->attachments[i].attachment]) { 897372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8974e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 89755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 89765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 897772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 89785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 8983e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 89845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin); 8985ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 89865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 89875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data != dev_data->renderPassMap.end()) { 89885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateDependencies(dev_data, pRenderPassBegin, render_pass_data->second->subpassToNode); 8989ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = render_pass_data->second; 8990ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes } 8991ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes else { 8992ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 89935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 89955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 89965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 89975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 89985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 89995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 900093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.insert(pRenderPassBegin->framebuffer); 90015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 900293c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski dev_data->frameBufferMap[pRenderPassBegin->framebuffer].referencingCmdBuffers.insert(pCB->commandBuffer); 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9009b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9010e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 90115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 90125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 901589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 9016e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 90175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9018b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 90225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 90235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 90245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 90255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 90275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9028b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9029e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 903389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 9034e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9036b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 903703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 903872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 903972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9040ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes RENDER_PASS_NODE* pRPNode = cb_data->second->activeRenderPass; 9041ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (pRPNode) { 904287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 904387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 904487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_STORE) { 904572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9046e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 90475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 9048e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 905072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 905287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_DONT_CARE) { 905372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9054e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 90555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 9056e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 905872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 90695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo); 9071ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 90725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 90735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9074b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9075e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 90765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 90775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90795121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, 90805121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes RENDER_PASS_NODE const *primaryPass, uint32_t primaryAttach, uint32_t secondaryAttach, 9081e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *msg) { 90825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9084414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a render pass 0x%" PRIx64 9085414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current render pass 0x%" PRIx64 "." 908681264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom "Attachment %" PRIu32 " is not compatible with %" PRIu32 ". %s", 90875121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes (void *)secondaryBuffer, (uint64_t)(secondaryPass->renderPass), (uint64_t)(primaryPass->renderPass), primaryAttach, secondaryAttach, 90885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis msg); 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90915121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, RENDER_PASS_NODE const *primaryPass, 90925121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes uint32_t primaryAttach, VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, 9093e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 90945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 90955121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->attachmentCount <= primaryAttach) { 90965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 90975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90985121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (secondaryPass->pCreateInfo->attachmentCount <= secondaryAttach) { 90995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 91005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 91025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 91055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The first is unused while the second is not."); 91075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 91105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The second is unused while the first is not."); 91125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91145121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->pAttachments[primaryAttach].format != 91155121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].format) { 91165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different formats."); 91185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91195121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->pAttachments[primaryAttach].samples != 91205121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].samples) { 91215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different samples."); 91235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (is_multi && 91255121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes primaryPass->pCreateInfo->pAttachments[primaryAttach].flags != 91265121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].flags) { 91275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 91285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different flags."); 91295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91335121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, RENDER_PASS_NODE const *primaryPass, 91345121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, const int subpass, 9135e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool is_multi) { 91365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 91375121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes const VkSubpassDescription &primary_desc = primaryPass->pCreateInfo->pSubpasses[subpass]; 91385121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes const VkSubpassDescription &secondary_desc = secondaryPass->pCreateInfo->pSubpasses[subpass]; 91395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 91405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 91435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 91445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 91465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 91475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_input_attach, secondaryBuffer, 91495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_input_attach, is_multi); 91505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 91525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 91545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 91555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 91565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 91595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_color_attach, secondaryBuffer, 91615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_color_attach, is_multi); 91625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 91635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 91675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 91685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_resolve_attach, secondaryBuffer, 91705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_resolve_attach, is_multi); 91715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 91735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 91745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 91755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 91775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 91785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_depthstencil_attach, secondaryBuffer, 91805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_depthstencil_attach, is_multi); 91815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9184e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9185e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass) { 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 91875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early exit if renderPass objects are identical (and therefore compatible) 91885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryPass == secondaryPass) 91895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 91915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 91925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data == dev_data->renderPassMap.end() || primary_data->second == nullptr) { 91935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 91945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9196414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid current Cmd Buffer 0x%p which has invalid render pass 0x%" PRIx64 ".", 91975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)primaryBuffer, (uint64_t)(primaryPass)); 91985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data == dev_data->renderPassMap.end() || secondary_data->second == nullptr) { 92015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 92025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9204414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%p which has invalid render pass 0x%" PRIx64 ".", 92055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass)); 92065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->subpassCount != secondary_data->second->pCreateInfo->subpassCount) { 92095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9211414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a render pass 0x%" PRIx64 9212414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current render pass 0x%" PRIx64 "." 92135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "They have a different number of subpasses.", 92145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass)); 92155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_multi = primary_data->second->pCreateInfo->subpassCount > 1; 92185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < primary_data->second->pCreateInfo->subpassCount; ++i) { 92195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 92205121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes validateSubpassCompatibility(dev_data, primaryBuffer, primary_data->second, secondaryBuffer, secondary_data->second, i, is_multi); 92215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9225e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 9226e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 92275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 92285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 92295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9231ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes VkFramebuffer primary_fb = pCB->activeRenderPass->fb; 92325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 92335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 92345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 92355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9237414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a framebuffer 0x%" PRIx64 9238414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current framebuffer 0x%" PRIx64 ".", 92395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 92405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fb_data = dev_data->frameBufferMap.find(secondary_fb); 92425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fb_data == dev_data->frameBufferMap.end()) { 92435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9245414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9246414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 92485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb_data->second.createInfo.renderPass, 92515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryBuffer, pSubCB->beginInfo.pInheritanceInfo->renderPass); 92525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9256e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 92575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 92585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 92595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 92605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 92615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 92625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 92635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 92645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 92655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 92665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 92675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9269414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9270414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 92715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 92725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 92735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 92765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 92795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 92805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 92815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 92825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9284414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9285414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 9286414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 92875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 92885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 92895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 92925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 929489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 929589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 9296e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 92975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9298b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 92995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 93005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 93015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 93045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 93055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 93065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9308414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 93095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 93125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9313414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 93145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 93175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 9321414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 93225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 9323ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 9326ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes skipCall |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->renderPass, pCommandBuffers[i], 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass); 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 9331ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->renderPass, 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass, errorString)) { 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 9336414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 9337414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 9339ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 93425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 93435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 9348414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) references framebuffer (0x%" PRIxLEAST64 9349414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") that does not match framebuffer (0x%" PRIxLEAST64 ") in active renderpass (0x%" PRIxLEAST64 ").", 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 9351ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass->renderPass); 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pSubCB); 93585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 93595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9365414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to simultaneously execute CB 0x%" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 93675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 93685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 93715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9374414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 93755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 9376414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, even though it does.", 93785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 93795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 93805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9382b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 93835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 9387414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 93885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 93895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 93935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 93945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 93955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 93975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 93985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9399b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9400e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 94015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 94025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9404e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 9405e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 94065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 940758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto mem_data = dev_data->memObjMap.find(mem); 940858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if ((mem_data != dev_data->memObjMap.end()) && (mem_data->second.image != VK_NULL_HANDLE)) { 94095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 941058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (FindLayouts(dev_data, mem_data->second.image, layouts)) { 94115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 94125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 94135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 94145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 94155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 94165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 94175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 942489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 942589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 94265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 94275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9428e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 94295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9430b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 943103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 943258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 94335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 94345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 9435b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & 9436b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 94385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 94395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 9440414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 94415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 94445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis storeMemRanges(dev_data, mem, offset, size); 94455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 944658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 9447b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 94485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9449e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 94505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 945103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 9452b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 94535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 9454b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 94555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 94565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 94585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 946003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 946189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 94625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9465b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 94665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= deleteMemRanges(my_data, mem); 9467b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9468e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 94695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 94705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9473e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 9474e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9475e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 94775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 94785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.offset > pMemRanges[i].offset) { 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 94815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 94825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 94835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 94845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 94855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_element->second.memRange.offset)); 94865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_element->second.memRange.size != VK_WHOLE_SIZE) && 94885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((mem_element->second.memRange.offset + mem_element->second.memRange.size) < 94895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pMemRanges[i].offset + pMemRanges[i].size))) { 94905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 94915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 94925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 94935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") exceeds the Memory Object's upper-bound " 94945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 94955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 94965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<size_t>(mem_element->second.memRange.offset + mem_element->second.memRange.size)); 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 95015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9503e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 9504e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9505e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 95095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 95105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize size = mem_element->second.memRange.size; 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 95125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char *data = static_cast<char *>(mem_element->second.pData); 95135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 95145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 95155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 95165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 9517414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, 95185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 95195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 95225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 95235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 9525414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, 95265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 95275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(mem_element->second.pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 95305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 95345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 953689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 953789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 95385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9539e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9542b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 95445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 9545b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9546e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 95475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 95485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 95505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 955289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 955389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 95545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9555e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9558b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 9560b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9561e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 95625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 95635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 95655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 95675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 956889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 95695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 95705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9571e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 9572b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 957394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 957494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 957594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 957647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 957794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 95785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 9579b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 958094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 9581b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 958247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 958347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 958447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &memEntry = dev_data->memObjMap.find(mem); 958547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (memEntry != dev_data->memObjMap.end()) { 958647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 958747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski insert_memory_ranges(image_handle, mem, memoryOffset, memRequirements, memEntry->second.imageRanges); 958847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski skipCall |= 958947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski validate_memory_range(dev_data, memEntry->second.bufferRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 959047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 959147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 95920a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 9593b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 959494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!skipCall) { 959594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 9596b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 959794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->memObjMap[mem].image = image; 959894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.mem = mem; 959994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memOffset = memoryOffset; 960094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memSize = memRequirements.size; 9601b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 960294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 960394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 960494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 960594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 9606414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 960794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 96085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 96105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 961289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 96133ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 96143ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 96155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9616b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 96173ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis auto event_node = dev_data->eventMap.find(event); 96183ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node != dev_data->eventMap.end()) { 96193ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.needsSignaled = false; 96203ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.stageMask = VK_PIPELINE_STAGE_HOST_BIT; 96213ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node->second.in_use.load()) { 96223ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 96233ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9624414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 96253ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 96263ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 96273ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 9628b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 96296fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 96306fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 96316fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 96326fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 96336fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 96346fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 96356fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 96366fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 96376fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 96383ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 96393ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 96405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 96415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 964489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 96455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9647e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9648b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 96494b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 9650a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence != VK_NULL_HANDLE) { 965118ef6d5a98654384d6d5c022e01324fa436c02afMichael Lentine trackCommandBuffers(dev_data, queue, 0, nullptr, fence); 965218ef6d5a98654384d6d5c022e01324fa436c02afMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 965318ef6d5a98654384d6d5c022e01324fa436c02afMichael Lentine if ((bindInfoCount != 0) && fence_data->second.in_use.load()) { 9654a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skip_call |= 9655a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 9656a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 9657414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIx64 " is already in use by another submission.", reinterpret_cast<uint64_t &>(fence)); 9658a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 965918ef6d5a98654384d6d5c022e01324fa436c02afMichael Lentine if (!fence_data->second.needsSignaled) { 9660a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skip_call |= 9661a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 9662a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 9663414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 9664a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence)); 9665a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 96664b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 96671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 96681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 96701344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 96711344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 96721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 96731344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9675e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 96791344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 96801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 96811344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9683e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96861344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 96871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 96881344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 96891344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9691e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 96951344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pWaitSemaphores[i]; 96961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 96971344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 96981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 96991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 97001344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 97021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9703414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 97041344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 97051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 97101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pSignalSemaphores[i]; 97111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 97121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 97135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 97151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9716414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 97171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 97181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 97215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97240a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 9725b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 97265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9727e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 97295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 973389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 973489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 97375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 9738b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 97395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 97401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 97410a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 97425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 974889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 9752b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 97535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 97545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 97565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 976089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 976189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 976289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 97635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 97670801763633180d277d26a90343464bd11646056fTobin Ehlis SWAPCHAIN_NODE *psc_node = new SWAPCHAIN_NODE(pCreateInfo); 9768b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 97690801763633180d277d26a90343464bd11646056fTobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = psc_node; 97705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 977589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 977689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 97775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9780b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 97815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain); 97825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 97835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data->second->images.size() > 0) { 97845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto swapchain_image : swapchain_data->second->images) { 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 97885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 97895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 97905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 97915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 97945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, (uint64_t)swapchain_image, 97960801763633180d277d26a90343464bd11646056fTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 979794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete swapchain_data->second; 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9803b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 98065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 980889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 980989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 98105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 98155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 98165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 9817b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 98185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 98190801763633180d277d26a90343464bd11646056fTobin Ehlis auto swapchain_node = dev_data->device_extensions.swapchainMap[swapchain]; 98200801763633180d277d26a90343464bd11646056fTobin Ehlis if (!swapchain_node->images.empty()) { 98210801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 98220801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 98230801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 9828414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 98295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 98365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 983794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 983894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.mipLevels = 1; 983994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 984094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.usage = swapchain_node->createInfo.imageUsage; 9841ae7fe2b3600678e83196bb0d79ca35afc599a122Tony Barbour image_node.createInfo.format = swapchain_node->createInfo.imageFormat; 9842ae7fe2b3600678e83196bb0d79ca35afc599a122Tony Barbour image_node.createInfo.extent.width = swapchain_node->createInfo.imageExtent.width; 9843ae7fe2b3600678e83196bb0d79ca35afc599a122Tony Barbour image_node.createInfo.extent.height = swapchain_node->createInfo.imageExtent.height; 9844ae7fe2b3600678e83196bb0d79ca35afc599a122Tony Barbour image_node.createInfo.sharingMode = swapchain_node->createInfo.imageSharingMode; 984594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.valid = false; 984694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 98515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 98525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 985789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPresentInfo) { 9863b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 98645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 98651344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = pPresentInfo->pWaitSemaphores[i]; 98661344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 98671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 98681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 98691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 98701344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 98711344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 98721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9873414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 98741344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 98751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98780801763633180d277d26a90343464bd11646056fTobin Ehlis VkDeviceMemory mem; 98795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 98805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]); 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) { 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]]; 988403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 98850801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= 98860a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 98870801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= validate_memory_is_valid(dev_data, mem, "vkQueuePresentKHR()", image); 988803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkImageLayout> layouts; 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindLayouts(dev_data, image, layouts)) { 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 98995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 99075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 99081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 99095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 991289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 991389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 99171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 9918b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 99191657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak if (semaphore != VK_NULL_HANDLE && 99201657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 99211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 99225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 99231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 99245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 99255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 99275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = dev_data->fenceMap.find(fence); 99295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data != dev_data->fenceMap.end()) { 99305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.swapchain = swapchain; 99315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9932b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 99331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 99345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) { 99355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = 99365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 99375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 99395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 994289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 994389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 994489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 99455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 99485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 9949b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis res = layer_create_msg_callback(my_data->report_data, pCreateInfo, pAllocator, pMsgCallback); 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 995589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 995689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 995789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 99585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 99595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 99605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 9961b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 99625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 99635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 996589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 996689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 996789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 99685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 99695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 99705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 99715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 997389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 997489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 997589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 9976a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 997708939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 9978a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 9979a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 9980a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 9981a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu dispatch_key key = get_dispatch_key(physicalDevice); 9982a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu layer_data *my_data = get_my_data_ptr(key, layer_data_map); 9983a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 998408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 998508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 998680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 99877ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 99887ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 99897ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 999080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 999180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 999209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 999309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 999409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 999589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 999680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 999780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 999880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 999980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1000080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 100015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1000209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 1000309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 1000409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 1000509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 100065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 100075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 100085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 100105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 100115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 100125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 100135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 100145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1001789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 100187ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 100193f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 100203f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 100213f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 100223f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 100237ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 100247ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100267ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 100307ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 100317ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 100327ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 100335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 100365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 100375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 100385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1003908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1004080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 100417ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 100427ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 100437ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 100447ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 100457ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 100467ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 100477ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 100487ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 100497ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 100507ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 100517ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 100527ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 100537ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 100547a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu // we should never be queried for these commands 100557a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu assert(strcmp(name, "vkEnumerateInstanceLayerProperties") && 100567a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu strcmp(name, "vkEnumerateInstanceExtensionProperties") && 100577a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu strcmp(name, "vkEnumerateDeviceLayerProperties")); 100587a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu 100597ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 100607ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 100617ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 100627ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 100637ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 100647ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 100657ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 100667ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 100677ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1006880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1006980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1007080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1007180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1007280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 1007380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 1007480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice) }, 1007580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit) }, 1007680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences) }, 1007780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus) }, 1007880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle) }, 1007980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle) }, 1008080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue) }, 1008180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 1008280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice) }, 1008380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence) }, 1008480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences) }, 1008580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore) }, 1008680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent) }, 1008780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool) }, 1008880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer) }, 1008980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView) }, 1009080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage) }, 1009180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView) }, 1009280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule) }, 1009380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline) }, 1009480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout) }, 1009580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler) }, 1009680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout) }, 1009780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool) }, 1009880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer) }, 1009980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass) }, 1010080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer) }, 1010180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView) }, 1010280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage) }, 1010380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView) }, 1010480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence) }, 1010580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "CreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache) }, 1010680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "DestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache) }, 1010780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "GetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData) }, 1010880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "MergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches) }, 1010980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines) }, 1011080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines) }, 1011180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler) }, 1011280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout) }, 1011380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout) }, 1011480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool) }, 1011580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool) }, 1011680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets) }, 1011780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets) }, 1011880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets) }, 1011980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool) }, 1012080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool) }, 1012180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool) }, 1012280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool) }, 1012380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers) }, 1012480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers) }, 1012580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer) }, 1012680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer) }, 1012780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer) }, 1012880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline) }, 1012980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport) }, 1013080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor) }, 1013180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth) }, 1013280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias) }, 1013380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants) }, 1013480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds) }, 1013580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask) }, 1013680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask) }, 1013780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference) }, 1013880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets) }, 1013980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers) }, 1014080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer) }, 1014180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw) }, 1014280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed) }, 1014380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect) }, 1014480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect) }, 1014580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch) }, 1014680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect) }, 1014780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer) }, 1014880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage) }, 1014980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage) }, 1015080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage) }, 1015180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer) }, 1015280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer) }, 1015380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer) }, 1015480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage) }, 1015580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage) }, 1015680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments) }, 1015780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage) }, 1015880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent) }, 1015980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent) }, 1016080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents) }, 1016180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier) }, 1016280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery) }, 1016380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery) }, 1016480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool) }, 1016580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults) }, 1016680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants) }, 1016780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp) }, 1016880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer) }, 1016980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule) }, 1017080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass) }, 1017180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass) }, 1017280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass) }, 1017380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass) }, 1017480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands) }, 1017580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent) }, 1017680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory) }, 1017780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu#if MTMERGESOURCE 1017880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory) }, 1017980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory) }, 1018080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory) }, 1018180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges) }, 1018280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges) }, 1018380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory) }, 1018480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements) }, 1018580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements) }, 1018680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu#endif 1018780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults) }, 1018880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory) }, 1018980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse) }, 1019080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore) }, 1019180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu { "vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent) }, 1019280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1019380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1019480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1019580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1019680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1019780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1019880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1019980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1020080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1020180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1020209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1020309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1020409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1020509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1020609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1020709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1020809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1020909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1021009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1021109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1021209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1021309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 1021409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 102153f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 102163f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 102173f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 102183f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 102193f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1022009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1022109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1022209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1022309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1022409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1022509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1022609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 1022709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1022809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 10229d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 10230d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10231d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 10232d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10233d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10234d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 10235d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1023689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 10237d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10238d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10239d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10240d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 10241d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 10242d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1024389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10244d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10245d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10246d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10247d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 10248d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1024989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 10250d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10251d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10252d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// loader-layer interface v0 10253d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1025408939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1025508939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 10256d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu return util_GetExtensionProperties(1, core_validation::instance_extensions, pCount, pProperties); 1025708939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1025808939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1025908939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1026008939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 10261e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu return util_GetLayerProperties(1, &core_validation::global_layer, pCount, pProperties); 1026208939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1026308939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1026408939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1026508939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 10266e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu return util_GetLayerProperties(1, &core_validation::global_layer, pCount, pProperties); 10267d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10268d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10269d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 10270d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 10271d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 10272a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine 10273a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 10274d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10275d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10276d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1027789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 10278d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10279d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10280d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 102817a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties")) 102827a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu return reinterpret_cast<PFN_vkVoidFunction>(vkEnumerateInstanceLayerProperties); 102837a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties")) 102847a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu return reinterpret_cast<PFN_vkVoidFunction>(vkEnumerateDeviceLayerProperties); 102857a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties")) 102867a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu return reinterpret_cast<PFN_vkVoidFunction>(vkEnumerateInstanceExtensionProperties); 102877a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu if (!strcmp(funcName, "vkGetInstanceProcAddr")) 102887a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu return reinterpret_cast<PFN_vkVoidFunction>(vkGetInstanceProcAddr); 102897a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu 1029089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1029108939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 10292