PackageDexOptimizer.java revision 7ba73dd509c39a073bc59901df78b24632c77fd7
1/* 2 * Copyright (C) 2015 The Android Open Source Project 3 * 4 * Licensed under the Apache License, Version 2.0 (the "License"); 5 * you may not use this file except in compliance with the License. 6 * You may obtain a copy of the License at 7 * 8 * http://www.apache.org/licenses/LICENSE-2.0 9 * 10 * Unless required by applicable law or agreed to in writing, software 11 * distributed under the License is distributed on an "AS IS" BASIS, 12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 13 * See the License for the specific language governing permissions and 14 * limitations under the License 15 */ 16 17package com.android.server.pm; 18 19import android.annotation.Nullable; 20import android.content.Context; 21import android.content.pm.ApplicationInfo; 22import android.content.pm.PackageParser; 23import android.os.FileUtils; 24import android.os.PowerManager; 25import android.os.SystemClock; 26import android.os.SystemProperties; 27import android.os.UserHandle; 28import android.os.WorkSource; 29import android.util.Log; 30import android.util.Slog; 31 32import com.android.internal.annotations.GuardedBy; 33import com.android.internal.util.IndentingPrintWriter; 34import com.android.server.pm.Installer.InstallerException; 35import com.android.server.pm.dex.DexoptOptions; 36import com.android.server.pm.dex.DexoptUtils; 37 38import java.io.File; 39import java.io.IOException; 40import java.util.ArrayList; 41import java.util.List; 42import java.util.Set; 43 44import dalvik.system.DexFile; 45 46import static com.android.server.pm.Installer.DEXOPT_BOOTCOMPLETE; 47import static com.android.server.pm.Installer.DEXOPT_DEBUGGABLE; 48import static com.android.server.pm.Installer.DEXOPT_PROFILE_GUIDED; 49import static com.android.server.pm.Installer.DEXOPT_PUBLIC; 50import static com.android.server.pm.Installer.DEXOPT_SECONDARY_DEX; 51import static com.android.server.pm.Installer.DEXOPT_FORCE; 52import static com.android.server.pm.Installer.DEXOPT_STORAGE_CE; 53import static com.android.server.pm.Installer.DEXOPT_STORAGE_DE; 54import static com.android.server.pm.InstructionSets.getAppDexInstructionSets; 55import static com.android.server.pm.InstructionSets.getDexCodeInstructionSets; 56 57import static com.android.server.pm.PackageManagerService.WATCHDOG_TIMEOUT; 58 59import static dalvik.system.DexFile.getNonProfileGuidedCompilerFilter; 60import static dalvik.system.DexFile.getSafeModeCompilerFilter; 61import static dalvik.system.DexFile.isProfileGuidedCompilerFilter; 62 63/** 64 * Helper class for running dexopt command on packages. 65 */ 66public class PackageDexOptimizer { 67 private static final String TAG = "PackageManager.DexOptimizer"; 68 static final String OAT_DIR_NAME = "oat"; 69 // TODO b/19550105 Remove error codes and use exceptions 70 public static final int DEX_OPT_SKIPPED = 0; 71 public static final int DEX_OPT_PERFORMED = 1; 72 public static final int DEX_OPT_FAILED = -1; 73 // One minute over PM WATCHDOG_TIMEOUT 74 private static final long WAKELOCK_TIMEOUT_MS = WATCHDOG_TIMEOUT + 1000 * 60; 75 76 /** Special library name that skips shared libraries check during compilation. */ 77 public static final String SKIP_SHARED_LIBRARY_CHECK = "&"; 78 79 @GuardedBy("mInstallLock") 80 private final Installer mInstaller; 81 private final Object mInstallLock; 82 83 @GuardedBy("mInstallLock") 84 private final PowerManager.WakeLock mDexoptWakeLock; 85 private volatile boolean mSystemReady; 86 87 PackageDexOptimizer(Installer installer, Object installLock, Context context, 88 String wakeLockTag) { 89 this.mInstaller = installer; 90 this.mInstallLock = installLock; 91 92 PowerManager powerManager = (PowerManager)context.getSystemService(Context.POWER_SERVICE); 93 mDexoptWakeLock = powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, wakeLockTag); 94 } 95 96 protected PackageDexOptimizer(PackageDexOptimizer from) { 97 this.mInstaller = from.mInstaller; 98 this.mInstallLock = from.mInstallLock; 99 this.mDexoptWakeLock = from.mDexoptWakeLock; 100 this.mSystemReady = from.mSystemReady; 101 } 102 103 static boolean canOptimizePackage(PackageParser.Package pkg) { 104 // We do not dexopt a package with no code. 105 if ((pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) { 106 return false; 107 } 108 109 // We do not dexopt a priv-app package when pm.dexopt.priv-apps is false. 110 if (pkg.isPrivilegedApp()) { 111 return SystemProperties.getBoolean("pm.dexopt.priv-apps", true); 112 } 113 114 return true; 115 } 116 117 /** 118 * Performs dexopt on all code paths and libraries of the specified package for specified 119 * instruction sets. 120 * 121 * <p>Calls to {@link com.android.server.pm.Installer#dexopt} on {@link #mInstaller} are 122 * synchronized on {@link #mInstallLock}. 123 */ 124 int performDexOpt(PackageParser.Package pkg, String[] sharedLibraries, 125 String[] instructionSets, CompilerStats.PackageStats packageStats, 126 boolean isUsedByOtherApps, DexoptOptions options) { 127 if (!canOptimizePackage(pkg)) { 128 return DEX_OPT_SKIPPED; 129 } 130 synchronized (mInstallLock) { 131 final long acquireTime = acquireWakeLockLI(pkg.applicationInfo.uid); 132 try { 133 return performDexOptLI(pkg, sharedLibraries, instructionSets, 134 packageStats, isUsedByOtherApps, options); 135 } finally { 136 releaseWakeLockLI(acquireTime); 137 } 138 } 139 } 140 141 /** 142 * Performs dexopt on all code paths of the given package. 143 * It assumes the install lock is held. 144 */ 145 @GuardedBy("mInstallLock") 146 private int performDexOptLI(PackageParser.Package pkg, String[] sharedLibraries, 147 String[] targetInstructionSets, CompilerStats.PackageStats packageStats, 148 boolean isUsedByOtherApps, DexoptOptions options) { 149 final String[] instructionSets = targetInstructionSets != null ? 150 targetInstructionSets : getAppDexInstructionSets(pkg.applicationInfo); 151 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets); 152 final List<String> paths = pkg.getAllCodePaths(); 153 final int sharedGid = UserHandle.getSharedAppGid(pkg.applicationInfo.uid); 154 155 final String compilerFilter = getRealCompilerFilter(pkg.applicationInfo, 156 options.getCompilerFilter(), isUsedByOtherApps); 157 final boolean profileUpdated = options.isCheckForProfileUpdates() && 158 isProfileUpdated(pkg, sharedGid, compilerFilter); 159 160 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct flags. 161 final int dexoptFlags = getDexFlags(pkg, compilerFilter, options.isBootComplete()); 162 163 // Get the class loader context dependencies. 164 // For each code path in the package, this array contains the class loader context that 165 // needs to be passed to dexopt in order to ensure correct optimizations. 166 String[] classLoaderContexts = DexoptUtils.getClassLoaderContexts( 167 pkg.applicationInfo, sharedLibraries); 168 169 int result = DEX_OPT_SKIPPED; 170 for (int i = 0; i < paths.size(); i++) { 171 // Skip paths that have no code. 172 if ((i == 0 && (pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) || 173 (i != 0 && (pkg.splitFlags[i - 1] & ApplicationInfo.FLAG_HAS_CODE) == 0)) { 174 continue; 175 } 176 // Append shared libraries with split dependencies for this split. 177 String path = paths.get(i); 178 if (options.getSplitName() != null) { 179 // We are asked to compile only a specific split. Check that the current path is 180 // what we are looking for. 181 if (!options.getSplitName().equals(new File(path).getName())) { 182 continue; 183 } 184 } 185 186 for (String dexCodeIsa : dexCodeInstructionSets) { 187 int newResult = dexOptPath(pkg, path, dexCodeIsa, compilerFilter, 188 profileUpdated, classLoaderContexts[i], dexoptFlags, sharedGid, 189 packageStats, options.isDowngrade()); 190 // The end result is: 191 // - FAILED if any path failed, 192 // - PERFORMED if at least one path needed compilation, 193 // - SKIPPED when all paths are up to date 194 if ((result != DEX_OPT_FAILED) && (newResult != DEX_OPT_SKIPPED)) { 195 result = newResult; 196 } 197 } 198 } 199 return result; 200 } 201 202 /** 203 * Performs dexopt on the {@code path} belonging to the package {@code pkg}. 204 * 205 * @return 206 * DEX_OPT_FAILED if there was any exception during dexopt 207 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path. 208 * DEX_OPT_SKIPPED if the path does not need to be deopt-ed. 209 */ 210 @GuardedBy("mInstallLock") 211 private int dexOptPath(PackageParser.Package pkg, String path, String isa, 212 String compilerFilter, boolean profileUpdated, String classLoaderContext, 213 int dexoptFlags, int uid, CompilerStats.PackageStats packageStats, boolean downgrade) { 214 int dexoptNeeded = getDexoptNeeded(path, isa, compilerFilter, classLoaderContext, 215 profileUpdated, downgrade); 216 if (Math.abs(dexoptNeeded) == DexFile.NO_DEXOPT_NEEDED) { 217 return DEX_OPT_SKIPPED; 218 } 219 220 // TODO(calin): there's no need to try to create the oat dir over and over again, 221 // especially since it involve an extra installd call. We should create 222 // if (if supported) on the fly during the dexopt call. 223 String oatDir = createOatDirIfSupported(pkg, isa); 224 225 Log.i(TAG, "Running dexopt (dexoptNeeded=" + dexoptNeeded + ") on: " + path 226 + " pkg=" + pkg.applicationInfo.packageName + " isa=" + isa 227 + " dexoptFlags=" + printDexoptFlags(dexoptFlags) 228 + " targetFilter=" + compilerFilter + " oatDir=" + oatDir 229 + " classLoaderContext=" + classLoaderContext); 230 231 try { 232 long startTime = System.currentTimeMillis(); 233 234 // TODO: Consider adding 2 different APIs for primary and secondary dexopt. 235 // installd only uses downgrade flag for secondary dex files and ignores it for 236 // primary dex files. 237 mInstaller.dexopt(path, uid, pkg.packageName, isa, dexoptNeeded, oatDir, dexoptFlags, 238 compilerFilter, pkg.volumeUuid, classLoaderContext, pkg.applicationInfo.seInfo, 239 false /* downgrade*/); 240 241 if (packageStats != null) { 242 long endTime = System.currentTimeMillis(); 243 packageStats.setCompileTime(path, (int)(endTime - startTime)); 244 } 245 return DEX_OPT_PERFORMED; 246 } catch (InstallerException e) { 247 Slog.w(TAG, "Failed to dexopt", e); 248 return DEX_OPT_FAILED; 249 } 250 } 251 252 /** 253 * Performs dexopt on the secondary dex {@code path} belonging to the app {@code info}. 254 * 255 * @return 256 * DEX_OPT_FAILED if there was any exception during dexopt 257 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path. 258 * NOTE that DEX_OPT_PERFORMED for secondary dex files includes the case when the dex file 259 * didn't need an update. That's because at the moment we don't get more than success/failure 260 * from installd. 261 * 262 * TODO(calin): Consider adding return codes to installd dexopt invocation (rather than 263 * throwing exceptions). Or maybe make a separate call to installd to get DexOptNeeded, though 264 * that seems wasteful. 265 */ 266 public int dexOptSecondaryDexPath(ApplicationInfo info, String path, Set<String> isas, 267 String compilerFilter, boolean isUsedByOtherApps, boolean downgrade) { 268 synchronized (mInstallLock) { 269 final long acquireTime = acquireWakeLockLI(info.uid); 270 try { 271 return dexOptSecondaryDexPathLI(info, path, isas, compilerFilter, 272 isUsedByOtherApps, downgrade); 273 } finally { 274 releaseWakeLockLI(acquireTime); 275 } 276 } 277 } 278 279 @GuardedBy("mInstallLock") 280 private long acquireWakeLockLI(final int uid) { 281 // During boot the system doesn't need to instantiate and obtain a wake lock. 282 // PowerManager might not be ready, but that doesn't mean that we can't proceed with 283 // dexopt. 284 if (!mSystemReady) { 285 return -1; 286 } 287 mDexoptWakeLock.setWorkSource(new WorkSource(uid)); 288 mDexoptWakeLock.acquire(WAKELOCK_TIMEOUT_MS); 289 return SystemClock.elapsedRealtime(); 290 } 291 292 @GuardedBy("mInstallLock") 293 private void releaseWakeLockLI(final long acquireTime) { 294 if (acquireTime < 0) { 295 return; 296 } 297 try { 298 if (mDexoptWakeLock.isHeld()) { 299 mDexoptWakeLock.release(); 300 } 301 final long duration = SystemClock.elapsedRealtime() - acquireTime; 302 if (duration >= WAKELOCK_TIMEOUT_MS) { 303 Slog.wtf(TAG, "WakeLock " + mDexoptWakeLock.getTag() 304 + " time out. Operation took " + duration + " ms. Thread: " 305 + Thread.currentThread().getName()); 306 } 307 } catch (Exception e) { 308 Slog.wtf(TAG, "Error while releasing " + mDexoptWakeLock.getTag() + " lock", e); 309 } 310 } 311 312 @GuardedBy("mInstallLock") 313 private int dexOptSecondaryDexPathLI(ApplicationInfo info, String path, Set<String> isas, 314 String compilerFilter, boolean isUsedByOtherApps, boolean downgrade) { 315 compilerFilter = getRealCompilerFilter(info, compilerFilter, isUsedByOtherApps); 316 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct flags. 317 // Secondary dex files are currently not compiled at boot. 318 int dexoptFlags = getDexFlags(info, compilerFilter, /* bootComplete */ true) 319 | DEXOPT_SECONDARY_DEX; 320 // Check the app storage and add the appropriate flags. 321 if (info.deviceProtectedDataDir != null && 322 FileUtils.contains(info.deviceProtectedDataDir, path)) { 323 dexoptFlags |= DEXOPT_STORAGE_DE; 324 } else if (info.credentialProtectedDataDir != null && 325 FileUtils.contains(info.credentialProtectedDataDir, path)) { 326 dexoptFlags |= DEXOPT_STORAGE_CE; 327 } else { 328 Slog.e(TAG, "Could not infer CE/DE storage for package " + info.packageName); 329 return DEX_OPT_FAILED; 330 } 331 Log.d(TAG, "Running dexopt on: " + path 332 + " pkg=" + info.packageName + " isa=" + isas 333 + " dexoptFlags=" + printDexoptFlags(dexoptFlags) 334 + " target-filter=" + compilerFilter); 335 336 try { 337 for (String isa : isas) { 338 // Reuse the same dexopt path as for the primary apks. We don't need all the 339 // arguments as some (dexopNeeded and oatDir) will be computed by installd because 340 // system server cannot read untrusted app content. 341 // TODO(calin): maybe add a separate call. 342 mInstaller.dexopt(path, info.uid, info.packageName, isa, /*dexoptNeeded*/ 0, 343 /*oatDir*/ null, dexoptFlags, 344 compilerFilter, info.volumeUuid, SKIP_SHARED_LIBRARY_CHECK, info.seInfoUser, 345 downgrade); 346 } 347 348 return DEX_OPT_PERFORMED; 349 } catch (InstallerException e) { 350 Slog.w(TAG, "Failed to dexopt", e); 351 return DEX_OPT_FAILED; 352 } 353 } 354 355 /** 356 * Adjust the given dexopt-needed value. Can be overridden to influence the decision to 357 * optimize or not (and in what way). 358 */ 359 protected int adjustDexoptNeeded(int dexoptNeeded) { 360 return dexoptNeeded; 361 } 362 363 /** 364 * Adjust the given dexopt flags that will be passed to the installer. 365 */ 366 protected int adjustDexoptFlags(int dexoptFlags) { 367 return dexoptFlags; 368 } 369 370 /** 371 * Dumps the dexopt state of the given package {@code pkg} to the given {@code PrintWriter}. 372 */ 373 void dumpDexoptState(IndentingPrintWriter pw, PackageParser.Package pkg) { 374 final String[] instructionSets = getAppDexInstructionSets(pkg.applicationInfo); 375 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets); 376 377 final List<String> paths = pkg.getAllCodePathsExcludingResourceOnly(); 378 379 for (String instructionSet : dexCodeInstructionSets) { 380 pw.println("Instruction Set: " + instructionSet); 381 pw.increaseIndent(); 382 for (String path : paths) { 383 String status = null; 384 try { 385 status = DexFile.getDexFileStatus(path, instructionSet); 386 } catch (IOException ioe) { 387 status = "[Exception]: " + ioe.getMessage(); 388 } 389 pw.println("path: " + path); 390 pw.println("status: " + status); 391 } 392 pw.decreaseIndent(); 393 } 394 } 395 396 /** 397 * Returns the compiler filter that should be used to optimize the package code. 398 * The target filter will be updated if the package code is used by other apps 399 * or if it has the safe mode flag set. 400 */ 401 private String getRealCompilerFilter(ApplicationInfo info, String targetCompilerFilter, 402 boolean isUsedByOtherApps) { 403 int flags = info.flags; 404 boolean vmSafeMode = (flags & ApplicationInfo.FLAG_VM_SAFE_MODE) != 0; 405 if (vmSafeMode) { 406 return getSafeModeCompilerFilter(targetCompilerFilter); 407 } 408 409 if (isProfileGuidedCompilerFilter(targetCompilerFilter) && isUsedByOtherApps) { 410 // If the dex files is used by other apps, we cannot use profile-guided compilation. 411 return getNonProfileGuidedCompilerFilter(targetCompilerFilter); 412 } 413 414 return targetCompilerFilter; 415 } 416 417 /** 418 * Computes the dex flags that needs to be pass to installd for the given package and compiler 419 * filter. 420 */ 421 private int getDexFlags(PackageParser.Package pkg, String compilerFilter, 422 boolean bootComplete) { 423 return getDexFlags(pkg.applicationInfo, compilerFilter, bootComplete); 424 } 425 426 private int getDexFlags(ApplicationInfo info, String compilerFilter, boolean bootComplete) { 427 int flags = info.flags; 428 boolean debuggable = (flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0; 429 // Profile guide compiled oat files should not be public. 430 boolean isProfileGuidedFilter = isProfileGuidedCompilerFilter(compilerFilter); 431 boolean isPublic = !info.isForwardLocked() && !isProfileGuidedFilter; 432 int profileFlag = isProfileGuidedFilter ? DEXOPT_PROFILE_GUIDED : 0; 433 int dexFlags = 434 (isPublic ? DEXOPT_PUBLIC : 0) 435 | (debuggable ? DEXOPT_DEBUGGABLE : 0) 436 | profileFlag 437 | (bootComplete ? DEXOPT_BOOTCOMPLETE : 0); 438 return adjustDexoptFlags(dexFlags); 439 } 440 441 /** 442 * Assesses if there's a need to perform dexopt on {@code path} for the given 443 * configuration (isa, compiler filter, profile). 444 */ 445 private int getDexoptNeeded(String path, String isa, String compilerFilter, 446 String classLoaderContext, boolean newProfile, boolean downgrade) { 447 int dexoptNeeded; 448 try { 449 dexoptNeeded = DexFile.getDexOptNeeded(path, isa, compilerFilter, classLoaderContext, 450 newProfile, downgrade); 451 } catch (IOException ioe) { 452 Slog.w(TAG, "IOException reading apk: " + path, ioe); 453 return DEX_OPT_FAILED; 454 } 455 return adjustDexoptNeeded(dexoptNeeded); 456 } 457 458 /** 459 * Checks if there is an update on the profile information of the {@code pkg}. 460 * If the compiler filter is not profile guided the method returns false. 461 * 462 * Note that this is a "destructive" operation with side effects. Under the hood the 463 * current profile and the reference profile will be merged and subsequent calls 464 * may return a different result. 465 */ 466 private boolean isProfileUpdated(PackageParser.Package pkg, int uid, String compilerFilter) { 467 // Check if we are allowed to merge and if the compiler filter is profile guided. 468 if (!isProfileGuidedCompilerFilter(compilerFilter)) { 469 return false; 470 } 471 // Merge profiles. It returns whether or not there was an updated in the profile info. 472 try { 473 return mInstaller.mergeProfiles(uid, pkg.packageName); 474 } catch (InstallerException e) { 475 Slog.w(TAG, "Failed to merge profiles", e); 476 } 477 return false; 478 } 479 480 /** 481 * Creates oat dir for the specified package if needed and supported. 482 * In certain cases oat directory 483 * <strong>cannot</strong> be created: 484 * <ul> 485 * <li>{@code pkg} is a system app, which is not updated.</li> 486 * <li>Package location is not a directory, i.e. monolithic install.</li> 487 * </ul> 488 * 489 * @return Absolute path to the oat directory or null, if oat directory 490 * cannot be created. 491 */ 492 @Nullable 493 private String createOatDirIfSupported(PackageParser.Package pkg, String dexInstructionSet) { 494 if (!pkg.canHaveOatDir()) { 495 return null; 496 } 497 File codePath = new File(pkg.codePath); 498 if (codePath.isDirectory()) { 499 // TODO(calin): why do we create this only if the codePath is a directory? (i.e for 500 // cluster packages). It seems that the logic for the folder creation is 501 // split between installd and here. 502 File oatDir = getOatDir(codePath); 503 try { 504 mInstaller.createOatDir(oatDir.getAbsolutePath(), dexInstructionSet); 505 } catch (InstallerException e) { 506 Slog.w(TAG, "Failed to create oat dir", e); 507 return null; 508 } 509 return oatDir.getAbsolutePath(); 510 } 511 return null; 512 } 513 514 static File getOatDir(File codePath) { 515 return new File(codePath, OAT_DIR_NAME); 516 } 517 518 void systemReady() { 519 mSystemReady = true; 520 } 521 522 private String printDexoptFlags(int flags) { 523 ArrayList<String> flagsList = new ArrayList<>(); 524 525 if ((flags & DEXOPT_BOOTCOMPLETE) == DEXOPT_BOOTCOMPLETE) { 526 flagsList.add("boot_complete"); 527 } 528 if ((flags & DEXOPT_DEBUGGABLE) == DEXOPT_DEBUGGABLE) { 529 flagsList.add("debuggable"); 530 } 531 if ((flags & DEXOPT_PROFILE_GUIDED) == DEXOPT_PROFILE_GUIDED) { 532 flagsList.add("profile_guided"); 533 } 534 if ((flags & DEXOPT_PUBLIC) == DEXOPT_PUBLIC) { 535 flagsList.add("public"); 536 } 537 if ((flags & DEXOPT_SECONDARY_DEX) == DEXOPT_SECONDARY_DEX) { 538 flagsList.add("secondary"); 539 } 540 if ((flags & DEXOPT_FORCE) == DEXOPT_FORCE) { 541 flagsList.add("force"); 542 } 543 if ((flags & DEXOPT_STORAGE_CE) == DEXOPT_STORAGE_CE) { 544 flagsList.add("storage_ce"); 545 } 546 if ((flags & DEXOPT_STORAGE_DE) == DEXOPT_STORAGE_DE) { 547 flagsList.add("storage_de"); 548 } 549 550 return String.join(",", flagsList); 551 } 552 553 /** 554 * A specialized PackageDexOptimizer that overrides already-installed checks, forcing a 555 * dexopt path. 556 */ 557 public static class ForcedUpdatePackageDexOptimizer extends PackageDexOptimizer { 558 559 public ForcedUpdatePackageDexOptimizer(Installer installer, Object installLock, 560 Context context, String wakeLockTag) { 561 super(installer, installLock, context, wakeLockTag); 562 } 563 564 public ForcedUpdatePackageDexOptimizer(PackageDexOptimizer from) { 565 super(from); 566 } 567 568 @Override 569 protected int adjustDexoptNeeded(int dexoptNeeded) { 570 if (dexoptNeeded == DexFile.NO_DEXOPT_NEEDED) { 571 // Ensure compilation by pretending a compiler filter change on the 572 // apk/odex location (the reason for the '-'. A positive value means 573 // the 'oat' location). 574 return -DexFile.DEX2OAT_FOR_FILTER; 575 } 576 return dexoptNeeded; 577 } 578 579 @Override 580 protected int adjustDexoptFlags(int flags) { 581 // Add DEXOPT_FORCE flag to signal installd that it should force compilation 582 // and discard dexoptanalyzer result. 583 return flags | DEXOPT_FORCE; 584 } 585 } 586} 587