PackageDexOptimizer.java revision fad6dc10b0e723f81a264ce608a47f2b7c279b2a
1/* 2 * Copyright (C) 2015 The Android Open Source Project 3 * 4 * Licensed under the Apache License, Version 2.0 (the "License"); 5 * you may not use this file except in compliance with the License. 6 * You may obtain a copy of the License at 7 * 8 * http://www.apache.org/licenses/LICENSE-2.0 9 * 10 * Unless required by applicable law or agreed to in writing, software 11 * distributed under the License is distributed on an "AS IS" BASIS, 12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 13 * See the License for the specific language governing permissions and 14 * limitations under the License 15 */ 16 17package com.android.server.pm; 18 19import android.annotation.Nullable; 20import android.content.Context; 21import android.content.pm.ApplicationInfo; 22import android.content.pm.PackageParser; 23import android.os.FileUtils; 24import android.os.PowerManager; 25import android.os.SystemClock; 26import android.os.SystemProperties; 27import android.os.UserHandle; 28import android.os.WorkSource; 29import android.util.Log; 30import android.util.Slog; 31 32import com.android.internal.annotations.GuardedBy; 33import com.android.internal.util.IndentingPrintWriter; 34import com.android.server.pm.Installer.InstallerException; 35import com.android.server.pm.dex.DexManager; 36import com.android.server.pm.dex.DexoptOptions; 37import com.android.server.pm.dex.DexoptUtils; 38import com.android.server.pm.dex.PackageDexUsage; 39 40import java.io.File; 41import java.io.IOException; 42import java.util.ArrayList; 43import java.util.List; 44 45import dalvik.system.DexFile; 46 47import static com.android.server.pm.Installer.DEXOPT_BOOTCOMPLETE; 48import static com.android.server.pm.Installer.DEXOPT_DEBUGGABLE; 49import static com.android.server.pm.Installer.DEXOPT_PROFILE_GUIDED; 50import static com.android.server.pm.Installer.DEXOPT_PUBLIC; 51import static com.android.server.pm.Installer.DEXOPT_SECONDARY_DEX; 52import static com.android.server.pm.Installer.DEXOPT_FORCE; 53import static com.android.server.pm.Installer.DEXOPT_STORAGE_CE; 54import static com.android.server.pm.Installer.DEXOPT_STORAGE_DE; 55import static com.android.server.pm.InstructionSets.getAppDexInstructionSets; 56import static com.android.server.pm.InstructionSets.getDexCodeInstructionSets; 57 58import static com.android.server.pm.PackageManagerService.WATCHDOG_TIMEOUT; 59 60import static dalvik.system.DexFile.getNonProfileGuidedCompilerFilter; 61import static dalvik.system.DexFile.getSafeModeCompilerFilter; 62import static dalvik.system.DexFile.isProfileGuidedCompilerFilter; 63 64/** 65 * Helper class for running dexopt command on packages. 66 */ 67public class PackageDexOptimizer { 68 private static final String TAG = "PackageManager.DexOptimizer"; 69 static final String OAT_DIR_NAME = "oat"; 70 // TODO b/19550105 Remove error codes and use exceptions 71 public static final int DEX_OPT_SKIPPED = 0; 72 public static final int DEX_OPT_PERFORMED = 1; 73 public static final int DEX_OPT_FAILED = -1; 74 // One minute over PM WATCHDOG_TIMEOUT 75 private static final long WAKELOCK_TIMEOUT_MS = WATCHDOG_TIMEOUT + 1000 * 60; 76 77 /** Special library name that skips shared libraries check during compilation. */ 78 public static final String SKIP_SHARED_LIBRARY_CHECK = "&"; 79 80 @GuardedBy("mInstallLock") 81 private final Installer mInstaller; 82 private final Object mInstallLock; 83 84 @GuardedBy("mInstallLock") 85 private final PowerManager.WakeLock mDexoptWakeLock; 86 private volatile boolean mSystemReady; 87 88 PackageDexOptimizer(Installer installer, Object installLock, Context context, 89 String wakeLockTag) { 90 this.mInstaller = installer; 91 this.mInstallLock = installLock; 92 93 PowerManager powerManager = (PowerManager)context.getSystemService(Context.POWER_SERVICE); 94 mDexoptWakeLock = powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, wakeLockTag); 95 } 96 97 protected PackageDexOptimizer(PackageDexOptimizer from) { 98 this.mInstaller = from.mInstaller; 99 this.mInstallLock = from.mInstallLock; 100 this.mDexoptWakeLock = from.mDexoptWakeLock; 101 this.mSystemReady = from.mSystemReady; 102 } 103 104 static boolean canOptimizePackage(PackageParser.Package pkg) { 105 // We do not dexopt a package with no code. 106 if ((pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) { 107 return false; 108 } 109 110 // We do not dexopt a priv-app package when pm.dexopt.priv-apps is false. 111 if (pkg.isPrivilegedApp()) { 112 return SystemProperties.getBoolean("pm.dexopt.priv-apps", true); 113 } 114 115 return true; 116 } 117 118 /** 119 * Performs dexopt on all code paths and libraries of the specified package for specified 120 * instruction sets. 121 * 122 * <p>Calls to {@link com.android.server.pm.Installer#dexopt} on {@link #mInstaller} are 123 * synchronized on {@link #mInstallLock}. 124 */ 125 int performDexOpt(PackageParser.Package pkg, String[] sharedLibraries, 126 String[] instructionSets, CompilerStats.PackageStats packageStats, 127 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) { 128 if (!canOptimizePackage(pkg)) { 129 return DEX_OPT_SKIPPED; 130 } 131 synchronized (mInstallLock) { 132 final long acquireTime = acquireWakeLockLI(pkg.applicationInfo.uid); 133 try { 134 return performDexOptLI(pkg, sharedLibraries, instructionSets, 135 packageStats, packageUseInfo, options); 136 } finally { 137 releaseWakeLockLI(acquireTime); 138 } 139 } 140 } 141 142 /** 143 * Performs dexopt on all code paths of the given package. 144 * It assumes the install lock is held. 145 */ 146 @GuardedBy("mInstallLock") 147 private int performDexOptLI(PackageParser.Package pkg, String[] sharedLibraries, 148 String[] targetInstructionSets, CompilerStats.PackageStats packageStats, 149 PackageDexUsage.PackageUseInfo packageUseInfo, DexoptOptions options) { 150 final String[] instructionSets = targetInstructionSets != null ? 151 targetInstructionSets : getAppDexInstructionSets(pkg.applicationInfo); 152 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets); 153 final List<String> paths = pkg.getAllCodePaths(); 154 final int sharedGid = UserHandle.getSharedAppGid(pkg.applicationInfo.uid); 155 156 // Get the class loader context dependencies. 157 // For each code path in the package, this array contains the class loader context that 158 // needs to be passed to dexopt in order to ensure correct optimizations. 159 String[] classLoaderContexts = DexoptUtils.getClassLoaderContexts( 160 pkg.applicationInfo, sharedLibraries); 161 162 int result = DEX_OPT_SKIPPED; 163 for (int i = 0; i < paths.size(); i++) { 164 // Skip paths that have no code. 165 if ((i == 0 && (pkg.applicationInfo.flags & ApplicationInfo.FLAG_HAS_CODE) == 0) || 166 (i != 0 && (pkg.splitFlags[i - 1] & ApplicationInfo.FLAG_HAS_CODE) == 0)) { 167 continue; 168 } 169 // Append shared libraries with split dependencies for this split. 170 String path = paths.get(i); 171 if (options.getSplitName() != null) { 172 // We are asked to compile only a specific split. Check that the current path is 173 // what we are looking for. 174 if (!options.getSplitName().equals(new File(path).getName())) { 175 continue; 176 } 177 } 178 179 final boolean isUsedByOtherApps = options.isDexoptAsSharedLibrary() 180 || packageUseInfo.isUsedByOtherApps(); 181 final String compilerFilter = getRealCompilerFilter(pkg.applicationInfo, 182 options.getCompilerFilter(), isUsedByOtherApps); 183 final boolean profileUpdated = options.isCheckForProfileUpdates() && 184 isProfileUpdated(pkg, sharedGid, compilerFilter); 185 186 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct 187 // flags. 188 final int dexoptFlags = getDexFlags(pkg, compilerFilter, options.isBootComplete()); 189 190 for (String dexCodeIsa : dexCodeInstructionSets) { 191 int newResult = dexOptPath(pkg, path, dexCodeIsa, compilerFilter, 192 profileUpdated, classLoaderContexts[i], dexoptFlags, sharedGid, 193 packageStats, options.isDowngrade()); 194 // The end result is: 195 // - FAILED if any path failed, 196 // - PERFORMED if at least one path needed compilation, 197 // - SKIPPED when all paths are up to date 198 if ((result != DEX_OPT_FAILED) && (newResult != DEX_OPT_SKIPPED)) { 199 result = newResult; 200 } 201 } 202 } 203 return result; 204 } 205 206 /** 207 * Performs dexopt on the {@code path} belonging to the package {@code pkg}. 208 * 209 * @return 210 * DEX_OPT_FAILED if there was any exception during dexopt 211 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path. 212 * DEX_OPT_SKIPPED if the path does not need to be deopt-ed. 213 */ 214 @GuardedBy("mInstallLock") 215 private int dexOptPath(PackageParser.Package pkg, String path, String isa, 216 String compilerFilter, boolean profileUpdated, String classLoaderContext, 217 int dexoptFlags, int uid, CompilerStats.PackageStats packageStats, boolean downgrade) { 218 int dexoptNeeded = getDexoptNeeded(path, isa, compilerFilter, classLoaderContext, 219 profileUpdated, downgrade); 220 if (Math.abs(dexoptNeeded) == DexFile.NO_DEXOPT_NEEDED) { 221 return DEX_OPT_SKIPPED; 222 } 223 224 // TODO(calin): there's no need to try to create the oat dir over and over again, 225 // especially since it involve an extra installd call. We should create 226 // if (if supported) on the fly during the dexopt call. 227 String oatDir = createOatDirIfSupported(pkg, isa); 228 229 Log.i(TAG, "Running dexopt (dexoptNeeded=" + dexoptNeeded + ") on: " + path 230 + " pkg=" + pkg.applicationInfo.packageName + " isa=" + isa 231 + " dexoptFlags=" + printDexoptFlags(dexoptFlags) 232 + " targetFilter=" + compilerFilter + " oatDir=" + oatDir 233 + " classLoaderContext=" + classLoaderContext); 234 235 try { 236 long startTime = System.currentTimeMillis(); 237 238 // TODO: Consider adding 2 different APIs for primary and secondary dexopt. 239 // installd only uses downgrade flag for secondary dex files and ignores it for 240 // primary dex files. 241 mInstaller.dexopt(path, uid, pkg.packageName, isa, dexoptNeeded, oatDir, dexoptFlags, 242 compilerFilter, pkg.volumeUuid, classLoaderContext, pkg.applicationInfo.seInfo, 243 false /* downgrade*/); 244 245 if (packageStats != null) { 246 long endTime = System.currentTimeMillis(); 247 packageStats.setCompileTime(path, (int)(endTime - startTime)); 248 } 249 return DEX_OPT_PERFORMED; 250 } catch (InstallerException e) { 251 Slog.w(TAG, "Failed to dexopt", e); 252 return DEX_OPT_FAILED; 253 } 254 } 255 256 /** 257 * Performs dexopt on the secondary dex {@code path} belonging to the app {@code info}. 258 * 259 * @return 260 * DEX_OPT_FAILED if there was any exception during dexopt 261 * DEX_OPT_PERFORMED if dexopt was performed successfully on the given path. 262 * NOTE that DEX_OPT_PERFORMED for secondary dex files includes the case when the dex file 263 * didn't need an update. That's because at the moment we don't get more than success/failure 264 * from installd. 265 * 266 * TODO(calin): Consider adding return codes to installd dexopt invocation (rather than 267 * throwing exceptions). Or maybe make a separate call to installd to get DexOptNeeded, though 268 * that seems wasteful. 269 */ 270 public int dexOptSecondaryDexPath(ApplicationInfo info, String path, 271 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) { 272 synchronized (mInstallLock) { 273 final long acquireTime = acquireWakeLockLI(info.uid); 274 try { 275 return dexOptSecondaryDexPathLI(info, path, dexUseInfo, options); 276 } finally { 277 releaseWakeLockLI(acquireTime); 278 } 279 } 280 } 281 282 @GuardedBy("mInstallLock") 283 private long acquireWakeLockLI(final int uid) { 284 // During boot the system doesn't need to instantiate and obtain a wake lock. 285 // PowerManager might not be ready, but that doesn't mean that we can't proceed with 286 // dexopt. 287 if (!mSystemReady) { 288 return -1; 289 } 290 mDexoptWakeLock.setWorkSource(new WorkSource(uid)); 291 mDexoptWakeLock.acquire(WAKELOCK_TIMEOUT_MS); 292 return SystemClock.elapsedRealtime(); 293 } 294 295 @GuardedBy("mInstallLock") 296 private void releaseWakeLockLI(final long acquireTime) { 297 if (acquireTime < 0) { 298 return; 299 } 300 try { 301 if (mDexoptWakeLock.isHeld()) { 302 mDexoptWakeLock.release(); 303 } 304 final long duration = SystemClock.elapsedRealtime() - acquireTime; 305 if (duration >= WAKELOCK_TIMEOUT_MS) { 306 Slog.wtf(TAG, "WakeLock " + mDexoptWakeLock.getTag() 307 + " time out. Operation took " + duration + " ms. Thread: " 308 + Thread.currentThread().getName()); 309 } 310 } catch (Exception e) { 311 Slog.wtf(TAG, "Error while releasing " + mDexoptWakeLock.getTag() + " lock", e); 312 } 313 } 314 315 @GuardedBy("mInstallLock") 316 private int dexOptSecondaryDexPathLI(ApplicationInfo info, String path, 317 PackageDexUsage.DexUseInfo dexUseInfo, DexoptOptions options) { 318 if (options.isDexoptOnlySharedDex() && !dexUseInfo.isUsedByOtherApps()) { 319 // We are asked to optimize only the dex files used by other apps and this is not 320 // on of them: skip it. 321 return DEX_OPT_SKIPPED; 322 } 323 324 String compilerFilter = getRealCompilerFilter(info, options.getCompilerFilter(), 325 dexUseInfo.isUsedByOtherApps()); 326 // Get the dexopt flags after getRealCompilerFilter to make sure we get the correct flags. 327 // Secondary dex files are currently not compiled at boot. 328 int dexoptFlags = getDexFlags(info, compilerFilter, /* bootComplete */ true) 329 | DEXOPT_SECONDARY_DEX; 330 // Check the app storage and add the appropriate flags. 331 if (info.deviceProtectedDataDir != null && 332 FileUtils.contains(info.deviceProtectedDataDir, path)) { 333 dexoptFlags |= DEXOPT_STORAGE_DE; 334 } else if (info.credentialProtectedDataDir != null && 335 FileUtils.contains(info.credentialProtectedDataDir, path)) { 336 dexoptFlags |= DEXOPT_STORAGE_CE; 337 } else { 338 Slog.e(TAG, "Could not infer CE/DE storage for package " + info.packageName); 339 return DEX_OPT_FAILED; 340 } 341 Log.d(TAG, "Running dexopt on: " + path 342 + " pkg=" + info.packageName + " isa=" + dexUseInfo.getLoaderIsas() 343 + " dexoptFlags=" + printDexoptFlags(dexoptFlags) 344 + " target-filter=" + compilerFilter); 345 346 String classLoaderContext; 347 if (dexUseInfo.isUnknownClassLoaderContext() || 348 dexUseInfo.isUnsupportedClassLoaderContext() || 349 dexUseInfo.isVariableClassLoaderContext()) { 350 // If we have an unknown (not yet set), unsupported (custom class loaders), or a 351 // variable class loader chain, compile without a context and mark the oat file with 352 // SKIP_SHARED_LIBRARY_CHECK. Note that his might lead to a incorrect compilation. 353 // TODO(calin): We should just extract in this case. 354 classLoaderContext = SKIP_SHARED_LIBRARY_CHECK; 355 } else { 356 classLoaderContext = dexUseInfo.getClassLoaderContext(); 357 } 358 try { 359 for (String isa : dexUseInfo.getLoaderIsas()) { 360 // Reuse the same dexopt path as for the primary apks. We don't need all the 361 // arguments as some (dexopNeeded and oatDir) will be computed by installd because 362 // system server cannot read untrusted app content. 363 // TODO(calin): maybe add a separate call. 364 mInstaller.dexopt(path, info.uid, info.packageName, isa, /*dexoptNeeded*/ 0, 365 /*oatDir*/ null, dexoptFlags, 366 compilerFilter, info.volumeUuid, classLoaderContext, info.seInfoUser, 367 options.isDowngrade()); 368 } 369 370 return DEX_OPT_PERFORMED; 371 } catch (InstallerException e) { 372 Slog.w(TAG, "Failed to dexopt", e); 373 return DEX_OPT_FAILED; 374 } 375 } 376 377 /** 378 * Adjust the given dexopt-needed value. Can be overridden to influence the decision to 379 * optimize or not (and in what way). 380 */ 381 protected int adjustDexoptNeeded(int dexoptNeeded) { 382 return dexoptNeeded; 383 } 384 385 /** 386 * Adjust the given dexopt flags that will be passed to the installer. 387 */ 388 protected int adjustDexoptFlags(int dexoptFlags) { 389 return dexoptFlags; 390 } 391 392 /** 393 * Dumps the dexopt state of the given package {@code pkg} to the given {@code PrintWriter}. 394 */ 395 void dumpDexoptState(IndentingPrintWriter pw, PackageParser.Package pkg) { 396 final String[] instructionSets = getAppDexInstructionSets(pkg.applicationInfo); 397 final String[] dexCodeInstructionSets = getDexCodeInstructionSets(instructionSets); 398 399 final List<String> paths = pkg.getAllCodePathsExcludingResourceOnly(); 400 401 for (String instructionSet : dexCodeInstructionSets) { 402 pw.println("Instruction Set: " + instructionSet); 403 pw.increaseIndent(); 404 for (String path : paths) { 405 String status = null; 406 try { 407 status = DexFile.getDexFileStatus(path, instructionSet); 408 } catch (IOException ioe) { 409 status = "[Exception]: " + ioe.getMessage(); 410 } 411 pw.println("path: " + path); 412 pw.println("status: " + status); 413 } 414 pw.decreaseIndent(); 415 } 416 } 417 418 /** 419 * Returns the compiler filter that should be used to optimize the package code. 420 * The target filter will be updated if the package code is used by other apps 421 * or if it has the safe mode flag set. 422 */ 423 private String getRealCompilerFilter(ApplicationInfo info, String targetCompilerFilter, 424 boolean isUsedByOtherApps) { 425 int flags = info.flags; 426 boolean vmSafeMode = (flags & ApplicationInfo.FLAG_VM_SAFE_MODE) != 0; 427 if (vmSafeMode) { 428 return getSafeModeCompilerFilter(targetCompilerFilter); 429 } 430 431 if (isProfileGuidedCompilerFilter(targetCompilerFilter) && isUsedByOtherApps) { 432 // If the dex files is used by other apps, we cannot use profile-guided compilation. 433 return getNonProfileGuidedCompilerFilter(targetCompilerFilter); 434 } 435 436 return targetCompilerFilter; 437 } 438 439 /** 440 * Computes the dex flags that needs to be pass to installd for the given package and compiler 441 * filter. 442 */ 443 private int getDexFlags(PackageParser.Package pkg, String compilerFilter, 444 boolean bootComplete) { 445 return getDexFlags(pkg.applicationInfo, compilerFilter, bootComplete); 446 } 447 448 private int getDexFlags(ApplicationInfo info, String compilerFilter, boolean bootComplete) { 449 int flags = info.flags; 450 boolean debuggable = (flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0; 451 // Profile guide compiled oat files should not be public. 452 boolean isProfileGuidedFilter = isProfileGuidedCompilerFilter(compilerFilter); 453 boolean isPublic = !info.isForwardLocked() && !isProfileGuidedFilter; 454 int profileFlag = isProfileGuidedFilter ? DEXOPT_PROFILE_GUIDED : 0; 455 int dexFlags = 456 (isPublic ? DEXOPT_PUBLIC : 0) 457 | (debuggable ? DEXOPT_DEBUGGABLE : 0) 458 | profileFlag 459 | (bootComplete ? DEXOPT_BOOTCOMPLETE : 0); 460 return adjustDexoptFlags(dexFlags); 461 } 462 463 /** 464 * Assesses if there's a need to perform dexopt on {@code path} for the given 465 * configuration (isa, compiler filter, profile). 466 */ 467 private int getDexoptNeeded(String path, String isa, String compilerFilter, 468 String classLoaderContext, boolean newProfile, boolean downgrade) { 469 int dexoptNeeded; 470 try { 471 dexoptNeeded = DexFile.getDexOptNeeded(path, isa, compilerFilter, classLoaderContext, 472 newProfile, downgrade); 473 } catch (IOException ioe) { 474 Slog.w(TAG, "IOException reading apk: " + path, ioe); 475 return DEX_OPT_FAILED; 476 } 477 return adjustDexoptNeeded(dexoptNeeded); 478 } 479 480 /** 481 * Checks if there is an update on the profile information of the {@code pkg}. 482 * If the compiler filter is not profile guided the method returns false. 483 * 484 * Note that this is a "destructive" operation with side effects. Under the hood the 485 * current profile and the reference profile will be merged and subsequent calls 486 * may return a different result. 487 */ 488 private boolean isProfileUpdated(PackageParser.Package pkg, int uid, String compilerFilter) { 489 // Check if we are allowed to merge and if the compiler filter is profile guided. 490 if (!isProfileGuidedCompilerFilter(compilerFilter)) { 491 return false; 492 } 493 // Merge profiles. It returns whether or not there was an updated in the profile info. 494 try { 495 return mInstaller.mergeProfiles(uid, pkg.packageName); 496 } catch (InstallerException e) { 497 Slog.w(TAG, "Failed to merge profiles", e); 498 } 499 return false; 500 } 501 502 /** 503 * Creates oat dir for the specified package if needed and supported. 504 * In certain cases oat directory 505 * <strong>cannot</strong> be created: 506 * <ul> 507 * <li>{@code pkg} is a system app, which is not updated.</li> 508 * <li>Package location is not a directory, i.e. monolithic install.</li> 509 * </ul> 510 * 511 * @return Absolute path to the oat directory or null, if oat directory 512 * cannot be created. 513 */ 514 @Nullable 515 private String createOatDirIfSupported(PackageParser.Package pkg, String dexInstructionSet) { 516 if (!pkg.canHaveOatDir()) { 517 return null; 518 } 519 File codePath = new File(pkg.codePath); 520 if (codePath.isDirectory()) { 521 // TODO(calin): why do we create this only if the codePath is a directory? (i.e for 522 // cluster packages). It seems that the logic for the folder creation is 523 // split between installd and here. 524 File oatDir = getOatDir(codePath); 525 try { 526 mInstaller.createOatDir(oatDir.getAbsolutePath(), dexInstructionSet); 527 } catch (InstallerException e) { 528 Slog.w(TAG, "Failed to create oat dir", e); 529 return null; 530 } 531 return oatDir.getAbsolutePath(); 532 } 533 return null; 534 } 535 536 static File getOatDir(File codePath) { 537 return new File(codePath, OAT_DIR_NAME); 538 } 539 540 void systemReady() { 541 mSystemReady = true; 542 } 543 544 private String printDexoptFlags(int flags) { 545 ArrayList<String> flagsList = new ArrayList<>(); 546 547 if ((flags & DEXOPT_BOOTCOMPLETE) == DEXOPT_BOOTCOMPLETE) { 548 flagsList.add("boot_complete"); 549 } 550 if ((flags & DEXOPT_DEBUGGABLE) == DEXOPT_DEBUGGABLE) { 551 flagsList.add("debuggable"); 552 } 553 if ((flags & DEXOPT_PROFILE_GUIDED) == DEXOPT_PROFILE_GUIDED) { 554 flagsList.add("profile_guided"); 555 } 556 if ((flags & DEXOPT_PUBLIC) == DEXOPT_PUBLIC) { 557 flagsList.add("public"); 558 } 559 if ((flags & DEXOPT_SECONDARY_DEX) == DEXOPT_SECONDARY_DEX) { 560 flagsList.add("secondary"); 561 } 562 if ((flags & DEXOPT_FORCE) == DEXOPT_FORCE) { 563 flagsList.add("force"); 564 } 565 if ((flags & DEXOPT_STORAGE_CE) == DEXOPT_STORAGE_CE) { 566 flagsList.add("storage_ce"); 567 } 568 if ((flags & DEXOPT_STORAGE_DE) == DEXOPT_STORAGE_DE) { 569 flagsList.add("storage_de"); 570 } 571 572 return String.join(",", flagsList); 573 } 574 575 /** 576 * A specialized PackageDexOptimizer that overrides already-installed checks, forcing a 577 * dexopt path. 578 */ 579 public static class ForcedUpdatePackageDexOptimizer extends PackageDexOptimizer { 580 581 public ForcedUpdatePackageDexOptimizer(Installer installer, Object installLock, 582 Context context, String wakeLockTag) { 583 super(installer, installLock, context, wakeLockTag); 584 } 585 586 public ForcedUpdatePackageDexOptimizer(PackageDexOptimizer from) { 587 super(from); 588 } 589 590 @Override 591 protected int adjustDexoptNeeded(int dexoptNeeded) { 592 if (dexoptNeeded == DexFile.NO_DEXOPT_NEEDED) { 593 // Ensure compilation by pretending a compiler filter change on the 594 // apk/odex location (the reason for the '-'. A positive value means 595 // the 'oat' location). 596 return -DexFile.DEX2OAT_FOR_FILTER; 597 } 598 return dexoptNeeded; 599 } 600 601 @Override 602 protected int adjustDexoptFlags(int flags) { 603 // Add DEXOPT_FORCE flag to signal installd that it should force compilation 604 // and discard dexoptanalyzer result. 605 return flags | DEXOPT_FORCE; 606 } 607 } 608} 609