b39ba19cf3d0f8a7c86bfcf0b0964b0d4c1fae33 |
|
24-Sep-2014 |
Mauro Carvalho Chehab <mchehab@osg.samsung.com> |
[media] drxd: remove a dead code drivers/media/dvb-frontends/drxd_hard.c:2839 drxd_init() info: ignoring unreachable code. Firmware request/release is not at drxd_init. So, we can remove that dead code. Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
|
cea130021448763b15f4b16af184bbab4be118fb |
|
04-Sep-2014 |
Mauro Carvalho Chehab <m.chehab@samsung.com> |
[media] drxd_hard: fix bad alignments As reported by cocinelle: drivers/media/dvb-frontends/drxd_hard.c:2632:3-51: code aligned with following code on line 2633 Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
619c027da030c532fb9a94911a117ffaa5d844b6 |
|
18-Mar-2014 |
Mauro Carvalho Chehab <m.chehab@samsung.com> |
[media] drxd: get rid of EXPORT_SYMBOL(drxd_config_i2c) This symbol is not used externally. Get rid of it. Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
73b8922fefed64c9bcb70e25b30a069bb9e61f40 |
|
05-Sep-2013 |
Dave Jones <davej@redhat.com> |
[media] drx-d: add missing braces in drxd_hard.c:DRXD_init No functional changes, but removes a duplicate check, if !state->type_A. Signed-off-by: Dave Jones <davej@fedoraproject.org> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
843e44a1347f97671c2f943c0d41f135e134bdb6 |
|
04-Oct-2013 |
Hans Verkuil <hans.verkuil@cisco.com> |
[media] drxd_hard: fix sparse warnings drivers/media/dvb-frontends/drxd_hard.c:1017:70: warning: Using plain integer as NULL pointer drivers/media/dvb-frontends/drxd_hard.c:1038:69: warning: Using plain integer as NULL pointer drivers/media/dvb-frontends/drxd_hard.c:2836:33: warning: Using plain integer as NULL pointer drivers/media/dvb-frontends/drxd_hard.c:2972:30: warning: Using plain integer as NULL pointer Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Reviewed-by: Antti Palosaari <crope@iki.fi> Reviewed-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
221ff3d0d59bcb20671e3e36b8417b52ca0de89f |
|
30-Sep-2013 |
Christoph Jaeger <christophjaeger@linux.com> |
[media] drxd_hard: remove unused SIZEOF_ARRAY SIZEOF_ARRAY is not used (anymore). Besides, ARRAY_SIZE, defined in include/linux/kernel.h, should be used rather than explicitly coding some variant of it. Signed-off-by: Christoph Jaeger <christophjaeger@linux.com> Reviewed-by: Sakari Ailus <sakari.ailus@iki.fi> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
ee45ddc1e03afc221afad273503b6c2fc0683008 |
|
23-Oct-2012 |
Ezequiel Garcia <elezegarcia@gmail.com> |
[media] dvb-frontends: Replace memcpy with struct assignment This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
e7c953d280cea9a79018ae36e2bc7cedc3678de3 |
|
15-Dec-2012 |
Patrice Chotard <patrice.chotard@sfr.fr> |
[media] drxd: allow functional gate control after, attach Previously, gate control didn't work until drxd_init() execution. Migrate necessary set of commands in drxd_attach to allow gate control to be used by tuner which are accessible through i2c gate. Reported-by: frederic.mantegazza@gbiloba.org Signed-off-by: Patrice Chotard <patricechotard@free.fr> Reviewed-by: Antti Palosaari <crope@iki.fi> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
8b35c2fee8a0a5f9c4779ad2eda8a8c9cf1be99d |
|
27-Oct-2012 |
Mauro Carvalho Chehab <mchehab@redhat.com> |
[media] drxd_hard: get rid of warning: no previous prototype drivers/media/dvb-frontends/drxd_hard.c:1751:5: warning: no previous prototype for 'SetOperationMode' [-Wmissing-prototypes] drivers/media/dvb-frontends/drxd_hard.c:2615:5: warning: no previous prototype for 'DRXD_init' [-Wmissing-prototypes] drivers/media/dvb-frontends/drxd_hard.c:2777:5: warning: no previous prototype for 'DRXD_status' [-Wmissing-prototypes] Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
c2c1b4156a447f113ef4d167decce29399c2667c |
|
28-Sep-2012 |
Peter Senna Tschudin <peter.senna@gmail.com> |
[media] drivers/media: Remove unnecessary semicolon A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> [mchehab@redhat.com: some hunks got bitroted; applied only the ones that succeeds] Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> [crope@iki.fi: For my drivers a8293, af9013, af9015, af9035] Acked-by: Antti Palosaari <crope@iki.fi> Reviewed-by: Antti Palosaari <crope@iki.fi> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
9a0bf528b4d66b605f02634236da085595c22101 |
|
14-Aug-2012 |
Mauro Carvalho Chehab <mchehab@redhat.com> |
[media] move the dvb/frontends to drivers/media/dvb-frontends Raise the DVB frontends one level up, as the intention is to remove the drivers/media/dvb directory. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|