History log of /drivers/staging/dgnc/
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
683a52a10148e929fb4844f9237f059a47c0b01b 08-Oct-2014 Linus Torvalds <torvalds@linux-foundation.org> Merge tag 'tty-3.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty

Pull tty/serial driver updates from Greg KH:
"Here's the big tty/serial driver patchset for 3.18-rc1.

Lots of little things in here, some good work from Peter Hurley on the
tty core, and in lots of drivers. There are also lots of other driver
updates in here as well, full details in the changelogs.

All have been in the linux-next tree for a while"

* tag 'tty-3.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty: (99 commits)
Revert "serial/core: Initialize the console pm state"
tty: serial: 8250: use 32bit variable for rpm_tx_active
tty: serial: msm: Add earlycon support
serial/core: Initialize the console pm state
serial: asc: Conditionally use readl_relaxed (COMPILE_TEST)
serial: of-serial: add PM suspend/resume support
m68k: AMIGA_BUILTIN_SERIAL should depend on TTY
asm/uapi: Add definition of TIOC[SG]RS485
tty/metag_da: Add console_poll module parameter
serial: 8250_pci: remove rts_n override from Baytrail quirk
serial: cadence: Add generic earlycon support
serial: imx: change the wait even to interruptiable
serial: imx: terminate the RX DMA when the UART is suspending
serial: imx: fix throttle/unthrottle callbacks for hardware assisted flow control
serial: 8250: Add Quark X1000 to 8250_pci.c
tty: omap-serial: pull out calculation from baud_is_mode16
tty: omap-serial: fix division by zero
xen_hvc: no reason to write the type key on xenstore
tty: serial: 8250_core: remove UART_IER_RDI in serial8250_stop_rx()
tty: serial: 8250_core: use the ->line argument as a hint in serial8250_find_match_or_unused()
...
446393e9602d3b32515ca107f3c004194cb690f3 01-Oct-2014 Ebru Akagunduz <ebru.akagunduz@gmail.com> staging: dgnc: Fix do not add new typedefs

This patch fixes "do not add new typedefs"
checkpatch.pl warning in dgnc_types.h

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
gnc_driver.c
gnc_driver.h
gnc_mgmt.c
gnc_neo.c
gnc_tty.c
gnc_tty.h
gnc_types.h
3fad9641abbee80f0c8ff0c726eca7255c338319 30-Sep-2014 Yeliz Taneroglu <yeliztaneroglu@gmail.com> staging: dgnc: Fix no spaces at the start of a line in dpacompat.h

The following patch the checkpatch.pl warning:

drivers/staging/dgnc/dpacompat.h:27 warning: please, no spaces at the start of a line

Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
pacompat.h
0eaa02e66d7059cd4e08171a2cc6f8a0ec677ce1 29-Sep-2014 Mahati Chamarthy <mahati.chamarthy@gmail.com> Staging: dgnc: Add missing blank line

This fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
3c4019d3e0d77c8992225efe4fc7420677b8ab40 29-Sep-2014 Mahati Chamarthy <mahati.chamarthy@gmail.com> Staging: dgnc: Remove unnecessary braces

This fixes the following checkpatch.pl warnings:
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
c313fe2c346d08246851f7441e68744d5c329497 29-Sep-2014 Mahati Chamarthy <mahati.chamarthy@gmail.com> Staging: dgnc: Remove return in void function

This fixes the following checkpatch.pl warnings:
WARNING: void function return statements are not generally useful

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
ac9080029d9acf5dbda3e4f417ea964957edb9d8 28-Sep-2014 Mahati Chamarthy <mahati.chamarthy@gmail.com> Staging: dgnc: Remove space before parenthesis

This fixes the following checkpatch.pl error:
ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
igi.h
b4e28a6142b5f5e691c4570d8808ebefec0ae6ef 26-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: dgnc_driver.h: Remove non-standard spinlock's macros

This patch removes non-standard spinlock's macros as they are no longer
used by this driver.

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
66663dc1032e03fa2e24fae80e84d71bb99fbedb 26-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: dgnc_driver.c: Replace non-standard spinlock's macros

This patch replaces non-standard spinlock's macros.
It is done using coccinelle and the following semantic patch:

@@
expression x;
@@

- DGNC_SPINLOCK_INIT(x)
+ spin_lock_init(&x)

@@
expression x, y;
@@

- DGNC_LOCK(x, y)
+ spin_lock_irqsave(&x, y)

@@
expression x, y;
@@

- DGNC_UNLOCK(x, y)
+ spin_unlock_irqrestore(&x, y)

@used_by_lock exists@
typedef ulong;
symbol lock_flags;
position p1, p2;
@@

(
ulong lock_flags@p1;
|
unsigned long lock_flags@p2;
)
...
(
spin_lock_irqsave(..., lock_flags)
|
spin_unlock_irqrestore(..., lock_flags)
)

@@
position used_by_lock.p1, used_by_lock.p2;
@@

(
- ulong lock_flags@p1;
+ unsigned long flags;
|
- unsigned long lock_flags@p2;
+ unsigned long flags;
)
<...
- lock_flags
+ flags
...>

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
7be869b0726b270a5702346e66f57e9886cbba6b 26-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: dgnc_neo.c: Replace non-standard spinlock's macros

This patch replaces non-standard spinlock's macros.
It is done using coccinelle and the following semantic patch:

@@
expression x;
@@

- DGNC_SPINLOCK_INIT(x)
+ spin_lock_init(&x)

@@
expression x, y;
@@

- DGNC_LOCK(x, y)
+ spin_lock_irqsave(&x, y)

@@
expression x, y;
@@

- DGNC_UNLOCK(x, y)
+ spin_unlock_irqrestore(&x, y)

@used_by_lock exists@
typedef ulong;
symbol lock_flags;
position p1, p2;
@@

(
ulong lock_flags@p1;
|
unsigned long lock_flags@p2;
)
...
(
spin_lock_irqsave(..., lock_flags)
|
spin_unlock_irqrestore(..., lock_flags)
)

@@
position used_by_lock.p1, used_by_lock.p2;
@@

(
- ulong lock_flags@p1;
+ unsigned long flags;
|
- unsigned long lock_flags@p2;
+ unsigned long flags;
)
<...
- lock_flags
+ flags
...>

Additionally replace 'lock_flags2' with 'flags2'.
This was done by hand since it had only 3 occurences and all in this file.

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
a44b508a32aed3a5e6af1468753886ba4d216a8c 26-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: dgnc_tty.c: Replace non-standard spinlock's macros

This patch replaces non-standard spinlock's macros.
It is done using coccinelle and the following semantic patch:

@@
expression x;
@@

- DGNC_SPINLOCK_INIT(x)
+ spin_lock_init(&x)

@@
expression x, y;
@@

- DGNC_LOCK(x, y)
+ spin_lock_irqsave(&x, y)

@@
expression x, y;
@@

- DGNC_UNLOCK(x, y)
+ spin_unlock_irqrestore(&x, y)

@used_by_lock exists@
typedef ulong;
symbol lock_flags;
position p1, p2;
@@

(
ulong lock_flags@p1;
|
unsigned long lock_flags@p2;
)
...
(
spin_lock_irqsave(..., lock_flags)
|
spin_unlock_irqrestore(..., lock_flags)
)

@@
position used_by_lock.p1, used_by_lock.p2;
@@

(
- ulong lock_flags@p1;
+ unsigned long flags;
|
- unsigned long lock_flags@p2;
+ unsigned long flags;
)
<...
- lock_flags
+ flags
...>

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
9a03d7c8cf8b244c3d66da2ce65c170013eeba56 26-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: dgnc_mgmt.c: Replace non-standard spinlock's macros

This patch replaces non-standard spinlock's macros.
It is done using coccinelle and the following semantic patch:

@@
expression x;
@@

- DGNC_SPINLOCK_INIT(x)
+ spin_lock_init(&x)

@@
expression x, y;
@@

- DGNC_LOCK(x, y)
+ spin_lock_irqsave(&x, y)

@@
expression x, y;
@@

- DGNC_UNLOCK(x, y)
+ spin_unlock_irqrestore(&x, y)

@used_by_lock exists@
typedef ulong;
symbol lock_flags;
position p1, p2;
@@

(
ulong lock_flags@p1;
|
unsigned long lock_flags@p2;
)
...
(
spin_lock_irqsave(..., lock_flags)
|
spin_unlock_irqrestore(..., lock_flags)
)

@@
position used_by_lock.p1, used_by_lock.p2;
@@

(
- ulong lock_flags@p1;
+ unsigned long flags;
|
- unsigned long lock_flags@p2;
+ unsigned long flags;
)
<...
- lock_flags
+ flags
...>

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_mgmt.c
42c4d46e3858caa04b99dde64ef5a82681179881 25-Sep-2014 Gulsah Kose <gulsah.1004@gmail.com> staging: dgnc: Fixed white space warning.

This patch fixes "please, no space before tabs" checkpatch.pl warning in
digi.h

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
igi.h
707505b58eb9aeef294e975a6d7f5afd1c74dd0a 23-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: Replace non-standard spinlock's macros

This patch replaces non-standard spinlock's macros.
It is done using coccinelle and the following semantic patch:

@@
expression x;
@@

- DGNC_SPINLOCK_INIT(x)
+ spin_lock_init(&x)

@@
expression x, y;
@@

- DGNC_LOCK(x, y)
+ spin_lock_irqsave(&x, y)

@@
expression x, y;
@@

- DGNC_UNLOCK(x, y)
+ spin_unlock_irqrestore(&x, y)

@used_by_lock exists@
typedef ulong;
symbol lock_flags;
position p1, p2;
@@

(
ulong lock_flags@p1;
|
unsigned long lock_flags@p2;
)
...
(
spin_lock_irqsave(..., lock_flags)
|
spin_unlock_irqrestore(..., lock_flags)
)

@@
position used_by_lock.p1, used_by_lock.p2;
@@

(
- ulong lock_flags@p1;
+ unsigned long flags;
|
- unsigned long lock_flags@p2;
+ unsigned long flags;
)
<...
- lock_flags
+ flags
...>

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
77b55d84aa49d2144afa74725118321189593fbb 21-Sep-2014 Gulsah Kose <gulsah.1004@gmail.com> staging: dgnc: Fix unnecessary braces warning.

Fixes "braces {} are not necessary for single statement blocks"
checkpatch.pl warnings in dgnc_sysfs.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_sysfs.c
fb33aa47a00edc789d17d80174cd3ed8a1c82c66 19-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: Check sscanf return value

This fixes the following checkpatch.pl warnings:
WARNING: unchecked sscanf return value

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_sysfs.c
f23e875fd26a05a0850db7c5e090030c80b4f583 20-Sep-2014 Gulsah Kose <gulsah.1004@gmail.com> staging: dgnc: Fix unnecessary space warning.

Fixed "Unnecessary space before function pointer argument" checkpatch.pl
warning in dgnc_driver.h

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
e8756d4a51d1246be36c5621827c288eb2d5e9b7 20-Sep-2014 Gulsah Kose <gulsah.1004@gmail.com> staging: dgnc: Fix missing blank line warning.

Fixes "Missing a blank line after declarations" checkpatch.pl warning in
dgnc_sysfs.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_sysfs.c
3dfe7557809e5867306c7a0614b9d1c6036cbe4d 19-Sep-2014 Vaishali Thakkar <vthakkar1994@gmail.com> Staging: dgnc: Merge lines and remove unused variable for immediate return

This patch merges two lines in a single line if immediate
return is found. It also removes unnecessory variable rc
as it is no longer needed.

This is done using Coccinelle. Semantic patch used for this
is as follows:

@@
type T;
identifier i;
identifier f;
constant C;
@@
- T i;
...when != i
when strict
(
return -C;
|
- i =
+ return
f(...);
- return i;
)

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Reviewed-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
10352c2a69f4aa2724f007a4922518c9ece7bf89 18-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: Move open brace on previous line

This fixes the following checkpatch.pl errors:
ERROR: that open brace { should be on the previous line

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
05a70e14035438e6866d7fcf8a79c67b8e1425e1 16-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: Do not initialise statics to 0 or NULL

This fixes the following checkpatch.pl error:
ERROR: do not initialise statics to 0 or NULL

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
b051017fb4e593998fc46ec9a991ad390c9114b5 15-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: Replace kzalloc with kcalloc

This fixes the following checkpatch.pl warnings:
WARNING: Prefer kcalloc over kzalloc with multiply

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
f3dadd29f7197d93d0441391f5e3815bf008cce1 14-Sep-2014 Roberta Dobrescu <roberta.dobrescu@gmail.com> staging: dgnc: Fix warnings relating to printk()

This fixes the following checkpatch.pl warnings:
WARNING: printk() should include KERN_ facility level
It replaces printk() with dev_dbg() in order to avoid the warning that a more
specific function should be used.

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
27d5775e75ec70c104479bd7fcdceb0d6e0203a8 30-Aug-2014 Bill Pemberton <wfp5p@worldbroken.com> staging: dgnc: remove Neo card ids from device table

The Digi Neo cards are supported by the jsm driver. Remove support
for these cards from dgnc.

Signed-off-by: Bill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
587abd7b030283baf921ba1a62c8a7280fea5e9d 01-Sep-2014 Seunghun Lee <waydi1@gmail.com> staging: dgnc: split two assignments into the two assignments on two lines.

split two assignments into the two assignments on two lines.

CC: Lidza Louina <lidza.louina@gmail.com>
CC: Mark Hounschell <markh@compro.net>
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ODO
gnc_cls.c
gnc_driver.c
gnc_neo.c
gnc_tty.c
239d1346f5f77135e272eee0c33cfa3e52fc4e1c 31-Aug-2014 Konrad Zapalowicz <bergo.torino+kernel@gmail.com> staging: dgnc: Fix sleeping under spinlock bug

This commit changes the memory allocation flags to ATOMIC in order to
avoid sleeping in the nowait/nolock code.

Signed-off-by: Konrad Zapalowicz <bergo.torino+kernel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
79f284d29bbf7852093d0262c097e8faee32bc03 31-Aug-2014 Seunghun Lee <waydi1@gmail.com> staging: dgnc: remove some unused macros

These macros do nothing, so remove it.

CC: Lidza Louina <lidza.louina@gmail.com>
CC: Mark Hounschell <markh@compro.net>
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
fb33cac8dc3d1f64bba3beff0f8b64814f7f9485 20-Aug-2014 Kieron Browne <kieron.browne@gmail.com> staging: dgnc: Fix checkpatch include warning

checkpatch.pl fix. Use #include <linux/uaccess.h> instead of
<asm/uaccess.h>

Signed-off-by: Kieron Browne <kieron.browne@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
f1e51745eb309a52f19d1115ddf8508a16aedbc4 19-Aug-2014 Seunghun Lee <waydi1@gmail.com> staging: dgnc: remove DPR Macros and related codes.

In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing.

So remove them and related codes.

CC: Lidza Louina <lidza.louina@gmail.com>
CC: Mark Hounschell <markh@compro.net>
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
gnc_driver.c
gnc_driver.h
gnc_mgmt.c
gnc_neo.c
gnc_tty.c
ed7f92da59f24dd966555efef978fe14085b3318 16-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Remove unnecessary dgnc_Major_Control_Registered variable

The dgnc_Major_Control_Registered variable purpose was to act as a flag
to indicate if the character device has been successfully registered
into the kernel. This flag was later checked in the module cleanup
function to know if the character device needs to be deregistered.

However the {device,class}_destroy and unregister_chrdev functions may
be called with 'invalid' data perfectly fine. This means that this
variable is not needed and can safely be removed which is what this
commit does.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
0b3a07ede37d0c1a0985032c9f2044d71813282a 16-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Remove not needed dgnc_driver_start variable

The dgnc_driver_start variable purpose was to indicate if the driver
'start' routine has been called. Now, because the 'start' routine can
only be called once this variable is not needed thus this commit
removes it.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
3599abafcc51594f1629f19a6a12ff92f6e94017 16-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Remove driver-wide polling counter variable

The polling counter variable is only exposed via sysfs and has no other
purpose.

Now, since the polling shall be implemented as a board specific feature
rather than being global in the driver this counter is obsolete.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
gnc_driver.h
gnc_sysfs.c
1d8c5aa329e7a7a17d9c99122d89d76663195ddb 16-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Remove driver-wide state variable

This commit removes the driver's global state variable. This is ok
because the state was changed only once at the end of init phase thus
the future usage of this variable is pointless.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
gnc_driver.h
gnc_sysfs.c
d6365fe50ebff17a5beccefed0c19d7dd847f076 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Remove unnecessary 'return' statement

This commit fixes the checkpath warning 'void function return
statements are not generally useful' caused by the 'return' at the end
of 'void' function.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
8aa5d0d825715db571be47b02ca8b176f70cb1da 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Fix missing blank line after declarations

This commit fixes the missing blank lines after declarations checkpath
warnings found in dgnc_cls.c file.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
e9b69997e74a88b388a6272a81e5133688683705 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Remove 'volatile' modifier where it is not needed

This commit fixes the checkpath warning about misused 'volatile'
modifier. In this case the 'volatile' was not needed as it was used
for regular automatic variable. Thos commit removes the 'volatile'.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
13d1773ace622802e99f2aae577f30eab444eb55 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Fix braces {} are not necessary for single statement blocks

This commit fixes the following checkpath warning in dgnc_neo.c file:
'braces {} are not necessary for single statement blocks'

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
5ef33f38cb148ad0fb4a7c8860d8e1c7ebe16bdb 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Fix that open brace { should be on the previous line

This commit fixes the following checkpath error in dgnc_neo.c file:
'that open brace { should be on the previous line'

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
1eba3dba7463cddd254605b5372ee38ceb45fa30 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Fix missing blank line after declarations

This commit deals with the checkapth warnings 'missing line after
declarations' in the dgnc_neo.c file.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
9dfe5670e1ceeda7378a6f4234cca6820fd5af46 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Fix included header from 'asm'

This commit fixes the checkpatch warning:

drivers/staging/dgnc/dgnc_neo.c:37:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
98b3bcc05fa7efaf6a9a1420ce4a0fc6c9031b36 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Update the TODO file

It turned out that the TODO file contained the invalid information as
some of the work has already been done. This commit updates it with the
current status of what is left to be done.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ODO
92ded48cc3f09b8f6bdf56348b9318f9badd28fe 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Siplify the dgnc_start function

This commit slightly simplifies the sgnc_start() function by
rearranging it. As a result the indentation level is reduced.
This is not the functional change.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
9a633d00d14129b5865502a0f45c160f523b446f 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Move utility functions out of dgnc_driver.c

This commit moves the utility functions out of dgnc_driver.c file and
puts them in the new dgnc_utils.{c,h} files. The accompanying changes
adjust the existing code to work with this design.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
akefile
gnc_driver.c
gnc_driver.h
gnc_tty.c
gnc_utils.c
gnc_utils.h
bbecbacbed32db649c10d1d4e0a6045b4f4d4750 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Remove unnecessary functions from dgnc_driver.c

This commit slightly cleans up the dgnc_driver.c file. The changes
include removing one-line proxy functions as they were not needed.
Additionaly the pci 'remove' function is deleted because it was no
need for it.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
ea6e9dea2e72a7abd146a2c5bab726b27f34b36c 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Fix frame size is larger than 1024B

This comit fixes the following sparse warnign:

drivers/staging/dgnc/dgnc_tty.c:572:1:
warning: the frame size of 1060 bytes is larger than 1024 bytes
[-Wframe-larger-than=]

This was caused by having buffer as an automatic variable. This commit
moves it from the stack to the heap.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
338fd80f9da7772ff3b957adb7ae1ed4615c484c 06-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Fix no spaces before tabs checkpath warning

This commit corrects the 'no space before tabs' checkpath warning.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
1e8810026b96f5ecaa551e1963c4fbc71d976d85 12-Aug-2014 Konrad Zapalowicz <bergo.torino@gmail.com> staging: dgnc: Fix externs should be avoided in the .c files

This commit fixes the following checkpatch warnings:

WARNING: externs should be avoided in .c files
#80: FILE: drivers/staging/dgnc/dgnc_driver.c:80:
+int dgnc_init_module(void);
#81: FILE: drivers/staging/dgnc/dgnc_driver.c:81:
+void dgnc_cleanup_module(void);

This was caused by putting the declarations for module init and module
exit fucntions on the top of the file. The fix removes these
declarations plus it also corrects the type of the init/exit functions.

Due to the dependency between init and exit functions the
dgnc_cleanup_module had to be put first.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
dfc2b00152e99e3adc36d7066811cd936b7cd60d 31-Jul-2014 Seunghun Lee <waydi1@gmail.com> staging: dgnc: Remove unneeded dgnc_trace.c and dgnc_trace.h

Removes unneeded dgnc_trace.c and dgnc_trace.h

CC: Lidza Louina <lidza.louina@gmail.com>
CC: Mark Hounschell <markh@compro.net>
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
akefile
gnc_cls.c
gnc_driver.c
gnc_neo.c
gnc_trace.c
gnc_trace.h
gnc_tty.c
83f053de12db59d44ab534e7ad86a87a83936826 31-Jul-2014 Seunghun Lee <waydi1@gmail.com> staging: dgnc: rephrase comment

Rephrase comment to explain original intention of function.

CC: Lidza Louina <lidza.louina@gmail.com>
CC: Mark Hounschell <markh@compro.net>
Suggested-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
e325f661cbeca23208967a3fad8389a717de1d16 28-Jul-2014 Seunghun Lee <waydi1@gmail.com> staging: dgnc: removes unused if defined code

DGNC_TRACER and TRC_TO_KMEM are never defined.

This patch removes if defined DGNC_TRACER and TRC_TO_KMEM code.

CC: Lidza Louina <lidza.louina@gmail.com>
CC: Mark Hounschell <markh@compro.net>
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
gnc_driver.h
gnc_trace.c
645b0314524b8017978fc43769a884bc95776b5a 25-Jul-2014 Seunghun Lee <waydi1@gmail.com> staging: dgnc: remove commented code

This patch removes commented code in dgnc driver.

CC: Lidza Louina <lidza.louina@gmail.com>
CC: Mark Hounschell <markh@compro.net>
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
gnc_trace.c
gnc_trace.h
gnc_tty.c
igi.h
fc1cfd3a5444c989fe9f5f6dbb5eaf4e24d982e0 24-Jul-2014 Seunghun Lee <waydi1@gmail.com> staging: dgnc: Fix space required after that ','

This patch fixes checkpatch errors:
"space required after that ','"

Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
5813104211a7db9277794d71814ceb04341b7f3f 22-Jul-2014 Seunghun Lee <waydi1@gmail.com> staging: dgnc: Remove all C99 comments

This patch fixes the following checkpatch error:

ERROR: do not use C99 // comments

CC: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
igi.h
635c4efa17bcd43b2c71d5f95ab63e1d4f7ad3dd 13-Jul-2014 Jeremiah Mahler <jmmahler@gmail.com> staging: dgnc: DGNC_VERIFY_BOARD macro in do while block

Enclose the body of the multi-statement DGNC_VERIFY_BOARD macro inside a
do - while block as per Documentation/CodingStyle. Fixes 1 error found
by checkpatch.pl.

Cc: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_sysfs.c
f420c6c8e88cb25811b9f5acc99d843ede153aaf 03-Jul-2014 Daeseok Youn <daeseok.youn@gmail.com> staging: dgnc: remove redundant memset call

The brd is allocated by kzalloc() in dgnc_found_board()
so do not need to set 0 to member variable.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
354579c2eed32c25ae8e65b94b058a9dad2df072 03-Jul-2014 Daeseok Youn <daeseok.youn@gmail.com> staging: dgnc: removes unreachable code

dgnc_tty_ioctl() cannot reach the end of function.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
3098e514686305f03d695a2c5c73ba96ad4cc273 03-Jul-2014 Daeseok Youn <daeseok.youn@gmail.com> staging: dgnc: Fix unsigned value for less than zero

The "un->un_open_count" is unsigned variable, so it cannot
be less than zero.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
5b4af85eedea141026214fb40827a718633c5ccf 03-Jul-2014 Daeseok Youn <daeseok.youn@gmail.com> staging: dgnc: remove redundant null check for kfree()

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
78adbb284cf319edd05d7322ca41e877b6f628e5 28-Jun-2014 Guillaume Morin <guillaume@morinfr.org> staging: dgnc_driver.c: code style fixes

Simple code style fixes:
- "if(" -> "if ("
- "switch(" -> "switch ("
- move one open brace to the line of the declaration instead of
its own line
- remove trailing whitespace

Signed-off-by: Guillaume Morin <guillaume@morinfr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
07467e509b90c75a7c5962c0857857eae79e5c33 03-Jun-2014 Vincent Heuken <me@vincentheuken.com> Staging: dgnc: fixed brace coding style issue in dgnc_driver.c

This is a patch to the dgnc_driver.c file that fixes the following
error:
ERROR: open brace '{' following function declarations go on
the next line

Signed-off-by: Vincent Heuken <me@vincentheuken.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
7879be810c05e7a1e6ef0dde65ad730d704535df 25-May-2014 Manuel Schölling <manuel.schoelling@gmx.de> staging: dgnc: Use time_after_eq()

To be future-proof and for better readability the time comparisons are
modified to use time_after_eq() instead of plain, error-prone math.

Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
9cdf838b3a25b3cf939c7d71c3d10823d7bbab6c 17-May-2014 Masaru Nomura <massa.nomura@gmail.com> staging: dgnc: dgnc_tty: Remove a prohibited space

Remove a prohibited space before a closed parenthesis of if statement
to meet kernel coding style.

Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
a82477c3dcacb20c00481fa59cf850e0012d6533 17-May-2014 Masaru Nomura <massa.nomura@gmail.com> staging: dgnc: dgnc_tty: Add a required space

Add a required space before an open parenthesis of if statement
to meet kernel coding style.

Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
50667c67dbefea289460dc3e2b4ebc307fd88000 18-May-2014 Masaru Nomura <massa.nomura@gmail.com> staging: dgnc: Remove extra curly braces

Remove unnecessary curly braces of if statements in dgnc_neo.c and
dgnc_tty.c to meet kernel coding style.

Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
gnc_tty.c
33cfbaf5d065bb166893a1adb20bdfc70b909516 18-May-2014 Masaru Nomura <massa.nomura@gmail.com> staging: dgnc: dgnc_neo: Clean up if statement

Fix line over 80 characters and indenting of condition part.
Also, remove unnecessary braces to meet coding style.

Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
2000c581d8372b6dfad397cdf8a68fe3832c8755 18-May-2014 Masaru Nomura <massa.nomura@gmail.com> staging: dgnc: Put else statements on the right line

Fix indenting of if-else statement in dgnc_neo.c and dgnc_tty.c
so that following else-if or else statement meets coding style.

Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
gnc_tty.c
c80561e96b81a01c3e4988fc08093479a1f0c914 14-May-2014 Dan Carpenter <dan.carpenter@oracle.com> staging: dgnc: UART_IIR_XOFF code is buggy

The UART_IIR_XOFF was supposed to be a no-op but, because there was a
missing semi-colon, the if statement is not "Empty". I have just deleted
this code because it was supposed to be a no-op anyway. UART_IIR_XOFF
is a standard define and not something specific to this driver.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
gnc_cls.h
0f33ae1ed6ac39da7b1f73972eb4791fe43d15d3 29-Apr-2014 Martin Kepplinger <martink@posteo.de> staging: dgnc: use dev_err() instead of printk()

Use dev_err() insted of printk() in order to provice userspace with
more useful information and use the common kernel coding style.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_sysfs.c
36aa10aa018c2ed5571ffd145f39d3fcf993cee0 26-Apr-2014 Vitaly Osipov <vitaly.osipov@gmail.com> staging: dgnc: redundant NULL checks before kfree()

Removed redundant NULL checks before calling kfree()

Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
3f2889621a6d47c3aa5e4284af808f8d79cc5d5d 20-Apr-2014 Son P. Nguyen <fastmutex@gmail.com> Staging: dgnc: dgnc_driver: fixed incorrect braces

Fixed incorrect braces (coding style)

Signed-off-by: Son P. Nguyen <fastmutex@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
2b46be68a1b67f40df4f288b90e79181c387eda6 27-Mar-2014 Antoine Sirinelli <antoine@monte-stello.com> staging: dgnc: cleanup dgnc_finalize_board_init()

Trivial cleanups:
- Transform a printk() to a dev_err() call
- Fix 2 lines over 80 characters

Signed-off-by: Antoine Sirinelli <antoine@monte-stello.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
f7c851d4248925f8c128865222f2f8b85737b8d2 09-Mar-2014 Chi Pham <fempsci@gmail.com> staging:dgnc: Removed assignments from if statements.

Coccinelle was used for this patch. The script is not complete (semantically) and might raise some checkpatch warnings in terms of indentation depending on existing code.

*** IFASSIGNMENT.COCCI START ***

/* Coccinelle script to handle assignments in if statements
* For compound statements, can so far only handle statements with the
* assignment on either extreme */

/* This rule is for simple cases
* e.g. just an assignment in if, possibly with unary operator */
@simple@
expression E1, E2;
statement S1, S2;
@@

+ E1 = E2;
if (
- (E1 = E2)
+ E1
)
S1 else S2

/* This rule is for compound statements where the assignment is on the right.*/
@right@
expression E, E1, E2;
statement S1, S2;
@@

(
/* and */
- if (E && (E1 = E2))
+ if (E) {
+ E1 = E2;
+ if (E1)
S1 else S2
+ } else S2
|
- if (E && (E1 = E2))
+ if (E) {
+ E1 = E2;
+ if (E1)
S1
+ }

/* or */
|
- if (E || (E1 = E2))
+ if (!E) {
+ E1 = E2;
+ if (E1)
S1 else S2
+ }
+ else S1
|
- if (E || (E1 = E2))
+ if (!E) {
+ E1 = E2;
+ if (E1) S1
+ } else
S1

/* not equal */
|
- if (E != (E1 = E2))
+ E1 = E2;
+ if (E != E1)
S1 else S2
|
- if (E != (E1 = E2))
+ E1 = E2;
+ if (E != E1)
S1

/* equal */
|
- if (E == (E1 = E2))
+ E1 = E2;
+ if (E == E1)
S1 else S2
|
- if (E == (E1 = E2))
+ E1 = E2;
+ if (E == E1)
S1

/* greater than */
|
- if (E > (E1 = E2))
+ E1 = E2;
+ if (E > E1)
S1 else S2
|
- if (E > (E1 = E2))
+ E1 = E2;
+ if (E > E1)
S1

/* less than */
|
- if (E < (E1 = E2))
+ E1 = E2;
+ if (E < E1)
S1 else S2
|
- if (E < (E1 = E2))
+ E1 = E2;
+ if (E < E1)
S1

/* lesser than or equal to */
|
- if (E <= (E1 = E2))
+ E1 = E2;
+ if (E <= E1)
S1 else S2
|
- if (E <= (E1 = E2))
+ E1 = E2;
+ if (E <= E1)
S1

/* greater than or equal to */
|
- if (E >= (E1 = E2))
+ E1 = E2;
+ if (E >= E1)
S1 else S2
|
- if (E >= (E1 = E2))
+ E1 = E2;
+ if (E >= E1)
S1
)

/* This rule is for compound statements where the assignment is on the left.*/
@left@
expression E, E1, E2;
statement S1, S2;
@@

(
/* and */
- if ((E1 = E2) && E)
+ E1 = E2;
+ if (E1 && E)
S1 else S2
|
- if ((E1 = E2) && E)
+ E1 = E2;
+ if (E1 && E)
S1
|

/* or */
- if ((E1 = E2) || E)
+ E1 = E2;
+ if (E1 || E)
S1
|
- if ((E1 = E2) || E)
+ E1 = E2;
+ if (E1 || E)
S1 else S2
|

/* not equal */
- if ((E1 = E2) != E)
+ E1 = E2;
+ if (E1 != E)
S1
|
- if ((E1 = E2) != E)
+ E1 = E2;
+ if (E1 != E)
S1 else S2
|

/* equal */
- if ((E1 = E2) == E)
+ E1 = E2;
+ if (E1 == E)
S1
|
- if ((E1 = E2) == E)
+ E1 = E2;
+ if (E1 == E)
S1 else S2
|
/* greater */
- if ((E1 = E2) > E)
+ E1 = E2;
+ if (E1 > E)
S1
|
- if ((E1 = E2) > E)
+ E1 = E2;
+ if (E1 > E)
S1 else S2
|

/* less */
- if ((E1 = E2) < E)
+ E1 = E2;
+ if (E1 < E)
S1
|
- if ((E1 = E2) < E)
+ E1 = E2;
+ if (E1 < E)
S1 else S2

/* lesser than or equal to */
- if ((E1 = E2) <= E)
+ E1 = E2;
+ if (E1 <= E)
S1
|
- if ((E1 = E2) <= E)
+ E1 = E2;
+ if (E1 <= E)
S1 else S2

/* greater than or equal to */
- if ((E1 = E2) >= E)
+ E1 = E2;
+ if (E1 >= E)
S1
|
- if ((E1 = E2) >= E)
+ E1 = E2;
+ if (E1 >= E)
S1 else S2
)

*** IFASSIGNMENT.COCCI END ***

Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
gnc_tty.c
93c76c9c1dd3de4a3d4ecbd494085c45fce20414 10-Mar-2014 Daeseok Youn <daeseok.youn@gmail.com> staging: dgnc: replace unnecessary while() with if()

It doesn't need to use while loop for getting newrate,
because it always breaks out the end of while loop with
"break". So just replace while with if.

And the type of newrate is "unsigned int", this type
is never less than zero. If it can be set to negative value by
user application with ioctl(), it is not zero but it
can be a unexpected value for setting custom baudrate.

Also smatch says:
drivers/staging/dgnc/dgnc_tty.c:967 dgnc_set_custom_speed() warn:
unsigned 'newrate' is never less than zero.
drivers/staging/dgnc/dgnc_tty.c:981 dgnc_set_custom_speed() info:
ignoring unreachable code.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
d5229247c8f46d824bf213071ec82a2c64feafab 15-Mar-2014 Gulsah Kose <gulsah.1004@gmail.com> staging: dgnc: Fix quoted string split across lines warning

This patch fixes "quoted string split across lines warning" warning in
dgnc_cls.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
gnc_cls.c
0469c7471e29d4089ed7f09aef88c47a8e8c7f49 14-Mar-2014 Iulia Manda <iulia.manda21@gmail.com> Staging: dgnc: fix indentation in dgnc_mgmt.c

Align test parts in if statement on separate lines.

Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
gnc_mgmt.c
3393fe90771b00cdf5b876243ba9cd9cc1d51272 11-Mar-2014 Iulia Manda <iulia.manda21@gmail.com> Staging:dgnc: Fixed space prohibited between function name and '('

Deleted space between sizeof and open parenthethis.

Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
gnc_mgmt.c
8dd64acdbdf7796897f7dd491aa762c109c2567e 10-Mar-2014 Iulia Manda <iulia.manda21@gmail.com> Staging:dgnc: Use uaccess.h header from linux dir instead of asm

Include <linux/uaccess.h> instead of <asm/uaccess.h>

Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
gnc_mgmt.c
969fbc860a9736835926b647e1370ded22b02635 10-Mar-2014 Iulia Manda <iulia.manda21@gmail.com> Stagind:dgnc: Fixed unnecessary braces for single statement blocks

Deleted unnecessary braces for single statement if blocks.

Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
gnc_mgmt.c
1c1dd2a06d9ce42007a499745f4b1cc2468f2bc9 10-Mar-2014 Iulia Manda <iulia.manda21@gmail.com> Staging:dgnc: Fixed else not following close brace error

Fix checkpatch.pl warning - else should follow close brace.

Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
gnc_mgmt.c
cf92c9cc89d36197769acc450e7a869861220b3e 09-Mar-2014 Himangi Saraogi <himangi774@gmail.com> staging:dgnc: Replace printk by pr_warn

This patch replaces printk with pr_warn as the printk calls are used to
display warnings to remove the checkpatch.pl warnings:
WARNING: printk() should include KERN_ facility level
and then WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev,
... then pr_warn(... to printk(KERN_WARNING ... on adding KERN_WARNING
message designation.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
206654728b433c18b59d7c28a3ac67da2e28f0c3 07-Mar-2014 Monam Agarwal <monamagarwal123@gmail.com> Staging: dgnc: Fix struct file_operations should normally be const

This patch fixes following checkpatch.pl warning:
WARNING:struct file_operations should normally be const

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
f4ad847a9f1dff3ca360c577c077d23cf65db8c0 21-Dec-2013 Rashika Kheria <rashika.kheria@gmail.com> drivers: dgnc: Include appropriate header file in dgnc_trace.c

Include appropriate header file dgnc/dgnc_trace.h in dgnc_trace.c
because function dgnc_tracer_free() has its prototype declaration in the
header file.

This eliminates the following warning in dgnc_trace.c:
drivers/staging/dgnc/dgnc_trace.c:180:6: warning: no previous prototype for ‘dgnc_tracer_free’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_trace.c
f0dcc9fa42a21d850178b53586f9bd5d6fc94e12 20-Dec-2013 stalinsrinivasan.s <stalinsrinivasan.subramanian@in.bosch.com> staging: dgnc: fix checkpatch.pl usage of comparison with jiffies

This is a patch to the dgnc_cls.c file that fixes up comparison with
jiffies usage warning found by the checkpatch.pl tool

Signed-off-by: S. Stalin Srinivasan <stalinsrinivasan.s@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
9979ef7d736cb7ea5f7d1ec58c95ab9b651012e6 20-Dec-2013 stalinsrinivasan.s <stalinsrinivasan.subramanian@in.bosch.com> staging: dgnc: fix checkpatch.pl usage of volatile.

This is a patch to the dgnc_cls.c file that fixes up volatile usage
warning found by the checkpatch.pl tool

Signed-off-by: S. Stalin Srinivasan <stalinsrinivasan.s@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
cb3714a6b0b5fe1737b5138ddadce16cf4230a26 20-Dec-2013 stalinsrinivasan.s <stalinsrinivasan.subramanian@in.bosch.com> staging: dgnc: fix 80 characters per line limitation and code indent warnings.

This is a patch to the dgnc_cls.c file that
fixes up 80 characters per line and code indent
warnings found by the checkpatch.pl tool.

Signed-off-by: S. Stalin Srinivasan <stalinsrinivasan.s@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
5ba21c464b78e924ae74225e4080e42fea4560e8 29-Nov-2013 Aldo Iljazi <mail@aldo.io> Staging: dgnc: dgnc_trace.c: fixed coding style issues

Fixed the following coding style issues:

Lines 66-70: Replaced spaced with tabs.
Lines 75, 98, 182: Inserted space before the open parenthesis.
Line 89: Inserted spaces around that '='

Signed-off-by: Aldo Iljazi <mail@aldo.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_trace.c
f32eca7d6f962a9d8e998dc28a96665a9a7deb78 19-Oct-2013 Ashvini Varatharaj <ashvinivaratharaj@gmail.com> Staging: dgnc: avoiding buffer overflow

drivers/staging/dgnc/dgnc_neo.c:1969 neo_vpd() error: buffer overflow 'brd->vpd' 128 <= 128
drivers/staging/dgnc/dgnc_neo.c:1970 neo_vpd() warn: buffer overflow 'brd->vpd' 128 <= 130
drivers/staging/dgnc/dgnc_neo.c:1970 neo_vpd() warn: buffer overflow 'brd->vpd' 128 <= 130

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
e15b0c4eeb88ed5f37ed2e887b6610bd1aa44348 19-Oct-2013 Ashvini Varatharaj <ashvinivaratharaj@gmail.com> Staging: dgnc: removing the comparison 'board<0'

Fix dgnc_mgmt_ioctl() warn: unsigned 'board' is never less than zero.

Signed-off-by: Ashvini Varatharaj <ashvinivaratharaj@gmail.com>
Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_mgmt.c
a27582310ce800ad8e73291260a0852e8b603865 18-Oct-2013 Archana kumari <archanakumari959@gmail.com> staging: dgnc: braces {} are not necessary for single statement in dgnc_driver.c

Fixes "braces {} are not necessary for single statement blocks" warning
in dgnc_driver.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
4ee0925da18f84146da698b7843ceabf9053f834 18-Oct-2013 Archana kumari <archanakumari959@gmail.com> staging: dgnc:Removed unecessary error messages in dgnc_driver.c

Fixed removal of unecessary error messages in staging:dgnc:dgnc_driver.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
3d47910be4d571743289e69165d6bd9db4b122d2 17-Oct-2013 Archana kumari <archanakumari959@gmail.com> staging: dgnc: braces {} are not necessary for single statement in dgnc_cls.c

Fix checkpatch.pl issues with braces {} are not necessary
for single statement blocks in dgnc_cls.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
4a75ffa8adce46dee5fdd362577ba22778e886e8 16-Oct-2013 Archana kumari <archanakumari959@gmail.com> staging:dgnc:Fixes use of deprecated headers in dgnc_cls.c

Fixes use of deprecated header <asm/io.h> in staging:dgnc:dgnc_cls.c

Signed-off-by: Archana kumari <archanakumari959@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
968a4e9208c4f8e97dbd00346c25af7cfec05c15 09-Oct-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: dgnc_tty: Do not use 0 for NULL pointer

Do not use 0 for NULL pointer.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
a07bf39a65cb5eb4e38426afc7d5e00d560211da 04-Oct-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: changes arguments in sizeof

The arguments that were passed into sizeof were
generic. This patch changes this by putting
the actual item that we need a size of instead.

For example:
- kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
+ kzalloc(sizeof(*brd), GFP_KERNEL);

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
gnc_mgmt.c
gnc_tty.c
d90ed81ac41fc0ef62bbc8aa66b3b2f3ef19427b 27-Sep-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: Remove KERNEL_VERSION check

This check is not required.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_kcompat.h
0e4f66b448c650851b1e16cae08f9700e403c341 26-Sep-2013 Jingoo Han <jg1.han@samsung.com> staging: dgnc: Remove casting the return value which is a void pointer

Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.

CC: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
gnc_sysfs.c
b74c746120376822fb9b5a28ab419cd4e07ac44f 09-Sep-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: removes LINUX_VERSION_CODE conditionals

This patch removes the conditionals that make sure
the driver supports various versions of the kernel.
They aren't needed.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
gnc_kcompat.h
gnc_tty.c
e2aad1d5716c5f7fa5deb4a96e6b6a4e9f24e78b 25-Sep-2013 Greg Kroah-Hartman <gregkh@linuxfoundation.org> Merge 3.12-rc2 into staging-next.

This resolves the merge problem with two iio drivers that Stephen
Rothwell pointed out.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
79e30af21fa56b92585c9efa5661d9c2cf9b997b 13-Sep-2013 Masanari Iida <standby24x7@gmail.com> staging: dgnc: Fix typo in staging/dgnc

Correct spelling typo in comments

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
gnc_neo.c
gnc_neo.h
gnc_tty.c
igi.h
8f90ef80490100e5b87cc386110779680a0486c9 09-Sep-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: removes parentheses around return statements

This patch removes parentheses around return
statements. They aren't needed.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
gnc_driver.c
gnc_mgmt.c
gnc_neo.c
gnc_sysfs.c
gnc_tty.c
03425f55a1604e969112257982fb910c1ce80f4f 09-Sep-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: renames board_t to dgnc_board

This patch renames the struct board_t to dgnc_board. board_t
wasn't a good name for it since the _t suffix is for typedefs.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
gnc_driver.c
gnc_driver.h
gnc_neo.c
gnc_sysfs.c
gnc_sysfs.h
gnc_tty.c
gnc_tty.h
5418ae3188a9a57f318f51c3c26c0fedfea82f8b 11-Sep-2013 Kees Cook <keescook@chromium.org> staging: dgnc: fix potential format string flaw

Make sure that format strings cannot leak into printk() calls from the
msgbuf string.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
c211148fb6355f347ec819a05c3034acd56e75c1 30-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: adds TODO

This patchs adds a TODO for the driver.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ODO
f230586994c7f571356570634b942f88bf2772bb 28-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: driver.c and .h: removes dgnc_driver_kzmalloc func

This patch removes the dgnc_driver_kzmalloc function from
driver.c and driver.h. A previous patch replaced all
dgnc_driver_kzmalloc function calls with kzalloc.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
gnc_driver.h
52f9d66844ee191e4d4c0c93394749050aa9b9e5 28-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: driver.c and tty.c: replaces dgnc_driver_kzmalloc with kzalloc

This patch replaces dgnc_driver_kzmalloc with kzalloc.
A patch that follows removes the dgnc_driver_kzmalloc
function.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
gnc_tty.c
a7a75386f958daa23ac042c0a12b48944ff41c53 28-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: tty.c: updates uart_struct declaration for sparse

This patch edits the type casts neo_uart_struct and
cls_uart_struct. A previous patch added the marker __iomem
to these structs. This patch ensures that the change to
the marker is consistent. This also removes these
sparse warnings:

warning: incorrect type in assignment (different address spaces)
expected struct neo_uart_struct [noderef] <asn:2>*ch_neo_uart
got struct neo_uart_struct *<noident>
warning: incorrect type in assignment (different address spaces)
expected struct cls_uart_struct [noderef] <asn:2>*ch_cls_uart
got struct cls_uart_struct *<noident>

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
e7f1c9320ee6b596d58c4b2baeb1bbdfb1f0d9af 26-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: tty.c: edits var in init func for sparse

This patch edits the vaddr variable in dgnc_tty_init.
The variable gets set to board_t->re_map_membase. A
previous patch changed the re_map_membase variable's
marker and type. This patch makes sure that the
changes are consistent and that it doesn't cause
sparse warnings.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
c2ac546ea4b5e71dafb80892558ca0f125187998 26-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: neo.c: changes param in neo_read_eeprom function for sparse

This patch adds a marker to neo_read_eeprom function's
base parameter.

It removes these warnings found in neo.c:

warning: incorrect type in argument 1 (different address spaces)
expected unsigned char *base
got unsigned char [noderef] [usertype] <asn:2>*re_map_membase
warning: incorrect type in argument 2 (different address spaces)
expected void volatile [noderef] <asn:2>*addr
got unsigned char *

These warnings happen because this function gets
called with a board_t->re_map_base variable. A previous
patch added the __iomem marker to this variable. This
patch ensures that the changes are consistent.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
68b146e8944ae3cfc64feb7f9a12cc6190562758 26-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: cls.c: changes var in cls_vpd function for sparse

This patch changes cls_vpd function's re_map_vpdbase variable
type and marker.

It removes these warnings found in cls.c:

warning: incorrect type in assignment (different address spaces)
expected unsigned char [usertype] *re_map_vpdbase
got void [noderef] <asn:2>*
warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] <asn:2>*addr
got unsigned char [usertype] *
warning: incorrect type in argument 1 (different address spaces)
expected void volatile [noderef] <asn:2>*addr
got unsigned char [usertype] *re_map_vpdbase

The variables passed to readb needs to be of type u8
with a __iomem marker. re_map_vpdbase is passed into
readb in the code.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
7915dea707820724ad5d5117e9e07ccccf712dd6 26-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: driver.h: changes a struct board_t var's type and marker for sparse

This patch changes the board_t->re_map_membase variable
type and marker.

It removes these warnings found in the neo.c,
driver.c and cls.c files:

warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] <asn:2>*addr
got unsigned char volatile *<noident>
warning: incorrect type in argument 2 (different address spaces)
expected void volatile [noderef] <asn:2>*addr
got unsigned char volatile *<noident>

The variables passed to readb and writeb need to
be of type u8 with a __iomem marker. These warnings
were popping up everytime the readb and writeb
functions were called with a
board_t->re_map_membase variable.

The change made to the driver.h file adds the marker
and changes the variable type.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
2587771a61bdf89a45cf54ddbed5458deaaddf26 26-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: neo_uart_struct: adds marker and changes vars' types for sparse

This patch fixes these warnings found in the neo.c file:

warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] <asn:2>*addr
got unsigned char volatile *<noident>
warning: incorrect type in argument 2 (different address spaces)
expected void volatile [noderef] <asn:2>*addr
got unsigned char volatile *<noident>

The variables passed to readb and writeb need to
be of type u8 with a __iomem marker. These warnings
were popping up everytime the readb and writeb
functions were called with a neo_uart_struct variable.

The change made to the driver.h file adds the marker
to the neo_uart_struct and the changes in neo.h
changes the variables' types.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
gnc_neo.h
2ea550bdfad1442749e6a1353afda93c8bb7a9ac 26-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: cls_uart_struct: adds marker and changes vars' types for sparse

This patch removes these sparse warnings found in the cls.c file:

warning: incorrect type in argument 1 (different address spaces)
expected void const volatile [noderef] <asn:2>*addr
got unsigned char volatile *<noident>
warning: incorrect type in argument 2 (different address spaces)
expected void volatile [noderef] <asn:2>*addr
got unsigned char volatile *<noident>

The variables passed to readb and writeb need to
be of type u8 with a __iomem marker. These warnings
were popping up everytime the readb and writeb
functions were called with a cls_uart_struct variable.

The change made to the driver.h file adds the marker
to the cls_uart_struct and the changes in cls.h
changes its variables' types.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.h
gnc_driver.h
b0b15cb27d0ae43ea15e10c7693781e92e92a370 26-Aug-2013 Chen Gang <gang.chen@asianux.com> staging: dgnc: Kconfig: add dependency PCI for it

DGNC is based on PCI, so need add related dependency, or when compiled
with PCI disabled, it will be fail.

The related error (randconfig for PCI disabled under s390):

drivers/staging/dgnc/dgnc_cls.c:1394:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
drivers/staging/dgnc/dgnc_cls.c:1407:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]

Cc: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
config
8287ac00ddfece19834d40a424406eecc692b407 22-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: driver.c: removes dgnc_mbuf function

This patch removes the dgnc_mbuf function. This function was causing the
errors:

drivers/staging/dgnc/dgnc_driver.c: In function 'dgnc_mbuf.constprop.0':
drivers/staging/dgnc/dgnc_driver.c:945:1: warning: the frame size of 1032
bytes is larger than 1024 bytes [-Wframe-larger-than=]

drivers/staging/dgnc/dgnc_tty.c: In function 'dgnc_sniff_nowait_nolock':
drivers/staging/dgnc/dgnc_tty.c:614:1: warning: the frame size of 1056
bytes is larger than 1024 bytes [-Wframe-larger-than=]

This patch removes it so the kernel won't be making noise when its
device is found on the system.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
68a5a5f38c2d80f74c946972375983ff85d508bb 22-Aug-2013 Tushar Behera <tushar.behera@linaro.org> staging: dgnc: driver.c: Need to include slab.h

With 'allyesconfig', we get following error without this.

drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_cleanup_board’:
drivers/staging/dgnc/dgnc_driver.c:459:3: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
kfree(brd->msgbuf_head);
^
drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_driver_kzmalloc’:
drivers/staging/dgnc/dgnc_driver.c:905:2: error: implicit declaration of function ‘kmalloc’ [-Werror=implicit-function-declaration]
void *p = kmalloc(size, priority);

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Cc: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
90d2a47152ae1fde6dc60f7bf9952035bb0e4924 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: tty.c: fixes code indent error

This patch fixes the error "code indent should use
tabs where possible" in dgnc_tty.c.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
0a60eb3313b4ac3bc173f21d828f893705b32245 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: sysfs.c: fixes code indent error

This patch fixes the error "code indent should use
tabs where possible" in dgnc_sysfs.c.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_sysfs.c
00804f773bad78dd15f9b5baae45d2808bc3f062 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: neo.c: fixes code indent error

This patch fixes the error "code indent should use
tabs where possible" in dgnc_neo.c.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
5a62025d4bbd98040daec93ed52c1ffe7eee2ef1 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: driver.h: fixes code indent error

This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.h.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
eae9842a5f10ae62ce653a12c8b9a150f544379f 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: driver.c: fixes code indent error

This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.c.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
ba48f61b135ad1ace174f548507b2af386372fd5 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: fixes struct declaration

This patch fixes the error: open brace '{'
following struct go on the same line.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
igi.h
58b905b39ffd7efbfd6d3ec3dbfd439b0b448af0 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: tty.c: fixes pointer syntax

This patch fixes the error: "foo* bar" should be "foo *bar".

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
4cfa73097f50c01057754112ef25f5edadf79c9d 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: removes CVS code from files

This patch removes the code supporting CVS
from its files.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
gnc_driver.c
gnc_mgmt.c
gnc_neo.c
gnc_pci.h
gnc_sysfs.c
gnc_trace.c
gnc_trace.h
gnc_tty.c
igi.h
0a0ba851746c398ce61a24d42e693bf31515b481 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: dpacompat.h: removes trailing whitespace

This patch removes trailing whitespace in
the dpacompat.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
pacompat.h
b8f5472a69d114e5aee9036a7e57e4990866b1fb 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: digi.h: removes trailing whitespace

This patch removes trailing whitespace in
the digi.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
igi.h
8b07d521c6844f577abd0ae1d30ead5401f5f47d 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: tty.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_tty.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
cfa4ccc9ab20a80079e92026379e3093a17ca9c0 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: trace.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_trace.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_trace.c
abbb82df2c2edd06534948d957a9aca9e61b4b24 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: sysfs.h: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_sysfs.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_sysfs.h
7a97deb209485cb6a4d8962e4b617e74f5f8dcb4 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: sysfs.c: removes trailing whitespace

This patch removes trailing whitespace in
the sysfs.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_sysfs.c
bae4f6886f566a1e064c3168931229e60204da9b 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: neo.h: removes trailing whitespace

This patch removes trailing whitespace in
the neo.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.h
5ba5b89ab6e68b309d1fcabb4be0d0b521aff3db 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: neo.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_neo.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
0986cda11eea9c97cddfabb0657688ad8dcaaf9a 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: mgmt.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_mgmt.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_mgmt.c
013c951d540d9c231ba5c59ca982bd364967c748 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: kcompat.h: removes trailing whitespace

This patch removes trailing whitespace in
the kcompat.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_kcompat.h
4c1c56e62c655f8617082f10f642b74866416840 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: driver.h: removes trailing whitespace

This patch removes trailing whitespace in
the driver.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
817b7847165ca22064bd52a6aea6ecb5fcc45eda 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: driver.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_driver.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
1ef56a42e93c7c27243943b6b8ef99a3abc2e674 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: cls.h: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_cls.h file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.h
5ca46fd4c814de9189b21ce4c29d00022f100152 21-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: cls.c: removes trailing whitespace

This patch removes trailing whitespace in
the dgnc_cls.c file.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
62a86e50e73f60300f51e30a62ba04a76888b4da 20-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: removes ifdef HAVE_UNLOCKED_IOCTL conditionals

This patch removes the HAVE_UNLOCKED_IOCTL conditional
statements from driver.c, mgmt.c and mgmt.h. This was
used to support older kernels. It isn't needed now.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
gnc_mgmt.c
gnc_mgmt.h
f1900e78cf599df78bbd7fe7762dd1a22d3c56a0 20-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: driver.c: fixes warning about assigning pointer

This patch fixes a warning associated with assigining
a pointer in the dgnc_mbuf function.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.c
35cf90459312fc3b6bc4bbf31aa5fe47b73922d4 15-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: removes proc code

This patch removes the dgnc_proc.c and dgnc_proc.h files and all
references to proc functions in dgnc_driver.c. This also removes proc.h
from the include headers in driver.c, mgmt.c and sysfs.c and proc.o
from the Makefile.

Drivers now use sysfs instead of proc.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
akefile
gnc_driver.c
gnc_mgmt.c
gnc_proc.c
gnc_proc.h
gnc_sysfs.c
100013fa1d15181dfefc22e61a2744e8e0ca3c00 13-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: removes read_cnt, real_raw, rawreadok and buf

This patch removes the use of read_cnt, real_raw, buf and rawreadok. The
variable buf is never used in the code. The variables rawreadok read_cnt
and real_raw don't exist in the new API. Reading the data raw is no
longer supported by the tty layer.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
a31cefa2648205a972b65c4b8d520823ae4be1b6 13-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: fixes ioctl param list

The declaration for the ioctl function has changed. The previous version
of this declaration took struct file *file as a parameter and the new
one does not. This patch removes that parameter.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
9b03ffaf7fb99316a2c21302e9dc1e4fef18a420 13-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgcn: removes unnecessary commands in ioctl

The commands TIOCGETP, TCGETS, and TCGETA are not supposed to be seen by
the ioctl. This patch removes the switch cases for these commands.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
5857a0b5f11b424911cc44034357d69abba85f8b 13-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: dereferences ts var in dgnc_tty_close()

The value tty->termios needed to be dereferenced to be assigned to the
variable ts.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
bf0f2ebff31adf786b59bc84d0522fed246c9471 13-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: fixes tty_port and tty_struct params

The functions tty_flip_buffer_push, tty_insert_flip_string,
tty_insert_flip_char and tty_buffer_request_room now require a struct of
type tty_port instead of struct tty_struct. This patch makes those
changes.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
22e3de76ab7f4e02825a158cb2575feb5be6b062 13-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: fixes termios error

This patch fixes this error: invalid type argument of ‘->’ (have ‘struct ktermios’).

There were changes in the tty layer's API. Access to the termios flags changed from tty->termios->*flag* to tty->termios.*flag*.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_tty.c
d27727b50219f9a7033e1a1be3fc45644881210f 13-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: removes Makefile.inc

The Makefile contains the variables needed for the driver to build.
The Makefile.inc isn't needed.

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
akefile.inc
ee92d533fad362036c90a0de09713c348e6f0436 02-Aug-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: Remove version.h header inclusion in dgnc_trace.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_trace.c
a111ea2eea27cc7558c398b89479e17343931fce 02-Aug-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: Remove version.h header inclusion in dgnc_sysfs.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_sysfs.c
253085a1e53f6daed43e0d46c3398a6d8ee7740a 02-Aug-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: Remove version.h header inclusion in dgnc_neo.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_neo.c
c397d5ecf59b3c1fb3c66a4254c4ccbbb6520c7c 02-Aug-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: Remove version.h header inclusion in dgnc_mgmt.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_mgmt.c
c27cdf0a7c298c10a768773cf4839a8450054597 02-Aug-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: Include version.h header in dgnc_kcompat.h

version.h header inclusion is necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_kcompat.h
02f2dff6b9f240b33e0914e4364a86646fd6cdb6 02-Aug-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: Remove version.h header inclusion in dgnc_driver.h

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_driver.h
17cd641b9a08535e0cf3891c9830d6e4739ccf02 02-Aug-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: Remove version.h header inclusion in dgnc_cls.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_cls.c
2db1f402fa0eb06d0443dc943715dbcdb05fc398 02-Aug-2013 Sachin Kamat <sachin.kamat@linaro.org> staging: dgnc: Remove duplicate header file inclusion

sched.h was included twice.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
gnc_proc.c
0b99d58902dd82fa51216eb8e0d6ddd8c43e90e4 01-Aug-2013 Lidza Louina <lidza.louina@gmail.com> staging: dgnc: add dgnc digi driver

This patch adds the DGNC driver. This is a TTY Serial Port
Driver for the Digi International Neo and Classic PCI based product
line by Digi International <http://www.digi.com>.

This driver isn't hooked up to the build system because it doesn't
build, it merely adds the driver written by Digi to the kernel tree so
that it can be cleaned up and fixed up properly over time.

Cc: Mark Hounschell <markh@compro.net>
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
config
akefile
akefile.inc
gnc_cls.c
gnc_cls.h
gnc_driver.c
gnc_driver.h
gnc_kcompat.h
gnc_mgmt.c
gnc_mgmt.h
gnc_neo.c
gnc_neo.h
gnc_pci.h
gnc_proc.c
gnc_proc.h
gnc_sysfs.c
gnc_sysfs.h
gnc_trace.c
gnc_trace.h
gnc_tty.c
gnc_tty.h
gnc_types.h
igi.h
pacompat.h