fwsignal.c revision fba1400a9b8149b3c7ee02be3b1ea0429912372e
1/*
2 * Copyright (c) 2010 Broadcom Corporation
3 *
4 * Permission to use, copy, modify, and/or distribute this software for any
5 * purpose with or without fee is hereby granted, provided that the above
6 * copyright notice and this permission notice appear in all copies.
7 *
8 * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
9 * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
10 * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
11 * SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
12 * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION
13 * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
14 * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
15 */
16#include <linux/types.h>
17#include <linux/if_ether.h>
18#include <linux/spinlock.h>
19#include <linux/skbuff.h>
20#include <linux/netdevice.h>
21#include <linux/err.h>
22#include <uapi/linux/nl80211.h>
23
24#include <brcmu_utils.h>
25#include <brcmu_wifi.h>
26#include "dhd.h"
27#include "dhd_dbg.h"
28#include "fwil.h"
29#include "fweh.h"
30#include "fwsignal.h"
31
32/**
33 * DOC: Firmware Signalling
34 *
35 * Firmware can send signals to host and vice versa, which are passed in the
36 * data packets using TLV based header. This signalling layer is on top of the
37 * BDC bus protocol layer.
38 */
39
40/*
41 * single definition for firmware-driver flow control tlv's.
42 *
43 * each tlv is specified by BRCMF_FWS_TLV_DEF(name, ID, length).
44 * A length value 0 indicates variable length tlv.
45 */
46#define BRCMF_FWS_TLV_DEFLIST \
47	BRCMF_FWS_TLV_DEF(MAC_OPEN, 1, 1) \
48	BRCMF_FWS_TLV_DEF(MAC_CLOSE, 2, 1) \
49	BRCMF_FWS_TLV_DEF(MAC_REQUEST_CREDIT, 3, 2) \
50	BRCMF_FWS_TLV_DEF(TXSTATUS, 4, 4) \
51	BRCMF_FWS_TLV_DEF(PKTTAG, 5, 4) \
52	BRCMF_FWS_TLV_DEF(MACDESC_ADD,	6, 8) \
53	BRCMF_FWS_TLV_DEF(MACDESC_DEL, 7, 8) \
54	BRCMF_FWS_TLV_DEF(RSSI, 8, 1) \
55	BRCMF_FWS_TLV_DEF(INTERFACE_OPEN, 9, 1) \
56	BRCMF_FWS_TLV_DEF(INTERFACE_CLOSE, 10, 1) \
57	BRCMF_FWS_TLV_DEF(FIFO_CREDITBACK, 11, 8) \
58	BRCMF_FWS_TLV_DEF(PENDING_TRAFFIC_BMP, 12, 2) \
59	BRCMF_FWS_TLV_DEF(MAC_REQUEST_PACKET, 13, 3) \
60	BRCMF_FWS_TLV_DEF(HOST_REORDER_RXPKTS, 14, 10) \
61	BRCMF_FWS_TLV_DEF(TRANS_ID, 18, 6) \
62	BRCMF_FWS_TLV_DEF(COMP_TXSTATUS, 19, 1) \
63	BRCMF_FWS_TLV_DEF(FILLER, 255, 0)
64
65/**
66 * enum brcmf_fws_tlv_type - definition of tlv identifiers.
67 */
68#define BRCMF_FWS_TLV_DEF(name, id, len) \
69	BRCMF_FWS_TYPE_ ## name =  id,
70enum brcmf_fws_tlv_type {
71	BRCMF_FWS_TLV_DEFLIST
72	BRCMF_FWS_TYPE_INVALID
73};
74#undef BRCMF_FWS_TLV_DEF
75
76#ifdef DEBUG
77/**
78 * brcmf_fws_tlv_names - array of tlv names.
79 */
80#define BRCMF_FWS_TLV_DEF(name, id, len) \
81	{ id, #name },
82static struct {
83	enum brcmf_fws_tlv_type id;
84	const char *name;
85} brcmf_fws_tlv_names[] = {
86	BRCMF_FWS_TLV_DEFLIST
87};
88#undef BRCMF_FWS_TLV_DEF
89
90static const char *brcmf_fws_get_tlv_name(enum brcmf_fws_tlv_type id)
91{
92	int i;
93
94	for (i = 0; i < ARRAY_SIZE(brcmf_fws_tlv_names); i++)
95		if (brcmf_fws_tlv_names[i].id == id)
96			return brcmf_fws_tlv_names[i].name;
97
98	return "INVALID";
99}
100#else
101static const char *brcmf_fws_get_tlv_name(enum brcmf_fws_tlv_type id)
102{
103	return "NODEBUG";
104}
105#endif /* DEBUG */
106
107/**
108 * flags used to enable tlv signalling from firmware.
109 */
110#define BRCMF_FWS_FLAGS_RSSI_SIGNALS			0x0001
111#define BRCMF_FWS_FLAGS_XONXOFF_SIGNALS			0x0002
112#define BRCMF_FWS_FLAGS_CREDIT_STATUS_SIGNALS		0x0004
113#define BRCMF_FWS_FLAGS_HOST_PROPTXSTATUS_ACTIVE	0x0008
114#define BRCMF_FWS_FLAGS_PSQ_GENERATIONFSM_ENABLE	0x0010
115#define BRCMF_FWS_FLAGS_PSQ_ZERO_BUFFER_ENABLE		0x0020
116#define BRCMF_FWS_FLAGS_HOST_RXREORDER_ACTIVE		0x0040
117
118#define BRCMF_FWS_HANGER_MAXITEMS			1024
119#define BRCMF_FWS_HANGER_ITEM_STATE_FREE		1
120#define BRCMF_FWS_HANGER_ITEM_STATE_INUSE		2
121#define BRCMF_FWS_HANGER_ITEM_STATE_INUSE_SUPPRESSED	3
122
123#define BRCMF_FWS_STATE_OPEN				1
124#define BRCMF_FWS_STATE_CLOSE				2
125
126#define BRCMF_FWS_FCMODE_NONE				0
127#define BRCMF_FWS_FCMODE_IMPLIED_CREDIT			1
128#define BRCMF_FWS_FCMODE_EXPLICIT_CREDIT		2
129
130#define BRCMF_FWS_MAC_DESC_TABLE_SIZE			32
131#define BRCMF_FWS_MAX_IFNUM				16
132#define BRCMF_FWS_MAC_DESC_ID_INVALID			0xff
133
134#define BRCMF_FWS_HOSTIF_FLOWSTATE_OFF			0
135#define BRCMF_FWS_HOSTIF_FLOWSTATE_ON			1
136
137#define BRCMF_FWS_PSQ_PREC_COUNT		((NL80211_NUM_ACS + 1) * 2)
138#define BRCMF_FWS_PSQ_LEN				256
139
140/**
141 * struct brcmf_fws_mac_descriptor - firmware signalling data per node/interface
142 *
143 * @occupied: slot is in use.
144 * @mac_handle: handle for mac entry determined by firmware.
145 * @interface_id: interface index.
146 * @state: current state.
147 * @ac_bitmap: ac queue bitmap.
148 * @requested_credit: credits requested by firmware.
149 * @ea: ethernet address.
150 * @psq: power-save queue.
151 */
152struct brcmf_fws_mac_descriptor {
153	u8 occupied;
154	u8 mac_handle;
155	u8 interface_id;
156	u8 state;
157	u8 ac_bitmap;
158	u8 requested_credit;
159	u8 ea[ETH_ALEN];
160	struct pktq psq;
161};
162
163/**
164 * FWFC packet identifier
165 *
166 * 32-bit packet identifier used in PKTTAG tlv from host to dongle.
167 *
168 * - Generated at the host (e.g. dhd)
169 * - Seen as a generic sequence number by wlc except the flags field
170 *
171 * Generation	: b[31]	=> generation number for this packet [host->fw]
172 *			   OR, current generation number [fw->host]
173 * Flags	: b[30:27] => command, status flags
174 * FIFO-AC	: b[26:24] => AC-FIFO id
175 * h-slot	: b[23:8] => hanger-slot
176 * freerun	: b[7:0] => A free running counter
177 */
178#define BRCMF_FWS_PKTTAG_GENERATION_MASK		0x80000000
179#define BRCMF_FWS_PKTTAG_GENERATION_SHIFT		31
180#define BRCMF_FWS_PKTTAG_FLAGS_MASK			0x78000000
181#define BRCMF_FWS_PKTTAG_FLAGS_SHIFT			27
182#define BRCMF_FWS_PKTTAG_FIFO_MASK			0x07000000
183#define BRCMF_FWS_PKTTAG_FIFO_SHIFT			24
184#define BRCMF_FWS_PKTTAG_HSLOT_MASK			0x00ffff00
185#define BRCMF_FWS_PKTTAG_HSLOT_SHIFT			8
186#define BRCMF_FWS_PKTTAG_FREERUN_MASK			0x000000ff
187#define BRCMF_FWS_PKTTAG_FREERUN_SHIFT			0
188
189#define brcmf_fws_pkttag_set_field(var, field, value) \
190	brcmu_maskset32((var), BRCMF_FWS_PKTTAG_ ## field ## _MASK, \
191			     BRCMF_FWS_PKTTAG_ ## field ## _SHIFT, (value))
192#define brcmf_fws_pkttag_get_field(var, field) \
193	brcmu_maskget32((var), BRCMF_FWS_PKTTAG_ ## field ## _MASK, \
194			     BRCMF_FWS_PKTTAG_ ## field ## _SHIFT)
195
196struct brcmf_fws_info {
197	struct brcmf_pub *drvr;
198	struct brcmf_fws_stats stats;
199	struct brcmf_fws_mac_descriptor nodes[BRCMF_FWS_MAC_DESC_TABLE_SIZE];
200	struct brcmf_fws_mac_descriptor other;
201	int fifo_credit[NL80211_NUM_ACS+1+1];
202};
203
204/**
205 * brcmf_fws_get_tlv_len() - returns defined length for given tlv id.
206 */
207#define BRCMF_FWS_TLV_DEF(name, id, len) \
208	case BRCMF_FWS_TYPE_ ## name: \
209		return len;
210
211static int brcmf_fws_get_tlv_len(struct brcmf_fws_info *fws,
212				 enum brcmf_fws_tlv_type id)
213{
214	switch (id) {
215	BRCMF_FWS_TLV_DEFLIST
216	default:
217		brcmf_err("invalid tlv id: %d\n", id);
218		fws->stats.tlv_invalid_type++;
219		break;
220	}
221	return -EINVAL;
222}
223#undef BRCMF_FWS_TLV_DEF
224
225static void brcmf_fws_init_mac_descriptor(struct brcmf_fws_mac_descriptor *desc,
226					  u8 *addr, u8 ifidx)
227{
228	brcmf_dbg(TRACE, "enter: ea=%pM, ifidx=%u\n", addr, ifidx);
229	desc->occupied = 1;
230	desc->state = BRCMF_FWS_STATE_OPEN;
231	desc->requested_credit = 0;
232	/* depending on use may need ifp->bssidx instead */
233	desc->interface_id = ifidx;
234	desc->ac_bitmap = 0xff; /* update this when handling APSD */
235	memcpy(&desc->ea[0], addr, ETH_ALEN);
236}
237
238static
239void brcmf_fws_clear_mac_descriptor(struct brcmf_fws_mac_descriptor *desc)
240{
241	brcmf_dbg(TRACE,
242		  "enter: ea=%pM, ifidx=%u\n", desc->ea, desc->interface_id);
243	desc->occupied = 0;
244	desc->state = BRCMF_FWS_STATE_CLOSE;
245	desc->requested_credit = 0;
246}
247
248static struct brcmf_fws_mac_descriptor *
249brcmf_fws_mac_descriptor_lookup(struct brcmf_fws_info *fws, u8 *ea)
250{
251	struct brcmf_fws_mac_descriptor *entry;
252	int i;
253
254	brcmf_dbg(TRACE, "enter: ea=%pM\n", ea);
255	if (ea == NULL)
256		return ERR_PTR(-EINVAL);
257
258	entry = &fws->nodes[0];
259	for (i = 0; i < ARRAY_SIZE(fws->nodes); i++) {
260		if (entry->occupied && !memcmp(entry->ea, ea, ETH_ALEN))
261			return entry;
262		entry++;
263	}
264
265	return ERR_PTR(-ENOENT);
266}
267
268static void brcmf_fws_mac_desc_cleanup(struct brcmf_fws_mac_descriptor *entry,
269				       bool (*fn)(struct sk_buff *, void *),
270				       int ifidx)
271{
272	brcmf_dbg(TRACE, "enter: entry=(ea=%pM,ifid=%d), ifidx=%d\n",
273		  entry->ea, entry->interface_id, ifidx);
274	if (entry->occupied && (fn == NULL || (ifidx == entry->interface_id))) {
275		brcmf_dbg(TRACE, "flush delayQ: ifidx=%d, qlen=%d\n",
276			  ifidx, entry->psq.len);
277		/* release packets held in DELAYQ */
278		brcmu_pktq_flush(&entry->psq, true, fn, &ifidx);
279		entry->occupied = !!(entry->psq.len);
280	}
281}
282
283static void brcmf_fws_cleanup(struct brcmf_fws_info *fws, int ifidx)
284{
285	int i;
286	struct brcmf_fws_mac_descriptor *table;
287
288	brcmf_dbg(TRACE, "enter: ifidx=%d\n", ifidx);
289	if (fws == NULL)
290		return;
291
292	/* cleanup individual nodes */
293	table = &fws->nodes[0];
294	for (i = 0; i < ARRAY_SIZE(fws->nodes); i++)
295		brcmf_fws_mac_desc_cleanup(&table[i], NULL, ifidx);
296
297	brcmf_fws_mac_desc_cleanup(&fws->other, NULL, ifidx);
298}
299
300static int brcmf_fws_rssi_indicate(struct brcmf_fws_info *fws, s8 rssi)
301{
302	brcmf_dbg(CTL, "rssi %d\n", rssi);
303	return 0;
304}
305
306static
307int brcmf_fws_macdesc_indicate(struct brcmf_fws_info *fws, u8 type, u8 *data)
308{
309	struct brcmf_fws_mac_descriptor *entry, *existing;
310	u8 mac_handle;
311	u8 ifidx;
312	u8 *addr;
313
314	mac_handle = *data++;
315	ifidx = *data++;
316	addr = data;
317
318	entry = &fws->nodes[mac_handle & 0x1F];
319	if (type == BRCMF_FWS_TYPE_MACDESC_DEL) {
320		brcmf_dbg(TRACE, "deleting mac %pM idx %d\n", addr, ifidx);
321		if (entry->occupied) {
322			entry->occupied = 0;
323			entry->state = BRCMF_FWS_STATE_CLOSE;
324			entry->requested_credit = 0;
325		} else {
326			fws->stats.mac_update_failed++;
327		}
328		return 0;
329	}
330
331	brcmf_dbg(TRACE, "add mac %pM idx %d\n", addr, ifidx);
332	existing = brcmf_fws_mac_descriptor_lookup(fws, addr);
333	if (IS_ERR(existing)) {
334		if (!entry->occupied) {
335			entry->mac_handle = mac_handle;
336			brcmf_fws_init_mac_descriptor(entry, addr, ifidx);
337			brcmu_pktq_init(&entry->psq, BRCMF_FWS_PSQ_PREC_COUNT,
338					BRCMF_FWS_PSQ_LEN);
339		} else {
340			fws->stats.mac_update_failed++;
341		}
342	} else {
343		if (entry != existing) {
344			brcmf_dbg(TRACE, "relocate mac\n");
345			memcpy(entry, existing,
346			       offsetof(struct brcmf_fws_mac_descriptor, psq));
347			entry->mac_handle = mac_handle;
348			brcmf_fws_clear_mac_descriptor(existing);
349		} else {
350			brcmf_dbg(TRACE, "use existing\n");
351			WARN_ON(entry->mac_handle != mac_handle);
352			/* TODO: what should we do here: continue, reinit, .. */
353		}
354	}
355	return 0;
356}
357
358static int brcmf_fws_dbg_seqnum_check(struct brcmf_fws_info *fws, u8 *data)
359{
360	__le32 timestamp;
361
362	memcpy(&timestamp, &data[2], sizeof(timestamp));
363	brcmf_dbg(INFO, "received: seq %d, timestamp %d\n", data[1],
364		  le32_to_cpu(timestamp));
365	return 0;
366}
367
368/* using macro so sparse checking does not complain
369 * about locking imbalance.
370 */
371#define brcmf_fws_lock(drvr, flags)				\
372do {								\
373	flags = 0;						\
374	spin_lock_irqsave(&((drvr)->fws_spinlock), (flags));	\
375} while (0)
376
377/* using macro so sparse checking does not complain
378 * about locking imbalance.
379 */
380#define brcmf_fws_unlock(drvr, flags) \
381	spin_unlock_irqrestore(&((drvr)->fws_spinlock), (flags))
382
383static int brcmf_fws_notify_credit_map(struct brcmf_if *ifp,
384				       const struct brcmf_event_msg *e,
385				       void *data)
386{
387	struct brcmf_fws_info *fws = ifp->drvr->fws;
388	int i;
389	ulong flags;
390	u8 *credits = data;
391
392	brcmf_fws_lock(ifp->drvr, flags);
393	for (i = 0; i < ARRAY_SIZE(fws->fifo_credit); i++)
394		fws->fifo_credit[i] = *credits++;
395	brcmf_fws_unlock(ifp->drvr, flags);
396	return 0;
397}
398
399int brcmf_fws_init(struct brcmf_pub *drvr)
400{
401	u32 tlv = 0;
402	int rc;
403
404	/* enable rssi signals */
405	if (drvr->fw_signals)
406		tlv = BRCMF_FWS_FLAGS_RSSI_SIGNALS |
407		      BRCMF_FWS_FLAGS_XONXOFF_SIGNALS;
408
409	spin_lock_init(&drvr->fws_spinlock);
410
411	drvr->fws = kzalloc(sizeof(*(drvr->fws)), GFP_KERNEL);
412	if (!drvr->fws) {
413		rc = -ENOMEM;
414		goto fail;
415	}
416
417	/* enable proptxtstatus signaling by default */
418	rc = brcmf_fil_iovar_int_set(drvr->iflist[0], "tlv", tlv);
419	if (rc < 0) {
420		brcmf_err("failed to set bdcv2 tlv signaling\n");
421		goto fail;
422	}
423
424	if (brcmf_fweh_register(drvr, BRCMF_E_FIFO_CREDIT_MAP,
425				brcmf_fws_notify_credit_map)) {
426		brcmf_err("register credit map handler failed\n");
427		goto fail;
428	}
429
430	/* create debugfs file for statistics */
431	brcmf_debugfs_create_fws_stats(drvr, &drvr->fws->stats);
432
433	/* set linkage back */
434	drvr->fws->drvr = drvr;
435
436	/* TODO: remove upon feature delivery */
437	brcmf_err("%s bdcv2 tlv signaling [%x]\n",
438		  drvr->fw_signals ? "enabled" : "disabled", tlv);
439	return 0;
440
441fail:
442	/* disable flow control entirely */
443	drvr->fw_signals = false;
444	brcmf_fws_deinit(drvr);
445	return rc;
446}
447
448void brcmf_fws_deinit(struct brcmf_pub *drvr)
449{
450	struct brcmf_fws_info *fws = drvr->fws;
451	ulong flags;
452
453	/* cleanup */
454	brcmf_fws_lock(drvr, flags);
455	brcmf_fws_cleanup(fws, -1);
456	drvr->fws = NULL;
457	brcmf_fws_unlock(drvr, flags);
458
459	/* free top structure */
460	kfree(fws);
461}
462
463int brcmf_fws_hdrpull(struct brcmf_pub *drvr, int ifidx, s16 signal_len,
464		      struct sk_buff *skb)
465{
466	struct brcmf_fws_info *fws = drvr->fws;
467	ulong flags;
468	u8 *signal_data;
469	s16 data_len;
470	u8 type;
471	u8 len;
472	u8 *data;
473
474	brcmf_dbg(TRACE, "enter: ifidx %d, skblen %u, sig %d\n",
475		  ifidx, skb->len, signal_len);
476
477	WARN_ON(signal_len > skb->len);
478
479	/* if flow control disabled, skip to packet data and leave */
480	if (!signal_len || !drvr->fw_signals) {
481		skb_pull(skb, signal_len);
482		return 0;
483	}
484
485	/* lock during tlv parsing */
486	brcmf_fws_lock(drvr, flags);
487
488	fws->stats.header_pulls++;
489	data_len = signal_len;
490	signal_data = skb->data;
491
492	while (data_len > 0) {
493		/* extract tlv info */
494		type = signal_data[0];
495
496		/* FILLER type is actually not a TLV, but
497		 * a single byte that can be skipped.
498		 */
499		if (type == BRCMF_FWS_TYPE_FILLER) {
500			signal_data += 1;
501			data_len -= 1;
502			continue;
503		}
504		len = signal_data[1];
505		data = signal_data + 2;
506
507		/* abort parsing when length invalid */
508		if (data_len < len + 2)
509			break;
510
511		if (len != brcmf_fws_get_tlv_len(fws, type))
512			break;
513
514		brcmf_dbg(INFO, "tlv type=%d (%s), len=%d\n", type,
515			  brcmf_fws_get_tlv_name(type), len);
516		switch (type) {
517		case BRCMF_FWS_TYPE_MAC_OPEN:
518		case BRCMF_FWS_TYPE_MAC_CLOSE:
519		case BRCMF_FWS_TYPE_MAC_REQUEST_CREDIT:
520		case BRCMF_FWS_TYPE_TXSTATUS:
521		case BRCMF_FWS_TYPE_PKTTAG:
522		case BRCMF_FWS_TYPE_INTERFACE_OPEN:
523		case BRCMF_FWS_TYPE_INTERFACE_CLOSE:
524		case BRCMF_FWS_TYPE_FIFO_CREDITBACK:
525		case BRCMF_FWS_TYPE_PENDING_TRAFFIC_BMP:
526		case BRCMF_FWS_TYPE_MAC_REQUEST_PACKET:
527		case BRCMF_FWS_TYPE_HOST_REORDER_RXPKTS:
528		case BRCMF_FWS_TYPE_COMP_TXSTATUS:
529			break;
530		case BRCMF_FWS_TYPE_MACDESC_ADD:
531		case BRCMF_FWS_TYPE_MACDESC_DEL:
532			brcmf_fws_macdesc_indicate(fws, type, data);
533			break;
534		case BRCMF_FWS_TYPE_RSSI:
535			brcmf_fws_rssi_indicate(fws, *data);
536			break;
537		case BRCMF_FWS_TYPE_TRANS_ID:
538			brcmf_fws_dbg_seqnum_check(fws, data);
539			break;
540		default:
541			fws->stats.tlv_invalid_type++;
542			break;
543		}
544
545		signal_data += len + 2;
546		data_len -= len + 2;
547	}
548
549	if (data_len != 0)
550		fws->stats.tlv_parse_failed++;
551
552	/* signalling processing result does
553	 * not affect the actual ethernet packet.
554	 */
555	skb_pull(skb, signal_len);
556
557	/* this may be a signal-only packet
558	 */
559	if (skb->len == 0)
560		fws->stats.header_only_pkt++;
561
562	brcmf_fws_unlock(drvr, flags);
563	return 0;
564}
565
566void brcmf_fws_reset_interface(struct brcmf_if *ifp)
567{
568	struct brcmf_fws_mac_descriptor *entry = ifp->fws_desc;
569
570	brcmf_dbg(TRACE, "enter: idx=%d\n", ifp->bssidx);
571	if (!entry)
572		return;
573
574	brcmf_fws_init_mac_descriptor(entry, ifp->mac_addr, ifp->ifidx);
575}
576
577void brcmf_fws_add_interface(struct brcmf_if *ifp)
578{
579	struct brcmf_fws_mac_descriptor *entry;
580
581	brcmf_dbg(TRACE, "enter: idx=%d, mac=%pM\n",
582		  ifp->bssidx, ifp->mac_addr);
583	if (!ifp->drvr->fw_signals)
584		return;
585
586	entry = kzalloc(sizeof(*entry), GFP_ATOMIC);
587	if (entry) {
588		ifp->fws_desc = entry;
589		brcmf_fws_init_mac_descriptor(entry, ifp->mac_addr, ifp->ifidx);
590		brcmu_pktq_init(&entry->psq, BRCMF_FWS_PSQ_PREC_COUNT,
591				BRCMF_FWS_PSQ_LEN);
592	} else {
593		brcmf_err("no firmware signalling\n");
594	}
595}
596
597void brcmf_fws_del_interface(struct brcmf_if *ifp)
598{
599	struct brcmf_fws_mac_descriptor *entry = ifp->fws_desc;
600
601	brcmf_dbg(TRACE, "enter: idx=%d\n", ifp->bssidx);
602	if (!entry)
603		return;
604
605	ifp->fws_desc = NULL;
606	brcmf_fws_clear_mac_descriptor(entry);
607	kfree(entry);
608}
609