History log of /frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
9ce18f72203d523e7378ddb3f0432871973df561 08-May-2018 Ray Essick <essick@google.com> Fix memory leak in media metrics primitives

code was clearing a pointer without having checked & reclaimed the
referenced memory.

Bug: 79352137
Test: adb shell dumpsys meminfo --unreachable system
Change-Id: I2b8faa806ac99d8e6390880d67b5bc090ef7c19b
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
92d23b433bd770c22c2d4a30b573602f5565de1b 29-Jan-2018 Ray Essick <essick@google.com> Remove finalized concept from media.metrics

the 'finalized' concept didn't pan out -- remove references to it.
Simplifies the code flow.
Also purged some uses of generateSessionID().

Bug: 71874686
Test: logcat/dumpsys
Change-Id: I39e48526a5696158d8195f47154881ca6ecda266
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
5b77bd22d66773891c7ade1606dde049f160d446 24-Jan-2018 Ray Essick <essick@google.com> Change media.metrics dump format for ALOG()

change a constant from -1 to PROTO_LAST so that we'll include any recent
fields when we debug.

Bug: 72406222
Test: manual, logcat examination
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
783bd0d74d142493b4ef0a15a2664535854e99f9 11-Jan-2018 Ray Essick <essick@google.com> media.metrics changes AString -> std::string

change from AString to std::string for how media.metrics handles
strings. This severs the dependency on libstagefright_foundation,
where AString is implemented, so we can integrate into places
which do not want to introduce a dependency on libstagefright_foundation.

Bug: 70805723
Test: compilation/linking, CTS subset
Change-Id: I66de971b6ec354444e06112607a2d7614084cef8
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
4e2eeffb7d8cbe8add700ad699afc2614668706b 27-Nov-2017 Dianne Hackborn <hackbod@google.com> Update to support long version codes.

Bug: 64459786
Test: manual
Change-Id: I8b251f5238d6aeed51642bc7c4fc573b2a5a408e
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
9bb7e3b88d9a2a1f86b83b00af5aae3e8d8ec644 23-Oct-2017 Ray Essick <essick@google.com> Prevent Race condition in media.metrics

Change scope of locking to avoid a window of vulnerability on queue
manipulation and item merging. Also cleans up a string manipulation
error exposed by the poc for the queue bug.

Bug: 68015343
Test: repeated running of PoC without crash
Change-Id: Iafa82936e6ec2e25793187e0fa17c2a23085f58f
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
7932c6d14b09c1eeaef4d76859ef18ef93b62bf4 04-Oct-2017 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Monitor binder status to media.metrics service" into oc-mr1-dev
58f5873633ee9ed6b3ed54a18c196e0df20ea961 02-Oct-2017 Ray Essick <essick@google.com> Correct cleanup when compacting metrics attributes

Correct management of compacted media metrics attributes; ensure
proper release of a stale reference after copying it down into
a spot vacated as part of a deletion.

Bug: 67110197
Test: logcat to see it trip through the fix
Change-Id: I19031ebf257e958141524458da6b808fa741cce7
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
2ab3c43f0a73a534f79903e86284f5cabe3f5831 02-Oct-2017 Ray Essick <essick@google.com> Monitor binder status to media.metrics service

Add code to use binder's linkToDeath() so that our clients learn when
(infrequently, we hope) the media.metrics service dies for some
reason. When this happens, arrange for the client to re-establish
its connection to the service.

Bug: 66948389
Test: kill media.metrics, watch logcat for reestablishment messages
Change-Id: Ic518b955ce6816698b21e6a9c844587cef2e2712
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
fa149560f4f4b529de3df9e87923ff7f9a8e89ad 19-Sep-2017 Ray Essick <essick@google.com> trim packagename if sideloaded, get versioncode

implement policy of not uploading package info when sideloaded
or through a non-playstore channel. Include versioncode information
when we do include a particular package.

Bug: 65027506
Test: watch logs and dumpsys for various package combinations
Change-Id: I8e601c899070b57c25181ba705e997f10ea052b4
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
f65f421540d8d1e2aad17b86368405b83cb40a26 31-Aug-2017 Ray Essick <essick@google.com> track pkgname/version in media.metrics

Enhances the media.metrics subsystem to track the pkg name & version
so analysis can move from "error rate has climbed" to "error rate has
climbed within app X".

Changes include fields to hold package name/version, the dump protocol
to emit those fields to upload, and better management of metrics data on
device (time and quantity).

Bug: 65027506
Test: review output of dumpsys media.metrics
Change-Id: Ia55b859d903835c84f7d43883f959dc1cdefb081
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
79a89ef4eb06a2d29fc3d083112de398111a9ddb 25-Apr-2017 Ray Essick <essick@google.com> Suppress 'radio' processes to media.metrics

We suppress calls from radio processes (including the basic phone
process) to the media.metrics service. This had started happening
for a particular video telephony application that ran within phone
instead of as some separate app with its own user id.

We do this here to speed up when a radio process learns that it
can not log to media.metrics. The existing sepolicy restrictions
remain in place as a fallback. The use case that prompted this
was having issues with the 5-second timeout before we learned that
radio wasn't allowed access to the media.metrics process.

Bug: 37552329
Test: observe 'dumpsys media.metrics' and logcat
Change-Id: I1824aa35860bb91dd796856453c1897ec21b496c
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp
0f0c9b5007ff694d05a91c28359db0553e4dd061 05-Apr-2017 Ray Essick <essick@google.com> Move MediaMetrics into its own library

Changes for the new HAL structure have brought about a build time
circular dependency between libmedia and libmediadrm. This set of
changes the media metrics code into its own library and arranges
for the relevant consumers of the media metrics code to link
to this new library (where they had previously picked it up by
including libmedia).

Bug: 36990807
Test: build, boot.
Change-Id: I81768eecca88d5e59e6e6e547f29308a94e30c7b
/frameworks/av/media/libmediametrics/MediaAnalyticsItem.cpp