History log of /frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
99098e35ebea11b11b919855b5894bfb3267d922 06-Jun-2017 Ram Mohan <ram.mohan@ittiam.com> configure port format

For SetParameter, the field is nIndex ignored. If the format is supported,
it is set as the format of the port.

Change-Id: I5c1a9a87b56102c368ac0cd67475add02c3e9a1f
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
457bde5e356661cdd7cf9c5c09e56cb402ed8550 14-Mar-2017 Ray Essick <essick@google.com> Merge "Add bounds check in SoftAACEncoder2::onQueueFilled()" into klp-dev am: 19b91af752 am: 8e3cf4d841 am: 5b1bfc1f43 am: 8abf11b512 am: 4bc4f78933 am: 7f2592fe4a am: dbdf026f76 am: c4305aeda4 am: 1baad9ad99
am: 2ad7f9b172

Change-Id: Iff4a0475dde613d649196c826dbc482e9af93872
d4d9c97a9d7937f3e360576ff0183e98cb6b54f4 14-Mar-2017 Ray Essick <essick@google.com> Merge "Fix TOCTOU problem in libstagefright_soft_aacenc" into klp-dev am: 2076915c5f am: dcda2ec2fe am: f5c7784dbd am: c3de266a99 am: 8655d4fc01 am: b05be00f56 am: eb58ce5bb0 am: a830539187 am: e973c65525
am: ae7fae1810

Change-Id: I08b043910e7bf2173cd1b19c3bb76f5753b38ff0
8abf11b512f7da119a04edbb152955bc5166e310 13-Mar-2017 Ray Essick <essick@google.com> Merge "Add bounds check in SoftAACEncoder2::onQueueFilled()" into klp-dev am: 19b91af752 am: 8e3cf4d841
am: 5b1bfc1f43

Change-Id: I32327162d3e69259656f0b3a82800f45572527fd
c3de266a990055c3764c9137a43da99a09d75ccc 13-Mar-2017 Ray Essick <essick@google.com> Merge "Fix TOCTOU problem in libstagefright_soft_aacenc" into klp-dev am: 2076915c5f am: dcda2ec2fe
am: f5c7784dbd

Change-Id: Ic1901b3fa14a1e1c7f582e5b7862e777489e7314
6231243626b8b9c57593b1f0ee417f2c4af4c0aa 13-Mar-2017 Ray Essick <essick@google.com> Add bounds check in SoftAACEncoder2::onQueueFilled()

Original code blindly copied some header information into the
user-supplied buffer without checking for sufficient space.
The code does check when it gets to filling the data -- it's
just the header copies that weren't checked.

Bug: 34617444
Test: ran POC before/after
Change-Id: I6e80ec90616f6cd02bb8316cd2d6e309b7e4729d
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
0495c029bd51bcfc1cca8c943ab4ce2f201dbe98 11-Mar-2017 Ray Essick <essick@google.com> Fix TOCTOU problem in libstagefright_soft_aacenc

Fixes a configuration error where we sized a buffer initially based
on the configuration at the time and held onto the buffer through the
rest of our lifetime. If the configuration was changed in a way that
resulted in needing a different size buffer, the code did not make
this happen.

Patch keeps the buffer around but also stores the 'current allocation
size'. This allows the later code that preps the buffer to query if
the buffer size is same or changed. If changed, we discard the old
buffer and allocate a new one of the appropriate size.

safetynet logging added so we can tell how often this happens in the
field.

Testing was done on nyc-mr2 (where poc was built). Patch applies
without change to k/l/m/n/master.

Bug: 34621073
Test: run POC, saw new diagnostics saying it caught the size change.
Change-Id: Ia95aadc8c727434b7ba9628deeae327c405336d3
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
2430ff6610479b4374958d2a5c4db0b129fc7803 16-Feb-2017 Wonsik Kim <wonsik@google.com> codecs: handle onReset() for a few encoders am: 5443b57cc5 am: 89f501d046 am: 4f428b7c02 am: a5e72ec799 am: 787a5136f0 am: 83485b615e
am: 58f7175ed4

Change-Id: Ib5d28de651178b0ab7cd3e44793a6078d904ff4c
5443b57cc54f2e46b35246637be26a69e9f493e1 10-Feb-2017 Wonsik Kim <wonsik@google.com> codecs: handle onReset() for a few encoders

Test: Run PoC binaries
Bug: 34749392
Bug: 34705519
Change-Id: I3356eb615b0e79272d71d72578d363671038c6dd
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
dd447c354eb6b2a99d67fd787cafe91e07e1fce6 10-Feb-2017 Wonsik Kim <wonsik@google.com> DO NOT MERGE codecs: handle onReset() for a few encoders

Test: Run PoC binaries
Bug: 34749392
Bug: 34705519
Change-Id: I3356eb615b0e79272d71d72578d363671038c6dd
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
423766ca07beb7e3e9cd301385708ca13fcce3e1 29-Feb-2016 Marco Nelissen <marcone@google.com> DO NOT MERGE Verify OMX buffer sizes prior to access

Bug: 27207275
Change-Id: I4412825d1ee233d993af0a67708bea54304ff62d
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
51f59b41eae9c4f493ebfd0972cee951895bdf19 29-Feb-2016 Marco Nelissen <marcone@google.com> DO NOT MERGE Verify OMX buffer sizes prior to access

Bug: 27207275
Change-Id: I4412825d1ee233d993af0a67708bea54304ff62d
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
2720c8b094cfa58de314daa8e5e4fb4fa81fe3b2 29-Feb-2016 Marco Nelissen <marcone@google.com> Verify OMX buffer sizes prior to access

Bug: 27207275
Change-Id: I4412825d1ee233d993af0a67708bea54304ff62d
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
ed2a94af7d53374d40c346cd4771ca168924e1e2 26-Jan-2016 Wonsik Kim <wonsik@google.com> stagefright: add profile capability check for audio codecs

Bug: 26742857
Change-Id: I237691a7520054930e3935559e33a464b947f111
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
b97cc6a9a3c81215e365c61b071a932073b56ff2 02-Aug-2014 Jean-Michel Trivi <jmtrivi@google.com> AAC encoder: add support for SBR mode selection

Change-Id: Ibc07bff7710398929c135f38324dd29857fa0ea6
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
619fd4d6d4d815065becbdf360422ee40dfa7690 03-Apr-2014 Glenn Kasten <gkasten@google.com> Merge commit '52a23bd3' into manualmerge

Change-Id: I7a6105f467a2fa3631c62be3d306845e9cf9b365
66fe2e9ee30bcb4161bc487ec63d2ae4a05f4051 02-Apr-2014 Glenn Kasten <gkasten@google.com> 64-bit: Correction to OMX_U32 and OMX_S32

Change-Id: I9c41bb34c35595ac19a7ab8faaacde8cb4fa9a15
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
84333e0475bc911adc16417f4ca327c975cf6c36 08-Feb-2014 Andreas Huber <andih@google.com> warnings be gone.

Change-Id: Ie3bae3f037730e316d7fca12e7a3527973f752ef
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
1b02586f0f41d82c80619cfc0d16cd3feb5eaec7 30-Aug-2013 Jean-Michel Trivi <jmtrivi@google.com> AAC encoder: handle missing object types

The audio object type for parametric stereo and lowdelay was not passed
to the FDK AAC encoder.

Bug 9428126

Change-Id: Ic32822afff8b1da6a2d80c1b65d514f24059fb29
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
a5761dcb5f9f017ca9b83ec868565d7ce54a92ac 04-Apr-2013 Andreas Huber <andih@google.com> Fix a number of warnings in stagefright code.

Change-Id: If3edd00d991851797aeccdfe795a4a405e3a2ea3
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
f60c660f048d5f5e2458cff243c20400d73757a7 29-Apr-2012 Dave Burke <daveburke@google.com> Added support for HE-AAC recording

Fixed bug in decoder related to sample rates / channel counts
Made decoder follow Fraunhofer pattern
Log if bitrate not available
Bug: 6275957

Change-Id: I47a8e29358fa4a88ebc73fe02d46a2bfb96c64fe
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp
aeb8fd460ed87d032b3fb8bb61e21eb542ce0f5b 19-Apr-2012 Dave Burke <daveburke@google.com> Add Fraunhofer AAC encoder with AAC-ELD support.

Change-Id: I6cd499d257d72f50a5b508bed97796a591a51506
/frameworks/av/media/libstagefright/codecs/aacenc/SoftAACEncoder2.cpp