| 2992cd084cd5cfd9ef253c37ef269d6c75e7e144 |
|
23-Aug-2017 |
Jack He <siyuanh@google.com> |
Fix checkstyle errors (2/2)
* Manual style corrections with IDE assistance
* Variable name refactors are done through IDE
* Corrected general style errors such as:
- "final private var" -> "private final var"
- "&&", "+", "||" should not be at the end of line
- Non-static private variable should be like "mVar"
- Private static variable should be like "sVar"
- Code file should always end with newline
- Inherited methods should be annotated with @Override
and no @hide tags
- Public methods should always have a JavaDoc entry
- "int[] array" is preferred over "int array[]"
- private methods should be accessed without "this."
when there is no name collisions.
- "boolean ? true : false" -> boolean
- "boolean ? false : true" -> !boolean
- "boolean == true" OR "boolean != false" -> boolean
- "boolean != true" OR "boolean == false" -> !boolean
Bug: 63596319
Test: make checkbuild, no functional changes
Change-Id: Iabdc2be912a32dd63a53213d175cf1bfef268ccd
/frameworks/base/core/java/android/bluetooth/le/PeriodicAdvertisingParameters.java
|
| a355e5efaf45a534ee6437aa4bae7d30f18c0ec2 |
|
23-Aug-2017 |
Jack He <siyuanh@google.com> |
Fix checkstyle errors (1/2)
* Automatic style corrections through IDE
Bug: 63596319
Test: make checkbuild, no manual changes, no functional changes
Change-Id: I2397d55abc34c9b7a9b748bec6137778df3421a7
/frameworks/base/core/java/android/bluetooth/le/PeriodicAdvertisingParameters.java
|
| 037d3513e0a06c8dc59748b75d49c06e1db5e510 |
|
06-May-2017 |
Sunny Kapdi <sunnyk@codeaurora.org> |
Bluetooth: Fix Periodic Adv interval check
The MIN and MAX values need to be swapped else
the parameter check in setInterval would always
fail
Bug: 37579882
Change-Id: I48538c2a61be88caaf04abd94074b3d9eb6dde96
/frameworks/base/core/java/android/bluetooth/le/PeriodicAdvertisingParameters.java
|
| e6c453d828fec3df82708d2b0c3bb00bd0a0dbf8 |
|
10-Apr-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Remove enable from PeriodicAdvertisingPariameters (1/2)
Instead of setting enable to true, one can just pass null
PeriodicAdvertisingParameters and achieve same result when starting the
set.
Passing the "enable" when updating the parameters make no sense, and
might be confusing.
Experience with "timeout" field, which was a part of AdvertiseSettings
show that merging fields that go into different HCI commands can cause
problems during processing, so keep enable as separate field.
Test: manual
Bug: 30622771
Change-Id: Ida02c59eb8433537179b4d22202fe745f8b4bb3e
/frameworks/base/core/java/android/bluetooth/le/PeriodicAdvertisingParameters.java
|
| 08ed924d8922eec0555f6a860d80e6e2770c8a2d |
|
23-Mar-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth API spelling fixes ("wether" -> "whether")
Bug: 30622771
Test: manual
Change-Id: I01c8b18d0057f2fd6e477ce2ca0b779321b6c0e6
/frameworks/base/core/java/android/bluetooth/le/PeriodicAdvertisingParameters.java
|
| a9d1a32e5e51ebc3c141370c9d5045c6c938aaf9 |
|
10-Jan-2017 |
Jakub Pawlowski <jpawlowski@google.com> |
Bluetooth 5 Advertising API
Test: manual
Bug: 30622771
Change-Id: Id6856e6110872ec50ff1af54ddc75c0104a6459c
(cherry picked from commit 5324a14cf490656269ef862d7f8f6b139a21c0e6)
/frameworks/base/core/java/android/bluetooth/le/PeriodicAdvertisingParameters.java
|