8e7f8ad3cea52f7cb83af986cead0c4691ccb445 |
|
27-Apr-2018 |
Abodunrinwa Toki <toki@google.com> |
Merge "FloatingActionMode.setOutsideTouchable" into pi-dev
|
49ec54250f0cafd962c3c5f7f286875cf499483a |
|
25-Apr-2018 |
Abodunrinwa Toki <toki@google.com> |
Fix floating toolbar menu item spacing. We mistakenly changed floating_toolbar_menu_button_side_padding in I309c729eb842d9388066bfb43eb18f33dbfe10b8 where in fact what we wanted to do was to just change the mIconTextSpacing. This cl fixes that. Change-Id: I1b940eb12d2948f8c167c3f37ed0eba105b9f5ce Fixes: 74032743 Test: built, observed visual look Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
29cb76849c94bdbd95439e372360a51720c6b067 |
|
11-Apr-2018 |
Abodunrinwa Toki <toki@google.com> |
FloatingActionMode.setOutsideTouchable Make floating toolbar outside-touchable for link action mode in non-selectable TextView. This allows the user to be able to dismiss the toolbar by tapping outside of the toolbar. Bug: 78099871 Bug: 73156794 Bug: 78298142 Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest Test: bit CtsViewTestCases:android.view.cts.ActionModeTest Change-Id: I8e3b460d0b1baee48d4f9cb3f92e73926eeee231
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
66d41f87ead4f4d27bcb1a610c4130130e4b4bdc |
|
17-Apr-2018 |
Mihai Popa <popam@google.com> |
No divider between floating toolbar item groups The CL removes the vertical divider that used to exist between adjacent menu item groups in the floating toolbar, as well as the extra padding between these, in order to adapt to the new UX requirements. The CL also centers the text view inside a button, when there is no icon shown at the left of the text view. This is only relevant when the minimum size of the button is larger than the text measured width, and we want the text to be centered inside the button in this case. Bug: 74032743 Test: manual testing Change-Id: I309c729eb842d9388066bfb43eb18f33dbfe10b8
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
17f91d5413d53674aefb8995bdbbb41cdc0c8811 |
|
10-Apr-2018 |
Mihai Popa <popam@google.com> |
Fix ripple effect for floating toolbar menu items A corner radius was set for the floating toolbar in Ifcf4cff1f38fd18b7dbb4c1802390e3beb92cd3c. This produced a bug, where the ripple effect set on the floating toolbar menu items was expanding outside the corners when these were pressed. This CL sets the menu items container to clip to outline, such that the ripple effect of the menu items will be clipped. Bug: 77547543 Test: manual testing Change-Id: Ib43a6c719aab1403273f47e559433c9856b4f8b4
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
fb4b6b8fd26a9dc9081d7a864e6d6ba609988975 |
|
01-Mar-2018 |
Mihai Popa <popam@google.com> |
[Magnifier-28] Set corner radius This CL updates both the magnifier and the floating toolbar to use the dialogCornerRadius attribute for the corner radius of their windows. In both we use its value defined in the default device theme, rather than the value defined in the application's custom theme. Bug: 70848492 Test: atest CtsWidgetTestCases:android.widget.cts.MagnifierTest Change-Id: Ifcf4cff1f38fd18b7dbb4c1802390e3beb92cd3c (cherry picked from commit 3dcbc2112d9a47779f2d6b1a54df729ae43aed7e) Merged-In: Ifcf4cff1f38fd18b7dbb4c1802390e3beb92cd3c
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
9c881f227b2a136193a0a9236100075363a76f68 |
|
16-Oct-2017 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar updates - Replace SHOW_AS_OVERFLOW_ALWAYS with SHOW_AS_ACTION_NEVER - MenuItem ordering - Allow textAssist items in overflow to show text with images - MenuItem label text now standard case (not allcaps) Bug: 62447250 Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest Change-Id: I07fa06f433a34adfad20b371417c95ce76422456
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
c9c83a9ccbf8040c4130cb896e40019250d9d636 |
|
29-Aug-2017 |
Tarandeep Singh <tarandeep@google.com> |
Add multi-display support to FloatingToolbar. DecorView has no support for multi-display (bug 65172902). Until that is done, the easy fix for displaying cut, copy, paste on non-default display is to modify FloatingToolbar. FloatingToolbar uses context of Default display. Changed it to use context of the window (which makes it multi-display compatible). Fixes: 64837794 Test: Manual using AAe's KitchenSink test app bit FrameworksCoreTests:android.widget.TextViewActivityTest bit CtsWidgetTestCases:android.widget.cts.TextViewTest Change-Id: I513f1aac1c0d22355c996247e3bf56c6d812348f
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
484c2e2fbec02209337bb86fc99b8b253bc06f99 |
|
08-Jun-2017 |
Siyamed Sinir <siyamed@google.com> |
Force Autofill in FloatingToolbar overflow menu Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest bit CtsWidgetTestCases:android.widget.cts.EditTextTest Bug: 62271937 Change-Id: Ib3447281f3bd1abc811a25fc55ad55e34e155bbb
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
46850fcaea40c63ba66dca8d492bc30b531ce104 |
|
22-May-2017 |
Abodunrinwa Toki <toki@google.com> |
Fix FloatingToolbar refresh on menu changes. Also includes some minor code clean ups. Fixes: 38465735 Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest bit CtsWidgetTestCases:android.widget.cts.TextViewTest Change-Id: Ie87cc256b77b3ec5732f49c000ce4845130fc91c
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
6eecdc934c6050d67a639116cde600c09e5b76bd |
|
11-Apr-2017 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Rules for ordering menu items. - The assist menu item should always appear first - Only the assist menu item should have an icon + text label The description above enforces the expected UX without breaking existing apps. Previously, apps couldn't have icons + text for a menu item (we only rendered text for such items). If we don't enforce that the assist menu item (android.R.id.textAssist) appears first, then this item could potentially be rendered in a different position for apps that specify an order number lower than that specified for the assist menu item. Test: Included in this cl. Bug: 35989798 Change-Id: I56c71450c850e1d8cd80d54d4e17a6390823485f
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
047fe047666be1c322b483dc4efe9c45498ab682 |
|
15-Mar-2017 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Change divider color. Test: Visually inspected. Bug: 36038316 Change-Id: I4bf3b2abdfe15ff02b3969d1824752640e733128
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
2a00f9807c4f447aa9fd4005b40885d80a7b1635 |
|
24-Feb-2017 |
Vladislav Kaznacheev <kaznacheev@google.com> |
Do not set tooltips on items in list-based menus. The presence of a tooltip (specifically, long click detection logic required by it) interferes with touch processing in AbsListView. Bug: 35726766 Test: android.cts.widget.PopupTest#testItemViewAttributes Change-Id: Ida49c07e5f2e3e06f5994f2cc4aa10ef112376d0
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
852e9ac797f5bde6442a1ddeb1f5bf25381b0816 |
|
22-Feb-2017 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Menu items with icon + text. - introduced one layout file to rule them all - removed specialized layout files Test: Manual tests checking expected appearance Bug: 34777048 Change-Id: Id5b84d60b48e84b40554c983bf8c144efd42c504
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
5fedfb8d469ea5d1911be3ec44c2c19e7946a6e3 |
|
06-Feb-2017 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Support for menu groups. 1. Menu groups are now separated by dividers 2. Update to menu item spacing as specified in new UX mocks 3. TextView-Editor now passes the "assist" menu as a group 4. "Share" menu reordered after "Cut/Copy/Paste" as per UX mocks update. Test: Manual tests. Bug: 34777048 Bug: 34777833 Change-Id: I3d435d8a38e5b146a54706f12dbf3ff629c504bf
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
6a944ca17547e520ed4988125ee4c1f172c87946 |
|
19-Jan-2017 |
Vladislav Kaznacheev <kaznacheev@google.com> |
Rename View.setTooltip/getTooltip to setTooltipText/getTooltipText Bug: 34454987 Test: android.view.cts.TooltipTest Change-Id: I7203d5c61804b79584ba8449643c6c0f27a90747
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
7039cbc6f3a596aee6851014019849490f358f13 |
|
04-Jan-2017 |
Vladislav Kaznacheev <kaznacheev@google.com> |
Add content description and tooltip to menu item Bug: 34076597 Test: manual Change-Id: Ide32463252457721286c929ab2f8f7bae241835d
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
49482f83e8d6a892bc8b084108bf05d82263772f |
|
01-Jul-2016 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Check that app supports RTL. The FloatingToolbar rendering is buggy when running in RTL mode for apps that do not support RTL. The CL checks if the running app supports RTL before running RTL-related logic. Bug: 29932935 Change-Id: I36c0d72984e0abc7c6430cc7d52d8efd7341820e
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
1d4e18340eea41235385be8c8e7f96cc6c25a59f |
|
16-May-2016 |
Phil Weaver <pweaver@google.com> |
Content description for FloatingToobar overflow. Was missing a content description. The same button is used for both opening and closing the toolbar, so it needs to be updated dynamically. Bug: 28750935 Change-Id: I7f75701ae6af45e5621c36b81003b658479e8b31
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
0780f3a0733ea8ff4e8a93ca1263d92e24a6e9bb |
|
03-May-2016 |
Abodunrinwa Toki <toki@google.com> |
Fix FloatingToolbar popup positioning. The FloatingToolbar popup wrongly assumes that the main content panel is wider than the overflow panel. In situations where this assumption fails, the toolbar popup is positioned wrongly within it's container window and items appear truncated. This CL fixes this issue. Bug: 28550367 Change-Id: I41669b1deed7dd34f0b2bd060d14452482d3d36c
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
51a8af680b35e4d77786f277a3f06c13246a9d98 |
|
28-Apr-2016 |
Abodunrinwa Toki <toki@google.com> |
Ensure FloatingToolbar is not rendered at negative x, y coordinates. Bug: 28343540 Change-Id: I550a1a2389a6f90525498962709f0c82e8e310ab
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
8949faf0660d5c5e5479f164094f8761290824b7 |
|
06-Apr-2016 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Include scroll indicators in overflow. Bug: 27427333 Change-Id: I7480cfe5f75d04e04792d9443435a76ab6773c64
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
f0f4d73b5b0338a4c94f1ef1a5973b69bbbe5134 |
|
23-Mar-2016 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Make it more obvious that there are more items in the overflow. 1. Make the overflow show part of the items hidden behind the scroll view 2. Increase the time the scrollbar is on screen so users are less likely to miss it Bug: 27427333 Change-Id: Ia0bff5fa29cba3103263bc7d063176b0ba7ff7b9
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
0cf648917fcbea6c91406566639294caacfa6fa1 |
|
17-Mar-2016 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Hide panels when they're invisible. This patch sets the visibility of a panel to INVISIBLE when it's alpha is 0. This will ensure that a user cannot interact with a view that cannot be seen. Not doing this resulted in a bug where the user will tap on an area of the toolbar and activate an unintended action. It also removes the redundant mResetOverflowButtonDrawable. It's actions are already performed in setPanelsStatesAtRestingPosition. Bug: 27693433 Change-Id: Iafcde23622c7d1604924c520f6748fdbb8b135e7
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
5650c523d664de84363441470cbf2aef7ecb139f |
|
04-Feb-2016 |
Abodunrinwa Toki <toki@google.com> |
Merge "Make sure the scrollbar shows when the overflow is opened."
|
cc9d617dca3e3b332db2e2e7293c5501dd935cec |
|
03-Feb-2016 |
Abodunrinwa Toki <toki@google.com> |
Make sure the scrollbar shows when the overflow is opened. This helps users to tell that they can scroll the view. Bug: 26955900 Change-Id: I49e65a3837b2610560dc1d049889e3cca2c32a0a
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
30f8ef46e5c02b3680a9e355690d74a73718ced8 |
|
01-Feb-2016 |
Abodunrinwa Toki <toki@google.com> |
Revert "Revert "FloatingToolbar: Fix orientation change handling."" This reverts commit 6608a80fb317ca1bd4d9644bf6ac3a4cb108fd4c. ...and fix the syntax errors. Change-Id: If2ca31d426b2e3eeac8444f7cb24ab21f169d30d
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
b61437de5f31d61698eec47221ca5fba1f76c61f |
|
01-Feb-2016 |
Narayan Kamath <narayan@google.com> |
Merge "Revert "FloatingToolbar: Fix orientation change handling.""
|
6608a80fb317ca1bd4d9644bf6ac3a4cb108fd4c |
|
01-Feb-2016 |
Narayan Kamath <narayan@google.com> |
Revert "FloatingToolbar: Fix orientation change handling." This reverts commit a874e30959c9a19275ff3ce47ba6deda1955d094. Change-Id: I8e61e4d1f4af8dea71f69babbe6224c01bb6c6ac
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
cc3fb7a46372f60d67445f599e980a0491bc3964 |
|
01-Feb-2016 |
Abodunrinwa Toki <toki@google.com> |
Merge "FloatingToolbar: Fix orientation change handling."
|
a874e30959c9a19275ff3ce47ba6deda1955d094 |
|
29-Jan-2016 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Fix orientation change handling. Orientation change handling was done using a config change listener but it is not a sufficient trigger for when the toolbar needs to be resized. It is called before the layout has changed. A better trigger for resizing the toolbar will be on layout change. At this time, we get an accurate measurement of the drawing area. Bug: 21816857 Change-Id: Ia4d752f12b64b64256c1c41d5ede5d2e29a4f408
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
649a401101f88238201e8cf0b8cae3c2448addef |
|
29-Jan-2016 |
Abodunrinwa Toki <toki@google.com> |
Merge "Fix floating toolbar rendering."
|
6be228c1116aac14143b2f1420f08f990d0ccd45 |
|
27-Jan-2016 |
Abodunrinwa Toki <toki@google.com> |
Fix floating toolbar rendering. The code to size and position the floating toolbar and it's content when there was no overflow menu was omitted. This caused bad rendering of the toolbar and it's content when an existing toolbar object was updated to go in the "no overflow" state. Fixed the issue by properly updating the floating toolbar size and positioning of it's contents in the "no overflow" state. Bug: 25973599 Change-Id: I9305140f493bc36b87328571cd7645f184d9cf30
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
d1cd7fdedea0647056e34f43cb79a67819d20533 |
|
27-Jan-2016 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar: Fix logic error in determining open/close overflow animation duration scale. Change-Id: I31b32ee4234979471e5b6f917abd14af4fb2e3ee
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
7e29d1b4fc77e3866dec1bc75f45055c70539ed6 |
|
30-Oct-2015 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar polish. This patch updates the FloatingToolbar to look and transition exactly as described in the UX spec. It includes an animating (VectorDrawable) overflow button and menu item buttons that sit in place during transitions. Bug: 24257588 Change-Id: I2b3f84ba451800830878667ce1abd7a99b4f9fea
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
8a5e1ae2f4e1aaf2db2a217e841371e18851df3f |
|
28-Sep-2015 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbarEspressoUtils + more TextView selection by touch tests Bug: 24102650 Change-Id: Idd7d8b29ad8cfdf10d75137762bb1cb677bda6b7
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
b9acbe40d298612a2ab6bfb15842e63ff8f09af5 |
|
16-Sep-2015 |
Abodunrinwa Toki <toki@google.com> |
Reduce delay of floating toolbar appearance. Bug: 21956394 Change-Id: Ide7ee2daffbf618b0a483c377032bf25b20d5b8e
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
4b26997eeb6bbb526738bcbfaaa9b7147ba0f4a2 |
|
16-Jul-2015 |
Yohei Yukawa <yukawa@google.com> |
PopupWindow position must be specified in window coordinates. This CL addresses TODOs in Ib641dda49f7ab1c7d60207c36a47767bb408. With this CL the position of PopupWindow is always specified in window-local coordinates even if FloatingToolbar#mParent is not a decor view. Bug: 22335001 Change-Id: I0cdd63a00051fa30981e517c07682075467ac598
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
9b9d2c572fe26ddbdd0aed8b9d5899b0f9b5c08c |
|
16-Jul-2015 |
Yohei Yukawa <yukawa@google.com> |
Fix comment bug in I71a8d356e868dc7715b030ca1078da4ec39368c3. This is a coment-only follow up CL for I71a8d356e868dc7715b030ca, which wrongly changed coordinates from window-local to view-local (relative to FloatingToolbar#mParent) when showing PopupWindow. The position of PopupWindow still needs to be specified in window-local coordinates as we had done before I71a8d356e868dc7715b030ca1078da4ec39368c3. Currently the problem might not be visible to users because 1. FloatingToolbar is not a public API hence all the instances are under our controll. 2. FloatingToolbar#mParent is alwasy initialized with PhoneWindow#getDecorView() for now. Bug: 22335001 Change-Id: Ib641dda49f7ab1c7d60207c36a47767bb408971c
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
bafc908304d49e8f7f7c5e52772c75da66e4daa3 |
|
14-Jul-2015 |
Yohei Yukawa <yukawa@google.com> |
Allow FloatingToolbar to be outside of the attached window. Currently PopupWindow used for the floating toolbar specifies neither FLAG_LAYOUT_NO_LIMITS nor FLAG_LAYOUT_IN_SCREEN. As a result, the floating toolbar can overlap the selected text when the attached window does not have enough height. Here is the repro code. final TextView textView = new TextView(this); textView.setLayoutParams( new ViewGroup.LayoutParams( ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT)); textView.setText("A test sentence."); textView.setTextIsSelectable(true); final AlertDialog dialog = new AlertDialog.Builder(this) .setView(textView) .create(); dialog.getWindow().setGravity(Gravity.BOTTOM) dialog.show(); If you tap a word in the dialog, the floating toolbar unintentionally overlaps the selected text due to the limited height of the AlertDialog. It also turns out that just calling PopupWindow.setClippingEnabled(false) to specify FLAG_LAYOUT_NO_LIMITS is not sufficient and ends up showing the toolbar on the NavBar because we have mistakenly compared bounds in window-local coordinates (e.g. FloatingActionModemContentRectOnWindow) with bounds in screen coordinates (e.g. FloatingActionMode#mScreenRect). Hence the confusion of window-local coordinates and screen coordinates in FloatingToolbar and FloatingToolbar also needs to be addresses. To summarize here are the notable changes in this CL: - Specify FLAG_LAYOUT_NO_LIMITS so that the floating toolbar can be placed outside of the attached window. (We do this with PopupWindow#setClippingEnabled) - Switch to use screen coordinates from window-local coordiantes in FloatingToolbar and FloatingActionMode because some system components such as WindowManager prefer screen coordinates. - Put -OnScreen suffix for Rect and Point variables as long as they are in screen coordinates. Bug: 22335001 Change-Id: I71a8d356e868dc7715b030ca1078da4ec39368c3
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
8747f37383c41805800d208c8a4ebeeebeddf2dc |
|
30-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Fix Floating toolbar overflow width. Also clean out unused methods. Bug: 22186458 Change-Id: I5ef03cd7938630c0d607b6fecd540f2bd83bbb65
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
c107b0ecdcd4e2f89ae4bec818c3a94f45c3c15e |
|
26-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Fix FloatingToolbar flicker in reaction to text cursor blink. 1. Reposition the toolbar on predraw only when positioning has changed. 2. Update the toolbar popup's position only if the content rect changed. 3. Fix FloatingToolbarPopup.cancelOverflowAnimations(). The previous implementation wasn't actually cancelling the animation. (1) is enough to fix the bug. But (2) and (3) fix issues in the toolbar directly related to this bug. Bug: 22039189 Change-Id: I84ec793d788f9402a1f8635e68e3344746f6af07
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
079f33bca029c440ec6e788d6b3185f850f57973 |
|
24-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Enforce FloatingToolbar themes. This ensures that theme attribute values that affect the look and feel of the FloatingToolbar views are the ones specified in the framework. The aim is to avoid apps modifying the toolbar's look and feel in unexpected ways by overriding Theme attributes. Bug: 21957785 Change-Id: Idd472b4e8511f0a039cd07f98b1fd3ce93ae97fa
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
9ae95dff1d9dc78ad98b85fbdb79108dd8a09957 |
|
19-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Better FloatingToolbar positioning. -The toolbar is now rendered over the IME. -The toolbar respects the presence of the IME and tries as much as possible not to obstruct it. -The toolbar may obstruct the IME if there is limited space and we can't find a position that won't obstruct the IME. *A side effect of the toolbar over the IME is that TextView handles will also always be rendered over the IME where necessary. This was the previous behavior before the regression. Bug: 17510971 Change-Id: I26a49565bf025d7c007ba6bb80468c4988fcc051
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
6bc12244480fcdeca84080d5382d63eb2b992883 |
|
16-Jun-2015 |
Clara Bayarri <clarabayarri@google.com> |
Fix Select All Option is truncated when device goes from landscape to portrait We were not taking into account configuration changes to update the available space for the toolbar. Bug: 21816857 Change-Id: I0f346e8eecb66ab788d1500239d5c1e020b87f97
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
6d2b75c86d7007512a6ad935e5125b735106d90a |
|
12-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Floating toolbar no longer obstructs the soft keyboard. -The toolbar popupwindow is set to "need" the keyboard -Updated toolbar positioning bounds -Updated toolbar positioning depending on available space Bug: 21304845 Change-Id: I8d8a59ef6ea639b11bb32cfeb6ead52087fb91e4
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
7aa6d0a4b1ec7f75335348a86284d3773cc72f91 |
|
03-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Change FloatingToolbar entry/exit animations to fadeIn/fadeOut. Bug: 21307167 Change-Id: I7f75e064c264666ad0e8f84d5421fcc15176ee3f
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
2fe44efced5ac28bc3e03c9c101644b4ef0134bb |
|
04-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Merge "Also refresh FloatingToolbar for "icon" menu item changes." into mnc-dev
|
e3eb1833503c324127c621d22cbf7ac1729dbc54 |
|
27-May-2015 |
Abodunrinwa Toki <toki@google.com> |
Fix floating toolbar position issues. This CL makes the toolbar respect a viewport specified by the content area (calculated from the globalVisibleRect and windowInsets). By doing this the toolbar positions itself appropraitely avoiding the status and nav bars. Bug: 21324303 Change-Id: I3de9e114194dd43888b7f581ef12c3f8b813b3ca
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
6cb5cc19d467251d2e1e28791bf070f4ea6a2eed |
|
03-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Fix FloatingToolbar positioning for RTL. -The position of the toolbar was forced to the left side in an attempt to fix an RTL bug. This led to wrong positioning in LTR. This is now fixed by using a dynamic "show" animation that takes into consideration already set positions. -The correct position of the toolbar wasn't recalculated on updates for RTL. This is now fixed. Bug:21455067 Change-Id: I0b31a8fd3c95549f5f10133a47a4d3ef27689010
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
5047132887112df4235beea8ff42a28f1653e202 |
|
01-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Also refresh FloatingToolbar for "icon" menu item changes. Bug: 21512730 Change-Id: I77f62c46e2d2a11e6cb4329fa8b659bb1a97a6b9
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
6c5ac8e9e6b4b06c460cd2231cdeb93b373efe5d |
|
01-Jun-2015 |
Abodunrinwa Toki <toki@google.com> |
Fix FloatingToolbar look and animation for RTL. - Fix positioning issues which causes the toolbar to appear cut since it extends beyond its containing window. - Fix the open/close overflow animations to open to left (instead or right) for RTL. Bug: 21455067 Change-Id: I799b74c67c96b03bca4b2c9fbb6e1165b651ac7f
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
b21562c4655cb8dfb73819b68b7fc8eeeab40dac |
|
20-May-2015 |
Abodunrinwa Toki <toki@google.com> |
Support icons in the FloatingToolbar Bug: 20202541 Change-Id: Id4d27851739ba557c7f7348094d79f0c5f782e6b
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
4ce050bd83b8c311d7cf7b50e0a36a28df68bc4a |
|
19-May-2015 |
Abodunrinwa Toki <toki@google.com> |
Fix wrong delay values for floatingtoolbar.hide/dismiss Change-Id: Ie16b5f49babd0df0c70b188c9637e17c661e029c
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
1b422a95f7a3308359031b960c3b491a7eeec0dd |
|
18-May-2015 |
Abodunrinwa Toki <toki@google.com> |
Merge "Hide the floating toolbar faster." into mnc-dev
|
ffebf68202311963c497f5793e17d7a075706fd6 |
|
12-May-2015 |
Abodunrinwa Toki <toki@google.com> |
Support min/max height for FloatingToolbar overflow. FloatingToolbar overflow now supports a minimum height of 2 items and a maxiumum height of 4 items. As was the behavior before this CL, it prefers to open the overflow above the selection. Change-Id: Ia7f7bf28530d57c036fb74eea0467d6f5704eb4c
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
c0fa6bd7ac8fa8f138c62d734d276e55d600bb6b |
|
05-May-2015 |
Abodunrinwa Toki <toki@google.com> |
Set FloatingToolbar width for portrait and landscape. Bug: 20711006 Change-Id: Iee061a1031406780eb0f85201543b644fbb4d813
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
cdffaa4c5af71b4bd0c99a98d411ee3883ec4733 |
|
06-May-2015 |
Abodunrinwa Toki <toki@google.com> |
Hide the floating toolbar faster. There's a delay in the toolbar dismiss animation to allow for touch feedback ripples to be visible. This is not necessary when hiding the toolbar. This CL removes the delay for hide animation. Change-Id: Ic665f717200cad863327ef495e416c99aafb2dea
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
c23ac32601af1c7a5877d99c221e7e79e0ed1c90 |
|
25-Apr-2015 |
Abodunrinwa Toki <toki@google.com> |
DO NOT MERGE: Minor fixes to FloatingToolbar. * Changes to isShowing() method. * Changes to initial content visibility on show(). Change-Id: I1b20cd5a3fc86ae7427b55c44efd3cc1118148ae
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
0ce3e08a8444c73e63a0f733357581fb4409449a |
|
21-Apr-2015 |
Abodunrinwa Toki <toki@google.com> |
Fix FloatingToolbar.show() *Finer cancel animation methods so we call only the necessary ones. *Don't set the FloatingToolbarPopup content view's alpha to 0 before showing it's popup window. *FloatingToolbarPopup.dismiss() should run when toolbar is hidden. Bug: 20456876 Change-Id: I2e7ff5f2ec56af2def0976fa8e770c651daaa3a3
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
d5358ffbee845ecb2ab3e1ebdfec3823104c0dd1 |
|
22-Apr-2015 |
Abodunrinwa Toki <toki@google.com> |
Fix floating toolbar touchable region bug. The floating toolbar is rendered inside a transparent popup window so that we can have smooth animations inside of the window (NOTE that animating a view and a window at the same time do not work well as both are not in sync.) Having a transparent window implies that we can't get touch events through to the content below the window for areas covered by the transparent window. To handle this issue we "burn a hole" through the window by specifying it's "touchable area". This is done using the mInsetsComputer which is set on the popup window's root view's tree observer. When the popup is dismissed and re-shown, we need to reset the mInsetsComputer as we most likely won't have that root view any longer. Change-Id: I13ea50bc19950180d339d05d82cbee03230e2f05
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
b90443724a5aa563cb81d6e7512329a66e80fa2c |
|
19-Apr-2015 |
Abodunrinwa Toki <toki@google.com> |
Fix FloatingToolbar animation interruptions. This CL makes sure animations don't conflict with one another. Cancelling an animation should also set the animating object to the end state. Change-Id: Ib74515bb99090ce11a6ccd840aba0baee9fc1bf5
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
7270d07aab00c30c7f339963d3e9312456a2462e |
|
17-Apr-2015 |
Abodunrinwa Toki <toki@google.com> |
Implement FloatingToolbar.hide() Bug: 20148125 Change-Id: I62e43df565801ada8230fc4a8d5d3f9e1fc842df
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
103d48ec09cbaeedf28b66425cde9198f767e0d5 |
|
16-Apr-2015 |
Abodunrinwa Toki <toki@google.com> |
Change FloatingToolbar window layout type. Floating toolbar is now rendered as TYPE_APPLICATION_ABOVE_SUB_PANEL. This causes the FloatingToolbar to be rendered in a layer above the text selection handles (at layer TYPE_APPLICATION_SUB_PANEL.) Bug: 20135562 Change-Id: I1484b3493bf4cd98c679eb222270c53daa46cdf4
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
f8e14fd89b63c91ff441765827dda672c67fa1db |
|
14-Apr-2015 |
Abodunrinwa Toki <toki@google.com> |
Style floating toolbar. Change-Id: Ib2729992274fc55ce35ffd68d1bed7b02bea89db
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
517adad1c44b40fddba84c067c987d6db3fc5840 |
|
07-Apr-2015 |
Abodunrinwa Toki <toki@google.com> |
FloatingToolbar with overflow. -Implemented the toolbar overflow -Refactored a bit to make the concepts clear and component easier to understand and maintain -Floating toolbar now uses a clipped popup window that allows touch events to go through the transparent parts Change-Id: I84794e45a8a10f004654550fe976585f9e62bdb5
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|
0c7ed2886e6d17cacc9c0eeb2b7036923ef9a6e0 |
|
27-Mar-2015 |
Abodunrinwa Toki <toki@google.com> |
New floating toolbar implementation for secondary action mode views. Change-Id: I04d179576290f1b107b3777287d81f149e16e658
/frameworks/base/core/java/com/android/internal/widget/FloatingToolbar.java
|