History log of /frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
1856a4cfcca8c18365e8fd855905b57679d3a280 04-Apr-2018 Kweku Adams <kwekua@google.com> Adding privacy tags to graphicsstats proto.

Creating a copy of the graphicsstats proto so that one can be tagged
with privacy annotations and the other can be used internally while
still using the protobuf-cpp-lite library.

Bug: 72570104
Test: flash device and check incident output
Merged-In: I2d72e7bd17689c1401a16d5a13956e6528ddb525
Change-Id: I0a46ee6cc463b133925be1cf8dee8cf3d107930c
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
0e4864725aaca48a289ae1e0237377ed5b135f7a 19-Mar-2018 John Reck <jreck@google.com> Revert "Revert "Break down jank between frame drops vs. triple buffered""

This reverts commit a6d8fbf4ea634f5f605b2b7db3ca98975f8625b5.

Fixes an out-of-bounds read in COMPARISONS by switching up
how comparisons works. Instead of requiring all jank types
to have an associated COMPARISON's entry, which kHighInputLatency
and kMissedDeadline don't, instead have each
COMPARISON indicate which JankType it applies to so it can
be independently sized from JankTypes.

Bug: 70220906
Bug: 75566601
Test: launching & using maps works
Change-Id: I7fd90daeb320b4627e42c3418c89726d860998c1
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
a6d8fbf4ea634f5f605b2b7db3ca98975f8625b5 19-Mar-2018 Aaron Whyte <awhyte@google.com> Revert "Break down jank between frame drops vs. triple buffered"

This reverts commit 09979fbee7201b46158c2c033194529e4284ea13.

Reason for revert: Based on stacktraces and change history, I think this is causing a cluster of P crashes.
https://b.corp.google.com/issues?q=(%22android%22%20%22:uirenderer::JankTracker::finishFrame%22)
Bug: 75566601
Bug: 75811585
Bug: 75407175
Bug: 75736222
Bug: 75391447
Bug: 75659839

Change-Id: I59a8c2d8906d347210c77fb3628f5801bc299bfb
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
09979fbee7201b46158c2c033194529e4284ea13 13-Mar-2018 John Reck <jreck@google.com> Break down jank between frame drops vs. triple buffered

Bug: 70220906
Test: JankyScene vs. systrace vs. jankstats
Change-Id: Ia012685020cc5bcabbd3f92f0bdeb84eaf50733d
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
73453e49d5bfd703ed8b7e67e91e89a5015354a8 12-Dec-2017 Dianne Hackborn <hackbod@google.com> Update graphics stats to use long version codes.

Bug: 64459786
Test: manual
Change-Id: Iab84727e0ac486f505c10aacdb5ec8871aaf121e
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
1bcacfdcab0eaa0cee92bd7f5a1b5e271dd68e52 03-Nov-2017 John Reck <jreck@google.com> Format the world (or just HWUI)

Test: No code changes, just ran through clang-format
Change-Id: Id23aa4ec7eebc0446fe3a30260f33e7fd455bb8c
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
caebafaf94b887c98e75c8bb2fdc5cd5a1c2abcf 12-Oct-2017 Dan Albert <danalbert@google.com> Merge "Add missing includes." am: 4be4bb3db7 am: 41c08f49b4
am: e9aaf3c546

Change-Id: I41e4375d053ad5aa64bd4ca3a78b23644b2c725b
41c08f49b467e5e8aa291ec4a704a301bd27a6dc 11-Oct-2017 Dan Albert <danalbert@google.com> Merge "Add missing includes."
am: 4be4bb3db7

Change-Id: Icdae2b63df8e5d61e6acabb6fb85efa28026d535
110e007fb86a0093b339b14b534570cfe7cc5297 11-Oct-2017 Dan Albert <danalbert@google.com> Add missing includes.

Test: mma
Bug: None
Change-Id: Iec8b0a7854091946a4bb6e804c5f4cce39a52b47
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
5206a871dc227b58b7d97da65e0c9563277fc4d2 18-Sep-2017 John Reck <jreck@google.com> Remove all FATAL_IFs from graphicsstats service

As graphicsstats can be subjected to data coming
from the disk and is in system_server we want
to bias towards best-effort instead of strict
no-errors that the rest of HWUI typically uses.

So treat any dump/merge of graphics stats as
best effort, ignoring any errors that occur.

Bug: 65652900
Test: verified 'dumpsys graphicsstats' still works

Change-Id: Ia9b91b745c2a9aedad2f22e3087e1d4bf37a1135
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
7075c79209256101aee60584ee7e1d6f7f959c61 05-Jul-2017 John Reck <jreck@google.com> Split out jank data from policy

Move ProfileData out to its own file with helper
accessors. This keeps policy (what is/isn't jank)
outside of the data storage.

Also use lambdas to iterate over the histogram
to make it nicer for dumping & proto-ifying.

Test: hwui_unit_tests pass & jank data still dumps

Change-Id: I88488369ec77590a2867f51128e65bb786aa34e6
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
915883b9f0c88371f416894366536d120d9cf7ad 03-May-2017 John Reck <jreck@google.com> Switch to protobuf lite

Fixes: 36272398

Protobuf lite isn't just smaller, it also doesn't
have the problematic DescriptorPool at all. So no
need to switch this to a shared library.

Test: hwui_unit_test passes and doesn't crash. CTS incident tests pass
as well

Change-Id: I2693ba2c47af89a5c561c4f63cc7e1f509ebbbec
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp
df1742ed47da1e9b61afeae16fa448d5302a8aa0 20-Jan-2017 John Reck <jreck@google.com> Overhaul GraphicsStatsService

* LRU cache of recently-used is dead, replaced
disk storage
* ASHMEM size is read from native by the system service,
no longer requires keeping a sizeof() in sync with a
constant in Java
* Supports dumping in proto format by passing --proto
* Rotates logs on a daily basis
* Keeps a history of the most recent 3 days

Bug: 33705836
Test: Manual. Verified log rotating works by setting it up to
rotate every minute instead of day. Confirmed /data/system/graphicsstats
only has the most recent 3 entries after several minutes

Change-Id: Ib84bafb26c58701cc86f123236de4fff01aaa4aa
/frameworks/base/libs/hwui/service/GraphicsStatsService.cpp