History log of /frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
78047782344dc2f75ec4fca7b884946065d2aadf 04-Jun-2018 Evan Laird <evanlaird@google.com> Wi-Fi, now corporeal!

Given a state where the Wi-Fi icon could overflow (i.e. on the lock
screen with mobile data and other icons showing:

Killing the sysui process could cause the whole wifi icon to become
hidden, and it never was unhidden.

Test: With the overflow space in use, `adb shell kill $(pid com.android.systemui)`
Change-Id: I026923b3dae16b9afa1a5acc3bd88887816a6391
Fixes: 80577291
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
c1397271750a76f57edad0c85218f320d5c83a92 22-May-2018 Evan Laird <evanlaird@google.com> Override getDrawingRect for wifi and mobile views

Fixes the ordering that gets generated for accessibility traversal

Test: visual with TalkBack on
Change-Id: Ib50dad448aaf2b9ed0fa90d12f6394db7fac3252
Fixes: 79722445
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
97ae20c5d841a244369dba5decaa3ab994cdad33 10-May-2018 Evan Laird <evanlaird@google.com> Allow mobile status bar icon to overflow

With display size set to larest, a wide notch emulated, and battery
percentage showing, it's possible to not be able to fit a single status
icon other than the battery. In this case, the mobile icon needs to
overflow into the etc area.

Some other changes:
- set View.INVISIBLE instead of View.GONE when hiding the mobile view so
that it correctly reports its width on measure
- Don't subtract padding from width when laying out StatusIconContainer

Test: visual
Change-Id: Ic8e73402a3371331dd4c803f3c4559da276ba0a2
Fixes: 78149953
Fixes: 77504032
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
150701d41f6e766b07265798c4dd9b5fc78e02cc 04-May-2018 Evan Laird <evanlaird@google.com> Show up to 8 icons before eliding; fix animations

Show up to 8 (including battery) system icons, and after 8 show 7 icons
and only 1 etc dot

Test: visual
Change-Id: I4c1eeb2bd6afd9d5a1aed3358919f0d29ef2a084
Fixes: 79165032
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
56fb9f8aa52d14006c2638a216c113c35b801e66 25-Apr-2018 Evan Laird <evanlaird@google.com> Always copy SignalIconState when keeping a reference

Defensively copy SignalIconState so that StatusBarWifiView and
StatusBarMobileView can properly detect changes to state.

Also don't do visibility changes if setting the same visibleState on
StatusBarWifiView.

Test: turn wifi on and off; verify that it goes away properly in status
bar
Fixes: 78353558
Fixes: 77738471
Fixes: 78050495
Fixes: 78163313

Change-Id: Ie9b9e05885c130c1ec6d6abb9d0567400df23e52
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
20b87bf0ae8c880a76d0de859b3665b7d4f2e144 12-Apr-2018 Evan Laird <evanlaird@google.com> Limit status icons and show etc dots

When <= 5 status icons exist, try to show them all (space permitting).
If > 5 exist, show 4 and etc dots.

Test: visual
Change-Id: I4c09344bee75b3cab6256dd69f11337b9b667b0f
Fixes: 73778753
Fixes: 77660387
Bug: 77822905
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
6dedbe6a4de6a0fe2045f60d90da5e1a41d3156f 05-Apr-2018 Evan Laird <evanlaird@google.com> Don't hide the mobile type id if it doesn't change

_Someone_ thought it would be a good idea to hide the mobile type
indicator if it hadn't changed from the last state. Better to not do
that.

Also removed an unused method in StatusBarIconControllerImpl.

Test: Reboot device with wifi off; data type indicator should show up
eventually; i.e., visual
Fixes: 77581445

Change-Id: I47a0c868b0e332c11e206b8c043a532bcbf10130
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
dbeefe3315d718f022b3b499311064a3fb015425 03-Apr-2018 Evan Laird <evanlaird@google.com> Fix icon tinting when in split screen

NotificationIconAreaController, StatusBarWifiView, StatusBarMobileView
all now respect the tintArea when `onDarkChanged` gets called

Test: visual; Split screen, chrome on top and settings on bottom, no icons
should be dark.

Change-Id: I7aa8f3383da3855e8ceab702539fce71edaa6af2
Fixes: 77494939
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java
e1d13c9884e6f4579b1265400b61a36207748dc3 20-Mar-2018 Evan Laird <evanlaird@google.com> Remove SignalClusterView in favor of IconManager

Refactors SignalClusterView into StatusBarSignalPolicy so that it can be
used in a StatusBarIconContainer and solve all of our status bar
problems.

- Remove all uses of SignalClusterView and references to
R.id.signal_cluster. The class still exists it's just unused now

- Add StatusBarIconHolder, which can point to StatusBarIcon,
WifiIconState, or PhoneIconState

- StatusBarIconList.Slot. Allows for easier indexing of icons now that
there can be multiple icons per slot

- Add StatusBarWifiView to be inflated inside of the
StatusBarIconController when needed

- StatusBarMobile view. similar to above

- Upgrade StatusBarIconControllerImpl and StatusBarIconList to
understand the holders and added 2 new methods to specifically handle
wifi / phone state changes

- Create IStatusBarIconView (todo: rename). Abstracts the properties we
want away from StatusBarIconView so that we can use an arbitrary view
type

- NeutralGoodDrawable. Draws a light and a dark icon when needed.

- Fixes a few demo mode bugs: multi sim was broken and also turning off
demo mode was a little broken

TODO: More tests are needed for StatusBarSignalPolicy and maybe the
IconManagers

Test: runtest systemui; visual
Bug: 63772836
Bug: 73778753
Bug: 74985733
Fixes: 74427768
Fixes: 74338687
Fixes: 74388467

Change-Id: I5621b3013cdc9638b61552bd4d7211f211eddf1b
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java