bd9be6d8cab19c78a6bf14b62c4bbb6ef8d13769 |
|
23-Feb-2018 |
mukesh agrawal <quiche@google.com> |
LogcatLog: add tracing functionality to trace() Some people have the crazy idea that the trace() method should help trace program execution. I don't know why they would think that, but I'll relent and make it so. Along the way: refactor how we filter trace/debug messages, so that we don't pay the cost of a stack trace unnecessarily. Bug: 73972044 Bug: 30737821 Test: tests/wifitests/runtests.sh (on walleye) Change-Id: Ida435642af81945bfcb16db5cf39b20e5bebc5bb
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/FakeWifiLog.java
|
f5d90be206db98bbd5894afc8d757dd32360b2d9 |
|
05-Aug-2016 |
mukesh agrawal <quiche@google.com> |
logging: add convenience APIs for literal messages Literal messages are reasonably common, so we should make them easy to log. Add APIs for that purpose, and migrate WifiDiagnostics to use them. Note that, functionally speaking, the LogcatLog implementations of these APIs behave the same their corresponding legacy APIs. However, we add these APIs for two reasons: - To track which log messages have been audited, to determine whether or not they contain parameters. - So that the WifiLog implementation for the new backend can inform the backend that these messages are clean (free of any sensitive data). Finally, we note that these convenience APIs may also provide a performance benefit. (Because the message is parameter-less, there's no need to create a LogMessage.) While there: change the level of some WifiDiagnostics log messages, to fit our new logging guidelines. BUG=30737889 TEST=wifitests/runtests.sh Change-Id: I3d39c1932800af6a818c59b6497c868f8399f8fa
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/FakeWifiLog.java
|
f46c533931224296b11d98798344c049f88db9a1 |
|
06-Aug-2016 |
mukesh agrawal <quiche@google.com> |
WifiDiagnostics: migrate to chained logging API Migrate parameterized log messages in WifiDiagnostics to the new chained logging API. Along the way: add DummyLogMessage and FakeLog, to facilitate testing. (Alternatively, we could bake their behavior into WifiDiagnosticsTest. But it seems likely that other tests will want the same behavior.) While there: - fix ordering of imports (WifiDiagnostics, WifiDiagnosticsTest) - remove unused imports (WifiDiagnostics) - change the level of some WifiDiagnostics log message, to fit our new guidelines BUG=30736898 TEST=wifitests/runtests.sh Change-Id: If60282adf40d58e80cdaa0d7e1e7008c490d545b
/frameworks/opt/net/wifi/service/java/com/android/server/wifi/FakeWifiLog.java
|