dee52f68e1f6a3edc0cb77caa0902bc10cb50c33 |
|
24-May-2018 |
Filip Pavlis <pavlis@google.com> |
Improve Jetifier's prefix configuration. 1) The reversed prefixes are no longer hardcoded in the Processor.kt but are part of the config file. 2) Originally the prexifes were used as the first line of defense when filtering what should be rewritten. This stopped to be intuitive since we introduced quite a lot of types of rules. And it is not immideately obvious when someone adds a new rule which is not covered by any prefix it gets ignored. Because of that from now we will use the prefixes as a check if we should report error with missing mapping or not or in cases where checking the rules is expensive. So in case of package map we directly check if package is there and if yes there is no need to look at prefixes. If the package is not there but prefix is satisfied we treat it as an error. 3) Fix bug with not dejetifying material package properly. First of all the changes from 2) will make sure this won't happen again. But also add suffix of "/" to make sure the prefix regex is matched. Bug: 80208210 Test: Added, updated and manually checked that material AndroidManifest.xml gets dejetified properly. Change-Id: I0e899cf1f80e8393f1593c372f66609527d80610
/frameworks/support/jetifier/jetifier/core/src/main/kotlin/com/android/tools/build/jetifier/core/config/Config.kt
|
5b12e59efaab28afee6ffc712a7c8d6ecbae8144 |
|
23-May-2018 |
Filip Pavlis <pavlis@google.com> |
Improvements in Jetifier. Cleaned up standalone tool API - We no longer have option for providing multiple files or specifing output directory. So the tool now supports only file to file conversion. I found the origal approach to be a bit ambiguous and also we never actually used it it was just part of the initialdesign. - DependencyVersionsMap is now part of the config file instead of being in the code. This allows more flexibility when providing custom config file and enables last minute fixes. Bug: 64833662 Test: Updated Change-Id: I475e74a2f6c5e61c3b3dec5d1bcc9c41ff2fee9b
/frameworks/support/jetifier/jetifier/core/src/main/kotlin/com/android/tools/build/jetifier/core/config/Config.kt
|
4e29091e542d87269447fdc8b3254ce86af06845 |
|
02-May-2018 |
Filip Pavlis <pavlis@google.com> |
Relax conditions for jetifier xml rewrite. Jetifier had very restricted set of XML tags to rewrite. This was causing failures and the list had to be extened. Because this does not scale well I have relaxed the selectors and jetifier now tries to rewrite basically anything in quotes or in tags. Another tiny change is that Jetifier will move files no matter if it is rewriting support library or not. This is related to the new strategy that we will rewrite files that are not originally from SL but are in the same namespace and satisfy our rules. By this we won't break usages of internal APIs. Test: Added Change-Id: I20041897eaa98899294092bd88a9371d811026d6 Fix: 79111795 Bug: 64833662
/frameworks/support/jetifier/jetifier/core/src/main/kotlin/com/android/tools/build/jetifier/core/config/Config.kt
|
d101a9abcc701ca9a05b4870ab4703bd7ea6b0e9 |
|
19-Apr-2018 |
Filip Pavlis <pavlis@google.com> |
Design rules fixes. + Added fallback rule when dejetifying new media classes. + androidx.car to ignore for dejetification + Replaced set with list for rules - because order matters. + Set 2.0.0 versions for arch components. Bug: b/64833662 Test: N/A Change-Id: If87ae7037bd08e77c4e5991a94b98f811e884c82
/frameworks/support/jetifier/jetifier/core/src/main/kotlin/com/android/tools/build/jetifier/core/config/Config.kt
|
ba381a314edcd57963ed1ac5910595e04faf29cc |
|
28-Mar-2018 |
Filip Pavlis <pavlis@google.com> |
Refactor Jetifier packages to com.android.tools Bug: b/64833662 Test: it builds! Change-Id: I27bc0d2b0de17ba0d22e7588dc0742a041f17f31
/frameworks/support/jetifier/jetifier/core/src/main/kotlin/com/android/tools/build/jetifier/core/config/Config.kt
|