| 65208317ba9d16486b47ebcaa868c596d424c87f |
|
10-Nov-2009 |
Lixin Yue <L.X.YUE@motorola.com> |
Update OBEX to fix missing several contact entries issue.
The third parameter count of PrivateOutputStream.write()
should be the size of vcards data plus header length, excluding the 3 bytes
for the response message and 3 bytes for the header ID and length.
Adjust the return value of getMaxPacketSize() by minus headser size, so that
applications should not get packet slipped during multiple sharing operation.
Do not set the header to null in getHeaderLength() to get PBAP PTS passed;
Per OBEX spec, for Get request:
Only the last packet need send the 0x49(End of Body);
for intermediate packets, we need to send 0x48 (Body).
If all packets use 0x49, some carkit like Nokia PD-17 will fail to download
all contacts, except data in the last packet.
Bug: 2246927
Dr No: Eastham
/frameworks/base/obex/javax/obex/Operation.java
|
| 05ff98bbefda39b9ff26f8bca132cfd0248745c6 |
|
14-Jul-2009 |
Tao Liejun <L.J.Tao@motorola.com> |
Fix minor obex bugs and re-format the comments
re-format comments
move connectible to connectable
remove unnecessary throws
remove not-used function ClientOperation.readResponse()
fix client abort case for PUT
set mOpen for PrivateOutputStream
add to platform.xml
/frameworks/base/obex/javax/obex/Operation.java
|
| 3998bf009acaf8cde4d7f837f8b8e41ae0a65141 |
|
02-Jul-2009 |
Tao Liejun <a19884@motorola.com> |
Obex library cleanup, third pass
- Change variable namings
- Remove interface public modifier
- Move 2 duplicate methods to ObexSession
- Removed unused code and variables
- Use static variables for some protocol defines
/frameworks/base/obex/javax/obex/Operation.java
|
| 2e0da96e757a977154063f980d3f4e1abd41cf09 |
|
01-Jul-2009 |
Nick Pelly <npelly@google.com> |
Obex library cleanup, first pass.
o Add Android.mk file.
o Add @hide so it is not exposed in the public API. It is not yet in shape.
o Prefer @throws to @exception
o Do not use @version. This is meaningless in Android.
o Prefer classes 'final' unless explicitly allowing inheritance
(See "Effective Java" item 15)
o Prefer CamelCaps java naming even for acronyms (OBEXHelper -> ObexHelper)
o Use the built-in MD5 library.
o Move ObexConstants into ObexHelper.
o Remove unused variables.
o Prefer stricter access priveleges. Most importantly, avoid public fields.
o Don't use 'import java.io.*'. Name each class explicitly.
o Delete commented out code. If its not used then remove it.
/frameworks/base/obex/javax/obex/Operation.java
|
| 9439a7fe517b858bc5e5c654b459315e4722feb2 |
|
30-Jun-2009 |
Nick Pelly <npelly@google.com> |
Add javax.obex library, contributed by Motorola.
Based of a JSR-82 reference implementation.
This check-in is 'as-is' from the source provided June 25.
This code does not conform to Android style and quality guidelines. I will be
working with Motorola to improve it. If it does not see substantial improvement
in the Eclair timeframe it will be deleted.
/frameworks/base/obex/javax/obex/Operation.java
|