| 5642625cfb065de38440408c1e2e8a8c6f8fa32d |
|
01-Nov-2010 |
Leon Scroggins <scroggo@google.com> |
Update insertion handler for WebTextView.
Bug:3152629
Change-Id: If2a33eb5456493fb9b3b2c54fcc4f5348fe129e1
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 44d2c69ad30878521c6eff66a83893099b3d12ee |
|
19-Oct-2010 |
Brad Fitzpatrick <bradfitz@android.com> |
Avoid NPE in WebTextView.lineUpScroll -> Touch.getMaxScrollX
Bug: 3110967
Change-Id: I156070956528c8c7d1eb6db5d2e8bb1fe119178d
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 2a30744cd73233646173d05ebdb28f7829ec7a52 |
|
15-Oct-2010 |
Leon Scroggins <scroggo@google.com> |
Line up textfield with WebTextView more often.
Bug:3097705
Line up when the selection changes (such as when the
selection is altered by the context menu) or when the
WebTextView scrolls.
Change-Id: Ia491064548131be1ac6f4d701a43cd8419a25367
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 23cb86a47d566db413d9c7679984ef3cfdfee848 |
|
12-Oct-2010 |
Leon Scroggins <scroggo@google.com> |
Allow TextView to do its thing.
Bug:3085639
Call super.onTouchEvent for ACTION_UP and ACTION_CANCEL.
This removes the old selection as appropriate.
Bug:3085587
Make the cursor visible so that the insertion handle
appears when tapping on the field.
Change-Id: If5ea6219de9ca351667021743b2e63edc6c47250
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 69ec5c22d09690d33f0b87a386de13cc61eb9b42 |
|
22-Apr-2010 |
Leon Scroggins <scroggo@google.com> |
Remove the WebTextView if it is drawing when it shouldn't.
Bug 2614064
Change-Id: Id5d0a27e862bb783299f6fa4863221a27318f52c
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 3fcf4863595f18be0691e19e530b1c0c8e79995e |
|
13-Apr-2010 |
Leon Scroggins <scroggo@google.com> |
Ensure the selection does not change in setTextAndKeepSelection.
Bug: 2589778
Change-Id: I72752797003216fdd12cebffbdf4cd9ffbf523e1
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| f9b1a092b6c86549a8257015a03ea59ebcd9a85e |
|
31-Mar-2010 |
Leon Scroggins <scroggo@google.com> |
Only include WEB_EDIT if there are more textfields.
Fixes http://b/issue?id=2559070
Requires a change to external/webkit.
Change-Id: I411a04d260c781a91d16832704bb5c34e9751bc1
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 62459c0fa5f379ab7aaaea3159654dd355117b37 |
|
09-Mar-2010 |
Leon Scroggins <scroggo@google.com> |
If the new text and old text are "", return from onTextChanged.
Fixes http://b/issue?id=2496329
Change-Id: I239f143c0e539710342e46783157344a4d7ccc08
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 7af1b837ff7add63cb1494d231ea11d874575b73 |
|
03-Mar-2010 |
Leon Scroggins <scroggo@google.com> |
Remove the TAB key from <textarea>s.
Do not use flag for web edit, so that the IME does not have the
TAB key.
Fix for http://b/issue?id=2484101
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 1be40985283e77d3fc5d98268f9f6453bcc7223e |
|
01-Mar-2010 |
Leon Scroggins <scroggo@google.com> |
Make nativeMoveCursorToNextInput return a boolean and use it.
If nativeMoveCursorToNextTextInput does not succeed, do not set the
default selection or perform the other actions which assumed that the
move worked.
Part of fix for http://b/issue?id=2478052
Requires a change to external/webkit.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| e265532f30ca460dc0900c4cdfc3c7425ae7714b |
|
16-Feb-2010 |
Leon Scroggins <scroggo@google.com> |
Create a default style for WebTextView.
As a result, all apps using WebView (and therefore WebTextView)
will get the same style, and display properly.
Fixes http://b/issue?id=2385422
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| af314e246dd6ee75b0d8d6b5a64d8443c7a8220d |
|
09-Feb-2010 |
Leon Scroggins <scroggo@google.com> |
Set the IME action to GO for normal textfields.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| d5ff5dbfebe9a6b906323b4cc98257a83bbf38b2 |
|
08-Feb-2010 |
Leon Scroggins <scroggo@google.com> |
Handle the Tab key by moving to the next textfield. And ensure
there is always a way to get to the next field.
http://b/issue?id=2414236 and http://b/issue?id=2414229
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 2edd68260f26cbd6eddd0df16404bb6bcb22b3b6 |
|
12-Jan-2010 |
Leon Scroggins <scroggo@google.com> |
Create a new ImeOption that disables fullscreen in landscape, and use it.
EditorInfo:
Add a flag to tell the InputMethodService to never go into fullscreen
mode.
InputMethodService:
When the new flag is set, onEvaluateFullscreenMode always returns
false.
WebTextView:
Use the new flag, along with IME_FLAG_NO_EXTRACT_UI. Fixes
http://b/issue?id=2358360
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 3a5033996e9df21abbd5b296d817c2acaedcb0f9 |
|
06-Jan-2010 |
Leon Scroggins <scroggo@google.com> |
Request <label> info only when accessing a textfield.
Previously, we were storing the label info each time we build the
navigation cache.
Requires a change to external/webkit.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| e38fc1898183a6bf8b0542a1d2627cdbcbd63198 |
|
05-Jan-2010 |
Leon Scroggins <scroggo@google.com> |
Show label information as hint text
Fix for http://b/issue?id=2331526
Requires a change to external/webkit.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| e26efa321c66716d58f3e338022caed8852af07e |
|
15-Dec-2009 |
Leon Scroggins <scroggo@google.com> |
If the DOM changes textfield focus, make the IME work properly.
Fix for http://b/issue?id=2219166
Requires a change to external/webkit
Remove the old change to update the WebTextView when a key is pressed,
since the IME does not generate key events. Instead, when the focus
changes, and the IME is serving the WebTextView, immediately clear
the cursor and update the WebTextView, so the user can continue
typing.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 47fabbfcbf99e5e3b73a6ee09059c77932ef1b7b |
|
08-Dec-2009 |
Leon Scroggins <scroggo@google.com> |
Pass a message to move the focus when user hits "Next".
Directly move the focus rather than passing a click.
Fixes http://b/issue?id=2292683
Requires a change to external/webkit
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 6be3bf2393030549306b438b9b17085035729135 |
|
08-Dec-2009 |
Leon Scroggins <scroggo@google.com> |
Some fixes for positioning the WebTextView.
Move the change in position/size before the call to bring into view,
so that the properly positioned field will be brought into view. It
is also now before we check to see if it is the same textfield, so
it happens in both cases.
Also remove some code which checks the selection and then sets it
unnecessarily. It was originally surrounding some code which called
setRect, which had a side-effect of changing the selection. That
code was removed (rendering the remaining code useless), and setRect
no longer has the side effect (the side effect was a result of calling
reqestFocus, which it no longer does - further, the change in selection from
requestFocus no longer affects the textfield's text).
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| aa7b9d78262b1df07a98bcf725958d418ff12ede |
|
07-Dec-2009 |
Leon Scroggins <scroggo@google.com> |
Set InputType of WebTextView according to <input> field's type.
Help fix http://b/issue?id=2150538 and http://b/issue?id=1890360
Use the <input type> information to set the InputType, so that
the IME can show the correct options. Also consolidate setup
of WebTextView into setType().
Requires a change in external/webkit.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 9e3e2d3a6967301730fd383e8b04d53fdfd008e5 |
|
04-Dec-2009 |
Leon Scroggins <scroggo@google.com> |
Show search icon for <input type="search"> fields.
Along with a change to external/webkit, fixes http://b/issue?id=2299650
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| cfc2915d926cee14380b54d0960262e748eed4f5 |
|
02-Dec-2009 |
Leon Scroggins <scroggo@google.com> |
In setDefaultSelection ensure that webkit is notified of the new selection.
Fix for http://b/issue?id=2254732
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| ed90811e711065bcc82a45f4173587cd95ef6b6f |
|
01-Dec-2009 |
Leon Scroggins <scroggo@google.com> |
Do not peform a click/move if longpress has been performed in WebTextView.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| bb107bd6f7981cd2b2e31a0afc6f6bf2a6d5118f |
|
23-Oct-2009 |
Leon Scroggins <scroggo@google.com> |
Many fixes to text input in the browser, particularly when moving to a new field.
Remove many instances where we are setting selection unnecessarily. Instead, only
set the selection due to a click, touch, or inserting a character. A touch will
now set the selection properly, rather than at the beginning/end, fixing
http://b/issue?id=1650395 Also fixes http://b/issue?id=2208188
Requires a change to external/webkit.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 1d96ca06d83ef87544a7053ab6c19b3b8233ae4b |
|
23-Oct-2009 |
Leon Scroggins <scroggo@google.com> |
Show the soft keyboard when pressing center key/trackball on input field
Fixes http://b/issue?id=2210234
Consolidate center key/trackball presses on input fields, and show
soft keyboard if the field is not readonly. Also rename the method
for a center press, and pass a click rather than a touch. Requires
a change in external/webkit.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| d9ec29f64827bc703a23b1c33d653906a91713fc |
|
22-Oct-2009 |
Cary Clark <cary@android.com> |
fix text area insertion order, partially
While Leon mulls over how to rewrite WebTextView to
handle webkit driven focus changes, these fixes make
the current code slightly more stable.
Keep track of when keyDown is sent again so that the
WebTextView won't be rebuilt in that case.
Don't clear the cursor from WebTextView if the there's
no native focus pointer.
Only set the selection to its initial state once when
passing events down to webkit.
partially fixes http://b/issue?id=2201049
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| fcafa46069a451d09f69a5df8c167596e7554666 |
|
21-Oct-2009 |
Cary Clark <cary@android.com> |
fix multiple text areas, and text areas without focus rings
If the typed key doesn't go with the current text area, clear
the focus so the key won't return to that text area. However,
don't clear the focus if it is already off the old text area.
fixes http://b/issue?id=2201049
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 0c5924e9dd1befadae8c73505d3acc9813bf8224 |
|
30-Sep-2009 |
Cary Clark <cary@android.com> |
preserve webkit-side text selection
When webkit modifies a text field programmatically, it may change
the selection. This competes with the UI thread attempting to
set the selection in response to the IME next button and changes
made by the trackball.
One recent fix (https://android-git.corp.google.com/g/#change,26904)
sets the selection from the UI side after the IME generated click.
Unfortunately, this can be generated under other circumstances,
so this change qualifies this with mOkayForFocusNotToMatch, which
is only set after the IME next button is pressed.
The other change qualfies onTextChanged calls so that if it was
triggered by setTextAndKeepSelection, the webkit-side selection
is unchanged.
fixes http://b/issue?id=2096746
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| eaa18dec91b6dd0ce3191a9ab65cdc95ef68b935 |
|
28-Sep-2009 |
Cary Clark <cary@android.com> |
scroll text field with touch
Add a hidden public method to text/method/Touch.java that
computes the maximum scroll amount for a text field.
Remove 'faketouch' code; it causes a crash and is
no longer required.
Pass the percentage of the current scroll from the UI
thread to webkit. One additional fix is to allow very
small movements which are currently disallowed because
they are smaller than 'smallerSlop' in WebTextView.java.
Companion fix is in external/webkit.
Fixes http://b/issue?id=2133049
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 94c715d662e803b43dde8984a60f937a26706c7d |
|
29-Sep-2009 |
Grace Kloba <klobag@google.com> |
Skip requestRectangleOnScreen for WebTextView during
zoom animation. If it is in edit mode, we already adjust
WebTextView in the end of zoom animation.
Fix part 1 of http://b/issue?id=2147168
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 37703b6c875a935e6341d8a710796bc0c87d3044 |
|
23-Sep-2009 |
Cary Clark <cary@android.com> |
invalidate the webview after pressing the IME 'next' button
fixes http://b/issue?id=2141013
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| d3997e556eb0509248c72b668c2cd955b7842b55 |
|
21-Sep-2009 |
Leon Scroggins <scroggo@google.com> |
Make scrolling textfields work better in the browser.
The touch slop seems to be too large for scrolling
a small textfield, so use a smaller number. Also,
in WebView, create viewToContentDimension, and use
it for determining the scroll position of the text
field.
Partial fix for http://b/issue?id=2133049
Change-Id: I0ded3be264b179bad39301e6adce86851b649a42
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 241403fd19edc44d089f3860db1562ed523dea07 |
|
17-Sep-2009 |
Leon Scroggins <scroggo@google.com> |
Update the input method when the selection changes.
Fix http://b/issue?id=2074446
Add in code that is normally called by TextView.onDraw(). Since
drawing does not happen for WebTextView, we need to call it
ourselves.
Change-Id: Icb47f6a58fba6f8b11e2924befc704f26af68d43
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 7ae34197b03313dd3f278b1a995252040ae6e2df |
|
16-Sep-2009 |
Leon Scroggins <scroggo@google.com> |
Allow touches to change the selection in WebTextView.
Fix http://b/issue?id=2019857
If the user has not moved beyond the scaled touch slop, do not
turn it into a scroll, so the user can change the selection.
Change-Id: I1d88691a35ea2da4b03ad713b56331b5c268b757
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| ef92e7a606167130d4ae52c1e23f32c3f0af291e |
|
02-Sep-2009 |
Leon Scroggins <scroggo@google.com> |
Prevent a crash when webkit changes the selection.
Partial fix for http://b/issue?id=2081673
This prevents a crash. However, if the user continues typing
into the textfield, the selection is incorrect. The real solution
(forthcoming), will make sure that the WebTextView's text gets
updated when webkit updates.
Change-Id: Ic832ec48fd4236c8116c5cbda1467677ad731feb
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 6679f2f70813eb93bf88297dc2de5e56bc7d7ca0 |
|
13-Aug-2009 |
Leon Scroggins <scroggo@google.com> |
Pass clicks to webkit's textfield to determine the new selection.
Requires a corresponding change to external/webkit. We were previously
letting WebTextView handle clicks, determine the change in selection,
and pass that down to webkit. This sometimes resulted in a different
placement of the caret if the WebTextView and the webkit-rendered
textfield did not line up exactly. Now, we pass the click directly
to webkit, which determines the new selection and passes that info
back to the WebTextView. This also has the benefit of letting
the WebTextView reflect changes in the selection that originated from
webkit. Also remove some unused parameters.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 010582885cbd5e1becadd6c53816c399465b459d |
|
30-Jul-2009 |
Leon Scroggins <scroggo@google.com> |
Allow the user to jump to the next textfield.
Requires a change to external/webkit. Set ImeActions for textfields,
depending on the existence of other textfields on the page, and
react accordingly.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 72543e1bc386f23f5d8f3f21068887ec16408fef |
|
23-Jul-2009 |
Leon Scroggins <scroggo@google.com> |
Improvements to dragging on the WebTextView.
When TextView handles a mouse move as a scroll, scroll the
underlying textfield/textarea. Also do not hide the cursor
while scrolling within a text input. Requires a change to
external/webkit.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 416a3c7cdd584e327d9f52ad3adf7c6ee2aeca3a |
|
22-Jul-2009 |
Leon Scroggins <scroggo@google.com> |
Prevent a drag from both scrolling the page and changing the selection.
Fix for http://issue?id=1995835. If the user uses touch to drag a
web page by the WebTextView, do not change the selection as well.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 0f5ad842fb3fbc0df2a4c8028940810782cedacc |
|
17-Jul-2009 |
Leon Scroggins <scroggo@google.com> |
Allow the user to scroll a webpage by touching a textfield.
Fix for http://b/issue?id=1703971. Because the browser overlays
the WebTextView over textfields, it intercepts all the touch
events, which was preventing the page from scrolling. This
change passes the move events back to the WebView to make
the page scroll.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 10be4fc63a0d43262f1cfeac3b4a7904fa8fbc14 |
|
20-Jul-2009 |
Leon Scroggins <scroggo@google.com> |
Do not hide the soft keyboard when the DOM has moved focus.
Instead of calling remove(), which would hide the soft
keyboard, remove the WebTextView manually, so the soft
keyboard remains up (if it was up to begin with). WebView
will properly handle the keys now that the focus has
changed.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 0857767516a73cc87e10c8ababa5262114fb0578 |
|
16-Jul-2009 |
Leon Scroggins <scroggo@google.com> |
Show the password in browser password fields.
Fix for http://b/issue?id=1979719 : cannot see password in browser
textfield. Show the system's password transformation in a password
field, which can be set to show the text partially or completely,
rather than webkit's version, which never shows the text.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 4890feb048e4f0510c577babe3bfd08521a3996b |
|
02-Jul-2009 |
Leon Scroggins <scroggo@google.com> |
In WebTextView, check the focus before sending a key.
This fixes a bug where the DOM has moved the focus, but the WebTextView
is still sending keys to the old focus. Requires a change in
external/webkit.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 409812691def88027dc16ac930646eb260536c69 |
|
01-Jul-2009 |
Leon Scroggins <scroggo@google.com> |
Fixes for moving a focused textfield on screen when entering a character.
When the focused node is a textfield, but the WebView has focus
(for example if the page had an initial focus) and the cursor
is not over a plugin or textfield, rebuild the WebTextView
to handle the keys. Also, remove mScrollToAccommodateCursor,
since now the WebTextView is only showing when we want to
scroll.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 0ca70883d752cce77b918421ef81f3134f6ccd1e |
|
26-Jun-2009 |
Leon Scroggins <scroggo@google.com> |
Assign a field name for textfields in the browser.
Fix for http://b/issue?id=1605291. Store the url and name of the
textfield in EditorInfo.fieldName.
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 243ea06d2bf67e8b54da51977687b08f49aeb093 |
|
25-Jun-2009 |
Cary Clark <cary@android.com> |
Remove the web text view if the key cannot be handled
Also add some debugging to WebTextView
Requires companion change in external/webkit
/frameworks/base/core/java/android/webkit/WebTextView.java
|
| 49f372210b09c461f7c32dddd9170f9e8dad076f |
|
05-Jun-2009 |
Android (Google) Code Review <android-gerrit@google.com> |
am 12bba912: Merge change 3238 into donut
Merge commit '12bba912238f305d385b30c278a4bdbb027b7a03'
* commit '12bba912238f305d385b30c278a4bdbb027b7a03':
Browser edit fields should report variation WEB_EDIT_TEXT.
|
| d3465f6021c23ab2fbdbb1b08cde72caac1c2018 |
|
02-Jun-2009 |
Leon Scroggins <scroggo@google.com> |
Rename the TextDialog to WebTextView.
Rename the TextDialog to be a more accurate description of what it is.
Also rename some methods and variables which pertain to it, and preload
the newly created class.
/frameworks/base/core/java/android/webkit/WebTextView.java
|