| e510fa4c0b56814aadd938596847aec9ab0290cc |
|
17-Jun-2011 |
David Brown <dab@google.com> |
Fix permissions check in IccSmsInterfaceManager.sendText()
In android.internal.telephony.IccSmsInterfaceManager, we currently use
enforceCallingPermission() rather than enforceCallingOrSelfPermission()
to enforce the SEND_SMS permission.
The difference is that enforceCallingPermission() will ALWAYS throw a
SecurityException if you're not handling an IPC, i.e. if the request is
from the same process as the telephony framework.
In other words, the current code prevents the phone app from ever using
SmsManager.sendTextMessage() :-(
This change fixes IccSmsInterfaceManager.sendText() to use
enforceCallingOrSelfPermission(), and I confirmed I can now send SMSes
from the phone app.
NOTE there are a bunch of other uses of enforceCallingPermission() in the
telephony framework (all SMS-related) that we probably want to fix too,
although I'm fixing just this one for now since it's blocking a hi-pri
phone UI feature. I opened bug 4686733 to cover the rest of the cleanup,
though.
Bug: 4686733
Change-Id: Iaffcf62c54493fa4961fb20894c974697f26e3a7
/frameworks/base/telephony/java/com/android/internal/telephony/IccSmsInterfaceManager.java
|
| 145ff609de3206b585819ef974fab20cdc2d9f5e |
|
16-Apr-2010 |
Jake Hamby <jhamby@google.com> |
Spelling corrections and other minor cosmetic cleanups.
- Fixed a bunch of typos in comments (plus a few variable names)
- Removed unused import lines from telephony classes
- Added @Override attribute to overriding methods
- Made SmsMessage.PduParser inner class private & deleted unused constructor
- Added type specifiers to declarations of ArrayList and HashMap
- SimulatedCommands.getRegistrationState() had an ArrayIndexOutOfBoundsException
trying to write to index 14 of a 14-element array. I removed the
out-of-bounds assignment.
Change-Id: I054b5156aa64ab6639028d5b45a7e688b2deee08
/frameworks/base/telephony/java/com/android/internal/telephony/IccSmsInterfaceManager.java
|
| 8be9ccdc5c76b015ee8c7aa9922c80fdc4dc59ea |
|
03-Sep-2009 |
Wei Huang <weih@google.com> |
add conditional verbose logging for when sending a SMS message.
Change-Id: I969e4cbee87ce5a42eaf5809292442e90db294cf
/frameworks/base/telephony/java/com/android/internal/telephony/IccSmsInterfaceManager.java
|
| 1f952a178db86559ff4bab79c4a9b5fae18096bf |
|
25-Aug-2009 |
Tammo Spalink <tammo@google.com> |
Move SMS pdu creation fully into the central Phone process.
Previously pdu creation was haphazardly done sometimes by the app and
sometimes centrally by the phone process -- specifically the phone
process did creation for multipart texts. This change gets rid of the
previous IPC interface for sending raw pdus to SMSDispatch in the
phone process, and instead makes everything work like multipart
messages worked before, namely the structured data is passed and pdu
encoding done centrally.
The motivation for this was the need to ensure that CDMA message id
numbers were strictly monotonic, including across reboots, which
necessitated central state in the form of a system property, which
could in turn only be modified by the phone process.
Hence, this (in part) addresses issue: http://buganizer/issue?id=2075760
Change-Id: I94ca207b6e657c465e8472534704db8646ee277c
/frameworks/base/telephony/java/com/android/internal/telephony/IccSmsInterfaceManager.java
|
| 04e71b3db84fd5f7fc4eefb49a33154ea91ec9fc |
|
02-Apr-2009 |
Wink Saville <> |
AI 144245: Fix merge conflict for megering in the CDMA changes in to master from donutburger.
Automated import of CL 144245
/frameworks/base/telephony/java/com/android/internal/telephony/IccSmsInterfaceManager.java
|