| 18e2b6f48045eebd802ff560420e1ad19b2e2da8 |
|
01-Nov-2011 |
Katherine Kuan <katherinekuan@google.com> |
Check activity state before showing phone disambig dialog
- This is a monkey bug on Crespo that happens often. The
monkey is likely tapping on a favorite contact in the Phone
app, which is trying to either dial the contact or
show a disambiguation dialog if the contact has multiple
phone numbers. There's an IllegalStateException with trying
to commit the dialog fragment transaction because the
saved state has already been called.
- After a PhoneNumberInteraction is started, a CursorLoader
is started, and when that returns, potentially we try to
commit a FragmentTransaction (showing the DialogFragment).
At this point, the activity may be long gone, so we need to
know if the activity has saved state or not. Hence,
we add a new base activity class (TransactionSafeActivity)
that keeps track of this information for us.
- The PhoneNumberInteractionTests still rely on passing in
a context to PhoneNumberInteraction (in order to check
that the queries and subsequent activities are correct),
but we typecast the static methods the app uses to
create these PhoneNumberInteraction objects.
Bug: 5132436
Change-Id: Id9d887bd55235b07133568a38d4922dc7fce24a7
/packages/apps/Contacts/src/com/android/contacts/ContactsActivity.java
|
| 4d788fc27ac855bd6e0cec17dff39a18564f0089 |
|
12-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
People: Action bar tab refactoring
- Now ActionBarAdapter manages the action bar tabs.
- Now ActionBarAdapter.setCurrentTab() should always be used to select
a tab programmatically, rather than directly calling
ActionBar.setSelectedNavigationItem().
- Do not re-create/re-initialize ActionBarAdapter/ActionBar for new
intents.
- Simplify fragment visibility update logic in PeopleActivity.
- Do not clear ActionBarAdapter.Listener in PeopleActivity.onPause;
do this only in onDestroy.
Activity is paused when we're processing onNewIntent(), but we still want to
get callbacks during this.
Change-Id: I93ec35e569e1854923503734693b6404cff92f50
/packages/apps/Contacts/src/com/android/contacts/ContactsActivity.java
|
| 50445e9d1efb1fa046d9a1232c973b4c96e1f52d |
|
12-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Retry: Set up fragments just after setContentView().
Redo of I9e0ad079 with fix for crash on portrait.
I9e0ad079 crashed if you launched the app on portrait, because contact details
fragments don't exist in the layout.
(It worked when you rotated from landscape to portrait, because the fragment
manager would recrate them even though the layout didin't have them.)
The only change from I9e0ad079 is that we still use onAttachFragment to
initialize details fragments.
* Original CL description:
... except for ContactsUnavailableFragment, which is not in the layout.
(we dynamically create it.)
It's part of refactoring to prepare for ViewPager.
This also fixes the "mFavoritesFragment and mFrequentFragment are both
StrequentContactListFragment but we always assume StrequentContactListFragment
is Favorites in onAttachFragment" issue.
Change-Id: If30611039d8cdaa8f91676454eba67e89fcbdcc8
/packages/apps/Contacts/src/com/android/contacts/ContactsActivity.java
|
| 4959ca3d0093a798859660f2914003d0da777645 |
|
12-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Revert "Set up fragments just after setContentView()."
It crashed on 2-pane portrait. Seems like there's no ContactDetailFragment in the layout...
This reverts commit 0dafecbe5dbf810d83f9cf0ce590e8e055c53a48
/packages/apps/Contacts/src/com/android/contacts/ContactsActivity.java
|
| 0dafecbe5dbf810d83f9cf0ce590e8e055c53a48 |
|
12-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Set up fragments just after setContentView().
... except for ContactsUnavailableFragment, which is not in the layout.
(we dynamically create it.)
It's part of refactoring to prepare for ViewPager.
This also fixes the "mFavoritesFragment and mFrequentFragment are both
StrequentContactListFragment but we always assume StrequentContactListFragment
is Favorites in onAttachFragment" issue.
Change-Id: I9e0ad079714813a5bef898a51eb49cc88a78dbf2
/packages/apps/Contacts/src/com/android/contacts/ContactsActivity.java
|
| 3a6a905a39e6cbb3b2dc99835cdf28c84437691a |
|
02-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing callback delivery for ContactSaveService
Bug: 3500229
Change-Id: Ia50aa5878344f182e33141ba891c3dea56a170ec
/packages/apps/Contacts/src/com/android/contacts/ContactsActivity.java
|
| 072d91171c749f43b64900118e6f4dcbdd7b1097 |
|
10-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adding mock shared preferences
Change-Id: I1af7cb97703191ce016a936fd843e1ac73be1022
/packages/apps/Contacts/src/com/android/contacts/ContactsActivity.java
|
| 1173ae29217fc83f254404f8a5fa10419ee83c93 |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing ContactBrowserActivityTest
Change-Id: Ie492eae15c7163d0f8a3577e73ae14b786709a35
/packages/apps/Contacts/src/com/android/contacts/ContactsActivity.java
|
| 6f667b55687bf9193323802e8f3234f0ab254388 |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Turning AccountTypeManager into a "system" service.
It's really not a system service proper. It just
uses the same API and the same dependency injection
mechanism as for system services.
Change-Id: I56e24e0f16642a5ab25e809ee12906d965845379
/packages/apps/Contacts/src/com/android/contacts/ContactsActivity.java
|