| 5c3a0a1440625fab859aab420cb08bc0276358a0 |
|
08-Nov-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix wrong contact being selected after editing (after a search)
- The problem is that after finding a contact via search
and editing that contact, we launch a VIEW intent to view
the contact. Then sometimes, that contact is not in the
current contact filter, so we may have to enter single contact
mode.
To avoid that, go back to the HC functionality of preserving
search mode. Now after editing, we return to the PeopleActivity
and preserve search mode if that's where we came from.
This was the relevant change from early ICS that is being
partially reverted:
Ibbaaccb03ac7961784dfa7b15c246b8d6f6489a4
The reason it was changed was to support viewing the contact
after editing a contact when the edit request came from a 3rd
party app. This still works with this change by adding
an intent extra in ContactEditorActivity.
- After the editing is done, only launch the VIEW intent
for the contact if we didn't come from the detail page for
that contact (on phone and tablet). We can just finish
the editor activity. This saves some time with setup / configuring
fragments because we don't have to resolve the VIEW intent
(i.e. On tablet, previously the VIEW intent launched the
ContactDetailActivity --> redirected to PeopleActivity -->
resolved intent to show the right contact.
Now we can just receive the onActivityResult and refresh
the page).
- Renamed ContactDetailActivity intent key to be consistent
Bug: 5542197
Change-Id: Ieaa9c147beeaa7c40f34fc1689858642b47fdbf9
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 966cc74cb9cff62cf19d7870dd1e2e849de44424 |
|
20-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Merge "Fix the double query issue on phone"
|
| 1db00f68b34f6cf7e9d19fedb559cf12f8c05e9c |
|
19-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Fix the double query issue on phone
The issue was that fragments had separate methods for search: setSearchMode()
and setQueryString(). But now that fragments will never be in search mode
when query is empty, there's no need to expose both methods.
Changed setSearchMode() to non-public, and let setQueryString() call it
when necessary, so now we don't have to issue unnecessary queries.
Note this CL doesn't modify adapters, so they still have setSearchMode()
and setQueryString() as separate, public methods.
Also did a bit of cleaning up on how PeopleActivity handles search mode.
(When I worked on it first time I wasn't too familiar with the code, so was
afraid to change existing code too much, which left the code unnecessarily
complicated.)
Also removed all fragment.setSearchMode()/setQueryString() calls in
ContactSelectionActivity.configureListFragment(). As far as I checked
there's no way to invoke this activity with reqeust.isSearchMode/getQueryText
set.
Also removed ContactEntryListFragment.get/setContactRequest, which weren't used
anywhere.
Bug 5274171
Change-Id: I794db7ed54cb6b8f45d69430ec2f77e7fa83fb8c
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| aaadf9393e98b04a40d249cd97ec758047268ed9 |
|
20-Oct-2011 |
Katherine Kuan <katherinekuan@google.com> |
Use text (instead of icons) for action bar tabs on tablet
Bug: 5345494
Change-Id: Id83008d868be9fba1d1bfe8c8d60adf0bff0cdcf
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 1ff189a390ce5011f729637baf248646560c1bc6 |
|
08-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Replace tab texts with icons
Also replaces existing "contact card" icons with ":D"
Bug: 5274359
Change-Id: I04b77bfdab17f4a2468e8ecde88fab7477c11e3f
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 0bf7cd0124fa6f74fe3d64619740420ded86dcce |
|
23-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Asset swap and make SearchView use themed context
- Make SearchView in action bar in People app use action bar
themed context so the query text and icons are white instead
of gray. Create a custom theme to make the hint text lighter
than the default DarkActionBar hint text color (as directed
by UX and framework)
- Replace panel_message asset (background of contact editor on
tablet and contact unavailable fragment)
- Replace the panel_content asset (background of group detail
fragment)
Bug: 5127109
Bug: 5199518
Change-Id: Icae927e1d158241140d18028d38cac25dbf282fc
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 9d2a74ef7b1817ad0708e41151358f5899aeeb67 |
|
15-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
New tab order: GROUPS / ALL / FAVORITES
To be consistent with the phone app.
Bug 5161134
Change-Id: Ieb50b78d140ca5404620c9ad03fb31433b7b666d
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| e668051b61d05c267a8e3c1bfd2fe9b034aa6ae1 |
|
12-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
New search behavior for empty query
It's a very lightweight change to implment the new spec, which says:
- Don't start searching until the user types the first letter
- But if the search view is shown, make the ALL tab current, and disable swipe
With this CL,
- No changes to ActionBarAdapter.isSearchMode(). It still returns true
if the search view is visible, even if it's empty.
- However, in order to make the all fragment show the normal list for
empty query, only turn the fragment into the search mode if the query is
non-empty.
Also reverts I25908651 as we no longer do a search with empty query.
Bug 5104010
Change-Id: I50038994c6d65aab71ceefdf9218f3c7ad2bc6a4
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| d8a61b7296bf7388505f0211d7ef44700e766193 |
|
27-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Use new search pattern in People app
- Magnifying glass should go inside the EditText field
- "Done" button on keyboard should hide the keyboard
- When going to a search result (contact card),
the "up" button should return to the search results
and not relaunch PeopleActivity
Bug: 5081198
Change-Id: I32e103c39c40da26bfd12f1fa8cef000f33ee1c9
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 5267367e202dcb39ef0fe912a7be9209548ec436 |
|
25-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Change the search UI on 2-pane
- Don't always show the search view. Instead, show the search icon as an
option menu.
- If the icon is tapped, show the search view.
- Don't show "Searching all contacts". Just show the search view right
next to the app icon.
This simply means to use the 1-pane search UI on 2-pane as well.
Bug 5055536
Change-Id: I9a4b16048285cd30975bcb2bae5ec3d01d15f20e
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 35d4aec605ce915ff5c574892a2069a37e0b9a77 |
|
20-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Implement sticky tab
Remember the last selected tab and open it when the app starts.
Bug 5046301
Change-Id: I94a11b3397181b09f72e91c20bf451e7ac8eb5ed
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| d84ea5c8b0a8376e7cf80b0e15b65a72fd99d7a9 |
|
14-Jul-2011 |
Adam Powell <adamp@google.com> |
Follow framework API change
Change-Id: I6bbc24d20d3bd254f6e2d54c14100fa9ab8513ed
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| e0c66aff27473d0edbd95660b95f0f2a80ab63ec |
|
13-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Show the "UP" icon on the search mode.
- On both 1-pane and 2-pane.
- Also just use a bool resource instead of styles to get
the "should show the home icon" setting.
- Also clean up how we set action bar display options.
Bug 4983521
Change-Id: I81f61a98bfc6695784a323cb28e05d7e3f7f932d
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 250ce43794cdf6820f7a13ef0195a566bd0c8c64 |
|
13-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
PeopleActivity: Swipe!
I was originally planning to create a set up classes to abstract out the
logic to controll fragment visibilities, but with the last refactoring on
ActionBarAdapter() I think it's managable without them...
Change-Id: Ic6c8a2b87005bc0cd3ab41dee7ac99db794274eb
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 4d788fc27ac855bd6e0cec17dff39a18564f0089 |
|
12-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
People: Action bar tab refactoring
- Now ActionBarAdapter manages the action bar tabs.
- Now ActionBarAdapter.setCurrentTab() should always be used to select
a tab programmatically, rather than directly calling
ActionBar.setSelectedNavigationItem().
- Do not re-create/re-initialize ActionBarAdapter/ActionBar for new
intents.
- Simplify fragment visibility update logic in PeopleActivity.
- Do not clear ActionBarAdapter.Listener in PeopleActivity.onPause;
do this only in onDestroy.
Activity is paused when we're processing onNewIntent(), but we still want to
get callbacks during this.
Change-Id: I93ec35e569e1854923503734693b6404cff92f50
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 30cc2916916535a8140637f54925c93189868de5 |
|
12-Jul-2011 |
Isaac Katzenelson <isaack@android.com> |
Temporary fix for crash on rotation in search mode
Change-Id: Iffc020090dddc4e3aa18972940dbe642c49d4dfd
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 495db43f0a08bd71ba28a42f89b80d38af15afec |
|
07-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Bring back account filter
- ContactListFilterController no longer loads accounts and groups,
to display in the action bar drop down menu. Now it just stores
current filter and saves it to preferences.
- ContactListFilterLoader is no longer needed because we're not
loading groups anymore
- Move adapter from ContactListFilterController to the
AccountFilterActivity
- AccountFilterActivity loads a list of accounts and returns
a ContactListFilter as an activity result based on the account
selected
- If "customize" is selected, then the CustomContactListFilterActivity
will be launched.
- Show header in contacts list according to what account filter
was selected
- Update filter activities to holo theme
- TODO: Remove the "display phones only" option in the
customize menu on the phone
Change-Id: I45e0bdee80e7885d39bf09183a66ec50d81d1982
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 4ba903cdf132a6be2e5efa33187b18ca8446e503 |
|
08-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Fix for search view/IME issues
- Set the search view as the custom action bar view on tablet too,
(not as an acition view of a menu item.)
- Add a dummy view to the action bar to prevent the search view from
getting the initial focus.
- Call SearchView.setIconified(false) to make sure the IME will pop up
when setting focus on the search view.
Fix for:
- tablet: Keyboard keeps popping up upon app launch.
- tablet: Keyboard keeps going away after each character is typed.
- tablet: Have the search view request focus again.
- phone: Keyboard won't pop up when the search view is shown
Note:
- The width of the search view on the tablet is temporary until we
get redlines.
Bug 4691469
Change-Id: I70d1dddebf63120e8fbbafd6a0548d8553a8927c
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 59dc2751d64f60f743b8a9e78186aa5b79dcaf83 |
|
07-Jul-2011 |
Isaac Katzenelson <isaack@android.com> |
Fix "Tab not maintained on rotation"
Change-Id: I331794c948dab876c808ba1274cb11dbdb70155d
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 1ee9df6facd2340416d6a33aeb739707643d2fc3 |
|
12-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix search view on phone
- Take SearchView out of the action bar on the phone
and put it into the overflow menu
- Hide menu item if already in search mode
Bug: 4575326
Change-Id: I63003bb2c31712510ffa30eadb65b8a511f42011
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| f3f933a798c9cfffb1c1c0cc770187b5b0b763eb |
|
10-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix NPE in ActionBarAdapter
- Fixing the SearchView will require more work, but temporarily
add a null check before calling any method on the SearchView so it
doesn't crash anymore in Monkey tests
Bug: 4584460
Change-Id: Ibb31a1931213cdce82b593c9de62e600d5ba2e35
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| b5760b94bbf56ce348876ec36f4669d20a1530f5 |
|
02-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add tabs to People app
- Move account filter into overflow menu
- Use action bar in tab and standard mode so the SearchView
is right aligned and part of the options menu instead of the
custom view in the action bar
- Make visibility of action bar home icon a style so the icon
can be hidden on the phone
- TODO: Make physical search button work on the phone so the
search box can be removed from the action bar
- TODO: Fix SearchView focus problems
Change-Id: I7b3ba49f80e1911fb4a096679a00560967584426
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| eb5c3228af1e86db5552bc8baf6bf62c77612f3e |
|
23-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Prevent empty search results from showing up before typing
Bug: 3446388
Change-Id: I6994eca6c90357e61dfbdc22283e3169ece25efc
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| c5792ae6760291d435e91e0fdd28ece6b3311439 |
|
21-Jan-2011 |
Adam Powell <adamp@google.com> |
API change - bug 3370353 and bug 3370338
Change-Id: I470771606f15936e3a20f4c0aaac0fe99b2a587f
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 8db1913dc30cd83ac27e10a4cfda12b4bf08dcfe |
|
13-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Making search mode triggered by focus in, but ignore focus out
Bug: 3340666
Change-Id: I75422950c9f708f4651ebf74a43f65eebcea9d11
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| fa49a66979567894c85fe2489d1375216d67597e |
|
13-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preventing multiple instances of contact browser from launching
There is a lot of complexity (and simplifications) in
this CL because as it turns out having fragment transactions
was causing focus to be acquired by the search field,
which was causing all kinds of problems. So now we only
have one permanent list fragment (which should go into the XML
file) and we just change modes on it.
Bug: 3345023
Change-Id: I096be24b7598350a074eb1dadc954c7619f26669
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 1173ae29217fc83f254404f8a5fa10419ee83c93 |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing ContactBrowserActivityTest
Change-Id: Ie492eae15c7163d0f8a3577e73ae14b786709a35
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 3e076bb53d39eb3757b376a003c412e4f44b0e3d |
|
11-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adding a hint to search view
Change-Id: Ie5c964a45458159c82c48414a54e19524289f794
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 11cbbf445e4724246836f006f06ad16cc82ca439 |
|
09-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Switching to framework styles in action bar
Change-Id: I218710421d40e28557252ac22f95c8e0c1791513
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 02cbf8b0e73a7e169445e341f387356242f0334d |
|
24-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preventing keyboard from showing while loading contact browser
Bug: 3224228
Change-Id: Ic036e07c3da8deeaf11671295ac0509dd10d7f71
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 8b8264620f9362e089322d1e3a7cc5620900e6f9 |
|
17-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Resurrecting empty state UI
Change-Id: Idc1ee48d62d4f0c01756f9b7689e0f31235b61d9
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 4597c92d655d45447780b32c7572acef110b6ed1 |
|
15-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming BaseAccountType to AccountType
Change-Id: Iff47bac0e1a118f4a5319526304df16cb89bd0cd
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| a31fe548862fef70d3244dc3414a478f91b098f6 |
|
13-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing contact filters for local (unsynced) contacts.
Bug: 3159239
Change-Id: Id469b19d35dc62e092db64f0ee3356a7ec2f2680
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 9ce839e2a86b1742682fdec69641c6ed9d665a06 |
|
12-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
New assets and layout in the contact filter pulldown
Change-Id: I549eccac6f6fe4e28a4a26a5a2433b3562dd8c91
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 3bfccddd6f61f6196a7f0af426c9e3f742de37f3 |
|
04-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing the size of the search field
Change-Id: I196ac49cc8a8120f3073b9a7afb8bbd84ad757a6
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 174fdc2dcb965f11cf4eb25e4ea961f0e1e56c85 |
|
29-Oct-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Automatically selecting first found contact.
Change-Id: I232f37d1b5256c315d514a2c8dee9e9eeca5dcb7
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| ab4d29f6a2edbfae008dbaff35f25baad73aa0df |
|
28-Oct-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Changing search navigation in Contacts
Search will be fully modal: when the search field
is focused, the app is in the search mode, period.
Back button will cancel search mode.
Change-Id: Ibeb6c28de7ed1a79129aed862a543a6ed2a36435
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 9806ed099226a19e92c29d9efa791cd187fd2a53 |
|
26-Oct-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing contact search
Bug: 3129260
Change-Id: Idb822c10da86cb58a7d46456135bdfa215723993
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 0b51a8d4539cc516dc2c02948335347d1df8769b |
|
22-Oct-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Forwarding keyboard input to the search view
Change-Id: I111214dc5bfd2194fef4647ec54fa671a7d1b8ed
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| c9916d303cc48b4a4ff94ef9c56d7ca5da72c4de |
|
13-Oct-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Improving layout of aggregation suggestions
Change-Id: I8690c36d0e80f89ee5043703e3a20bc46357f6e5
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| bee8d3bd37edf44c535c0cc401e8d03f095b8328 |
|
13-Oct-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Improved layout of contact filter view
Also, no longer showing the down-arrow when there
is no filter or only one filter.
Change-Id: Ie9bbb7aa279ff2013e4c24ca8f302d864679c35c
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 251e4f7dc45928053133fe15fd456da00b7cbe8c |
|
06-Oct-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Contact filter uses custom UI instead of NotifyingSpinner
Change-Id: Ia51c6944d67e41050be4e3e60856b15b77ffa090
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 15ccbb4d22fd65165cacb7970cbe61de1aa9aac4 |
|
06-Oct-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Moving contact filter spinner to the action bar
Change-Id: I29506d0e71e15e4804899146855f22690969d1f5
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 88a405fcd3fecfa24c756a8a453a957ecc9f95ae |
|
28-Sep-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing preservation of tab selection on rotation
Change-Id: I954e5ba21466a4e6489b40f47171e576c57537e8
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 1a59cffd839069ce91a9febb8a136442340ab4c8 |
|
18-Sep-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Switching to tab and search UI provided by the framework.
Could not make the search UI always on: apart from some
serious technical difficulties the UX is odd.
First the UX issue: I type in
a query and then switch to some tab. If we leave the
query string in the field there is a disconnect between
that query and what you see in the list. If we wipe off
the query and then we have to retype it completely on
the next search.
Now the technical issue: the search field grabs focus
so whenever I open Contacts, the search field is focused
and the keyboard is up.
Also had to hack SearchView a bit because it does not expose
the API of its constituent AutocompleteEditText.
Change-Id: Ie8848d16ab724e9bb6b7025e88b495c7297d49a7
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| 2eb26aacc35a624607187418d61c78258eee8b2c |
|
06-Aug-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing bug with query string change
To repro the bug, click on search, enter "a", backspace "b"
The result will be for the filter "a".
This CL fixes the problem
Change-Id: Ie85ff4945de4ebbe623dee4a8430dac73c52f0cb
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|
| fcfdffb439ccf1ddef971109b82e782c47161572 |
|
16-Jul-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming NavigationBar to ActionBarAdapter
Also, moving browser modes to a class of their own.
Change-Id: Ie2745581537e09717a2c7a58ecebec1b7ada0c81
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
|