History log of /packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
e21b1670fc902f27a5580ac4bedd0d68a53a6c2f 09-Nov-2011 Katherine Kuan <katherinekuan@google.com> Fix NPE in PeopleActivity with returning a null intent from editor

Bug: 5592500
Change-Id: Iabbdc4c0422a58cfc557cbcd84a92d33c1b01ff6
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
5c3a0a1440625fab859aab420cb08bc0276358a0 08-Nov-2011 Katherine Kuan <katherinekuan@google.com> Fix wrong contact being selected after editing (after a search)

- The problem is that after finding a contact via search
and editing that contact, we launch a VIEW intent to view
the contact. Then sometimes, that contact is not in the
current contact filter, so we may have to enter single contact
mode.

To avoid that, go back to the HC functionality of preserving
search mode. Now after editing, we return to the PeopleActivity
and preserve search mode if that's where we came from.
This was the relevant change from early ICS that is being
partially reverted:
Ibbaaccb03ac7961784dfa7b15c246b8d6f6489a4

The reason it was changed was to support viewing the contact
after editing a contact when the edit request came from a 3rd
party app. This still works with this change by adding
an intent extra in ContactEditorActivity.

- After the editing is done, only launch the VIEW intent
for the contact if we didn't come from the detail page for
that contact (on phone and tablet). We can just finish
the editor activity. This saves some time with setup / configuring
fragments because we don't have to resolve the VIEW intent
(i.e. On tablet, previously the VIEW intent launched the
ContactDetailActivity --> redirected to PeopleActivity -->
resolved intent to show the right contact.
Now we can just receive the onActivityResult and refresh
the page).

- Renamed ContactDetailActivity intent key to be consistent

Bug: 5542197
Change-Id: Ieaa9c147beeaa7c40f34fc1689858642b47fdbf9
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
36d24d7ede42a252c82c4aa783b2231c5e2eea79 26-Sep-2011 Dave Santoro <dsantoro@google.com> Avoid showing error if contact removed on save.

Because removing all data from a local contact can actually cause
the raw contact and contact to be deleted, we need to track that
case so that the caller does not consider the lack of a lookup
URI to be an error.

Also made "Me" header all-caps for no-profile case.

Bug 5346614
Bug 5354364

Change-Id: If1e1d67da9c14eb8782be05b2e39ece19b5ac026
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
8d5abcb71ed4d9671b9066b9e3ffaf5372d2b22c 03-Sep-2011 Makoto Onuki <omakoto@google.com> Make sure only People and Dialtacts responds to search key

- Remove the default search activity meta-data from manifest, so the old-style
search dialog won't show up when the serach key is pressed. It was for
pre-HC style search UI. Now the search key only works on people and dialtacts,
which implement either startSearch or onSearchRequested.

- Removed all the startSearch/onSearchRequested methods which are now
unnecessary.

- Also removed startSearch() in some fragmets. They're not used.

- Tested some viewer/editor/picker activities, and also both dialtacts and
people, the launcher search box, and the SEARCH intent, on both the phone
and the tablet (except dialtacts on tablet). All looking good.

Bug 5230790

Change-Id: If269df74ae218707daa5b7039439c6fea2575e8d
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
18f5f79fa3991a864a17596fe14a04045a7540eb 19-Aug-2011 Daisuke Miyakawa <dmiyakawa@google.com> add contact capability for Phone UI

Also make edit screen exit to previous screen so that Phone UI
and 3rd applications won't confuse users with INSERT Intent.

TESTED:
* phones with/without a hard menu key
- Phone UI should have just one "create contact" menu on the right
place in the search mode.
- Phone UI should not show the menu outside the search mode.

- People UI should correctly navigate users using add/edit capability

* tablet
- People UI should correctly navigate users using add/edit capability

Bug: 5185218
Change-Id: Id8360aeb6ef99ef0d3ab2902e97c0bbe8f590c17
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
bec0e12648b7c90aab9eda5b2837faca2493e5c3 10-Aug-2011 Makoto Onuki <omakoto@google.com> Remove unused callback

Bug 5143491

Change-Id: I20b82551329f1beb05dc4039cf0d501fe9a9e676
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc 27-Jul-2011 Dave Santoro <dsantoro@google.com> App changes for account types with data sets.

This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).

This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.

Bug 5077096

Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
1390f85d3776dd9ad9d38f611f3a0d4ed59f6249 27-Jul-2011 Katherine Kuan <katherinekuan@google.com> Modify action bar for group editor and group card

- Remove home icon in group card
- Change done/cancel buttons in editor
- Remove old honeycomb style on editor activities
and have it use the new split style solid action bar one

Bug: 5081353
Change-Id: Ie39f7f1ea5bd80d5246158442325207effd6aff7
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
9b3dfd0bc36568558bfdc32a5d4c30f2d0df5fed 22-Jul-2011 Katherine Kuan <katherinekuan@google.com> Modify action bar for contact editor

- Use custom action bar for "Done" button (hide app icon and
get rid of "up" affordance")
- Move "Cancel" into the overflow menu and rename it to "Discard"
- Remove "delete" button from overflow menu in editor as specified
by the UX mocks b/c the user can delete the contact in the
contact card already

Change-Id: Ic389983a08a7b03fa24e7f4c1c37c95bd6c1c9fa
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
5649a12fe551855f00c8dbeacfc96511c2a5fb71 20-Jul-2011 Katherine Kuan <katherinekuan@google.com> Go to contact card after editing

- In PeopleActivity, get rid of startActivityForResult to launch editor
because the editor will take care of launching the
contact card itself (instead of relying on the PeopleActivity
in the tablet to reload the contact details)

Bug: 4769324
Change-Id: Ibbaaccb03ac7961784dfa7b15c246b8d6f6489a4
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
53b427b3dc6f04340133b2da135b3f5efea4de11 17-Jul-2011 Makoto Onuki <omakoto@google.com> Make search less magical

- Remove PeopleActivity.mSearchMode. Instead, always ask ActionBarAdapter
the current mode.

- Don't use the default search behavior (i.e. send a new intent) on 1-pane.
Now 1-pane and 2-pane go through the same path for the search menu item
and for the search key.
i.e. when search key is pressed, show the search view (only on 1-pane),
set focus, turn the "all" list into the search mode too.
(and the "all" list should initially show all contantacts eventually, but
it's another issue which hasn't been fixed yet.)

- Remove dead branches.

- Instead of startSearch, override onSearchRequested(), which is the preferred
way of implementing a custom search action.

Change-Id: I4fd15a7f3164a3832df21b8fa1fb215e53d1a3e1
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
43fbbc1e5bbc295d0be5033a002e9f532fdfb119 15-Jul-2011 Makoto Onuki <omakoto@google.com> Disable search key press on 1-pane detail/editor activities

These activities don't have the search menu item, so the search key shouldn't
work.
(The behavior was weird anyway... e.g. it worked differently on
ContactDetailActivity and GroupDetailActivity...)

Bug 5032530

Change-Id: If3504cbd3e5cf027d43eec68d8f89e41bd7d324c
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
9856fcee477d04f51bdbcbfdf632876c6b8a1173 01-Jun-2011 Katherine Kuan <katherinekuan@google.com> New People activity

- This is part 1 of bringing up the new People app
- Rename ContactBrowserActivity and related XMLs to PeopleActivity
- Change Contacts to People app launcher icon
- Create new task affinity for phone app activities
- Get rid of ContactsFrontDoor activity because it doesn't need
to distinguish between Dialtacts and ContactBrowserActivity anymore

Change-Id: I8c5e1ed540b294c1bda85409ca1499f88d4459ee
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
51e8d634f2d16aeaed73b6fba42d02a1c2d48b20 20-May-2011 Daniel Lehmann <lehmannd@google.com> Remove an unneeded function and an unused callback function

Change-Id: Icb01f50ad12d19a019da04bc27fa0d6f6ec04dfe
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
6313d346faaa29ff3c01c117268626163491523e 17-Mar-2011 Daniel Lehmann <lehmannd@google.com> Fix crash when opening the editor and move buttons to ActionBar

Change-Id: Id079a1e88c06aee2d1ff2894bc516c4df8b43406
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
1b29450c1cfa977075aaea4c2a02c233e2301323 24-Feb-2011 Dmitri Plotnikov <dplotnikov@google.com> Fix the issue where contact creation is triggered by another app

Bug: 3483189
Change-Id: I88374824ab49549e683fab51519d7915661073c0
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
c9eda37df2ff1ba2f845ae330bae364cb35fa50a 23-Feb-2011 Dmitri Plotnikov <dplotnikov@google.com> Close contact editor after deleting contact

Bug: 3396132
Change-Id: I1818446b8ecb6ef71d7c763d3e7ea3dc4c820b02
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
a011414b12955a91c8f3efe528f374654d930098 15-Feb-2011 Dmitri Plotnikov <dplotnikov@google.com> Moving contact saving to the service

Bug: 3220304
Bug: 3452739
Change-Id: If4124096a24e5dd302feb5338efaaa8398b2cb6b
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
6f667b55687bf9193323802e8f3234f0ab254388 09-Jan-2011 Dmitri Plotnikov <dplotnikov@google.com> Turning AccountTypeManager into a "system" service.

It's really not a system service proper. It just
uses the same API and the same dependency injection
mechanism as for system services.

Change-Id: I56e24e0f16642a5ab25e809ee12906d965845379
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
a07fa5f37031e4c5cd2933de02d2db41ec153e2b 09-Jan-2011 Dmitri Plotnikov <dplotnikov@google.com> Renaming AccountTypes to AccountTypeManager.

The intent is to turn it into a "system service" of sorts.

Change-Id: I047d70a2e59978c05916965ef0c0d9f18abc55e6
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
b77be6d2ad06edfd8751f55043e4aa9fd9f36015 04-Jan-2011 Dmitri Plotnikov <dplotnikov@google.com> Removing inflation levels from AccountType.

Also, fixing asynchronous update and concurrency issues.

Bug: 3140873

Change-Id: Ie9d342d23ee4a8d23405ef4145c54d7673b2cbe9
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
69f9e6f0cd9b5401da55f251e9bd98e69643d7df 04-Jan-2011 Dmitri Plotnikov <dplotnikov@google.com> Renaming fields and variables from "source" to "accountType"

Change-Id: Ie41036e35a45fc7d9a8c934a3cbe68399c567ad6
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
fff6f07a02d3e3bbeff2ecf94a703782b71aea66 22-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Adding support for 3rd party contact editing

Change-Id: I0379f7392a23aea68d0f59a9869bb72275f5bddb
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
f7ab3f49c3c21544d1bfddc5f9a70019c5b3ae49 10-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Ignore "join completed" action if it arrives after activity is closed.

Bug: 3259952
Change-Id: If757bafda9dd4edc8120faa1bea6ffefef762acf
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 03-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Renaming a couple of packages

Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
9df61ed9eeecb81043e7e6662ff3da83428d6865 03-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Implementing "app up" behavior

Bug: 3237656
Change-Id: Ief60f257ea59a1da8ad9e3fcabf292ee4f7506c3
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
2b46f0301c51973d6e3b02b78b398af097244af9 30-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Pushing contact joining to the service (background thread)

Bug: 3228687
Change-Id: If7f492aab683e6033a82e45714795c4a04407234
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
66bca8f360c9e21b6a47006f21db7b46b6b46340 25-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Turning ContactDeletionInteraction into a Fragment

Change-Id: I6edb576d0158b7082d3e2bc4d1902d34fc62cc7a
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
1ac58b6f2a925c5a4f759346e5244dfd174acd08 20-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Adding "Create new group" functionality

Change-Id: I2d0c28fcf3e9b3099c8889560a149f18f0f74c38
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
7d901bb3d4118762e21f4db19e35fc937dcf96fe 03-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Automatically adding suggested contact to My Contacts on switch

If the user creates a new contact, gets an aggregation
suggestion and clicks on it - we switch to the selected
contact, but now also adding it to the My Contacts group
if applicable.

Bug: 3140599
Change-Id: I29a18fde42f62297236d1eae88fb149cc7a204b7
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
1015d629f848de9d331a47c819f55854549d661d 02-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Fixing crash on saving an empty contact

Bug: 3118296
Change-Id: I666129a10bdefeacdbe847b858c0e900e05bfb30
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
249888359a0468df8ae09e0733131281db725944 23-Oct-2010 Daniel Lehmann <lehmannd@google.com> Fix deletion from editor

Bug:2999957
Change-Id: I25daccb1b721b468a4ee4cbcb96344c02ceb410f
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
e47dd262a9880121fc2b75fe82b002bc101fc682 20-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Using an intent to switch to aggregation suggestion.

When the user picks an aggregation suggestion to edit,
switching to the new editor is now done with an intent
instead of a reload. This adds a nice transitional
animation.

Change-Id: Iaeab24a6328be51dcde69c1a6ed9babc929709a4
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
8c91dfb9ef1c7ac1a4b2feed0b9a8585d4873542 15-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Conact editor to remain open after a manual join

Bug: 3060255
Change-Id: Ice2bd7d4f1473d3e2c81d6ccd4e3a67428b2bf51
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
825cb62b7df3cfe208651d488278e1b57c863884 27-Aug-2010 Daniel Lehmann <lehmannd@google.com> Show the editor in full-screen for Edit and New.

Change-Id: I1f02d979db141d2b08b82aac85fa2deb39c5fbec
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
3514fd3fbc7aabdddc647cd6f745437ba4f780a6 19-Aug-2010 Daniel Lehmann <lehmannd@google.com> Use new FragmentManager APIs

Change-Id: I31a862f131c58dbe482573fee177d934fa1e4710
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
15972398b530b91612418dc11d41c356d4f43739 11-Aug-2010 Daniel Lehmann <lehmannd@google.com> Allow saving without closing the Editor

Bug:2895633
Change-Id: I8f8c83952ac84389f9d06bc1ef833ba96a8b887f
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
a35a7e2aabc4edfafb9b4171e279bdb4c0c03d44 04-Aug-2010 Daniel Lehmann <lehmannd@google.com> Redo dialogs with DialogFragment and fix Join/Seperate

Change-Id: Ied997ad6ba3cf260eb2a04b8882184f1f800140c
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
b846fc117b2c4c0c3ed5eb3e9ce32591986a0253 29-Jul-2010 Daniel Lehmann <lehmannd@google.com> Allow deletion from Editor-Screen

Change-Id: I456f7c753a3f73e9d812db2e7a79c8de83b6cfec
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
22fb2053fe2bfe98376bf1a0e564f23ae9cecded 28-Jul-2010 Daniel Lehmann <lehmannd@google.com> Show contact after creation; refactor ContactEditorFragment.Listener

Change-Id: I1fcf45334196a3776ed187cfeb93334f88cee281
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
ef3f8f045ed4150caa64749742227acd0e6b85d8 27-Jul-2010 Daniel Lehmann <lehmannd@google.com> Replaced Google by Android Open Source project

Change-Id: I41bf58262c5524d19119aa767e6961a46c679611
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
3b7d5949bfa524534e5d1aa29b8eaff8733ae00c 23-Jul-2010 Daniel Lehmann <lehmannd@google.com> Make it possible for View and Edit to be in a Dialog

Change-Id: I55e0f3d9369e638651034131812a590984ff2282
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
3648d2ea76a6649230d1fdd3dba92797ae7cfb26 30-Jun-2010 Daniel Lehmann <lehmannd@google.com> Removed done and revert. Replaced instances of LinearLayout by FrameLayout for speed.

Change-Id: Idbf4cf14431ae66de7888432189492f5896693b9
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
f319cf8549738feca5965a598af9a310869e1f3d 26-Jun-2010 Daniel Lehmann <lehmannd@google.com> Use the form-based editor in a fragment

Change-Id: I461bc1842f5c9cf1d97f4ef285eb5d88c850134f
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
173ffe1300afa6a88a7f0a924adade121e564274 15-Jun-2010 Daniel Lehmann <lehmannd@google.com> More work on modal field editors

Bug:2680726
Change-Id: I6685fd6d20358bc2f83b2b81294106e86db0fcee
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
eb4d1bf9868dfddd958d8f028e36a4d2da7a8731 09-Jun-2010 Dianne Hackborn <hackbod@google.com> Follow Fragment API change: framework now handles menus.

Change-Id: I1bb8d4616e2b09a9c7139d4f4f5a5267c55c96e9
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java
cdef2b60aa87b1178033fdc964a3402386c03d7c 07-Jun-2010 Daniel Lehmann <lehmannd@google.com> Modal field editors

Bug:2680726
Change-Id: I167b02c50653abfa22ed72023993c9dd31f752a9
/packages/apps/Contacts/src/com/android/contacts/activities/ContactEditorActivity.java