| d0cf37c2c9c5a1ff888bc3e853f6115467dae5b9 |
|
08-Nov-2011 |
Makoto Onuki <omakoto@google.com> |
Phone: Delay-create search fragment
In order to take full advantage of the new "fragment deferred start" feature.
Now we create the search fragment in the first onLayout call, which is after
all other fragments are created.
Bug 5550646
Change-Id: I2e3710fb4ea6ff4301309538dd58bdef5811bc8b
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 9bd59f27cc5ad318b4bb78fc0576604e57f0b7a6 |
|
07-Nov-2011 |
Adam Powell <adamp@google.com> |
Follow framework API changes.
The Fragment#setStartDeferred method has been removed in favor of the
new setUserVisibleHint method. Update Contacts code that was using the
previous API in progress.
Change-Id: I9800a2c01f5343e4e732fb4649004f492c28ee97
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 18e2b6f48045eebd802ff560420e1ad19b2e2da8 |
|
01-Nov-2011 |
Katherine Kuan <katherinekuan@google.com> |
Check activity state before showing phone disambig dialog
- This is a monkey bug on Crespo that happens often. The
monkey is likely tapping on a favorite contact in the Phone
app, which is trying to either dial the contact or
show a disambiguation dialog if the contact has multiple
phone numbers. There's an IllegalStateException with trying
to commit the dialog fragment transaction because the
saved state has already been called.
- After a PhoneNumberInteraction is started, a CursorLoader
is started, and when that returns, potentially we try to
commit a FragmentTransaction (showing the DialogFragment).
At this point, the activity may be long gone, so we need to
know if the activity has saved state or not. Hence,
we add a new base activity class (TransactionSafeActivity)
that keeps track of this information for us.
- The PhoneNumberInteractionTests still rely on passing in
a context to PhoneNumberInteraction (in order to check
that the queries and subsequent activities are correct),
but we typecast the static methods the app uses to
create these PhoneNumberInteraction objects.
Bug: 5132436
Change-Id: Id9d887bd55235b07133568a38d4922dc7fce24a7
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 557984daeba92a4e36d6cd0eedf2fba0abfb24a1 |
|
29-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "Defer phone search fragment" into ics-mr1
|
| 36da3e799e4612edeaf6bf1bfea0800621c9b253 |
|
29-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Defer phone search fragment
Bug: 5534082
Change-Id: I2f604c63af8221c363a0ea8425d57f41e3a99c75
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 5a30a6d9aec74bf28b389b787ca5809bcb89822d |
|
28-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Delay SearchView preparation
Bug: 5530471
Change-Id: I1fe143c3a32b75f0e1e313f403db7564be76ac14
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 34b901ca7781cf7fdd4f6275ef98ae73c95749c2 |
|
18-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Filter and header refactoring.
- have AccountFilterUtil to unify account filter implementations.
- modify account header on top of search screens
Now it is bigger than before (40dip > 32dip), and uses people's
blue text color instead of gray (issue 5451033)
- introduce ContactListSeparatorTextViewStyle and use it everywhere
Bug: 5269692
Bug: 5451033
Bug: 5429203
Change-Id: Ibe810ff9adaafc74d53b0dcf171a3853f4be039a
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 1db00f68b34f6cf7e9d19fedb559cf12f8c05e9c |
|
19-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Fix the double query issue on phone
The issue was that fragments had separate methods for search: setSearchMode()
and setQueryString(). But now that fragments will never be in search mode
when query is empty, there's no need to expose both methods.
Changed setSearchMode() to non-public, and let setQueryString() call it
when necessary, so now we don't have to issue unnecessary queries.
Note this CL doesn't modify adapters, so they still have setSearchMode()
and setQueryString() as separate, public methods.
Also did a bit of cleaning up on how PeopleActivity handles search mode.
(When I worked on it first time I wasn't too familiar with the code, so was
afraid to change existing code too much, which left the code unnecessarily
complicated.)
Also removed all fragment.setSearchMode()/setQueryString() calls in
ContactSelectionActivity.configureListFragment(). As far as I checked
there's no way to invoke this activity with reqeust.isSearchMode/getQueryText
set.
Also removed ContactEntryListFragment.get/setContactRequest, which weren't used
anywhere.
Bug 5274171
Change-Id: I794db7ed54cb6b8f45d69430ec2f77e7fa83fb8c
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| a012aec6f22dd6a37c518c895db45b173e186ef4 |
|
16-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Make a Singleton for ContactListFilterController
Better fix for issue 5165507 "Contacts to Display filter loses its
setting when going from People to Phone app". Now the whole app
has one instance and People and Phone UIs share it. All notification
will be delivered to both Activities, and thus no hack on onStart()
will be needed.
Also fixes issue 5299160 "Account filter header not updated when account
is removed from device". We need to update filter after
AccountTypeManager finishes its reload operation.
Now filter settings should be saved only from the controller, so this
change removes the code saving filter settings to SharedPreferences from
Activity/Fragment.
Bug: 5165507
Bug: 5299160
Change-Id: I4118271f1a78976af6cb3d432b1dd7b30c18eb7a
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 9679e44ab946e3c822b7a733f1a998a5cbbfc2b5 |
|
13-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Use "all contacts" icon for favorite tab
Bug: 5443416
Change-Id: Ibbad768ae88341ea1d0ef5d26285a2130bbc25d2
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 7e8372e5fe33ff7252c79b7de7d55b4885074c8c |
|
12-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show previous tab after phone call in phone search
Previously we've shown calllog when users called from
phone search screen. Now this change navigates users to
each tab (phone, calllog, favorite) when phone is made
from phone search.
TESTED:
incoming calls
-> go back to calllog
outgoing calls
- make a phone call from dialpad -> go back to dialpad
- make a phone call from favorite -> go back to favorite
- make a phone call from calllog -> go to calllog
- make a phone call from call detail -> go to calllog
- make a phone call from People UI -> go to calllog
- make a phone call from dialpad and launch Phone UI
again during the phone call -> go to dialpad
(previous commit log says "go to calllog", but it looks
wrong)
- make a phone call from contact card (reached via
phone favorite) -> go to calllog
- make a phone call from dialpad or favorite, bail out the
in-call UI. Have the recipient hang up the call.
Then have an incoming call again. Hang up the second phone
call.
-> go to calllog
(new)
- make a phone call from search UI launched from dialpad
-> go to dialpad
- make a phone call from search UI launched from favorite
-> go to favorite
Bug: 5360106
Change-Id: I58f0e7160896bed5eae7d2bd8c7739712d6c681c
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 5db4f136163675105813900b1f3f7da48bde97b6 |
|
10-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
[Phone] Fix layout for phone favorite screen
- Have additional padding between headers
- Use blue color for filter header in phone favorite
- Have bigger texts for A-Z section header
- Have photos on left in "phone search" screen
- Add "New Contacts" menu in favorite screen
Because LayoutFilter isn't ready on Fragment#onAttach(),
we need to have initAdapters() on onCreateView(), which looks
strange. However it will need much work to move every layout
logic to PhoneFavoriteMergedAdapter, let's just have a TODO
for that.
Bug: 5432231
Change-Id: I19b0849a6ec1fd38bec259859753dab13b88cc12
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 9b9104874ec0680ac60cb0527d127fc1c34bdb7e |
|
30-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
[Phone] New phone favorite tab.
This change introduces yet another fragment for a special
"phone favorite + phone all" screen and uses it as Phone UI's
"Favorite" tab instead of using ContactTileListFragment.
The new fragment merges two adapters into one adapter called
PhoneFavoriteMergedAdapter. To keep layout consistency between
two adapters, the new adapter tweaks original Views on demand,
especially paddings for those Views.
Now that "favorite" screen contains "all phone" section, we should
treat previous "all phone" screen (PhoneNumberPickerFragment) as
"phone search" screen instead. To do that, this change also replaces
"ALL CONTACTS" strings/icons with "search" magnifying glass icons.
IME is now shown up upon the search button click again.
Bug: 5359840
Change-Id: I04cb2433882d74f1e826c02991a5a54c3be993ab
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 17c62974608af9b34908c4a14194d53fd89cca6f |
|
27-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Use CALL_ORIGIN flag
CALL_ORIGIN flag allows Phone app know where the phone call
request comes from.
TESTED:
incoming calls
-> go back to calllog
outgoing calls
- make a phone call from dialpad -> go back to dialpad
- make a phone call from favorite -> go back to favorite
- make a phone call from calllog -> go to calllog
- make a phone call from call detail -> go to calllog
- make a phone call from People UI -> go to calllog
- make a phone call from dialpad and launch Phone UI
again during the phone call -> go to calllog
- make a phone call from contact card (reached via
phone favorite) -> go to calllog
- make a phone call from favorite and add another
person to the phone call via in-call ui
-> go back to "favorite" (undetermined behavior actually)
- make a phone call from dialpad or favorite, bail out the
in-call UI. Have the recipient hang up the call.
Then have an incoming call again. Hang up the second phone
call.
-> go to calllog
Must be after I4d5f825f7d5109c6ff8c27b6e53a31ca9e6b832f
Bug: 5360106
Change-Id: I7b88b245e82e96e150937ee53029d397a28a9b2d
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| e66b8d7609c5505dfdda7483ef1cfc18f6d074c7 |
|
15-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Merge "New avatars"
|
| ecfc26c3f9495f1a4efed69a1582ff2b0deb2c71 |
|
13-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
New avatars
Bug:5074147
Change-Id: I583d22c63a7b617567c523efeed292ae1e2be7e4
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 9ed91a9539b6f685b63784cdc84ac41ad14fd988 |
|
13-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
[Phone] Don't use custom shared preferences
Just use the app-wide default shared preferences, so that it'll read from the
cache rather than the filesystem.
The default shared preferences should be preloaded by
ContactsApplication.onCreate using a worker thread when Dialtacts needs it.
It was actually a strict mode violation causing something like > 100ms penalty,
but I assumed it was beacuse it was the first read and unavoidable.
I hadn't realized dialtacts had its own preferences.
I also fixed the social widget settings. Existing settings will all be
migrated.
Also fixed the log spew from SocialWidgetSettings.
Bug 5296990
Change-Id: Idb8e393ebfd6c77b14906ea4ee26dfd032da2770
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 7a330308196e8f75d6ec5e449a0dd28813cfc373 |
|
07-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "Make filter header clickable"
|
| 124e5cbea97366d4db1fa5ffe59efedd5913aded |
|
07-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Make filter header clickable
Bug: 5160689
Change-Id: If2f9435bf0090f8bfc138a45fe2c9c04eec08091
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| d0d5eaae0052140a1e993ec63c930b0309e36e3b |
|
07-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Use setContentDescription for tabs
Bug: 5249855
Change-Id: Idb0fa5c10713fedf87ee157166734b642514f33d
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| c897f0213aec9dc589ea81fe53ccee444101f232 |
|
26-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "Let Phone UI reload filter on onStart()"
|
| cbe05df145b800118f3ca45f61ea486fad1cca08 |
|
25-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Let Phone UI reload filter on onStart()
This is workaround for bug 5165507: Contacts to Display filter loses
its setting when going from People to Phone app
- call ContactListFilterController#onStart() or its variant.
Not calling it is an apparent bug in DialpadActivity
- instead of checking local filter cache, load it from preferences
every time, only on Phone UI
The root problem is that People and Phone UI don't share one
controller insntance and thus they don't receive the same
filter change event. When the user changes the filter in People,
Phone UI won't receieve the event, for example.
On Phone UI, back button doesn't introduce Activity#finish(), which
makes the whole issue more prominent in People -> Phone case
(set filter on People, and go to Phone), but it does exist in the
opposite case (set filter on Phone, and go to People). The latter
case causes the problem only when People is in background (with
Home button, for example).
This will fix:
- display filter change isn't reflected in Phone, when going from
People to Phone (what reported in bug 5165507)
This won't fix:
- display filter change isn't reflected when it is modified in
Phone UI, while People is in background (with Home button event)
(what caused by the root problem behind that bug)
A more fundementaly fix would be to share one single
ContactListFilterController, which would be more complicated and
a bit too risky at this point.
Bug: 5165507
Change-Id: Ie7968deb99c07597c35e3bb1531461f0a42c326a
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 4b25da79091157935042d2942a8961ceba92166f |
|
25-Aug-2011 |
Minh Pham <phamm@google.com> |
Change commit() to commitAllowingStateLoss()
- Following the pattern in Email and Gmail, we change all commit() to commitAllowingStateLoss().
At least this will stop the monkey ISE.
Bug: 5167769
Bug: 5179918
Change-Id: Ibee8380a0f854aeb30bc3c4359fb706faf4efb4b
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 6beadaeb0f159a150f62471a5c5f0b0463e46733 |
|
22-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show IME when search button is pressed.
Bug: 5189462
Change-Id: Ief5059ef9e28d28ac5c0117222e09643ea32bd69
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 2c1ba625efd310747bed10a180716ca82e09ef4f |
|
19-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "add contact capability for Phone UI"
|
| 18f5f79fa3991a864a17596fe14a04045a7540eb |
|
19-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
add contact capability for Phone UI
Also make edit screen exit to previous screen so that Phone UI
and 3rd applications won't confuse users with INSERT Intent.
TESTED:
* phones with/without a hard menu key
- Phone UI should have just one "create contact" menu on the right
place in the search mode.
- Phone UI should not show the menu outside the search mode.
- People UI should correctly navigate users using add/edit capability
* tablet
- People UI should correctly navigate users using add/edit capability
Bug: 5185218
Change-Id: Id8360aeb6ef99ef0d3ab2902e97c0bbe8f590c17
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 68ca6aa964ae356354615a3bbc19ea99b4597a4b |
|
18-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Hide unnecessary menus when launched via DIAL intent
ViewPager#getCurrentItem() returns "tabIndex" after
ViewPager#setCurrentItem(tabIndex, false), so we need to preserve
the previous value.
TESTED (using phone devices with/without a hard menu key)
- swipe actions do not corrupt menus
- tab clicks do not corrupt menus
- DIAL intent corretly shows/hides menus
- Menus aren't corrupted in Dialpad Chooser
Bug: 5118757
Change-Id: Id857a2d7ac5a007db65b20f80270a07ea527ba7f
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| b59500deb3a7cb7c681b1196ba9ccb57e4e2d83e |
|
17-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Get rid of an unnecessary member variable
Bug: 5131136
Change-Id: I7e02df8ea7ce553efd919cc41a1da97343c5605f
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| ad3e9d878ac1412568151182ebe94c41c2a91d37 |
|
17-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show filter menu on the right of SearchView when no menu button
TESTED:
- filter option menu shows up on the right side of SearchView
instead of being shown as an overflow menu when the device
doesn't have a hard menu button
- filter option menu keeps shown as one of menus when
the device has a hard menu button
Bug: 5131136
Change-Id: Ice630533cfd4fb13383958489549236f9229053d
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 766c5848b68aebc5500f82f998f7fdd9e866677c |
|
17-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "Suppress IME show-up on search mode."
|
| 0cd6f7319b11b210147f73d0f34f758a49a26897 |
|
17-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "Show call settings menu correctly when no hard menu key"
|
| 33a3023e9071af540fd5fbb32c6d09cf6234fdd1 |
|
16-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show call settings menu correctly when no hard menu key
TESTED:
- call settings is visible on every fragment (phone with hard menu key)
- call settings is visible appropriately (phone without hard menu key)
Bug: 5172892
Change-Id: I1d5c115f4f1ee0bdecf858789f648aa5b05c331c
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| f944adbf961e77c6d22767236efa47cecc3a5db2 |
|
17-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Suppress IME show-up on search mode.
- call SearchView#clearFocus()
- prepare the search view on onCreate()
Though SearchView itself tries to suppress IME on its clearFocus(),
ondemand SearchView creation forces IME show-up for some reason
(attaching it to ActionBar might be the cause of the harm).
Just creating the view every time on onCreate() avoids the problem.
It doesn't hurt performance or any other app capability much.
This change also removes some stale code for showing up IME, which
is needless anyway.
Bug: 5104943
Change-Id: I4c542b3d0cdc5287c9285493e8e5ed0ce25cb204
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| f4fbfdd4f283d2143b87bc6319cb13527b4fe8d1 |
|
15-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Remove DialpadActivity
It is never used anymore. We're using Dial*tacts*Activity for Phone.
Intent with "com.android.phone.action.TOUCH_DIALER" has been used
inside the Activity and has never supported it for external use.
We'll keep the Intent for now, but we won't support correct behavior
for it. Using android.intent.action.DIAL should do what 3rd party
app will want.
TESTED:
- app works as usual with DIAL intent
- all unit tests run correctly
- intent with TOUCH_DIALER introduces Dialpad screen in
DialtactsActivity
Bug: 5160191
Change-Id: I77d38fb3f7b51782fab3fee7b9e732f55ecf4654
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| d4ed72eb6610b1318545741140569a973c4ab452 |
|
13-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Use custom filter when filter isn't saved
- includes misc UI fix on tablet. width isn't set
correctly.
TESTED (needs the change above):
- keep contacts visibility after GB to ICS migration
- keep filter option between People and Phone UI
- keep filter option after People/Phone reboot (killing the process)
REMAINING ISSUES:
- Custom filter affects "All contacts" filter.
For example, if the user choose "All contacts" after showing
"Other contacts" using custom filter (in Google directory),
"Other contacts" will be shown (while it sholdn't).
"All contacts" should show contacts inside default_directory,
or at least it shouldn't be affected by previous custom filter
choice.
- Phone filter still shows "Other contacts" (with phones)
unxpectedly, which should be fixed.
Bug: 5153692
Change-Id: I5c8a9a51caaec967af66fd7840e45efe9802f283
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 231a6fb24a67f054641e7c7d21c487915d35f4ac |
|
15-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show the call option menu in Favorite tab too.
Now that all three tabs show that, we don't need to manage it
on each Fragment.
Bug: 5149475
Change-Id: I16e1fa2bfeb4bffa6b9e37e2583da3614fa367da
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 9d58f279befb457bdcb302085b62cd4e3279c777 |
|
15-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "Call invalidateOptionMenu() on onNewIntent()"
|
| a07abf7f425f2da7487d58851c10c30c03ebda91 |
|
14-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Call invalidateOptionMenu() on onNewIntent()
CALL intent is often used by the other apps or CallLog screen to request
dialpad screen (DialpadFragment), at which we should clean up previous menu
states prepared by CallLog or Favorites tabs.
Bug: 5148698
Change-Id: I4cee5a3abc92805353bf0a53fe68c062124cbac3
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 3b0c7db46d43dba4782ef9e04a2860fbcf730baf |
|
14-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Avoid NPE on hideInputMethod()
It happens when there's no focused view.
Bug: 5157908
Change-Id: I82e7d69b71f2e23274696a1d1a582f503ca80fcc
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| c36c75318f8e47679d5281b7de2a2b5295eede50 |
|
12-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Only call onVisibilityChanged on creation for the current tab.
When the fragment is initially attached, there is a call to
onVisibilityChanged, so that the fragment knows whether it is shown or
not.
Currently, we are calling this with true or false for all tabs (actually
only the DialpadFragment and CallLogFragment, as they implement the
listener interface). However, we do not need to be notified that we are
not visible if we are just being created.
This is needed because otherwise we will assume we were being dismissed
while in reality we were never shown.
Bug: 5157085
Change-Id: I37be7799b0e473cc2eabefef75a56335420979a3
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| cce61178a881b20f69b0249599a792d7dacef7ce |
|
08-Aug-2011 |
Adam Powell <adamp@google.com> |
Possible low-fruit optimization for DialtactsActivity.
Reuse generated fragments for the ViewPager once created.
Change-Id: Ic3a2b421814fc576c8bc9d51e95697208667df4e
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 8f59c2b18b73df6af3c808802620839f0a6a61d4 |
|
04-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Reflect recent UX design changes around filter capability
Include several related changes
- introduce filter option in phone search
-- have limited filter support in PhoneNumberListAdapter. There's
no easy way to share the logic for filtering as People UI
is taking care of Contacts/RawContacts table while Phone UI
needs to take care of Data table, though we may be able to have
some utility library for filter operations.
- have additonal layouts for filtered phone search. Along with it,
also introduce some pixel-perfect design for Phone/People apps
both for phone and tablet
- add "up" capability for CustomContactListFilterActivity
- launch CustomContactListFilterActivity directly from
AccountFilterActivity instead of relying on
their parent Activities (PeopleActivity and DialtactsActivity).
-- In the current structure, IME is shown during migrating
from AccountFilterActivity to CustomContactListFilterActivity
"only in Phone UI", as SearchView temporarily has a focus
FUTURE TODO:
Currently devices without hard menu key show overflow menu in
Phone search mode, while we want soft button on the right side
of search view.
Bug: 5104984
Bug: 5081251
Bug: 5121569
Change-Id: If935f13b33b105884a914b207fd096588825226e
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| a5ed6df7d3702e648075204b790cf15dcd98a6e6 |
|
03-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Hide search view before showing the other views
Bug: 5105154
Change-Id: Id03a7753e77e8d19761dbfc8268a34bb82c97af9
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| b15498a22a1b4dae0fc4be681f7b63d1d7dab1eb |
|
29-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show DialpadChooser correctly.
We need to make DialpadFragment to handle a new Intent
via onNewIntent(). The code was once removed in
I3b2f95b0d34e89bb9665b2014048a634d29e54ce because of possible
NPE. This time we avoid it by just using "if" clause.
Set DialpadChooserAdapter anytime when it is required. Now
Fragment can be reused with onCreateView() (when users' swipe
action), at which the adapter can be available though
the chooser view is recreated.
Modify DialpadFragment#resolveIntent() so that it is
easier to understand. Rename it to configureScreenFromIntent(),
since it is only about its screen state now.
Remove some logic around dial uri handling. Now DialpadFragment
gets the uri directly from Intent instead of parent Activity, so
there's no need to keep it inside DialtactsActivity.
TESTED:
- Launch "Phone" with no calls active
- Make a call, press the "Add call" button from the in-call UI
- Make a call, bail out of the in-call UI without ending the
call, launch "Phone" from the home screen. Play with swipe,
exiting dialpad chooser screen several times
- Launch "Phone" from the other app with a phone number Uri
Bug: 5087992
Bug: 4983278
Change-Id: I5fd687daccf15f632219925a4846019594beec0a
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 3792cc74f8a1a55a04af72508b70d7f3281a5eb6 |
|
27-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "Make search behave correctly"
|
| d04768a41fc0c1918eec625fb61e3c8b90719b13 |
|
27-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Make search behave correctly
- call setIconifiedByDefault(true) and setIconified(false) to
show magnifying glass icon inside SearchView's edit text
- manually call onActionViewExpanded() on entering search mode
and onActionViewCollapsed() on exitting the mode to make
SearchView work correctly with its close button
-- Those should be called automatically if we let search view
menu item do that, but because we're using custom layout,
we need to do that manually.
- clear focus and hide soft key when the user presses "done" button
on soft keyboard
- ignore close event when text is empty, to prevent recursive
exitSearchUi() call
Bug: 5080181
Change-Id: I4b603cca8e3051a247a858573ec3f6d631d75ec0
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| f6828029b127f60d758bf30052989d64f50cfa86 |
|
25-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Implement smoother swipe animation for Phone UI
Phone UI conditionally shows split ActionBar on the bottom,
which makes swipe animation less smooth. This change makes it
smoother by reducing layout re-calculation.
- stop changing menu state on onPageSelected but do so on
onPageScrollStateChange.
- use android:windowActionBarOverlay to suppress recalculation
during menu show-up
- add marginTop to every fragment for Phone so that fragments
won't overlap with ActionBar
- add paddingBottom for CallLog and Favorites so that those
fragments won't overlap with split ActionBar
FUTURE TODO:
We need custom assets for android:actionBarStyle
- android:background
- android:backgroundStacked
- android:backgroundSplit
Bug: 5022052
Change-Id: I3bd48cf9d8aaa398806531823fca63de328b807a
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 0cd85b36f08bac6f7c72e1465b52a1d0d8a7cb3b |
|
26-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "Set CLEAR_TOP for "HomeAsUp" button in phone settings"
|
| 6a3515380fb0658c7e07c3569054646b8473fa3e |
|
25-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Enable smooth scroll on tab select
Bug: 5073629
Change-Id: Ie92c01ee11ddfad756e918bc0dee364f7eb125bf
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 147618fa21a2ed187e79aa2eb0414d5f9170310d |
|
22-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Set CLEAR_TOP for "HomeAsUp" button in phone settings
Change-Id: I1d833c18f871f08b4235fc633f4ee615a4d1024d
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 37efa3aeea2e26fdee640b797efc39279500c4da |
|
19-Jul-2011 |
Frank Sposaro <sposaro@google.com> |
Added empty states for ContactTileList.
Change-Id: Id1f90d994059f6ba8193129e7e552a632516364d
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 0c07935a3d838ed24db7d20df839be97fe4c625a |
|
19-Jul-2011 |
Frank Sposaro <sposaro@google.com> |
ContactTiles are using new phone only Uris.
Bug: 4904403
Change-Id: Ib597ceee7f26ca77f8e5f050bfbfccd421a675a5
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 7979ea27c046dfc2d9305b3282233046acef6ec4 |
|
15-Jul-2011 |
Frank Sposaro <sposaro@google.com> |
Enhanced performance in ContactTileAdapter.
-Contacts Load faster because now saving cursor and not copying into ArrayList.
-ContactTileLoader factory performs more optimized queries.
Bug: 4901406
Change-Id: I91902a99252e99db081d4437066a74f9fa21f5d1
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| c7457855f3baa28ff43bd8013664e789f176f4bc |
|
13-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Disable highlight
Holo dark made it annoying.
Bug: 5022254
Change-Id: I2b4bf47c7b3e91626523a22a29a86232bb15f042
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 9e095d2ffc4a94d2fb925d19df6db12bc2b1e124 |
|
08-Jul-2011 |
Frank Sposaro <sposaro@google.com> |
Added QuickContacts.
Change-Id: I0bf3b536da73c2f9862a958ff0275ef8404def4f
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| bd762dc826d85e5b7db634ef14a0dbb70c42eaab |
|
06-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Introduce overflow menu button
Available when there's no hard menu key on the device.
Also remove Call Settings menu from favorite screen.
Bug: 5001942
Change-Id: Ib0ff3fb15a26001dbdad4756bfa4e4bfe1652da2
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 2c1f7878d72184a56e9c2b0d9f4d74be439979c2 |
|
06-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
append final
Change-Id: I3ba98a0a0aedf1e9fda8e3592ec72362032509cc
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 43105d0b04963ac96acc1fa7f97278f927f48948 |
|
03-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fix possible menu-not-shown/search ui not shown problem
Fragment should not be managed by its parent Activity but by
FragmentManager.
- use onFragmentAttach() to tolerate Fragment recreation
- Stop caching Fragment in Activity as much as possible.
- move "Call Settings" to Activity-wide options menu
- make PhoneNumberPickerFragment tolerate NPE on
setNameHighlightingEnabled() call
Change-Id: I06a748ea1a618f0fa83ef3c8f99653effc37895e
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 87e324c46ea0c9034fd1cf5a884ef2b2cb9c2c7a |
|
01-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show quick contact in phone search UI
Change-Id: Ibc643162b9c74964b1b9e9bd89351203fb29d6b6
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 88f70fc83cdd119e85d9890b2875faf5c981b47d |
|
01-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show app icon on Phone search UI.
Change-Id: I2c09ed6635b27042c7c98bb40c41fa1724e533db
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| aa72f08effc0b2bac7c56dd2fed9bbeae3a6f109 |
|
01-Jul-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Add the search button in CallLog/Favorites
- Use ActionBar's split style
- Maintain swipe/tab-select behavior correctly
- remove old menus and add search menu item
- use xml instead of programatically adding menu items
Change-Id: Ibb00ae0f33d3a42b72c238f4d1d9a3fe0ea31562
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 862c0230cf03b05f97a673abdc525cdc5ced98bb |
|
30-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Merge "Support horizontal swipe in Phone app"
|
| 438e1f19279ea058e145c84dbe3ba62cc14df645 |
|
29-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Support horizontal swipe in Phone app
- introduce ViewPager for swipe support
- let DialpadFragment call resolveIntent() by itself
on onCreateView()
- remove ContactsFragment (a.k.a previous "3rd" tab)
- remove resolveIntent() call in onNewIntent()
-- This was introduced to fix bug: 4724464 but we cannot
do same thing anymore, as we cannot assume views in the
Fragment is ready at that moment.
- remove some codes coping with old tab behavior.
-- After having the ViewPager, we cannot simply assume
Fragment is a replacement of previous tab activities.
Fragment creation is delayed by ViewPager, so some of
old codes causes NPE.
Bug: 4974874
Change-Id: I3b2f95b0d34e89bb9665b2014048a634d29e54ce
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 36c33609482ae5c961ac5f3b67c581a0bb430f38 |
|
30-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Add comment about keyboard showup logic.
Change-Id: I53ae005377479da5d7365d7421fbc2a07049a55f
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| f4e5dfa30a752ec785b2eecee21c2b620104def2 |
|
30-Jun-2011 |
Amith Yamasani <yamasani@google.com> |
Merge "One way to make the keyboard appear on starting search."
|
| c18f9b7cb0846d0c10fe0398224b53530a2194ec |
|
30-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show incall UI correctly.
Change I39f9b042990c7c1136fd7471cd292d5a679505cc removed what we
need. In GB we explicitly used phoneIsInUse(), so using it again
would be appropriate.
Also use "inverse" color so texts should be visble at least
Change-Id: I401bcb25d1d75a4eda5c1747e724293e93d87d68
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| c5be9585f664a893392486e3f86c67f3e083f271 |
|
30-Jun-2011 |
Amith Yamasani <yamasani@google.com> |
One way to make the keyboard appear on starting search.
Change-Id: Ie76bf8e58fbf99025f803847ba091928a7a209e6
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| cfcd0764a1ec53c6014df9ce3e7d3a3da511599f |
|
29-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Highlight search texts in search result
PeopleActivity does it.
Change-Id: I2d4523ace783c2b622e0d0e0cd17fb61d1155c0a
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 20962611bd54c64c206351d53b51686081d89e53 |
|
24-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Remove contact tab.
- remove contact list tab on phone UI
- show search button instead of voice mail button
-- uses temporary assets
- remove some layout xml and have dimen values instead
Bug: 4691486
Change-Id: Iec028849fa65079ac7d76a64baf1590fd4537c37
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 350e8d53a135e0bb62308a93dd09777364c08a58 |
|
24-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Handle menu event correctly.
Right now after showing search UI, every menu cannot be available.
- make them available
- refrain menu in search UI
Change-Id: I4bf0056c9b404d43c2ab2ac0f227441c1147d09f
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 68f33150cf394279fc97f06ba5601482741147b7 |
|
24-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Focus last selected tab
"StickyTab" behavior needs more implementation. This mitigate
user experience a bit.
TODO: implement SticyTab behavior which had existed in GB
Bug: 4904820
Change-Id: I39f9b042990c7c1136fd7471cd292d5a679505cc
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| b2e626ad4fedc0fd726f66b9942d1b2f30d9cfef |
|
21-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Implement phone search in DialtactsActivity
Includes tiny layout fixes for ContactSelectionActivity,
which also uses the same phone search fragment.
TODO: let the other Adapters like DefaultContactPickerFragment,
EmailAddressPickerFragment support grouping feature.
Change-Id: I8d7718192522a0005b9b76931560fe297cad882f
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| b1f0e5e8a4de69bd80276742900441e930fa4c86 |
|
22-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show dialog if multiple candidates exist
In GB we show a list of phone number to call in Favorites
screen, while we don't now.
Also refrain PhoneNumberInteraction from showing a dialog
by itself but let a nested class do instead. showDialog() is now
obsolete and we should use DialogFragment instead.
Bug: 4743008
Change-Id: I202963c2f03424f07ee386bd9713fde4091a0ae2
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 5d96befd4cc61df08f89b83aa01b669765470315 |
|
17-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fill in phone number again on onNewIntent()
Bug: 4724464
Change-Id: I1ebaa29e497e88211936837e56418a744619f81d
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 5e684a424e7036ba3d379221d1889b4dd7265021 |
|
10-Jun-2011 |
Dave Santoro <dsantoro@google.com> |
Update references to ContactBrowserActivity.
The activity was moved to PeopleActivity - references in comments
and test were not all updated.
Change-Id: Ie01e514323a05c4316d4f42c9af75f7759434352
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 32f395567c9d103e9101c2549f76945c9dee20b5 |
|
06-Jun-2011 |
Frank Sposaro <sposaro@google.com> |
Redesigning how Favorite contacts are displayed
Changing to muli columns with big pictures
Change-Id: I582f4dae52229920b20d39b565a1a9fd84b28529
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| be18de05d6f6a107c552e369bce58f51c946fde7 |
|
07-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add group detail fragment on tablet
- Add action bar on GroupDetailActivity, title, and subtitle
- Make everything use the groupUri instead of passing around
account name, type, group Id, and group title
- Fix some of the callback listeners between the group fragments
and group activities
- Add factory methods to ContactListFilter
Change-Id: I63066ea6eefde1e57562b6396d6dc590ed023c84
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 9856fcee477d04f51bdbcbfdf632876c6b8a1173 |
|
01-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
New People activity
- This is part 1 of bringing up the new People app
- Rename ContactBrowserActivity and related XMLs to PeopleActivity
- Change Contacts to People app launcher icon
- Create new task affinity for phone app activities
- Get rid of ContactsFrontDoor activity because it doesn't need
to distinguish between Dialtacts and ContactBrowserActivity anymore
Change-Id: I8c5e1ed540b294c1bda85409ca1499f88d4459ee
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 00848d5b0cd3199fb91171936eb59db7c5e4b6af |
|
02-Jun-2011 |
David Brown <dab@google.com> |
Remove tab text in Dialtacts
Remove the text labels from the 4 tabs in the Dialtacts activity, leaving
only the icons. This allows all 4 tabs to be visible on phone-size
screens in portrait.
This is a short-term fix for ICS dogfooding. We *will* ultimately bring
back labels at some point, but the exact visual design is still TBD.
Bug: 4520620
Change-Id: I5ecb9a2034bdd4cbc54d298d1318ab6f2d7ed15b
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| aae838c5a7ef38f4f2778cff6dfaa1f650a44522 |
|
24-May-2011 |
Daniel Lehmann <lehmannd@google.com> |
Bring back the Strequent Fragment
Change-Id: Ib18bd1023c6f4ecd6bb6ec72eac68481ba815004
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 261cd5650d07fbc41ea8f19d4e422094612d1454 |
|
17-May-2011 |
Daniel Lehmann <lehmannd@google.com> |
Turn ImportExportInteraction into DialogFragment
Bug:3126133
Change-Id: I544d836b3c5d0e3c38352978d55a55e131885638
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| c15062754af08cadc50b4b8ec89c2175a4bec1fe |
|
13-May-2011 |
Daniel Lehmann <lehmannd@google.com> |
Use Fragments for tabs
This will require more work later, but it is a first step that should allow
all features to still be accessible
Change-Id: Iad544575960e6a8beb5f0018ae9a8b5633fe8281
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 285fdc6bed0f2bcfb95b4d5f8cf9066a4f8ab888 |
|
11-May-2011 |
David Brown <dab@google.com> |
Fragmentize the dialpad UI
Moved most of DialpadActivity into the new class DialpadFragment.
The old DialpadActivity is now just a simple container for the fragment.
TESTED (on crespo):
- Dialing an outgoing call
- Options menu (only visible once you've typed at least one digit)
- "Dialpad chooser" scenario (the special UI when you bring up the
dialpad while a call is already active). Note that text colors in
the dialpad chooser items are wrong; that'll be fixed by some
upcoming theme cleanup.
Change-Id: I8827727bb2bc86936c4ef23e1a307ac04141c1ea
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 9add0e5ef2a267acbe104e04f4cf6ab24cb8ba3e |
|
11-May-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add groups tab and show list of groups
- New groups activity, fragment, and adapter classes,
as well as and associated XML layouts
- For phone only, tablet UI is unaffected
Bug: 4409350
Change-Id: Ibeb592142e5ddc1efa5701472bbc72bde11d9760
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|
| 09fba0a6d82a7f88ce3c8cbb74eddd4bb96eb7e4 |
|
06-May-2011 |
Daniel Lehmann <lehmannd@google.com> |
Several renames for consistency. Should help with fragmentizing afterwards
TwelveKeyDialer ==> DialpadActivity
RecentCallsListActivity ==> CallLogActivity (be consistent with tab name)
Renamed xml files to have a clearer connection to the object that they
represent
Change-Id: Ie4f123dc03a445596e5ecc216adfef61275dbea3
/packages/apps/Contacts/src/com/android/contacts/activities/DialtactsActivity.java
|