| 4885a0250ad6720450c9809814b851b7039f5e17 |
|
26-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Use a plain String instead of CharArrayBuffer.
The code used to use CharArrayBuffer to store the numbers as they are
being processed. However, AbstractCursor.copyToCharArrayBuffer()
actually calls AbstractCursor.getString() and we actually instantiate a
new String when comparing the phone numbers: we might as well call
Cursor.getString() directly and avoid creating two new String objects
each time we need to compare numbers.
Empirically, this seems to reduce the run time of the addGroups()
method.
Bug: 5290401
Change-Id: I397a9e6a14657ce261f8b8c11e607b13083bdef1
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogGroupBuilder.java
|
| ffa8963f6d5d0fd672c11dea2c2d16048da36577 |
|
21-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Correctly match SIP addresses.
When grouping items in the call log, we were using the function to
compare phone numbers. However, this strips all non-numeric characters,
which means that all SIP addresses without a number in them will match.
Instead, SIP addresses are defined to match only if they are identical.
Bug: 5483719
Bug: 5390325
Change-Id: Ic6f1d55ccbd433cc6062ca803fcfd88ae4f68a8a
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogGroupBuilder.java
|
| de4f16aa0ff53c2756a3f9bf67ad7cb59b4d1aa3 |
|
13-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Clean-up after extracting nested classes from CallLogFragment.
A few fields were made package accessible: fix those up.
Also, move around a couple of interfaces to the most appropriate
location.
Bug: 5101753
Change-Id: I34af0dc6401874d9c8c71932bce239852d42f703
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogGroupBuilder.java
|
| 568ad27e706d7c75dd7412e34c2236c772704a04 |
|
13-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Extract nested classes from CallLogFragment.
This should help making the changes to the CallLogFragment easier to
make as there is less code around.
This has been done entired using Eclipse's refactoring with no manual
changes.
In the process, a couple of fields have been expanded from private to
package, because, while their were private, they were being used by
the parent/nested class anyway. I will fix those in a follow-up.
Bug: 5101753
Change-Id: Id46e18cfa86939100342daa020430063959dfcfc
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogGroupBuilder.java
|
| 6fb088eca53d723edb4ea0803751eff484c9ae8b |
|
20-Jul-2011 |
Flavio Lerda <flerda@google.com> |
Updates grouping behavior for the call log.
We are now using the following policy:
Voicemail and missed calls are grouped with following missed calls (not
voicemail) from the same number.
Incoming and outgoing calls are grouped with following incoming or
outgoing calls from the same number.
Bug: 4968671
Change-Id: I304baca0c02e10e9cbee1c9b01a573e28738fa2a
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogGroupBuilder.java
|
| 7533282d831b5adb59d2e579ba9901535288bd89 |
|
19-Jul-2011 |
Flavio Lerda <flerda@google.com> |
Add tests for CallLogGroupBuilder.
These tests are not extensive as I am going to change the actual
grouping logic in follow-up, so I kept these limited to really simple
cases that will not change in the follow-up.
Change-Id: I830f47c297abb783247696a4f65f569b74282e43
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogGroupBuilder.java
|
| 92a26f3d90c3ef3fd24e45d6c6d594ea57054427 |
|
19-Jul-2011 |
Flavio Lerda <flerda@google.com> |
Move logic for grouping phone calls into a helper.
Change-Id: I85e3fce30743ca956f90d11ab755754e820b9b15
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogGroupBuilder.java
|