| f8ce15cc8a76ff536e1b5b19163589176adde58f |
|
03-Nov-2011 |
Makoto Onuki <omakoto@google.com> |
Fix bug 5563362: failed to initialize external account type
The contacts.xml parser has had a bug that it processes each ContactsDataKind
tag twice,for START_TAG and for END_TAG.
When processing for END_TAG, because an end tag doesn't have attributes
it created an empty DataKind, with null mimetype. (This bug existed even
before the EditSchema change, meaning MR0 still has this issue.)
Before MR1 this null mimetype was just not used anywhere, so it was okay.
But in MR1 we have the duplicate mimetype check, and it will complain
if a contacts.xml has more than one ContactsDataKind therefore has multiple
"null" mimetype definitions.
Made sure to only process for START_TAG. Also cleaned up existing code
with a similar check.
Also included the package name in the error message for duplicated mimetypes.
Bug 5563362
Change-Id: Ib68fb0dca03784c4d7976ac8bf68b1dce5305b03
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| c641e62225a253373c08cdd9e3144df090162b60 |
|
08-Nov-2011 |
Makoto Onuki <omakoto@google.com> |
EditSchema: add mandatory check for "name" and "photo".
- The editor works fine without other fields.
- Also added test for missing supports* attributes for the name kind.
(for now, all the support* attributes must be true. Otherwise the
editor may not work properly.)
- Also fixed the default value for the support* attributes, which was
mistakenly set to true.
Bug 5578679
Change-Id: Iec5412feb3aa671b64f74d850ccf67daaa87c88e
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 86ccb6ce2ff6078b06add93aab489951ef83bc72 |
|
19-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Follow up to EditSchema parser
- Now AccountType.addKind() throws DefinitionException instead of just logging.
- Now the test contacts.xml (= test_basic_contacts.xml) defines "event" and
"relationship" DataKinds too. BUA should be able to copy this file.
- Added another xml, contacts_fallback.xml, to the test apk.
This defines what's equivalent to the fallback type. Unittests load this file
directly and compares the result to the fallback account type.
- Cleaned up existing account definitions in order to make sure
contacts_fallback.xml is really identical to the fallback type. This includes:
** Now structured name, display name, phonetic name, and phone DataKinds
all have 'kind.typeOverallMax = 1'.
** The "assistant" phone type is no longer a custom column. It's only used for
the fallback type and I don't think it's too critical.
- Also, NameKindBuilder no longer re-order phonetic fields, because no
other account types do this. In the previous CL I did it because I thought
that'd be more "correct", but on the second thought it's probably not a good
idea to make too many non-critical changes at this point.
Bug 5381810
Change-Id: Ie6a4eb3b876ab22a3dcdb6a9c278e387f8166125
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| dcf751d75ad5d31620a4216d8c53fd59525e8bd8 |
|
18-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
EditSchema parser for ExternalAccountType
This also includes:
- Removed getHeaderColor/getSideBarColor from AccountType
- Implemented a test authenticator/sync adapter in the test apk.
This defines a test account type "com.android.contacts.tests.authtest.basic".
We could potentially add more account types to the test apk to test different
edit schema variations, but at this point this is impossible, as
ExternalAccountType doesn't have a way to tell which contacts.xml belongs
to which account type. The current contacts.xml defined here builds
the fallback account type equivalent.
The sync adapter is pretty rudimentary; it doesn't clear the isDirty flag
on modified raw contacts or delete raw contacts with isDeleted set. At
this point this doesn't seem to be necessary to test EditSchema.
Note:
For now it's still not meant to be public API. Right now it's only manually
tested with the edit schema defition in the test apk described above.
Bug 5381810
Change-Id: Ifefdb969b4e08775125924b1366d24effc4db2f2
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 50a27b70581b0191995969c63edd1f6a3db3d1b7 |
|
07-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Clean up account definition
Removed:
- DataKind.isList. Use typeOverallMax = 1 instead
- DataKind.textAppearanceResourceId. Always use medium
- EditField.isFullName. Wasn't used.
Bug 5381810
Change-Id: I5ff109c075a5edb80ff97737432c78589570a1ea
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| ee05dcdd4b066ad909322c10919fb1812214673b |
|
06-Oct-2011 |
Katherine Kuan <katherinekuan@google.com> |
Cleanup of chat capability icon and primary icon in DataKind
- Add content description to chat capability icon for
accessibility
- Remove primary icon from DataKind because we don't display
it anymore in the UI (it's an unused field since we only
display secondary action icons now)
Bug: 5416674
Change-Id: I6587dd9186af68b0e794d3e73cbc3dad9fdac332
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 96e87fd6e808e9d853263ffeb5104f3253a18639 |
|
21-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
Use existence of editor as indicator whether source is editable.
Bug:3093621
Change-Id: I3ba344667ce1b0f2da6847d783c0ac90f36ebd8f
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 9db59fe67d9f2624120c718499a74eab7fea3c03 |
|
06-Sep-2011 |
Katherine Kuan <katherinekuan@google.com> |
Alignment tweaks in contact editor
- Multi-line address edit text field should now be
aligned with the spinner beside it
- Other misc alignment fixes
Bug: 5250070
Change-Id: I92b4b0d13cd1346227b95e7326a1c37ec68b066d
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 2cb71bd0d6096f48d9d8c6d66a753b164468abb2 |
|
01-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Fix contact editor account header
Bug: 5179920 Google+ profile should say "My Google+ profile"
Reverted default account type name changes
Flipped account name and type usage that was wrong
Vertically aligned the headers.
Change-Id: Icc279fcba5d426d1afaf32b59bec30ed5d739907
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 63f80f8f1235110354f0413ad2bf09bca332b7a0 |
|
30-Aug-2011 |
Daniel Lehmann <lehmannd@google.com> |
Merge "Use framework style for section headers and visual tweaks"
|
| 66c1ae914fa8e71ff6ca0a5c9659ad760b5a5484 |
|
25-Aug-2011 |
Mindy Pereira <mindyp@google.com> |
Swap local profile string to corrected string.
Fixes Bug:5179592 Local profile card string should be "My local profile"
Change-Id: I5b75cfba12978765a87e37ceaeafae96cca9b03d
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 5a7b563bdf571ebc14a1fa5f91f9a393948461cf |
|
09-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Use framework style for section headers and visual tweaks
- Use list separator style from framework for the blue headers
in our app (frequent header, recent header, kind type headers)
--> this allows us to get reduce the number of views in our
view tree because the divider is now an asset and part of the
TextView background.
- Adjust padding so it lines up with the new headers now
- Minor visual tweaks
Bug: 5136189
Change-Id: I7b10cc7e608b809d1a97ad8d8c59e31ab9d77e11
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 1792b08c500ed528e7d21401affd936b3a7b3dc6 |
|
24-Aug-2011 |
Daniel Lehmann <lehmannd@google.com> |
Fix various Quick Contact visuals
Also fixed a bug where the secondary action can be tapped even though
it doesn't exist (crashes)
This also fixes pushed states, which have been filed a couple of times
Bug:5137515
Change-Id: I810d12a79f0088a0770a0eaf9225fe7906ebd8e7
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 6cb8be1e8b92ec2713010b068fbaf47d89372c98 |
|
05-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
New assets for action bar
- Plus other miscellaneous assets
- Modified some files to reference the new assets
- TODO: Clean up unused assets again
Bug: 5121276
Bug: 5128825
Change-Id: Ib3996bfefc58c02cbf81a32dea890beb9711d935
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| edb576aab33efff623691a89ace3c76cb2ff12d1 |
|
28-Jul-2011 |
Daniel Lehmann <lehmannd@google.com> |
Implement new QuickContact design
- Also removes default-functionality
- Fixes the flicker when dismissing (Bug:5025418)
Change-Id: I46cf0fbdb2dcbf002612672e5e8f81a9b1ab6939
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 2179037e606ef55fa2d6bfa009371eaa522906f1 |
|
25-Jul-2011 |
Daniel Lehmann <lehmannd@google.com> |
Show type OTHER again
Bug:4689649
Change-Id: Ia513a3be6cb1a6ede92533afe430c8b1ad1d845f
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 398e3805b4278310250e5fd1007e2e73b9453d0f |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix "Add new" strings in contact editor
- Instead of using type-specific strings like "Add new
phone number" just use "Add new" since we have labels
for kind sections now.
Change-Id: I0e386ae29330193fec18b62f3949c46e095a872c
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| a66642330b5c4a62c8b7ce438ccff57c3b017eb1 |
|
21-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Show more fields above the keyboard in contact editor
- For the phone
- Small visual fixes that will allow as many fields as
possible to be visible when the keyboard is up
* Smaller icons, fonts
* Change some colors
* Remove the "+" icon
* Make address field default to min height 1 line
instead of 3
Bug: 4382255
Change-Id: Icc665c866e4c1cfaa0ba8de7dae9a0c1cbd1b575
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| fd33cc3ab956222dffa6b669a13a614747a5cdff |
|
26-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add flag to AccountType for ability to edit group membership
- Needed for the group editor feature (upcoming CL)
- Only Google and Exchange group membership lists can be edited,
all other groups from other sources are not editable (for ICS at
least)
Change-Id: I8f2ab08a6ff0cebcce0b182e4793dfbc645a5412
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| da5bf1cf60beef3de5e651a569fa544293683926 |
|
03-May-2011 |
Dave Santoro <dsantoro@google.com> |
Modifications to bold contacts' first names.
For lists and headers, this is calculated by using a similar technique as we
use in the list view for highlighting text when the sort order and display
order do not match - we look for the overlap point between the display name
and the alternate display name, and bold the leading or trailing part, based
on the display order.
For the edit view, we convert the display name into a structured name (via an
API extracted from the structured name editor code that calls into the provider
to handle splitting), and then bold the span corresponding to the contact's
given name.
This also fixes an issue with the alternate display order in which we weren't
honoring that preference on the contact details view.
Change-Id: I6af048725541996cb303810a56a1ad79fc276e11
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| a2d4a9652fb4db9ee222abc7a637366c6c50427c |
|
07-May-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix font sizing and spacing in editor
- Remove name labels
- Remove extra divideres
Bug:4382255
Change-Id: I59c5b91e699b7386690e6df58e58b247d3086c99
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 2591436971bad3050c85929c8e0c5a8d48111f88 |
|
30-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix "add field" logic
- Only update "add field" footer when field goes empty --> non-empty
and vice versa, fix the case for 4 line addresses in Exchange contacts
- Add property in DataKind class for "add field" string
- Remove hash map of mime types --> string resource IDs in
KindSectionView
- Remove "add internet call" string
Bug: 4363151
Bug: 4371568
Change-Id: Id2fec743a7c3e68d8404591cc61de20487245b0a
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 5ec40b04041818bc042c0671cb1a43b54f650e25 |
|
02-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Modernizing phonetic name support
Bug: 3497894
Change-Id: I5aaa77275bbe1921af2d7ef034d2319691f8abf7
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 27e78563c1f04490ffa8b850a0442715482d1f2c |
|
14-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing order of phonetic names in contact editor
They should unconditionally follow the family-middle-given order
Change-Id: I23405198afdba459a4c97f16143be0600963bb02
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 1dc28bef7d5353310359c3711b6cdac390d8a2e0 |
|
11-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Restoring full functionality of no-account contacts
Bug: 3339401
Change-Id: I2c185ee6e1189b89fce875f59b55ccd68edf6313
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 4597c92d655d45447780b32c7572acef110b6ed1 |
|
15-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming BaseAccountType to AccountType
Change-Id: Iff47bac0e1a118f4a5319526304df16cb89bd0cd
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 392ccec3b56e8074a5a028af28106134b39f64bc |
|
02-Nov-2010 |
Daniel Lehmann <lehmannd@google.com> |
Provide support for events (birthdays)
Bug:3134950
Change-Id: I9194dca403496a6f3a72bb45f69b16d8f530b15d
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 0540f8b74a44f5d1da519cc54e598d75f0e572dd |
|
29-Oct-2010 |
Daniel Lehmann <lehmannd@google.com> |
Support the contact field "Relation"
Also removed the "secondary" flag (was unused)
Also removed the inflate function from GoogleAccountType (was doing exactly the same as the base class)
Bug:3134946
Change-Id: I587e96e61ef15d8c87ac8749c852caa3138aeb60
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|
| 35769b804fbfd5a1fc0b2c36cd0a786d662c4334 |
|
19-Oct-2010 |
Daniel Lehmann <lehmannd@google.com> |
Renamed Sources to AccountTypes
Change-Id: I088c7d9cd66fd4d38e93bc97a6644247f72037ef
/packages/apps/Contacts/src/com/android/contacts/model/BaseAccountType.java
|