| 86ccb6ce2ff6078b06add93aab489951ef83bc72 |
|
19-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Follow up to EditSchema parser
- Now AccountType.addKind() throws DefinitionException instead of just logging.
- Now the test contacts.xml (= test_basic_contacts.xml) defines "event" and
"relationship" DataKinds too. BUA should be able to copy this file.
- Added another xml, contacts_fallback.xml, to the test apk.
This defines what's equivalent to the fallback type. Unittests load this file
directly and compares the result to the fallback account type.
- Cleaned up existing account definitions in order to make sure
contacts_fallback.xml is really identical to the fallback type. This includes:
** Now structured name, display name, phonetic name, and phone DataKinds
all have 'kind.typeOverallMax = 1'.
** The "assistant" phone type is no longer a custom column. It's only used for
the fallback type and I don't think it's too critical.
- Also, NameKindBuilder no longer re-order phonetic fields, because no
other account types do this. In the previous CL I did it because I thought
that'd be more "correct", but on the second thought it's probably not a good
idea to make too many non-critical changes at this point.
Bug 5381810
Change-Id: Ie6a4eb3b876ab22a3dcdb6a9c278e387f8166125
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| dcf751d75ad5d31620a4216d8c53fd59525e8bd8 |
|
18-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
EditSchema parser for ExternalAccountType
This also includes:
- Removed getHeaderColor/getSideBarColor from AccountType
- Implemented a test authenticator/sync adapter in the test apk.
This defines a test account type "com.android.contacts.tests.authtest.basic".
We could potentially add more account types to the test apk to test different
edit schema variations, but at this point this is impossible, as
ExternalAccountType doesn't have a way to tell which contacts.xml belongs
to which account type. The current contacts.xml defined here builds
the fallback account type equivalent.
The sync adapter is pretty rudimentary; it doesn't clear the isDirty flag
on modified raw contacts or delete raw contacts with isDeleted set. At
this point this doesn't seem to be necessary to test EditSchema.
Note:
For now it's still not meant to be public API. Right now it's only manually
tested with the edit schema defition in the test apk described above.
Bug 5381810
Change-Id: Ifefdb969b4e08775125924b1366d24effc4db2f2
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| 50a27b70581b0191995969c63edd1f6a3db3d1b7 |
|
07-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Clean up account definition
Removed:
- DataKind.isList. Use typeOverallMax = 1 instead
- DataKind.textAppearanceResourceId. Always use medium
- EditField.isFullName. Wasn't used.
Bug 5381810
Change-Id: I5ff109c075a5edb80ff97737432c78589570a1ea
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| ee05dcdd4b066ad909322c10919fb1812214673b |
|
06-Oct-2011 |
Katherine Kuan <katherinekuan@google.com> |
Cleanup of chat capability icon and primary icon in DataKind
- Add content description to chat capability icon for
accessibility
- Remove primary icon from DataKind because we don't display
it anymore in the UI (it's an unused field since we only
display secondary action icons now)
Bug: 5416674
Change-Id: I6587dd9186af68b0e794d3e73cbc3dad9fdac332
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| fbb876392608a36ec1d23704f29d8b46d5d23991 |
|
01-Oct-2011 |
Daniel Lehmann <lehmannd@google.com> |
Add missing copyright headers
Bug:5399509
Change-Id: Iba658e35cd0bf71a9320037ddb80257003f780c7
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| 1792b08c500ed528e7d21401affd936b3a7b3dc6 |
|
24-Aug-2011 |
Daniel Lehmann <lehmannd@google.com> |
Fix various Quick Contact visuals
Also fixed a bug where the secondary action can be tapped even though
it doesn't exist (crashes)
This also fixes pushed states, which have been filed a couple of times
Bug:5137515
Change-Id: I810d12a79f0088a0770a0eaf9225fe7906ebd8e7
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| edb576aab33efff623691a89ace3c76cb2ff12d1 |
|
28-Jul-2011 |
Daniel Lehmann <lehmannd@google.com> |
Implement new QuickContact design
- Also removes default-functionality
- Fixes the flicker when dismissing (Bug:5025418)
Change-Id: I46cf0fbdb2dcbf002612672e5e8f81a9b1ab6939
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| 398e3805b4278310250e5fd1007e2e73b9453d0f |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix "Add new" strings in contact editor
- Instead of using type-specific strings like "Add new
phone number" just use "Add new" since we have labels
for kind sections now.
Change-Id: I0e386ae29330193fec18b62f3949c46e095a872c
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| a2d4a9652fb4db9ee222abc7a637366c6c50427c |
|
07-May-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix font sizing and spacing in editor
- Remove name labels
- Remove extra divideres
Bug:4382255
Change-Id: I59c5b91e699b7386690e6df58e58b247d3086c99
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| 2591436971bad3050c85929c8e0c5a8d48111f88 |
|
30-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix "add field" logic
- Only update "add field" footer when field goes empty --> non-empty
and vice versa, fix the case for 4 line addresses in Exchange contacts
- Add property in DataKind class for "add field" string
- Remove hash map of mime types --> string resource IDs in
KindSectionView
- Remove "add internet call" string
Bug: 4363151
Bug: 4371568
Change-Id: Id2fec743a7c3e68d8404591cc61de20487245b0a
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| 63ffb90935d8aec295e4a8f62af6c77dafe1899f |
|
27-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
Refactor to inflate views from XML
- This is part 1 of getting the contact editor up to par with
the UI mocks, there are some known issues that will be fixed
in coming CLs (i.e. add button functionality)
- This way, the field editors can be vertically stacked
on the phone and horizontally stacked on the tablet.
- Get rid of duplicate labels by using the hint text in the field
or spinner as the title
Change-Id: Ia00a1a65ad0bbd7a4bc05ccb93dd1b1496bca5df
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|
| 405671a7b42d97ebf7ae7c0eeb4721f881139673 |
|
29-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move DataKind outside AccountTypes
Bug: 4184675
Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
/packages/apps/Contacts/src/com/android/contacts/model/DataKind.java
|