History log of /packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
c89565e1beec2ef986967a6330f1e7b0231a3c53 19-Nov-2011 Flavio Lerda <flerda@google.com> Store contact info using country iso as well.

Currently we are using just the number to store contact information that
we look-up. However, the look-up result depends also on the country in
which the call was placed or received.

This can lead to issues if the result is not the same depending on the
contact. This is particularly problematic in case of upgrades: the call
log will contain a number of entries without a country iso value since
the field was introduced after the Gingerbread release.

Use the country iso both when storing the contact in the in-memory
cache, as well as when updating the cache stored in the call log itself.

Bug: 5638376
Change-Id: I4c77556395147f05c2524d93cc1c800943395b6c
/packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java
0646f2712e8b4a5ada51bd586d5f179d38a304c5 17-Oct-2011 Flavio Lerda <flerda@google.com> Use framework API to match voicemail number.

We were tracking the voicemail number within the application. This has
two shortcomings: it would not be updated automatically when its value
changes and the matching against it was only based on it being
identical, without taking into account other possible formatting
differences.

Switch to use PhoneNumberUtils.isVoiceMailNumber() instead, which is
what the Phone app is also using.

Bug: 5435925
Bug: 5416495
Change-Id: Ie56363c578cf5f6102fd6880ffce14f608ddaf0b
/packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java
731f861593f3de69e8b3070b46e589cab42341f9 07-Oct-2011 Flavio Lerda <flerda@google.com> Share contact look up between call log and call details.

Currently, it is possible to get a contact be correctly identified in
the call log, but not in the details, because the logic to do the
look-up are completely separate.

For example, SIP contacts are correctly looked up by the call log, but
not by the details. Moreover, we recently fixed a few bugs in the logic
for looking up contacts in the call log, that have not been propagated
to the call details because the code is independent.

This commit moves the whole logic of looking up a contact given a number
(which may be a SIP number) from the CallLogAdapter into its own class.
Then, CallDetailActivity can use that to look up the contact in a way
that is guaranteed to yield the same result.

Bug: 5415134
Change-Id: I73acc39ba5dc65ecce6861f210224304fd91822d
/packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java
74628686391735dac1b13409e7f61e9f1514ea20 06-Oct-2011 Flavio Lerda <flerda@google.com> Remove strict mode violation with number formatting.

The call log is currently performing formatting on phone numbers in the
main thread (during bind view).

At the same time, however, we are always doing a background request to
look-up the contacts. Move the formatting call to the background thread.

In order for the right information to be shown as soon as the call log
is opened, we also need to store this information in our cached values
in the database. This means that the number will show unformatted the
very first time, and then updated once the background require is
completed.

Bug: 5316982
Change-Id: I20d1971948afa33c7825f0bd38a9520021f75378
/packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java
55e30c7a0feb8fe533b489c6c053454bfb2eb155 05-Oct-2011 Flavio Lerda <flerda@google.com> Revert "Remove strict mode violation with number formatting."

This reverts commit bbe62216b5163ec53eb990218bdbe608631dd8e7

Broke the build.
/packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java
bbe62216b5163ec53eb990218bdbe608631dd8e7 28-Sep-2011 Flavio Lerda <flerda@google.com> Remove strict mode violation with number formatting.

The call log is currently performing formatting on phone numbers in the
main thread (during bind view).

At the same time, however, we are always doing a background request to
look-up the contacts. Move the formatting call to the background thread.

In order for the right information to be shown as soon as the call log
is opened, we also need to store this information in our cached values
in the database. This means that the number will show unformatted the
very first time, and then updated once the background require is
completed.

Bug: 5316982
Change-Id: If1e4990243e73af6c9519fbf5e76a5d234e99e15
/packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java
c071dc49418588dc01b987d291ee45dbe41c3d82 06-Sep-2011 Flavio Lerda <flerda@google.com> Maintain the current view (voicemail only or all calls) on updates.

When the underlying content provider content changes, keep the same view
(voicemail only or all calls) as the one the user is looking at.

The underlying data may change because we updated some of the cached
columns, which currently causes the view to be updated for what seems to
the user no valid reason.

The only events we want to be sure to communicate to the user are new
voicemail and missed calls, but the notification bar takes care of those
cases, and if the application is currently open, we will refresh the
content anyway when resumed.

Bug: 5247042
Change-Id: I6db0a980aaafed5990f8e84bf4a9a1d0f44efb36
/packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java
5ee899e689a8ddcc500655f24b0bcdfdbf401702 23-Aug-2011 Flavio Lerda <flerda@google.com> Use photo id when available.

Photo id is a long that uniquely identifies a photo associated with a
contact. It only handles low-res photos, but that's what's used in the
call log anyway.

This commit uses photo ids instead of thumbnail URIs if the photo id is
available, since that's more efficient for storage purposes. In fact, if
a photo id is available it does not even bother storing the URI.

This will make a significant difference in terms of storage when I will
use the call log table to store cached contact information, including
the photo id and thumbnail URI.

Bug: 5101753
Change-Id: Ia60e3ce33763fe3744208763befbaf4489d60bdd
/packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java
f78a59076ab7700f0f7482d9935763dcab235563 14-Aug-2011 Flavio Lerda <flerda@google.com> Update the call log contact info cache.

Now that we use the call log cache again, we should also update it when
we find more up-to-date information when looking up in the contacts
database.

Bug: 5101753
Change-Id: I408c1d5c8ec3752d5c15e761274eb06fb9242de6
/packages/apps/Contacts/tests/src/com/android/contacts/calllog/CallLogAdapterTest.java