| df266ade99188365d4a52f89a6d26b549c2aaf9a |
|
18-Aug-2011 |
David Brown <dab@google.com> |
Clean up StatusBarManager usage in the phone app
In preparation for adding the DISABLE_NAVIGATION flag while an incoming
call is ringing (see bug 5161286), here's a big cleanup / simplification
of the phone app's use of the StatusBarManager.
Previously, we had two separate helper methods to disable the status bar
"notification windowshade" while in-call: one in the PhoneApp
(disable/reenableStatusBar()) and the other in the NotificationMgr
(NotificationMgr$StatusBarMgr.enableExpandedView()).
The InCallScreen was calling them both(!) and they could potentially
interfere with each other.
Now, the InCallScreen purely uses the NotificationMgr's helper class for
this, so we can totally get rid of those two PhoneApp methods. (The
EmergencyDialer also used these, but it's a totally separate activity so
it can just call StatusBarManager.disable() directly.)
Also, some other related cleanup:
- Update the NotificationMgr to be more explicit about being a singleton,
and use the exact same naming conventions as we already use with the
CallController / CallNotifier / InCallUiState / etc.
- Rename the helper class from StatusBarMgr to StatusBarHelper to be less
confusing (since "StatusBarManager" means something already)
- Improve javadoc in several places
TESTED to make sure no regressions from Gingerbread:
- While on a call, with the in-call UI up:
- Status bar "windowshade" not draggable in all call states
- Speakerphone and Mute icons appear correctly when necessary
- Alert notifications (like when receiving a text) are silenced
- While still in-call, bail out of the in-call UI:
- Status bar "windowshade" is now draggable
- Speakerphone and Mute icons still appear correctly
- Alert notifications are still silenced
- End the call and return to the home screen
- Status bar "windowshade" is draggable
- Speakerphone and Mute icons are properly cleaned up
- Alert notifications make their usual sounds
- Also, tested bailing out of the in-call UI and then ending the call
remotely (by hanging up the other end): all status bar icons got
cleaned up correctly.
- Emergency dialer (from lockscreen): make sure "windowshade" is not
draggable
Bug: 5161286
Change-Id: I4fa0f0f305d038943b93494ce8500dc339304691
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|
| 8e8a4aff9ad5b1e3bbc76e894b71c0c0c85d86bd |
|
15-Jan-2011 |
Robert Greenwalt <rgreenwalt@google.com> |
Moving gsm.NetworkInfo to OperatorInfo
NetworkInfo had a bad name collision, wasn't gsm specific and was really
about operators.
Change-Id: Id2986afeb29089df03efe5817ebc69ebf6d82463
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|
| c58406cd7ed20632fcb2e2e794a27299d4321733 |
|
22-May-2010 |
Wink Saville <wink@google.com> |
Change all uses of PhoneApp.getInstance().phone to PhoneApp.getPhone().
Change-Id: Ic4301b722d9a191b73f1ecc77052eb9bc6bdd06b
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|
| cfc35689d980c1b75ae7bef94b65d21594bcaf66 |
|
21-Apr-2010 |
John Wang <johnwang@google.com> |
Add try connect again later error message.
It is for bug 2571583 to provide better failure information of network operator selection.
Show the "try again later" message when the network selection failure is temporary and might succeed by retries.
Change-Id: I83e06957412dafc3f626e732a01d87b199ba511b
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|
| 2b1b2a4bae6cc53df7b162b6f7445b5c6e091171 |
|
05-Mar-2010 |
Tim Park <tpark@google.com> |
Handle orientation changes in NetworkSettings activity correctly
Fix for 2479263: Ignore orientation changes since there isn't a
landscape specific layout. Ran into another not foreground
dialog dismissal crash -- track IsForeground status and
don't show or dismiss Dialogs if we are not foreground.
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|
| c51f5ac3de9db72a11dfbb1cefd8cc72f7a0fc7c |
|
02-Apr-2009 |
Wink Saville <> |
AI 144245: Fix merge conflict for megering in the CDMA changes in to master from donutburger.
Automated import of CL 144245
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|
| b16363f5fc191b769e88c364243e34b92eb22688 |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|
| a412e78a7bba553a66503370b4c618db83528916 |
|
04-Mar-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //depot/cupcake/@135843
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|
| 62f98540ff39eb68eea5e393d5a2ac61e412c313 |
|
13-Feb-2009 |
The Android Open Source Project <initial-contribution@android.com> |
auto import from //branches/cupcake/...@131421
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|
| abc47110c17fa8e8cb6161bc045e87f31eeb7a1c |
|
21-Oct-2008 |
The Android Open Source Project <initial-contribution@android.com> |
Initial Contribution
/packages/apps/Phone/src/com/android/phone/NetworkSetting.java
|