History log of /frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
b7945cae5ad0feaad09378d0db77f2b3105e5235 22-Sep-2011 Jake Hamby <jhamby@google.com> Enable support for multiple SMSDispatchers in CDMALTEPhone.

Refactor framework to support multiple SMSDispatcher objects on
dual-mode devices that require support for both 3GPP and 3GPP2
format SMS messages. Each dispatcher registers to receive events for
the appropriate message format.

Note: All applications which handle incoming SMS messages by processing the
SMS_RECEIVED_ACTION broadcast intent MUST pass the "format" extra from the intent
into the new createPdu() method in android.telephony.SmsMessage that takes an
extra format parameter. This is required in order to correctly decode the PDU on
devices which require support for both 3GPP and 3GPP2 formats at the same time,
such as CDMA/LTE devices and GSM/CDMA world phones.

- moved code to manage device storage events from SMSDispatcher to a
new class, SmsStorageMonitor, which is shared among all dispatchers.

- moved code to monitor per-application outgoing SMS usage from
SMSDispatcher.SmsCounter to a new class, SmsUsageMonitor, which
is shared among all dispatchers.

- fixed a bug that prevented CDMALTEPhone from setting the MCC/MNC
operator numeric value in the telephony provider from the UICC,
as GSMPhone does, when the SIM records have loaded.

Change-Id: I2789ac07b6ca2948138bca7f75481f9b31514f20
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
31e61185a6c34c8fd80c3283b9d80dc136b57b63 03-Jun-2011 Ed Heyl <ed@google.com> resolved conflicts for merge of 39ddeae0 to master

Change-Id: I84f00b97470c2a4a2d19492aef4b65942db2f69f
62388cfc1fb2483eb6582ccb8e36d47f16bf01fa 26-May-2011 Simon Wilson <simonwilson@google.com> resolved conflicts for merge of a38fad37 to honeycomb-plus-aosp

Conflicts:
telephony/java/com/android/internal/telephony/cdma/SmsMessage.java

Change-Id: I4c808c752954c5d1f752f4b4c02ad41ea491e416
a38fad37c21a13ddf1cc14e5a960f395af558ee8 24-May-2011 Soojung Shin <sj46.shin@samsung.com> am 4e4ad341: SmsMessage: convert + to international dialing prefix

* commit '4e4ad34159dc1c720a3e6145bb9f14c60fb1a3f7':
SmsMessage: convert + to international dialing prefix
4e4ad34159dc1c720a3e6145bb9f14c60fb1a3f7 13-May-2011 Soojung Shin <sj46.shin@samsung.com> SmsMessage: convert + to international dialing prefix

When sending an SMS to an international number in the format
+401234567890, the "+" should be converted to the International
Dialing Prefix (in the US, 011). However, the device drops this
"+" altogether in the outbound data burst message causing the message
to fail or be sent to the wrong address.

Change-Id: If25c092d283f1703b49cf52d0379efa54639f093
Signed-off-by: Soojung Shin <sj46.shin@samsung.com>
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
43a17654cf4bfe7f1ec22bd8b7b32daccdf27c09 07-Apr-2011 Joe Onorato <joeo@google.com> Remove the deprecated things from Config.java. These haven't been working since before 1.0.

Change-Id: Ic2e8fa68797ea9d486f4117f3d82c98233cdab1e
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
055ed42e7062bd46820b8e629cda0b7cf9a4fb65 08-Dec-2010 Wink Saville <wink@google.com> am d9c7fde9: am a00d89e8: am 2b858cae: Merge "Telephony: Add support to read 3GPP2 sms from CSIM/RUIM"

* commit 'd9c7fde961dbb78f980be08b9be77b929630c897':
Telephony: Add support to read 3GPP2 sms from CSIM/RUIM
a00d89e824c523c51955176b61e50472828fd8b1 08-Dec-2010 Wink Saville <wink@google.com> am 2b858cae: Merge "Telephony: Add support to read 3GPP2 sms from CSIM/RUIM"

* commit '2b858caecb3c293c47b48eed12a55a49e3039874':
Telephony: Add support to read 3GPP2 sms from CSIM/RUIM
ee7d1973ff3cd7c9c8744696901b37833027cafb 12-Oct-2010 Rekha Kumar <rekhak@codeaurora.org> Telephony: Add support to read 3GPP2 sms from CSIM/RUIM

Add parser to parse 3GPP2 format sms stored in CSIM/RUIM card

Change-Id: I4720ba7602fcc1b078de0d5fea34247541242c1c
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
cc8c6496b7c0f0827aac57eef40c54b6412a7da6 02-Oct-2010 Jake Hamby <jhamby@google.com> resolved conflicts for merge of 3543a40b to master

Change-Id: I307c8f1277b84763e537ced0ac3410ec06fce431
3543a40b24c4256413ef6bbc3017792ca3e4a2e6 02-Oct-2010 Jake Hamby <jhamby@google.com> am 7888486d: Merge "Add subaddress to SMS fingerprint calculation."

Merge commit '7888486d1c930301535069bd90bb0bf3525b2bb5' into gingerbread-plus-aosp

* commit '7888486d1c930301535069bd90bb0bf3525b2bb5':
Add subaddress to SMS fingerprint calculation.
f51eadaf1f83abfe16a609a4ded6d789494689b2 21-Sep-2010 Jake Hamby <jhamby@google.com> Typo fixes in comments and minor code cleanups.

* Fix some typos in Javadoc and log messages.
* Remove redundant initializer in BluetoothAdapter.readOutOfBandData()
* Use canonical "UTF-8" charset name instead of "UTF8" in
BluetoothDevice.convertPinToBytes()

Change-Id: I58cd5dc48a7ad0053d204c5f590b4b3d438d8672
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
7d16427653e047e4901988e7ee04d637e65253b7 27-Sep-2010 Naveen Kalla <nkalla@codeaurora.org> Add subaddress to SMS fingerprint calculation.

As per SMS specification in 3GPP2 C.S0015-B, section 4.3.1.6, if the
Subaddress is included in a CDMA SMS message, it needs to be used for
duplicate detection. Subaddress, which is an optional field was omitted
while computing the SMS fingerprint. Hence it was never being used in
duplicate detection if it was included in the SMS. Add subaddress to the
SMS fingerprint.

Change-Id: Iad9e89887a17caba59033ab8f8d94b63b33cb4bb
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
a774f5817b5a24f5ccbb15c97fc4d5038310245b 16-Aug-2010 Jake Hamby <jhamby@google.com> resolved conflicts for merge of 31202b1a to master

Change-Id: Ia8ae32c5ebcd13843ed9cc82c80bf551b38e586f
17f616823a562ceb3a008f91e05d43bc56d37cae 13-Aug-2010 Jake Hamby <jhamby@google.com> Fix character count bug and Javadoc typos in SMS (with test cases)

Fix a character count bug I discovered while working on related SMS
bugs. Includes a new set of test cases to verify the fix for the
buggy calculateLength() methods ("runtest frameworks-telephony").

You can also verify that the counter works properly in the Mms app
by typing characters until the boundary is crossed where an
additional message part is required. The counter should count down
to 0 characters remaining before increasing the message count.

Change-Id: I4de68b82dfc53dcae094865798f2c0235a355d43
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
cae1bfd26629a83cf8646c4606ff6cf19fd1937d 19-May-2010 The Android Open Source Project <initial-contribution@android.com> am 634e9a12: am 54525412: am 3aecdb9d: merge from open-source master
3aecdb9d7e92b1a91860600feefb5c0062b652cf 18-May-2010 The Android Open Source Project <initial-contribution@android.com> merge from open-source master

Change-Id: Ib711450566694550d9cb9ba01c25599010d2e5e4
390de220248d05ccb9dc10a197700ad3c1595937 11-May-2010 Jake Hamby <jhamby@google.com> Fix some typos and other cosmetic cleanups in telephony framework.

- Fix typos in Javadoc and comments.
- Fix Javadoc @link references to other classes/methods.
- Rename MISSING_UKNOWN_APN to MISSING_UNKNOWN_APN in DataConnection.
- Remove unused (and misspelled) RETRYIES_* consts in RetryManager.

Change-Id: I3b44ac8320d6c1e4c350be600c7ef266aaf735e4
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
9e397775e18f369f7855affd23a3ce6a24053218 03-May-2010 Jake Hamby <jhamby@google.com> Fix Javadoc param tags and typo in private constant definition.

- Two Javadoc comments in telephony/cdma/SmsMessage.java had the wrong parameter name in @param.
- Typo in private constant defined in telephony/cdma/sms/BearerData.java.

Change-Id: I3c210383f74a5fef022e0958ab56ef9b7be8e97c
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
bcd573229e5ec6d59bb7931a84a2baa86e0d200a 24-Apr-2010 Jake Hamby <jhamby@google.com> Fix some more typos, remove unused imports, and remove unnecessary cast.

More minor code cleanups in the telephony framework.

Change-Id: I27abe11e02fc6fea12885eea4fe275240a546332
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
cbcd9be4104b3872902898b84fae92d1623fd8f1 20-Apr-2010 Jake Hamby <jhamby@google.com> Fix a few more Javadoc typos.

Change-Id: Id43fe2551ef53c1a0a779c6101ea0bc7c23e1f93
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
83fd7b0d53f2fecb5b92cb911910e07659e246ca 16-Dec-2009 John Joseph <jnjoseph@quicinc.com> frameworks/base: Handle broadcast sms properly

Broadcast SMS does not have teleservice id field. Add
support to identify broadcast SMS based on message type.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
9d34319f1ce5be4124a0b6293162587f4573496f 16-Sep-2009 Christian Gustafsson <christian.gustafsson@motorola.com> CDMA Check for network duplicate sms

In some cases a sms acknowledgement might be lost. The network will then resend
the same sms. These duplicate sms should be acknowledged but not shown to the
user.

C.S0015-B 4.3.1.6 Unique Message Identification.

The fields used to identify a message are:
* Message Identifier,
* Originating Address,
* Originating Subaddress, and
* Message Center Time Stamp.

Since some of the fields are optional, the Teleservice Layer shall use as
many of the fields as are present in the SMS message to determine message
uniqueness. Mobile stations should discard repeated messages.

1. Add a fingerprint function to SmsMessage.java. This returns a byte array
to be used as a unique identifier. Parts that make up the identifier are
the originating address, teleservice id and the bearerdata. Using all of
the bearerdata saves parsing time. There are no random bits allowed in
the standard. This makes binary comparison possible. Using all of the
bearerdata accounts for the message id, smsc timestamp and "... shall
use as many of the fields as are present in the SMS message".
2. Have CdmaSMSDispatcher.dispatchMessage() pull a fingerprint and check if
it matches the last acknowledged fingerprint. When it matches return and
signal that message was handled.
3. Have CdmaSMSDispatcher.acknowledgeLastIncomingSms() take the last
dispatched fingerprint move it to the last acknowledged fingerprint.
Only do this if processing of the sms was successful.

Change-Id: If79f8fe40896cd290940b7ccd5a17531ab937b60
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
50f7ea53c3f356453fc4304b911c9a022290d924 15-Sep-2009 jsh <jsh@google.com> Some SMS logging improvements.

Use Log.isLoggable() to enable logs at runtime. Implement SmsResponse.toString()
so we can see what's returned.

Hopefully helps with debugging b/2086832.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
d304ae583d862250a21b5949fc3dbdf3af1febac 03-Sep-2009 Tammo Spalink <tammo@google.com> Fix CDMA SMS delivery status reporting.

CDMA SMS status reports are messages with bearer data message type
DELIVERY_ACK. Identify these messages after parsing during demux,
update the deliveryPendingList and generate a RESULT_OK intent in the
same manner as GSM.

Addresses issue:
http://buganizer/issue?id=2047571

Change-Id: Ia38718b0bb169a0f3398f50c27a95e8bce7e4c99
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
98a5ba78f99f6537b34b673521f7d4ab9893c80b 09-Sep-2009 Tammo Spalink <tammo@google.com> Avoid CDMA messages with IDs of zero.

In reference to issue:
http://buganizer/issue?id=2047571

Change-Id: I88b5cdbb988f12206663bbb3fdc9508a437b19ad
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
1f952a178db86559ff4bab79c4a9b5fae18096bf 25-Aug-2009 Tammo Spalink <tammo@google.com> Move SMS pdu creation fully into the central Phone process.

Previously pdu creation was haphazardly done sometimes by the app and
sometimes centrally by the phone process -- specifically the phone
process did creation for multipart texts. This change gets rid of the
previous IPC interface for sending raw pdus to SMSDispatch in the
phone process, and instead makes everything work like multipart
messages worked before, namely the structured data is passed and pdu
encoding done centrally.

The motivation for this was the need to ensure that CDMA message id
numbers were strictly monotonic, including across reboots, which
necessitated central state in the form of a system property, which
could in turn only be modified by the phone process.

Hence, this (in part) addresses issue: http://buganizer/issue?id=2075760

Change-Id: I94ca207b6e657c465e8472534704db8646ee277c
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
49bd918dc26a3a599d8d04212de5600abc3e48c4 20-Aug-2009 Tammo Spalink <tammo@google.com> more cdma sms debug logging
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
079ad20da7df79f26880c9076967dc3fbce6528c 17-Aug-2009 Tammo Spalink <tammo@google.com> cdma sms encoding tweaks and logging / debugging annotations.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
c84401fb8b3ed90039bd132b343852303ef88ce6 13-Jul-2009 yong liu <yong.liu@motorola.com> CDMA Message Waiting Indication support

Add support for Message Waiting Info Record defined in 3GPP2 C.S-0005
and used for voice mail count by some CDMA networks
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
1424fe0059a3fe163fb98bad807a1eb635b0a161 23-Jul-2009 Tammo Spalink <tammo@google.com> added non-numeric cdma sms address support

addresses bug http://buganizer/issue?id=1992198
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
2fa57a3fd1f5be9136b51c955e0ecc355021ecba 30-Jun-2009 yong liu <yong.liu@motorola.com> Message address encoding fix

Set DIGIT_MODE_4BIT_DTMF as the default digitMode and
TON_UNKNOWN as the default 'type of network'.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
5082fd58e33aa54d760459de3368912c37864a4f 24-Jun-2009 Satish Roddom <satishroddom@motorola.com> frameworks/base: Update mPdu in createFromPdu

Inside createFromPdu(), the passed-in parameter 'pdu' is assigned
to msg.mPdu, so that we can call getPdu() to get it back.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
ce099c3226b33b43e0dd5d1f24347b14a2223ee1 01-Jun-2009 David Krause <david.krause@motorola.com> frameworks/base: CDMA voicemail support
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
fc78f358cb1d1cee99758bcd6ef998a122ef27c9 11-Jun-2009 Tammo Spalink <tammo@google.com> for cdma concatenated (long) messages, replace ascii7bit with gsm7bit encoding
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
a94945d3a1cf23caf33759eb1de84195d3fcb37b 03-Jun-2009 Tammo Spalink <tammo@google.com> make sms calculateLength radio-independent
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
baae313f896d8048f23e4acc76e554c8aa4667bd 12-May-2009 Tammo Spalink <tammo@google.com> support more minor cdms sms bearer data subparameters

- also clean up CdmaSmsAddress
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
64c499113a758cf80cddfd4d0183f944a1a6645a 05-May-2009 Tammo Spalink <tammo@google.com> SmsHeader rewrite, in preparation for migration to public API.

See http://b/issue?id=1751571

Changes the semantics of SmsHeader from containing only opaque data
to exposing occurs-once frequently-used fields together with a list
of opaque fields. Also changes the coding to and from byte array to
be symmetrical, whereas previous encoding had an extra length field.

Cdma SmsMessage -- cleanup of code paths along with adjustments to
match the new header semantics, which should address at least some
of the issues with concatenated messages. See http://b/issue?id=1809759
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
8478b59f177ec97a9996b71f7fac1509ba9ef493 30-Apr-2009 Tammo Spalink <tammo@google.com> clean up cdma sms creation and parsing

related to issue http://b/issue?id=1782245

- fixes 7bit ASCII encode and decode (previous completely broken)

- also consolidates encoding of user data, and changed to match
the conventions of the new data coding -- previously likely
broken for several cases
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
8c49d32cb9980959c402eaa243fd5129cd9942fc 24-Apr-2009 Tammo Spalink <tammo@google.com> enable additional cdma sms fields and user data encodings

enable ia5 and octet user data encodings
properly expose parsed user data
support additional bearer data subparameter types
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
e66b5c43cb2d0aece7f4a636a2368a9c66c46cf5 24-Apr-2009 Wink Saville <wink@google.com> Teleca 090414 & 090423 patches for CDMA to complete phase1 work.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
83917db040bd7498ebca3b74f879dc1c9e223d8e 14-Apr-2009 Tammo Spalink <tammo@google.com> Initial code for cdma sms encode and decode, in java, with simple tests.

(direct cherry-pick of master 42/42/8)
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java
767a662ecde33c3979bf02b793d392aca0403162 02-Apr-2009 Wink Saville <> AI 144185: Integrate cdma into the main code base.

Automated import of CL 144185
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/SmsMessage.java