History log of /frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
4144a060257004902fb53c967c408217399e3fc2 30-Aug-2011 Jake Hamby <jhamby@google.com> Use the local timezone for CDMA SMS timestamps.

3GPP2 uses the local timezone for timestamps in SMS messages.
Use the local timezone instead of UTC when decoding bearer data.

Bug: 5123883
Change-Id: Iec25bcbb7862f0794ead80b6923c815b68bdd2a5
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
ee60f3fb1b4e61ac8027293a658ba710e36d36b6 11-May-2011 Jake Hamby <jhamby@google.com> resolved conflicts for merge of 18cc814c to honeycomb-plus-aosp

Change-Id: I2b569ada3baec2dc486296623063bc2b504c5e96
18cc814c94edb188b73a92f0d34878d9dc054ff6 05-May-2011 Jake Hamby <jhamby@google.com> am 4d53cb02: Merge "Enable support for SMS national language shift tables." into gingerbread

* commit '4d53cb02168fe35104d7e644dd9b3efd8ca4c91b':
Enable support for SMS national language shift tables.
b49a73dfc4c9817bba1f227e9330555acdf9b56f 16-Mar-2011 Jake Hamby <jhamby@google.com> Enable support for SMS national language shift tables.

Add support for encoding and decoding SMS 7 bit user data using the
national language shift tables defined in 3GPP TS 23.038 (GSM/UMTS only),
including the new tables added in Release 9 for Indic languages.

Decoding is always supported, but encoding is only enabled for the
specific language tables added to the new integer array resources
"config_sms_enabled_single_shift_tables" and
"config_sms_enabled_locking_shift_tables" defined in
frameworks/base/core/res/res/values/config.xml. The default empty arrays
should be overridden in an OEM overlay for the specific nationalities where
SMS national language shift table encoding is allowed/mandated (e.g. Turkey).
GsmAlphabet.countGsmSeptets() will try to find the most efficient encoding
among all combinations of enabled locking shift and single shift tables.
If no 7 bit encoding is possible, 16 bit UCS-2 encoding will be used.

This change also fixes a bug in the decoder: when an escape septet
is followed by a septet with no entry in the extension (single shift)
table, TS 23.038 Table 6.2.1.1 states that the MS shall display
the character in the main GSM 7 bit default alphabet table, or the
active national language locking shift table. Previously, we were
decoding this sequence as a space character. Two consecutive escape
septets will continue to decode as a space character, according to
Note 1 of table 6.2.1.1.

Change-Id: I4dab3f0ffe39f3df2064ed93c9c05f26e274d18b
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
36ca1d3a693f0a416e758bb52801a3381a34a605 15-Mar-2011 Brad Fitzpatrick <bradfitz@android.com> am 9ac9b285: am b98c8fca: Merge "Removing self-assignment statement."

* commit '9ac9b28576834b69561a48a4050e7ad027543bcd':
Removing self-assignment statement.
9ac9b28576834b69561a48a4050e7ad027543bcd 15-Mar-2011 Brad Fitzpatrick <bradfitz@android.com> am b98c8fca: Merge "Removing self-assignment statement."

* commit 'b98c8fca954718cb61d6513e623a78f1b0bd0edb':
Removing self-assignment statement.
92fb16685fd8d28b231a02bfa3ef76d3924210ad 08-Mar-2011 Simon Wilson <simonwilson@google.com> am 10993b2d: am 6b6869d5: Merge "mms: mms wap push length check before pdu processing." into gingerbread

* commit '10993b2d1e3614073970aad119ffb2cc9bc8f73f':
mms: mms wap push length check before pdu processing.
7ac1cb787ca0386e285a8cd10e095b12821aaf7f 07-Mar-2011 Soojung Shin <sj46.shin@samsung.com> mms: mms wap push length check before pdu processing.

Change-Id: Id5b5572bcd2953e496f03142d13bd2d012225e30
Signed-off-by: Soojung Shin <sj46.shin@samsung.com>
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
3fe49d8168ab7344d495ea5ee8ed6b9ef3145495 07-Mar-2011 Soojung Shin <sj46.shin@samsung.com> am fa680a18: am ff5a0990: Added to check for supporting mms content-disposition, utf8 decoding.

* commit 'fa680a18f617de202912b8a9fe3fc0890a9fe09e':
Added to check for supporting mms content-disposition, utf8 decoding.
ff5a09904fb05f2776f1bbf1dd3915f38031190c 02-Mar-2011 Soojung Shin <sj46.shin@samsung.com> Added to check for supporting mms content-disposition, utf8 decoding.

Change-Id: Ieae1bb2ac36675f569fb21285ca6ef289c367bf7
Signed-off-by: Soojung Shin <sj46.shin@samsung.com>
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
c007925423f4ffcefa3bfd17e40288305ebe5ae2 22-Feb-2011 Jozef BABJAK <jozef.babjak@gmail.com> Removing self-assignment statement.

Change-Id: I429235093de4539bde3950075fbdaa4ef5bdeedd
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
a774f5817b5a24f5ccbb15c97fc4d5038310245b 16-Aug-2010 Jake Hamby <jhamby@google.com> resolved conflicts for merge of 31202b1a to master

Change-Id: Ia8ae32c5ebcd13843ed9cc82c80bf551b38e586f
17f616823a562ceb3a008f91e05d43bc56d37cae 13-Aug-2010 Jake Hamby <jhamby@google.com> Fix character count bug and Javadoc typos in SMS (with test cases)

Fix a character count bug I discovered while working on related SMS
bugs. Includes a new set of test cases to verify the fix for the
buggy calculateLength() methods ("runtest frameworks-telephony").

You can also verify that the counter works properly in the Mms app
by typing characters until the boundary is crossed where an
additional message part is required. The counter should count down
to 0 characters remaining before increasing the message count.

Change-Id: I4de68b82dfc53dcae094865798f2c0235a355d43
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
9e397775e18f369f7855affd23a3ce6a24053218 03-May-2010 Jake Hamby <jhamby@google.com> Fix Javadoc param tags and typo in private constant definition.

- Two Javadoc comments in telephony/cdma/SmsMessage.java had the wrong parameter name in @param.
- Typo in private constant defined in telephony/cdma/sms/BearerData.java.

Change-Id: I3c210383f74a5fef022e0958ab56ef9b7be8e97c
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
bcd573229e5ec6d59bb7931a84a2baa86e0d200a 24-Apr-2010 Jake Hamby <jhamby@google.com> Fix some more typos, remove unused imports, and remove unnecessary cast.

More minor code cleanups in the telephony framework.

Change-Id: I27abe11e02fc6fea12885eea4fe275240a546332
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
cbcd9be4104b3872902898b84fae92d1623fd8f1 20-Apr-2010 Jake Hamby <jhamby@google.com> Fix a few more Javadoc typos.

Change-Id: Id43fe2551ef53c1a0a779c6101ea0bc7c23e1f93
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
145ff609de3206b585819ef974fab20cdc2d9f5e 16-Apr-2010 Jake Hamby <jhamby@google.com> Spelling corrections and other minor cosmetic cleanups.

- Fixed a bunch of typos in comments (plus a few variable names)
- Removed unused import lines from telephony classes
- Added @Override attribute to overriding methods
- Made SmsMessage.PduParser inner class private & deleted unused constructor
- Added type specifiers to declarations of ArrayList and HashMap
- SimulatedCommands.getRegistrationState() had an ArrayIndexOutOfBoundsException
trying to write to index 14 of a 14-element array. I removed the
out-of-bounds assignment.

Change-Id: I054b5156aa64ab6639028d5b45a7e688b2deee08
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
3e5c3a6db4c8ad4842ee1f6a2cdb04f6e107db57 06-Nov-2009 jsh <jsh@google.com> Fix some SMS encode issues.

1. Spanish SMS 71-160 chars not sent. This was because calculateLength
allowed for single-segment EMS encoding, while encodeUserDataPayload
did not. For now, change calculateLength to match encodeUserDataPayload
(ie, fallback to UTF16 in this case). (b/2224849)
2. Unicode value of N w/tilde was incorrect. (b/2224849)
3. Add '\' and '/' to the list of valid separators in CDMA SMS numeric
addresses. (b/2236527)
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
079ad20da7df79f26880c9076967dc3fbce6528c 17-Aug-2009 Tammo Spalink <tammo@google.com> cdma sms encoding tweaks and logging / debugging annotations.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
9688c6046fdbf6a24e3541bd6342995b4605fd5d 12-Aug-2009 Wink Saville <wink@google.com> Rename bcdByteToInt to gsmBcdByteToInt and beBcdByteToInt to cdmaBcdByteToInt.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
e00dd1e5a37bed0de964b353d47a4bd7cdff532f 28-Jul-2009 Tammo Spalink <tammo@google.com> Make GSM 7-bit encoding properly deal with initial padding.

For CDMA, clean up the GSM encapsulation to properly align
user data payload after the user data header.

Addresses http://buganizer/issue?id=2007011
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
e4ebbd29f78df25e22c701b597c3c15b7f8add73 08-Aug-2009 Christian Gustafsson <christian.gustafsson@motorola.com> CDMA voicemail notification fixes

1. Convert the voicemail count of a VM notification from
BCD to decimal. That way the user will not be notified
of 16 new VM when there are only 10.
Ref: 3GPP2 C.S0015-B / 4.5.12 Number of Messages.
2. Allow VMN-95 notifications without "User Data" to be
processed. Only mandatory items for VMN-95 are
"Message Identifier" and "Number of Messages".
Ref: 3GPP2 C.S0015-B / 4.3.5 Voice Mail Notification.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
2d65082b158564819404e556db6492272111b5b3 05-Aug-2009 Tammo Spalink <tammo@google.com> fix CDMA SMS ASCII decode and mapping
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
98aed46992679cf1ddc99bdb735c9d18b92ce940 02-Aug-2009 Tammo Spalink <tammo@google.com> relax ia5 parsing, and combine with ascii
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
f62a2bf29a6cf87be03b290b8b660db245022881 28-Jul-2009 Tammo Spalink <tammo@google.com> allow illegal subparam sizes for CDMA SMS

addresses http://buganizer/issue?id=2008358
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
1424fe0059a3fe163fb98bad807a1eb635b0a161 23-Jul-2009 Tammo Spalink <tammo@google.com> added non-numeric cdma sms address support

addresses bug http://buganizer/issue?id=1992198
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
05b301b9df83ee7aa7ac2a93e137bc1fd58d3fce 10-Jul-2009 Wink Saville <wink@google.com> Changes 203 and 225 from partner repo.

These are combined to save testing time.


Change 225:
make NV_READY return State.READY.

Change 203:

CDMA SMS decoding support for Latin and fix for WAP concatenation

1. Enabled support for 8bit Latin decoding.
2. Change octet decoding to remove an extra pad byte from the payload.
This caused problems with the concatenation of WAP PUSH messages.
3. Decode octet encoded data as if it was Latin. There are devices out
there that will use 0 instead of 8.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
0fd833a50f43239e619fa383045374459f42ca49 07-Jul-2009 Tammo Spalink <tammo@google.com> septet-align UD after any UDH for GSM-7bit coding
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
8561de157c78e65e49f6989cd2c242c416631df7 28-Jun-2009 Tammo Spalink <tammo@google.com> eliminate byte-typed cdma sms fields
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
8203dc1bc8d99e2fe430a1a3026983e2e440e6d5 09-Jun-2009 Tammo Spalink <tammo@google.com> cdma sms is91 support
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
326c66d888f9b3ce82af93fe63e4828a4a4e3fbe 24-Jun-2009 Tammo Spalink <tammo@google.com> make BitwiseInputStream.read return int

Keep the maximum access 8 bits to avoid dealing with
endianness issues.
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
fc78f358cb1d1cee99758bcd6ef998a122ef27c9 11-Jun-2009 Tammo Spalink <tammo@google.com> for cdma concatenated (long) messages, replace ascii7bit with gsm7bit encoding
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
a94945d3a1cf23caf33759eb1de84195d3fcb37b 03-Jun-2009 Tammo Spalink <tammo@google.com> make sms calculateLength radio-independent
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
baae313f896d8048f23e4acc76e554c8aa4667bd 12-May-2009 Tammo Spalink <tammo@google.com> support more minor cdms sms bearer data subparameters

- also clean up CdmaSmsAddress
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
64c499113a758cf80cddfd4d0183f944a1a6645a 05-May-2009 Tammo Spalink <tammo@google.com> SmsHeader rewrite, in preparation for migration to public API.

See http://b/issue?id=1751571

Changes the semantics of SmsHeader from containing only opaque data
to exposing occurs-once frequently-used fields together with a list
of opaque fields. Also changes the coding to and from byte array to
be symmetrical, whereas previous encoding had an extra length field.

Cdma SmsMessage -- cleanup of code paths along with adjustments to
match the new header semantics, which should address at least some
of the issues with concatenated messages. See http://b/issue?id=1809759
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
8478b59f177ec97a9996b71f7fac1509ba9ef493 30-Apr-2009 Tammo Spalink <tammo@google.com> clean up cdma sms creation and parsing

related to issue http://b/issue?id=1782245

- fixes 7bit ASCII encode and decode (previous completely broken)

- also consolidates encoding of user data, and changed to match
the conventions of the new data coding -- previously likely
broken for several cases
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
8c49d32cb9980959c402eaa243fd5129cd9942fc 24-Apr-2009 Tammo Spalink <tammo@google.com> enable additional cdma sms fields and user data encodings

enable ia5 and octet user data encodings
properly expose parsed user data
support additional bearer data subparameter types
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
83917db040bd7498ebca3b74f879dc1c9e223d8e 14-Apr-2009 Tammo Spalink <tammo@google.com> Initial code for cdma sms encode and decode, in java, with simple tests.

(direct cherry-pick of master 42/42/8)
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java
767a662ecde33c3979bf02b793d392aca0403162 02-Apr-2009 Wink Saville <> AI 144185: Integrate cdma into the main code base.

Automated import of CL 144185
/frameworks/base/telephony/java/com/android/internal/telephony/cdma/sms/BearerData.java