3aba36cc373e82ca3a3331bb77bd1278d0afde06 |
|
01-Apr-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing tests that did not get updated earlier The change https://android-git.corp.google.com/g/#change,45372 broke the tests. I have verified that it's the tests and not the tested code that is broken. Bug: 2524876 Change-Id: Iaa3d1012bef301d09562793b0adac8888be2c783
/packages/apps/Contacts/tests/src/com/android/contacts/EntityDeltaTests.java
|
88d00c2450a0a16bf1dd35e9f3c9ba843a97ec62 |
|
23-Sep-2009 |
Jeff Sharkey <jsharkey@android.com> |
Hook up logic for re-parenting of user edits, unit tests. When persisting edits, we assert that RawContacts.VERSION has remained consistent. When this check fails, it usually means that a server change has changed the underlying data, and instead of dropping user edits, we "re-parent" their changes after re-reading the base data. This change finishes up the re-parenting logic to run over an entire EntitySet, and also has a nice pile of unit tests to verify behavior. Fixes http://b/2115136
/packages/apps/Contacts/tests/src/com/android/contacts/EntityDeltaTests.java
|
49d17b3e7692ae9442c342db236fa93d4a837c28 |
|
07-Sep-2009 |
Jeff Sharkey <jsharkey@android.com> |
Lookup uris, delete, aggregation rules, untyped, sharing. ContactsListView: combined together various import/export menus under single dialog, hiding SIM import when no ICC present. Switched almost all cases to use soft "lookup" uris, especially for pick and operation cases. Brought back delete in long-press menu, and pick modes needed for SHOW_OR_CREATE. These partially fix http://b/2096050 and http://b/2096870 and http://b/2102632 ViewContactActivity: changed menus to inflate from XML, added "Share" option to replace barcode. Confirmed that it sends vCard through Gmail, other apps can match MIME-type to begin appearing in picker. Changed EAS rules back to untyped for Email and IM, which now allows use to use IM type as protocol picker. Fixes http://b/2072731 and http://b/2092744 and http://b/2088935 EditContactActivity: restructured editing to front-load all version assertions, and perform as single batch to prepare for reparenting. Correctly generate AggregationExceptions using new API from dplotnikov, especially in cases where we create multiple RawContacts from scratch. Unit tests to verify exceptions built correctly for edge cases. Also showing toast when saving failed. These changes were mostly untracked, but fixes http://b/2099211 Various untracked NPE related to untyped HardCodedSources and cleanup of "tel" "smsto" and SMS MIME-type constants.
/packages/apps/Contacts/tests/src/com/android/contacts/EntityDeltaTests.java
|
985585b0557d277ee2ae3e8093cd577d0d1d59b1 |
|
03-Sep-2009 |
Jeff Sharkey <jsharkey@android.com> |
Correctly change aggregation mode in all cases, unit tests. Fixed broken unit tests, and in the process corrected an issue where we changed aggregation mode in some cases where is wasn't needed. (When updating but no values change.)
/packages/apps/Contacts/tests/src/com/android/contacts/EntityDeltaTests.java
|
14f61ab769f6e178a540a7579e446a010fb836da |
|
06-Aug-2009 |
Jeff Sharkey <jsharkey@android.com> |
Switch edit UI to tabs, TYPE_ASSERT for version, cleanup. Integrated with the tabs and header widget built by emillar, kept separate from BaseContactCardActivity since I'm handling EDIT/INSERT intents differently. Added hooks to pick primary photo/name from header. Cleaned up the colorful testing UI, added padding to match mocks, and initial pass at collapsed secondary area. Added back menu items and confirmation toast. Changed to new TYPE_ASSERT ContentProviderOperation for asserting RawContacts.VERSION number during updates.
/packages/apps/Contacts/tests/src/com/android/contacts/EntityDeltaTests.java
|
8d9767d79f9fe2a09ee6e981b1fede7e9863d62a |
|
02-Aug-2009 |
Jeff Sharkey <jsharkey@android.com> |
Refactor "Augmented" to "Delta" to make meaning clearer.
/packages/apps/Contacts/tests/src/com/android/contacts/EntityDeltaTests.java
|