| 513486cfb5d446f098b1c97d16932e51e316d1a7 |
|
13-Oct-2011 |
Ben Komalo <benkomalo@google.com> |
Fix per account starred mailboxes.
We always switched to combined view when we tapped "Starred" in a
mailbox list. This was confusing since tapping to show the mailbox list
will take you to the mailbox list for the combined view, even if there's
only one account on the device! Other confusing things happened like
showing coloured account chips, even if there's only one account.
This fixes it so that we pass the account ID when building the
selection. Lots of wiring to make it happen, but very little change
overall.
Bug: 5388326
Change-Id: I1fe52f211cceca0c1b26581e200f3c7adcd0734a
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| 2ac164f609faea134b8fa1d6c0ebc90ccda91166 |
|
01-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Fix bug 4982804 / nested fragment transaction
Post MessageOrderManager callbacks instead of calling them directly
to break the loop.
Change-Id: I033121f7bdbadf6edd7a0fab87b960b737da820e
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| 22d1a794cd9636634bb31689f53603c0ae64c522 |
|
29-Jun-2011 |
Makoto Onuki <omakoto@google.com> |
Newer/older + auto-advance for one-pane
- Moved MessageOrderManager code from 2-pabe to the base class.
- Most of the code is shared between 1-pane and 2-pane.
- Also fixed the bug where we re-created MessageOrderManager every time
the user taps newer/older, which was the reson the newer/older button
temporarily got disabled when you tapped them.
Before this CL we stopped MOM in uninstallMessageViewFragment, but now that
we don't reuse fragments this means we stops MOM when we remove the current
message view, and re-created a new one when a new message view is created.
Now we stop MOM when the right pane gets hidden (2pane) or when showing
the mailbox/message list (1pane).
- Also removed a now unused callback onMessageShown() from MessageViewFragment.
We used to update MOM on this event, but now we do this in
installMessageViweFramgment().
Bug 4575586
Change-Id: Idc4aba184f318e0c086afc29dcbe42364e2b51b3
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| 50d934360d51392ac2aa6f11de4d6e1446cf78c9 |
|
29-Jun-2011 |
Makoto Onuki <omakoto@google.com> |
Fix the "onPostExecute executed even when cancelled" issue
Renamed onPostExecute to onSuccess and made sure it won't called
if a task is cancelled in time.
Also removed isCancelled(). To implement it right we should make sure
that onPostExecute() isn't finished when setting mCancelled, but it's a bit
of a pain to implement right, and we don't really have to use it.
Change-Id: I3a0baf504506ffc4952a5553f7098a8415842fa3
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| 4a893e60b468e0b67db522c047fa7fab057cfd6f |
|
29-Jun-2011 |
Makoto Onuki <omakoto@google.com> |
Switch to EmailAsyncTask
Also remove the isCancelled test in onPostExecute, where it should
never return true.
Change-Id: Ica2b07db22d73769c2ead5f232f4890bd3bb87da
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| 4c4e4c3515c3e3300e03f90e02a0c520dc2dff32 |
|
13-May-2011 |
Makoto Onuki <omakoto@google.com> |
Clean up the method to build message list selection.
- Moved the method to EmailCommon.
- Use *_SELECTION for magic mailboxes
(meaning we now use subqueries for magic mailbox selections, rather than
building the mailbox ID list by ourselves)
Change-Id: I3ebf6af62fd912fea6faea0f75e05fc61c87af3b
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| 31d9acbf0623872f9d4a2b3210b5970854b654c7 |
|
12-Feb-2011 |
Marc Blank <mblank@google.com> |
Email split, part huit: Refactor constants, clean emailcommon
* There are three pieces to this CL (sorry):
1) Move and/or rename some constants into emailcommon
2) Move Utility to emailcommon, moving the few UI
related utilities back into Email (FolderProperties
and UiUtilities)
3) Remove all references to resources from emailcommon
* The three pieces relate in that, between them, they allow
the emailcommon static library to compile cleanly
Bug: 3442973
Change-Id: Ic5e3abaa2a1b36999e0b6653c6c2134ea1bd544f
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| a7bc0319a75184ad706bb35c049af107ac3688e6 |
|
10-Feb-2011 |
Marc Blank <mblank@google.com> |
Email split, part six: EmailContent
* Moved EmailContent to emailcommon
Change-Id: Ib3db1bfcfe74554c0e5afd3cfce6d72f26e9aeb9
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| 29d79adf4b4e716d40922d7e2008c5091460c143 |
|
06-Jan-2011 |
Andy Stadler <stadler@google.com> |
Fix cursor leaks when canceling AsyncTask
We discovered that AsyncTask.cancel() doesn't quite perform as expected;
In particular, if you call cancel() during a particularly slow background
worker, the result is discarded and onPostExecute() is never called. If
the result is an open cursor, then we "leak" by not closing it.
For AccountFolderList, which has a multi-step doInBackground():
1. Check for isCancelled() during the long doInBackground() which will
reduce the number of discarded cursors in the first place.
2. Check for isCancelled() at the end of the long doInBackground() and
if true, close the result cursors and return null.
3. In the existing isCancelled() code in onPostExecute(), close the
cursors.
For other AsyncTasks (with simpler configurations):
1. Check for isCancelled() at the end of doInBackground() and if true,
close the just-opened cursor and return null.
See also Change-Id: Ie63a3197af563baa8bb0fe6f1ef9423e281cbf4c
Bug: 3088870
Change-Id: I51b11bb5b23f209f8b61962500a063040484fd24
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| 931ca67a1f1baa0c1fd115124e35183c7786fc63 |
|
09-Nov-2010 |
Makoto Onuki <omakoto@google.com> |
New message view command layout
UI Changes:
- "Move", "Delete" and "Mark as unread" became action bar commands.
- The message view bottom panel now only has "newer" and "older" buttons,
with the current position in the message list. (shown as POS of TOTAL)
- The buttom panel is now shown only on portrait
Non UI changes
- MessageOrderManager now keeps track of the current cursor position
as well as the total message count.
- Fixed the "move_action" string, which was wrongly marked as non-translatable.
Bug 3169454
Change-Id: I599543f9e11000a4ee283d31fbd407b2ab53ac44
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| 7183724276e0d829fd01a5bc1f2f6d0f6b6a8818 |
|
09-Sep-2010 |
Makoto Onuki <omakoto@google.com> |
Don't check flagLoaded for outbox message list
We found a case where messages in outbox have flagLoaded=FLAG_LOADED_UNLOADED,
where it should be FLAG_LOADED_COMPLETE. Haven't found the root problem, but
remove the flagLoaded test to mitigate the problem.
Also moved the buildMailboxIdSelection call to a worker thread.
(this method issues some queries.)
Bug 2984285
Change-Id: I2a5be300fb3da703698512262cc38bea75d0f7ba
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| d6a2978857e0866d7441f8e140338477545d59a5 |
|
21-Jul-2010 |
Makoto Onuki <omakoto@google.com> |
First cut of two pane activity.
How to launch:
- Kick "Email 2 Pane" in the app drawer.
Major known issues:
- When you launches "Email 2 Pane", it starts directly; the logic in Welcom
won't be executed.
- There's no UI to add accounts. Use the old UI.
- There's no way to select non-default accounts.
- The on-screen buttons except for older/newer don't work.
- No contex menus work.
Change-Id: I38374acafafbae62e46f84294a7677e54686cfc2
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|
| de0a1c33c9507e96d554ca645d42d07f1241157e |
|
01-Jul-2010 |
Makoto Onuki <omakoto@google.com> |
Extract MessageListTask and make it self-contained.
Introducing MessageOrderManager which maintains a message list for
MessageView. It's used to tell if there is newer/older messages
in a mailbox, and the id of them.
Also, slightly related to this, moved mWaitForLoadMessageId to
ControllerResults where it should belong.
Change-Id: I84e32180c7e84a317f2204bb10ad7245ec022dca
/packages/apps/Email/src/com/android/email/activity/MessageOrderManager.java
|