| a841177ae2676d3ad92f82f8d378bc4915f238c9 |
|
30-Aug-2011 |
David Brown <dab@google.com> |
Fix a bunch of STOPSHIP comments, mostly about PII logging.
TESTED:
- normal outgoing call sequence: confirmed no PII in logs
- normal incoming call sequence: no PII there either
- verified the ITelephony call() and dial() APIs still work, and don't
log any PII either. (Added new tests to the CallDialTest activity for
these.)
- confirmed no remaining STOPSHIPs anywhere under apps/Phone
Bug: 5231962
Change-Id: I995bc58791f553f1a4ad51276b4b31603b196635
/packages/apps/Phone/tests/src/com/android/phone/tests/CallDialTest.java
|
| 65454c803eb305c4740885ad4995a871b034a58a |
|
22-Jun-2011 |
David Brown <dab@google.com> |
Use constants for URI schemes
Use SCHEME_* constants instead of hardcoding
"tel" / "sip" / "sms" / etc. everywhere.
Change-Id: I1858384909a54ae86a27a5f557a80ee185873927
/packages/apps/Phone/tests/src/com/android/phone/tests/CallDialTest.java
|
| 6c5cf46a2a31f0bffe9df36da8922971f7ee296b |
|
27-Oct-2010 |
David Brown <dab@google.com> |
Handle CALL intent gracefully on non-voice-capable devices
The exact details:
- For tel: URIs, just demote the CALL to a DIAL and relaunch it. That
hands it over to the Contacts app, which will bring up a UI letting you
do something useful with the phone number (like "Add to contacts" if it
isn't a contact yet.) See https://android-git.corp.google.com/g/76050
for the Contacts change.
- For anything other than a tel: URI, since the Contacts app can't do
anything useful with those (yet) we just display a generic "Voice
calling not supported" dialog (using basically the same wording as the
dialog that currently comes up if you try making a SIP call on a device
that doesn't support SIP.)
- The above applies only to the CALL intent. The other call-related
intents (CALL_PRIVILEGED and CALL_EMERGENCY) are only used internally by
built-in apps, so they should never get used in the first place on a
non-voice-capable device. So if we *do* ever see these, we log a
warning and show the generic dialog.
- Removed the "@android:style/Theme.NoDisplay" them from
OutgoingCallBroadcaster so that the new dialog will get the correct
system-wide default theme. This was irrelevant all along since
OutgoingCallBroadcaster never brought up any UI anyway.
- Finally, since there should now be no way to ever reach the InCallScreen
on non-voice-capable devices, throw an exception if that ever happens
(to make sure we notice.) There's a STOPSHIP comment to turn that into
just a warning before we ship.
TESTED on Stingray:
- Confirmed CALL and DIAL behavior using the CallDialTest activity from
change https://android-git.corp.google.com/g/75710 :
(1) tel: intent
==> CALL and DIAL both bring up the dialog from the
Contacts app with the options "Add to contacts" and "Close".
(2) sip: intent:
==> CALL brings up a generic "Voice calling not supported"
dialog from the phone app. DIAL throws an
ActivityNotFoundException just like on regular phones (since
the dialer has never handled sip: URIs.)
(3) blank intent (with no data)
==> CALL throws ActivityNotFoundException. DIAL is absorbed by
the contacts app but does nothing (since "bring up an empty
dialer" is meaningless on a non-voice-capable device.
- Also confirmed correct behavior of the generic "Voice calling not
supported" dialog:
- tap OK button
- tap outside the dialog
- press BACK
- press HOME
All of these successfully dismiss the dialog.
- Also tested a bunch of scenarios on Stingray to confirm that we don't ever
try to create the InCallScreen:
- regular boot
- manually killing and restarting the phone app
- after a CALL intent
- during an OTASP call
Bug: 3116625
Change-Id: I10d490c89e881572efb3e39b50c7b47338a7b5f5
/packages/apps/Phone/tests/src/com/android/phone/tests/CallDialTest.java
|
| 0e9303c0e8b526ae6d1d8181bf66e85aa4b51836 |
|
22-Oct-2010 |
David Brown <dab@google.com> |
Add CALL/DIAL test activity.
This is a test activity that mimics the behavior of 3rd party apps firing
off CALL and DIAL intents, which will be useful when working on bugs
3116684 and/or 3116625 (which cover handling DIAL and CALL gracefully on
non-voice-capable devices.)
Note this activity is part of com.android.phone.tests, which is not
installed by default, and it's not in the LAUNCHER category either. So to
run it you need to manually build apps/Phone and do an "adb sync", and
then "adb shell am start -n com.android.phone.tests/.CallDialTest".
Bug: 3116625
Change-Id: Ibadbd36bdb06121611a501acfa20ad42ba3f38d7
/packages/apps/Phone/tests/src/com/android/phone/tests/CallDialTest.java
|