aeaba441ddb05dede8bd86291ca78f42d670d54c |
|
09-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Automatically add a geocoded location to entries in the call log. This change adds a geocoded location value to entries added to the call log. One limitation is that this is unaware of changes to the locale. We needed to decide whether this is fine or if we should update the stored geocode on locale changes. Bug: 5129581 Change-Id: I2ad1b3fbd24491df2febf3e1fd615c16dd74398f
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
eeffa7edb048e785ebc665c830dc84d87f174b07 |
|
04-Aug-2011 |
Debashish Chatterjee <debashishc@google.com> |
Allow read-only sharing of Uri in voicemail content provider. Since we perform our own permission check, uri permission check done by the content resolver is not sufficient. Our implementation of the content provider should also explicitly check for uri level permission. This is needed to allow sharing of voicemail uri from the contacts app. In a follow up change we will allow sharing of URIs only to those apps that has ALL permission. Right now the provider definition does not allow sharing of uri. Bug: 4961053 Change-Id: I5af53ee76ea10fa5f45c8cdcb95c773cc7ad138e
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
0b442c4154c77f39aeb84216f433e5bd11cbf79e |
|
04-Aug-2011 |
Debashish Chatterjee <debashishc@google.com> |
Fixed broken VoicemailContentProviderTest. The tests were broken in two areas following recent changes - permission READ_WRITE_OWN_VOICEMAIL was renamed to ADD_VOICEMAIL in the production code, but was not renamed in test. - Two new synthetic fields DISPLAY_NAME and SIZE were added in the production code but the expected num fields were not updated in the tests. Change-Id: I96c1997af8dadb5a95d7224b0364cf48e6244977
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
c6eb4fe44502116f834fadcc54214b3fa93ff564 |
|
28-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
Delete voicemail data when source package is uninstalled. The deletion of voicemail data for the uninstalled package is done through a service. The PackageIntentReceiver just forwards the package removal intent to the service after sanity check that the intent is really for an uninstalled package. The logic to check whether the intent should trigger a clean up is repeated in VoicemailCleanupService as well. This provides an extra safety net and and also lets the unit test cover this functionality. Bug: 5056159 Change-Id: Id7315a1318d510b50878f26c2e0d380c1920ee4e
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
d558ccc921460ac382850a8e6e2e668f3a2b9b26 |
|
29-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
No more use audio mime type for voicemail uris. This makes the uri handling simpler, as we voicemail uris can now only be of item or dir and does not depend on the content. This also avoids strict mode violation when getType is called from UI thread. There is no change needed in the contacts app because the URI mime type is right now used by the app. Bug: 5090052 Change-Id: Ie2e502f9b09465dc343e873d43e206aaad8b6076
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
51d1da962292ecef21abdf7e41abfdb7f1d72fcd |
|
27-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
Merge "Improvements in voicemail broadcast notifications."
|
94cc8c65bc46f60b912091d3037376e15b74da0f |
|
26-Jul-2011 |
Flavio Lerda <flerda@google.com> |
Do not expose the NEW column in the Voicemail provider. We added the IS_READ column, so that we can distinguish between items that are new and items that have not been read (or heard, for voicemail). However, there is no reason to expose the NEW status of voicemail, since that is about whether the user should be notified and it is handled entirely by the content provider and Contacts application. This is part of the changes needed to fix notifications for voicemails. Bug: 5036195 Change-Id: I74d760a73d5ffbbb6eb26f2dbe7c7ca2a92ad2d6
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
9a5dfea6acfb15cff4654e10ea96ecd50a4d15b5 |
|
26-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
Fixed VoicemailProviderTest. A recent change added a new 'IS_READ' field into the content provider but this test was missed to be updated for the number of columns expected out of the content provider. Change-Id: I03885e2b2ac827fe04e06e528e9ffd51823004ee
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
929a04e2830e30718930d96335dfb0a729b6ab91 |
|
23-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
Improvements in voicemail broadcast notifications. This change fixes two primary issues: 1) If a voicemail record is modified through call log provider, a voicemail provider notification is now generated. 2) voicemail notifications are now sent with permission ALL if the receiving component packages is not the owner of the modified record. This ensures that a voicemail source (having OWN permission) gets notified only of changes for records that it owns. But a package that has ALL permissions get notified of everything, A new interface DatabaseModifier is now used by both voicemail as well as calllog provider to perform any operations that can modify the underlying table. DbModifierWithVmNotification implementation of this interface fires relevant notifications under the hoods. All logic related to sending notifications is now moved from VoicemailContentProvider to this new class. bulkInsert has no special treatment anymore. We now fall back to the framework's default implementation. It was complicated to optimize for provider_changed events for bulk insert when using the DatabaseModifier interface. TODO: I am yet to write unit tests for broadcast intents. I have done manual testing to make sure that they work. Also the existing unit tests pass, proving that none of the existing content provider operations are broken by using the DatabaseModifier wrapper. Bug: 5060354 Bug: 4974222 Change-Id: I0935105f146a71abeffbde634d79f8806b8e0ed2
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
b2197b235e3d96e7f70c24d548b7dac52dab88d8 |
|
21-Jul-2011 |
Flavio Lerda <flerda@google.com> |
Implement IS_READ column in content providers. Add support for the IS_READ column in the call log and voicemail content providers. This columns will be used to store whether a call log entry (currently only voicemail) has been read or otherwise consumed by the user. Bug: 5036195 Change-Id: I06840f9820f7d568a738c0307f4294c2b8c66031
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
9cf06e7bcb0be759f1c930412fd2e41eba4f5f03 |
|
06-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
VoicemailStatus content provider implementation. - New Voicemail.Delegate implementation for voicemail_status table. - modified openFile() interface to simplify the interaction. - UridData now has a getWhereClause() method that can be used by both the tables to set selection clause based on the uriData. - Imrpoved permission checks for ContentValues for update/insert/bulkinsert operations. Bug:4968719 Change-Id: I6a6173c58d9929ef952c7d7e95afb8bc5ff4157b
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
4b571ba0de4fac4ff9d2a4277032b8c6548fdbfa |
|
05-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
Refactored VoicemailContentProvider to simplify using multiple tables. This is needed to simplify the voicemail provider to be able to serve operations on the voicemail_status table as well. The idea is to retain all common functionality related to voicemail permission check etc in the main VoicemailContentProvider class. And delegate database level operations to another class that only deals with functionality speficic to the underlying table. In the favor of code reuse the interaction between voicemail_content_provider and voicemail_table_implementations is both ways. VoicemailTable interface defines the operations exposed by both sides. I have also added a couple of new test cases to cover getType() and source_package check in the uri. Old test cases continue to pass to prove that the refactoring did not break any functionality. Change-Id: I4cb031234c2f5746084c51557e2ba0edbaf3d6de
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
e36e13b9e92759bb861a10ff22195853359c267d |
|
04-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
Modified voicemail provider to accept source_package as a param. Voicemail provider now no more supports /source/ path. Also stopped using deprecated fields of VoicemailContract. Change-Id: Ieab08781bca6ec571f29c56ca55d84a8fd18547b
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
06f995b614e0ebe59ff75f170e20ca96c9b17f0c |
|
01-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
Send broadcast intents to specific component instead of package. This avoids sending duplicate notification to the same package if it has more than components registered for the same broadcast. Change-Id: I93744aebc9a4800c5ce1fd60fb1468382f55934e
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
975d52af754e6f05089fcd9f7066df05c290c3b7 |
|
01-Jul-2011 |
Debashish Chatterjee <debashishc@google.com> |
Fixed VoicemailProviderTest. A recent change in voicemail content provider used the package manager queryBroadcastReceivers() to query the receiving packages of the broadcast intent. However, mock package manager used in the test env does not support this operation and throws an exception. The fix is to wrap this method within the content provider implementation and stub the wrapper method in the test. Change-Id: Ief4887f1379614466ea6471cf7b132ef873550ba
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
00e7c94b70f4b477653534dbe559d1759d796157 |
|
16-Jun-2011 |
Debashish Chatterjee <debashishc@google.com> |
Added checks in voicemail provider to not expose call_log fields. - Voicemail provider now has check to ensure that no field outside of its projection is accesible. - Moved functionality to check ContentValues against a projection map to DbQueryUtils. - Associated test cases. Change-Id: I23033c96f74f0ab981152f70e585c69ba5284602
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|
1975b56a3368b4b7684429ffa79e7b9dbc35b475 |
|
16-Jun-2011 |
Debashish Chatterjee <debashishc@google.com> |
Unit tests for voicemail provider. These tests cover basic functionality of the provider including permission checks and media content input/output. The key functionality that is yet to be tested is provider change broadcast intents. This requires us to use a mocking framework, and we are yet to finalize on which one we will use. Change-Id: I2304309c4fc109cc1e0b969ede33d8268a4d4194
/packages/providers/ContactsProvider/tests/src/com/android/providers/contacts/VoicemailProviderTest.java
|