| 731f861593f3de69e8b3070b46e589cab42341f9 |
|
07-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Share contact look up between call log and call details.
Currently, it is possible to get a contact be correctly identified in
the call log, but not in the details, because the logic to do the
look-up are completely separate.
For example, SIP contacts are correctly looked up by the call log, but
not by the details. Moreover, we recently fixed a few bugs in the logic
for looking up contacts in the call log, that have not been propagated
to the call details because the code is independent.
This commit moves the whole logic of looking up a contact given a number
(which may be a SIP number) from the CallLogAdapter into its own class.
Then, CallDetailActivity can use that to look up the contact in a way
that is guaranteed to yield the same result.
Bug: 5415134
Change-Id: I73acc39ba5dc65ecce6861f210224304fd91822d
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfo.java
|
| 74628686391735dac1b13409e7f61e9f1514ea20 |
|
06-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Remove strict mode violation with number formatting.
The call log is currently performing formatting on phone numbers in the
main thread (during bind view).
At the same time, however, we are always doing a background request to
look-up the contacts. Move the formatting call to the background thread.
In order for the right information to be shown as soon as the call log
is opened, we also need to store this information in our cached values
in the database. This means that the number will show unformatted the
very first time, and then updated once the background require is
completed.
Bug: 5316982
Change-Id: I20d1971948afa33c7825f0bd38a9520021f75378
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfo.java
|
| 55e30c7a0feb8fe533b489c6c053454bfb2eb155 |
|
05-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Revert "Remove strict mode violation with number formatting."
This reverts commit bbe62216b5163ec53eb990218bdbe608631dd8e7
Broke the build.
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfo.java
|
| bbe62216b5163ec53eb990218bdbe608631dd8e7 |
|
28-Sep-2011 |
Flavio Lerda <flerda@google.com> |
Remove strict mode violation with number formatting.
The call log is currently performing formatting on phone numbers in the
main thread (during bind view).
At the same time, however, we are always doing a background request to
look-up the contacts. Move the formatting call to the background thread.
In order for the right information to be shown as soon as the call log
is opened, we also need to store this information in our cached values
in the database. This means that the number will show unformatted the
very first time, and then updated once the background require is
completed.
Bug: 5316982
Change-Id: If1e4990243e73af6c9519fbf5e76a5d234e99e15
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfo.java
|
| 4813c270af2b5d904437757807541f1f5e19bb93 |
|
19-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Use the call log to cache additional contact information.
The new version of the call log needs a bit more information about the
matching contact (if any) to render its entries.
This change both uses the newly added columns in the call log to lookup
this values and stores the updated values back into the call log.
These values are used for setting up the quick contact badge and
formatting the phone number.
This also fixes a few smaller issues:
- the phone number shown used to change format between the initially set
value to the one obtained from the contact: this value is now cached.
- we were using -1 as the id of a non-existing contact, but 0 is
actually the value used elsewhere for this, so stick to that.
- make sure we use the cached value from the call log for formatting.
- update the call log if there was no previous value.
- introduce a UriUtils with a couple of useful functions for handling
URIs.
Bug: 5101753
Change-Id: I22f2b03b234da91e02dbeebe11a94c2f56295a3d
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfo.java
|
| 5ee899e689a8ddcc500655f24b0bcdfdbf401702 |
|
23-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Use photo id when available.
Photo id is a long that uniquely identifies a photo associated with a
contact. It only handles low-res photos, but that's what's used in the
call log anyway.
This commit uses photo ids instead of thumbnail URIs if the photo id is
available, since that's more efficient for storage purposes. In fact, if
a photo id is available it does not even bother storing the URI.
This will make a significant difference in terms of storage when I will
use the call log table to store cached contact information, including
the photo id and thumbnail URI.
Bug: 5101753
Change-Id: Ia60e3ce33763fe3744208763befbaf4489d60bdd
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfo.java
|
| 071aa0d0511cbffac933539eaa484860fae2132d |
|
22-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Use Contact URIs instead of contact ids.
Contact ids are not guaranteed to be stable.
Instead use a contact URI (which contains both a lookup key and a
contact id, used only as a hint).
This change is needed for caching, since we do not what to cache the
unstable contact ids.
Bug: 5101753
Change-Id: I34814c8935e706ee898adcedc39c4baeea147d67
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfo.java
|
| 568ad27e706d7c75dd7412e34c2236c772704a04 |
|
13-Aug-2011 |
Flavio Lerda <flerda@google.com> |
Extract nested classes from CallLogFragment.
This should help making the changes to the CallLogFragment easier to
make as there is less code around.
This has been done entired using Eclipse's refactoring with no manual
changes.
In the process, a couple of fields have been expanded from private to
package, because, while their were private, they were being used by
the parent/nested class anyway. I will fix those in a follow-up.
Bug: 5101753
Change-Id: Id46e18cfa86939100342daa020430063959dfcfc
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfo.java
|