1de396f6df89363169d3a2e61a61fa98d12c1ef8 |
|
23-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Refactor code 1) introduce VCardProperty and make use of it everywhere Previously we had had two structures for it: VCardParserImpl_V21.PropertyData and VCardEntry#Property. The former was for holding raw data for property, while the latter was for holding resultant (encoded) values. Apparently we can share same structure. To do so, we need to let VCardInterpreter pass the structure to interpreter side, instead of splitting them into smaller pieces by using several propertyXXX() calls. Thus this change introduces onPropertyCreated(VCardProperty) in lieu of propertyXXX(). Now vCard parser side is responsible for encoding Quoted-Printable, BASE64, and several charsets. Users are still able to do them manually by using VCardEntry#getRawValue(). 2) add better handling for data inside VCardEntry Now VCardEntry has so many fields that it is harder to iterate those data, while the iteration itself is common use case for it. At least three functionalities are now using iteration: toString(), isEmpty(), and constructInsertOperations(). This change introduces inner iterator functionality. VCardEntry.EntryElementIterator allows users to implement their own iteration logic. VCardEntry#iterateAllData(VCardEntry.EntryElementIterator) iterates all data inside VCardEntry and pass them into the inner iterator. 3) make VCardParser abstract class VCardParser should provide some utility functionality like VCardParser#getInstance(), while currently users have to choose one of inherited classes like VCardParser_V21, which is hindering encapsulation. Currently no external library implements VCardParser, so this change isn't so harmful. Bug: 4167593 Bug: 4066223 Change-Id: Ic6bb453cf733cf1de356789b36dd90521dceff56
/frameworks/opt/vcard/java/com/android/vcard/VCardEntryConstructor.java
|
48dd8e86a81d2ab40eb762975c8211c225002bf0 |
|
22-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Tolerate nested vCard. vCard 2.1 requires to handle nest (or grouping) while our parser has not supported it well. One support we have had is ignoring top element when FLAG_TORELATE_NEST is specified, which isn't appropriate. e.g. BEGIN:VCARD X-VENDER-SPECIFIC-META-INFO:XXXX ... BEGIN:VCARD (Actual content) END:VCARD END:VCARD This change lets the vCard lib import nested vCard. One problem around handling the case above is that, after having this change, we'll get two vCard elements instead of one, as the top element isn't ignored on parser level any more, while we don't want the top-level data. To solve the problem, this change also makes vCard importer ignore such empty data. This changes just flattens nested vCard. Caller needs to take care of grouping/nest case using VCardEntry#getChildren() if it wants to support grouping feature. - introduce "children" into VCardEntry, which enables users to handle nested vCard on their side. - make vCard parsers accept nest cases. - make vCard interpreters handle nest cases. - make VCardEntry ignore empty data during constructing insert opertions. - make tests accept nest cases. - add additional test cases for verifying more details. - add debug string capability. - remove codes for performance measurement. Bug: 4066223 Change-Id: Id8af659c2cc0bb0db59c8de239d9d95e9d440089
/frameworks/opt/vcard/java/com/android/vcard/VCardEntryConstructor.java
|
02117b3d19787ff65486b9f9db8abd338ae4c9f9 |
|
11-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Use same TAG in vCard Tiny cleanups are included Bug: 4066223 Change-Id: I0b121e93ea5c624325d44b8aa6bab42d9a9a24fb
/frameworks/opt/vcard/java/com/android/vcard/VCardEntryConstructor.java
|
9919ad2126c06dbf2eb54a11e6158f87f316bc22 |
|
10-Feb-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Stop using private APIs as much as possible. - remove CharsetUtils stuffs - remove private APIs in PhoneNumberUtils/TextUtils. We keep the hidden flag "Data.FOR_EXPORT_ONLY", so this code still needs access to private API. We don't remove it right now since we may still need it while we confirmed that the other stuffs are "ok" to be removed. Some more investigation will be needed in the future to remove the flag. Bug: 3143497 Change-Id: I074a7798d2208c3e14a524bd5f307a91ac50f735
/frameworks/opt/vcard/java/com/android/vcard/VCardEntryConstructor.java
|
58ca5f9943bb5c8aeeab3150ac96f1143dfd86ba |
|
18-Aug-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Add a few tests confirming the behavior of vCard library. Fix test code as it doesn't convert multi-byte params to UTF-8 properly. Modified the content of v30_commpa_separated.vcf, as the original intent of the file is not realistic (I've never seen this kind of complicated form). Also, without successfully parsing it, we torelate it. Added comma-separated-types cases instead , as this might be a bit more serious (a whole parse may fail due to this form of types). Change-Id: I1403e1c1d81d4325b25ad12ff143a76f0b9ab3a7
/frameworks/opt/vcard/java/com/android/vcard/VCardEntryConstructor.java
|
2bf85a1a15a3175119ab8415fc590fd5fe3d0752 |
|
18-Aug-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Make vCard importer/exporter aware of multi-byte parameters. Based on the change Ic877940242d87ef918bf8d4dac601d37b296259b Bug: 2922186 Change-Id: Id4cd674a0565670023b7bb1010b21d8349dd4daa
/frameworks/opt/vcard/java/com/android/vcard/VCardEntryConstructor.java
|
d5a8fc2a35c69fc34df35fd545ccf83d548ba50c |
|
13-Jul-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Rename a test file for comma-separated values in VALUE fields. Also add TODO for supporting the values. Bug: 2835996 Change-Id: I02c9d8735cee943e307fbbe75f0635bad636c396
/frameworks/opt/vcard/java/com/android/vcard/VCardEntryConstructor.java
|
58610106ce61adad9b1caa1fe9f7925c3e938bab |
|
08-Jun-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Supress unnecessary warning. Make VCardSourceDetector#PARSE_TYPE_UNKNOWN public for letting it available for default estimated type. Change-Id: I77a464ea22c2565f1d077b94db9f29233031297e
/frameworks/opt/vcard/java/com/android/vcard/VCardEntryConstructor.java
|
4199c54c527330ac01699b176e7bca186a3aa3a4 |
|
04-Jun-2010 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move vCard code in platform/framework/base to platform/framework/opt/vcard. See also 33m4347ad6 in platform/framework/base. Bug: 2735156 Change-Id: I64b1bd42515a32b354396a030ec77d1ea3c5a08c
/frameworks/opt/vcard/java/com/android/vcard/VCardEntryConstructor.java
|