| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 82a4f4408b74e193b43a12dc8e16c946a93bae4a |
|
08-May-2012 |
Makoto Onuki <omakoto@google.com> |
Clarify AccountType.resPackageName/summaryResPackageName
Gave them clearer names and added javadoc.
And added a workaround for the fact that the view notification
service for the google account type is implemented in the sync
adapter, not in the authenticator.
This really needs further clean up.
Change-Id: I567656393fab30293c831fac802884dc84daf861
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 8ca93ed0938e00ee94b03e6d609895593cfdbdbd |
|
23-Apr-2012 |
Adam Powell <adamp@google.com> |
Navigation adjustment for updated design guidelines and QuickContact cards
Bug 6362611
Change QuickContactActivity to task affinity "" to keep it from starting
orphaned/confused tasks.
Launch ContactDetailActivity in the same task from QuickContactActivity.
Launch app-supplied intents from QuickContactActivity in the same task.
Clear the QuickContactActivity task when launching it from a launcher
shortcut or widget. This prevents activities launched from the
finished QuickContactActivity from hanging around as the root and
failing to be reset.
Remove app-specific Up navigation code from ContactDetailActivity and
let the JB framework handle it automatically.
Change-Id: I4abebcb135b2d3269039b3307a49115c13528295
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 5c3a0a1440625fab859aab420cb08bc0276358a0 |
|
08-Nov-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix wrong contact being selected after editing (after a search)
- The problem is that after finding a contact via search
and editing that contact, we launch a VIEW intent to view
the contact. Then sometimes, that contact is not in the
current contact filter, so we may have to enter single contact
mode.
To avoid that, go back to the HC functionality of preserving
search mode. Now after editing, we return to the PeopleActivity
and preserve search mode if that's where we came from.
This was the relevant change from early ICS that is being
partially reverted:
Ibbaaccb03ac7961784dfa7b15c246b8d6f6489a4
The reason it was changed was to support viewing the contact
after editing a contact when the edit request came from a 3rd
party app. This still works with this change by adding
an intent extra in ContactEditorActivity.
- After the editing is done, only launch the VIEW intent
for the contact if we didn't come from the detail page for
that contact (on phone and tablet). We can just finish
the editor activity. This saves some time with setup / configuring
fragments because we don't have to resolve the VIEW intent
(i.e. On tablet, previously the VIEW intent launched the
ContactDetailActivity --> redirected to PeopleActivity -->
resolved intent to show the right contact.
Now we can just receive the onActivityResult and refresh
the page).
- Renamed ContactDetailActivity intent key to be consistent
Bug: 5542197
Change-Id: Ieaa9c147beeaa7c40f34fc1689858642b47fdbf9
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 15586e733fe0500ffe336fcdc6eabdb35f996402 |
|
21-Sep-2011 |
Erik <epastern@google.com> |
b/5335419 Go up one level at a time
Change-Id: I5a6597896588a2ff8372b8b3877dc6f00abc074c
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 8d5abcb71ed4d9671b9066b9e3ffaf5372d2b22c |
|
03-Sep-2011 |
Makoto Onuki <omakoto@google.com> |
Make sure only People and Dialtacts responds to search key
- Remove the default search activity meta-data from manifest, so the old-style
search dialog won't show up when the serach key is pressed. It was for
pre-HC style search UI. Now the search key only works on people and dialtacts,
which implement either startSearch or onSearchRequested.
- Removed all the startSearch/onSearchRequested methods which are now
unnecessary.
- Also removed startSearch() in some fragmets. They're not used.
- Tested some viewer/editor/picker activities, and also both dialtacts and
people, the launcher search box, and the SEARCH intent, on both the phone
and the tablet (except dialtacts on tablet). All looking good.
Bug 5230790
Change-Id: If269df74ae218707daa5b7039439c6fea2575e8d
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| d78ee90c0d4d93b82ad440396e87ae4f47f53e93 |
|
15-Aug-2011 |
Daniel Lehmann <lehmannd@google.com> |
Several DB changes as requested by ES
- Switch from resource ids to names to prevent breakage on package upgrade
Bug:5135277
- Add SYNC1...SYNC4 columns to StreamItems and StreamItemPhotos
Bug:5119385
- Remove ACTION, ACTION_URI from Groups, StreamItems and StreamItemPhotos
(this reduces db size and prevents click intercepting)
Bug:5135808
- Add some raw-contact fields to the StreamItem and StreamItemPhotos query
Bug:5134081
Doing those changes in one block to prevent too many db upgrade steps
Change-Id: I4c90742580c86203a1686bb625c026438ed19b8f
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 1390f85d3776dd9ad9d38f611f3a0d4ed59f6249 |
|
27-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Modify action bar for group editor and group card
- Remove home icon in group card
- Change done/cancel buttons in editor
- Remove old honeycomb style on editor activities
and have it use the new split style solid action bar one
Bug: 5081353
Change-Id: Ie39f7f1ea5bd80d5246158442325207effd6aff7
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| b7ae952816e330e4e1f7e148df1b6dbb52f28f5a |
|
25-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Make "up" button different from "back" button
- Explicitly go to PeopleActivity when "up" is pressed
- Use flag FLAG_ACTIVITY_CLEAR_TOP to prevent having
PeopleActivity multiple times in the back stack
- Use PeopleActivity.class because we don't want to use
a URI like LIST_ALL_CONTACTS otherwise it will switch
the tab or the account filter that has been last set
by the user
Bug: 5071475
Change-Id: Id6f768db3838fa0bc007feda89a92e3d36c8a694
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 703cda7119b710446f7abc38843043b7cbbf3a47 |
|
16-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Show group source on group detail page
- Show group source button as:
* scrolling header item in ListView for phone portrait
* non-scrolling header outside of ListView for tablet landscape
and portrait (b/c can't addHeaderView on ListView after
the adapter is set and we reuse the GroupDetailFragment
on the tablet)
* custom action bar button in phone landscape
- Tested by inserting an action and action_uri for one group
Change-Id: I29abad130dac57e3077fd4f3e546a451f579b394
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 53b427b3dc6f04340133b2da135b3f5efea4de11 |
|
17-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Make search less magical
- Remove PeopleActivity.mSearchMode. Instead, always ask ActionBarAdapter
the current mode.
- Don't use the default search behavior (i.e. send a new intent) on 1-pane.
Now 1-pane and 2-pane go through the same path for the search menu item
and for the search key.
i.e. when search key is pressed, show the search view (only on 1-pane),
set focus, turn the "all" list into the search mode too.
(and the "all" list should initially show all contantacts eventually, but
it's another issue which hasn't been fixed yet.)
- Remove dead branches.
- Instead of startSearch, override onSearchRequested(), which is the preferred
way of implementing a custom search action.
Change-Id: I4fd15a7f3164a3832df21b8fa1fb215e53d1a3e1
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 43fbbc1e5bbc295d0be5033a002e9f532fdfb119 |
|
15-Jul-2011 |
Makoto Onuki <omakoto@google.com> |
Disable search key press on 1-pane detail/editor activities
These activities don't have the search menu item, so the search key shouldn't
work.
(The behavior was weird anyway... e.g. it worked differently on
ContactDetailActivity and GroupDetailActivity...)
Bug 5032530
Change-Id: If3504cbd3e5cf027d43eec68d8f89e41bd7d324c
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 4e2bb32000f391ceb0de7309a159bee5d8e04fc5 |
|
12-Jul-2011 |
Frank Sposaro <sposaro@google.com> |
Pressing a group member on phone takes you to contact card.
Bug: 5016808
Change-Id: I59990fd0301bfa4934f8add568b40b080eb70e02
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 267073407439d7df012a2e0df577e39a1f89c4a8 |
|
08-Jul-2011 |
Isaac Katzenelson <isaack@android.com> |
Remove deleted groups from GroupBrowserList
Change-Id: Iea7435c6b1f569dd8ac5416b35470b9ae2f48761
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 4ec198790236ab4be6bc5d73441215b684832618 |
|
06-Jul-2011 |
Isaac Katzenelson <isaack@android.com> |
Made "up" button go back.
Fixed on Group View, Contact View and Contact Option View
Change-Id: I6ee4de75dee59b0bc35a611adbe837cebe7ed722
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| 72a8e70ef935935fdbb26c53f760be59bbdfe824 |
|
04-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Group editor for phone
- Instead of a 2-column page, make all the fields stack vertically
for the phone layout
- Since new intents for groups will not be supported in this release,
we can just call into GroupEditorActivity directly
Change-Id: I6b81b26b030ce9815d5f2c2c0d52e10d842970b6
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| c6b8afe730255537978f2c938cca6986cae63c34 |
|
23-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Group editor on tablet
- Allow autocomplete to add new members which presents
the user with suggestions from the raw_contacts table
with the same account name and type as the group
- Hook up the "new" and "edit" group buttons on the tablet
- Once the user exits the editor, update the group list
and scroll the group list to the group that was just edited
- Allow rename of groups (make the names of read-only groups
not editable)
- Allow removal of members
- Hook up the done / cancel / up / back buttons
- TODO: Be able to create a new group + add new members
in the same transaction. Then the new group editor
will allow adding members at the same time. Currently
you can only add a name to a new group. Once it's created,
then you can go and edit the membership.
- TODO: Bulk add/remove members in one transaction when the
user exits the editor. Currently it's saving the change
after you modify the membership list (even before you hit
the "Done" button in the editor).
- TODO: Add member status message and chat presence
- TODO: Add UI for non-editable groups
Change-Id: I1f32a28862c358b8bd1469666743cd240d28f80b
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| be18de05d6f6a107c552e369bce58f51c946fde7 |
|
07-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
Add group detail fragment on tablet
- Add action bar on GroupDetailActivity, title, and subtitle
- Make everything use the groupUri instead of passing around
account name, type, group Id, and group title
- Fix some of the callback listeners between the group fragments
and group activities
- Add factory methods to ContactListFilter
Change-Id: I63066ea6eefde1e57562b6396d6dc590ed023c84
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|
| fd8cdedb816cb1fc5894e2e3c5e144ff16b90b7c |
|
11-May-2011 |
Katherine Kuan <katherinekuan@google.com> |
Group detail page and list of members
- Click on group in group list goes to a detail page
- Temporarily show members, TODO: Move list as
an expanded list in group browser activity
- TODO: Populate detail page with group info and
group actions
Bug: 4413116
Change-Id: I114d276f96aed318307d185910ae8799228262c9
/packages/apps/Contacts/src/com/android/contacts/activities/GroupDetailActivity.java
|