History log of /packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
e0b2f1e2d01d1ac52ba207dc7ce76971d853298e 12-Jun-2012 Chiao Cheng <chiaocheng@google.com> Global import order fix.

Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements

Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.

Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
fadd5e1f1845b8d98e247bbd30535928dc5e0f81 02-Dec-2011 Daisuke Miyakawa <dmiyakawa@google.com> Use NEW_TASK flag for launching in-call UI

To make Intent creation consistent, prepare relevant methods in
ContactsUtils and use them everywhere.

Bug: 5691827
Change-Id: I41509bfc7d914ba87ab614450b53fc93ce0eba4b
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
76821d02351701b3829aa5754dd9a86e417f635f 10-Oct-2011 Flavio Lerda <flerda@google.com> Only show recent items in the new section.

This commit limits the set of items in the new section to items that
have been receiving within the last 7 days.

In order to make the unread items more visible even when they are not in
the new section, use highlighting on them, both in the text and the play
icon.

Bug: 5403047
Change-Id: I577c58bfcb9ef2031839092d50f41c357c7decba
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
151d6bd83b2bdad993f9fe943f0d2608d99de94c 30-Sep-2011 Flavio Lerda <flerda@google.com> Merge "Updates disable states for voicemail."
5b32cd5d397675fff2189f6b1662695cc33a1348 30-Sep-2011 Flavio Lerda <flerda@google.com> Updates disable states for voicemail.

Use updated disabled assets for voicemail.
Use the correct disable state for the play icon.
Do not show a thumb or already played bar when seek bar is disabled.

Bug: 5282585
Change-Id: I522793b55b36b03e7af6b0195f4005432446e8f8
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
7ecd4db75649634acddc42b64f6bf933d2f37a44 28-Sep-2011 Flavio Lerda <flerda@google.com> Improve accessibility of call log's call button.

Use the contact name or phone number is the content description for the
call button, so that it is clear which person or number will be dialed.

Bug: 5276039
Change-Id: Icb63d4a26a978b008af470dde12e5e7e93a242b6
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
6af176fa4156446c8522642575fc7c2f98c39e74 05-Sep-2011 Flavio Lerda <flerda@google.com> Remove unheard icon next to voicemail.

Since unheard voicemails are anyway in the top "New" section, there is no
need to have the extra icon.

Moreover, this means we do not have two similar looking icons next to
each other, which make the iconography harder to understand: one meant
"unheard message", the other meant "press to play".

Bug: 5254001
Change-Id: Ie0e40a87435442a0f829c544d83ad24bd6fb7f17
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
9b81f1d888772086e49fa39bfa3304f9e072614c 09-Aug-2011 Flavio Lerda <flerda@google.com> Reduce number of views in call log.

Use only one image for the secondary action and configure it at
run-time.

Bug: 5099652
Change-Id: Ibcc9f2f0abbf4d7d409ba5d574d88387836fc0bf
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
fe17026100674b204f3b4fc6cb5a61f51ac99ec6 03-Aug-2011 Flavio Lerda <flerda@google.com> Use a single text view for count and date of calls.

This further reduces the number of views needed to render the call log.

At the same time, fix a few minor issues that are needed for pixel
perfect UI:
- Do not show the text when the item is new.
- Instead, for new items, highlight the date in the color associated
with the item (blue for voicemail, red for missed calls).
- Do not put a separating slash between the count and the date.

Bug: 5099652
Change-Id: I18b71463e7398f00f0fe8fecbeb334b67d618312
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
b88abaaf3e733a9daf681277b7e5e8e58c015462 03-Aug-2011 Flavio Lerda <flerda@google.com> Use simple TextView for call details header.

Instead of the using the more complex call_log_phone_call_details
layout, use just a text view, since all we want to show is the name (or
number) of the person who called.

Bug: 5099652
Change-Id: I408b5ffaeea09c0efe2631bd317d1ea640be294f
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
405695664582b4989cffcf054bf1aceb83dec437 22-Jul-2011 Flavio Lerda <flerda@google.com> Updates to visual design.

- Use sizes from spec.
- Show only contact name in call details header.
- Add spacing between contact icons.
- Updates a few assets.
- Add contentDescription to a number of elements.
- Use @dimen instead of ?attr for dimensions.

Bug: 4989127
Bug: 4989128
Bug: 5039572
Bug: 5038409
Change-Id: I3a59af44c77f739185feef39afd57193b5e0176a
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
33b28a1fc0e8ca5c2c285655d0ed8bd0dc275600 21-Jul-2011 Flavio Lerda <flerda@google.com> Remove the call button area if we cannot call.

If this is not a voicemail, then the whole call button area is empty and
there is no need to keep that around. Instead, extend the text area to
the right of the screen.

If there is a voicemail, keep the empty call button area for visual
consistency.

Bug: 5056506
Change-Id: Iaad9228ad6dcc67ebcd8a893ca0383fa595376e4
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
a113689156ac38177fb8fdf82e5327c3f916d331 18-Jul-2011 Flavio Lerda <flerda@google.com> Add playback button in call log.

This commit adds a separate playback button to the call log, according
to the latest mocks.

Change-Id: I5d732d7a3775b4c723fb6a70015ed187e40c5c46
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
76921903290ba9229e0238395c35569cbadecb20 13-Jul-2011 Flavio Lerda <flerda@google.com> Split new and older items in the call log.

This commit changes the way call log items are displayed.

Instead of using a single cursor showing all items, it creates two
cursors, one for new items (missed calls and voicemail with the NEW
field set to 1) and older items (missed calls and voicemail with the NEW
field set to 0 and incoming and outgoing calls).

To make this as much as possible transparent to the UI code, it actually
creates a merged cursor from the two cursor above, so that the UI does
not need to know about the fact that these correspond to two different
queries.

To allocate space for the headers (which are present only if the
underlying cursor is not empty), they are also added to the merged
cursor, using MatrixCursors.

Since the UI needs to know whether to show a header, a new call log
item, or an older call log item, add a synthetic column called "section"
which represents which section a given row belongs to.

In the process, encapsulate the details of the queries being made to the
call log. Probably a follow-up can be done to further hide the details
of how the query works.

Change-Id: I0be6ac5b4ca5b0ccd74a648a5d8687e05ad77a82
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
178eeebac88b352c131bd0315a99da16162c986e 11-Jul-2011 Flavio Lerda <flerda@google.com> Open groups of calls in the CallDetailActivity.

This change allow showing the details of a group of calls in the
CallDetailActivity.

First of all, it adds a way to pass to the activity a list of calls,
namely by using an extra containing a list of ids of rows in the call
log. It preserves the existing mean to open the call details using a URI
for backward compatibility.

In turns, the activity will get the details of each call, assuming they
all come from the same number and therefore the same person, and show a
single contact header at the top, while placing the detail of each of
the calls in the list at the bottom of the activity.

With that done, we no longer allow opening up groups of calls in the
call log: they are no longer necessary, as the details of the calls
within a group are now accessible in the details page.

In the process, extract a utility class that encapsulates operations on
phone number, like whether calls can be placed to a phone number, and
how to display the number to the user. There might be a few more places
where this helper can be used, but I will look at those in a follow-up.

A few optimizations still need to be pursued, for instance the lookup of
the details of the phone calls in a group can be optimized.

Another candidate for a follow-up is using a common ContactInfo class
between the call log and the call details, maybe with shared functions
to extra the information from a cursor.

A further improvement would be to have a shared cache of the contact
info and call log details, so that looking up the information when
opening the call details can be done more efficiently (it is currently a
strict mode violation) since the call details will generally require
information which had already been looked up by the call log beforehand.

Change-Id: I408650d7485afe4c132dd9cc376e6ba0e3388c1e
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
223a843a7290517eccf340817cdae424658dd0da 11-Jul-2011 Flavio Lerda <flerda@google.com> Allow for multiple call icons in the call log.

This commit adds support for having multiple call icons on a single
entry, to handle group entries.

When the group is represented as text, we currently use only the first
call type, but, in a follow-up, I will use an additional counter.

Change-Id: Iaa9d1c84eb926c1500bf0a439d45ce59314bd198
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
371d5f97d0b87ea0c9d8e8e178c04df34336a29e 09-Jul-2011 Flavio Lerda <flerda@google.com> Update the formatting of call log entries.

Use the three line style that is also used in the details view, in fact,
reuse the helper class and layout from that class.

Fix a few cases that were correctly handled by the call log list but not
by the details view.

Change-Id: I32e6516a571d6e3d95b5f0e414a4fc711cb6a51b
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
e00060ff05c602e036cf0c3809ed866270c93c3f 04-Jul-2011 Flavio Lerda <flerda@google.com> Visual updates to the call log.

- New style icons for the different call types.
- Icons for call and playback of voicemail.
- Style definitions for call log.
- Add placeholder assets.

Change-Id: Ia2ec57dc078d1dec9680aea4917aea0490dda1a8
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java
d2031e0c809580219faa55a27c237c7bdf8505a5 06-Jun-2011 Flavio Lerda <flerda@google.com> Refactor code for filling call log views.

Move the code that decides how to fill the call log views into a
separate helper class. This makes things easier to reuse and test.

Change-Id: I5e03e6764f395ca7e9f7ed5451c476ac1bfe6a95
/packages/apps/Contacts/src/com/android/contacts/calllog/CallLogListItemHelper.java