| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfoHelper.java
|
| 643edd29b2234dfa22132b55284c1863f3b1ec5d |
|
17-Nov-2011 |
David Brown <dab@google.com> |
Fix a crash caused by SIP addresses containing "%40" instead of "@"
ContactInfoHelper.lookupNumber() was assuming that SIP addresses would
always contain the character '@', but that's not always true since the
username/domainname delimiter can actually be "%40" (the URI-escaped
equivalent.)
This would cause Dialtacts to crash upon launch if you somehow managed to
get a SIP address like "123%40foo" in your call log.
TESTED:
(1) Make an outgoing call to the (malformed) SIP address "123%40foo"
(2) Launch Dialtacts ("Phone")
==> No longer crashes
This change should be submitted after change I62d15a in frameworks/base,
which adds the PhoneNumberUtils.getUsernameFromUriNumber() method.
Bug: 5637074
Change-Id: I06f333cf993ca5e33b88c0c8b9006116b6fd5cf7
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfoHelper.java
|
| d70e5ad6e99bb7ef9ac58f95d2522de0aa6fa531 |
|
02-Nov-2011 |
Flavio Lerda <flerda@google.com> |
Use ContactsContract.PhoneLookup to look up SIP addresses.
We recently added support for looking up contacts with a given SIP
address using ContactContracts.PhoneLookup instead of a generic,
expensive ContactsContract.Data query.
Use this new look-up mechanism in the call log and call details.
Bug: 5529690
Change-Id: I6a10cfa5038ceca96669cf07ed20d7d47bd25427
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfoHelper.java
|
| 5c357cdc621aa2b59c4c9b9969540af88fe15277 |
|
27-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Merge "Correctly match SIP addresses." into ics-mr1
|
| ffa8963f6d5d0fd672c11dea2c2d16048da36577 |
|
21-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Correctly match SIP addresses.
When grouping items in the call log, we were using the function to
compare phone numbers. However, this strips all non-numeric characters,
which means that all SIP addresses without a number in them will match.
Instead, SIP addresses are defined to match only if they are identical.
Bug: 5483719
Bug: 5390325
Change-Id: Ic6f1d55ccbd433cc6062ca803fcfd88ae4f68a8a
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfoHelper.java
|
| 2624136fddb5054d3b1b2824ce6cfeaadba83305 |
|
19-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Merge "Normalize the phone number before contact look up."
|
| 252fabfd63452535d5c63694d7c5a6d7c24dd256 |
|
14-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Normalize the phone number before contact look up.
The contact look-up request does not include a way to specify a
country which the number may correspond to. In the call log, we might
have calls that were placed or received while in one country and their
numbers will not match the contacts when the user is in a different
country.
To fix this issue, normalize the phone number using the country stored
in the call log together with the number itself and use that to look
up the contact.
Bug: 5252190
Change-Id: I46471fa2acffd541a2192f6948a613c13484c2d1
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfoHelper.java
|
| 1d18da7d48d31aa5f5ee94e188e80400eac03595 |
|
17-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Also look up number as an "Internet call" address.
If a number in the call log is not found as the number of a contact,
also check whether the number was added as part of an "Internet call"
address for one of the contacts.
Normally, one should put a full SIP address in the "Internet call"
address, but it is possible to put just a plain phone number and that
still correcly works to dial that number using the internet calling
feature.
However, the call log does not correctly match the number in that case,
because a plain phone number is never looked up as an "Internet call"
address.
This commit adds that look-up, if the regular look-up of a phone number
fails.
Bug: 5390273
Change-Id: Ibb722083ea1e0166bdd630a6f12f678a90de41eb
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfoHelper.java
|
| 79318fc2faaddaa0411523c2480d128f2fa16bb2 |
|
10-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Cherry pick "Use number in the call log and call details." DO NOT MERGE
Since we are using that number when dialing, we should also use it when
displaying the number.
Bug: 5331961
Change-Id: I70d3fe724461cf15c1749af627d07369294eecc6
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfoHelper.java
|
| 8156a879dadab88e7b0a0130f933754a46bc71d5 |
|
10-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Use number in the call log and call details.
Since we are using that number when dialing, we should also use it when
displaying the number.
Bug: 5331961
Change-Id: I70d3fe724461cf15c1749af627d07369294eecc6
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfoHelper.java
|
| 731f861593f3de69e8b3070b46e589cab42341f9 |
|
07-Oct-2011 |
Flavio Lerda <flerda@google.com> |
Share contact look up between call log and call details.
Currently, it is possible to get a contact be correctly identified in
the call log, but not in the details, because the logic to do the
look-up are completely separate.
For example, SIP contacts are correctly looked up by the call log, but
not by the details. Moreover, we recently fixed a few bugs in the logic
for looking up contacts in the call log, that have not been propagated
to the call details because the code is independent.
This commit moves the whole logic of looking up a contact given a number
(which may be a SIP number) from the CallLogAdapter into its own class.
Then, CallDetailActivity can use that to look up the contact in a way
that is guaranteed to yield the same result.
Bug: 5415134
Change-Id: I73acc39ba5dc65ecce6861f210224304fd91822d
/packages/apps/Contacts/src/com/android/contacts/calllog/ContactInfoHelper.java
|