| bc365a6107c2feec99d4fbb18e60baeea145c374 |
|
08-Aug-2012 |
Daniel Lehmann <lehmannd@google.com> |
Stop double-animating when removing the last editor. Fixes jump cuts
Bug:6009430
Change-Id: I8e0a24334a5d92bc300f4d0ff15da99f4786852c
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| ca87e9c598929b5b6a62da9b80d2114168e24274 |
|
06-Mar-2012 |
Daniel Lehmann <lehmannd@google.com> |
Added some smoother transitions to the editor
- Transition when removing a field
- Transition when pushing the "Add organization" button
- Transition for visibility of "Add xxx" when entering text
- Added pushed state on "Add organization" button
- Increased the height of "Add xxx" to match the expanded size for simple
Editors from 40dip to 48dip
Bug:6009430
Change-Id: Ia4524006b528f49d587c6277ecc98b11f77ddc0d
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 26918da1650c1ff7b6f92deb978ab976525c811a |
|
03-Feb-2012 |
Josh Gargus <jjosh@google.com> |
Contact-editor now immediately shows proper editor for new fields.
Previously, when adding a new field via "Add new" or "Add another
field", an empty field appeared, but the user couldn't edit its
contents without first tapping on it. Now the approperiate editor
UI pops up immediately (eg: when you add a new "event", a date-picker
pops up).
Bug: 5070818
Change-Id: I882a8202a6a76f73f3efd24734b0e0acdbcecac0
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 50a27b70581b0191995969c63edd1f6a3db3d1b7 |
|
07-Oct-2011 |
Makoto Onuki <omakoto@google.com> |
Clean up account definition
Removed:
- DataKind.isList. Use typeOverallMax = 1 instead
- DataKind.textAppearanceResourceId. Always use medium
- EditField.isFullName. Wasn't used.
Bug 5381810
Change-Id: I5ff109c075a5edb80ff97737432c78589570a1ea
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| fd70903236883f47b21f23b8cb49a1ccacdfcdf1 |
|
02-Aug-2011 |
Katherine Kuan <katherinekuan@google.com> |
Pixel perfect work for phone contact editor
- Always show account header for raw contacts
- Align text fields and titles along the left margin
- Align spinners
- Use "Add new" as the default text if there's no value
in Event or Groups field yet
- Restyle account header
- Use primary/secondary colors everywhere
- Non-editable contact fixes: remove "not editable on
this device" and replace it with a toast when the
user clicks on the header, restyle item_read_only_field
Bug: 5097095
Change-Id: I94a6c91b05344028b64c62735fb4559f9944529d
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 2293e55d550fbc9974d1185960715e59acb14a85 |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Clear field if try to delete last field in section of contact editor
- Don't remove the field if it's the last field in the section,
just clear all EditText fields in that editor
Bug: 4382255
Change-Id: I2b436fbe895e5cc52770eefedaa2bc5f9726605f
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 398e3805b4278310250e5fd1007e2e73b9453d0f |
|
22-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix "Add new" strings in contact editor
- Instead of using type-specific strings like "Add new
phone number" just use "Add new" since we have labels
for kind sections now.
Change-Id: I0e386ae29330193fec18b62f3949c46e095a872c
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 3fa75acf99f5245eae00c77086ff130b3552ceec |
|
21-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Organization field expands when tapped
- In order to show as many fields as possible on the
contact editor, we collapse the editor into a button
that only expands the EditText fields when tapped
(collapsing is not possible unless the user exits
the editor).
- Add an isEmpty() method on the KindSectionView
so we can distinguish between a contact with existing
organization info versus a contact who has an empty
organization field
Change-Id: Iff818c30422c96d1acf6a03cbbcfb6f17bfed106
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| a94859f61c216d4e137a631995026d3ddefbbf70 |
|
20-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Contact editor fixes
- Bring back data kind titles
- "Delete" button should be invisible not gone
- Make field + spinner horizontally stacked instead of vertically
stacked on phone
- Don't show account header if editing an existing contact that
only consists of 1 raw contact
Change-Id: I7dd4bfdf273eeaccca8399d182c0a56a6e23a8c7
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 5e330ed98f1c2711b4cd3b375a1c0f76bedaf3e1 |
|
16-Jul-2011 |
Katherine Kuan <katherinekuan@google.com> |
Remove unnecessary delete buttons in contact editor
- Don't offer the delete button until the user has typed something
into the field
Change-Id: I37585565b77f3d6a06677341191bb0f0cc72e508
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 2591436971bad3050c85929c8e0c5a8d48111f88 |
|
30-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix "add field" logic
- Only update "add field" footer when field goes empty --> non-empty
and vice versa, fix the case for 4 line addresses in Exchange contacts
- Add property in DataKind class for "add field" string
- Remove hash map of mime types --> string resource IDs in
KindSectionView
- Remove "add internet call" string
Bug: 4363151
Bug: 4371568
Change-Id: Id2fec743a7c3e68d8404591cc61de20487245b0a
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 1b22073590c1801c3e6c7bde2f4636632a049f6c |
|
29-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
"Add field" footer logic
- Instead of an explicit "+" button to add a new field (which
also allows adding multiple empty fields), only show a
"add field" footer to the KindSectionView if there are no
existing empty fields in the section.
- Make the whole footer a touch target and display a
custom message according to the DataKind mime type
Bug: 4363151
Change-Id: Ib7cef5ed5aaefa5b1269f95ed8fe89e7dd742f36
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 63ffb90935d8aec295e4a8f62af6c77dafe1899f |
|
27-Apr-2011 |
Katherine Kuan <katherinekuan@google.com> |
Refactor to inflate views from XML
- This is part 1 of getting the contact editor up to par with
the UI mocks, there are some known issues that will be fixed
in coming CLs (i.e. add button functionality)
- This way, the field editors can be vertically stacked
on the phone and horizontally stacked on the tablet.
- Get rid of duplicate labels by using the hint text in the field
or spinner as the title
Change-Id: Ia00a1a65ad0bbd7a4bc05ccb93dd1b1496bca5df
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 405671a7b42d97ebf7ae7c0eeb4721f881139673 |
|
29-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move DataKind outside AccountTypes
Bug: 4184675
Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| eeb68a341734ded343004d4eecb585420e70605b |
|
25-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Posting focus request after adding a new field in the contact editor.
Also, making the contact name selected on the activity start
Bug: 3403046
Change-Id: Ic6baf9d4404237d62bca3cdabc41a14422236a3c
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 62bab31374dd66462643cbc04ebb2acece4b9b39 |
|
30-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing handling of single-item data kinds.
The bug was that if we had an existing row
for a single-item kind like nickname,
but that row was empty and therefore invisible,
we would allow the UI to create another,
visible row.
The fix finds that invisible row if it exists
and makes it visible thus eliminating duplication.
Bug: 3334481
Change-Id: Ic639e5ae42b485fe6830078e5043a4f10b757086
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| ba3c2e541b17bc68ff86ed402e7ee2c0a84f7d80 |
|
23-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Adjusting padding and fonts in contact detail
Change-Id: Ia7d2a01e72c38a6aa9e7a72ef380c7b5fcf149f2
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| fa82b398f49bf8d5ae386c326f246f0e56e438b9 |
|
10-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Ensuring that the "plus" button is always bottom-aligned
Bug: 3273190
Change-Id: I5a41989b5362b5d14fe4b44642eee1ebb50a197f
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 91d8e892d549bbeba721cb434163a83bc99330a9 |
|
08-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Aligining fields in the editor
Change-Id: I7137055bf8ab61df33f6a87c8e6c8227dbee8a9f
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 02bb1252aa990813fa9e86ad75c458acc15e6801 |
|
06-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Removing progress dialog when saving a contact
Bug: 3253127
Change-Id: Ifd3b58f202fea76596880fb6de9f8acc46a32d79
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|
| 18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 |
|
03-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming a couple of packages
Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/editor/KindSectionView.java
|