851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data This refactoring abstracts out the need to directly refer to Contacts database columns throughout the code. Instead, all of this information is retained in getter/setter methods within the Contact, RawContact, and DataItem classes and sub-classes. ContactLoader.Result class has been pulled to the top level as the Contact class. The Entity class has been removed and replaced with a RawContact class, with getters/setters to raw contact information. Renamed EntityDelta to RawContactDelta for better understandability as well as adding getters/setters for specific fields in the ValuesDelta nested class within EntityDelta. EntityDeltaList and EntityModifier have been renamed to RawContactDeltaList and RawContactModifier with the methods using the RawContact class directly rather than the Entity class. Data items for a raw contact are represented by a DataItem object with specialized getters/setters for subclasses of DataItem. (e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper around ContentValues. This abstracts away the ContactsContract column fields into getters/setters. The above refactoring is accompanied with changes throughout the codebase to use the new Contact, RawContact, and DataItem classes. Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|
e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix. Changed import order to be in accordance with style guide: http://source.android.com/source/code-style.html#order-import-statements Static imports will be placed at the top since most existing files used that convention. It is also a style that can be handled by both eclipse and intellij. Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|
e55faef88185628c842e0aa778d883f209323630 |
|
07-Dec-2011 |
Katherine Kuan <katherinekuan@google.com> |
Fix suggestions box being 1 character behind In contact editor, the aggregation suggestions is 1 character behind because the ValuesDelta sent to the AggergationSuggestionEngine contains a structured name that is not fully synced with the display name. The solution is to wait for the structured + unstructured names to be synced before sending it to the suggestion engine. Bug: 5507256 Change-Id: I5f9b6da40ef7843a3b67dc9deaa2af3cbb68c477
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|
b05466a9349441e79fb12d60abdf669168b59593 |
|
22-Sep-2011 |
Isaac Katzenelson <isaack@android.com> |
Fix name editor data loss on rotation Bug: 5290661 Edited name for a contact not saved When the contact editor was recreated on screen rotation the data on the name editor was updated incorrectly. The problem was that a change to any of the fields in the name editor was erasing the other fields. Instead of erasing the other fields, i changed the code to sync between the display name and structured name so that on rotation, the data is correctly stored and retrieved. Change-Id: I644bfea2af4e759e1d7d94aa09840ed15efd079d
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|
da5bf1cf60beef3de5e651a569fa544293683926 |
|
03-May-2011 |
Dave Santoro <dsantoro@google.com> |
Modifications to bold contacts' first names. For lists and headers, this is calculated by using a similar technique as we use in the list view for highlighting text when the sort order and display order do not match - we look for the overlap point between the display name and the alternate display name, and bold the leading or trailing part, based on the display order. For the edit view, we convert the display name into a structured name (via an API extracted from the structured name editor code that calls into the provider to handle splitting), and then bold the span corresponding to the contact's given name. This also fixes an issue with the alternate display order in which we weren't honoring that preference on the contact details view. Change-Id: I6af048725541996cb303810a56a1ad79fc276e11
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|
d37a891cb44cd17083c06d7be693c469403d16df |
|
27-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Enable account switcher in contact creation - remove account selection step before contact creation - (phone) put account info on the right side of photos instead of having "header" for it -- renamed header_* ids for account stuffs as they may not be part of header any more. - add migration functionality to EntityModifier - add test for it - no optimal layout Bug: 4184675 Change-Id: I0e777f9aa37a7c9145bd430f897f8068b0bede56
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|
405671a7b42d97ebf7ae7c0eeb4721f881139673 |
|
29-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move DataKind outside AccountTypes Bug: 4184675 Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|
83cc117f09934ab275419bc5ffc8c60a16a28fc3 |
|
01-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Using the right class loader for unmarshalling Bug: 3497767 Change-Id: I68d54f07cd4e65843e90f8f819212798df018acd
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|
c77f48947093d5f84b7df661a29b8b45d573cc10 |
|
01-Mar-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing parsing of intent extras for Exchange contacts Bug: 2969875 Change-Id: Ifd7f1ba2e794ebf24626c53e5ed3a14ae9adc791
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|
11bb73bcdf4290ced99e3e06b1f76d4c37357aea |
|
26-Feb-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Preserving name structured on expand/collapse operations If the user does not change components of the structured name, the expand and collapse operations in the editor should not reparse or re-compose the name. Bug: 3473362 Change-Id: I4fe5f0d06757b2fe098a5bd895c84108195049e9
/packages/apps/Contacts/src/com/android/contacts/editor/StructuredNameEditorView.java
|