History log of /packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
f63bfe6ff43827b22674a7131929db382c71c00b 14-Nov-2012 Yorke Lee <yorkelee@google.com> Keyboard nav fix for list in GroupDetailFragment

Bug: 7495057
Change-Id: I8847a6fc33f719e9ce828d26ba73367c13426483
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
851222a96b5d68602fb361ea3527101e893f67e3 21-Jun-2012 Maurice Chu <mochu@google.com> Added thin object layer around contact data

This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.

ContactLoader.Result class has been pulled to the top level as
the Contact class.

The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.

Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.

The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.

Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
e0b2f1e2d01d1ac52ba207dc7ce76971d853298e 12-Jun-2012 Chiao Cheng <chiaocheng@google.com> Global import order fix.

Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements

Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.

Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
82a4f4408b74e193b43a12dc8e16c946a93bae4a 08-May-2012 Makoto Onuki <omakoto@google.com> Clarify AccountType.resPackageName/summaryResPackageName

Gave them clearer names and added javadoc.

And added a workaround for the fact that the view notification
service for the google account type is implemented in the sync
adapter, not in the authenticator.

This really needs further clean up.

Change-Id: I567656393fab30293c831fac802884dc84daf861
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
2f77c85543e6c497e63cd0e216b70e58c1d13ec3 31-Mar-2012 Daniel Lehmann <lehmannd@google.com> Various refactorings to prepare proper big picture loading

- Added a function to load a picture with ideal sampleSize
- Renamed xmls/java files for tiles
- ContactTileView is now abstract and has subclasses for each use-case
- Added mechanism to estimate the image-size in a tile before layout
- Changed the cross-fade in ContactPhotoManager to apply the fade to the
current picture instead of the default avatar. Reduces flickering

Bug:6202229

Change-Id: Ic8636d1b3349473163fb2424b5f74476fd435fb5
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
cf3d9f04955a8ec3cb405b8a4ddcaddcece2a245 08-Mar-2012 Daniel Lehmann <lehmannd@google.com> Fixed various issues around cross-fades

* Fixes the layout in portrait tablet
* Introduces the same cross-fade when going from group to group
* Reduces memory consumption by creating the transition-bitmap on demand
(takes 40ms on Xoom)
* Simplifies the layout files by removing some configuration options
that we aren't using anyway
* Split the detail views for contact and groups, so that the animation
of one doesn't affect the other

Bug:6117161

Change-Id: I2509c9387de6b1ac60dbc9b694564291910bde72
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
4e05a29c9b05c8cb74972aa5b9fe55fe35d7f45d 04-Jan-2012 Josh Gargus <jjosh@google.com> Call correct number of frequently-called contact.

When you tap on a frequent-called contact in Dialtacts, it either
calls the default number for that contact (if one is set), or pops
up a disambiguation dialog. The desired behavior is to dial the
the number that is explicitly displayed in the list-item.

Bug: 5790357
Change-Id: I2ea14abab9d0aa79d4517e7221796c1886a8f947
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
c18a58ef7432c3faa1318029372cd6cbeba1e437 03-Nov-2011 Katherine Kuan <katherinekuan@google.com> Fix flicker on group detail page on tablet

- Occassionally, after doing a sync, sometimes the group
detail page will flicker on the tablet.

- Remove destroyLoader() call right before restartLoader().
According to the documentation in LoaderManagerImpl,
destroying a loader destroys any data associated with it,
which seems like it could potentially cause all the photos
to disappear in the group member ListView.
(Otherwise it's not clear why the photos would all
disappear instead of showing the ListView empty state.
The group title / group membership size are always
on screen, and never blank out.)

- Haven't seen group detail page photos flicker anymore.
Selecting different groups in the group list still works
properly. Tested on phones and tablet.

Bug: 5513239
Change-Id: I39684b884b850715ded91449072cb8ff15e6d928
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
a939372643a86688ae196cce03cf4f6f70864d93 31-Oct-2011 Daisuke Miyakawa <dmiyakawa@google.com> Reduce the number of columns for group queries

1~5% performance improvement. Also will improve memory usage.

Bug: 5550672
Change-Id: I5ad0876ce469fbf86334e3f77b15cd240d9f761b
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
7a700cf798a19a8452b8671f643a05336f63f611 28-Oct-2011 Katherine Kuan <katherinekuan@google.com> Launch quick contacts after selecting frequent contact on tablet

- Previously clicking on a frequently contacted person
would request the contact detail fragment to load that contact,
but the app wouldn't switch tabs or update the selected contact
in the contact list.

- Pass the Rect of the target view to the listener to launch quick
contacts

Bug: 5236515
Change-Id: Ic2d888ed02f8fd2b5a47d49f99cc96755bf55d37
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
4270aa76bb02cd76f77170f93fcd6ed3db897bd4 19-Oct-2011 Katherine Kuan <katherinekuan@google.com> Add empty state to group detail page

Bug: 5160342
Change-Id: I1061fae0366285f601cfb7964f74da2eb4e5855b
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
04e6b557e45cc645c4fca1578358b63945452975 03-Sep-2011 Katherine Kuan <katherinekuan@google.com> Show edit group option for default auto-added Focus groups

- Focus groups like "Friends", "Family", and "Coworkers" are read-only
because their titles are read-only and they cannot be deleted, but
their membership can still be editable, so show the "edit group"
option.

- Fix bug with editable Google+ circles were editable by adding a
missing dataset field

Bug: 5250453

Change-Id: I3c5590a01bf641fb22e97fdba4a4eb3c41725e6c
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
e92a978f8d3b98364abae85559e547659de1bc58 25-Aug-2011 Isaac Katzenelson <isaack@android.com> Remove group editing for readonly groups

Bug: 5209461 Uneditable groups (i.e. Circles from G+)
seems to be editable, even if they aren't

Added a check that removes the edit button in the Group Details
fragment is the group is read-only.

Change-Id: I83b403c6b4b69d86b52827810741e86ace2e8c53
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
f5f8430538efb5636bdd2385f742ec1b23d10b17 22-Aug-2011 Katherine Kuan <katherinekuan@google.com> Fix group source crash on phone

- The group source button is supposed to be a scrolling header
in the list of group members on the phone portrait view, but
we can't add a header view to a ListView after the adapter is set.
(Setting the adapter had to be moved before setting the header
view otherwise the group detail page would flicker on every
sync).

- Make the header static as a simplification and hide the view
if there's no group source needed.

- Remove fading edge on group members list

Bug: 5195472
Change-Id: Ibedc629ddd85a54ed8beee92650df617a09d2a6c
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
d78ee90c0d4d93b82ad440396e87ae4f47f53e93 15-Aug-2011 Daniel Lehmann <lehmannd@google.com> Several DB changes as requested by ES

- Switch from resource ids to names to prevent breakage on package upgrade
Bug:5135277
- Add SYNC1...SYNC4 columns to StreamItems and StreamItemPhotos
Bug:5119385
- Remove ACTION, ACTION_URI from Groups, StreamItems and StreamItemPhotos
(this reduces db size and prevents click intercepting)
Bug:5135808
- Add some raw-contact fields to the StreamItem and StreamItemPhotos query
Bug:5134081

Doing those changes in one block to prevent too many db upgrade steps

Change-Id: I4c90742580c86203a1686bb625c026438ed19b8f
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
1fcb853d2cf6670db9b4eecc492f4676894d4bec 11-Aug-2011 Makoto Onuki <omakoto@google.com> Fix bug 5051541 Group members list flashes when syncing

Bug 5051541

Change-Id: I0b90426067c2bc179be9c8103df8818720330889
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
90f2996a01a1804b2a64d316c6550e6d322a5e92 08-Aug-2011 Isaac Katzenelson <isaack@android.com> Remove group edit button in empty state

Bug: 5134586
Change-Id: Id7b77e16c1393d8ec1293776513274027f996bf9
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc 27-Jul-2011 Dave Santoro <dsantoro@google.com> App changes for account types with data sets.

This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).

This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.

Bug 5077096

Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
7b827b27547ae53c5ba9ed5e0d06a1d6b00e5b8d 20-Jul-2011 Isaac Katzenelson <isaack@android.com> Merge "Fix group editing buttons"
e962aaf7c3d00baa27cd8f1965e00aaf7c13e557 19-Jul-2011 Isaac Katzenelson <isaack@android.com> Fix group editing buttons

Removed rename button from XML.
Added a variable to store the "is read only" status.
Hide the delete button if the group is read only.

Change-Id: I758114355c81d98df2e326c7f3511a67caf3c438
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
703cda7119b710446f7abc38843043b7cbbf3a47 16-Jul-2011 Katherine Kuan <katherinekuan@google.com> Show group source on group detail page

- Show group source button as:
* scrolling header item in ListView for phone portrait
* non-scrolling header outside of ListView for tablet landscape
and portrait (b/c can't addHeaderView on ListView after
the adapter is set and we reuse the GroupDetailFragment
on the tablet)
* custom action bar button in phone landscape
- Tested by inserting an action and action_uri for one group

Change-Id: I29abad130dac57e3077fd4f3e546a451f579b394
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
7979ea27c046dfc2d9305b3282233046acef6ec4 15-Jul-2011 Frank Sposaro <sposaro@google.com> Enhanced performance in ContactTileAdapter.

-Contacts Load faster because now saving cursor and not copying into ArrayList.
-ContactTileLoader factory performs more optimized queries.

Bug: 4901406
Change-Id: I91902a99252e99db081d4437066a74f9fa21f5d1
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
2b431c0384a7638b91478eef521125cdf0b51b11 17-Jul-2011 Katherine Kuan <katherinekuan@google.com> Fix group size string

It should be of the format "X people from Y" where X is the size
and Y is the account type display label

Change-Id: Ic46d287e42b0d69c8f5dc1275d4894ada5ff67d1
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
1aeaea08ba325e9a2aacdb39be44ec363c097e79 14-Jul-2011 Daniel Lehmann <lehmannd@google.com> Merge "Allow a sync adapter to provide an OPEN action for a group"
4e2bb32000f391ceb0de7309a159bee5d8e04fc5 12-Jul-2011 Frank Sposaro <sposaro@google.com> Pressing a group member on phone takes you to contact card.

Bug: 5016808
Change-Id: I59990fd0301bfa4934f8add568b40b080eb70e02
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
7f61eba2cddfdd99f155c851eaa490f73358d031 12-Jul-2011 Daniel Lehmann <lehmannd@google.com> Allow a sync adapter to provide an OPEN action for a group

Bug:4413120
Change-Id: Idf0f969c20a82c8dcfa04b9234ccebf3f659da99
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
9e095d2ffc4a94d2fb925d19df6db12bc2b1e124 08-Jul-2011 Frank Sposaro <sposaro@google.com> Added QuickContacts.

Change-Id: I0bf3b536da73c2f9862a958ff0275ef8404def4f
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
267073407439d7df012a2e0df577e39a1f89c4a8 08-Jul-2011 Isaac Katzenelson <isaack@android.com> Remove deleted groups from GroupBrowserList

Change-Id: Iea7435c6b1f569dd8ac5416b35470b9ae2f48761
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
e5d06f534d58baa27fe6b1091b9724f81fd258c9 07-Jul-2011 Frank Sposaro <sposaro@google.com> ContactTile column counts are now dynamically adjusted.

Bug: 4969044
Change-Id: I5185b93ea3e7720136c929ce4c8ab820d7b4dfc9
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
c6b8afe730255537978f2c938cca6986cae63c34 23-Jun-2011 Katherine Kuan <katherinekuan@google.com> Group editor on tablet

- Allow autocomplete to add new members which presents
the user with suggestions from the raw_contacts table
with the same account name and type as the group
- Hook up the "new" and "edit" group buttons on the tablet
- Once the user exits the editor, update the group list
and scroll the group list to the group that was just edited
- Allow rename of groups (make the names of read-only groups
not editable)
- Allow removal of members
- Hook up the done / cancel / up / back buttons

- TODO: Be able to create a new group + add new members
in the same transaction. Then the new group editor
will allow adding members at the same time. Currently
you can only add a name to a new group. Once it's created,
then you can go and edit the membership.

- TODO: Bulk add/remove members in one transaction when the
user exits the editor. Currently it's saving the change
after you modify the membership list (even before you hit
the "Done" button in the editor).

- TODO: Add member status message and chat presence

- TODO: Add UI for non-editable groups

Change-Id: I1f32a28862c358b8bd1469666743cd240d28f80b
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
5f34b2e20ad4a41b6dd3fd0703d59e085bffeb1c 22-Jun-2011 Frank Sposaro <sposaro@google.com> Group members are now displayed as ContactTiles

-For Tablet
When trying to view a list of all the group member, they
will show up as ContactTiles.

Added GroupMemberLoader as a helper class to query
for all members based on group id.

Change-Id: I7eae9066a2e881c28eca1fc157142e49a9bad725
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
8268bbe65440c70db46b4c505433fac1fdc36e58 11-Jun-2011 Katherine Kuan <katherinekuan@google.com> Add group menu options in group details fragment

- Move "new contact" and "new group" menu items into
list fragment (instead of details fragment or
people activity), so it works according to the current
tab esp for the phone
- Move group menu items into group detail fragment
- Remove custom "new contact" button
- Add some fixes for menu items / fragments going into and
out of search mode

Change-Id: I1f2a4d7e90b4e5d438bb271f0a66e21d8069b189
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
be18de05d6f6a107c552e369bce58f51c946fde7 07-Jun-2011 Katherine Kuan <katherinekuan@google.com> Add group detail fragment on tablet

- Add action bar on GroupDetailActivity, title, and subtitle
- Make everything use the groupUri instead of passing around
account name, type, group Id, and group title
- Fix some of the callback listeners between the group fragments
and group activities
- Add factory methods to ContactListFilter

Change-Id: I63066ea6eefde1e57562b6396d6dc590ed023c84
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java
fd8cdedb816cb1fc5894e2e3c5e144ff16b90b7c 11-May-2011 Katherine Kuan <katherinekuan@google.com> Group detail page and list of members

- Click on group in group list goes to a detail page
- Temporarily show members, TODO: Move list as
an expanded list in group browser activity
- TODO: Populate detail page with group info and
group actions

Bug: 4413116
Change-Id: I114d276f96aed318307d185910ae8799228262c9
/packages/apps/Contacts/src/com/android/contacts/group/GroupDetailFragment.java