| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| be5650190106f2147f5782e6c7b3295b5668a5ee |
|
24-Feb-2012 |
Daniel Lehmann <lehmannd@google.com> |
Guard against an NPE. Fixes a monkey bug
Bug:6058383
Change-Id: Ia8141d373929a8b1ad7e848db6c404cbd3eadcf1
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| fadd5e1f1845b8d98e247bbd30535928dc5e0f81 |
|
02-Dec-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Use NEW_TASK flag for launching in-call UI
To make Intent creation consistent, prepare relevant methods in
ContactsUtils and use them everywhere.
Bug: 5691827
Change-Id: I41509bfc7d914ba87ab614450b53fc93ce0eba4b
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| e1c007eeb40a40b21e60bb4c8a42e0affd9fcdd1 |
|
23-Oct-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Make Phone UI show Sip addresse
Must be after I4729c87ecd11296599ed0313e8ad1f5aeabbd32b and
Ifbbfe9df3b9a560666d35ca78aeb07d513963195.
Bug: 5039627
Change-Id: If43911d5b828da6360b38bf386ab7ba52d7ca00a
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 18e2b6f48045eebd802ff560420e1ad19b2e2da8 |
|
01-Nov-2011 |
Katherine Kuan <katherinekuan@google.com> |
Check activity state before showing phone disambig dialog
- This is a monkey bug on Crespo that happens often. The
monkey is likely tapping on a favorite contact in the Phone
app, which is trying to either dial the contact or
show a disambiguation dialog if the contact has multiple
phone numbers. There's an IllegalStateException with trying
to commit the dialog fragment transaction because the
saved state has already been called.
- After a PhoneNumberInteraction is started, a CursorLoader
is started, and when that returns, potentially we try to
commit a FragmentTransaction (showing the DialogFragment).
At this point, the activity may be long gone, so we need to
know if the activity has saved state or not. Hence,
we add a new base activity class (TransactionSafeActivity)
that keeps track of this information for us.
- The PhoneNumberInteractionTests still rely on passing in
a context to PhoneNumberInteraction (in order to check
that the queries and subsequent activities are correct),
but we typecast the static methods the app uses to
create these PhoneNumberInteraction objects.
Bug: 5132436
Change-Id: Id9d887bd55235b07133568a38d4922dc7fce24a7
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 17c62974608af9b34908c4a14194d53fd89cca6f |
|
27-Sep-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Use CALL_ORIGIN flag
CALL_ORIGIN flag allows Phone app know where the phone call
request comes from.
TESTED:
incoming calls
-> go back to calllog
outgoing calls
- make a phone call from dialpad -> go back to dialpad
- make a phone call from favorite -> go back to favorite
- make a phone call from calllog -> go to calllog
- make a phone call from call detail -> go to calllog
- make a phone call from People UI -> go to calllog
- make a phone call from dialpad and launch Phone UI
again during the phone call -> go to calllog
- make a phone call from contact card (reached via
phone favorite) -> go to calllog
- make a phone call from favorite and add another
person to the phone call via in-call ui
-> go back to "favorite" (undetermined behavior actually)
- make a phone call from dialpad or favorite, bail out the
in-call UI. Have the recipient hang up the call.
Then have an incoming call again. Hang up the second phone
call.
-> go to calllog
Must be after I4d5f825f7d5109c6ff8c27b6e53a31ca9e6b832f
Bug: 5360106
Change-Id: I7b88b245e82e96e150937ee53029d397a28a9b2d
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 01a9fac7bd963d29c607cb17d579b68a71aa8854 |
|
16-Sep-2011 |
Dave Santoro <dsantoro@google.com> |
Fix phone number comparison in Phone Favorites.
This switches to using ContactsUtils.shouldCollapse for determining
whether we should combine the two numbers.
Bug 5294289
Change-Id: Id1ec369cfe698b52186ff392255d789458622e9d
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| dd19fd696a8d173ae36cd8325686c85eba5010e0 |
|
15-Aug-2011 |
Daniel Lehmann <lehmannd@google.com> |
Merge "Renaming com.google.i18n.phonenumbers to com.android.i18n.phonenumbers to avoid name collision."
|
| e2dbb11633fd988358d3f82c68b01a9ba7a3eee5 |
|
14-Aug-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Implement CREATOR for parcelable
API requires each Parcelable to prepare CREATOR
Bug: 5157448
Change-Id: I88825dba69f4dbe14ed2a164138ad0ac0a284681
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 8cebd7f86f952729bc83c7601ba101a705cdeab3 |
|
12-Aug-2011 |
Shaopeng Jia <shaopengjia@google.com> |
Renaming com.google.i18n.phonenumbers to com.android.i18n.phonenumbers
to avoid name collision.
Bug: 5157607
Change-Id: I8569776c3c4ae1ba9b346495e51b846fbe065f74
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| b2e626ad4fedc0fd726f66b9942d1b2f30d9cfef |
|
21-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Implement phone search in DialtactsActivity
Includes tiny layout fixes for ContactSelectionActivity,
which also uses the same phone search fragment.
TODO: let the other Adapters like DefaultContactPickerFragment,
EmailAddressPickerFragment support grouping feature.
Change-Id: I8d7718192522a0005b9b76931560fe297cad882f
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| b1f0e5e8a4de69bd80276742900441e930fa4c86 |
|
22-Jun-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Show dialog if multiple candidates exist
In GB we show a list of phone number to call in Favorites
screen, while we don't now.
Also refrain PhoneNumberInteraction from showing a dialog
by itself but let a nested class do instead. showDialog() is now
obsolete and we should use DialogFragment instead.
Bug: 4743008
Change-Id: I202963c2f03424f07ee386bd9713fde4091a0ae2
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 405671a7b42d97ebf7ae7c0eeb4721f881139673 |
|
29-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Move DataKind outside AccountTypes
Bug: 4184675
Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 0a39387107a29a8fe42f760e7e660cbda33d53f3 |
|
09-Mar-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Use i18n phone number lib when comparing two phone numbers
PhoneNumberUtils#compare() returns false positive result.
Bug: 2586019
Change-Id: Ia4ebd9adb36eca15f879dd3ec45870fa0c555f55
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 931cb6128412d10f9bb1916601356766195d2859 |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Fixing PhoneNumberInteractionTest
Bug: 3330180
Change-Id: I8431d08405bd5ad71b94679cec803ebe5315df2e
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| a07fa5f37031e4c5cd2933de02d2db41ec153e2b |
|
09-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming AccountTypes to AccountTypeManager.
The intent is to turn it into a "system service" of sorts.
Change-Id: I047d70a2e59978c05916965ef0c0d9f18abc55e6
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| b77be6d2ad06edfd8751f55043e4aa9fd9f36015 |
|
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Removing inflation levels from AccountType.
Also, fixing asynchronous update and concurrency issues.
Bug: 3140873
Change-Id: Ie9d342d23ee4a8d23405ef4145c54d7673b2cbe9
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 69f9e6f0cd9b5401da55f251e9bd98e69643d7df |
|
04-Jan-2011 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming fields and variables from "source" to "accountType"
Change-Id: Ie41036e35a45fc7d9a8c934a3cbe68399c567ad6
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 9d2bcfb40d0ee107886eb99eba13a840e944ba43 |
|
20-Dec-2010 |
Dianne Hackborn <hackbod@google.com> |
Update to new Loader APIs.
Change-Id: I4be23901304890e1d0237d81e6cfb3889d5b6591
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 18ffaa2561cc7dd2e3ef81737e6537931c0a9a11 |
|
03-Dec-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming a couple of packages
Change-Id: I2c0f86b51baa622df629206f8b79ef1d0df09119
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 0f78e8b198c56963d6d6044839bb0679f4afd075 |
|
25-Nov-2010 |
Daniel Lehmann <lehmannd@google.com> |
Move handling of primary to quickcontacts
Bug:3212270
Change-Id: I2d35aef0407e02cc4612a66ca09dbcd89b2fe714
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 4597c92d655d45447780b32c7572acef110b6ed1 |
|
15-Nov-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Renaming BaseAccountType to AccountType
Change-Id: Iff47bac0e1a118f4a5319526304df16cb89bd0cd
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| 35769b804fbfd5a1fc0b2c36cd0a786d662c4334 |
|
19-Oct-2010 |
Daniel Lehmann <lehmannd@google.com> |
Renamed Sources to AccountTypes
Change-Id: I088c7d9cd66fd4d38e93bc97a6644247f72037ef
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|
| b4e8886bcb25cde3b03eedcc815c0166329af3a4 |
|
01-Jul-2010 |
Dmitri Plotnikov <dplotnikov@google.com> |
Making call/sms interaction preserve dialog state
And also cleaning up the implementation
Change-Id: I6d9ca845477282d4ef9db7417e99cffc9e608c86
/packages/apps/Contacts/src/com/android/contacts/interactions/PhoneNumberInteraction.java
|