| 851222a96b5d68602fb361ea3527101e893f67e3 |
|
21-Jun-2012 |
Maurice Chu <mochu@google.com> |
Added thin object layer around contact data
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
/packages/apps/Contacts/tests/src/com/android/contacts/activities/PeopleActivityTest.java
|
| e0b2f1e2d01d1ac52ba207dc7ce76971d853298e |
|
12-Jun-2012 |
Chiao Cheng <chiaocheng@google.com> |
Global import order fix.
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/tests/src/com/android/contacts/activities/PeopleActivityTest.java
|
| 0454960b4b9e43b75bbfd0fb296c25d59111a765 |
|
23-Nov-2011 |
Daisuke Miyakawa <dmiyakawa@google.com> |
Fix test breakage
- Fix broken tests
- Add one test for SIP call in PhoneNumberInteraction.
- Move some tests to the category "small test"
Bug: 5661071
Change-Id: If27295928e1af46e193a462ca4f6c3c5168f893f
/packages/apps/Contacts/tests/src/com/android/contacts/activities/PeopleActivityTest.java
|
| 96e87fd6e808e9d853263ffeb5104f3253a18639 |
|
21-Sep-2011 |
Daniel Lehmann <lehmannd@google.com> |
Use existence of editor as indicator whether source is editable.
Bug:3093621
Change-Id: I3ba344667ce1b0f2da6847d783c0ac90f36ebd8f
/packages/apps/Contacts/tests/src/com/android/contacts/activities/PeopleActivityTest.java
|
| e7d15fb4bacfe85e175aa8012f9af8d41a2cfa15 |
|
25-Aug-2011 |
Makoto Onuki <omakoto@google.com> |
Disable PeopleActivityTest
This test is pretty outdated.
Bug 5193806
Change-Id: I40a72ed73d577c5e441a93fba32bf3647bbfbc0e
/packages/apps/Contacts/tests/src/com/android/contacts/activities/PeopleActivityTest.java
|
| 51ada3680de8700bc273a7e652886823f4c1981f |
|
05-Aug-2011 |
Hugo Hudson <hugohudson@google.com> |
Prepare playback immediately, new BackgroundTaskService.
- Immediately we start the CallDetailActivity with a voicemail, do the
preparing of the media so we can see the duration.
- Use the duration text field to show "buffering..." until media source
is prepared.
- Do the preparing in the background, this fixes a strict mode
violation.
- If there's an error preparing, show an error message in that field.
- Add tests for both of the above cases.
BackgroundTaskService:
- Introduces new BackgroundTaskService, lightweight method for
submitting AsyncTask objects.
- Introduces BackgroundTask interface and simple AbstractBackgroundTask
abstract implementation.
- Adds BackgroundTaskService to ContactsApplication allowing Activity
objects to get hold of a regular background task service.
- Adds a MockBackgroundTaskService for use with injecting for test, so
that we can prevent or control processing of background tasks.
Other:
- Every time we resume the Activity, we were causing a new voicemail
fragment to be created. There was no bug tracking this, I just
noticed it because of occasionally flaky tests. Added a fix and test
to catch it again next time.
- Fixes missing tear down method in PeopleActivityTest.
Bug: 5115133
Bug: 5059965
Bug: 5114261
Bug: 5113695
Change-Id: Ia2469229fa756da8b3977231fbf23a9d3fb379ce
/packages/apps/Contacts/tests/src/com/android/contacts/activities/PeopleActivityTest.java
|
| 2b3f3c54d3beb017b2f59f19e9ce0ecc3e039dbc |
|
27-Jul-2011 |
Dave Santoro <dsantoro@google.com> |
App changes for account types with data sets.
This is primarily a replacement of the Android Account object in most
parts of the app with a new AccountWithDataSet object that extends
Account (by adding an additional attribute, the data set).
This also includes a major refactoring of the AccountTypeManager,
both to allow it to handle data sets and to allow for
non-sync-adapter packages to be referenced by the sync adapters for
an account and registered as sources of contact data. Attributes of
the sync adapter that would typically come from the authenticator
can be parsed out of the Contacts XML for these packages.
Bug 5077096
Change-Id: I88f311c64eae78c88e9999bff6f7de8538e62157
/packages/apps/Contacts/tests/src/com/android/contacts/activities/PeopleActivityTest.java
|
| 34ce5e98f78b46b858d8afd450d1153c1d985426 |
|
06-Jun-2011 |
Flavio Lerda <flerda@google.com> |
Introduces a TestLoaderManager to test loaders.
Currently, the ContactDeletionInterationTest are flaky because waiting
for one of the loader to complete will fail if the loader was completed
before we start waiting.
Since this happens asynchronously and we do not information of which
loaders have completed, there is not an easy way to know whether the
loader already completed or never started.
This change introduces a TestLoaderManager which is an implementation of
LoaderManager which delegates to another object, but keeps track of
which loaders have completed. This allows to correctly wait for Loaders
to complete, even if they might have completed before the call to
waitForLoaders takes place.
Change-Id: I5e3795e10fc9b3424b983cdef4ac32feed7dbf74
/packages/apps/Contacts/tests/src/com/android/contacts/activities/PeopleActivityTest.java
|
| 9856fcee477d04f51bdbcbfdf632876c6b8a1173 |
|
01-Jun-2011 |
Katherine Kuan <katherinekuan@google.com> |
New People activity
- This is part 1 of bringing up the new People app
- Rename ContactBrowserActivity and related XMLs to PeopleActivity
- Change Contacts to People app launcher icon
- Create new task affinity for phone app activities
- Get rid of ContactsFrontDoor activity because it doesn't need
to distinguish between Dialtacts and ContactBrowserActivity anymore
Change-Id: I8c5e1ed540b294c1bda85409ca1499f88d4459ee
/packages/apps/Contacts/tests/src/com/android/contacts/activities/PeopleActivityTest.java
|