12011-04-19 Vsevolod Vlasov <vsevik@chromium.org> 2 3 Reviewed by Pavel Feldman. 4 5 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength 6 https://bugs.webkit.org/show_bug.cgi?id=58883 7 8 * WebCoreSupport/FrameLoaderClientGtk.cpp: 9 (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength): 10 * WebCoreSupport/FrameLoaderClientGtk.h: 11 * webkit/webkitdownload.cpp: 12 (DownloadClient::didReceiveData): 13 142011-04-18 Zan Dobersek <zandobersek@gmail.com> 15 16 Reviewed by Martin Robinson. 17 18 [GTK] Need support for dumping focus rectangles in pixel results 19 https://bugs.webkit.org/show_bug.cgi?id=53647 20 21 Add a support function that returns the rectangle of the current 22 selection in frame. 23 24 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 25 (DumpRenderTreeSupportGtk::rectangleForSelection): 26 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 27 282011-04-12 Xan Lopez <xlopez@igalia.com> 29 30 Unreviewed build fix. 31 32 * webkit/webkitwebhistoryitem.cpp: 33 342011-04-12 Stephanie Lewis <slewis@apple.com> 35 36 Reviewed by Oliver Hunt. 37 38 https://bugs.webkit.org/show_bug.cgi?id=58280 39 <rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception. 40 41 Add a header include. Fallout from untangling some header files in WebCore. 42 43 * webkit/webkitwebhistoryitem.cpp: 44 452011-02-03 Martin Robinson <mrobinson@igalia.com> 46 47 Reviewed by Eric Seidel. 48 49 [GTK] The GTK+ DRT needs an implementation of the PlainTextController 50 https://bugs.webkit.org/show_bug.cgi?id=53605 51 52 Added jsValueToDOMRange to DumpRenderTreeSupportGtk. This static method can convert 53 a JSValueRef to a WebKitDOMRange. When it's possible to do this with the public 54 API, we can remove this method. 55 56 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 57 (DumpRenderTreeSupportGtk::jsValueToDOMRange): Added. 58 * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added declaration. 59 602011-04-11 Mario Sanchez Prada <msanchez@igalia.com> 61 62 Reviewed by Chris Fleizach. 63 64 [Gtk] Implement support for Embedded Objects 65 https://bugs.webkit.org/show_bug.cgi?id=52148 66 67 New accessibility unit test for embedded objects. 68 69 * tests/testatk.c: 70 (testWebkitAtkEmbeddedObjects): New unit test. 71 (main): Added the new unit test. 72 732011-04-08 Dominic Cooney <dominicc@google.com> 74 75 Reviewed by Adam Roben. 76 77 Make layoutTestController.shadowRoot return null, not undefined, 78 when its argument is invalid. 79 https://bugs.webkit.org/show_bug.cgi?id=58121 80 81 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 82 (DumpRenderTreeSupportGtk::shadowRoot): 83 842011-04-08 Dominic Cooney <dominicc@google.com> 85 86 Reviewed by Kent Tamura. 87 88 layoutTestController.shadowRoot should return undefined if its 89 argument is not an element. 90 https://bugs.webkit.org/show_bug.cgi?id=58119 91 92 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 93 (DumpRenderTreeSupportGtk::shadowRoot): 94 952011-04-08 Mario Sanchez Prada <msanchez@igalia.com> 96 97 Reviewed by Martin Robinson. 98 99 [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement 100 https://bugs.webkit.org/show_bug.cgi?id=58039 101 102 Implemented missing functions in GTK's DRT. 103 104 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 105 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 106 (modifyAccessibilityValue): Helper function to increment or decrement 107 the current value for an object through the AccessibilityObject's API. 108 (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function, 109 to be used from GTK's DRT. 110 (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto. 111 1122011-04-06 Gustavo Noronha Silva <gns@gnome.org> 113 114 Reviewed by Martin Robinson. 115 116 [GTK] Need a way to get the path to a WebKitWebPlugin 117 https://bugs.webkit.org/show_bug.cgi?id=57968 118 119 Expose the path of the plugin through the WebKitWebPlugin object. 120 121 * webkit/webkitwebplugin.cpp: 122 (webkit_web_plugin_get_path): 123 * webkit/webkitwebplugin.h: 124 * webkit/webkitwebpluginprivate.h: 125 1262011-04-07 Alice Boxhall <aboxhall@chromium.org> 127 128 Reviewed by Ryosuke Niwa. 129 130 Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler. 131 https://bugs.webkit.org/show_bug.cgi?id=57921 132 133 * webkit/webkitwebview.cpp: 134 (webkit_web_view_forward_context_menu_event): 135 Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode() 136 method has moved on to EventHandler. 137 1382011-04-05 Martin Robinson <mrobinson@igalia.com> 139 140 Reviewed by Eric Seidel. 141 142 [Cairo] Better separate the concerns of GraphicsContextCairo 143 https://bugs.webkit.org/show_bug.cgi?id=55150 144 145 Add a PlatformContextCairo which right now stores the cairo_t* for a 146 GraphicsContextCairo. Later patches will move logic for tracking ContextShadow 147 and image masking layers into this PlatformContextCairo class. 148 149 * webkit/webkitwebframe.cpp: 150 (draw_page_callback): 151 * webkit/webkitwebview.cpp: 152 (webkit_web_view_expose_event): 153 (webkit_web_view_draw): 154 1552011-04-04 MORITA Hajime <morrita@google.com> 156 157 Reviewed by Ryosuke Niwa. 158 159 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult 160 https://bugs.webkit.org/show_bug.cgi?id=56085 161 162 * WebCoreSupport/TextCheckerClientEnchant.h: 163 (WebKit::TextCheckerClientEnchant::requestCheckingOfString): 164 1652011-04-04 Martin Robinson <mrobinson@igalia.com> 166 167 Reviewed by Gustavo Noronha Silva. 168 169 [GTK] WebGL support 170 https://bugs.webkit.org/show_bug.cgi?id=31517 171 172 Add support for toggling WebGL at runtime when it's enabled. 173 174 * webkit/webkitwebsettings.cpp: Add the enable-webgl property. When ENABLE_WEBGL 175 is not enabled, it's a no-op. 176 (webkit_web_settings_class_init): Update to support enable-webgl. 177 (webkit_web_settings_set_property): Ditto. 178 (webkit_web_settings_get_property): Ditto. 179 * webkit/webkitwebview.cpp: 180 (webkit_web_view_update_settings): Ditto. 181 1822011-04-04 Alexey Proskuryakov <ap@apple.com> 183 184 Reviewed by Dan Bernstein. 185 186 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2 187 https://bugs.webkit.org/show_bug.cgi?id=51230 188 <rdar://problem/8780989> 189 190 * webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): Moved Caps Lock handling from 191 WebKits to WebCore, because WebKit shouldn't be smart. 192 1932011-04-04 Martin Robinson <mrobinson@igalia.com> 194 195 Reviewed by Xan Lopez. 196 197 [Gtk] webkit_web_view_popup_menu_handler should call SelectionController::localCaretRect 198 https://bugs.webkit.org/show_bug.cgi?id=54633 199 200 Remove use of legacy editing positions when positioning keyboard-driven context 201 menus. Simplify the code greatly. 202 203 * webkit/webkitwebview.cpp: 204 (getLocationForKeyboardGeneratedContextMenu): Added this helper which calculates 205 the context menu position. 206 (webkit_web_view_popup_menu_handler): Simplify code preventing the menu from bumping 207 into the edges of the view. Remove (0,-1) hack as it no longer seems to be important. 208 2092011-04-02 Dominic Cooney <dominicc@google.com> 210 211 Reviewed by Martin Robinson. 212 213 Add layoutTestController.shadowRoot to GTK DumpRenderTree. 214 https://bugs.webkit.org/show_bug.cgi?id=57551 215 216 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 217 (DumpRenderTreeSupportGtk::shadowRoot): 218 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 219 2202011-04-01 Sheriff Bot <webkit.review.bot@gmail.com> 221 222 Unreviewed, rolling out r82721. 223 http://trac.webkit.org/changeset/82721 224 https://bugs.webkit.org/show_bug.cgi?id=57687 225 226 This patch introduced assertion failures on the GTK+ bots. 227 (Requested by mrobinson on #webkit). 228 229 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 230 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 231 2322011-04-01 Dominic Cooney <dominicc@google.com> 233 234 Reviewed by Martin Robinson. 235 236 Add layoutTestController.shadowRoot to GTK DumpRenderTree. 237 https://bugs.webkit.org/show_bug.cgi?id=57551 238 239 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 240 (DumpRenderTreeSupportGtk::shadowRoot): 241 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 242 2432011-03-31 Xan Lopez <xlopez@igalia.com> 244 245 Reviewed by Martin Robinson. 246 247 [GTK] Link explicitly with XRender on Linux/Unix 248 https://bugs.webkit.org/show_bug.cgi?id=57558 249 250 * GNUmakefile.am: add XRender LIBS. 251 2522011-03-31 Evan Martin <evan@chromium.org> 253 254 Build fix from previous change. 255 256 * WebCoreSupport/FrameLoaderClientGtk.cpp: 257 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): 258 2592011-03-31 Evan Martin <evan@chromium.org> 260 261 Reviewed by Eric Seidel. 262 263 <title> should support dir attribute 264 https://bugs.webkit.org/show_bug.cgi?id=50961 265 266 Update to new FrameLoaderClient interface. 267 268 * WebCoreSupport/FrameLoaderClientGtk.cpp: 269 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): 270 (WebKit::FrameLoaderClient::setTitle): 271 * WebCoreSupport/FrameLoaderClientGtk.h: 272 2732011-03-29 Philippe Normand <pnormand@igalia.com> 274 275 Unreviewed, disable an assert in testwebview due to 276 https://bugs.webkit.org/show_bug.cgi?id=57315 277 278 * tests/testwebview.c: 279 2802011-03-28 Adele Peterson <adele@apple.com> 281 282 Build fix. 283 284 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 285 (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker): 286 2872011-03-28 Sergio Villar Senin <svillar@igalia.com> 288 289 Reviewed by Martin Robinson. 290 291 [GTK] Fullscreen tests failing after r82084 292 https://bugs.webkit.org/show_bug.cgi?id=57219 293 294 Added the withKeyboard parameter to supportsFullScreenForElement 295 method in ChromeClient. Fullscreen will be disabled for keyboard 296 access by default. 297 298 * WebCoreSupport/ChromeClientGtk.cpp: 299 (WebKit::ChromeClient::supportsFullScreenForElement): 300 * WebCoreSupport/ChromeClientGtk.h: 301 3022011-03-25 Andy Estes <aestes@apple.com> 303 304 Reviewed by Adele Peterson. 305 306 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js 307 https://bugs.webkit.org/show_bug.cgi?id=49016 308 309 Update objectContentType() implementation to handle the 310 shouldPreferPlugInsForImages flag. 311 312 * WebCoreSupport/FrameLoaderClientGtk.cpp: 313 (WebKit::FrameLoaderClient::objectContentType): 314 * WebCoreSupport/FrameLoaderClientGtk.h: 315 3162011-03-25 Priit Laes <plaes@plaes.org> 317 318 Reviewed by Martin Robinson. 319 320 [GTK] [PATCH] Avoid critical warning when free-ing list of plugins 321 https://bugs.webkit.org/show_bug.cgi?id=57025 322 323 * webkit/webkitwebplugindatabase.cpp: 324 (webkit_web_plugin_database_plugins_list_free): 325 Use regular check and return instead of g_return_if_fail. 326 3272011-03-24 Sheriff Bot <webkit.review.bot@gmail.com> 328 329 Unreviewed, rolling out r81916 and r81917. 330 http://trac.webkit.org/changeset/81916 331 http://trac.webkit.org/changeset/81917 332 https://bugs.webkit.org/show_bug.cgi?id=57071 333 334 broke a test on platforms that do not have QuickTime installed 335 (Requested by estes on #webkit). 336 337 * WebCoreSupport/FrameLoaderClientGtk.cpp: 338 (WebKit::FrameLoaderClient::objectContentType): 339 * WebCoreSupport/FrameLoaderClientGtk.h: 340 3412011-03-24 Andy Estes <aestes@apple.com> 342 343 Reviewed by Darin Adler. 344 345 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js 346 https://bugs.webkit.org/show_bug.cgi?id=49016 347 348 Update objectContentType() implementation to handle the 349 shouldPreferPlugInsForImages flag. 350 351 * WebCoreSupport/FrameLoaderClientGtk.cpp: 352 (WebKit::FrameLoaderClient::objectContentType): 353 * WebCoreSupport/FrameLoaderClientGtk.h: 354 3552011-03-23 Brady Eidson <beidson@apple.com> 356 357 Reviewed by Sam Weinig. 358 359 Change IconDatabase opening to allow for arbitrary filenames 360 https://bugs.webkit.org/show_bug.cgi?id=56977 361 362 * webkit/webkiticondatabase.cpp: 363 (webkit_icon_database_set_path): 364 3652011-03-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 366 367 Rubber-stamped by Xan Lopez. 368 369 Applications that include WebKit headers fail to build when using strict warnings 370 because the signature for webkit_application_cache_get_maximum_size is missing a 371 'void' to make it explicit it takes no arguments. 372 373 * webkit/webkitapplicationcache.h: 374 3752011-03-21 Alejandro G. Castro <alex@igalia.com> 376 377 Reviewed by Martin Robinson. 378 379 [GTK] 1.3.13 release bump 380 https://bugs.webkit.org/show_bug.cgi?id=56795 381 382 Version bump for 1.3.13 and updated NEWS file with release notes. 383 384 * NEWS: 385 3862011-03-21 Chang Shu <cshu@webkit.org> 387 388 Reviewed by Alexey Proskuryakov. 389 390 REGRESSION (r79953): Can't type in MS Outlook 2011 391 https://bugs.webkit.org/show_bug.cgi?id=56665 392 393 r79953 removed the WebView level editablity which is persistent no matter whether 394 underlying document itself is changed and editability gets lost. The resolution is to 395 set this WebView editable value to WebCore. This avoids the callback from WebCore to 396 WebKit which was the main goal in r79953 to improve performance. 397 398 * webkit/webkitwebview.cpp: 399 (webkit_web_view_get_editable): 400 (webkit_web_view_set_editable): 401 4022011-03-21 Mario Sanchez Prada <msanchez@igalia.com> 403 404 Reviewed by Martin Robinson. 405 406 [GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes 407 https://bugs.webkit.org/show_bug.cgi?id=56737 408 409 * tests/testatk.c: 410 (testWebkitAtkHypertextAndHyperlinks): Updated unit test to also 411 check offsets for hyperlinks inside <span> nodes. 412 4132011-03-18 David Keijser <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com> 414 415 Reviewed by Martin Robinson. 416 417 [GTK] On-demand event-listeners for DOM event signals 418 https://bugs.webkit.org/show_bug.cgi?id=49649 419 420 * tests/testdomdomwindow.c: update unit tests for new APIs. 421 (load_event_callback): ditto. 422 (test_dom_domview_signals): ditto. 423 (load_status_callback): ditto. 424 4252011-03-17 Brady Eidson <beidson@apple.com> 426 427 Reviewed by Sam Weinig. 428 429 https://bugs.webkit.org/show_bug.cgi?id=56425 430 More groundwork for WebKit2 IconDatabase 431 432 Update already-used function names: 433 * webkit/webkiticondatabase.cpp: 434 (webkit_icon_database_get_icon_uri): 435 (webkit_icon_database_get_icon_pixbuf): 436 * webkit/webkitwebview.cpp: 437 (webkit_web_view_get_icon_uri): 438 4392011-03-16 Joseph Pecoraro <joepeck@webkit.org> 440 441 Reviewed by Kenneth Rohde Christiansen. 442 443 Viewport no longer allows an auto value for "user-scalable" 444 https://bugs.webkit.org/show_bug.cgi?id=55416 445 446 Make the default value for userScalable be true. 447 448 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 449 (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): update test output to include userScalable. 450 * webkit/webkitviewportattributes.cpp: 451 (webkitViewportAttributesRecompute): 452 4532011-03-15 Ilya Sherman <isherman@chromium.org> 454 455 Reviewed by Tony Chang. 456 457 Autofilled form elements are assigned fixed background color but not text color 458 https://bugs.webkit.org/show_bug.cgi?id=48382 459 460 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 461 (DumpRenderTreeSupportGtk::setAutofilled): Added. 462 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 463 4642011-03-14 Ryuan Choi <ryuan.choi@samsung.com> 465 466 Reviewed by Martin Robinson. 467 468 [GTK] Possible leaks after splitting TextCheckerClientEnchant. 469 https://bugs.webkit.org/show_bug.cgi?id=55989 470 471 Convert gchar* to GOwnPtr<gchar> and refactor the code. 472 473 * WebCoreSupport/TextCheckerClientEnchant.cpp: 474 (WebKit::TextCheckerClientEnchant::checkSpellingOfString): 475 4762011-03-11 Marco Peereboom <marco@peereboom.us> 477 478 Reviewed by Gustavo Noronha Silva. 479 480 Provide a knob to enable/disable DNS prefetching. 481 DNS prefetching is enabled by default. 482 https://bugs.webkit.org/show_bug.cgi?id=55973 483 484 * webkit/webkitwebsettings.cpp: 485 (webkit_web_settings_class_init): 486 (webkit_web_settings_set_property): 487 (webkit_web_settings_get_property): 488 (webkit_web_settings_copy): 489 * webkit/webkitwebview.cpp: 490 (webkit_web_view_update_settings): 491 (webkit_web_view_settings_notify): 492 4932011-03-08 Philippe Normand <pnormand@igalia.com> 494 495 Reviewed by Martin Robinson. 496 497 [GTK] close-web-view emitted on disposed WebView 498 https://bugs.webkit.org/show_bug.cgi?id=55932 499 500 * WebCoreSupport/ChromeClientGtk.cpp: 501 (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib 502 source before destruction of the ChromeClient. 503 5042011-03-11 Roland Steiner <rolandsteiner@chromium.org> 505 506 Reviewed by Ryosuke Niwa. 507 508 Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/ 509 https://bugs.webkit.org/show_bug.cgi?id=55570 510 511 Add a virtual function toInputElement() to Node that has a default 512 implementation of returning 0. 513 For HTMLInputElement and WMLInputElement (which derive from InputElement) 514 override this to return the object. 515 Change all calling sites of the old toInputElement to use the new member 516 function. This also allows us to save some casts. 517 518 No new tests (refactoring). 519 520 * src/WebInputElement.cpp: 521 (WebKit::toWebInputElement): 522 523 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 524 (DumpRenderTreeSupportGtk::setValueForUser): 525 5262011-03-10 Philippe Normand <pnormand@igalia.com> 527 528 Reviewed by Xan Lopez. 529 530 [GTK] unittests/testapplicationcache crashes 531 https://bugs.webkit.org/show_bug.cgi?id=56083 532 533 Removed the webkit_application_cache_get_database_directory_path 534 API as the underlying ApplicationCacheStorage doesn't allow 535 setting the cache path multiple times. 536 537 * tests/testapplicationcache.c: 538 (main): 539 * webkit/webkitapplicationcache.cpp: 540 (webkit_application_cache_get_database_directory_path): 541 * webkit/webkitapplicationcache.h: 542 * webkit/webkitglobals.cpp: 543 (webkitInit): 544 5452011-03-09 Peter Kasting <pkasting@google.com> 546 547 Reviewed by Mihai Parparita. 548 549 Unify Windows version checks. 550 https://bugs.webkit.org/show_bug.cgi?id=55979 551 552 * webkit/webkitwebsettings.cpp: 553 (webkitOSVersion): 554 5552011-03-08 Christian Dywan <christian@lanedo.com> 556 557 Reviewed by Martin Robinson. 558 559 [GTK] provide an API to control the IconDatabase 560 https://bugs.webkit.org/show_bug.cgi?id=32510 561 562 * GNUmakefile.am: 563 * WebCoreSupport/FrameLoaderClientGtk.cpp: Emit signals on 564 the icon database for new icons. 565 * webkit/webkit.h: 566 * webkit/webkitdefines.h: 567 * webkit/webkitglobals.cpp: 568 * webkit/webkitglobals.h: Add a function to obtain the global 569 icon database. 570 * webkit/webkiticondatabase.cpp: 571 * webkit/webkiticondatabase.h: Implement public icon database 572 object with methods for obtaining icon URLs, pixbufs, clearing 573 waiting for new icons. 574 * webkit/webkitwebview.cpp: 575 * webkit/webkitwebview.h: Add a method to obtain an icon pixbuf 576 for the web view. 5772011-03-08 Carlos Garcia Campos <cgarcia@igalia.com> 578 579 Reviewed by Martin Robinson. 580 581 [GTK] Add layoutTestController.setValueForUser() after r80412 582 https://bugs.webkit.org/show_bug.cgi?id=55862 583 584 Add setValueForUser method to DumpRenderTreeSupportGTK. 585 586 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 587 (DumpRenderTreeSupportGtk::setValueForUser): 588 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 589 5902011-03-07 Sam Weinig <sam@webkit.org> 591 592 Reviewed by Anders Carlsson. 593 594 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse 595 https://bugs.webkit.org/show_bug.cgi?id=55827 596 597 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse 598 and pass the entire response, instead of just the MIMEType. 599 600 * WebCoreSupport/FrameLoaderClientGtk.cpp: 601 (WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse): 602 * WebCoreSupport/FrameLoaderClientGtk.h: 603 6042011-03-01 Martin Robinson <mrobinson@igalia.com> 605 606 Reviewed by Xan Lopez. 607 608 [GTK] Windowless plugins override the view cursor 609 https://bugs.webkit.org/show_bug.cgi?id=55531 610 611 * WebCoreSupport/ChromeClientGtk.cpp: 612 (WebKit::ChromeClient::setCursor): Moved the implementation of setCursor here 613 which is more fitting since it sets the cursor for the entire window. 614 6152011-03-03 Brady Eidson <beidson@apple.com> 616 617 Reviewed by Darin Adler. 618 619 https://bugs.webkit.org/show_bug.cgi?id=55721 620 Global IconDatabase should be returned by reference, not as a pointer 621 622 * webkit/webkitglobals.cpp: 623 (closeIconDatabaseOnExit): 624 (WebKit::setIconDatabaseEnabled): 625 * webkit/webkitwebview.cpp: 626 (webkit_web_view_get_icon_uri): 627 6282011-03-03 Alexey Proskuryakov <ap@apple.com> 629 630 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included 631 via ChromeClient.h 632 633 * WebCoreSupport/ChromeClientGtk.h: 634 6352011-03-02 Alexey Proskuryakov <ap@apple.com> 636 637 Reviewed by Darin Adler. 638 639 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access 640 https://bugs.webkit.org/show_bug.cgi?id=55633 641 <rdar://problem/8963023> 642 643 * WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::keyboardUIMode): 644 * WebCoreSupport/ChromeClientGtk.h: 645 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since 646 this platform doesn't observe or have full keyboard access state. 647 6482011-03-03 Lukasz Slachciak <l.slachciak@samsung.com> 649 650 Reviewed by Xan Lopez. 651 652 [GTK] Extended application cache database API and added unit tests file. 653 https://bugs.webkit.org/show_bug.cgi?id=55335 654 655 * GNUmakefile.am: Add testapplicationcache.c and remove webkitapplicationcacheprivate.h. 656 * tests/testapplicationcache.c: Added. 657 (test_applicationcache_maximum_size): Tests if application cache storage is set/get correctly. 658 (test_applicationcache_database_directory_path): Tests if application cache directory path is set/get correctly. 659 (main): 660 * webkit/webkitapplicationcache.cpp: 661 (webkit_application_cache_get_maximum_size): New API for getting application cache maximum storage size. 662 * webkit/webkitapplicationcache.h: Declaration of API for getting/setting application cache maximum storage size. 663 * webkit/webkitapplicationcacheprivate.h: Removed. 6642011-03-03 Peter Kasting <pkasting@google.com> 665 666 Reviewed by James Robinson. 667 668 Drop redundant "Windows; " from the Windows-specific User Agent string. 669 https://bugs.webkit.org/show_bug.cgi?id=54567 670 671 * webkit/webkitwebsettings.cpp: 672 (webkitPlatform): 673 (webkitUserAgent): 674 6752011-03-02 Martin Robinson <mrobinson@igalia.com> 676 677 Reviewed by Xan Lopez. 678 679 Do a bit of cleanup in ChromeClientGtk. Instead of always fetching the 680 WebKitWebView from the frame, simply get it from the member variable of 681 the ChromeClientGtk instance itself. 682 683 * WebCoreSupport/ChromeClientGtk.cpp: 684 (WebKit::ChromeClient::scrollbarsVisible): 685 (WebKit::ChromeClient::exceededDatabaseQuota): 686 (WebKit::ChromeClient::requestGeolocationPermissionForFrame): 687 (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame): 688 (WebKit::ChromeClient::enterFullscreenForNode): 689 (WebKit::ChromeClient::exitFullscreenForNode): 690 6912011-03-01 Joseph Pecoraro <joepeck@webkit.org> 692 693 Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port. 694 695 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 696 (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): 697 * webkit/webkitviewportattributes.cpp: 698 (webkitViewportAttributesRecompute): 699 7002011-03-01 Joseph Pecoraro <joepeck@webkit.org> 701 702 Reviewed by Kenneth Rohde Christiansen. 703 704 Viewport Warning/Error Messages Are Now Inaccurate 705 https://bugs.webkit.org/show_bug.cgi?id=53707 706 707 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 708 (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): pass a Document into computeViewportAttributes for warnings to be reported to. 709 * webkit/webkitviewportattributes.cpp: 710 (webkitViewportAttributesRecompute): pass a Document into computeViewportAttributes for warnings to be reported to. 711 7122011-03-01 Kamil Blank <k.blank@samsung.com> 713 714 Reviewed by Martin Robinson. 715 716 [GTK] Fixing headers order in webkit.h. 717 https://bugs.webkit.org/show_bug.cgi?id=55316 718 719 * webkit/webkit.h: Style fix. 720 7212011-03-01 Joone Hur <joone.hur@collabora.co.uk> 722 723 Reviewed by Martin Robinson. 724 725 [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp 726 https://bugs.webkit.org/show_bug.cgi?id=55437 727 728 * webkit/webkitwebview.cpp: Convert use of cairo_t to RefPtr<cairo_t>. 729 (webkit_web_view_expose_event): 730 7312011-02-28 Chang Shu <cshu@webkit.org> 732 733 Reviewed by Ryosuke Niwa. 734 735 Remove the support of Frame::isContentEditable and its dependencies. 736 https://bugs.webkit.org/show_bug.cgi?id=54292 737 738 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode. 739 740 * WebCoreSupport/EditorClientGtk.cpp: 741 * WebCoreSupport/EditorClientGtk.h: 742 * webkit/webkitwebview.cpp: 743 (webkit_web_view_init): 744 (webkit_web_view_get_editable): 745 (webkit_web_view_set_editable): 746 * webkit/webkitwebviewprivate.h: 747 7482011-02-26 Lukasz Slachciak <l.slachciak@samsung.com> 749 750 Reviewed by Xan Lopez. 751 752 [GTK] Implemented API to set/get web application cache directory path database. 753 754 * GNUmakefile.am: Add webkitapplicationcache.h file. 755 * webkit/webkit.h: Add webkitapplicationcache.h file. 756 * webkit/webkitapplicationcache.cpp: definition of API setting and getting 757 web application cache directory path database. 758 (webkit_application_cache_get_database_directory_path): 759 (webkit_application_cache_set_database_directory_path): 760 * webkit/webkitapplicationcache.h: Added new API file for setting and getting 761 web application cache directory path database. 762 * webkit/webkitglobals.cpp: 763 (webkitInit): use webkit_application_cache_set_database_directory_path 764 to set default web application cache directory path database. 765 7662011-02-26 Vsevolod Vlasov <vsevik@chromium.org> 767 768 Reviewed by Pavel Feldman. 769 770 DumpRenderTree should reset frame opener between tests. 771 https://bugs.webkit.org/show_bug.cgi?id=54874 772 773 Added clearOpener method to DumpRenderTreeSupportGTK. 774 775 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 776 (DumpRenderTreeSupportGtk::clearOpener): 777 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 778 7792011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org> 780 781 Reviewed by Andreas Kling. 782 783 Make it possible to test the targetdensity-dpi support 784 https://bugs.webkit.org/show_bug.cgi?id=55142 785 786 Test the viewport meta tag feature targetdensity-dpi by 787 adding extra arguments to dumpConfigurationForViewport 788 789 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 790 (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): 791 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 792 7932011-02-26 Sheriff Bot <webkit.review.bot@gmail.com> 794 795 Unreviewed, rolling out r79764. 796 http://trac.webkit.org/changeset/79764 797 https://bugs.webkit.org/show_bug.cgi?id=55295 798 799 "broke Chromium builds" (Requested by rniwa on #webkit). 800 801 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 802 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 803 8042011-02-26 Vsevolod Vlasov <vsevik@chromium.org> 805 806 Reviewed by Pavel Feldman. 807 808 DumpRenderTree should reset frame opener between tests. 809 https://bugs.webkit.org/show_bug.cgi?id=54874 810 811 Added clearOpener method to DumpRenderTreeSupportGTK. 812 813 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 814 (DumpRenderTreeSupportGtk::clearOpener): 815 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 816 8172011-02-24 Peter Kasting <pkasting@google.com> 818 819 Reviewed by Eric Seidel. 820 821 Drop the "U; " encryption level from the User Agent string. 822 https://bugs.webkit.org/show_bug.cgi?id=54566 823 824 * webkit/webkitwebsettings.cpp: 825 (webkitUserAgent): 826 8272011-02-24 Andrew Wilson <atwilson@chromium.org> 828 829 Unreviewed, rolling out r79570. 830 http://trac.webkit.org/changeset/79570 831 https://bugs.webkit.org/show_bug.cgi?id=54874 832 833 Breaks chromium build because glue/mocks/mock_web_frame.h/cc 834 was not updated 835 836 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 837 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 838 8392011-02-24 Vsevolod Vlasov <vsevik@chromium.org> 840 841 Reviewed by Alexey Proskuryakov. 842 843 DumpRenderTree should reset frame opener between tests. 844 https://bugs.webkit.org/show_bug.cgi?id=54874 845 846 Added clearOpener method to DumpRenderTreeSupportGTK. 847 848 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 849 (DumpRenderTreeSupportGtk::clearOpener): 850 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 851 8522011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com> 853 854 Reviewed by Alexey Proskuryakov. 855 856 Drop the language tag part from the User Agent string 857 https://bugs.webkit.org/show_bug.cgi?id=54560 858 859 * webkit/webkitwebsettings.cpp: 860 (webkitUserAgent): 861 8622011-02-22 Martin Robinson <mrobinson@igalia.com> 863 864 Reviewed by Xan Lopez. 865 866 [GTK] position:fixed elements flicker while scrolling after r74196 867 https://bugs.webkit.org/show_bug.cgi?id=54981 868 869 * WebCoreSupport/ChromeClientGtk.cpp: 870 (WebKit::ChromeClient::ChromeClient): Initialize the new m_pendingScrollInvalidations 871 boolean to false. 872 (WebKit::ChromeClient::invalidateWindow): If this is an immediate invalidation and we 873 having pending scrolling invalidations, instruct GDK to process updates now. 874 (WebKit::ChromeClient::scroll): Remove the call to gdk_window_process_updates. Set 875 m_pendingScrollInvalidations to true to force it to happen in invalidateWindow instead. 876 * WebCoreSupport/ChromeClientGtk.h: Add new boolean member. 877 8782011-02-02 Martin Robinson <mrobinson@igalia.com> 879 880 Reviewed by Xan Lopez. 881 882 [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace 883 https://bugs.webkit.org/show_bug.cgi?id=53603 884 885 Add setSelectTrailingWhitespaceEnabled and selectTrailingWhitespaceEnabled which allow 886 setting and querying the selectTrailingWhitespaceEnabled setting. EditorClient just 887 listens to this value during DRT runs. Perhaps later we can expose this to the public 888 API. 889 890 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 891 (DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled): Added 892 (DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled): Added 893 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 894 * WebCoreSupport/EditorClientGtk.cpp: 895 (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): Ask DRTSupportGtk 896 for the appropriate return value. 897 8982011-02-21 Alejandro G. Castro <alex@igalia.com> 899 900 Reviewed by Xan Lopez. 901 902 [GTK] [REGRESSION] After r79130, spell tests did not work 903 https://bugs.webkit.org/show_bug.cgi?id=54860 904 905 * WebCoreSupport/TextCheckerClientEnchant.cpp: 906 (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided 907 freeing the default PangoLanguage. 908 * webkit/webkitwebview.cpp: 909 (webkit_web_view_update_settings): Initialized list of dictionaries. 910 9112011-02-17 Ryosuke Niwa <rniwa@webkit.org> 912 913 Reviewed by Kent Tamura. 914 915 Rename Position::node() to Position::deprecatedNode() 916 https://bugs.webkit.org/show_bug.cgi?id=54622 917 918 Done the rename. All calls to node() are replaced by calls to deprecatedNode(). 919 920 * webkit/webkitwebview.cpp: 921 (webkit_web_view_popup_menu_handler): 922 9232011-02-19 Ryuan Choi <ryuan.choi@samsung.com> 924 925 Reviewed by Martin Robinson. 926 927 [GTK] Remove mandatory Enchant dependency 928 https://bugs.webkit.org/show_bug.cgi?id=51587 929 930 Extract TextCheckerClientEnchant From EditorClientGtk and remove 931 enchant dependency from other files. 932 933 * GNUmakefile.am: 934 * WebCoreSupport/EditorClientGtk.cpp: 935 (WebKit::EditorClient::EditorClient): 936 * WebCoreSupport/EditorClientGtk.h: 937 (WebKit::EditorClient::textChecker): 938 * WebCoreSupport/TextCheckerClientEnchant.cpp: Added. 939 (WebKit::TextCheckerClientEnchant::TextCheckerClientEnchant): 940 (WebKit::TextCheckerClientEnchant::~TextCheckerClientEnchant): 941 (WebKit::TextCheckerClientEnchant::ignoreWordInSpellDocument): 942 (WebKit::TextCheckerClientEnchant::learnWord): 943 (WebKit::TextCheckerClientEnchant::checkSpellingOfString): 944 (WebKit::TextCheckerClientEnchant::getAutoCorrectSuggestionForMisspelledWord): 945 (WebKit::TextCheckerClientEnchant::checkGrammarOfString): 946 (WebKit::TextCheckerClientEnchant::getGuessesForWord): 947 (WebKit::getAvailableDictionariesCallback): 948 (WebKit::TextCheckerClientEnchant::updateSpellCheckingLanguage): 949 (WebKit::TextCheckerClientEnchant::freeSpellCheckingLanguage): 950 * WebCoreSupport/TextCheckerClientEnchant.h: Added. 951 (WebKit::TextCheckerClientEnchant::requestCheckingOfString): 952 * webkit/webkitwebsettings.cpp: 953 (webkit_web_settings_finalize): 954 (webkit_web_settings_set_property): 955 * webkit/webkitwebview.cpp: 956 (webkit_web_view_settings_notify): 957 9582011-02-19 Charlie Reis <creis@chromium.org> 959 960 Reviewed by Mihai Parparita. 961 962 Ensure loading has stopped in HistoryController::goToItem 963 https://bugs.webkit.org/show_bug.cgi?id=54517 964 965 Add a FrameLoaderClient callback for whether to stop loading before goToItem. 966 967 Test: http/tests/navigation/forward-to-fragment-fires-onload.html 968 969 * WebCoreSupport/FrameLoaderClientGtk.cpp: 970 (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added. 971 * WebCoreSupport/FrameLoaderClientGtk.h: 972 9732011-02-18 Mario Sanchez Prada <msanchez@igalia.com> 974 975 Reviewed by Martin Robinson. 976 977 [Gtk] atk_text_get_selection/atk_text_set_selection fails for list items 978 https://bugs.webkit.org/show_bug.cgi?id=53453 979 980 Update unit test to check the fix for this bug. 981 982 * tests/testatk.c: 983 (testWebkitAtkTextSelections): Check that functions from AtkText 984 interface to set and get text selections work with list items. 985 9862011-02-17 Robert Ancell <rober.ancell@gmail.com> 987 988 Reviewed by Martin Robinson. 989 990 [PATCH] GTK documentation fails to build due to changed paths 991 https://bugs.webkit.org/show_bug.cgi?id=54600 992 993 * docs/GNUmakefile.am: Update the paths that have now moved the Source 994 directory. 995 9962011-02-16 Joone Hur <joone.hur@collabora.co.uk> 997 998 Reviewed by Xan Lopez. 999 1000 [GTK] Match more various WebKit API enum values with WebCore enum values 1001 https://bugs.webkit.org/show_bug.cgi?id=54352 1002 1003 AssertMatchingEnums.cpp was added to assert that various WebKit API enum values 1004 continue matching WebCore defined enum values in the following changeset. 1005 http://trac.webkit.org/changeset/77868 1006 However, there are already enum values that have been asserted in other files, 1007 so these assert macros defined need to be moved to AssertMatchingEnum.cpp. 1008 1009 * WebCoreSupport/AssertMatchingEnums.cpp: Add more enum values to be asserted. 1010 * webkit/webkitwebnavigationaction.cpp: 1011 (webkit_web_navigation_action_class_init): Move the assert macros of 1012 WEBKIT_WEB_NAVIGATION_REASON_* to AssertMatchingEnums.cpp. 1013 * webkit/webkitwebsettings.cpp: 1014 (webkit_web_settings_class_init): Move the assert macros of WEBKIT_EDITING_BEHAVIOR_* 1015 to AssertMatchingEnums.cpp. 1016 10172011-02-16 Mario Sanchez Prada <msanchez@igalia.com> 1018 1019 Reviewed by Martin Robinson. 1020 1021 [GTK] events missing when a document is (re)loaded 1022 https://bugs.webkit.org/show_bug.cgi?id=25831 1023 1024 Emit the right signals when reloading a document. 1025 1026 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1027 (WebKit::notifyAccessibilityStatus): New function, to make sure 1028 the signals involved in reloading a document are properly emitted. 1029 (WebKit::notifyStatus): Also notify accessibility if enabled. 1030 10312011-02-15 Kenneth Russell <kbr@google.com> 1032 1033 Reviewed by Darin Fisher. 1034 1035 Allow controlling minimum DOMTimer interval on a per-page basis 1036 https://bugs.webkit.org/show_bug.cgi?id=54312 1037 1038 Added needed methods to implement LayoutTestController's new 1039 setMinimumTimerInterval method. 1040 1041 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 1042 (DumpRenderTreeSupportGtk::defaultMinimumTimerInterval): 1043 (DumpRenderTreeSupportGtk::setMinimumTimerInterval): 1044 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 1045 10462011-02-15 Christian Dywan <christian@lanedo.com> 1047 1048 Rubber-stamped by Gustavo Noronha Silva. 1049 1050 * webkit/webkitwebsettings.cpp: Correct a typo, it is 1051 acces*s*ibility with two s. 1052 10532011-01-26 MORITA Hajime <morrita@google.com> 1054 1055 Reviewed by Ryosuke Niwa. 1056 1057 Refactoring: Extract TextCheckerClient from EditorClient 1058 https://bugs.webkit.org/show_bug.cgi?id=53213 1059 1060 * WebCoreSupport/EditorClientGtk.h: 1061 (WebKit::EditorClient::textChecker): 1062 10632011-02-07 Ryosuke Niwa <rniwa@webkit.org> 1064 1065 Reviewed by Adam Barth. 1066 1067 Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard 1068 https://bugs.webkit.org/show_bug.cgi?id=52417 1069 1070 Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently 1071 not implemented. 1072 1073 * WebCoreSupport/EditorClientGtk.cpp: 1074 (WebKit::EditorClient::canCopyCut): Added. 1075 (WebKit::EditorClient::canPaste): Added. 1076 * WebCoreSupport/EditorClientGtk.h: 1077 10782011-02-14 Alejandro G. Castro <alex@igalia.com> 1079 1080 Reviewed by Xan Lopez. 1081 1082 [GTK] testwebdatasource test fails in the bots 1083 https://bugs.webkit.org/show_bug.cgi?id=54414 1084 1085 Changed the uri we check, added www to avoid the rewrite that we 1086 get when we as the uri to the request in case it finishes. 1087 1088 * tests/testwebdatasource.c: 1089 (notify_load_status_cb): 1090 10912011-02-11 Sheriff Bot <webkit.review.bot@gmail.com> 1092 1093 Unreviewed, rolling out r78331. 1094 http://trac.webkit.org/changeset/78331 1095 https://bugs.webkit.org/show_bug.cgi?id=54295 1096 1097 This patch broke 11 tests in GTK bots (Requested by svillar on 1098 #webkit). 1099 1100 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1101 (WebKit::notifyStatus): 1102 11032011-02-10 Nate Chapin <japhet@chromium.org> 1104 1105 Reviewed by Adam Barth. 1106 1107 Update calls to DocumentWriter. 1108 https://bugs.webkit.org/show_bug.cgi?id=50489 1109 1110 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1111 (WebKit::FrameLoaderClient::FrameLoaderClient): 1112 (WebKit::FrameLoaderClient::didRunInsecureContent): 1113 (WebKit::FrameLoaderClient::dispatchDidLoadMainResource): 1114 (WebKit::FrameLoaderClient::finishedLoading): 1115 * WebCoreSupport/FrameLoaderClientGtk.h: 1116 * webkit/webkitwebview.cpp: 1117 (webkit_web_view_get_encoding): 1118 11192011-02-11 Mario Sanchez Prada <msanchez@igalia.com> 1120 1121 Reviewed by Xan Lopez. 1122 1123 [GTK] events missing when a document is (re)loaded 1124 https://bugs.webkit.org/show_bug.cgi?id=25831 1125 1126 Emit the right signals when reloading a document. 1127 1128 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1129 (WebKit::notifyAccessibilityStatus): New function, to make sure 1130 the signals involved in reloading a document are properly emitted. 1131 (WebKit::notifyStatus): Also notify accessibility if enabled. 1132 11332011-02-08 Martin Robinson <mrobinson@igalia.com> 1134 1135 Reviewed by Xan Lopez. 1136 1137 [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled 1138 https://bugs.webkit.org/show_bug.cgi?id=54033 1139 1140 Add a DumpRenderTreeSupportGtk method for turning the icon database on and off. 1141 This is a likely candidate for a new API point. 1142 1143 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 1144 (DumpRenderTreeSupportGtk::setIconDatabaseEnabled): Added. 1145 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 1146 * webkit/webkitglobals.cpp: 1147 (webkitInit): Call setIconDatabaseEnabled(true) on startup, instead 1148 of initializing the database manually. 1149 (WebKit::setIconDatabaseEnabled): Added. 1150 * webkit/webkitglobalsprivate.h: Added declarations. 1151 11522011-02-08 Adam Barth <abarth@webkit.org> 1153 1154 Reviewed by Eric Seidel. 1155 1156 Remove orphan code from old parser 1157 https://bugs.webkit.org/show_bug.cgi?id=53984 1158 1159 * WebCoreSupport/ChromeClientGtk.h: 1160 11612011-02-02 Ilya Tikhonovsky <loislo@chromium.org> 1162 1163 Reviewed by Yury Semikhatsky. 1164 1165 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController. 1166 1167 https://bugs.webkit.org/show_bug.cgi?id=53169 1168 1169 Minor change enforced by major changes in WebCore/inspector/InspectorController. 1170 1171 * WebCoreSupport/InspectorClientGtk.cpp: 1172 * webkit/webkitwebinspector.cpp: 1173 (webkit_web_inspector_get_property): 1174 11752011-02-08 Carlos Garcia Campos <cgarcia@igalia.com> 1176 1177 Reviewed by Martin Robinson. 1178 1179 [GTK] DRT's TextInputController is unimplemented on GTK 1180 https://bugs.webkit.org/show_bug.cgi?id=52997 1181 1182 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 1183 (DumpRenderTreeSupportGtk::setComposition): 1184 (DumpRenderTreeSupportGtk::confirmComposition): 1185 (DumpRenderTreeSupportGtk::firstRectForCharacterRange): 1186 (DumpRenderTreeSupportGtk::selectedRange): New methods needed by 1187 TextInputController. 1188 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 1189 11902011-02-07 Enrica Casucci <enrica@apple.com> 1191 1192 Reviewed Adam Roben and Darin Adler. 1193 1194 WebKit2: drag and drop support on Windows. 1195 https://bugs.webkit.org/show_bug.cgi?id=52775 1196 1197 Removed createDragImageForLink from DragClient. 1198 1199 * WebCoreSupport/DragClientGtk.cpp: 1200 * WebCoreSupport/DragClientGtk.h: 1201 12022011-02-07 Joone Hur <joone.hur@collabora.co.uk> 1203 1204 Reviewed by Martin Robinson. 1205 1206 [Gtk] Implement layoutTestController.findString 1207 https://bugs.webkit.org/show_bug.cgi?id=50237 1208 1209 * GNUmakefile.am: Add AssertMatchingEnums.cpp. 1210 * WebCoreSupport/AssertMatchingEnums.cpp: Add this file to assert that various 1211 WebKit API enum values continue matching WebCore defined enum values. 1212 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 1213 (DumpRenderTreeSupportGtk::findString): 1214 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 1215 12162011-02-07 Martin Robinson <mrobinson@igalia.com> 1217 1218 Reviewed by Daniel Bates. 1219 1220 [GTK] fast/history/history-subframe-with-name.html fails with GTK DRT 1221 https://bugs.webkit.org/show_bug.cgi?id=44784 1222 1223 Call FrameLoader::loadURLIntoChildFrame on the parent frame's loader, not the child's. 1224 1225 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1226 (WebKit::FrameLoaderClient::createFrame): Fix the call to FrameLoader::loadURLIntoChildFrame. 1227 12282011-02-07 Mario Sanchez Prada <msanchez@igalia.com> 1229 1230 Reviewed by Xan Lopez. 1231 1232 [Gtk] atk_text_get_caret_offset fails for list items 1233 https://bugs.webkit.org/show_bug.cgi?id=53436 1234 1235 Update unit test to check the fix for this bug. 1236 1237 * tests/testatk.c: 1238 (testWebkitAtkCaretOffsets): Check that the caret offset returned 1239 match the value previously set. 1240 12412011-02-04 Joone Hur <joone.hur@collabora.co.uk> 1242 1243 Unreviewed, Fix compilation warning. 1244 1245 Constructor initialization list should follow the declaration order. 1246 1247 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1248 (WebKit::FrameLoaderClient::FrameLoaderClient): m_hasRepresentation is moved to 1249 the last position in the initialization list. 1250 12512011-02-04 Martin Robinson <mrobinson@igalia.com> 1252 1253 Reviewed by Xan Lopez. 1254 1255 [GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name 1256 https://bugs.webkit.org/show_bug.cgi?id=53797 1257 1258 When the frame name changes between different calls to webkit_web_frame_get_name 1259 on the same frame, return the new frame name instead of the one valid during the 1260 previous call. 1261 1262 * webkit/webkitwebframe.cpp: 1263 (webkit_web_frame_init): Initialize the frame name to 0. 1264 (webkit_web_frame_get_name): Check the current frame name first before 1265 returning the cached value. 1266 12672011-02-04 Martin Robinson <mrobinson@igalia.com> 1268 1269 Reviewed by Gustavo Noronha Silva. 1270 1271 [GTK] fast/events/pagehide-timeout.html fails 1272 https://bugs.webkit.org/show_bug.cgi?id=53771 1273 1274 Add the document browser cache model. This model is optimized for viewing 1275 a series of local files, while the document viewer is optimized for only 1276 viewing one local file. Improve the documentation on the mapping of these 1277 enum values to actual cache settings. 1278 1279 * webkit/webkitglobals.cpp: 1280 (webkit_set_cache_model): Add support for the document browser cache model and 1281 improve comments in this section better explaining where the magic numbers come from. 1282 * webkit/webkitglobals.h: Added an enum value for the document browser cache model. 1283 12842011-02-03 Yury Semikhatsky <yurys@chromium.org> 1285 1286 Reviewed by Pavel Feldman. 1287 1288 Web Inspector: remove settings related methods from InspectorClient 1289 https://bugs.webkit.org/show_bug.cgi?id=53686 1290 1291 * WebCoreSupport/InspectorClientGtk.cpp: 1292 (WebKit::InspectorFrontendClient::InspectorFrontendClient): 1293 * WebCoreSupport/InspectorClientGtk.h: 1294 12952011-02-03 Adam Langley <agl@chromium.org> 1296 1297 Reviewed by Adam Barth. 1298 1299 Plumb mixed script URL to FrameLoaderClient 1300 https://bugs.webkit.org/show_bug.cgi?id=52384 1301 1302 Regressions covered by http/tests/security/mixedContent/* 1303 1304 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1305 (WebKit::FrameLoaderClient::didRunInsecureContent): 1306 * WebCoreSupport/FrameLoaderClientGtk.h: 1307 13082011-02-03 Joone Hur <joone.hur@collabora.co.uk> 1309 1310 Reviewed by Martin Robinson. 1311 1312 [Gtk] No need to set text encoding in the provisional phase 1313 https://bugs.webkit.org/show_bug.cgi?id=53487 1314 1315 According to changeset 67253, setEncoding could be called multiple times from 1316 committedLoad, finishedLoading, dispatchDidFailLoading, and setMainDocumentError 1317 in FrameLoaderClient. To fix this, the relevant code was removed from 1318 FrameLoaderClient and moved to DocumentLoader::commitData. However, that 1319 code was not removed from FrameLoaderClient::finishedLoading in WebKitGtk+. 1320 1321 Due to this reason, after loading a html document, other ports initialize the 1322 text encoding from FrameLoaderClient::finishedLoading, but WebKitGtk+ sets 1323 the same encoding again, even tries to set encoding in the provisional phase. 1324 This causes unnecessary encoding setting. 1325 1326 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1327 (WebKit::FrameLoaderClient::FrameLoaderClient): Set m_hasRepresentation to false. 1328 (WebKit::FrameLoaderClient::makeRepresentation): Set m_hasRepresentation to true. 1329 (WebKit::FrameLoaderClient::revertToProvisionalState): Set m_hasRepresentation to true. 1330 (WebKit::FrameLoaderClient::finishedLoading): Skip the encoding setting when 1331 m_hasRepresentation is false. 1332 * WebCoreSupport/FrameLoaderClientGtk.h: Added m_hasRepresentation. 1333 13342011-02-02 Alejandro G. Castro <alex@igalia.com> 1335 1336 Reviewed by Martin Robinson. 1337 1338 Update the NEWS file in preparation for the 1.3.11 release. 1339 1340 * NEWS: Update the NEWS. 1341 13422011-02-02 Dan Winship <danw@gnome.org> 1343 1344 Reviewed by Martin Robinson. 1345 1346 [GTK] drop soup cache stuff, which has been moved to libsoup 1347 https://bugs.webkit.org/show_bug.cgi?id=50747 1348 1349 * GNUmakefile.am: Remove old cache files. 1350 13512011-02-02 David Hyatt <hyatt@apple.com> 1352 1353 Reviewed by Darin Adler. 1354 1355 Removal of right()/bottom(), converting to maxX()/maxY(). 1356 1357 * webkit/webkitwebview.cpp: 1358 (webkit_web_view_popup_menu_handler): 1359 13602011-02-01 Mario Sanchez Prada <msanchez@igalia.com> 1361 1362 Reviewed by Martin Robinson. 1363 1364 [Gtk] atk_text_set_caret_offset fails for list items 1365 https://bugs.webkit.org/show_bug.cgi?id=53388 1366 1367 Update unit test to check the fix for this bug. 1368 1369 * tests/testatk.c: 1370 (testWebkitAtkCaretOffsets): Ensure setting the caret in a list 1371 item through the AtkText interface is possible. 1372 13732011-02-01 Mario Sanchez Prada <msanchez@igalia.com> 1374 1375 Reviewed by Martin Robinson. 1376 1377 [GTK] character range extents is off when the end of a wrapped line is included 1378 https://bugs.webkit.org/show_bug.cgi?id=53323 1379 1380 Update unit test to check the fix for this bug. 1381 1382 * tests/testatk.c: 1383 (testWebkitAtkGetExtents): Check that the extent for a full line 1384 are the same height than for a partial section of the same line. 1385 13862011-02-01 Mario Sanchez Prada <msanchez@igalia.com> 1387 1388 Reviewed by Martin Robinson. 1389 1390 [GTK] Caret Offset is one off at the end of wrapped lines 1391 https://bugs.webkit.org/show_bug.cgi?id=53300 1392 1393 Update unit test to check the fix for this bug. 1394 1395 * tests/testatk.c: 1396 (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Set and get 1397 the caret offset at the edge of the line. 1398 13992011-01-31 Mario Sanchez Prada <msanchez@igalia.com> 1400 1401 Reviewed by Martin Robinson. 1402 1403 [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful 1404 https://bugs.webkit.org/show_bug.cgi?id=53389 1405 1406 New unit test to check the fix for this bug. 1407 1408 * tests/testatk.c: 1409 (testWebkitAtkCaretOffsets): New. 1410 (main): Add new test. 1411 14122011-01-29 Dan Winship <danw@gnome.org> 1413 1414 Reviewed by Xan Lopez. 1415 1416 [GTK] Remove HAVE_LIBSOUP_2_29_90 and HAVE_GSETTINGS conditionals; 1417 we depend on glib 2.27.4 and libsoup 2.33.1 now. 1418 https://bugs.webkit.org/show_bug.cgi?id=50675 1419 1420 * GNUmakefile.am: 1421 * WebCoreSupport/InspectorClientGtk.cpp: 1422 (WebKit::InspectorClient::storeSetting): 1423 * webkit/webkitprivate.cpp: 1424 (inspectorGSettings): 1425 * webkit/webkitprivate.h: 1426 14272011-01-28 Dan Bernstein <mitz@apple.com> 1428 1429 Reviewed by Sam Weinig. 1430 1431 <select> can't display right-to-left (rtl) languages 1432 https://bugs.webkit.org/show_bug.cgi?id=19785 1433 1434 * WebCoreSupport/ChromeClientGtk.cpp: 1435 (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. 1436 * WebCoreSupport/ChromeClientGtk.h: 1437 14382011-01-28 Alejandro G. Castro <alex@igalia.com> 1439 1440 Reviewed by Xan Lopez. 1441 1442 [GTK] Fix compilation warning 1443 https://bugs.webkit.org/show_bug.cgi?id=53292 1444 1445 * webkit/webkitwebframe.cpp: 1446 (draw_page_callback): Cast the pageCount from size_t to int, it 1447 should be safe considering page_nr is the number of pages, 1448 0-based. 1449 14502011-01-27 Nate Chapin <japhet@chromium.org> 1451 1452 Reviewed by Adam Barth. 1453 1454 Use Document::url() instead of FrameLoader::url(). 1455 https://bugs.webkit.org/show_bug.cgi?id=41165 1456 1457 * webkit/webkitwebview.cpp: 1458 (webkit_web_view_get_icon_uri): 1459 14602011-01-27 Mario Sanchez Prada <msanchez@igalia.com> 1461 1462 Reviewed by Martin Robinson. 1463 1464 [GTK] Space characters in source document interfere with reported caret offset 1465 https://bugs.webkit.org/show_bug.cgi?id=53033 1466 1467 New unit test to check the fix for this bug. 1468 1469 * tests/testatk.c: 1470 (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): New. 1471 (main): Add new unit test. 1472 14732011-01-26 Mario Sanchez Prada <msanchez@igalia.com> 1474 1475 Reviewed by Martin Robinson. 1476 1477 [GTK] Reliable crash with getTextAtOffset() 1478 https://bugs.webkit.org/show_bug.cgi?id=53131 1479 1480 New unit test to check the fix for this bug. 1481 1482 * tests/testatk.c: 1483 (testWebkitAtkGetTextAtOffsetWithSpecialCharacters): New. 1484 (main): Add new unit test. 1485 14862011-01-21 Carlos Garcia Campos <cgarcia@igalia.com> 1487 1488 Reviewed by Martin Robinson. 1489 1490 [GTK] Show caps lock indicator in password fields 1491 https://bugs.webkit.org/show_bug.cgi?id=52878 1492 1493 Test: manual-tests/password-caps-lock.html 1494 1495 * webkit/webkitwebview.cpp: 1496 (webkit_web_view_key_release_event): Call 1497 capsLockStateMayHaveChanged() when caps lock key is pressed. 1498 14992011-01-19 Joone Hur <joone.hur@collabora.co.uk> 1500 1501 Reviewed by Andreas Kling. 1502 1503 [GTK] No need to invalidate empty areas in ChromeClient::invalidateContentsAndWindow 1504 https://bugs.webkit.org/show_bug.cgi?id=52702 1505 1506 Don't call gdk_window_invalidate_rect if an updated rectangle is empty. 1507 1508 * WebCoreSupport/ChromeClientGtk.cpp: 1509 (WebKit::ChromeClient::invalidateContentsAndWindow): 1510 15112011-01-17 Philippe Normand <pnormand@igalia.com> 1512 1513 Unreviewed, build fix for 2 GTK tests html file paths. 1514 1515 * tests/testmimehandling.c: 1516 (main): 1517 * tests/testwebview.c: 1518 15192011-01-16 Adam Barth <abarth@webkit.org> 1520 1521 Rubber-stamped by Eric Seidel. 1522 1523 Move WebKit into Source 1524 https://bugs.webkit.org/show_bug.cgi?id=52530 1525 1526 * GNUmakefile.am: 1527 15282011-01-14 Yuzo Fujishima <yuzo@google.com> 1529 1530 Reviewed by Antti Koivisto. 1531 1532 Rename cache() to memoryCache() 1533 https://bugs.webkit.org/show_bug.cgi?id=52433 1534 1535 * webkit/webkitglobals.cpp: 1536 (webkit_set_cache_model): 1537 15382011-01-14 Pavel Feldman <pfeldman@chromium.org> 1539 1540 Not reviewed: gtk build fix (2). 1541 1542 * webkit/webkitwebview.cpp: 1543 15442011-01-14 Pavel Feldman <pfeldman@chromium.org> 1545 1546 Not reviewed: gtk build fix. 1547 1548 * webkit/webkitwebinspector.cpp: 1549 15502011-01-13 Alejandro G. Castro <alex@igalia.com> 1551 1552 Reviewed by Martin Robinson. 1553 1554 [gtk] Zero-sized font does not yet work 1555 https://bugs.webkit.org/show_bug.cgi?id=49793 1556 1557 Allow 0 as a minimum-font-size value for the settings. 1558 1559 * webkit/webkitwebsettings.cpp: 1560 (webkit_web_settings_class_init): 1561 15622011-01-12 Philippe Normand <pnormand@igalia.com> 1563 1564 Unreviewed build fix for 32-bits Release. Include GRefPtrGtk.h so 1565 the GdkCursor templates are found and used at runtime. 1566 1567 * WebCoreSupport/FullscreenVideoController.cpp: 1568 15692011-01-11 Carlos Garcia Campos <cgarcia@igalia.com> 1570 1571 Reviewed by Martin Robinson. 1572 1573 [GTK] GRefPtr should not be used with Gtk widgets 1574 https://bugs.webkit.org/show_bug.cgi?id=51241 1575 1576 GRefPtr breaks the widget life-cycle, the main problem is 1577 that GRefPtr calls g_object_unref() when it's destroyed, 1578 which is undesirable for widgets. In gtk+ widgets are created with 1579 a floating reference and when added to a container, the container 1580 takes the ownership of the widget consuming the floating 1581 reference. So you don't usually need to call g_object_ref/unref on 1582 widgets (only for some operations like reparent a widget) and 1583 toplevel widgets are destroyed with gtk_widget_destroy(). 1584 1585 * WebCoreSupport/DragClientGtk.cpp: 1586 (WebKit::DragClient::DragClient): 1587 (WebKit::DragClient::~DragClient): 1588 (WebKit::DragClient::startDrag): 1589 * WebCoreSupport/DragClientGtk.h: 1590 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1591 (WebKit::postCommitFrameViewSetup): 1592 * webkit/webkitwebview.cpp: 1593 (webkit_web_view_dispose): 1594 * webkit/webkitwebviewprivate.h: 1595 15962011-01-10 Martin Robinson <mrobinson@igalia.com> 1597 1598 Reviewed by Xan Lopez. 1599 1600 Update the NEWS file in preparation for the 1.3.10 release. 1601 1602 * NEWS: Update the NEWS. 1603 16042011-01-10 Martin Robinson <mrobinson@igalia.com> 1605 1606 Reviewed by Xan Lopez. 1607 1608 [GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release 1609 https://bugs.webkit.org/show_bug.cgi?id=52173 1610 1611 * WebCoreSupport/FullscreenVideoController.cpp: 1612 (FullscreenVideoController::enterFullscreen): Use a GRefPtr here to avoid having to 1613 call either g_object_unref or gdk_cursor_unref. 1614 * webkit/webkitwebview.cpp: Guard use of deprecated methods. 1615 (webkit_web_view_realize): Ditto. 1616 (webkit_web_view_drag_end): Ditto. 1617 16182011-01-10 Alejandro G. Castro <alex@igalia.com> 1619 1620 Reviewed by Xan Lopez. 1621 1622 [GTK] Fix gtk2 compilation for master 1623 https://bugs.webkit.org/show_bug.cgi?id=51885 1624 1625 * webkit/webkitsoupauthdialog.c: 1626 (show_auth_dialog): Removed the call to 1627 gtk_dialog_set_has_separator API to remove a warning. 1628 16292011-01-10 Xan Lopez <xlopez@igalia.com> 1630 1631 Reviewed by Martin Robinson. 1632 1633 [GTK] Create intermediate libWebCore library 1634 https://bugs.webkit.org/show_bug.cgi?id=52116 1635 1636 * GNUmakefile.am: add libWebCore.la to LIBADD and remove webcore 1637 sources from the libwebkit library SOURCES. 1638 16392011-01-09 Xianzhu Wang <phnixwxz@gmail.com> 1640 1641 Reviewed by Darin Fisher. 1642 1643 https://bugs.webkit.org/show_bug.cgi?id=41441 1644 createWindow method should only do window-creating without URL navigation 1645 1646 * WebCoreSupport/ChromeClientGtk.cpp: 1647 (WebKit::ChromeClient::createWindow): 1648 16492011-01-08 Martin Robinson <mrobinson@igalia.com> 1650 1651 GTK+ build fix. Adding missing headers to the source list, fixing make dist. 1652 1653 * GNUmakefile.am: Fix make dist. 1654 16552011-01-07 Adam Barth <abarth@webkit.org> 1656 1657 Rubber-stamped by Eric Seidel. 1658 1659 Move WebCore to Source 1660 https://bugs.webkit.org/show_bug.cgi?id=52050 1661 1662 * GNUmakefile.am: 1663 16642011-01-07 Mario Sanchez Prada <msanchez@igalia.com> 1665 1666 Reviewed by Chris Fleizach. 1667 1668 GTK: AX: atk tests need to be updated after recent changes 1669 https://bugs.webkit.org/show_bug.cgi?id=51932 1670 1671 Fix gtk_widget_get_accessible() in WebKitWebView to keep returning 1672 the AtkObject of role ATK_ROLE_DOCUMENT_FRAME. 1673 1674 With the change to support WK2 accessibility, the root object of 1675 the AX hierarchy is different from what GTK expects as the current 1676 hirarchy right now includes a new accessible object as the parent 1677 of the accessible web area (AXScrollView). 1678 1679 * webkit/webkitwebview.cpp: 1680 (webkit_web_view_get_accessible): Return the first child of the 1681 wrapper associated to the root accessible object in the document, 1682 to keep everything in the GTK port working as it used to be. 1683 1684 Re-enable skipped ATK unit tests now they are passing again. 1685 1686 * tests/testatk.c: 1687 (main): Re-enable skipped tests. 1688 * tests/testatkroles.c: 1689 (main): Ditto. 1690 16912011-01-06 Martin Robinson <mrobinson@igalia.com> 1692 1693 Reviewed by Xan Lopez. 1694 1695 GTK: AX: atk tests need to be updated after recent changes 1696 https://bugs.webkit.org/show_bug.cgi?id=51932 1697 1698 Skip ATK unit tests until we can look into what is causing these failures. 1699 1700 * tests/testatk.c: 1701 (main): Skip all tests. 1702 * tests/testatkroles.c: 1703 (main): Ditto. 1704 17052011-01-06 Martin Robinson <mrobinson@igalia.com> 1706 1707 Reviewed by Xan Lopez. 1708 1709 Include a new header in the static headers list. This is necessary 1710 so that "make install" installs the header. 1711 1712 * GNUmakefile.am: Include webkitglobals.h in the header list. 1713 17142011-01-05 Martin Robinson <mrobinson@igalia.com> 1715 1716 Reviewed by Gustavo Noronha. 1717 1718 Build fix for GTK+ 3.x. Remove the call to gtk_range_set_update_policy. 1719 GTK+ 3.x has removed this method and the default in GTK+ 2.x is continuous, 1720 so this call is unnecessary. 1721 1722 * WebCoreSupport/FullscreenVideoController.cpp: 1723 (FullscreenVideoController::createHud): Remove call to gtk_range_set_update_policy(). 1724 17252011-01-04 Chris Fleizach <cfleizach@apple.com> 1726 1727 Reviewed by Martin Robinson. 1728 1729 GTK: AX: DRT needs to use correct root object method. 1730 https://bugs.webkit.org/show_bug.cgi?id=51911 1731 1732 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 1733 (DumpRenderTreeSupportGtk::getRootAccessibleElement): 1734 (DumpRenderTreeSupportGtk::getFocusedAccessibleElement): 1735 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 1736 17372011-01-04 Chris Fleizach <cfleizach@apple.com> 1738 1739 Reviewed by Sam Weinig. 1740 1741 WK2: Support Accessibility 1742 https://bugs.webkit.org/show_bug.cgi?id=51859 1743 1744 Use rootObject() method to get top of ax tree. 1745 1746 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 1747 (DumpRenderTreeSupportGtk::getFocusedAccessibleElement): 1748 * webkit/webkitwebview.cpp: 1749 (webkit_web_view_get_accessible): 1750 17512011-01-03 Martin Robinson <mrobinson@igalia.com> 1752 1753 Reviewed by Darin Adler. 1754 1755 Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr 1756 https://bugs.webkit.org/show_bug.cgi?id=51846 1757 1758 Changed all references to PlatformRefPtr in GTK+ code to GRefPtr. 1759 17602011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 1761 1762 Reviewed by Martin Robinson. 1763 1764 [GTK] Split webkitprivate.{cpp,h} in more manageable chunks 1765 https://bugs.webkit.org/show_bug.cgi?id=50698 1766 1767 Final patch, removing webkitprivate.{cpp,h}, and adding a 1768 webkitglobals module to hold non-object-specific functions and 1769 definitions that do not make sense on their own. 1770 1771 * GNUmakefile.am: 1772 * WebCoreSupport/ChromeClientGtk.cpp: 1773 (WebKit::ChromeClient::createWindow): 1774 * WebCoreSupport/ContextMenuClientGtk.cpp: 1775 * WebCoreSupport/DocumentLoaderGtk.cpp: 1776 (WebKit::DocumentLoader::attachToFrame): 1777 * WebCoreSupport/DragClientGtk.cpp: 1778 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 1779 * WebCoreSupport/EditorClientGtk.cpp: 1780 (WebKit::EditorClient::ignoreWordInSpellDocument): 1781 (WebKit::EditorClient::learnWord): 1782 (WebKit::EditorClient::checkSpellingOfString): 1783 (WebKit::EditorClient::getGuessesForWord): 1784 * WebCoreSupport/FrameLoaderClientGtk.cpp: 1785 (WebKit::FrameLoaderClient::createDocumentLoader): 1786 * WebCoreSupport/InspectorClientGtk.cpp: 1787 * webkit/webkit.h: 1788 * webkit/webkitapplicationcache.cpp: 1789 (webkit_application_cache_set_maximum_size): 1790 * webkit/webkitdownload.cpp: 1791 (webkit_download_class_init): 1792 * webkit/webkitgeolocationpolicydecision.cpp: 1793 * webkit/webkitglobals.cpp: Added. 1794 (webkit_get_default_session): 1795 (webkit_set_cache_model): 1796 (webkit_get_cache_model): 1797 (webkit_get_web_plugin_database): 1798 (currentToplevelCallback): 1799 (closeIconDatabaseOnExit): 1800 (webkitInit): 1801 (WebKit::pasteboardHelperInstance): 1802 * webkit/webkitglobals.h: Added. 1803 * webkit/webkitglobalsprivate.h: Copied from WebKit/gtk/webkit/webkitwebsettingsprivate.h. 1804 * webkit/webkithittestresult.cpp: 1805 (webkit_hit_test_result_class_init): 1806 * webkit/webkitnetworkrequest.cpp: 1807 (webkit_network_request_class_init): 1808 * webkit/webkitnetworkresponse.cpp: 1809 (webkit_network_response_class_init): 1810 * webkit/webkitprivate.cpp: Removed. 1811 * webkit/webkitprivate.h: Removed. 1812 * webkit/webkitsecurityorigin.cpp: 1813 * webkit/webkitviewportattributes.cpp: 1814 * webkit/webkitwebbackforwardlist.cpp: 1815 (webkit_web_back_forward_list_class_init): 1816 * webkit/webkitwebdatabase.cpp: 1817 * webkit/webkitwebdatasource.cpp: 1818 (webkit_web_data_source_class_init): 1819 (webkit_web_data_source_new_with_request): 1820 (WebKit::kitNew): 1821 * webkit/webkitwebframe.cpp: 1822 (webkit_web_frame_class_init): 1823 * webkit/webkitwebframeprivate.h: 1824 * webkit/webkitwebhistoryitem.cpp: 1825 (webkit_web_history_item_class_init): 1826 * webkit/webkitwebinspector.cpp: 1827 * webkit/webkitwebnavigationaction.cpp: 1828 * webkit/webkitwebplugin.cpp: 1829 (webkit_web_plugin_class_init): 1830 * webkit/webkitwebplugindatabase.cpp: 1831 (webkit_web_plugin_database_class_init): 1832 * webkit/webkitwebpluginprivate.h: 1833 * webkit/webkitwebpolicydecision.cpp: 1834 * webkit/webkitwebresource.cpp: 1835 * webkit/webkitwebsettings.cpp: 1836 (webkit_web_settings_class_init): 1837 (webkitWebViewGetEnchantDicts): 1838 (WebKit::core): 1839 * webkit/webkitwebsettingsprivate.h: 1840 * webkit/webkitwebview.cpp: 1841 (webkit_web_view_class_init): 1842 (webkit_web_view_update_settings): 1843 (webkit_web_view_settings_notify): 1844 * webkit/webkitwebview.h: 1845 * webkit/webkitwebwindowfeatures.cpp: 1846 (webkit_web_window_features_class_init): 1847 (WebKit::kitNew): 1848 18492011-01-02 Xan Lopez <xlopez@igalia.com> 1850 1851 Fix GTK+ build. 1852 1853 * GNUmakefile.am: tests do actually include JSC. 1854 18552011-01-02 Xan Lopez <xlopez@igalia.com> 1856 1857 Fix GTK+ build. 1858 1859 * GNUmakefile.am: remove individual -I$(srcdir)/Source when we'll 1860 already get them from javascriptcore_cppflags, and add it for the 1861 introspection build (which is not tested in the bots). 1862 18632011-01-02 Adam Barth <abarth@webkit.org> 1864 1865 Speculative build fix for GTK. Add Source to the include paths. 1866 1867 * GNUmakefile.am: 1868 18692011-01-01 Adam Barth <abarth@webkit.org> 1870 1871 Reviewed by Eric Seidel. 1872 1873 Move JavaScriptCore to Source 1874 https://bugs.webkit.org/show_bug.cgi?id=51604 1875 1876 * GNUmakefile.am: 1877 * docs/GNUmakefile.am: 1878 - Point to JavaScriptCore in its new location. 1879 18802010-12-29 Martin Robinson <mrobinson@igalia.com> 1881 1882 Build fix for GTK+. 1883 1884 * webkit/webkitwebinspector.cpp: Add missing DumpRenderTreeSupportGtk include. 1885 18862010-12-29 Martin Robinson <mrobinson@igalia.com> 1887 1888 [GTK] GSettings warning is concealing real warnings on the build bots 1889 https://bugs.webkit.org/show_bug.cgi?id=51691 1890 1891 Reviewed by Xan Lopez. 1892 1893 Do not print the GSettings warning message when running in DumpRenderTree. 1894 1895 * webkit/webkitwebinspector.cpp: 1896 (inspectorGSettings): Do not print the GSettings warning if we are running 1897 in DumpRenderTree. This should clean up the test results page a great deal. 1898 18992010-12-28 Martin Robinson <mrobinson@igalia.com> 1900 1901 Reviewed by Xan Lopez. 1902 1903 [GTK] Closing a window during an onload event can trigger serious GLib warnings 1904 https://bugs.webkit.org/show_bug.cgi?id=51686 1905 1906 Don't emit the close-web-view signal immediately during execution of closeWindowSoon. 1907 The signal handler may choose to destroy the web view while handling that signal, 1908 which may remove the last reference to the web view. FrameLoaderClient depends on the 1909 view still existing though. Instead, let the caller finish executing and emit the signal 1910 after a 0 length timeout. This matches the behavior on the Windows and Mac ports. 1911 1912 * WebCoreSupport/ChromeClientGtk.cpp: 1913 (WebKit::ChromeClient::ChromeClient): Initialize the timer id. 1914 (WebKit::emitCloseWebViewSignalLater): Callback for the timer. 1915 (WebKit::ChromeClient::closeWindowSoon): Do the actual signal invocation after 1916 the caller finishes its tasks. 1917 * WebCoreSupport/ChromeClientGtk.h: Add a new member for the timer id. We 1918 can use this to prevent emitting the close-web-view signal twice. 1919 19202010-12-28 Martin Robinson <mrobinson@igalia.com> 1921 1922 Reviewed by Eric Seidel. 1923 1924 [GTK] Clean up usage of NULL in webkitwebframe.cpp 1925 https://bugs.webkit.org/show_bug.cgi?id=51685 1926 1927 Replace occurrences of NULL with 0, in webkitwebframe.cpp. Not all 1928 uses of NULL have been changed, as certain GLib functions require 1929 an explicit NULL as a sentinel. 1930 1931 * webkit/webkitwebframe.cpp: 1932 (webkit_web_frame_get_data_source_from_core_loader): 1933 (webkit_web_frame_class_init): 1934 (webkit_web_frame_new): 1935 (webkit_web_frame_get_title): 1936 (webkit_web_frame_get_uri): 1937 (webkit_web_frame_get_web_view): 1938 (webkit_web_frame_get_name): 1939 (webkit_web_frame_get_parent): 1940 (webkit_web_frame_load_string): 1941 (webkit_web_frame_load_alternate_string): 1942 (webkit_web_frame_find_frame): 1943 (webkit_web_frame_get_global_context): 1944 (webkit_web_frame_get_data_source): 1945 (webkit_web_frame_get_provisional_data_source): 1946 (webkit_web_frame_print_full): 1947 (webkit_web_frame_get_security_origin): 1948 (webkit_web_frame_get_network_response): 1949 19502010-12-27 Martin Robinson <mrobinson@igalia.com> 1951 1952 Reviewed by Ryosuke Niwa. 1953 1954 [GTK] EditorClient::generateEditorCommands queues up "null string" commands 1955 https://bugs.webkit.org/show_bug.cgi?id=51569 1956 1957 Prevent adding "null string" editor commands by first checking whether or not 1958 the command string is null in generateEditorCommands before appending it to the 1959 list of pending editor command strings. 1960 1961 * WebCoreSupport/EditorClientGtk.cpp: 1962 (WebKit::EditorClient::generateEditorCommands): Check for the null string (no 1963 command for this key combination) before appending a command string to the list of 1964 pending editor commands. 1965 (WebKit::EditorClient::executePendingEditorCommands): Add an ASSERT which detects 1966 null command strings. 1967 19682010-12-27 Xan Lopez <xlopez@igalia.com> 1969 1970 Reviewed by Martin Robinson. 1971 1972 Remove unneeded includes from our headers. 1973 1974 * WebCoreSupport/PasteboardHelperGtk.h: ditto. 1975 * webkit/webkitprivate.h: ditto. 1976 * webkit/webkitsoupauthdialog.h: ditto. 1977 19782010-12-21 Philippe Normand <pnormand@igalia.com> 1979 1980 Reviewed by Eric Seidel. 1981 1982 [GTK] minimal build with --database fails 1983 https://bugs.webkit.org/show_bug.cgi?id=51394 1984 1985 * webkit/webkitprivate.cpp: 1986 (webkit_init): Use cacheStorage() only if the 1987 OFFLINE_WEB_APPLICATIONS feature is enabled. 1988 19892010-12-22 Sam Weinig <sam@webkit.org> 1990 1991 Reviewed by Darin Adler. 1992 1993 WebKit2 needs to mirror the frame tree in the UIProcess 1994 https://bugs.webkit.org/show_bug.cgi?id=51546 1995 1996 - Add client functions to notify that a frame has been added or 1997 removed from the page cache. 1998 1999 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2000 (WebKit::FrameLoaderClient::didSaveToPageCache): 2001 (WebKit::FrameLoaderClient::didRestoreFromPageCache): 2002 * WebCoreSupport/FrameLoaderClientGtk.h: 2003 20042010-12-22 Xan Lopez <xlopez@igalia.com> 2005 2006 Reviewed by Gustavo Noronha. 2007 2008 * NEWS: update for 1.3.9 release. 2009 20102010-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2011 2012 Reviewed by Xan Lopez. 2013 2014 Add WebPlugin, WebPluginDatabase, and ViewportAttributes to the 2015 documentation control files, in preparation for 1.3.8. Also take 2016 the opportunity to add descriptions to WebPlugin and 2017 WebPluginDatabase. 2018 2019 * docs/GNUmakefile.am: 2020 * docs/webkitgtk-docs.sgml: 2021 * docs/webkitgtk-sections.txt: 2022 * webkit/webkitwebplugin.cpp: 2023 * webkit/webkitwebplugindatabase.cpp: 2024 20252010-12-20 Xan Lopez <xlopez@igalia.com> 2026 2027 Reviewed by Gustavo Noronha. 2028 2029 * GNUmakefile.am: add missing files. 2030 * NEWS: update for 1.3.8 release. 2031 20322010-12-18 Antonio Gomes <agomes@rim.com> 2033 2034 Reviewed by Xan Lopez. 2035 2036 [GTK+] Simplify spatial navigation handling in EditorClientGtk.cpp 2037 https://bugs.webkit.org/show_bug.cgi?id=51302 2038 2039 Patch changes: 2040 1) The editor command for LEFT arrow key press without modifier 2041 from MoveBackward to MoveLeft; 2042 2) And similarly changes the editor command for RIGHT arrow key 2043 press without modifier from MoveForward to MoveRight. 2044 2045 It has no implications since SelectionController::modifyMovingRight() 2046 handles "MoveRight" equaly to how SelectionController::modifyMovingForward() 2047 handles "MoveForward" when granularity is 'CharacterGranularity'. The former 2048 falls back to the later in the case of other editor commands. 2049 2050 Analogously, the same applies to how SelectionController::modifyMovingLeft() and 2051 SelectionController::modifyMovingForward() handle "MoveLeft" and "MoveBackward" 2052 editor commands, respectively. 2053 2054 With this change we can remove the spatial navigation hack from moveCursorCallback(), 2055 in EditorClientGtk.cpp. 2056 2057 * WebCoreSupport/EditorClientGtk.cpp: 2058 (WebKit::moveCursorCallback): 2059 20602010-12-16 Carlos Garcia Campos <cgarcia@igalia.com> 2061 2062 Reviewed by Martin Robinson. 2063 2064 [Gtk] scrolling artifacts 2065 https://bugs.webkit.org/show_bug.cgi?id=45029 2066 2067 Call gdk_window_process_updates() right after moving the window 2068 when scrolling. 2069 2070 * WebCoreSupport/ChromeClientGtk.cpp: 2071 (WebKit::ChromeClient::scroll): 2072 20732010-12-15 Sheriff Bot <webkit.review.bot@gmail.com> 2074 2075 Unreviewed, rolling out r74117. 2076 http://trac.webkit.org/changeset/74117 2077 https://bugs.webkit.org/show_bug.cgi?id=51113 2078 2079 This broke the GTK1 build. (Requested by mrobinson on 2080 #webkit). 2081 2082 * GNUmakefile.am: 2083 20842010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> 2085 2086 Reviewed by Martin Robinson. 2087 2088 Changes to enable building WebKit2 for Gtk port. 2089 (https://bugs.webkit.org/show_bug.cgi?id=37369) 2090 2091 * GNUmakefile.am: Added WebCore/bindings/gobject to webkitgtk_sources & webkitgtk_cppflags. 2092 They should get compiled only when WebKit/gtk/GNUmakefile.am is getting included but not 2093 with WebKit2/GNUmakefile.am inclusion. 2094 20952010-12-14 Carlos Garcia Campos <cgarcia@igalia.com> 2096 2097 Reviewed by Martin Robinson. 2098 2099 [GTK] Simplify context-menu handling code 2100 https://bugs.webkit.org/show_bug.cgi?id=49658 2101 2102 Use gtk_container_foreach() so that we only iterate the list of 2103 children once and we avoid creating/destroying the list. It also 2104 connects the activate signal for submenu items. 2105 2106 * webkit/webkitwebview.cpp: 2107 (contextMenuConnectActivate): 2108 (webkit_web_view_forward_context_menu_event): 2109 21102010-12-14 Carlos Garcia Campos <cgarcia@igalia.com> 2111 2112 Reviewed by Xan Lopez. 2113 2114 [GTK] Fix several issues in r73858 2115 https://bugs.webkit.org/show_bug.cgi?id=51032 2116 2117 - It uses both glib private data and it allocates its own private 2118 structure. 2119 - It calls parent's dispose method from finalize. 2120 - webkit_web_plugin_get_mimetypes() uses a wrong annotation for the 2121 returned value, it should be transfer none rather than transfer 2122 container. 2123 - Since the mime type list is internal and we return the list and not a 2124 copy, it should never be freed by the caller, so 2125 webkit_web_plugin_mime_type_list_free() should be removed from the 2126 public API. 2127 - Mime types list is used uninitialized. 2128 - Mention in the docs that list returned by 2129 webkit_web_plugin_database_get_plugins() must be freed with 2130 webkit_web_plugin_database_plugins_list_free(). 2131 2132 * webkit/webkitwebplugin.cpp: 2133 (webkit_web_plugin_finalize): 2134 (webkit_web_plugin_class_init): 2135 (webkit_web_plugin_init): 2136 * webkit/webkitwebplugin.h: 2137 * webkit/webkitwebplugindatabase.cpp: 2138 21392010-12-14 Diego Escalante Urrelo <descalante@igalia.com> 2140 2141 Reviewed by Xan Lopez. 2142 2143 [gtk] misnamed gtk-doc strings for webkit_web_view_can_{c|c|p}_clipboard 2144 https://bugs.webkit.org/show_bug.cgi?id=50571 2145 2146 * webkit/webkitwebview.cpp: 2147 21482010-12-13 Xan Lopez <xlopez@igalia.com> 2149 2150 Reviewed by Martin Robinson. 2151 2152 [GTK] Add API to enable/disable plugins at runtime 2153 https://bugs.webkit.org/show_bug.cgi?id=50891 2154 2155 * tests/testwebplugindatabase.c: 2156 (test_webkit_web_plugin_database_get_plugins): test that disabling 2157 a plugin works. 2158 * webkit/webkitwebplugin.cpp: 2159 (webkit_web_plugin_get_property): hook 'enabled' property. 2160 (webkit_web_plugin_set_property): ditto. 2161 (webkit_web_plugin_class_init): define 'enabled' property. 2162 (webkit_web_plugin_set_enabled): setter for the property. 2163 (webkit_web_plugin_get_enabled): getter for the property. 2164 * webkit/webkitwebplugin.h: add the APIs to the header. 2165 21662010-12-13 Carlos Garcia Campos <cgarcia@igalia.com> 2167 2168 Reviewed by Xan Lopez. 2169 2170 [GTK] Do not use GET_PRIVATE macros 2171 https://bugs.webkit.org/show_bug.cgi?id=50915 2172 2173 GET_PRIVATE macros are slow and should only be used in the object 2174 init() method. 2175 2176 * WebCoreSupport/ContextMenuClientGtk.cpp: 2177 (WebKit::inputMethodsMenuItem): 2178 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2179 (WebKit::FrameLoaderClient::postProgressFinishedNotification): 2180 (WebKit::FrameLoaderClient::setTitle): 2181 (WebKit::FrameLoaderClient::dispatchCreatePage): 2182 (WebKit::postCommitFrameViewSetup): 2183 * webkit/webkitdownload.cpp: 2184 (webkit_download_init): 2185 * webkit/webkitgeolocationpolicydecision.cpp: 2186 (webkit_geolocation_policy_decision_init): 2187 * webkit/webkithittestresult.cpp: 2188 (webkit_hit_test_result_init): 2189 * webkit/webkitnetworkrequest.cpp: 2190 (webkit_network_request_init): 2191 * webkit/webkitsecurityorigin.cpp: 2192 (webkit_security_origin_init): 2193 * webkit/webkitsecurityoriginprivate.h: 2194 * webkit/webkitviewportattributes.cpp: 2195 (webkit_viewport_attributes_init): 2196 * webkit/webkitwebbackforwardlist.cpp: 2197 (webkit_web_back_forward_list_init): 2198 * webkit/webkitwebdatabase.cpp: 2199 (webkit_web_database_init): 2200 * webkit/webkitwebdatasource.cpp: 2201 (webkit_web_data_source_init): 2202 * webkit/webkitwebframe.cpp: 2203 (webkit_web_frame_init): 2204 (webkit_web_frame_new): 2205 * webkit/webkitwebframeprivate.h: 2206 * webkit/webkitwebhistoryitem.cpp: 2207 (webkit_web_history_item_init): 2208 * webkit/webkitwebinspector.cpp: 2209 (webkit_web_inspector_init): 2210 * webkit/webkitwebnavigationaction.cpp: 2211 (webkit_web_navigation_action_init): 2212 * webkit/webkitwebplugin.cpp: 2213 (webkit_web_plugin_init): 2214 * webkit/webkitwebplugindatabase.cpp: 2215 (webkit_web_plugin_database_init): 2216 * webkit/webkitwebplugindatabaseprivate.h: 2217 * webkit/webkitwebpluginprivate.h: 2218 * webkit/webkitwebpolicydecision.cpp: 2219 (webkit_web_policy_decision_init): 2220 * webkit/webkitwebresource.cpp: 2221 (webkit_web_resource_init): 2222 * webkit/webkitwebresourceprivate.h: 2223 * webkit/webkitwebsettings.cpp: 2224 (webkit_web_settings_init): 2225 * webkit/webkitwebview.cpp: 2226 (PopupMenuPositionFunc): 2227 (webkit_web_view_forward_context_menu_event): 2228 (webkit_web_view_drag_end): 2229 (webkit_web_view_drag_data_get): 2230 (webkit_web_view_query_tooltip): 2231 (webkit_web_view_init): 2232 * webkit/webkitwebwindowfeatures.cpp: 2233 (webkit_web_window_features_init): 2234 22352010-10-28 MORITA Hajime <morrita@google.com> 2236 2237 Reviewed by Ojan Vafai. 2238 2239 spellcheck does not check pasted text 2240 https://bugs.webkit.org/show_bug.cgi?id=40092 2241 2242 Added a stub implememntation. 2243 2244 * WebCoreSupport/EditorClientGtk.h: 2245 (WebKit::EditorClient::requestCheckingOfString): 2246 22472010-12-12 Xan Lopez <xlopez@igalia.com> 2248 2249 Rubber-stamped by Martin Robinson. 2250 2251 * webkit/webkitwebplugin.h: add a note about the extension list 2252 being a NULL-terminated array. 2253 22542010-12-12 Xan Lopez <xlopez@igalia.com> 2255 2256 Rubber-stamped by Gustavo Noronha. 2257 2258 Stop checking for glib >= 2.16, we have dependend on a newer 2259 version for a long time now. 2260 2261 * tests/testatk.c: Stop checking for glib >= 2.16. 2262 * tests/testatkroles.c: ditto. 2263 * tests/testdomdocument.c: ditto. 2264 * tests/testdomdomwindow.c: ditto. 2265 * tests/testdomnode.c: ditto. 2266 * tests/testglobals.c: ditto. 2267 * tests/testhttpbackend.c: ditto. 2268 * tests/testloading.c: ditto. 2269 * tests/testmimehandling.c: ditto. 2270 * tests/testnetworkrequest.c: ditto. 2271 * tests/testnetworkresponse.c: ditto. 2272 * tests/testwebbackforwardlist.c: ditto. 2273 * tests/testwebdatasource.c: ditto. 2274 * tests/testwebframe.c: ditto. 2275 * tests/testwebhistoryitem.c: ditto. 2276 * tests/testwebresource.c: ditto. 2277 * tests/testwebsettings.c: ditto. 2278 * tests/testwebview.c: ditto. 2279 * tests/testwindow.c: ditto. 2280 22812010-12-11 Xan Lopez <xlopez@igalia.com> 2282 2283 Reviewed by Martin Robinson. 2284 2285 [GTK] Add APIs for plugin management 2286 https://bugs.webkit.org/show_bug.cgi?id=50827 2287 2288 Add WebKitWebPluginDatabase and WebKitWebPlugin classes for basic 2289 plugin management at the client level. For now they provide 2290 "read-only" access to the plugin list. 2291 2292 * GNUmakefile.am: add new files to the build. 2293 * tests/testwebplugindatabase.c: Test that the database contains 2294 the test plugin, which should always be loaded. 2295 * webkit/webkit.h: add new headers. 2296 * webkit/webkitdefines.h: add new defines. 2297 * webkit/webkitwebplugin.cpp: An new class representing a plugin object. 2298 * webkit/webkitwebplugin.h: ditto. 2299 * webkit/webkitwebplugindatabase.cpp: A new class that contains the list of active plugins. 2300 * webkit/webkitwebplugindatabase.h: ditto. 2301 * webkit/webkitwebplugindatabaseprivate.h: Private header. 2302 * webkit/webkitwebpluginprivate.h: Private header. 2303 * webkit/webkitwebview.cpp: 2304 (webkit_get_web_plugin_database): returns the WebKitWebPluginDatabase for this session. 2305 * webkit/webkitwebview.h: add method to header. 2306 23072010-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2308 2309 Reviewed by Martin Robinson. 2310 2311 [GTK] Split webkitprivate.{cpp,h} in more manageable chunks 2312 https://bugs.webkit.org/show_bug.cgi?id=50698 2313 2314 Split private bits of several objects to their own private 2315 headers, and to their implementation files. 2316 2317 * GNUmakefile.am: 2318 * WebCoreSupport/ChromeClientGtk.cpp: 2319 * WebCoreSupport/EditorClientGtk.cpp: 2320 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2321 (WebKit::FrameLoaderClient::dispatchWillSendRequest): 2322 * webkit/webkitdownload.cpp: 2323 (webkit_download_set_response): 2324 * webkit/webkitdownloadprivate.h: Added. 2325 * webkit/webkithittestresult.cpp: 2326 (WebKit::kit): 2327 * webkit/webkithittestresultprivate.h: Added. 2328 * webkit/webkitnetworkresponse.cpp: 2329 (WebKit::core): 2330 (WebKit::kitNew): 2331 * webkit/webkitnetworkresponseprivate.h: Added. 2332 * webkit/webkitprivate.cpp: 2333 * webkit/webkitprivate.h: 2334 * webkit/webkitsecurityorigin.cpp: 2335 (webkit_security_origin_get_web_database): 2336 (WebKit::core): 2337 (WebKit::kit): 2338 * webkit/webkitsecurityoriginprivate.h: Added. 2339 * webkit/webkitviewportattributes.cpp: 2340 * webkit/webkitviewportattributesprivate.h: Added. 2341 * webkit/webkitwebbackforwardlist.cpp: 2342 * webkit/webkitwebbackforwardlistprivate.h: Added. 2343 * webkit/webkitwebdatabase.cpp: 2344 * webkit/webkitwebframe.cpp: 2345 (webkit_web_frame_get_network_response): 2346 * webkit/webkitwebhistoryitem.cpp: 2347 * webkit/webkitwebhistoryitemprivate.h: Added. 2348 * webkit/webkitwebnavigationaction.cpp: 2349 (WebKit::kit): 2350 (WebKit::core): 2351 * webkit/webkitwebnavigationactionprivate.h: Added. 2352 * webkit/webkitwebpolicydecision.cpp: 2353 * webkit/webkitwebpolicydecisionprivate.h: Added. 2354 * webkit/webkitwebresource.cpp: 2355 * webkit/webkitwebresourceprivate.h: Added. 2356 * webkit/webkitwebsettings.cpp: 2357 * webkit/webkitwebsettingsprivate.h: Added. 2358 * webkit/webkitwebview.cpp: 2359 23602010-12-10 Alejandro G. Castro <alex@igalia.com> 2361 2362 Unreviewed, fixed small typo in the name of a function. 2363 2364 * webkit/webkitwebsettings.cpp: 2365 (getAvailableDictionariesCallback): 2366 (webkit_web_settings_set_property): 2367 23682010-12-09 Alejandro G. Castro <alex@igalia.com> 2369 2370 Reviewed by Martin Robinson. 2371 2372 [GTK] Add hasSpellingMarker support to the DRT 2373 https://bugs.webkit.org/show_bug.cgi?id=50739 2374 2375 Added a new private API function to support the spelling marker 2376 tests in the DRT. 2377 2378 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2379 (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker): 2380 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2381 23822010-12-10 Alejandro G. Castro <alex@igalia.com> 2383 2384 Reviewed by Martin Robinson. 2385 2386 [GTK] Choose a dictionary in case there is no one defined or the 2387 env LANG does not propose one 2388 https://bugs.webkit.org/show_bug.cgi?id=50738 2389 2390 In case no dict is set and we can not find one using the 2391 environment just get the first dictionary installed in the list. 2392 2393 * webkit/webkitwebsettings.cpp: 2394 (getAvilableDictionariesCallback): 2395 (webkit_web_settings_set_property): 2396 23972010-12-10 Martin Robinson <mrobinson@igalia.com> 2398 2399 Reviewed by Gustavo Noronha Silva. 2400 2401 Remove unnecessary variable names from DumpRenderTreeSupportGtk 2402 https://bugs.webkit.org/show_bug.cgi?id=50815 2403 2404 There were some unnecessary variable names in DumpRenderTreeSupportGtk, 2405 so remove them. 2406 2407 * WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it. 2408 24092010-12-10 Joone Hur <joone@kldp.org> 2410 2411 Reviewed by Xan Lopez. 2412 2413 [GTK] Unskipping some test cases in /userscripts dependent on addUserStyleSheet 2414 https://bugs.webkit.org/show_bug.cgi?id=50808 2415 2416 Unskipping the following test cases: 2417 userscripts/mixed-case-stylesheet.html 2418 userscripts/simple-stylesheet.html 2419 userscripts/user-style-all-frames.html 2420 2421 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2422 (DumpRenderTreeSupportGtk::addUserStyleSheet): Added "bool allFrames" parameter. 2423 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2424 24252010-12-10 Joone Hur <joone@kldp.org> 2426 2427 Reviewed by Eric Seidel. 2428 2429 [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet 2430 https://bugs.webkit.org/show_bug.cgi?id=50783 2431 2432 This patch allows to unskip the following test cases: 2433 printing/page-rule-selection.html 2434 printing/page-format-data.html 2435 2436 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2437 (DumpRenderTreeSupportGtk::pageProperty): Added. 2438 (DumpRenderTreeSupportGtk::isPageBoxVisible): Ditto. 2439 (DumpRenderTreeSupportGtk::pageSizeAndMarginsInPixels): Ditto. 2440 (DumpRenderTreeSupportGtk::addUserStyleSheet): Ditto. 2441 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2442 24432010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2444 2445 Reviewed by Martin Robinson. 2446 2447 [GTK] Split webkitprivate.{cpp,h} in more manageable chunks 2448 https://bugs.webkit.org/show_bug.cgi?id=50698 2449 2450 Split private bits of WebKitWebInspector to its own private 2451 header, and to its implementation file. 2452 2453 * WebCoreSupport/InspectorClientGtk.cpp: 2454 * webkit/webkitprivate.cpp: 2455 * webkit/webkitprivate.h: 2456 * webkit/webkitwebinspector.cpp: 2457 (isSchemaAvailable): 2458 (inspectorGSettings): 2459 * webkit/webkitwebinspectorprivate.h: Added. 2460 * webkit/webkitwebview.cpp: 2461 24622010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2463 2464 Reviewed by Martin Robinson. 2465 2466 [GTK] Split webkitprivate.{cpp,h} in more manageable chunks 2467 https://bugs.webkit.org/show_bug.cgi?id=50698 2468 2469 Split private bits of WebKitNetworkRequest to its own private 2470 header, and to its implementation file. Also take the opportunity 2471 to use PlatformRefPtr for NetworkRequest where it makes sense, and 2472 make the creation less verbose by adding kitNew. 2473 2474 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2475 (WebKit::FrameLoaderClient::dispatchWillSendRequest): 2476 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): 2477 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): 2478 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 2479 (WebKit::FrameLoaderClient::download): 2480 (WebKit::FrameLoaderClient::startDownload): 2481 * webkit/webkitdownload.cpp: 2482 * webkit/webkitnetworkrequest.cpp: 2483 (WebKit::kitNew): 2484 (WebKit::core): 2485 * webkit/webkitnetworkrequestprivate.h: Added. 2486 * webkit/webkitprivate.cpp: 2487 * webkit/webkitprivate.h: 2488 * webkit/webkitwebdatasource.cpp: 2489 (webkit_web_data_source_get_initial_request): 2490 (webkit_web_data_source_get_request): 2491 * webkit/webkitwebframe.cpp: 2492 24932010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2494 2495 Reviewed by Martin Robinson. 2496 2497 [GTK] Split webkitprivate.{cpp,h} in more manageable chunks 2498 https://bugs.webkit.org/show_bug.cgi?id=50698 2499 2500 Split private bits of WebKitWebFrame to its own private header, and 2501 to its implementation file. 2502 2503 * GNUmakefile.am: 2504 * WebCoreSupport/ChromeClientGtk.cpp: 2505 * WebCoreSupport/DragClientGtk.cpp: 2506 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2507 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2508 * webkit/webkitprivate.cpp: 2509 * webkit/webkitprivate.h: 2510 * webkit/webkitwebdatasource.cpp: 2511 * webkit/webkitwebframe.cpp: 2512 (WebKit::getViewFromFrame): 2513 (WebKit::core): 2514 (WebKit::kit): 2515 * webkit/webkitwebframeprivate.h: Added. 2516 * webkit/webkitwebpolicydecision.cpp: 2517 * webkit/webkitwebview.cpp: 2518 25192010-12-09 Antonio Gomes <agomes@rim.com> 2520 2521 Reviewed by Martin Robinson. 2522 2523 [Gtk] Populate DumpRenderTreeSupportGtk (part IV) 2524 https://bugs.webkit.org/show_bug.cgi?id=48429 2525 2526 Moved also webkit_worker_thread_count() to DumpRenderTreeSupportGtk, 2527 since it was only used by DRT for now. 2528 2529 Since this method was the only one in webkitworker.cpp, the file was 2530 also removed. 2531 2532 * GNUmakefile.am: 2533 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2534 (DumpRenderTreeSupportGtk::workerThreadCount): 2535 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2536 * webkit/webkitprivate.h: 2537 * webkit/webkitworkers.cpp: Removed. 2538 25392010-12-06 Philippe Normand <pnormand@igalia.com> 2540 2541 Reviewed by Martin Robinson. 2542 2543 [GTK] Support the Mozilla-style Fullscreen Javascript API 2544 https://bugs.webkit.org/show_bug.cgi?id=50572 2545 2546 Fullscreen API support. It is controlled at runtime using a new 2547 setting called enable-fullscreen, set to FALSE by default. 2548 2549 * WebCoreSupport/ChromeClientGtk.cpp: 2550 (WebKit::ChromeClient::supportsFullScreenForElement): 2551 (WebKit::ChromeClient::enterFullScreenForElement): 2552 (WebKit::ChromeClient::exitFullScreenForElement): 2553 * WebCoreSupport/ChromeClientGtk.h: 2554 * webkit/webkitwebsettings.cpp: 2555 (webkit_web_settings_class_init): 2556 (webkit_web_settings_set_property): 2557 (webkit_web_settings_get_property): 2558 (webkit_web_settings_copy): 2559 * webkit/webkitwebview.cpp: 2560 (webkit_web_view_update_settings): 2561 25622010-12-09 Joone Hur <joone@kldp.org> 2563 2564 Reviewed by Martin Robinson. 2565 2566 [GTK] Support for viewport meta tag 2567 https://bugs.webkit.org/show_bug.cgi?id=45443 2568 2569 This patch adds a new gobject to offer the viewport properties to user agents. 2570 It is WebKitViewportAttributes that contains the viewport size, initial scale with limits, 2571 and information about whether a user is able to scale the contents in the viewport. 2572 2573 This feature was introduced by Safari on the iPhone. For more information on 2574 the viewport properties, refer to the Safari reference library at 2575 http://developer.apple.com/safari/library/documentation/appleapplications/reference/safarihtmlref/articles/metatags.html 2576 2577 * GNUmakefile.am: Added webkitviewportattributes.h webkitviewportattributes.cpp. 2578 * WebCoreSupport/ChromeClientGtk.cpp: 2579 (WebKit::ChromeClient::dispatchViewportDataDidChange): Added this callback to know whether the viewport arguments is available. 2580 * WebCoreSupport/ChromeClientGtk.h: 2581 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2582 (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): Added this function to compute the viewport attributes with the given availableWidth and availableHeight. 2583 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2584 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2585 (WebKit::postCommitFrameViewSetup): Invalidate the viewport attributes. 2586 * webkit/webkit.h: 2587 * webkit/webkitdefines.h: 2588 * webkit/webkitprivate.h: Added webkitViewportAttributesRecompute as a private function. 2589 * webkit/webkitviewportattributes.cpp: Added. 2590 (webkit_viewport_attributes_class_init): 2591 (webkit_viewport_attributes_init): 2592 (webkit_viewport_attributes_get_property): 2593 (webkit_viewport_attributes_set_property): 2594 (webkitViewportAttributesRecompute): Recompute the optimal viewport attributes and emit the viewport-attributes-changed signal. 2595 (webkit_viewport_attributes_recompute): a public API for calling webkitViewportAttributesRecompute. 2596 * webkit/webkitviewportattributes.h: Added. 2597 * webkit/webkitwebview.cpp: 2598 (webkit_web_view_get_property): Added PROP_VIEWPORT_ATTRIBUTES. 2599 (webkit_web_view_dispose): Deallocate the WebKitViewportAttributes instance. 2600 (webkit_web_view_class_init): Added the viewport-attributes-recompute-requested and viewport-attributes-changed signals. 2601 (webkit_web_view_init): Set the WebKitViewportAttributes instance. 2602 (webkit_web_view_get_viewport_attributes): Added a getter to obtain the WebKitViewportAttributes instance held by the given WebKitWebView. 2603 * webkit/webkitwebview.h: 2604 * webkit/webkitwebviewprivate.h: Added WebKitViewportAttributes as a private variable. 2605 26062010-12-09 Xan Lopez <xlopez@igalia.com> 2607 2608 Reviewed by Martin Robinson. 2609 2610 Fix 'make install' woes with some versions of automake. 2611 2612 * GNUmakefile.am: use $(top_builddir) instead of $(builddir), 2613 since we actually want a valid path for the file regardless of the 2614 place from where the script is called. 2615 26162010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2617 2618 Build fix. Take webView{Enter,Exit}Fullscreen back out of the 2619 WebKit namespace, and remove a function signature that got in by 2620 mistake because of a bad merge. 2621 2622 * webkit/webkitprivate.h: 2623 * webkit/webkitwebview.cpp: 2624 (WebKit::core): 2625 (WebKit::kit): 2626 26272010-12-08 Brian Weinstein <bweinstein@apple.com> 2628 2629 Reviewed by John Sullivan. 2630 2631 Layering Violation in ContextMenu - member variable of type HitTestResult 2632 https://bugs.webkit.org/show_bug.cgi?id=50586 2633 2634 Update users of ContextMenu and ContextMenuController to match where the new functions 2635 are located. 2636 2637 * WebCoreSupport/ContextMenuClientGtk.cpp: 2638 (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): 2639 26402010-12-08 Martin Robinson <mrobinson@igalia.com> 2641 2642 Reviewed by John Sullivan. 2643 2644 [GTK] Layering violation in ContextMenuGtk.cpp 2645 https://bugs.webkit.org/show_bug.cgi?id=50676 2646 2647 ContextMenuGtk accesses the page's ContextMenuController, which is a layering 2648 violation. This was fixed for Mac with change r73469. We make a similar fix here 2649 by moving the "activated" signal connection to the WebKit layer. 2650 2651 * webkit/webkitwebview.cpp: 2652 (popupMenuItemActivated): Have ContextMenuController handle this signal. 2653 (webkit_web_view_forward_context_menu_event): For all items in the untouched 2654 context menu, connect their "activated" signal to the new popupMenuItemActivated 2655 handler. 2656 26572010-12-08 Antonio Gomes <agomes@rim.com> 2658 2659 Reviewed by Martin Robinson. 2660 2661 [Gtk] Populate DumpRenderTreeSupportGtk (part III) 2662 https://bugs.webkit.org/show_bug.cgi?id=48429 2663 2664 Adjusted some call sites of previously internal API declared 2665 webkitprivate.h that have moved to DumpRenderTreeSupportGtk. 2666 2667 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2668 (DumpRenderTreeSupportGtk::gcCollectJavascriptObjects): 2669 (DumpRenderTreeSupportGtk::gcCollectJavascriptObjectsOnAlternateThread): 2670 (DumpRenderTreeSupportGtk::gcCountJavascriptObjects): 2671 (DumpRenderTreeSupportGtk::layoutFrame): 2672 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2673 * webkit/webkitprivate.h: 2674 * webkit/webkitwebframe.cpp: 2675 26762010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2677 2678 Reviewed by Martin Robinson. 2679 2680 [GTK] Split webkitprivate.{cpp,h} in more manageable chunks 2681 https://bugs.webkit.org/show_bug.cgi?id=50698 2682 2683 Split private bits of WebKitWebView to its own private header, and 2684 to its implementation file. Take the opportunity to fix includes 2685 sorting to comply with the style guide. 2686 2687 * WebCoreSupport/ChromeClientGtk.cpp: 2688 (WebKit::ChromeClient::enterFullscreenForNode): 2689 (WebKit::ChromeClient::exitFullscreenForNode): 2690 * WebCoreSupport/ContextMenuClientGtk.cpp: 2691 * WebCoreSupport/DragClientGtk.cpp: 2692 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2693 * WebCoreSupport/EditorClientGtk.cpp: 2694 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2695 * WebCoreSupport/InspectorClientGtk.cpp: 2696 * WebCoreSupport/PasteboardHelperGtk.cpp: 2697 * webkit/webkitprivate.cpp: 2698 (webkit_init): 2699 * webkit/webkitprivate.h: 2700 * webkit/webkitwebbackforwardlist.cpp: 2701 * webkit/webkitwebdatasource.cpp: 2702 * webkit/webkitwebframe.cpp: 2703 * webkit/webkitwebview.cpp: 2704 (WebKit::core): 2705 (WebKit::kit): 2706 (WebKit::webViewEnterFullscreen): 2707 (WebKit::webViewExitFullscreen): 2708 * webkit/webkitwebviewprivate.h: Added. 2709 27102010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2711 2712 Reviewed by Xan Lopez. 2713 2714 The storage for the subresources is a GHashTable which does not 2715 guarantee order, so we need to make our checking more resilient. 2716 2717 * tests/testwebresource.c: 2718 (test_web_resource_sub_resource_loading): 2719 27202010-12-08 Alejandro G. Castro <alex@igalia.com> 2721 2722 Reviewed by Gustavo Noronha Silva. 2723 2724 Fix assertion in the API test, we are requesting the favicon and 2725 the subresource so we have to make sure we are assigning just the 2726 first subresource. 2727 2728 * tests/testwebresource.c: 2729 (resource_request_starting_sub_cb): 2730 27312010-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2732 2733 Reviewed by Martin Robinson. 2734 2735 [GTK] clears the subresources prematurely 2736 https://bugs.webkit.org/show_bug.cgi?id=50634 2737 2738 Make adding the main resource explicit, and only clear 2739 subresources when the new load is committed, avoid clearing them 2740 prematurely. 2741 2742 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2743 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): 2744 (WebKit::FrameLoaderClient::provisionalLoadStarted): 2745 (WebKit::FrameLoaderClient::prepareForDataSourceReplacement): 2746 (WebKit::postCommitFrameViewSetup): 2747 * tests/testwebdatasource.c: 2748 (notify_load_status_lifetime_cb): 2749 (test_webkit_web_data_source_lifetime): 2750 (main): 2751 * webkit/webkitprivate.h: 2752 * webkit/webkitwebview.cpp: 2753 (webkit_web_view_add_main_resource): 2754 (webkit_web_view_add_resource): 2755 (webkit_web_view_clear_resources): 2756 27572010-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 2758 2759 Reviewed by Xan Lopez. 2760 2761 [GTK] testwebdatasource - unreachable test is broken 2762 https://bugs.webkit.org/show_bug.cgi?id=50629 2763 2764 Fix, and disable testwebdatasource's unreachable test (it is not 2765 passing now that it actually tests what it should). This also 2766 fixes the wait timer to actually work as expected. 2767 2768 * tests/testwebdatasource.c: 2769 (notify_load_status_unreachable_cb): 2770 (notify_load_status_cb): 2771 (test_webkit_web_data_source): 2772 27732010-12-07 Martin Robinson <mrobinson@igalia.com> 2774 2775 Unreviewed, rolling out r73392. 2776 http://trac.webkit.org/changeset/73392 2777 https://bugs.webkit.org/show_bug.cgi?id=50489 2778 2779 This commit caused crashes on the GTK+ bots 2780 2781 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2782 (WebKit::FrameLoaderClient::finishedLoading): 2783 * webkit/webkitwebview.cpp: 2784 (webkit_web_view_get_encoding): 2785 27862010-12-06 Nate Chapin <japhet@chromium.org> 2787 2788 Reviewed by Adam Barth. 2789 2790 Update calls to DocumentWriter. 2791 https://bugs.webkit.org/show_bug.cgi?id=50489 2792 2793 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2794 (WebKit::FrameLoaderClient::finishedLoading): 2795 * webkit/webkitwebview.cpp: 2796 (webkit_web_view_get_encoding): 2797 27982010-12-06 Martin Robinson <mrobinson@igalia.com> 2799 2800 Reviewed by Xan Lopez. 2801 2802 [GTK] Build is broken after r73353 2803 https://bugs.webkit.org/show_bug.cgi?id=50568 2804 2805 Fix the gtk-doc build by making all members of the cache model 2806 enum public. gtk-doc does not support making only some enum 2807 members private. We should also expose it so that users querying 2808 the cache model do not get mysterious, undocumented results. 2809 2810 * webkit/webkitwebview.h: Fix gtk-doc for the cache model enum. 2811 28122010-12-06 Derek Weitzel <djw8605@gmail.com> 2813 2814 Reviewed by Martin Robinson. 2815 2816 [GTK] API Documentation referencing depreciated GTK_WIDGET_TOPLEVEL 2817 https://bugs.webkit.org/show_bug.cgi?id=50512 2818 2819 Fixed reference to depreciated GTK_WIDGET_TOPLEVEL. 2820 2821 * webkit/webkitwebview.cpp: 2822 28232010-12-06 Joone Hur <joone@kldp.org> 2824 2825 Reviewed by Xan Lopez. 2826 2827 [GTK] The webkit cache model needs to be set when WebFrameLoaderClient::didPerformFirstNavigation() is called 2828 https://bugs.webkit.org/show_bug.cgi?id=50430 2829 2830 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2831 (WebKit::FrameLoaderClient::didPerformFirstNavigation): Set the webview cache model. 2832 * webkit/webkitprivate.cpp: 2833 (webkit_init): Removed the code of setting the webview cache model. 2834 28352010-12-04 Antonio Gomes <agomes@rim.com> 2836 2837 Reviewed by Martin Robinson. 2838 2839 [Gtk] Populate DumpRenderTreeSupportGtk (Part II) 2840 https://bugs.webkit.org/show_bug.cgi?id=48429 2841 2842 Moved more private method declared with WEBKIT_API to 2843 DumpRenderTreeSupportGtk, since they were only being used by DRT. 2844 2845 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2846 (DumpRenderTreeSupportGtk::executeCoreCommandByName): 2847 (DumpRenderTreeSupportGtk::isCommandEnabled): 2848 (DumpRenderTreeSupportGtk::whiteListAccessFromOrigin): 2849 (DumpRenderTreeSupportGtk::resetOriginAccessWhiteLists): 2850 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2851 * webkit/webkitprivate.cpp: 2852 * webkit/webkitprivate.h: 2853 * webkit/webkitwebview.cpp: 2854 28552010-11-08 Antonio Gomes <agomes@rim.com> 2856 2857 Reviewed by Martin Robinson. 2858 2859 [Gtk] Populate DumpRenderTreeSupportGtk 2860 https://bugs.webkit.org/show_bug.cgi?id=48429 2861 2862 Moved most of the webkit_web_frame* methods defined as private APIs in webkitprivate.h 2863 to DumpRenderTreeSupportGtk, as static class methods. These methods had 2864 not gone throught the formal API review process and were only being used by DRT for now. 2865 2866 The essence of each original method name were kept. For example 2867 webkit_web_frame_get_children(...) was renamed to DumpRenderTreeSupportGtk::getFrameChildren(...), 2868 and so on. 2869 2870 Also some of the method bodies were changed to return non-glib types (gchar* -> CString). 2871 2872 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 2873 (DumpRenderTreeSupportGtk::getFrameChildren): 2874 (DumpRenderTreeSupportGtk::getInnerText): 2875 (DumpRenderTreeSupportGtk::dumpRenderTree): 2876 (DumpRenderTreeSupportGtk::counterValueForElementById): 2877 (DumpRenderTreeSupportGtk::pageNumberForElementById): 2878 (DumpRenderTreeSupportGtk::numberOfPagesForFrame): 2879 (DumpRenderTreeSupportGtk::getPendingUnloadEventCount): 2880 (DumpRenderTreeSupportGtk::pauseAnimation): 2881 (DumpRenderTreeSupportGtk::pauseTransition): 2882 (DumpRenderTreeSupportGtk::pauseSvgAnimation): 2883 (DumpRenderTreeSupportGtk::markerTextForListItem): 2884 (DumpRenderTreeSupportGtk::numberOfActiveAnimations): 2885 (DumpRenderTreeSupportGtk::suspendAnimations): 2886 (DumpRenderTreeSupportGtk::resumeAnimations): 2887 (DumpRenderTreeSupportGtk::clearMainFrameName): 2888 (DumpRenderTreeSupportGtk::getFocusedAccessibleElement): 2889 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2890 * webkit/webkitprivate.h: 2891 * webkit/webkitwebframe.cpp: 2892 28932010-12-02 Martin Robinson <mrobinson@igalia.com> 2894 2895 Reviewed by Xan Lopez. 2896 2897 [GTK] DumpRenderTree has two copies of JavaScriptCore 2898 https://bugs.webkit.org/show_bug.cgi?id=49877 2899 2900 Keep WebKit/WebCore symbols hidden. 2901 2902 * GNUmakefile.am: Move the symbol visibility rules here, because 2903 now JSC symbols are visible, but WebCore/WebKit symbols are hidden. 2904 29052010-12-02 Daniel Bates <dbates@rim.com> 2906 2907 Ignore WebKit/gtk/docs/GNUmakefile.in and WebKit/gtk/po/*.pot so that 2908 these files do not appear in an svn stat. This change makes SVN 2909 consistent with the current Git ignore behavior for these files. 2910 2911 * docs: Added property svn:ignore. 2912 * po: Added property svn:ignore. 2913 29142010-12-01 Jia Pu <jpu@apple.com> 2915 2916 Reviewed by Darin Adler. 2917 2918 Support multiple correction candidates panel for misspelled word on Mac OS X. 2919 https://bugs.webkit.org/show_bug.cgi?id=50137 2920 <rdar://problem/8568059> 2921 2922 Adopted new function signature defined in base class. 2923 2924 * WebCoreSupport/EditorClientGtk.cpp: 2925 (WebKit::EditorClient::getGuessesForWord): 2926 * WebCoreSupport/EditorClientGtk.h: 2927 29282010-11-30 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk> 2929 2930 Reviewed by Martin Robinson. 2931 2932 [GTK] Fix wrong type in assert return value 2933 https://bugs.webkit.org/show_bug.cgi?id=50208 2934 2935 Use appropriate return type in different g_return_val_if_fail(). This 2936 removes some compiler warning. 2937 2938 * webkit/webkitwebdatasource.cpp: 2939 (webkit_web_data_source_is_loading): 2940 * webkit/webkitwebframe.cpp: 2941 (webkit_web_frame_page_number_for_element_by_id): 2942 (webkit_web_frame_number_of_pages): 2943 29442010-11-30 Mario Sanchez Prada <msanchez@igalia.com> 2945 2946 Reviewed by Chris Fleizach. 2947 2948 [GTK] Implement ROLE_COMBO_BOX 2949 https://bugs.webkit.org/show_bug.cgi?id=25678 2950 2951 New test to check the implementation of the combo boxes. 2952 2953 * tests/testatk.c: 2954 (testWebkitAtkComboBox): New test, checking that the roles and the 2955 implemented interfaces for a combo box and its descendants work. 2956 (main): Added the new unit test. 2957 29582010-11-30 Carlos Garcia Campos <cgarcia@igalia.com> 2959 2960 Reviewed by Martin Robinson. 2961 2962 [GTK] Test fast/events/mouseover-mouseout2.html crashes 2963 https://bugs.webkit.org/show_bug.cgi?id=50214 2964 2965 * WebCoreSupport/ChromeClientGtk.cpp: 2966 (WebKit::ChromeClient::mouseDidMoveOverElement): 2967 * webkit/webkitwebview.cpp: 2968 (webkit_web_view_query_tooltip): 2969 29702010-11-30 Sheriff Bot <webkit.review.bot@gmail.com> 2971 2972 Unreviewed, rolling out r72764. 2973 http://trac.webkit.org/changeset/72764 2974 https://bugs.webkit.org/show_bug.cgi?id=50215 2975 2976 This change is causing assertion failures on the debug bots. 2977 (Requested by mrobinson on #webkit). 2978 2979 * WebCoreSupport/FrameLoaderClientGtk.cpp: 2980 (WebKit::notifyStatus): 2981 * tests/testatk.c: 2982 (main): 2983 29842010-11-29 Xan Lopez <xlopez@igalia.com> 2985 2986 Reviewed by Martin Robinson. 2987 2988 * NEWS: update for 1.3.7 release. 2989 29902010-11-29 Carlos Garcia Campos <cgarcia@igalia.com> 2991 2992 Reviewed by Xan Lopez. 2993 2994 [Gtk] Tooltips should be fully keyboard accessible 2995 https://bugs.webkit.org/show_bug.cgi?id=25525 2996 2997 Position the tooltip under the current focused element when the 2998 tooltip has been triggered using the keyboard. 2999 3000 * webkit/webkitwebview.cpp: 3001 (webkit_web_view_query_tooltip): 3002 (webkit_web_view_show_help): 3003 (webkit_web_view_class_init): 3004 30052010-11-29 Carlos Garcia Campos <cgarcia@igalia.com> 3006 3007 Reviewed by Xan Lopez. 3008 3009 [GTK] Tooltips not shown when scrolling 3010 https://bugs.webkit.org/show_bug.cgi?id=50143 3011 3012 Convert tooltip area to window coordinates so that tooltips are 3013 shown even after scrolling. 3014 3015 * WebCoreSupport/ChromeClientGtk.cpp: 3016 (WebKit::ChromeClient::mouseDidMoveOverElement): 3017 30182010-11-26 Carlos Garcia Campos <cgarcia@igalia.com> 3019 3020 Reviewed by Xan Lopez. 3021 3022 [GTK] Inspector: add a way to inspect a WebKitDOMNode 3023 https://bugs.webkit.org/show_bug.cgi?id=49903 3024 3025 * webkit/webkitwebinspector.cpp: 3026 (webkit_web_inspector_inspect_node): 3027 * webkit/webkitwebinspector.h: 3028 30292010-11-26 Mario Sanchez Prada <msanchez@igalia.com> 3030 3031 Reviewed by Xan Lopez. 3032 3033 [GTK] events missing when a document is (re)loaded 3034 https://bugs.webkit.org/show_bug.cgi?id=25831 3035 3036 Emit the right signals when reloading a document. 3037 3038 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3039 (WebKit::notifyAccessibilityStatus): New function, to make sure 3040 the signals involved in reloading a document are properly emitted. 3041 (WebKit::notifyStatus): Also notify accessibility if enabled. 3042 3043 New unit test to check the signals are being actually emitted. 3044 3045 * tests/testatk.c: 3046 (stateChangedCb): Callback for 'state-change' signal emitted by 3047 the accessible object associated to the webView. 3048 (documentReloadCb): Callback for 'reload' signal. 3049 (documentLoadCompleteCb): Callback for 'load-complete' signal. 3050 (webviewLoadStatusChangedCb): Callback for 'notify::load-status' 3051 signal, emitted by the WebKitWebView object (not the AtkObject). 3052 (testWebkitAtkDocumentReloadEvents): New unit test. 3053 (main): Added the new unit test. 3054 30552010-11-24 Xan Lopez <xlopez@igalia.com> 3056 3057 Reviewed by Martin Robinson. 3058 3059 [GTK] Make kit() methods return the proper type instead of gpointer 3060 https://bugs.webkit.org/show_bug.cgi?id=50034 3061 3062 * WebCoreSupport/EditorClientGtk.cpp: 3063 (WebKit::EditorClient::shouldDeleteRange): get rid of unneeded cast. 3064 (WebKit::EditorClient::shouldShowDeleteInterface): ditto. 3065 (WebKit::EditorClient::shouldBeginEditing): ditto. 3066 (WebKit::EditorClient::shouldEndEditing): ditto. 3067 (WebKit::EditorClient::shouldInsertText): ditto. 3068 (WebKit::EditorClient::shouldChangeSelectedRange): ditto. 3069 (WebKit::EditorClient::shouldApplyStyle): ditto. 3070 (WebKit::EditorClient::shouldInsertNode): ditto. 3071 * webkit/webkitprivate.cpp: 3072 (WebKit::kit): ditto. 3073 * webkit/webkitwebview.cpp: 3074 (webkit_web_view_get_dom_document): ditto. 3075 30762010-11-24 Xan Lopez <xlopez@igalia.com> 3077 3078 Reviewed by Martin Robinson. 3079 3080 Fix crashes in GTK+ bots. Use kit() instead of wrapFoo, otherwise 3081 the DOM objects won't be in the cache and we'll ASSERT when 3082 unreffing them. 3083 3084 * WebCoreSupport/EditorClientGtk.cpp: 3085 (WebKit::EditorClient::shouldDeleteRange): use kit to get the 3086 GObject wrapper for the DOM object. 3087 (WebKit::EditorClient::shouldShowDeleteInterface): ditto. 3088 (WebKit::EditorClient::shouldBeginEditing): ditto. 3089 (WebKit::EditorClient::shouldEndEditing): ditto. 3090 (WebKit::EditorClient::shouldInsertText): ditto. 3091 (WebKit::EditorClient::shouldChangeSelectedRange): ditto. 3092 (WebKit::EditorClient::shouldApplyStyle): ditto. 3093 (WebKit::EditorClient::shouldInsertNode): ditto. 3094 30952010-11-24 Martin Robinson <mrobinson@igalia.com> 3096 3097 Reviewed by Xan Lopez. 3098 3099 [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient 3100 https://bugs.webkit.org/show_bug.cgi?id=49143 3101 3102 Add signals that encapsulate the functionality of the Mac EditingDelegate. These signals 3103 are private for now, but DRT consumes them to produce proper output for editing tests. 3104 After some time, these may be part of the public API. 3105 3106 * WebCoreSupport/EditorClientGtk.cpp: 3107 (WebKit::EditorClient::shouldDeleteRange): Fire the appropriate editing signal. 3108 (WebKit::EditorClient::shouldShowDeleteInterface): Ditto. 3109 (WebKit::EditorClient::shouldBeginEditing): Ditto. 3110 (WebKit::EditorClient::shouldEndEditing): Ditto. 3111 (WebKit::kit): Added helper function. 3112 (WebKit::EditorClient::shouldInsertText): Fire the appropriate editing signal. 3113 (WebKit::EditorClient::shouldChangeSelectedRange): Ditto. 3114 (WebKit::EditorClient::shouldApplyStyle): Ditto. 3115 (WebKit::EditorClient::didBeginEditing): Ditto. 3116 (WebKit::EditorClient::respondToChangedContents): Ditto. 3117 (WebKit::EditorClient::respondToChangedSelection): Ditto. 3118 (WebKit::EditorClient::didEndEditing): Ditto. 3119 (WebKit::EditorClient::shouldInsertNode): Ditto. 3120 * webkit/webkitwebview.cpp: 3121 (webkit_web_view_real_should_allow_editing_action): Added this default signal 3122 callback which explicitly allows cancellable editing actions. 3123 (webkit_web_view_class_init): Add new editing signal declarations to the view. 3124 * webkit/webkitwebview.h: 3125 * webkitmarshal.list: Added some new marshaling definitions. 3126 31272010-11-24 Sheriff Bot <webkit.review.bot@gmail.com> 3128 3129 Unreviewed, rolling out r72499. 3130 http://trac.webkit.org/changeset/72499 3131 https://bugs.webkit.org/show_bug.cgi?id=50022 3132 3133 This change is causing crashes on the bots. (Requested by 3134 mrobinson on #webkit). 3135 3136 * tests/testatk.c: 3137 (main): 3138 31392010-11-23 Xan Lopez <xlopez@igalia.com> 3140 3141 Reviewed by Martin Robinson. 3142 3143 [GTK] Fix IFrame DOM bindings API 3144 https://bugs.webkit.org/show_bug.cgi?id=49980 3145 3146 * tests/testdomdocument.c: 3147 (test_dom_document_garbage_collection): change to use the fixed 3148 IFrame APIs. 3149 31502010-11-23 Carlos Garcia Campos <cgarcia@igalia.com> 3151 3152 Reviewed by Martin Robinson. 3153 3154 focus issue with links that have tooltips 3155 https://bugs.webkit.org/show_bug.cgi?id=49498 3156 3157 Set the area of the widget where the tooltip should be shown when 3158 a new tooltip is set. Since the widget is the same (the view), if 3159 the tooltip area is not set and a new tooltip is triggered while 3160 the previous one is still visible, the text of the tooltip is 3161 updated but its position doesn't change. 3162 3163 * WebCoreSupport/ChromeClientGtk.cpp: 3164 (WebKit::ChromeClient::mouseDidMoveOverElement): 3165 * webkit/webkitprivate.h: 3166 * webkit/webkitwebview.cpp: 3167 (webkit_web_view_query_tooltip): 3168 31692010-11-21 Mario Sanchez Prada <msanchez@igalia.com> 3170 3171 Reviewed by Chris Fleizach. 3172 3173 [GTK] Implement ROLE_COMBO_BOX 3174 https://bugs.webkit.org/show_bug.cgi?id=25678 3175 3176 New test to check the implementation of the combo boxes. 3177 3178 * tests/testatk.c: 3179 (testWebkitAtkComboBox): New test, checking that the roles and the 3180 implemented interfaces for a combo box and its descendants work. 3181 (main): Added the new unit test. 3182 31832010-11-20 Xan Lopez <xlopez@igalia.com> 3184 3185 Reviewed by Martin Robinson. 3186 3187 Remove leftover code in unit test. 3188 3189 * GNUmakefile.am: remove unneeded utils file in dependency list. 3190 * tests/testdomdocument.c: 3191 (main): do not change to the directory of a non existing resource 3192 list. 3193 31942010-11-20 Xan Lopez <xlopez@igalia.com> 3195 3196 Reviewed by Martin Robinson. 3197 3198 [GTK] Memory managament for DOM GObject wrappers 3199 https://bugs.webkit.org/show_bug.cgi?id=40302 3200 3201 Initial attempt to have a kind of poor man's garbage collection 3202 for GObject DOM objects. We tie the object's lifecycle to their 3203 parent Frame and/or its document; that is, all objects will be 3204 collected when their parent frame is destroyed or when that frame 3205 transitions to a new document. Manual management (calling 3206 g_object_unref on them) is also allowed, and is required for 3207 objects that are not in the DOM tree (eg NodeLists). 3208 3209 * GNUmakefile.am: add testutils file to testdomdocument.c 3210 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3211 (WebKit::FrameLoaderClient::setMainFrameDocumentReady): collect 3212 DOM objects on document transition. 3213 * tests/testdomdocument.c: 3214 (dom_document_fixture_teardown): only destroy the view if it's not 3215 already destroyed, since the new test detroys it on its own. 3216 (test_dom_document_get_elements_by_tag_name): manually unref node list. 3217 (test_dom_document_get_elements_by_class_name): ditto. 3218 (test_dom_document_get_links): ditto. 3219 (test_dom_document_garbage_collection): test all possible 3220 scenarios for DOM object "garbage collection". 3221 (main): add new test. 3222 * tests/testdomnode.c: 3223 (test_dom_node_hierarchy_navigation): manually unref node list. 3224 (test_dom_node_insertion): ditto. 3225 * webkit/webkithittestresult.cpp: 3226 (webkit_hit_test_result_dispose): unref the inner node on dispose 3227 now that the memory management model is clarified. 3228 (webkit_hit_test_result_class_init): hook dispose. 3229 * webkit/webkitwebframe.cpp: 3230 (webkit_web_frame_core_frame_gone): clear DOM objects attached to this frame. 3231 (webkit_web_frame_finalize): ditto. 3232 32332010-11-18 Xan Lopez <xlopez@igalia.com> 3234 3235 Reviewed by Martin Robinson. 3236 3237 Fix introspection build, we were missing a -I flag. 3238 3239 * GNUmakefile.am: 3240 32412010-11-18 Mario Sanchez Prada <msanchez@igalia.com> 3242 3243 Reviewed by Martin Robinson. 3244 3245 [Gtk] atk_text_get_selection returns the wrong offsets after a link 3246 https://bugs.webkit.org/show_bug.cgi?id=49514 3247 3248 Updated test case to also chech this specific subcase. 3249 3250 We need to explicitly check the case of having a selection in a 3251 paragraph after an embedded object (i.e. a link) to make sure the 3252 right calculations are being done when the paragraph is composed 3253 of more than just one text object, and the current selection is 3254 made only in one of them. 3255 3256 * tests/testatk.c: 3257 (testWebkitAtkTextSelections): Make sure that a selection after a 3258 link in a paragraph is working ok when asking for the text 3259 selection from the point of view of the paragraph. 3260 32612010-11-17 Martin Robinson <mrobinson@igalia.com> 3262 3263 Reviewed by Gustavo Noronha Silva. 3264 3265 [GTK] Changing any GNUmakefile.am in the source tree forces a rebuld of the DOM bindings and WebKit APi 3266 https://bugs.webkit.org/show_bug.cgi?id=49400 3267 3268 Add GNUmakefile.am and include all WebKit API build rules. Make webkitenum.* 3269 depend on this new file, instead of the generated GNUmakefile.am. 3270 3271 * GNUmakefile.am: Copied from GNUmakefile.am. 3272 32732010-11-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 3274 3275 Reviewed by Martin Robinson. 3276 3277 Fix a typo that leads to emitting the wrong signal if it is done 3278 by using the signals array. 3279 3280 * webkit/webkitwebview.cpp: 3281 (webkit_web_view_class_init): 3282 32832010-11-16 Carlos Garcia Campos <cgarcia@igalia.com> 3284 3285 Reviewed by Martin Robinson. 3286 3287 [GTK] Some key-press events can't be handled by WebView 3288 https://bugs.webkit.org/show_bug.cgi?id=48986 3289 3290 The problem is that "popup-menu" and "show-help" signals are 3291 handled by GtkTextView, as they are added to the key bindings set 3292 of every widget in gtk_widget_class_init(). For all other bindings 3293 handled by GtkTextView we are stopping the signal emission in 3294 their callbacks, so we only need to do the same for "popup-menu" 3295 and "show-help" signals. 3296 3297 * WebCoreSupport/EditorClientGtk.cpp: 3298 (WebKit::toggleOverwriteCallback): 3299 (WebKit::popupMenuCallback): 3300 (WebKit::showHelpCallback): 3301 (WebKit::EditorClient::EditorClient): 3302 33032010-11-16 Carlos Garcia Campos <cgarcia@igalia.com> 3304 3305 Reviewed by Martin Robinson. 3306 3307 [GTK] Show default context menu for the currently focused element when activated with keyboard 3308 https://bugs.webkit.org/show_bug.cgi?id=49376 3309 3310 * webkit/webkitwebview.cpp: 3311 (webkit_web_view_popup_menu_handler): 3312 33132010-11-11 Joone Hur <joone@kldp.org> 3314 3315 Reviewed by Antonio Gomes. 3316 3317 [GTK][DRT] Implement LayoutTestController::nodesFromRect 3318 https://bugs.webkit.org/show_bug.cgi?id=46598 3319 3320 Support nodesFromRect in DRT 3321 3322 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: 3323 (DumpRenderTreeSupportGtk::nodesFromRect): Added. 3324 * WebCoreSupport/DumpRenderTreeSupportGtk.h: 3325 33262010-11-11 Chang Shu <chang.shu@nokia.com> 3327 3328 Reviewed by Antonio Gomes. 3329 3330 [GTK] Replace "MoveForward"/"MoveBackward" with "MoveRight"/"MoveLeft" 3331 to make spatial navigation work on input/textarea. 3332 https://bugs.webkit.org/show_bug.cgi?id=49056 3333 3334 * WebCoreSupport/EditorClientGtk.cpp: 3335 (WebKit::moveCursorCallback): 3336 33372010-11-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk> 3338 3339 Reviewed by Martin Robinson. 3340 3341 [GTK] Link with target name set does not work 3342 https://bugs.webkit.org/show_bug.cgi?id=48865 3343 3344 When a new page is created with a name (target=myFrame), the new 3345 mainFrame could not be found because they where not stored in the 3346 same PageGroup. As PageGroup are not exposed externally so the 3347 simpliest solution is to use a global page group name. This also fixes 3348 issue with visited link coloration across pages. After this change the 3349 private function webkit_web_view_set_group_name() was no longer used 3350 so it was removed completly. 3351 3352 * WebCoreSupport/ChromeClientGtk.cpp: 3353 (WebKit::ChromeClient::closeWindowSoon): 3354 * WebCoreSupport/InspectorClientGtk.cpp: 3355 (WebKit::InspectorClient::openInspectorFrontend): 3356 * webkit/webkitprivate.h: 3357 * webkit/webkitwebview.cpp: 3358 (webkit_web_view_init): 3359 33602010-11-08 Alexey Proskuryakov <ap@apple.com> 3361 3362 Reviewed by Darin Adler. 3363 3364 https://bugs.webkit.org/show_bug.cgi?id=48685 3365 Notify UI process about focused frame 3366 3367 Added an empty implementation of the new ChromeClient method. 3368 3369 * WebCoreSupport/ChromeClientGtk.cpp: 3370 (WebKit::ChromeClient::focusedFrameChanged): 3371 * WebCoreSupport/ChromeClientGtk.h: 3372 33732010-11-08 Martin Robinson <mrobinson@igalia.com> 3374 3375 Reviewed by Andreas Kling. 3376 3377 [GTK] Error page templates are not filled properly 3378 https://bugs.webkit.org/show_bug.cgi?id=49148 3379 3380 Replace a call to makeString with String::format. This was mistakenly 3381 changed to makeString in an earlier commit. 3382 3383 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3384 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 3385 33862010-11-08 Xan Lopez <xlopez@igalia.com> 3387 3388 Reviewed by Martin Robinson. 3389 3390 * NEWS: update for release. 3391 33922010-11-08 Csaba Osztrogonac <ossy@webkit.org> 3393 3394 Unreviewed, rolling out r71466. 3395 http://trac.webkit.org/changeset/71466 3396 https://bugs.webkit.org/show_bug.cgi?id=48865 3397 3398 It broke layout tests on GTK bots. 3399 3400 * WebCoreSupport/ChromeClientGtk.cpp: 3401 (WebKit::ChromeClient::closeWindowSoon): 3402 * webkit/webkitprivate.h: 3403 * webkit/webkitwebview.cpp: 3404 (webkit_web_view_init): 3405 (webkit_web_view_set_group_name): 3406 34072010-11-07 Adam Barth <abarth@webkit.org> 3408 3409 Reviewed by Eric Seidel. 3410 3411 Rename Cache to MemoryCache 3412 https://bugs.webkit.org/show_bug.cgi?id=49159 3413 3414 * webkit/webkitwebview.cpp: 3415 34162010-11-05 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk> 3417 3418 Reviewed by Martin Robinson. 3419 3420 [GTK] Link with target name set does not work correctly 3421 https://bugs.webkit.org/show_bug.cgi?id=48865 3422 3423 When a new page is created with a name (target=myFrame), the new 3424 mainFrame could not be found because they where not stored in the 3425 same PageGroup. As PageGroup are not exposed externally so the 3426 simpliest solution is to use a global page group name. This also fixes 3427 issue with visited link coloration across pages. After this change the 3428 private function webkit_web_view_set_group_name() was no longer used 3429 so it was removed completly. 3430 3431 * WebCoreSupport/ChromeClientGtk.cpp: 3432 (WebKit::ChromeClient::closeWindowSoon): 3433 * webkit/webkitprivate.h: 3434 * webkit/webkitwebview.cpp: 3435 (webkit_web_view_init): 3436 34372010-11-05 Chris Marrin <cmarrin@apple.com> 3438 3439 Reviewed by Simon Fraser. 3440 3441 Move resumeAnimations/suspendAnimations from Frame to AnimationController. 3442 https://bugs.webkit.org/show_bug.cgi?id=49073 3443 3444 * webkit/webkitwebframe.cpp: 3445 (webkit_web_frame_suspend_animations): 3446 (webkit_web_frame_resume_animations): 3447 34482010-11-05 Chris Marrin <cmarrin@apple.com> 3449 3450 Unreviewed. 3451 3452 Small fix to GTK build 3453 3454 * webkit/webkitwebframe.cpp: 3455 (webkit_web_frame_suspend_animations): 3456 (webkit_web_frame_resume_animations): 3457 34582010-11-05 Chris Marrin <cmarrin@apple.com> 3459 3460 Reviewed by Simon Fraser. 3461 3462 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state 3463 https://bugs.webkit.org/show_bug.cgi?id=46945 3464 3465 * webkit/webkitwebframe.cpp: 3466 (webkit_web_frame_suspend_animations): 3467 (webkit_web_frame_resume_animations): 3468 34692010-11-03 Daniel Bates <dbates@rim.com> 3470 3471 For unnamed frames, window.name returns a generated name 3472 https://bugs.webkit.org/show_bug.cgi?id=6751 3473 3474 Part 1 of 2. 3475 3476 Substitute FrameTree::uniqueName() for FrameTree::name() in the GTK port. 3477 3478 * webkit/webkitwebframe.cpp: 3479 (webkit_web_frame_get_name): 3480 34812010-11-02 Martin Robinson <mrobinson@igalia.com> 3482 3483 Reviewed by Adam Barth. 3484 3485 [Cairo] Remove PlatformRefPtrCairo 3486 https://bugs.webkit.org/show_bug.cgi?id=48192 3487 3488 Replace instances of PlatformRefPtr smart pointers that wrap Cairo 3489 types with RefPtrs. 3490 3491 * WebCoreSupport/DragClientGtk.cpp: Use RefPtr instead of PlatformRefPtr. 3492 (WebKit::dragIconWindowDrawEventCallback): 3493 * WebCoreSupport/DragClientGtk.h: Ditto. 3494 34952010-11-02 Daniel Bates <dbates@rim.com> 3496 3497 Reviewed by Martin Robinson. 3498 3499 Set frame name before appending it to the frame tree in the Apple Windows, 3500 GTK, and EFL ports 3501 https://bugs.webkit.org/show_bug.cgi?id=48806 3502 3503 Make the frame creation process in the GTK-port consistent with the 3504 Mac, Qt, and Haiku ports. In particular, set the name of the new 3505 frame before it's appended to the frame tree. 3506 3507 At this time we cannot test this change since it is being masked by 3508 HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>. 3509 We'll be able to test this once we fix bug #6751. 3510 3511 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3512 (WebKit::FrameLoaderClient::createFrame): 3513 35142010-11-01 Jennifer Braithwaite <jennb@google.com> 3515 3516 Reviewed by Martin Robinson. 3517 3518 GTK: Update resource tracking when moving a frame between documents 3519 https://bugs.webkit.org/show_bug.cgi?id=48362 3520 3521 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3522 (WebKit::FrameLoaderClient::transferLoadingResourceFromPage): 3523 Assign resource id to current web view and remove from former web view. 3524 * webkit/webkitprivate.h: 3525 * webkit/webkitwebview.cpp: 3526 (webkit_web_view_remove_resource): 3527 Added. 3528 35292010-11-01 Mario Sanchez Prada <msanchez@igalia.com> 3530 3531 Reviewed by Martin Robinson. 3532 3533 [GTK] Cleanup needed in testatk.c file 3534 https://bugs.webkit.org/show_bug.cgi?id=48759 3535 3536 Cleanup done in testatk.c, mainly addressing the following issues: 3537 3538 - Removed any trace of extra main loops in tests, so now we just 3539 spin the original main loop in all of them to get the a11y 3540 objects. 3541 3542 - As we no longer use the extra main loops, removed the bail_out 3543 function, used along with g_idle_add() to stop those extra loops. 3544 3545 - As we now spin the loop in every test, created a new function 3546 waitForAccessibilityObjects() to write the loop just once. 3547 3548 - Fixed name in incorrectly named test testWekitAtkTextSelections. 3549 3550 - Alphabetically sorted the list of includes. 3551 3552 - Renamed all identifiers to camel Case notation. 3553 3554 - Declare variables when needed only (instead of declaring all of 3555 them at the beginning of the function). 3556 3557 - Don't declare two variables of the same type in the same line. 3558 3559 - No more short names like 'obj', 'textObj' or 'alloc'. Use names 3560 like 'object', 'textObject' and 'allocation' instead. 3561 3562 - Fixed indentation. 3563 3564 - Make sure all comments finish with '.' 3565 3566 - Replace NULL's with 0's. 3567 3568 * tests/testatk.c: 3569 (waitForAccessibleObjects): New, manually spins the main context 3570 to make sure accessible objects are created before continuing. 3571 (testGetTextFunction): Fixed this function to be compliant with 3572 the WebKit's coding style. 3573 (runGetTextTests): Ditto. 3574 (testWebkitAtkGetTextAtOffsetForms): Ditto. 3575 (testWebkitAtkGetTextAtOffset): Ditto. 3576 (testWebkitAtkGetTextAtOffsetNewlines): Ditto. 3577 (testWebkitAtkGetTextAtOffsetTextarea): Ditto. 3578 (testWebkitAtkGetTextAtOffsetTextInput): Ditto. 3579 (testWebkitAtkGetTextInParagraphAndBodySimple): Ditto. 3580 (testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto. 3581 (testWebkitAtkGetTextInTable): Ditto. 3582 (testWebkitAtkGetHeadersInTable): Ditto. 3583 (compAtkAttribute): Ditto. 3584 (atkAttributeSetAttributeNameHasValue): Ditto. 3585 (testWebkitAtkTextAttributes): Ditto. 3586 (testWebkitAtkTextSelections): Ditto. 3587 (testWebkitAtkGetExtents): Ditto. 3588 (testWebkitAtkLayoutAndDataTables): Ditto. 3589 (testWebkitAtkLinksWithInlineImages): Ditto. 3590 (testWebkitAtkHypertextAndHyperlinks): Ditto. 3591 (testWebkitAtkListsOfItems): Ditto. 3592 (testWebkitAtkTextChangedNotifications): Ditto. 3593 (main): Ditto. 3594 35952010-11-01 Brady Eidson <beidson@apple.com> 3596 3597 Reviewed by Anders Carlsson. 3598 3599 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699 3600 Context menu support for WebKit 2. 3601 3602 * WebCoreSupport/ChromeClientGtk.h: 3603 (WebKit::ChromeClient::showContextMenu): 3604 36052010-11-01 Martin Robinson <mrobinson@igalia.com> 3606 3607 Reviewed by Xan Lopez. 3608 3609 [GTK] Pasting markup into Thunderbird compose window produces no text 3610 https://bugs.webkit.org/show_bug.cgi?id=43737 3611 3612 Added a test verifying that the meta tag prefix on markup data exists. 3613 3614 * tests/testcopyandpaste.c: 3615 (load_status_cb): Add a check for the meta tag prefix. 3616 36172010-11-01 Mario Sanchez Prada <msanchez@igalia.com> 3618 3619 Reviewed by Martin Robinson. 3620 3621 [Gtk] AtkHyperlink needs to be implemented 3622 https://bugs.webkit.org/show_bug.cgi?id=33785 3623 3624 New test to ensure the AtkHypertext/AtkHyperlink stuff works. 3625 3626 * tests/testatk.c: 3627 (testWebkitAtkHypertextAndHyperlinks): New test, checking both the 3628 implementation of the AtkHypertext interface, the subclass of the 3629 AtkHyperlink abstract class, and the implementation of the 3630 AtkAction interface in that subclass. 3631 (main): Added the new unit test. 3632 36332010-10-30 Xan Lopez <xlopez@igalia.com> 3634 3635 Reviewed by Martin Robinson. 3636 3637 [GTK] Use new width for height APIs in GTK+ 3.x 3638 https://bugs.webkit.org/show_bug.cgi?id=48709 3639 3640 Use the new width for height APIs in GTK+ 3.x, since size-request 3641 is deprecated. 3642 3643 For now we just return the same value for preferred and minimum 3644 width/height, which should match the 2.x behavior. Probably we 3645 could do something smarter for the minimum values. 3646 3647 * webkit/webkitwebview.cpp: 3648 (webkit_web_view_get_preferred_width): return our preferred width. 3649 (webkit_web_view_get_preferred_height): return our preferred height. 3650 (webkit_web_view_class_init): hook the new default handlers. 3651 36522010-10-29 Daniel Bates <dbates@rim.com> 3653 3654 No review, rolling out 70971. 3655 http://trac.webkit.org/changeset/70971 3656 https://bugs.webkit.org/show_bug.cgi?id=6751 3657 3658 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since 3659 it caused layout test failures on all bots. In particular, the 3660 child count in a generated frame name differs after this patch. We need 3661 to look into this further. 3662 3663 * webkit/webkitwebframe.cpp: 3664 (webkit_web_frame_get_name): 3665 36662010-10-28 Antonio Gomes <agomes@rim.com> 3667 3668 Reviewed by Ojan Vafai. 3669 3670 Needs a "LinuxEditingBehavior", perhaps with a better name 3671 https://bugs.webkit.org/show_bug.cgi?id=36627 3672 3673 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WEBKIT_EDITING_BEHAVIOR_UNIX. 3674 3675 * webkit/webkitwebsettings.cpp: 3676 (webkit_web_settings_class_init): 3677 * webkit/webkitwebsettings.h: 3678 36792010-10-29 Daniel Bates <dbates@rim.com> 3680 3681 Reviewed by Adam Barth. 3682 3683 For unnamed frames, window.name returns a generated name 3684 https://bugs.webkit.org/show_bug.cgi?id=6751 3685 3686 Modified GTK-port to use FrameTree::uniqueName(). 3687 3688 * webkit/webkitwebframe.cpp: 3689 (webkit_web_frame_get_name): 3690 36912010-10-29 Martin Robinson <mrobinson@igalia.com> 3692 3693 Build fix for GTK+ after BackForwardListImpl introduction. 3694 3695 * webkit/webkitwebbackforwardlist.cpp: 3696 (webkit_web_back_forward_list_new_with_web_view): 3697 36982010-10-29 Darin Adler <darin@apple.com> 3699 3700 Reviewed by Sam Weinig. 3701 3702 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring 3703 https://bugs.webkit.org/show_bug.cgi?id=48574 3704 3705 * webkit/webkitprivate.h: 3706 * webkit/webkitwebbackforwardlist.cpp: 3707 (webkit_web_back_forward_list_dispose): 3708 (webkit_web_back_forward_list_new_with_web_view): 3709 (webkit_web_back_forward_list_go_forward): 3710 (webkit_web_back_forward_list_go_back): 3711 (webkit_web_back_forward_list_contains_item): 3712 (webkit_web_back_forward_list_go_to_item): 3713 (webkit_web_back_forward_list_get_forward_list_with_limit): 3714 (webkit_web_back_forward_list_get_back_list_with_limit): 3715 (webkit_web_back_forward_list_get_back_item): 3716 (webkit_web_back_forward_list_get_current_item): 3717 (webkit_web_back_forward_list_get_forward_item): 3718 (webkit_web_back_forward_list_get_nth_item): 3719 (webkit_web_back_forward_list_get_back_length): 3720 (webkit_web_back_forward_list_get_forward_length): 3721 (webkit_web_back_forward_list_get_limit): 3722 (webkit_web_back_forward_list_set_limit): 3723 (webkit_web_back_forward_list_add_item): 3724 (webkit_web_back_forward_list_clear): 3725 (WebKit::core): 3726 * webkit/webkitwebview.cpp: 3727 (webkit_web_view_set_maintains_back_forward_list): 3728 (webkit_web_view_get_back_forward_list): 3729 Use BackForwardListImpl. 3730 37312010-10-29 Alexey Proskuryakov <ap@apple.com> 3732 3733 Reviewed by Darin Adler. 3734 3735 https://bugs.webkit.org/show_bug.cgi?id=48576 3736 Let WebKit2 client know when a frame is a frameset 3737 3738 Added a blank implementation of the new FrameLoaderClient method. 3739 3740 * WebCoreSupport/FrameLoaderClientGtk.h: 3741 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3742 (WebKit::FrameLoaderClient::dispatchDidBecomeFrameset): 3743 37442010-10-29 Alejandro G. Castro <alex@igalia.com> 3745 3746 Reviewed by Martin Robinson. 3747 3748 [GTK] Add the GtkScrollablePolicy property to the webview 3749 https://bugs.webkit.org/show_bug.cgi?id=48357 3750 3751 Added the GtkScrollablePolicy properties to the webview widget, it 3752 is now required for GtkScrollable widgets in GTK+ 3.x. 3753 3754 * webkit/webkitprivate.h: 3755 * webkit/webkitwebview.cpp: 3756 (setHorizontalScrollPolicy): Added. 3757 (setVerticalScrollPolicy): Added. 3758 (getHorizontalScrollPolicy): Added. 3759 (getVerticalScrollPolicy): Added. 3760 (webkit_web_view_get_property): 3761 (webkit_web_view_set_property): 3762 (webkit_web_view_class_init): 3763 37642010-10-28 Sergio Villar Senin <svillar@igalia.com> 3765 3766 Reviewed by Martin Robinson. 3767 3768 [GTK] WebKitWebFrame's load-status is not properly notified to the tests 3769 https://bugs.webkit.org/show_bug.cgi?id=48048 3770 3771 "frame-created" signal must be issued before loading any data, 3772 that way clients can correctly capture all the loading related 3773 signals for that frame. 3774 3775 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3776 (WebKit::FrameLoaderClient::createFrame): 3777 37782010-10-27 Mario Sanchez Prada <msanchez@igalia.com> 3779 3780 Reviewed by Martin Robinson. 3781 3782 getTextAtOffset returns incorrect results if a link includes text and an image 3783 https://bugs.webkit.org/show_bug.cgi?id=47365 3784 3785 New test to make sure this bug is actually fixed. 3786 3787 * tests/testatk.c: 3788 (testWebkitAtkLinksWithInlineImages): New test. 3789 (main): Added new test. 3790 37912010-10-26 Antonio Gomes <agomes@rim.com> 3792 3793 Reviewed by Martin Robinson. 3794 3795 [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea) 3796 https://bugs.webkit.org/show_bug.cgi?id=48199 3797 3798 Implemented an initial version of the DumpRenderTreeSupportGtk class. 3799 The main idea is that it groups together the bodies of many LayoutTestController 3800 methods, so they can directly access WebCore features. This way we eliminate the 3801 need of adding APIs to WebKitGTK just to expand its test coverage through DRT. 3802 3803 The DumpRenderTreeSupportGtk class so far includes a getter and setter for the WebKitTabToLinksPreferenceKey 3804 property as a sample implementation. Also it makes it possible to unskip fast/events/tab-focus-anchor.html and 3805 to fix stderr messages from all 22 spatial-navigation tests in fast/events/spatial-navigation. 3806 3807 * WebCoreSupport/ChromeClientGtk.cpp: 3808 (WebKit::ChromeClient::tabsToLinks): 3809 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added. 3810 (DumpRenderTreeSupportGtk::DumpRenderTreeSupportGtk): 3811 (DumpRenderTreeSupportGtk::~DumpRenderTreeSupportGtk): 3812 (DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled): 3813 (DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled): Getter to the WebKitTabToLinksPreferenceKey property. 3814 (DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain): Setter to the WebKitTabToLinksPreferenceKey property. 3815 (DumpRenderTreeSupportGtk::linksIncludedInFocusChain): 3816 * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added. 3817 38182010-10-26 Jenn Braithwaite <jennb@chromium.org> 3819 3820 Reviewed by Dmitry Titov. 3821 3822 Resource tracking failure when trying to move a frame between documents 3823 https://bugs.webkit.org/show_bug.cgi?id=44713 3824 3825 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3826 (WebKit::FrameLoaderClient::transferLoadingResourceFromPage): 3827 Empty method. 3828 * WebCoreSupport/FrameLoaderClientGtk.h: 3829 38302010-10-26 Mario Sanchez Prada <msanchez@igalia.com> 3831 3832 Reviewed by Chris Fleizach. 3833 3834 [Gtk] Layout tables should indicate that they are not data tables via an object attribute 3835 https://bugs.webkit.org/show_bug.cgi?id=35422 3836 3837 New unit test to check the 'layout-guess' attribute in tables. 3838 3839 * tests/testatk.c: 3840 (atkAttributeSetAttributeNameHasValue): New, looks for a attribute 3841 with a specific value, by the name of attribute. 3842 (atkAttributeSetContainsAttributeName): New, just checks whether 3843 an attribute with a specified name is present in the set. 3844 (atkAttributeSetAttributeHasValue): Modified to relay on the new 3845 function atkAttributeSetAttributeNameHasValue(). 3846 (testWebkitAtkLayoutAndDataTables): New test. 3847 (main): Added the new test. 3848 38492010-10-26 Xan Lopez <xlopez@igalia.com> 3850 3851 Reviewed by Martin Robinson. 3852 3853 [GTK] Port to new GtkScrollable interface in GTK+ 3.x 3854 https://bugs.webkit.org/show_bug.cgi?id=48202 3855 3856 Use the new GtkScrollable interface when compiling against GTK+ 3857 3.x. 3858 3859 * webkit/webkitwebview.cpp: 3860 (setHorizontalAdjustment): 3861 (setVerticalAdjustment): 3862 (getHorizontalAdjustment): 3863 (getVerticalAdjustment): 3864 (webkit_web_view_get_property): 3865 (webkit_web_view_set_property): 3866 (webkit_web_view_class_init): 3867 38682010-10-22 Sam Weinig <sam@webkit.org> 3869 3870 Reviewed by Anders Carlsson. 3871 3872 WebKit2 needs to pass the current event modifier flags when requesting a new window 3873 https://bugs.webkit.org/show_bug.cgi?id=48140 3874 3875 * WebCoreSupport/ChromeClientGtk.cpp: 3876 (WebKit::ChromeClient::createWindow): 3877 * WebCoreSupport/ChromeClientGtk.h: 3878 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3879 (WebKit::FrameLoaderClient::dispatchCreatePage): 3880 * WebCoreSupport/FrameLoaderClientGtk.h: 3881 Add NavigationAction parameter. 3882 38832010-10-20 Philippe Normand <pnormand@igalia.com> 3884 3885 Reviewed by Xan Lopez. 3886 3887 [GTK] use gtk_widget_hide instead of gtk_widget_hide_all in the fullscreen video conroller 3888 https://bugs.webkit.org/show_bug.cgi?id=47972 3889 3890 * WebCoreSupport/FullscreenVideoController.cpp: 3891 (FullscreenVideoController::hideHud): 3892 (FullscreenVideoController::exitFullscreen): 3893 38942010-10-19 Joone Hur <joone@kldp.org> 3895 3896 Reviewed by Martin Robinson. 3897 3898 [GTK] Needs fixing mistyped comments in the API documentation 3899 https://bugs.webkit.org/show_bug.cgi?id=47656 3900 3901 Fixed mistyped comments in the API documenentation. 3902 3903 * webkit/webkitwebsettings.cpp: Fixed a mistyped comment in the the section block. 3904 * webkit/webkitwebwindowfeatures.cpp: Fixed a mistyped comment in the section block. 3905 39062010-10-18 Xan Lopez <xlopez@igalia.com> 3907 3908 Reviewed by Martin Robinson. 3909 3910 * NEWS: update for 1.3.5 release. 3911 * docs/webkitgtk-sections.txt: add new APIs. 3912 39132010-10-18 Pavel Feldman <pfeldman@chromium.org> 3914 3915 Reviewed by Simon Fraser. 3916 3917 Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages(). 3918 https://bugs.webkit.org/show_bug.cgi?id=46224 3919 3920 * WebCoreSupport/InspectorClientGtk.cpp: 3921 (WebKit::InspectorClient::sendMessageToFrontend): 3922 39232010-10-14 Antonio Gomes <agomes@rim.com> 3924 3925 Reviewed by Martin Robinson and Xan Lopez. 3926 3927 [Gtk]: DRT does not support frame flattening testing 3928 https://bugs.webkit.org/show_bug.cgi?id=38650 3929 3930 Implement enable-frame-flattening API for Gtk+. 3931 3932 * webkit/webkitwebsettings.cpp: 3933 (webkit_web_settings_class_init): 3934 (webkit_web_settings_set_property): 3935 (webkit_web_settings_get_property): 3936 (webkit_web_settings_copy): 3937 * webkit/webkitwebview.cpp: 3938 (webkit_web_view_update_settings): 3939 (webkit_web_view_settings_notify): 3940 39412010-10-15 Nikolas Zimmermann <nzimmermann@rim.com> 3942 3943 Reviewed by Dirk Schulze. 3944 3945 Replace some String::format() usages by StringConcatenate in WebKit 3946 https://bugs.webkit.org/show_bug.cgi?id=47714 3947 3948 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3949 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 3950 * webkit/webkitwebsettings.cpp: 3951 (webkitOSVersion): 3952 (webkitUserAgent): 3953 39542010-10-14 Joone Hur <joone@kldp.org> 3955 3956 Reviewed by Andreas Kling. 3957 3958 [GTK] google.co.kr was missed when checking Google domains 3959 https://bugs.webkit.org/show_bug.cgi?id=47652 3960 3961 WebKitGtk+ maintains a list of Google domains for working well with Google sites. 3962 Add google.co.kr also to the list to be checked with other Google domains. 3963 3964 * WebCoreSupport/FrameLoaderClientGtk.cpp: 3965 (WebKit::initializeDomainsList): Added google.co.kr. 3966 39672010-10-13 Sergio Villar Senin <svillar@igalia.com> 3968 3969 Reviewed by Martin Robinson. 3970 3971 WebKitGtk+ to use the new API from the imported SoupURILoader code 3972 3973 [GTK] Add HTTP caching support 3974 https://bugs.webkit.org/show_bug.cgi?id=44261 3975 3976 ResourceHandleInternal m_msg is now called m_soupMessage. 3977 3978 * webkit/webkitdownload.cpp: 3979 (webkit_download_new_with_handle): 3980 (webkit_download_start): 3981 39822010-10-13 Xan Lopez <xlopez@igalia.com> 3983 3984 Reviewed by Gustavo Noronha. 3985 3986 [GTK] Remove more warnings from the g-i scanner run 3987 https://bugs.webkit.org/show_bug.cgi?id=47255 3988 3989 Fixes almost all warnings coming from the g-i scanner. 3990 3991 * webkit/webkitsecurityorigin.cpp: Rename parameter names in 3992 gtk-doc blurb to the actual name of the parameter. 3993 * webkit/webkitsoupauthdialog.c: ditto. 3994 (webkit_soup_auth_dialog_class_init): Write missing doc for the 3995 'current-toplevel' signal. 3996 * webkit/webkitsoupauthdialog.h: Rename signal parameter to its 3997 actual name. 3998 * webkit/webkitwebdatabase.cpp: Rename parameter names in 3999 gtk-doc blurb to the actual name of the parameter. 4000 * webkit/webkitwebinspector.cpp: ditto. 4001 (webkit_web_inspector_class_init): ditto. 4002 * webkit/webkitwebview.cpp: ditto. 4003 (webkit_web_view_class_init): ditto. 4004 * webkit/webkitwebview.h: Rename the parameter names to be in sync 4005 with the ones we use in the function definition. 4006 40072010-10-12 Sheriff Bot <webkit.review.bot@gmail.com> 4008 4009 Unreviewed, rolling out r69589. 4010 http://trac.webkit.org/changeset/69589 4011 https://bugs.webkit.org/show_bug.cgi?id=47547 4012 4013 Wrong patch landed from a bug with two patches (Requested by 4014 mrobinson on #webkit). 4015 4016 * webkit/webkitdownload.cpp: 4017 (webkit_download_new_with_handle): 4018 (webkit_download_start): 4019 40202010-10-12 Sergio Villar Senin <svillar@igalia.com> 4021 4022 Reviewed by Martin Robinson. 4023 4024 [GTK] Add HTTP caching support 4025 https://bugs.webkit.org/show_bug.cgi?id=44261 4026 4027 ResourceHandle's m_msg renamed to m_soupMsg and it's also now a PlatformRefPtr 4028 4029 * webkit/webkitdownload.cpp: 4030 (webkit_download_new_with_handle): 4031 (webkit_download_start): 4032 40332010-10-09 Carlos Garcia Campos <cgarcia@igalia.com> 4034 4035 Reviewed by Xan Lopez. 4036 4037 [GTK] Removed unused callback in webkitwebview 4038 https://bugs.webkit.org/show_bug.cgi?id=47092 4039 4040 In webkit_web_view_forward_context_menu_event() a callback is 4041 connected for the destroy signal of the popup menu, however we 4042 reuse the same menu always, holding a ref to it, so it's not 4043 destroyed when withdrawn by the user. 4044 4045 * webkit/webkitwebview.cpp: 4046 (webkit_web_view_forward_context_menu_event): 4047 40482010-10-08 Martin Robinson <mrobinson@igalia.com> 4049 4050 Reviewed by Xan Lopez. 4051 4052 [GTK] Remove duplicate code in WebKit/gtk/WebCoreSupport/DragClientGtk.cpp 4053 https://bugs.webkit.org/show_bug.cgi?id=47367 4054 4055 Remove as much duplicate code as possible from DragClientGtk. Most of this code 4056 is GTK2/GTK3 independent, so only the bits that aren't should be protected by 4057 #ifdefs. 4058 4059 * WebCoreSupport/DragClientGtk.cpp: 4060 (WebKit::dragIconWindowDrawEventCallback): Modified the name of this callback 4061 so that it is shared between build types. 4062 (WebKit::DragClient::DragClient): Updated the signal connectors to reflect the change above. 4063 (WebKit::DragClient::~DragClient): The build types share the callback name, so remove 4064 the #ifdef here. 4065 (WebKit::DragClient::drawDragIconWindow): Changed the name of this method and make it 4066 independent of the build type. 4067 * WebCoreSupport/DragClientGtk.h: Update method declaration and remove #ifdefs. 4068 40692010-10-07 Carlos Garcia Campos <cgarcia@igalia.com> 4070 4071 Reviewed by Xan Lopez. 4072 4073 [GTK] Use draw instead of expose_event in WebView when building with gtk3 4074 https://bugs.webkit.org/show_bug.cgi?id=47338 4075 4076 * webkit/webkitwebview.cpp: 4077 (webkit_web_view_expose_event): 4078 (webkit_web_view_draw): 4079 (webkit_web_view_class_init): 4080 40812010-10-07 Carlos Garcia Campos <cgarcia@igalia.com> 4082 4083 Reviewed by Xan Lopez. 4084 4085 [GTK] Don't use GtkObject 4086 https://bugs.webkit.org/show_bug.cgi?id=47090 4087 4088 GtkObject has been removed in gtk3. 4089 4090 * WebCoreSupport/EditorClientGtk.cpp: 4091 (WebKit::EditorClient::generateEditorCommands): 4092 * WebCoreSupport/FullscreenVideoController.cpp: 4093 (FullscreenVideoController::createHud): 4094 40952010-10-07 Carlos Garcia Campos <cgarcia@igalia.com> 4096 4097 Reviewed by Xan Lopez. 4098 4099 [GTK] Fix the build for GTK+ 3 4100 https://bugs.webkit.org/show_bug.cgi?id=47249 4101 4102 Use GdkVisual instead of GdkColormap. GdkColormap has been removed 4103 in gtk3 4104 4105 * webkit/webkitwebview.cpp: 4106 (webkit_web_view_realize): 4107 41082010-10-07 Carlos Garcia Campos <cgarcia@igalia.com> 4109 4110 Reviewed by Xan Lopez. 4111 4112 [GTK] Fix the build for GTK+ 3 4113 https://bugs.webkit.org/show_bug.cgi?id=47249 4114 4115 Do not use GdkDrawable deprecated API. Some methods of GdkDrawable 4116 are deprecated in gtk2 and have been removed in gtk3. Equivalent 4117 API has been added to GdkWindow. 4118 4119 * tests/testcopyandpaste.c: 4120 (runPasteTestCallback): 4121 * webkit/webkitwebview.cpp: 4122 (webkit_web_view_button_press_event): 4123 41242010-10-07 Carlos Garcia Campos <cgarcia@igalia.com> 4125 4126 Reviewed by Xan Lopez. 4127 4128 [GTK] Use draw signal instead of expose_event in DragClientGtk when building with gtk3 4129 https://bugs.webkit.org/show_bug.cgi?id=47326 4130 4131 * WebCoreSupport/DragClientGtk.cpp: 4132 (WebKit::dragIconWindowDrawCallback): 4133 (WebKit::DragClient::DragClient): 4134 (WebKit::DragClient::~DragClient): 4135 (WebKit::DragClient::startDrag): 4136 (WebKit::DragClient::dragIconWindowDraw): 4137 * WebCoreSupport/DragClientGtk.h: 4138 41392010-10-07 Carlos Garcia Campos <cgarcia@igalia.com> 4140 4141 Reviewed by Xan Lopez. 4142 4143 [GTK] Fix the build for GTK+ 3 4144 https://bugs.webkit.org/show_bug.cgi?id=47249 4145 4146 Don't use gtk_size_request_get_size(). It has been removed, 4147 gtk_widget_get_preferred_size() should be used instead 4148 4149 * webkit/webkitwebview.cpp: 4150 (PopupMenuPositionFunc): 4151 41522010-10-06 Sheriff Bot <webkit.review.bot@gmail.com> 4153 4154 Unreviewed, rolling out r69201. 4155 http://trac.webkit.org/changeset/69201 4156 https://bugs.webkit.org/show_bug.cgi?id=47279 4157 4158 This change broke the WebKitGTK+ build for GTK+ 2.0. 4159 (Requested by mrobinson on #webkit). 4160 4161 * tests/testcopyandpaste.c: 4162 (runPasteTestCallback): 4163 * webkit/webkitwebview.cpp: 4164 (webkit_web_view_button_press_event): 4165 41662010-10-06 Carlos Garcia Campos <cgarcia@igalia.com> 4167 4168 Reviewed by Xan Lopez. 4169 4170 Port to gtk+3 (2.91.0) 4171 https://bugs.webkit.org/show_bug.cgi?id=47249 4172 4173 Do not use GdkDrawable deprecated API 4174 4175 Some methods of GdkDrawable are deprecated in gtk2 and have been 4176 remmoved in gtk3. Equivalent API has been added to GdkWindow. 4177 4178 * tests/testcopyandpaste.c: 4179 (runPasteTestCallback): 4180 * webkit/webkitwebview.cpp: 4181 (webkit_web_view_button_press_event): 4182 41832010-09-28 Jenn Braithwaite <jennb@chromium.org> 4184 4185 Reviewed by Dmitry Titov. 4186 4187 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument. 4188 https://bugs.webkit.org/show_bug.cgi?id=46663 4189 4190 * WebCoreSupport/FrameLoaderClientGtk.cpp: 4191 (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument): 4192 * WebCoreSupport/FrameLoaderClientGtk.h: 4193 41942010-09-27 Mario Sanchez Prada <msanchez@igalia.com> 4195 4196 Reviewed by Chris Fleizach. 4197 4198 [Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items 4199 https://bugs.webkit.org/show_bug.cgi?id=45381 4200 4201 Updated test to match the new exposure of list item markers. 4202 4203 Also, added some extra assertions in that test to make sure the 4204 accessible objects associated to the items implement AtkText. 4205 4206 * tests/testatk.c: 4207 (testWebkitAtkListsOfItems): 4208 (main): 4209 42102010-09-27 Philippe Normand <pnormand@igalia.com> 4211 4212 Reviewed by Martin Robinson. 4213 4214 [GTK] Doesn't build with gtk+ 2.14 4215 https://bugs.webkit.org/show_bug.cgi?id=46565 4216 4217 Fixed the build for GTK+ 2.14. Don't use gdk_window_get_cursor() 4218 for that GTK+ version as I found no acceptable way to work-around 4219 its absence. 4220 4221 * WebCoreSupport/FullscreenVideoController.cpp: 4222 (FullscreenVideoController::showHud): 4223 (FullscreenVideoController::hideHud): 4224 (FullscreenVideoController::enterFullscreen): 4225 42262010-09-26 Jenn Braithwaite <jennb@chromium.org> 4227 4228 Reviewed by Adam Barth. 4229 4230 GTK client needs updating when live iframe element is moved 4231 between pages. 4232 https://bugs.webkit.org/show_bug.cgi?id=46300 4233 4234 Test: fast/frames/iframe-reparenting-adopt-node.html 4235 4236 * WebCoreSupport/FrameLoaderClientGtk.cpp: 4237 (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument): 4238 Update the webView for the frame to match the parent frame's 4239 webView. 4240 42412010-09-24 Martin Robinson <mrobinson@igalia.com> 4242 4243 Reviewed by Gustavo Noronha Silva. 4244 4245 [GTK] opening local files on win32 4246 https://bugs.webkit.org/show_bug.cgi?id=31066 4247 4248 Add tests that check the mime type returned by local files loaded via file URLs. 4249 4250 * tests/testmimehandling.c: 4251 (testRemoteMimeType): Added. 4252 (testLocalMimeType): Added. 4253 (main): Run tests by using g_test_add_data_func with either 4254 testRemoteMimeType or testLocalMimeType. 4255 42562010-09-23 Martin Robinson <mrobinson@igalia.com> 4257 4258 Reviewed by Nate Chapin. 4259 4260 [GTK] Some tests from r68174 fail on the GTK+ bots 4261 https://bugs.webkit.org/show_bug.cgi?id=46396 4262 4263 Fix since version number in this new WebKitWebSettings property. 4264 4265 * webkit/webkitwebsettings.cpp: 4266 (webkit_web_settings_class_init): Fix the since version number. 4267 42682010-09-23 Nate Chapin <japhet@chromium.org> 4269 4270 Unreviewed, build fix. 4271 4272 Add a missing comma in webkitwebsettings.cpp. 4273 4274 * webkit/webkitwebsettings.cpp: 4275 42762010-09-23 Nate Chapin <japhet@chromium.org> 4277 4278 Reviewed by Darin Fisher. 4279 4280 Add hyperlink auditing settings (i.e., <a ping>). 4281 https://bugs.webkit.org/show_bug.cgi?id=30458 4282 4283 * webkit/webkitwebsettings.cpp: 4284 (webkit_web_settings_class_init): 4285 (webkit_web_settings_set_property): 4286 (webkit_web_settings_get_property): 4287 (webkit_web_settings_copy): 4288 * webkit/webkitwebview.cpp: 4289 (webkit_web_view_update_settings): 4290 (webkit_web_view_settings_notify): 4291 42922010-09-22 Mario Sanchez Prada <msanchez@igalia.com> 4293 4294 Reviewed by Martin Robinson. 4295 4296 [GTK] Replace instances of g_timeout_add() with g_idle_add() in testatk.c 4297 https://bugs.webkit.org/show_bug.cgi?id=46284 4298 4299 Use g_idle_add() whenever g_timeout_add() was being used. 4300 4301 This is desired because it's better to rely on the main loop to 4302 decide when it's a good moment to execute the task (when idle) 4303 than manually setting a timeout, which also sets a minimum amount 4304 of time needed to get the function executed. 4305 4306 * tests/testatk.c: 4307 (testWekitAtkTextSelections): 4308 (testWebkitAtkGetExtents): 4309 (testWebkitAtkListsOfItems): 4310 (main): 4311 43122010-09-22 Mario Sanchez Prada <msanchez@igalia.com> 4313 4314 Reviewed by Martin Robinson. 4315 4316 [Gtk] object:text-changed events should be emitted for entries and password text 4317 https://bugs.webkit.org/show_bug.cgi?id=25898 4318 4319 New unit test to make sure text-changed signals are emitted 4320 4321 * tests/testatk.c: 4322 (textChangedCb): New. Signal handler for the 4323 text-changed::insert and text-changed::delete signals. 4324 (checkTextChangesAndBailOut): New. Source function to check 4325 the global result of the test and quit from the main loop. 4326 (testWebkitAtkTextChangedNotifications): New test. 4327 (main): 4328 43292010-09-22 Martin Robinson <mrobinson@igalia.com> 4330 4331 Reviewed by Xan Lopez. 4332 4333 Added information about drop shadow improvements to the NEWS file. 4334 4335 * NEWS: Added information about drop shadow improvements. 4336 43372010-09-21 Xan Lopez <xlopez@igalia.com> 4338 4339 Reviewed by Martin Robinson. 4340 4341 [GTK] Fix transfer annotations for WebKitGTK+ static API 4342 https://bugs.webkit.org/show_bug.cgi?id=46244 4343 4344 Deal with all the warnings related to transfer issues. Mostly the 4345 problem was the transfer being missing, but there were also typos 4346 in the function name or missing ':' at the end of the function 4347 name in the gtk-doc. 4348 4349 * webkit/webkitdownload.cpp: 4350 * webkit/webkitnetworkrequest.cpp: 4351 * webkit/webkitnetworkresponse.cpp: 4352 * webkit/webkitsecurityorigin.cpp: 4353 * webkit/webkitwebdatabase.cpp: 4354 * webkit/webkitwebdatasource.cpp: 4355 * webkit/webkitwebframe.cpp: 4356 * webkit/webkitwebhistoryitem.cpp: 4357 * webkit/webkitwebinspector.cpp: 4358 * webkit/webkitwebresource.cpp: 4359 * webkit/webkitwebsettings.cpp: 4360 * webkit/webkitwebview.cpp: 4361 (webkit_web_view_class_init): 4362 (webkit_web_view_get_main_frame): 4363 43642010-09-21 Xan Lopez <xlopez@igalia.com> 4365 4366 Reviewed by Gustavo Noronha. 4367 4368 Update for 1.3.4 release. 4369 4370 * NEWS: 4371 43722010-09-17 Darin Adler <darin@apple.com> 4373 4374 Reviewed by Sam Weinig. 4375 4376 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload 4377 https://bugs.webkit.org/show_bug.cgi?id=42863 4378 4379 * webkit/webkitwebview.cpp: 4380 (webkit_web_view_get_zoom_level): 4381 (webkit_web_view_apply_zoom_level): 4382 (webkit_web_view_set_full_content_zoom): 4383 Call functions on Frame instead of FrameView. 4384 43852010-09-16 Martin Robinson <mrobinson@igalia.com> 4386 4387 Reviewed by Xan Lopez. 4388 4389 [GTK] Implement dissolveDragImageToFraction 4390 https://bugs.webkit.org/show_bug.cgi?id=45826 4391 4392 To support full alpha in the drag icon, changed the drag icon to be a 4393 GtkWindow with an RGBA colormap. Added logic to support painting the drag 4394 image to this window during the expose event. 4395 4396 * WebCoreSupport/DragClientGtk.cpp: 4397 (WebKit::dragIconWindowExposeEventCallback): Added. 4398 (WebKit::DragClient::DragClient): Initialize the new drag icon window. 4399 (WebKit::DragClient::~DragClient): Disconnect the expose event signal. 4400 (WebKit::DragClient::startDrag): Resize the drag icon window the appropriate size and 4401 if necessary, set its colormap. 4402 (WebKit::DragClient::dragIconWindowExposeEvent): Added. 4403 * WebCoreSupport/DragClientGtk.h: Added new member and method declarations. 4404 44052010-09-14 Philippe Normand <pnormand@igalia.com> 4406 4407 Reviewed by Eric Carlson and Martin Robinson. 4408 4409 [GTK] eventSender.contextClick() should return the contents of the context menu 4410 https://bugs.webkit.org/show_bug.cgi?id=39102 4411 4412 New private WebView API to retrieve the context-menu widget. This 4413 is used by DRT only. 4414 4415 * webkit/webkitprivate.h: 4416 * webkit/webkitwebview.cpp: 4417 (webkit_web_view_get_context_menu): 4418 44192010-09-16 Alejandro G. Castro <alex@igalia.com> 4420 4421 Reviewed by Xan Lopez. 4422 4423 GTK+ 3.x. updates, gtk_widget_size_request is deprecated and 4424 "activate-slider" style property for scrollbars is gone. 4425 4426 * webkit/webkitwebview.cpp: 4427 (PopupMenuPositionFunc): 4428 44292010-09-15 Martin Robinson <mrobinson@igalia.com> 4430 4431 Reviewed by David Levin. 4432 4433 [GTK] [REGRESSION] r67591 broke the testwebbackforwardlist API test and introduced a memory leak 4434 https://bugs.webkit.org/show_bug.cgi?id=45865 4435 4436 When initializing the backForwardList private member of the WebView, do 4437 so with adoptPlatformRef to prevent a memory leak. 4438 4439 * webkit/webkitwebview.cpp: 4440 (webkit_web_view_init): Initialize member with adoptPlatformRef. 4441 44422010-09-15 Martin Robinson <mrobinson@igalia.com> 4443 4444 Reviewed by Eric Seidel. 4445 4446 [Gtk] Use GOwnPtr for code that needs it 4447 https://bugs.webkit.org/show_bug.cgi?id=21594 4448 4449 Convert as reference counted private members of WebKitWebView to 4450 smart pointers as possible. This removes a lot of unecessary manual 4451 memory management. Also convert some pointer members away from pointer 4452 types, now that we are sure their destructors are called. 4453 4454 * WebCoreSupport/ContextMenuClientGtk.cpp: 4455 (WebKit::inputMethodsMenuItem): Updated to reflect PlatformRefPtr changes. 4456 * WebCoreSupport/DragClientGtk.cpp: 4457 (WebKit::DragClient::startDrag): Ditto. 4458 * WebCoreSupport/EditorClientGtk.cpp: 4459 (WebKit::EditorClient::setInputMethodState): Ditto. 4460 (WebKit::EditorClient::respondToChangedSelection): Ditto. 4461 (WebKit::EditorClient::handleInputMethodKeydown): Ditto. 4462 (WebKit::EditorClient::handleInputMethodMousePress): Ditto. 4463 (WebKit::EditorClient::EditorClient): Ditto. 4464 (WebKit::EditorClient::~EditorClient): Ditto. 4465 * WebCoreSupport/FrameLoaderClientGtk.cpp: 4466 (WebKit::postCommitFrameViewSetup): Ditto. 4467 * webkit/webkitprivate.h: Ditto. 4468 * webkit/webkitwebview.cpp: Ditto. 4469 (destroy_menu_cb): Ditto. 4470 (webkit_web_view_forward_context_menu_event): Ditto. 4471 (webkit_web_view_key_release_event): Ditto. 4472 (webkit_web_view_button_press_event): Ditto. 4473 (webkit_web_view_button_release_event): Ditto. 4474 (webkit_web_view_focus_in_event): Ditto. 4475 (webkit_web_view_focus_out_event): Ditto. 4476 (webkit_web_view_realize): Ditto. 4477 (webkit_web_view_set_scroll_adjustments): Ditto. 4478 (webkit_web_view_dispose): Changed all g_object_unref calls to 4479 PlatformRefPtr.clear(). Although this will also be done by the manual 4480 call to the WebKitWebViewPrivate destructor, the order that these 4481 fields are zero'd in is still very sensitive. 4482 (webkit_web_view_finalize): Updated to reflect PlatformRefPtr changes. 4483 (webViewGetDPI): Ditto. 4484 (webkit_web_view_screen_changed): Ditto. 4485 (webkit_web_view_drag_end): Ditto. 4486 (webkit_web_view_drag_data_get): Ditto. 4487 (doDragLeaveLater): Ditto. 4488 (webkit_web_view_drag_leave): Ditto. 4489 (webkit_web_view_drag_motion): Ditto. 4490 (webkit_web_view_drag_data_received): Ditto. 4491 (webkit_web_view_drag_drop): Ditto. 4492 (webkit_web_view_get_im_context): Ditto. 4493 (webkit_web_view_update_settings): Ditto. 4494 (webkit_web_view_init): Ditto. 4495 (webkit_web_view_set_settings): Ditto. 4496 (webkit_web_view_get_settings): Ditto. 4497 (webkit_web_view_get_inspector): Ditto. 4498 (webkit_web_view_set_window_features): Ditto. 4499 (webkit_web_view_get_window_features): Ditto. 4500 (webkit_web_view_get_back_forward_list): Ditto. 4501 (webkit_web_view_zoom_in): Ditto. 4502 (webkit_web_view_zoom_out): Ditto. 4503 (webkit_web_view_add_resource): Ditto. 4504 (webkit_web_view_get_resource): Ditto. 4505 (webkit_web_view_get_main_resource): Ditto. 4506 (webkit_web_view_clear_resources): Ditto. 4507 (webkit_web_view_get_subresources): Ditto. 4508 45092010-09-14 Martin Robinson <mrobinson@igalia.com> 4510 4511 Reviewed by Xan Lopez. 4512 4513 [GTK] fast/events/keydown-numpad-keys.html produces many GLib warnings 4514 https://bugs.webkit.org/show_bug.cgi?id=45775 4515 4516 Handle the toggle-overwrite signal on the GtkTextView used for generating editing 4517 commands. Ignore this signals, as the default handler assumes that the GtkTextView 4518 has a layout and this one does not. 4519 4520 * WebCoreSupport/EditorClientGtk.cpp: 4521 (WebKit::toggleOverwriteCallback): Added. Cancels the default handler. 4522 (WebKit::EditorClient::EditorClient): Attach a handler for toggle-overwrite. 4523 45242010-09-14 Pavel Feldman <pfeldman@chromium.org> 4525 4526 Reviewed by Yury Semikhatsky. 4527 4528 Web Inspector: Provide network-based load timing. 4529 Before this change, inspector used timers taken from 4530 within WebCore notifications (that are by definition 4531 synchronous and serialized). As a result, timing was 4532 affected by the routines running on the main thread 4533 (JavaScript and such). 4534 https://bugs.webkit.org/show_bug.cgi?id=45664 4535 4536 * webkit/webkitdownload.cpp: 4537 (DownloadClient::didFinishLoading): 4538 45392010-09-15 Sheriff Bot <webkit.review.bot@gmail.com> 4540 4541 Unreviewed, rolling out r67551. 4542 http://trac.webkit.org/changeset/67551 4543 https://bugs.webkit.org/show_bug.cgi?id=45816 4544 4545 "Plugin tests fail" (Requested by yurys on #webkit). 4546 4547 * webkit/webkitdownload.cpp: 4548 (DownloadClient::didFinishLoading): 4549 45502010-09-14 Pavel Feldman <pfeldman@chromium.org> 4551 4552 Reviewed by Yury Semikhatsky. 4553 4554 Web Inspector: Provide network-based load timing. 4555 Before this change, inspector used timers taken from 4556 within WebCore notifications (that are by definition 4557 synchronous and serialized). As a result, timing was 4558 affected by the routines running on the main thread 4559 (JavaScript and such). 4560 https://bugs.webkit.org/show_bug.cgi?id=45664 4561 4562 * webkit/webkitdownload.cpp: 4563 (DownloadClient::didFinishLoading): 4564 45652010-09-13 Enrica Casucci <enrica@apple.com> 4566 4567 Reviewed by Sam Weinig. 4568 4569 Paste should be implemented in WebCore like Copy and Cut for Mac also. 4570 https://bugs.webkit.org/show_bug.cgi?id=45494 4571 <rdar://problem/7660537> 4572 4573 On the Mac platform, the implementation of the paste operation is all done 4574 at the WebKit level. In order to support it on WebKit2 it is necessary to 4575 refactor the code and move this functionality at the level of WebCore like 4576 we already have on Windows. 4577 The original code relies on some in AppKit functions that call back into 4578 WebKit causing problems in WebKit2. All this functionality has been moved 4579 at the level of the editor client where it can be dealt with appropriately. 4580 4581 * WebCoreSupport/FrameLoaderClientGtk.cpp: 4582 (WebKit::FrameLoaderClient::canShowMIMETypeAsHTML): Added stub. 4583 * WebCoreSupport/FrameLoaderClientGtk.h: 4584 45852010-09-13 Mario Sanchez Prada <msanchez@igalia.com> 4586 4587 Reviewed by Martin Robinson. 4588 4589 [GTK] Provide unit tests for AtkText's text selection functions 4590 https://bugs.webkit.org/show_bug.cgi?id=43919 4591 4592 New tests to check getting, setting and removing text selections 4593 4594 * tests/testatk.c: 4595 (testWekitAtkTextSelections): New unit tests to check all the text 4596 selection related functions altogether through a single test 4597 function. 4598 (main): 4599 4600 Make sure that code dependant on getting information from the 4601 clipboard gets executed only when there's a GDK window associated 4602 to the webview widget, as that's not the case when executing the 4603 unit tests (the wedbview is not inside of any toplevel window) and 4604 will make the tests crash if not taken into account. 4605 4606 * WebCoreSupport/EditorClientGtk.cpp: 4607 (WebKit::EditorClient::respondToChangedSelection): 4608 46092010-09-11 Xan Lopez <xlopez@igalia.com> 4610 4611 Reviewed by Martin Robinson. 4612 4613 [GTK] Make introspection work with g-o-i 0.9.5 4614 https://bugs.webkit.org/show_bug.cgi?id=45590 4615 4616 Use new type syntax and bump version number of the gir file. 4617 4618 * JSCore.gir.in: 4619 46202010-09-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 4621 4622 Reviewed by Darin Adler. 4623 4624 Add NetworkingContext to avoid layer violations 4625 https://bugs.webkit.org/show_bug.cgi?id=42292 4626 4627 * webkit/webkitdownload.cpp: 4628 (webkit_download_start): 4629 * webkit/webkitprivate.cpp: 4630 (currentToplevelCallback): 4631 46322010-09-10 Sam Weinig <sam@webkit.org> 4633 4634 Fix GTK build. 4635 4636 * webkit/webkitwebview.cpp: 4637 (webkit_web_view_set_full_content_zoom): 4638 46392010-09-10 Sam Weinig <sam@webkit.org> 4640 4641 Reviewed by Darin Adler. 4642 4643 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom. 4644 Precursor to <rdar://problem/7660657> 4645 https://bugs.webkit.org/show_bug.cgi?id=45522 4646 4647 * webkit/webkitwebview.cpp: 4648 (webkit_web_view_get_zoom_level): 4649 (webkit_web_view_apply_zoom_level): 4650 (webkit_web_view_set_full_content_zoom): 4651 46522010-09-10 Mario Sanchez Prada <msanchez@igalia.com> 4653 4654 Reviewed by Gustavo Noronha Silva. 4655 4656 [GTK] Fix warnings because of bad assignments in testatk.c 4657 https://bugs.webkit.org/show_bug.cgi?id=45538 4658 4659 Use AtkObject and AtkText instances properly in the code. 4660 4661 * tests/testatk.c: 4662 (testWebkitAtkListsOfItems): 4663 46642010-09-10 Adam Barth <abarth@webkit.org> 4665 4666 Reviewed by Darin Fisher. 4667 4668 Move code from WebKit-layer to DocumentLoader 4669 https://bugs.webkit.org/show_bug.cgi?id=45569 4670 4671 * WebCoreSupport/FrameLoaderClientGtk.cpp: 4672 (WebKit::FrameLoaderClient::committedLoad): 4673 46742010-09-10 Adam Barth <abarth@webkit.org> 4675 4676 Reviewed by Eric Seidel. 4677 4678 Main resource bytes shouldn't bounce through FrameLoader 4679 https://bugs.webkit.org/show_bug.cgi?id=45496 4680 4681 Now return the bytes to the DocumentLoader. 4682 4683 * WebCoreSupport/FrameLoaderClientGtk.cpp: 4684 (WebKit::FrameLoaderClient::committedLoad): 4685 46862010-09-10 Martin Robinson <mrobinson@igalia.com> 4687 4688 Reviewed by Xan Lopez. 4689 4690 [GTK] Placement new / manual destructor invocation should be used on private GObject memory 4691 https://bugs.webkit.org/show_bug.cgi?id=45550 4692 4693 GLib allocates and deallocates GObject private data structs itself. When 4694 those structs contain C++ members, their constructors and destructors are not 4695 called. This is not only dangerous, it makes RefPtr-type smart pointers much 4696 less useful. We can fix this problem by calling placement new on the private 4697 data struct during instance initialization and calling the destructor during 4698 finalization. 4699 4700 This patch takes that approach and switches plain char* members of 4701 WebKitWebView (with manual memory allocation) to use CString. 4702 4703 * webkit/webkitprivate.h: Switch char* members to CString. 4704 * webkit/webkitwebview.cpp: 4705 (webkit_web_view_finalize): Manually call the destructor on the private 4706 data. Remove manual deallocation of members which are now CString. 4707 (webkit_web_view_query_tooltip): Update to reflect CString change. 4708 (webkit_web_view_init): Use placement new to initialize C++ members of 4709 the private data section. 4710 (webkit_web_view_get_encoding): Update to reflect CString change. 4711 (webkit_web_view_get_custom_encoding): Ditto. 4712 (webkit_web_view_add_resource): Ditto. 4713 (webkit_web_view_get_resource): Ditto. 4714 (webkit_web_view_clear_resources): Ditto. 4715 (webkit_web_view_set_tooltip_text): Ditto. 4716 (webkit_web_view_get_icon_uri): Ditto. 4717 47182010-09-10 Gustavo Noronha Silva <gns@gnome.org> 4719 4720 Reviewed by Martin Robinson. 4721 4722 [GTK] Google sites do not like WebKitGTK+ 4723 https://bugs.webkit.org/show_bug.cgi?id=39617 4724 4725 Special-case Google domains, and spoof User-Agent when talking to 4726 them, to stop being treated as a second-class citizen. 4727 4728 * WebCoreSupport/FrameLoaderClientGtk.cpp: 4729 (WebKit::initializeDomainsList): 4730 (WebKit::isGoogleDomain): 4731 (WebKit::FrameLoaderClient::userAgent): If enable-site-specific-quirks 4732 is enabled, send the standard WebKit User-Agent string, disregarding the 4733 custom one set by the browser for Google domains. 4734 * webkit/webkitprivate.h: 4735 * webkit/webkitwebsettings.cpp: 4736 (webkitPlatform): Fix style, and simplify. 4737 (webkitOSVersion): Ditto. 4738 (webkitUserAgent): Add the Version/x.y string Safari has been 4739 using since Safari 2.2. 4740 47412010-09-10 Xan Lopez <xlopez@igalia.com> 4742 4743 Reviewed by Martin Robinson. 4744 4745 Fix compilation with GTK+ 3.x. 4746 4747 GDK key macros were renamed from GDK_FOO to GDK_KEY_FOO, we need 4748 to include the compat header provided if we want to keep using the 4749 old names. 4750 4751 * WebCoreSupport/FullscreenVideoController.cpp: include GtkVersioning.h 4752 47532010-09-08 Darin Adler <darin@apple.com> 4754 4755 Reviewed by Adam Barth. 4756 4757 Move functions from Frame to Editor as planned 4758 https://bugs.webkit.org/show_bug.cgi?id=45218 4759 4760 * webkit/webkitwebview.cpp: 4761 (webkit_web_view_set_highlight_text_matches): 4762 (webkit_web_view_get_selected_text): 4763 (webkit_web_view_set_editable): 4764 Changed call sites to use editor(). 4765 47662010-09-09 Philippe Normand <pnormand@igalia.com> 4767 4768 Reviewed by Martin Robinson. 4769 4770 [GTK] testmimehandling falsely succeeds testing Ogg mime type 4771 https://bugs.webkit.org/show_bug.cgi?id=45349 4772 4773 Make this actually test an ogg file request instead of pdf and 4774 changed the expected result to match libsoup content-sniffing 4775 result in the case of ogg/vorbis file. 4776 4777 * tests/testmimehandling.c: 4778 (mime_type_policy_decision_requested_cb): 4779 (test_mime_ogg): 4780 47812010-09-08 Mario Sanchez Prada <msanchez@igalia.com> 4782 4783 Reviewed by Martin Robinson. 4784 4785 [Gtk] A list item's number/bullet should not be a child of that list item 4786 https://bugs.webkit.org/show_bug.cgi?id=45190 4787 4788 New unit test added. 4789 4790 * tests/testatk.c: 4791 (testWebkitAtkListsOfItems): New test to check ordered/unordered 4792 list of items are properly exposed to AT technologies. 4793 (main): 4794 47952010-09-07 Martin Robinson <mrobinson@igalia.com> 4796 4797 Reviewed by Xan Lopez. 4798 4799 [GTK] Fix some feature guards 4800 https://bugs.webkit.org/show_bug.cgi?id=45302 4801 4802 * webkit/webkitprivate.h: Add ENABLE(VIDEO) guards for video specific members. 4803 48042010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 4805 4806 Reviewed by Darin Adler. 4807 4808 Add NetworkingContext to avoid layer violations 4809 https://bugs.webkit.org/show_bug.cgi?id=42292 4810 4811 Add GTK's specific implementation of FrameNetworkingContext. 4812 4813 * WebCoreSupport/FrameLoaderClientGtk.cpp: 4814 (WebKit::FrameLoaderClient::createNetworkingContext): 4815 * WebCoreSupport/FrameLoaderClientGtk.h: 4816 48172010-09-03 Xan Lopez <xlopez@igalia.com> 4818 4819 Reviewed by Gustavo Noronha. 4820 4821 Dialog separators are gone in GTK+ 3.x. 4822 4823 * webkit/webkitsoupauthdialog.c: 4824 (show_auth_dialog): 4825 48262010-09-02 Yury Semikhatsky <yurys@chromium.org> 4827 4828 Reviewed by Pavel Feldman. 4829 4830 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 4831 https://bugs.webkit.org/show_bug.cgi?id=44230 4832 4833 * WebCoreSupport/InspectorClientGtk.cpp: 4834 (WebKit::notifyWebViewDestroyed): 4835 (WebKit::InspectorFrontendClient::destroyInspectorWindow): 4836 (WebKit::InspectorFrontendClient::closeWindow): 4837 (WebKit::InspectorFrontendClient::disconnectFromBackend): 4838 * WebCoreSupport/InspectorClientGtk.h: 4839 48402010-08-31 Dave Hyatt <hyatt@apple.com> 4841 4842 Reviewed by Sam Weinig. 4843 4844 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that 4845 the former can occur in more places without having to do the latter. 4846 4847 * webkit/webkitwebview.cpp: 4848 (webkit_web_view_expose_event): 4849 48502010-08-31 Martin Robinson <mrobinson@igalia.com> 4851 4852 Reviewed by Gustavo Noronha Silva. 4853 4854 [GTK] Isolate all GTK+ typedefs into one file 4855 https://bugs.webkit.org/show_bug.cgi?id=44900 4856 4857 * WebCoreSupport/EditorClientGtk.h: Remove GTK+ typedefs. 4858 * WebCoreSupport/FullscreenVideoController.h: Ditto. 4859 48602010-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 4861 4862 Reviewed by Martin Robinson. 4863 4864 Preparations for the 1.3.4 release. 4865 4866 * NEWS: 4867 * docs/webkitgtk-docs.sgml: 4868 48692010-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 4870 4871 Unreviewed. Minor documentation typo fix. 4872 4873 * webkit/webkitwebview.cpp: 4874 48752010-08-30 Alejandro G. Castro <alex@igalia.com> 4876 4877 Reviewed by Martin Robinson. 4878 4879 [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer 4880 are deprecated 4881 https://bugs.webkit.org/show_bug.cgi?id=44787 4882 4883 We have replaced GtkVersioning.cpp with GtkVersioning.c and 4884 created a function (getDefaultGDKPointerDevice) to get the pointer 4885 of the window with the new APIs. We added that function to DRT and 4886 copyandpaste unit test. 4887 4888 * tests/testcopyandpaste.c: 4889 (runPasteTestCallback): 4890 48912010-08-30 Sheriff Bot <webkit.review.bot@gmail.com> 4892 4893 Unreviewed, rolling out r66198. 4894 http://trac.webkit.org/changeset/66198 4895 https://bugs.webkit.org/show_bug.cgi?id=44856 4896 4897 It made tests crash on Qt bot (Requested by Ossy_ on #webkit). 4898 4899 * WebCoreSupport/InspectorClientGtk.cpp: 4900 (WebKit::notifyWebViewDestroyed): 4901 (WebKit::InspectorFrontendClient::destroyInspectorWindow): 4902 (WebKit::InspectorFrontendClient::closeWindow): 4903 * WebCoreSupport/InspectorClientGtk.h: 4904 49052010-08-27 Yury Semikhatsky <yurys@chromium.org> 4906 4907 Reviewed by Pavel Feldman. 4908 4909 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 4910 https://bugs.webkit.org/show_bug.cgi?id=44230 4911 4912 * WebCoreSupport/InspectorClientGtk.cpp: 4913 (WebKit::notifyWebViewDestroyed): 4914 (WebKit::InspectorFrontendClient::destroyInspectorWindow): 4915 (WebKit::InspectorFrontendClient::closeWindow): 4916 (WebKit::InspectorFrontendClient::disconnectFromBackend): 4917 * WebCoreSupport/InspectorClientGtk.h: 4918 49192010-08-26 Yury Semikhatsky <yurys@chromium.org> 4920 4921 Unreviewed. Revert r66103 since Qt tests are failing. 4922 4923 * WebCoreSupport/InspectorClientGtk.cpp: 4924 (WebKit::notifyWebViewDestroyed): 4925 (WebKit::InspectorFrontendClient::destroyInspectorWindow): 4926 (WebKit::InspectorFrontendClient::closeWindow): 4927 * WebCoreSupport/InspectorClientGtk.h: 4928 49292010-08-26 Yury Semikhatsky <yurys@chromium.org> 4930 4931 Reviewed by Pavel Feldman. 4932 4933 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector 4934 https://bugs.webkit.org/show_bug.cgi?id=44230 4935 4936 * WebCoreSupport/InspectorClientGtk.cpp: 4937 (WebKit::notifyWebViewDestroyed): 4938 (WebKit::InspectorFrontendClient::destroyInspectorWindow): 4939 (WebKit::InspectorFrontendClient::closeWindow): 4940 (WebKit::InspectorFrontendClient::disconnectFromBackend): 4941 * WebCoreSupport/InspectorClientGtk.h: 4942 49432010-08-26 Gustavo Noronha Silva <gns@gnome.org> 4944 4945 Reviewed by Martin Robinson. 4946 4947 [GTK] WebKitGTK+ needs proper introspection annotation for most types and methods 4948 https://bugs.webkit.org/show_bug.cgi?id=44565 4949 4950 Add documentation and introspection specific information to a few 4951 getter and setter methods. 4952 4953 * webkit/webkitwebview.cpp: 4954 49552010-08-25 Martin Robinson <mrobinson@igalia.com> 4956 4957 Reviewed by Gustavo Noronha Silva. 4958 4959 confirm dialog should show OK/Cancel instead of Yes/No for consistency 4960 https://bugs.webkit.org/show_bug.cgi?id=32877 4961 4962 Change the button labels for the fallback confirmation dialog to be 4963 OK and Cancel. 4964 4965 * webkit/webkitwebview.cpp: 4966 (webkit_web_view_script_dialog): 4967 49682010-08-25 Martin Robinson <mrobinson@igalia.com> 4969 4970 Reviewed by Gustavo Noronha Silva. 4971 4972 Cairo and EFL port shouldn't depend on glib. 4973 https://bugs.webkit.org/show_bug.cgi?id=44354 4974 4975 Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and 4976 adoptPlatformRef. 4977 4978 * WebCoreSupport/ChromeClientGtk.cpp: 4979 (WebKit::ChromeClient::requestGeolocationPermissionForFrame): 4980 * WebCoreSupport/DragClientGtk.cpp: 4981 (WebKit::DragClient::startDrag): 4982 * WebCoreSupport/EditorClientGtk.h: 4983 * WebCoreSupport/FrameLoaderClientGtk.cpp: 4984 (WebKit::FrameLoaderClient::dispatchWillSendRequest): 4985 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): 4986 (WebKit::FrameLoaderClient::createPlugin): 4987 * WebCoreSupport/FullscreenVideoController.h: 4988 * WebCoreSupport/InspectorClientGtk.cpp: 4989 (WebKit::InspectorClient::populateSetting): 4990 (WebKit::InspectorClient::storeSetting): 4991 * webkit/webkitdownload.cpp: 4992 (webkit_download_error): 4993 * webkit/webkitnetworkrequest.cpp: 4994 (webkit_network_request_new_with_core_request): 4995 * webkit/webkitnetworkresponse.cpp: 4996 (webkit_network_response_new_with_core_response): 4997 49982010-08-24 Xan Lopez <xlopez@igalia.com> 4999 5000 Reviewed by Martin Robinson. 5001 5002 Set a device to the event struct when building with GTK+ 3.x, it's 5003 mandatory. 5004 5005 * tests/testcopyandpaste.c: 5006 (runPasteTestCallback): 5007 50082010-08-24 Martin Robinson <mrobinson@igalia.com> 5009 5010 Build fix for GTK+. 5011 5012 * tests/testkeyevents.c: 5013 (key_press_event_cb): 5014 (key_release_event_cb): 5015 50162010-08-24 Martin Robinson <mrobinson@igalia.com> 5017 5018 Reviewed by Xan Lopez. 5019 5020 [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events 5021 https://bugs.webkit.org/show_bug.cgi?id=44534 5022 5023 Fix an issue where a GdkEvent* is treated like a GdkEvent. 5024 5025 * tests/testkeyevents.c: 5026 (key_press_event_cb): 5027 (key_release_event_cb): 5028 50292010-08-24 Martin Robinson <mrobinson@igalia.com> 5030 5031 Reviewed by Xan Lopez. 5032 5033 [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events 5034 https://bugs.webkit.org/show_bug.cgi?id=44534 5035 5036 * tests/testcopyandpaste.c: 5037 (runPasteTestCallback): Switch to using gdk_event_new and also reference the GdkWindow. 5038 when setting it on the event. It is dereferenced by gdk_event_free(...). 5039 * tests/testhittestresult.c: 5040 (load_status_cb): Switch to using gdk_event_new. 5041 50422010-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5043 5044 Rubber-stamped by Xan Lopez. 5045 5046 Do not initialize the GSettings object in webkit_init - the other 5047 call sites are always called in the main thread so this is 5048 unnecessary. 5049 5050 * webkit/webkitprivate.cpp: 5051 (webkit_init): 5052 50532010-08-20 Martin Robinson <mrobinson@igalia.com> 5054 5055 Reviewed by Pavel Feldman. 5056 5057 Web Inspector: Inspector tests were disabled for GTK. 5058 https://bugs.webkit.org/show_bug.cgi?id=43977 5059 5060 Allow setting the inspector resources path via an environment variables 5061 and add a method, inspectorFilesPath, to the WebKit InspectorClient that 5062 encapsulates this logic. 5063 5064 * WebCoreSupport/InspectorClientGtk.cpp: 5065 (WebKit::InspectorClient::openInspectorFrontend): Use the new inspectorFilesPath method to 5066 get the path to the resource. 5067 (WebKit::InspectorClient::inspectorFilesPath): Added. 5068 (WebKit::InspectorFrontendClient::localizedStringsURL): Use inspectorFilesPath method. 5069 * WebCoreSupport/InspectorClientGtk.h: Add method and member variables for caching the result. 5070 50712010-08-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5072 5073 Reviewed by Kenneth Rohde Christiansen. 5074 5075 [Gtk] Enable view mode media feature layout test 5076 https://bugs.webkit.org/show_bug.cgi?id=43278 5077 5078 Add the view-mode property, to control the WebCore page's viewMode. 5079 5080 * docs/webkitgtk-sections.txt: 5081 * webkit/webkitwebview.cpp: 5082 (webkit_web_view_get_property): 5083 (webkit_web_view_set_property): 5084 (webkit_web_view_class_init): 5085 (webkit_web_view_set_view_mode): 5086 (webkit_web_view_get_view_mode): 5087 * webkit/webkitwebview.h: 5088 50892010-08-19 Philippe Normand <pnormand@igalia.com> 5090 5091 Reviewed by Gustavo Noronha Silva. 5092 5093 [GStreamer] GTK XOverlay support in GStreamerGWorld 5094 https://bugs.webkit.org/show_bug.cgi?id=39474 5095 5096 New FullscreenVideoController object, private in the webview. It 5097 is created when the user presses the fullscreen button of the 5098 video controls. Video is displayed in fullscreen, controls are 5099 displayed when the user moves the mouse and when the video is 5100 paused. There's also basic keyboard shortcuts support: F/f to 5101 leave fullscreen, space to toggle play/pause and up/down to 5102 control volume. 5103 5104 * WebCoreSupport/ChromeClientGtk.cpp: 5105 (WebKit::ChromeClient::supportsFullscreenForNode): 5106 (WebKit::ChromeClient::enterFullscreenForNode): 5107 (WebKit::ChromeClient::exitFullscreenForNode): 5108 * WebCoreSupport/ChromeClientGtk.h: 5109 * WebCoreSupport/FullscreenVideoController.cpp: Added. 5110 (hideHudCallback): 5111 (onFullscreenGtkMotionNotifyEvent): 5112 (onFullscreenGtkActiveNotification): 5113 (onFullscreenGtkConfigureEvent): 5114 (onFullscreenGtkDestroy): 5115 (togglePlayPauseActivated): 5116 (exitFullscreenActivated): 5117 (progressBarUpdateCallback): 5118 (timeScaleButtonPressed): 5119 (timeScaleButtonReleased): 5120 (timeScaleValueChanged): 5121 (volumeValueChanged): 5122 (playerVolumeChangedCallback): 5123 (playerMuteChangedCallback): 5124 (FullscreenVideoController::FullscreenVideoController): 5125 (FullscreenVideoController::~FullscreenVideoController): 5126 (FullscreenVideoController::setMediaElement): 5127 (FullscreenVideoController::gtkConfigure): 5128 (FullscreenVideoController::showHud): 5129 (FullscreenVideoController::hideHud): 5130 (onFullscreenGtkKeyPressEvent): 5131 (FullscreenVideoController::enterFullscreen): 5132 (FullscreenVideoController::updateHudPosition): 5133 (FullscreenVideoController::exitOnUserRequest): 5134 (FullscreenVideoController::exitFullscreen): 5135 (FullscreenVideoController::canPlay): 5136 (FullscreenVideoController::play): 5137 (FullscreenVideoController::pause): 5138 (FullscreenVideoController::playStateChanged): 5139 (FullscreenVideoController::togglePlay): 5140 (FullscreenVideoController::volume): 5141 (FullscreenVideoController::muted): 5142 (FullscreenVideoController::setVolume): 5143 (FullscreenVideoController::volumeChanged): 5144 (FullscreenVideoController::muteChanged): 5145 (FullscreenVideoController::currentTime): 5146 (FullscreenVideoController::setCurrentTime): 5147 (FullscreenVideoController::duration): 5148 (FullscreenVideoController::percentLoaded): 5149 (FullscreenVideoController::beginSeek): 5150 (FullscreenVideoController::doSeek): 5151 (FullscreenVideoController::endSeek): 5152 (timeToString): 5153 (FullscreenVideoController::updateHudProgressBar): 5154 (FullscreenVideoController::createHud): 5155 * WebCoreSupport/FullscreenVideoController.h: Added. 5156 (FullscreenVideoController::mediaElement): 5157 * webkit/webkitprivate.cpp: 5158 (webkit_web_view_enter_fullscreen): 5159 (webkit_web_view_exit_fullscreen): 5160 * webkit/webkitprivate.h: 5161 51622010-08-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5163 5164 Reviewed by Martin Robinson. 5165 5166 [GTK] WebBackForwardList's new_with_web_view should not be public 5167 https://bugs.webkit.org/show_bug.cgi?id=43802 5168 5169 Deprecate the constructor. The introspection annotation has been 5170 fixed in a previous commit. 5171 5172 * webkit/webkitwebbackforwardlist.cpp: 5173 51742010-08-17 Ilya Tikhonovsky <loislo@chromium.org> 5175 5176 Reviewed by Yury Semikhatsky. 5177 5178 Web Inspector: replace hand written InspectorBackendStub.js with generated one. 5179 https://bugs.webkit.org/show_bug.cgi?id=43791 5180 5181 * WebCoreSupport/InspectorClientGtk.cpp: 5182 (WebKit::InspectorClient::openInspectorFrontend): 5183 51842010-08-18 Sheriff Bot <webkit.review.bot@gmail.com> 5185 5186 Unreviewed, rolling out r65595. 5187 http://trac.webkit.org/changeset/65595 5188 https://bugs.webkit.org/show_bug.cgi?id=44161 5189 5190 qt build failed (Requested by loislo on #webkit). 5191 5192 * WebCoreSupport/InspectorClientGtk.cpp: 5193 (WebKit::InspectorClient::openInspectorFrontend): 5194 51952010-08-17 Ilya Tikhonovsky <loislo@chromium.org> 5196 5197 Reviewed by Yury Semikhatsky. 5198 5199 Web Inspector: replace hand written InspectorBackendStub.js by generated one. 5200 https://bugs.webkit.org/show_bug.cgi?id=43791 5201 5202 * WebCoreSupport/InspectorClientGtk.cpp: 5203 (WebKit::InspectorClient::openInspectorFrontend): 5204 52052010-08-17 Xan Lopez <xlopez@igalia.com> 5206 5207 Reviewed by Gustavo Noronha. 5208 5209 Fix the builds when HAVE_GSETTINGS is defined. 5210 5211 * webkit/webkitprivate.cpp: 5212 (isSchemaAvailable): 5213 (inspectorGSettings): 5214 52152010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> 5216 5217 Reviewed by Darin Adler. 5218 5219 Add NetworkingContext to avoid layer violations 5220 https://bugs.webkit.org/show_bug.cgi?id=42292 5221 5222 Preparation: Just add the files to the build system. 5223 5224 * WebCoreSupport/FrameNetworkingContextGtk.h: Added. 5225 Placeholder with tentative code that might be changed when landing 5226 the rest of it. 5227 52282010-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5229 5230 Reviewed by Martin Robinson. 5231 5232 WebBackForwardList.get_{back|forward}_list_with_limit not introspectable 5233 https://bugs.webkit.org/show_bug.cgi?id=43054 5234 5235 Annotate WebKitWebBackForwardList and the function that is used to fetch it from 5236 the WebKitWebView. More will follow. 5237 5238 * webkit/webkitwebbackforwardlist.cpp: Annotations, and small 5239 improvements to the docs. 5240 * webkit/webkitwebbackforwardlist.h: Couple empty lines missing. 5241 * webkit/webkitwebview.cpp: 5242 52432010-08-17 Martin Robinson <mrobinson@igalia.com> 5244 5245 Reviewed by Gustavo Noronha Silva. 5246 5247 [GTK] Clean up WebCore/platform/graphics/gtk/ImageGtk.cpp 5248 https://bugs.webkit.org/show_bug.cgi?id=44069 5249 5250 * WebCoreSupport/InspectorClientGtk.cpp: 5251 (WebKit::InspectorClient::openInspectorFrontend): Switched to using the new WEBKITGTK_API_VERSION_STRING define. 5252 * webkit/webkitprivate.cpp: 5253 (inspectorGSettings): Ditto. 5254 52552010-08-17 Sheriff Bot <webkit.review.bot@gmail.com> 5256 5257 Unreviewed, rolling out r65500. 5258 http://trac.webkit.org/changeset/65500 5259 https://bugs.webkit.org/show_bug.cgi?id=44108 5260 5261 Qt bots failed to compile. (Requested by loislo on #webkit). 5262 5263 * WebCoreSupport/InspectorClientGtk.cpp: 5264 (WebKit::InspectorClient::openInspectorFrontend): 5265 52662010-08-17 Ilya Tikhonovsky <loislo@chromium.org> 5267 5268 Reviewed by Yury Semikhatsky. 5269 5270 Web Inspector: replace hand written InspectorBackendStub.js by generated one. 5271 https://bugs.webkit.org/show_bug.cgi?id=43791 5272 5273 * WebCoreSupport/InspectorClientGtk.cpp: 5274 (WebKit::InspectorClient::openInspectorFrontend): 5275 52762010-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5277 5278 Reviewed by Martin Robinson. 5279 5280 [GTK] GSettings support adds annoying warnings on systems with older glib versions 5281 https://bugs.webkit.org/show_bug.cgi?id=44056 5282 5283 Use #ifdef instead of #if for HAVE_GSETTINGS to avoid warnings 5284 when it is not defined. 5285 5286 * WebCoreSupport/InspectorClientGtk.cpp: 5287 * webkit/webkitprivate.cpp: 5288 (webkit_init): 5289 * webkit/webkitprivate.h: 5290 52912010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5292 5293 Really add a missing file. I wish I would remember running git add 5294 on them after applying a patch =(. 5295 5296 * org.webkitgtk.gschema.xml.in: Added. 5297 52982010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5299 5300 Reviewed by Martin Robinson. 5301 5302 [GTK] Use GSettings to save/restore Web Inspector settings 5303 https://bugs.webkit.org/show_bug.cgi?id=43512 5304 5305 Use GSettings to save/restore settings used by the Web Inspector. 5306 A few helper functions were added to have settings that use 5307 boolean values be actual booleans, and also to conform with the 5308 GSettings naming requirements for keys. 5309 5310 * WebCoreSupport/InspectorClientGtk.cpp: 5311 (WebKit::toGSettingName): 5312 (WebKit::truthStringFromVariant): 5313 (WebKit::variantFromTruthString): 5314 (WebKit::InspectorClient::populateSetting): 5315 (WebKit::InspectorClient::storeSetting): 5316 * org.webkit.gtk.gschema.xml: Added. 5317 * webkit/webkitprivate.cpp: 5318 (inspectorGSettings): 5319 (webkit_init): 5320 * webkit/webkitprivate.h: 5321 53222010-08-11 Joone Hur <joone@kldp.org> 5323 5324 Reviewed by Martin Robinson. 5325 5326 [GTK] Last Hangul letter is typed again when a composition is finished with mouse press 5327 https://bugs.webkit.org/show_bug.cgi?id=40518 5328 5329 When a mouse press fires during a IME composition, the current composition character 5330 can be entered twice at the previous editing position and a new editing position. 5331 Because the IME commit signal is emitted after the mouse press event. 5332 This patch allows to prevent the commit signal during a composition when a mouse press fires. 5333 5334 * WebCoreSupport/EditorClientGtk.cpp: 5335 (WebKit::imContextCommitted): 5336 (WebKit::EditorClient::handleInputMethodKeydown): Allow to accept the next composition commit. 5337 (WebKit::EditorClient::handleInputMethodMousePress): Added for handling IME when a mouse press fires. 5338 (WebKit::EditorClient::EditorClient): Initialize m_preventNextCompositionCommit 5339 * WebCoreSupport/EditorClientGtk.h: 5340 (WebKit::EditorClient::preventNextCompositionCommit): Added for checking whether skipping a commit. 5341 * webkit/webkitwebview.cpp: 5342 (webkit_web_view_button_press_event): Call handleInputMethodMousePress() 5343 53442010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5345 5346 Reviewed by Martin Robinson. 5347 5348 Small improvement to the documentation of the geolocation-policy-decision-requested 5349 signal, stating more clearly what is expected from the handler. 5350 5351 * webkit/webkitwebview.cpp: 5352 (webkit_web_view_class_init): 5353 53542010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5355 5356 Reviewed by Martin Robinson. 5357 5358 [GTK] Geolocation policy decision object leaking 5359 https://bugs.webkit.org/show_bug.cgi?id=43884 5360 5361 Use GRefPtr on the policy decision object to fix the leak. 5362 5363 * WebCoreSupport/ChromeClientGtk.cpp: 5364 (WebKit::ChromeClient::requestGeolocationPermissionForFrame): 5365 53662010-08-10 Chris Marrin <cmarrin@apple.com> 5367 5368 Reviewed by Oliver Hunt. 5369 5370 Add suspendAnimations/resumeAnimation API to DRT 5371 https://bugs.webkit.org/show_bug.cgi?id=43733 5372 5373 Gtk specific API. 5374 5375 * webkit/webkitprivate.h: 5376 * webkit/webkitwebframe.cpp: 5377 (webkit_web_frame_suspend_animations): 5378 (webkit_web_frame_resume_animations): 5379 53802010-08-10 Gavin Barraclough <barraclough@apple.com> 5381 5382 Rubber stamped by Sam Weinig. 5383 5384 Bug 43786 - Move AtomicStringHash from WebCore to WTF 5385 Also remove deprecated string headers from WebCore/platform/text. 5386 5387 * gdom/ConvertToGCharPrivate.h: 5388 53892010-08-06 Gavin Barraclough <barraclough@apple.com> 5390 5391 Rubber stamped by Sam Weinig 5392 5393 Bug 43594 - Add string forwards to Forward.h 5394 This allows us to remove forward declarations for these classes from 5395 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::). 5396 5397 * WebCoreSupport/InspectorClientGtk.h: 5398 53992010-08-09 Martin Robinson <mrobinson@igalia.com> 5400 5401 Reviewed by Xan Lopez. 5402 5403 [gtk] gtk_im_context_focus_in() should only be called when an input-able element has focus 5404 https://bugs.webkit.org/show_bug.cgi?id=43602 5405 5406 Only call gtk_im_context_focus_in() when we focus a frame which is currently in 5407 an editable node. 5408 5409 * webkit/webkitwebview.cpp: 5410 (webkit_web_view_focus_in_event): Conditionalize call to gtk_im_context_focus_in(). 5411 54122010-08-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5413 5414 Reviewed by Xan Lopez. 5415 5416 Use the new paths, and also fix the path for localizedStrings. 5417 5418 * WebCoreSupport/InspectorClientGtk.cpp: 5419 (WebKit::InspectorClient::openInspectorFrontend): 5420 (WebKit::InspectorFrontendClient::localizedStringsURL): 5421 54222010-08-06 Jessie Berlin <jberlin@apple.com> 5423 5424 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build. 5425 Unreviewed. 5426 5427 * WebCoreSupport/InspectorClientGtk.h: 5428 54292010-08-05 Xan Lopez <xlopez@igalia.com> 5430 5431 Reviewed by Gustavo Noronha. 5432 5433 [GTK] Use correct path for Inspector data files in GTK+3.x builds 5434 https://bugs.webkit.org/show_bug.cgi?id=43445 5435 5436 Use the right data path for inspector files when building with 5437 GTK+ 3.x. 5438 5439 * WebCoreSupport/InspectorClientGtk.cpp: 5440 (WebKit::InspectorClient::openInspectorFrontend): 5441 54422010-08-03 Daniel Bates <dbates@rim.com> 5443 5444 Fix misspelled word 'teh' in the description of the XSS Auditor setting. 5445 5446 * webkit/webkitwebsettings.cpp: 5447 (webkit_web_settings_class_init): 5448 54492010-08-03 Xan Lopez <xlopez@igalia.com> 5450 5451 Reviewed by Gustavo Noronha. 5452 5453 [GTK] Fix DOM event dispatch 5454 https://bugs.webkit.org/show_bug.cgi?id=40847 5455 5456 Test DOM event dispatch. 5457 5458 * tests/testdomdomwindow.c: 5459 (load_event_callback): 5460 (test_dom_domview_signals): 5461 (clicked_cb): 5462 (load_status_callback): 5463 (test_dom_domview_dispatch_event): 5464 (main): 5465 54662010-08-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 5467 5468 Reviewed by Xan Lopez. 5469 5470 [GTK] Does not paint the node highlight used by the inspector 5471 https://bugs.webkit.org/show_bug.cgi?id=43429 5472 5473 Implement highlighting the nodes when using the inspector. 5474 5475 * WebCoreSupport/InspectorClientGtk.cpp: 5476 (WebKit::InspectorClient::highlight): 5477 (WebKit::InspectorClient::hideHighlight): 5478 * webkit/webkitwebview.cpp: 5479 (webkit_web_view_expose_event): 5480 54812010-08-03 Xan Lopez <xlopez@igalia.com> 5482 5483 Reviewed by Gustavo Noronha. 5484 5485 Update unit tests now that string parameters are 'const char*'. 5486 5487 * tests/testdomdocument.c: 5488 (test_dom_document_title): 5489 (test_dom_document_get_elements_by_tag_name): 5490 (test_dom_document_get_elements_by_class_name): 5491 (test_dom_document_get_element_by_id): 5492 * tests/testdomnode.c: 5493 (test_dom_node_insertion): 5494 54952010-08-02 Martin Robinson <mrobinson@igalia.com> 5496 5497 Reviewed by Xan Lopez. 5498 5499 [GTK] DRT implement execCommand() 5500 https://bugs.webkit.org/show_bug.cgi?id=35351 5501 5502 * webkit/webkitprivate.h: Add some private methods for the DRT which enable 5503 LayoutTestController.execCommand and LayoutTestController.isCommandEnabled: 5504 webkit_web_view_execute_core_command_by_name and webkit_web_view_is_command_enabled. 5505 * webkit/webkitwebview.cpp: 5506 (webkit_web_view_execute_core_command_by_name): added. 5507 (webkit_web_view_is_command_enabled): Added. 5508 55092010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> 5510 5511 Reviewed by Darin Fisher. 5512 5513 PopupMenu refactoring in preparation to WebKit2 5514 https://bugs.webkit.org/show_bug.cgi?id=42592 5515 5516 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu 5517 instances, concrete classes that inherit from ChromeClient needed to be changed to 5518 implement the new methods. 5519 5520 * WebCoreSupport/ChromeClientGtk.cpp: 5521 (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): 5522 (WebKit::ChromeClient::createPopupMenu): 5523 (WebKit::ChromeClient::createSearchPopupMenu): 5524 * WebCoreSupport/ChromeClientGtk.h: 5525 55262010-08-02 Martin Robinson <mrobinson@igalia.com> 5527 5528 Reviewed by Xan Lopez. 5529 5530 [GTK] Create a frame-created signal 5531 https://bugs.webkit.org/show_bug.cgi?id=43284 5532 5533 Add a frame-created signal, which will allow developers to track 5534 the beginning of a frame lifecycle and attach signal handlers to 5535 all new frames. 5536 5537 * WebCoreSupport/FrameLoaderClientGtk.cpp: 5538 (WebKit::FrameLoaderClient::createFrame): Emit the frame-created signal. 5539 * tests/testwebframe.c: Add a test which verifies that the correct number of 5540 frame-created signals is fired when a page with iframes loads. 5541 (createFrameSignalTestFrameCreatedCallback): Added. 5542 (createFrameSignalTestTimeout): Added. 5543 (test_webkit_web_frame_created_signal): Added. 5544 (main): Add a reference to the new test. 5545 * webkit/webkitprivate.h: De-normalize webkit_web_frame_init_with_web_view into 5546 the one place that it is used, so that the frame-created signal may be fired there. 5547 * webkit/webkitwebframe.cpp: Remove webkit_web_frame_init_with_web_view. 5548 * webkit/webkitwebview.cpp: 5549 (webkit_web_view_class_init): Add the frame-created signal declaration. 5550 55512010-08-02 Mario Sanchez Prada <msanchez@igalia.com> 5552 5553 Reviewed by Chris Fleizach. 5554 5555 [GTK] Implement support for get_character_extents and get_range_extents 5556 https://bugs.webkit.org/show_bug.cgi?id=25677 5557 5558 Added new unit tests to check get_character_extents and 5559 get_range_extents functions for the ATK_TEXT interface 5560 5561 Based on a previous patch by Joanmarie Diggs. 5562 5563 * tests/testatk.c: 5564 (test_webkit_atk_get_extents): 5565 (main): 5566 55672010-08-02 Jeremy Orlow <jorlow@chromium.org> 5568 5569 Speculative revert of 64425 due to Chromium instability 5570 https://bugs.webkit.org/show_bug.cgi?id=43347 5571 5572 * WebCoreSupport/ChromeClientGtk.cpp: 5573 * WebCoreSupport/ChromeClientGtk.h: 5574 55752010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> 5576 5577 Reviewed by Darin Fisher. 5578 5579 PopupMenu refactoring in preparation to WebKit2 5580 https://bugs.webkit.org/show_bug.cgi?id=42592 5581 5582 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu 5583 instances, concrete classes that inherit from ChromeClient needed to be changed to 5584 implement the new methods. 5585 5586 * WebCoreSupport/ChromeClientGtk.cpp: 5587 (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): 5588 (WebKit::ChromeClient::createPopupMenu): 5589 (WebKit::ChromeClient::createSearchPopupMenu): 5590 * WebCoreSupport/ChromeClientGtk.h: 5591 55922010-07-31 Sheriff Bot <webkit.review.bot@gmail.com> 5593 5594 Unreviewed, rolling out r64422. 5595 http://trac.webkit.org/changeset/64422 5596 https://bugs.webkit.org/show_bug.cgi?id=43304 5597 5598 Build fixes are needed for Snow Leopard and Windows. 5599 (Requested by lca on #webkit). 5600 5601 * WebCoreSupport/ChromeClientGtk.cpp: 5602 * WebCoreSupport/ChromeClientGtk.h: 5603 56042010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> 5605 5606 Reviewed by Darin Fisher. 5607 5608 PopupMenu refactoring in preparation to WebKit2 5609 https://bugs.webkit.org/show_bug.cgi?id=42592 5610 5611 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu 5612 instances, concrete classes that inherit from ChromeClient needed to be changed to 5613 implement the new methods. 5614 5615 * WebCoreSupport/ChromeClientGtk.cpp: 5616 (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): 5617 (WebKit::ChromeClient::createPopupMenu): 5618 (WebKit::ChromeClient::createSearchPopupMenu): 5619 * WebCoreSupport/ChromeClientGtk.h: 5620 56212010-07-30 Joseph Pecoraro <joepeck@webkit.org> 5622 5623 Reviewed by David Kilzer. 5624 5625 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas) 5626 https://bugs.webkit.org/show_bug.cgi?id=40627 5627 5628 * WebCoreSupport/ChromeClientGtk.cpp: 5629 (WebKit::ChromeClient::reachedApplicationCacheOriginQuota): 5630 * WebCoreSupport/ChromeClientGtk.h: 56312010-07-26 Steve Block <steveblock@google.com> 5632 5633 Reviewed by Jeremy Orlow. 5634 5635 Page clients should be passed to Page constructor via structure of pointers 5636 https://bugs.webkit.org/show_bug.cgi?id=42834 5637 5638 * webkit/webkitwebview.cpp: 5639 (webkit_web_view_init): 5640 56412010-07-16 Zhe Su <suzhe@chromium.org> 5642 5643 Reviewed by Darin Adler. 5644 5645 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms 5646 https://bugs.webkit.org/show_bug.cgi?id=42253 5647 5648 Dummy implementation of EditorClient::willSetInputMethodState. 5649 5650 * WebCoreSupport/EditorClientGtk.cpp: 5651 (WebKit::EditorClient::willSetInputMethodState): 5652 * WebCoreSupport/EditorClientGtk.h: 5653 56542010-07-16 Nate Chapin <japhet@chromium.org> 5655 5656 Reviewed by Darin Fisher. 5657 5658 Uncomment an assert that broke due to r63100. 5659 5660 https://bugs.webkit.org/show_bug.cgi?id=42298 5661 5662 * tests/testwebview.c: 5663 56642010-07-14 Sam Weinig <sam@webkit.org> 5665 5666 Reviewed by Darin Adler. 5667 5668 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232 5669 Make changing Cursors work in WebKit2. 5670 5671 * WebCoreSupport/ChromeClientGtk.cpp: 5672 (WebKit::ChromeClient::setCursor): 5673 * WebCoreSupport/ChromeClientGtk.h: 5674 Change prototype to match new one. 5675 56762010-07-12 Martin Robinson <mrobinson@igalia.com> 5677 5678 Reviewed by Gustavo Noronha Silva. 5679 5680 [GTK] r63100 broke the testwebview test 5681 https://bugs.webkit.org/show_bug.cgi?id=42114 5682 5683 * tests/testwebview.c: Disable a failing assertion in test_webkit_web_view_adjustments 5684 until we can get to the bottom of the failure. 5685 56862010-07-12 Xan Lopez <xlopez@igalia.com> 5687 5688 Reviewed by Gustavo Noronha. 5689 5690 Update for 1.3.3 5691 5692 * NEWS: 5693 56942010-07-12 Xan Lopez <xlopez@igalia.com> 5695 5696 Reviewed by Gustavo Noronha. 5697 5698 Fix compilation with sealed GTK+. 5699 5700 * webkit/webkitwebview.cpp: 5701 (webkit_web_view_drag_motion): 5702 (webkit_web_view_drag_data_received): 5703 (webkit_web_view_drag_drop): 5704 57052010-07-11 Martin Robinson <mrobinson@igalia.com> 5706 5707 Reviewed by Xan Lopez. 5708 5709 [GTK] WebKitWebView should support drops 5710 https://bugs.webkit.org/show_bug.cgi?id=39843 5711 5712 Add support for dropping content onto GTK+ WebViews. 5713 5714 * webkit/webkitprivate.h: 5715 Add a DroppingContext struct to keep track of drop data while the drop is 5716 in progress. Have WebKitWebView keep a map of GdkDragContexts to DroppingContexts. 5717 * webkit/webkitwebview.cpp: Add necessary includes and globalPointForClientPoint helper. 5718 (webkit_web_view_popup_menu_handler): Use globalPointForClientPoint helper. 5719 (webkit_web_view_dispose): Properly clean up droppingContexts member. 5720 (webkit_web_view_finalize): Delete droppingContext member. 5721 (globalPointForClientPoint): Added. 5722 (doDragLeaveLater): Added. 5723 (webkit_web_view_drag_leave): Added. 5724 (webkit_web_view_drag_motion): Added. 5725 (webkit_web_view_drag_data_received): Added. 5726 (webkit_web_view_drag_drop): Added. 5727 (webkit_web_view_class_init): Connect new drop signal handlers to the widget definition. 5728 (webkit_web_view_init): Set up the widget as a drop destination and initialize droppingContexts. 5729 57302010-07-07 Sam Weinig <sam@webkit.org> 5731 5732 Reviewed by Anders Carlsson. 5733 5734 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772 5735 Add basic piping for BackForwardControllerClient. 5736 5737 * webkit/webkitwebview.cpp: 5738 (webkit_web_view_init): 5739 57402010-06-19 Ilya Tikhonovsky <loislo@chromium.org> 5741 5742 Reviewed by Yury Semikhatsky. 5743 5744 WebInspector: js function name was fixed. 5745 dispatchMessageToFrontend -> dispatchMessageFromBackend. 5746 https://bugs.webkit.org/show_bug.cgi?id=40675 5747 5748 * WebCoreSupport/InspectorClientGtk.cpp: 5749 (WebKit::InspectorClient::sendMessageToFrontend): 5750 57512010-06-23 Martin Robinson <mrobinson@igalia.com> 5752 5753 Reviewed by Gustavo Noronha Silva. 5754 5755 [GTK] Separate DerivedSources per-project 5756 https://bugs.webkit.org/show_bug.cgi?id=41109 5757 5758 Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare 5759 for properly building WebKit2. 5760 5761 * webkitmarshal.list: Touch this file to force a rebuild of the marshaling code. 5762 57632010-07-01 Xan Lopez <xlopez@igalia.com> 5764 5765 Reviewed by Gustavo Noronha. 5766 5767 [GTK] Stop using GdkRegion in 3.x mode 5768 https://bugs.webkit.org/show_bug.cgi?id=41463 5769 5770 Make us compile without using GdkRegion, since it's gone from GTK+ 5771 3.x. 5772 5773 * WebCoreSupport/ChromeClientGtk.cpp: 5774 (WebKit::ChromeClient::scroll): 5775 * webkit/webkitwebview.cpp: 5776 (webkit_web_view_expose_event): 5777 57782010-07-01 Martin Robinson <mrobinson@igalia.com> 5779 5780 Reviewed by Xan Lopez. 5781 5782 [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer 5783 https://bugs.webkit.org/show_bug.cgi?id=40333 5784 5785 Convert draggingDataObjects to a pointer. The constructor and destructor of the 5786 HashMap should be called explicitly. GObject memory allocation does not do this. 5787 5788 * WebCoreSupport/DragClientGtk.cpp: 5789 (WebKit::DragClient::startDrag): 5790 * webkit/webkitprivate.h: 5791 * webkit/webkitwebview.cpp: 5792 (webkit_web_view_dispose): 5793 (webkit_web_view_drag_end): 5794 (webkit_web_view_drag_data_get): 5795 (webkit_web_view_init): 5796 57972010-06-30 Martin Robinson <mrobinson@igalia.com> 5798 5799 Unreviewed, rolling out r62226. 5800 http://trac.webkit.org/changeset/62226 5801 https://bugs.webkit.org/show_bug.cgi?id=40333 5802 5803 This change caused 13 new crashers. 5804 5805 * WebCoreSupport/DragClientGtk.cpp: 5806 (WebKit::DragClient::startDrag): 5807 * webkit/webkitprivate.h: 5808 * webkit/webkitwebview.cpp: 5809 (webkit_web_view_dispose): 5810 (webkit_web_view_drag_end): 5811 (webkit_web_view_drag_data_get): 5812 (webkit_web_view_init): 5813 58142010-06-30 Martin Robinson <mrobinson@igalia.com> 5815 5816 Reviewed by Xan Lopez. 5817 5818 [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer 5819 https://bugs.webkit.org/show_bug.cgi?id=40333 5820 5821 Convert draggingDataObjects to a pointer. The constructor and destructor of the 5822 HashMap should be called explicitly. GObject memory allocation does not do this. 5823 5824 * WebCoreSupport/DragClientGtk.cpp: 5825 (WebKit::DragClient::startDrag): 5826 * webkit/webkitprivate.h: 5827 * webkit/webkitwebview.cpp: 5828 (webkit_web_view_dispose): 5829 (webkit_web_view_drag_end): 5830 (webkit_web_view_drag_data_get): 5831 (webkit_web_view_init): 5832 58332010-06-30 Xan Lopez <xlopez@igalia.com> 5834 5835 Reviewed by Gustavo Noronha. 5836 5837 [GTK] Unit test for DOM insertion methods 5838 https://bugs.webkit.org/show_bug.cgi?id=40495 5839 5840 Add unit test for webkit_dom_node_remove_child. 5841 5842 * tests/testdomnode.c: 5843 (test_dom_node_insertion): 5844 58452010-06-30 Xan Lopez <xlopez@igalia.com> 5846 5847 Reviewed by Gustavo Noronha. 5848 5849 [GTK] Unit test for DOM insertion methods 5850 https://bugs.webkit.org/show_bug.cgi?id=40495 5851 5852 Add unit tests for node insertion and replacement methods. 5853 5854 * tests/testdomnode.c: 5855 (test_dom_node_insertion): 5856 (main): 5857 58582010-06-30 Mario Sanchez Prada <msanchez@igalia.com> 5859 5860 Reviewed by Xan Lopez. 5861 5862 [GTK] Random failure on 'testdownload' unit test 5863 https://bugs.webkit.org/show_bug.cgi?id=38256 5864 5865 Make sure the set_filename function is called after handling the 5866 'download-requested' signal for the asynchronous test. This change 5867 is needed because it could happen, with the current code, that the 5868 set_filename () function got called too early in the mainloop, 5869 therefore screwing the tests because the 'theDownload' global 5870 variable wouldn't be properly set yet. 5871 5872 With this modification we ensure the set_filename() function gets 5873 called always after handling the download-requested signal, 5874 therefore avoiding potentialproblems. 5875 5876 * tests/testdownload.c: 5877 (set_filename): 5878 (handle_download_requested_cb): 5879 (download_requested_cb): 5880 (download_requested_asynch_cb): 5881 (test_webkit_download_perform): 5882 58832010-06-30 José Millán Soto <jmillan@igalia.com> 5884 5885 Reviewed by Xan Lopez. 5886 5887 [Gtk] Text attributes not exposed 5888 https://bugs.webkit.org/show_bug.cgi?id=25528 5889 5890 Added new tests for accessible text attributes 5891 5892 * tests/testatk.c: 5893 (compAtkAttribute): 5894 (compAtkAttributeName): 5895 (atkAttributeSetAttributeHasValue): 5896 (atkAttributeSetAreEqual): 5897 (testWebkitAtkTextAttributes): 5898 (main): 5899 59002010-06-28 Xan Lopez <xlopez@igalia.com> 5901 5902 Reviewed by Gustavo Noronha. 5903 5904 Update for 1.3.2. 5905 5906 * NEWS: 5907 59082010-06-28 Xan Lopez <xlopez@igalia.com> 5909 5910 Reviewed by Gustavo Noronha. 5911 5912 [GTK] Does not compile with -DGSEAL_ENABLE 5913 https://bugs.webkit.org/show_bug.cgi?id=37851 5914 5915 Fix build with GSEAL enabled. 5916 5917 * WebCoreSupport/FrameLoaderClientGtk.cpp: 5918 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 5919 * webkit/webkitsoupauthdialog.c: 5920 (show_auth_dialog): 5921 59222010-06-28 Xan Lopez <xlopez@igalia.com> 5923 5924 Reviewed by Gustavo Noronha. 5925 5926 [GTK] Add support for GTK+3 5927 https://bugs.webkit.org/show_bug.cgi?id=41253 5928 5929 Adapt build system to 3.x support, allow the JSCore gir and webkit 5930 pc files to be configurable at build time for different API 5931 versions. 5932 5933 * JSCore-1.0.gir: Removed. 5934 * JSCore.gir.in: Added. 5935 * docs/GNUmakefile.am: 5936 * webkit.pc.in: 5937 59382010-06-25 Mario Sanchez Prada <msanchez@igalia.com> 5939 5940 Reviewed by Xan Lopez. 5941 5942 [Gtk] Implement atk_table_get_column_header 5943 https://bugs.webkit.org/show_bug.cgi?id=30896 5944 5945 Replace g_timeout_add() with g_idle_add(). 5946 5947 * tests/testatk.c: 5948 (test_webkit_atk_get_text_at_offset_forms): 5949 (test_webkit_atk_get_text_at_offset): 5950 (test_webkit_atk_get_text_at_offset_newlines): 5951 (test_webkit_atk_get_text_at_offset_textarea): 5952 (test_webkit_atk_get_text_at_offset_text_input): 5953 (testWebkitAtkGetTextInParagraphAndBodySimple): 5954 (testWebkitAtkGetTextInParagraphAndBodyModerate): 5955 (testWebkitAtkGetTextInTable): 5956 (testWebkitAtkGetHeadersInTable): 5957 59582010-06-25 Mario Sanchez Prada <msanchez@igalia.com> 5959 5960 Reviewed by Xan Lopez. 5961 5962 [Gtk] Implement atk_table_get_column_header 5963 https://bugs.webkit.org/show_bug.cgi?id=30896 5964 5965 Added new test to check whether the implementation of 5966 get_column_headers() and get_row_headers() works ok. 5967 5968 * tests/testatk.c: 5969 (testWebkitAtkGetHeadersInTable): 5970 (main): 5971 59722010-06-25 Martin Robinson <mrobinson@igalia.com> 5973 5974 Reviewed by Xan Lopez. 5975 5976 [GTK] Pasteboard code does not take into account the nil character when getting and setting markup/netscape-url data 5977 https://bugs.webkit.org/show_bug.cgi?id=41221 5978 5979 Add a test for this issue which simulates a paste keyboard event into an editable 5980 body. The pasteboard should contain a markup portion containing a null terminator. 5981 5982 * tests/testcopyandpaste.c: 5983 (test_info_new): 5984 (test_info_destroy): 5985 (load_status_cb): 5986 (runPasteTestCallback): 5987 (window_object_cleared_callback): 5988 (pasting_test_get_data_callback): 5989 (pasting_test_clear_data_callback): 5990 (test_pasting_markup): 5991 (main): 5992 59932010-06-24 Martin Robinson <mrobinson@igalia.com> 5994 5995 Reviewed by Xan Lopez. 5996 5997 [GTK] Cannot change the selection via the keyboard 5998 https://bugs.webkit.org/show_bug.cgi?id=41162 5999 6000 Fix issue where the selection could not be extended via the keyboard by 6001 adjusting the logic guarding against inserting text in non-editable nodes. 6002 6003 * WebCoreSupport/EditorClientGtk.cpp: 6004 (WebKit::EditorClient::handleKeyboardEvent): 6005 Allow editor commands that do not insert text in non-editable nodes. This 6006 fixes keyboard selection extension in non-editable nodes. Move the existing 6007 check to after the execution of any editor commands. 6008 60092010-06-15 Dumitru Daniliuc <dumi@chromium.org> 6010 6011 Reviewed by Adam Barth. 6012 6013 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase. 6014 https://bugs.webkit.org/show_bug.cgi?id=39041 6015 6016 * webkit/webkitwebview.cpp: 6017 (webkit_web_view_update_settings): 6018 (webkit_web_view_settings_notify): 6019 (webkit_get_cache_model): 6020 60212010-06-16 Martin Robinson <mrobinson@igalia.com> 6022 6023 Reviewed by Gustavo Noronha Silva. 6024 6025 [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT 6026 https://bugs.webkit.org/show_bug.cgi?id=40600 6027 6028 * WebCoreSupport/DragClientGtk.cpp: 6029 (WebKit::DragClient::startDrag): Reset the click count after a drag starts. 6030 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6031 (WebKit::postCommitFrameViewSetup): Reset the click count after a load is committed. 6032 * webkit/webkitprivate.h: Move static click counting variables to be per-view. 6033 * webkit/webkitwebview.cpp: 6034 (getEventTime): Added. 6035 (webkit_web_view_button_press_event): If the event time is zero, use the current time. 6036 (webkit_web_view_finalize): Clean up click counting member. 6037 (webkit_web_view_init): Initialize click counting member. 6038 60392010-06-15 Xan Lopez <xlopez@igalia.com> 6040 6041 Fix compilation with older GTK+. 6042 6043 * WebCoreSupport/ChromeClientGtk.cpp: 6044 (WebKit::ChromeClient::pageRect): 6045 60462010-06-15 Xan Lopez <xlopez@igalia.com> 6047 6048 Reviewed by Gustavo Noronha. 6049 6050 [GTK] Does not compile with -DGSEAL_ENABLE 6051 https://bugs.webkit.org/show_bug.cgi?id=37851 6052 6053 Fix compilation with GSEAL_ENABLE. 6054 6055 * WebCoreSupport/ChromeClientGtk.cpp: 6056 (WebKit::ChromeClient::pageRect): 6057 (WebKit::ChromeClient::contentsSizeChanged): 6058 * tests/testdomnode.c: 6059 (test_dom_node_insertion): 6060 * webkit/webkitwebview.cpp: 6061 (webkit_web_view_realize): 6062 (webkit_web_view_script_dialog): 6063 (webkit_web_view_drag_end): 6064 (webkit_web_view_init): 6065 60662010-06-14 Ilya Tikhonovsky <loislo@chromium.org> 6067 6068 Unreviewed build fix. 6069 6070 This is a fix for flaky inspector tests at gtk-debug bots. 6071 6072 * WebCoreSupport/InspectorClientGtk.cpp: 6073 (WebKit::InspectorFrontendClient::destroyInspectorWindow): 6074 60752010-06-14 Ilya Tikhonovsky <loislo@chromium.org> 6076 6077 Reviewed by Pavel Feldman. 6078 6079 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc 6080 data from inspected page to WebInspector as JSON string via http. The native 6081 serialization to JSON string is supported by InspectorValue's classes. This patch 6082 has the implementation of sendMessageToFrontend function. WebKit version of it still 6083 uses ScriptFunctionCall and will be switched to another transport a little bit later. 6084 https://bugs.webkit.org/show_bug.cgi?id=40134 6085 6086 * WebCoreSupport/InspectorClientGtk.cpp: 6087 (WebKit::InspectorClient::releaseFrontendPage): 6088 (WebKit::InspectorClient::sendMessageToFrontend): 6089 * WebCoreSupport/InspectorClientGtk.h: 6090 60912010-06-10 Eric Seidel <eric@webkit.org> 6092 6093 Reviewed by Adam Barth. 6094 6095 Reduce FrameView.h includes to speed up build times 6096 https://bugs.webkit.org/show_bug.cgi?id=40408 6097 6098 * webkit/webkitwebinspector.cpp: 6099 - Include RenderLayer.h 6100 61012010-06-09 Sheriff Bot <webkit.review.bot@gmail.com> 6102 6103 Unreviewed, rolling out r60889. 6104 http://trac.webkit.org/changeset/60889 6105 https://bugs.webkit.org/show_bug.cgi?id=40365 6106 6107 gtk bot has some kind of memory corruption (Requested by 6108 loislo on #webkit). 6109 6110 * WebCoreSupport/InspectorClientGtk.cpp: 6111 (WebKit::InspectorClient::InspectorClient): 6112 (WebKit::InspectorClient::openInspectorFrontend): 6113 (WebKit::InspectorFrontendClient::InspectorFrontendClient): 6114 (WebKit::InspectorFrontendClient::destroyInspectorWindow): 6115 * WebCoreSupport/InspectorClientGtk.h: 6116 61172010-06-07 Ilya Tikhonovsky <loislo@chromium.org> 6118 6119 Reviewed by Pavel Feldman. 6120 6121 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc 6122 data from inspected page to WebInspector as JSON string via http. The native 6123 serialization to JSON string is supported by InspectorValue's classes. This patch 6124 has the implementation of sendMessageToFrontend function. WebKit version of it still 6125 uses ScriptFunctionCall and will be switched to another transport a little bit later. 6126 https://bugs.webkit.org/show_bug.cgi?id=40134 6127 6128 * WebCoreSupport/InspectorClientGtk.cpp: 6129 (WebKit::InspectorClient::releaseFrontendPage): 6130 (WebKit::InspectorClient::sendMessageToFrontend): 6131 * WebCoreSupport/InspectorClientGtk.h: 6132 61332010-06-08 Xan Lopez <xlopez@igalia.com> 6134 6135 Reviewed by Gustavo Noronha. 6136 6137 [GTK] Unit testing for WebKitDOMNode hierarchy walk 6138 https://bugs.webkit.org/show_bug.cgi?id=40171 6139 6140 Add some DOM node unit testing. 6141 6142 * tests/testdomnode.c: Added. 6143 (finish_loading): 6144 (dom_node_fixture_setup): 6145 (dom_node_fixture_teardown): 6146 (test_dom_node_hierarchy_navigation): 6147 (main): 6148 61492010-06-08 Antonio Gomes <tonikitoo@webkit.org> 6150 6151 Reviewed by Ojan Vafai and Darin Adler. 6152 6153 Refactor platform dependent editing behavior code out of Settings 6154 https://bugs.webkit.org/show_bug.cgi?id=39854 6155 6156 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to 6157 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly. 6158 6159 * webkit/webkitprivate.cpp: 6160 (WebKit::core): 6161 * webkit/webkitprivate.h: 6162 * webkit/webkitwebview.cpp: 6163 (webkit_web_view_update_settings): 6164 (webkit_web_view_settings_notify): 6165 61662010-06-08 Xan Lopez <xlopez@igalia.com> 6167 6168 Reviewed by Gustavo Noronha. 6169 6170 [GTK] Add inner-node property to WebKitHitTestResult 6171 https://bugs.webkit.org/show_bug.cgi?id=40131 6172 6173 Add a 'inner-node' property to WebKitHitTestResult, carrying the 6174 DOM node where the hit test happened. 6175 6176 * tests/testhittestresult.c: 6177 (load_status_cb): 6178 * webkit/webkithittestresult.cpp: 6179 (webkit_hit_test_result_get_property): 6180 (webkit_hit_test_result_set_property): 6181 (webkit_hit_test_result_class_init): 6182 * webkit/webkitprivate.cpp: 6183 (WebKit::kit): 6184 61852010-06-07 Martin Robinson <mrobinson@igalia.com> 6186 6187 Reviewed by Xan Lopez. 6188 6189 [GTK] gtk_widget_get_window should replace widget->window 6190 https://bugs.webkit.org/show_bug.cgi?id=40180 6191 6192 Replace uses of widget->window with gtk_widget_get_window. 6193 6194 * WebCoreSupport/ChromeClientGtk.cpp: 6195 (WebKit::ChromeClient::invalidateContentsAndWindow): Replace widget->window uses. 6196 (WebKit::ChromeClient::scroll): Ditto. 6197 (WebKit::widgetScreenPosition): Ditto. 6198 * WebCoreSupport/DragClientGtk.cpp: Move gtk_widget_get_window define to GtkVersioning.h. 6199 * webkit/webkitwebview.cpp: 6200 (webkit_web_view_popup_menu_handler): Replace widget->window uses. 6201 (webkit_web_view_button_press_event): Ditto. 6202 62032010-06-04 Martin Robinson <mrobinson@igalia.com> 6204 6205 Reviewed by Xan Lopez. 6206 6207 [GTK] Drag gesture can take mouse grab indefinitely 6208 https://bugs.webkit.org/show_bug.cgi?id=32840 6209 6210 Initiate drag events with the current GTK+ event instead of synthesizing 6211 an event. Something about synthesized events is causing a drag freeze in 6212 certain situations. 6213 6214 * WebCoreSupport/DragClientGtk.cpp: 6215 (WebKit::DragClient::startDrag): Start the drag with the current GTK+ event. 6216 62172010-06-03 Sheriff Bot <webkit.review.bot@gmail.com> 6218 6219 Unreviewed, rolling out r60632. 6220 http://trac.webkit.org/changeset/60632 6221 https://bugs.webkit.org/show_bug.cgi?id=40143 6222 6223 This change broke the 64-bit bots. (Requested by mrobinson on 6224 #webkit). 6225 6226 * WebCoreSupport/DragClientGtk.cpp: 6227 (WebKit::DragClient::DragClient): 6228 (WebKit::DragClient::startDrag): 6229 * WebCoreSupport/DragClientGtk.h: 6230 62312010-06-03 Martin Robinson <mrobinson@igalia.com> 6232 6233 Reviewed by Xan Lopez. 6234 6235 [GTK] Drag gesture can take mouse grab indefinitely 6236 https://bugs.webkit.org/show_bug.cgi?id=32840 6237 6238 Start GTK+ drags with the previous mouse button down event instead of 6239 synthesizing the event. The synthesized event was not completely valid 6240 and froze some drags indefinitely. 6241 6242 * WebCoreSupport/DragClientGtk.cpp: 6243 (WebKit::buttonPressEvent): Added. 6244 (WebKit::DragClient::DragClient): 6245 Connect to the 'button-press-event' signal of the WebView. 6246 (WebKit::DragClient::startDrag): 6247 Instead of synthesizing a button press event use the last real one. 6248 * WebCoreSupport/DragClientGtk.h: 6249 (WebKit::DragClient::setLastButtonPressEvent): Added. 6250 62512010-06-01 Xan Lopez <xlopez@igalia.com> 6252 6253 Reviewed by Gustavo Noronha. 6254 6255 Memory Leak: The main resource of page is not free. 6256 https://bugs.webkit.org/show_bug.cgi?id=39973 6257 6258 Fix refcount tracking of the main resource. Patch by Genhua Liu. 6259 6260 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6261 (WebKit::FrameLoaderClient::dispatchDidFinishLoading): 6262 62632010-06-01 Xan Lopez <xlopez@igalia.com> 6264 6265 Reviewed by Gustavo Noronha. 6266 6267 Fix-up for previous leak fix, the identifier was not always duped. 6268 6269 * webkit/webkitprivate.h: 6270 * webkit/webkitwebview.cpp: 6271 (webkit_web_view_add_resource): 6272 62732010-06-01 Xan Lopez <xlopez@igalia.com> 6274 6275 Reviewed by Gustavo Noronha. 6276 6277 Plug a small leak. 6278 6279 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6280 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): 6281 62822010-06-01 Martin Robinson <mrobinson@igalia.com> 6283 6284 Reviewed by Xan Lopez. 6285 6286 [GTK] Double clicks cause three button press events 6287 https://bugs.webkit.org/show_bug.cgi?id=38853 6288 6289 Handle click counting much like the Windows port. GTK+ only 6290 counts triple-clicks natively, so use GTK+ double-click settings 6291 to count clicks with even larger click counts. Also filter the 6292 extra GDK_BUTTON_PRESS before GDK_{2,3}BUTTON_PRESS events using 6293 gdk_event_peek(). 6294 6295 * webkit/webkitwebview.cpp: 6296 (webkit_web_view_button_press_event): Count clicks manually. Filter extra events. 6297 62982010-05-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 6299 6300 Reviewed by Xan Lopez. 6301 6302 [GTK] Missing links to documentation of general functions 6303 https://bugs.webkit.org/show_bug.cgi?id=39964 6304 6305 Add global functions section, and move those functions that are 6306 currently in WebKitWebView's source file to the bottom, along with 6307 the description. 6308 6309 * docs/webkitgtk-docs.sgml: 6310 * docs/webkitgtk-sections.txt: 6311 * webkit/webkitwebview.cpp: 6312 (webkit_web_view_get_dom_document): 6313 (webkit_get_default_session): 6314 63152010-05-31 Martin Robinson <mrobinson@igalia.com> 6316 6317 Reviewed by Gustavo Noronha Silva. 6318 6319 [GTK] Text copied from a WebView cannot be pasted into gnome-terminal 6320 https://bugs.webkit.org/show_bug.cgi?id=39827 6321 6322 Add a test to prevent regressions for this issue. 6323 6324 * tests/testcopyandpaste.c: Added. 6325 (test_info_new): 6326 (test_info_destroy): 6327 (copy_and_paste_fixture_setup): 6328 (copy_and_paste_fixture_teardown): 6329 (load_status_cb): 6330 (map_event_cb): 6331 (test_copy_and_paste): 6332 (main): 6333 63342010-05-27 Gustavo Noronha Silva <gns@gnome.org> 6335 6336 Update documentation control files, and fix Since tags for 1.3.1. 6337 6338 * docs/webkitgtk-docs.sgml: 6339 * docs/webkitgtk-sections.txt: 6340 * webkit/webkitwebbackforwardlist.cpp: 6341 * webkit/webkitwebview.cpp: 6342 63432010-05-27 Xan Lopez <xlopez@igalia.com> 6344 6345 Reviewed by Gustavo Noronha. 6346 6347 Update for 1.3.1 release. 6348 6349 * NEWS: 6350 63512010-05-27 Martin Robinson <mrobinson@igalia.com> 6352 6353 Reviewed by Xan Lopez. 6354 6355 [GTK] Dragging onto the desktop causes a critical GLib warning 6356 https://bugs.webkit.org/show_bug.cgi?id=39718 6357 6358 Only increment the window reference count if it is not null during drag-end 6359 signal processing. 6360 6361 * webkit/webkitwebview.cpp: 6362 (webkit_web_view_drag_end): Guard against null window values. 6363 63642010-05-26 Xan Lopez <xlopez@igalia.com> 6365 6366 Reviewed by Gustavo Noronha. 6367 6368 [GTK] Add support for DOM events in the GObject DOM bindings 6369 https://bugs.webkit.org/show_bug.cgi?id=38844 6370 6371 Test DOMWindow signals. 6372 6373 * tests/testdomdomwindow.c: Added. 6374 (finish_loading): 6375 (dom_domview_fixture_setup): 6376 (dom_domview_fixture_teardown): 6377 (loadedCallback): 6378 (clickedCallback): 6379 (map_event_cb): 6380 (load_event_callback): 6381 (test_dom_domview_signals): 6382 (main): 6383 63842010-05-24 Darin Adler <darin@apple.com> 6385 6386 Reviewed by Eric Seidel. 6387 6388 Move view-related functions from Frame to FrameView 6389 https://bugs.webkit.org/show_bug.cgi?id=39366 6390 6391 * webkit/webkitwebview.cpp: 6392 (webkit_web_view_set_editable): Remove call to empty function 6393 removeEditngStyleFromBodyElement. 6394 (webkit_web_view_get_zoom_level): Call functions on FrameView. 6395 (webkit_web_view_apply_zoom_level): Ditto. 6396 63972010-05-22 Martin Robinson <mrobinson@igalia.com> 6398 6399 Reviewed by Xan Lopez. 6400 6401 [GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt 6402 https://bugs.webkit.org/show_bug.cgi?id=39465 6403 6404 Properly call EventHandler::dragSourceEndedAt so that dragEnd events are processed in the DOM. 6405 dragSourceEndedAt is responsible for calling the dragEnd DOM event as well as cleaning up assets 6406 (such as the Clipboard) associated with the drag source. 6407 6408 * webkit/webkitwebview.cpp: 6409 (webkit_web_view_drag_end): Remember to call dragSourceEndedAt here. 6410 64112010-05-22 Martin Robinson <mrobinson@igalia.com> 6412 6413 Reviewed by Xan Lopez. 6414 6415 [GTK] WebKit/gtk/WebCoreSupport/DragClientGtk::startDrag should use the Clipboard::sourceOperation 6416 https://bugs.webkit.org/show_bug.cgi?id=39459 6417 6418 * WebCoreSupport/DragClientGtk.cpp: 6419 (WebKit::DragClient::startDrag): 6420 Use Clipboard::sourceOperation instead of trying to figure out the GdkDragAction 6421 manually. The DOM may have changed the appropriate list of actions anyhow. 6422 64232010-05-21 Steve Block <steveblock@google.com> 6424 6425 Reviewed by Jeremy Orlow. 6426 6427 Add DeviceOrientation and DeviceOrientationClient 6428 https://bugs.webkit.org/show_bug.cgi?id=39479 6429 6430 * webkit/webkitwebview.cpp: 6431 (webkit_web_view_init): 6432 64332010-05-19 Sheriff Bot <webkit.review.bot@gmail.com> 6434 6435 Unreviewed, rolling out r59240. 6436 http://trac.webkit.org/changeset/59240 6437 https://bugs.webkit.org/show_bug.cgi?id=39377 6438 6439 "Might cause crashes in GTK+ bots" (Requested by xan_ on 6440 #webkit). 6441 6442 * WebCoreSupport/ContextMenuClientGtk.cpp: 6443 (WebKit::inputMethodsMenuItem): 6444 * WebCoreSupport/EditorClientGtk.cpp: 6445 (WebKit::EditorClient::setInputMethodState): 6446 (WebKit::EditorClient::respondToChangedSelection): 6447 (WebKit::EditorClient::handleInputMethodKeydown): 6448 (WebKit::EditorClient::EditorClient): 6449 (WebKit::EditorClient::~EditorClient): 6450 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6451 (WebKit::postCommitFrameViewSetup): 6452 * webkit/webkitprivate.h: 6453 * webkit/webkitwebview.cpp: 6454 (destroy_menu_cb): 6455 (webkit_web_view_forward_context_menu_event): 6456 (webkit_web_view_key_release_event): 6457 (webkit_web_view_button_release_event): 6458 (webkit_web_view_focus_in_event): 6459 (webkit_web_view_focus_out_event): 6460 (webkit_web_view_realize): 6461 (webkit_web_view_set_scroll_adjustments): 6462 (webkit_web_view_dispose): 6463 (webkit_web_view_finalize): 6464 (webViewGetDPI): 6465 (webkit_web_view_screen_changed): 6466 (webkit_web_view_query_tooltip): 6467 (webkit_web_view_get_im_context): 6468 (webkit_web_view_update_settings): 6469 (webkit_web_view_init): 6470 (webkit_web_view_set_settings): 6471 (webkit_web_view_get_settings): 6472 (webkit_web_view_get_inspector): 6473 (webkit_web_view_set_window_features): 6474 (webkit_web_view_get_window_features): 6475 (webkit_web_view_get_back_forward_list): 6476 (webkit_web_view_zoom_in): 6477 (webkit_web_view_zoom_out): 6478 (webkit_web_view_get_encoding): 6479 (webkit_web_view_get_custom_encoding): 6480 (webkit_web_view_add_resource): 6481 (webkit_web_view_get_resource): 6482 (webkit_web_view_get_main_resource): 6483 (webkit_web_view_clear_resources): 6484 (webkit_web_view_get_subresources): 6485 (webkit_web_view_set_tooltip_text): 6486 (webkit_web_view_get_icon_uri): 6487 64882010-05-18 Martin Robinson <mrobinson@igalia.com> 6489 6490 Reviewed by Xan Lopez. 6491 6492 [GTK] DragClientGtk::startDrag leaks GdkEvents 6493 https://bugs.webkit.org/show_bug.cgi?id=39322 6494 6495 * WebCoreSupport/DragClientGtk.cpp: 6496 (WebKit::DragClient::startDrag): Properly clean up allocated GdkEvent. 6497 64982010-05-12 Martin Robinson <mrobinson@igalia.com> 6499 6500 Reviewed by Xan Lopez. 6501 6502 [Gtk] Use GOwnPtr for code that needs it 6503 https://bugs.webkit.org/show_bug.cgi?id=21594 6504 6505 Convert many uses of raw pointers to GRefPtr and GOwnPtr in WebKitWebView. 6506 6507 * WebCoreSupport/ContextMenuClientGtk.cpp: 6508 (WebKit::inputMethodsMenuItem): 6509 * WebCoreSupport/EditorClientGtk.cpp: 6510 (WebKit::EditorClient::setInputMethodState): 6511 (WebKit::EditorClient::respondToChangedSelection): 6512 (WebKit::EditorClient::handleInputMethodKeydown): 6513 (WebKit::EditorClient::EditorClient): 6514 (WebKit::EditorClient::~EditorClient): 6515 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6516 (WebKit::postCommitFrameViewSetup): 6517 * webkit/webkitprivate.h: 6518 * webkit/webkitwebview.cpp: 6519 (destroy_menu_cb): 6520 (webkit_web_view_forward_context_menu_event): 6521 (webkit_web_view_key_release_event): 6522 (webkit_web_view_button_release_event): 6523 (webkit_web_view_focus_in_event): 6524 (webkit_web_view_focus_out_event): 6525 (webkit_web_view_realize): 6526 (webkit_web_view_set_scroll_adjustments): 6527 (webkit_web_view_dispose): 6528 (webkit_web_view_finalize): 6529 (webViewGetDPI): 6530 (webkit_web_view_screen_changed): 6531 (webkit_web_view_query_tooltip): 6532 (webkit_web_view_get_im_context): 6533 (webkit_web_view_update_settings): 6534 (webkit_web_view_init): 6535 (webkit_web_view_set_settings): 6536 (webkit_web_view_get_settings): 6537 (webkit_web_view_get_inspector): 6538 (webkit_web_view_set_window_features): 6539 (webkit_web_view_get_window_features): 6540 (webkit_web_view_get_back_forward_list): 6541 (webkit_web_view_zoom_in): 6542 (webkit_web_view_zoom_out): 6543 (webkit_web_view_get_encoding): 6544 (webkit_web_view_get_custom_encoding): 6545 (webkit_web_view_add_resource): 6546 (webkit_web_view_get_resource): 6547 (webkit_web_view_get_main_resource): 6548 (webkit_web_view_clear_resources): 6549 (webkit_web_view_get_subresources): 6550 (webkit_web_view_set_tooltip_text): 6551 (webkit_web_view_get_icon_uri): 6552 65532010-05-11 Martin Robinson <mrobinson@igalia.com> 6554 6555 Reviewed by Xan Lopez. 6556 6557 [Gtk] Doesn't support gtk-key-themes 6558 https://bugs.webkit.org/show_bug.cgi?id=28257 6559 6560 Add support for GTK+ key themes. 6561 6562 * WebCoreSupport/EditorClientGtk.cpp: 6563 (WebKit::backspaceCallback): Added. 6564 (WebKit::cutClipboardCallback): Added. 6565 (WebKit::copyClipboardCallback): Added. 6566 (WebKit::pasteClipboardCallback): Added. 6567 (WebKit::selectAllCallback): Added. 6568 (WebKit::deleteFromCursorCallback): Added. 6569 (WebKit::moveCursorCallback): Added. 6570 (WebKit::EditorClient::generateEditorCommands): Added. 6571 (WebKit::EditorClient::executePendingEditorCommands): Added. 6572 (WebKit::EditorClient::handleKeyboardEvent): Derive editor commands both from internal text widget and a list of fallbacks. 6573 (WebKit::EditorClient::EditorClient): Add m_nativeWidget initializer. 6574 * WebCoreSupport/EditorClientGtk.h: 6575 (WebKit::EditorClient::addPendingEditorCommand): Add m_nativeWidget member. 6576 65772010-05-06 Martin Robinson <mrobinson@webkit.org> 6578 6579 Reviewed by Xan Lopez. 6580 6581 Remove use of GOwnPtr to hold GObject types. 6582 https://bugs.webkit.org/show_bug.cgi?id=38669 6583 6584 Change use of GOwnPtr to GRefPtr to types which are natively reference-counted. 6585 6586 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6587 (WebKit::FrameLoaderClient::dispatchWillSendRequest): Change GOwnPtr to GRefPtr in some places. 6588 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto. 6589 * webkit/webkitnetworkrequest.cpp: 6590 (webkit_network_request_new_with_core_request): Ditto. 6591 * webkit/webkitnetworkresponse.cpp: 6592 (webkit_network_response_new_with_core_response): Ditto. 6593 * webkit/webkitprivate.cpp: Remove GOwnPtr reference counting template specialization. 6594 * webkit/webkitprivate.h: Ditto. 6595 65962010-05-06 Martin Robinson <mrobinson@webkit.org> 6597 6598 Reviewed by Gustavo Noronha Silva. 6599 6600 [GTK] Enable DOM clipboard and drag-and-drop access 6601 https://bugs.webkit.org/show_bug.cgi?id=30623 6602 6603 Convert dragging portion of drag-and-drop to use DataObjectGtk. 6604 6605 * WebCoreSupport/DragClientGtk.cpp: 6606 (WebKit::DragClient::willPerformDragDestinationAction): Remove the notImplemented. It is implemented, it's just a no-op. 6607 (WebKit::DragClient::startDrag): Start the drag context via the ClipboardGtk and PasteboardHelper now. 6608 * WebCoreSupport/DragClientGtk.h: Small style fix. 6609 * webkit/webkitprivate.h: Add a HashMap of contexts and DataObjects here to to represent all current drag operations. 6610 * webkit/webkitwebview.cpp: 6611 (webkit_web_view_dispose): Clear all data objects during disposal. 6612 (webkit_web_view_drag_end): When a drag is over, just remove it from the map. 6613 (webkit_web_view_drag_data_get): To get the drag data, just grab it from the DataObject. 6614 66152010-05-03 Abhishek Arya <inferno@chromium.org> 6616 6617 Reviewed by Adam Barth. 6618 6619 Add support for controlling clipboard access from javascript. 6620 Clipboard access from javascript is disabled by default. 6621 https://bugs.webkit.org/show_bug.cgi?id=27751 6622 6623 * webkit/webkitwebsettings.cpp: 6624 (webkit_web_settings_class_init): 6625 (webkit_web_settings_set_property): 6626 (webkit_web_settings_get_property): 6627 (webkit_web_settings_copy): 6628 * webkit/webkitwebview.cpp: 6629 (webkit_web_view_update_settings): 6630 (webkit_web_view_settings_notify): 6631 66322010-05-03 Jens Alfke <snej@chromium.org> 6633 6634 Reviewed by Darin Fisher. 6635 6636 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient 6637 https://bugs.webkit.org/show_bug.cgi?id=38397 6638 6639 No tests (functionality is exposed only through native WebKit API.) 6640 6641 * WebCoreSupport/FrameLoaderClientGtk.h: 6642 (WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent): 6643 66442010-05-01 Xan Lopez <xlopez@igalia.com> 6645 6646 Reviewed by Oliver Hunt. 6647 6648 [GTK] GObject DOM bindings 6649 https://bugs.webkit.org/show_bug.cgi?id=33590 6650 6651 Test webkit_dom_document_get_links. 6652 6653 * tests/testdomdocument.c: 6654 (test_dom_document_get_links): 6655 (main): 6656 66572010-04-29 Xan Lopez <xlopez@igalia.com> 6658 6659 Reviewed by Gustavo Noronha. 6660 6661 [GTK] GObject DOM bindings 6662 https://bugs.webkit.org/show_bug.cgi?id=33590 6663 6664 Test webkit_dom_document_get_element_by_id; 6665 6666 * tests/testdomdocument.c: 6667 (test_dom_document_get_element_by_id): 6668 (main): 6669 66702010-04-29 Xan Lopez <xlopez@igalia.com> 6671 6672 Reviewed by Gustavo Noronha. 6673 6674 [GTK] GObject DOM bindings 6675 https://bugs.webkit.org/show_bug.cgi?id=33590 6676 6677 Test webkit_dom_document_get_elements_by_class_name. 6678 6679 * tests/testdomdocument.c: 6680 (test_dom_document_get_elements_by_class_name): 6681 (main): 6682 66832010-04-29 Xan Lopez <xlopez@igalia.com> 6684 6685 Reviewed by Gustavo Noronha. 6686 6687 [GTK] GObject DOM bindings 6688 https://bugs.webkit.org/show_bug.cgi?id=33590 6689 6690 Test webkit_dom_document_get_elements_by_tag_name. 6691 6692 * tests/testdomdocument.c: 6693 (test_dom_document_get_elements_by_tag_name): 6694 (main): 6695 66962010-04-29 Xan Lopez <xlopez@igalia.com> 6697 6698 Reviewed by Gustavo Noronha. 6699 6700 [GTK] GObject DOM bindings 6701 https://bugs.webkit.org/show_bug.cgi?id=33590 6702 6703 Move WebKitDOMDocument unit tests to their own file. 6704 6705 * tests/testdomdocument.c: Added. 6706 (finish_loading): 6707 (dom_document_fixture_setup): 6708 (dom_document_fixture_teardown): 6709 (test_dom_document_title): 6710 (main): 6711 * tests/testwebview.c: 6712 67132010-04-29 Xan Lopez <xlopez@igalia.com> 6714 6715 Reviewed by Gustavo Noronha. 6716 6717 [GTK] GObject DOM bindings 6718 https://bugs.webkit.org/show_bug.cgi?id=33590 6719 6720 Include <webkit/webkitdom.h> in the main webkit.h header. 6721 6722 * webkit/webkit.h: 6723 67242010-04-25 Sam Weinig <sam@webkit.org> 6725 6726 Reviewed by Maciej Stachowiak. 6727 6728 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097 6729 Disentangle initializing the main thread from initializing threading 6730 6731 * webkit/webkitprivate.cpp: 6732 (webkit_init): Add call to initializeMainThread. 6733 67342010-04-22 Dave Moore <davemoore@chromium.org> 6735 6736 Reviewed by Dimitri Glazkov. 6737 6738 Added notification when the favicons for a page are changed 6739 from a script. 6740 The Document object will notify the frame loader, which will 6741 notify the client. Implementations of FrameLoaderClient will 6742 have to add one method; dispatchDidChangeIcons(). 6743 6744 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6745 (WebKit::FrameLoaderClient::dispatchDidChangeIcons): 6746 * WebCoreSupport/FrameLoaderClientGtk.h: 6747 67482010-04-22 Xan Lopez <xlopez@igalia.com> 6749 6750 Reviewed by Gustavo Noronha. 6751 6752 [GTK] GObject DOM bindings 6753 https://bugs.webkit.org/show_bug.cgi?id=33590 6754 6755 Add webkit_web_view_get_document to retrieve the WebKitDOMDocument 6756 from a WebKitWebView, and a very simple test for it. 6757 6758 * tests/testwebview.c: 6759 * webkit/webkitwebview.cpp: 6760 (webkit_web_view_get_document): 6761 * webkit/webkitwebview.h: 6762 67632010-04-22 Diego Escalante Urrelo <descalante@igalia.com> 6764 6765 Reviewed by Xan Lopez. 6766 6767 [Gtk] Evaluate and create tests for all the AtkRole's implemented by 6768 WebKitGtk 6769 https://bugs.webkit.org/show_bug.cgi?id=34449 6770 6771 Expand testatkroles to test ATK_ROLE_COMBO_BOX. 6772 6773 * tests/testatkroles.c: 6774 (test_webkit_atk_get_role_combobox): 6775 (main): 6776 67772010-04-22 Diego Escalante Urrelo <descalante@igalia.com> 6778 6779 Reviewed by Xan Lopez. 6780 6781 [Gtk] Evaluate and create tests for all the AtkRole's implemented by 6782 WebKitGtk 6783 https://bugs.webkit.org/show_bug.cgi?id=34449 6784 6785 Expand testatkroles to test ATK_ROLE_SEPARATOR. 6786 6787 * tests/testatkroles.c: 6788 (test_webkit_atk_get_role_separator): 6789 (main): 6790 67912010-04-22 Adam Barth <abarth@webkit.org> 6792 6793 Unreviewed, rolling out r58069. 6794 http://trac.webkit.org/changeset/58069 6795 https://bugs.webkit.org/show_bug.cgi?id=27751 6796 6797 Broke compile on Windows. 6798 6799 * webkit/webkitwebsettings.cpp: 6800 (webkit_web_settings_class_init): 6801 (webkit_web_settings_set_property): 6802 (webkit_web_settings_get_property): 6803 (webkit_web_settings_copy): 6804 * webkit/webkitwebview.cpp: 6805 (webkit_web_view_update_settings): 6806 (webkit_web_view_settings_notify): 6807 68082010-04-22 Abhishek Arya <inferno@chromium.org> 6809 6810 Reviewed by Adam Barth. 6811 6812 Add support for controlling clipboard access from javascript. 6813 Clipboard access from javascript is disabled by default. 6814 https://bugs.webkit.org/show_bug.cgi?id=27751 6815 6816 * webkit/webkitwebsettings.cpp: 6817 (webkit_web_settings_class_init): 6818 (webkit_web_settings_set_property): 6819 (webkit_web_settings_get_property): 6820 (webkit_web_settings_copy): 6821 * webkit/webkitwebview.cpp: 6822 (webkit_web_view_update_settings): 6823 (webkit_web_view_settings_notify): 6824 68252010-04-21 Jakub Wieczorek <jwieczorek@webkit.org> 6826 6827 Reviewed by Darin Adler. 6828 6829 List item markers are not always updated after changes in the DOM. 6830 https://bugs.webkit.org/show_bug.cgi?id=37060 6831 6832 * webkit/webkitprivate.h: 6833 * webkit/webkitwebframe.cpp: 6834 (webkit_web_frame_marker_text_for_list_item): Add a private API to get the marker text for a list item. 6835 68362010-04-21 Diego Escalante Urrelo <descalante@igalia.com> 6837 6838 Reviewed by Xan Lopez. 6839 6840 [Gtk] Evaluate and create tests for all the AtkRole's implemented by 6841 WebKitGtk 6842 https://bugs.webkit.org/show_bug.cgi?id=34449 6843 6844 Expand testatkroles to test ATK_ROLE_FORM. 6845 6846 * tests/testatkroles.c: 6847 (test_webkit_atk_get_role_form): 6848 (main): 6849 68502010-04-20 Adam Barth <abarth@webkit.org> 6851 6852 Reviewed by Eric Seidel. 6853 6854 Factor DocumentWriter out of FrameLoader 6855 https://bugs.webkit.org/show_bug.cgi?id=37175 6856 6857 Update these callsites because the method moved to DocumentWriter. 6858 6859 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6860 (WebKit::FrameLoaderClient::committedLoad): 6861 (WebKit::FrameLoaderClient::finishedLoading): 6862 * webkit/webkitwebview.cpp: 6863 (webkit_web_view_get_encoding): 6864 68652010-04-20 Kent Tamura <tkent@chromium.org> 6866 6867 Reviewed by Darin Adler. 6868 6869 Change a parameter type of chooseIconForFiles() 6870 https://bugs.webkit.org/show_bug.cgi?id=37504 6871 6872 * WebCoreSupport/ChromeClientGtk.cpp: 6873 (WebKit::ChromeClient::chooseIconForFiles): 6874 * WebCoreSupport/ChromeClientGtk.h: 6875 68762010-04-20 Martin Robinson <mrobinson@webkit.org> 6877 6878 Reviewed by Gustavo Noronha Silva. 6879 6880 [GTK] Enable DOM clipboard and drag-and-drop access 6881 https://bugs.webkit.org/show_bug.cgi?id=30623 6882 6883 Move most of the PasteboardHelper logic into WebCore. This helps 6884 prepare for WebKit2 and leads to a clearer separation of concerns 6885 between the WebKit and WebCore layers. 6886 6887 * WebCoreSupport/EditorClientGtk.cpp: 6888 (WebKit::collapseSelection): Converted this logic to a GClosure callback. 6889 (WebKit::EditorClient::respondToChangedSelection): Collapse selection via GClosure now. 6890 * WebCoreSupport/PasteboardHelperGtk.cpp: Moved most of the code to WebCore. 6891 (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): This constructor just initializes the target list. 6892 (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): The destructor no longer needs to free the target list. 6893 (WebKit::PasteboardHelperGtk::getIdForTargetType): Added, virtual method for getting target ids. 6894 (WebKit::PasteboardHelperGtk::usePrimarySelectionClipboard): Added, virtual method for querying current clipboard. 6895 * WebCoreSupport/PasteboardHelperGtk.h: Update method list to reflect reduced functionality. 6896 68972010-04-19 Diego Escalante Urrelo <descalante@igalia.com> 6898 6899 Reviewed by Xan Lopez. 6900 6901 [Gtk] Evaluate and create tests for all the AtkRole's implemented by 6902 WebKitGtk 6903 https://bugs.webkit.org/show_bug.cgi?id=34449 6904 6905 Expand testatkroles to test ATK form roles. 6906 6907 * tests/testatkroles.c: 6908 (test_webkit_atk_get_role_check_box): 6909 (test_webkit_atk_get_role_entry): 6910 (test_webkit_atk_get_role_label): 6911 (test_webkit_atk_get_role_listbox): 6912 (test_webkit_atk_get_role_password_text): 6913 (test_webkit_atk_get_role_push_button): 6914 (test_webkit_atk_get_role_radio_button): 6915 (main): 6916 69172010-04-19 Diego Escalante Urrelo <descalante@igalia.com> 6918 6919 Reviewed by Xan Lopez. 6920 6921 [Gtk] Evaluate and create tests for all the AtkRole's implemented by 6922 WebKitGtk 6923 https://bugs.webkit.org/show_bug.cgi?id=34449 6924 6925 Add testatkroles to test ATK non form roles. 6926 6927 * tests/testatkroles.c: Added. 6928 (finish_loading): 6929 (atk_roles_fixture_setup): 6930 (atk_roles_fixture_teardown): 6931 (get_child_and_test_role): 6932 (test_webkit_atk_get_role_document_frame): 6933 (test_webkit_atk_get_role_heading): 6934 (test_webkit_atk_get_role_image): 6935 (test_webkit_atk_get_role_link): 6936 (test_webkit_atk_get_role_list_and_item): 6937 (test_webkit_atk_get_role_paragraph): 6938 (test_webkit_atk_get_role_section): 6939 (test_webkit_atk_get_role_table): 6940 (main): 6941 69422010-04-17 Alejandro G. Castro <alex@igalia.com> 6943 6944 Reviewed by Xan Lopez. 6945 6946 We have to initialize the timer attribute after destroying it, not 6947 doing it was causing crashes in some situations. 6948 6949 * webkit/webkitdownload.cpp: 6950 (webkit_download_finalize): 6951 69522010-04-13 Timothy Hatcher <timothy@apple.com> 6953 6954 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry. 6955 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists. 6956 6957 SecurityOrigin needs a way to remove individual OriginAccessEntries 6958 https://bugs.webkit.org/show_bug.cgi?id=37449 6959 6960 Reviewed by Dave Hyatt. 6961 6962 * webkit/webkitprivate.cpp: 6963 (webkit_white_list_access_from_origin): 6964 (webkit_reset_origin_access_white_lists): 6965 69662010-04-11 Sheriff Bot <webkit.review.bot@gmail.com> 6967 6968 Unreviewed, rolling out r57468. 6969 http://trac.webkit.org/changeset/57468 6970 https://bugs.webkit.org/show_bug.cgi?id=37433 6971 6972 Broke the world... Must have applied the patch wrong 6973 (Requested by abarth on #webkit). 6974 6975 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6976 (WebKit::FrameLoaderClient::committedLoad): 6977 (WebKit::FrameLoaderClient::finishedLoading): 6978 * webkit/webkitwebview.cpp: 6979 (webkit_web_view_get_encoding): 6980 69812010-04-11 Adam Barth <abarth@webkit.org> 6982 6983 Reviewed by Eric Seidel. 6984 6985 Factor DocumentWriter out of FrameLoader 6986 https://bugs.webkit.org/show_bug.cgi?id=37175 6987 6988 Update these callsites because the method moved to DocumentWriter. 6989 6990 * WebCoreSupport/FrameLoaderClientGtk.cpp: 6991 (WebKit::FrameLoaderClient::committedLoad): 6992 (WebKit::FrameLoaderClient::finishedLoading): 6993 * webkit/webkitwebview.cpp: 6994 (webkit_web_view_get_encoding): 6995 69962010-04-07 Andrey Kosyakov <caseq@chromium.org> 6997 6998 Reviewed by Yury Semikhatsky. 6999 7000 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest() 7001 https://bugs.webkit.org/show_bug.cgi?id=36949 7002 7003 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7004 * WebCoreSupport/FrameLoaderClientGtk.h: 7005 70062010-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7007 7008 Reviewed by Holger Freyther. 7009 7010 [GTK] webkit_get_default_session() should make sure webkit_init() is called 7011 https://bugs.webkit.org/show_bug.cgi?id=36754 7012 7013 Make sure global functions that do not require a WebKitWebView to 7014 be created call webkit_init() before doing their job. Also add an 7015 API test to check for that. 7016 7017 * tests/testglobals.c: Added. 7018 (test_globals_default_session): 7019 (main): 7020 * webkit/webkitwebview.cpp: 7021 (webkit_get_default_session): 7022 (webkit_set_cache_model): 7023 (webkit_get_cache_model): 7024 70252010-03-31 Marcus Bulach <bulach@chromium.org> 7026 7027 Reviewed by Jeremy Orlow. 7028 7029 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame. 7030 https://bugs.webkit.org/show_bug.cgi?id=35031 7031 7032 * WebCoreSupport/ChromeClientGtk.cpp: 7033 (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame): 7034 * WebCoreSupport/ChromeClientGtk.h: 7035 70362010-03-30 Gavin Barraclough <barraclough@apple.com> 7037 7038 Rubber stamped by Sam Weinig. 7039 7040 https://bugs.webkit.org/show_bug.cgi?id=36866 7041 Move CString to WTF 7042 7043 * WebCoreSupport/ChromeClientGtk.cpp: 7044 * WebCoreSupport/ContextMenuClientGtk.cpp: 7045 * WebCoreSupport/EditorClientGtk.cpp: 7046 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7047 * WebCoreSupport/InspectorClientGtk.cpp: 7048 * gdom/ConvertToGCharPrivate.h: 7049 * webkit/webkitdownload.cpp: 7050 * webkit/webkithittestresult.cpp: 7051 * webkit/webkitnetworkrequest.cpp: 7052 * webkit/webkitprivate.h: 7053 * webkit/webkitsecurityorigin.cpp: 7054 * webkit/webkitwebdatabase.cpp: 7055 * webkit/webkitwebframe.cpp: 7056 * webkit/webkitwebhistoryitem.cpp: 7057 (webkit_web_history_item_finalize): 7058 (webkit_web_history_item_get_target): 7059 * webkit/webkitwebresource.cpp: 7060 * webkit/webkitwebsettings.cpp: 7061 * webkit/webkitwebview.cpp: 7062 70632010-03-28 Alexey Proskuryakov <ap@apple.com> 7064 7065 Build fix. Include WindowsKeyboardCodes.h instead of KeyboardCodes.h. 7066 7067 * WebCoreSupport/EditorClientGtk.cpp: 7068 70692010-03-27 Sergio Villar Senin <svillar@igalia.com> 7070 7071 Reviewed by Eric Seidel. 7072 7073 FrameLoader emits onload-event when handling 7074 dispatchDidHandleOnloadEvents 7075 7076 [GTK] Improve reporting of frame loader callbacks in DRT 7077 https://bugs.webkit.org/show_bug.cgi?id=36454 7078 7079 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7080 (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents): 7081 implemented, now it emits onload-event signal 7082 * webkit/webkitwebview.cpp: added onload-event signal 7083 70842010-03-25 Sergio Villar SenÃn <svillar@igalia.com> 7085 7086 Reviewed by Xan Lopez. 7087 7088 Added new API webkit_web_back_forward_list_clear. This function 7089 clears the back forward list 7090 7091 [GTK] http/history tests are failing 7092 https://bugs.webkit.org/show_bug.cgi?id=36173 7093 7094 * tests/testwebbackforwardlist.c: 7095 (test_webkit_web_back_forward_list_clear): 7096 (main): added new unit test for the new API 7097 * webkit/webkitwebbackforwardlist.cpp: 7098 (webkit_web_back_forward_list_clear): 7099 * webkit/webkitwebbackforwardlist.h: new function that clears the 7100 back forward list 7101 71022010-03-24 Kent Tamura <tkent@chromium.org> 7103 7104 Reviewed by Darin Adler. 7105 7106 Make Icon::createIconForFiles() optional. 7107 https://bugs.webkit.org/show_bug.cgi?id=35072 7108 7109 - Rename iconForFiles() to chooseIconForFiles(). 7110 - Call Icon::createIconForFiles() from chooseIconForFiles(). 7111 7112 * WebCoreSupport/ChromeClientGtk.cpp: 7113 * WebCoreSupport/ChromeClientGtk.h: 7114 71152010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7116 7117 Reviewed by Holger Freyther. 7118 7119 [GTK] Does not build with latest GTK+ development release 7120 https://bugs.webkit.org/show_bug.cgi?id=36398 7121 7122 Fix building with newest GTK+ versions. 7123 7124 * WebCoreSupport/ChromeClientGtk.cpp: 7125 (WebKit::ChromeClient::windowRect): 7126 (WebKit::ChromeClient::setWindowRect): 7127 (WebKit::ChromeClient::unfocus): 7128 (WebKit::ChromeClient::canTakeFocus): 7129 (WebKit::ChromeClient::contentsSizeChanged): 7130 * webkit/webkitprivate.cpp: 7131 (currentToplevelCallback): 7132 * webkit/webkitwebframe.cpp: 7133 (webkit_web_frame_print_full): 7134 (webkit_web_frame_print): 7135 * webkit/webkitwebview.cpp: 7136 (webkit_web_view_grab_focus): 7137 (webkit_web_view_focus_in_event): 7138 (webkit_web_view_script_dialog): 7139 71402010-03-18 Philip Chimento <philip.chimento@gmail.com> 7141 7142 Reviewed by Oliver Hunt. 7143 7144 Setting the GObject WebKitWebView property 'window-features' to NULL 7145 causes a crash. 7146 https://bugs.webkit.org/show_bug.cgi?id=36144 7147 7148 * tests/testwebview.c: Add unit test for this bug. 7149 * webkit/webkitwebview.cpp: Don't allow the 'window-features' property 7150 to be set to NULL. 7151 * webkit/webkitwebwindowfeatures.cpp: 7152 (webkit_web_window_features_equal): Don't examine the members of either 7153 web_window_features argument if either is NULL, just return that they 7154 are not equal. Additionally, if they are the same object, return that 7155 they are equal. 7156 71572010-03-16 Xan Lopez <xlopez@igalia.com> 7158 7159 Reviewed by Gustavo Noronha. 7160 7161 Update for 1.1.90 release. 7162 7163 * NEWS: 7164 71652010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7166 7167 Fix one too many empty lines in documentation of 7168 window-obejct-cleared signal, which caused the documentation to be 7169 rendered funny. Thanks to Martin Robinson for noticing. 7170 7171 * webkit/webkitwebview.cpp: 7172 71732010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7174 7175 Unreviewed. Add missing symbol to GeoLocation documentation 7176 section. 7177 7178 * docs/webkitgtk-sections.txt: 7179 71802010-03-16 Martin Robinson <mrobinson@webkit.org> 7181 7182 Reviewed by Xan Lopez. 7183 7184 can't input korean into lower all input box except adress input box in webkit gtk launcher 7185 https://bugs.webkit.org/show_bug.cgi?id=32290 7186 7187 Make the GTK+ EditorClient properly handle different types of input module 7188 behavior such as commit and preedit signals that happen outside of key event 7189 filtering and multiple times in a row. Filter keyup events as well as keydown 7190 events and call gtk_im_context_focus_{in/out} when the WebView focus changes. 7191 7192 Added tests for this behavior to the GTK+ unit tests. 7193 7194 * WebCoreSupport/EditorClientGtk.cpp: 7195 (WebKit::imContextCommitted): Handle this signal properly when it happens outside of 7196 key event filtering. 7197 (WebKit::imContextPreeditChanged): Immediately update the preedit state and do not reject 7198 empty preedits, so that cancellation works properly. 7199 (WebKit::EditorClient::updatePendingComposition): Add this method, which handles the 7200 situation where a commit signal happens when there is still a pending commit. 7201 (WebKit::EditorClient::shouldBeginEditing): Clear pending composition state before editing 7202 starts. 7203 (WebKit::EditorClient::shouldEndEditing): Clear pending composition state before editing ends. 7204 (WebKit::EditorClient::handleKeyboardEvent): No longer special case preedits which happen during 7205 key event filtering. When confirming a pending composition use insertText instead of confirmComposition. 7206 (WebKit::EditorClient::handleInputMethodKeydown): 7207 * WebCoreSupport/EditorClientGtk.h: Make pendingComposition a member, so that multiple WebViews 7208 do not share state. 7209 (WebKit::EditorClient::webView): Added. 7210 (WebKit::EditorClient::treatContextCommitAsKeyEvent): Added. 7211 (WebKit::EditorClient::clearPendingComposition): Added. 7212 * tests/testkeyevents.c: 7213 (test_keypress_events_load_status_cb): 7214 (map_event_cb): 7215 (setup_keyevent_test): 7216 (test_keypress_events): 7217 (element_text_equal_to): 7218 (test_ime_load_status_cb): 7219 (test_ime): 7220 (main): 7221 * webkit/webkitwebview.cpp: 7222 (webkit_web_view_key_release_event): 7223 (webkit_web_view_focus_in_event): 7224 72252010-03-16 Yury Semikhatsky <yurys@chromium.org> 7226 7227 Reviewed by Pavel Feldman. 7228 7229 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost. 7230 7231 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder 7232 https://bugs.webkit.org/show_bug.cgi?id=35036 7233 7234 * WebCoreSupport/InspectorClientGtk.cpp: 7235 (WebKit::notifyWebViewDestroyed): 7236 (WebKit::InspectorClient::InspectorClient): 7237 (WebKit::InspectorClient::inspectorDestroyed): 7238 (WebKit::InspectorClient::openInspectorFrontend): 7239 (WebKit::InspectorClient::highlight): 7240 (WebKit::InspectorClient::hideHighlight): 7241 (WebKit::InspectorClient::populateSetting): 7242 (WebKit::InspectorClient::storeSetting): 7243 (WebKit::InspectorFrontendClient::InspectorFrontendClient): 7244 (WebKit::InspectorFrontendClient::~InspectorFrontendClient): 7245 (WebKit::InspectorFrontendClient::destroyInspectorWindow): 7246 (WebKit::InspectorFrontendClient::localizedStringsURL): 7247 (WebKit::InspectorFrontendClient::hiddenPanels): 7248 (WebKit::InspectorFrontendClient::bringToFront): 7249 (WebKit::InspectorFrontendClient::closeWindow): 7250 (WebKit::InspectorFrontendClient::attachWindow): 7251 (WebKit::InspectorFrontendClient::detachWindow): 7252 (WebKit::InspectorFrontendClient::setAttachedWindowHeight): 7253 (WebKit::InspectorFrontendClient::inspectedURLChanged): 7254 * WebCoreSupport/InspectorClientGtk.h: 7255 72562010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com> 7257 7258 Reviewed by Holger Freyther. 7259 7260 https://bugs.webkit.org/show_bug.cgi?id=35502 7261 [Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText 7262 7263 New test to be sure we do not accidentally implement AtkText for tables 7264 7265 * tests/testatk.c 7266 (testWebkitAtkGetTextInTable): 7267 (main): 7268 72692010-03-09 Philippe Normand <pnormand@igalia.com> 7270 7271 Reviewed by Holger Freyther. 7272 7273 [GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20 7274 https://bugs.webkit.org/show_bug.cgi?id=35909 7275 7276 * webkit/webkitwebview.cpp: GTK_WIDGET_IS_SENSITIVE has been 7277 deprecated in gtk 2.20. Use gtk_widget_is_sensitive when available. 7278 72792010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7280 7281 Rubber-stamped by Kenneth Rohde Christiansen. 7282 7283 Misc documentation fixes. Fixes (almost) all warnings emitted by 7284 the documentation build process. Only the broken references to JSC 7285 objects remain. 7286 7287 * webkit/webkitsecurityorigin.cpp: 7288 * webkit/webkitwebbackforwardlist.cpp: 7289 * webkit/webkitwebdatasource.cpp: 7290 * webkit/webkitwebframe.cpp: 7291 * webkit/webkitwebhistoryitem.cpp: 7292 * webkit/webkitwebinspector.cpp: 7293 (webkit_web_inspector_class_init): 7294 * webkit/webkitwebsettings.cpp: 7295 (webkit_web_settings_class_init): 7296 * webkit/webkitwebview.cpp: 7297 (DNDContentsRequest::webkit_web_view_class_init): 7298 72992010-03-11 Anders Carlsson <andersca@apple.com> 7300 7301 Reviewed by David Hyatt. 7302 7303 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents. 7304 7305 * WebCoreSupport/ChromeClientGtk.cpp: 7306 * WebCoreSupport/ChromeClientGtk.h: 7307 73082010-03-09 Philippe Normand <pnormand@igalia.com> 7309 7310 Reviewed by Gustavo Noronha Silva. 7311 7312 [GTK] testkeyevents doesn't stop if input event injection fails 7313 https://bugs.webkit.org/show_bug.cgi?id=35922 7314 7315 * tests/testkeyevents.c: 7316 (load_status_cb): Added a safeguard to exit from the test if the 7317 input event injection failed. 7318 73192010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7320 7321 Unreviewed. Documentation control files update for 1.1.23. 7322 7323 * docs/webkitgtk-docs.sgml: 7324 73252010-03-08 Csaba Osztrogonác <ossy@webkit.org> 7326 7327 [GTK] Unreviewed buildfix after r55688. 7328 7329 * webkit/webkitdownload.cpp: 7330 (webkit_download_start): 7331 73322010-03-02 Adam Treat <atreat@rim.com> 7333 7334 Reviewed by Dave Hyatt. 7335 7336 Adapt the gtk port to the refactoring of repaint methods. 7337 7338 https://bugs.webkit.org/show_bug.cgi?id=34214 7339 7340 * WebCoreSupport/ChromeClientGtk.cpp: 7341 * WebCoreSupport/ChromeClientGtk.h: 7342 73432010-03-08 Eric Uhrhane <ericu@chromium.org> 7344 7345 Reviewed by David Levin. 7346 7347 Remove the now-redundant Settings fields for the Database 7348 https://bugs.webkit.org/show_bug.cgi?id=35763 7349 7350 No new tests; this code isn't called. 7351 7352 * webkit/webkitwebview.cpp: Remove the calls into Settings. 7353 (DNDContentsRequest::webkit_web_view_update_settings): 7354 (DNDContentsRequest::webkit_web_view_settings_notify): 7355 73562010-03-06 Arno Renevier <arno@renevier.net> 7357 7358 Reviewed by Eric Seidel. 7359 7360 [Gtk] GEOLOCATION_POLICY_DECISION_CANCELLED unused 7361 https://bugs.webkit.org/show_bug.cgi?id=35803 7362 7363 * webkit/webkitwebview.cpp: 7364 (DNDContentsRequest::webkit_web_view_class_init): 7365 73662010-03-03 Antonio Gomes <tonikitoo@webkit.org> 7367 7368 Reviewed by Gustavo Noronha. 7369 Patch by Antonio Gomes <tonikitoo@webkit.org> 7370 7371 [Gtk] Add 'enable-spatial-navigation' setting for toggle Spatial Navigation on/off 7372 https://bugs.webkit.org/show_bug.cgi?id=35701 7373 7374 * webkit/webkitwebsettings.cpp: 7375 (webkit_web_settings_class_init): 7376 (webkit_web_settings_set_property): 7377 (webkit_web_settings_get_property): 7378 (webkit_web_settings_copy): 7379 * webkit/webkitwebview.cpp: 7380 (DNDContentsRequest::webkit_web_view_update_settings): 7381 (DNDContentsRequest::webkit_web_view_settings_notify): 7382 73832010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch> 7384 7385 Reviewed by Xan Lopez. 7386 7387 Miscellaneous little fixes for the windows build of webkit-gtk 7388 https://bugs.webkit.org/show_bug.cgi?id=35640 7389 7390 * webkit/webkitdownload.cpp: Windows headers define ERROR 7391 which breaks the build. Undef ERROR if it is defined. 7392 73932010-03-03 Philippe Normand <pnormand@igalia.com> 7394 7395 Unreviewed, build fix after r55452. 7396 7397 * webkit/webkitwebview.cpp: 7398 (DNDContentsRequest::webkit_web_view_settings_notify): added missing braces. 7399 74002010-03-02 Eric Uhrhane <ericu@chromium.org> 7401 7402 Reviewed by David Levin. 7403 7404 Move database enable bit fully out of settings 7405 This is stage one of a three-stage commit [webkit, then chromium, then 7406 webkit again]. In this change I'm adding calls to 7407 Database::setIsAvailable inside Settings::setDatabaseEnabled and 7408 anywhere else that called it, and switching webkit fully over to using 7409 that flag [added in a previous checkin]. Phase two will remove 7410 Chromium's use of Settings for the Database, and phase three will remove 7411 the Setting for the Database enable entirely, leaving only 7412 Database::isAvailable/setIsAvailable. 7413 7414 No new tests; tested by existing storage tests. 7415 7416 https://bugs.webkit.org/show_bug.cgi?id=35310 7417 7418 * webkit/webkitwebview.cpp: Add calls to Database::setIsAvailable 7419 (DNDContentsRequest::webkit_web_view_update_settings): 7420 (DNDContentsRequest::webkit_web_view_settings_notify): 7421 74222010-03-02 Arno Renevier <arno@renevier.net> 7423 7424 Reviewed by Gustavo Noronha Silva. 7425 7426 [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame 7427 https://bugs.webkit.org/show_bug.cgi?id=35210 7428 7429 * WebCoreSupport/ChromeClientGtk.cpp: 7430 * WebCoreSupport/ChromeClientGtk.h: 7431 * docs/webkitgtk-sections.txt: 7432 * webkit/webkit.h: 7433 * webkit/webkitdefines.h: 7434 * webkit/webkitgeolocationpolicydecision.cpp: Added. 7435 (webkit_geolocation_policy_decision_class_init): 7436 (webkit_geolocation_policy_decision_init): 7437 (webkit_geolocation_policy_decision_new): 7438 (webkit_geolocation_policy_allow): 7439 (webkit_geolocation_policy_deny): 7440 * webkit/webkitgeolocationpolicydecision.h: Added. 7441 * webkit/webkitprivate.h: 7442 * webkit/webkitwebview.cpp: 7443 (DNDContentsRequest::webkit_web_view_class_init): 7444 * webkitmarshal.list: 7445 74462010-03-01 José Millán Soto <jmillan@igalia.com> 7447 7448 Reviewed by Gustavo Noronha Silva. 7449 7450 [GTK] Right click does not activate text entry 7451 https://bugs.webkit.org/show_bug.cgi?id=29177 7452 7453 Makes the frame handle the mouse click event before sending the 7454 context menu event. 7455 7456 * webkit/webkitwebview.cpp: 7457 (PopupMenuPositionFunc): 7458 Function created to make the popup menu appear in the correct position, especially 7459 when invoked from the keyboard. 7460 (webkit_web_view_forward_context_menu_event): 7461 Mouse click event is sent to frame before creating context menu, 7462 PopupMenuPositionFunc used to determine the position where the menu should appear. 7463 (webkit_web_view_popup_menu_handler): 7464 Improved focused node position detection. Event button set to right button. 7465 74662010-03-01 Jakob Petsovits <jpetsovits@rim.com> 7467 7468 Reviewed by Adam Barth. 7469 7470 Adapt to the new ZoomMode enum. 7471 https://bugs.webkit.org/show_bug.cgi?id=35347 7472 7473 * webkit/webkitwebview.cpp: 7474 (DNDContentsRequest::webkit_web_view_apply_zoom_level): 7475 74762010-03-01 Kalle Vahlman <zuh@iki.fi> 7477 7478 Reviewed by Gustavo Noronha Silva. 7479 7480 Queue a resize when either of the content dimensions change 7481 https://bugs.webkit.org/show_bug.cgi?id=35489 7482 7483 The check for size changes only queued a resize if both of the content 7484 dimensions change, leaving the widget size out-of-sync if eg. only the 7485 width changes. 7486 7487 * WebCoreSupport/ChromeClientGtk.cpp: 7488 74892009-12-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7490 7491 Reviewed by Xan Lopez. 7492 7493 [GTK] Needs proper reporting of frame loader callbacks, in DRT 7494 https://bugs.webkit.org/show_bug.cgi?id=32170 7495 7496 Add new signal to report when the document load is finished for a 7497 frame. 7498 7499 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7500 (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad): 7501 * webkit/webkitwebview.cpp: 7502 (webkit_web_view_class_init): 7503 75042010-02-26 Antonio Gomes <tonikitoo@webkit.org> 7505 7506 Complementary commit of r55300. Missing "notify::" to signal name. 7507 7508 * tests/testwebview.c: 7509 (test_webkit_web_view_grab_focus): 7510 75112010-02-26 Antonio Gomes <tonikitoo@webkit.org> 7512 7513 Reviewed by Xan Lopez. 7514 Patch by Antonio Gomes <tonikitoo@webkit.org> 7515 7516 [GTK] Make webkit_web_view_grab_focus to active focus controller. 7517 https://bugs.webkit.org/show_bug.cgi?id=35402 7518 7519 When programatically setting focus to an element in an inner document, 7520 calling "hasFocus()" from this document returns FALSE, because 7521 document's FocusController is not activated. It does not happen 7522 if |document| is the main document. 7523 7524 Making webkit_web_view_grab_focus to actually activate the FocusController, 7525 fixes the issue. 7526 7527 * tests/testwebview.c: 7528 (server_callback): 7529 (test_webkit_web_view_grab_focus): 7530 * webkit/webkitwebview.cpp: 7531 (webkit_web_view_grab_focus): 7532 75332010-02-26 Alejandro G. Castro <alex@igalia.com> 7534 7535 Unreviewed. 7536 7537 Reverted last patch (r55295), it causes problems with the frames. 7538 7539 * WebCoreSupport/ChromeClientGtk.cpp: 7540 75412010-02-19 Alejandro G. Castro <alex@igalia.com> 7542 7543 Reviewed by Xan Lopez. 7544 7545 [GTK] Some region checks in scroll are not required 7546 https://bugs.webkit.org/show_bug.cgi?id=35142 7547 7548 Removes some of the operations checking the moved and invalidated 7549 regions when scrolling, it is done already in 7550 gdk_window_move_region. 7551 7552 * WebCoreSupport/ChromeClientGtk.cpp: 7553 75542010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7555 7556 Reviewed by Xan Lopez. 7557 7558 [Gtk] crashed when destroying 7559 https://bugs.webkit.org/show_bug.cgi?id=31271 7560 7561 NULL-check the page before relaying the focus out event, since 7562 this might happen when destroying the widget without destroying 7563 its parent, and we currently crash. 7564 7565 * tests/testwebview.c: 7566 (delayed_destroy): 7567 (test_webkit_web_view_destroy): 7568 (main): 7569 * webkit/webkitwebview.cpp: 7570 (webkit_web_view_focus_in_event): 7571 75722010-02-24 Krzysztof Kotlenga <pocek@users.sf.net> 7573 7574 Reviewed by Gustavo Noronha Silva. 7575 7576 [Gtk] Creation of a WebkitWebView widget is very slow 7577 https://bugs.webkit.org/show_bug.cgi?id=30032 7578 7579 * WebCoreSupport/EditorClientGtk.cpp: 7580 (WebKit::EditorClient::ignoreWordInSpellDocument): Change 'langs' to 'dicts' 7581 to reflect the fact that the list just holds Enchant dictionaries now. 7582 (WebKit::EditorClient::learnWord): Ditto. 7583 (WebKit::EditorClient::checkSpellingOfString): Ditto. 7584 (WebKit::EditorClient::getGuessesForWord): Ditto. 7585 * webkit/webkitprivate.h: Remove the now unused SpellLanguage struct. 7586 * webkit/webkitwebsettings.cpp: Change function call to reflect new 7587 webkit_web_settings_get_enchant_dicts name. 7588 (get_enchant_broker): Add this method which returns the enchant broker singleton. 7589 (free_spell_checking_language): The list contents have changed, so change 7590 the way each element is freed. 7591 (webkit_web_settings_finalize): Change to reflect 'spell_checking_languages_list' 7592 to 'enchant_dicts' member name change. 7593 (webkit_web_settings_set_property): Use the broker singleton here instead of making 7594 a new one for each language. The Enchant dictionary is now the list payload. 7595 (webkit_web_settings_copy): More name-change updates. 7596 (webkit_web_settings_get_enchant_dicts): Ditto. 7597 75982010-02-23 Leandro Pereira <leandro@profusion.mobi> 7599 7600 Reviewed by Gustavo Noronha Silva. 7601 7602 Fixes references to GOwnPtr and GRefPtr so the GTK+ port builds 7603 again. 7604 http://webkit.org/b/35084 7605 7606 * WebKit/gtk/webkit/webkitwebview.cpp: 7607 76082010-02-23 Shinichiro Hamaji <hamaji@chromium.org> 7609 7610 Reviewed by Eric Seidel. 7611 7612 [Gtk] Implement layoutTestController.numberOfPages 7613 https://bugs.webkit.org/show_bug.cgi?id=35228 7614 7615 * webkit/webkitprivate.h: 7616 * webkit/webkitwebframe.cpp: 7617 (webkit_web_frame_number_of_pages): 7618 76192010-02-23 José Millán Soto <jmillan@igalia.com> 7620 7621 Reviewed by Xan Lopez. 7622 7623 [Gtk] Server message not shown on http authentication 7624 https://bugs.webkit.org/show_bug.cgi?id=34219 7625 7626 * webkit/webkitsoupauthdialog.c: 7627 (show_auth_dialog): 7628 Server message is displayed, messageLabel and message variables were 7629 renamed to avoid confusion. 7630 76312010-02-23 Steve Block <steveblock@google.com> 7632 7633 Reviewed by Darin Adler. 7634 7635 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame 7636 https://bugs.webkit.org/show_bug.cgi?id=34962 7637 7638 This method is required so that a Geolocation object can cancel an 7639 asynchronous permission request. This allows the chrome client to cancel 7640 any UI it is showing for the permission request. 7641 7642 * WebCoreSupport/ChromeClientGtk.h: 7643 (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame): 7644 76452010-02-23 Xan Lopez <xlopez@igalia.com> 7646 7647 Reviewed by Gustavo Noronha. 7648 7649 Do not do unnecessary work during size_allocate. 7650 7651 FrameView::resize will already queue a layout, so there's no need 7652 to force one ourselves. On top of that, the layout function 7653 already adjusts the view size when needed, so there's no need to 7654 do that manually either. No change in the layout tests or unit 7655 tests after this. 7656 7657 * webkit/webkitwebview.cpp: 7658 (webkit_web_view_size_allocate): 7659 76602010-02-22 Xan Lopez <xlopez@igalia.com> 7661 7662 Reviewed by Gustavo Noronha. 7663 7664 Update for release. 7665 7666 * NEWS: 7667 76682010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7669 7670 Reviewed by Xan Lopez. 7671 7672 [Soup] loses information related to message flags when converting from/to Resource{Request,Response} 7673 https://bugs.webkit.org/show_bug.cgi?id=35093 7674 7675 Update the flags that are stored in the request, when the response 7676 is received. 7677 7678 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7679 (WebKit::FrameLoaderClient::dispatchDidReceiveResponse): 7680 76812010-02-20 Gustavo Noronha Silva <gns@gnome.org> 7682 7683 Unreviewed. Trivial fix - unnecessary variable got added by 7684 mistake. 7685 7686 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7687 (WebKit::FrameLoaderClient::dispatchDidReceiveResponse): 7688 76892010-02-18 Diego Escalante Urrelo <descalante@igalia.com> 7690 7691 Reviewed by Gustavo Noronha Silva. 7692 7693 [GTK] WebKitDownload documentation is incomplete 7694 https://bugs.webkit.org/show_bug.cgi?id=35018 7695 7696 Concretely the error signal was undocumented. Also two relevant enums 7697 were not included. 7698 7699 * docs/webkitgtk-sections.txt: 7700 * docs/webkitgtk.types: 7701 * webkit/webkitdownload.cpp: 7702 (webkit_download_class_init): 7703 77042010-02-17 Dmitry Titov <dimich@chromium.org> 7705 7706 Reviewed by David Levin, Darin Fisher, Simon Hausmann. 7707 7708 When a live iframe element is moved between pages, it still depends on the old page. 7709 https://bugs.webkit.org/show_bug.cgi?id=34382 7710 7711 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7712 (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument): 7713 Added empty implementation of a new virtual method. 7714 7715 * WebCoreSupport/FrameLoaderClientGtk.h: 7716 77172010-02-17 Kent Tamura <tkent@chromium.org> 7718 7719 Reviewed by Eric Seidel. 7720 7721 Introduces new Icon loading interface in order to support 7722 asynchronous loading. 7723 https://bugs.webkit.org/show_bug.cgi?id=32054 7724 7725 Add an empty implementation of ChromeClient::iconForFiles(). 7726 7727 * WebCoreSupport/ChromeClientGtk.cpp: 7728 (WebKit::ChromeClient::iconForFiles): 7729 * WebCoreSupport/ChromeClientGtk.h: 7730 77312010-02-17 Xan Lopez <xlopez@igalia.com> 7732 7733 Reviewed by Gustavo Noronha. 7734 7735 Rename 'enable-java' setting to 'enable-java-applet', since it 7736 only controls whether <applet> is supported or not instead of 7737 whether all Java content is supported or not. 7738 7739 * webkit/webkitwebsettings.cpp: 7740 (webkit_web_settings_class_init): 7741 (webkit_web_settings_set_property): 7742 (webkit_web_settings_get_property): 7743 (webkit_web_settings_copy): 7744 * webkit/webkitwebview.cpp: 7745 (DNDContentsRequest::webkit_web_view_update_settings): 7746 (DNDContentsRequest::webkit_web_view_settings_notify): 7747 77482010-02-17 Xan Lopez <xlopez@igalia.com> 7749 7750 Reviewed by Gustavo Noronha. 7751 7752 [Linux] Webkit incompatible with Java plugins 7753 https://bugs.webkit.org/show_bug.cgi?id=24912 7754 7755 Implement FrameLoaderClient::createJavaAppletWidget. 7756 7757 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7758 (WebKit::FrameLoaderClient::createJavaAppletWidget): 7759 77602010-02-17 Xan Lopez <xlopez@igalia.com> 7761 7762 Reviewed by Gustavo Noronha. 7763 7764 [Linux] Webkit incompatible with Java plugins 7765 https://bugs.webkit.org/show_bug.cgi?id=24912 7766 7767 Add a WebKitWebSetting to enable/disable the Java plugin support. 7768 7769 * webkit/webkitwebsettings.cpp: 7770 (webkit_web_settings_class_init): 7771 (webkit_web_settings_set_property): 7772 (webkit_web_settings_get_property): 7773 (webkit_web_settings_copy): 7774 * webkit/webkitwebview.cpp: 7775 (webkit_web_view_update_settings): 7776 (webkit_web_view_settings_notify): 7777 77782010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7779 7780 Reviewed by Xan Lopez. 7781 7782 Test that data URIs that cause downloads to be started do not crash. 7783 7784 * tests/testdownload.c: 7785 (mime_type_policy_decision_requested_cb): 7786 (idle_quit_loop_cb): 7787 (test_webkit_download_data): 7788 (main): 7789 77902010-02-17 Philippe Normand <pnormand@igalia.com> 7791 7792 Reviewed by Xan Lopez. 7793 7794 Missing property warning after r54873 7795 https://bugs.webkit.org/show_bug.cgi?id=35023 7796 7797 Add a new WebKitWebSettings setting, 'enable-file-access-from-file-uris', set to 7798 FALSE by default, that when enabled will assign each file:// URI 7799 their own security domain. 7800 7801 * webkit/webkitwebsettings.cpp: 7802 (webkit_web_settings_class_init): 7803 (webkit_web_settings_set_property): 7804 (webkit_web_settings_get_property): 7805 (webkit_web_settings_copy): 7806 78072010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7808 7809 Reviewed by Xan Lopez. 7810 7811 Check if the handle has a SoupMessage before trying to use 7812 it. This will be the case in non-HTTP(S) URLs. 7813 7814 * webkit/webkitdownload.cpp: 7815 (webkit_download_new_with_handle): 7816 (webkit_download_start): 7817 78182010-02-16 Xan Lopez <xlopez@igalia.com> 7819 7820 Reviewed by Gustavo Noronha. 7821 7822 Add a new WebKitWebSettings setting, 'auto-resize-window', set to 7823 FALSE by default, that when enabled will apply any resizes or 7824 moves done by a page through various DOM methods (moveTo, 7825 resizeTo, moveBy, resizeBy). 7826 7827 * WebCoreSupport/ChromeClientGtk.cpp: 7828 * webkit/webkitwebsettings.cpp: 7829 (webkit_web_settings_class_init): 7830 (webkit_web_settings_set_property): 7831 (webkit_web_settings_get_property): 7832 (webkit_web_settings_copy): 7833 78342010-02-15 Emilio Pozuelo Monfort <pochu27@gmail.com> 7835 7836 Reviewed by Gustavo Noronha Silva. 7837 7838 [GTK] Fails to build on GNU/Hurd because of PATH_MAX usage 7839 https://bugs.webkit.org/show_bug.cgi?id=34920 7840 7841 Use dynamic allocation instead of fixed PATH_MAX size buffers to 7842 fix the build on GNU/Hurd, where PATH_MAX is undefined. 7843 7844 * tests/testmimehandling.c: 7845 (main): 7846 * tests/testwebview.c: 7847 (main): 7848 78492010-02-14 Diego Escalante Urrelo <descalante@igalia.com> 7850 7851 Reviewed by Gustavo Noronha Silva. 7852 7853 [gtk] WebKitDownload's currentSize property is guint, should be guint64 7854 https://bugs.webkit.org/show_bug.cgi?id=34829 7855 7856 Actually use a guint64 for current-size property in WebKitDownload, we 7857 were using a guint which is likely the cause for wrong sizes for files 7858 over 4 Gb. 7859 7860 * webkit/webkitdownload.cpp: 7861 78622010-02-09 Gustavo Noronha Silva <gns@gnome.org> 7863 7864 Reviewed by Xan Lopez. 7865 7866 [GTK] Hits assertion on history back, with page cache enabled, in specific conditions 7867 https://bugs.webkit.org/show_bug.cgi?id=34773 7868 7869 Make sure cached frames have their scrollbars disconnected from 7870 the WebView's adjustments. 7871 7872 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7873 (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame): 7874 78752010-02-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7876 7877 Reviewed by Xan Lopez. 7878 7879 [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache 7880 https://bugs.webkit.org/show_bug.cgi?id=34754 7881 7882 Test that lower, and upper bounds are kept when goibg back with 7883 page cache enabled, and disabled. Page cache behaviour is still a 7884 bit broken (see FIXME). 7885 7886 * tests/testwebview.c: 7887 (server_callback): 7888 (map_event_cb): 7889 (do_test_webkit_web_view_adjustments): 7890 (test_webkit_web_view_adjustments): 7891 (main): 7892 78932010-02-09 Xan Lopez <xlopez@igalia.com> 7894 7895 Reviewed by Gustavo Noronha. 7896 7897 [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache 7898 https://bugs.webkit.org/show_bug.cgi?id=34754 7899 7900 Set the Gtk Adjustments of the FrameViews when they are restored 7901 from the PageCache too. Right we only do it for the newly created 7902 FrameViews in transitionToCommittedForNewPage, but we it also 7903 needs to be done in the equilavent transition method for cached 7904 pages. 7905 7906 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7907 (WebKit::postCommitFrameViewSetup): 7908 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame): 7909 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 7910 79112010-02-08 Xan Lopez <xlopez@igalia.com> 7912 7913 Reviewed by Gustavo Noronha. 7914 7915 [GTK] Implement FrameLoaderClient::hasWebView 7916 https://bugs.webkit.org/show_bug.cgi?id=34682 7917 7918 Used for sanity-check ASSERTS in the FrameLoader code. 7919 7920 * WebCoreSupport/FrameLoaderClientGtk.cpp: 7921 (WebKit::FrameLoaderClient::hasWebView): 7922 79232010-02-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 7924 7925 Reviewed by Xan Lopez. 7926 7927 News about 1.1.21. 7928 7929 * NEWS: 7930 79312010-02-05 Shinichiro Hamaji <hamaji@chromium.org> 7932 7933 Reviewed by Gustavo Noronha Silva. 7934 7935 [Gtk] Implement layoutTestController.pageNumberForElementById 7936 https://bugs.webkit.org/show_bug.cgi?id=34572 7937 7938 * webkit/webkitprivate.h: 7939 * webkit/webkitwebframe.cpp: 7940 (webkit_web_frame_page_number_for_element_by_id): 7941 79422010-02-04 Christian Dywan <christian@twotoasts.de> 7943 7944 Reviewed by Gustavo Noronha Silva. 7945 7946 [GTK] Add and cleanup return values of signals in view and frame 7947 https://bugs.webkit.org/show_bug.cgi?id=33484 7948 7949 Add missing and cleanup return values of web frame and web view signals. 7950 7951 * webkit/webkitwebframe.cpp: 7952 (webkit_web_frame_class_init): 7953 * webkit/webkitwebview.cpp: 7954 (DNDContentsRequest::webkit_web_view_class_init): 7955 79562010-02-02 Gustavo Noronha Silva <gns@gnome.org> 7957 7958 Reviewed by Xan Lopez. 7959 7960 Changes in 1.1.20, and documentation control files update. 7961 7962 * NEWS: 7963 * docs/webkitgtk-docs.sgml: 7964 79652010-02-02 Martin Robinson <martin.james.robinson@gmail.com> 7966 7967 Reviewed by Gustavo Noronha Silva. 7968 7969 [GTK] When selection changes selections in other WebView are not collapsed 7970 https://bugs.webkit.org/show_bug.cgi?id=34043 7971 7972 Collapse the selection of a WebView even when the new selection owner is 7973 a new WebView. 7974 7975 * WebCoreSupport/PasteboardHelperGtk.cpp: 7976 (WebKit::clearClipboardContentsCallback): Only clear the DataObject we are setting 7977 is not the same as the one referenced in this callback. Use the same behavior for 7978 collapsing the selection. 7979 (WebKit::PasteboardHelperGtk::writeClipboardContents): Instead of recording a boolean 7980 record the actual data used while writing to the clipboard. 7981 79822010-01-27 Martin Robinson <mrobinson@webkit.org> 7983 7984 Reviewed by Gustavo Noronha Silva. 7985 7986 [GTK] Expose the IM context via the API 7987 https://bugs.webkit.org/show_bug.cgi?id=33327 7988 7989 Expose the GtkIMMultiContext as a property of WebKitWebView. This will 7990 allow embedders to generate the input method context menu entries and 7991 make testing certain IM context behavior possible. 7992 7993 * webkit/webkitwebview.cpp: 7994 (webkit_web_view_get_property): 7995 (DNDContentsRequest::webkit_web_view_get_im_context): 7996 (DNDContentsRequest::webkit_web_view_class_init): 7997 79982010-01-19 Joanmarie Diggs <joanmarie.diggs@gmail.com> 7999 8000 Reviewed by Xan Lopez. 8001 8002 https://bugs.webkit.org/show_bug.cgi?id=30883 8003 [Gtk] Implement AtkText for HTML elements which contain text 8004 8005 Adds two news tests. 8006 8007 * tests/testatk.c 8008 (testWebkitAtkGetTextInParagraphAndBodySimple): 8009 (testWebkitAtkGetTextInParagraphAndBodyModerate): 8010 (main): 8011 80122010-01-19 Gustavo Noronha Silva <gns@gnome.org> 8013 8014 Unreviewed. Changes to the test I forgot to make after a last 8015 minute change before landing 53294 - this causes make distcheck to 8016 fail. 8017 8018 * tests/testloading.c: 8019 (load_error_status_changed_cb): 8020 (test_loading_error): 8021 80222010-01-19 Gustavo Noronha Silva <gns@gnome.org> 8023 8024 Reviewed by Xan Lopez. 8025 8026 News items for 1.1.19. 8027 8028 * NEWS: 8029 80302010-01-19 Gustavo Noronha Silva <gns@gnome.org> 8031 8032 Reviewed by Xan Lopez. 8033 8034 [GTK] More crashes related to the clipboard management 8035 https://bugs.webkit.org/show_bug.cgi?id=33746 8036 8037 Pass the WebKitWebView object (which is a GObject, thus 8038 ref-counted) to the clipboard functions instead of passing the 8039 Page - this allows us to explicitely protect the object inbetween 8040 the clipboard call and its callbacks, which fixes the crash. 8041 8042 * WebCoreSupport/EditorClientGtk.cpp: 8043 (WebKit::EditorClient::respondToChangedSelection): 8044 * WebCoreSupport/PasteboardHelperGtk.cpp: 8045 (WebKit::getClipboardContentsCallback): 8046 (WebKit::clearClipboardContentsCallback): 8047 (WebKit::PasteboardHelperGtk::writeClipboardContents): 8048 80492010-01-15 Alejandro G. Castro <alex@igalia.com> 8050 8051 Reviewed by Xan Lopez. 8052 8053 Original patch by David Ronis <david.ronis@mcgill.ca> 8054 8055 Upgrade 1.1.17->1.1.18 fails: GTK_WIDGET_TOPLEVEL' was not declared in this scope 8056 https://bugs.webkit.org/show_bug.cgi?id=33486 8057 8058 Deprecated symbols replaced for gtk+ versions over 2.18. 8059 8060 * WebCoreSupport/ChromeClientGtk.cpp: 8061 (WebKit::ChromeClient::windowRect): 8062 * webkit/webkitprivate.cpp: 8063 (currentToplevelCallback): 8064 * webkit/webkitwebframe.cpp: 8065 (webkit_web_frame_print_full): 8066 (webkit_web_frame_print): 8067 * webkit/webkitwebview.cpp: 8068 (webkit_web_view_focus_in_event): 8069 80702010-01-14 Gustavo Noronha Silva <gns@gnome.org> 8071 8072 Reviewed by Eric Seidel. 8073 8074 [GTK] Crashes cleaning clipboard contents, with page cache enabled 8075 https://bugs.webkit.org/show_bug.cgi?id=32900 8076 8077 Null-check the focus controller to avoid crashing. Could not find 8078 a way to reproduce this consistently, thus no test. 8079 8080 * WebCoreSupport/PasteboardHelperGtk.cpp: 8081 (WebKit::clearClipboardContentsCallback): 8082 80832010-01-14 Gustavo Noronha Silva <gns@gnome.org> 8084 8085 Reviewed by Oliver Hunter. 8086 8087 [GTK] couple fixes for signal emissions, and property notifications 8088 https://bugs.webkit.org/show_bug.cgi?id=33428 8089 8090 Do not emit signals and property notifications for error 8091 pages. The notifications are not really useful for anything, you 8092 can get them back by overriding the error pages, and it avoids a 8093 number of hacks. 8094 8095 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8096 (WebKit::FrameLoaderClient::FrameLoaderClient): 8097 (WebKit::FrameLoaderClient::dispatchDidFinishLoad): 8098 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon): 8099 (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad): 8100 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): 8101 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): 8102 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout): 8103 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 8104 * WebCoreSupport/FrameLoaderClientGtk.h: 8105 * tests/testloading.c: 8106 (load_error_status_changed_cb): 8107 (test_loading_error): 8108 81092010-01-14 Martin Robinson <martin.james.robinson@gmail.com> 8110 8111 Reviewed by Xan Lopez. 8112 8113 [GTK] Enable DOM clipboard and drag-and-drop access 8114 https://bugs.webkit.org/show_bug.cgi?id=30623 8115 8116 Use DataObjectGtk when setting and clearing pasteboard data on 8117 the GDK_SELECTION_PRIMARY clipboard. 8118 8119 * WebCoreSupport/EditorClientGtk.cpp: 8120 (WebKit::EditorClient::respondToChangedSelection): 8121 (WebKit::EditorClient::EditorClient): 8122 * WebCoreSupport/EditorClientGtk.h: 8123 * WebCoreSupport/PasteboardHelperGtk.cpp: 8124 (WebKit::fillSelectionData): 8125 (WebKit::targetListForDataObject): 8126 (WebKit::getClipboardContentsCallback): 8127 (WebKit::clearClipboardContentsCallback): 8128 (WebKit::PasteboardHelperGtk::writeClipboardContents): 8129 * WebCoreSupport/PasteboardHelperGtk.h: 8130 81312010-01-14 Alejandro G. Castro <alex@igalia.com> 8132 8133 Reviewed by Xan Lopez. 8134 8135 Review the tooltip implementation 8136 https://bugs.webkit.org/show_bug.cgi?id=32819 8137 8138 Change the GTK tooltip implementation to avoid the workaround that 8139 we are currently using. Now we use a new private API to set the 8140 text and all the tooltip handling is done in the webview widget. 8141 8142 * WebCoreSupport/ChromeClientGtk.cpp: 8143 * webkit/webkitprivate.h: 8144 * webkit/webkitwebview.cpp: 8145 (webkit_web_view_set_tooltip_text): Added, new private API. 8146 (webkit_web_view_query_tooltip): Added 8147 81482010-01-09 Gustavo Noronha Silva <gns@gnome.org> 8149 8150 Reviewed by Xan Lopez. 8151 8152 [GTK] couple fixes for signal emissions, and property notifications 8153 https://bugs.webkit.org/show_bug.cgi?id=33428 8154 8155 Fix commitedLoad being called where it should not, causing it to 8156 be called one time too many in some cases. We now match Qt's and 8157 Mac's behavior here. 8158 8159 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8160 (WebKit::FrameLoaderClient::finishedLoading): 8161 * tests/testloading.c: 8162 (load_error_status_changed_cb): 8163 81642010-01-08 Gustavo Noronha Silva <gns@gnome.org> 8165 8166 Reviewed by Xan Lopez. 8167 8168 [GTK] loading test should use SoupServer instead of actual sites 8169 https://bugs.webkit.org/show_bug.cgi?id=33353 8170 8171 Make all the loading tests use SoupServer, instead of fetching 8172 stuff from the Internet. 8173 8174 * tests/testloading.c: 8175 (server_callback): 8176 (get_uri_for_path): 8177 (test_loading_status): 8178 (test_loading_error): 8179 (test_loading_cancelled): 8180 (load_wentback_status_changed_cb): 8181 (load_error_test): 8182 (test_loading_goback): 8183 (main): 8184 81852010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com> 8186 8187 Reviewed by Xan Lopez. 8188 8189 https://bugs.webkit.org/show_bug.cgi?id=30883 8190 [Gtk] Implement AtkText for HTML elements which contain text 8191 8192 * tests/testatk.c 8193 (test_webkit_atk_get_text_at_offset): 8194 (test_webkit_atk_get_text_at_offset_forms): 8195 (test_webkit_atk_get_text_at_offset_newlines): 8196 81972010-01-05 Gustavo Noronha Silva <gns@gnome.org> 8198 8199 Updated docs for 1.1.18 release. 8200 8201 * docs/webkitgtk-docs.sgml: 8202 * docs/webkitgtk-sections.txt: 8203 82042010-01-05 Xan Lopez <xlopez@igalia.com> 8205 8206 Update for 1.1.18 release. 8207 8208 * NEWS: 8209 82102010-01-04 Maciej Stachowiak <mjs@apple.com> 8211 8212 Reviewed by Darin Fisher. 8213 8214 Reorganize, document and rename OS() platform macros. 8215 https://bugs.webkit.org/show_bug.cgi?id=33198 8216 8217 Adapt to name changes. 8218 8219 * webkit/webkitwebsettings.cpp: 8220 (webkit_get_user_agent): 8221 82222010-01-04 Maciej Stachowiak <mjs@apple.com> 8223 8224 Reviewed by Adam Barth. 8225 8226 Reorganize, document and rename CPU() platform macros. 8227 https://bugs.webkit.org/show_bug.cgi?id=33145 8228 8229 * webkit/webkitwebsettings.cpp: 8230 (webkit_get_user_agent): 8231 82322009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8233 8234 Reviewed by Xan Lopez. 8235 8236 Remove emission of signal that does not exist. 8237 8238 * WebCoreSupport/InspectorClientGtk.cpp: 8239 (WebKit::InspectorClient::inspectorDestroyed): 8240 (WebKit::InspectorClient::webViewDestroyed): 8241 82422009-12-20 Xan Lopez <xlopez@igalia.com> 8243 8244 Reviewed by Gustavo Noronha. 8245 8246 Unset the adjustments in our FrameView when detaching from 8247 parent. Fixes some crashers when transitioning to a new page from 8248 a scrolled page. 8249 8250 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8251 (WebKit::FrameLoaderClient::detachedFromParent2): 8252 82532009-12-20 Xan Lopez <xlopez@igalia.com> 8254 8255 Rubber-stamped by Gustavo Noronha. 8256 8257 Disable the page cache by default since: 8258 8259 - It was previously off by default. 8260 - There are still some issues when enabling it. 8261 8262 * webkit/webkitwebsettings.cpp: 8263 (webkit_web_settings_class_init): 8264 82652009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8266 8267 Reviewed by Xan Lopez. 8268 8269 Provides a new API to copy WebKitWebHistoryItem objects. 8270 8271 * webkit/webkitwebhistoryitem.cpp: 8272 (webkit_web_history_item_copy): 8273 * webkit/webkitwebhistoryitem.h: 8274 82752009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8276 8277 Reviewed by Xan Lopez. 8278 8279 Make sure we get the URI that is being loaded when updating 8280 WebKitWebFrame's knowledge of it. This was causing problems now 8281 that page cache is enabled. 8282 8283 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8284 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): 8285 * tests/testloading.c: 8286 (load_goback_status_changed_cb): 8287 (load_wentback_status_changed_cb): 8288 (test_loading_goback): 8289 (main): 8290 82912009-12-20 Alejandro G. Castro <alex@igalia.com> 8292 8293 Reviewed by Xan Lopez. 8294 8295 [GTK] Cache control APIs 8296 https://bugs.webkit.org/show_bug.cgi?id=24001 8297 8298 Original patch by Bobby Powers <bobby@laptop.org> 8299 8300 Added new API to specify cache models for GTK port. 8301 8302 * webkit/webkitprivate.cpp: 8303 (webkit_init): set a default cache model. 8304 * webkit/webkitwebview.cpp: 8305 * webkit/webkitwebview.h: 8306 (webkit_set_cache_model): Added function. 8307 (webkit_get_cache_model): Added function. 8308 83092009-12-20 Xan Lopez <xlopez@igalia.com> 8310 8311 Revert the previous patch, it introduces some failures in the 8312 bots. 8313 8314 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8315 (WebKit::FrameLoaderClient::committedLoad): 8316 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 8317 83182009-12-20 Xan Lopez <xlopez@igalia.com> 8319 8320 Reviewed by Gustavo Noronha. 8321 8322 [GTK] crash when loading new page 8323 https://bugs.webkit.org/show_bug.cgi?id=32752 8324 8325 Wait until the document is attached to adjust our alignments, 8326 since we need to make sure the FrameView in the document content 8327 render object matches the newly created FrameView for the new 8328 page, otherwise we'll try to relayout the wrong view. 8329 8330 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8331 (WebKit::FrameLoaderClient::committedLoad): 8332 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 8333 83342009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8335 8336 Reviewed by Xan Lopez. 8337 8338 Create a new WebKitDataSource object when attaching to a frame, if 8339 one does not exist. This may happen when we are fetching data from 8340 the page cache. 8341 8342 * WebCoreSupport/DocumentLoaderGtk.cpp: 8343 (WebKit::DocumentLoader::attachToFrame): 8344 (WebKit::DocumentLoader::unrefDataSource): 8345 83462009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8347 8348 Rubber-stamped by Xan Lopez. 8349 8350 Make sure the text encoding machinery is initialized from the main 8351 frame, before opening the icon database. 8352 8353 * webkit/webkitprivate.cpp: 8354 (webkit_init): 8355 83562009-12-19 Alejandro G. Castro <alex@igalia.com> 8357 8358 Reviewed by Xan Lopez. 8359 8360 Fixed the problem when pasting in the same window with the 8361 middle-button, now we store a reference to the range instead of 8362 requesting it every time, and we do not release it until the 8363 clipboard is requested. 8364 https://bugs.webkit.org/show_bug.cgi?id=28153 8365 8366 * WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp: 8367 * WebKit/gtk/WebCoreSupport/EditorClientGtk.h: 8368 83692009-12-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8370 8371 Reviewed by Xan Lopez. 8372 8373 Protect download objects when reporting errors, to make sure the 8374 download stays alive between the status change notification, and 8375 the error signal emission. 8376 8377 * webkit/webkitdownload.cpp: 8378 (webkit_download_error): 8379 83802009-12-18 Xan Lopez <xlopez@igalia.com> 8381 8382 Reviewed by Gustavo Noronha. 8383 8384 Fix gtk-doc of webkit_web_resource_new. 8385 8386 * webkit/webkitwebresource.cpp: 8387 83882009-12-18 Adam Roben <aroben@apple.com> 8389 8390 GTK build fix 8391 8392 * webkit/webkitprivate.cpp: Added #include. 8393 83942009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex@igalia.com> 8395 8396 Reviewed by Gustavo Noronha Silva. 8397 8398 [GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache 8399 8400 * webkit/webkitwebsettings.cpp: 8401 (_WebKitWebSettingsPrivate::): 8402 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 8403 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): 8404 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): 8405 (_WebKitWebSettingsPrivate::webkit_web_settings_copy): 8406 * webkit/webkitwebview.cpp: 8407 84082009-12-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8409 8410 Reviewed by Xan Lopez. 8411 8412 More make distcheck fixes. Use a more robust solution to making 8413 sure we are in the correct directory for running these tests. 8414 8415 * tests/testmimehandling.c: 8416 (main): 8417 * tests/testwebview.c: 8418 (main): 8419 84202009-12-17 Christian Dywan <christian@twotoasts.de> 8421 8422 Reviewed by Gustavo Noronha Silva. 8423 8424 [GTK] Don't assume downloads are always synchronous 8425 http://bugs.webkit.org/show_bug.cgi?id=32359 8426 8427 * tests/testdownload.c: 8428 (download_requested_cb): 8429 (set_filename): 8430 (test_webkit_download_perform): 8431 (test_webkit_download_synch): 8432 (test_webkit_download_asynch): 8433 (main): Test downloads synchronously and asynchronously. 8434 * webkit/webkitwebview.cpp: 8435 (webkit_web_view_class_init): 8436 (webkit_web_view_request_download): Only try to start a requested 8437 download if the destination URI is set and clarify the documentation. 8438 84392009-12-17 Christian Dywan <christian@twotoasts.de> 8440 8441 Reviewed by Xan Lopez. 8442 8443 Deprecate the title-changed signal of WebKitWebFrame. 8444 8445 * webkit/webkitwebframe.cpp: 8446 (webkit_web_frame_class_init): 8447 84482009-12-17 Martin Robinson <martin.james.robinson@gmail.com> 8449 8450 Reviewed by Gustavo Noronha Silva. 8451 8452 [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs 8453 https://bugs.webkit.org/show_bug.cgi?id=21599 8454 8455 Convert a use of GOwnPtr for a reference counted type to GRefPtr. 8456 8457 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8458 (WebKit::FrameLoaderClient::createPlugin): 8459 84602009-12-17 Evan Martin <evan@chromium.org> 8461 8462 Reviewed by Xan Lopez. 8463 8464 Expose the page workarounds ("quirks") setting to the GTK+ WebKit API. 8465 8466 * webkit/webkitwebsettings.cpp: 8467 (webkit_web_settings_class_init): 8468 (webkit_web_settings_set_property): 8469 (webkit_web_settings_get_property): 8470 (webkit_web_settings_copy): 8471 * webkit/webkitwebview.cpp: 8472 (webkit_web_view_update_settings): 8473 84742009-12-16 Dan Winship <danw@gnome.org> 8475 8476 Reviewed by Gustavo Noronha Silva. 8477 8478 Content-Encoding support 8479 8480 https://bugs.webkit.org/show_bug.cgi?id=522772 8481 8482 * webkit/webkitprivate.cpp: 8483 (webkit_init): add a SoupContentDecoder feature to the session 8484 84852009-12-16 Christian Dywan <christian@twotoasts.de> 8486 8487 Reviewed by Gustavo Noronha Silva. 8488 8489 Deprecate the old loading signals load-started, load-committed, 8490 load-finished, load-progress-changed and change unit tests to use 8491 load-status instead. 8492 8493 * tests/testmimehandling.c: 8494 (idle_quit_loop_cb): 8495 (test_mime_type): use notify::load-status 8496 * tests/testwebdatasource.c: 8497 (notify_load_status_unreachable_cb): 8498 (notify_load_status_cb): 8499 (test_webkit_web_data_source): 8500 (test_webkit_web_data_source_unreachable_uri): Remove uses of 8501 g_main_loop_is_running. It's an error if the loop is wrongly terminated. 8502 * tests/testwebresource.c: 8503 (notify_load_status_cb): 8504 (test_web_resource_loading): 8505 (notify_load_status_sub_cb): 8506 (test_web_resource_sub_resource_loading): use notify::load-status 8507 * tests/testwebview.c: 8508 (idle_quit_loop_cb): 8509 (test_webkit_web_view_icon_uri): 8510 * tests/testwindow.c: 8511 (notify_load_status_cb): 8512 (test_webkit_window_scrollbar_policy): use notify::load-status 8513 * webkit/webkitwebframe.cpp: 8514 (webkit_web_frame_class_init): 8515 * webkit/webkitwebview.cpp: 8516 (webkit_web_view_class_init): Deprecate old load signals. 8517 85182009-12-16 Christian Dywan <christian@twotoasts.de> 8519 8520 Reviewed by Gustavo Noronha Silva. 8521 8522 Take into account favicon.ico in the webresource test. 8523 8524 * tests/testwebresource.c: 8525 (test_web_resource_sub_resource_loading): 8526 85272009-12-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8528 8529 Rubber-stamped by Xan Lopez. 8530 8531 Add tab_key_cycles_through_elements to copies of 8532 WebKitWebSettings. 8533 8534 * webkit/webkitwebsettings.cpp: 8535 (webkit_web_settings_copy): 8536 85372009-12-16 Martin Robinson <martin.james.robinson@gmail.com> 8538 8539 Reviewed by Gustavo Noronha Silva. 8540 8541 [GTK] webkit_web_navigation_action_get_button() documentation 8542 https://bugs.webkit.org/show_bug.cgi?id=25555 8543 8544 Small documentation improvement for webkit_web_navigation_action_get_button. 8545 8546 * webkit/webkitwebnavigationaction.cpp: 8547 85482009-12-13 Sam Weinig <sam@webkit.org> 8549 8550 Reviewed by Dan Bernstein. 8551 8552 Fix for https://bugs.webkit.org/show_bug.cgi?id=32499 8553 Add client based Geolocation provider 8554 8555 Add first cut of a client based Geolocation provider. This is guarded by 8556 ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a 8557 GeolocationControllerClient interface that no-one currently implements, 8558 but will in a subsequent patch. 8559 8560 * webkit/webkitwebview.cpp: 8561 (webkit_web_view_init): 8562 85632009-12-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8564 8565 Reviewed by Xan Lopez. 8566 8567 New setting to allow applications to completely suppress the 8568 default context menu that is generated by WebKit. This allows them 8569 to still pass the event to the default handler without needing to 8570 use ugly hacks such as handling populate-popup, and removing all 8571 the items from the default context menu. 8572 8573 * webkit/webkitwebsettings.cpp: 8574 (webkit_web_settings_class_init): 8575 (webkit_web_settings_set_property): 8576 (webkit_web_settings_get_property): 8577 (webkit_web_settings_copy): 8578 * webkit/webkitwebview.cpp: 8579 (webkit_web_view_forward_context_menu_event): 8580 85812009-12-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8582 8583 Reviewed by Xan Lopez. 8584 8585 Also give the right click event to the frame's event handler, if 8586 there WebCore decides to not generate the default context 8587 menu. This fixes some pages that handle right-button clicks for 8588 things other than context menu creation. 8589 8590 * webkit/webkitwebview.cpp: 8591 (webkit_web_view_forward_context_menu_event): 8592 85932009-12-13 Christian Dywan <christian@twotoasts.de> 8594 8595 Reviewed by Holger Freyther. 8596 8597 http://bugs.webkit.org/show_bug.cgi?id=31014 8598 [Gtk] Build fails with gtk+-2.10 (no tested with older releases) 8599 8600 Guard GTK+ 2.12 specific tooltip code with #ifdef. 8601 8602 * WebCoreSupport/ChromeClientGtk.cpp: 8603 (WebKit::ChromeClient::mouseDidMoveOverElement): 8604 86052009-12-11 Christian Dywan <christian@twotoasts.de> 8606 8607 Reviewed by Eric Seidel. 8608 8609 [GTK] Build with --disable-svg is broken 8610 http://bugs.webkit.org/show_bug.cgi?id=32361 8611 8612 * webkit/webkitwebframe.cpp: 8613 (webkit_web_frame_pause_svg_animation): Fix ENABLE(SVG) guards. 8614 86152009-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8616 8617 Reviewed by Xan Lopez. 8618 8619 Add a missing null-check, that is causing some crash reports. 8620 8621 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8622 (WebKit::FrameLoaderClient::committedLoad): 8623 86242009-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8625 8626 Reviewed by Xan Lopez. 8627 8628 [GTK] Should provide an API to control the IconDatabase 8629 https://bugs.webkit.org/show_bug.cgi?id=32334 8630 8631 First step towards a full IconDatabase API. This provides 8632 notification for pages with favicons, and lets clients handle 8633 them. 8634 8635 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8636 (WebKit::FrameLoaderClient::registerForIconNotification): 8637 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon): 8638 * tests/resources/blank.ico: Added. 8639 * tests/testwebview.c: Added. 8640 (server_callback): 8641 (idle_quit_loop_cb): 8642 (icon_uri_changed_cb): 8643 (icon_loaded_cb): 8644 (test_webkit_web_view_icon_uri): 8645 (main): 8646 * webkit/webkitprivate.cpp: 8647 (closeIconDatabaseOnExit): 8648 (webkit_init): 8649 * webkit/webkitprivate.h: 8650 * webkit/webkitwebview.cpp: 8651 (webkit_web_view_get_property): 8652 (webkit_web_view_finalize): 8653 (webkit_web_view_class_init): 8654 (webkit_web_view_get_icon_uri): 8655 * webkit/webkitwebview.h: 8656 86572009-12-08 Christian Dywan <christian@twotoasts.de> 8658 8659 Reviewed by Gustavo Noronha Silva. 8660 8661 Point out the meaning of "Content-Disposition" when implementing the 8662 mime-type-policy-decision-requested signal. 8663 8664 * webkit/webkitwebview.cpp: 8665 (webkit_web_view_class_init): 8666 86672009-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8668 8669 Reviewed by Xan Lopez. 8670 8671 [GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that 8672 https://bugs.webkit.org/show_bug.cgi?id=32247 8673 8674 Provide a way for applications to respect Content-Disposition, by 8675 fetching the WebKitNetworkResponse from the frame during 8676 mime-type-policy-decision-requested. 8677 8678 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8679 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Download 8680 content when Content-Disposition is attachment. 8681 * tests/testmimehandling.c: 8682 (server_callback): 8683 (mime_type_policy_decision_requested_cb): 8684 * tests/testwebframe.c: 8685 (test_webkit_web_frame_response): 8686 (main): 8687 * webkit/webkitprivate.cpp: 8688 (WebKit::core): 8689 * webkit/webkitwebframe.cpp: 8690 (webkit_web_frame_get_network_response): 8691 * webkit/webkitwebframe.h: 8692 86932009-12-07 Gyuyoung Kim <gyuyoung@gmail.com> 8694 8695 Reviewed by Eric Seidel. 8696 8697 https://bugs.webkit.org/show_bug.cgi?id=32024 8698 [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER 8699 8700 Fix build errors when javascript-debugger is disabled on GTK 8701 8702 * webkit/webkitwebinspector.cpp: 8703 (webkit_web_inspector_set_property): 8704 (webkit_web_inspector_get_property): 8705 87062009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com> 8707 8708 Reviewed by Xan Lopez. 8709 8710 https://bugs.webkit.org/show_bug.cgi?id=25415 8711 [GTK][ATK] Please implement support for get_text_at_offset 8712 8713 Eliminate the segfaults which occur when accessing the text interface now 8714 implemented by text controls. 8715 8716 * tests/testatk.c 8717 (test_webkit_atk_get_text_at_offset_textarea): 8718 (test_webkit_atk_get_text_at_offset_text_input): 8719 (main): 8720 87212009-12-06 Gustavo Noronha Silva <gns@gnome.org> 8722 8723 Reviewed by Xan Lopez. 8724 8725 New test to make sure we do not regress this feature anymore. All 8726 test files were created by me. 8727 8728 [GTK] REGRESSION: webkit thinks it can render PDFs 8729 https://bugs.webkit.org/show_bug.cgi?id=32183 8730 8731 * tests/resources/test.html: Added. 8732 * tests/resources/test.ogg: Added. 8733 * tests/resources/test.pdf: Added. 8734 * tests/resources/test.txt: Added. 8735 * tests/testmimehandling.c: Added. 8736 (server_callback): 8737 (idle_quit_loop_cb): 8738 (mime_type_policy_decision_requested_cb): 8739 (test_mime_type): 8740 (test_mime_pdf): 8741 (test_mime_html): 8742 (test_mime_text): 8743 (test_mime_ogg): 8744 (main): 8745 87462009-12-05 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8747 8748 Reviewed by Xan Lopez. 8749 8750 Use a better URI for the unreachable test. localhost:80 is very 8751 likely to be open. 8752 8753 * tests/testwebdatasource.c: 8754 (load_finished_unreachable_cb): 8755 (test_webkit_web_data_source_unreachable_uri): 8756 87572009-12-03 Brady Eidson <beidson@apple.com> 8758 8759 Reviewed by Sam Weinig. 8760 8761 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API 8762 8763 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8764 (WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage): 8765 (WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage): 8766 (WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage): 8767 * WebCoreSupport/FrameLoaderClientGtk.h: 8768 87692009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com> 8770 8771 Reviewed by Timothy Hatcher. 8772 8773 Web Inspector: Simplify the settings support in inspector controller. 8774 8775 https://bugs.webkit.org/show_bug.cgi?id=32076 8776 8777 * WebCoreSupport/InspectorClientGtk.cpp: 8778 (WebKit::InspectorClient::populateSetting): 8779 (WebKit::InspectorClient::storeSetting): 8780 * WebCoreSupport/InspectorClientGtk.h: 8781 87822009-12-03 Ben Murdoch <benm@google.com> 8783 8784 Reviewed by Brady Eidson. 8785 8786 [Android] The FrameLoaderClient is unaware of BackForwardList changes. 8787 https://bugs.webkit.org/show_bug.cgi?id=31914 8788 8789 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8790 (WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug). 8791 (WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto. 8792 (WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto. 8793 * WebCoreSupport/FrameLoaderClientGtk.h: 8794 87952009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> 8796 8797 Reviewed by Simon Fraser. 8798 8799 Add SVG animation test framework with 'snapshot' functionality 8800 https://bugs.webkit.org/show_bug.cgi?id=31897 8801 8802 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method, 8803 forwarding the call to SVGDocumentExtensions, if SVG is enabled. 8804 8805 Implemented just like the existing pauseAnimation* methods for CSS animations. 8806 8807 * webkit/webkitprivate.h: 8808 * webkit/webkitwebframe.cpp: 8809 (webkit_web_frame_pause_svg_animation): 8810 88112009-11-30 Xan Lopez <xlopez@igalia.com> 8812 8813 Reviewed by Gustavo Noronha. 8814 8815 Prepare for 1.1.17 release. 8816 8817 * NEWS: 8818 * docs/webkitgtk-docs.sgml: 8819 * docs/webkitgtk-sections.txt: 8820 * webkit/webkitwebsettings.cpp: 8821 (webkit_web_settings_class_init): 8822 88232009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com> 8824 8825 Reviewed by Oliver Hunt. 8826 8827 Move GOwnPtr* from wtf to wtf/gtk 8828 https://bugs.webkit.org/show_bug.cgi?id=31793 8829 8830 * webkit/webkitwebview.cpp: Change the path for GOwnPtr.h. 8831 88322009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com> 8833 8834 Reviewed by Xan Lopez. 8835 8836 https://bugs.webkit.org/show_bug.cgi?id=25415 8837 [GTK][ATK] Please implement support for get_text_at_offset 8838 8839 When building up the pango layout from text boxes, only append a 8840 newline char after verifying there are no more boxes on this line. 8841 8842 * tests/testatk.c 8843 (test_webkit_atk_get_text_at_offset_newlines): 8844 (main): 8845 88462009-11-19 Pavel Feldman <pfeldman@chromium.org> 8847 8848 Reviewed by Gustavo Noronha Silva. 8849 8850 Web Inspector: Implement "show inspector" in WebKit GTK 8851 API and enable console tests. 8852 8853 https://bugs.webkit.org/show_bug.cgi?id=31669 8854 8855 * webkit/webkitwebinspector.cpp: 8856 (webkit_web_inspector_show): 8857 * webkit/webkitwebinspector.h: 8858 88592009-11-18 Martin Robinson <martin.james.robinson@gmail.com> 8860 8861 Reviewed by Gustavo Noronha. 8862 8863 [GTK] Tab key does not cycle through elements by default 8864 https://bugs.webkit.org/show_bug.cgi?id=31505 8865 8866 Properly localize documentation strings for the 8867 tab-key-cycles-through-elements property. 8868 8869 * webkit/webkitwebsettings.cpp: 8870 (webkit_web_settings_class_init): 8871 88722009-11-17 Martin Robinson <martin.james.robinson@gmail.com> 8873 8874 Reviewed by Gustavo Noronha. 8875 8876 [GTK] Tab key does not cycle through elements by default 8877 https://bugs.webkit.org/show_bug.cgi?id=31505 8878 8879 Ensure that WebKitWebSettings tab-key-cycles-through-elements 8880 property is true by default with the G_PARAM_CONSTRUCT_FLAG. 8881 8882 * webkit/webkitwebsettings.cpp: 8883 (webkit_web_settings_class_init): 8884 88852009-11-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8886 8887 Reviewed by Xan Lopez. 8888 8889 [GTK] Failing test media/video-document-types.html 8890 https://bugs.webkit.org/show_bug.cgi?id=31352 8891 8892 Match what Mac has been doing since r36001: cancel the main load, 8893 and handle failures caused by 'will be handled by plugin' errors. 8894 8895 Covered by test media/video-document-types.html 8896 8897 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8898 (WebKit::FrameLoaderClient::committedLoad): 8899 (WebKit::FrameLoaderClient::shouldFallBack): 8900 89012009-11-17 Pavel Feldman <pfeldman@chromium.org> 8902 8903 Reviewed by Timothy Hatcher. 8904 8905 Web Inspector: Make DRT show web inspector for tests in inspector/ folder. 8906 - Updated DRT to show/close inspector for all tests under /inspector 8907 - Introduced LayoutTestController::setTimelineProfilingEnabled and 8908 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled 8909 - Removed reload on each inspector test 8910 - Renamed fast/inspector to fast/inspector-support in order not to trigger 8911 inspector for those. 8912 - Reimplemented timeline tests in order to get rid of reload there. 8913 - Moved tests that don't require harness into the fast group. 8914 8915 https://bugs.webkit.org/show_bug.cgi?id=31472 8916 8917 * webkit/webkitwebinspector.cpp: 8918 (webkit_web_inspector_class_init): 8919 (webkit_web_inspector_set_property): 8920 (webkit_web_inspector_get_property): 8921 89222009-11-13 Adam Roben <aroben@apple.com> 8923 8924 Update for changes to FrameLoaderClient 8925 8926 Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when 8927 window objects in isolated worlds are cleared 8928 8929 Reviewed by Dave Hyatt. 8930 8931 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8932 (WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld): 8933 * WebCoreSupport/FrameLoaderClientGtk.h: 8934 Replaced windowObjectCleared with this function. Does nothing if the 8935 passed-in world is not the mainThreadNormalWorld(). 8936 89372009-11-12 Shinichiro Hamaji <hamaji@chromium.org> 8938 8939 Reviewed by Darin Adler. 8940 8941 externalRepresentation should take Frame as the argument 8942 https://bugs.webkit.org/show_bug.cgi?id=31393 8943 8944 No new tests as this is just a refactoring. 8945 8946 * webkit/webkitwebframe.cpp: 8947 (webkit_web_frame_dump_render_tree): 8948 89492009-11-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 8950 8951 Reviewed by Holger Freyther. 8952 8953 Should not print javascript console messages to stdout 8954 https://bugs.webkit.org/show_bug.cgi?id=31346 8955 8956 * webkit/webkitwebview.cpp: 8957 (webkit_web_view_real_console_message): Print console messages to 8958 stderr instead, using the recommended method (a g_log variant). 8959 89602009-11-11 Philippe Normand <pnormand@igalia.com> 8961 8962 Reviewed by Xan Lopez. 8963 8964 https://bugs.webkit.org/show_bug.cgi?id=30221 8965 [GTK] fails to load media embedded in iframe element 8966 8967 The FrameLoader can show Media if the audio/video support is 8968 enabled at compile time. 8969 8970 * WebCoreSupport/FrameLoaderClientGtk.cpp: 8971 (WebKit::FrameLoaderClient::canShowMIMEType): 8972 89732009-11-10 Martin Robinson <martin.james.robinson@gmail.com> 8974 8975 Reviewed by Jan Alonzo. 8976 8977 [GTK] Remove WebSocket configuration from WebKitWebSettings 8978 https://bugs.webkit.org/show_bug.cgi?id=31244 8979 8980 Remove non-functional enable-web-sockets property from WebKitWebSettings. 8981 8982 * webkit/webkitwebsettings.cpp: 8983 (webkit_web_settings_class_init): 8984 (webkit_web_settings_set_property): 8985 (webkit_web_settings_get_property): 8986 (webkit_web_settings_copy): 8987 89882009-11-09 Martin Robinson <martin.james.robinson@gmail.com> 8989 8990 Reviewed by Jan Alonzo. 8991 8992 [GTK] Expose Page::tabKeyCyclesThroughElements in the API 8993 https://bugs.webkit.org/show_bug.cgi?id=30482 8994 8995 Expose Page::tabKeyCyclesThroughElements as a property of 8996 WebKitWebSettings. 8997 8998 * webkit/webkitwebsettings.cpp: 8999 (webkit_web_settings_class_init): 9000 (webkit_web_settings_set_property): 9001 (webkit_web_settings_get_property): 9002 * webkit/webkitwebview.cpp: 9003 (webkit_web_view_update_settings): 9004 (webkit_web_view_settings_notify): 9005 90062009-11-04 Martin Robinson <martin.james.robinson@gmail.com> 9007 9008 Reviewed by Jan Alonzo. 9009 9010 [GTK] Enable DOM clipboard and drag-and-drop access 9011 https://bugs.webkit.org/show_bug.cgi?id=30623 9012 9013 Move handling of target list to PasteboardHelperGtk. 9014 9015 * WebCoreSupport/PasteboardHelperGtk.cpp: 9016 (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): 9017 (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): 9018 (WebKit::PasteboardHelperGtk::fullTargetList): 9019 * WebCoreSupport/PasteboardHelperGtk.h: 9020 * webkit/webkitprivate.cpp: 9021 (WebKit::pasteboardHelperInstance): 9022 (webkit_init): 9023 * webkit/webkitprivate.h: 9024 * webkit/webkitwebview.cpp: 9025 (webkit_web_view_dispose): 9026 (webkit_web_view_init): 9027 (webkit_web_view_get_copy_target_list): 9028 (webkit_web_view_get_paste_target_list): 9029 90302009-10-30 Evan Stade <estade@chromium.org> 9031 9032 Reviewed by David Levin. 9033 9034 Notify the chrome when the focused node has changed. 9035 https://bugs.webkit.org/show_bug.cgi?id=30832 9036 9037 Added stub implementation for new ChromeClient function. 9038 9039 * WebCoreSupport/ChromeClientGtk.cpp: 9040 (WebKit::ChromeClient::focusedNodeChanged): 9041 * WebCoreSupport/ChromeClientGtk.h: 9042 90432009-10-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9044 9045 Unreviewed. Trivial fix - move public API declaration into the 9046 public subsection of the doc. 9047 9048 * docs/webkitgtk-sections.txt: 9049 90502009-10-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9051 9052 Reviewed by Jan Alonzo. 9053 9054 [GTK] API to start inspector for a WebView 9055 https://bugs.webkit.org/show_bug.cgi?id=22551 9056 9057 Provide a simple, coordinates-based API to start the inspector. 9058 9059 * WebCoreSupport/InspectorClientGtk.cpp: 9060 (WebKit::InspectorClient::createPage): Use files from the source 9061 tree when running from the top of the source directory. 9062 (WebKit::InspectorClient::localizedStringsURL): Ditto. 9063 * webkit/webkitprivate.h: 9064 * webkit/webkitwebinspector.cpp: 9065 (webkit_web_inspector_inspect_coordinates): 9066 (webkit_web_inspector_close): 9067 (webkit_web_inspector_execute_script): 9068 * webkit/webkitwebinspector.h: 9069 90702009-10-27 Shinichiro Hamaji <hamaji@chromium.org> 9071 9072 Reviewed by Darin Adler. 9073 9074 Provide a way to get counter values with layoutTestContoller 9075 https://bugs.webkit.org/show_bug.cgi?id=30555 9076 9077 * webkit/webkitprivate.h: 9078 * webkit/webkitwebframe.cpp: 9079 (webkit_web_frame_counter_value_for_element_by_id): 9080 90812009-10-28 Joe Mason <jmason@rim.com> 9082 9083 Reviewed by Adam Treat. 9084 9085 Call the shared FrameLoader::defaultObjectContentType instead of 9086 copying code into FrameLoaderClient::objectContentType. This causes no 9087 behavioural change. 9088 9089 * WebCoreSupport/FrameLoaderClientGtk.cpp: 9090 (WebKit::FrameLoaderClient::objectContentType): 9091 90922009-10-28 Xan Lopez <xlopez@igalia.com> 9093 9094 Reviewed by Jan Alonzo. 9095 9096 [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries 9097 https://bugs.webkit.org/show_bug.cgi?id=25897 9098 9099 Update test to also check that entries implement the AtkText 9100 interface. 9101 9102 * tests/testatk.c: 9103 (run_get_text_tests): 9104 (test_webkit_atk_get_text_at_offset_forms): 9105 (test_webkit_atk_get_text_at_offset): 9106 (main): 9107 91082009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9109 9110 Unreviewed. Update documentation control files for 1.1.16. 9111 9112 * docs/webkitgtk-docs.sgml: 9113 * docs/webkitgtk-sections.txt: 9114 91152009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9116 9117 Reviewed by Xan Lopez. 9118 9119 https://bugs.webkit.org/show_bug.cgi?id=30759 9120 [GTK] Should use WebKitNetworkResponse, and expose it 9121 9122 WebKitDownload now uses our WebKitNetworkResponse instead of using 9123 ResourceResponse directly. By exposing the response, like we do 9124 with the request, we give our users the ability to look at the 9125 response headers, status code, and so on, through the SoupMessage 9126 object. 9127 9128 * webkit/webkitdownload.cpp: 9129 (webkit_download_dispose): 9130 (webkit_download_finalize): 9131 (webkit_download_get_property): 9132 (webkit_download_set_property): 9133 (webkit_download_class_init): 9134 (webkit_download_get_network_response): 9135 (webkit_download_set_response): 9136 (webkit_download_get_total_size): 9137 (webkit_download_get_progress): 9138 (webkit_download_received_data): 9139 * webkit/webkitdownload.h: 9140 91412009-10-26 Xan Lopez <xlopez@igalia.com> 9142 9143 Reviewed by Gustavo Noronha. 9144 9145 Update for 1.1.16 release. 9146 9147 * NEWS: 9148 91492009-10-22 Gavin Barraclough <barraclough@apple.com> 9150 9151 Reviewed by NOBODY (build fix). 9152 Build fix following bug #30696. 9153 9154 * WebCoreSupport/FrameLoaderClientGtk.cpp: 9155 (WebKit::FrameLoaderClient::windowObjectCleared): 9156 * webkit/webkitwebframe.cpp: 9157 (webkit_web_frame_get_global_context): 9158 91592009-10-22 Alejandro G. Castro <alex@igalia.com> 9160 9161 Reviewed by Xan Lopez. 9162 9163 m_webView should be private attribute of the EditorClientGtk. 9164 https://bugs.webkit.org/show_bug.cgi?id=30664 9165 9166 * WebKit/gtk/WebCoreSupport/EditorClientGtk.h: 9167 91682009-10-20 Fumitoshi Ukai <ukai@chromium.org> 9169 9170 Reviewed by David Levin. 9171 9172 Removed WebSocket runtime settings. 9173 https://bugs.webkit.org/show_bug.cgi?id=29896 9174 9175 WebSocket runtime configuration is supported by chromium/v8 only. 9176 9177 * webkit/webkitwebview.cpp: 9178 (webkit_web_view_update_settings): 9179 (webkit_web_view_settings_notify): 9180 91812009-10-19 Jan Michael Alonzo <jmalonzo@webkit.org> 9182 9183 Reviewed by Alexey Proskuryakov. 9184 9185 [Gtk] ApplicationCacheStorage error while compiling WebKit/gtk/webkit/webkitapplicationcache.cpp 9186 https://bugs.webkit.org/show_bug.cgi?id=30358 9187 9188 Guard calls to cacheStorage() with ENABLE(OFFLINE_WEB_APPLICATIONS). 9189 9190 * webkit/webkitapplicationcache.cpp: 9191 91922009-10-19 Zan Dobersek <zandobersek@gmail.com> 9193 9194 Reviewed by Gustavo Noronha. 9195 9196 Add a settings to allow DOM pastes to be performed. 9197 9198 * webkit/webkitwebsettings.cpp: 9199 (webkit_web_settings_class_init): 9200 (webkit_web_settings_set_property): 9201 (webkit_web_settings_get_property): 9202 (webkit_web_settings_copy): 9203 * webkit/webkitwebview.cpp: 9204 (webkit_web_view_update_settings): 9205 (webkit_web_view_settings_notify): 9206 92072009-10-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9208 9209 Unreviewed. Make WebKitHitTestResult actually appear in the 9210 documentation index. 9211 9212 * docs/webkitgtk-docs.sgml: 9213 92142009-10-15 Xan Lopez <xlopez@igalia.com> 9215 9216 Reviewed by Gustavo Noronha. 9217 9218 Protect WebSocket calls in case the feature is not compiled in. 9219 9220 * webkit/webkitwebview.cpp: 9221 (webkit_web_view_update_settings): 9222 (webkit_web_view_settings_notify): 9223 92242009-10-15 Zan Dobersek <zandobersek@gmail.com> 9225 9226 Reviewed by Gustavo Noronha. 9227 9228 Add a settings to enable support for experimental Web Sockets. 9229 Currently this comes in handy in layout tests. 9230 9231 * webkit/webkitwebsettings.cpp: 9232 (webkit_web_settings_class_init): 9233 (webkit_web_settings_set_property): 9234 (webkit_web_settings_get_property): 9235 (webkit_web_settings_copy): 9236 * webkit/webkitwebview.cpp: 9237 (webkit_web_view_update_settings): 9238 (webkit_web_view_settings_notify): 9239 92402009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9241 9242 Reviewed by Xan Lopez. 9243 9244 page transition may crash webkit 9245 https://bugs.webkit.org/show_bug.cgi?id=29890 9246 9247 There are actually cases in which a resource may be asked using 9248 webkit_web_view_get_resource after a new load has already been 9249 started, so protect ourselves from crashes in this case. 9250 9251 * WebCoreSupport/FrameLoaderClientGtk.cpp: 9252 (WebKit::FrameLoaderClient::dispatchDidFinishLoading): 9253 * webkit/webkitwebview.cpp: 9254 (webkit_web_view_get_resource): 9255 92562009-10-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9257 9258 Rubber-stamped by Xan Lopez. 9259 9260 Remove unnecessary self-include. 9261 9262 * webkit/webkitsecurityorigin.h: 9263 92642009-10-12 Christian Dywan <christian@twotoasts.de> 9265 9266 Reviewed by Gustavo Noronha. 9267 9268 [GTK] Crash when right-clicking misspelled word 9269 https://bugs.webkit.org/show_bug.cgi?id=29772 9270 9271 Make sure the dictionary exist before adding it to the list of 9272 dictionaries. 9273 9274 * WebCoreSupport/EditorClientGtk.cpp: 9275 (WebKit::EditorClient::checkSpellingOfString): 9276 * webkit/webkitwebsettings.cpp: 9277 (webkit_web_settings_set_property): 9278 92792009-10-08 Adam Barth <abarth@webkit.org> 9280 9281 Reviewed by Eric Seidel. 9282 9283 Move executeScript from FrameLoader to ScriptController 9284 https://bugs.webkit.org/show_bug.cgi?id=30200 9285 9286 Update API call. 9287 9288 * webkit/webkitwebview.cpp: 9289 (webkit_web_view_execute_script): 9290 92912009-10-07 Xan Lopez <xlopez@igalia.com> 9292 9293 Fix the GTK+ build. 9294 9295 * webkit/webkitwebpolicydecision.cpp: 9296 (webkit_web_policy_decision_use): 9297 (webkit_web_policy_decision_ignore): 9298 (webkit_web_policy_decision_download): 9299 93002009-10-07 Adam Barth <abarth@webkit.org> 9301 9302 Reviewed by Darin Adler. 9303 9304 Factor PolicyChecker out of FrameLoader 9305 https://bugs.webkit.org/show_bug.cgi?id=30155 9306 9307 Move the policy callback to the policy object. 9308 9309 * WebCoreSupport/FrameLoaderClientGtk.cpp: 9310 (WebKit::FrameLoaderClient::dispatchWillSubmitForm): 9311 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): 9312 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): 9313 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 9314 93152009-10-07 Martin Robinson <martin.james.robinson@gmail.com> 9316 9317 [GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html 9318 https://bugs.webkit.org/show_bug.cgi?id=30121 9319 9320 Clear previous preedit or pending composition before storing new ones. 9321 This can happen when a WebView receives a native keydown event without 9322 a matching keyup event or when preventDefault() is called on DOM keydown 9323 events. 9324 9325 * WebCoreSupport/EditorClientGtk.cpp: 9326 (WebKit::setPendingComposition): 9327 (WebKit::setPendingPreedit): 9328 (WebKit::clearPendingIMData): 9329 (WebKit::imContextCommitted): 9330 (WebKit::imContextPreeditChanged): 9331 93322009-10-06 Xan Lopez <xlopez@igalia.com> 9333 9334 Reviewed by Eric Seidel. 9335 9336 https://bugs.webkit.org/show_bug.cgi?id=25526 9337 [Gtk] Additional support is needed for caret browsing 9338 9339 Remove special cases for caret browsing, they are now handled in 9340 cross-platform code. 9341 9342 * WebCoreSupport/EditorClientGtk.cpp: 9343 (WebKit::EditorClient::handleKeyboardEvent): 9344 93452009-10-06 Pavel Feldman <pfeldman@chromium.org> 9346 9347 Reviewed by Timothy Hatcher. 9348 9349 Web Inspector: close inspector client view on 9350 InspectorController::close API call. 9351 9352 In order to run batch web inspector layout tests (and not affect 9353 subsequent tests) we should close inspector client's view upon 9354 InspectorController::close API call. 9355 9356 https://bugs.webkit.org/show_bug.cgi?id=30009 9357 9358 * WebCoreSupport/InspectorClientGtk.cpp: 9359 (WebKit::InspectorClient::createPage): 9360 93612009-10-06 Alejandro G. Castro <alex@igalia.com> 9362 9363 Reviewed by Xan Lopez. 9364 9365 ASSERT executing the webhistory unittest in a debug build 9366 https://bugs.webkit.org/show_bug.cgi?id=28947 9367 9368 We have to call g_object_new first to initialize webkit threading 9369 before creating the KURL. 9370 9371 * WebKit/gtk/webkit/webkitwebhistoryitem.cpp: 9372 93732009-10-06 José Millán Soto <fid@gpul.org> 9374 9375 Reviewed by Xan Lopez. 9376 9377 Header files of WebKitGTK do not comply with WebKit coding style (Patch attached) 9378 https://bugs.webkit.org/show_bug.cgi?id=30076 9379 9380 Solves various issues in header files. 9381 9382 * WebCoreSupport/DocumentLoaderGtk.h: Added "headed guards" 9383 * webkit/webkitdefines.h: 9384 * webkit/webkitdownload.h: 9385 * webkit/webkiterror.h: 9386 * webkit/webkithittestresult.h: 9387 * webkit/webkitnetworkrequest.h: 9388 * webkit/webkitnetworkresponse.h: 9389 * webkit/webkitprivate.h: 9390 * webkit/webkitsecurityorigin.h: 9391 * webkit/webkitsoupauthdialog.h: 9392 * webkit/webkitversion.h.in: 9393 * webkit/webkitwebbackforwardlist.h: 9394 * webkit/webkitwebdatabase.h: 9395 * webkit/webkitwebdatasource.h: 9396 * webkit/webkitwebframe.h: 9397 * webkit/webkitwebhistoryitem.h: 9398 * webkit/webkitwebinspector.h: 9399 * webkit/webkitwebnavigationaction.h: 9400 * webkit/webkitwebpolicydecision.h: 9401 * webkit/webkitwebresource.h: 9402 * webkit/webkitwebsettings.h: 9403 * webkit/webkitwebview.h: 9404 * webkit/webkitwebwindowfeatures.h: 9405 94062009-10-03 Adam Barth <abarth@webkit.org> 9407 9408 More build fixing. 9409 9410 * webkit/webkitwebview.cpp: 9411 (webkit_web_view_go_back_or_forward): 9412 (webkit_web_view_can_go_back_or_forward): 9413 94142009-10-03 Adam Barth <abarth@webkit.org> 9415 9416 Unreviewed build fix. 9417 9418 * webkit/webkitwebview.cpp: 9419 (webkit_web_view_go_back_or_forward): 9420 94212009-10-03 Adam Barth <abarth@webkit.org> 9422 9423 Reviewed by Sam Weinig. 9424 9425 Factor PageController out of FrameLoader and Page 9426 https://bugs.webkit.org/show_bug.cgi?id=30037 9427 9428 * webkit/webkitwebview.cpp: 9429 (webkit_web_view_can_go_back_or_forward): 9430 94312009-10-01 Xan Lopez <xlopez@igalia.com> 9432 9433 Reviewed by Gustavo Noronha. 9434 9435 Set the type for the fake event, otherwise the test ASSERTs in 9436 debug builds. 9437 9438 * tests/testhittestresult.c: 9439 (load_status_cb): 9440 94412009-10-01 Martin Robinson <martin.james.robinson@gmail.com> 9442 9443 Reviewed by Xan Lopez. 9444 9445 [GTK] GtkIMContext filtering interferes with DOM key events 9446 https://bugs.webkit.org/show_bug.cgi?id=28733 9447 9448 Ensure that keyboard events filtered by the GtkIMContext still create 9449 the proper DOM events. 9450 9451 * WebCoreSupport/EditorClientGtk.cpp: 9452 (WebKit::clearPendingIMData): 9453 (WebKit::imContextCommitted): 9454 (WebKit::imContextPreeditChanged): 9455 (WebKit::EditorClient::shouldBeginEditing): 9456 (WebKit::EditorClient::shouldEndEditing): 9457 (WebKit::interpretEditorCommandKeyEvent): 9458 (WebKit::handleCaretBrowsingKeyboardEvent): 9459 (WebKit::EditorClient::handleKeyboardEvent): 9460 (WebKit::EditorClient::handleInputMethodKeydown): 9461 * tests/testkeyevents.c: Added. 9462 (test_info_new): 9463 (test_info_destroy): 9464 (key_event_fixture_setup): 9465 (key_event_fixture_teardown): 9466 (key_press_event_cb): 9467 (key_release_event_cb): 9468 (load_status_cb): 9469 (map_event_cb): 9470 (test_keypress): 9471 (main): 9472 94732009-09-29 Xan Lopez <xlopez@igalia.com> 9474 9475 Reviewed by Gustavo Noronha. 9476 9477 Do not set a non-default parent window for child widgets. We are 9478 just doing the same than the default path does, and on top of that 9479 if the widget's window changes (for example, during DnD widgets 9480 are usually unrealized/realized) the child widget will we left 9481 pointing to a dead window. 9482 9483 For examples of crashers caused by this see 9484 https://bugzilla.gnome.org/show_bug.cgi?id=596397 and 9485 https://bugzilla.gnome.org/show_bug.cgi?id=596398 9486 9487 * webkit/webkitwebview.cpp: 9488 (webkit_web_view_container_add): 9489 94902009-09-29 Xan Lopez <xlopez@igalia.com> 9491 9492 Rubber-stamped by Eric Seidel. 9493 9494 [Gtk] Crash when saving a password 9495 https://bugs.webkit.org/show_bug.cgi?id=28070 9496 9497 Disconnect the 'got-headers' callback when we are done with 9498 it. The signal can be emitted more than once if the message is 9499 retransmitted, but each time that happens authData is created 9500 again and a new callback connected, so we have to get rid of the 9501 old one (which will crash because we free authData). 9502 9503 * webkit/webkitsoupauthdialog.c: 9504 (save_password_callback): 9505 95062009-09-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9507 9508 Reviewed by Xan Lopez. 9509 9510 Pop down the context menu when the page transitions to committed, 9511 to avoid keeping a context menu out of context. 9512 9513 * WebCoreSupport/FrameLoaderClientGtk.cpp: 9514 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 9515 * webkit/webkitprivate.h: 9516 * webkit/webkitwebview.cpp: 9517 (destroy_menu_cb): 9518 (webkit_web_view_forward_context_menu_event): 9519 95202009-09-24 Jon Honeycutt <jhoneycutt@apple.com> 9521 9522 Reviewed by Alice Liu. 9523 9524 * webkit/webkitwebview.cpp: 9525 (webkit_web_view_init): 9526 Pass 0 for new Page constructor argument. 9527 95282009-09-24 Xan Lopez <xlopez@igalia.com> 9529 9530 Reviewed by Gustavo Noronha and Jan Alonzo. 9531 [GTK] Add WEBKIT_LOAD_ERROR status 9532 https://bugs.webkit.org/show_bug.cgi?id=29644 9533 9534 Add a new load-status enum value, WEBKIT_LOAD_FAILED, emitted when 9535 there's an error during the load process. This is needed if we 9536 want notify::load-status to be able to handle all situations, 9537 since WEBKIT_LOAD_FINISHED is not emitted when there's an error 9538 and we are lacking a notification of the load being stopped. 9539 9540 * WebCoreSupport/FrameLoaderClientGtk.cpp: 9541 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 9542 * tests/testloading.c: 9543 (web_loading_fixture_setup): 9544 (load_error_status_changed_cb): 9545 (load_error_cb): 9546 (test_loading_error): 9547 (load_cancelled_cb): 9548 (stop_load): 9549 (load_cancelled_status_changed_cb): 9550 (test_loading_cancelled): 9551 (main): 9552 * webkit/webkitwebframe.h: 9553 95542009-09-24 Xan Lopez <xlopez@igalia.com> 9555 9556 Revert r48697, since it broke key handling notification to GTK+. 9557 9558 * WebCoreSupport/EditorClientGtk.cpp: 9559 (WebKit::imContextCommitted): 9560 (WebKit::imContextPreeditChanged): 9561 (WebKit::EditorClient::shouldBeginEditing): 9562 (WebKit::EditorClient::shouldEndEditing): 9563 (WebKit::interpretKeyEvent): 9564 (WebKit::handleEditingKeyboardEvent): 9565 (WebKit::EditorClient::handleKeyboardEvent): 9566 (WebKit::EditorClient::handleInputMethodKeydown): 9567 95682009-09-23 Martin Robinson <martin.james.robinson@gmail.com> 9569 9570 Reviewed by Xan Lopez. 9571 9572 [GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images 9573 https://bugs.webkit.org/show_bug.cgi?id=29654 9574 9575 Ensure that even when GTKSimpleIMContext filters non-IME keystrokes, 9576 keyboard events are fired properly. 9577 9578 * WebCoreSupport/EditorClientGtk.cpp: 9579 (WebKit::clearPendingIMData): 9580 (WebKit::imContextCommitted): 9581 (WebKit::imContextPreeditChanged): 9582 (WebKit::EditorClient::shouldBeginEditing): 9583 (WebKit::EditorClient::shouldEndEditing): 9584 (WebKit::interpretEditorCommandKeyEvent): 9585 (WebKit::handleCaretBrowsingKeyboardEvent): 9586 (WebKit::EditorClient::handleKeyboardEvent): 9587 (WebKit::EditorClient::handleInputMethodKeydown): 9588 95892009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9590 9591 Reviewed by Xan Lopez. 9592 9593 [GTK] need to dump number of pending unload handlers 9594 https://bugs.webkit.org/show_bug.cgi?id=29685 9595 9596 * webkit/webkitprivate.h: 9597 * webkit/webkitwebframe.cpp: 9598 (webkit_web_frame_get_pending_unload_event_count): New function to 9599 satisfy DRT needs. 9600 96012009-09-23 Jan Michael Alonzo <jmalonzo@webkit.org> 9602 9603 Reviewed by Xan Lopez. 9604 9605 Minor reorganization to the patch landed in 9606 http://trac.webkit.org/changeset/48670. Also move JSCore-1.0.gir 9607 in the gtk directory as that's only useful to the Gtk port at the 9608 moment. 9609 9610 * JSCore-1.0.gir: Renamed from JSCore-1.0.gir. 9611 96122009-09-22 Xan Lopez <xlopez@igalia.com> 9613 9614 Reviewed by Jan Alonzo. 9615 9616 Hardcode element positions at 0,0 so that we know where to 9617 generate events to test WebKitHitTestResult. 9618 9619 * tests/testhittestresult.c: 9620 (load_status_cb): 9621 (test_webkit_hit_test_result): 9622 (main): 9623 96242009-09-22 Xan Lopez <xlopez@igalia.com> 9625 9626 Reviewed by Jan Alonzo. 9627 9628 [GTK] WebKitHitTestResult is completely broken in gmail 9629 https://bugs.webkit.org/show_bug.cgi?id=29527 9630 9631 We need to use the main or focused frame when doing the coordinate 9632 transformation instead of always using the main frame. 9633 9634 * webkit/webkitwebview.cpp: 9635 (webkit_web_view_get_hit_test_result): 9636 96372009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9638 9639 Update documentation control files to 1.1.15. 9640 9641 * docs/webkitgtk-docs.sgml: 9642 * docs/webkitgtk-sections.txt: 9643 96442009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9645 9646 Unreviewed docs build fix. Current CFLAGS and LIBS variables no 9647 longer bring gthread in. 9648 9649 * docs/GNUmakefile.am: 9650 96512009-09-21 Xan Lopez <xlopez@igalia.com> 9652 9653 Reviewed by Gustavo Noronha. 9654 9655 Update for release. 9656 9657 * NEWS: 9658 96592009-09-20 Xan Lopez <xlopez@igalia.com> 9660 9661 Reviewed by Gustavo Noronha. 9662 9663 Small documentation fix. 9664 9665 * webkit/webkithittestresult.cpp: 9666 96672009-09-18 Xan Lopez <xlopez@igalia.com> 9668 9669 Build fix. 9670 9671 Add missing file to the repository. 9672 9673 * tests/testhittestresult.c: Added. 9674 (test_info_new): 9675 (test_info_destroy): 9676 (hit_test_result_fixture_setup): 9677 (hit_test_result_fixture_teardown): 9678 (load_status_cb): 9679 (test_webkit_hit_test_result): 9680 (main): 9681 96822009-09-18 Kenneth Rohde Christiansen <kenneth@webkit.org> 9683 9684 [Gtk] Unreviewed build fix. 9685 9686 * WebCoreSupport/ChromeClientGtk.cpp: 9687 (WebKit::ChromeClient::platformPageClient): 9688 96892009-09-17 Kenneth Rohde Christiansen <kenneth@webkit.org> 9690 9691 Reviewed by Simon Hausmann. 9692 9693 Make PlatformWindow return something else than PlatformWidget 9694 https://bugs.webkit.org/show_bug.cgi?id=29085 9695 9696 Reflect the rename of platformWindow and it's return type. 9697 9698 * WebCoreSupport/ChromeClientGtk.cpp: 9699 (WebKit::ChromeClient::platformPageClient): 9700 (WebKit::ChromeClient::runOpenPanel): 9701 * WebCoreSupport/ChromeClientGtk.h: 9702 * webkit/webkitprivate.cpp: 9703 (currentToplevelCallback): 9704 * webkit/webkitwebview.cpp: 9705 (webkit_web_view_popup_menu_handler): 9706 97072009-09-18 Xan Lopez <xlopez@igalia.com> 9708 9709 Reviewed by Jan Alonzo. 9710 9711 Document webkit_web_view_stop_loading. 9712 9713 * webkit/webkitwebview.cpp: 9714 97152009-09-18 Xan Lopez <xlopez@igalia.com> 9716 9717 Reviewed by Gustavo Noronha and Jan Alonzo. 9718 9719 [GTK] context menu overriding API is very limited 9720 https://bugs.webkit.org/show_bug.cgi?id=27546 9721 9722 Add webkit_web_view_get_hit_test_result, a function to get a hit 9723 test result from a GdkEventButton. Useful to let applications 9724 decide between several actions on button press depending on what 9725 is being pressed. 9726 9727 * webkit/webkitwebview.cpp: 9728 (webkit_web_view_stop_loading): 9729 (documentPointForWindowPoint): 9730 (webkit_web_view_get_hit_test_result): 9731 * webkit/webkitwebview.h: 9732 97332009-09-18 Xan Lopez <xlopez@igalia.com> 9734 9735 Reviewed by Gustavo Noronha and Jan Alonzo. 9736 9737 [GTK] context menu overriding API is very limited 9738 https://bugs.webkit.org/show_bug.cgi?id=27546 9739 9740 Add WebKitHitTestResult, a wrapper over HitTestResult. It contains 9741 context information about a point in the web page. 9742 9743 * webkit/webkit.h: 9744 * webkit/webkitdefines.h: 9745 * webkit/webkithittestresult.cpp: Added. 9746 (webkit_hit_test_result_finalize): 9747 (webkit_hit_test_result_get_property): 9748 (webkit_hit_test_result_set_property): 9749 (webkit_hit_test_result_class_init): 9750 (webkit_hit_test_result_init): 9751 * webkit/webkithittestresult.h: Added. 9752 * webkit/webkitprivate.cpp: 9753 (WebKit::kit): 9754 * webkit/webkitprivate.h: 9755 97562009-09-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9757 9758 Reviewed by Xan Lopez and Jan Alonzo. 9759 9760 https://bugs.webkit.org/show_bug.cgi?id=29134 9761 [GTK] Add API to access sub resources 9762 9763 Implement getting subresources, and improve testing of 9764 main, and sub resources loading. 9765 97662009-09-11 Xan Lopez <xlopez@igalia.com> 9767 9768 Reviewed by Jan Alonzo. 9769 9770 [GTK] Use gtk_style_set_background instead of gdk_window_set_background 9771 https://bugs.webkit.org/show_bug.cgi?id=29173 9772 9773 Use gtk_style_set_background instead of gdk_window_set_background, 9774 as suggested by the documentation. Also, use GTK_STATE_NORMAL 9775 directly, since that's the default state of a GtkWidget. 9776 9777 * webkit/webkitwebview.cpp: 9778 (webkit_web_view_realize): 9779 97802009-09-09 Zan Dobersek <zandobersek@gmail.com> 9781 9782 Reviewed by Gustavo Noronha. 9783 9784 [GTK] DumpRenderTree needs eventSender object and implementation 9785 https://bugs.webkit.org/show_bug.cgi?id=25990 9786 9787 Creates a function that is accessible from the DumpRenderTree tool 9788 and calls the layout method on the frame view. 9789 9790 * webkit/webkitprivate.h: 9791 * webkit/webkitwebframe.cpp: 9792 (webkit_web_frame_layout): 9793 97942009-09-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9795 9796 Reviewed by Xan Lopez. 9797 9798 https://bugs.webkit.org/show_bug.cgi?id=29044 9799 [GTK] Should update suggested-filename when the response is received 9800 9801 Set suggested filename also when the response only comes after the 9802 download has started. 9803 9804 * webkit/webkitdownload.cpp: 9805 (webkit_download_set_response): 9806 (webkit_download_set_suggested_filename): 9807 * webkit/webkitwebview.cpp: 9808 (webkit_web_view_request_download): 9809 98102009-09-08 Priit Laes <plaes@plaes.org> 9811 9812 Reviewed by Gustavo Noronha. 9813 9814 Fix up erroneus 'Since: @version@' tags in documentation. 9815 9816 * webkit/webkitwebdatasource.cpp: 9817 * webkit/webkitwebresource.cpp: 9818 (webkit_web_resource_class_init): 9819 * webkit/webkitwebsettings.cpp: 9820 (webkit_web_settings_class_init): 9821 * webkit/webkitwebview.cpp: 9822 (webkit_web_view_class_init): 9823 * webkit/webkitwebwindowfeatures.cpp: 9824 98252009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9826 9827 Link new objects documents in the main document. 9828 9829 * docs/webkitgtk-docs.sgml: 9830 98312009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9832 9833 Documentation control files updated for 1.1.14. 9834 9835 * docs/webkitgtk-docs.sgml: 9836 * docs/webkitgtk-sections.txt: 9837 98382009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9839 9840 What's new for 1.1.14. 9841 9842 * NEWS: 9843 98442009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9845 9846 Rubber-stamped by Xan Lopez. 9847 9848 Use g_return_if_fail to check for the SoupURI creation, instead of 9849 printing a custom warning. 9850 9851 * webkit/webkitnetworkrequest.cpp: 9852 (webkit_network_request_set_uri): 9853 98542009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9855 9856 Reviewed by Xan Lopez. 9857 9858 https://bugs.webkit.org/show_bug.cgi?id=26854 9859 [GTK] Needs API to allow more control over outgoing requests 9860 9861 Map the willSendRequest delegate to the 'resource-request-starting' 9862 signal, allowing more control of the resources that are fetched. 9863 9864 Mapping willSendRequest properly requires an appropriate Response 9865 object, so we are introducing WebKitNetworkResponse, which works in a 9866 way similar to WebKitNetworkRequest. 9867 9868 * WebCoreSupport/FrameLoaderClientGtk.cpp: 9869 (WebKit::FrameLoaderClient::dispatchWillSendRequest): 9870 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): 9871 (WebKit::FrameLoaderClient::dispatchDidFinishLoading): 9872 (WebKit::FrameLoaderClient::dispatchDidFailLoading): 9873 * tests/testnetworkresponse.c: Added. 9874 (test_network_response_create_destroy): 9875 (test_network_response_properties): 9876 (main): 9877 * tests/testwebresource.c: 9878 (resource_request_starting_cb): 9879 (load_finished_cb): 9880 (test_web_resource_loading): 9881 (main): 9882 * webkit/webkit.h: 9883 * webkit/webkitdefines.h: 9884 * webkit/webkitnetworkrequest.cpp: 9885 * webkit/webkitnetworkresponse.cpp: Added. 9886 (webkit_network_response_dispose): 9887 (webkit_network_response_finalize): 9888 (webkit_network_response_get_property): 9889 (webkit_network_response_set_property): 9890 (webkit_network_response_class_init): 9891 (webkit_network_response_init): 9892 (webkit_network_response_new_with_core_response): 9893 (webkit_network_response_new): 9894 (webkit_network_response_set_uri): 9895 (webkit_network_response_get_uri): 9896 (webkit_network_response_get_message): 9897 * webkit/webkitnetworkresponse.h: Added. 9898 * webkit/webkitprivate.cpp: 9899 (WTF::SoupMessage): 9900 (WTF::WebKitNetworkRequest): 9901 (WTF::WebKitNetworkResponse): 9902 (WTF::WebKitWebResource): 9903 * webkit/webkitprivate.h: 9904 * webkit/webkitwebresource.cpp: 9905 (webkit_web_resource_cleanup): 9906 (webkit_web_resource_finalize): 9907 (webkit_web_resource_class_init): 9908 (webkit_web_resource_set_property): 9909 (webkit_web_resource_get_uri): 9910 * webkit/webkitwebview.cpp: 9911 (webkit_web_view_class_init): 9912 * webkitmarshal.list: 9913 99142009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9915 9916 Reviewed by Jan Alonzo. 9917 9918 https://bugs.webkit.org/show_bug.cgi?id=28979 9919 [GTK] Misc improvments to NetworkRequest 9920 9921 Unref message in dispose, as it should be, not in finalize. 9922 9923 * webkit/webkitnetworkrequest.cpp: 9924 (webkit_network_request_dispose): 9925 (webkit_network_request_finalize): 9926 (webkit_network_request_class_init): 9927 99282009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 9929 9930 Reviewed by Jan Alonzo. 9931 9932 https://bugs.webkit.org/show_bug.cgi?id=28979 9933 [GTK] Misc improvments to NetworkRequest 9934 9935 Bring documentation up-to-date with reality regarding NetworkRequest. 9936 9937 * webkit/webkitnetworkrequest.cpp: 9938 99392009-09-07 Xan Lopez <xlopez@igalia.com> 9940 9941 Reviewed by Gustavo Noronha. 9942 9943 Make the auth dialog usable when libsoup does not have a 9944 SoupPasswordManager, since it might go away in the next 9945 development cycle. 9946 9947 * webkit/webkitsoupauthdialog.c: 9948 (response_callback): 9949 (session_can_save_passwords): 9950 (session_authenticate): 99512009-09-06 Xan Lopez <xlopez@igalia.com> 9952 9953 Reviewed by Gustavo Noronha. 9954 9955 Update the unitests to latest changes wrt scrollbar policy. 9956 9957 * tests/testwindow.c: 9958 (test_webkit_window_scrollbar_policy): 9959 99602009-09-06 Martin Robinson <martin.james.robinson@gmail.com> 9961 9962 Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez. 9963 9964 [Gtk] Expose a database API 9965 https://bugs.webkit.org/show_bug.cgi?id=27899 9966 9967 Expose an HTML5 database API for GTK+. 9968 9969 * WebCoreSupport/ChromeClientGtk.cpp: 9970 (WebKit::ChromeClient::print): 9971 * webkit/webkit.h: 9972 * webkit/webkitdefines.h: 9973 * webkit/webkitprivate.cpp: 9974 (webkit_init): 9975 * webkit/webkitprivate.h: 9976 * webkit/webkitsecurityorigin.cpp: Added. 9977 (webkit_security_origin_finalize): 9978 (webkit_security_origin_dispose): 9979 (webkit_security_origin_set_property): 9980 (webkit_security_origin_get_property): 9981 (webkit_security_origins): 9982 (webkit_security_origin_class_init): 9983 (webkit_security_origin_init): 9984 (webkit_security_origin_get_protocol): 9985 (webkit_security_origin_get_host): 9986 (webkit_security_origin_get_port): 9987 (webkit_security_origin_get_web_database_usage): 9988 (webkit_security_origin_get_web_database_quota): 9989 (webkit_security_origin_set_web_database_quota): 9990 (webkit_security_origin_get_all_web_databases): 9991 (WebKit::kit): 9992 (WebKit::core): 9993 (webkit_security_origin_get_web_database): 9994 * webkit/webkitsecurityorigin.h: Added. 9995 * webkit/webkitwebdatabase.cpp: Added. 9996 (webkit_web_database_finalize): 9997 (webkit_web_database_dispose): 9998 (webkit_web_database_set_property): 9999 (webkit_web_database_get_property): 10000 (webkit_web_database_class_init): 10001 (webkit_web_database_init): 10002 (webkit_web_database_set_security_origin): 10003 (webkit_web_database_set_name): 10004 (webkit_web_database_get_security_origin): 10005 (webkit_web_database_get_name): 10006 (webkit_web_database_get_display_name): 10007 (webkit_web_database_get_expected_size): 10008 (webkit_web_database_get_size): 10009 (webkit_web_database_get_filename): 10010 (webkit_web_database_remove): 10011 (webkit_remove_all_web_databases): 10012 (webkit_get_web_database_directory_path): 10013 (webkit_set_web_database_directory_path): 10014 (webkit_get_default_web_database_quota): 10015 * webkit/webkitwebdatabase.h: Added. 10016 * webkit/webkitwebframe.cpp: 10017 (webkit_web_frame_new): 10018 (webkit_web_frame_get_focused_accessible_element): 10019 (webkit_web_frame_get_horizontal_scrollbar_policy): 10020 * webkit/webkitwebframe.h: 10021 * webkit/webkitwebview.cpp: 10022 (webkit_web_view_class_init): 10023 100242009-09-03 Adam Barth <abarth@webkit.org> 10025 10026 Reviewed by eric@webkit.org. 10027 10028 https://bugs.webkit.org/show_bug.cgi?id=24696 10029 10030 Stub implementations of mixed content methods of FrameLoaderClient. 10031 10032 * WebCoreSupport/FrameLoaderClientGtk.cpp: 10033 (WebKit::FrameLoaderClient::didDisplayInsecureContent): 10034 (WebKit::FrameLoaderClient::didRunInsecureContent): 10035 * WebCoreSupport/FrameLoaderClientGtk.h: 10036 100372009-09-03 Xan Lopez <xlopez@igalia.com> 10038 10039 Reviewed by Gustavo Noronha. 10040 10041 Access private member variables directly instead of using the 10042 accessor. 10043 10044 * WebCoreSupport/FrameLoaderClientGtk.cpp: 10045 (WebKit::FrameLoaderClient::createFrame): 10046 (WebKit::FrameLoaderClient::windowObjectCleared): 10047 100482009-09-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10049 10050 Reviewed by Xan Lopez. 10051 10052 Remove bogus asserts that break Debug builds at runtime. 10053 10054 * WebCoreSupport/DocumentLoaderGtk.cpp: 10055 (WebKit::DocumentLoader::detachFromFrame): 10056 (WebKit::DocumentLoader::decreaseLoadCount): 10057 100582009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org> 10059 10060 Reviewed by Xan Lopez and Gustavo Noronha. 10061 10062 [Gtk] Implement a WebDataSource for the gtk port 10063 https://bugs.webkit.org/show_bug.cgi?id=24758 10064 10065 Add data source API getters to WebKitWebFrame. 10066 Also add WebKitWebDataSource unit test. 10067 10068 * tests/testwebdatasource.c: Added. 10069 * webkit/webkitwebframe.cpp: 10070 * webkit/webkitwebframe.h: 10071 100722009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org> 10073 10074 Reviewed by Xan Lopez and Gustavo Noronha. 10075 10076 [Gtk] Implement a WebDataSource for the gtk port 10077 https://bugs.webkit.org/show_bug.cgi?id=24758 10078 10079 Subclass DocumentLoader for Gtk and implement it under the WebKit 10080 namespace. Add WebKitWebDataSource implementation that closely 10081 follows the mac implementation of the API. 10082 10083 * WebCoreSupport/DocumentLoaderGtk.cpp: Added. 10084 * WebCoreSupport/DocumentLoaderGtk.h: Added. 10085 * webkit/webkitwebdatasource.cpp: Added. 10086 * webkit/webkitwebdatasource.h: Added. 10087 100882009-09-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10089 10090 Reviewed by Xan Lopez. 10091 10092 Avoid causing unexpected issues with window sizing when sites 10093 disable scrollbars completely. 10094 10095 * WebCoreSupport/ChromeClientGtk.cpp: 10096 (WebKit::ChromeClient::scrollbarsModeDidChange): 10097 * tests/testwindow.c: 10098 (test_webkit_window_scrollbar_policy): 10099 * webkit/webkitwebframe.cpp: 10100 (webkit_web_frame_class_init): 10101 101022009-09-01 Jan Michael Alonzo <jmalonzo@webkit.org> 10103 10104 Reviewed by Xan Lopez and Gustavo Noronha. 10105 10106 [Gtk] Implement a WebDataSource for the gtk port 10107 https://bugs.webkit.org/show_bug.cgi?id=24758 10108 10109 Implement WebKitWebResource for the resource-related API for 10110 WebKitWebDataSource. 10111 10112 * GNUmakefile.am: 10113 101142009-09-01 Xan Lopez <xlopez@igalia.com> 10115 10116 Reviewed by Jan Alonzo. 10117 10118 https://bugs.webkit.org/show_bug.cgi?id=28842 10119 [GTK] Do not emit extra FINISHED load-status signals 10120 10121 Do not emit FINISHED load-status signals on our own, just rely on 10122 WebCore for that. Avoids emitting FINISHED several times when we 10123 fail to load a URI. 10124 10125 * WebCoreSupport/FrameLoaderClientGtk.cpp: 10126 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): 10127 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 10128 * tests/testloading.c: 10129 (web_loading_fixture_setup): 10130 (web_loading_fixture_teardown): 10131 (load_finished_cb): 10132 (status_changed_cb): 10133 (test_loading_status): 10134 (load_error_status_changed_cb): 10135 (load_error_cb): 10136 (test_loading_error): 10137 (main): 10138 * webkit/webkitwebframe.h: 10139 101402009-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10141 10142 Reviewed by Alexey Proskuryakov. 10143 10144 https://bugs.webkit.org/show_bug.cgi?id=28466 10145 When downloading a file, two GET requests are sent to the HTTP server 10146 10147 Support reusing a connection that is already ongoing, instead of 10148 cancelling the connection and creating another. 10149 10150 * WebCoreSupport/FrameLoaderClientGtk.cpp: 10151 (WebKit::FrameLoaderClient::download): 10152 * webkit/webkitdownload.cpp: 10153 (webkit_download_new_with_handle): 10154 (webkit_download_start): 10155 * webkit/webkitprivate.h: 10156 * webkit/webkitwebview.cpp: 10157 (webkit_web_view_request_download): 10158 101592009-08-31 Alexey Proskuryakov <ap@apple.com> 10160 10161 Gtk build fix. 10162 10163 This is also a behavior fix, at least on debug builds - a caller of 10164 webkit_web_history_item_new_with_data() could pass an URL that could cause an assertion 10165 failure in KURL. 10166 10167 * webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_new_with_data): Pass a null 10168 KURL as base to parse properly. 10169 101702009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10171 10172 Reviewed by Holger Freyther. 10173 10174 https://bugs.webkit.org/show_bug.cgi?id=25889 10175 [GTK] scrollbar policy for main frame is not implementable 10176 10177 Add properties and a signal to report scrollbar policy changes to 10178 client code, and a default handler that does the right thing when 10179 using GtkScrolledWindow. 10180 10181 * WebCoreSupport/ChromeClientGtk.cpp: 10182 (WebKit::ChromeClient::scrollbarsModeDidChange): 10183 * WebCoreSupport/ChromeClientGtk.h: 10184 * webkit/webkitwebframe.cpp: 10185 (webkit_web_frame_get_property): 10186 (webkit_web_frame_class_init): 10187 (webkit_web_frame_get_horizontal_scrollbar_policy): 10188 (webkit_web_frame_get_vertical_scrollbar_policy): 10189 * webkit/webkitwebframe.h: 10190 * tests/testwindow.c: Added. 10191 (load_finished_cb): 10192 (test_webkit_window_scrollbar_policy): 10193 (main): 10194 101952009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org> 10196 10197 Reviewed by Gustavo Noronha and Xan Lopez. 10198 10199 [Gtk] Add view source mode API 10200 https://bugs.webkit.org/show_bug.cgi?id=28805 10201 10202 Implement setter and getter for "view source" mode. 10203 10204 * webkit/webkitwebview.cpp: 10205 (webkit_web_view_set_view_source_mode): 10206 (webkit_web_frame_get_view_source_mode): 10207 * webkit/webkitwebview.h: 10208 102092009-08-26 Xan Lopez <xlopez@igalia.com> 10210 10211 Reviewed by Gustavo Noronha. 10212 10213 https://bugs.webkit.org/show_bug.cgi?id=28738 10214 Expose undo/redo functionality in WebKitWebView 10215 10216 Expose undo/redo functionality in WebKitWebView, keeping the 10217 default bindings as they were. 10218 10219 * WebCoreSupport/EditorClientGtk.cpp: 10220 (WebKit::): 10221 * webkit/webkitwebview.cpp: 10222 (webkit_web_view_real_undo): 10223 (webkit_web_view_real_redo): 10224 (webkit_web_view_class_init): 10225 (webkit_web_view_can_undo): 10226 (webkit_web_view_undo): 10227 (webkit_web_view_can_redo): 10228 (webkit_web_view_redo): 10229 * webkit/webkitwebview.h: 10230 102312009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10232 10233 Reviewed by Xan Lopez. 10234 10235 News about the 1.1.13 release. 10236 10237 * NEWS: 10238 102392009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10240 10241 Reviewed by Xan Lopez. 10242 10243 Add new symbols, and an index of new symbols for the 1.1.13 10244 release. 10245 10246 * docs/webkitgtk-docs.sgml: 10247 * docs/webkitgtk-sections.txt: 10248 102492009-08-23 Xan Lopez <xlopez@igalia.com> 10250 10251 Reviewed by Gustavo Noronha. 10252 10253 Fix a couple of typos. 10254 10255 * webkit/webkitwebsettings.cpp: 10256 (webkit_web_settings_class_init): 10257 102582009-08-23 Xan Lopez <xlopez@igalia.com> 10259 10260 Reviewed by Gustavo Noronha. 10261 10262 Update editing-behavior property here too. 10263 10264 * webkit/webkitwebview.cpp: 10265 (webkit_web_view_settings_notify): 10266 102672009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org> 10268 10269 Rubberstamped by Gustavo Noronha. 10270 10271 Fix regressions introduced by http://trac.webkit.org/changeset/47690. 10272 10273 Update the setting whenever the property gets set. 10274 10275 * webkit/webkitwebview.cpp: 10276 (webkit_web_view_settings_notify): 10277 102782009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org> 10279 10280 Reviewed by Xan Lopez. 10281 10282 [Gtk] API for disabling local file access to web URLs 10283 https://bugs.webkit.org/show_bug.cgi?id=28663 10284 10285 Add a setting to enable or disable file access to web URLs. It's 10286 disabled by default for security reasons. 10287 10288 * webkit/webkitwebsettings.cpp: 10289 (webkit_web_settings_class_init): 10290 (webkit_web_settings_set_property): 10291 (webkit_web_settings_get_property): 10292 (webkit_web_settings_copy): 10293 * webkit/webkitwebview.cpp: 10294 (webkit_web_view_update_settings): 10295 102962009-08-22 Xan Lopez <xlopez@igalia.com> 10297 10298 Reviewed by Jan Alonzo. 10299 10300 https://bugs.webkit.org/show_bug.cgi?id=28154 10301 clicking below end of text in a textarea moves cursor to wrong position 10302 10303 Expose the EditingBehavior setting and set it by default to Mac, 10304 since that what matches the GTK+ default behavior. 10305 10306 * webkit/webkitprivate.cpp: 10307 (WebKit::core): 10308 * webkit/webkitprivate.h: 10309 * webkit/webkitwebsettings.cpp: 10310 (webkit_web_settings_class_init): 10311 (webkit_web_settings_set_property): 10312 (webkit_web_settings_get_property): 10313 (webkit_web_settings_copy): 10314 * webkit/webkitwebsettings.h: 10315 * webkit/webkitwebview.cpp: 10316 (webkit_web_view_update_settings): 10317 103182009-08-20 Aaron Boodman <aa@chromium.org> 10319 10320 Hopefully the last speculative build for gtk. 10321 10322 * webkit/webkitprivate.cpp: 10323 (webkit_white_list_access_from_origin): 10324 * webkit/webkitprivate.h: 10325 103262009-08-20 David Levin <levin@chromium.org> 10327 10328 Another speculative build for gtk. 10329 10330 * webkit/webkitprivate.cpp: 10331 (webkit_white_list_access_to_origin): 10332 103332009-08-20 David Levin <levin@chromium.org> 10334 10335 Speculative build for gtk. 10336 10337 * webkit/webkitprivate.cpp: 10338 (webkit_white_list_access_to_origin): 10339 103402009-08-19 Aaron Boodman <aa@chromium.org> 10341 10342 Fix build break. 10343 10344 * webkit/webkitprivate.h: "WEBKIT API" -> "WEBKIT_API" 10345 103462009-08-19 Aaron Boodman <aa@chromium.org> 10347 10348 Reviewed by David Levin. 10349 10350 https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to 10351 specify a more granular policy for cross-origin XHR access. 10352 10353 * webkit/webkitprivate.cpp: 10354 (webkit_white_list_access_to_origin): Add API to manipulate origin access whitelists. 10355 (webkit_reset_origin_access_white_lists): Ditto. 10356 * webkit/webkitprivate.h: Ditto. 10357 103582009-08-18 Xan Lopez <xlopez@igalia.com> 10359 10360 Rubber-stamped by Holger Freyther. 10361 10362 Remove an unneeded include. 10363 10364 * WebCoreSupport/DragClientGtk.cpp: 10365 103662009-08-18 Fumitoshi Ukai <ukai@chromium.org> 10367 10368 Reviewed by Eric Seidel. 10369 10370 https://bugs.webkit.org/show_bug.cgi?id=28443 10371 Fix build break with gtk older than 2.14. 10372 10373 WebKit gtk port requires gtk 2.10 or later, but DragClientGtk.cpp 10374 uses gtk_widget_get_window that is introduced in 2.14. 10375 10376 * WebCoreSupport/DragClientGtk.cpp: 10377 define gtk_widget_get_window for gtk older than 2.14. 10378 103792009-08-18 Jan Michael Alonzo <jmalonzo@webkit.org> 10380 10381 Reviewed by Oliver Hunt. 10382 10383 [Gtk] crash when closing page from javascript 10384 https://bugs.webkit.org/show_bug.cgi?id=27439 10385 10386 Do not unref the WebView in ChromeClientGtk::closeWindowSoon 10387 because (1) a create-web-view handler can return a NULL WebView, 10388 (2) the created WebView is owned by its containing widget, and (3) 10389 clients may not handle the close-web-view signal so this avoids 10390 unreffing a WebView more than once. 10391 10392 * WebCoreSupport/ChromeClientGtk.cpp: 10393 (WebKit::ChromeClient::closeWindowSoon): 10394 * webkit/webkitwebview.cpp: 10395 (webkit_web_view_class_init): 10396 103972009-08-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10398 10399 Reviewed by Jan Alonzo. 10400 10401 https://bugs.webkit.org/show_bug.cgi?id=19360 10402 Frags on current page don't generate "navigation-requested" events 10403 10404 Fix order of parameters for the creation of SubstituteData object, 10405 so that normal data loads do not have an unreachable URL. Also 10406 remove a confusion about the purpose of the last parameter. 10407 10408 * webkit/webkitwebframe.cpp: 10409 (webkit_web_frame_load_data): 10410 104112009-08-18 Drew Wilson <atwilson@google.com> 10412 10413 Reviewed by Eric Seidel. 10414 10415 Need to extend DumpRenderTree to expose number of worker threads 10416 https://bugs.webkit.org/show_bug.cgi?id=28292 10417 10418 * webkit/webkitprivate.h: 10419 * webkit/webkitworkers.cpp: Added. 10420 (webkit_worker_thread_count): 10421 Exposed WebCore::WorkerThread::workerThreadCount() for the gtk version of DumpRenderTree. 10422 104232009-08-18 Xan Lopez <xlopez@igalia.com> 10424 10425 Reviewed by Gustavo Noronha. 10426 10427 Fix the ATK unit test. 10428 10429 We now support line boundaries in the get_text functions, so we 10430 need to make sure the test has the layout we expect by giving it 10431 enough space to fit in one line. 10432 10433 * tests/testatk.c: 10434 (test_webkit_atk_get_text_at_offset): 10435 104362009-08-15 Zan Dobersek <zandobersek@gmail.com> 10437 10438 Reviewed by Xan Lopez. 10439 10440 Fix compiler warnings. 10441 10442 * webkit/webkitwebview.cpp: 10443 (clipboard_contents_received): 10444 (webkit_web_view_drag_data_get): 10445 104462009-08-14 Jiahua Huang <jhuangjiahua@gmail.com> 10447 10448 Reviewed by Jan Alonzo. 10449 10450 [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target. 10451 https://bugs.webkit.org/show_bug.cgi?id=27028 10452 10453 Add a function in WebKit::PasteboardHelperGtk that will return the 10454 value of WEBKIT_WEB_VIEW_TARGET_INFO_HTML, 10455 and WebCore::clipboard_get_contents_cb will use that. 10456 10457 * WebCoreSupport/PasteboardHelperGtk.cpp: 10458 (WebKit::PasteboardHelperGtk::getWebViewTargetInfoHtml): 10459 * WebCoreSupport/PasteboardHelperGtk.h: 10460 104612009-08-14 Benjamin Otte <otte@gnome.org> 10462 10463 Reviewed by Gustavo Noronha. 10464 10465 Fix webkit_web_view_set_highlight_text_matches() so that highlighting 10466 works properly in documents with frames. 10467 10468 * webkit/webkitwebview.cpp: 10469 (webkit_web_view_set_highlight_text_matches): 10470 104712009-08-13 Zan Dobersek <zandobersek@gmail.com> 10472 10473 Reviewed by Gustavo Noronha. 10474 10475 [GTK] Drag and drop support 10476 https://bugs.webkit.org/show_bug.cgi?id=23642 10477 10478 Adds support for drag actions in WebKitWebView and DragClient. 10479 10480 Defines a support structure that can hold additional drag and drop data, 10481 such as selection data or target IDs (infos) and can be passed through 10482 clipboard requests. 10483 10484 Implements DragClient functions that gather start position of the drag 10485 and start the GTK drag. 10486 10487 * WebCoreSupport/DragClientGtk.cpp: 10488 (WebKit::DragClient::DragClient): 10489 (WebKit::DragClient::willPerformDragSourceAction): 10490 (WebKit::DragClient::startDrag): 10491 (WebKit::DragClient::createDragImageForLink): A small style fix. 10492 * WebCoreSupport/DragClientGtk.h: 10493 * webkit/webkitwebview.cpp: 10494 (webkit_web_view_drag_end): 10495 (clipboard_contents_received): GtkClipboard callback. 10496 (webkit_web_view_drag_data_get): 10497 (webkit_web_view_class_init): 10498 (webkit_web_view_init): 10499 * webkit/webkitwebview.h: Add GTK selection targets. 10500 105012009-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10502 10503 Unreviewed build fix. 10504 10505 Last-minute change on the new soup API to use the keyring was not 10506 reflected in our usage - the documentation says we should use 10507 g_slist_free, and soup_auth_free_saved_users doesn't exist. 10508 10509 * webkit/webkitsoupauthdialog.c: 10510 (session_authenticate): 10511 105122009-08-12 Xan Lopez <xlopez@igalia.com> 10513 10514 Reviewed by Jan Alonzo. 10515 10516 [GTK] Remove keyring optional features 10517 https://bugs.webkit.org/show_bug.cgi?id=28173 10518 10519 Remove keyring support from our code and rely on libsoup to store 10520 the authentication data if the user requests that support in their 10521 application/library. 10522 10523 * webkit/webkitsoupauthdialog.c: 10524 (response_callback): 10525 (show_auth_dialog): 10526 (session_authenticate): 10527 105282009-08-11 Benjamin Otte <otte@gnome.org> 10529 10530 Reviewed by Xan Lopez. 10531 10532 When instructed to print an out-of-range page, print an empty page 10533 instead of crashing. 10534 10535 * webkit/webkitwebframe.cpp: 10536 (draw_page_callback): 10537 105382009-08-10 Brady Eidson <beidson@apple.com> 10539 10540 GTK build fix. 10541 10542 * webkit/webkitdownload.cpp: 10543 (webkit_download_get_suggested_filename): 10544 105452009-08-08 Xan Lopez <xlopez@igalia.com> 10546 10547 Roll out r46928, since it wasn't done in accordance with the 10548 agreed naming. 10549 10550 * ChangeLog: 10551 10552 Remove the ChangeLog entry, since it was added at the bottom of 10553 the file. 10554 10555 * gdom/GdomDOMObject.h: Removed. 10556 * gdom/GdomDOMObjectPrivate.h: Removed. 10557 105582009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org> 10559 10560 Reviewed by Xan Lopez. 10561 10562 [Gtk] Enable accessibility in Gtk DRT 10563 https://bugs.webkit.org/show_bug.cgi?id=25989 10564 10565 Add SPI to get the focused accessible element to be used by DRT. 10566 10567 * webkit/webkitprivate.h: 10568 * webkit/webkitwebframe.cpp: 10569 (webkit_web_frame_get_focused_accessible_element): 10570 105712009-07-30 Martin Robinson <mrobinson@appcelerator.com> 10572 10573 Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo. 10574 10575 [GTK] new-window-policy-decision-requested provides no information about the target frame 10576 https://bugs.webkit.org/show_bug.cgi?id=27792 10577 10578 Add frameName property to the WebKitWebNavigation object. 10579 10580 * WebCoreSupport/FrameLoaderClientGtk.cpp: 10581 (WebKit::getNavigationAction): 10582 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): 10583 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 10584 * webkit/webkitwebnavigationaction.cpp: 10585 (webkit_web_navigation_action_get_property): 10586 (webkit_web_navigation_action_set_property): 10587 (webkit_web_navigation_action_class_init): 10588 (webkit_web_navigation_action_get_target_frame): 10589 (webkit_web_navigation_action_set_target_frame): 10590 * webkit/webkitwebnavigationaction.h: 10591 105922009-07-29 Kevin McCullough <kmccullough@apple.com> 10593 10594 Reviewed by Darin Adler. 10595 10596 Added foundation work to allow a testing infrastructure for the Web 10597 Inspector. 10598 10599 * WebCoreSupport/InspectorClientGtk.cpp: 10600 (WebKit::InspectorClient::inspectorWindowObjectCleared): 10601 * WebCoreSupport/InspectorClientGtk.h: 10602 106032009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org> 10604 10605 Reviewed by Eric Seidel and Xan Lopez. 10606 10607 [Gtk] Enable http/tests/appcache tests 10608 https://bugs.webkit.org/show_bug.cgi?id=27674 10609 10610 Add 'enable-offline-web-application-cache' WebSetting to enable 10611 or disable the appcache. Also, Add appcache SPI for DRT to use. 10612 10613 * webkit/webkitapplicationcache.cpp: Added. 10614 (webkit_application_cache_set_maximum_size): 10615 * webkit/webkitprivate.cpp: 10616 (webkit_init): 10617 * webkit/webkitprivate.h: 10618 * webkit/webkitwebsettings.cpp: 10619 (webkit_web_settings_class_init): 10620 (webkit_web_settings_set_property): 10621 (webkit_web_settings_get_property): 10622 (webkit_web_settings_copy): 10623 * webkit/webkitwebview.cpp: 10624 (webkit_web_view_update_settings): 10625 (webkit_web_view_settings_notify): 10626 106272009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10628 10629 Reviewed by Xan Lopez. 10630 10631 Add information about the regression fix for WEBKIT_DEBUG. 10632 10633 * NEWS: 10634 106352009-07-28 Priit Laes <plaes@plaes.org> 10636 10637 Reviewed by Xan Lopez. 10638 10639 Fix mnemonics in the soup authentication dialog. 10640 10641 * webkit/webkitsoupauthdialog.c: 10642 (show_auth_dialog): 10643 106442009-07-28 Xan Lopez <xlopez@igalia.com> 10645 10646 Reviewed by Gustavo Noronha. 10647 10648 * NEWS: update for 1.1.12 release. 10649 106502009-07-27 Alexey Proskuryakov <ap@webkit.org> 10651 10652 Build fix. 10653 10654 * webkit/webkitwebframe.cpp: (webkit_gc_count_javascript_objects): Added a namespace to 10655 SilenceAssertionsOnly. 10656 106572009-07-27 Alexey Proskuryakov <ap@webkit.org> 10658 10659 Reviewed by Darin Adler. 10660 10661 https://bugs.webkit.org/show_bug.cgi?id=27735 10662 Give a helpful name to JSLock constructor argument 10663 10664 * webkit/webkitwebframe.cpp: 10665 (webkit_gc_count_javascript_objects): 10666 106672009-07-24 Priit Laes <plaes@plaes.org> 10668 10669 Reviewed by Xan Lopez. 10670 10671 [Gtk] Password is saved into gnome-keyring even if auth. fails 10672 https://bugs.webkit.org/show_bug.cgi?id=27560 10673 10674 Check authentication result and save password only when authentication 10675 succeeds. 10676 10677 * webkit/webkitsoupauthdialog.c: 10678 (free_authData): 10679 (response_callback): 10680 (save_password_callback): 10681 106822009-07-24 Andrei Popescu <andreip@google.com> 10683 10684 Reviewed by Anders Carlsson. 10685 10686 ApplicationCache should have size limit 10687 https://bugs.webkit.org/show_bug.cgi?id=22700 10688 10689 * WebCoreSupport/ChromeClientGtk.cpp: 10690 (WebKit::ChromeClient::reachedMaxAppCacheSize): 10691 Adds empty implementation of reachedMaxAppCacheSize. 10692 * WebCoreSupport/ChromeClientGtk.h: 10693 106942009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org> 10695 10696 Reviewed by Eric Seidel. 10697 10698 [Gtk] Add implementation of GCController for DRT 10699 https://bugs.webkit.org/show_bug.cgi?id=27636 10700 10701 Add SPI for GCController to use. 10702 10703 * webkit/webkitprivate.h: 10704 * webkit/webkitwebframe.cpp: 10705 (webkit_gc_collect_javascript_objects): 10706 (webkit_gc_collect_javascript_objects_on_alternate_thread): 10707 (webkit_gc_count_javascript_objects): 10708 107092009-07-22 Xan Lopez <xlopez@igalia.com> 10710 10711 Reviewed by Mark Rowe. 10712 10713 Fix compiler warning. 10714 10715 * tests/testwebsettings.c: 10716 (test_webkit_web_settings_user_agent): 10717 107182009-07-22 Xan Lopez <xlopez@igalia.com> 10719 10720 Reviewed by Gustavo Noronha. 10721 10722 Remove unused variables. 10723 10724 * webkit/webkitwebview.cpp: 10725 (webkit_web_view_grab_focus): 10726 (webkit_web_view_focus_in_event): 10727 107282009-07-21 Priit Laes <plaes@plaes.org> 10729 10730 Reviewed by Holger Freyther. 10731 10732 [GTK+] Missing accelerator in authentication dialog 10733 https://bugs.webkit.org/show_bug.cgi?id=25509 10734 10735 Add accelerator to checkbox text. 10736 10737 * WebKit/gtk/webkit/webkitsoupauthdialog.c: 10738 (show_auth_dialog): 10739 107402009-07-21 Priit Laes <plaes@plaes.org> 10741 10742 Reviewed by Holger Freyther. 10743 10744 [GTK] http auth dialog pops up twice after a cancelled atempt 10745 https://bugs.webkit.org/show_bug.cgi?id=24818 10746 10747 Remove workaround required for libsoup versions <=2.26.2 as we depend 10748 on 2.27.4 now. 10749 10750 * webkit/webkitsoupauthdialog.c: 10751 (session_authenticate): 10752 107532009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10754 10755 Reviewed by Holger Freyther. 10756 10757 [GTK] Widget size negotiation 10758 https://bugs.webkit.org/show_bug.cgi?id=17154 10759 10760 Implement proper size request for the WebView widget. 10761 10762 * WebCoreSupport/ChromeClientGtk.cpp: 10763 (WebKit::ChromeClient::contentsSizeChanged): 10764 * webkit/webkitwebview.cpp: 10765 (webkit_web_view_size_request): 10766 (webkit_web_view_class_init): 10767 107682009-07-16 Holger Hans Peter Freyther <zecke@selfish.org> 10769 10770 Reviewed by Jan Alonzo. 10771 10772 [GTK+] Update the focus handling code. 10773 10774 Change focus-in to always call setActive(true), call 10775 FocusController::setFocusedFrame when no focused frame exists 10776 other SelectionController::setActive. This is matching Windows 10777 and Qt. 10778 10779 On focus-out call FocusController::setActive(false) and 10780 SelectionController::setFocued(false). This is matching Windows 10781 and Qt as well. 10782 10783 * webkit/webkitwebview.cpp: 10784 (webkit_web_view_focus_in_event): 10785 (webkit_web_view_focus_out_event): 10786 107872009-07-16 Xiaomei Ji <xji@chromium.org> 10788 10789 Reviewed by Dan Bernstein. 10790 10791 This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's." 10792 https://bugs.webkit.org/show_bug.cgi?id=24187 10793 10794 Add one extra parameter to the callee of HitTestResult::title() due to the signature change. 10795 10796 10797 * WebCoreSupport/ChromeClientGtk.cpp: 10798 (WebKit::ChromeClient::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title(). 10799 108002009-07-16 Xiaomei Ji <xji@chromium.org> 10801 10802 Reviewed by Darin Adler. 10803 10804 Fix tooltip does not get its directionality from its element's directionality. 10805 https://bugs.webkit.org/show_bug.cgi?id=24187 10806 10807 Per mitz's suggestion in comment #6, while getting the plain-text 10808 title, we also get the directionality of the title. How to handle 10809 the directionality is up to clients. Clients could ignore it, 10810 or use attribute or unicode control characters to display the title 10811 as what they want. 10812 10813 * WebCoreSupport/ChromeClientGtk.cpp: 10814 (WebKit::ChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet). 10815 * WebCoreSupport/ChromeClientGtk.h: Add directionality as 2nd parameter to setToolTip(). 10816 108172009-07-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10818 10819 Rubber-stamped by Jan Alonzo. 10820 10821 Fix enable-xss-auditor property documentation, and default value 10822 to match the fact that it is now enabled by default. 10823 10824 * webkit/webkitwebsettings.cpp: 10825 (webkit_web_settings_class_init): 10826 108272009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu> 10828 10829 Reviewed by Darin Adler. 10830 10831 Change all Noncopyable inheriting visibility to public. 10832 https://bugs.webkit.org/show_bug.cgi?id=27225 10833 10834 Change all Noncopyable inheriting visibility to public because 10835 it is needed to the custom allocation framework (bug #20422). 10836 10837 * webkit/webkitdownload.cpp: 10838 108392009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10840 10841 Unreviewed. Late NEWS file for 1.1.11. 10842 10843 * NEWS: 10844 108452009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10846 10847 Unreviewed. Changes to the doc control files for 1.1.11. 10848 10849 * docs/webkitgtk-docs.sgml: 10850 * docs/webkitgtk-sections.txt: 10851 108522009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10853 10854 Rubber-stamped by Holger Freyther. 10855 10856 Fix unit test to use the correct assumption that the SoupMessage 10857 will be NULL when WebKitNetworkRequest is created from an URI. 10858 10859 * tests/testnetworkrequest.c: 10860 (test_network_request_create_destroy): 10861 108622009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org> 10863 10864 <https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk] 10865 REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html 10866 10867 Reviewed by Gustavo Noronha. 10868 10869 focus-in and focus-out events only get triggered when there's user 10870 interaction, hence setFocused(bool) never gets called when 10871 focusEvent is triggered when running the layout tests. The 10872 solution seems to be to implement grab-focus too so we can call 10873 setFocused(bool) when a widget has focus. 10874 10875 * webkit/webkitwebview.cpp: 10876 (webkit_web_view_grab_focus): 10877 (webkit_web_view_focus_in_event): 10878 (webkit_web_view_class_init): 10879 108802009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org> 10881 10882 https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT 10883 10884 Reviewed by Gustavo Noronha and Xan Lopez. 10885 10886 Add API to support opening and closing of JavaScript windows automatically. 10887 10888 * WebCoreSupport/ChromeClientGtk.cpp: 10889 (WebKit::ChromeClient::closeWindowSoon): 10890 * webkit/webkitprivate.h: 10891 * webkit/webkitwebsettings.cpp: 10892 (webkit_web_settings_class_init): 10893 (webkit_web_settings_set_property): 10894 (webkit_web_settings_get_property): 10895 (webkit_web_settings_copy): 10896 * webkit/webkitwebview.cpp: 10897 (webkit_web_view_real_close_web_view): 10898 (webkit_web_view_class_init): 10899 (webkit_web_view_update_settings): 10900 (webkit_web_view_settings_notify): 10901 (webkit_web_view_set_group_name): 10902 * webkit/webkitwebview.h: 10903 109042009-07-12 Brent Fulgham <bfulgham@gmail.com> 10905 10906 Speculative build fix after http://trac.webkit.org/changeset/45786. 10907 10908 * WebCoreSupport/ChromeClientGtk.cpp: 10909 (WebKit::ChromeClient::addMessageToConsole): 10910 * WebCoreSupport/ChromeClientGtk.h: 10911 109122009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com> 10913 10914 Reviewed by Dave Hyatt. 10915 10916 Make Widget RefCounted to fix: 10917 10918 <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs 10919 at WebCore::Widget::afterMouseDown() after clicking To Do's close 10920 box 10921 <rdar://problem/6978804> WER #16: Repro Access Violation in 10922 WebCore::PluginView::bindingInstance (1310178023) 10923 -and- 10924 <rdar://problem/6991251> WER #13: Crash in WebKit! 10925 WebCore::PluginView::performRequest+203 (1311461169) 10926 10927 * WebCoreSupport/FrameLoaderClientGtk.cpp: 10928 (WebKit::FrameLoaderClient::createPlugin): 10929 (WebKit::FrameLoaderClient::createJavaAppletWidget): 10930 * WebCoreSupport/FrameLoaderClientGtk.h: 10931 109322009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 10933 10934 Reviewed by Jan Alonzo. 10935 10936 Use soup's content sniffing 10937 https://bugs.webkit.org/show_bug.cgi?id=26982 10938 10939 Add the new Content Sniffing feature provided by libsoup. 10940 10941 * webkit/webkitprivate.cpp: 10942 (webkit_init): 10943 109442009-07-05 Holger Hans Peter Freyther <zecke@selfish.org> 10945 10946 Reviewed by Xan Lopez. 10947 10948 Always initialize WebCore. 10949 10950 It is possible that WebKitWebSettings and other classes get 10951 constructed before the WebKitWebView. In this case WebCore is 10952 not yet properly initialized. Add webkit_init to every class 10953 that can be constructed by API users. 10954 10955 * webkit/webkitdownload.cpp: 10956 (webkit_download_class_init): 10957 * webkit/webkitnetworkrequest.cpp: 10958 (webkit_network_request_class_init): 10959 * webkit/webkitwebbackforwardlist.cpp: 10960 (webkit_web_back_forward_list_class_init): 10961 * webkit/webkitwebhistoryitem.cpp: 10962 (webkit_web_history_item_class_init): 10963 * webkit/webkitwebsettings.cpp: 10964 (webkit_web_settings_class_init): 10965 * webkit/webkitwebwindowfeatures.cpp: 10966 (webkit_web_window_features_class_init): 10967 109682009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org> 10969 10970 Reviewed by Xan Lopez and Gustavo Noronha. 10971 10972 Set user-agent from application 10973 https://bugs.webkit.org/show_bug.cgi?id=17375 10974 10975 Add 'user-agent' setter/getter API to WebSettings. 10976 10977 * WebCoreSupport/FrameLoaderClientGtk.cpp: 10978 (WebKit::FrameLoaderClient::FrameLoaderClient): 10979 (WebKit::FrameLoaderClient::userAgent): 10980 * WebCoreSupport/FrameLoaderClientGtk.h: 10981 * webkit/webkitprivate.h: 10982 * webkit/webkitversion.h.in: 10983 * webkit/webkitwebsettings.cpp: 10984 (webkit_get_user_agent): 10985 (webkit_web_settings_class_init): 10986 (webkit_web_settings_finalize): 10987 (webkit_web_settings_set_property): 10988 (webkit_web_settings_get_property): 10989 (webkit_web_settings_copy): 10990 (webkit_web_settings_get_user_agent): 10991 * webkit/webkitwebsettings.h: 10992 * webkit/webkitwebview.cpp: 10993 (webkit_web_view_dispose): 10994 109952009-07-02 Xan Lopez <xlopez@igalia.com> 10996 10997 Reviewed by Holger Freyther. 10998 10999 Update the new boolean property in FocusController that keeps 11000 track of whether or not the Page is focused. 11001 11002 * webkit/webkitwebview.cpp: 11003 (webkit_web_view_focus_in_event): 11004 (webkit_web_view_focus_out_event): 11005 110062009-06-29 Xan Lopez <xlopez@igalia.com> 11007 11008 Reviewed by Jan Alonzo. 11009 11010 Fix a couple of compiler warnings. 11011 11012 * webkit/webkitwebnavigationaction.cpp: 11013 * webkit/webkitwebview.cpp: 11014 (webkit_web_view_real_move_cursor): 11015 110162009-06-28 Xan Lopez <xlopez@igalia.com> 11017 11018 Fix the GTK+ build. 11019 11020 * WebCoreSupport/ContextMenuClientGtk.cpp: 11021 (WebKit::ContextMenuClient::isSpeaking): 11022 * WebCoreSupport/ContextMenuClientGtk.h: 11023 110242009-06-24 Jiahua Huang <jhuangjiahua@gmail.com> 11025 11026 Reviewed by Holger Freyther. 11027 11028 [Gtk] Add Undo/Redo support to WebKitGtk 11029 https://bugs.webkit.org/show_bug.cgi?id=26573 11030 11031 Implement EditorClient::undo and other interested funcs. 11032 11033 * WebCoreSupport/EditorClientGtk.cpp: 11034 (WebKit::EditorClient::registerCommandForUndo): 11035 (WebKit::EditorClient::registerCommandForRedo): 11036 (WebKit::EditorClient::clearUndoRedoOperations): 11037 (WebKit::EditorClient::canUndo): 11038 (WebKit::EditorClient::canRedo): 11039 (WebKit::EditorClient::undo): 11040 (WebKit::EditorClient::redo): 11041 (WebKit::EditorClient::EditorClient): 11042 * WebCoreSupport/EditorClientGtk.h: 11043 110442009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org> 11045 11046 Reviewed by Gustavo Noronha and Xan Lopez. 11047 11048 [Gtk] Implement DRT XSS auditor support 11049 https://bugs.webkit.org/show_bug.cgi?id=26571 11050 11051 Add a setting "enable-xss-auditor" to enable this feature. 11052 11053 * webkit/webkitwebsettings.cpp: 11054 (webkit_web_settings_class_init): 11055 (webkit_web_settings_set_property): 11056 (webkit_web_settings_get_property): 11057 (webkit_web_settings_copy): 11058 * webkit/webkitwebview.cpp: 11059 (webkit_web_view_update_settings): 11060 (webkit_web_view_settings_notify): 11061 110622009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org> 11063 11064 Reviewed by Gustavo Noronha and Xan Lopez. 11065 11066 webkit_web_back_forward_list_add_item() should add a ref for the history item 11067 https://bugs.webkit.org/show_bug.cgi?id=26517 11068 11069 Add a ref to the WebHistoryItem when it's added to the back 11070 forward list through webkit_web_back_forward_list_add_item. 11071 This keeps the history item alive and prevents pywebkitgtk from 11072 crashing 11073 11074 * tests/testwebbackforwardlist.c: 11075 (test_webkit_web_history_item_lifetime): 11076 (test_webkit_web_back_forward_list_order): 11077 (test_webkit_web_back_forward_list_add_item): 11078 * webkit/webkitwebbackforwardlist.cpp: 11079 (webkit_web_back_forward_list_add_item): 11080 110812009-06-20 Gustavo Noronha Silva <gns@gnome.org> 11082 11083 Reviewed by Jan Alonzo. 11084 11085 Initial test case for loading statuses. 11086 11087 * tests/testloading.c: Added. 11088 (load_finished_cb): 11089 (status_changed_cb): 11090 (test_loading_status): 11091 (main): 11092 110932009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11094 11095 Rubber-stamped by Jan Alonzo. 11096 11097 Fix the ordering in which the new load status goes into the enum 11098 to avoid ABI breakage. 11099 11100 * webkit/webkitwebframe.h: 11101 111022009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11103 11104 Reviewed by Xan Lopez and Christian Dywan. 11105 11106 Add a new load status to report that the first visually non-empty 11107 layout has been done. 11108 11109 * WebCoreSupport/FrameLoaderClientGtk.cpp: 11110 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout): 11111 * webkit/webkitwebframe.h: 11112 111132009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11114 11115 Reviewed by Xan Lopez. 11116 11117 Fix parameters of navigation-policy-decision-requested callback, 11118 to be correct in number and type 11119 11120 * tests/testhttpbackend.c: 11121 (navigation_policy_decision_requested_cb): 11122 111232009-06-18 Christian Dywan <christian@twotoasts.de> 11124 11125 Reviewed by Gustavo Noronha. 11126 11127 * WebCoreSupport/FrameLoaderClientGtk.cpp: 11128 (WebKit::loadDone): 11129 (WebKit::FrameLoaderClient::dispatchDidFinishLoad): 11130 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): 11131 (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static 11132 function loadDone to emit "load-done" and update the status and update 11133 the relevent places. We missed some status notifications before. 11134 111352009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11136 11137 Rubber-stamped by Xan Lopez. 11138 11139 Be consistent in always using the term URI instead of URL in the 11140 documentation of WebKitWebView signals. 11141 11142 * webkit/webkitwebview.cpp: 11143 (webkit_web_view_class_init): 11144 111452009-06-16 Xan Lopez <xlopez@igalia.com> 11146 11147 Reviewed by Gustavo Noronha. 11148 11149 Do not use g_assert_cmpint to test for NULL pointer, just 11150 g_assert. 11151 11152 * tests/testnetworkrequest.c: 11153 (test_network_request_create_destroy): 11154 111552009-06-15 Xan Lopez <xlopez@igalia.com> 11156 11157 Reviewed by Gustavo Noronha. 11158 11159 https://bugs.webkit.org/show_bug.cgi?id=26377 11160 [GTK] Confusion about range of 'progress' property 11161 11162 Range for the progress property is 0.0 .. 1.0, don't multiply it 11163 by 100 to make it a percentage. 11164 11165 * webkit/webkitwebview.cpp: 11166 (webkit_web_view_get_progress): 11167 111682009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11169 11170 Unreviewed. Add new symbols list for 1.1.10 release. 11171 11172 * docs/webkitgtk-docs.sgml: 11173 111742009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11175 11176 Rubber-stamped by Xan Lopez. 11177 11178 Fix Since tags for the new uri and message properties. 11179 11180 * webkit/webkitnetworkrequest.cpp: 11181 (webkit_network_request_class_init): 11182 111832009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11184 11185 Unreviewed. Adding new documented API to the generated 11186 documentation. 11187 11188 * docs/webkitgtk-sections.txt: 11189 111902009-06-15 Xan Lopez <xlopez@igalia.com> 11191 11192 Reviewed by Gustavo Noronha. 11193 11194 Update NEWS for 1.1.10 release. 11195 11196 * NEWS: 11197 111982009-06-11 Gustavo Noronha Silva <gns@gnome.org> 11199 11200 Reviewed by Xan Lopez. 11201 11202 Add a test to perform an actual download. 11203 11204 * tests/testdownload.c: 11205 (navigation_policy_decision_requested_cb): 11206 (notify_status_cb): 11207 (download_requested_cb): 11208 (test_webkit_download_perform): 11209 (main): 11210 112112009-06-11 Gustavo Noronha Silva <gns@gnome.org> 11212 11213 Reviewed by Xan Lopez. 11214 11215 Fix crash when downloading, caused by assuming SoupMessage would 11216 be there. This change factors the logic required to create a 11217 ResourceRequest from a WebKitNetworkRequest into a core() 11218 function, like we have for some other classes. 11219 11220 * webkit/webkitdownload.cpp: 11221 (webkit_download_start): 11222 * webkit/webkitprivate.cpp: 11223 (WebKit::core): 11224 * webkit/webkitprivate.h: 11225 * webkit/webkitwebframe.cpp: 11226 (webkit_web_frame_load_request): 11227 112282009-06-10 Gustavo Noronha Silva <gns@gnome.org> 11229 11230 Reviewed by Xan Lopez. 11231 11232 Make WebKitNetworkRequest a proper GObject, making URI and 11233 SoupMessage properties. Also adding unit tests for creation and 11234 destruction. 11235 11236 * tests/testnetworkrequest.c: Added. 11237 (test_network_request_create_destroy): 11238 (test_network_request_properties): 11239 (main): 11240 * webkit/webkitnetworkrequest.cpp: 11241 (webkit_network_request_get_property): 11242 (webkit_network_request_set_property): 11243 (webkit_network_request_class_init): 11244 (webkit_network_request_init): 11245 (webkit_network_request_constructor): 11246 (webkit_network_request_new_with_core_request): 11247 (webkit_network_request_new): 11248 (webkit_network_request_set_uri): 11249 (webkit_network_request_get_uri): 11250 * webkit/webkitnetworkrequest.h: 11251 112522009-06-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11253 11254 Reviewed by Xan Lopez. 11255 11256 News for 1.1.9. 11257 11258 * NEWS: 11259 112602009-06-09 Jan Michael Alonzo <jmalonzo@webkit.org> 11261 11262 Reviewed by Gustavo Noronha. 11263 11264 Clear the frame name before we run each tests so we don't get 11265 "someFloaString" or "3" in the target frame name. 11266 11267 * webkit/webkitprivate.h: 11268 * webkit/webkitwebframe.cpp: 11269 (webkit_web_frame_clear_main_frame_name): 11270 11271 112722009-06-10 Xan Lopez <xlopez@igalia.com> 11273 11274 Reviewed by Jan Alonzo. 11275 11276 https://bugs.webkit.org/show_bug.cgi?id=25415 11277 [GTK][ATK] Please implement support for get_text_at_offset 11278 11279 Update test for new implementation (it fixes two bugs and adds 11280 actual implementations for LINE boundaries). 11281 11282 * tests/testatk.c: 11283 (test_webkit_atk_get_text_at_offset): 11284 112852009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11286 11287 Reviewed by Xan Lopez. 11288 11289 https://bugs.webkit.org/show_bug.cgi?id=26104 11290 [GTK] Make NetworkRequest a proper GObject and expose SoupMessage 11291 11292 Refactor how SoupMessage is handled, so that our ResourceRequest 11293 object doesn't have to store it as a member, which complicates 11294 managing ResourceRequest's lifetvime. 11295 11296 * tests/testhttpbackend.c: 11297 (navigation_policy_decision_requested_cb): 11298 (test_soup_message_lifetime): 11299 * webkit/webkitnetworkrequest.cpp: 11300 (WTF::SoupMessage): 11301 (webkit_network_request_new_with_core_request): 11302 113032009-06-08 Gustavo Noronha Silva <gns@gnome.org> 11304 11305 Reviewed by Jan Alonzo. 11306 11307 https://bugs.webkit.org/show_bug.cgi?id=26240 11308 [GTK] Try again button loses query strings 11309 11310 Only trigger reload, when try again is clicked, this way we do not 11311 lose the query strings, like we did when also triggering a form 11312 submission. 11313 11314 * resources/error.html: 11315 113162009-06-06 Gustavo Noronha Silva <gns@gnome.org> 11317 11318 Reviewed by Xan Lopez. 11319 11320 https://bugs.webkit.org/show_bug.cgi?id=26175 11321 [GTK] Download progress notification should be throttled, for the benefit of download managers 11322 11323 Throttle notifications for the 'progress' property of the Download 11324 object, and update documentation to note the fact that this is 11325 being done, and how to get all notifications if you really care 11326 about them. 11327 11328 * webkit/webkitdownload.cpp: 11329 (webkit_download_class_init): 11330 (webkit_download_received_data): 11331 113322009-05-29 Jan Michael Alonzo <jmalonzo@webkit.org> 11333 11334 Reviewed by Gustavo Noronha. 11335 11336 Fixed compile warning when comparing the different navigation types 11337 11338 * webkit/webkitwebnavigationaction.cpp: 11339 (webkit_web_navigation_action_class_init): 11340 113412009-05-29 Xan Lopez <xlopez@igalia.com> 11342 11343 Reviewed by Gustavo Noronha. 11344 11345 https://bugs.webkit.org/show_bug.cgi?id=26075 11346 [GTK] Refactor key scrolling code 11347 11348 After the scrolling changes in r44177 we can now use the 11349 FrameView::scroll method like the other ports, keeping the magic 11350 constants for the scrolling amounts inside WebCore proper. 11351 11352 * webkit/webkitwebview.cpp: 11353 (webkit_web_view_real_move_cursor): 11354 113552009-05-29 Gustavo Noronha Silva <gns@gnome.org> 11356 11357 Reviewed by Jan Alonzo. 11358 11359 Make NetworkRequest carry a reference of the SoupMessage used by 11360 ResourceRequest, and use that to create new ResourceRequests where 11361 needed, so that no information is lost while passing around 11362 NetworkRequest objects. 11363 11364 * WebCoreSupport/FrameLoaderClientGtk.cpp: 11365 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): 11366 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 11367 (WebKit::FrameLoaderClient::startDownload): 11368 * webkit/webkitdownload.cpp: 11369 (webkit_download_start): 11370 * webkit/webkitnetworkrequest.cpp: 11371 (webkit_network_request_finalize): 11372 (webkit_network_request_new_with_core_request): 11373 (webkit_network_request_new): 11374 (webkit_network_request_get_message): 11375 * webkit/webkitprivate.h: 11376 * webkit/webkitwebframe.cpp: 11377 (webkit_web_frame_load_request): 11378 113792009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11380 11381 Reviewed by Xan Lopez. 11382 11383 https://bugs.webkit.org/show_bug.cgi?id=26048 11384 navigation-policy-decision-requested documentation incomplete 11385 11386 Fix documentation for all policy decision request signals, to 11387 mention that an actual decision is expected when you return TRUE, 11388 meaning that you handled the signal. 11389 11390 * webkit/webkitwebview.cpp: 11391 (webkit_web_view_class_init): 11392 113932009-05-28 Xan Lopez <xlopez@igalia.com> 11394 11395 Reviewed by Gustavo Noronha. 11396 11397 Mention the implementation of the new AtkText methods. 11398 11399 * NEWS: 11400 114012009-05-19 Xan Lopez <xlopez@igalia.com> 11402 11403 Reviewed by Jan Alonzo and Gustavo Noronha. 11404 11405 https://bugs.webkit.org/show_bug.cgi?id=25415 11406 [GTK][ATK] Please implement support for get_text_at_offset 11407 11408 New test file for ATK functionality. 11409 11410 * tests/testatk.c: Added. 11411 (bail_out): 11412 (test_get_text_function): 11413 (test_webkit_atk_get_text_at_offset): 11414 (main): 11415 114162009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11417 11418 Reviewed by Xan Lopez. 11419 11420 Document changes worth noting for 1.1.8. 11421 11422 * NEWS: 11423 114242009-05-27 Xan Lopez <xlopez@igalia.com> 11425 11426 Reviewed by Gustavo Noronha. 11427 11428 https://bugs.webkit.org/show_bug.cgi?id=26039 11429 [GTK] WebKitWebHistoryItem lifetime fixes 11430 11431 Modify the management of history items by the BackForward list. 11432 11433 Having the objects add themselves to a hash table with an extra 11434 reference made impossible for the cleanup code in the dispose 11435 method to be ever called in normal conditions, since dispose is 11436 called before getting rid of the last reference, which the objects 11437 were making to themselves. Get rid of this extra reference and 11438 move the responsibility of the cleanup to the BackForward list 11439 itself, which effectively owns the WebKitWebHistoryItems now. 11440 11441 Also, update the tests to reflect this change. 11442 11443 * tests/testwebbackforwardlist.c: 11444 (test_webkit_web_history_item_lifetime): 11445 (test_webkit_web_back_forward_list_order): 11446 (test_webkit_web_back_forward_list_add_item): 11447 * tests/testwebhistoryitem.c: 11448 (web_history_item_fixture_setup): 11449 (web_history_item_fixture_teardown): 11450 * webkit/webkitprivate.h: 11451 * webkit/webkitwebbackforwardlist.cpp: 11452 (webkit_web_back_forward_list_dispose): 11453 (webkit_web_back_forward_list_class_init): 11454 * webkit/webkitwebhistoryitem.cpp: 11455 (webkit_history_items): 11456 (webkit_history_item_add): 11457 (webkit_web_history_item_dispose): 11458 (WebKit::kit): 11459 114602009-05-26 Xan Lopez <xlopez@igalia.com> 11461 11462 Reviewed by Jan Alonzo. 11463 11464 https://bugs.webkit.org/show_bug.cgi?id=26039 11465 [GTK] WebKitWebHistoryItem lifetime fixes 11466 11467 Delete the BackForwardList before the Page, otherwise the references 11468 to the WebKitWebHistoryItems will be gone. 11469 11470 * webkit/webkitwebview.cpp: 11471 (webkit_web_view_dispose): 11472 114732009-05-27 Gustavo Noronha Silva <gns@gnome.org> 11474 11475 Reviewed by Xan Lopez. 11476 11477 Add comment to clarify why scrolling is done as it is and not with 11478 gdk_window_scroll. 11479 11480 * WebCoreSupport/ChromeClientGtk.cpp: 11481 (WebKit::ChromeClient::scroll): 11482 114832009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11484 11485 Unreviewed. Adding new symbols index for 1.1.8. 11486 11487 * docs/webkitgtk-docs.sgml: 11488 114892009-05-26 Holger Hans Peter Freyther <zecke@selfish.org> 11490 11491 Reviewed by Xan Lopez. 11492 11493 Add a new signal called "create-plugin-widget" and emit it from 11494 within the FrameLoaderClientGtk::createPlugin method. If a 11495 GtkWidget gets returned it will be embedded as a WebCore::Widget 11496 using the new GtkPluginWidget. 11497 11498 * WebCoreSupport/FrameLoaderClientGtk.cpp: 11499 (WebKit::FrameLoaderClient::createPlugin): 11500 * webkit/webkitwebview.cpp: 11501 (webkit_signal_accumulator_object_handled): 11502 (webkit_web_view_class_init): 11503 * webkitmarshal.list: 11504 115052009-05-24 Xan Lopez <xlopez@igalia.com> 11506 11507 Reviewed by Mark Rowe. 11508 11509 https://bugs.webkit.org/show_bug.cgi?id=25987 11510 [GTK] Clarify WebKitWebView::download-requested documentation 11511 11512 Explain a bit why this signal is not emitted by default and offer 11513 a common solution/setup for that issue. 11514 11515 * webkit/webkitwebview.cpp: 11516 (webkit_web_view_class_init): 11517 115182009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org> 11519 11520 Rubber-stamped by Gustavo Noronha. 11521 11522 Break the switch once private browsing is selected. 11523 11524 * webkit/webkitwebsettings.cpp: 11525 (webkit_web_settings_set_property): 11526 (webkit_web_settings_get_property): 11527 115282009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org> 11529 11530 Reviewed by Gustavo Noronha and Xan Lopez. 11531 11532 [Gtk] Enable database and localStorage support 11533 https://bugs.webkit.org/show_bug.cgi?id=25629 11534 11535 Add settings to enable or disable database and localStorage 11536 support and enable them by default. This allows databases to be 11537 shown in the WebInspector as well as allow us to run the storage 11538 layout tests. 11539 11540 * webkit/webkitwebsettings.cpp: 11541 (webkit_web_settings_class_init): 11542 (webkit_web_settings_set_property): 11543 (webkit_web_settings_get_property): 11544 (webkit_web_settings_copy): 11545 * webkit/webkitwebview.cpp: 11546 (webkit_web_view_update_settings): 11547 (webkit_web_view_settings_notify): 11548 115492009-05-23 David Kilzer <ddkilzer@apple.com> 11550 11551 Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr 11552 11553 <https://bugs.webkit.org/show_bug.cgi?id=25495> 11554 11555 Reviewed by Oliver Hunt. 11556 11557 * WebCoreSupport/ChromeClientGtk.h: 11558 (WebKit::ChromeClient::createHTMLParserQuirks): Return a 11559 PassOwnPtr<> instead of a raw HTMLParserQuirks pointer. 11560 115612009-05-22 Gustavo Noronha Silva <gns@gnome.org> 11562 11563 Reviewed by Jan Alonzo. 11564 11565 Improve NetworkRequest documentation. 11566 11567 * webkit/webkitnetworkrequest.cpp: 11568 (webkit_network_request_class_init): 11569 (webkit_network_request_init): 11570 115712009-05-21 Xan Lopez <xlopez@igalia.com> 11572 11573 Reviewed by Maciej Stachowiak. 11574 11575 https://bugs.webkit.org/show_bug.cgi?id=24818 11576 [GTK] http auth dialog pops up twice after a cancelled atempt 11577 11578 Workaround libsoup bug 11579 http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made 11580 libsoup emit the 'authenticate' signal more often than it was 11581 expected. 11582 11583 We'll be able to remove this when we depend on libsoup > 2.26.2. 11584 11585 * webkit/webkitsoupauthdialog.c: 11586 (session_authenticate): 11587 115882009-05-21 Darin Fisher <darin@chromium.org> 11589 11590 Fix build bustage. 11591 11592 * WebCoreSupport/EditorClientGtk.cpp: 11593 (WebKit::EditorClient::getAutoCorrectSuggestionForMisspelledWord): Add stub for method. 11594 * WebCoreSupport/EditorClientGtk.h: 11595 115962009-05-20 Holger Hans Peter Freyther <zecke@selfish.org> 11597 11598 Reviewed by Darin Adler. 11599 11600 https://bugs.webkit.org/show_bug.cgi?id=25834 11601 11602 Make ChromeClient a interface again 11603 11604 With recent additions to ChromeClient.h empty defaults were 11605 added. This is bad for porters as these changes go unnoticed 11606 and at runtime no notImplemented warning is logged and grepping 11607 for notImplemented will not show anything. Change this Client 11608 to be like the other Clients again and always have pure virtuals 11609 (but for stuff inside #ifdef PLATFORM(MAC)). 11610 11611 Update the various WebKit/* implementations to compile again. 11612 11613 * WebCoreSupport/ChromeClientGtk.cpp: 11614 (WebKit::ChromeClient::setCursor): 11615 (WebKit::ChromeClient::requestGeolocationPermissionForFrame): 11616 * WebCoreSupport/ChromeClientGtk.h: 11617 (WebKit::ChromeClient::scrollRectIntoView): 11618 116192009-05-19 Xan Lopez <xlopez@igalia.com> 11620 11621 Reviewed by Jan Alonzo. 11622 11623 Do not try to free enchant broker and dictionary if they do not 11624 exist, those functions aren't NULL-safe. 11625 11626 * webkit/webkitwebsettings.cpp: 11627 (free_spell_checking_language): 11628 116292009-05-15 Gustavo Noronha Silva <gns@gnome.org> 11630 11631 Reviewed by Jan Alonzo. 11632 11633 Plug memory leak. 11634 11635 * webkit/webkitwebsettings.cpp: 11636 (free_spell_checking_language): 11637 (webkit_web_settings_finalize): 11638 (webkit_web_settings_set_property): 11639 116402009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch> 11641 11642 Reviewed by Jan Alonzo. 11643 11644 Converting filename to uri by concatenating strings is broken 11645 on Windows. Use proper glib conversion functions. 11646 11647 * webkit/webkitwebview.cpp: 11648 (webkit_web_view_open): 11649 * tests/testdownload.c: 11650 (test_webkit_download_create): 11651 116522009-05-13 Xan Lopez <xlopez@igalia.com> 11653 11654 Reviewed by Gustavo Noronha. 11655 11656 Do not handle KeyEvents with Ctrl or Alt modifiers that we 11657 otherwise know nothing about. Otherwise shortcuts defined in the 11658 WebView will never be executed. 11659 11660 * WebCoreSupport/EditorClientGtk.cpp: 11661 (WebKit::handleEditingKeyboardEvent): 11662 116632009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11664 11665 Add information about the SVG index bounds check committed in 11666 r43590. 11667 11668 * NEWS: 11669 116702009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11671 11672 Reviewed by Xan Lopez. 11673 11674 Note changes since 1.1.6. 11675 11676 * NEWS: 11677 116782009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11679 11680 Unreviewed. Updated control file, and main file for the 1.1.7 11681 release. 11682 11683 * docs/webkitgtk-docs.sgml: 11684 * docs/webkitgtk-sections.txt: 11685 116862009-05-11 Holger Hans Peter Freyther <zecke@selfish.org> 11687 11688 Reviewed by Xan Lopez. 11689 11690 https://bugs.webkit.org/show_bug.cgi?id=25685 11691 [GTK] Middle click paste form the pasteboard 11692 11693 For paste from middle button (button==2) we want to use 11694 the GDK_PRIMARY_SELECTION. Implement the new getCurrentTarget 11695 method in PasteboardHelperGtk by asking the WebView which 11696 clipboard to use. 11697 11698 * WebCoreSupport/PasteboardHelperGtk.cpp: 11699 (WebKit::PasteboardHelperGtk::getCurrentTarget): 11700 * WebCoreSupport/PasteboardHelperGtk.h: 11701 * webkit/webkitprivate.h: 11702 * webkit/webkitwebview.cpp: 11703 (webkit_web_view_button_press_event): 11704 (webkit_web_view_use_primary_for_paste): 11705 117062009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org> 11707 11708 Reviewed by Holger Freyther. 11709 11710 [Gtk] Various autotools build refactoring and fixes 11711 https://bugs.webkit.org/show_bug.cgi?id=25286 11712 11713 Add glib-2.0 to the list of required package. 11714 11715 * webkit.pc.in: 11716 117172009-05-11 Christian Dywan <christian@twotoasts.de> 11718 11719 Reviewed by Gustavo Noronha. 11720 11721 https://bugs.webkit.org/show_bug.cgi?id=25697 11722 [GTK] Warnings building WebKit/gtk/tests/testwebframe.c 11723 11724 * tests/testwebframe.c: 11725 (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget* 11726 to fix pointer type incompatibility warnings. 11727 117282009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11729 11730 Reviewed by Xan Lopez. 11731 11732 Make the scan program call g_thread_init(NULL) in addition to 11733 g_type_init(), so that it actually works. 11734 11735 * docs/GNUmakefile.am: 11736 117372009-05-08 Xan Lopez <xlopez@igalia.com> 11738 11739 Reviewed by Gustavo Noronha. 11740 11741 Unify scrolling code via adjustments and keys. Use the WebCore 11742 defined constants, since that's what people are most used to at 11743 this point. 11744 11745 * ChangeLog: 11746 * webkit/webkitwebview.cpp: 11747 (webkit_web_view_real_move_cursor): 11748 117492009-05-07 Christian Dywan <christian@twotoasts.de> 11750 11751 Reviewed by Gustavo Noronha. 11752 11753 * WebCoreSupport/FrameLoaderClientGtk.cpp: 11754 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): 11755 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): Add missing 11756 call to notifyStatus in the committed case and a missing property notify. 11757 117582009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11759 11760 Reviewed by Xan Lopez. 11761 11762 https://bugs.webkit.org/show_bug.cgi?id=24786 11763 WebKitDownload sometimes suggests peculiar filenames 11764 11765 When a download is requested by an ongoing request, use the already 11766 provided response to set the suggested filename for the WebKitDownload 11767 object, if available. 11768 11769 * WebCoreSupport/FrameLoaderClientGtk.cpp: 11770 (WebKit::FrameLoaderClient::download): 11771 * webkit/webkitdownload.cpp: 11772 (_WebKitDownloadPrivate::webkit_download_set_property): 11773 (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): 11774 (_WebKitDownloadPrivate::webkit_download_set_suggested_filename): 11775 * webkit/webkitprivate.h: 11776 * webkit/webkitwebview.cpp: 11777 117782009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org> 11779 11780 Reviewed by Holger Freyther. 11781 11782 GTK+ API implementation files have bogus extern "C" entries 11783 https://bugs.webkit.org/show_bug.cgi?id=24322 11784 11785 Remove bogus extern "C" from the source files. 11786 11787 * webkit/webkitdownload.cpp: 11788 (DownloadClient::cannotShowURL): 11789 * webkit/webkiterror.cpp: 11790 (webkit_plugin_error_quark): 11791 * webkit/webkitnetworkrequest.cpp: 11792 (webkit_network_request_get_uri): 11793 * webkit/webkitprivate.cpp: 11794 (webkit_init): 11795 * webkit/webkitversion.cpp: 11796 (webkit_micro_version): 11797 * webkit/webkitwebbackforwardlist.cpp: 11798 * webkit/webkitwebframe.cpp: 11799 (webkit_web_frame_get_load_status): 11800 * webkit/webkitwebhistoryitem.cpp: 11801 * webkit/webkitwebinspector.cpp: 11802 (webkit_web_inspector_set_inspector_client): 11803 * webkit/webkitwebnavigationaction.cpp: 11804 (webkit_web_navigation_action_get_modifier_state): 11805 * webkit/webkitwebpolicydecision.cpp: 11806 (webkit_web_policy_decision_cancel): 11807 * webkit/webkitwebsettings.cpp: 11808 (webkit_web_settings_get_spell_languages): 11809 * webkit/webkitwebview.cpp: 11810 * webkit/webkitwebwindowfeatures.cpp: 11811 (webkit_web_window_features_equal): 11812 118132009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org> 11814 11815 Reviewed by Holger Freyther. 11816 11817 Misc fixes to InspectorClientGtk. 11818 11819 * WebCoreSupport/InspectorClientGtk.cpp: 11820 (WebKit::InspectorClient::createPage): use g_filename_to_uri to 11821 get the URI and use web_view_load_uri instead of the deprecated 11822 web_view_open method for loading the URI. 11823 (WebKit::InspectorClient::localizedStringsURL): implement. 11824 118252009-05-05 Ben Murdoch <benm@google.com> 11826 11827 Reviewed by Eric Seidel. 11828 11829 Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds. 11830 https://bugs.webkit.org/show_bug.cgi?id=24776 11831 11832 * WebCoreSupport/ChromeClientGtk.cpp: 11833 (WebKit::ChromeClient::exceededDatabaseQuota): 11834 * WebCoreSupport/ChromeClientGtk.h: 11835 118362009-05-06 Christian Dywan <christian@twotoasts.de> 11837 11838 Reviewed by Gustavo Noronha. 11839 11840 http://bugs.webkit.org/show_bug.cgi?id=17066 11841 [GTK] Improve frameloader signals 11842 11843 Implement load-status and progress properties on the view, as well as 11844 load-status on the frame. This supersedes the different load signals 11845 load-progress-changed, load-committed, load-done, load-started and 11846 load-finished which are not only misnamed but broken by design. 11847 11848 * WebCoreSupport/FrameLoaderClientGtk.cpp: 11849 (WebKit::notifyStatus): 11850 (WebKit::FrameLoaderClient::postProgressStartedNotification): 11851 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): 11852 (WebKit::FrameLoaderClient::dispatchDidFinishLoad): 11853 (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad): 11854 * webkit/webkitprivate.h: 11855 * webkit/webkitwebframe.cpp: 11856 * webkit/webkitwebframe.h: 11857 * webkit/webkitwebview.cpp: 11858 * webkit/webkitwebview.h: 11859 118602009-05-05 Xan Lopez <xlopez@igalia.com> 11861 11862 Reviewed by Holger Freyther. 11863 11864 Fix memory leaks. 11865 11866 * WebCoreSupport/EditorClientGtk.cpp: 11867 (WebKit::EditorClient::checkSpellingOfString): 11868 118692009-05-02 Gustavo Noronha Silva <gns@gnome.org> 11870 11871 Reviewed by Holger Freyther. 11872 11873 https://bugs.webkit.org/show_bug.cgi?id=25466 11874 WebKitGtk+ 1.1.6 prints weird error messages in Liferea 11875 11876 Use strlen instead of g_utf8_strlen when calculating the size of 11877 the data that is being given to webkit_web_frame_load_string to be 11878 loaded, so that we don't miss any of the content. 11879 11880 * webkit/webkitwebframe.cpp: 11881 118822009-05-01 Dimitri Glazkov <dglazkov@chromium.org> 11883 11884 Unreviewed, bulid fix. 11885 11886 Fix mis-applied patch. 11887 11888 * WebCoreSupport/FrameLoaderClientGtk.cpp: 11889 (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): 11890 118912009-05-01 Pavel Feldman <pfeldman@chromium.org> 11892 11893 Reviewed by Timothy Hatcher. 11894 11895 Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest. 11896 11897 https://bugs.webkit.org/show_bug.cgi?id=25347 11898 11899 * WebCoreSupport/FrameLoaderClientGtk.cpp: 11900 (WebKit::FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest): 11901 * WebCoreSupport/FrameLoaderClientGtk.h: 11902 119032009-04-30 David Kilzer <ddkilzer@apple.com> 11904 11905 Provide a mechanism to create a quirks delegate for HTMLParser 11906 11907 Reviewed by David Hyatt. 11908 11909 * WebCoreSupport/ChromeClientGtk.h: 11910 (WebKit::ChromeClient::createHTMLParserQuirks): Added. The 11911 default implementation of this factory method returns 0. 11912 119132009-04-30 Pavel Feldman <pfeldman@chromium.org> 11914 11915 Reviewed by Dimitri Glazkov. 11916 11917 https://bugs.webkit.org/show_bug.cgi?id=25342 11918 Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole. 11919 11920 * WebCoreSupport/ChromeClientGtk.cpp: 11921 (WebKit::ChromeClient::addMessageToConsole): 11922 * WebCoreSupport/ChromeClientGtk.h: 11923 119242009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11925 11926 Unreviewed. Update gtk-doc control and base sgml files for 1.1.6. 11927 11928 * docs/webkitgtk-docs.sgml: 11929 * docs/webkitgtk-sections.txt: 11930 119312009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 11932 11933 Reviewed by Xan Lopez. 11934 11935 Updated with news for the 1.1.6 release. 11936 11937 * NEWS: 11938 119392009-04-28 Xan Lopez <xlopez@igalia.com> 11940 11941 Reviewed by Gustavo Noronha. 11942 11943 Leave a bit of space from the previous page when advacing a whole 11944 page. This matches the behavior of our scrollbar scrolling code 11945 and is just nicer in general. 11946 11947 * webkit/webkitwebview.cpp: 11948 119492009-04-28 Xan Lopez <xlopez@igalia.com> 11950 11951 Unreviewed: committed a few bits by mistake, remove them. 11952 11953 * WebCoreSupport/EditorClientGtk.cpp: 11954 (WebKit::handleEditingKeyboardEvent): 11955 119562009-04-28 Xan Lopez <xlopez@igalia.com> 11957 11958 Reviewed by Gustavo Noronha. 11959 11960 https://bugs.webkit.org/show_bug.cgi?id=16135 11961 [GTK] Support caret browsing 11962 11963 Refactor keyboard event handling to work properly under caret 11964 browsing mode. Most of the code comes from the Windows port. 11965 11966 * WebCoreSupport/EditorClientGtk.cpp: 11967 (WebKit::): 11968 (WebKit::interpretKeyEvent): 11969 (WebKit::handleEditingKeyboardEvent): 11970 (WebKit::EditorClient::handleKeyboardEvent): 11971 119722009-04-28 Xan Lopez <xlopez@igalia.com> 11973 11974 Reviewed by Gustavo Noronha. 11975 11976 https://bugs.webkit.org/show_bug.cgi?id=16135 11977 [GTK] Support caret browsing 11978 11979 Based on a patch by Alp Toker. 11980 11981 Add enable-caret-browsing setting to WebKitWebView. 11982 11983 * webkit/webkitwebsettings.cpp: 11984 (_WebKitWebSettingsPrivate::): 11985 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 11986 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): 11987 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): 11988 (_WebKitWebSettingsPrivate::webkit_web_settings_copy): 11989 * webkit/webkitwebview.cpp: 11990 119912009-04-27 Gustavo Noronha Silva <gns@gnome.org> 11992 11993 Reviewed by Xan Lopez. 11994 11995 https://bugs.webkit.org/show_bug.cgi?id=25409 11996 [GTK] incorrectly fallsback on cancellation 11997 11998 Check whether we should fallback also on didFailLoad, so that we 11999 don't get error pages showing up in parts of the content of some 12000 sites because of, for instance, location changes. 12001 12002 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12003 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 12004 120052009-04-27 Gustavo Noronha Silva <gns@gnome.org> 12006 12007 Reviewed by Xan Lopez. 12008 12009 https://bugs.webkit.org/show_bug.cgi?id=25409 12010 [GTK] incorrectly fallsback on cancellation 12011 12012 Correctly handle cancellation and frame loading interruption 12013 caused by policy change. This also fixes 12014 fast/frames/location-change.html. 12015 12016 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12017 (WebKit::FrameLoaderClient::shouldFallBack): 12018 120192009-04-26 Xan Lopez <xlopez@igalia.com> 12020 12021 Reviewed by Mark Rowe. 12022 12023 Plug memory leak. 12024 12025 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12026 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 12027 120282009-04-26 Xan Lopez <xlopez@igalia.com> 12029 12030 Reviewed by Gustavo Noronha. 12031 12032 https://bugs.webkit.org/show_bug.cgi?id=25391 12033 G_SIGNAL_ACTION flag in WebKitWebView signals 12034 12035 Most of the signals in WebKitGTK+ have the G_SIGNAL_ACTION flag, 12036 but I don't think this makes sense. The flag is meant for those 12037 signals that can be emitted by the user to trigger some action in 12038 the view, as if it were a normal API, which is not the case for 12039 most of them. 12040 12041 * webkit/webkitdownload.cpp: 12042 (_WebKitDownloadPrivate::webkit_download_class_init): 12043 * webkit/webkitwebframe.cpp: 12044 * webkit/webkitwebinspector.cpp: 12045 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): 12046 * webkit/webkitwebview.cpp: 12047 120482009-04-26 Xan Lopez <xlopez@igalia.com> 12049 12050 Unreviewed, actually apply the right patch. 12051 12052 * webkit/webkitwebview.cpp: 12053 (webkit_web_view_move_cursor): 12054 120552009-04-26 Xan Lopez <xlopez@igalia.com> 12056 12057 Reviewed by Gustavo Noronha. 12058 12059 Pass a variable to hold the return value of the 'move-cursor' 12060 signal, otherwise a crash can happen. 12061 12062 * webkit/webkitwebview.cpp: 12063 (webkit_web_view_move_cursor): 12064 120652009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12066 12067 Reviewed by Xan Lopez. 12068 12069 https://bugs.webkit.org/show_bug.cgi?id=24786 12070 WebKitDownload sometimes suggests peculiar filenames 12071 12072 Refactor the emission of the download-requested signal so that we 12073 have less code duplication. 12074 12075 * WebCoreSupport/ContextMenuClientGtk.cpp: 12076 (WebKit::ContextMenuClient::downloadURL): 12077 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12078 (WebKit::FrameLoaderClient::startDownload): 12079 * webkit/webkitprivate.h: 12080 * webkit/webkitwebview.cpp: 12081 120822009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> 12083 12084 Reviewed by Xan Lopez. 12085 12086 [GTK] Error reporting 12087 https://bugs.webkit.org/show_bug.cgi?id=18344 12088 12089 Update FrameLoad errors to use WebKitErrors. 12090 12091 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12092 (WebKit::FrameLoaderClient::cancelledError): 12093 (WebKit::FrameLoaderClient::blockedError): 12094 (WebKit::FrameLoaderClient::cannotShowURLError): 12095 (WebKit::FrameLoaderClient::interruptForPolicyChangeError): 12096 (WebKit::FrameLoaderClient::cannotShowMIMETypeError): 12097 (WebKit::FrameLoaderClient::fileDoesNotExistError): 12098 (WebKit::FrameLoaderClient::pluginWillHandleLoadError): 12099 (WebKit::FrameLoaderClient::shouldFallBack): 12100 * webkit/webkiterror.h: Added. 12101 * webkit/webkiterror.cpp: Added. 12102 121032009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> 12104 12105 Reviewed by Xan Lopez. 12106 12107 [GTK] Error reporting 12108 https://bugs.webkit.org/show_bug.cgi?id=18344 12109 12110 Display a default error page for load errors. 12111 12112 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12113 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 12114 * resources/error.html: Added. 12115 121162009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> 12117 12118 Reviewed by Xan Lopez. 12119 12120 [GTK] Error reporting 12121 https://bugs.webkit.org/show_bug.cgi?id=18344 12122 12123 Add a WebKitWebFrame API to load alternate content for unreachable URLs. 12124 Also add a new signal "load-error" for handling load errors. 12125 12126 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12127 (WebKit::FrameLoaderClient::postProgressFinishedNotification): 12128 (WebKit::FrameLoaderClient::dispatchDidFailLoading): 12129 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): 12130 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 12131 * webkit/webkitwebframe.cpp: 12132 * webkit/webkitwebframe.h: 12133 * webkit/webkitwebview.cpp: 12134 121352009-04-24 Jan Michael Alonzo <jmalonzo@webkit.org> 12136 12137 Rubber-stamped by Gustavo Noronha. 12138 12139 Fix braces to comply with style guidelines. 12140 12141 * WebCoreSupport/PasteboardHelperGtk.cpp: 12142 (WebKit::PasteboardHelperGtk::getClipboard): 12143 (WebKit::PasteboardHelperGtk::getCopyTargetList): 12144 (WebKit::PasteboardHelperGtk::getPasteTargetList): 12145 121462009-04-24 Sergio GarcÃa-Cuevas <sergio_gcg@telefonica.net> 12147 12148 Reviewed by Gustavo Noronha. 12149 12150 https://bugs.webkit.org/show_bug.cgi?id=17267 12151 [GTK] Primary selection/clipboard support 12152 12153 Add a method for getting the primary selection. 12154 12155 * WebCoreSupport/PasteboardHelperGtk.cpp: 12156 (WebKit::PasteboardHelperGtk::getPrimary): 12157 * WebCoreSupport/PasteboardHelperGtk.h: 12158 121592009-04-24 Johan Bilien <jobi@via.ecp.fr> 12160 12161 Reviewed by Xan Lopez. 12162 12163 https://bugs.webkit.org/show_bug.cgi?id=25373 12164 Popup menu has the wrong size when popped up near the edge 12165 of the screen 12166 12167 * webkit/webkitwebview.cpp: 12168 (webkit_web_view_forward_context_menu_event): Let GTK place 12169 the popup menu instead of trying to do better and failing 12170 121712009-04-24 Christian Dywan <christian@twotoasts.de> 12172 12173 Rubber-stamped by Gustavo Noronha. 12174 12175 * webkit/webkitwebsettings.cpp: 12176 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the 12177 description of the enable-spell-checking property and correct the 12178 mentioning of the default language used. 12179 121802009-04-24 Diego Escalante Urrelo <diegoe@gnome.org> 12181 12182 Reviewed by Gustavo Noronha. 12183 12184 https://bugs.webkit.org/show_bug.cgi?id=15616 12185 [GTK] Add spell checking 12186 12187 Implement EditorClient::ignoreWordInSpellDocument, 12188 EditorClient::learnWord and EditorClient::getGuessesForWord. This 12189 enables the corresponding user actions. 12190 12191 * WebCoreSupport/EditorClientGtk.cpp: 12192 (WebKit::EditorClient::ignoreWordInSpellDocument): 12193 (WebKit::EditorClient::learnWord): 12194 (WebKit::EditorClient::getGuessesForWord): 12195 121962009-04-24 Diego Escalante Urrelo <diegoe@gnome.org> 12197 12198 Reviewed by Gustavo Noronha. 12199 12200 https://bugs.webkit.org/show_bug.cgi?id=15616 12201 [GTK] Add spell checking 12202 12203 Implement EditorClient::checkSpellingOfString; enabling spell checking 12204 to actually happen, this is the basis for other spelling functions. 12205 12206 * WebCoreSupport/EditorClientGtk.cpp: 12207 (WebKit::EditorClient::checkSpellingOfString): 12208 122092009-04-24 Diego Escalante Urrelo <diegoe@gnome.org> 12210 12211 Reviewed by Gustavo Noronha. 12212 12213 https://bugs.webkit.org/show_bug.cgi?id=15616 12214 [GTK] Add spell checking 12215 12216 Add spell-checking-languages property to WebKitWebSettings. 12217 12218 * webkit/webkitprivate.h: 12219 * webkit/webkitwebsettings.cpp: 12220 (_WebKitWebSettingsPrivate::): 12221 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 12222 (_WebKitWebSettingsPrivate::webkit_web_settings_init): 12223 (_WebKitWebSettingsPrivate::webkit_web_settings_finalize): 12224 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): 12225 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): 12226 (_WebKitWebSettingsPrivate::webkit_web_settings_copy): 12227 (_WebKitWebSettingsPrivate::webkit_web_settings_get_spell_languages): 12228 122292009-04-24 Diego Escalante Urrelo <diegoe@gnome.org> 12230 12231 Reviewed by Gustavo Noronha. 12232 12233 https://bugs.webkit.org/show_bug.cgi?id=15616 12234 [GTK] Add spell checking 12235 12236 Add enable-spell-checking property to WebKitWebSettings and implement 12237 EditorClient::isContinuousSpellCheckingEnabled and 12238 EditorClient::toggleContinuousSpellChecking to allow the UI to 12239 enable check as you type spell checking. 12240 12241 * WebCoreSupport/EditorClientGtk.cpp: 12242 (WebKit::EditorClient::isContinuousSpellCheckingEnabled): 12243 (WebKit::EditorClient::toggleContinuousSpellChecking): 12244 * webkit/webkitwebsettings.cpp: 12245 (_WebKitWebSettingsPrivate::): 12246 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 12247 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): 12248 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): 12249 (_WebKitWebSettingsPrivate::webkit_web_settings_copy): 12250 122512009-04-21 Xan Lopez <xlopez@igalia.com> 12252 12253 Reviewed by Gustavo Noronha. 12254 12255 https://bugs.webkit.org/show_bug.cgi?id=21546 12256 [GTK] ATK accessibility enhancements 12257 12258 Implement window<->screen coordinate transformation functions. 12259 12260 * WebCoreSupport/ChromeClientGtk.cpp: 12261 (WebKit::widgetScreenPosition): 12262 (WebKit::ChromeClient::windowToScreen): 12263 (WebKit::ChromeClient::screenToWindow): 12264 122652009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12266 12267 Reviewed by Xan Lopez. 12268 12269 https://bugs.webkit.org/show_bug.cgi?id=24786 12270 WebKitDownload sometimes suggests peculiar filenames 12271 12272 Remove query and ref from the URI that is to be downloaded when 12273 using it to provide a file name suggestion. 12274 12275 * webkit/webkitdownload.cpp: 12276 (_WebKitDownloadPrivate::webkit_download_set_property): 12277 122782009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12279 12280 Reviewed by Xan Lopez. 12281 12282 Handle the case when the plugin view is destroyed during 12283 didReceiveResponse, to avoid crashing. 12284 12285 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12286 (WebKit::FrameLoaderClient::committedLoad): 12287 122882009-04-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12289 12290 Reviewed by Alexey Proskuryakov. 12291 12292 https://bugs.webkit.org/show_bug.cgi?id=25251 12293 Crash when frame creation removes it from the parent 12294 12295 This brings us up-to-date with the expectations of sub-frame 12296 creation, following what Mac has done. It fixes crashes when 12297 calling init on the child frame removes it from the page. 12298 12299 This makes the following test pass instead of crash: 12300 12301 fast/loader/frame-creation-removal.html 12302 12303 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12304 (WebKit::FrameLoaderClient::createFrame): 12305 123062009-04-16 Christian Dywan <christian@twotoasts.de> 12307 12308 Reviewed by Holger Freyther. 12309 12310 http://bugs.webkit.org/show_bug.cgi?id=25042 12311 destroying webview widget directly causes crash. 12312 12313 * tests/testwebframe.c: 12314 (test_webkit_web_frame_create_destroy): Add a test case for destroying 12315 a web view shortly after packing it in a window. 12316 123172009-04-16 Xan Lopez <xlopez@igalia.com> 12318 12319 Reviewed by Sam Weinig. 12320 12321 https://bugs.webkit.org/show_bug.cgi?id=25241 12322 Remove superfluous NotImplemented.h includes. 12323 12324 * webkit/webkitprivate.cpp: 12325 123262009-04-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12327 12328 Unreviewed. Update gtk-doc control and base sgml files for 1.1.5. 12329 12330 * docs/webkitgtk-docs.sgml: 12331 * docs/webkitgtk-sections.txt: 12332 123332009-04-14 Xan Lopez <xlopez@igalia.com> 12334 12335 * NEWS: updated for 1.1.5 release. 12336 123372009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12338 12339 Reviewed by Holger Freyther. 12340 12341 https://bugs.webkit.org/show_bug.cgi?id=22898 12342 [GTK] need proper API for printing 12343 12344 Added simple printing unit tests. 12345 12346 * tests/testwebframe.c: 12347 (print_requested_cb): 12348 (print_timeout): 12349 (test_webkit_web_frame_printing): 12350 (main): 12351 123522009-04-13 Gustavo Noronha Silva <gns@gnome.org> 12353 12354 Reviewed by Holger Freyther. 12355 12356 https://bugs.webkit.org/show_bug.cgi?id=22898 12357 [GTK] need proper API for printing 12358 12359 Implement proper printing API, using the GTK+ printing API. 12360 12361 * WebCoreSupport/ChromeClientGtk.cpp: 12362 (WebKit::ChromeClient::print): 12363 * webkit/webkitprivate.h: 12364 * webkit/webkitwebframe.cpp: 12365 * webkit/webkitwebframe.h: 12366 * webkit/webkitwebview.cpp: 12367 123682009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12369 12370 Reviewed by Holger Freyther. 12371 12372 https://bugs.webkit.org/show_bug.cgi?id=25124 12373 [GTK] many strings still missing translation calls 12374 12375 Mark the missing strings for translation. 12376 12377 * webkit/webkitdownload.cpp: 12378 (_WebKitDownloadPrivate::webkit_download_cancel): 12379 * webkit/webkitsoupauthdialog.c: 12380 (show_auth_dialog): 12381 * webkit/webkitwebhistoryitem.cpp: 12382 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init): 12383 * webkit/webkitwebinspector.cpp: 12384 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): 12385 * webkit/webkitwebnavigationaction.cpp: 12386 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): 12387 * webkit/webkitwebsettings.cpp: 12388 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 12389 * webkit/webkitwebview.cpp: 12390 123912009-04-08 Alejandro Piñeiro <apinheiro@igalia.com> 12392 12393 Reviewed by Holger Freyther. 12394 12395 https://bugs.webkit.org/show_bug.cgi?id=21546 12396 [GTK] ATK accessibility enhancements 12397 12398 Use getOrCreate instead of just get, as we need to actually create 12399 the wrapper object the first time this function is called. 12400 12401 * webkit/webkitwebview.cpp: 12402 124032009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12404 12405 Rubber-stamped by Sam Weinig. 12406 12407 https://bugs.webkit.org/show_bug.cgi?id=20575 12408 No localization in WebKitGtk 12409 12410 Implemented localization support for WebKitGTK+. 12411 12412 * WebCoreSupport/ChromeClientGtk.cpp: 12413 * WebCoreSupport/ContextMenuClientGtk.cpp: 12414 * po/POTFILES: Added. 12415 * po/README: Added. 12416 * po/webkit.pot: Added. 12417 * webkit/webkitdownload.cpp: 12418 (_WebKitDownloadPrivate::webkit_download_class_init): 12419 * webkit/webkitprivate.cpp: 12420 (webkit_init): 12421 * webkit/webkitwebframe.cpp: 12422 124232009-04-05 Xan Lopez <xlopez@igalia.com> 12424 12425 Reviewed by Holger Freyther. 12426 12427 https://bugs.webkit.org/show_bug.cgi?id=25042 12428 destroying webview widget directly causes crash. 12429 12430 Do not connect the WebView to its own screen-changed signal, set a 12431 default handler instead. 12432 12433 * webkit/webkitwebview.cpp: 12434 124352009-04-05 Xan Lopez <xlopez@igalia.com> 12436 12437 Reviewed by Holger Freyther. 12438 12439 https://bugs.webkit.org/show_bug.cgi?id=25042 12440 destroying webview widget directly causes crash. 12441 12442 GtkWidget::screen-changed can be emitted when a widget is being 12443 destroyed, protect against it. 12444 12445 * webkit/webkitwebview.cpp: 12446 124472009-04-05 Jan Michael Alonzo <jmalonzo@webkit.org> 12448 12449 Reviewed by Holger Freyther. 12450 12451 [Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled 12452 https://bugs.webkit.org/show_bug.cgi?id=24487 12453 12454 Updated documentation and put more information about the 12455 private-browsing setting for WebKitGtk. 12456 12457 * webkit/webkitwebsettings.cpp: 12458 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 12459 124602009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12461 12462 Reviewed by Holger Freyther. 12463 12464 Remove pre-processor checks for GTK+ >= 2.10, since we now require 12465 at least that version. 12466 12467 * WebCoreSupport/EditorClientGtk.cpp: 12468 (WebKit::clipboard_clear_contents_cb): 12469 (WebKit::EditorClient::respondToChangedSelection): 12470 * webkit/webkitwebframe.cpp: 12471 * webkit/webkitwebview.cpp: 12472 124732009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12474 12475 Reviewed by Alexey Proskuryakov. 12476 12477 https://bugs.webkit.org/show_bug.cgi?id=24844 12478 Unit test WebKitDownload 12479 12480 Extra checks to avoid crashing and a critical message when 12481 property accessor functions are called before the download is 12482 started. 12483 12484 * webkit/webkitdownload.cpp: 12485 (_WebKitDownloadPrivate::webkit_download_get_progress): 12486 (_WebKitDownloadPrivate::webkit_download_get_elapsed_time): 12487 124882009-04-01 Christian Dywan <christian@twotoasts.de> 12489 12490 Reviewed by Holger Freyther. 12491 12492 * tests/testdownload.c: Added. 12493 (test_webkit_download_create): 12494 (main): Add an initial unit test for downloading. 12495 124962009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12497 12498 Unreviewed typo fixes, and naming normalization in the 12499 documentation. 12500 12501 * docs/webkitenvironment.xml: 12502 * webkit/webkitwebview.cpp: 12503 125042009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12505 12506 Reviewed by Holger Freyther. 12507 12508 Updated gtk-doc configuration files for the 1.1.1, 1.1.2, 1.1.3, 12509 and 1.1.4 versions of WebKitGTK+. 12510 12511 * docs/webkitgtk-docs.sgml: 12512 * docs/webkitgtk-sections.txt: 12513 125142009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12515 12516 Reviewed by Holger Freyther. 12517 12518 https://bugs.webkit.org/show_bug.cgi?id=17045 12519 [GTK] Documentation 12520 12521 Added header documentation for WebKitWebNavigationAction and 12522 WebKitWebPolicyDecision. 12523 12524 Added missing documentation pieces for WebKitSoupAuthDialog, 12525 WebKitDownload and WebKitWebPolicyDecision. 12526 12527 Wrote a section about using the WEBKIT_DEBUG environment variable. 12528 12529 * docs/GNUmakefile.am: 12530 * docs/webkitenvironment.xml: Added. 12531 * docs/webkitgtk-docs.sgml: 12532 * webkit/webkitdownload.cpp: 12533 * webkit/webkitsoupauthdialog.c: 12534 * webkit/webkitwebnavigationaction.cpp: 12535 * webkit/webkitwebpolicydecision.cpp: 12536 125372009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12538 12539 Reviewed by Holger Freyther. 12540 12541 Integrate gtk-doc into the Gtk+ buildsystem. 12542 12543 Based on original work by Holger Freyther. 12544 12545 Integrate gtk-doc into our buildsystem. We are forced to 12546 use recursive make for gtk-doc itself as the to be installed 12547 gtk-doc.make (done by gtkdocize) is not working in a non 12548 recursive environment. 12549 12550 The documentation can only be generated when srcdir == builddir. 12551 In all other cases the generated files will not be found. This 12552 limitation can be found in pango and gtk+ as well. There is no 12553 easy way around. The resulting html documentation will be saved 12554 in the srcdir as well. 12555 12556 * docs/GNUmakefile.am: Added. 12557 * docs/version.xml.in: Added. 12558 * docs/webkitgtk-docs.sgml: 12559 125602009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12561 12562 Unreviewed. Documenting what changed since the 1.1.3 release, in 12563 the GTK+ port. 12564 12565 * NEWS: 12566 125672009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> 12568 12569 Unreviewed. Add information on the bug-fix-only 1.1.3 release. 12570 12571 * NEWS: 12572 125732009-03-30 Xan Lopez <xlopez@igalia.com> 12574 12575 Reviewed by Holger Freyther. 12576 12577 https://bugs.webkit.org/show_bug.cgi?id=24878 12578 [GTK] Use GtkBinding system to handle key events in WebView 12579 12580 Use GtkBinding system for key events in WebKitWebView. Allows the 12581 user to reconfigure the bindings and fixes a bunch of bugs along 12582 the way (we were not checking modifier keys in most actions). 12583 12584 * webkit/webkitwebview.cpp: 12585 (webkit_web_view_move_cursor): 12586 * webkit/webkitwebview.h: 12587 * webkitmarshal.list: 12588 125892009-03-28 Xan Lopez <xlopez@igalia.com> 12590 12591 Reviewed by Mark Rowe. 12592 12593 https://bugs.webkit.org/show_bug.cgi?id=24790 12594 [GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function 12595 12596 Set the right visibility to the WebKitSoupAuthDialog get_type 12597 function. 12598 12599 * webkit/webkitsoupauthdialog.h: 12600 126012009-03-28 Jan Michael Alonzo <jmalonzo@webkit.org> 12602 12603 Gtk build fix. Not reviewed. 12604 12605 FrameLoader::loadURL and FrameLoader::detachChildren went private 12606 per changes in http://trac.webkit.org/changeset/42055. Follow 12607 Mac's behaviour and use FrameLoader::loadURLIntoChildFrame for 12608 loadURL and FrameLoader::detachParent for detachChildrem. 12609 12610 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12611 (WebKit::FrameLoaderClient::createFrame): 12612 * webkit/webkitwebview.cpp: 12613 126142009-03-25 Gustavo Noronha Silva <gns@gnome.org> 12615 12616 Reviewed by Holger Freyther. 12617 12618 https://bugs.webkit.org/show_bug.cgi?id=15793 12619 [GTK] tooltip position doesn't update when hovering consecutive links 12620 12621 Work-around tooltips not updating their location when the elements 12622 are consecutive, by clearing the tooltip when handling 12623 mouseDidMoveOverElement. 12624 12625 * WebCoreSupport/ChromeClientGtk.cpp: 12626 (WebKit::ChromeClient::mouseDidMoveOverElement): 12627 126282009-03-23 Alejandro Garcia Castro <alex@igalia.com> 12629 12630 Reviewed by Holger Freyther. 12631 12632 [Gtk] Current API does not allow us to open target="_blank" links 12633 in new tabs instead of windows 12634 https://bugs.webkit.org/show_bug.cgi?id=23932 12635 12636 Added a signal to the API (new-window-policy-decision-requested) 12637 that allows the browser to decide the policy for the new window 12638 request, if the signal is not handled we open the new window as 12639 usual. 12640 12641 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12642 (WebKit::getNavigationAction): 12643 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): 12644 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 12645 * webkit/webkitwebview.cpp: 12646 126472009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com> 12648 12649 Not reviewed. Fix style issues with my previous commit (r41866) as 12650 suggested by Holger in https://bugs.webkit.org/show_bug.cgi?id=24493 12651 12652 * tests/testwebhistoryitem.c: 12653 (test_webkit_web_history_item_get_data): 12654 (test_webkit_web_history_item_alternate_title): 12655 126562009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com> 12657 12658 Reviewed by Holger Freyther. 12659 12660 [GTK] Misc patches for WebKitWebHistoryItem 12661 https://bugs.webkit.org/show_bug.cgi?id=24493 12662 12663 Add unit test for WebKitWebHistoryItem 12664 12665 * tests/testwebhistoryitem.c: Added. 12666 (web_history_item_fixture_setup): 12667 (web_history_item_fixture_teardown): 12668 (test_webkit_web_history_item_get_data): 12669 (test_webkit_web_history_item_alternate_title): 12670 (main): 12671 126722009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com> 12673 12674 Reviewed by Holger Freyther. 12675 12676 Separate gtk unit tests 12677 https://bugs.webkit.org/show_bug.cgi?id=24039 12678 12679 Split the current single-file unit test to make it more 12680 modularized and manageable in the future as more unit tests are 12681 written. 12682 12683 * tests/main.c: Removed. 12684 * tests/testwebbackforwardlist.c: Copied from WebKit/gtk/tests/main.c. 12685 (main): 12686 * tests/testwebframe.c: Copied from WebKit/gtk/tests/main.c. 12687 (main): 12688 126892009-03-16 Christian Dywan <christian@twotoasts.de> 12690 12691 Reviewed by Adam Roben. 12692 12693 [gtk] API implementation: url and title 12694 http://bugs.webkit.org/show_bug.cgi?id=14807 12695 12696 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12697 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): 12698 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): 12699 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): 12700 * webkit/webkitwebview.cpp: 12701 * webkit/webkitwebview.h: Implement "title" and "uri" properties as well 12702 as according functions. "uri" always reflects the current location 12703 including navigation inside the same page. title-changed is deprecated. 12704 127052009-03-15 Gustavo Noronha Silva <gns@gnome.org> 12706 12707 Reviewed by Anders Carlsson. 12708 12709 Fix default policy decision to be ignore, on MIME checks, if 12710 WebKit doesn't know how to handle the MIME type. The documentation 12711 is already correct, and this was an oversight when the policy 12712 decision code was first committed. Since 1.1.2 will be the first 12713 release to support download, there is no practical change in 12714 behavior. 12715 12716 * WebCoreSupport/FrameLoaderClientGtk.cpp: 12717 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): 12718 127192009-03-15 Xan Lopez <xlopez@igalia.com> 12720 12721 * NEWS: update for 1.1.2. 12722 127232009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org> 12724 12725 Reviewed by Holger Freyther. 12726 12727 [GTK] use of confirm dialog (yes/no) causes segfault 12728 https://bugs.webkit.org/show_bug.cgi?id=20940 12729 12730 Change the script-confirm marshaller from OBJECT,STRING,BOOLEAN to 12731 OBJECT,STRING,POINTER 12732 12733 * webkit/webkitwebview.cpp: 12734 * webkitmarshal.list: 12735 127362009-03-12 Gustavo Noronha Silva <gns@gnome.org> 12737 12738 Reviewed by Alexey Proskuryakov. 12739 12740 https://bugs.webkit.org/show_bug.cgi?id=24553 12741 [GTK] Improvements to WebKitDownload 12742 12743 Rename 'state' to 'status' to match the naming in the frame 12744 loader rework that we plan to land soonish, and make it a 12745 property, for the same reason. 12746 12747 * webkit/webkitdownload.cpp: 12748 (_WebKitDownloadPrivate::): 12749 (_WebKitDownloadPrivate::webkit_download_finalize): 12750 (_WebKitDownloadPrivate::webkit_download_get_property): 12751 (_WebKitDownloadPrivate::webkit_download_set_property): 12752 (_WebKitDownloadPrivate::webkit_download_class_init): 12753 (_WebKitDownloadPrivate::webkit_download_init): 12754 (_WebKitDownloadPrivate::webkit_download_start): 12755 (_WebKitDownloadPrivate::webkit_download_cancel): 12756 (_WebKitDownloadPrivate::webkit_download_set_destination_uri): 12757 (_WebKitDownloadPrivate::webkit_download_get_status): 12758 (_WebKitDownloadPrivate::webkit_download_set_status): 12759 (_WebKitDownloadPrivate::webkit_download_received_data): 12760 (_WebKitDownloadPrivate::webkit_download_finished_loading): 12761 (_WebKitDownloadPrivate::webkit_download_error): 12762 * webkit/webkitdownload.h: 12763 127642009-03-12 Gustavo Noronha Silva <gns@gnome.org> 12765 12766 Reviewed by Alexey Proskuryakov. 12767 12768 https://bugs.webkit.org/show_bug.cgi?id=24553 12769 [GTK] Improvements to WebKitDownload 12770 12771 Improved documentation for the download-requested signal, to make 12772 its usage clear. 12773 12774 * webkit/webkitwebview.cpp: 12775 127762009-03-12 Gustavo Noronha Silva <gns@gnome.org> 12777 12778 Reviewed by Alp Toker. 12779 12780 https://bugs.webkit.org/show_bug.cgi?id=24541 12781 Scrolling with home and end keys not always works 12782 12783 Also make page up and page down keys be handled by the webview key 12784 event code, so that they also work in cases where the GTK+ 12785 scrollbars don't handle them directly, like in the bugzill's patch 12786 review page. 12787 12788 * webkit/webkitwebview.cpp: 12789 127902009-03-12 Gustavo Noronha Silva <gns@gnome.org> 12791 12792 Reviewed by Alp Toker. 12793 12794 https://bugs.webkit.org/show_bug.cgi?id=24541 12795 Scrolling with home and end keys not always works 12796 12797 Make home and end keys behave more consistently for scrolling the 12798 view. 12799 12800 * webkit/webkitwebview.cpp: 12801 128022009-03-12 Gustavo Noronha Silva <gns@gnome.org> 12803 12804 Reviewed by Alp Toker. 12805 12806 https://bugs.webkit.org/show_bug.cgi?id=24254 12807 [GTK] spacebar doesn't scroll down 12808 12809 Make spacebar and shift+spacebar scroll like page up and down 12810 respectively would. 12811 12812 * webkit/webkitwebview.cpp: 12813 128142009-03-10 Xan Lopez <xlopez@igalia.com> 12815 12816 Reviewed by Holger Freyther. 12817 12818 https://bugs.webkit.org/show_bug.cgi?id=24493 12819 [GTK] Misc patches for WebKitWebHistoryItem 12820 12821 Only run code in dispose once per instance. 12822 12823 * webkit/webkitwebhistoryitem.cpp: 12824 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): 12825 128262009-03-10 Xan Lopez <xlopez@igalia.com> 12827 12828 Reviewed by Holger Freyther. 12829 12830 https://bugs.webkit.org/show_bug.cgi?id=24493 12831 [GTK] Misc patches for WebKitWebHistoryItem 12832 12833 Call deref() on our internal HistoryItem on dispose, as we always 12834 acquire it with a releaseRef() call to a PassRefPtr, which passes 12835 ownership. 12836 12837 * webkit/webkitwebhistoryitem.cpp: 12838 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): 12839 128402009-03-10 Xan Lopez <xlopez@igalia.com> 12841 12842 Reviewed by Holger Freyther. 12843 12844 https://bugs.webkit.org/show_bug.cgi?id=24493 12845 [GTK] Misc patches for WebKitWebHistoryItem 12846 12847 return foo? foo : NULL == return foo 12848 12849 * webkit/webkitwebhistoryitem.cpp: 12850 (WebKit::core): 12851 128522009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org> 12853 12854 Reviewed by Holger Freyther. 12855 12856 Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled 12857 https://bugs.webkit.org/show_bug.cgi?id=24487 12858 12859 Add private browsing option "enable-private-browsing" to WebKitWebSettings. 12860 12861 * webkit/webkitwebsettings.cpp: 12862 (_WebKitWebSettingsPrivate::): 12863 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 12864 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): 12865 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): 12866 (_WebKitWebSettingsPrivate::webkit_web_settings_copy): 12867 * webkit/webkitwebview.cpp: 12868 128692009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org> 12870 12871 Reviewed by Holger Freyther. 12872 12873 [GTK] BackForward history leak? 12874 https://bugs.webkit.org/show_bug.cgi?id=19528 12875 12876 Don't ref the history items when returning the back/forward list 12877 Added test_webkit_web_history_item_lifetime test case for this. 12878 12879 * tests/main.c: 12880 (test_webkit_web_history_item_lifetime): 12881 (test_webkit_web_back_forward_list_order): Style fix. 12882 (test_webkit_web_back_forward_list_add_item): Style fix. 12883 (main): 12884 * webkit/webkitwebbackforwardlist.cpp: 12885 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): 12886 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit): 12887 128882009-03-10 Xan Lopez <xlopez@igalia.com> 12889 12890 Reviewed by Alexey Proskuryakov. 12891 12892 https://bugs.webkit.org/show_bug.cgi?id=24493 12893 [GTK] Misc patches for WebKitWebHistoryItem 12894 12895 Use g_hash_table_new_full so we can save the manual unref on the 12896 values when removing them from the table. 12897 12898 * webkit/webkitwebhistoryitem.cpp: 12899 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): 12900 129012009-03-10 Xan Lopez <xan@gnome.org> 12902 12903 Reviewed by Alexey Proskuryakov. 12904 12905 https://bugs.webkit.org/show_bug.cgi?id=24493 12906 [GTK] Misc patches for WebKitWebHistoryItem 12907 12908 Use 'if (foo)' instead of 'if (foo != NULL)', per coding style 12909 guidelines. 12910 12911 * webkit/webkitwebhistoryitem.cpp: 12912 (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): 12913 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title): 12914 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title): 12915 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri): 12916 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri): 12917 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time): 12918 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): 12919 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): 12920 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children): 12921 129222009-03-10 Xan Lopez <xlopez@igalia.com> 12923 12924 Reviewed by Alexey Proskuryakov. 12925 12926 Correct return value to false instead of NULL. 12927 12928 * webkit/webkitwebhistoryitem.cpp: 12929 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): 12930 129312009-03-08 Holger Hans Peter Freyther <zecke@selfish.org> 12932 12933 Reviewed by Mark Rowe. 12934 12935 Add javascript-profiling-enabled property and implement it. This 12936 will enable/disable the profiler on the InstpectorController. 12937 12938 * webkit/webkitprivate.h: 12939 * webkit/webkitwebinspector.cpp: 12940 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): 12941 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property): 12942 (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property): 12943 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_inspector_client): 12944 * webkit/webkitwebview.cpp: 12945 129462009-03-05 Gustavo Noronha Silva <gns@gnome.org> 12947 12948 Reviewed by Olliej. 12949 12950 https://bugs.webkit.org/show_bug.cgi?id=24295 12951 webkit_web_back_forward_list_add_item needs a Since tag 12952 12953 Add missing Since tag to webkit_web_back_forward_list_add_item 12954 documentation. 12955 12956 * webkit/webkitwebbackforwardlist.cpp: 12957 129582009-03-05 Gustavo Noronha Silva <gns@gnome.org> 12959 12960 Reviewed by Mark Rowe. 12961 12962 https://bugs.webkit.org/show_bug.cgi?id=24417 12963 [GTK] WebKitDownload's _cancel and _dispose methods may emit warnings 12964 12965 NULL-check for timer on _cancel and _dispose, to avoid bad 12966 warnings. 12967 12968 * webkit/webkitdownload.cpp: 12969 (_WebKitDownloadPrivate::webkit_download_finalize): 12970 (_WebKitDownloadPrivate::webkit_download_cancel): 12971 129722009-03-02 Xan Lopez <xan@gnome.org> 12973 12974 Reviewed by Mark Rowe. 12975 12976 https://bugs.webkit.org/show_bug.cgi?id=24287 12977 [GTK] Move auth dialog feature to WebKit/ 12978 12979 Add WebKitSoupAuthDialog and add it to the session in webkit_init. 12980 12981 * webkit/webkitprivate.cpp: 12982 (currentToplevelCallback): 12983 (webkit_init): 12984 * webkit/webkitsoupauthdialog.c: Added. 12985 (webkit_soup_auth_dialog_class_init): 12986 (webkit_soup_auth_dialog_init): 12987 (webkit_soup_auth_dialog_session_feature_init): 12988 (free_authData): 12989 (set_password_callback): 12990 (response_callback): 12991 (table_add_entry): 12992 (show_auth_dialog): 12993 (find_password_callback): 12994 (session_authenticate): 12995 (attach): 12996 * webkit/webkitsoupauthdialog.h: Added. 12997 129982009-03-03 Gustavo Noronha Silva <gns@gnome.org> 12999 13000 Reviewed by Alexey Proskuryakov. 13001 13002 https://bugs.webkit.org/show_bug.cgi?id=16826 13003 [Gtk] Implement WebKitDownload 13004 13005 Implement download, and provide a nice object wrapping the 13006 download process. Initial work done by Marco Barisione and 13007 Pierre-Luc Beaudoin for Collabora. 13008 13009 * WebCoreSupport/ContextMenuClientGtk.cpp: 13010 (WebKit::ContextMenuClient::downloadURL): 13011 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13012 (WebKit::FrameLoaderClient::download): 13013 (WebKit::FrameLoaderClient::startDownload): 13014 * webkit/webkit.h: 13015 * webkit/webkitdefines.h: 13016 * webkit/webkitdownload.cpp: Added. 13017 (_WebKitDownloadPrivate::): 13018 (_WebKitDownloadPrivate::webkit_download_dispose): 13019 (_WebKitDownloadPrivate::webkit_download_finalize): 13020 (_WebKitDownloadPrivate::webkit_download_get_property): 13021 (_WebKitDownloadPrivate::webkit_download_set_property): 13022 (_WebKitDownloadPrivate::webkit_download_class_init): 13023 (_WebKitDownloadPrivate::webkit_download_init): 13024 (_WebKitDownloadPrivate::webkit_download_new): 13025 (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri): 13026 (_WebKitDownloadPrivate::webkit_download_close_stream): 13027 (_WebKitDownloadPrivate::webkit_download_start): 13028 (_WebKitDownloadPrivate::webkit_download_cancel): 13029 (_WebKitDownloadPrivate::webkit_download_get_uri): 13030 (_WebKitDownloadPrivate::webkit_download_get_network_request): 13031 (_WebKitDownloadPrivate::webkit_download_set_response): 13032 (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): 13033 (_WebKitDownloadPrivate::webkit_download_get_destination_uri): 13034 (_WebKitDownloadPrivate::webkit_download_set_destination_uri): 13035 (_WebKitDownloadPrivate::webkit_download_get_state): 13036 (_WebKitDownloadPrivate::webkit_download_get_total_size): 13037 (_WebKitDownloadPrivate::webkit_download_get_current_size): 13038 (_WebKitDownloadPrivate::webkit_download_get_progress): 13039 (_WebKitDownloadPrivate::webkit_download_get_elapsed_time): 13040 (_WebKitDownloadPrivate::webkit_download_received_data): 13041 (_WebKitDownloadPrivate::webkit_download_finished_loading): 13042 (_WebKitDownloadPrivate::webkit_download_error): 13043 (_WebKitDownloadPrivate::DownloadClient::DownloadClient): 13044 (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse): 13045 (_WebKitDownloadPrivate::DownloadClient::didReceiveData): 13046 (_WebKitDownloadPrivate::DownloadClient::didFinishLoading): 13047 (_WebKitDownloadPrivate::DownloadClient::didFail): 13048 (_WebKitDownloadPrivate::DownloadClient::wasBlocked): 13049 (_WebKitDownloadPrivate::DownloadClient::cannotShowURL): 13050 * webkit/webkitdownload.h: Added. 13051 * webkit/webkitprivate.h: 13052 * webkit/webkitwebview.cpp: 13053 * webkitmarshal.list: 13054 130552009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org> 13056 13057 Reviewed by Holger Freyther. 13058 13059 [Gtk] get the HTTP layout tests going 13060 https://bugs.webkit.org/show_bug.cgi?id=24259 13061 13062 Added API to get the response mime type from a frame. We need this 13063 so we can decide if we need to dump the frame as text or its 13064 render tree 13065 13066 * webkit/webkitprivate.h: 13067 * webkit/webkitwebframe.cpp: 13068 130692009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org> 13070 13071 Reviewed by Holger Freyther. 13072 13073 [Gtk] get the HTTP layout tests going 13074 https://bugs.webkit.org/show_bug.cgi?id=24259 13075 13076 Create a WebKitWebHistoryItem for each WebCore::HistoryItem when 13077 necessary. 13078 Add necessary API additions for us to be able to dump a WebKitWebHistoryItem 13079 13080 * webkit/webkitprivate.h: 13081 * webkit/webkitwebbackforwardlist.cpp: 13082 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): 13083 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit): 13084 * webkit/webkitwebhistoryitem.cpp: 13085 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): 13086 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): 13087 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): 13088 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): 13089 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): 13090 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children): 13091 (WebKit::core): 13092 (WebKit::kit): 13093 130942009-03-01 Christian Dywan <christian@twotoasts.de> 13095 13096 Reviewed by Holger Freyther. 13097 13098 * webkit/webkitprivate.h: 13099 * webkit/webkitwebview.cpp: 13100 (webkit_web_view_get_encoding): 13101 * webkit/webkitwebview.h: Implement 'encoding' and 'custom-encoding' 13102 properties as well as webkit_web_view_get_encoding. 13103 131042009-03-01 Gustavo Noronha Silva <gns@gnome.org> 13105 13106 Unreviewed simple wording fix for the NEWS file. 13107 13108 * NEWS: 13109 131102009-03-01 Xan Lopez <xan@gnome.org> 13111 13112 Add NEWS file to track progress between releases. 13113 13114 * NEWS: Added. 13115 131162009-02-28 Christian Dywan <christian@twotoasts.de> 13117 13118 Reviewed by Holger Freyther. 13119 13120 * webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a 13121 locale path is passed for compatibility, since we used to support that. 13122 131232009-02-27 Gustavo Noronha Silva <gns@gnome.org> 13124 13125 Reviewed by David Hyatt. 13126 13127 Automatically ignore empty requests to avoid crashing. This fixes 13128 the crash in fast/loader/empty-embed-src-attribute.html. 13129 13130 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13131 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): 13132 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): 13133 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 13134 131352009-02-27 Xan Lopez <xan@gnome.org> 13136 13137 Reviewed by Alexey Proskuryakov. 13138 13139 https://bugs.webkit.org/show_bug.cgi?id=24221 13140 [GTK] Do not emit load-finished when being disposed 13141 13142 webkit_web_view_stop_load() is called from dispose() on 13143 WebKitWebView. This eventually calls postProgressFinishedNotification 13144 in FrameLoaderClientGtk, which emits load-finished. Add 13145 a 'disposing' flag to WebView that we can check here, so 13146 we avoid emitting signals on objects on their way to be 13147 destroyed. This fixes a bunch of critical warnings when 13148 closing a loading WebView. 13149 13150 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13151 (WebKit::FrameLoaderClient::postProgressFinishedNotification): 13152 * webkit/webkitprivate.h: 13153 * webkit/webkitwebview.cpp: 13154 131552009-02-27 Xan Lopez <xan@gnome.org> 13156 13157 Rubber-stamped by Alexey Proskuryakov. 13158 13159 https://bugs.webkit.org/show_bug.cgi?id=24222 13160 [GTK] Remove checks for old glib versions 13161 13162 libsoup, which is a hard dependency, needs at least glib 2.15.3, 13163 so remove all glib checks for versions older than that. 13164 13165 * webkit/webkitwebview.cpp: 13166 131672009-02-26 Xan Lopez <xan@gnome.org> 13168 13169 Reviewed by Holger Freyther. 13170 13171 https://bugs.webkit.org/show_bug.cgi?id=16947 13172 [GTK] Missing HTTP Auth challenge 13173 13174 Add new marshalers list. 13175 13176 * webkitmarshal.list: Added. 13177 131782009-02-26 Xan Lopez <xan@gnome.org> 13179 13180 Reviewed by Alexey Proskuryakov. 13181 13182 https://bugs.webkit.org/show_bug.cgi?id=24193 13183 [GTK] Checkbuttons not activated with space 13184 13185 Do not swallow key events with GtkIMContext for non-editable 13186 content. 13187 13188 * WebCoreSupport/EditorClientGtk.cpp: 13189 (WebKit::EditorClient::handleInputMethodKeydown): 13190 131912009-02-26 Xan Lopez <xan@gnome.org> 13192 13193 Reviewed by Alexey Proskuryakov. 13194 13195 https://bugs.webkit.org/show_bug.cgi?id=24103 13196 [GTK] Use correct return value for WebView button-release handler 13197 13198 We are returning whatever the core code tells us it did, but this 13199 does not play well with the GTK+ model. GTK+ in general expects it 13200 will see a button-release if it saw a button-press and no 13201 motion/leave/etc events in between. EventHandler.cpp will, in some 13202 cases, not handle press but handle release, confusing the parent 13203 container of the WebView. 13204 13205 As a workaround return always FALSE for button-release (this is 13206 the same than the Windows port does). 13207 13208 * webkit/webkitwebview.cpp: 13209 132102009-02-26 Xan Lopez <xan@gnome.org> 13211 13212 Reviewed by Holger Freyther. 13213 13214 https://bugs.webkit.org/show_bug.cgi?id=17585 13215 [gtk] get|set encoding api 13216 13217 Add functions to get and set a custom encoding an a view. 13218 13219 * webkit/webkitprivate.h: 13220 * webkit/webkitwebview.cpp: 13221 (webkit_web_view_set_custom_encoding): 13222 (webkit_web_view_get_custom_encoding): 13223 * webkit/webkitwebview.h: 13224 132252009-02-23 Xan Lopez <xan@gnome.org> 13226 13227 Reviewed by Alexey Proskuryakov. 13228 13229 https://bugs.webkit.org/show_bug.cgi?id=22624 13230 [SOUP][GTK] Need API to get SoupSession from WebKit. 13231 13232 Add API to get the default soup session. 13233 13234 * webkit/webkitwebview.cpp: 13235 * webkit/webkitwebview.h: 13236 132372009-02-23 Xan Lopez <xan@gnome.org> 13238 13239 Reviewed by Alexey Proskuryakov. 13240 13241 https://bugs.webkit.org/show_bug.cgi?id=22624 13242 [SOUP][GTK] Need API to get SoupSession from WebKit. 13243 13244 Add soup dependency to pc file. 13245 13246 * webkit.pc.in: 13247 132482009-02-23 Jan Michael Alonzo <jmalonzo@webkit.org> 13249 13250 Reviewed by Mark Rowe. 13251 13252 [GTK] Back / Forward history menus are flipped 13253 https://bugs.webkit.org/show_bug.cgi?id=22694 13254 13255 Don't call g_list_reverse when returning the back or forward list. 13256 13257 * tests/main.c: 13258 (test_webkit_web_back_forward_list_order): 13259 (main): 13260 * webkit/webkitwebbackforwardlist.cpp: 13261 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): 13262 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit): 13263 132642009-02-17 Xan Lopez <xan@gnome.org> 13265 13266 Rubber-stamped by Alexey Proskuryakov. 13267 13268 Restoring change landed in r40715, which was accidentally undone 13269 by r40918. 13270 13271 * webkit/webkitwebframe.cpp: 13272 132732009-02-12 Christian Dywan <christian@twotoasts.de> 13274 13275 Reviewed by Holger Freyther. 13276 13277 http://bugs.webkit.org/show_bug.cgi?id=17176 13278 [GTK] API: hovering-over-link and webkit_web_view_open /_load_foo 13279 13280 * webkit/webkitwebframe.cpp: 13281 * webkit/webkitwebframe.h: 13282 * webkit/webkitwebview.cpp: 13283 * webkit/webkitwebview.h: Introduce webkit_web_frame_load_uri, 13284 webkit_web_frame_load_string, webkit_web_view_load_uri and 13285 webkit_web_view_load_request and unify implementations. 13286 132872009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com> 13288 13289 Stub out InspectorClient::hiddenPanels. 13290 13291 Reviewed by Timothy Hatcher. 13292 13293 * WebCoreSupport/InspectorClientGtk.cpp: 13294 (WebKit::InspectorClient::hiddenPanels): 13295 * WebCoreSupport/InspectorClientGtk.h: 13296 132972009-02-07 Holger Hans Peter Freyther <zecke@selfish.org> 13298 13299 Unreviewed build fix Use toNormalizedRange(). 13300 13301 * WebCoreSupport/EditorClientGtk.cpp: 13302 (WebKit::clipboard_get_contents_cb): 13303 133042009-02-06 Geoffrey Garen <ggaren@apple.com> 13305 13306 Build fix. 13307 13308 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13309 (WebKit::FrameLoaderClient::updateGlobalHistoryRedirectLinks): 13310 * WebCoreSupport/FrameLoaderClientGtk.h: 13311 133122009-02-06 Xan Lopez <xan@gnome.org> 13313 13314 Reviewed by Holger Freyther. 13315 13316 Reported by Daniel Macks. 13317 13318 https://bugs.webkit.org/show_bug.cgi?id=20412 13319 13320 Use positive numbers for the target info IDs, gtk_target_list_add 13321 casts them to 'guint'. Also just start them from 0, since the 13322 values are not relevant or magic in any way, they are just used as 13323 tokens for the user of the API. 13324 13325 * webkit/webkitwebview.h: 13326 133272009-02-06 Xan Lopez <xan@gnome.org> 13328 13329 Reviewed by Alexey Proskuryakov. 13330 13331 https://bugs.webkit.org/show_bug.cgi?id=23769 13332 13333 Do not use empty ResourceError errors. 13334 13335 Rather create bogus but non-null errors, since some codepaths 13336 expect these. For example, see DocumentLoader::mainReceivedError. 13337 13338 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13339 (WebKit::FrameLoaderClient::cancelledError): 13340 (WebKit::FrameLoaderClient::blockedError): 13341 (WebKit::FrameLoaderClient::cannotShowURLError): 13342 (WebKit::FrameLoaderClient::interruptForPolicyChangeError): 13343 (WebKit::FrameLoaderClient::cannotShowMIMETypeError): 13344 (WebKit::FrameLoaderClient::fileDoesNotExistError): 13345 (WebKit::FrameLoaderClient::pluginWillHandleLoadError): 13346 133472009-02-06 Xan Lopez <xan@gnome.org> 13348 13349 Reviewed by Alexey Proskuryakov. 13350 13351 https://bugs.webkit.org/show_bug.cgi?id=23761 13352 13353 Use two-arg KURL ctor. 13354 13355 We are using the one-arg ctor currently, but: 13356 13357 - It assumes the strings are already encoded, which is not 13358 necesarily the case for us. 13359 13360 - The single-argument KURL ctors expect their input to already be 13361 the output of a previous KURL::parse call, so for the general 13362 case (ie, random user input) we need to use the two-arg ctor 13363 anyway. 13364 13365 * webkit/webkitwebframe.cpp: 13366 * webkit/webkitwebview.cpp: 13367 133682009-02-05 Aaron Boodman <aa@chromium.org> 13369 13370 Reviewed by Dave Hyatt. 13371 13372 https://bugs.webkit.org/show_bug.cgi?id=23708 13373 Adds documentElementAvailable() callback to FrameLoaderClient. 13374 13375 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13376 (WebKit::FrameLoaderClient::documentElementAvailable): 13377 Stub out documentElementAvailable() 13378 * WebCoreSupport/FrameLoaderClientGtk.h: 13379 Ditto. 13380 133812009-02-03 Hiroyuki Ikezoe <poincare@ikezoe.net> 13382 13383 Reviewed by Holger Freyther. 13384 13385 https://bugs.webkit.org/show_bug.cgi?id=22988 13386 [GTK] Need a public method to add a WebKitWebHistoryItem to 13387 WebKitWebBackForwardList. 13388 13389 Wrap WebCore::BackForwardList::addItem. 13390 13391 * tests/main.c: 13392 (test_webkit_web_back_forward_list_add_item): 13393 (main): 13394 * webkit/webkitwebbackforwardlist.cpp: 13395 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_add_item): 13396 * webkit/webkitwebbackforwardlist.h: 13397 133982009-02-02 Geoffrey Garen <ggaren@apple.com> 13399 13400 Build fix. 13401 13402 * webkit/webkitwebview.cpp: 13403 134042009-02-02 Geoffrey Garen <ggaren@apple.com> 13405 13406 Build fix. 13407 13408 * webkit/webkitwebframe.cpp: 13409 134102009-02-02 Geoffrey Garen <ggaren@apple.com> 13411 13412 Build fix. 13413 13414 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13415 (WebKit::FrameLoaderClient::createFrame): 13416 134172009-02-02 Geoffrey Garen <ggaren@apple.com> 13418 13419 Reviewed by Sam Weinig. 13420 13421 Track redirects in global history. 13422 13423 Keep GTK building. 13424 13425 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13426 (WebKit::FrameLoaderClient::createFrame): 13427 (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): 13428 * WebCoreSupport/FrameLoaderClientGtk.h: 13429 134302009-02-02 Anders Carlsson <andersca@apple.com> 13431 13432 Build fix. 13433 13434 * WebCoreSupport/FrameLoaderClientGtk.h: 13435 134362009-02-02 Anders Carlsson <andersca@apple.com> 13437 13438 Reviewed by Dan Bernstein. 13439 13440 Update for changes to WebCore. 13441 13442 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13443 (WebKit::FrameLoaderClient::createPlugin): 13444 (WebKit::FrameLoaderClient::createJavaAppletWidget): 13445 * WebCoreSupport/FrameLoaderClientGtk.h: 13446 134472009-02-02 Holger Hans Peter Freyther <zecke@selfish.org> 13448 13449 Reviewed by Darin Adler. 13450 13451 Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView 13452 13453 https://bugs.webkit.org/show_bug.cgi?id=23428 13454 13455 FrameView::forceLayout could be killed but the comment might 13456 contain a value over the the plain FrameView::layout... 13457 13458 Adjust the WebCore/WebKit consumers of these methods. 13459 13460 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13461 (WebKit::FrameLoaderClient::forceLayout): 13462 * webkit/webkitwebview.cpp: 13463 134642009-01-30 Geoffrey Garen <ggaren@apple.com> 13465 13466 Build fix. 13467 13468 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13469 (WebKit::FrameLoaderClient::createFrame): 13470 134712009-01-30 Holger Hans Peter Freyther <zecke@selfish.org> 13472 13473 Reviewed by Simon Hausmann. 13474 13475 https://bugs.webkit.org/show_bug.cgi?id=22056 13476 13477 Kill FrameLoaderClient.cpp, move the code over to Frame::createView 13478 13479 FrameLoaderClient is supposed to be an interface, move the 13480 to be shared code to Frame which is a controller and is 13481 allowed to create a FrameView. 13482 13483 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13484 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 13485 134862009-01-27 Brady Eidson <beidson@apple.com> 13487 13488 Reviewed by Dan Bernstein 13489 13490 Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage 13491 13492 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13493 (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame): 13494 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame): 13495 * WebCoreSupport/FrameLoaderClientGtk.h: 13496 134972009-01-25 Darin Adler <darin@apple.com> 13498 13499 Try to fix GTK build. 13500 13501 * webkit/webkitwebview.cpp: Added include of FloatQuad.h. 13502 135032009-01-13 Alexander V. Butenko <alex@digiqube.com> 13504 13505 Reviewed by Holger Freyther. 13506 13507 https://bugs.webkit.org/show_bug.cgi?id=23279 13508 13509 Fix crash on WebView dispose stage. 13510 13511 Add null checks to webkit_web_view_set_scroll_adjustments and 13512 webkit_web_view_get_accessible as they get called from within 13513 the dispose. 13514 13515 * webkit/webkitwebview.cpp: 13516 135172009-01-11 Xan Lopez <xan@gnome.org> 13518 13519 Reviewed by Holger Freyther. 13520 13521 Use NULL instead of 0 when dealing with pointers, as agreed for 13522 the coding style of the WebKit GTK port for its GTK+ specific 13523 files. 13524 13525 * webkit/webkitwebview.cpp: 13526 135272009-01-11 Xan Lopez <xan@gnome.org> 13528 13529 Reviewed by Holger Freyther. 13530 13531 Add padding to the class structs to avoid breaking ABI each time 13532 we add stuff there. 13533 13534 * webkit/webkitnetworkrequest.h: 13535 * webkit/webkitwebbackforwardlist.h: 13536 * webkit/webkitwebhistoryitem.h: 13537 * webkit/webkitwebnavigationaction.h: 13538 * webkit/webkitwebpolicydecision.h: 13539 * webkit/webkitwebview.h: 13540 135412009-01-09 Benjamin Otte <otte@gnome.org> 13542 13543 Reviewed by Holger Freyther. 13544 13545 https://bugs.webkit.org/show_bug.cgi?id=23194 13546 13547 make the finalize function the dispose function. Not releasing held 13548 objects in dispose can cause crashers later. 13549 13550 * webkit/webkitwebview.cpp: 13551 135522009-01-09 Benjamin Otte <otte@gnome.org> 13553 13554 Reviewed by Holger Freyther. 13555 13556 https://bugs.webkit.org/show_bug.cgi?id=23194 13557 13558 Remove broken code that uses a fallback. The previous code did 2 13559 policy decisions which caused crashes. 13560 Download is still notImplemented(); 13561 13562 * webkit/webkitwebpolicydecision.cpp: 13563 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download): 13564 135652009-01-03 Xan Lopez <xan@gnome.org> 13566 13567 Reviewed by Holger Freyther. 13568 13569 [GTK] Need a public method to reload view bypassing cache 13570 https://bugs.webkit.org/show_bug.cgi?id=19815 13571 13572 * webkit/webkitwebview.cpp: 13573 * webkit/webkitwebview.h: 13574 13575 Add webkit_web_view_reload_bypass_cache. 13576 135772009-01-07 Holger Hans Peter Freyther <zecke@selfish.org> 13578 13579 Reviewed by Maciej Stachowiak. 13580 13581 Add private API to get the number of active animations of 13582 a frame. This is required by the DumpRenderTree utility. 13583 13584 * webkit/webkitprivate.h: 13585 * webkit/webkitwebframe.cpp: 13586 135872009-01-05 Adam Treat <adam.treat@torchmobile.com> 13588 13589 Fix build 13590 13591 * WebCoreSupport/ChromeClientGtk.h: 13592 135932009-01-05 Adam Treat <adam.treat@torchmobile.com> 13594 13595 Reviewed by George Staikos. 13596 13597 Build fix for contentsSizeChanged 13598 13599 * WebCoreSupport/ChromeClientGtk.cpp: 13600 (WebKit::ChromeClient::contentsSizeChanged): 13601 * WebCoreSupport/ChromeClientGtk.h: 13602 136032009-01-04 Adam Treat <adam.treat@torchmobile.com> 13604 13605 Reviewed by George Staikos. 13606 13607 Make the gtk port build with the new fixedLayoutSize feature 13608 13609 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13610 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 13611 136122009-01-03 Holger Hans Peter Freyther <zecke@selfish.org> 13613 13614 Reviewed by Darin Adler. 13615 13616 [GTK] Fix the reference counting of WebKitWebFrames 13617 13618 The ownership is the following: WebKitWebView owns a WebCore::Page. 13619 WebKitWebView is creating one WebKitWebFrame which will be the 13620 mainFrame of the WebCore::Page (having the reference on the Frame). 13621 13622 The FrameLoaderClient has the reference of the WebKitWebFrame for 13623 the main frame and also any other frame. This means when the 13624 WebCore::Frame goes away the FrameLoaderClient will go away which 13625 will normally remove the last reference of the WebKitWebFrame. Because 13626 an API user might have g_object_ref'ed the WebKitWebFrame null 13627 checks had to be added to WebKitWebFrame. 13628 13629 For WebCore::Frames created by the FrameLoaderClient the ownership 13630 will be passed down to the FrameTree, the WebKitWebFrame is not holding 13631 a reference to the WebCore::Frame. 13632 13633 Do not g_object_unref the mainFrame in the destructor of the 13634 WebKitWebFrame as this will happen from within the WebCore::Page 13635 destruction. Do not hold a reference to the WebCore::Frame (circle) in 13636 WebKitWebFrame, add null checks as the WebCore::Frame might have gone 13637 away. Do not keep track of the FrameLoaderClient in the private 13638 structures as it was mostly unusued. 13639 13640 https://bugs.webkit.org/show_bug.cgi?id=21837 13641 13642 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13643 (WebKit::FrameLoaderClient::frameLoaderDestroyed): 13644 (WebKit::FrameLoaderClient::createFrame): 13645 * tests/main.c: Add test case. 13646 (test_webkit_web_frame_create_destroy): 13647 (test_webkit_web_frame_lifetime): 13648 (main): 13649 * webkit/webkitprivate.cpp: 13650 (WebKit::core): 13651 * webkit/webkitprivate.h: 13652 * webkit/webkitwebframe.cpp: 13653 * webkit/webkitwebview.cpp: 13654 136552009-01-02 Holger Hans Peter Freyther <zecke@selfish.org> 13656 13657 Unreviewed build fix. 13658 13659 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13660 136612008-12-31 Holger Hans Peter Freyther <zecke@selfish.org> 13662 13663 Reviewed by Nikolas Zimmermann. 13664 13665 https://bugs.webkit.org/show_bug.cgi?id=17045 13666 13667 Add section information for View, Frame, Settings, HistoryItem, BackForwardList, WindowFeatures and Inspector 13668 13669 Add section information and informal examples for WebKitWebView, 13670 WebKitWebFrame, WebKitWebSettings, WebKitWebNetworkRequest, 13671 WebKitWebWindowFeatures, WebKitWebHistoryItem, 13672 WebKitWebBackForwardList and WebKitWebInspector. 13673 13674 * docs/webkitgtk-sections.txt: Decide to not document some bits 13675 * webkit/webkitnetworkrequest.cpp: 13676 * webkit/webkitwebbackforwardlist.cpp: 13677 * webkit/webkitwebframe.cpp: 13678 * webkit/webkitwebhistoryitem.cpp: 13679 * webkit/webkitwebhistoryitem.h: 13680 * webkit/webkitwebinspector.cpp: 13681 * webkit/webkitwebsettings.cpp: 13682 * webkit/webkitwebsettings.h: 13683 * webkit/webkitwebview.cpp: 13684 * webkit/webkitwebwindowfeatures.cpp: 13685 136862008-12-21 Xan Lopez <xan@gnome.org> 13687 13688 Reviewed by Holger Freyther. 13689 13690 https://bugs.webkit.org/show_bug.cgi?id=16092 13691 [GTK] Middle-mouse click should allow opening a URL in a new tab 13692 13693 Add mouse button and keyboard state modifiers info to navigation action. 13694 13695 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13696 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 13697 * webkit/webkitwebnavigationaction.cpp: 13698 (_WebKitWebNavigationActionPrivate::): 13699 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property): 13700 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property): 13701 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): 13702 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_button): 13703 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_modifier_state): 13704 * webkit/webkitwebnavigationaction.h: 13705 137062008-12-19 Marco Barisione <marco.barisione@collabora.co.uk> 13707 13708 Reviewed by Holger Freyther. 13709 13710 http://bugs.webkit.org/show_bug.cgi?id=16562 13711 [gtk] Implement WebPolicyDelegate methods 13712 13713 Original work by Pierre-Luc Beaudoin. Final touches by Gustavo 13714 Noronha. 13715 13716 This implements the delegates methods of WebPolicyDelegate. 13717 Since Gtk+/C doesn't have delegate methods, they are replaced with 13718 signals. 13719 13720 A new object WebKitWebPolicyDecision allows the browser to delay its 13721 response in certain cases. WebKitWebNavigationAction contains the 13722 information about what caused a navigation request. 13723 13724 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13725 (WebKit::FrameLoaderClient::FrameLoaderClient): 13726 (WebKit::FrameLoaderClient::~FrameLoaderClient): 13727 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): 13728 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): 13729 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 13730 (WebKit::FrameLoaderClient::cancelPolicyCheck): 13731 (WebKit::FrameLoaderClient::canShowMIMEType): 13732 * WebCoreSupport/FrameLoaderClientGtk.h: 13733 * webkit/webkit.h: 13734 * webkit/webkitdefines.h: 13735 * webkit/webkitprivate.cpp: 13736 (WebKit::kit): 13737 (WebKit::core): 13738 * webkit/webkitprivate.h: 13739 * webkit/webkitwebnavigationaction.cpp: Added. 13740 (_WebKitWebNavigationActionPrivate::): 13741 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property): 13742 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property): 13743 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_init): 13744 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_finalize): 13745 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): 13746 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_reason): 13747 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_reason): 13748 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_original_uri): 13749 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_original_uri): 13750 * webkit/webkitwebnavigationaction.h: Added. 13751 * webkit/webkitwebpolicydecision.cpp: Added. 13752 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_class_init): 13753 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_init): 13754 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_new): 13755 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_use): 13756 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_ignore): 13757 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download): 13758 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_cancel): 13759 * webkit/webkitwebpolicydecision.h: Added. 13760 * webkit/webkitwebview.cpp: 13761 * webkit/webkitwebview.h: 13762 137632008-12-18 Dan Bernstein <mitz@apple.com> 13764 13765 Reviewed by Sam Weinig. 13766 13767 - stub out FrameLoaderClient::shouldUseCredentialStorage(). 13768 13769 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13770 (WebKit::FrameLoaderClient::shouldUseCredentialStorage): 13771 * WebCoreSupport/FrameLoaderClientGtk.h: 13772 137732008-12-18 Sam Weinig <sam@webkit.org> 13774 13775 Reviewed by John Sullivan. 13776 13777 Stub out FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout() 13778 13779 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13780 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout): 13781 * WebCoreSupport/FrameLoaderClientGtk.h: 13782 137832008-12-13 Holger Hans Peter Freyther <zecke@selfish.org> 13784 13785 Reviewed by Cameron Zwarich. 13786 13787 [GTK] Fix crash with LayoutTests/fast/loader/frame-creation-removal.html 13788 13789 Call WebCore::Frame::init after the frame has been given 13790 a name and been added to the FrameTree of the parent. 13791 13792 Removing the call to init is fine as FrameLoaderClientGtk::createFrame 13793 is the only user of webkit_web_frame_init_with_web_view and is already 13794 calling WebCore::Frame::init. 13795 13796 * webkit/webkitwebframe.cpp: 13797 137982008-12-13 Adam Bergkvist <adam.bergkvist@ericsson.com> 13799 13800 Reviewed by Holger Freyther. 13801 13802 https://bugs.webkit.org/show_bug.cgi?id=22779 13803 13804 Check for GTK version >= 2.14.0 before using gtk_test_init. 13805 13806 * tests/main.c: 13807 (main): 13808 138092008-12-13 Zan Dobersek <zandobersek@gmail.com> 13810 13811 Reviewed by Darin Adler. 13812 13813 https://bugs.webkit.org/show_bug.cgi?id=22039 13814 13815 Implement animation and transition pausing as needed by DumpRenderTree. 13816 13817 * webkit/webkitprivate.h: 13818 * webkit/webkitwebframe.cpp: 13819 138202008-11-29 Holger Hans Peter Freyther <zecke@selfish.org> 13821 13822 Rubber-stamped by Simon Hausmann. 13823 13824 https://bugs.webkit.org/show_bug.cgi?id=22574 13825 13826 Make webkit_web_view_set_window_features internal 13827 13828 Calling this method will not result in a notify::window-features 13829 signal being emitted. This would allow replacing a 13830 WebKitWebWindowFeature on a WebKitWebView without anyone noticing 13831 and the client code would monitor the wrong object. 13832 13833 * WebCoreSupport/ChromeClientGtk.cpp: 13834 (WebKit::ChromeClient::createWindow): 13835 * webkit/webkitwebview.cpp: 13836 * webkit/webkitwebview.h: 13837 138382008-12-09 Brett Wilson <brettw@chromium.org> 13839 13840 Reviewed by Dave Hyatt. 13841 13842 https://bugs.webkit.org/show_bug.cgi?id=22177 13843 13844 Add a callback on ChromeClient that the state of form elements on 13845 the page has changed. This is to allow clients implementing session 13846 saving to know when the current state is dirty. 13847 13848 * WebCoreSupport/ChromeClientGtk.h: 13849 (WebKit::ChromeClient::formStateDidChange): 13850 138512008-12-07 Holger Hans Peter Freyther <zecke@selfish.org> 13852 13853 Reviewed by Eric Seidel. 13854 13855 [Gtk+] Use glib's unit test facilities to test the WebKit/Gtk+ API 13856 13857 https://bugs.webkit.org/show_bug.cgi?id=22491 13858 13859 Add the skeleton to WebKit/gtk/tests and integrate that into the 13860 buildsystem. Testing support was added in glib 2.16. For versions 13861 using glib < 2.16 we compile an empty application. 13862 13863 * tests/main.c: Added. https://bugs.webkit.org/show_bug.cgi?id=21837 13864 will be the first consumer. 13865 (main): 13866 138672008-12-06 Simon Fraser <simon.fraser@apple.com> 13868 13869 Reviewed by Dave Hyatt 13870 13871 https://bugs.webkit.org/show_bug.cgi?id=15671 13872 13873 Renderer::caretRect() is now localCaretRect(), which needs 13874 converting to absolute coordinates (taking transforms into account). 13875 13876 * webkit/webkitwebview.cpp: 13877 138782008-12-01 Xan Lopez <xan@gnome.org> 13879 13880 Reviewed by Holger Freyther. 13881 13882 http://bugs.webkit.org/show_bug.cgi?id=22553 13883 Remove unneeded GObject casts. 13884 13885 Remove unneeded casts to GObject in functions that take a gpointer 13886 argument. 13887 13888 * WebCoreSupport/ChromeClientGtk.cpp: 13889 (WebKit::ChromeClient::setWindowRect): 13890 (WebKit::ChromeClient::createWindow): 13891 (WebKit::ChromeClient::setToolbarsVisible): 13892 (WebKit::ChromeClient::toolbarsVisible): 13893 (WebKit::ChromeClient::setStatusbarVisible): 13894 (WebKit::ChromeClient::statusbarVisible): 13895 (WebKit::ChromeClient::setScrollbarsVisible): 13896 (WebKit::ChromeClient::scrollbarsVisible): 13897 (WebKit::ChromeClient::setMenubarVisible): 13898 (WebKit::ChromeClient::menubarVisible): 13899 (WebKit::ChromeClient::setToolTip): 13900 * WebCoreSupport/InspectorClientGtk.cpp: 13901 (WebKit::InspectorClient::createPage): 13902 * webkit/webkitwebframe.cpp: 13903 * webkit/webkitwebview.cpp: 13904 * webkit/webkitwebwindowfeatures.cpp: 13905 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features): 13906 139072008-11-29 Christian Dywan <christian@twotoasts.de> 13908 13909 Reviewed by Holger Freyther. 13910 13911 http://bugs.webkit.org/show_bug.cgi?id=17122 13912 [GTK] Bad font default settings 13913 13914 Implement a property "enforce-96-dpi" in WebKitWebSettings 13915 that can be enabled to force the view to assume 96 DPI. 13916 13917 * webkit/webkitwebsettings.cpp: 13918 (_WebKitWebSettingsPrivate::): 13919 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 13920 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): 13921 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): 13922 * webkit/webkitwebview.cpp: 13923 139242008-11-28 Holger Hans Peter Freyther <zecke@selfish.org> 13925 13926 Reviewed by Nikolas Zimmermann. 13927 13928 Simplify the code. There is no reason to have code like 13929 if (true) return false; which is using temporary variables. 13930 13931 * webkit/webkitwebview.cpp: 13932 139332008-11-28 Holger Hans Peter Freyther <zecke@selfish.org> 13934 13935 Reviewed by Nikolas Zimmermann. 13936 13937 Remove bogus null checks. The WebKitWebView own's a WebCore::Page 13938 which is owning a WebCore::ChromeClient. There is no way that a 13939 WebCore::ChromeClient is still around when the WebKitWebView is gone. 13940 13941 m_webView can only be null when a ChromeClient gets constructed with 13942 a null WebKitWebView which is not allowed. 13943 13944 * WebCoreSupport/ChromeClientGtk.cpp: 13945 (WebKit::ChromeClient::ChromeClient): 13946 (WebKit::ChromeClient::windowRect): 13947 (WebKit::ChromeClient::setWindowRect): 13948 (WebKit::ChromeClient::pageRect): 13949 (WebKit::ChromeClient::focus): 13950 (WebKit::ChromeClient::unfocus): 13951 (WebKit::ChromeClient::show): 13952 (WebKit::ChromeClient::setToolbarsVisible): 13953 (WebKit::ChromeClient::toolbarsVisible): 13954 (WebKit::ChromeClient::setStatusbarVisible): 13955 (WebKit::ChromeClient::statusbarVisible): 13956 (WebKit::ChromeClient::setScrollbarsVisible): 13957 (WebKit::ChromeClient::setMenubarVisible): 13958 (WebKit::ChromeClient::menubarVisible): 13959 (WebKit::ChromeClient::canTakeFocus): 13960 (WebKit::ChromeClient::repaint): 13961 (WebKit::ChromeClient::scroll): 13962 (WebKit::ChromeClient::platformWindow): 13963 139642008-11-28 Gustavo Noronha Silva <gns@gnome.org> 13965 13966 Reviewed and slightly modified by Holger Freyther. 13967 13968 https://bugs.webkit.org/show_bug.cgi?id=19130 13969 13970 ChromeClient::createWindow and friends need to be implemented 13971 13972 Code from Gustavo Noronha and Marco Barisione 13973 <marco.barisione@collabora.co.uk> in this change set. 13974 13975 Implemented all the ChromeClient interfaces needed to have new 13976 window creation functioning and exposed to client code. We 13977 implemented a mirror GObject to the WindowFeatures object provided 13978 by WebCore. 13979 13980 * WebCoreSupport/ChromeClientGtk.cpp: 13981 (WebKit::ChromeClient::windowRect): 13982 (WebKit::ChromeClient::setWindowRect): 13983 (WebKit::ChromeClient::unfocus): 13984 (WebKit::ChromeClient::createWindow): 13985 (WebKit::ChromeClient::show): 13986 (WebKit::ChromeClient::setToolbarsVisible): 13987 (WebKit::ChromeClient::toolbarsVisible): 13988 (WebKit::ChromeClient::setStatusbarVisible): 13989 (WebKit::ChromeClient::statusbarVisible): 13990 (WebKit::ChromeClient::setScrollbarsVisible): 13991 (WebKit::ChromeClient::scrollbarsVisible): 13992 (WebKit::ChromeClient::setMenubarVisible): 13993 (WebKit::ChromeClient::menubarVisible): 13994 (WebKit::ChromeClient::setResizable): 13995 * WebCoreSupport/FrameLoaderClientGtk.cpp: 13996 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): 13997 (WebKit::FrameLoaderClient::dispatchShow): 13998 (WebKit::FrameLoaderClient::dispatchCreatePage): 13999 * webkit/webkit.h: 14000 * webkit/webkitdefines.h: 14001 * webkit/webkitprivate.h: 14002 * webkit/webkitwebview.cpp: 14003 * webkit/webkitwebview.h: 14004 * webkit/webkitwebwindowfeatures.cpp: Added. 14005 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_class_init): 14006 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_init): 14007 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_finalize): 14008 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_set_property): 14009 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_get_property): 14010 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new): 14011 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features): 14012 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_equal): 14013 * webkit/webkitwebwindowfeatures.h: Added. 14014 140152008-11-24 Darin Fisher <darin@chromium.org> 14016 14017 Fix bustage. 14018 14019 http://bugs.webkit.org/show_bug.cgi?id=15643 14020 14021 * WebCoreSupport/EditorClientGtk.cpp: 14022 (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): 14023 * WebCoreSupport/EditorClientGtk.h: 14024 140252008-11-24 Darin Adler <darin@apple.com> 14026 14027 Reviewed by Dan Bernstein. 14028 14029 - https://bugs.webkit.org/show_bug.cgi?id=22470 14030 remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory 14031 14032 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14033 (WebKit::FrameLoaderClient::updateGlobalHistory): Remove argument. 14034 * WebCoreSupport/FrameLoaderClientGtk.h: Ditto. 14035 140362008-11-24 Christian Dywan <christian@twotoasts.de> 14037 14038 Reviewed by Holger Freyther. 14039 14040 http://bugs.webkit.org/show_bug.cgi?id=17122 14041 [GTK] Bad font default settings 14042 14043 * webkit/webkitwebsettings.cpp: 14044 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 14045 Use default font size 12 instead of 10 14046 140472008-11-24 Zan Dobersek <zandobersek@gmail.com> 14048 14049 Reviewed by Holger Freyther. 14050 14051 https://bugs.webkit.org/show_bug.cgi?id=22039 14052 14053 Implement a semi-private function for adding a directory to 14054 PluginDatabase's paths. 14055 14056 * webkit/webkitprivate.h: 14057 * webkit/webkitwebsettings.cpp: 14058 (_WebKitWebSettingsPrivate::webkit_web_settings_add_extra_plugin_directory): 14059 140602008-11-23 Holger Hans Peter Freyther <zecke@selfish.org> 14061 14062 Rubber-stamped by Sam Weinig. 14063 14064 Add gtk-doc configuration/source for the WebKit/Gtk+ Reference Manual 14065 14066 These files will be used by gtk-doc to generate the documentation. They 14067 contain information how to group the symbols of our API, which objects 14068 to inspect during the generation of the manual and how to display the 14069 manual. 14070 14071 * docs/webkitgtk-docs.sgml: Added. 14072 * docs/webkitgtk-overrides.txt: Added. 14073 * docs/webkitgtk-sections.txt: Added. 14074 * docs/webkitgtk.types: Added. 14075 140762008-11-23 Holger Hans Peter Freyther <zecke@selfish.org> 14077 14078 Reviewed by Sam Weinig. 14079 14080 Make gtk-doc happy with the existing API documentation 14081 14082 - Mark the *Private pointers in the struct private 14083 - Use Returns: where gtk-doc wants us to 14084 - Fix the parameters to make gtk-doc happy 14085 - Fix signal references 14086 14087 * webkit/webkitnetworkrequest.h: 14088 * webkit/webkitwebbackforwardlist.cpp: 14089 * webkit/webkitwebbackforwardlist.h: 14090 * webkit/webkitwebframe.h: 14091 * webkit/webkitwebhistoryitem.cpp: 14092 * webkit/webkitwebinspector.cpp: 14093 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): 14094 * webkit/webkitwebview.cpp: 14095 * webkit/webkitwebview.h: 14096 140972008-11-19 Darin Fisher <darin@chromium.org> 14098 14099 Bustage fix. 14100 14101 https://bugs.webkit.org/show_bug.cgi?id=22373 14102 Ports busted by addition of ScriptValue.{h,cpp} 14103 14104 * webkit/webkitwebview.cpp: 14105 141062008-11-18 Holger Hans Peter Freyther <zecke@selfish.org> 14107 14108 Reviewed by Simon Hausmann. 14109 14110 Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports 14111 14112 After Hyatt's work on Widget and ScrollView there is little difference 14113 between the implementation of Qt, Gtk+ and Win. In fact any kind of 14114 difference is mostly a bug. Alp has fixed two of such errors for the Gtk+ 14115 port and the Qt port has at least one of them left. 14116 14117 The only difference between the implementations is in getting the the 14118 IntSize for the new FrameView, the background color to be applied and 14119 eventually some post processing. 14120 14121 Unify the implementations by providing a static helper function that 14122 takes a Frame, IntSize, color and transparency bit and calling it from 14123 the Gtk+, the Qt and the Windows port. 14124 14125 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14126 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 14127 141282008-11-16 Christian Dywan <christian@twoasts.de> 14129 14130 Reviewed by Holger Freyther. 14131 14132 https://bugs.webkit.org/show_bug.cgi?id=22207 14133 [Gtk] Font sizes are not handled properly when updated at runtime 14134 14135 * webkit/webkitwebview.cpp: Move the DPI/ conversion into a 14136 helper function and apply the logic in the notification callback. 14137 141382008-11-06 Alp Toker <alp@nuanti.com> 14139 14140 Reviewed by Darin Adler. 14141 14142 https://bugs.webkit.org/show_bug.cgi?id=22047 14143 GTK: Add support for multiple file selection in the file upload control 14144 14145 Implemented with GtkFileChooser. 14146 14147 * WebCoreSupport/ChromeClientGtk.cpp: 14148 (WebKit::ChromeClient::runOpenPanel): 14149 141502008-11-03 Cameron Zwarich <zwarich@apple.com> 14151 14152 Rubber-stamped by Maciej Stachowiak. 14153 14154 Move more files into the runtime subdirectory of JavaScriptCore. 14155 14156 * webkit/webkitprivate.cpp: 14157 141582008-11-03 Alp Toker <alp@nuanti.com> 14159 14160 Reviewed by Holger Freyther. 14161 14162 Deprecate flawed webkit_web_frame_new() function. This would never 14163 have worked properly when used outside WebCore since Frame::create() 14164 can only be called without an owner element once in the lifetime of a 14165 Page and would result in assertions, leaks and an unusable WebView 14166 instance. 14167 14168 Frame creation may be exposed in API some time later via the DOM 14169 binding but probably not in the WebKit GTK+ core API. 14170 14171 * webkit/webkitwebframe.cpp: 14172 * webkit/webkitwebframe.h: 14173 141742008-11-03 Alp Toker <alp@nuanti.com> 14175 14176 Reviewed by Holger Freyther. 14177 14178 Redundant scrollbars appear in frames where they shouldn't be visible 14179 eg. embedded Google adverts. 14180 14181 Call setCanHaveScrollbars() when necessary. The Mac and Win ports 14182 already have this but it was missing in FrameLoaderClientGtk. 14183 14184 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14185 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 14186 141872008-11-03 Alp Toker <alp@nuanti.com> 14188 14189 Rubber-stamped by Holger Freyther. 14190 14191 Sync WebKit GTK+ default UA version string to 528.5+. (We're still 14192 doing this manually!) 14193 14194 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14195 (WebKit::composeUserAgent): 14196 141972008-10-31 Christian Dywan <christian@twotoasts.de> 14198 14199 Reviewed by Mark Rowe. 14200 14201 http://bugs.webkit.org/show_bug.cgi?id=22018 14202 enable-developer-extras doesn't toggle WebInspector 14203 14204 * webkit/webkitwebview.cpp: 14205 Add missing 'if' in notification for 'enable-developer-extras'. 14206 142072008-10-30 Alp Toker <alp@nuanti.com> 14208 14209 Reviewed by Dave Hyatt. 14210 14211 Fix GIF animations. WebCore will not update animated GIFs if 14212 the WebView is marked offscreen so we need to call 14213 frameView->setParentVisible() when necessary like the Mac and Win 14214 ports do. Regression was introduced around r37155 during the 14215 HostWindow refactor. 14216 14217 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14218 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 14219 142202008-10-30 Alp Toker <alp@nuanti.com> 14221 14222 Rubber-stamped by Holger Freyther. 14223 14224 Fix typo in recently added web inspector signal. dettach -> detach. 14225 14226 * WebCoreSupport/InspectorClientGtk.cpp: 14227 (WebKit::InspectorClient::detachWindow): 14228 * webkit/webkitwebinspector.cpp: 14229 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): 14230 142312008-10-30 Alp Toker <alp@nuanti.com> 14232 14233 Fix version comments for the web inspector added in r37982. Available 14234 since 1.0.3, not 1.0.2. 14235 14236 * webkit/webkitwebinspector.cpp: 14237 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): 14238 * webkit/webkitwebsettings.cpp: 14239 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 14240 * webkit/webkitwebview.cpp: 14241 142422008-10-29 Gustavo Noronha Silva <gns@gnome.org> 14243 14244 Reviewed and slightly changed by Holger Freyther. 14245 14246 Implemented a new WebKitWebInspector class to provide a GObject 14247 API for the Web Inspector. Also implemented InspectorClient. 14248 14249 * WebCoreSupport/InspectorClientGtk.cpp: 14250 (WebKit::notifyWebViewDestroyed): 14251 (WebKit::InspectorClient::InspectorClient): 14252 (WebKit::InspectorClient::inspectorDestroyed): 14253 (WebKit::InspectorClient::webViewDestroyed): 14254 (WebKit::InspectorClient::createPage): 14255 (WebKit::InspectorClient::showWindow): 14256 (WebKit::InspectorClient::closeWindow): 14257 (WebKit::InspectorClient::attachWindow): 14258 (WebKit::InspectorClient::detachWindow): 14259 (WebKit::InspectorClient::inspectedURLChanged): 14260 * WebCoreSupport/InspectorClientGtk.h: 14261 * webkit/webkit.h: 14262 * webkit/webkit-marshal.list: 14263 * webkit/webkitdefines.h: 14264 * webkit/webkitprivate.h: 14265 * webkit/webkitwebinspector.cpp: Added. 14266 (_WebKitWebInspectorPrivate::webkit_inspect_web_view_request_handled): 14267 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): 14268 (_WebKitWebInspectorPrivate::webkit_web_inspector_init): 14269 (_WebKitWebInspectorPrivate::webkit_web_inspector_finalize): 14270 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property): 14271 (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property): 14272 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_web_view): 14273 * webkit/webkitwebinspector.h: Added. 14274 * webkit/webkitwebsettings.cpp: 14275 (_WebKitWebSettingsPrivate::): 14276 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 14277 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): 14278 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): 14279 (_WebKitWebSettingsPrivate::webkit_web_settings_copy): 14280 * webkit/webkitwebview.cpp: 14281 * webkit/webkitwebview.h: 14282 142832008-10-27 Michael Tross <michael@tross.org> 14284 14285 Reviewed by Alp Toker. Landed by Jan Alonzo. 14286 14287 https://bugs.webkit.org/show_bug.cgi?id=21827 14288 [GTK] Fix memory leak in webkit_web_view_load_string 14289 14290 * webkit/webkitwebview.cpp: 14291 142922008-10-24 Sam Weinig <sam@webkit.org> 14293 14294 Fix the Gtk build. 14295 14296 * WebCoreSupport/ChromeClientGtk.cpp: 14297 142982008-10-24 Sam Weinig <sam@webkit.org> 14299 14300 Reviewed by Dan Bernstein. 14301 14302 Fix https://bugs.webkit.org/show_bug.cgi?id=21759 14303 Layering violation: FileChooser should not depend on Document/Frame/Page 14304 14305 * WebCoreSupport/ChromeClientGtk.cpp: 14306 (WebKit::ChromeClient::runOpenPanel): 14307 * WebCoreSupport/ChromeClientGtk.h: 14308 143092008-10-24 Timothy Hatcher <timothy@apple.com> 14310 14311 Stub out new InspectorClient methods. 14312 14313 https://bugs.webkit.org/show_bug.cgi?id=21856 14314 14315 Reviewed by Darin Adler. 14316 14317 * WebCoreSupport/InspectorClientGtk.cpp: 14318 (WebKit::InspectorClient::populateSetting): Not implemented. 14319 (WebKit::InspectorClient::storeSetting): Ditto. 14320 (WebKit::InspectorClient::removeSetting): Ditto. 14321 * WebCoreSupport/InspectorClientGtk.h: 14322 143232008-10-22 Alp Toker <alp@nuanti.com> 14324 14325 Build fix for older GTK+ versions where GTK_TYPE_TARGET_LIST isn't 14326 defined. 14327 14328 * webkit/webkitwebview.cpp: 14329 143302008-10-22 Alp Toker <alp@nuanti.com> 14331 14332 Reviewed by Adam Roben. 14333 14334 Avoid critical warnings on older GTK+ versions (2.8) by not checking 14335 for GTK+ setting properties when we know they don't exist. 14336 14337 * WebCoreSupport/ContextMenuClientGtk.cpp: 14338 (WebKit::inputMethodsMenuItem): 14339 (WebKit::unicodeMenuItem): 14340 143412008-10-20 Sam Weinig <sam@webkit.org> 14342 14343 Reviewed by Anders Carlsson. 14344 14345 Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port. 14346 14347 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14348 * WebCoreSupport/FrameLoaderClientGtk.h: 14349 143502008-10-20 Alp Toker <alp@nuanti.com> 14351 14352 Reviewed by Dave Hyatt. 14353 14354 https://bugs.webkit.org/show_bug.cgi?id=21303 14355 [GTK] Scrolling glitches 14356 14357 Implement a buffering scheme to avoid full repaints when scrolling 14358 views or subframes significantly improving scrolling performance. 14359 14360 Improve rendering performance by coalescing large numbers of small 14361 repaints. 14362 14363 Also fixes long-running issues with scrollbar positioning and frame 14364 invalidation. 14365 14366 Rendering in the GTK+ port should be more similar to other ports after 14367 these changes. 14368 14369 * WebCoreSupport/ChromeClientGtk.cpp: 14370 (WebKit::ChromeClient::repaint): 14371 (WebKit::ChromeClient::scroll): 14372 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14373 (WebKit::FrameLoaderClient::forceLayout): 14374 * webkit/webkitwebview.cpp: 14375 143762008-10-17 Luke Kenneth Casson Leighton <lkcl@lkcl.net> 14377 14378 Reviewed by Mark Rowe. Landed by Jan Alonzo. 14379 14380 https://bugs.webkit.org/show_bug.cgi?id=20403 14381 [Gtk] Segfault after a table with an iframe is attempted to be added twice to DOM model with javascript 14382 14383 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14384 (WebKit::FrameLoaderClient::frameLoaderDestroyed): 14385 (WebKit::FrameLoaderClient::detachedFromParent4): 14386 143872008-10-06 David Hyatt <hyatt@apple.com> 14388 14389 Enable viewless Mac WebKit to paint some basic pages. 14390 14391 Reviewed by Sam Weinig 14392 14393 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14394 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 14395 * WebCoreSupport/FrameLoaderClientGtk.h: 14396 143972008-10-03 David Hyatt <hyatt@apple.com> 14398 14399 Fix Gtk bustage from use of containingWindow() over on the WebKit side. Replace with HostWindow use. 14400 14401 * webkit/webkitwebview.cpp: 14402 144032008-10-03 David Hyatt <hyatt@apple.com> 14404 14405 https://bugs.webkit.org/show_bug.cgi?id=21340 14406 14407 Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now. 14408 14409 Reviewed by Dan Bernstein & Darin Adler 14410 14411 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14412 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 14413 144142008-10-03 Alp Toker <alp@nuanti.com> 14415 14416 Remove some left-over GTK+ includes. No change in functionality. 14417 14418 * webkit/webkitwebhistoryitem.h: 14419 144202008-10-03 Alp Toker <alp@nuanti.com> 14421 14422 Build fix following r37234. Remove addToDirtyRegion from the header 14423 too. 14424 14425 * WebCoreSupport/ChromeClientGtk.h: 14426 144272008-10-03 David Hyatt <hyatt@apple.com> 14428 14429 Remove addToDirtyRegion. 14430 14431 Reviewed by Oliver Hunt 14432 14433 * WebCoreSupport/ChromeClientGtk.cpp: 14434 144352008-10-02 David Hyatt <hyatt@apple.com> 14436 14437 https://bugs.webkit.org/show_bug.cgi?id=21314 14438 14439 Make scrollBackingStore cross-platform. 14440 14441 Reviewed by Sam Weinig 14442 14443 * WebCoreSupport/ChromeClientGtk.cpp: 14444 (WebKit::ChromeClient::repaint): 14445 (WebKit::ChromeClient::scroll): 14446 * WebCoreSupport/ChromeClientGtk.h: 14447 144482008-10-01 David Hyatt <hyatt@apple.com> 14449 14450 https://bugs.webkit.org/show_bug.cgi?id=21282 14451 14452 Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now. 14453 14454 Reviewed by Adam Roben 14455 14456 * WebCoreSupport/ChromeClientGtk.cpp: 14457 (WebKit::ChromeClient::windowToScreen): 14458 (WebKit::ChromeClient::screenToWindow): 14459 * WebCoreSupport/ChromeClientGtk.h: 14460 144612008-09-30 Dave Hyatt <hyatt@apple.com> 14462 14463 http://bugs.webkit.org/show_bug.cgi?id=21250 14464 14465 Rename updateContents to repaintContentRectangle and make it cross-platform by always sending 14466 repaints up through the ChromeClient. 14467 14468 Reviewed by Darin Adler 14469 14470 * WebCoreSupport/ChromeClientGtk.cpp: 14471 (WebKit::ChromeClient::repaint): 14472 * WebCoreSupport/ChromeClientGtk.h: 14473 144742008-09-16 Alp Toker <alp@nuanti.com> 14475 14476 Suggested by Dave Hyatt. 14477 14478 Build fix and cleanup. Rename ScrollBar to Scrollbar. 14479 14480 * webkit/webkitwebview.cpp: 14481 144822008-09-13 Adrien Nader <camaradetux@gmail.com> 14483 14484 Gtk build fix, not reviewed. 14485 14486 * webkit/webkitwebview.cpp: 14487 144882008-09-10 Alp Toker <alp@nuanti.com> 14489 14490 Reviewed by Mark Rowe. 14491 14492 https://bugs.webkit.org/show_bug.cgi?id=17267 14493 [GTK] Primary selection/clipboard support 14494 14495 Implement primary selection support (copying only, no paste yet). 14496 14497 * WebCoreSupport/EditorClientGtk.cpp: 14498 (WebKit::clipboard_get_contents_cb): 14499 (WebKit::clipboard_clear_contents_cb): 14500 (WebKit::EditorClient::respondToChangedSelection): 14501 145022008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca> 14503 14504 Reviewed by Maciej Stachowiak. 14505 14506 Bug 20704: Replace the KJS namespace 14507 <https://bugs.webkit.org/show_bug.cgi?id=20704> 14508 14509 Rename the KJS namespace to JSC. 14510 14511 * webkit/webkitprivate.cpp: 14512 (webkit_init): 14513 145142008-09-05 Gustavo Noronha Silva <gns@gnome.org> 14515 14516 Reviewed by Alp Toker. 14517 14518 https://bugs.webkit.org/show_bug.cgi?id=18346 14519 [GTK] Remove build warnings 14520 14521 Removed/commented code that is not (yet) used, and reordered 14522 member variables initialization for FrameLoaderClient, so that the 14523 compiler is happy and prints less warnings when building. 14524 14525 * WebCoreSupport/ContextMenuClientGtk.cpp: 14526 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14527 (WebKit::FrameLoaderClient::FrameLoaderClient): 14528 145292008-09-03 Alp Toker <alp@nuanti.com> 14530 14531 Build fix following r36073. Include config.h where necessary. 14532 14533 * WebCoreSupport/PasteboardHelperGtk.cpp: 14534 * webkit/webkitversion.cpp: 14535 145362008-09-01 Alp Toker <alp@nuanti.com> 14537 14538 Reviewed by Eric Seidel. 14539 14540 https://bugs.webkit.org/show_bug.cgi?id=19939 14541 [GTK] webkit_web_history_item_get_title() fails with assertion 14542 14543 Make sure newly constructed WebHistoryItem objects wrap a WebCore 14544 history item when necessary. Avoid G_PARAM_CONSTRUCT since it destroys 14545 history data -- use WEBKIT_PARAM flags instead as they do the right 14546 thing. This restores history functionality. 14547 14548 Also use CString to simplify UTF-8 string management. 14549 14550 * webkit/webkitwebbackforwardlist.cpp: 14551 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): 14552 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit): 14553 No need to initialize the vector with a size since it's cleared by the 14554 callee. 14555 * webkit/webkitwebhistoryitem.cpp: 14556 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_finalize): 14557 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init): 14558 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): 14559 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): 14560 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): 14561 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title): 14562 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title): 14563 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title): 14564 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri): 14565 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri): 14566 145672008-08-27 Adrien Nader <camaradetux@gmail.com> 14568 14569 Reviewed by Eric Seidel. 14570 14571 https://bugs.webkit.org/show_bug.cgi?id=20099 14572 [GTK] SHIFT+PAGE_UP/DOWN doesn't extend selection 14573 14574 * WebCoreSupport/EditorClientGtk.cpp: 14575 (WebKit::EditorClient::handleKeyboardEvent): 14576 145772008-08-27 Brady Eidson <beidson@apple.com> 14578 14579 Reviewed by Anders 14580 14581 <rdar://problem/6134133> - Crash when loading large movie as a standalone document 14582 14583 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14584 (WebKit::FrameLoaderClient::pluginWillHandleLoadError): Stubbed for now 14585 * WebCoreSupport/FrameLoaderClientGtk.h: 14586 145872008-08-18 Alp Toker <alp@nuanti.com> 14588 14589 Reviewed by Holger Freyther. 14590 14591 https://bugs.webkit.org/show_bug.cgi?id=20350 14592 [GTK] Get DumpRenderTree working 14593 14594 Add a private function to WebFrame to dump the render tree as required 14595 for the DumpRenderTree testing tool. 14596 14597 * webkit/webkitprivate.h: 14598 * webkit/webkitwebframe.cpp: 14599 146002008-08-12 Timothy Hatcher <timothy@apple.com> 14601 14602 Add a stub for InspectorClient::setAttachedWindowHeight. 14603 14604 * WebCoreSupport/InspectorClientGtk.cpp: 14605 (WebKit::InspectorClient::setAttachedWindowHeight): 14606 Call notImplemented(). 14607 * WebCoreSupport/InspectorClientGtk.h: 14608 146092008-08-10 Alp Toker <alp@nuanti.com> 14610 14611 Remove leftover qmake/GTK+ build files. 14612 14613 * webkit/headers.pri: Removed. 14614 146152008-08-02 Christian Dywan <christian@twotoasts.de> 14616 14617 Reviewed by Eric Seidel. 14618 14619 Remove webkit-marshal.list, which was made obsolete in #19742 14620 14621 * webkit/webkit-marshal.list: Removed. 14622 146232008-08-01 Wouter Bolsterlee <uws@xs4all.nl> 14624 14625 Reviewed by Eric Seidel. 14626 14627 https://bugs.webkit.org/show_bug.cgi?id=20035 14628 [GTK] Fix return value for webkit_web_view_go_to_back_forward_item() 14629 14630 * webkit/webkitwebview.cpp: 14631 146322008-07-30 Marco Barisione <marco.barisione@collabora.co.uk> 14633 14634 Reviewed by Holger. 14635 14636 http://bugs.webkit.org/show_bug.cgi?id=19742 14637 [GTK] Auto generate webkitmarshal.list 14638 14639 Auto generate webkitmarshal.list from source files to reduce the 14640 number of conflicts when merging git branches or when applying 14641 patches. 14642 Also rename webkit-marshal.* to webkitmarshal.* for consistency. 14643 14644 * webkit/webkitwebframe.cpp: Include webkitmarshal.h instead of 14645 webkit-marshal.h. 14646 * webkit/webkitwebview.cpp: Ditto. 14647 146482008-07-30 Gustavo Noronha Silva <gns@gnome.org> 14649 14650 Reviewed by Sam. 14651 14652 https://bugs.webkit.org/show_bug.cgi?id=20205 14653 Typo in comment for bracer ending block 14654 14655 * webkit/webkitprivate.cpp: Typo fix in comment for the brace 14656 that ends the WebKit namespace; WebCore -> WebKit 14657 146582008-07-26 Mark Rowe <mrowe@apple.com> 14659 14660 Build fix. Changes to accommodate newly named/signatured loading methods in WebCore. 14661 14662 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14663 (WebKit::FrameLoaderClient::createFrame): 14664 146652008-07-17 Christian Dywan <christian@twotoasts.de> 14666 14667 Reviewed by Holger Freyther. 14668 14669 https://bugs.webkit.org/show_bug.cgi?id=19813 14670 [GTK] WebKit crashes on invalid settings notify callback 14671 14672 * webkit/webkitwebview.cpp: Disconnect in webkit_web_view_finalize 14673 146742008-07-08 Jan Michael Alonzo <jmalonzo@webkit.org> 14675 14676 Reviewed by Christian Dywan. 14677 14678 Replace 'const' with G_CONST_RETURN macro to make it flexible to 14679 disable constness 14680 14681 * webkit/webkitnetworkrequest.cpp: 14682 * webkit/webkitnetworkrequest.h: 14683 * webkit/webkitwebframe.cpp: 14684 * webkit/webkitwebframe.h: 14685 * webkit/webkitwebhistoryitem.cpp: 14686 * webkit/webkitwebhistoryitem.h: 14687 146882008-06-18 Marco Barisione <marco.barisione@collabora.co.uk> 14689 14690 Reviewed by Alp Toker. 14691 14692 https://bugs.webkit.org/show_bug.cgi?id=19171 14693 [GTK] GTypes for enumerations 14694 14695 Generate GTypes for public enumerations so they can be used as 14696 properties. 14697 14698 * GNUmakefile.am: Generate webkit-enum-types.cpp and 14699 webkit-enum-types.h. 14700 147012008-06-17 Christian Dywan <christian@twotoasts.de> 14702 14703 Reviewed by Alp. 14704 14705 [GTK] WebKitWebHistoryItem needs properties 14706 https://bugs.webkit.org/show_bug.cgi?id=19558 14707 14708 Implement properties matching the existing accessors. 14709 14710 * webkit/webkitwebhistoryitem.cpp: 14711 (_WebKitWebHistoryItemPrivate::): 14712 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init): 14713 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_property): 14714 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_property): 14715 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title): 14716 147172008-06-15 Darin Adler <darin@apple.com> 14718 14719 - give Frame object functions shorter names: scriptProxy() -> script(), 14720 selectionController() -> selection(), animationController() -> animation() 14721 14722 * WebCoreSupport/EditorClientGtk.cpp: 14723 (WebKit::EditorClient::handleKeyboardEvent): 14724 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14725 (WebKit::FrameLoaderClient::windowObjectCleared): 14726 * webkit/webkitwebframe.cpp: 14727 * webkit/webkitwebview.cpp: 14728 147292008-06-15 Darin Adler <darin@apple.com> 14730 14731 - undo bogus renaming done by the script 14732 14733 * WebCoreSupport/ContextMenuClientGtk.cpp: 14734 * webkit/webkitnetworkrequest.h: 14735 * webkit/webkitwebbackforwardlist.h: 14736 * webkit/webkitwebframe.h: 14737 * webkit/webkitwebhistoryitem.h: 14738 * webkit/webkitwebsettings.h: 14739 147402008-06-15 Darin Adler <darin@apple.com> 14741 14742 - new names for a few key JavaScriptCore files 14743 14744 * WebCoreSupport/ContextMenuClientGtk.cpp: 14745 * webkit/webkitnetworkrequest.h: 14746 * webkit/webkitwebbackforwardlist.h: 14747 * webkit/webkitwebframe.h: 14748 * webkit/webkitwebhistoryitem.h: 14749 * webkit/webkitwebsettings.h: 14750 147512008-06-15 Christian Dywan <christian@twotoasts.de> 14752 14753 Reviewed by Alp Toker. 14754 14755 [GTK] Property setters do not call g_object_notify() 14756 https://bugs.webkit.org/show_bug.cgi?id=18405 14757 14758 * webkit/webkitwebview.cpp: 14759 147602008-06-15 Christian Dywan <christian@twotoasts.de> 14761 14762 Reviewed by Alp Toker. 14763 14764 Tiny documentation fix, s/capacity/limit 14765 14766 * webkit/webkitwebbackforwardlist.cpp: 14767 147682008-06-14 Darin Adler <darin@apple.com> 14769 14770 Rubber stamped by Sam. 14771 14772 - new names for kjs_binding.h and kjs_proxy.h 14773 14774 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14775 * webkit/webkitwebframe.cpp: 14776 147772008-06-14 Darin Adler <darin@apple.com> 14778 14779 - fix build 14780 14781 * webkit/webkitwebframe.cpp: Remove a bogus release() call. 14782 147832008-06-14 Darin Adler <darin@apple.com> 14784 14785 Reviewed by Sam. 14786 14787 - more https://bugs.webkit.org/show_bug.cgi?id=17257 14788 start ref counts at 1 instead of 0 for speed 14789 14790 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14791 (WebKit::FrameLoaderClient::createDocumentLoader): Use create instead of new. 14792 * webkit/webkitwebframe.cpp: 14793 (webkit_web_frame_new): Ditto. 14794 (webkit_web_frame_init_with_web_view): Ditto. 14795 147962008-06-13 Darin Adler <darin@apple.com> 14797 14798 - try to fix build 14799 14800 * WebCoreSupport/FrameLoaderClientGtk.h: Add missing argument. 14801 148022008-06-13 Darin Adler <darin@apple.com> 14803 14804 Reviewed by John Sullivan. 14805 14806 - updated for addition of FormState argument to action policy functions 14807 14808 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14809 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): 14810 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 14811 148122008-06-10 Christian Dywan <christian@twotoasts.de> 14813 14814 Reviewed by Alp Toker and Darin Adler. 14815 14816 https://bugs.webkit.org/show_bug.cgi?id=16676 14817 Apply GTK coding style to WebKit Gtk public headers 14818 14819 * webkit/webkitnetworkrequest.h: 14820 * webkit/webkitwebbackforwardlist.h: 14821 * webkit/webkitwebframe.h: 14822 * webkit/webkitwebhistoryitem.h: 14823 * webkit/webkitwebsettings.h: 14824 * webkit/webkitwebview.h: 14825 148262008-06-07 Jan Michael Alonzo <jmalonzo@webkit.org> 14827 14828 Confirmed by Christian Dywan. 14829 14830 Gtk build fix for r34432 14831 14832 * webkit/webkitwebhistoryitem.cpp: 14833 (_WebKitWebHistoryItemPrivate::webkit_history_item_add): 14834 (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): 14835 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): 14836 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): 14837 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): 14838 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): 14839 (WebKit::core): 14840 148412008-06-07 Darin Adler <darin@apple.com> 14842 14843 - try to fix build after HistoryItem changes 14844 14845 * webkit/webkitwebhistoryitem.cpp: 14846 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): Use HistoryItem::create. 14847 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): Ditto. I also 14848 believe this fixes a memory leak in the old version. 14849 148502008-06-07 Christian Dywan <christian@twotoasts.de> 14851 14852 Reviewed by Alp Toker. 14853 14854 https://bugs.webkit.org/show_bug.cgi?id=17324 14855 Remove PLATFORM ifdefs from ContextMenu.cpp 14856 14857 * WebCoreSupport/ContextMenuClientGtk.cpp: 14858 (WebKit::ContextMenuClient::ContextMenuClient): 14859 (WebKit::ContextMenuClient::contextMenuDestroyed): 14860 (WebKit::inputMethodsMenuItem): 14861 (WebKit::): 14862 (WebKit::insertControlCharacter): 14863 (WebKit::unicodeMenuItem): 14864 (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): 14865 * WebCoreSupport/ContextMenuClientGtk.h: 14866 * webkit/webkitwebview.cpp: 14867 148682008-06-05 Alp Toker <alp@nuanti.com> 14869 14870 Add 'Since' documentation for API versioning functions. 14871 14872 * webkit/webkitversion.cpp: 14873 148742008-06-05 Christian Dywan <christian@twotoasts.de> 14875 14876 Reviewed by Alp Toker. 14877 14878 https://bugs.webkit.org/show_bug.cgi?id=14141 14879 Please add a version to the Gtk port 14880 14881 * webkit/webkit.h: 14882 * webkit/webkitversion.cpp: Added. 14883 * webkit/webkitversion.h.in: Added. 14884 * webkit/webkitwebsettings.cpp: 14885 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 14886 * webkit/webkitwebview.cpp: 14887 148882008-06-01 Alp Toker <alp@nuanti.com> 14889 14890 Suggested by Christian Dywan. 14891 14892 Use float literals for zoom values and improve documentation wording. 14893 14894 * webkit/webkitwebsettings.cpp: 14895 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 14896 * webkit/webkitwebview.cpp: 14897 148982008-06-01 Alp Toker <alp@nuanti.com> 14899 14900 Reviewed by Oliver. 14901 14902 Remove webkit_web_view_go_backward(), 14903 webkit_web_view_can_go_backward(). These have been obsoleted by 14904 the back() versions for quite a while. 14905 14906 * webkit/webkitwebview.cpp: 14907 * webkit/webkitwebview.h: 14908 149092008-05-31 Alp Toker <alp@nuanti.com> 14910 14911 Fix inconsistent zoom docs and enum name landed in r34249. Issue 14912 noticed by Marco Barisione. 14913 14914 * webkit/webkitwebview.cpp: 14915 149162008-05-30 Carlos MartÃn Nieto <carlos@cmartin.tk> 14917 14918 Reviewed by Alp Toker. 14919 14920 http://bugs.webkit.org/show_bug.cgi?id=18383 14921 [GTK] The "hovering-over-link" signal arguments aren't documented. 14922 14923 * webkit/webkitwebview.cpp: 14924 149252008-05-29 Marco Barisione <marco@collabora.co.uk> 14926 14927 Reviewed (and tweaked) by Alp Toker. 14928 14929 http://bugs.webkit.org/show_bug.cgi?id=18281 14930 [GTK] add functions to set/get the zoom level 14931 14932 * webkit/webkitwebsettings.cpp: 14933 (_WebKitWebSettingsPrivate::): 14934 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): 14935 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): 14936 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): 14937 * webkit/webkitwebview.cpp: Add functions to get and set the zoom 14938 level. 14939 * webkit/webkitwebview.h: Ditto. 14940 * webkit/webkitprivate.h: 14941 149422008-05-28 Alp Toker <alp@nuanti.com> 14943 14944 Reviewed by Alexey Proskuryakov. 14945 14946 http://bugs.webkit.org/show_bug.cgi?id=18704 14947 [gtk] cannot type letters with dead keys in textarea 14948 14949 http://bugs.webkit.org/show_bug.cgi?id=14120 14950 [GDK] Support input methods 14951 14952 Add support for input method composition. 14953 14954 Remove some old hacks so we handle input method events more 14955 consistently. 14956 14957 * WebCoreSupport/EditorClientGtk.cpp: 14958 (WebKit::imContextCommitted): 14959 (WebKit::imContextPreeditChanged): 14960 (WebKit::EditorClient::setInputMethodState): 14961 (WebKit::EditorClient::respondToChangedSelection): 14962 (WebKit::EditorClient::handleInputMethodKeydown): 14963 (WebKit::EditorClient::EditorClient): 14964 (WebKit::EditorClient::~EditorClient): 14965 (WebKit::EditorClient::textFieldDidBeginEditing): 14966 (WebKit::EditorClient::textFieldDidEndEditing): 14967 (WebKit::EditorClient::textDidChangeInTextField): 14968 (WebKit::EditorClient::doTextFieldCommandFromEvent): 14969 * webkit/webkitwebview.cpp: 14970 149712008-05-25 Alp Toker <alp@nuanti.com> 14972 14973 Reviewed by Niko. 14974 14975 Drop WebView focus when the widget is focused out. 14976 14977 * webkit/webkitwebview.cpp: 14978 149792008-05-25 Sriram Neelakandan <sriram.neelakandan@gmail.com> 14980 14981 Reviewed by Alp Toker. 14982 14983 http://bugs.webkit.org/show_bug.cgi?id=18935 14984 [Gtk] Plugin Load crashes with NP_FULL mode 14985 14986 Fix crash due to uninitialized variable. 14987 14988 * WebCoreSupport/FrameLoaderClientGtk.cpp: 14989 (WebKit::FrameLoaderClient::FrameLoaderClient): 14990 149912008-05-24 Alp Toker <alp@nuanti.com> 14992 14993 https://bugs.webkit.org/show_bug.cgi?id=18825 14994 webkitgtk fails to build from source: "Database Tracker" has not been declared 14995 14996 GTK+ fix for building without database support. 14997 exceededDatabaseQuota() still needs to be present, just a no-op. 14998 14999 * WebCoreSupport/ChromeClientGtk.cpp: 15000 (WebKit::ChromeClient::exceededDatabaseQuota): 15001 150022008-05-23 Alp Toker <alp@nuanti.com> 15003 15004 GTK+ fixes for building without database support. 15005 15006 * WebCoreSupport/ChromeClientGtk.cpp: 15007 150082008-05-19 Alp Toker <alp@nuanti.com> 15009 15010 Reviewed by Anders and Beth. 15011 15012 http://bugs.webkit.org/show_bug.cgi?id=16495 15013 [GTK] Accessibility support with ATK/AT-SPI 15014 15015 Initial ATK/AT-SPI accessibility support for the GTK+ port. 15016 15017 * webkit/webkitwebview.cpp: 15018 150192008-05-06 Christian Dywan <christian@twotoasts.de> 15020 15021 Rubber stamped by Alp. 15022 15023 Back out 17626. It wasn't ready for commit. 15024 15025 * webkit/webkitprivate.h: 15026 * webkit/webkitwebview.cpp: 15027 * webkit/webkitwebview.h: 15028 150292008-05-01 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk> 15030 15031 Reviewed by Alp Toker. 15032 15033 https://bugs.webkit.org/show_bug.cgi?id=14750 15034 Added support for NPAPI plugins on Gtk and Qt-x11 ports. 15035 15036 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15037 (WebKit::FrameLoaderClient::FrameLoaderClient): 15038 (WebKit::FrameLoaderClient::committedLoad): 15039 (WebKit::FrameLoaderClient::createPlugin): 15040 (WebKit::FrameLoaderClient::redirectDataToPlugin): 15041 (WebKit::FrameLoaderClient::finishedLoading): 15042 (WebKit::FrameLoaderClient::setMainDocumentError): 15043 * WebCoreSupport/FrameLoaderClientGtk.h: 15044 150452008-04-30 Sean Egan <seanegan@gmail.com> 15046 15047 Reviewed and modified by Holger. 15048 15049 https://bugs.webkit.org/show_bug.cgi?id=17626 15050 Support setting background color and a 16-bit alpha channel. 15051 15052 * webkit/webkitprivate.h: 15053 * webkit/webkitwebview.cpp: 15054 * webkit/webkitwebview.h: 15055 150562008-04-24 Dan Bernstein <mitz@apple.com> 15057 15058 - build fix 15059 15060 * webkit/webkitwebview.cpp: 15061 150622008-04-24 Anders Carlsson <andersca@apple.com> 15063 15064 Reviewed by Sam. 15065 15066 Change some String arguments to be const references instead. 15067 15068 * WebCoreSupport/EditorClientGtk.cpp: 15069 (WebKit::EditorClient::shouldInsertText): 15070 * WebCoreSupport/EditorClientGtk.h: 15071 150722008-04-23 Christian Dywan <christian@twotoasts.de> 15073 15074 Reviewed by Alp Toker. 15075 15076 Emit a warning about an unknown setting only if it is 15077 not a valid property. Otherwise applications can't 15078 subclass WebKitWebSettings to add new properties. 15079 15080 * webkit/webkitwebview.cpp: 15081 150822008-04-20 Simon Hausmann <hausmann@webkit.org> 15083 15084 Reviewed by Alp Toker. 15085 15086 http://bugs.webkit.org/show_bug.cgi?id=18578 15087 Share the printing code between the Gtk and the Qt port 15088 15089 Share the printing code between the Gtk and the Qt port 15090 and added printing to the Qt WebKit API. 15091 15092 * webkit/webkitwebframe.cpp: Removed PrintContext in favour of 15093 page/Printcontext.cpp/h 15094 150952008-04-19 Alp Toker <alp@nuanti.com> 15096 15097 Reviewed by Maciej. 15098 15099 Enable visited link tracking by default at startup. 15100 15101 With this patch, the GTK+ port rendering of Acid3 now matches the 15102 reference page. 15103 15104 * webkit/webkitprivate.cpp: 15105 (WebKit::core): 15106 (webkit_init): 15107 151082008-04-11 Mark Rowe <mrowe@apple.com> 15109 15110 Gtk build fix after r32231. 15111 15112 * webkit/webkitwebview.cpp: Update to use contentRenderer. 15113 151142008-04-18 Alp Toker <alp@atoker.com> 15115 15116 Rubber-stamped by Holger Freyther. 15117 15118 http://bugs.webkit.org/show_bug.cgi?id=18218 15119 [Gtk] segfault when clicking on a disabled button 15120 15121 Always use the main frame for mouse events (not the focused frame) 15122 since it knows best how to get the event through to the right target. 15123 15124 This also fixes a null crasher. 15125 15126 * webkit/webkitwebview.cpp: 15127 151282008-04-17 Alp Toker <alp@atoker.com> 15129 15130 Rubber-stamped by Holger Freyther. 15131 15132 Reduce hard-coded page-cache count to 3 based on research done for the 15133 Mac port on value / page. 15134 15135 We will need to make this more dynamic or configurable at some point 15136 but for now it's best to keep closer to the behaviour before page 15137 caching was enabled. 15138 15139 Issue spotted by Mark Rowe. 15140 15141 * webkit/webkitprivate.cpp: 15142 (webkit_init): 15143 151442008-04-17 Daniele Metilli <daniele.metilli@gmail.com> 15145 15146 Reviewed by Eric. 15147 15148 Fixed a typo in the copyright header. 15149 15150 * webkit/webkitprivate.h: 15151 151522008-04-14 Holger Freyther <zecke@selfish.org> 15153 15154 Reviewed by Alp Toker. 15155 15156 https://bugs.webkit.org/show_bug.cgi?id=18411 15157 Enable Page caching and create FrameViews on the fly 15158 15159 Create the FrameView on the fly and cache pages 15160 15161 - Keep a copy of the GtkAdjustment to be able to reuse it for the 15162 FrameViews 15163 - Do not initially create a FrameView and update the WebKit code to 15164 cope with not having a view. 15165 - Cache seven pages by default. 15166 15167 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15168 (WebKit::FrameLoaderClient::createFrame): 15169 (WebKit::FrameLoaderClient::canCachePage): 15170 (WebKit::FrameLoaderClient::savePlatformDataToCachedPage): 15171 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage): 15172 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 15173 * webkit/webkitprivate.cpp: 15174 (webkit_init): 15175 * webkit/webkitprivate.h: 15176 * webkit/webkitwebframe.cpp: 15177 * webkit/webkitwebview.cpp: 15178 151792008-04-10 Mario Bensi <mbensi@pleyo.com> 15180 15181 Reviewed by Alp Toker. 15182 15183 https://bugs.webkit.org/show_bug.cgi?id=18400 15184 Database example doesn't work on Gtk port 15185 15186 Fix quota in ChromeClient 15187 15188 * WebCoreSupport/ChromeClientGtk.cpp: 15189 (WebKit::ChromeClient::exceededDatabaseQuota): 15190 151912008-04-08 Adam Roben <aroben@apple.com> 15192 15193 Move callOnMainThread to WTF 15194 15195 Reviewed by Alexey Proskuryakov. 15196 15197 * webkit/webkitprivate.cpp: Updated #include. 15198 (webkit_init): Changed to call KJS::initializeThreading. 15199 152002008-04-06 Luca Bruno <lethalman88@gmail.com> 15201 15202 Reviewed by Alp Toker. 15203 15204 Fix webkit_web_view_get_transparent() return value. 15205 15206 * webkit/webkitwebview.cpp: 15207 152082008-03-31 Jasper Bryant-Greene <jasper@unix.geek.nz> 15209 15210 Reviewed by Darin Adler. 15211 15212 Resolves http://bugs.webkit.org/show_bug.cgi?id=18010 15213 "WebKitNetworkRequestPrivate is defined in two places unnecessarily" 15214 15215 Removed unnecessary definition of WebKitNetworkRequestPrivate in 15216 webkitprivate.h 15217 15218 * webkit/webkitprivate.h: 15219 152202008-03-25 Brady Eidson <beidson@apple.com> 15221 15222 Reviewed by Darin 15223 15224 Remove newly obsolete FrameLoaderClient methods 15225 15226 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15227 * WebCoreSupport/FrameLoaderClientGtk.h: 15228 152292008-03-20 Alp Toker <alp@atoker.com> 15230 15231 GTK+ build fix. Back out r31183. This patch also introduced API style 15232 issues. 15233 15234 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15235 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 15236 * webkit/headers.pri: 15237 * webkit/webkit-marshal.list: 15238 * webkit/webkitdefines.h: 15239 * webkit/webkitnavigationaction.cpp: Removed. 15240 * webkit/webkitnavigationaction.h: Removed. 15241 * webkit/webkitprivate.cpp: 15242 * webkit/webkitprivate.h: 15243 * webkit/webkitwebview.cpp: 15244 * webkit/webkitwebview.h: 15245 152462008-03-20 Jasper Bryant-Greene <jasper@unix.geek.nz> 15247 15248 Reviewed and tweaked by Anders. 15249 15250 Resolves http://bugs.webkit.org/show_bug.cgi?id=16092 15251 "[GTK] Middle-mouse click should allow opening a URL in a new tab" 15252 15253 Created WebKitNavigationAction object exported through the API. The 15254 navigation-requested signal provides this object as context for the 15255 requested navigation, allowing the application to decide what to do 15256 with the navigation based on which mouse button was used, which 15257 modifier keys were held down, etc. This allows, for example, the 15258 application to open links in a new tab when either middle-click or 15259 control-click are used to initiate the navigation. 15260 15261 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15262 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 15263 * webkit/headers.pri: 15264 * webkit/webkit-marshal.list: 15265 * webkit/webkitdefines.h: 15266 * webkit/webkitnavigationaction.cpp: Added. 15267 (webkit_navigation_action_finalize): 15268 (webkit_navigation_action_class_init): 15269 (webkit_navigation_action_init): 15270 (webkit_navigation_action_get_button): 15271 (webkit_navigation_action_get_modifier_flags): 15272 (webkit_navigation_action_get_navigation_type): 15273 (webkit_navigation_action_get_original_url): 15274 * webkit/webkitnavigationaction.h: Added. 15275 * webkit/webkitprivate.cpp: 15276 (WebKit::kit): 15277 * webkit/webkitprivate.h: 15278 * webkit/webkitwebview.cpp: 15279 * webkit/webkitwebview.h: 15280 152812008-03-18 Rodney Dawes <dobey@wayofthemonkey.com> 15282 15283 Reviewed and landed by jhoneycutt. 15284 15285 Update to check if the MIME type is supported by a plugin. 15286 15287 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15288 (FrameLoaderClient::objectContentType): 15289 152902008-03-18 Rodney Dawes <dobey@wayofthemonkey.com> 15291 15292 Reviewed by Jon Honeycutt. 15293 15294 Update setContainingWindow() calls to pass a GtkWidget. 15295 15296 * webkit/webkitwebframe.cpp: 15297 (webkit_web_frame_new): 15298 (webkit_web_frame_init_with_web_view): 15299 153002008-03-13 Rodney Dawes <dobey@wayofthemonkey.com> 15301 15302 Fix GTK+ build for SharedBuffer changes. 15303 15304 * webkit/webkitwebview.cpp: 15305 (webkit_web_view_load_string): 15306 153072008-03-12 Tommi Komulainen <tommi.komulainen@iki.fi> 15308 15309 Reviewed by Alp Toker. 15310 15311 http://bugs.webkit.org/show_bug.cgi?id=17799 15312 WebView signals should use more specific types 15313 15314 * webkit/webkitwebview.cpp: Use WEBKIT_TYPE_WEB_FRAME argument 15315 type in "script-alert", "script-confirm", "script-script-prompt" 15316 signals so that it gets more clearly documented rather than just 15317 plain GObject. 15318 153192008-03-10 Xan Lopez <xan@gnome.org> 15320 15321 Reviewed by Alp Toker. 15322 15323 Fix "missing braces" compiler warning. 15324 15325 * webkit/webkitwebview.cpp: 15326 153272008-03-04 Sam Weinig <sam@webkit.org> 15328 15329 Reviewed by Mark Rowe. 15330 15331 - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including 15332 JSDOMWindow.h 15333 15334 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15335 * webkit/webkitwebframe.cpp: 15336 153372008-03-03 Sam Weinig <sam@webkit.org> 15338 15339 GTK+ build fix. 15340 15341 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15342 (WebKit::FrameLoaderClient::windowObjectCleared): 15343 153442008-03-03 Alp Toker <alp@atoker.com> 15345 15346 Fix the GTK+ build following breakage introduced in r30712. 15347 15348 * WebCoreSupport/EditorClientGtk.cpp: 15349 (WebKit::imContextCommitted): 15350 153512008-03-02 Alp Toker <alp@atoker.com> 15352 15353 Reviewed by Mark Rowe. 15354 15355 Split the WebKit GTK+ build out of the WebCore build and change the 15356 shared object name to match the package name. 15357 15358 * webkit.pc.in: 15359 153602008-02-27 Adam Roben <aroben@apple.com> 15361 15362 Attempt to fix the GTK+ build 15363 15364 * webkit/webkitwebframe.cpp: 15365 153662008-02-24 Darin Adler <darin@apple.com> 15367 15368 Reviewed by Sam. 15369 15370 - remove separate client calls for "standard" and "reload' history 15371 15372 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15373 (WebKit::FrameLoaderClient::updateGlobalHistory): 15374 * WebCoreSupport/FrameLoaderClientGtk.h: 15375 153762008-02-23 Alexey Proskuryakov <ap@webkit.org> 15377 15378 Build fix. 15379 15380 * webkit/webkitprivate.cpp: 15381 (webkit_init): Renamed initializeThreading to initializeThreadingAndMainThread. 15382 153832008-02-18 Alp Toker <alp@atoker.com> 15384 15385 Reviewed by Mark Rowe. 15386 15387 http://bugs.webkit.org/show_bug.cgi?id=17312 15388 [GTK] Webview Transparent Background 15389 15390 Add support for WebView background transparency. 15391 15392 * webkit/webkitprivate.h: 15393 * webkit/webkitwebview.cpp: 15394 * webkit/webkitwebview.h: 15395 153962008-02-18 Alp Toker <alp@atoker.com> 15397 15398 Reviewed by Mark Rowe. 15399 15400 Implement webkit_web_view_get_focused_frame() 15401 15402 Equivalent to selectedFrame in the Mac API. 15403 15404 * webkit/webkitwebview.cpp: 15405 * webkit/webkitwebview.h: 15406 154072008-02-17 Jan Michael Alonzo <jmalonzo@unpluggable.com> 15408 15409 Reviewed by Mark Rowe. 15410 15411 Fix a crash introduced in changeset #29985 by moving the dereference to after 15412 the null check. 15413 15414 * webkit/webkitwebhistoryitem.cpp: 15415 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): 15416 154172008-02-15 Alp Toker <alp@atoker.com> 15418 15419 Fix the GTK+ build following breakage introduced in r30243. 15420 15421 * WebCoreSupport/ChromeClientGtk.cpp: 15422 (WebKit::ChromeClient::mouseDidMoveOverElement): 15423 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15424 (WebKit::FrameLoaderClient::objectContentType): 15425 154262008-02-15 Darin Adler <darin@apple.com> 15427 15428 - another try at fixing the build 15429 15430 * webkit/webkitwebview.cpp: Added some explicit conversions to KURL. 15431 154322008-02-14 Darin Adler <darin@apple.com> 15433 15434 * webkit/webkitwebframe.cpp: Removed DeprecatedString use to try to keep it building. 15435 * webkit/webkitwebview.cpp: Ditto. 15436 154372008-02-14 Holger Hans Peter Freyther <zecke@selfish.org> 15438 15439 Reviewed by Alp. 15440 15441 * Make the handling of the coreFrame consistent. We construct the coreFrame 15442 at the beginning and it will live until the end. Change the g_return_(val_)if 15443 to ASSERTs as having a 0 coreFrame can never happen. 15444 15445 * webkit/webkitwebframe.cpp: 15446 (PrintContext::webkit_web_frame_print): 15447 154482008-02-14 Holger Hans Peter Freyther <zecke@selfish.org> 15449 15450 Reviewed by Alp. 15451 15452 * Make sure that the WebCore::Frame is living as long as the WebKitWebFrame 15453 wrapped around it. All current calls to WebCore::Frame from within the 15454 WebKitWebFrame are safe, even in the case where the WebCore::Frame is already 15455 detached from the WebCore::Page. 15456 * For the mainFrame the WebKitWebView is holding the initial reference and 15457 will unref on destruction. 15458 * For sub-frames the FramerLoaderClientGtk.cpp will do the unrefing when the 15459 frame gets detached from the parent. 15460 * Make sure FrameLoader::detachFromParent gets called by calling FrameLoader::detachChildren 15461 15462 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15463 (WebKit::FrameLoaderClient::detachedFromParent4): 15464 * webkit/webkitprivate.cpp: 15465 (WebKit::core): 15466 * webkit/webkitprivate.h: 15467 * webkit/webkitwebframe.cpp: 15468 * webkit/webkitwebview.cpp: 15469 154702008-02-14 Holger Hans Peter Freyther <zecke@selfish.org> 15471 15472 Reviewed by Alp. 15473 15474 WebCore::Frame is RefCounted, do not manually delete it! 15475 15476 * webkit/webkitwebframe.cpp: 15477 154782008-02-14 Holger Hans Peter Freyther <zecke@selfish.org> 15479 15480 Reviewed by Alp. 15481 15482 * Plug a leak 15483 15484 * webkit/webkitwebframe.cpp: 15485 154862008-02-14 Holger Hans Peter Freyther <zecke@selfish.org> 15487 15488 Reviewed by Alp. 15489 15490 * Update the Copyright Information 15491 15492 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15493 * webkit/webkitprivate.h: 15494 * webkit/webkitwebframe.cpp: 15495 154962008-02-13 Alp Toker <alp@atoker.com> 15497 15498 Reviewed by Adam Roben. 15499 15500 Fix very small, upside down, inside out text on GTK+/DirectFB. 15501 15502 Based on an initial patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> 15503 15504 Test the result of gdk_screen_get_resolution() and use a default 15505 fallback in case of failure. 15506 15507 Also remove an unhelpful runtime warning. 15508 15509 * webkit/webkitwebview.cpp: 15510 155112008-02-08 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk> 15512 15513 Reviewed by Alp Toker. 15514 15515 http://bugs.webkit.org/show_bug.cgi?id=17009 15516 [Gtk] Webkit strips accents from some dead-key combinations 15517 15518 KeyEvents have to go through the gtk input method. 15519 15520 * WebCoreSupport/EditorClientGtk.cpp: 15521 (WebKit::imContextCommitted): 15522 (WebKit::EditorClient::doTextFieldCommandFromEvent): 15523 155242008-02-05 Mark Rowe <mrowe@apple.com> 15525 15526 Reviewed by Alp Toker. 15527 15528 Fix warnings seen on the Gtk port by declaring variables and using constants of the correct types. 15529 15530 * webkit/webkitwebbackforwardlist.cpp: 15531 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_contains_item): 15532 * webkit/webkitwebhistoryitem.cpp: 15533 * webkit/webkitwebview.cpp: 15534 155352008-02-04 Christian Dywan <christian@imendio.com> 15536 15537 Reviewed by Alp Toker. 15538 15539 http://bugs.webkit.org/show_bug.cgi?id=17065 15540 [GTK] Use a consistent coding style 15541 15542 * WebCoreSupport/EditorClientGtk.cpp: 15543 (WebKit::imContextCommitted): 15544 (WebKit::EditorClient::EditorClient): 15545 (WebKit::EditorClient::~EditorClient): 15546 (WebKit::EditorClient::textFieldDidEndEditing): 15547 * webkit/webkitdefines.h: 15548 * webkit/webkitnetworkrequest.cpp: 15549 (_WebKitNetworkRequestPrivate::webkit_network_request_finalize): 15550 (_WebKitNetworkRequestPrivate::webkit_network_request_class_init): 15551 (_WebKitNetworkRequestPrivate::webkit_network_request_init): 15552 (_WebKitNetworkRequestPrivate::webkit_network_request_new): 15553 (_WebKitNetworkRequestPrivate::webkit_network_request_set_uri): 15554 (_WebKitNetworkRequestPrivate::webkit_network_request_get_uri): 15555 * webkit/webkitnetworkrequest.h: 15556 * webkit/webkitprivate.cpp: 15557 (WebKit::getViewFromFrame): 15558 (WebKit::core): 15559 * webkit/webkitprivate.h: 15560 * webkit/webkitwebbackforwardlist.cpp: 15561 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_new_with_web_view): 15562 * webkit/webkitwebbackforwardlist.h: 15563 * webkit/webkitwebframe.cpp: 15564 * webkit/webkitwebframe.h: 15565 * webkit/webkitwebhistoryitem.cpp: 15566 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): 15567 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_finalize): 15568 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): 15569 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): 15570 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): 15571 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title): 15572 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title): 15573 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title): 15574 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri): 15575 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri): 15576 (WebKit::core): 15577 * webkit/webkitwebhistoryitem.h: 15578 * webkit/webkitwebsettings.h: 15579 * webkit/webkitwebview.cpp: 15580 * webkit/webkitwebview.h: 15581 155822008-02-04 Alp Toker <alp@atoker.com> 15583 15584 Rubber-stamped by Mark Rowe. 15585 15586 Remove all trailing whitespace in the GTK+ port and related 15587 components. 15588 15589 * WebCoreSupport/DragClientGtk.h: 15590 * WebCoreSupport/FrameLoaderClientGtk.h: 15591 * WebCoreSupport/InspectorClientGtk.h: 15592 * WebCoreSupport/PasteboardHelperGtk.h: 15593 * webkit/webkitprivate.h: 15594 * webkit/webkitwebbackforwardlist.cpp: 15595 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_contains_item): 15596 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): 15597 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_item): 15598 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_length): 15599 * webkit/webkitwebhistoryitem.cpp: 15600 (_WebKitWebHistoryItemPrivate::webkit_history_items): 15601 (_WebKitWebHistoryItemPrivate::webkit_history_item_add): 15602 (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): 15603 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): 15604 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): 15605 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title): 15606 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title): 15607 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title): 15608 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri): 15609 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time): 15610 (WebKit::kit): 15611 * webkit/webkitwebhistoryitem.h: 15612 * webkit/webkitwebview.cpp: 15613 * webkit/webkitwebview.h: 15614 156152008-02-03 Christian Dywan <christian@imendio.com> 15616 15617 Reviewed by Alp Toker. 15618 15619 http://bugs.webkit.org/show_bug.cgi?id=17046 15620 [GTK] Context menu fixes and customisation suport 15621 15622 * webkit/webkitwebview.cpp: 15623 156242008-01-31 Alp Toker <alp@atoker.com> 15625 15626 Reviewed by Mark Rowe. 15627 15628 Fix the pkg-config file to follow GTK+ package naming and versioning 15629 conventions. 15630 15631 Remove unneeded dependency listings. 15632 15633 * WebKitGtk.pc.in: Removed. 15634 * webkit.pc.in: Copied from WebKit/gtk/WebKitGtk.pc.in. 15635 156362008-01-31 Alp Toker <alp@atoker.com> 15637 15638 Rubber-stamped by Adam Roben. 15639 15640 http://bugs.webkit.org/show_bug.cgi?id=17006 15641 [GTK] Header path should be webkit/webkit.h 15642 15643 Move the GTK+ API sources as needed and update the build systems. 15644 15645 * WebView: Removed. 15646 * WebView/headers.pri: Removed. 15647 * WebView/webkit-marshal.list: Removed. 15648 * WebView/webkit.h: Removed. 15649 * WebView/webkitdefines.h: Removed. 15650 * WebView/webkitnetworkrequest.cpp: Removed. 15651 * WebView/webkitnetworkrequest.h: Removed. 15652 * WebView/webkitprivate.cpp: Removed. 15653 * WebView/webkitprivate.h: Removed. 15654 * WebView/webkitwebbackforwardlist.cpp: Removed. 15655 * WebView/webkitwebbackforwardlist.h: Removed. 15656 * WebView/webkitwebframe.cpp: Removed. 15657 * WebView/webkitwebframe.h: Removed. 15658 * WebView/webkitwebhistoryitem.cpp: Removed. 15659 * WebView/webkitwebhistoryitem.h: Removed. 15660 * WebView/webkitwebsettings.cpp: Removed. 15661 * WebView/webkitwebsettings.h: Removed. 15662 * WebView/webkitwebview.cpp: Removed. 15663 * WebView/webkitwebview.h: Removed. 15664 * webkit: Copied from WebKit/gtk/WebView. 15665 * webkit/webkit.h: 15666 * webkit/webkitnetworkrequest.h: 15667 * webkit/webkitprivate.h: 15668 * webkit/webkitwebbackforwardlist.h: 15669 * webkit/webkitwebframe.h: 15670 * webkit/webkitwebhistoryitem.h: 15671 * webkit/webkitwebsettings.h: 15672 * webkit/webkitwebview.h: 15673 156742008-01-27 Jan Michael Alonzo <jmalonzo@unpluggable.com> 15675 15676 Reviewed by Alp Toker. 15677 15678 http://bugs.webkit.org/show_bug.cgi?id=14811 15679 [gtk] [request] add a webkit_gtk_page_go_to_history_item function 15680 15681 implement back/forward list and history item 15682 15683 * WebView/headers.pri: 15684 * WebView/webkit.h: 15685 * WebView/webkitprivate.cpp: 15686 * WebView/webkitprivate.h: 15687 * WebView/webkitwebbackforwardlist.cpp: Added. 15688 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_dispose): 15689 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_class_init): 15690 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_init): 15691 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_new_with_web_view): 15692 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_go_forward): 15693 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_go_back): 15694 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_contains_item): 15695 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_go_to_item): 15696 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): 15697 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit): 15698 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_item): 15699 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_current_item): 15700 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_item): 15701 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_nth_item): 15702 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_length): 15703 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_length): 15704 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_limit): 15705 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_set_limit): 15706 * WebView/webkitwebbackforwardlist.h: Added. 15707 * WebView/webkitwebhistoryitem.cpp: Added. 15708 (_WebKitWebHistoryItemPrivate::webkit_history_items): 15709 (_WebKitWebHistoryItemPrivate::webkit_history_item_add): 15710 (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): 15711 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose): 15712 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_finalize): 15713 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init): 15714 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_init): 15715 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): 15716 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): 15717 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): 15718 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title): 15719 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title): 15720 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title): 15721 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri): 15722 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri): 15723 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time): 15724 (WebKit::core): 15725 (WebKit::kit): 15726 * WebView/webkitwebhistoryitem.h: Added. 15727 * WebView/webkitwebview.cpp: 15728 * WebView/webkitwebview.h: 15729 157302008-01-25 Ori Bernstein <ori@eigenstate.org> 15731 15732 Reviewed by Alp Toker. 15733 15734 http://bugs.webkit.org/show_bug.cgi?id=16795 15735 WebKitGtk crashes when there is no focused Frame 15736 15737 Add a null check. focusedFrame() isn't used directly anywhere else so 15738 this is the only case that needs to be fixed. 15739 15740 * WebView/webkitwebview.cpp: 15741 157422008-01-22 Christian Dywan <christian@imendio.com> 15743 15744 Reviewed by Alp Toker. 15745 15746 [GTK] API: WebKitWebSettings is not usable 15747 http://bugs.webkit.org/show_bug.cgi?id=16219 15748 15749 Implement WebKitWebSettings. 15750 15751 * WebView/headers.pri: 15752 * WebView/webkit.h: 15753 * WebView/webkitprivate.cpp: 15754 * WebView/webkitprivate.h: 15755 * WebView/webkitsettings.cpp: Removed. 15756 * WebView/webkitsettings.h: Removed. 15757 * WebView/webkitwebsettings.cpp: Added. 15758 * WebView/webkitwebsettings.h: Added. 15759 * WebView/webkitwebview.cpp: 15760 * WebView/webkitwebview.h: 15761 157622008-01-21 Alp Toker <alp@atoker.com> 15763 15764 GTK+ build fix for breakage introduced in r29698. 15765 15766 * WebCoreSupport/ChromeClientGtk.h: 15767 157682008-01-21 Darin Adler <darin@apple.com> 15769 15770 Reviewed by John Sullivan. 15771 15772 - updated for changes to database functions 15773 15774 * WebCoreSupport/ChromeClientGtk.cpp: 15775 (WebKit::ChromeClient::exceededDatabaseQuota): 15776 * WebCoreSupport/ChromeClientGtk.h: 15777 * WebView/webkitprivate.cpp: 15778 (webkit_init): 15779 157802008-01-20 Alp Toker <alp@atoker.com> 15781 15782 Reviewed by Mark Rowe. 15783 15784 Attach the widget's style to its window and set the background to the 15785 base background to avoid black flicker when repainting. This is 15786 similar to what GtkTextView does. 15787 15788 * WebView/webkitwebview.cpp: 15789 157902008-01-19 Christian Dywan <christian@imendio.com> 15791 15792 Reviewed by Alp Toker. 15793 15794 http://bugs.webkit.org/show_bug.cgi?id=16882 15795 [GTK] ChromeClientGtk is incompete 15796 15797 Implement these functions. 15798 15799 * WebCoreSupport/ChromeClientGtk.cpp: 15800 (WebKit::ChromeClient::windowRect): 15801 (WebKit::ChromeClient::pageRect): 15802 (WebKit::ChromeClient::scaleFactor): 15803 (WebKit::ChromeClient::focus): 15804 (WebKit::ChromeClient::unfocus): 15805 (WebKit::ChromeClient::canTakeFocus): 15806 (WebKit::ChromeClient::takeFocus): 15807 (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel): 15808 158092008-01-18 Luca Bruno <lethalman88@gmail.com> 15810 15811 Reviewed by Alp Toker. 15812 15813 http://bugs.webkit.org/show_bug.cgi?id=16910 15814 [GTK] REGRESSION: keyboard cursor doesn't blink 15815 15816 http://bugs.webkit.org/show_bug.cgi?id=16863 15817 [GTK] REGRESSION: tab focusing doesn't work 15818 15819 * WebView/webkitwebview.cpp: 15820 (webkit_web_view_focus_in_event): Added. Set the active frame. 15821 (webkit_web_view_class_init): 15822 158232008-01-16 Alp Toker <alp@atoker.com> 15824 15825 Reviewed by Mark Rowe. 15826 15827 http://bugs.webkit.org/show_bug.cgi?id=16218 15828 [GTK] API: Should this entry point be called go_back rather than go_backward? 15829 15830 Obsolete 'backward' terminology in API in favour of 'back'. Introduce 15831 step-based back/forward functions. 15832 15833 Document more functions. 15834 15835 * WebView/webkitdefines.h: 15836 * WebView/webkitwebview.cpp: 15837 * WebView/webkitwebview.h: 15838 158392008-01-10 Maciej Stachowiak <mjs@apple.com> 15840 15841 Reviewed by Sam. 15842 15843 - remove SecurityOriginData and fold its functionality into SecurityOrigin 15844 15845 * WebCoreSupport/ChromeClientGtk.cpp: 15846 (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase): 15847 (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation): 15848 * WebCoreSupport/ChromeClientGtk.h: 15849 158502008-01-09 Luca Bruno <lethalman88@gmail.com> 15851 15852 Reviewed by Alp Toker. 15853 15854 http://bugs.webkit.org/show_bug.cgi?id=16802 15855 [GTK] Missing gtk properties 15856 15857 Add missing properties to WebKitViewFrame and WebKitWebView. 15858 15859 * WebView/webkitprivate.h: add some useful defines for param specs 15860 * WebView/webkitwebframe.cpp: 15861 (webkit_web_frame_get_property): added 15862 (webkit_web_frame_class_init): add name, title and uri read-only properties 15863 * WebView/webkitwebview.cpp: 15864 (webkit_web_view_get_property): add editable property read 15865 (webkit_web_view_set_property): added for editable property write 15866 (webkit_web_view_class_init): add read-write editable property 15867 158682008-01-03 Xan Lopez <xan@gnome.org> 15869 15870 Reviewed by Alp Toker. 15871 15872 http://bugs.webkit.org/show_bug.cgi?id=16654 15873 [GTK] Signal "navigation-requested" does not react correctly on 15874 return TRUE from callbacks 15875 15876 * WebView/webkitwebview.cpp: use our own accumulator for signals 15877 returning WebKitNavigationResponse. The emission will be stopped 15878 when any callback returns anything but 15879 WEBKIT_NAVIGATION_RESPONSE_ACCEPT. 15880 158812008-01-02 Holger Hans Peter Freyther <zecke@selfish.org> 15882 15883 Rubber stamped by Darin Adler. 15884 15885 Coding Style fix. Do not use an else because we use a return in the 15886 if branch. 15887 15888 * WebView/webkitwebview.cpp: 15889 158902008-01-02 Luca Bruno <lethalman88@gmail.com> 15891 15892 Reviewed by Alp Toker. 15893 15894 http://bugs.webkit.org/show_bug.cgi?id=16115 15895 [GTK] ContextMenu and ContextMenuItem lacks an implementation 15896 15897 Add context menu support. 15898 15899 Based on a patch by Holger Freyther. 15900 15901 * WebCoreSupport/ContextMenuClientGtk.cpp: 15902 (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): 15903 * WebView/webkitprivate.h: 15904 * WebView/webkitwebview.cpp: 15905 159062007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com> 15907 15908 Reviewed by Alp Toker. 15909 15910 http://bugs.webkit.org/show_bug.cgi?id=16669 15911 autotools update and fixes 15912 15913 pkgconfig file and icon database inclusion fix 15914 15915 * WebKitGtk.pc.in: Remove ICU_FLAGS from Cflags 15916 * WebView/webkitprivate.cpp: Guard ICONDATABASE inclusions 15917 159182007-12-28 Christian Dywan <christian@twotoasts.de> 15919 15920 Reviewed by Alp Toker. 15921 15922 http://bugs.webkit.org/show_bug.cgi?id=16642 15923 [GTK] webkit_web_view_has_selection returns the opposite result 15924 15925 Invert the return value. 15926 15927 * WebView/webkitwebview.cpp: 15928 159292007-12-26 Jan Michael Alonzo <jmalonzo@unpluggable.com> 15930 15931 Reviewed by Alp Toker. 15932 15933 http://bugs.webkit.org/show_bug.cgi?id=16390 15934 Use autotools or GNU make as the build system for the GTK port 15935 15936 * WebKitGtk.pc.in: Added. 15937 159382007-12-24 Christian Dywan <christian@twotoasts.de> 15939 15940 Reviewed by Alp Toker. 15941 15942 http://bugs.webkit.org/attachment.cgi?id=18099 15943 There are no NULL checks for strings in public api 15944 15945 Add missing NULL checks for string parameters. 15946 15947 Provide sensible defaults when NULL is passed for the optional 15948 parameters in webkit_web_view_load_string(). UTF-8 is the default 15949 encoding used by GLib and text/html is a reasonable default content 15950 type. 15951 15952 * WebView/webkitnetworkrequest.cpp: 15953 * WebView/webkitwebview.cpp: 15954 159552007-12-22 Xan Lopez <xan@gnome.org> 15956 15957 Reviewed by Alp Toker. 15958 15959 Use webView, web_view, etc for variable names instead of page, which 15960 was left over from the old API. 15961 15962 * WebCoreSupport/EditorClientGtk.cpp: 15963 (WebKit::imContextCommitted): 15964 (WebKit::EditorClient::EditorClient): 15965 (WebKit::EditorClient::~EditorClient): 15966 (WebKit::EditorClient::textFieldDidBeginEditing): 15967 (WebKit::EditorClient::textFieldDidEndEditing): 15968 * WebCoreSupport/EditorClientGtk.h: 15969 * WebCoreSupport/FrameLoaderClientGtk.cpp: 15970 (WebKit::FrameLoaderClient::postProgressStartedNotification): 15971 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): 15972 (WebKit::FrameLoaderClient::postProgressFinishedNotification): 15973 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 15974 (WebKit::FrameLoaderClient::windowObjectCleared): 15975 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon): 15976 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): 15977 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): 15978 159792007-12-22 Alp Toker <alp@atoker.com> 15980 15981 GTK+ build fix 15982 15983 GTK_TARGET_OTHER_APP is not available in older GTK+ versions. Pass 15984 empty target flags for now. 15985 15986 Check GTK+, not GLib versions, since they are different. 15987 15988 * WebView/webkitwebview.cpp: 15989 159902007-12-22 Luca Bruno <lethalman88@gmail.com> 15991 15992 Reviewed by Alp Toker. 15993 15994 http://bugs.webkit.org/show_bug.cgi?id=16311 15995 [Gtk] Copy rich text to clipboard as text/plain and text/html. 15996 15997 Add copy and paste targets for WebView and implement 15998 WebCore::PasteboardHelper. 15999 16000 * WebCoreSupport/PasteboardHelperGtk.cpp: Added. 16001 (WebKit::PasteboardHelperGtk::getClipboard): 16002 (WebKit::PasteboardHelperGtk::getCopyTargetList): 16003 (WebKit::PasteboardHelperGtk::getPasteTargetList): 16004 * WebCoreSupport/PasteboardHelperGtk.h: Added. 16005 * WebView/webkitprivate.cpp: 16006 (webkit_init): set the PasteboardHelperGtk as WebCore::Pasteboard helper 16007 * WebView/webkitprivate.h: 16008 (_WebKitWebViewPrivate::copy_target_list): added 16009 (_WebKitWebViewPrivate::paste_target_list): added 16010 * WebView/webkitwebview.cpp: 16011 (webkit_web_view_get_property): added 16012 (webkit_web_view_finalize): 16013 (webkit_web_view_class_init): create properties for COPY_TARGET and PASTE_TARGET and create the copy and paste target lists 16014 (webkit_web_view_get_copy_target_list): added 16015 (webkit_web_view_get_paste_target_list): added 16016 * WebView/webkitwebview.h: 16017 (webkit_web_view_get_copy_target_list): added 16018 (webkit_web_view_get_paste_target_list): added 16019 160202007-12-22 Xan Lopez <xan@gnome.org> 16021 16022 Reviewed by Alp Toker. 16023 16024 Follow up to http://bugs.webkit.org/show_bug.cgi?id=16144 16025 16026 * WebView/webkitwebview.cpp: 16027 Fix signal id arguments for g_signal_emit in 16028 clipboard functions. 16029 160302007-12-21 Alp Toker <alp@atoker.com> 16031 16032 Documentation typo fix: s/wether/whether 16033 16034 * WebView/webkitwebview.cpp: 16035 160362007-12-21 Christian Dywan <christian@twotoasts.de> 16037 16038 Reviewed by Alp Toker. 16039 16040 http://bugs.webkit.org/show_bug.cgi?id=16144 16041 [GTK] Clipboard/ selection handling functions 16042 16043 * WebView/webkitprivate.h: 16044 * WebView/webkitwebview.cpp: 16045 * WebView/webkitwebview.h: 16046 160472007-12-19 Christian Dywan <christian@twotoasts.de> 16048 16049 Reviewed by Alp Toker. 16050 16051 http://bugs.webkit.org/show_bug.cgi?id=16222 16052 [GTK] Implement inline search and highlighting of matching strings. 16053 16054 * WebView/webkitwebview.cpp: 16055 * WebView/webkitwebview.h: 16056 160572007-12-19 Alp Toker <alp@atoker.com> 16058 16059 Reviewed by Holger Freyther. 16060 16061 Delete when Destroy functions are called to avoid leaks 16062 16063 This matches the Mac port. 16064 16065 * WebCoreSupport/ChromeClientGtk.cpp: 16066 * WebCoreSupport/ContextMenuClientGtk.cpp: 16067 * WebCoreSupport/InspectorClientGtk.cpp: 16068 160692007-12-14 Juan A. Suarez Romero <jasuarez@igalia.com> 16070 16071 Reviewed by Alp Toker. 16072 16073 http://bugs.webkit.org/show_bug.cgi?id=16042 16074 [GTK] Eliminate webkit_init() 16075 16076 Move webkit initialization to WebView class init. 16077 16078 * WebView/headers.pri: 16079 * WebView/webkit.h: 16080 * WebView/webkitglobal.cpp: Removed. 16081 * WebView/webkitglobal.h: Removed. 16082 * WebView/webkitprivate.cpp: 16083 (WebKit::webkit_init): 16084 * WebView/webkitprivate.h: 16085 * WebView/webkitwebframe.cpp: 16086 * WebView/webkitwebview.cpp: 16087 160882007-12-17 Luca Bruno <lethalman88@gmail.com> 16089 16090 Reviewed by Alp Toker. 16091 16092 http://bugs.webkit.org/show_bug.cgi?id=13542 16093 gdklauncher doesnt change URL in adress GTKEntry. 16094 16095 Let DOMDocument observers do their work before emitting title-changed. 16096 The load-committed signal has been added for both the view and the frame. 16097 16098 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16099 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): emit title-changed 16100 (WebKit::FrameLoaderClient::setTitle): set private title 16101 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): update the frame uri and emit load-committed 16102 * WebView/webkit-marshal.list: 16103 * WebView/webkitprivate.h: 16104 (_WebKitWebFramePrivate): rename location to uri 16105 * WebView/webkitwebframe.cpp: 16106 (webkit_web_frame_get_location): renamed to *_get_uri 16107 (webkit_web_frame_get_uri): 16108 (webkit_web_frame_real_title_changed): removed (see FrameLoaderClient::setTitle) 16109 (webkit_web_frame_class_init): pass the frame and the title in title-changed, not the uri 16110 (webkit_web_frame_finalize): 16111 * WebView/webkitwebframe.h: 16112 (_WebKitWebFrameClass): removed title_changed 16113 * WebView/webkitwebview.cpp: 16114 (webkit_web_view_class_init): pass only the title in title-changed 16115 161162007-12-14 Alp Toker <alp@atoker.com> 16117 16118 Fix inconsistent indentation in the license header. Maciej was right! 16119 16120 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16121 161222007-12-14 Alp Toker <alp@atoker.com> 16123 16124 Reviewed by Maciej. 16125 16126 http://bugs.webkit.org/show_bug.cgi?id=16432 16127 [GTK] Update license headers 16128 16129 Consent has been given by the authors of these files to change license 16130 to the LGPL as outlined in the bug report. 16131 16132 * WebCoreSupport/ChromeClientGtk.cpp: 16133 * WebCoreSupport/ContextMenuClientGtk.cpp: 16134 * WebCoreSupport/DragClientGtk.cpp: 16135 * WebCoreSupport/EditorClientGtk.cpp: 16136 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16137 (WebKit::FrameLoaderClient::makeRepresentation): 16138 (WebKit::FrameLoaderClient::forceLayout): 16139 (WebKit::FrameLoaderClient::forceLayoutForNonHTML): 16140 (WebKit::FrameLoaderClient::setCopiesOnScroll): 16141 (WebKit::FrameLoaderClient::detachedFromParent1): 16142 (WebKit::FrameLoaderClient::detachedFromParent2): 16143 (WebKit::FrameLoaderClient::detachedFromParent3): 16144 (WebKit::FrameLoaderClient::detachedFromParent4): 16145 (WebKit::FrameLoaderClient::loadedFromCachedPage): 16146 (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents): 16147 (WebKit::FrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): 16148 (WebKit::FrameLoaderClient::dispatchDidCancelClientRedirect): 16149 (WebKit::FrameLoaderClient::dispatchWillPerformClientRedirect): 16150 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): 16151 (WebKit::FrameLoaderClient::dispatchWillClose): 16152 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): 16153 (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad): 16154 (WebKit::FrameLoaderClient::dispatchDidFirstLayout): 16155 (WebKit::FrameLoaderClient::dispatchShow): 16156 (WebKit::FrameLoaderClient::cancelPolicyCheck): 16157 (WebKit::FrameLoaderClient::dispatchDidLoadMainResource): 16158 (WebKit::FrameLoaderClient::revertToProvisionalState): 16159 (WebKit::FrameLoaderClient::clearUnarchivingState): 16160 (WebKit::FrameLoaderClient::willChangeTitle): 16161 (WebKit::FrameLoaderClient::didChangeTitle): 16162 (WebKit::FrameLoaderClient::finalSetupForReplace): 16163 (WebKit::FrameLoaderClient::setDefersLoading): 16164 (WebKit::FrameLoaderClient::isArchiveLoadPending): 16165 (WebKit::FrameLoaderClient::cancelPendingArchiveLoad): 16166 (WebKit::FrameLoaderClient::clearArchivedResources): 16167 (WebKit::FrameLoaderClient::canHandleRequest): 16168 (WebKit::FrameLoaderClient::canShowMIMEType): 16169 (WebKit::FrameLoaderClient::representationExistsForURLScheme): 16170 (WebKit::FrameLoaderClient::generatedMIMETypeForURLScheme): 16171 (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength): 16172 (WebKit::FrameLoaderClient::dispatchDidFinishLoading): 16173 (WebKit::FrameLoaderClient::dispatchDidFailLoading): 16174 (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): 16175 (WebKit::FrameLoaderClient::download): 16176 (WebKit::FrameLoaderClient::cancelledError): 16177 (WebKit::FrameLoaderClient::blockedError): 16178 (WebKit::FrameLoaderClient::cannotShowURLError): 16179 (WebKit::FrameLoaderClient::interruptForPolicyChangeError): 16180 (WebKit::FrameLoaderClient::cannotShowMIMETypeError): 16181 (WebKit::FrameLoaderClient::fileDoesNotExistError): 16182 (WebKit::FrameLoaderClient::shouldFallBack): 16183 (WebKit::FrameLoaderClient::willUseArchive): 16184 (WebKit::FrameLoaderClient::canCachePage): 16185 (WebKit::FrameLoaderClient::dispatchCreatePage): 16186 (WebKit::FrameLoaderClient::dispatchUnableToImplementPolicy): 16187 (WebKit::FrameLoaderClient::setMainDocumentError): 16188 (WebKit::FrameLoaderClient::startDownload): 16189 (WebKit::FrameLoaderClient::updateGlobalHistoryForStandardLoad): 16190 (WebKit::FrameLoaderClient::updateGlobalHistoryForReload): 16191 (WebKit::FrameLoaderClient::savePlatformDataToCachedPage): 16192 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage): 16193 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 16194 * WebCoreSupport/InspectorClientGtk.cpp: 16195 * WebView/webkitwebview.cpp: 16196 161972007-12-14 Darin Adler <darin@apple.com> 16198 16199 Reviewed by Alexey. 16200 16201 * WebCoreSupport/EditorClientGtk.cpp: 16202 (WebKit::EditorClient::handleKeyboardEvent): Changed to use Editor::command 16203 instead of Editor::execCommand. 16204 * WebView/webkitwebview.cpp: Ditto. 16205 162062007-12-12 Brady Eidson <beidson@apple.com> 16207 16208 Reviewed by Sam Weinig 16209 16210 As part of doing some CachedPage and client cleanup, keep GTK building 16211 16212 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16213 (WebKit::FrameLoaderClient::savePlatformDataToCachedPage): 16214 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage): 16215 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage): 16216 * WebCoreSupport/FrameLoaderClientGtk.h: 16217 162182007-12-12 Alp Toker <alp@atoker.com> 16219 16220 Reviewed by Holger Freyther. 16221 16222 http://bugs.webkit.org/show_bug.cgi?id=15576 16223 [GTK] Printing support 16224 16225 Add printing support. 16226 16227 The API will be kept internal for the time being, but printing can now 16228 be triggered by Web pages or the JSC API using JavaScript. 16229 16230 The print spooler and pagination code is fairly abstract and could be 16231 shared by other ports including Win and Qt once complete. It doesn't 16232 have header/footer support yet. 16233 16234 * WebCoreSupport/ChromeClientGtk.cpp: 16235 (WebKit::ChromeClient::print): 16236 * WebView/webkitprivate.h: 16237 * WebView/webkitwebframe.cpp: 16238 (PrintContext::begin_print): 16239 (PrintContext::draw_page): 16240 (PrintContext::end_print): 16241 (PrintContext::webkit_web_frame_print): 16242 162432007-12-12 Sam Weinig <sam@webkit.org> 16244 16245 Build fix. 16246 16247 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16248 (WebKit::FrameLoaderClient::didChangeTitle): 16249 162502007-12-12 Sam Weinig <sam@webkit.org> 16251 16252 Build fix. 16253 16254 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16255 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 16256 162572007-12-11 George Wright <george.wright@collabora.co.uk> 16258 16259 Reviewed by Alp Toker. 16260 16261 http://bugs.webkit.org/show_bug.cgi?id=14120 16262 [GDK] Support input methods 16263 16264 This patch adds infrastructure for input method support. 16265 16266 It also adds Hildon features for the Maemo mobile platform sufficient 16267 to support the virtual keyboard. 16268 16269 * WebCoreSupport/EditorClientGtk.cpp: 16270 (WebKit::imContextCommitted): 16271 (WebKit::EditorClient::EditorClient): 16272 (WebKit::EditorClient::~EditorClient): 16273 (WebKit::EditorClient::textFieldDidBeginEditing): 16274 (WebKit::EditorClient::textFieldDidEndEditing): 16275 * WebCoreSupport/EditorClientGtk.h: 16276 * WebView/webkitprivate.h: 16277 * WebView/webkitwebview.cpp: 16278 162792007-12-07 Alexey Proskuryakov <ap@webkit.org> 16280 16281 Reviewed by Darin Adler. 16282 16283 <rdar://problem/5535636> 16284 Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard. 16285 16286 http://bugs.webkit.org/show_bug.cgi?id=13916 16287 JavaScript detects Tab as a character input on a textfield validation 16288 16289 * WebCoreSupport/EditorClientGtk.cpp: 16290 (WebKit::EditorClient::handleKeyboardEvent): 16291 (WebKit::EditorClient::handleInputMethodKeydown): 16292 * WebCoreSupport/EditorClientGtk.h: 16293 Updated for cross-platform changes as much as it was possible without a gtk build environment. 16294 162952007-12-08 Luca Bruno <lethalman88@gmail.com> 16296 16297 Reviewed by Alp Toker. 16298 16299 http://bugs.webkit.org/show_bug.cgi?id=16346 16300 [GTK] Some webview parts must use the focused frame. 16301 16302 Also update some old code. 16303 16304 * WebView/webkitprivate.cpp: 16305 (getFrameFromView): removed 16306 16307 * WebView/webkitprivate.h: 16308 (getFrameFromView): removed 16309 16310 * WebView/webkitwebview.cpp: 16311 (webkit_web_view_expose_event): 16312 (webkit_web_view_key_press_event): use focused frame 16313 (webkit_web_view_key_release_event): use focused frame 16314 (webkit_web_view_button_press_event): 16315 (webkit_web_view_button_release_event): 16316 (webkit_web_view_motion_event): 16317 (webkit_web_view_scroll_event): 16318 (webkit_web_view_size_allocate): 16319 (webkit_web_view_set_scroll_adjustments): 16320 (webkit_web_view_execute_script): 16321 (webkit_web_view_stop_loading): 16322 (webkit_web_view_load_string): 16323 (webkit_web_view_reload): 16324 (webkit_web_view_open): 16325 (webkit_web_view_can_go_forward): 16326 (webkit_web_view_can_go_backward): 16327 (webkit_web_view_go_forward): 16328 (webkit_web_view_go_backward): 16329 16330 * WebCoreSupport/EditorClientGtk.cpp: 16331 (WebKit::EditorClient::handleKeypress): fix for page up and page down keys for editable contents 16332 163332007-12-07 Luca Bruno <lethalman88@gmail.com> 16334 16335 Reviewed by Alp Toker. 16336 16337 http://bugs.webkit.org/show_bug.cgi?id=16333 16338 [GTK] Key bindings must work with focused frames. 16339 16340 There are still more cases where getFrameFromView() is mis-used that 16341 need to be fixed, but this is a good start. 16342 16343 * WebView/webkitwebview.cpp: 16344 (webkit_web_view_real_select_all): 16345 (webkit_web_view_real_cut_clipboard): 16346 (webkit_web_view_real_copy_clipboard): 16347 (webkit_web_view_real_paste_clipboard): 16348 163492007-12-06 Xan Lopez <xan@gnome.org> 16350 16351 Reviewed by Alp Toker. 16352 16353 http://bugs.webkit.org/show_bug.cgi?id=16329 16354 [GTK] Two small cleanups 16355 16356 * WebCoreSupport/ChromeClientGtk.cpp: 16357 (WebKit::ChromeClient::createWindow): 16358 (WebKit::ChromeClient::addMessageToConsole): 16359 (WebKit::ChromeClient::runJavaScriptAlert): 16360 (WebKit::ChromeClient::runJavaScriptConfirm): 16361 (WebKit::ChromeClient::runJavaScriptPrompt): 16362 (WebKit::ChromeClient::setStatusbarText): 16363 (WebKit::ChromeClient::mouseDidMoveOverElement): 16364 (WebKit::ChromeClient::setToolTip): 16365 * WebCoreSupport/ChromeClientGtk.h: 16366 * WebView/webkitprivate.cpp: 16367 (WebKit::kit): 16368 s/m_webPage/m_webView/ 16369 * WebView/webkitwebview.cpp: 16370 Chain up to the parent class to activate bindings instead 16371 of doing it explicitely. 16372 163732007-12-06 Holger Hans Peter Freyther <holger.freyther@trolltech.com> 16374 16375 Reviewed by Alp Toker. 16376 16377 http://bugs.webkit.org/show_bug.cgi?id=16173 16378 Licensing change 16379 16380 Change license from BSD to LGPL. 16381 16382 * WebCoreSupport/ChromeClientGtk.h: 16383 * WebView/webkitdefines.h: 16384 * WebView/webkitglobal.cpp: 16385 * WebView/webkitglobal.h: 16386 * WebView/webkitnetworkrequest.cpp: 16387 * WebView/webkitnetworkrequest.h: 16388 * WebView/webkitprivate.cpp: 16389 * WebView/webkitprivate.h: 16390 * WebView/webkitsettings.cpp: 16391 * WebView/webkitsettings.h: 16392 * WebView/webkitwebframe.cpp: 16393 * WebView/webkitwebframe.h: 16394 * WebView/webkitwebview.h: 16395 163962007-12-05 Michael Natterer <mitch@imendio.com> 16397 16398 Reviewed by Alp Toker. 16399 16400 * WebView/webkitwebview.cpp: split key and button event handlers 16401 into separate press and release functions. 16402 164032007-12-05 Luca Bruno <lethalman88@gmail.com> 16404 16405 Reviewed by Alp Toker. 16406 16407 Handle events for Home and End keys. 16408 16409 * WebView/webkitwebview.cpp: 16410 (webkit_web_view_key_event): 16411 * WebCoreSupport/EditorClientGtk.cpp: 16412 (EditorClient::handleKeypress): 16413 164142007-12-05 Michael Natterer <mitch@imendio.com> 16415 16416 Reviewed by Alp Toker. 16417 16418 * WebView/webkitwebview.cpp 16419 * WebCoreSupport/ChromeClientGtk.cpp 16420 * WebCoreSupport/FrameLoaderClientGtk.cpp: canonicalize signal names. 16421 164222007-12-04 Darin Adler <darin@apple.com> 16423 16424 Reviewed by Kevin Decker. 16425 16426 * WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled. 16427 * WebCoreSupport/FrameLoaderClientGtk.h: Ditto. 16428 164292007-12-04 Michael Natterer <mitch@imendio.com> 16430 16431 Reviewed by Alp Toker. 16432 16433 * WebView/webkitwebframe.cpp: don't redeclare the marshaller 16434 prototype but simply include "webkit-marshal.h" now that its build 16435 is fixed. 16436 164372007-12-04 Luca Bruno <lethalman88@gmail.com> 16438 16439 Reviewed by Alp Toker. 16440 16441 Fix a regression in key press propagation in r28386. 16442 16443 Fix indentation (was off by two spaces). 16444 16445 * WebView/webkitwebview.cpp: 16446 164472007-12-04 Luca Bruno <lethalman88@gmail.com> 16448 16449 Reviewed by Alp Toker. 16450 16451 http://bugs.webkit.org/show_bug.cgi?id=15911 16452 [GTK] Use GtkBindingSet to make key bindings user-configurable 16453 16454 This patch doesn't cover the full range of bindings, only the ones 16455 that seem obviously correct and have clear public API. 16456 16457 * WebCoreSupport/EditorClientGtk.cpp: 16458 (WebKit::EditorClient::handleKeypress): do not handle clipboard operations and select-all 16459 * WebView/webkitwebview.cpp: add cut, copy, paste and select-all signals and allow binding sets (issue #15911 and #16144) 16460 * WebView/webkitwebview.h: 16461 164622007-12-04 Xan Lopez <xan@gnome.org> 16463 16464 Reviewed by Alp Toker. 16465 16466 http://bugs.webkit.org/show_bug.cgi?id=15561 16467 GTK port needs DumpRenderTree implementation 16468 16469 Start work on the GTK+ DRT. 16470 16471 Add a couple of proposed new API entry points. They are currently for 16472 internal use only by DRT and not in the public headers. 16473 16474 * WebView/webkitprivate.h: 16475 * WebView/webkitwebframe.cpp: 16476 164772007-12-03 Dan Bernstein <mitz@apple.com> 16478 16479 Reviewed by Dave Hyatt. 16480 16481 - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame 16482 16483 * WebView/webkitwebview.cpp: Remove the call to sendResizeEvent() since 16484 FrameView sends it now. 16485 164862007-12-03 Alp Toker <alp@atoker.com> 16487 16488 globalObject() GTK+ build fix. 16489 16490 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16491 (WebKit::FrameLoaderClient::windowObjectCleared): 16492 164932007-12-03 Geoffrey Garen <ggaren@apple.com> 16494 16495 GTK Build fix: get globalExec from the right place. 16496 16497 * WebView/webkitwebframe.cpp: 16498 164992007-12-01 Alp Toker <alp@atoker.com> 16500 16501 Reviewed by Adam Roben. 16502 16503 Wrap type definitions in webkitdefines.h with G_BEGIN_DECLS, which 16504 takes care of extern "C". 16505 16506 Introduce a webkit.h convenience header. 16507 16508 Remove another left-over from the old API. 16509 16510 * WebView/headers.pri: 16511 * WebView/webkit.h: Added. 16512 * WebView/webkitdefines.h: 16513 165142007-12-01 Alp Toker <alp@atoker.com> 16515 16516 Reviewed by Adam Roben. 16517 16518 http://bugs.webkit.org/show_bug.cgi?id=15687 16519 [Gtk] Allow API clients to interact with JavaScript in web pages 16520 16521 Include the necessary JavaScriptCore headers directly in the public 16522 API headers. 16523 16524 This is the last of a series of changes needed to allow GTK+ 16525 applications to access the JS API. 16526 16527 Until http://bugs.webkit.org/show_bug.cgi?id=16029 is resolved, 16528 developers will still have to include the individual JS API headers 16529 individually if they want to use it in their applications. 16530 16531 Patch also removes some old legacy use of GDK that was in 16532 WebKitWebFrame. No ABI change. 16533 16534 * WebView/webkitdefines.h: 16535 * WebView/webkitwebframe.h: 16536 * WebView/webkitwebview.h: 16537 165382007-11-30 Jan Michael Alonzo <jmalonzo@unpluggable.com> 16539 16540 Fix for GTK+ Debug build breakage introduced in r28273. 16541 16542 * WebView/webkitprivate.cpp: 16543 (WebKit::kit): 16544 165452007-11-30 Alp Toker <alp@atoker.com> 16546 16547 Reviewed by Adam Roben. 16548 16549 http://bugs.webkit.org/show_bug.cgi?id=15691 16550 [GTK] Public API does not follow GTK+ conventions 16551 16552 Refactor the WebKit/GTK+ public API. Changes: 16553 WebKitPage -> WebKitWebView 16554 WebKitFrame -> WebKitWebFrame 16555 16556 Public API source and header names have been updated to mirror the API 16557 changes. 16558 16559 The API is now kept in WebKit/gtk/WebView to match other ports in the 16560 same class such as Mac and Win. 16561 16562 API/ABI-breaking change. 16563 16564 * Api: Removed. 16565 * Api/headers.pri: Removed. 16566 * Api/webkitgtk-marshal.list: Removed. 16567 * Api/webkitgtkdefines.h: Removed. 16568 * Api/webkitgtkframe.cpp: Removed. 16569 * Api/webkitgtkframe.h: Removed. 16570 * Api/webkitgtkglobal.cpp: Removed. 16571 * Api/webkitgtkglobal.h: Removed. 16572 * Api/webkitgtknetworkrequest.cpp: Removed. 16573 * Api/webkitgtknetworkrequest.h: Removed. 16574 * Api/webkitgtkpage.cpp: Removed. 16575 * Api/webkitgtkpage.h: Removed. 16576 * Api/webkitgtkprivate.cpp: Removed. 16577 * Api/webkitgtkprivate.h: Removed. 16578 * Api/webkitgtksettings.cpp: Removed. 16579 * Api/webkitgtksettings.h: Removed. 16580 * WebCoreSupport/ChromeClientGtk.cpp: 16581 (WebKit::ChromeClient::ChromeClient): 16582 (WebKit::ChromeClient::createWindow): 16583 * WebCoreSupport/ChromeClientGtk.h: 16584 (WebKit::ChromeClient::webPage): 16585 * WebCoreSupport/EditorClientGtk.cpp: 16586 (WebKit::EditorClient::isEditable): 16587 (WebKit::EditorClient::EditorClient): 16588 * WebCoreSupport/EditorClientGtk.h: 16589 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16590 (WebKit::FrameLoaderClient::FrameLoaderClient): 16591 (WebKit::FrameLoaderClient::postProgressStartedNotification): 16592 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): 16593 (WebKit::FrameLoaderClient::postProgressFinishedNotification): 16594 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): 16595 (WebKit::FrameLoaderClient::createFrame): 16596 (WebKit::FrameLoaderClient::windowObjectCleared): 16597 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon): 16598 (WebKit::FrameLoaderClient::setTitle): 16599 * WebCoreSupport/FrameLoaderClientGtk.h: 16600 (WebKit::FrameLoaderClient::webFrame): 16601 * WebView: Added. 16602 * WebView/headers.pri: Added. 16603 * WebView/webkit-marshal.list: Added. 16604 * WebView/webkitdefines.h: Added. 16605 * WebView/webkitglobal.cpp: Added. 16606 * WebView/webkitglobal.h: Added. 16607 * WebView/webkitnetworkrequest.cpp: Added. 16608 * WebView/webkitnetworkrequest.h: Added. 16609 * WebView/webkitprivate.cpp: Added. 16610 (WebKit::apply): 16611 (WebKit::create): 16612 (WebKit::getFrameFromView): 16613 (WebKit::getViewFromFrame): 16614 (WebKit::core): 16615 (WebKit::kit): 16616 * WebView/webkitprivate.h: Added. 16617 * WebView/webkitsettings.cpp: Added. 16618 * WebView/webkitsettings.h: Added. 16619 * WebView/webkitwebframe.cpp: Added. 16620 * WebView/webkitwebframe.h: Added. 16621 * WebView/webkitwebview.cpp: Added. 16622 * WebView/webkitwebview.h: Added. 16623 166242007-11-28 Alp Toker <alp@atoker.com> 16625 16626 Reviewed by Timothy Hatcher. 16627 16628 http://bugs.webkit.org/show_bug.cgi?id=16174 16629 [GTK] Use "URI" not "URL" in public API 16630 16631 Replace use of the term "URL" with "URI" in public headers, 16632 documentation and some internal code to match GLib/GTK+ convention. 16633 16634 This is now mentioned in the API guidelines: 16635 http://trac.webkit.org/projects/webkit/wiki/HackingGtk 16636 16637 API/ABI-breaking change. 16638 16639 * Api/webkitgtkframe.cpp: 16640 * Api/webkitgtknetworkrequest.cpp: 16641 * Api/webkitgtknetworkrequest.h: 16642 * Api/webkitgtkpage.cpp: 16643 * Api/webkitgtkpage.h: 16644 * Api/webkitgtkprivate.h: 16645 * Api/webkitgtksettings.h: 16646 166472007-11-29 Brady Eidson <beidson@apple.com> 16648 16649 Better build fix for Gtk 16650 16651 * WebCoreSupport/ChromeClientGtk.h: 16652 166532007-11-29 Brady Eidson <beidson@apple.com> 16654 16655 Keep it building with new client method 16656 16657 * WebCoreSupport/ChromeClientGtk.cpp: 16658 (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase): 16659 (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation): 16660 * WebCoreSupport/ChromeClientGtk.h: 16661 166622007-11-26 Alp Toker <alp@atoker.com> 16663 16664 Reviewed by Adam Roben. 16665 16666 http://bugs.webkit.org/show_bug.cgi?id=16149 16667 Implement the window-object-cleared signal 16668 16669 This implementation provides the JSGlobalContextRef and JSObjectRef 16670 directly rather than using an intermediate JS wrapper object, similar 16671 to the approach taken by the Win port. 16672 16673 * Api/webkitgtk-marshal.list: 16674 * Api/webkitgtkframe.h: 16675 * Api/webkitgtkpage.cpp: 16676 * Api/webkitgtkpage.h: 16677 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16678 (WebKit::FrameLoaderClient::windowObjectCleared): 16679 166802007-11-24 Alp Toker <alp@atoker.com> 16681 16682 Reviewed by Mark Rowe. 16683 16684 http://bugs.webkit.org/show_bug.cgi?id=15691 16685 [GTK] Public API does not follow GTK+ conventions 16686 16687 Public API enhancements: 16688 16689 Implement webkit_page_get_editable() and webkit_page_set_editable(). 16690 16691 Implement webkit_frame_get_name(). 16692 16693 Remove definitions for functions that are unusable or not implemented. 16694 This has caused much confusion for application developers. 16695 16696 Improve documentation. 16697 16698 Correct/constify some return types. 16699 16700 Add parameter checks. 16701 16702 Make the default fixed font "Courier New" to match the other Web 16703 font names. 16704 16705 * Api/webkitgtkframe.cpp: 16706 * Api/webkitgtkframe.h: 16707 * Api/webkitgtkpage.cpp: 16708 * Api/webkitgtkpage.h: 16709 * Api/webkitgtkprivate.h: 16710 * WebCoreSupport/EditorClientGtk.cpp: 16711 (WebKit::EditorClient::isEditable): 16712 167132007-11-24 Alp Toker <alp@atoker.com> 16714 16715 Reviewed by Mark Rowe. 16716 16717 http://bugs.webkit.org/show_bug.cgi?id=16125 16718 [GTK] Up key doesn't work properly when content is editable 16719 16720 Add a missing 'break' to avoid falling through to the next case when 16721 handling VK_UP keystrokes. This was noticed when working on editing 16722 support in the GTK+ port. 16723 16724 I've checked the other cases for similar typos and they seem fine. 16725 16726 * WebCoreSupport/EditorClientGtk.cpp: 16727 (WebKit::EditorClient::handleKeypress): 16728 167292007-11-24 Xan Lopez <xan@gnome.org> 16730 16731 Reviewed by Alp Toker. 16732 16733 http://bugs.webkit.org/show_bug.cgi?id=15745 16734 [GTK] Arrow keys do not Scroll 16735 16736 * Api/webkitgtkpage.cpp: 16737 16738 Support Up/Down/Right/Left keys to scroll. Slight hack, see FIXME for 16739 details. 16740 167412007-11-24 Christian Dywan <christian@twotoasts.de> 16742 16743 Reviewed by Alp Toker. 16744 16745 http://bugs.webkit.org/show_bug.cgi?id=15891 16746 [GTK] Javascript console and dialogs are not implemented 16747 16748 Fix call to gtk_message_dialog_new() which expects a format string. 16749 16750 * Api/webkitgtkpage.cpp: 16751 167522007-11-24 Christian Dywan <christian@twotoasts.de> 16753 16754 Reviewed by Alp Toker. 16755 16756 http://bugs.webkit.org/show_bug.cgi?id=15793 16757 [GTK] Webkit doesn't show title attribute tooltip when hovering over an image 16758 16759 Implement tooltip support using the new Tooltip API. 16760 16761 Support for older versions of GTK+ is still lacking. 16762 16763 * WebCoreSupport/ChromeClientGtk.cpp: 16764 (WebKit::ChromeClient::setToolTip): 16765 167662007-11-22 Alp Toker <alp@atoker.com> 16767 16768 Reviewed by Mark Rowe. 16769 16770 Implement and document several WebKitFrame functions, some of which 16771 are necessary to support DRT. 16772 16773 Correct NULL handling and improve run-time checks. 16774 16775 * Api/webkitgtkframe.cpp: 16776 * Api/webkitgtkframe.h: 16777 * Api/webkitgtkprivate.cpp: 16778 167792007-11-22 Alp Toker <alp@atoker.com> 16780 16781 Whitespace fixes only. 16782 16783 * Api/webkitgtkframe.cpp: 16784 * Api/webkitgtkpage.cpp: 16785 * Api/webkitgtkpage.h: 16786 * Api/webkitgtkprivate.h: 16787 * WebCoreSupport/ChromeClientGtk.cpp: 16788 * WebCoreSupport/ContextMenuClientGtk.cpp: 16789 * WebCoreSupport/ContextMenuClientGtk.h: 16790 * WebCoreSupport/DragClientGtk.h: 16791 * WebCoreSupport/EditorClientGtk.h: 16792 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16793 (WebKit::FrameLoaderClient::dispatchWillSendRequest): 16794 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): 16795 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): 16796 (WebKit::FrameLoaderClient::createFrame): 16797 (WebKit::FrameLoaderClient::createJavaAppletWidget): 16798 (WebKit::FrameLoaderClient::registerForIconNotification): 16799 (WebKit::FrameLoaderClient::setMainFrameDocumentReady): 16800 (WebKit::FrameLoaderClient::dispatchDidFinishLoad): 16801 (WebKit::FrameLoaderClient::frameLoadCompleted): 16802 (WebKit::FrameLoaderClient::saveViewStateToItem): 16803 (WebKit::FrameLoaderClient::restoreViewState): 16804 (WebKit::FrameLoaderClient::shouldGoToHistoryItem): 16805 (WebKit::FrameLoaderClient::setTitle): 16806 * WebCoreSupport/FrameLoaderClientGtk.h: 16807 168082007-11-22 Michael Natterer <mitch@imendio.com> 16809 16810 Reviewed by Alp Toker. 16811 16812 http://bugs.webkit.org/show_bug.cgi?id=15984 16813 Implement "navigation-requested" signal for WebKit Gtk 16814 16815 * Api/webkitgtknetworkrequest.h: fix parent class member. 16816 16817 * Api/webkitgtknetworkrequest.cpp 16818 * Api/webkitgtkprivate.h: basic implementation featuring an 16819 "url" member and API. 16820 16821 * Api/webkitgtkdefines.h: added network request typedefs. 16822 16823 * Api/webkitgtkpage.h: fix enum name: 16824 s/WEBKIT_NAVIGATION_REQUEST_RESPONSE/WebKitNavigationRequestResponse/ 16825 and sanitized enum values. 16826 16827 * Api/webkitgtkpage.cpp: made "navigation-requested" a signal. 16828 16829 * Api/webkitgtk-marshal.list: added INT:OBJECT,OBJECT 16830 16831 * WebCoreSupport/FrameLoaderClientGtk.cpp: emit the new signal in 16832 dispatchDecidePolicyForNavigationAction(). 16833 168342007-11-18 Christian Dywan <christian@twotoasts.de> 16835 16836 Reviewed by Alp. 16837 16838 http://bugs.webkit.org/show_bug.cgi?id=15891 16839 [GTK] Javascript console and dialogs are not implemented 16840 16841 Correct script-prompt to return NULL when cancelled. 16842 16843 Small changes to avoid compiler warnings. 16844 16845 * Api/webkitgtkpage.cpp: 16846 168472007-11-17 Timothy Hatcher <timothy@apple.com> 16848 16849 Reviewed by Mark Rowe. 16850 16851 Bug 13470: i18n: The Web Inspector is not localizable 16852 http://bugs.webkit.org/show_bug.cgi?id=13470 16853 16854 * WebCoreSupport/InspectorClientGtk.cpp: 16855 (WebKit::InspectorClient::localizedStringsURL): Empty stub. 16856 * WebCoreSupport/InspectorClientGtk.h: Add localizedStringsURL. 16857 168582007-11-13 Mark Rowe <mrowe@apple.com> 16859 16860 Gtk build fix. Replace incorrect use of the LOG macro with g_print. 16861 16862 * Api/webkitgtkpage.cpp: 16863 168642007-11-13 Christian Dywan <christian@twotoasts.de> 16865 16866 Reviewed by Alp. 16867 16868 http://bugs.webkit.org/show_bug.cgi?id=15891 16869 [GTK] Javascript console and dialogs are not implemented 16870 16871 Implement signals for script dialogs and console messages. 16872 16873 * Api/webkitgtk-marshal.list: 16874 * Api/webkitgtkpage.cpp: 16875 * Api/webkitgtkpage.h: 16876 * WebCoreSupport/ChromeClientGtk.cpp: 16877 (WebKit::ChromeClient::addMessageToConsole): 16878 (WebKit::ChromeClient::runJavaScriptAlert): 16879 (WebKit::ChromeClient::runJavaScriptConfirm): 16880 (WebKit::ChromeClient::runJavaScriptPrompt): 16881 168822007-11-11 Alp Toker <alp@atoker.com> 16883 16884 Reviewed by Anders. 16885 16886 Initialize m_userAgent. 16887 16888 Fix typos in GDK_WINDOWING conditionals. 16889 16890 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16891 (WebKit::FrameLoaderClient::FrameLoaderClient): 16892 (WebKit::agentPlatform): 16893 168942007-11-11 Alp Toker <alp@atoker.com> 16895 16896 Reviewed by Mark Rowe. 16897 16898 Mention Safari in the UserAgent string to improve site compatibility. 16899 16900 Also bump the hard-coded AppleWebKit version number. 16901 16902 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16903 (WebKit::composeUserAgent): 16904 169052007-11-09 Xan Lopez <xan@gnome.org> 16906 16907 Reviewed by Alp. 16908 16909 Fix http://bugs.webkit.org/show_bug.cgi?id=15926 16910 [GTK] WebKitPage map handler is redundant. 16911 16912 * Api/webkitgtkpage.cpp: 16913 The map handler for WebKitPage is redundant, GtkContainer does 16914 the same (and more correctly). 16915 169162007-11-08 Alp Toker <alp@atoker.com> 16917 16918 Reviewed by Mark Rowe. 16919 16920 http://bugs.webkit.org/show_bug.cgi?id=15653 16921 [GTK] Text editor does not handle common keystrokes 16922 16923 Handle more keystrokes in EditorClientGtk. Note that this is a 16924 temporary measure pending a proper solution using GtkBindingSet (see 16925 http://bugs.webkit.org/show_bug.cgi?id=15911). 16926 16927 * WebCoreSupport/EditorClientGtk.cpp: 16928 (WebKit::EditorClient::handleKeypress): 16929 169302007-11-08 Kevin McCullough <kmccullough@apple.com> 16931 16932 Reviewed by Sam. 16933 16934 - windowObjectCleared() is no longer const. It needs to setup the 16935 script debugger and cannot be const to do so. 16936 16937 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16938 (WebKit::FrameLoaderClient::windowObjectCleared): 16939 * WebCoreSupport/FrameLoaderClientGtk.h: 16940 169412007-11-06 Rodney Dawes <dobey@wayofthemonkey.com> 16942 16943 Fix http://bugs.webkit.org/attachment.cgi?id=17043&action=view 16944 Bug 15766: [GTK] WebKit sometimes spews binary data as text/plain into iframes 16945 16946 FrameLoaderClient::objectContentType needs to check with the MIMETypeRegistry 16947 to determine whether the given MIME type is displayable as an image or non-image. 16948 16949 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16950 (FrameLoaderClient::objectContentType): Change logic to match that in 16951 the Windows and Mac ports. 16952 169532007-11-05 Christian Dywan <christian@twotoasts.de> 16954 16955 Reviewed by Maciej. 16956 16957 http://bugs.webkit.org/show_bug.cgi?id=15409 16958 FrameLoaderClientGtk hardcodes data, including platform to Linux i686 16959 16960 Compute a proper user agent string. 16961 16962 Patch includes fixes by Alp. 16963 16964 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16965 (WebKit::agentPlatform): 16966 (WebKit::agentOS): 16967 (WebKit::composeUserAgent): 16968 (WebKit::FrameLoaderClient::userAgent): 16969 * WebCoreSupport/FrameLoaderClientGtk.h: 16970 169712007-11-05 Mark Rowe <mrowe@apple.com> 16972 16973 Rubber-stamped by Alp Toker. 16974 16975 Remove unused m_firstData member from FrameLoaderClientGtk. 16976 16977 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16978 * WebCoreSupport/FrameLoaderClientGtk.h: 16979 169802007-11-05 Mark Rowe <mrowe@apple.com> 16981 16982 Reviewed by Alp Toker. 16983 16984 Fix http://bugs.webkit.org/show_bug.cgi?id=15842 16985 Bug 15842: [Gtk] about:blank doesn't work 16986 16987 * WebCoreSupport/FrameLoaderClientGtk.cpp: 16988 (WebKit::FrameLoaderClient::finishedLoading): Set the encoding on the frame loader to 16989 get work done that is normally done when the first bit of data is received, even in the 16990 case of a document with no data (like about:blank). 16991 169922007-11-03 Alp Toker <alp@atoker.com> 16993 16994 Reviewed by Mark Rowe. 16995 16996 Restore correct double and triple click behaviour 16997 16998 We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after 16999 recent refactoring. 17000 17001 * Api/webkitgtkpage.cpp: 17002 170032007-11-03 Alp Toker <alp@atoker.com> 17004 17005 Reviewed by Mark Rowe. 17006 17007 Frame scrolling and invalidation fixes 17008 17009 Make upward scroll events have a positive delta to match other ports. 17010 17011 Fix the invalidation rect offset for frames so that scrolling works properly. 17012 17013 Avoid allocating negative sizes to widgets to avoid GTK+ warnings. 17014 17015 Allow tabbing to all widgets and links. 17016 17017 Fix event returns, improving the focus situation and correcting scroll wheel 17018 behavior. 17019 17020 * Api/webkitgtkpage.cpp: 17021 * WebCoreSupport/ChromeClientGtk.cpp: 17022 170232007-10-29 Alp Toker <alp@atoker.com> 17024 17025 Reviewed by Maciej. 17026 17027 Do not allow control to reach end of non-void functions 17028 17029 * Api/webkitgtksettings.cpp: 17030 170312007-10-28 Lars Lindner <lars.lindner@gmail.com> 17032 17033 Reviewed by Alp. 17034 17035 http://bugs.webkit.org/show_bug.cgi?id=15466 17036 [gtk] widget does not take focus on mouse click 17037 17038 Grab widget focus in mouse press callback. 17039 17040 * Api/webkitgtkpage.cpp: 17041 170422007-10-25 Alp Toker <alp@atoker.com> 17043 17044 Reviewed by Brady. 17045 17046 http://bugs.webkit.org/show_bug.cgi?id=15686 17047 GtkLauncher aborts on launch due to uninitialized threading subsystem 17048 17049 Re-enable database support in the GTK+ port, with a fix. 17050 17051 Initialize GLib threading as early as possible. 17052 17053 * Api/webkitgtkglobal.cpp: 17054 170552007-10-25 Alp Toker <alp@atoker.com> 17056 17057 Unreviewed fix to make the GTK+ port run. 17058 17059 http://bugs.webkit.org/show_bug.cgi?id=15686 17060 GtkLauncher aborts on launch due to uninitialized threading subsystem 17061 17062 http://bugs.webkit.org/show_bug.cgi?id=15688 17063 [GTK] Make it possible to disable database support 17064 17065 Make database path initialization conditional on database support 17066 being enabled. 17067 17068 * Api/webkitgtkglobal.cpp: 17069 170702007-10-24 Mark Rowe <mrowe@apple.com> 17071 17072 Gtk build fix. Track WebCore changes in r27004. 17073 17074 * Api/webkitgtkglobal.cpp: 17075 170762007-10-22 Alp Toker <alp@atoker.com> 17077 17078 Reviewed by Mark Rowe. 17079 17080 http://bugs.webkit.org/show_bug.cgi?id=15611 17081 [GTK] Text selection behaviour different in Debug and Release builds 17082 17083 http://bugs.webkit.org/show_bug.cgi?id=15578 17084 [GTK] Text editor caret does not blink 17085 17086 Never allow control to reach the end of non-void functions. 17087 17088 Return more sensible values, or in some cases, nulls. 17089 17090 * Api/webkitgtksettings.cpp: 17091 * Api/webkitgtksettings.h: 17092 * WebCoreSupport/DragClientGtk.cpp: 17093 (WebKit::DragClient::actionMaskForDrag): 17094 (WebKit::DragClient::dragSourceActionMaskForPoint): 17095 (WebKit::DragClient::createDragImageForLink): 17096 170972007-10-20 Mark Rowe <mrowe@apple.com> 17098 17099 Reviewed by Alp. 17100 17101 Gtk changes needed to enable HTML 5 client-side database storage. 17102 17103 * Api/webkitgtkglobal.cpp: Set a default database path based on the user data directory. 17104 This should become configurable by client applications in the future. 17105 171062007-10-20 Mark Rowe <mrowe@apple.com> 17107 17108 Reviewed by Eric. 17109 17110 Don't allow control characters to be inserted into editable regions. 17111 17112 * WebCoreSupport/EditorClientGtk.cpp: 17113 (WebKit::EditorClient::handleKeypress): 17114 171152007-10-19 Alp Toker <alp@atoker.com> 17116 17117 Reviewed by Oliver. 17118 17119 GTK+ build fix enabling the new local database storage feature. 17120 There is also a prospective Qt build fix. 17121 17122 * WebCoreSupport/ChromeClientGtk.cpp: 17123 (WebKit::ChromeClient::runDatabaseSizeLimitPrompt): 17124 * WebCoreSupport/ChromeClientGtk.h: 17125 171262007-10-14 Jan Michael Alonzo <jmalonzo@unpluggable.com> 17127 17128 Reviewed by Adam. 17129 17130 http://bugs.webkit.org/show_bug.cgi?id=15299 17131 Fix "hovering_over_link" signal not emitted when consecutive links 17132 are hovered. 17133 17134 * WebCoreSupport/ChromeClientGtk.cpp: 17135 (WebKit::ChromeClient::mouseDidMoveOverElement): 17136 * WebCoreSupport/ChromeClientGtk.h: 17137 - Remove m_didSendLinkSignal as it is superseded by m_hoveredLinkURL 17138 171392007-10-10 Alice Liu <alice.liu@apple.com> 17140 17141 Reviewed by Geoff Garen. 17142 17143 changes to keep the build from breaking 17144 17145 * WebCoreSupport/FrameLoaderClientGtk.cpp: 17146 (WebKit::FrameLoaderClient::createFrame): 17147 * WebCoreSupport/FrameLoaderClientGtk.h: 17148 171492007-10-03 Alp Toker <alp@atoker.com> 17150 17151 Reviewed by Adam. 17152 17153 http://bugs.webkit.org/show_bug.cgi?id=14726 17154 [gtk] API design. Mapping the WebView delegates to signals. 17155 17156 Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'. 17157 17158 * Api/webkitgtkdefines.h: 17159 * Api/webkitgtkframe.cpp: 17160 * Api/webkitgtkframe.h: 17161 * Api/webkitgtkglobal.cpp: 17162 * Api/webkitgtkglobal.h: 17163 * Api/webkitgtknetworkrequest.h: 17164 * Api/webkitgtkpage.cpp: 17165 * Api/webkitgtkpage.h: 17166 * Api/webkitgtkprivate.cpp: 17167 (WebKit::apply): 17168 (WebKit::create): 17169 (WebKit::getFrameFromPage): 17170 (WebKit::getPageFromFrame): 17171 (WebKit::core): 17172 (WebKit::kit): 17173 * Api/webkitgtkprivate.h: 17174 * Api/webkitgtksettings.cpp: 17175 * Api/webkitgtksettings.h: 17176 * WebCoreSupport/ChromeClientGtk.cpp: 17177 (WebKit::ChromeClient::ChromeClient): 17178 (WebKit::ChromeClient::createWindow): 17179 (WebKit::ChromeClient::addMessageToConsole): 17180 (WebKit::ChromeClient::runJavaScriptAlert): 17181 (WebKit::ChromeClient::runJavaScriptConfirm): 17182 (WebKit::ChromeClient::runJavaScriptPrompt): 17183 * WebCoreSupport/ChromeClientGtk.h: 17184 (WebKit::ChromeClient::webPage): 17185 * WebCoreSupport/EditorClientGtk.cpp: 17186 (WebKit::EditorClient::EditorClient): 17187 * WebCoreSupport/EditorClientGtk.h: 17188 * WebCoreSupport/FrameLoaderClientGtk.cpp: 17189 (WebKit::FrameLoaderClient::FrameLoaderClient): 17190 (WebKit::FrameLoaderClient::postProgressStartedNotification): 17191 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): 17192 (WebKit::FrameLoaderClient::postProgressFinishedNotification): 17193 (WebKit::FrameLoaderClient::createFrame): 17194 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon): 17195 (WebKit::FrameLoaderClient::setTitle): 17196 * WebCoreSupport/FrameLoaderClientGtk.h: 17197 (WebKit::FrameLoaderClient::webFrame): 17198 171992007-10-02 Cosimo Cecchi <cosimoc@svn.gnome.org> 17200 17201 Reviewed by Mark. 17202 17203 http://bugs.webkit.org/show_bug.cgi?id=15299 17204 Fix "hovering_over_link" signal being fired every time mouse moves. 17205 17206 * WebCoreSupport/ChromeClientGtk.cpp: 17207 (WebKit::ChromeClient::ChromeClient): 17208 (WebKit::ChromeClient::mouseDidMoveOverElement): 17209 * WebCoreSupport/ChromeClientGtk.h: 17210 172112007-09-21 Sean Egan <seanegan@gmail.com> 17212 17213 Reviewed by Alp. 17214 17215 Add an "execute_script" method to programmatically call Javascript 17216 http://bugs.webkit.org/show_bug.cgi?id=15255 17217 17218 * Api/webkitgtkpage.cpp: 17219 * Api/webkitgtkpage.h: 17220 172212007-09-29 Lars Lindner <lars.lindner@gmail.com> 17222 17223 Reviewed by Adam. 17224 17225 ChromeClientGtk.cpp does not implement mouseDidMoveOverElement() 17226 http://bugs.webkit.org/show_bug.cgi?id=15299 17227 17228 Implementing "hovering_over_link" signal. 17229 17230 * WebCoreSupport/ChromeClientGtk.cpp: 17231 (WebKit::ChromeClient::mouseDidMoveOverElement): 17232 172332007-09-26 Mark Rowe <mrowe@apple.com> 17234 17235 Gtk build fix. 17236 17237 * WebCoreSupport/FrameLoaderClientGtk.cpp: Check for empty URL instead of invalid URL. 17238 172392007-09-17 Holger Hans Peter Freyther <zecke@selfish.org> 17240 17241 Reviewed by Adam. 17242 17243 WebKitGtkPage and WebKitGtkFrame have a dependency on each other. To 17244 allow client code to include both headers the typedef's for 17245 WebKitGtkFrame, WebKitGtkPage, WebKitGtkFrameData and WebKitGtkNetworkRequest 17246 are moved into webkitgtkdefines.h and included by both webkitgtkpage.h and 17247 webkitgtkframe.h 17248 17249 * Api/webkitgtkdefines.h: 17250 * Api/webkitgtkframe.h: 17251 * Api/webkitgtkpage.h: 17252 172532007-09-17 Cyril Brulebois <cyril.brulebois@enst-bretagne.fr> 17254 17255 Reviewed by Mark, some Coding Style changes by Holger. 17256 17257 This is from http://bugs.webkit.org/show_bug.cgi?id=14812. 17258 17259 Add title and location to WebKitGtkFramePrivate, add 17260 webkit_gtk_frame_get_location to the WebKitGtkFrame API as well 17261 as a title_changed callback, implement 17262 webkit_gtk_frame_get_title and webkit_gtk_frame_get_location. 17263 17264 Initial patch by Diego Escalante Urrelo. 17265 17266 * Api/webkitgtkframe.cpp: 17267 * Api/webkitgtkframe.h: 17268 * Api/webkitgtkprivate.h: 17269 172702007-09-15 Holger Hans Peter Freyther <zecke@selfish.org> 17271 17272 Reviewed by Mark. 17273 17274 Use the new WebCore::String::fromUTF8 function to convert 17275 from the Gtk+ representation of a string to WebCore::String. 17276 17277 * WebCoreSupport/ChromeClientGtk.cpp: 17278 (WebKit::ChromeClient::runJavaScriptPrompt): 17279 172802007-09-10 Nigel Tao <nigeltao@gnome.org> 17281 17282 Reviewed by Mark Rowe. 17283 17284 Fix a typo where webkit_gtk_page_can_copy was declared twice, 17285 rather than webkit_gtk_page_can_paste. 17286 17287 * Api/webkitgtkpage.h: 17288 172892007-09-08 Brady Eidson <beidson@apple.com> 17290 17291 Better build fix 17292 17293 * WebCoreSupport/FrameLoaderClientGtk.cpp: 17294 (WebKit::FrameLoaderClient::registerForIconNotification): 17295 * WebCoreSupport/FrameLoaderClientGtk.h: 17296 172972007-09-08 Brady Eidson <beidson@apple.com> 17298 17299 Build fix 17300 17301 * WebCoreSupport/FrameLoaderClientGtk.cpp: 17302 (WebKit::FrameLoaderClient::registerForIconNotification): 17303 * WebCoreSupport/FrameLoaderClientGtk.h: 17304 173052007-09-05 Geoffrey Garen <ggaren@apple.com> 17306 17307 Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher. 17308 17309 Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no 17310 memory cache, or a very tiny one 17311 17312 Keep the GTK build working with an empty stub. 17313 17314 * WebCoreSupport/FrameLoaderClientGtk.cpp: 17315 (WebKit::FrameLoaderClient::didPerformFirstNavigation): 17316 * WebCoreSupport/FrameLoaderClientGtk.h: 17317 173182007-09-01 Oliver Hunt <oliver@apple.com> 17319 17320 Reviewed by Sam. 17321 17322 <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions 17323 17324 EditorClient::setInputMethodState stub 17325 17326 * WebCoreSupport/EditorClientGtk.cpp: 17327 (WebKit::EditorClient::setInputMethodState): 17328 * WebCoreSupport/EditorClientGtk.h: 17329 173302007-08-18 Holger Hans Peter Freyther <zecke@selfish.org> 17331 17332 Build fix. Add const to the first parameter of createPlugin 17333 17334 * WebCoreSupport/FrameLoaderClientGtk.cpp: 17335 173362007-08-17 Anders Carlsson <andersca@apple.com> 17337 17338 Build fix. 17339 17340 * WebCoreSupport/FrameLoaderClientGtk.cpp: 17341 (WebKit::FrameLoaderClient::createPlugin): 17342 * WebCoreSupport/FrameLoaderClientGtk.h: 17343 173442007-08-11 Holger Hans Peter Freyther <zecke@selfish.org> 17345 17346 Reviewed by Adam. 17347 17348 To not hit the needsLayout() assert of Frame::paint for subframes we need to 17349 make sure they are layed out. Use the newly created FrameView::layoutIfNeededRecursive 17350 method to do this. 17351 17352 * Api/webkitgtkpage.cpp: 17353 173542007-08-11 Holger Hans Peter Freyther <zecke@selfish.org> 17355 17356 Reviewed by Adam. 17357 17358 Fix text selection by setting a DragClient when creating the Page. Now 17359 that we have a DragClient we can free the Page when WebKitGtkPage gets 17360 destructed. 17361 17362 * Api/webkitgtkpage.cpp: 17363 * WebCoreSupport/DragClientGtk.cpp: Added. 17364 (WebKit::DragClient::willPerformDragDestinationAction): 17365 (WebKit::DragClient::willPerformDragSourceAction): 17366 (WebKit::DragClient::actionMaskForDrag): 17367 (WebKit::DragClient::dragSourceActionMaskForPoint): 17368 (WebKit::DragClient::startDrag): 17369 (WebKit::DragClient::createDragImageForLink): 17370 * WebCoreSupport/DragClientGtk.h: Added. 17371 173722007-08-10 Holger Hans Peter Freyther <zecke@selfish.org> 17373 17374 Reviewed by Anders. 17375 17376 Make WebKitGtkPage a GtkContainer to avoid a size_allocate 17377 race of GtkScrollBar and GtkLayout. 17378 17379 * Api/webkitgtk-marshal.list: 17380 * Api/webkitgtkframe.cpp: 17381 * Api/webkitgtkpage.cpp: 17382 * Api/webkitgtkpage.h: 17383 * Api/webkitgtkprivate.h: 17384 173852007-08-10 Holger Hans Peter Freyther <zecke@selfish.org> 17386 17387 Reviewed by Niko. 17388 17389 Minor changes to the WebKit::EditorClient to allow removing 17390 of text from TextFields. Remove the selectWordBeforeMenuEvent method 17391 which is not used and not within WebCore::EditorClient. 17392 17393 * WebCoreSupport/EditorClientGtk.cpp: 17394 (WebKit::EditorClient::shouldDeleteRange): 17395 (WebKit::EditorClient::shouldBeginEditing): 17396 (WebKit::EditorClient::shouldEndEditing): 17397 (WebKit::EditorClient::shouldApplyStyle): 17398 (WebKit::EditorClient::shouldInsertNode): 17399 * WebCoreSupport/EditorClientGtk.h: 17400 174012007-08-10 Holger Hans Peter Freyther <zecke@selfish.org> 17402 17403 Reviewed by Mark. 17404 17405 Rename the namespace from WebKitGtk to WebKit. Move the various *Client 17406 classes into the WebKit namespace. Change the class names to not contain Gtk. 17407 The file names have to contain the Gtk suffix to not clash with files in WebCore (e.g. 17408 bridge/EditorClient.h). 17409 17410 17411 * Api/webkitgtkframe.cpp: 17412 * Api/webkitgtkpage.cpp: 17413 * Api/webkitgtkprivate.cpp: 17414 * Api/webkitgtkprivate.h: 17415 * ChangeLog: 17416 * WebCoreSupport/ChromeClientGtk.cpp: 17417 (WebKit::ChromeClient::ChromeClient): 17418 (WebKit::ChromeClient::chromeDestroyed): 17419 (WebKit::ChromeClient::windowRect): 17420 (WebKit::ChromeClient::setWindowRect): 17421 (WebKit::ChromeClient::pageRect): 17422 (WebKit::ChromeClient::scaleFactor): 17423 (WebKit::ChromeClient::focus): 17424 (WebKit::ChromeClient::unfocus): 17425 (WebKit::ChromeClient::createWindow): 17426 (WebKit::ChromeClient::createModalDialog): 17427 (WebKit::ChromeClient::show): 17428 (WebKit::ChromeClient::canRunModal): 17429 (WebKit::ChromeClient::runModal): 17430 (WebKit::ChromeClient::setToolbarsVisible): 17431 (WebKit::ChromeClient::toolbarsVisible): 17432 (WebKit::ChromeClient::setStatusbarVisible): 17433 (WebKit::ChromeClient::statusbarVisible): 17434 (WebKit::ChromeClient::setScrollbarsVisible): 17435 (WebKit::ChromeClient::scrollbarsVisible): 17436 (WebKit::ChromeClient::setMenubarVisible): 17437 (WebKit::ChromeClient::menubarVisible): 17438 (WebKit::ChromeClient::setResizable): 17439 (WebKit::ChromeClient::closeWindowSoon): 17440 (WebKit::ChromeClient::canTakeFocus): 17441 (WebKit::ChromeClient::takeFocus): 17442 (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel): 17443 (WebKit::ChromeClient::runBeforeUnloadConfirmPanel): 17444 (WebKit::ChromeClient::runJavaScriptAlert): 17445 (WebKit::ChromeClient::runJavaScriptConfirm): 17446 (WebKit::ChromeClient::setStatusbarText): 17447 (WebKit::ChromeClient::shouldInterruptJavaScript): 17448 (WebKit::ChromeClient::tabsToLinks): 17449 (WebKit::ChromeClient::windowResizerRect): 17450 (WebKit::ChromeClient::addToDirtyRegion): 17451 (WebKit::ChromeClient::scrollBackingStore): 17452 (WebKit::ChromeClient::updateBackingStore): 17453 (WebKit::ChromeClient::mouseDidMoveOverElement): 17454 (WebKit::ChromeClient::setToolTip): 17455 * WebCoreSupport/ChromeClientGtk.h: 17456 * WebCoreSupport/ContextMenuClientGtk.cpp: 17457 (WebKit::ContextMenuClient::contextMenuDestroyed): 17458 (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): 17459 (WebKit::ContextMenuClient::contextMenuItemSelected): 17460 (WebKit::ContextMenuClient::downloadURL): 17461 (WebKit::ContextMenuClient::copyImageToClipboard): 17462 (WebKit::ContextMenuClient::searchWithGoogle): 17463 (WebKit::ContextMenuClient::lookUpInDictionary): 17464 (WebKit::ContextMenuClient::speak): 17465 * WebCoreSupport/ContextMenuClientGtk.h: 17466 * WebCoreSupport/EditorClientGtk.cpp: 17467 (WebKit::EditorClient::shouldDeleteRange): 17468 (WebKit::EditorClient::shouldShowDeleteInterface): 17469 (WebKit::EditorClient::isContinuousSpellCheckingEnabled): 17470 (WebKit::EditorClient::isGrammarCheckingEnabled): 17471 (WebKit::EditorClient::spellCheckerDocumentTag): 17472 (WebKit::EditorClient::shouldBeginEditing): 17473 (WebKit::EditorClient::shouldEndEditing): 17474 (WebKit::EditorClient::shouldInsertText): 17475 (WebKit::EditorClient::shouldChangeSelectedRange): 17476 (WebKit::EditorClient::shouldApplyStyle): 17477 (WebKit::EditorClient::shouldMoveRangeAfterDelete): 17478 (WebKit::EditorClient::didBeginEditing): 17479 (WebKit::EditorClient::respondToChangedContents): 17480 (WebKit::EditorClient::respondToChangedSelection): 17481 (WebKit::EditorClient::didEndEditing): 17482 (WebKit::EditorClient::didWriteSelectionToPasteboard): 17483 (WebKit::EditorClient::didSetSelectionTypesForPasteboard): 17484 (WebKit::EditorClient::selectWordBeforeMenuEvent): 17485 (WebKit::EditorClient::isEditable): 17486 (WebKit::EditorClient::registerCommandForUndo): 17487 (WebKit::EditorClient::registerCommandForRedo): 17488 (WebKit::EditorClient::clearUndoRedoOperations): 17489 (WebKit::EditorClient::canUndo): 17490 (WebKit::EditorClient::canRedo): 17491 (WebKit::EditorClient::undo): 17492 (WebKit::EditorClient::redo): 17493 (WebKit::EditorClient::shouldInsertNode): 17494 (WebKit::EditorClient::pageDestroyed): 17495 (WebKit::EditorClient::smartInsertDeleteEnabled): 17496 (WebKit::EditorClient::toggleContinuousSpellChecking): 17497 (WebKit::EditorClient::toggleGrammarChecking): 17498 (WebKit::EditorClient::handleInputMethodKeypress): 17499 (WebKit::EditorClient::EditorClient): 17500 (WebKit::EditorClient::textFieldDidBeginEditing): 17501 (WebKit::EditorClient::textFieldDidEndEditing): 17502 (WebKit::EditorClient::textDidChangeInTextField): 17503 (WebKit::EditorClient::doTextFieldCommandFromEvent): 17504 (WebKit::EditorClient::textWillBeDeletedInTextField): 17505 (WebKit::EditorClient::textDidChangeInTextArea): 17506 (WebKit::EditorClient::ignoreWordInSpellDocument): 17507 (WebKit::EditorClient::learnWord): 17508 (WebKit::EditorClient::checkSpellingOfString): 17509 (WebKit::EditorClient::checkGrammarOfString): 17510 (WebKit::EditorClient::updateSpellingUIWithGrammarString): 17511 (WebKit::EditorClient::updateSpellingUIWithMisspelledWord): 17512 (WebKit::EditorClient::showSpellingUI): 17513 (WebKit::EditorClient::spellingUIIsShowing): 17514 * WebCoreSupport/EditorClientGtk.h: 17515 * WebCoreSupport/FrameLoaderClientGtk.cpp: 17516 (WebKit::FrameLoaderClient::FrameLoaderClient): 17517 (WebKit::FrameLoaderClient::userAgent): 17518 (WebKit::FrameLoaderClient::createDocumentLoader): 17519 (WebKit::FrameLoaderClient::committedLoad): 17520 (WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): 17521 (WebKit::FrameLoaderClient::dispatchDidCancelAuthenticationChallenge): 17522 (WebKit::FrameLoaderClient::dispatchWillSendRequest): 17523 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): 17524 (WebKit::FrameLoaderClient::postProgressStartedNotification): 17525 (WebKit::FrameLoaderClient::postProgressFinishedNotification): 17526 (WebKit::FrameLoaderClient::frameLoaderDestroyed): 17527 (WebKit::FrameLoaderClient::dispatchDidReceiveResponse): 17528 (WebKit::FrameLoaderClient::createPlugin): 17529 (WebKit::FrameLoaderClient::redirectDataToPlugin): 17530 (WebKit::FrameLoaderClient::createJavaAppletWidget): 17531 (WebKit::FrameLoaderClient::overrideMediaType): 17532 (WebKit::FrameLoaderClient::windowObjectCleared): 17533 (WebKit::FrameLoaderClient::setMainFrameDocumentReady): 17534 (WebKit::FrameLoaderClient::hasWebView): 17535 (WebKit::FrameLoaderClient::hasFrameView): 17536 (WebKit::FrameLoaderClient::dispatchDidFinishLoad): 17537 (WebKit::FrameLoaderClient::frameLoadCompleted): 17538 (WebKit::FrameLoaderClient::saveViewStateToItem): 17539 (WebKit::FrameLoaderClient::restoreViewState): 17540 (WebKit::FrameLoaderClient::privateBrowsingEnabled): 17541 (WebKit::FrameLoaderClient::makeDocumentView): 17542 (WebKit::FrameLoaderClient::makeRepresentation): 17543 (WebKit::FrameLoaderClient::forceLayout): 17544 (WebKit::FrameLoaderClient::forceLayoutForNonHTML): 17545 (WebKit::FrameLoaderClient::setCopiesOnScroll): 17546 (WebKit::FrameLoaderClient::detachedFromParent1): 17547 (WebKit::FrameLoaderClient::detachedFromParent2): 17548 (WebKit::FrameLoaderClient::detachedFromParent3): 17549 (WebKit::FrameLoaderClient::detachedFromParent4): 17550 (WebKit::FrameLoaderClient::loadedFromCachedPage): 17551 (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents): 17552 (WebKit::FrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): 17553 (WebKit::FrameLoaderClient::dispatchDidCancelClientRedirect): 17554 (WebKit::FrameLoaderClient::dispatchWillPerformClientRedirect): 17555 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): 17556 (WebKit::FrameLoaderClient::dispatchWillClose): 17557 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon): 17558 (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad): 17559 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): 17560 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): 17561 (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad): 17562 (WebKit::FrameLoaderClient::dispatchDidFirstLayout): 17563 (WebKit::FrameLoaderClient::dispatchShow): 17564 (WebKit::FrameLoaderClient::cancelPolicyCheck): 17565 (WebKit::FrameLoaderClient::dispatchDidLoadMainResource): 17566 (WebKit::FrameLoaderClient::revertToProvisionalState): 17567 (WebKit::FrameLoaderClient::clearUnarchivingState): 17568 (WebKit::FrameLoaderClient::willChangeTitle): 17569 (WebKit::FrameLoaderClient::didChangeTitle): 17570 (WebKit::FrameLoaderClient::finishedLoading): 17571 (WebKit::FrameLoaderClient::finalSetupForReplace): 17572 (WebKit::FrameLoaderClient::setDefersLoading): 17573 (WebKit::FrameLoaderClient::isArchiveLoadPending): 17574 (WebKit::FrameLoaderClient::cancelPendingArchiveLoad): 17575 (WebKit::FrameLoaderClient::clearArchivedResources): 17576 (WebKit::FrameLoaderClient::canHandleRequest): 17577 (WebKit::FrameLoaderClient::canShowMIMEType): 17578 (WebKit::FrameLoaderClient::representationExistsForURLScheme): 17579 (WebKit::FrameLoaderClient::generatedMIMETypeForURLScheme): 17580 (WebKit::FrameLoaderClient::provisionalLoadStarted): 17581 (WebKit::FrameLoaderClient::didFinishLoad): 17582 (WebKit::FrameLoaderClient::setDocumentViewFromCachedPage): 17583 (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength): 17584 (WebKit::FrameLoaderClient::dispatchDidFinishLoading): 17585 (WebKit::FrameLoaderClient::dispatchDidFailLoading): 17586 (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): 17587 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): 17588 (WebKit::FrameLoaderClient::dispatchDidFailLoad): 17589 (WebKit::FrameLoaderClient::download): 17590 (WebKit::FrameLoaderClient::cancelledError): 17591 (WebKit::FrameLoaderClient::blockedError): 17592 (WebKit::FrameLoaderClient::cannotShowURLError): 17593 (WebKit::FrameLoaderClient::interruptForPolicyChangeError): 17594 (WebKit::FrameLoaderClient::cannotShowMIMETypeError): 17595 (WebKit::FrameLoaderClient::fileDoesNotExistError): 17596 (WebKit::FrameLoaderClient::shouldFallBack): 17597 (WebKit::FrameLoaderClient::willUseArchive): 17598 (WebKit::FrameLoaderClient::saveDocumentViewToCachedPage): 17599 (WebKit::FrameLoaderClient::canCachePage): 17600 (WebKit::FrameLoaderClient::dispatchCreatePage): 17601 (WebKit::FrameLoaderClient::dispatchUnableToImplementPolicy): 17602 * WebCoreSupport/FrameLoaderClientGtk.h: 17603 * WebCoreSupport/InspectorClientGtk.cpp: 17604 (WebKit::InspectorClient::inspectorDestroyed): 17605 (WebKit::InspectorClient::createPage): 17606 (WebKit::InspectorClient::showWindow): 17607 (WebKit::InspectorClient::closeWindow): 17608 (WebKit::InspectorClient::attachWindow): 17609 (WebKit::InspectorClient::detachWindow): 17610 (WebKit::InspectorClient::highlight): 17611 (WebKit::InspectorClient::hideHighlight): 17612 * WebCoreSupport/InspectorClientGtk.h: 17613 176142007-08-10 Holger Hans Peter Freyther <zecke@selfish.org> 17615 17616 Reviewed by Adam. 17617 17618 As of http://bugs.webkit.org/show_bug.cgi?id=14727 move the 17619 various *ClientGdk.{cpp,h} files from WebCore to WebKit/gtk/WebCoreSupport and 17620 rename it from Gdk to Gtk. 17621 17622 * Api/webkitgtkdefines.h: 17623 * Api/webkitgtkframe.cpp: 17624 * Api/webkitgtkframe.h: 17625 * Api/webkitgtkglobal.cpp: 17626 * Api/webkitgtkglobal.h: 17627 * Api/webkitgtknetworkrequest.cpp: 17628 * Api/webkitgtknetworkrequest.h: 17629 * Api/webkitgtkpage.cpp: 17630 * Api/webkitgtkpage.h: 17631 * Api/webkitgtkprivate.cpp: 17632 * Api/webkitgtkprivate.h: 17633 * Api/webkitgtksettings.cpp: 17634 * Api/webkitgtksettings.h: 17635 * WebCoreSupport/ChromeClientGtk.cpp: Renamed from WebKit/gtk/WebCoreSupport/ChromeClientGdk.cpp. 17636 (WebKitGtk::ChromeClientGtk::ChromeClientGtk): 17637 (WebKitGtk::ChromeClientGtk::chromeDestroyed): 17638 (WebKitGtk::ChromeClientGtk::windowRect): 17639 (WebKitGtk::ChromeClientGtk::setWindowRect): 17640 (WebKitGtk::ChromeClientGtk::pageRect): 17641 (WebKitGtk::ChromeClientGtk::scaleFactor): 17642 (WebKitGtk::ChromeClientGtk::focus): 17643 (WebKitGtk::ChromeClientGtk::unfocus): 17644 (WebKitGtk::ChromeClientGtk::createWindow): 17645 (WebKitGtk::ChromeClientGtk::createModalDialog): 17646 (WebKitGtk::ChromeClientGtk::show): 17647 (WebKitGtk::ChromeClientGtk::canRunModal): 17648 (WebKitGtk::ChromeClientGtk::runModal): 17649 (WebKitGtk::ChromeClientGtk::setToolbarsVisible): 17650 (WebKitGtk::ChromeClientGtk::toolbarsVisible): 17651 (WebKitGtk::ChromeClientGtk::setStatusbarVisible): 17652 (WebKitGtk::ChromeClientGtk::statusbarVisible): 17653 (WebKitGtk::ChromeClientGtk::setScrollbarsVisible): 17654 (WebKitGtk::ChromeClientGtk::scrollbarsVisible): 17655 (WebKitGtk::ChromeClientGtk::setMenubarVisible): 17656 (WebKitGtk::ChromeClientGtk::menubarVisible): 17657 (WebKitGtk::ChromeClientGtk::setResizable): 17658 (WebKitGtk::ChromeClientGtk::closeWindowSoon): 17659 (WebKitGtk::ChromeClientGtk::canTakeFocus): 17660 (WebKitGtk::ChromeClientGtk::takeFocus): 17661 (WebKitGtk::ChromeClientGtk::canRunBeforeUnloadConfirmPanel): 17662 (WebKitGtk::ChromeClientGtk::runBeforeUnloadConfirmPanel): 17663 (WebKitGtk::ChromeClientGtk::addMessageToConsole): 17664 (WebKitGtk::ChromeClientGtk::runJavaScriptAlert): 17665 (WebKitGtk::ChromeClientGtk::runJavaScriptConfirm): 17666 (WebKitGtk::ChromeClientGtk::runJavaScriptPrompt): 17667 (WebKitGtk::ChromeClientGtk::setStatusbarText): 17668 (WebKitGtk::ChromeClientGtk::shouldInterruptJavaScript): 17669 (WebKitGtk::ChromeClientGtk::tabsToLinks): 17670 (WebKitGtk::ChromeClientGtk::windowResizerRect): 17671 (WebKitGtk::ChromeClientGtk::addToDirtyRegion): 17672 (WebKitGtk::ChromeClientGtk::scrollBackingStore): 17673 (WebKitGtk::ChromeClientGtk::updateBackingStore): 17674 (WebKitGtk::ChromeClientGtk::mouseDidMoveOverElement): 17675 (WebKitGtk::ChromeClientGtk::setToolTip): 17676 * WebCoreSupport/ChromeClientGtk.h: Renamed from WebKit/gtk/WebCoreSupport/ChromeClientGdk.h. 17677 (WebKitGtk::ChromeClientGtk::webPage): 17678 * WebCoreSupport/ContextMenuClientGtk.cpp: Renamed from WebCore/page/gdk/ContextMenuClientGdk.cpp. 17679 (WebCore::ContextMenuClientGtk::contextMenuDestroyed): 17680 (WebCore::ContextMenuClientGtk::getCustomMenuFromDefaultItems): 17681 (WebCore::ContextMenuClientGtk::contextMenuItemSelected): 17682 (WebCore::ContextMenuClientGtk::downloadURL): 17683 (WebCore::ContextMenuClientGtk::copyImageToClipboard): 17684 (WebCore::ContextMenuClientGtk::searchWithGoogle): 17685 (WebCore::ContextMenuClientGtk::lookUpInDictionary): 17686 (WebCore::ContextMenuClientGtk::speak): 17687 (WebCore::ContextMenuClientGtk::stopSpeaking): 17688 * WebCoreSupport/ContextMenuClientGtk.h: Renamed from WebCore/page/gdk/ContextMenuClientGdk.h. 17689 * WebCoreSupport/EditorClientGtk.cpp: Renamed from WebCore/platform/gdk/EditorClientGdk.cpp. 17690 (WebCore::EditorClientGtk::shouldDeleteRange): 17691 (WebCore::EditorClientGtk::shouldShowDeleteInterface): 17692 (WebCore::EditorClientGtk::isContinuousSpellCheckingEnabled): 17693 (WebCore::EditorClientGtk::isGrammarCheckingEnabled): 17694 (WebCore::EditorClientGtk::spellCheckerDocumentTag): 17695 (WebCore::EditorClientGtk::shouldBeginEditing): 17696 (WebCore::EditorClientGtk::shouldEndEditing): 17697 (WebCore::EditorClientGtk::shouldInsertText): 17698 (WebCore::EditorClientGtk::shouldChangeSelectedRange): 17699 (WebCore::EditorClientGtk::shouldApplyStyle): 17700 (WebCore::EditorClientGtk::shouldMoveRangeAfterDelete): 17701 (WebCore::EditorClientGtk::didBeginEditing): 17702 (WebCore::EditorClientGtk::respondToChangedContents): 17703 (WebCore::EditorClientGtk::respondToChangedSelection): 17704 (WebCore::EditorClientGtk::didEndEditing): 17705 (WebCore::EditorClientGtk::didWriteSelectionToPasteboard): 17706 (WebCore::EditorClientGtk::didSetSelectionTypesForPasteboard): 17707 (WebCore::EditorClientGtk::selectWordBeforeMenuEvent): 17708 (WebCore::EditorClientGtk::isEditable): 17709 (WebCore::EditorClientGtk::registerCommandForUndo): 17710 (WebCore::EditorClientGtk::registerCommandForRedo): 17711 (WebCore::EditorClientGtk::clearUndoRedoOperations): 17712 (WebCore::EditorClientGtk::canUndo): 17713 (WebCore::EditorClientGtk::canRedo): 17714 (WebCore::EditorClientGtk::undo): 17715 (WebCore::EditorClientGtk::redo): 17716 (WebCore::EditorClientGtk::shouldInsertNode): 17717 (WebCore::EditorClientGtk::pageDestroyed): 17718 (WebCore::EditorClientGtk::smartInsertDeleteEnabled): 17719 (WebCore::EditorClientGtk::toggleContinuousSpellChecking): 17720 (WebCore::EditorClientGtk::toggleGrammarChecking): 17721 (WebCore::EditorClientGtk::handleKeypress): 17722 (WebCore::EditorClientGtk::handleInputMethodKeypress): 17723 (WebCore::EditorClientGtk::EditorClientGtk): 17724 (WebCore::EditorClientGtk::textFieldDidBeginEditing): 17725 (WebCore::EditorClientGtk::textFieldDidEndEditing): 17726 (WebCore::EditorClientGtk::textDidChangeInTextField): 17727 (WebCore::EditorClientGtk::doTextFieldCommandFromEvent): 17728 (WebCore::EditorClientGtk::textWillBeDeletedInTextField): 17729 (WebCore::EditorClientGtk::textDidChangeInTextArea): 17730 (WebCore::EditorClientGtk::ignoreWordInSpellDocument): 17731 (WebCore::EditorClientGtk::learnWord): 17732 (WebCore::EditorClientGtk::checkSpellingOfString): 17733 (WebCore::EditorClientGtk::checkGrammarOfString): 17734 (WebCore::EditorClientGtk::updateSpellingUIWithGrammarString): 17735 (WebCore::EditorClientGtk::updateSpellingUIWithMisspelledWord): 17736 (WebCore::EditorClientGtk::showSpellingUI): 17737 (WebCore::EditorClientGtk::spellingUIIsShowing): 17738 (WebCore::EditorClientGtk::getGuessesForWord): 17739 * WebCoreSupport/EditorClientGtk.h: Renamed from WebCore/platform/gdk/EditorClientGdk.h. 17740 * WebCoreSupport/FrameLoaderClientGtk.cpp: Renamed from WebCore/loader/gdk/FrameLoaderClientGdk.cpp. 17741 (WebCore::FrameLoaderClientGtk::FrameLoaderClientGtk): 17742 (WebCore::FrameLoaderClientGtk::userAgent): 17743 (WebCore::FrameLoaderClientGtk::createDocumentLoader): 17744 (WebCore::FrameLoaderClientGtk::dispatchWillSubmitForm): 17745 (WebCore::FrameLoaderClientGtk::committedLoad): 17746 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveAuthenticationChallenge): 17747 (WebCore::FrameLoaderClientGtk::dispatchDidCancelAuthenticationChallenge): 17748 (WebCore::FrameLoaderClientGtk::dispatchWillSendRequest): 17749 (WebCore::FrameLoaderClientGtk::assignIdentifierToInitialRequest): 17750 (WebCore::FrameLoaderClientGtk::postProgressStartedNotification): 17751 (WebCore::FrameLoaderClientGtk::postProgressEstimateChangedNotification): 17752 (WebCore::FrameLoaderClientGtk::postProgressFinishedNotification): 17753 (WebCore::FrameLoaderClientGtk::frameLoaderDestroyed): 17754 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveResponse): 17755 (WebCore::FrameLoaderClientGtk::dispatchDecidePolicyForMIMEType): 17756 (WebCore::FrameLoaderClientGtk::dispatchDecidePolicyForNewWindowAction): 17757 (WebCore::FrameLoaderClientGtk::dispatchDecidePolicyForNavigationAction): 17758 (WebCore::FrameLoaderClientGtk::createPlugin): 17759 (WebCore::FrameLoaderClientGtk::createFrame): 17760 (WebCore::FrameLoaderClientGtk::redirectDataToPlugin): 17761 (WebCore::FrameLoaderClientGtk::createJavaAppletWidget): 17762 (WebCore::FrameLoaderClientGtk::objectContentType): 17763 (WebCore::FrameLoaderClientGtk::overrideMediaType): 17764 (WebCore::FrameLoaderClientGtk::windowObjectCleared): 17765 (WebCore::FrameLoaderClientGtk::setMainFrameDocumentReady): 17766 (WebCore::FrameLoaderClientGtk::hasWebView): 17767 (WebCore::FrameLoaderClientGtk::hasFrameView): 17768 (WebCore::FrameLoaderClientGtk::dispatchDidFinishLoad): 17769 (WebCore::FrameLoaderClientGtk::frameLoadCompleted): 17770 (WebCore::FrameLoaderClientGtk::saveViewStateToItem): 17771 (WebCore::FrameLoaderClientGtk::restoreViewState): 17772 (WebCore::FrameLoaderClientGtk::shouldGoToHistoryItem): 17773 (WebCore::FrameLoaderClientGtk::privateBrowsingEnabled): 17774 (WebCore::FrameLoaderClientGtk::makeDocumentView): 17775 (WebCore::FrameLoaderClientGtk::makeRepresentation): 17776 (WebCore::FrameLoaderClientGtk::forceLayout): 17777 (WebCore::FrameLoaderClientGtk::forceLayoutForNonHTML): 17778 (WebCore::FrameLoaderClientGtk::setCopiesOnScroll): 17779 (WebCore::FrameLoaderClientGtk::detachedFromParent1): 17780 (WebCore::FrameLoaderClientGtk::detachedFromParent2): 17781 (WebCore::FrameLoaderClientGtk::detachedFromParent3): 17782 (WebCore::FrameLoaderClientGtk::detachedFromParent4): 17783 (WebCore::FrameLoaderClientGtk::loadedFromCachedPage): 17784 (WebCore::FrameLoaderClientGtk::dispatchDidHandleOnloadEvents): 17785 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveServerRedirectForProvisionalLoad): 17786 (WebCore::FrameLoaderClientGtk::dispatchDidCancelClientRedirect): 17787 (WebCore::FrameLoaderClientGtk::dispatchWillPerformClientRedirect): 17788 (WebCore::FrameLoaderClientGtk::dispatchDidChangeLocationWithinPage): 17789 (WebCore::FrameLoaderClientGtk::dispatchWillClose): 17790 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveIcon): 17791 (WebCore::FrameLoaderClientGtk::dispatchDidStartProvisionalLoad): 17792 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveTitle): 17793 (WebCore::FrameLoaderClientGtk::dispatchDidCommitLoad): 17794 (WebCore::FrameLoaderClientGtk::dispatchDidFinishDocumentLoad): 17795 (WebCore::FrameLoaderClientGtk::dispatchDidFirstLayout): 17796 (WebCore::FrameLoaderClientGtk::dispatchShow): 17797 (WebCore::FrameLoaderClientGtk::cancelPolicyCheck): 17798 (WebCore::FrameLoaderClientGtk::dispatchDidLoadMainResource): 17799 (WebCore::FrameLoaderClientGtk::revertToProvisionalState): 17800 (WebCore::FrameLoaderClientGtk::clearUnarchivingState): 17801 (WebCore::FrameLoaderClientGtk::willChangeTitle): 17802 (WebCore::FrameLoaderClientGtk::didChangeTitle): 17803 (WebCore::FrameLoaderClientGtk::finishedLoading): 17804 (WebCore::FrameLoaderClientGtk::finalSetupForReplace): 17805 (WebCore::FrameLoaderClientGtk::setDefersLoading): 17806 (WebCore::FrameLoaderClientGtk::isArchiveLoadPending): 17807 (WebCore::FrameLoaderClientGtk::cancelPendingArchiveLoad): 17808 (WebCore::FrameLoaderClientGtk::clearArchivedResources): 17809 (WebCore::FrameLoaderClientGtk::canHandleRequest): 17810 (WebCore::FrameLoaderClientGtk::canShowMIMEType): 17811 (WebCore::FrameLoaderClientGtk::representationExistsForURLScheme): 17812 (WebCore::FrameLoaderClientGtk::generatedMIMETypeForURLScheme): 17813 (WebCore::FrameLoaderClientGtk::provisionalLoadStarted): 17814 (WebCore::FrameLoaderClientGtk::didFinishLoad): 17815 (WebCore::FrameLoaderClientGtk::prepareForDataSourceReplacement): 17816 (WebCore::FrameLoaderClientGtk::setTitle): 17817 (WebCore::FrameLoaderClientGtk::setDocumentViewFromCachedPage): 17818 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveContentLength): 17819 (WebCore::FrameLoaderClientGtk::dispatchDidFinishLoading): 17820 (WebCore::FrameLoaderClientGtk::dispatchDidFailLoading): 17821 (WebCore::FrameLoaderClientGtk::dispatchDidLoadResourceFromMemoryCache): 17822 (WebCore::FrameLoaderClientGtk::dispatchDidFailProvisionalLoad): 17823 (WebCore::FrameLoaderClientGtk::dispatchDidFailLoad): 17824 (WebCore::FrameLoaderClientGtk::download): 17825 (WebCore::FrameLoaderClientGtk::cancelledError): 17826 (WebCore::FrameLoaderClientGtk::blockedError): 17827 (WebCore::FrameLoaderClientGtk::cannotShowURLError): 17828 (WebCore::FrameLoaderClientGtk::interruptForPolicyChangeError): 17829 (WebCore::FrameLoaderClientGtk::cannotShowMIMETypeError): 17830 (WebCore::FrameLoaderClientGtk::fileDoesNotExistError): 17831 (WebCore::FrameLoaderClientGtk::shouldFallBack): 17832 (WebCore::FrameLoaderClientGtk::willUseArchive): 17833 (WebCore::FrameLoaderClientGtk::saveDocumentViewToCachedPage): 17834 (WebCore::FrameLoaderClientGtk::canCachePage): 17835 (WebCore::FrameLoaderClientGtk::dispatchCreatePage): 17836 (WebCore::FrameLoaderClientGtk::dispatchUnableToImplementPolicy): 17837 * WebCoreSupport/FrameLoaderClientGtk.h: Renamed from WebCore/loader/gdk/FrameLoaderClientGdk.h. 17838 (WebCore::FrameLoaderClientGtk::~FrameLoaderClientGtk): 17839 (WebCore::FrameLoaderClientGtk::webFrame): 17840 * WebCoreSupport/InspectorClientGtk.cpp: Renamed from WebCore/page/gdk/InspectorClientGdk.cpp. 17841 (WebCore::InspectorClientGtk::inspectorDestroyed): 17842 (WebCore::InspectorClientGtk::createPage): 17843 (WebCore::InspectorClientGtk::showWindow): 17844 (WebCore::InspectorClientGtk::closeWindow): 17845 (WebCore::InspectorClientGtk::attachWindow): 17846 (WebCore::InspectorClientGtk::detachWindow): 17847 (WebCore::InspectorClientGtk::highlight): 17848 (WebCore::InspectorClientGtk::hideHighlight): 17849 (WebCore::InspectorClientGtk::inspectedURLChanged): 17850 * WebCoreSupport/InspectorClientGtk.h: Renamed from WebCore/page/gdk/InspectorClientGdk.h. 17851 178522007-08-10 Holger Hans Peter Freyther <zecke@selfish.org> 17853 17854 Build fix. 17855 17856 * Api/webkitgtkframe.cpp: 17857 178582007-08-10 Holger Hans Peter Freyther <zecke@selfish.org> 17859 17860 Reviewed by Adam. 17861 17862 Remove the create_frame virtual method of WebKitGtkPage. This method was inspired 17863 by the Qt port but to be useful for reimplementations WebKitGtkFrameData would need 17864 to export/expose WebCore types. WebView doesn't offer such a method so I decided to 17865 remove it. 17866 Add a internal constructor to WebKitGtkFrame to be used for constructing Sub-Frames. This 17867 is currently used by FrameLoaderClientGdk::createFrame. 17868 17869 * Api/webkitgtkframe.cpp: 17870 * Api/webkitgtkframedata.cpp: Removed. 17871 * Api/webkitgtkframedata.h: Removed. 17872 * Api/webkitgtkpage.cpp: 17873 * Api/webkitgtkpage.h: 17874 * Api/webkitgtkprivate.h: 17875 178762007-08-10 Holger Hans Peter Freyther <zecke@selfish.org> 17877 17878 Reviewed by Adam. 17879 17880 Follow the changes of ScrollView in WebCore and call setContainingWindow, set the 17881 GtkAdjustment of the GtkLayout and reimplement the set_scroll_adjustments method and pass 17882 the GtkAdjustments to ScrollView. 17883 This makes having one GdkWindow for the complete FrameTree possible. 17884 17885 17886 * gtk/Api/webkitgtkframe.cpp: 17887 * gtk/Api/webkitgtkpage.cpp: 17888 178892007-08-08 Holger Hans Peter Freyther <zecke@selfish.org> 17890 17891 Reviewed by Niko. 17892 17893 We only need to set the Settings of the Page once so do it in 17894 WebKitGtkPage instead of WebKitGtkFrame. 17895 17896 * gtk/Api/webkitgtkframe.cpp: 17897 * gtk/Api/webkitgtkpage.cpp: 17898 178992007-08-08 Holger Hans Peter Freyther <zecke@selfish.org> 17900 17901 Reviewed by Niko. 17902 17903 Instead of reimplementing the general event method, reimplement 17904 the specific mouse, expose, keyboard event methods. 17905 17906 Call the finalize implementation of the base class from WebKitGtkPage 17907 and WebKitGtkFrame. 17908 17909 * gtk/Api/webkitgtkframe.cpp: 17910 * gtk/Api/webkitgtkpage.cpp: 17911 179122007-08-08 Holger Hans Peter Freyther <zecke@selfish.org> 17913 17914 Reviewed by Niko. 17915 17916 Remove the custom painting in favor of the Widget::paint 17917 implementation. 17918 17919 * gtk/Api/webkitgtkpage.cpp: 17920 179212007-08-08 Holger Hans Peter Freyther <zecke@selfish.org> 17922 17923 Reviewed by Adam. 17924 17925 Moved code from class FrameGdk into WebKitGtkFrame. Update the 17926 webkitgrkprivate.h header file to not include FrameGdk.h. 17927 17928 * gtk/Api/webkitgtkframe.cpp: 17929 * gtk/Api/webkitgtkprivate.h: 17930 179312007-08-08 Holger Hans Peter Freyther <zecke@selfish.org> 17932 17933 Reviewed by Adam. 17934 17935 Change variable names to follow the Coding-Style. Replace occurences 17936 of a_b with aB and place the '*' correctly. 17937 17938 * gtk/Api/webkitgtkframe.cpp: 17939 * gtk/Api/webkitgtkpage.cpp: 17940 * gtk/Api/webkitgtkprivate.h: 17941 179422007-08-08 Holger Hans Peter Freyther <zecke@selfish.org> 17943 17944 Reviewed by Adam. 17945 17946 Reimplement GtkWidget::event and handle the keyboard and mouse 17947 events inside WebKitGtkPage. 17948 17949 * gtk/Api/webkitgtkpage.cpp: 17950 (FrameGdkExposeData::frame_gdk_expose_child): 17951 (FrameGdkExposeData::webkit_gtk_page_rendering_area_handle_gdk_event): 17952 (FrameGdkExposeData::webkit_gtk_page_register_rendering_area_events): 17953 (FrameGdkExposeData::webkit_gtk_page_class_init): 17954 179552007-08-07 Xan Lopez <xan@gnome.org> 17956 17957 Reviewed by Mark Rowe. 17958 17959 http://bugs.webkit.org/show_bug.cgi?id=14815 17960 [gtk] API implementation: reload 17961 17962 * gtk/Api/webkitgtkpage.cpp: Implement the webkit_gtk_page_reload() 17963 function. 17964 179652007-07-30 Diego Escalante Urrelo <diegoe@gnome.org> 17966 17967 Reviewed by Adam. 17968 17969 http://bugs.webkit.org/show_bug.cgi?id=14806 17970 Implement can_go_backward and can_go_forward in webkitgtkpage.cpp 17971 17972 * gtk/Api/webkitgtkpage.cpp: Implement webkit_gtk_page_can_go_backward() and 17973 webkit_gtk_page_can_go_forward() functions. 17974 179752007-07-30 Diego Escalante Urrelo <diegoe@gnome.org> 17976 17977 Reviewed by Alp Toker. 17978 17979 http://bugs.webkit.org/show_bug.cgi?id=14810 17980 Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp 17981 17982 This is the proper fix for #14810. 17983 17984 * gtk/Api/webkitgtkframe.cpp: 17985 * gtk/Api/webkitgtkpage.cpp: Fix the marshaller type of the "load_finished" signal and 17986 correct the class_offset parameters. 17987 179882007-07-29 Diego Escalante Urrelo <diegoe@gnome.org> 17989 17990 Reviewed by Alp Toker. 17991 17992 http://bugs.webkit.org/show_bug.cgi?id=14810 17993 Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp 17994 17995 * gtk/Api/webkitgtkpage.cpp: Use a correct n_params value and the corresponding types for 17996 them in the "load_finished" signal. 17997 179982007-07-22 Holger Hans Peter Freyther <zecke@selfish.org> 17999 18000 Reviewed by Adam. 18001 18002 Add the first API and partial implementation of the WebKit/Gtk port as 18003 of http://bugs.webkit.org/show_bug.cgi?id=14678. 18004 18005 The delegates of WebView will be modeled as signals. Delegates like the 18006 WebPolicyDelegate will be implemented as signals with default handlers. 18007 18008 Start moving files to WebKit/gtk/WebCoreSupport. 18009 18010 * gtk: Added. 18011 * gtk/Api: Added. 18012 * gtk/Api/headers.pri: Added. 18013 * gtk/Api/webkitgtk-marshal.list: Added. 18014 * gtk/Api/webkitgtkdefines.h: Added. 18015 * gtk/Api/webkitgtkframe.cpp: Added. 18016 * gtk/Api/webkitgtkframe.h: Added. 18017 * gtk/Api/webkitgtkframedata.cpp: Added. 18018 * gtk/Api/webkitgtkframedata.h: Added. 18019 * gtk/Api/webkitgtkglobal.cpp: Added. 18020 * gtk/Api/webkitgtkglobal.h: Added. 18021 * gtk/Api/webkitgtknetworkrequest.cpp: Added. 18022 * gtk/Api/webkitgtknetworkrequest.h: Added. 18023 * gtk/Api/webkitgtkpage.cpp: Added. 18024 * gtk/Api/webkitgtkpage.h: Added. 18025 * gtk/Api/webkitgtkprivate.cpp: Added. 18026 * gtk/Api/webkitgtkprivate.h: Added. 18027 * gtk/Api/webkitgtksettings.cpp: Added. 18028 * gtk/Api/webkitgtksettings.h: Added. 18029 * gtk/WebCoreSupport: Added. 18030 * gtk/WebCoreSupport/ChromeClientGdk.cpp: Added. 18031 (WebCore::ChromeClientGdk::ChromeClientGdk): 18032 (WebCore::ChromeClientGdk::chromeDestroyed): 18033 (WebCore::ChromeClientGdk::windowRect): 18034 (WebCore::ChromeClientGdk::setWindowRect): 18035 (WebCore::ChromeClientGdk::pageRect): 18036 (WebCore::ChromeClientGdk::scaleFactor): 18037 (WebCore::ChromeClientGdk::focus): 18038 (WebCore::ChromeClientGdk::unfocus): 18039 (WebCore::ChromeClientGdk::createWindow): 18040 (WebCore::ChromeClientGdk::createModalDialog): 18041 (WebCore::ChromeClientGdk::show): 18042 (WebCore::ChromeClientGdk::canRunModal): 18043 (WebCore::ChromeClientGdk::runModal): 18044 (WebCore::ChromeClientGdk::setToolbarsVisible): 18045 (WebCore::ChromeClientGdk::toolbarsVisible): 18046 (WebCore::ChromeClientGdk::setStatusbarVisible): 18047 (WebCore::ChromeClientGdk::statusbarVisible): 18048 (WebCore::ChromeClientGdk::setScrollbarsVisible): 18049 (WebCore::ChromeClientGdk::scrollbarsVisible): 18050 (WebCore::ChromeClientGdk::setMenubarVisible): 18051 (WebCore::ChromeClientGdk::menubarVisible): 18052 (WebCore::ChromeClientGdk::setResizable): 18053 (WebCore::ChromeClientGdk::closeWindowSoon): 18054 (WebCore::ChromeClientGdk::canTakeFocus): 18055 (WebCore::ChromeClientGdk::takeFocus): 18056 (WebCore::ChromeClientGdk::canRunBeforeUnloadConfirmPanel): 18057 (WebCore::ChromeClientGdk::runBeforeUnloadConfirmPanel): 18058 (WebCore::ChromeClientGdk::addMessageToConsole): 18059 (WebCore::ChromeClientGdk::runJavaScriptAlert): 18060 (WebCore::ChromeClientGdk::runJavaScriptConfirm): 18061 (WebCore::ChromeClientGdk::runJavaScriptPrompt): 18062 (WebCore::ChromeClientGdk::setStatusbarText): 18063 (WebCore::ChromeClientGdk::shouldInterruptJavaScript): 18064 (WebCore::ChromeClientGdk::tabsToLinks): 18065 (WebCore::ChromeClientGdk::windowResizerRect): 18066 (WebCore::ChromeClientGdk::addToDirtyRegion): 18067 (WebCore::ChromeClientGdk::scrollBackingStore): 18068 (WebCore::ChromeClientGdk::updateBackingStore): 18069 (WebCore::ChromeClientGdk::mouseDidMoveOverElement): 18070 (WebCore::ChromeClientGdk::setToolTip): 18071 (WebCore::ChromeClientGdk::print): 18072 * gtk/WebCoreSupport/ChromeClientGdk.h: Added. 18073 18074