12011-04-19 Ojan Vafai <ojan@chromium.org> 2 3 Fix check for whether a failure is expected to deal with 4 flaky tests and FAIL expectations. 5 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 6 72011-04-19 Ojan Vafai <ojan@chromium.org> 8 9 Reviewed by Eric Seidel. 10 11 don't show missing text results for tests that only dump image results 12 https://bugs.webkit.org/show_bug.cgi?id=58931 13 14 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 15 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 16 172011-04-19 Ojan Vafai <ojan@chromium.org> 18 19 Reviewed by Eric Seidel. 20 21 don't show failures table if there are only new tests 22 https://bugs.webkit.org/show_bug.cgi?id=58929 23 24 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 25 262011-04-19 Ojan Vafai <ojan@chromium.org> 27 28 Reviewed by Eric Seidel. 29 30 don't show failures table if there are only new tests 31 https://bugs.webkit.org/show_bug.cgi?id=58929 32 33 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 34 352011-04-19 Ojan Vafai <ojan@chromium.org> 36 37 Fix unittest failures from http://trac.webkit.org/changeset/84294. 38 39 * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: 40 * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: 41 422011-04-18 Ojan Vafai <ojan@chromium.org> 43 44 Reviewed by Eric Seidel. 45 46 switch new-run-webkit-tests to using the new results file 47 https://bugs.webkit.org/show_bug.cgi?id=58861 48 49 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 50 * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: 51 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 52 532011-04-19 Renata Hodovan <reni@webkit.org> 54 55 Reviewed by Eric Seidel. 56 57 Move the alignment related macros from Vector.h to new Alignment.h. 58 https://bugs.webkit.org/show_bug.cgi?id=56000 59 60 Adding the new file to the forwarding headers of Tools. 61 62 * DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added. 63 642011-04-19 Kevin Ollivier <kevino@theolliviers.com> 65 66 [wx] Unreviewed build fix for Win / wx 2.9 wxPython installation. 67 68 * wx/packaging/build-win-installer.py: 69 * wx/packaging/wxWebKitInstaller.iss.in: 70 712011-04-19 Adam Roben <aroben@apple.com> 72 73 Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled 74 75 * Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when 76 accelerated compositing is disabled. 77 782011-04-19 Ojan Vafai <ojan@chromium.org> 79 80 Remove accidentally committed debug code. 81 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 82 832011-04-19 Brent Fulgham <bfulgham@webkit.org> 84 85 Unreviewed build correction. 86 87 Avoid duplicate stub implementation of test routine 88 for WinCairo build. 89 90 * WebKitTestRunner/win/TestInvocationWin.cpp: Exclude 91 WinCairo from using this stub. 92 932011-04-18 Ojan Vafai <ojan@chromium.org> 94 95 Reviewed by Eric Seidel. 96 97 make results file work with audio and reftests 98 https://bugs.webkit.org/show_bug.cgi?id=58860 99 100 Also fix bug with timeout tests and store a bit in the JSON 101 for new image tests instead of loading the image result to check if it's there. 102 103 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 104 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 105 1062011-04-19 Jer Noble <jer.noble@apple.com> 107 108 Reviewed by Adam Roben. 109 110 REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output 111 https://bugs.webkit.org/show_bug.cgi?id=58890 112 113 Add a layoutTestController flag which controls when full screen callbacks are written to stdout. 114 Defaults to false. 115 116 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks(). 117 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 118 (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set. 119 (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto. 120 (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto. 121 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 122 (WTR::LayoutTestController::LayoutTestController): Initialize new ivar. 123 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 124 (WTR::LayoutTestController::dumpFullScreenCallbacks): Added. 125 (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added. 126 1272011-04-19 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> 128 129 Reviewed by Andreas Kling. 130 131 [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect) 132 https://bugs.webkit.org/show_bug.cgi?id=35086 133 134 fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused 135 a DRT sideeffect problem, because the resetSettings didn't set 136 the default value of LocalContentCanAccessFileUrls. 137 138 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 139 (WebCore::WebPage::resetSettings): 140 1412011-04-18 Zan Dobersek <zandobersek@gmail.com> 142 143 Reviewed by Martin Robinson. 144 145 [GTK] Need support for dumping focus rectangles in pixel results 146 https://bugs.webkit.org/show_bug.cgi?id=53647 147 148 Dump the selection rect if it has been requested. 149 150 * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: 151 (createBitmapContextFromWebView): 152 1532011-04-18 Eric Seidel <eric@webkit.org> 154 155 Reviewed by Adam Barth. 156 157 test-webkitpy should run the ActiveWorkItems tests 158 https://bugs.webkit.org/show_bug.cgi?id=58859 159 160 Also make the unit tests pass. :) 161 162 * QueueStatusServer/model/activeworkitems.py: 163 * QueueStatusServer/model/queue.py: 164 * QueueStatusServer/model/workitems.py: 165 1662011-04-18 Eric Seidel <eric@webkit.org> 167 168 Reviewed by Adam Barth. 169 170 queues.webkit.org should show trailing-days pass counts for queues 171 https://bugs.webkit.org/show_bug.cgi?id=58812 172 173 This lets us see if each bot is pulling its own weight or not. 174 Before I wrote this patch our suspicious was that one of the 175 cq bots was doing most of the work. Turns out they're actually 176 pretty even in their recent pass counts. 177 178 * QueueStatusServer/handlers/queuestatus.py: 179 * QueueStatusServer/index.yaml: 180 * QueueStatusServer/templates/queuestatus.html: 181 1822011-04-18 Dirk Pranke <dpranke@chromium.org> 183 184 Reviewed by Eric Seidel. 185 186 new-run-webkit-tests: obsolete old threading code, part 1 187 https://bugs.webkit.org/show_bug.cgi?id=58752 188 189 This patch removes support for the 'old-inline' and 190 'old-threads' worker models, and deletes the corresponding code. 191 Now that the new code is stable, this stuff is no longer 192 necessary. 193 194 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed. 195 * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed. 196 * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed. 197 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 198 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 199 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 200 2012011-04-18 Dirk Pranke <dpranke@chromium.org> 202 203 Reviewed by Eric Seidel. 204 205 new-run-webkit-tests: add an --additional-drt-flag option 206 https://bugs.webkit.org/show_bug.cgi?id=58680 207 208 NRWT has a bunch of command line flags that exist to pass 209 custom flags to DRT, especially on chromium. It would be nice 210 if there was a generic mechanism to pass through flags so we 211 didn't have all the custom ones. 212 213 * Scripts/webkitpy/layout_tests/port/chromium.py: 214 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 215 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 216 * Scripts/webkitpy/layout_tests/port/test.py: 217 * Scripts/webkitpy/layout_tests/port/webkit.py: 218 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 219 2202011-04-05 Jer Noble <jer.noble@apple.com> 221 222 Reviewed by Sam Weinig. 223 224 WebKit2: WKTR should support WebKit2 full screen APIs 225 https://bugs.webkit.org/show_bug.cgi?id=56318 226 227 Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing 228 WKTR to test the LayoutTest/fullscreen/ tests. 229 230 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 231 (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient. 232 (WTR::InjectedBundlePage::supportsFullScreen): Added. 233 (WTR::InjectedBundlePage::enterFullScreenForElement): Added. 234 (WTR::InjectedBundlePage::exitFullScreenForElement): Added. 235 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 236 * WebKitTestRunner/TestController.cpp: 237 (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference. 238 2392011-04-18 Dirk Pranke <dpranke@chromium.org> 240 241 Reviewed by Tony Chang. 242 243 new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory 244 https://bugs.webkit.org/show_bug.cgi?id=58388 245 246 * Scripts/webkitpy/layout_tests/port/chromium.py: 247 2482011-04-18 Evan Martin <evan@chromium.org> 249 250 Reviewed by Eric Seidel. 251 252 [chromium] expose title direction to webkit client 253 https://bugs.webkit.org/show_bug.cgi?id=58823 254 255 * DumpRenderTree/chromium/LayoutTestController.cpp: 256 (LayoutTestController::LayoutTestController): 257 (LayoutTestController::reset): 258 * DumpRenderTree/chromium/LayoutTestController.h: 259 (LayoutTestController::setTitleTextDirection): 260 Add member and setter to let us stash the title direction at load time. 261 262 * DumpRenderTree/chromium/WebViewHost.cpp: 263 (WebViewHost::didReceiveTitle): 264 * DumpRenderTree/chromium/WebViewHost.h: 265 Adapt to new API; push the title into layoutTestController when we 266 receive it. 267 2682011-04-18 Dirk Pranke <dpranke@chromium.org> 269 270 Unreviewed. 271 272 Re-land r84112. It was rolled out in r84127 but it didn't need 273 to be. Only r84111 actually broke things. 274 275 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: 276 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 277 2782011-04-18 Dirk Pranke <dpranke@chromium.org> 279 280 Reviewed by Tony Chang. 281 282 new-run-webkit-tests: don't run more processes than necessary 283 https://bugs.webkit.org/show_bug.cgi?id=58751 284 285 Previously NRWT would start up 1 process for each processor on 286 the machine by default, which was a waste if we were only 287 running a few shards of tests. 288 289 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 290 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 291 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 292 2932011-04-18 Ojan Vafai <ojan@chromium.org> 294 295 Reviewed by Eric Seidel. 296 297 include links to actual.png files for new pixel tests 298 https://bugs.webkit.org/show_bug.cgi?id=58831 299 300 Load image elements to confirm whether the files exist. 301 Image elements will load without being appended to the DOM. 302 303 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 304 3052011-04-18 Ojan Vafai <ojan@chromium.org> 306 307 Reviewed by Eric Seidel. 308 309 add a zoomed view for pixel results to the new results html file 310 https://bugs.webkit.org/show_bug.cgi?id=58827 311 312 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 313 3142011-04-18 Ojan Vafai <ojan@chromium.org> 315 316 Reviewed by Eric Seidel. 317 318 add labels to results html page 319 https://bugs.webkit.org/show_bug.cgi?id=58803 320 321 -fix iframe size to be the size of the png results 322 -fix a bunch of aesthetic nits 323 -fix some incorrectly styled code 324 325 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 326 3272011-04-18 Chang Shu <cshu@webkit.org> 328 329 Reviewed by Eric Seidel. 330 331 WebKitTestRunner needs layoutTestController.pathToLocalResource 332 https://bugs.webkit.org/show_bug.cgi?id=42541 333 334 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 335 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 336 * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: 337 (WTR::LayoutTestController::pathToLocalResource): 338 * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: 339 (WTR::LayoutTestController::pathToLocalResource): 340 * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: 341 (WTR::LayoutTestController::pathToLocalResource): 342 3432011-04-18 Timothy Hatcher <timothy@apple.com> 344 345 Make update-webkit-localizable-strings put WebKit/win strings in WebCore 346 now that all localized strings in WebKit/win use WEB_UI_STRING. 347 348 https://webkit.org/b/58747 349 350 Reviewed by Dan Bernstein. 351 352 * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently. 353 3542011-04-18 Patrick Gansterer <paroga@webkit.org> 355 356 Reviewed by Adam Roben. 357 358 [WIN] Use WCHAR instead of TCHAR 359 https://bugs.webkit.org/show_bug.cgi?id=58755 360 361 We always use the UNICODE versions of windows functions, so 362 the usage of TCHAR makes no sense and mixing them is bad style. 363 364 * WinLauncher/PrintWebUIDelegate.cpp: 365 Also fix various style issues (including indentation and removal of ugly C-casts). 366 * WinLauncher/WinLauncher.cpp: 367 3682011-04-18 Dominic Cooney <dominicc@chromium.org> 369 370 Reviewed by Andreas Kling. 371 372 Add layoutTestController.shadowRoot to Qt DRT. 373 https://bugs.webkit.org/show_bug.cgi?id=58759 374 375 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 376 (LayoutTestController::shadowRoot): Added. 377 * DumpRenderTree/qt/LayoutTestControllerQt.h: 378 3792011-04-18 Sheriff Bot <webkit.review.bot@gmail.com> 380 381 Unreviewed, rolling out r84111. 382 http://trac.webkit.org/changeset/84111 383 https://bugs.webkit.org/show_bug.cgi?id=58771 384 385 Chromium linux layout tests are broken. (Requested by loislo2 386 on #webkit). 387 388 * Scripts/webkitpy/layout_tests/port/chromium.py: 389 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 390 * Scripts/webkitpy/layout_tests/port/mock_drt.py: 391 3922011-04-18 Sheriff Bot <webkit.review.bot@gmail.com> 393 394 Unreviewed, rolling out r84112. 395 http://trac.webkit.org/changeset/84112 396 https://bugs.webkit.org/show_bug.cgi?id=58770 397 398 Chromium linux layout tests are broken. (Requested by loislo2 399 on #webkit). 400 401 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: 402 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 403 4042011-04-17 Daniel Bates <dbates@webkit.org> 405 406 Reviewed by Eric Seidel and Adam Barth. 407 408 webkit-patch land hangs if svn prompts for credentials 409 https://bugs.webkit.org/show_bug.cgi?id=31500 410 411 Prompt for username and password when using git-svn and there aren't cached SVN credentials. 412 413 * Scripts/webkitpy/common/checkout/scm.py: 414 - Added mixin class SVNRepository and made both class SVN and Git inherit from it. 415 - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value 416 for argument realm; modified call sites as needed. 417 - Modified AuthenticationError constructor to take optional prompt_for_password argument. 418 - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument. 419 - Modified Git._commit_on_branch() to take optional username and password argument. 420 - Modified Git.push_local_commits_to_server() to take optional username and password 421 argument and to call has_authorization_for_realm(). 422 * Scripts/webkitpy/common/checkout/scm_unittest.py: 423 - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument. 424 - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to 425 SVN.has_authorization_for_realm(). 426 * Scripts/webkitpy/common/net/credentials.py: 427 - Modified Credentials.read_credentials() to call User.prompt_password() instead 428 of using getpass.getpass() directly. 429 * Scripts/webkitpy/common/system/user.py: 430 - Added User.prompt_password(). 431 * Scripts/webkitpy/tool/steps/commit.py: 432 - Modified Commit.run() to prompt for a password if needed. 433 4342011-04-17 Dirk Pranke <dpranke@chromium.org> 435 436 Reviewed by Ojan Vafai. 437 438 new-run-webkit-tests: save stderr into the layout-test-results dir 439 https://bugs.webkit.org/show_bug.cgi?id=58690 440 441 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: 442 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 443 4442011-04-17 Dirk Pranke <dpranke@chromium.org> 445 446 Reviewed by Ojan Vafai. 447 448 new-run-webkit-tests: read stderr from chromium DRT separately 449 https://bugs.webkit.org/show_bug.cgi?id=58708 450 451 * Scripts/webkitpy/layout_tests/port/chromium.py: 452 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 453 * Scripts/webkitpy/layout_tests/port/mock_drt.py: 454 4552011-04-17 Patrick Gansterer <paroga@webkit.org> 456 457 Reviewed by Adam Barth. 458 459 Rename PLATFORM(CA) to USE(CA) 460 https://bugs.webkit.org/show_bug.cgi?id=58742 461 462 * DumpRenderTree/mac/DumpRenderTree.mm: 463 (resetDefaultsToConsistentValues): 464 4652011-04-17 Patrick Gansterer <paroga@webkit.org> 466 467 Reviewed by Adam Barth. 468 469 Rename PLATFORM(CG) to USE(CG) 470 https://bugs.webkit.org/show_bug.cgi?id=58729 471 472 * DumpRenderTree/PixelDumpSupport.cpp: 473 * DumpRenderTree/chromium/WebViewHost.cpp: 474 (WebViewHost::paintRect): 475 * DumpRenderTree/config.h: 476 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 477 (createBitmapContextFromWebView): 478 * TestWebKitAPI/PlatformWebView.h: 479 * WebKitTestRunner/config.h: 480 * WebKitTestRunner/win/TestInvocationWin.cpp: 481 4822011-04-16 Patrick Gansterer <paroga@webkit.org> 483 484 Reviewed by Eric Seidel. 485 486 Rename PLATFORM(CAIRO) to USE(CAIRO) 487 https://bugs.webkit.org/show_bug.cgi?id=55192 488 489 * DumpRenderTree/PixelDumpSupport.cpp: 490 * DumpRenderTree/config.h: 491 * DumpRenderTree/win/PixelDumpSupportWin.cpp: 492 (createBitmapContextFromWebView): 493 * WebKitTestRunner/config.h: 494 4952011-04-16 Ojan Vafai <ojan@chromium.org> 496 497 Reviewed by Eric Seidel. 498 499 show diffs+test inline in the results page 500 https://bugs.webkit.org/show_bug.cgi?id=58723 501 502 Put each row in it's own tbody and sort based on tbodies. That way 503 we can append the results to the tbody inline as another table row. 504 505 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 506 5072011-04-16 Ojan Vafai <ojan@chromium.org> 508 509 Reviewed by Eric Seidel. 510 511 handle new tests in the new results html file 512 https://bugs.webkit.org/show_bug.cgi?id=58715 513 514 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 515 5162011-04-15 Dirk Pranke <dpranke@chromium.org> 517 518 Reviewed by Ojan Vafai. 519 520 old-run-webkit-tests: save the list of tests actually run to a file 521 https://bugs.webkit.org/show_bug.cgi?id=58692 522 523 * Scripts/old-run-webkit-tests: 524 5252011-04-15 Dirk Pranke <dpranke@chromium.org> 526 527 Reviewed by Ojan Vafai. 528 529 fix MockFileSystem.abspath() on windows 530 https://bugs.webkit.org/show_bug.cgi?id=58713 531 532 The existing code was borked on Windows if a path was passed 533 in using a drive letter (e.g., "d:\foo.txt"), and would go 534 into an infinite recursive loop. While win paths shouldn't 535 normally be passed into the mock filesystem, this just 536 bulletproofs things a bit (note that "/foo.txt" is considered 537 an absolute path on windows python as well. 538 539 * Scripts/webkitpy/common/system/filesystem_mock.py: 540 5412011-04-15 Ojan Vafai <ojan@chromium.org> 542 543 Reviewed by Eric Seidel. 544 545 show stderr files and httpd log files 546 https://bugs.webkit.org/show_bug.cgi?id=58714 547 548 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 549 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 550 5512011-04-15 Shishir Agrawal <shishir@chromium.org> 552 553 Reviewed by James Robinson. 554 555 Add a flag to guard Page Visibility API changes. 556 https://bugs.webkit.org/show_bug.cgi?id=58464 557 558 * Scripts/build-webkit: 559 5602011-04-15 Chang Shu <cshu@webkit.org> 561 562 Reviewed by Alexey Proskuryakov. 563 564 When a message with url embedded is added to console, the "file:" scheme 565 and path should be stripped. 566 https://bugs.webkit.org/show_bug.cgi?id=58665 567 568 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 569 (WTR::lastFileURLPathComponent): 570 (WTR::InjectedBundlePage::willAddMessageToConsole): 571 5722011-04-15 Jeff Miller <jeffm@apple.com> 573 574 Reviewed by Sam Weinig. 575 576 Add takeFocus callback to WKPageUIClient 577 https://bugs.webkit.org/show_bug.cgi?id=58686 578 579 Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner. 580 581 * MiniBrowser/mac/BrowserWindowController.m: 582 (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry. 583 * MiniBrowser/win/BrowserView.cpp: 584 (BrowserView::create): Added empty takeFocus entry. 585 * WebKitTestRunner/TestController.cpp: 586 (WTR::TestController::createOtherPage): Added empty takeFocus entry. 587 (WTR::TestController::initialize): Added empty takeFocus entry. 588 5892011-04-15 Ojan Vafai <ojan@chromium.org> 590 591 Reviewed by Eric Seidel. 592 593 only show pretty-diff/wdiff if they were generated 594 https://bugs.webkit.org/show_bug.cgi?id=58682 595 596 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 597 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 598 * Scripts/webkitpy/layout_tests/port/base.py: 599 6002011-04-15 Andreas Kling <kling@webkit.org> 601 602 Reviewed by Antonio Gomes. 603 604 [Qt] DRT: Default custom policy delegate decision should be Ignore. 605 606 If layoutTestController.setCustomPolicyDelegate() is called with only 607 one argument, the second ("permissive") should default to false. 608 609 * DumpRenderTree/qt/LayoutTestControllerQt.h: 610 6112011-04-15 Ojan Vafai <ojan@chromium.org> 612 613 Reviewed by Eric Seidel. 614 615 fix path to layout test in new results file 616 https://bugs.webkit.org/show_bug.cgi?id=58618 617 618 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 619 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 620 6212011-04-15 Ojan Vafai <ojan@chromium.org> 622 623 Reviewed by Eric Seidel. 624 625 fix sorting in new results file 626 https://bugs.webkit.org/show_bug.cgi?id=58616 627 628 -Fix the custom sort to return -1, 0, 1 instead of true/false. 629 -Secondary sort by test name when sort values are equal. 630 -Sort by test name by default. 631 632 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 633 6342011-04-15 Dmitry Lomov <dslomov@google.com> 635 636 Reviewed by David Levin. 637 638 check-webkit-style shouldn't complain about not including a primary header file 639 if none exists 640 https://bugs.webkit.org/show_bug.cgi?id=39514 641 642 * Scripts/webkitpy/style/checkers/cpp.py: 643 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 644 6452011-04-15 Eric Seidel <eric@webkit.org> 646 647 Reviewed by Mihai Parparita. 648 649 queues.webkit.org should display when a bot last rebooted 650 https://bugs.webkit.org/show_bug.cgi?id=58562 651 652 There is more repeated code here than I would like. I fear 653 my django-fu isn't quite up to snuff. 654 655 * QueueStatusServer/handlers/queuestatus.py: 656 * QueueStatusServer/templates/queuestatus.html: 657 6582011-04-14 Alok Priyadarshi <alokp@chromium.org> 659 660 Reviewed by Adam Barth. 661 662 Remove dependency on chromium skia::PlatformCanvas 663 https://bugs.webkit.org/show_bug.cgi?id=57563 664 665 Fixed compile error on Mac when using Core Graphics. 666 667 * DumpRenderTree/chromium/WebViewHost.cpp: 668 (WebViewHost::paintRect): 669 6702011-04-14 Alok Priyadarshi <alokp@chromium.org> 671 672 Reviewed by James Robinson. 673 674 Remove dependency on chromium skia::PlatformCanvas 675 https://bugs.webkit.org/show_bug.cgi?id=57563 676 677 * DumpRenderTree/chromium/TestShell.cpp: 678 (makeCanvasOpaque): 679 (TestShell::dumpImage): 680 * DumpRenderTree/chromium/TestShell.h: 681 * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: 682 (WebThemeControlDRTWin::WebThemeControlDRTWin): 683 (WebThemeControlDRTWin::draw): 684 (WebThemeControlDRTWin::drawTextField): 685 (WebThemeControlDRTWin::drawProgressBar): 686 * DumpRenderTree/chromium/WebThemeControlDRTWin.h: 687 * DumpRenderTree/chromium/WebViewHost.cpp: 688 (WebViewHost::canvas): 689 * DumpRenderTree/chromium/WebViewHost.h: 690 6912011-04-14 Keith Kyzivat <keith.kyzivat@nokia.com> 692 693 Reviewed by Laszlo Gombos. 694 695 [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser 696 https://bugs.webkit.org/show_bug.cgi?id=58007 697 698 Adds flag to start the test browsers maximized. 699 Symbian started maximized on QtTestBrowser - made MiniBrowser follow 700 suit. 701 Also fixes some ToggleFullScreen issues so that prior window state is 702 restored. 703 704 * MiniBrowser/qt/BrowserWindow.cpp: 705 (BrowserWindow::BrowserWindow): 706 (BrowserWindow::toggleFullScreenMode): 707 * MiniBrowser/qt/MiniBrowserApplication.cpp: 708 (MiniBrowserApplication::handleUserOptions): 709 * MiniBrowser/qt/MiniBrowserApplication.h: 710 (WindowOptions::WindowOptions): 711 * QtTestBrowser/launcherwindow.cpp: 712 (LauncherWindow::init): 713 (LauncherWindow::toggleFullScreenMode): 714 * QtTestBrowser/launcherwindow.h: 715 (WindowOptions::WindowOptions): 716 * QtTestBrowser/main.cpp: 717 (LauncherApplication::handleUserOptions): 718 7192011-04-14 Ojan Vafai <ojan@chromium.org> 720 721 Reviewed by Eric Seidel. 722 723 add checkbox to only show unexpected results to new results file 724 https://bugs.webkit.org/show_bug.cgi?id=58606 725 726 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 727 7282011-04-13 Brent Fulgham <bfulgham@webkit.org> 729 730 Reviewed by Martin Robinson. 731 732 [WinCairo] Implement ImageDiff Logic. 733 http://bugs.webkit.org/show_bug.cgi?id=58486 734 735 * DumpRenderTree/win/ImageDiffCairo.cpp: Added. 736 (strtof): 737 (readFromData): 738 (createImageFromStdin): 739 (releaseMallocBuffer): 740 (createDifferenceImage): 741 (imageHasAlpha): 742 (writeToData): 743 (main): 744 * DumpRenderTree/win/ImageDiff.vcproj: Updated for new 745 ImageDiffCairo.cpp (excluding from Apple builds). 746 * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use 747 new ImageDiffWinCairoCommon.vsprops file. 748 * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use 749 new ImageDiffWinCairoCommon.vsprops file. 750 * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added. 751 * Scripts/old-run-webkit-tests: Make sure proper executable 752 is built and executed for WinCairo port. 753 7542011-04-14 Ojan Vafai <ojan@chromium.org> 755 756 Reviewed by Eric Seidel. 757 758 only show expected failure type for ports that use an expectations file 759 https://bugs.webkit.org/show_bug.cgi?id=58588 760 761 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 762 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 763 7642011-04-14 Eric Seidel <eric@webkit.org> 765 766 Reviewed by Adam Barth. 767 768 commit-queue fails to catch IOError when results.html is missing 769 https://bugs.webkit.org/show_bug.cgi?id=58589 770 771 * Scripts/webkitpy/tool/commands/queues.py: 772 * Scripts/webkitpy/tool/commands/queues_unittest.py: 773 7742011-04-14 Kevin Ollivier <kevino@theolliviers.com> 775 776 [wx] Unreviewed build fix for Mac installation script. 777 778 * wx/packaging/build-mac-installer.py: 779 7802011-04-14 Ojan Vafai <ojan@chromium.org> 781 782 Reviewed by Tony Chang. 783 784 sort columns in the new json_results.html file 785 https://bugs.webkit.org/show_bug.cgi?id=58581 786 787 Also fix padding on TDs and the path to layout tests. 788 789 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: 790 7912011-04-14 Eric Seidel <eric@webkit.org> 792 793 Reviewed by Dimitri Glazkov. 794 795 queues.webkit.org should display when a bot last passed a patch 796 https://bugs.webkit.org/show_bug.cgi?id=58546 797 798 I am suspicious that some of our commit-queue instances are never 799 actually passing anything. 800 801 This will let us know if those bots are never passing patches. 802 803 * QueueStatusServer/handlers/queuestatus.py: 804 * QueueStatusServer/index.yaml: 805 * QueueStatusServer/templates/queuestatus.html: 806 8072011-04-14 Dirk Pranke <dpranke@chromium.org> 808 809 Reviewed by Adam Roben. 810 811 REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13 812 https://bugs.webkit.org/show_bug.cgi?id=58545 813 814 Remove platform-specific overrides; the default behavior should 815 be working everywhere now, I think. 816 817 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 818 * Scripts/webkitpy/layout_tests/port/mac.py: 819 8202011-04-14 Eric Seidel <eric@webkit.org> 821 822 Reviewed by Adam Barth. 823 824 commit-queues are hitting an exception trying to land when the tree is red 825 https://bugs.webkit.org/show_bug.cgi?id=58558 826 827 Just an un-tested (and thus broken) code path from yesterday's changes. 828 829 * Scripts/webkitpy/common/net/layouttestresults.py: 830 * Scripts/webkitpy/common/net/layouttestresults_unittest.py: 831 * Scripts/webkitpy/tool/commands/queues.py: 832 * Scripts/webkitpy/tool/commands/queues_unittest.py: 833 8342011-04-14 Kevin Ollivier <kevino@theolliviers.com> 835 836 [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1. 837 838 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 839 (LayoutTestController::shadowRoot): 840 * wx/build/wxpresets.py: 841 8422011-04-14 Victoria Kirst <vrk@google.com> 843 844 Reviewed by James Robinson. 845 846 [chromium] Failing GPU video tests 847 https://bugs.webkit.org/show_bug.cgi?id=57926 848 849 Added/updated GPU directory names for rebaseline tool. 850 851 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 852 8532011-04-13 Daniel Bates <dbates@rim.com> 854 855 Reviewed by Adam Barth. 856 857 Perl unit test removeEOL.pl should print test case name on failure 858 https://bugs.webkit.org/show_bug.cgi?id=58513 859 860 * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as 861 second argument of Test::Simple::ok(). 862 8632011-04-13 Kent Tamura <tkent@chromium.org> 864 865 Reviewed by Eric Seidel. 866 867 gdb-safari should pass arguments to safari. 868 https://bugs.webkit.org/show_bug.cgi?id=58439 869 870 We can do: 871 gdb-safari --debug LayoutTests/.../foo.html 872 873 * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg. 874 8752011-04-13 Dirk Pranke <dpranke@chromium.org> 876 877 Unreviewed, build fix. 878 https://bugs.webkit.org/show_bug.cgi?id=52763 879 880 r83799 broke test-webkitpy because it assumed we always have 881 access to a real filesystem (we don't during the unit tests). 882 Stubbing out the copy for now but we might need a better 883 solution at some point. 884 885 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 886 8872011-04-13 Dirk Pranke <dpranke@chromium.org> 888 889 Reviewed by Tony Chang. 890 891 new-run-webkit-tests --run-singly option is busted 892 https://bugs.webkit.org/show_bug.cgi?id=55909 893 894 Python's broken lexical scoping strikes again :(. 895 896 * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: 897 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 898 8992011-04-13 Ojan Vafai <ojan@chromium.org> 900 901 Reviewed by Eric Seidel. 902 903 generated unexpected_results.html from unexpected_results.json 904 https://bugs.webkit.org/show_bug.cgi?id=52763 905 906 Eventually, we'll merge this with results.html and have a single richer results page. 907 For now, I just want to get something checked in that we can iterate on. 908 909 * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added. 910 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 911 9122011-04-13 Eric Seidel <eric@webkit.org> 913 914 Reviewed by Adam Barth. 915 916 Up the failure limit to allow the commit-queue to actually land when the tree is red 917 https://bugs.webkit.org/show_bug.cgi?id=58499 918 919 This change increases the --exit-after-N-failures limit used by the commit-queue 920 from 1 to 10. This will cause the code added in bug 58494 to actually get 921 exercised and the queues should start being able to land when the trees are red. 922 923 When testing I found that test_runtests_leopard_commit_queue_hack_command was the 924 only unit test to actually detect this change! Since we don't actually 925 run on leopard anymore, I removed the hack code and repurposed the test. 926 927 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 928 * Scripts/webkitpy/tool/steps/runtests.py: 929 * Scripts/webkitpy/tool/steps/steps_unittest.py: 930 9312011-04-13 Eric Seidel <eric@webkit.org> 932 933 Reviewed by Adam Barth. 934 935 commit-queue should be able to land when tree is red 936 https://bugs.webkit.org/show_bug.cgi?id=58494 937 938 There is some yak hair on my hands, I will admit. 939 940 This change is mostly about adding an ExpectedFailures 941 class to track when the bots are red and we should be 942 ignoring failures when landing from the commit-queue. 943 944 However, to make intelligent decisions about patches we 945 need to know whether the run hit the --exit-after-N-failures limit 946 or not. Right now that information is not saved off in results.html 947 so we have to pull the information from RunTests. 948 949 I've plumbed the --exit-after-N-failures information into 950 LayoutTestResults for now to make the ExpectedFailures code cleaner. 951 952 As a result of adding all these additional calls to delegate.layout_test_results() 953 I broke some of our flaky test detection tests and had to re-write them 954 to not depend on the number of layout_test_results code. 955 956 At the same time I updated the commit-queue to use the newer filesystem 957 API (to allow us to use MockFileSystem) which required further changes 958 to the layout tests. Changes were required in either case, since 959 we're now calling layout_test_results() in more cases, which previously 960 would try and hit the disk (until I moved it to use tool.filesystem). 961 962 I should note that *all* of this code is disabled for now, since our 963 --exit-after-N-failures limit is currently 1! (Thus were always in the 964 case where we can't actually tell if the layout test results are legit.) 965 I will up that limit in a second patch (which may require a couple more unit test tweaks). 966 967 * Scripts/webkitpy/common/net/layouttestresults.py: 968 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 969 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: 970 * Scripts/webkitpy/tool/bot/expectedfailures.py: Added. 971 * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added. 972 * Scripts/webkitpy/tool/commands/queues.py: 973 * Scripts/webkitpy/tool/commands/queues_unittest.py: 974 * Scripts/webkitpy/tool/commands/queuestest.py: 975 * Scripts/webkitpy/tool/steps/runtests.py: 976 9772011-04-13 Brent Fulgham <bfulgham@webkit.org> 978 979 Unreviewed build correction. 980 981 * TestWebKitAPI/PlatformWebView.h: Limit include of 982 <CoreGraphics/CGGeometry> to PLATFORM(CG) users. 983 9842011-04-13 Mihai Parparita <mihaip@chromium.org> 985 986 Reviewed by Eric Seidel. 987 988 [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT 989 https://bugs.webkit.org/show_bug.cgi?id=58489 990 991 r83743 added --additional-platform-directory to old-run-webkit-tests, 992 rename the equivalent flag in new-run-webkit-tests to be consistent. 993 994 * Scripts/webkitpy/layout_tests/port/base.py: 995 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 996 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 997 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 998 9992011-04-13 Mihai Parparita <mihaip@chromium.org> 1000 1001 Reviewed by Eric Seidel. 1002 1003 Rebaseline queue server 1004 https://bugs.webkit.org/show_bug.cgi?id=57891 1005 1006 Adds a simple rebaseline queue server (meant to run at 1007 http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT) 1008 builders and their failing tests, and allows those tests to be added to 1009 a per-builer rebaseline queue. 1010 1011 A subsequent change will add a mode to NRWT (and/or a wrapper script) 1012 for pulling the tests to be rebaselined from the server and running them 1013 with --reset-results (the initial use-case is for the GPU hardware bots, 1014 which do not have checked-in baselines, therefore there is no need for a 1015 check-in step yet). 1016 1017 * RebaselineQueueServer/app.yaml: Added. 1018 * RebaselineQueueServer/handlers/__init__.py: Added. 1019 * RebaselineQueueServer/handlers/builderqueue.py: Added. 1020 * RebaselineQueueServer/handlers/pages.py: Added. 1021 * RebaselineQueueServer/index.yaml: Added. 1022 * RebaselineQueueServer/main.py: Added. 1023 * RebaselineQueueServer/model/__init__.py: Added. 1024 * RebaselineQueueServer/model/queueentry.py: Added. 1025 * RebaselineQueueServer/static/builder-frame-empty.html: Added. 1026 * RebaselineQueueServer/static/styles.css: Added. 1027 * RebaselineQueueServer/templates/builder-picker.html: Added. 1028 * RebaselineQueueServer/templates/builder-queue-edit.html: Added. 1029 * RebaselineQueueServer/templates/builder-queue-list.html: Added. 1030 * RebaselineQueueServer/templates/home.html: Added. 1031 10322011-04-13 Dirk Pranke <dpranke@chromium.org> 1033 1034 Reviewed by Mihai Parparita. 1035 1036 nrwt: enable multiple processes by default on Chromium Win. 1037 https://bugs.webkit.org/show_bug.cgi?id=55163 1038 1039 Re-land r79268; it should be more stable now and will hopefully 1040 work. 1041 1042 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 1043 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 1044 10452011-04-13 Dirk Pranke <dpranke@chromium.org> 1046 1047 Reviewed by Ojan Vafai. 1048 1049 new-run-webkit-tests: configure logging in child processes properly 1050 https://bugs.webkit.org/show_bug.cgi?id=58296 1051 1052 Logging propagated properly from manager to worker processes on 1053 Unix but not on Windows; this fixes that. 1054 1055 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: 1056 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: 1057 10582011-04-13 Dirk Pranke <dpranke@chromium.org> 1059 1060 Reviewed by Ojan Vafai. 1061 1062 new-run-webkit-tests: suppress extraneous pretty patch warnings 1063 https://bugs.webkit.org/show_bug.cgi?id=58295 1064 1065 NRWT wasn't being careful about when it logged messages from 1066 PrettyPatch not being available; it should only log during 1067 check_build(), and be silent otherwise. This was causing us to 1068 get multiple errors at runtime, which was confusing. 1069 1070 * Scripts/webkitpy/layout_tests/port/base.py: 1071 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 1072 * Scripts/webkitpy/layout_tests/port/chromium.py: 1073 10742011-04-13 Dirk Pranke <dpranke@chromium.org> 1075 1076 Reviewed by Jian Li. 1077 1078 add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests 1079 https://bugs.webkit.org/show_bug.cgi?id=58461 1080 1081 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 1082 10832011-04-13 Tony Chang <tony@chromium.org> 1084 1085 Unreviewed, fix NRWT. Stack: 1086 1087 return super(ChromiumPort, self).results_directory(self) 1088 TypeError: results_directory() takes exactly 1 argument (2 given) 1089 1090 * Scripts/webkitpy/layout_tests/port/chromium.py: 1091 10922011-04-13 Adam Roben <aroben@apple.com> 1093 1094 Teach ORWT about extra platform-specific directories to be searched before the default ones 1095 1096 Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for 1097 platform-specific results 1098 1099 Reviewed by Anders Carlsson. 1100 1101 * Scripts/old-run-webkit-tests: 1102 (top-level): Added @additionalPlatformDirectories and hooked up 1103 --additional-platform-directories to populate it. 1104 (buildPlatformResultHierarchy): Prepend the additional platform directories to the default 1105 list (after filtering out any of the additional directories that don't exist). 1106 11072011-04-13 Lucas Forschler <lforschler@apple.com> 1108 1109 Reviewed by Adam Roben. 1110 1111 Add the /T command to taskkill.exe. 1112 This will kill spawned child processes. 1113 1114 * BuildSlaveSupport/win/kill-old-processes: 1115 11162011-04-13 Lucas Forschler <lforschler@apple.com> 1117 1118 Reviewed by Adam Roben. 1119 1120 Sort kill list alphabeticaly. 1121 Fixed capitalization on VcBuildHelper. 1122 1123 * BuildSlaveSupport/win/kill-old-processes: 1124 11252011-04-13 Lucas Forschler <lforschler@apple.com> 1126 1127 Reviewed by Adam Roben. 1128 1129 https://bugs.webkit.org/show_bug.cgi?id=58384 1130 Update kill-old-processes to include a few new ones. 1131 1132 * BuildSlaveSupport/win/kill-old-processes: 1133 11342011-04-13 Gustavo Noronha Silva <gns@gnome.org> 1135 1136 Reviewed by Martin Robinson. 1137 1138 [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself 1139 https://bugs.webkit.org/show_bug.cgi?id=58297 1140 1141 Do not disable flash specifically when built with GTK+ 3 - 1142 PluginPackage should do the right thing while loading plugins. 1143 1144 * GtkLauncher/main.c: 1145 (main): 1146 11472011-04-12 Kent Tamura <tkent@chromium.org> 1148 1149 Reviewed by Dimitri Glazkov. 1150 1151 [Chromium] Add WebSettings::setValidationMessageTimerMagnification() 1152 https://bugs.webkit.org/show_bug.cgi?id=57426 1153 1154 * DumpRenderTree/chromium/WebPreferences.cpp: 1155 (WebPreferences::applyTo): Disable the validation message timer. 1156 11572011-04-12 James Kozianski <koz@chromium.org> 1158 1159 Unreviewed. 1160 1161 Adding myself to committers.py. 1162 1163 * Scripts/webkitpy/common/config/committers.py: 1164 11652011-04-12 Brent Fulgham <bfulgham@webkit.org> 1166 1167 Unreviewed build correction for WinCairo bot after r83639. 1168 https://bugs.webkit.org/show_bug.cgi?id=51790 1169 1170 Correct typo for the new "update-webkit-wincairo-libs" script. 1171 1172 * Scripts/build-webkit: Incorrectly calling the 1173 update-webkit-cairo-libs which does not exist. 1174 11752011-04-12 Alice Liu <alice.liu@apple.com> 1176 1177 Reviewed by Jon Honeycutt. 1178 1179 A change that should have been part of http://trac.webkit.org/changeset/83628 1180 1181 * DumpRenderTree/win/DumpRenderTree.cpp: 1182 (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false. 1183 11842011-04-12 Dirk Pranke <dpranke@chromium.org> 1185 1186 Reviewed by Tony Chang. 1187 1188 new-run-webkit-tests: --results-directory is relative to builddir, not $PWD 1189 https://bugs.webkit.org/show_bug.cgi?id=58272 1190 1191 NRWT was interpreting the --results-directory cmd line arg as 1192 relative to the build directory, not the current working 1193 directory (ORWT uses the latter, which is much more intuitive). 1194 1195 This patch fixes the base case, but includes an override for 1196 Chromium that is needed until the bots can be updated. 1197 1198 * Scripts/webkitpy/layout_tests/port/base.py: 1199 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 1200 * Scripts/webkitpy/layout_tests/port/chromium.py: 1201 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 1202 * Scripts/webkitpy/layout_tests/port/test.py: 1203 * Scripts/webkitpy/layout_tests/port/webkit.py: 1204 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 1205 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 1206 12072011-04-12 Philippe Normand <pnormand@igalia.com> 1208 1209 Unreviewed, roll out r83621 as it broke the GTK build. 1210 1211 [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account 1212 https://bugs.webkit.org/show_bug.cgi?id=58333 1213 1214 * Scripts/build-jsc: 1215 * Scripts/build-webkit: 1216 12172011-04-12 Carl Lobo <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org> 1218 1219 Reviewed by Adam Roben. 1220 1221 Patch to download the WinCairo dependancies as part of build-webkit. 1222 https://bugs.webkit.org/show_bug.cgi?id=51790 1223 1224 This patch downloads the dependancies from 1225 http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 1226 checking the modification timestamp etc. 1227 1228 * Tools/Scripts/build-webkit 1229 * Tools/Scripts/update-webkit: Modified to understand the --wincairo 1230 flag, and to update WinCairo dependencies when used. 1231 * Tools/Scripts/update-webkit-cairo-libs: added 1232 * Tools/Scripts/update-webkit-dependency: added 1233 * Tools/Scripts/update-webkit-auxiliary-libs 1234 12352011-04-12 Jeff Miller <jeffm@apple.com> 1236 1237 Reviewed by Adam Roben. 1238 1239 WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options 1240 https://bugs.webkit.org/show_bug.cgi?id=56020 1241 1242 Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view, 1243 since WebKit will do this for us. If we didn't do this, TranslateMessage() would be called twice, 1244 which would generate two characters for every keypress (for example). I didn't bother doing this for 1245 WebKitTestRunner, since it doesn't get any WM_KEYDOWN events. 1246 1247 Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior. 1248 1249 * MiniBrowser/win/main.cpp: 1250 (shouldTranslateMessage): Added. 1251 (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to. 1252 * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows. 1253 * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown(). 1254 * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added. 1255 (TestWebKitAPI::didNotHandleKeyEventCallback): Added. 1256 (TestWebKitAPI::runAndWatchForWMChar): Added. 1257 (TestWebKitAPI::TEST): Added. 1258 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: 1259 (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to. 1260 (TestWebKitAPI::Util::shouldTranslateMessage): Added. 1261 * TestWebKitAPI/win/PlatformWebViewWin.cpp: 1262 (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added. 1263 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp. 1264 12652011-04-12 Dirk Pranke <dpranke@chromium.org> 1266 1267 Reviewed by Tony Chang. 1268 1269 new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory 1270 https://bugs.webkit.org/show_bug.cgi?id=58290 1271 1272 This is some preliminary refactoring for bug 58272. 1273 1274 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 1275 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: 1276 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 1277 * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: 1278 * Scripts/webkitpy/layout_tests/port/test.py: 1279 * Scripts/webkitpy/layout_tests/port/chromium.py: 1280 * Scripts/webkitpy/layout_tests/port/base.py: 1281 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 1282 12832011-04-12 Dirk Pranke <dpranke@chromium.org> 1284 1285 Reviewed by Eric Seidel. 1286 1287 webkitpy: fix mock_filesystem abspath to handle relative paths 1288 and add filesystem.chdir() and filesystem.getcwd() to be able 1289 to test this and mock it out. 1290 1291 https://bugs.webkit.org/show_bug.cgi?id=58288 1292 1293 * Scripts/webkitpy/common/system/filesystem.py: 1294 * Scripts/webkitpy/common/system/filesystem_mock.py: 1295 * Scripts/webkitpy/common/system/filesystem_unittest.py: 1296 12972011-04-12 Alice Liu <alice.liu@apple.com> 1298 1299 Reviewed by Sam Weinig. 1300 1301 https://bugs.webkit.org/show_bug.cgi?id=58292 1302 Provide new setting to allow site icon loading despite disabling automatic image loading in general. 1303 1304 * DumpRenderTree/mac/DumpRenderTree.mm: 1305 (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false. 1306 13072011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com> 1308 1309 Reviewed by Eric Seidel. 1310 1311 [Qt] Enable JIT build for SH4 platforms. 1312 https://bugs.webkit.org/show_bug.cgi?id=58317 1313 1314 1315 * DumpRenderTree/qt/DumpRenderTree.pro: 1316 * QtTestBrowser/QtTestBrowser.pro: 1317 * Scripts/webkitdirs.pm: 1318 13192011-04-12 Tony Chang <tony@chromium.org> 1320 1321 Reviewed by Andreas Kling. 1322 1323 [Qt] embed checksums in PNGs written by Qt-DRT 1324 https://bugs.webkit.org/show_bug.cgi?id=58173 1325 1326 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 1327 (WebCore::DumpRenderTree::dump): 1328 13292011-04-12 Eric Seidel <eric@webkit.org> 1330 1331 Reviewed by Adam Barth. 1332 1333 commit-queue should upload failure diffs when tests fail 1334 https://bugs.webkit.org/show_bug.cgi?id=58348 1335 1336 This change was mostly just plumbing. We were already saving 1337 this information for flaky test reporting. I just made it possible 1338 for normal failures to report archives as well. 1339 1340 I did a little abstraction work to try and share some code between 1341 flakytestreporter.py and this new code. There is still more we could do. 1342 1343 In making this change I also went through and updated the various 1344 places we have urls hard-coded in our python and pointed them at 1345 common.config.urls. 1346 1347 * Scripts/webkitpy/common/checkout/scm.py: 1348 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 1349 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 1350 * Scripts/webkitpy/common/net/statusserver.py: 1351 * Scripts/webkitpy/layout_tests/port/base.py: 1352 * Scripts/webkitpy/tool/bot/botinfo.py: Added. 1353 * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added. 1354 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 1355 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 1356 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: 1357 * Scripts/webkitpy/tool/commands/queues.py: 1358 13592011-04-12 Daniel Bates <dbates@rim.com> 1360 1361 Rubber-stamped by Eric Seidel. 1362 1363 svn-apply and/or patch(1) has trouble applying patches that makes changes to files 1364 with Windows line endings 1365 https://bugs.webkit.org/show_bug.cgi?id=53625 1366 1367 Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be 1368 applied to an SCM checkout on a Windows file system and vice-versa. 1369 1370 This issue manifests itself due to custom SCM settings as well as differences in 1371 gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support 1372 into svn-apply/unapply to compensate for differences in line endings by converting 1373 the line endings in a patch to match the line endings in the target file (if it exists). 1374 1375 * Scripts/VCSUtils.pm: 1376 - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the 1377 content read from the specified file handle. Obviously, this heuristic will not work 1378 for files with mixed line endings, but I don't envision such files to be the norm. If 1379 this turns out to be an issue then we can improve the heuristic. 1380 - Added firstEOLInFile(). 1381 - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash. 1382 In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line 1383 endings in the diff instead of the line endings in the target file. 1384 - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be 1385 re-used in parseDiff(). 1386 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1} 1387 to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use 1388 mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl. 1389 * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added. 1390 * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added. 1391 13922011-04-12 Sam Weinig <sam@webkit.org> 1393 1394 Reviewed by Adam Roben. 1395 1396 REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests) 1397 https://bugs.webkit.org/show_bug.cgi?id=58336 1398 1399 * WebKitTestRunner/TestController.cpp: 1400 (WTR::TestController::resetStateToConsistentValues): 1401 Remove cache clearing as that is causing tests to crash on Windows 7. 1402 14032011-04-11 Sam Weinig <sam@webkit.org> 1404 1405 Reviewed by Anders Carlsson. 1406 1407 REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing 1408 <rdar://problem/8981346> 1409 https://bugs.webkit.org/show_bug.cgi?id=54159 1410 1411 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 1412 (WTR::InjectedBundlePage::InjectedBundlePage): 1413 (WTR::InjectedBundlePage::decidePolicyForNavigationAction): 1414 (WTR::InjectedBundlePage::decidePolicyForNewWindowAction): 1415 (WTR::InjectedBundlePage::decidePolicyForResponse): 1416 (WTR::InjectedBundlePage::unableToImplementPolicy): 1417 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: 1418 Add short-circuited policy client which matches WebKit1. 1419 1420 * WebKitTestRunner/TestController.cpp: 1421 (WTR::TestController::resetStateToConsistentValues): 1422 Clear the cache between tests to ensure consistent results. 1423 14242011-04-11 George Guo <George.Guo@nokia.com> 1425 1426 Reviewed by Eric Seidel. 1427 1428 prepare-ChangeLog support email input but -h did not show the option 1429 https://bugs.webkit.org/show_bug.cgi?id=58164 1430 1431 Add email option to -h to improve the usability 1432 1433 * Scripts/prepare-ChangeLog: 1434 14352011-04-11 Dimitri Glazkov <dglazkov@chromium.org> 1436 1437 Reviewed by Eric Carlson. 1438 1439 Rename MediaControls to MediaControlRootElement. 1440 https://bugs.webkit.org/show_bug.cgi?id=58250 1441 1442 * Scripts/do-webcore-rename: Documented the renaming. 1443 14442011-04-11 Sam Weinig <sam@webkit.org> 1445 1446 Fix Windows build. 1447 1448 * MiniBrowser/win/BrowserView.cpp: 1449 (BrowserView::create): 1450 14512011-04-11 Sam Weinig <sam@webkit.org> 1452 1453 Reviewed by Anders Carlsson. 1454 1455 Move focus management out of WebKit via the UIClient 1456 <rdar://problem/8784068> 1457 https://bugs.webkit.org/show_bug.cgi?id=58278 1458 1459 * MiniBrowser/mac/BrowserWindowController.m: 1460 (-[BrowserWindowController awakeFromNib]): 1461 * WebKitTestRunner/TestController.cpp: 1462 (WTR::TestController::createOtherPage): 1463 (WTR::TestController::initialize): 1464 Add stubs for new UIClient functions. 1465 14662011-02-03 Martin Robinson <mrobinson@igalia.com> 1467 1468 Reviewed by Eric Seidel. 1469 1470 [GTK] The GTK+ DRT needs an implementation of the PlainTextController 1471 https://bugs.webkit.org/show_bug.cgi?id=53605 1472 1473 Add an implementation of the PlainTextController for the GTK+ DRT. 1474 1475 * DumpRenderTree/gtk/DumpRenderTree.cpp: 1476 (addControllerToWindow): Added this helper method. 1477 (webViewWindowObjectCleared): Use the new helper to add EventSender 1478 and the PlainTextController to the window object. 1479 * GNUmakefile.am: Added PlainTextController source files. 1480 * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely 1481 on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange 1482 until that functionality exists somewhere in the WebKitGTK+ stack. 1483 * DumpRenderTree/gtk/PlainTextController.h: Added. 1484 14852011-04-11 Yael Aharon <yael.aharon@nokia.com> 1486 1487 Unreviewed. 1488 1489 Adding my IRC nick. 1490 1491 * Scripts/webkitpy/common/config/committers.py: 1492 14932011-04-11 Dirk Pranke <dpranke@chromium.org> 1494 1495 Reviewed by Adam Roben. 1496 1497 new-run-webkit-tests: fix crash when running under windows cmd.exe 1498 https://bugs.webkit.org/show_bug.cgi?id=58197 1499 1500 We would intermittently crash when running NRWT directly under 1501 cmd.exe on windows because we were sharing the stdin file 1502 descriptor between the python process and the http server. 1503 cmd.exe really didn't like that, and there was no reason to 1504 share the descriptor, so we now use a PIPE instead. 1505 1506 * Scripts/webkitpy/layout_tests/port/http_server.py: 1507 15082011-04-11 Dirk Pranke <dpranke@chromium.org> 1509 1510 Reviewed by Ojan Vafai. 1511 1512 new-run-webkit-tests: add unit tests for Port.diff_image() 1513 https://bugs.webkit.org/show_bug.cgi?id=58196 1514 1515 Add the unit tests for the fix in bug 58195. 1516 1517 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 1518 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 1519 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: 1520 15212011-04-11 Dirk Pranke <dpranke@chromium.org> 1522 1523 Reviewed by Tony Chang. 1524 1525 new-run-webkit-tests: implement support for audio, take two 1526 https://bugs.webkit.org/show_bug.cgi?id=58195 1527 1528 Attempt to re-land the fix for bug 58101 (which was initially 1529 landed in r83330, but rolled out). This is the same patch but 1530 fixes crashes in Port.diff_image() caused by the change for 1531 empty image files being None instead of ''. 1532 1533 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 1534 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 1535 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 1536 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 1537 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: 1538 * Scripts/webkitpy/layout_tests/port/base.py: 1539 * Scripts/webkitpy/layout_tests/port/chromium.py: 1540 * Scripts/webkitpy/layout_tests/port/dryrun.py: 1541 * Scripts/webkitpy/layout_tests/port/mock_drt.py: 1542 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 1543 * Scripts/webkitpy/layout_tests/port/test.py: 1544 * Scripts/webkitpy/layout_tests/port/webkit.py: 1545 15462011-04-11 Mario Sanchez Prada <msanchez@igalia.com> 1547 1548 Reviewed by Xan Lopez. 1549 1550 [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT 1551 https://bugs.webkit.org/show_bug.cgi?id=57854 1552 1553 Implement missing features in GTK's DRT. 1554 1555 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 1556 (indexRangeInTable): New helper function to get the range string 1557 for the current cell inside the parent table, either from the 1558 point of view of rows or columns. 1559 (AccessibilityUIElement::rowIndexRange): Implemented by relying on 1560 the new helper function indexRangeInTable(). 1561 (AccessibilityUIElement::columnIndexRange): Ditto. 1562 15632011-04-11 Mario Sanchez Prada <msanchez@igalia.com> 1564 1565 Reviewed by Chris Fleizach. 1566 1567 [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT 1568 https://bugs.webkit.org/show_bug.cgi?id=57826 1569 1570 Implement missing feature in GTK's DRT. 1571 1572 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 1573 (AccessibilityUIElement::cellForColumnAndRow): Implemented, by 1574 relying on the analogous function from the AtkTable interface. 1575 15762011-04-05 Timothy Hatcher <timothy@apple.com> 1577 1578 Fix the extract-localizable-strings script errors that started after 1579 WEB_UI_STRING was added to LocalizedStrings.h in WebCore. 1580 1581 * Scripts/extract-localizable-strings: Skip LocalizedStrings.h. 1582 15832011-04-11 Tony Chang <tony@chromium.org> 1584 1585 Reviewed by Eric Seidel. 1586 1587 fix crc computation on 64 bit machines 1588 https://bugs.webkit.org/show_bug.cgi?id=58243 1589 1590 unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits 1591 1592 * DumpRenderTree/CyclicRedundancyCheck.cpp: 1593 (makeCrcTable): 1594 (computeCrc): 1595 * DumpRenderTree/CyclicRedundancyCheck.h: 1596 * DumpRenderTree/PixelDumpSupport.cpp: 1597 (appendIntToVector): 1598 (convertChecksumToPNGComment): 1599 16002011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com> 1601 1602 Reviewed by Eric Seidel. 1603 1604 Require no undefined symbols during compilation. 1605 1606 [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols 1607 https://bugs.webkit.org/show_bug.cgi?id=54896 1608 1609 Add -Wl,--no-undefined to catch missing symbols early. 1610 1611 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 1612 * WebKitTestRunner/qt/WebKitTestRunner.pro: 1613 16142011-04-10 Kevin Ollivier <kevino@theolliviers.com> 1615 1616 [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs. 1617 1618 * wx/build/settings.py: 1619 16202011-04-10 Kevin Ollivier <kevino@theolliviers.com> 1621 1622 [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories. 1623 1624 * wx/build/settings.py: 1625 16262011-04-10 David Levin <levin@chromium.org> 1627 1628 Reviewed by Dimitri Glazkov. 1629 1630 REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux. 1631 https://bugs.webkit.org/show_bug.cgi?id=58201 1632 1633 * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now, 1634 and filed bug 58202. 1635 16362011-04-09 David Levin <levin@chromium.org> 1637 1638 Unreviewed, rolling out r83394. 1639 http://trac.webkit.org/changeset/83394 1640 https://bugs.webkit.org/show_bug.cgi?id=53625 1641 1642 Patch was incorrect as noted in the bug. 1643 1644 * Scripts/svn-apply: 1645 16462011-04-09 David Levin <levin@chromium.org> 1647 1648 Reviewed by Adam Barth. 1649 1650 svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings 1651 https://bugs.webkit.org/show_bug.cgi?id=53625 1652 1653 * Scripts/svn-apply: Ensure that the portions of patches 1654 which are for vcproj/vsprops files has DOS line endings. 1655 16562011-04-09 Dirk Pranke <dpranke@chromium.org> 1657 1658 Reviewed by Tony Chang. 1659 1660 It looks like NRWT has not been stopping DRT/TestShell 1661 instances properly on windows, probably for a long time. 1662 This would go a long way to explaining why we often have 1663 processes lying around :) 1664 1665 https://bugs.webkit.org/show_bug.cgi?id=57807 1666 1667 * Scripts/webkitpy/layout_tests/port/chromium.py: 1668 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 1669 16702011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com> 1671 1672 Reviewed by Laszlo Gombos. 1673 1674 [Qt] Don't link against fontconfig or X11 if embedded 1675 https://bugs.webkit.org/show_bug.cgi?id=58104 1676 1677 * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded 1678 * QtTestBrowser/QtTestBrowser.pro: ditto 1679 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto 1680 * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto 1681 16822011-04-08 Jon Honeycutt <jhoneycutt@apple.com> 1683 1684 http/tests/loading/preload-append-scan.php is failing on Windows 1685 https://bugs.webkit.org/show_bug.cgi?id=58178 1686 1687 Reviewed by Brian Weinstein. 1688 1689 * DumpRenderTree/win/DumpRenderTree.cpp: 1690 (lastPathComponent): 1691 Use CFURL API to find the last path component, rather than 1692 PathFindFileName(), because the latter will include the query string. 1693 16942011-04-08 Jian Li <jianli@chromium.org> 1695 1696 Unreviewed, rolling out r83327, r83330 since these patches are very 1697 likely to break chromium webkit mac10.6 builders. 1698 1699 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 1700 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 1701 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 1702 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 1703 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: 1704 * Scripts/webkitpy/layout_tests/port/base.py: 1705 * Scripts/webkitpy/layout_tests/port/chromium.py: 1706 * Scripts/webkitpy/layout_tests/port/dryrun.py: 1707 * Scripts/webkitpy/layout_tests/port/mock_drt.py: 1708 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 1709 * Scripts/webkitpy/layout_tests/port/test.py: 1710 * Scripts/webkitpy/layout_tests/port/webkit.py: 1711 17122011-04-08 Vincent Scheib <scheib@chromium.org> 1713 1714 Reviewed by Eric Seidel. 1715 1716 add chromium-gpu-linux-x86_64 to the recognized list of ports 1717 https://bugs.webkit.org/show_bug.cgi?id=58099 1718 1719 Add chromium-gpu-linux-x86_64 to fix assert. 1720 1721 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 1722 17232011-04-08 Alpha Lam <hclam@chromium.org> 1724 1725 Unreviewed, rolling out r83335. 1726 http://trac.webkit.org/changeset/83335 1727 https://bugs.webkit.org/show_bug.cgi?id=53556 1728 1729 GTK and QT bots are broken 1730 1731 * Scripts/build-webkit: 1732 17332011-04-07 Anna Cavender <annacc@chromium.org> 1734 1735 Reviewed by Eric Carlson. 1736 1737 Setup ENABLE(TRACK) feature define 1738 https://bugs.webkit.org/show_bug.cgi?id=53556 1739 1740 * Scripts/build-webkit: 1741 17422011-04-08 Dirk Pranke <dpranke@chromium.org> 1743 1744 Reviewed by Adam Roben. 1745 1746 new-run-webkit-tests: configure a NRWT test bot for Mac SL 1747 https://bugs.webkit.org/show_bug.cgi?id=58114 1748 1749 This change removes the old new-run-webkit-tests entry and 1750 updates it for a new test-only bot. 1751 1752 * BuildSlaveSupport/build.webkit.org-config/config.json: 1753 17542011-04-08 Dominic Cooney <dominicc@google.com> 1755 1756 Reviewed by Adam Roben. 1757 1758 Make layoutTestController.shadowRoot return null, not undefined, 1759 when its argument is invalid. 1760 https://bugs.webkit.org/show_bug.cgi?id=58121 1761 1762 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 1763 (LayoutTestController::shadowRoot): 1764 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 1765 (WTR::LayoutTestController::shadowRoot): 1766 17672011-04-08 Pere Martir <pere.martir4@gmail.com> 1768 1769 Reviewed by Adam Roben. 1770 1771 Locate NSTD.EXE in 64-bit Windows 1772 https://bugs.webkit.org/show_bug.cgi?id=57847 1773 1774 * Scripts/old-run-webkit-tests: 1775 17762011-04-08 Adam Roben <aroben@apple.com> 1777 1778 Qt build fix 1779 1780 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list. 1781 17822011-04-07 Adam Roben <aroben@apple.com> 1783 1784 Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms 1785 1786 Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a 1787 plugin 1788 1789 Reviewed by Anders Carlsson. 1790 1791 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: 1792 (pluginLogWithArguments): Moved code to format and log the message here... 1793 (pluginLog): ...from here. 1794 1795 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments. 1796 1797 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 1798 (PluginTest::log): Added. Calls through to pluginLogWithArguments. 1799 1800 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log. 1801 1802 * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added. 1803 (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about 1804 to begin. 1805 (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple 1806 constructor. 1807 (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that 1808 can be used to invoke our setWillBeDestroyed function. 1809 (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if 1810 anything unexpected happens). 1811 (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if 1812 NPP_SetWindow was called during destruction. On other platforms, logs a failure message if 1813 NPP_SetWindow was *not* called during destruction. 1814 (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only 1815 method, setWillBeDestroyed. 1816 (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest 1817 object. 1818 1819 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 1820 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 1821 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 1822 * GNUmakefile.am: 1823 Added new test. 1824 1825 * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with 1826 WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>. 1827 18282011-04-08 Mario Sanchez Prada <msanchez@igalia.com> 1829 1830 Reviewed by Martin Robinson. 1831 1832 [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement 1833 https://bugs.webkit.org/show_bug.cgi?id=58039 1834 1835 Implement missing functions in GTK's DRT. 1836 1837 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 1838 (AccessibilityUIElement::increment): Implemented. 1839 (AccessibilityUIElement::decrement): Implemented. 1840 18412011-04-08 Dominic Cooney <dominicc@google.com> 1842 1843 Reviewed by Kent Tamura. 1844 1845 Make WK2 layoutTestController.shadowRoot return undefined, not 1846 null, when its argument is not an element. 1847 https://bugs.webkit.org/show_bug.cgi?id=58121 1848 1849 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 1850 (WTR::LayoutTestController::shadowRoot): 1851 18522011-04-07 Dirk Pranke <dpranke@chromium.org> 1853 1854 Reviewed by Mihai Parparita. 1855 1856 Change reference port for Mac GPU baselines from 1857 Leopard to SnowLeopard, XP to Win7, and Linux-x86 1858 to Linux x86-64. 1859 1860 https://bugs.webkit.org/show_bug.cgi?id=58099 1861 1862 * Scripts/webkitpy/layout_tests/port/chromium.py: 1863 18642011-04-07 Andrew Scherkus <scherkus@chromium.org> 1865 1866 Revert ENABLE_TRACK patch due to compile failures. 1867 1868 * Scripts/build-webkit: 1869 18702011-04-07 Tony Chang <tony@chromium.org> 1871 1872 Reviewed by Eric Seidel. 1873 1874 update DRT to embed checksums in png files 1875 https://bugs.webkit.org/show_bug.cgi?id=57871 1876 1877 We insert the bytes for the comment in printPNG rather than at encode 1878 time because each platform does its own PNG encoding (either using CG 1879 or cairo). Putting this in pringPNG avoids having to duplicate this 1880 code, although it's not as clean as doing it at encoding time. 1881 1882 We insert the comment right after the IHDR chunk of the PNG. 1883 1884 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 1885 * DumpRenderTree/CyclicRedundancyCheck.cpp: Added. 1886 (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js 1887 (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js 1888 * DumpRenderTree/CyclicRedundancyCheck.h: Added. 1889 * DumpRenderTree/PixelDumpSupport.cpp: 1890 (dumpWebViewAsPixelsAndCompareWithExpected): 1891 (convertChecksumToPNGComment): Generate the bytes to insert. 1892 (printPNG): Insert the png comment before the first IDAT section. 1893 * DumpRenderTree/PixelDumpSupport.h: 1894 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: 1895 (printPNG): 1896 (dumpBitmap): 1897 * DumpRenderTree/cg/PixelDumpSupportCG.cpp: 1898 (printPNG): 1899 (dumpBitmap): 1900 * DumpRenderTree/win/DumpRenderTree.vcproj: 1901 * GNUmakefile.am: 1902 19032011-04-07 Jeff Miller <jeffm@apple.com> 1904 1905 Reviewed by Adam Roben. 1906 1907 Replace WKStringGetCharactersPtr() with WKStringGetCharacters() 1908 https://bugs.webkit.org/show_bug.cgi?id=58058 1909 1910 * TestWebKitAPI/Tests/WebKit2/WKString.cpp: 1911 (TestWebKitAPI::TEST): Add tests for WKStringGetLength() and WKStringGetCharactersPtr(). 1912 19132011-04-07 Chang Shu <cshu@webkit.org> 1914 1915 Reviewed by Darin Adler. 1916 1917 WebKitTestRunner needs layoutTestController.isPageBoxVisible 1918 https://bugs.webkit.org/show_bug.cgi?id=42695 1919 1920 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 1921 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 1922 (WTR::LayoutTestController::isPageBoxVisible): 1923 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 1924 19252011-04-07 Adam Roben <aroben@apple.com> 1926 1927 Build fix 1928 1929 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import. 1930 19312011-04-07 Adam Roben <aroben@apple.com> 1932 1933 Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished() 1934 1935 commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks]. 1936 (Unfortunately the buildbot documentation does not make this clear.) finished() is the only 1937 hook we have, so we have to do our work there. I added a new addCustomURLs method which can 1938 be overridden by subclasses to provide extra URLs before we call up to the base class (after 1939 which adding more URLs is no longer possible). 1940 1941 Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks 1942 bot results page 1943 1944 Reviewed by John Sullivan. 1945 1946 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 1947 (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here... 1948 (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that 1949 method is never called for MasterShellCommands. 1950 (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called) 1951 with this method (which is). 1952 19532011-04-07 Adam Roben <aroben@apple.com> 1954 1955 Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete() 1956 1957 This matches how most of our other build steps work, so is good just for improving 1958 consistency between build steps. It should also make it possible for 1959 ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were 1960 trying to do this in finished() after we had called up to the base class, but that was 1961 apparently too late to add more URLs.) 1962 1963 Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot 1964 results page 1965 1966 Reviewed by John Sullivan. 1967 1968 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 1969 (ExtractTestResults): Added a descriptionDone property so that we don't have to manually 1970 call setText to get the right text to show up for this step. This matches how most of our 1971 other build steps work. 1972 (ExtractTestResults.commandComplete): Replaced our override of finished with this function. 1973 This is how most of our other build steps work. 1974 (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this 1975 function, to match the base class. 1976 19772011-04-07 Adam Barth <abarth@webkit.org> 1978 1979 Reviewed by Maciej Stachowiak. 1980 1981 webkit-patch shouldn't state the whole working copy when calling check-webkit-style 1982 https://bugs.webkit.org/show_bug.cgi?id=58022 1983 1984 Previously, we were ignoring the args variable! This patch fixes the 1985 regression introduced in http://trac.webkit.org/changeset/82771. 1986 1987 * Scripts/webkitpy/tool/commands/download_unittest.py: 1988 * Scripts/webkitpy/tool/mocktool.py: 1989 * Scripts/webkitpy/tool/steps/checkstyle.py: 1990 19912011-04-07 Maciej Stachowiak <mjs@apple.com> 1992 1993 Reviewed by Adam Barth. 1994 1995 REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories 1996 https://bugs.webkit.org/show_bug.cgi?id=58017 1997 1998 * Scripts/webkitpy/common/checkout/scm.py: 1999 * Scripts/webkitpy/common/checkout/scm_unittest.py: 2000 20012011-04-06 Chang Shu <cshu@webkit.org> 2002 2003 Reviewed by Darin Adler. 2004 2005 WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels 2006 https://bugs.webkit.org/show_bug.cgi?id=57984 2007 2008 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2009 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2010 (WTR::LayoutTestController::pageSizeAndMarginsInPixels): 2011 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2012 20132011-04-06 Chris Rogers <crogers@google.com> 2014 2015 Reviewed by Tony Chang. 2016 2017 Add web audio support to DumpRenderTree (mac port) 2018 https://bugs.webkit.org/show_bug.cgi?id=57969 2019 2020 * DumpRenderTree/LayoutTestController.cpp: 2021 (LayoutTestController::LayoutTestController): 2022 (setEncodedAudioDataCallback): 2023 (LayoutTestController::staticFunctions): 2024 * DumpRenderTree/LayoutTestController.h: 2025 (LayoutTestController::dumpAsAudio): 2026 (LayoutTestController::setDumpAsAudio): 2027 (LayoutTestController::encodedAudioData): 2028 (LayoutTestController::setEncodedAudioData): 2029 * DumpRenderTree/mac/DumpRenderTree.mm: 2030 (dumpAudio): 2031 (dump): 2032 20332011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com> 2034 2035 Reviewed by Kenneth Rohde Christiansen. 2036 2037 [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests 2038 https://bugs.webkit.org/show_bug.cgi?id=56086 2039 2040 Add the missing method. 2041 2042 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 2043 (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test. 2044 * DumpRenderTree/qt/DumpRenderTreeQt.h: 2045 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 2046 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 2047 20482011-04-06 Dai Mikurube <dmikurube@chromium.org> 2049 2050 Reviewed by David Levin. 2051 2052 Add QUOTA build flag for unified quota API 2053 https://bugs.webkit.org/show_bug.cgi?id=57918 2054 2055 * Scripts/build-webkit: Added QUOTA build flag 2056 20572011-04-06 Dirk Pranke <dpranke@chromium.org> 2058 2059 Reviewed by Tony Chang. 2060 2061 Adjust the apple webkit port's default timeout to match 2062 old-run-webkit-tests at 35 seconds. 2063 2064 https://bugs.webkit.org/show_bug.cgi?id=37738 2065 2066 * Scripts/webkitpy/layout_tests/port/mac.py: 2067 20682011-04-06 Scott Cameron <sccameron@rim.com> 2069 2070 Reviewed by Eric Seidel. 2071 2072 Remove global variable $httpdPath and replace with the return value of 2073 getHTTPDPath(). Also remove unnecessary calls to getHTTPDPath(). 2074 https://bugs.webkit.org/show_bug.cgi?id=53499 2075 2076 * Scripts/run-iexploder-tests: 2077 * Scripts/webkitperl/httpd.pm: 2078 20792011-04-06 Kevin Ollivier <kevino@theolliviers.com> 2080 2081 Reviewed by Darin Adler. 2082 2083 Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros. 2084 2085 https://bugs.webkit.org/show_bug.cgi?id=27551 2086 2087 * DumpRenderTree/config.h: 2088 * WebKitAPITest/config.h: 2089 * WebKitTestRunner/config.h: 2090 20912011-04-06 Tony Chang <tony@chromium.org> 2092 2093 Reviewed by Darin Adler. 2094 2095 teach run-webkit-tests to read checksums from png files 2096 https://bugs.webkit.org/show_bug.cgi?id=57993 2097 2098 * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's 2099 no .checksum and look for the checksum in there. 2100 21012011-04-06 David Dorwin <ddorwin@chromium.org> 2102 2103 Reviewed by David Levin. 2104 2105 Enable fullscreen layout tests for Chromium 2106 https://bugs.webkit.org/show_bug.cgi?id=55726 2107 2108 Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen). 2109 2110 * DumpRenderTree/chromium/WebPreferences.cpp: 2111 (WebPreferences::applyTo): 2112 21132011-04-06 Adam Roben <aroben@apple.com> 2114 2115 Add a "view leaks" link to builds on SnowLeopard Intel Leaks 2116 2117 Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page 2118 2119 Reviewed by David Kilzer. 2120 2121 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 2122 (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the 2123 build's results directory here... 2124 (ExtractTestResults.finished): ...from here. 2125 (ExtractTestResultsAndLeaks): New class that's used by the leaks builder 2126 (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view 2127 leaks" link to point to Leaks Viewer for this build. 2128 (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere, 2129 but it seemed good to add for consistency with BuildAndTestFactory. 2130 (BuildAndTestFactory): Added ExtractTestResultsClass abstraction. 2131 (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so 2132 that we'll get a "view leaks" link. 2133 21342011-04-06 Zan Dobersek <zandobersek@gmail.com> 2135 2136 Reviewed by Eric Seidel. 2137 2138 [Gtk] plugins/set-status.html fails 2139 https://bugs.webkit.org/show_bug.cgi?id=57844 2140 2141 Allow an empty status text to be dumped. 2142 2143 * DumpRenderTree/gtk/DumpRenderTree.cpp: 2144 (webViewStatusBarTextChanged): 2145 21462011-04-06 Chang Shu <cshu@webkit.org> 2147 2148 Reviewed by Darin Adler. 2149 2150 WebKitTestRunner needs layoutTestController.pageNumberForElementById 2151 https://bugs.webkit.org/show_bug.cgi?id=42329 2152 2153 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2154 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2155 (WTR::LayoutTestController::pageNumberForElementById): 2156 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2157 21582011-04-06 Sergio Villar Senin <svillar@igalia.com> 2159 2160 Reviewed by Martin Robinson. 2161 2162 [GTK] DumpRenderTree: do not try to free NULL SoupURIs 2163 https://bugs.webkit.org/show_bug.cgi?id=57932 2164 2165 Some Layout tests have invalid URIs that do not generate valid 2166 SoupURI instances. Do not try to free those NULL SoupURIs. 2167 2168 * DumpRenderTree/gtk/DumpRenderTree.cpp: 2169 (willSendRequestCallback): 2170 21712011-04-06 Csaba Osztrogonác <ossy@webkit.org> 2172 2173 Reviewed by Andreas Kling. 2174 2175 ORWT shouldn't generate diff files for tests without expected files 2176 https://bugs.webkit.org/show_bug.cgi?id=57846 2177 2178 * Scripts/old-run-webkit-tests: 2179 21802011-04-05 Kevin Ollivier <kevino@theolliviers.com> 2181 2182 [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch 2183 to deps. 2184 2185 * wx/install-unix-extras: 2186 21872011-04-05 Sheriff Bot <webkit.review.bot@gmail.com> 2188 2189 Unreviewed, rolling out r82978, r82999, and r83001. 2190 http://trac.webkit.org/changeset/82978 2191 http://trac.webkit.org/changeset/82999 2192 http://trac.webkit.org/changeset/83001 2193 https://bugs.webkit.org/show_bug.cgi?id=57913 2194 2195 Does not work in Python 2.5 (Requested by abarth on #webkit). 2196 2197 * Scripts/webkitpy/common/system/executive.py: 2198 * Scripts/webkitpy/common/system/executive_unittest.py: 2199 22002011-04-05 Chang Shu <cshu@webkit.org> 2201 2202 Reviewed by Darin Adler. 2203 2204 WebKitTestRunner needs layoutTestController.numberOfPages 2205 https://bugs.webkit.org/show_bug.cgi?id=42694 2206 2207 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2208 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2209 (WTR::LayoutTestController::numberOfPages): 2210 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2211 22122011-04-05 Tony Chang <tony@chromium.org> 2213 2214 Reviewed by Mihai Parparita. 2215 2216 [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64 2217 https://bugs.webkit.org/show_bug.cgi?id=57889 2218 2219 * Scripts/webkitpy/layout_tests/port/chromium.py: 2220 * Scripts/webkitpy/layout_tests/port/test.py: 2221 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2222 22232011-04-05 Adam Barth <abarth@webkit.org> 2224 2225 Silly with statement, from the future! 2226 2227 * Scripts/webkitpy/common/system/executive.py: 2228 22292011-04-05 Adam Barth <abarth@webkit.org> 2230 2231 Reviewed by Tony Chang. 2232 2233 Don't use Exception.message because it's deprecated 2234 https://bugs.webkit.org/show_bug.cgi?id=57892 2235 2236 Suppress the warning for now. When we move to Python 3, we might need 2237 to something more dramatic. 2238 2239 * Scripts/webkitpy/common/system/executive.py: 2240 22412011-04-05 Mihai Parparita <mihaip@chromium.org> 2242 2243 Reviewed by Ojan Vafai. 2244 2245 Add builders.js to dashboard file list 2246 https://bugs.webkit.org/show_bug.cgi?id=57899 2247 2248 Add file added by http://crrev.com/80538 to dashboard file list. 2249 2250 * TestResultServer/handlers/dashboardhandler.py: 2251 22522011-04-05 MORITA Hajime <morrita@google.com> 2253 2254 Reviewed by Adam Barth. 2255 2256 webkit-patch should print git's stderr when git svn dcommit fail 2257 http://webkit.org/b/57861 2258 2259 * Scripts/webkitpy/common/checkout/scm.py: 2260 22612011-04-05 Mihai Parparita <mihaip@chromium.org> 2262 2263 Reviewed by Tony Chang. 2264 2265 Add --baseline-search-path to NRWT 2266 https://bugs.webkit.org/show_bug.cgi?id=56233 2267 2268 Add NRWT option to specify additional directories to look for baselines 2269 (will be used by hardware GPU bots which will have local per-bot 2270 expectations for some tests) 2271 2272 * Scripts/webkitpy/common/system/filesystem_mock.py: 2273 * Scripts/webkitpy/layout_tests/port/base.py: 2274 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 2275 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 2276 22772011-04-05 Adam Roben <aroben@apple.com> 2278 2279 Strip off /results.html from results URLs before trying to load leaks files from them 2280 2281 r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html 2282 files, rather than pointing to the directory that contains them. This is more convenient for 2283 people browsing build.webkit.org, but confused Leaks Viewer. 2284 2285 Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds 2286 list don't work 2287 2288 Reviewed by Joseph Pecoraro. 2289 2290 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: 2291 (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL. 2292 22932011-04-05 Carol Szabo <carol@webkit.org> 2294 2295 Unreviewed. 2296 2297 Updated my info in committers.py 2298 2299 Scripts\webkitpy\common\config\committers.py 2300 23012011-04-05 Csaba Osztrogonác <ossy@webkit.org> 2302 2303 Reviewed by Laszlo Gombos. 2304 2305 [Qt] Make WebKitLibraries optional for building QtWebKit 2306 https://bugs.webkit.org/show_bug.cgi?id=57542 2307 2308 * Scripts/build-webkit: 2309 23102011-04-05 Chang Shu <cshu@webkit.org> 2311 2312 Reviewed by Laszlo Gombos. 2313 2314 [Qt] MiniBrowser defaultUrl does not work 2315 https://bugs.webkit.org/show_bug.cgi?id=57021 2316 2317 Match the behavior and coding of MiniBrowser to QtTestBrowser. 2318 * MiniBrowser/qt/main.cpp: 2319 (main): 2320 23212011-04-05 Jade Han <jade.han@nokia.com> 2322 2323 Reviewed by Laszlo Gombos. 2324 2325 [Qt] [Symbian] Disable WebKitTestRunner for Symbian 2326 https://bugs.webkit.org/show_bug.cgi?id=54977 2327 2328 This change is a preparation to enable building webkit2 for Symbian. 2329 Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian. 2330 2331 * Tools.pro: 2332 23332011-04-05 Zoltan Horvath <zoltan@webkit.org> 2334 2335 Reviewed by Andreas Kling. 2336 2337 [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader 2338 https://bugs.webkit.org/show_bug.cgi?id=57832 2339 2340 Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow. 2341 2342 * MiniBrowser/qt/UrlLoader.cpp: 2343 (UrlLoader::UrlLoader): 2344 23452011-04-05 Zoltan Horvath <zoltan@webkit.org> 2346 2347 [Qt] Linux Release minimal build fix after r82919. 2348 2349 * MiniBrowser/qt/BrowserWindow.cpp: 2350 (BrowserWindow::loadURLListFromFile): 2351 * QtTestBrowser/launcherwindow.cpp: 2352 (LauncherWindow::loadURLListFromFile): 2353 23542011-04-05 Zoltan Horvath <zoltan@webkit.org> 2355 2356 Reviewed by Andreas Kling. 2357 2358 [Qt] Make URL loader accessible from testbrowser's menus 2359 https://bugs.webkit.org/show_bug.cgi?id=57823 2360 2361 Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu. 2362 2363 * MiniBrowser/qt/BrowserWindow.cpp: 2364 (BrowserWindow::BrowserWindow): 2365 (BrowserWindow::loadURLListFromFile): 2366 (BrowserWindow::~BrowserWindow): 2367 * MiniBrowser/qt/BrowserWindow.h: 2368 * QtTestBrowser/launcherwindow.cpp: 2369 (LauncherWindow::LauncherWindow): 2370 (LauncherWindow::~LauncherWindow): 2371 (LauncherWindow::createChrome): 2372 (LauncherWindow::loadURLListFromFile): 2373 * QtTestBrowser/launcherwindow.h: 2374 23752011-04-04 Sam Weinig <sam@webkit.org> 2376 2377 Reviewed by Brian Weinstein. 2378 2379 Remove duplicate API from WKContext 2380 <rdar://problem/8727879> 2381 https://bugs.webkit.org/show_bug.cgi?id=57815 2382 2383 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 2384 * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed. 2385 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 2386 Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed. 2387 23882011-04-04 Tony Chang <tony@chromium.org> 2389 2390 Reviewed by Ojan Vafai. 2391 2392 [chromium] don't write .checksum files if a fallback platform has an embedded checksum 2393 https://bugs.webkit.org/show_bug.cgi?id=57783 2394 2395 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2396 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 2397 23982011-04-04 Kevin Ollivier <kevino@theolliviers.com> 2399 2400 [wx] Unreviewed build fix, run uninstall when cleaning to remove built files 2401 from WebKitBuild. 2402 2403 * Scripts/webkitdirs.pm: 2404 24052011-04-04 Martin Robinson <mrobinson@igalia.com> 2406 2407 Reviewed by Gustavo Noronha Silva. 2408 2409 [GTK] WebGL support 2410 https://bugs.webkit.org/show_bug.cgi?id=31517 2411 2412 Add support to the DRT for turning on WebGL when a layout tests requests it. 2413 2414 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2415 (LayoutTestController::overridePreference): Allow turning on WebGL from tests. 2416 24172011-04-04 Chang Shu <cshu@webkit.org> 2418 2419 Reviewed by Darin Adler. 2420 2421 WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs 2422 https://bugs.webkit.org/show_bug.cgi?id=57572 2423 2424 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2425 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2426 (WTR::LayoutTestController::setAllowFileAccessFromFileURLs): 2427 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2428 24292011-04-04 Keith Kyzivat <keith.kyzivat@nokia.com> 2430 2431 Reviewed by Csaba Osztrogonác. 2432 2433 [Qt] DumpRenderTree breaks compilation in some uClibc environments 2434 https://bugs.webkit.org/show_bug.cgi?id=57602 2435 2436 * DumpRenderTree/qt/main.cpp: 2437 (get_backtrace): 2438 24392011-04-04 Kevin Ollivier <kevino@theolliviers.com> 2440 2441 [wx] Unreviewed build fix, add new LayoutTestController method stub to wx. 2442 2443 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 2444 (LayoutTestController::shadowRoot): 2445 24462011-04-04 Pavel Podivilov <podivilov@chromium.org> 2447 2448 Unreviewed, fix exception in rebaseline tool. 2449 2450 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2451 24522011-04-02 Beth Dakin <bdakin@apple.com> 2453 2454 Rubber-stamped by Geoff Garen. 2455 2456 For Dan! 2457 * DumpRenderTree/mac/DumpRenderTree.mm: 2458 (resetWebViewToConsistentStateBeforeTesting): 2459 24602011-04-02 Beth Dakin <bdakin@apple.com> 2461 2462 Rubber-stamped by Geoff Garen. 2463 2464 Need to reset the scale, much like zoom. 2465 * DumpRenderTree/mac/DumpRenderTree.mm: 2466 (resetWebViewToConsistentStateBeforeTesting): 2467 24682011-04-02 Sam Weinig <sam@webkit.org> 2469 2470 Reviewed by Beth Dakin. 2471 2472 https://bugs.webkit.org/show_bug.cgi?id=57605 2473 Frame::pageScaleFactor() should not affect getBoundingClientRect() or 2474 getClientRects() 2475 -and corresponding- 2476 <rdar://problem/9194541> 2477 2478 Add DRT support for the scaleWebView SPI. 2479 * DumpRenderTree/mac/EventSendingController.mm: 2480 (+[EventSendingController isSelectorExcludedFromWebScript:]): 2481 (+[EventSendingController webScriptNameForSelector:]): 2482 (-[EventSendingController scalePageBy:atX:andY:]): 2483 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: 2484 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: 2485 (WTR::EventSendingController::scalePageBy): 2486 * WebKitTestRunner/InjectedBundle/EventSendingController.h: 2487 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 2488 (WTR::InjectedBundlePage::reset): 2489 24902011-04-02 Dominic Cooney <dominicc@google.com> 2491 2492 Reviewed by Martin Robinson. 2493 2494 Add layoutTestController.shadowRoot to GTK DumpRenderTree. 2495 https://bugs.webkit.org/show_bug.cgi?id=57551 2496 2497 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2498 (LayoutTestController::shadowRoot): 2499 25002011-04-02 Patrick Gansterer <paroga@webkit.org> 2501 2502 Reviewed by Eric Seidel. 2503 2504 Remove AbstractStep._run_script and move script names to ports.py 2505 https://bugs.webkit.org/show_bug.cgi?id=57704 2506 2507 Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail. 2508 2509 * Scripts/webkitpy/common/config/ports.py: 2510 * Scripts/webkitpy/tool/commands/download_unittest.py: 2511 * Scripts/webkitpy/tool/commands/roll_unittest.py: 2512 * Scripts/webkitpy/tool/commands/upload_unittest.py: 2513 * Scripts/webkitpy/tool/steps/abstractstep.py: 2514 * Scripts/webkitpy/tool/steps/checkstyle.py: 2515 * Scripts/webkitpy/tool/steps/preparechangelog.py: 2516 * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: 2517 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py: 2518 25192011-04-02 Patrick Gansterer <paroga@webkit.org> 2520 2521 Reviewed by Eric Seidel. 2522 2523 Emulate shebang on Win32 2524 https://bugs.webkit.org/show_bug.cgi?id=55927 2525 2526 Scripts on Windows work only if they are called with the explicit interpreter. 2527 Read the first line of scripts to detect the correct executable. 2528 2529 * Scripts/webkitpy/common/config/ports.py: 2530 * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script(). 2531 * Scripts/webkitpy/common/system/executive_unittest.py: 2532 25332011-04-01 Adam Barth <abarth@webkit.org> 2534 2535 Reviewed by Eric Seidel. 2536 2537 apos entities shouldn't show up in ChangeLogs when using webkit-patch 2538 https://bugs.webkit.org/show_bug.cgi?id=57692 2539 2540 Previously, we were using BeautifulSoup to process XML from 2541 bugs.webkit.org, but that's incorrect. We should be using 2542 BeautifulStoneSoup to process the XML. We were getting the ' 2543 entity wrong because ' is an XML entity but not an HTML entity. 2544 2545 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 2546 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: 2547 25482011-04-01 Sheriff Bot <webkit.review.bot@gmail.com> 2549 2550 Unreviewed, rolling out r82721. 2551 http://trac.webkit.org/changeset/82721 2552 https://bugs.webkit.org/show_bug.cgi?id=57687 2553 2554 This patch introduced assertion failures on the GTK+ bots. 2555 (Requested by mrobinson on #webkit). 2556 2557 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2558 (LayoutTestController::shadowRoot): 2559 25602011-04-01 Csaba Osztrogonác <ossy@webkit.org> 2561 2562 Unreviewed buildfix. 2563 2564 [Qt][WK2] Build Webkit2 using "-2" option on Qt 2565 https://bugs.webkit.org/show_bug.cgi?id=55074 2566 2567 * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake. 2568 (The isWK2() function removes it from @ARGV, but not from @options.) 2569 25702011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com> 2571 2572 Reviewed by Csaba Osztrogonác. 2573 2574 [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671 2575 https://bugs.webkit.org/show_bug.cgi?id=57666 2576 2577 * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc. 2578 25792011-04-01 Dirk Pranke <dpranke@chromium.org> 2580 2581 Reviewed by Adam Barth. 2582 2583 new-run-webkit-tests: fix feature detection, skipped platform lists on mac 2584 2585 We apparently never implemented the code to skip tests based on 2586 what was compiled into DRT. Also, change the logic used to skip 2587 platform directories to match what old-run-webkit-tests does: 2588 skip every test not in a directory in the baseline search path. 2589 2590 https://bugs.webkit.org/show_bug.cgi?id=57662 2591 2592 * Scripts/webkitpy/layout_tests/port/mac.py: 2593 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 2594 * Scripts/webkitpy/layout_tests/port/webkit.py: 2595 25962011-03-29 Mark Rowe <mrowe@apple.com> 2597 2598 Reviewed by Jon Honeycutt. 2599 2600 <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed 2601 2602 Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X. 2603 2604 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 2605 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: 2606 * Scripts/webkitpy/layout_tests/port/mac.py: 2607 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 2608 26092011-04-01 Chang Shu <cshu@webkit.org> 2610 2611 Reviewed by Csaba Osztrogonác. 2612 2613 [Qt][WK2] Build Webkit2 using "-2" option on Qt 2614 https://bugs.webkit.org/show_bug.cgi?id=55074 2615 2616 * Scripts/build-webkit: 2617 26182011-04-01 Dirk Pranke <dpranke@chromium.org> 2619 2620 Reviewed by Tony Chang. 2621 2622 new-run-webkit-tests: remove spurious port version override in webkit.py 2623 base.py provides a default implementation so this is just 2624 breaking things. 2625 2626 https://bugs.webkit.org/show_bug.cgi?id=57667 2627 2628 * Scripts/webkitpy/layout_tests/port/webkit.py: 2629 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 2630 26312011-04-01 Csaba Osztrogonác <ossy@webkit.org> 2632 2633 Reviewed by Adam Roben. 2634 2635 Make view results on waterfall direct link to results.html 2636 https://bugs.webkit.org/show_bug.cgi?id=57671 2637 2638 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL. 2639 * Scripts/old-run-webkit-tests: Add links to httpd access and error logs. 2640 26412011-04-01 Sam Weinig <sam@webkit.org> 2642 2643 Fix windows build. 2644 2645 * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: 2646 (TestWebKitAPI::TEST): 2647 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: 2648 (TestWebKitAPI::flushMessages): 2649 26502011-04-01 Sam Weinig <sam@webkit.org> 2651 2652 Reviewed by Adam Roben. 2653 2654 Add adoptWK to WKRetainPtr.h 2655 https://bugs.webkit.org/show_bug.cgi?id=57670 2656 2657 * TestWebKitAPI/PlatformUtilities.h: 2658 * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: 2659 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: 2660 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: 2661 * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: 2662 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: 2663 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: 2664 * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: 2665 * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: 2666 (TestWebKitAPI::createSessionStateContainingFormData): 2667 * WebKitTestRunner/StringFunctions.h: 2668 Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h. 2669 26702011-04-01 Sam Weinig <sam@webkit.org> 2671 2672 Reviewed by Adam Roben. 2673 2674 Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot. 2675 2676 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2677 (WTR::LayoutTestController::shadowRoot): 2678 Make judicious use of adoptWK(). 2679 26802011-04-01 Sam Weinig <sam@webkit.org> 2681 2682 Reviewed by Timothy Hatcher. 2683 2684 Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING. 2685 2686 * Scripts/extract-localizable-strings: 2687 26882011-04-01 Anders Carlsson <andersca@apple.com> 2689 2690 Reviewed by Sam Weinig. 2691 2692 Shockwave plug-in doesn't accept mouse events 2693 https://bugs.webkit.org/show_bug.cgi?id=57653 2694 <rdar://problem/8483273> 2695 2696 Add a plug-in test. 2697 2698 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 2699 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 2700 (PluginTest::indicateTestFailure): 2701 Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here. 2702 2703 (PluginTest::NPN_ConvertPoint): 2704 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 2705 * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: 2706 (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject): 2707 Call indicateTestFailure. 2708 2709 * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added. 2710 * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added. 2711 (ConvertPoint::ConvertPoint): 2712 (ConvertPoint::testConvert): 2713 (ConvertPoint::NPP_New): 2714 27152011-04-01 Dominic Cooney <dominicc@google.com> 2716 2717 Reviewed by Martin Robinson. 2718 2719 Add layoutTestController.shadowRoot to GTK DumpRenderTree. 2720 https://bugs.webkit.org/show_bug.cgi?id=57551 2721 2722 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2723 (LayoutTestController::shadowRoot): 2724 27252011-04-01 Sam Weinig <sam@webkit.org> 2726 2727 Reviewed by Anders Carlsson. 2728 2729 WebKitTestRunner needs layoutTestController.shadowRoot 2730 https://bugs.webkit.org/show_bug.cgi?id=57661 2731 2732 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2733 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2734 (WTR::LayoutTestController::shadowRoot): 2735 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2736 Implement layoutTestController.shadowRoot for WebKit2. 2737 27382011-04-01 Chang Shu <cshu@webkit.org> 2739 2740 Reviewed by Darin Adler. 2741 2742 WebKitTestRunner needs layoutTestController.setDatabaseQuota 2743 https://bugs.webkit.org/show_bug.cgi?id=57568 2744 2745 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2746 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2747 (WTR::LayoutTestController::setDatabaseQuota): 2748 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2749 27502011-04-01 Dirk Pranke <dpranke@chromium.org> 2751 2752 Reviewed by Tony Chang. 2753 2754 This patch completes the cleanup of 2755 rebaseline-chromium-webkit-tests to work with all of the 2756 variants of a platform (we can now rebaseline gpu- and non-gpu 2757 files at the same time). 2758 2759 When the rebaselining is complete, any lines declared as 2760 REBASELINE in the expectations file that matches a test that was 2761 actually rebaselined will be deleted, even if only one of the 2762 variants was actually rebaselined. This may cause odd problems, 2763 but is better than where we're at today. 2764 2765 This change removes the -g flag and deprecates -w. The -g flag is gone 2766 because GPU baselines are handled just like any other variant. 2767 The -w flag is deprecated because this tool now only works 2768 against the canaries, since that's the only place we have a full 2769 set of bots. It will be trivial to change this to 2770 build.webkit.org if we decide that's where we want them to be. 2771 2772 Also, this patch deletes a lot of cruft that is no longer needed 2773 in the test_expectations code and the port-specific code. 2774 2775 https://bugs.webkit.org/show_bug.cgi?id=55191 2776 2777 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 2778 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 2779 * Scripts/webkitpy/layout_tests/port/base.py: 2780 * Scripts/webkitpy/layout_tests/port/base_unittest.py: 2781 * Scripts/webkitpy/layout_tests/port/chromium.py: 2782 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 2783 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 2784 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 2785 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: 2786 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 2787 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 2788 * Scripts/webkitpy/layout_tests/port/mac.py: 2789 * Scripts/webkitpy/layout_tests/port/test.py: 2790 * Scripts/webkitpy/layout_tests/port/webkit.py: 2791 * Scripts/webkitpy/layout_tests/port/win.py: 2792 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2793 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 2794 27952011-04-01 Dirk Pranke <dpranke@chromium.org> 2796 2797 Reviewed by Adam Barth. 2798 2799 rebaseline-chromium-webkit-tests does not work correctly with 2800 version-specific baselines. This patch updates the tool to use 2801 all of the version-specific bots on the canaries, and will now 2802 attempt to rebaseline all of the versions by default, although 2803 it will not update both GPU and CPU versions. 2804 2805 Also, it will no longer modify the test_expectations.txt file 2806 *at all*. You will have to manually delete the REBASELINE lines 2807 after running the tool and determining that it did what you 2808 wanted it to do. This should be fixed in a separate bug - see 2809 webkit bug #55191. 2810 2811 https://bugs.webkit.org/show_bug.cgi?id=55608 2812 2813 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: 2814 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: 2815 * Scripts/webkitpy/layout_tests/port/chromium.py: 2816 * Scripts/webkitpy/layout_tests/port/test.py: 2817 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 2818 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 2819 28202011-03-31 Tony Chang <tony@chromium.org> 2821 2822 Reviewed by Ojan Vafai. 2823 2824 [chromium] update the rebaseline tool to know about pngs with checksums 2825 https://bugs.webkit.org/show_bug.cgi?id=57481 2826 2827 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png 2828 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: 2829 28302011-04-01 Adam Roben <aroben@apple.com> 2831 2832 Retrieve revision numbers from the build's got_revision property in Leaks Viewer 2833 2834 Previously, we were getting the revision of the first revision that triggered a build. 2835 Choosing the last revision would have been more accurate. But got_revision is what is used 2836 everywhere else on build.webkit.org, and should work even when there were no changes that 2837 triggered a build (e.g., if someone clicked the Force Build button). 2838 2839 Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the 2840 recent builds list 2841 2842 Reviewed by Anders Carlsson. 2843 2844 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: 2845 (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision 2846 property, rather than out of the first (i.e., earliest) change in the sourceStamp object. 2847 2848 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: 2849 (Array.prototype.first): Added this helper function to return the first element in an array 2850 that matches the given predicate, or null if no such element exists. 2851 28522011-03-31 Adam Roben <aroben@apple.com> 2853 2854 Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs 2855 2856 Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting 2857 2858 Reviewed by Darin Adler. 2859 2860 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 2861 (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug 2862 URL on its own line. 2863 2864 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: 2865 (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test 2866 progression, and added a new test that uses a short bug URL while I was at it. 2867 28682011-04-01 Adam Roben <aroben@apple.com> 2869 2870 Mark .vcproj/.vsprops/.sln files as being Windows-only 2871 2872 Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have 2873 2874 Reviewed by Anders Carlsson. 2875 2876 * Scripts/webkitpy/common/config/build.py: 2877 (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj 2878 directories as Windows-only. 2879 2880 * Scripts/webkitpy/common/config/build_unittest.py: 2881 (ShoulBuildTest): Added test cases for the above. 2882 28832011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com> 2884 2885 Reviewed by Laszlo Gombos. 2886 2887 [Qt] Build MiniBrowser for Symbian 2888 https://bugs.webkit.org/show_bug.cgi?id=56319 2889 2890 Have MiniBrowser reference it's own copy of useragentlist.txt instead 2891 of copying QtTestBrowser's. 2892 Remove Tools/MiniBrowser/DerivedSources.pro 2893 This reduces complexity in the Tools scripts due to Symbian limitations. 2894 2895 * DerivedSources.pro: 2896 * MiniBrowser/DerivedSources.pro: Removed. 2897 * MiniBrowser/MiniBrowser.qrc: 2898 * MiniBrowser/qt/MiniBrowser.pro: 2899 * Scripts/webkitdirs.pm: 2900 29012011-03-31 Chang Shu <cshu@webkit.org> 2902 2903 Reviewed by Darin Adler. 2904 2905 WebKitTestRunner needs layoutTestController.clearAllDatabases 2906 https://bugs.webkit.org/show_bug.cgi?id=42540 2907 2908 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2909 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 2910 (WTR::InjectedBundle::beginTesting): 2911 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 2912 (WTR::LayoutTestController::clearAllDatabases): 2913 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 2914 29152011-03-31 Chang Shu <cshu@webkit.org> 2916 2917 Reviewed by Darin Adler. 2918 2919 WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs 2920 https://bugs.webkit.org/show_bug.cgi?id=42692 2921 2922 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: 2923 29242011-03-31 Darin Adler <darin@apple.com> 2925 2926 Reviewed by Sam Weinig. 2927 2928 Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner 2929 https://bugs.webkit.org/show_bug.cgi?id=57573 2930 2931 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: 2932 Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward. 2933 Removed fake definitions of keyDown and contextClick. 2934 2935 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: 2936 (WTR::operator==): Added. So we can compare two WKPoint structs. 2937 (WTR::parseModifier): Added. 2938 (WTR::parseModifierArray): Added. 2939 (WTR::EventSendingController::EventSendingController): Initialize the 2940 new data members. 2941 (WTR::EventSendingController::mouseDown): Added. Calls 2942 WKBundlePageSimulateMouseDown. 2943 (WTR::EventSendingController::mouseUp): Added. Calls 2944 WKBundlePageSimulateMouseUp. 2945 (WTR::EventSendingController::mouseMoveTo): Added. Calls 2946 WKBundlePageSimulateMouseMotion. 2947 (WTR::EventSendingController::leapForward): Added. 2948 (WTR::EventSendingController::updateClickCount): Added. Used by the 2949 mouseDown/Up functions to create a click count. 2950 2951 * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated 2952 for the changes above. 2953 29542011-03-31 Sergio Villar Senin <svillar@igalia.com> 2955 2956 Reviewed by Martin Robinson. 2957 2958 [GTK] implement LayoutTestController::setWillSendRequestReturnsNull 2959 https://bugs.webkit.org/show_bug.cgi?id=57362 2960 2961 Do not generate DRT output if willSendRequestReturnsNull is set. 2962 2963 * DumpRenderTree/gtk/DumpRenderTree.cpp: 2964 (willSendRequestCallback): 2965 29662011-03-31 Vamshikrishna.Yellenki <vamshi@motorola.com> and Alejandro G. Castro <alex@igalia.com> 2967 2968 Reviewed by Martin Robinson. 2969 2970 Implement MiniBrowser for Gtk port. 2971 https://bugs.webkit.org/show_bug.cgi?id=48512 2972 2973 Initial implementation of the Gtk MiniBrowser. 2974 2975 * MiniBrowser/gtk/GNUmakefile.am: Added. 2976 * MiniBrowser/gtk/main.c: Added. 2977 (activateUriEntryCallback): 2978 (destroyCallback): 2979 (goBackCallback): 2980 (goForwardCallback): 2981 (createToolbar): 2982 (createWebView): 2983 (createWindow): 2984 (argumentToURL): 2985 (main): 2986 29872011-03-30 Dominic Cooney <dominicc@google.com> 2988 2989 Reviewed by Dimitri Glazkov. 2990 2991 Adds layoutTestController.shadowRoot accessor to Mac DRT. 2992 https://bugs.webkit.org/show_bug.cgi?id=57415 2993 2994 * DumpRenderTree/LayoutTestController.cpp: 2995 (shadowRootCallback): 2996 (LayoutTestController::staticFunctions): 2997 * DumpRenderTree/LayoutTestController.h: 2998 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 2999 (LayoutTestController::shadowRoot): 3000 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 3001 (LayoutTestController::shadowRoot): 3002 30032011-03-30 Matthew Delaney <mdelaney@apple.com> 3004 3005 Reviewed by Chris Marrin. 3006 3007 Update fast/canvas tests to avoid dumping the render tree when possible 3008 https://bugs.webkit.org/show_bug.cgi?id=57493 3009 3010 * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for 3011 accelerated drawing and accelerated drawing for canvas 3012 30132011-03-30 Adam Roben <aroben@apple.com> 3014 3015 Stop ignoring leaks in CGGradientCreateWithColorStops 3016 3017 Fixes <rdar://problem/7888547>. 3018 3019 Rubber-stamped by John Sullivan. 3020 3021 * Scripts/old-run-webkit-tests: 3022 (countAndPrintLeaks): Removed some code to ignore those leaks. 3023 30242011-03-30 Timur Iskhodzhanov <timurrrr@google.com> 3025 3026 Reviewed by Alexey Proskuryakov. 3027 3028 Add some dynamic annotations to JavaScriptCore/wtf 3029 https://bugs.webkit.org/show_bug.cgi?id=53747 3030 3031 By using these annotations we can improve the precision of finding 3032 WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind. 3033 These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1". 3034 3035 These files don't add new functionality, so don't need extra tests. 3036 3037 * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added. 3038 30392011-03-30 Steve Falkenburg <sfalken@apple.com> 3040 3041 Reviewed by Adam Roben. 3042 3043 Share most vsprops between Release and Production builds in releaseproduction.vsprops 3044 https://bugs.webkit.org/show_bug.cgi?id=57508 3045 3046 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: 3047 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: 3048 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: 3049 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: 3050 * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: 3051 * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: 3052 * DumpRenderTree/win/ImageDiffProduction.vsprops: 3053 * DumpRenderTree/win/ImageDiffRelease.vsprops: 3054 * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: 3055 * FindSafari/FindSafariProduction.vsprops: 3056 * FindSafari/FindSafariRelease.vsprops: 3057 * FindSafari/FindSafariReleaseCairoCFLite.vsprops: 3058 * FindSafari/FindSafariReleasePGO.vsprops: 3059 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: 3060 * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: 3061 * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: 3062 * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: 3063 * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: 3064 * WebKitAPITest/WebKitAPITestProduction.vsprops: 3065 * WebKitAPITest/WebKitAPITestRelease.vsprops: 3066 * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: 3067 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: 3068 * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: 3069 * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: 3070 * WebKitTestRunner/win/InjectedBundleProduction.vsprops: 3071 * WebKitTestRunner/win/InjectedBundleRelease.vsprops: 3072 * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: 3073 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: 3074 * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: 3075 * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: 3076 * WinLauncher/WinLauncherProduction.vsprops: 3077 * WinLauncher/WinLauncherRelease.vsprops: 3078 * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: 3079 * record-memory-win/record-memory-winProduction.vsprops: 3080 * record-memory-win/record-memory-winRelease.vsprops: 3081 * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: 3082 30832011-03-30 Steve Falkenburg <sfalken@apple.com> 3084 3085 Reviewed by Adam Roben. 3086 3087 Update Windows production build logic for new production configurations 3088 https://bugs.webkit.org/show_bug.cgi?id=57494 3089 3090 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: 3091 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: 3092 * DumpRenderTree/win/ImageDiffProduction.vsprops: 3093 * FindSafari/FindSafariProduction.vsprops: 3094 * FindSafari/FindSafariReleasePGO.vsprops: 3095 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: 3096 * WebKitAPITest/WebKitAPITestProduction.vsprops: 3097 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: 3098 * WebKitTestRunner/win/InjectedBundleProduction.vsprops: 3099 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: 3100 * WinLauncher/WinLauncherProduction.vsprops: 3101 * record-memory-win/record-memory-winProduction.vsprops: 3102 31032011-03-30 Robert Hogan <robert@webkit.org> 3104 3105 Reviewed by Antonio Gomes. 3106 3107 [Qt] Fix LoadHTMLStringItem::invoke() after r75966 3108 Unskip http/tests/navigation/go-back-to-error-page.html 3109 3110 Also add the location of DumpRenderTreeSupportQt.h 3111 to DRT's include paths. 3112 3113 https://bugs.webkit.org/show_bug.cgi?id=52614 3114 3115 * DumpRenderTree/qt/DumpRenderTree.pro: 3116 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 3117 * DumpRenderTree/qt/DumpRenderTreeQt.h: 3118 * DumpRenderTree/qt/GCControllerQt.cpp: 3119 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3120 (LayoutTestController::queueLoadHTMLString): 3121 * DumpRenderTree/qt/LayoutTestControllerQt.h: 3122 * DumpRenderTree/qt/PlainTextControllerQt.cpp: 3123 * DumpRenderTree/qt/TextInputControllerQt.cpp: 3124 * DumpRenderTree/qt/WorkQueueItemQt.cpp: 3125 (LoadAlternateHTMLStringItem::invoke): 3126 * DumpRenderTree/qt/WorkQueueItemQt.h: 3127 (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem): 3128 * QtTestBrowser/QtTestBrowser.pro: 3129 * QtTestBrowser/launcherwindow.h: 3130 31312011-03-30 Adam Barth <abarth@webkit.org> 3132 3133 Reviewed by Adam Roben. 3134 3135 SheriffBot rollouts take too long 3136 https://bugs.webkit.org/show_bug.cgi?id=57498 3137 3138 We used to build before landing rollouts via the commit-queue to 3139 prevent further breakage, but now that our individual commit-queue 3140 machines are slower, building takes too long. I can't remember the 3141 last time a rollout broke compile. It seems like just landing the 3142 patch is the better trade-off. 3143 3144 * Scripts/webkitpy/tool/bot/commitqueuetask.py: 3145 * Scripts/webkitpy/tool/commands/queues_unittest.py: 3146 31472011-03-30 Adam Barth <abarth@webkit.org> 3148 3149 Remove platform/chromium-mac-snowleopard 3150 https://bugs.webkit.org/show_bug.cgi?id=57486 3151 3152 This directory no longer exists, so we can remove it from the fallback 3153 chain. 3154 3155 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 3156 31572011-03-30 Steve Falkenburg <sfalken@apple.com> 3158 3159 Reviewed by Adam Roben. 3160 3161 Rename Windows configuration Release_LTCG to Production for clarity 3162 https://bugs.webkit.org/show_bug.cgi?id=57465 3163 3164 * DumpRenderTree/DumpRenderTree.sln: 3165 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 3166 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops. 3167 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed. 3168 * DumpRenderTree/win/DumpRenderTree.vcproj: 3169 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops. 3170 * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed. 3171 * DumpRenderTree/win/ImageDiff.vcproj: 3172 * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops. 3173 * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed. 3174 * FindSafari/FindSafari.vcproj: 3175 * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops. 3176 * FindSafari/FindSafariReleaseLTCG.vsprops: Removed. 3177 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops. 3178 * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed. 3179 * MiniBrowser/MiniBrowser.vcproj: 3180 * Scripts/webkitdirs.pm: 3181 * TestWebKitAPI/win/TestWebKitAPI.sln: 3182 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 3183 * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: 3184 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: 3185 * WebKitAPITest/WebKitAPITest.vcproj: 3186 * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops. 3187 * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed. 3188 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 3189 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops. 3190 * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed. 3191 * WebKitTestRunner/WebKitTestRunner.sln: 3192 * WebKitTestRunner/win/InjectedBundle.vcproj: 3193 * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: 3194 * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops. 3195 * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed. 3196 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 3197 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops. 3198 * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed. 3199 * WinLauncher/WinLauncher.vcproj: 3200 * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops. 3201 * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed. 3202 * record-memory-win/record-memory-win.vcproj: 3203 * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops. 3204 * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed. 3205 32062011-03-30 MORITA Hajime <morrita@google.com> 3207 3208 Reviewed by Dimitri Glazkov. 3209 3210 [Chromium] Expose the shadow DOM to DumpRenderTree JS tests. 3211 https://bugs.webkit.org/show_bug.cgi?id=56573 3212 3213 Added LayoutTestController.shadowRoot() to Chromium DRT. 3214 3215 * DumpRenderTree/chromium/LayoutTestController.cpp: 3216 (LayoutTestController::LayoutTestController): 3217 (LayoutTestController::shadowRoot): 3218 * DumpRenderTree/chromium/LayoutTestController.h: 3219 32202011-03-30 Yuta Kitamura <yutak@chromium.org> 3221 3222 Reviewed by Kent Tamura. 3223 3224 [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled 3225 https://bugs.webkit.org/show_bug.cgi?id=57430 3226 3227 * DumpRenderTree/chromium/LayoutTestController.cpp: 3228 (LayoutTestController::LayoutTestController): 3229 (LayoutTestController::setPluginsEnabled): 3230 * DumpRenderTree/chromium/LayoutTestController.h: 3231 32322011-03-30 Maciej Stachowiak <mjs@apple.com> 3233 3234 Reviewed by Adam Barth. 3235 3236 make webkit-patch upload respect -d 3237 https://bugs.webkit.org/show_bug.cgi?id=57425 3238 3239 * Scripts/webkitpy/common/checkout/scm.py: 3240 * Scripts/webkitpy/tool/steps/commit.py: 3241 32422011-03-30 Maciej Stachowiak <mjs@apple.com> 3243 3244 Reviewed by Adam Barth. 3245 3246 Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use 3247 https://bugs.webkit.org/show_bug.cgi?id=57429 3248 3249 * Scripts/webkitpy/common/checkout/scm.py: 3250 32512011-03-29 Sheriff Bot <webkit.review.bot@gmail.com> 3252 3253 Unreviewed, rolling out r82383. 3254 http://trac.webkit.org/changeset/82383 3255 https://bugs.webkit.org/show_bug.cgi?id=57417 3256 3257 "nrwt isn't shutting down cleanly" (Requested by dpranke on 3258 #webkit). 3259 3260 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 3261 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 3262 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 3263 32642011-03-29 Kent Tamura <tkent@chromium.org> 3265 3266 Reviewed by Dimitri Glazkov. 3267 3268 Make validation message bubble testable 3269 https://bugs.webkit.org/show_bug.cgi?id=57290 3270 3271 * DumpRenderTree/mac/DumpRenderTree.mm: 3272 (createWebViewAndOffscreenWindow): Change a setting so that validation 3273 bubbles isn't hidden automatically. 3274 32752011-03-29 Dirk Pranke <dpranke@chromium.org> 3276 3277 Reviewed by Ojan Vafai. 3278 3279 new-run-webkit-tests: use 'threads' on win instead of 'old-threads' 3280 3281 It's a bit unclear whether multiple threads or multiple 3282 processes will be a better model on windows. This change will 3283 test threads for now while we're still working out the bugs in 3284 multiple-processes. 3285 3286 https://bugs.webkit.org/show_bug.cgi?id=57410 3287 3288 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 3289 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 3290 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 3291 32922011-03-29 David Levin <levin@chromium.org> 3293 3294 Reviewed by Shinichiro Hamaji. 3295 3296 check-webkit-style confused by two ChangeLog entries in a row from same user 3297 https://bugs.webkit.org/show_bug.cgi?id=57250 3298 3299 * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker. 3300 * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function. 3301 * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked. 3302 It basically assumes only one ChangeLog entry is being processed because that is the standard case and 3303 checking more than that would be very messey. 3304 * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case. 3305 * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked. 3306 33072011-03-29 Kent Tamura <tkent@chromium.org> 3308 3309 Reviewed by Dimitri Glazkov. 3310 3311 [Mac] Enable interactive-validation tests on Mac DRT 3312 https://bugs.webkit.org/show_bug.cgi?id=57308 3313 3314 * DumpRenderTree/mac/DumpRenderTree.mm: 3315 (createWebViewAndOffscreenWindow): Enable the form interactive validation feature. 3316 33172011-03-29 Chang Shu <cshu@webkit.org> 3318 3319 Reviewed by Kenneth Rohde Christiansen. 3320 3321 WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs 3322 https://bugs.webkit.org/show_bug.cgi?id=42692 3323 3324 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 3325 (WTR::InjectedBundle::beginTesting): 3326 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 3327 (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs): 3328 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 3329 33302011-03-24 Martin Robinson <mrobinson@igalia.com> 3331 3332 Reviewed by Xan Lopez. 3333 3334 [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar 3335 https://bugs.webkit.org/show_bug.cgi?id=57067 3336 3337 Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This 3338 will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will 3339 update DRT and pixel results as hundreds of results will need to be updated. 3340 3341 * DumpRenderTree/gtk/DumpRenderTree.cpp: 3342 (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow 3343 by overriding the theme RC/CSS files. 3344 33452011-03-29 Steve Falkenburg <sfalken@apple.com> 3346 3347 Reviewed by Adam Roben. 3348 3349 Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE 3350 https://bugs.webkit.org/show_bug.cgi?id=57394 3351 3352 Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from 3353 InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within 3354 the IDE. To avoid this, add a separate vsprops file for each project configuration that 3355 contains the required inherited property sheets. 3356 3357 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 3358 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added. 3359 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added. 3360 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added. 3361 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added. 3362 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added. 3363 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added. 3364 * DumpRenderTree/win/DumpRenderTree.vcproj: 3365 * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added. 3366 * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added. 3367 * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added. 3368 * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added. 3369 * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added. 3370 * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added. 3371 * DumpRenderTree/win/ImageDiff.vcproj: 3372 * DumpRenderTree/win/ImageDiffDebug.vsprops: Added. 3373 * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added. 3374 * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added. 3375 * DumpRenderTree/win/ImageDiffRelease.vsprops: Added. 3376 * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added. 3377 * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added. 3378 * FindSafari/FindSafari.vcproj: 3379 * FindSafari/FindSafariDebug.vsprops: Added. 3380 * FindSafari/FindSafariDebugAll.vsprops: Added. 3381 * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added. 3382 * FindSafari/FindSafariRelease.vsprops: Added. 3383 * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added. 3384 * FindSafari/FindSafariReleaseLTCG.vsprops: Added. 3385 * FindSafari/FindSafariReleasePGO.vsprops: Added. 3386 * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added. 3387 * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added. 3388 * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added. 3389 * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added. 3390 * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added. 3391 * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added. 3392 * MiniBrowser/MiniBrowser.vcproj: 3393 * WebKitAPITest/WebKitAPITest.vcproj: 3394 * WebKitAPITest/WebKitAPITestDebug.vsprops: Added. 3395 * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added. 3396 * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added. 3397 * WebKitAPITest/WebKitAPITestRelease.vsprops: Added. 3398 * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added. 3399 * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added. 3400 * WebKitLauncherWin/WebKitLauncherWin.vcproj: 3401 * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added. 3402 * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added. 3403 * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added. 3404 * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added. 3405 * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added. 3406 * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added. 3407 * WebKitTestRunner/win/InjectedBundle.vcproj: 3408 * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added. 3409 * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added. 3410 * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added. 3411 * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added. 3412 * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added. 3413 * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added. 3414 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 3415 * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added. 3416 * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added. 3417 * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added. 3418 * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added. 3419 * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added. 3420 * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added. 3421 * WinLauncher/WinLauncher.vcproj: 3422 * WinLauncher/WinLauncherDebug.vsprops: Added. 3423 * WinLauncher/WinLauncherDebugAll.vsprops: Added. 3424 * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added. 3425 * WinLauncher/WinLauncherRelease.vsprops: Added. 3426 * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added. 3427 * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added. 3428 * record-memory-win/record-memory-win.vcproj: 3429 * record-memory-win/record-memory-winDebug.vsprops: Added. 3430 * record-memory-win/record-memory-winDebugAll.vsprops: Added. 3431 * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added. 3432 * record-memory-win/record-memory-winRelease.vsprops: Added. 3433 * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added. 3434 * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added. 3435 34362011-03-29 Adam Barth <abarth@webkit.org> 3437 3438 Reviewed by Darin Adler. 3439 3440 test_runner2.py can crash due to undefined variable 3441 https://bugs.webkit.org/show_bug.cgi?id=57356 3442 3443 Replace reference to undefined variable with a variable that's actually 3444 defined. AFAICT, there's no way to test this code. 3445 3446 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 3447 34482011-03-29 Tony Chang <tony@chromium.org> 3449 3450 Reviewed by Eric Seidel. 3451 3452 cleanup rebaseline-chromium-webkit-tests 3453 https://bugs.webkit.org/show_bug.cgi?id=57375 3454 3455 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 3456 - Split _extract_and_add_new_baselines into 3 functions 3457 - Reduce the amount of line wrapping (the file already has lines 3458 over 80 col, so may as well try to make the file consistent) 3459 - Remove unnecessary ()s 3460 34612011-03-29 Brent Fulgham <bfulgham@webkit.org> 3462 3463 Reviewed by Adam Roben. 3464 3465 Make WinCairo a core builder. 3466 https://bugs.webkit.org/show_bug.cgi?id=57373 3467 3468 * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo. 3469 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo. 3470 34712011-03-29 Timothy Hatcher <timothy@apple.com> 3472 3473 Update update-webkit-localizable-strings to understand that WebKit and 3474 WebKit2 strings go in WebCore. 3475 3476 Also make extract-localizable-strings optionally use an exclude file. No individual 3477 warnings are produced about unlocalized strings when there is no exclude file. This 3478 is needed for WebCore, since there are too many bare strings. 3479 3480 https://webkit.org/b/57354 3481 3482 Reviewed by Sam Weinig. 3483 3484 * Scripts/extract-localizable-strings: Support "-" to mean no exclude file. 3485 * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2. 3486 34872011-03-29 Darin Adler <darin@apple.com> 3488 3489 Reviewed by Adam Roben. 3490 3491 WebKit2 bundle page needs to offer generated file hooks 3492 https://bugs.webkit.org/show_bug.cgi?id=57279 3493 3494 (Land missing part of the original patch after r82289.) 3495 3496 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 3497 (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks. 3498 34992011-03-29 Tony Chang <tony@chromium.org> 3500 3501 Reviewed by Ojan Vafai. 3502 3503 [chromium] NRWT should be able to read checksums from png comments 3504 https://bugs.webkit.org/show_bug.cgi?id=57280 3505 3506 * Scripts/read-checksum-from-png: Added. Utility script to read the checksum 3507 from a file. 3508 * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading 3509 * Scripts/webkitpy/common/system/filesystem_mock.py: 3510 * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum, 3511 if the -checksum.txt file doesn't exist, try looking in the png. 3512 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 3513 * Scripts/webkitpy/layout_tests/port/test.py: 3514 * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first 3515 2k for a png comment with the checksum 3516 * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added. 3517 35182011-03-29 Philippe Normand <pnormand@igalia.com> 3519 3520 Rubber-stamped by Gustavo Noronha Silva. 3521 3522 [GTK] http/tests/uri/username-with-no-hostname.html fails 3523 https://bugs.webkit.org/show_bug.cgi?id=57325 3524 3525 * DumpRenderTree/gtk/DumpRenderTree.cpp: 3526 (willSendRequestCallback): URI host value check done case-insensitively. 3527 35282011-03-29 Philippe Normand <pnormand@igalia.com> 3529 3530 Reviewed by Martin Robinson. 3531 3532 [GTK] http/tests/uri/username-with-no-hostname.html fails 3533 https://bugs.webkit.org/show_bug.cgi?id=57325 3534 3535 * DumpRenderTree/gtk/DumpRenderTree.cpp: 3536 (willSendRequestCallback): Check URI before submitting the request 3537 to WebCore. 3538 35392011-03-29 Noel Gordon <noel.gordon@gmail.com> 3540 3541 Reviewed by Ojan Vafai. 3542 3543 [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls 3544 https://bugs.webkit.org/show_bug.cgi?id=57303 3545 3546 * DumpRenderTree/chromium/EventSender.cpp: 3547 (EventSender::doDragDrop): 3548 (EventSender::beginDragWithFiles): 3549 35502011-03-29 Zoltan Horvath <zoltan@webkit.org> 3551 3552 Reviewed by Andreas Kling. 3553 3554 [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser 3555 https://bugs.webkit.org/show_bug.cgi?id=57314 3556 3557 Provide possibility to print loaded urls to the standard output. 3558 3559 * MiniBrowser/qt/BrowserWindow.cpp: 3560 (BrowserWindow::BrowserWindow): 3561 (BrowserWindow::printURL): 3562 * MiniBrowser/qt/BrowserWindow.h: 3563 * MiniBrowser/qt/MiniBrowserApplication.cpp: 3564 (MiniBrowserApplication::handleUserOptions): 3565 * MiniBrowser/qt/MiniBrowserApplication.h: 3566 (WindowOptions::WindowOptions): 3567 * QtTestBrowser/launcherwindow.cpp: 3568 (LauncherWindow::initializeView): 3569 (LauncherWindow::printURL): 3570 (LauncherWindow::cloneWindow): 3571 * QtTestBrowser/launcherwindow.h: 3572 (WindowOptions::WindowOptions): 3573 * QtTestBrowser/main.cpp: 3574 (LauncherApplication::handleUserOptions): 3575 35762011-03-29 Gabor Loki <loki@webkit.org> 3577 3578 Rubber-stamped by Csaba Osztrogonác. 3579 3580 [Qt] Teach build-jsc how to build JavaScriptCore on Qt 3581 https://bugs.webkit.org/show_bug.cgi?id=56918 3582 3583 * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake. 3584 35852011-03-28 Gabor Loki <loki@webkit.org> 3586 3587 Reviewed by Csaba Osztrogonác. 3588 3589 [Qt] Teach build-jsc how to build JavaScriptCore on Qt 3590 https://bugs.webkit.org/show_bug.cgi?id=56918 3591 3592 * Scripts/build-jsc: 3593 * Scripts/webkitdirs.pm: 3594 35952011-03-28 Andrew Foster <andrewf@chromium.org> 3596 3597 Reviewed by Ojan Vafai. 3598 3599 webkit-patch should be more intelligent about whether a bug applies to a patch 3600 Create a new function, parse_bug_id_from_changelog() which determines 3601 that a bug is related to a patch by parsing the output generated from 3602 prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in 3603 the description of a patch. 3604 https://bugs.webkit.org/show_bug.cgi?id=56989 3605 3606 * Scripts/webkitpy/common/checkout/api.py: 3607 * Scripts/webkitpy/common/checkout/changelog.py: 3608 * Scripts/webkitpy/common/net/bugzilla/__init__.py: 3609 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 3610 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: 3611 * Scripts/webkitpy/style/checkers/changelog.py: 3612 * Scripts/webkitpy/tool/commands/upload.py: 3613 36142011-03-28 Maciej Stachowiak <mjs@apple.com> 3615 3616 Revert accidentally commited change. 3617 3618 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 3619 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): 3620 36212011-03-28 Tony Chang <tony@chromium.org> 3622 3623 Reviewed by Adam Barth. 3624 3625 [chromium] have DRT write the png checksum into a png comment 3626 https://bugs.webkit.org/show_bug.cgi?id=57255 3627 3628 * DumpRenderTree/chromium/TestShell.cpp: 3629 (TestShell::dumpImage): 3630 36312011-03-28 Adele Peterson <adele@apple.com> 3632 3633 Removing Qt stub, since it doesn't use the same header as the others. 3634 3635 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3636 36372011-03-28 Adele Peterson <adele@apple.com> 3638 3639 Added a few more stubs. 3640 3641 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 3642 (LayoutTestController::hasGrammarMarker): 3643 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 3644 (LayoutTestController::hasGrammarMarker): 3645 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 3646 (LayoutTestController::hasGrammarMarker): 3647 36482011-03-28 Adele Peterson <adele@apple.com> 3649 3650 Build fix. 3651 3652 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 3653 (LayoutTestController::hasGrammarMarker): 3654 36552011-03-28 Adele Peterson <adele@apple.com> 3656 3657 Reviewed by Eric Seidel. 3658 3659 Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type 3660 https://bugs.webkit.org/show_bug.cgi?id=57173 3661 3662 * DumpRenderTree/LayoutTestController.cpp: 3663 (hasGrammarMarkerCallback): Added. 3664 (LayoutTestController::staticFunctions): Added case for hasGrammarMarker. 3665 * DumpRenderTree/LayoutTestController.h: 3666 * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled. 3667 * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method. 3668 36692011-03-28 Csaba Osztrogonác <ossy@webkit.org> 3670 3671 Reviewed by Benjamin Poulain. 3672 3673 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled 3674 https://bugs.webkit.org/show_bug.cgi?id=57087 3675 3676 Trivial typo fix after r82082. 3677 3678 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: 3679 (WTR::activateFonts): 3680 36812011-03-28 Alexis Menard <alexis.menard@openbossa.org> 3682 3683 Reviewed by Andreas Kling. 3684 3685 Add myself to the committers list. 3686 3687 * Scripts/webkitpy/common/config/committers.py: 3688 36892011-03-28 Simon Fraser <simon.fraser@apple.com> 3690 3691 Reviewed by Sam Weinig. 3692 3693 WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs 3694 to link against WebKit.framework for now. 3695 3696 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: 3697 36982011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com> 3699 3700 Reviewed by Andreas Kling. 3701 3702 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled 3703 https://bugs.webkit.org/show_bug.cgi?id=57087 3704 3705 Disable QT_ASCII_CAST_WARNINGS for applications. 3706 3707 * DumpRenderTree/qt/DumpRenderTree.pro: 3708 * DumpRenderTree/qt/ImageDiff.pro: 3709 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 3710 * MiniBrowser/qt/MiniBrowser.pro: 3711 * QtTestBrowser/QtTestBrowser.pro: 3712 * WebKitTestRunner/qt/WebKitTestRunner.pro: 3713 37142011-03-28 Andreas Kling <kling@webkit.org> 3715 3716 Reviewed by Kenneth Rohde Christiansen. 3717 3718 [Qt] QtTestBrowser doesn't reset its window title when opening about:blank 3719 https://bugs.webkit.org/show_bug.cgi?id=57224 3720 3721 * QtTestBrowser/mainwindow.cpp: 3722 (MainWindow::buildUI): 3723 (MainWindow::onTitleChanged): 3724 * QtTestBrowser/mainwindow.h: 3725 37262011-03-27 Jer Noble <jer.noble@apple.com> 3727 3728 Reviewed by Maciej Stachowiak. 3729 3730 Full Screen: disable keyboard access by default 3731 https://bugs.webkit.org/show_bug.cgi?id=56684 3732 3733 Accept the withKeyboard parameter to supportsFullScreenForElement. 3734 3735 * DumpRenderTree/mac/UIDelegate.mm: 3736 (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]): 3737 37382011-03-27 Patrick Gansterer <paroga@webkit.org> 3739 3740 Reviewed by David Levin. 3741 3742 check-webkit-style should check ChangeLog for a valid bug number 3743 https://bugs.webkit.org/show_bug.cgi?id=57184 3744 3745 * Scripts/webkitpy/style/checker.py: 3746 * Scripts/webkitpy/style/checker_unittest.py: 3747 * Scripts/webkitpy/style/checkers/changelog.py: Added. 3748 * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added. 3749 37502011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com> 3751 3752 Reviewed by Andreas Kling. 3753 3754 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled 3755 https://bugs.webkit.org/show_bug.cgi?id=57087 3756 3757 Use explicit conversion for string to avoid depending on the default codec 3758 installed by the user code. 3759 3760 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: 3761 (WTR::activateFonts): 3762 37632011-03-26 Maciej Stachowiak <mjs@apple.com> 3764 3765 Revert inadvertantly committed changes. 3766 3767 * Scripts/old-run-webkit-tests: 3768 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 3769 37702011-03-26 Andreas Kling <kling@webkit.org> 3771 3772 Reviewed by Kenneth Rohde Christiansen. 3773 3774 [Qt] Show page icons (favicons) in QtTestBrowser location bar. 3775 https://bugs.webkit.org/show_bug.cgi?id=57162 3776 3777 * QtTestBrowser/QtTestBrowser.qrc: 3778 * QtTestBrowser/favicon.png: Added. 3779 * QtTestBrowser/locationedit.cpp: 3780 (defaultPageIcon): 3781 (LocationEdit::LocationEdit): 3782 (LocationEdit::setPageIcon): 3783 (LocationEdit::resizeEvent): 3784 (LocationEdit::updateInternalGeometry): 3785 * QtTestBrowser/locationedit.h: 3786 * QtTestBrowser/mainwindow.cpp: 3787 (MainWindow::buildUI): 3788 (MainWindow::onIconChanged): 3789 (MainWindow::onLoadStarted): 3790 * QtTestBrowser/mainwindow.h: 3791 37922011-03-23 Martin Robinson <mrobinson@igalia.com> 3793 3794 Reviewed by Xan Lopez. 3795 3796 [GTK] Force DumpRenderTree to use 96 DPI 3797 https://bugs.webkit.org/show_bug.cgi?id=56866 3798 3799 Make sure that GTK+ is set to use 96 DPI when running tests. This ensures 3800 broader compatibility with WebKit2 and makes setting font sizes more straightforward. 3801 3802 * DumpRenderTree/gtk/DumpRenderTree.cpp: 3803 (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI. 3804 (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution. 3805 (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI. 3806 38072011-03-25 Andy Estes <aestes@apple.com> 3808 3809 Reviewed by Adele Peterson. 3810 3811 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js 3812 https://bugs.webkit.org/show_bug.cgi?id=49016 3813 3814 TestNetscapePlugIn needs to register support for an image MIME type so 3815 we can test that the embed tag prefers plug-ins to render image MIME 3816 types. 3817 3818 * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png. 3819 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 3820 (NP_GetMIMEDescription): Ditto. 3821 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto. 3822 38232011-03-25 Jessie Berlin <jberlin@apple.com> 3824 3825 Reviewed by Sam Weinig. 3826 3827 WebKit2: Need to be able to set and get the Cookie Storage Policy. 3828 https://bugs.webkit.org/show_bug.cgi?id=50780 3829 3830 Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2. 3831 3832 The test is named "CookieManager" so that we can eventually exercise more of the 3833 CookieManager functionality in the test. 3834 3835 * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added. 3836 (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy): 3837 Assert that the policy returned is equal to the policy set in 3838 didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy. 3839 (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy): 3840 Set the policy to something different than the user's policy and get the policy again. 3841 (TestWebKitAPI::didFinishLoadForFrame): 3842 Get the user's policy so that it can be restored at the end of the test. 3843 (TestWebKitAPI::TEST): 3844 Load about:blank so that the Web Process gets instatiated (needed to get the 3845 CookieManager). 3846 3847 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 3848 Add CookieManager.cpp. 3849 38502011-03-24 Kevin Ollivier <kevino@theolliviers.com> 3851 3852 [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard. 3853 3854 * wx/build/settings.py: 3855 38562011-03-24 Ilya Sherman <isherman@chromium.org> 3857 3858 Reviewed by Adam Roben. 3859 3860 Implement layoutTestController.setAutoFilled in DRT on Windows 3861 https://bugs.webkit.org/show_bug.cgi?id=56828 3862 3863 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 3864 (LayoutTestController::setAutofilled): Implemented. 3865 38662011-03-24 Brent Fulgham <bfulgham@webkit.org> 3867 3868 Unreviewed build correction. 3869 3870 Correct vsprops file for Debug variant of the CFLite build. 3871 Disable a CFNETWORK-specific test when building for CFLite. 3872 3873 * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: 3874 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 3875 38762011-03-24 Dirk Pranke <dpranke@chromium.org> 3877 3878 Reviewed by Adam Barth. 3879 3880 fix regressions introduced in 81908 - there were a couple of 3881 code paths that only fired under python 2.5 that I missed. 3882 3883 Also change a couple of 'python' references to sys.executable 3884 in order to handle runing test-webkitpy with a binary other than 3885 something called 'python'. 3886 3887 https://bugs.webkit.org/show_bug.cgi?id=57063 3888 3889 * Scripts/webkitpy/layout_tests/port/mac.py: 3890 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 3891 * Scripts/webkitpy/test/cat.py: 3892 * Scripts/webkitpy/test/echo.py: 3893 38942011-03-24 Brent Fulgham <bfulgham@webkit.org> 3895 3896 Unreviewed build correction. 3897 3898 Add a stub implementation of the TestInvocation dumping logic. 3899 Update project files to reflect new file. 3900 3901 * WebKitTestRunner/cairo: Added. 3902 * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added. 3903 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): 3904 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 3905 39062011-03-24 Dirk Pranke <dpranke@chromium.org> 3907 3908 Reviewed by Tony Chang. 3909 3910 new-run-webkit-tests: clean up worker model defaults. This 3911 changes the default behavior to 'threads' instead of 3912 'old-threads', and clarifies that chromium-win-* and 3913 chromium-mac-leopard are exceptions. 3914 3915 https://bugs.webkit.org/show_bug.cgi?id=56971 3916 3917 * Scripts/webkitpy/layout_tests/port/base.py: 3918 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 3919 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 3920 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 3921 * Scripts/webkitpy/layout_tests/port/test.py: 3922 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 3923 39242011-03-23 Leandro Gracia Gil <leandrogracia@chromium.org> 3925 3926 Reviewed by Darin Adler. 3927 3928 Media Stream API: fix the order of the options in build-webkit. 3929 https://bugs.webkit.org/show_bug.cgi?id=56949 3930 3931 Fix the order of the options in build-webkit. 3932 3933 * Scripts/build-webkit: 3934 39352011-03-23 Adam Klein <adamk@chromium.org> 3936 3937 Reviewed by Mihai Parparita. 3938 3939 Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory 3940 https://bugs.webkit.org/show_bug.cgi?id=56884 3941 3942 This option will be utilized by Chromium's ui_tests to allow 3943 referencing js-test-resources from a layout test over HTTP. 3944 3945 * Scripts/new-run-webkit-httpd: 3946 Added --layout_tests_dir option. 3947 * Scripts/webkitpy/layout_tests/port/http_server.py: 3948 Plumbed through as layout_tests_dir param. 3949 39502011-03-23 Dirk Pranke <dpranke@chromium.org> 3951 3952 Reviewed by Mihai Parparita. 3953 3954 new-run-webkit-tests: run tests in ascending alphabetical order per 3955 dir. This is a second attempt at the fix; the first attempt, in 3956 r81597, broke the behavior on the old-inline and old-threads 3957 worker models. 3958 3959 https://bugs.webkit.org/show_bug.cgi?id=56760 3960 3961 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: 3962 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 3963 * Scripts/webkitpy/layout_tests/port/test.py: 3964 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 3965 39662011-03-23 Mario Sanchez Prada <msanchez@igalia.com> 3967 3968 Reviewed by Martin Robinson. 3969 3970 [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal 3971 https://bugs.webkit.org/show_bug.cgi?id=56953 3972 3973 Print the string for the detail of 'property-change' signal. 3974 3975 * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: 3976 (axObjectEventListener): Print the detail string. 3977 39782011-03-23 Yury Semikhatsky <yurys@chromium.org> 3979 3980 Reviewed by Pavel Feldman. 3981 3982 [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h 3983 https://bugs.webkit.org/show_bug.cgi?id=56843 3984 3985 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 3986 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 3987 39882011-03-22 Eric Seidel <eric@webkit.org> 3989 3990 Reviewed by Adam Barth. 3991 3992 Teach update-webkit about gyp 3993 https://bugs.webkit.org/show_bug.cgi?id=56881 3994 3995 This makes it possible for someone who builds from Xcode 3996 to just run update-webkit --gyp and have the project files 3997 generated after update automatically. 3998 3999 I also added a stand-alone "generate-project-files" script 4000 wrapping Source/gyp/configure. This makes running gyp simpler 4001 since most people will not have gyp or Source/gyp in their path. 4002 4003 * Scripts/build-webkit: 4004 * Scripts/generate-project-files: Added. 4005 * Scripts/update-webkit: 4006 40072011-03-22 Anton D'Auria <adauria@apple.com> 4008 4009 Reviewed by Alexey Proskuryakov. 4010 4011 Add +[WebApplicationCache getOriginsWithCache] 4012 https://bugs.webkit.org/show_bug.cgi?id=56722 4013 4014 * DumpRenderTree/LayoutTestController.cpp: 4015 (originsWithApplicationCacheCallback): 4016 (LayoutTestController::staticFunctions): 4017 * DumpRenderTree/LayoutTestController.h: 4018 * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub. 4019 (LayoutTestController::originsWithApplicationCache): 4020 * DumpRenderTree/chromium/LayoutTestController.h: 4021 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub. 4022 (LayoutTestController::originsWithApplicationCache): 4023 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers. 4024 (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers. 4025 (LayoutTestController::originsWithApplicationCache): 4026 (LayoutTestController::originsWithLocalStorage): 4027 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub. 4028 (LayoutTestController::originsWithApplicationCache): 4029 * DumpRenderTree/qt/LayoutTestControllerQt.h: 4030 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub. 4031 (LayoutTestController::originsWithApplicationCache): 4032 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub. 4033 (LayoutTestController::originsWithApplicationCache): 4034 40352011-03-22 Eric Seidel <eric@webkit.org> 4036 4037 Reviewed by Adam Barth. 4038 4039 Add support to build-webkit for building with gyp-generated project files 4040 https://bugs.webkit.org/show_bug.cgi?id=56877 4041 4042 build-webkit is a cesspool. This change just hacks in --gyp support for Mac. 4043 Eventually we'll want to support gyp-generated projects in a more general manner. 4044 4045 * Scripts/build-webkit: 4046 40472011-03-22 David Kilzer <ddkilzer@apple.com> 4048 4049 <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode 4050 4051 Reviewed by Joseph Pecoraro. 4052 4053 * Scripts/build-webkit: Updated usage statement to include 4054 --dsym. 4055 * Scripts/webkitdirs.pm: Added $generateDsym variable. 4056 (generateDsym): Added. Call determineGenerateDsym() and 4057 return $generateDsym. 4058 (determineGenerateDsym): Added. Parse @ARGV for --dsym and set 4059 $generateDsym. 4060 (argumentsForXcode): Added. Returns additional arguments for 4061 xcodebuild based on command-line switches. 4062 (XcodeOptions): Updated to include argumentsForXcode() in the 4063 array returned. 4064 40652011-03-22 Adam Roben <aroben@apple.com> 4066 4067 Make Leopard Debug bots and Windows XP Debug (Tests) core builders 4068 4069 These bots are consistently green again. 4070 4071 Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be 4072 core builders 4073 4074 Rubber-stamped by Antti Koivisto. 4075 4076 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 4077 (BuildBot.__init__): Loosened the regexps for Leopard and Windows. 4078 4079 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 4080 (BuildBotTest.test_builder_name_regexps): Updated expectations. 4081 40822011-03-21 Sheriff Bot <webkit.review.bot@gmail.com> 4083 4084 Unreviewed, rolling out r81597. 4085 http://trac.webkit.org/changeset/81597 4086 https://bugs.webkit.org/show_bug.cgi?id=56801 4087 4088 Change results in lots of unexpected flaky on the dashboard. 4089 (Requested by pfeldman on #webkit). 4090 4091 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 4092 * Scripts/webkitpy/layout_tests/port/test.py: 4093 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 4094 40952011-03-21 Sam Weinig <sam@webkit.org> 4096 4097 Fix failing tests on the WebKit2 bots. 4098 4099 * WebKitTestRunner/TestController.cpp: 4100 (WTR::TestController::resetStateToConsistentValues): 4101 41022011-03-21 Daniel Sievers <sievers@google.com> 4103 4104 Reviewed by Simon Fraser. 4105 4106 [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline 4107 https://bugs.webkit.org/show_bug.cgi?id=56139 4108 4109 * DumpRenderTree/chromium/DumpRenderTree.cpp: 4110 (main): 4111 * DumpRenderTree/chromium/LayoutTestController.cpp: 4112 (LayoutTestController::LayoutTestController): 4113 (LayoutTestController::layerTreeAsText): 4114 * DumpRenderTree/chromium/LayoutTestController.h: 4115 (LayoutTestController::setShowDebugLayerTree): 4116 * DumpRenderTree/chromium/TestShell.cpp: 4117 (TestShell::runFileTest): 4118 (TestShell::dump): 4119 * DumpRenderTree/chromium/TestShell.h: 4120 (TestParams::TestParams): 4121 41222011-03-21 Adam Roben <aroben@apple.com> 4123 4124 Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file 4125 4126 Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML 4127 output as plain text 4128 4129 Reviewed by David Kilzer. 4130 4131 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 4132 (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded 4133 to the master. 4134 (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work, 4135 since we're running on the build master, not the slave. Instead, turn the raw source of 4136 actual.html which the build slave uploaded into an HTML log. 4137 41382011-03-21 Dirk Pranke <dpranke@chromium.org> 4139 4140 Reviewed by Mihai Parparita. 4141 4142 new-run-webkit-tests: run tests in ascending alphabetical order per dir 4143 https://bugs.webkit.org/show_bug.cgi?id=56760 4144 4145 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 4146 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 4147 * Scripts/webkitpy/layout_tests/port/test.py: 4148 41492011-03-21 Leandro Gracia Gil <leandrogracia@chromium.org> 4150 4151 Reviewed by Steve Block. 4152 4153 Media Stream API patch 0: adding compilation guards. 4154 https://bugs.webkit.org/show_bug.cgi?id=56458 4155 4156 Adding options to enable the media stream API feature in Chromium. 4157 4158 * Scripts/build-webkit: 4159 41602011-03-21 Qi Zhang <qi.2.zhang@nokia.com> 4161 4162 Reviewed by Laszlo Gombos. 4163 4164 [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree 4165 https://bugs.webkit.org/show_bug.cgi?id=56323 4166 4167 Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 4168 "--stdout" or "--stderr" option. 4169 4170 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 4171 (WebCore::DumpRenderTree::~DumpRenderTree): 4172 (WebCore::DumpRenderTree::processArgsLine): 4173 (WebCore::DumpRenderTree::loadNextTestInStandAloneMode): 4174 * DumpRenderTree/qt/DumpRenderTreeQt.h: 4175 (WebCore::DumpRenderTree::setRedirectOutputFileName): 4176 (WebCore::DumpRenderTree::setRedirectErrorFileName): 4177 * DumpRenderTree/qt/main.cpp: 4178 (isOption): 4179 (takeOptionValue): 4180 (printUsage): 4181 (main): 4182 41832011-03-21 Adam Roben <aroben@apple.com> 4184 4185 Fix exceptions on the buildbot due to my last change 4186 4187 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 4188 (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing. 4189 41902011-03-21 Adam Roben <aroben@apple.com> 4191 4192 Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file 4193 4194 Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML 4195 output as plain text 4196 4197 Reviewed by Darin Adler. 4198 4199 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 4200 (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext 4201 logs. 4202 (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to 4203 the build master. This will correctly treat it as HTML. 4204 42052011-03-20 Bill Budge <bbudge@chromium.org> 4206 4207 Reviewed by Adam Barth. 4208 4209 Rename ThreadSafeShared to ThreadSafeRefCounted 4210 https://bugs.webkit.org/show_bug.cgi?id=56714 4211 4212 No new tests. Exposes no new functionality. 4213 4214 * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h. 4215 * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed. 4216 * Scripts/do-webcore-rename: 4217 42182011-03-19 Anton D'Auria <adauria@apple.com> 4219 4220 Reviewed by Dan Bernstein. 4221 4222 Add stub to LayoutTestControllerGtk.cpp to fix GTK build 4223 https://bugs.webkit.org/show_bug.cgi?id=56719 4224 4225 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub. 4226 (LayoutTestController::clearApplicationCacheForOrigin): 4227 42282011-03-19 Anton D'Auria <adauria@apple.com> 4229 4230 Reviewed by Alexey Proskuryakov. 4231 4232 ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin 4233 https://bugs.webkit.org/show_bug.cgi?id=56415 4234 4235 * DumpRenderTree/LayoutTestController.cpp: 4236 (clearApplicationCacheForOriginCallback): 4237 (LayoutTestController::staticFunctions): 4238 * DumpRenderTree/LayoutTestController.h: 4239 * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs. 4240 (LayoutTestController::LayoutTestController): 4241 (LayoutTestController::clearAllApplicationCaches): 4242 (LayoutTestController::clearApplicationCacheForOrigin): 4243 * DumpRenderTree/chromium/LayoutTestController.h: 4244 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub. 4245 (LayoutTestController::clearApplicationCacheForOrigin): 4246 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub. 4247 (LayoutTestController::clearApplicationCacheForOrigin): 4248 * DumpRenderTree/qt/LayoutTestControllerQt.h: 4249 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub. 4250 (LayoutTestController::clearApplicationCacheForOrigin): 4251 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub. 4252 (LayoutTestController::clearApplicationCacheForOrigin): 4253 42542011-03-18 Dan Bernstein <mitz@apple.com> 4255 4256 Revised build fix for r81135. 4257 4258 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: 4259 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 4260 42612011-03-18 Adam Roben <aroben@apple.com> 4262 4263 Windows build fix 4264 4265 * WebKitTestRunner/config.h: Add a missing #endif. 4266 42672011-03-18 Andreas Kling <kling@webkit.org> 4268 4269 Unbreak Qt build after r81494. 4270 4271 * WebKitTestRunner/qt/TestInvocationQt.cpp: 4272 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): 4273 42742011-03-18 Sam Weinig <sam@webkit.org> 4275 4276 Fix windows build. This was really Adam Roben's fault. I swear! 4277 4278 * WebKitTestRunner/config.h: 4279 42802011-03-18 Sam Weinig <sam@webkit.org> 4281 4282 Reviewed by Adam Roben. 4283 4284 Pixel tests don't work in WebKitTestRunner on Windows 4285 https://bugs.webkit.org/show_bug.cgi?id=56630 4286 4287 Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2 4288 built-in snapshotting instead of using the window server on the Mac. 4289 4290 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 4291 (WTR::InjectedBundle::InjectedBundle): 4292 (WTR::InjectedBundle::didReceiveMessage): 4293 (WTR::InjectedBundle::beginTesting): 4294 (WTR::InjectedBundle::done): 4295 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 4296 (WTR::InjectedBundle::setPixelResult): 4297 (WTR::InjectedBundle::shouldDumpPixels): 4298 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 4299 (WTR::InjectedBundlePage::dump): 4300 Take the snapshot in the bundle and send it to the UIProcess for dumping. 4301 4302 * WebKitTestRunner/TestInvocation.cpp: 4303 (WTR::TestInvocation::invoke): 4304 (WTR::TestInvocation::dump): 4305 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 4306 * WebKitTestRunner/TestInvocation.h: 4307 * WebKitTestRunner/cg: Added. 4308 * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm. 4309 (WTR::createCGContextFromImage): 4310 (WTR::computeMD5HashStringForContext): 4311 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): 4312 * WebKitTestRunner/mac/TestInvocationMac.mm: Removed. 4313 Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code. 4314 4315 * WebKitTestRunner/win/TestInvocationWin.cpp: 4316 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): 4317 Keep stub for Cairo build. 4318 4319 * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added. 4320 Add CG configuration. 4321 4322 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 4323 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 4324 Add new files. 4325 43262011-03-18 Adam Roben <aroben@apple.com> 4327 4328 Don't allow Leaks Viewer's vertical scrollbar to cover up long function names 4329 4330 Rubber-stamped by Simon Fraser. 4331 4332 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: 4333 (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default 4334 overflow-y:overlay so that the scrollbar doesn't overlay the content. 4335 43362011-03-18 Adam Roben <aroben@apple.com> 4337 4338 Don't ellipsize long or indented function names in Leaks Viewer 4339 4340 Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal 4341 scrollbar 4342 4343 Reviewed by Simon Fraser. 4344 4345 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: 4346 (.data-grid .data-container): 4347 (.data-grid td > div, .data-grid th > div): 4348 Allow the contents to extend to the right. 4349 43502011-03-18 Adam Roben <aroben@apple.com> 4351 4352 Fix some leaks in DRT seen on the leaks bot 4353 4354 Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and 4355 setWillSendRequestClearHeaderCallback in DRT are leaky 4356 4357 Reviewed by Alexey Proskuryakov. 4358 4359 * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added. 4360 4361 * DumpRenderTree/LayoutTestController.cpp: 4362 (addURLToRedirectCallback): 4363 (setWillSendRequestClearHeaderCallback): 4364 Use OwnArrayPtr to cause the strings to be deleted. 4365 43662011-03-18 Adam Roben <aroben@apple.com> 4367 4368 Fix a NSURLCredential leak seen on the leaks bot 4369 4370 Fixes <http://webkit.org/b/56637> -[SynchronousLoader 4371 connection:didReceiveAuthenticationChallenge:] is leaky 4372 4373 Reviewed by John Sullivan. 4374 4375 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 4376 (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to 4377 cause the NSURLCredential to be released. 4378 43792011-03-18 John Knottenbelt <jknotten@chromium.org> 4380 4381 Unreviewed. 4382 4383 Remove unnecessary brackets around my email address. 4384 4385 * Scripts/webkitpy/common/config/committers.py: 4386 43872011-03-18 Adam Roben <aroben@apple.com> 4388 4389 Remove some files I accidentally added in r81454 4390 4391 * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed. 4392 * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed. 4393 43942011-03-18 Adam Roben <aroben@apple.com> 4395 4396 Ignore an NSNumberFormatter leak on SnowLeopard 4397 4398 * Scripts/old-run-webkit-tests: 4399 (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter 4400 getObjectValue:forString:errorDescription:]. 4401 44022011-03-18 Adam Roben <aroben@apple.com> 4403 4404 Fix a leak beneath LayoutTestController::authenticateSession seen on the bots 4405 4406 Rubber-stamped by Mark Rowe. 4407 4408 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 4409 (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be 4410 released. 4411 44122011-03-17 Adam Roben <aroben@apple.com> 4413 4414 Address a review comment I missed in r81445 4415 4416 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: 4417 (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of 4418 leaked bytes to speed up searching on long lines. 4419 44202011-03-17 Adam Roben <aroben@apple.com> 4421 4422 Mark leaky builds orange, even if all regression tests passed 4423 4424 Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on 4425 build.webkit.org when all tests pass even though there are still leaks 4426 4427 Reviewed by Dan Bernstein. 4428 4429 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 4430 (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will 4431 be marked orange if this build step generates warnings. 4432 44332011-03-17 Adam Roben <aroben@apple.com> 4434 4435 Allow values in Leaks Viewer to be shown as percentages 4436 4437 Double-clicking on a column will toggle between showing percentages and showing real values. 4438 4439 Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total 4440 number of leaked bytes in Leaks Viewer 4441 4442 Reviewed by Joe Pecoraro. 4443 4444 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: 4445 (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level 4446 node's totalTime, which is used in calculating percentages. 4447 4448 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: 4449 (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be 4450 showing them as percentages. 4451 44522011-03-17 Adam Roben <aroben@apple.com> 4453 4454 Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer 4455 4456 The Self and Total columns now report the number of leaked bytes. The new Calls column shows 4457 the number of leaked allocations. And the new Average column shows the average number of 4458 leaked bytes per call. 4459 4460 Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not 4461 just how many allocations 4462 4463 Reviewed by Joe Pecoraro. 4464 4465 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: 4466 (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:" 4467 line and store it with the leak stack. 4468 (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls 4469 properties. 4470 (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack 4471 property, and changed to store the number of leaked bytes in .selfTime/.totalTime. 4472 .numberOfCalls now holds the number of leaked allocations. 4473 4474 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: 4475 (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will 4476 appear. 4477 (monkeyPatchInspectorObjects): Format the values as bytes. 4478 44792011-03-17 Adam Roben <aroben@apple.com> 4480 4481 Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests 4482 4483 Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any 4484 regression tests 4485 4486 Reviewed by James Robinson. 4487 4488 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: 4489 (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which 4490 is always populated, even when all regression tests pass. 4491 44922011-03-10 Hayato Ito <hayato@chromium.org> 4493 4494 Reviewed by Tony Chang. 4495 4496 Add a check logic for reftests in case that a reftest is marked AS REBASELINE. 4497 4498 https://bugs.webkit.org/show_bug.cgi?id=56076 4499 4500 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 4501 45022011-03-17 Adam Roben <aroben@apple.com> 4503 4504 Skip a compositing-sensitive test when accelerated compositing is disabled 4505 4506 Reviewed by Sam Weinig. 4507 4508 * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when 4509 accelerated compositing is disabled. 4510 45112011-03-17 Adam Roben <aroben@apple.com> 4512 4513 Start using PlatformSpecificScheduler for the Mac builders 4514 4515 The current set of file/directory patterns should work for Mac builders. We may discover 4516 that there are more files and directories we can exclude from the Mac builds, but they can 4517 be added later. 4518 4519 Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds 4520 4521 Reviewed by Mark Rowe. 4522 4523 * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two 4524 PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard. 4525 4526 * Scripts/webkitpy/common/config/build.py: 4527 (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and 4528 cleaned up patterns a little bit. 4529 4530 * Scripts/webkitpy/common/config/build_unittest.py: 4531 (ShouldBuildTest): Fixed some expected results. 4532 (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard" 4533 platforms. 4534 45352011-03-17 Jeff Miller <jeffm@apple.com> 4536 4537 Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically: 4538 4539 *.mode* 4540 *.pbxuser 4541 *.perspective* 4542 project.xcworkspace 4543 xcuserdata 4544 4545 * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore. 4546 * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore. 4547 * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore. 4548 * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore. 4549 * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore. 4550 45512011-03-17 Adam Roben <aroben@apple.com> 4552 4553 Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows 4554 4555 Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from 4556 mac-wk2 4557 4558 Reviewed by Anders Carlsson. 4559 4560 * Scripts/old-run-webkit-tests: 4561 (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result 4562 directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when 4563 we're running in WebKit2 mode. 4564 45652011-03-17 Mikhail Naganov <mnaganov@chromium.org> 4566 4567 Reviewed by Yury Semikhatsky. 4568 4569 Web Inspector: Clean up Inspector strings. 4570 https://bugs.webkit.org/show_bug.cgi?id=56557 4571 4572 Modify the script to deal correctly with "\xNN" escapes, and to 4573 check strings in Chromium's DevTools.js. 4574 4575 * Scripts/check-inspector-strings: 4576 45772011-03-17 Keith Kyzivat <keith.kyzivat@nokia.com> 4578 4579 Reviewed by Benjamin Poulain. 4580 4581 Update autoinstall to install mechanize 0.2.4 4582 https://bugs.webkit.org/show_bug.cgi?id=56499 4583 4584 Newer versions of mechanize support HTTPS proxies, which is necessary 4585 for people using webkit-patch behind firewalls. 4586 4587 * Scripts/webkitpy/common/system/autoinstall.py: 4588 * Scripts/webkitpy/thirdparty/__init__.py: 4589 45902011-03-16 Sam Weinig <sam@webkit.org> 4591 4592 Reviewed by Adam Roben. 4593 4594 REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2 4595 https://bugs.webkit.org/show_bug.cgi?id=56541 4596 4597 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 4598 (WTR::InjectedBundlePage::willSendRequestForFrame): 4599 Check for an empty host in addition to a null host. This bug was introduced 4600 when porting off of the KURL code and onto the WKURLRef version. 4601 46022011-03-16 Sam Weinig <sam@webkit.org> 4603 4604 Reviewed by Adam Roben. 4605 4606 Add Lucas Forschler to the list of WebKit committers. 4607 4608 * Scripts/webkitpy/common/config/committers.py: 4609 46102011-03-16 Sam Weinig <sam@webkit.org> 4611 4612 Reviewed upon and dictated through Adam Roben. 4613 4614 Escape crashing function names in results.html. This fixes an issue 4615 when a crash involves a type with templates. 4616 4617 * Scripts/old-run-webkit-tests: 4618 46192011-03-16 Daniel Sievers <sievers@google.com> 4620 4621 Reviewed by James Robinson. 4622 4623 Add setting to always force compositing mode 4624 https://bugs.webkit.org/show_bug.cgi?id=56156 4625 4626 * DumpRenderTree/chromium/DumpRenderTree.cpp: 4627 (main): 4628 * DumpRenderTree/chromium/TestShell.cpp: 4629 (TestShell::TestShell): 4630 (TestShell::resetWebSettings): 4631 * DumpRenderTree/chromium/TestShell.h: 4632 (TestShell::setForceCompositingMode): 4633 * DumpRenderTree/chromium/WebPreferences.cpp: 4634 (WebPreferences::reset): 4635 (WebPreferences::applyTo): 4636 * DumpRenderTree/chromium/WebPreferences.h: 4637 46382011-03-15 Hayato Ito <hayato@chromium.org> 4639 4640 Reviewed by Ojan Vafai. 4641 4642 Ignore files that will be used by reftests in old-run-webkit-tests. 4643 4644 https://bugs.webkit.org/show_bug.cgi?id=55936 4645 4646 * Scripts/old-run-webkit-tests: 4647 46482011-03-15 Felipe Oliveira da Silva Netto <f.dachshund@gmail.com> 4649 4650 Reviewed by Adam Roben. 4651 4652 Function relativeScriptsDir doesn't return the correct relative 4653 Scripts directory. 4654 4655 * Scripts/webkitdirs.pm: 4656 (relativeScriptsDir): Ensure we use the directory that contains 4657 webkitdirs.pm, not the one that contains the original script that 4658 was invoked. 4659 46602011-03-15 Kevin Ollivier <kevino@theolliviers.com> 4661 4662 [wx] Build fixes for long linker commands on Win and method return error, plus a Mac 4663 fix to link against the Security framework after recent WebKitSystemInterface changes. 4664 4665 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 4666 (LayoutTestController::originsWithLocalStorage): 4667 * wx/build/settings.py: 4668 * wx/build/waf_extensions.py: 4669 46702011-03-15 Sam Weinig <sam@webkit.org> 4671 4672 Reviewed by Darin Adler. 4673 4674 Add script to convert a patch to a prettypatch and show in the default browser 4675 https://bugs.webkit.org/show_bug.cgi?id=56416 4676 4677 This can be used either like 4678 $ svn-create-patch | show-pretty-diff 4679 or 4680 $ show-pretty-diff patch.diff 4681 4682 * Scripts/show-pretty-diff: Added. 4683 46842011-03-15 Brian Weinstein <bweinstein@apple.com> 4685 4686 Rubber-stamped by Adam Roben. 4687 4688 Adding myself as a reviewer. 4689 4690 * Scripts/webkitpy/common/config/committers.py: 4691 46922011-03-15 Anders Carlsson <andersca@apple.com> 4693 4694 Try to fix the Windows build. 4695 4696 * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: 4697 (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject): 4698 46992011-03-15 Anders Carlsson <andersca@apple.com> 4700 4701 Reviewed by Sam Weinig. 4702 4703 Make sure that NP_Shutdown is always the last NPP function called 4704 https://bugs.webkit.org/show_bug.cgi?id=56391 4705 4706 Add a test that times out if an NP_Deallocate object is called after NP_Shutdown. 4707 4708 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 4709 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 4710 (PluginTest::PluginTest): 4711 (PluginTest::NP_Shutdown): 4712 (PluginTest::registerNPShutdownFunction): 4713 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 4714 * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added. 4715 (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown): 4716 (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject): 4717 (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty): 4718 (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty): 4719 (NPDeallocateCalledBeforeNPShutdown::NPP_New): 4720 (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue): 4721 (NPDeallocateCalledBeforeNPShutdown::shutdown): 4722 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 4723 (NP_Shutdown): 4724 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 4725 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 4726 * GNUmakefile.am: 4727 47282011-03-15 Ilya Sherman <isherman@chromium.org> 4729 4730 Reviewed by Tony Chang. 4731 4732 Autofilled form elements are assigned fixed background color but not text color 4733 https://bugs.webkit.org/show_bug.cgi?id=48382 4734 4735 * DumpRenderTree/LayoutTestController.cpp: 4736 (setAutofilledCallback): Added. 4737 (LayoutTestController::staticFunctions): 4738 * DumpRenderTree/LayoutTestController.h: 4739 * DumpRenderTree/chromium/LayoutTestController.cpp: 4740 (LayoutTestController::LayoutTestController): 4741 (LayoutTestController::setAutofilled): Added. 4742 * DumpRenderTree/chromium/LayoutTestController.h: 4743 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 4744 (LayoutTestController::setAutofilled): Added. 4745 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 4746 (LayoutTestController::setAutofilled): Added. 4747 (LayoutTestController::setValueForUser): Style tweak. 4748 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 4749 (LayoutTestController::setAutofilled): Added (stub). 4750 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 4751 (LayoutTestController::setAutofilled): Added (stub). 4752 47532011-03-15 Dan Bernstein <mitz@apple.com> 4754 4755 Build fix after r81135. 4756 4757 * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: 4758 47592011-03-15 Dan Bernstein <mitz@apple.com> 4760 4761 Build fix after r81135. 4762 4763 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: 4764 * WebKitTestRunner/mac/TestControllerMac.mm: 4765 * WebKitTestRunner/mac/TestInvocationMac.mm: 4766 * WebKitTestRunner/mac/main.mm: 4767 47682011-03-15 Balazs Kelemen <kbalazs@webkit.org> 4769 4770 Reviewed by Adam Barth. 4771 4772 REGRESSION(80977): breaks Qt ARMv7 Linux Release bot 4773 https://bugs.webkit.org/show_bug.cgi?id=56349 4774 4775 * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig 4776 on platforms where we use it. Copied from DumpRenderTree.pro. 4777 47782011-03-15 Dan Bernstein <mitz@apple.com> 4779 4780 Build fix after r81135. 4781 4782 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: 4783 * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: 4784 47852011-03-15 Kevin Ollivier <kevino@theolliviers.com> 4786 4787 Reviewed by Darin Adler. 4788 4789 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export 4790 info into the headers rather than in export symbol definition files, but disable it on 4791 all platforms initially so we can deal with port build issues one port at a time. 4792 4793 https://bugs.webkit.org/show_bug.cgi?id=27551 4794 4795 * DumpRenderTree/cg/ImageDiffCG.cpp: 4796 * DumpRenderTree/chromium/config.h: 4797 * DumpRenderTree/config.h: 4798 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 4799 * TestWebKitAPI/TestWebKitAPIPrefix.h: 4800 * WebKitAPITest/HostWindow.cpp: 4801 * WebKitAPITest/TestsController.cpp: 4802 * WebKitAPITest/config.h: Added. 4803 * WebKitAPITest/main.cpp: 4804 * WebKitAPITest/tests/WebViewDestruction.cpp: 4805 * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: 4806 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: 4807 * WebKitTestRunner/InjectedBundle/GCController.cpp: 4808 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 4809 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: 4810 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 4811 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 4812 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: 4813 * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: 4814 * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: 4815 * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: 4816 * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: 4817 * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: 4818 * WebKitTestRunner/TestController.cpp: 4819 * WebKitTestRunner/TestInvocation.cpp: 4820 * WebKitTestRunner/config.h: Added. 4821 * WebKitTestRunner/qt/PlatformWebViewQt.cpp: 4822 * WebKitTestRunner/qt/TestControllerQt.cpp: 4823 * WebKitTestRunner/qt/TestInvocationQt.cpp: 4824 * WebKitTestRunner/qt/main.cpp: 4825 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 4826 * WebKitTestRunner/win/TestControllerWin.cpp: 4827 * WebKitTestRunner/win/TestInvocationWin.cpp: 4828 * WebKitTestRunner/win/main.cpp: 4829 * wx/build/settings.py: 4830 48312011-03-15 Hayato Ito <hayato@chromium.org> 4832 4833 Reviewed by Shinichiro Hamaji. 4834 4835 [NRWT] Add support for reftests to new-run-webkit-tests. 4836 4837 https://bugs.webkit.org/show_bug.cgi?id=55457 4838 4839 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 4840 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 4841 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: 4842 * Scripts/webkitpy/layout_tests/port/base.py: 4843 * Scripts/webkitpy/layout_tests/port/dryrun.py: 4844 * Scripts/webkitpy/layout_tests/port/test.py: 4845 * Scripts/webkitpy/layout_tests/port/test_files.py: 4846 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 4847 48482011-03-15 Alejandro G. Castro <alex@igalia.com> 4849 4850 Reviewed by Martin Robinson. 4851 4852 [GTK] Fix compilation warning after r80892 4853 https://bugs.webkit.org/show_bug.cgi?id=56302 4854 4855 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 4856 (LayoutTestController::originsWithLocalStorage): 4857 48582011-03-15 Robert Hogan <robert@webkit.org> 4859 4860 Reviewed by Adam Barth. 4861 4862 Document the qmakearg argument, and hint how to build webkit2 on Qt 4863 https://bugs.webkit.org/show_bug.cgi?id=56326 4864 4865 * Scripts/build-webkit: add --qmakearg to build-webkit --help 4866 48672011-03-15 Adam Roben <aroben@apple.com> 4868 4869 Make Windows 7 Release (Tests) a core builder 4870 4871 We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably 4872 give it a few more days of greenness first. 4873 4874 Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder 4875 4876 Reviewed by Sam Weinig. 4877 4878 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 4879 (BuildBot): Added a regexp to match Windows 7 Release (Tests). 4880 4881 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 4882 (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org. 4883 Updated the core regexps to match the buildbot module. Updated the expected results to match 4884 the current set of core builders. 4885 48862011-03-14 Adam Roben <aroben@apple.com> 4887 4888 Add forgotten file from r81116 4889 4890 * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added. 4891 48922011-03-14 Sam Weinig <sam@webkit.org> 4893 4894 Reviewed by Adam Roben. 4895 4896 about:blank fake responses don't get serialized when sent the UIProcess 4897 <rdar://problem/9108119> 4898 https://bugs.webkit.org/show_bug.cgi?id=56357 4899 4900 * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added. 4901 (TestWebKitAPI::decidePolicyForResponse): 4902 (TestWebKitAPI::TEST): 4903 Add test that loads of about:blank have a response with a MIMEType of text/html. 4904 4905 * TestWebKitAPI/PlatformUtilities.h: 4906 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: 4907 (TestWebKitAPI::Util::MIMETypeForWKURLResponse): 4908 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: 4909 (TestWebKitAPI::Util::MIMETypeForWKURLResponse): 4910 Add helper to get the MIMEType from a WKURLResponse. 4911 4912 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 4913 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 4914 Add new files. 4915 49162011-03-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com> 4917 4918 Reviewed by Kenneth Rohde Christiansen. 4919 4920 [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser 4921 https://bugs.webkit.org/show_bug.cgi?id=56006 4922 4923 * QtTestBrowser/launcherwindow.cpp: 4924 (LauncherWindow::initializeView): 4925 * QtTestBrowser/main.cpp: 4926 (LauncherApplication::handleUserOptions): 4927 49282011-03-14 James Kozianski <koz@chromium.org> 4929 4930 Reviewed by Ojan Vafai. 4931 4932 Add method to make BuildBot return test outputs 4933 https://bugs.webkit.org/show_bug.cgi?id=54374 4934 4935 The Builder.latest_cached_build will be used by the new rebaseline 4936 script to determine the build to use baselines from. 4937 4938 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 4939 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 4940 49412011-03-14 Adam Roben <aroben@apple.com> 4942 4943 Test that WKBundlePageCanHandleRequest returns true for empty document URLs 4944 4945 Reviewed by Sam Weinig. 4946 4947 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added. 4948 (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test. 4949 (TestWebKitAPI::setInjectedBundleClient): Hook up our callback. 4950 (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to 4951 ensure the web process is initialized, then ask the bundle to run the test and assert that 4952 it succeeded. 4953 4954 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added. 4955 (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class. 4956 (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to 4957 handle a given URL. 4958 (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown 4959 URL type cannot be handled). 4960 (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the 4961 result. 4962 4963 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 4964 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 4965 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: 4966 Added new files to the project. 4967 49682011-03-14 Sheriff Bot <webkit.review.bot@gmail.com> 4969 4970 Unreviewed, rolling out r81094. 4971 http://trac.webkit.org/changeset/81094 4972 https://bugs.webkit.org/show_bug.cgi?id=56355 4973 4974 Broke the chromium DRT related build. (Requested by dave_levin 4975 on #webkit). 4976 4977 * DumpRenderTree/chromium/DumpRenderTree.cpp: 4978 (main): 4979 * DumpRenderTree/chromium/LayoutTestController.cpp: 4980 (LayoutTestController::LayoutTestController): 4981 (LayoutTestController::layerTreeAsText): 4982 * DumpRenderTree/chromium/LayoutTestController.h: 4983 * DumpRenderTree/chromium/TestShell.cpp: 4984 (TestShell::runFileTest): 4985 (TestShell::dump): 4986 * DumpRenderTree/chromium/TestShell.h: 4987 (TestParams::TestParams): 4988 49892011-03-14 Daniel Sievers <sievers@google.com> 4990 4991 Reviewed by Simon Fraser. 4992 4993 [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline 4994 https://bugs.webkit.org/show_bug.cgi?id=56139 4995 4996 * DumpRenderTree/chromium/DumpRenderTree.cpp: 4997 (main): 4998 * DumpRenderTree/chromium/LayoutTestController.cpp: 4999 (LayoutTestController::LayoutTestController): 5000 (LayoutTestController::layerTreeAsText): 5001 * DumpRenderTree/chromium/LayoutTestController.h: 5002 (LayoutTestController::setShowDebugLayerTree): 5003 * DumpRenderTree/chromium/TestShell.cpp: 5004 (TestShell::runFileTest): 5005 (TestShell::dump): 5006 * DumpRenderTree/chromium/TestShell.h: 5007 (TestParams::TestParams): 5008 50092011-03-14 Balazs Kelemen <kbalazs@webkit.org> 5010 5011 Reviewed by Adam Roben. 5012 5013 [Qt][WK2]Unbreak InjectedBundle on Qt 5014 https://bugs.webkit.org/show_bug.cgi?id=54109 5015 5016 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 5017 (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2 5018 API's instead of KURL to analyze the URL. 5019 * WebKitTestRunner/StringFunctions.h: 5020 (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally 5021 in the WebKitTestRunner project. 5022 (WTR::toWK): Use adoptWK. 5023 (WTR::operator<<): Added helper for printing a WKURL. 5024 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link 5025 against WebCore. 5026 50272011-03-14 Balazs Kelemen <kbalazs@webkit.org> 5028 5029 Reviewed by Kenneth Rohde Christiansen. 5030 5031 check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory 5032 https://bugs.webkit.org/show_bug.cgi?id=56321 5033 5034 * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c" 5035 to the list of exceptions for WebKit2 C API headers. 5036 50372011-03-14 Adam Roben <aroben@apple.com> 5038 5039 Show the list of recent leaky builds in reverse chronological order 5040 5041 Previously they were being shown in a deterministic but surprising order based on 5042 lexicographically sorting the build offsets (-1, -10, -2, -3...). 5043 5044 Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order 5045 5046 Reviewed by Darin Adler. 5047 5048 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: 5049 (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our 5050 callback. 5051 50522011-03-14 Adam Roben <aroben@apple.com> 5053 5054 Show a list of up to 10 recent leaky builds when Leaks Viewer loads 5055 5056 Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to 5057 analyze 5058 5059 Reviewed by David Kilzer and Joe Pecoraro. 5060 5061 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: 5062 (#url-prompt): Made this a bit taller to make room for the list of builds. 5063 5064 (#recent-builds-loading-indicator): 5065 (#recent-builds-list): 5066 Added styles for the build list and loading indicator. 5067 5068 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: 5069 (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading 5070 it. This will unescape it. 5071 (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt. 5072 (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt. 5073 (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds. 5074 (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the 5075 prompt UI. 5076 (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is 5077 now also used when a recent build is clicked. 5078 5079 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added. 5080 (RecentBuildsLoader): Store the callback. 5081 (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified 5082 builder. Find the revision number, leak count, and results URL for each one. Pass the 5083 resulting info to our callback. 5084 5085 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: 5086 (range): Added this helper function to return an array containing the integers [0, n). 5087 5088 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added 5089 RecentBuildsLoader.js and added text to the prompt UI to show the recent builds. 5090 50912011-03-14 Mark Rowe <mrowe@apple.com> 5092 5093 Reviewed by Adam Roben. 5094 5095 Fix two memory leaks within LayoutTestController's storage support. 5096 5097 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 5098 (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned 5099 by JSStringCreateWithCFString. 5100 (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we 5101 allocate. 5102 51032011-03-14 Mark Rowe <mrowe@apple.com> 5104 5105 Reviewed by Oliver Hunt. 5106 5107 <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot 5108 5109 * DumpRenderTree/LayoutTestController.cpp: 5110 (LayoutTestController::staticFunctions): Remove duplicate entries. 5111 51122011-03-14 Alice Liu <alice.liu@apple.com> 5113 5114 Reviewed by Dan Bernstein. 5115 5116 DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64" 5117 5118 * DumpRenderTree/mac/PerlSupport/Makefile: 5119 Add whitespace when joining "-arch" with the architectures passed in as arguments. 5120 51212011-03-14 Daniel Bates <dbates@rim.com> 5122 5123 https://bugs.webkit.org/show_bug.cgi?id=55438 5124 Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add 5125 when landing changeset 81041 <http://trac.webkit.org/changeset/81041>. 5126 5127 * Scripts/build-webkit: 5128 51292011-03-14 Daniel Bates <dbates@rim.com> 5130 5131 Reviewed by David Kilzer. 5132 5133 Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject() 5134 https://bugs.webkit.org/show_bug.cgi?id=55438 5135 5136 Separate out the EFL- and WinCE-specific logic from the port-independent logic in 5137 webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the 5138 CMake arguments for feature defines. 5139 5140 * Scripts/build-webkit: 5141 - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments. 5142 - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit(). 5143 - Sorted forward declarations. 5144 - Initialize $makeArgs with the empty string so as to simplify its use in string operations; 5145 Modified call sites as needed. 5146 * Scripts/webkitdirs.pm: 5147 - Added cleanCMakeGeneratedProject() to clean a CMake build. 5148 - Added buildCMakeGeneratedProject() to build using generated build system. 5149 - Added buildCMakeProjectOrExit() which is a facade for building a CMake project. 5150 - Added generateBuildSystemFromCMakeProject() to generate the build system from 5151 a CMake project. 5152 - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit(). 5153 51542011-03-14 John Knottenbelt <jknotten@chromium.org> 5155 5156 Reviewed by Steve Block. 5157 5158 Detach Geolocation from Frame when Page destroyed. 5159 https://bugs.webkit.org/show_bug.cgi?id=52877 5160 5161 Extend the layout test controller to expose the number of pending 5162 geolocation requests, so that we can test that the requests have 5163 been cancelled on page close. 5164 5165 * DumpRenderTree/LayoutTestController.cpp: 5166 (numberOfPendingGeolocationPermissionRequestsCallback): 5167 (LayoutTestController::staticFunctions): 5168 * DumpRenderTree/LayoutTestController.h: 5169 * DumpRenderTree/chromium/LayoutTestController.cpp: 5170 (LayoutTestController::LayoutTestController): 5171 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5172 * DumpRenderTree/chromium/LayoutTestController.h: 5173 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 5174 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5175 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 5176 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5177 * DumpRenderTree/mac/UIDelegate.h: 5178 * DumpRenderTree/mac/UIDelegate.mm: 5179 (-[UIDelegate numberOfPendingGeolocationPermissionRequests]): 5180 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5181 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5182 * DumpRenderTree/qt/LayoutTestControllerQt.h: 5183 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 5184 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5185 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 5186 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5187 5188 51892011-03-14 Gyuyoung Kim <gyuyoung.kim@samsung.com> 5190 5191 Unreviewed. Modify my email address in committers.py. 5192 5193 * Scripts/webkitpy/common/config/committers.py: 5194 51952011-03-13 Joe Wild <joseph.wild@nokia.com> 5196 5197 Reviewed by Kenneth Rohde Christiansen. 5198 5199 [Qt] QtLauncher does not load the same set of fonts as the DRT 5200 https://bugs.webkit.org/show_bug.cgi?id=34959 5201 5202 This patch adds the option "-use-test-fonts" to the QtTestBrowser. 5203 When this option is used the webkit fonts are loaded the same 5204 as they are in DumpRenderTree. This option can be used on 5205 QtTestBrowser and run-launcher. It can only be used 5206 on Linux systems with FcInit and is configured as such. 5207 5208 * QtTestBrowser/launcherwindow.h: 5209 (WindowOptions::WindowOptions): 5210 * QtTestBrowser/main.cpp: 5211 (initWebKitTestFonts): 5212 (launcherMain): 5213 (LauncherApplication::handleUserOptions): 5214 52152011-03-12 Dan Bernstein <mitz@apple.com> 5216 5217 Reviewed by Mark Rowe. 5218 5219 <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures 5220 DumpRenderTree is being built for. 5221 5222 * DumpRenderTree/mac/PerlSupport/Makefile: 5223 52242011-03-12 Dan Bernstein <mitz@apple.com> 5225 5226 Suggested by Mark Rowe. 5227 5228 * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled 5229 as they were before r80915. 5230 52312011-03-12 Anders Carlsson <andersca@apple.com> 5232 5233 Reviewed by Sam Weinig. 5234 5235 Should be able to download a PDF to the Downloads folder 5236 https://bugs.webkit.org/show_bug.cgi?id=56256 5237 5238 * MiniBrowser/mac/BrowserWindowController.m: 5239 (-[BrowserWindowController awakeFromNib]): 5240 * WebKitTestRunner/TestController.cpp: 5241 (WTR::TestController::createOtherPage): 5242 (WTR::TestController::initialize): 5243 Update for API changes. 5244 52452011-03-11 Anton D'Auria <adauria@apple.com> 5246 5247 Reviewed and landed by Brady Eidson. 5248 5249 https://bugs.webkit.org/show_bug.cgi?id=51878 5250 Add WebKit1 API to view and delete local storage 5251 5252 Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins. 5253 5254 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 5255 * DumpRenderTree/LayoutTestController.cpp: 5256 (syncLocalStorageCallback): 5257 (observeStorageTrackerNotificationsCallback): 5258 (deleteAllLocalStorageCallback): 5259 (deleteLocalStorageForOriginCallback): 5260 (originsWithLocalStorageCallback): 5261 (LayoutTestController::staticFunctions): 5262 * DumpRenderTree/LayoutTestController.h: 5263 * DumpRenderTree/StorageTrackerDelegate.h: Added. 5264 * DumpRenderTree/StorageTrackerDelegate.mm: Added. 5265 (-[StorageTrackerDelegate init]): 5266 (-[StorageTrackerDelegate logNotifications:controller:]): 5267 (-[StorageTrackerDelegate originModified:]): 5268 (-[StorageTrackerDelegate dealloc]): 5269 (-[StorageTrackerDelegate setControllerToNotifyDone:]): 5270 * DumpRenderTree/chromium/LayoutTestController.cpp: 5271 (LayoutTestController::LayoutTestController): 5272 (LayoutTestController::deleteAllLocalStorage): 5273 (LayoutTestController::originsWithLocalStorage): 5274 (LayoutTestController::deleteLocalStorageForOrigin): 5275 (observeStorageTrackerNotifications): 5276 (syncLocalStorage): 5277 * DumpRenderTree/chromium/LayoutTestController.h: 5278 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 5279 (LayoutTestController::originsWithLocalStorage): 5280 (LayoutTestController::deleteAllLocalStorage): 5281 (LayoutTestController::deleteLocalStorageForOrigin): 5282 (LayoutTestController::observeStorageTrackerNotifications): 5283 (LayoutTestController::syncLocalStorage): 5284 * DumpRenderTree/mac/DumpRenderTree.mm: 5285 (resetDefaultsToConsistentValues): 5286 (allocateGlobalControllers): 5287 (releaseGlobalControllers): 5288 * DumpRenderTree/mac/DumpRenderTreeMac.h: 5289 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 5290 (LayoutTestController::syncLocalStorage): 5291 (LayoutTestController::observeStorageTrackerNotifications): 5292 (LayoutTestController::deleteAllLocalStorage): 5293 (LayoutTestController::originsWithLocalStorage): 5294 (LayoutTestController::deleteLocalStorageForOrigin): 5295 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5296 (LayoutTestController::originsWithLocalStorage): 5297 (LayoutTestController::deleteAllLocalStorage): 5298 (LayoutTestController::deleteLocalStorageForOrigin): 5299 (LayoutTestController::observeStorageTrackerNotifications): 5300 (LayoutTestController::syncLocalStorage): 5301 * DumpRenderTree/qt/LayoutTestControllerQt.h: 5302 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 5303 (LayoutTestController::clearAllApplicationCaches): 5304 (LayoutTestController::syncLocalStorage): 5305 (LayoutTestController::observeStorageTrackerNotifications): 5306 (LayoutTestController::clearAllDatabases): 5307 (LayoutTestController::deleteAllLocalStorage): 5308 (LayoutTestController::originsWithLocalStorage): 5309 (LayoutTestController::deleteLocalStorageForOrigin): 5310 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 5311 (LayoutTestController::syncLocalStorage): 5312 (LayoutTestController::observeStorageTrackerNotifications): 5313 (LayoutTestController::clearAllDatabases): 5314 (LayoutTestController::deleteAllLocalStorage): 5315 (LayoutTestController::originsWithLocalStorage): 5316 (LayoutTestController::deleteLocalStorageForOrigin): 5317 53182011-03-11 Jessie Berlin <jberlin@apple.com> 5319 5320 Reviewed by Adam Roben. 5321 5322 Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web 5323 Process has finished launching. 5324 https://bugs.webkit.org/show_bug.cgi?id=56208 5325 5326 * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added. 5327 (TestWebKitAPI::TEST): 5328 Test that calling WKContextClearResourceCaches works with both options when called before 5329 the Web Process is valid. 5330 5331 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 5332 Add the new test. 5333 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 5334 Ditto. 5335 53362011-03-11 Adam Roben <aroben@apple.com> 5337 5338 Make it possible to view all leaks from a build at once in Leaks Viewer 5339 5340 You can now give Leaks Viewer the URL of a build results page (e.g., 5341 <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it 5342 will load all the leaks files from that build. 5343 5344 Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks 5345 files from a particular build at once, rather than one at a time 5346 5347 Reviewed by David Kilzer. 5348 5349 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added. 5350 (LeaksLoader): Initialize our properties. 5351 (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and 5352 load it. Otherwise assume it's a build results page URL and start fetching the leaks files 5353 from that page. 5354 (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading 5355 so it can provide feedback. Then load each one and pass it to the client. 5356 (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse 5357 it into a DOM, pull out all the links to leaks files, and load each one. 5358 5359 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added. 5360 (LeaksParser): Initialize our worker. 5361 (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents. 5362 5363 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added. 5364 This code mostly came from Worker.js. 5365 (LeaksParserWorker): Initialize our profile. 5366 (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our 5367 profile. 5368 (LeaksParserWorker.prototype._parseLeaks): 5369 (LeaksParserWorker.prototype._createNode): 5370 (LeaksParserWorker.prototype._incorporateLeaks): 5371 Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed 5372 version of createProfile which adds to this.profile instead of making a new profile each 5373 time. 5374 (onmessage): Parse the file and send back the new profile. 5375 5376 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: 5377 (#loading-indicator): 5378 (#spinner): 5379 (#loading-indicator-label): 5380 Tweaked styles to accomodate a longer label. 5381 5382 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: 5383 (LeaksViewer.loaded): Set up a loader and parser. 5384 5385 (LeaksViewer.get filesLeftToParse): 5386 (LeaksViewer.set filesLeftToParse): 5387 Added these simple accessors. 5388 5389 (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count. 5390 (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to 5391 the parser. 5392 (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed, 5393 tell the ProfilerAgent and mark that we're done loading. (Code came from the old 5394 _loadLeaksFromURL function). 5395 (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader. 5396 (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the 5397 loading indicator, including the number of files being loaded. 5398 (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too. 5399 (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label! 5400 (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to 5401 _loadingIndicatorText. 5402 5403 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added. 5404 (getResource): Moved here from LeaksViewer.js. 5405 5406 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by 5407 LeaksParserWorker.js. 5408 5409 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS 5410 files, added a #loading-indicator-label element, and tweaked the prompt wording. 5411 54122011-03-11 Adam Roben <aroben@apple.com> 5413 5414 Don't trigger a build when build.webkit.org's HTML files are modified 5415 5416 Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did 5417 5418 Reviewed by Dan Bernstein. 5419 5420 * Scripts/webkitpy/common/config/build.py: 5421 (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of 5422 directories that shouldn't trigger builds. Re-sorted the list. 5423 5424 * Scripts/webkitpy/common/config/build_unittest.py: 5425 (ShouldBuildTest): Added a test to cover the above change. 5426 54272011-03-11 Adam Roben <aroben@apple.com> 5428 5429 Roll out r80848 5430 5431 It was accidentally committed. 5432 5433 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: 5434 (LeaksViewer._loadLeaksFromURL): 5435 54362011-03-11 Tony Chang <tony@chromium.org> 5437 5438 Reviewed by Ojan Vafai. 5439 5440 kill hung lighttpd processes on the chromium win bot 5441 https://bugs.webkit.org/show_bug.cgi?id=56152 5442 5443 Sometimes this process doesn't exit and it holds on to 5444 a log file that we can't delete or copy, causing the tests 5445 to go red. 5446 5447 * BuildSlaveSupport/win/kill-old-processes: 5448 54492011-03-11 Ilya Sherman <isherman@chromium.org> 5450 5451 Reviewed by Kent Tamura. 5452 5453 [Chromium] missing HTMLInputElement::setValueForUser() to tests 5454 https://bugs.webkit.org/show_bug.cgi?id=55854 5455 5456 * DumpRenderTree/chromium/LayoutTestController.cpp: 5457 (LayoutTestController::LayoutTestController): 5458 (LayoutTestController::setValueForUser): Added. 5459 * DumpRenderTree/chromium/LayoutTestController.h: 5460 54612011-03-10 Peter Kasting <pkasting@google.com> 5462 5463 Reviewed by Dimitri Glazkov. 5464 5465 Clean up some gross code in TestShellWin.cpp. No functional change. 5466 https://bugs.webkit.org/show_bug.cgi?id=56048 5467 5468 * DumpRenderTree/chromium/TestShellWin.cpp: 5469 (checkLayoutTestSystemDependencies): 5470 54712011-03-10 Keith Kyzivat <keith.kyzivat@nokia.com> 5472 5473 Reviewed by Laszlo Gombos. 5474 5475 [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian) 5476 5477 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: 5478 (WTR::activateFonts): Guard X11-specific code with Q_WS_X11. 5479 54802011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com> 5481 5482 Reviewed by Kenneth Rohde Christiansen. 5483 5484 [EFL] Make single backing store the default for EWebLauncher 5485 https://bugs.webkit.org/show_bug.cgi?id=55753 5486 5487 Set single backing store the default for EWebLauncher. 5488 5489 * EWebLauncher/main.c: 5490 (main): 5491 54922011-03-10 Adam Roben <aroben@apple.com> 5493 5494 Ignore errors from files being held open when creating a test result archive 5495 5496 Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive 5497 fails to delete the results directory 5498 5499 Reviewed by Mark Rowe. 5500 5501 * BuildSlaveSupport/test-result-archive: 5502 (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be 5503 thrown when a process is holding a file open. 5504 55052011-03-10 Sheriff Bot <webkit.review.bot@gmail.com> 5506 5507 Unreviewed, rolling out r80701. 5508 http://trac.webkit.org/changeset/80701 5509 https://bugs.webkit.org/show_bug.cgi?id=56126 5510 5511 fast/dom/Geolocation/window-close-crash.html fails on Snow 5512 Leopard release builds (Requested by mihaip on #webkit). 5513 5514 * DumpRenderTree/LayoutTestController.cpp: 5515 (LayoutTestController::staticFunctions): 5516 * DumpRenderTree/LayoutTestController.h: 5517 * DumpRenderTree/chromium/LayoutTestController.cpp: 5518 (LayoutTestController::LayoutTestController): 5519 * DumpRenderTree/chromium/LayoutTestController.h: 5520 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 5521 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 5522 * DumpRenderTree/mac/UIDelegate.h: 5523 * DumpRenderTree/mac/UIDelegate.mm: 5524 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5525 * DumpRenderTree/qt/LayoutTestControllerQt.h: 5526 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 5527 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 5528 55292011-03-10 Philippe Normand <pnormand@igalia.com> 5530 5531 Reviewed by Gustavo Noronha Silva. 5532 5533 [GTK] run-gtk-tests doesn't fail if a test crashes 5534 https://bugs.webkit.org/show_bug.cgi?id=56089 5535 5536 * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status 5537 even if a test crashes. So run the tests individually and if a 5538 test fails remember its exit code so run-gtk-test fails too, if 5539 required. 5540 55412011-01-26 John Knottenbelt <jknotten@chromium.org> 5542 5543 Reviewed by Dmitry Titov. 5544 5545 Detach Geolocation from Frame when Page destroyed. 5546 https://bugs.webkit.org/show_bug.cgi?id=52877 5547 5548 Extend the layout test controller to expose the number of pending 5549 geolocation requests, so that we can test that the requests have 5550 been cancelled on page close. 5551 5552 * DumpRenderTree/LayoutTestController.cpp: 5553 (numberOfPendingGeolocationPermissionRequestsCallback): 5554 (LayoutTestController::staticFunctions): 5555 * DumpRenderTree/LayoutTestController.h: 5556 * DumpRenderTree/chromium/LayoutTestController.cpp: 5557 (LayoutTestController::LayoutTestController): 5558 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5559 * DumpRenderTree/chromium/LayoutTestController.h: 5560 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 5561 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5562 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 5563 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5564 * DumpRenderTree/mac/UIDelegate.h: 5565 * DumpRenderTree/mac/UIDelegate.mm: 5566 (-[UIDelegate numberOfPendingGeolocationPermissionRequests]): 5567 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5568 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5569 * DumpRenderTree/qt/LayoutTestControllerQt.h: 5570 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 5571 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5572 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 5573 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 5574 5575 55762011-03-09 Adam Roben <aroben@apple.com> 5577 5578 Hide Leaks Viewer's URL prompt by default 5579 5580 We will show it as needed. I think I left it visible by default by accident after doing some 5581 testing. 5582 5583 Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a 5584 URL is passed as a query parameter, but does 5585 5586 Reviewed by Simon Fraser. 5587 5588 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: 5589 55902011-03-09 Adam Roben <aroben@apple.com> 5591 5592 Don't use Element.classList or box-shadow in Leaks Viewer 5593 5594 They aren't supported by Safari 5. Luckily we have substitutes for them! 5595 5596 Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5 5597 5598 Reviewed by Simon Fraser. 5599 5600 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: 5601 (#url-prompt): Use -webkit-box-shadow instead of box-shadow. 5602 5603 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: 5604 (LeaksViewer.urlPromptButtonClicked): 5605 (LeaksViewer._displayURLPrompt): 5606 (LeaksViewer._setLoadingIndicatorHidden): 5607 Use add/removeStyleClass (from utilities.js) instead of Element.classList. 5608 56092011-03-09 Adam Roben <aroben@apple.com> 5610 5611 Add a link to the Leaks Viewer tool on the build.webkit.org homepage 5612 5613 Rubber-stamped by David Kilzer. 5614 5615 * BuildSlaveSupport/build.webkit.org-config/templates/root.html: 5616 56172011-03-09 Adam Roben <aroben@apple.com> 5618 5619 Add a Leaks Viewer tool to build.webkit.org 5620 5621 This tool parses leaks from the files generated by the leaks bot and displays them in a 5622 view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's 5623 code). 5624 5625 The URL of the leaks file can be entered in a prompt when the tools is first shown, or can 5626 be passed to the tool via the "url" query parameter. 5627 5628 Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to 5629 the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web 5630 Inspector's Heavy profile view. But it's still pretty useful as-is. 5631 5632 Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots 5633 5634 Reviewed by Darin Adler. 5635 5636 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added. 5637 (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt. 5638 (#url-prompt): This is the prompt itself. 5639 5640 (#loading-indicator): 5641 (#loading-indicator > img): 5642 These show a spinner in the bottom-right when we're loading a leaks file. 5643 5644 (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks 5645 as percentages. 5646 5647 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added. 5648 (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a 5649 URL if one wasn't given to us as a query parameter). 5650 5651 (LeaksViewer.get loading): 5652 (LeaksViewer.set loading): 5653 (LeaksViewer.get url): 5654 (LeaksViewer.set url): 5655 Pretty simple accessors. 5656 5657 (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the 5658 prompt. 5659 (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input. 5660 (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the 5661 file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off 5662 the profile to the Web Inspector code once it's been created. 5663 (LeaksViewer._loadingStatusChanged): Update our loading indicator and title. 5664 (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator. 5665 (LeaksViewer._updateTitle): Set our title based on our URL and loading status. 5666 (getResource): Helper function to fetch a resource via XHR and pass it to a callback. 5667 5668 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added. 5669 (WebInspector.UIString): Just a simple implementation since this tool isn't localized. 5670 (ProfilerAgent.getProfile): Store the callback. 5671 (ProfilerAgent.profileReady): Call the callback. 5672 (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak 5673 count and total leak counts as real values, not percentages or milliseconds. 5674 5675 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added. 5676 (onmessage): Create a profile based on the leaks file and pass it back to our caller. 5677 (parseLeaks): Extract call stacks out of a leaks file. 5678 (createNode): Helper function to create a new empty profile node. 5679 (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by 5680 WebInspector.ProfileView. 5681 5682 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added. 5683 56842011-03-09 Dan Bernstein <mitz@apple.com> 5685 5686 Reviewed by Adam Roben. 5687 5688 Combine multiple --ignore-tests values 5689 https://bugs.webkit.org/show_bug.cgi?id=56016 5690 5691 * Scripts/old-run-webkit-tests: 5692 56932011-03-08 Kenji Imasaki <imasaki@chromium.org> 5694 5695 Reviewed by David Levin. 5696 5697 Adding myself to the committer file. 5698 5699 * Scripts/webkitpy/common/config/committers.py: 5700 57012011-03-08 Jessie Berlin <jberlin@apple.com> 5702 5703 Rubber-stamped by Adam Roben. 5704 5705 Fix two leaks I introduced into the API tests. 5706 5707 * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: 5708 (TestWebKitAPI::TEST): 5709 57102011-03-08 Jessie Berlin <jberlin@apple.com> 5711 5712 Reviewed by Anders Carlsson. 5713 5714 Crash in CFNetwork visiting google.com 5715 https://bugs.webkit.org/show_bug.cgi?id=55958 5716 5717 Add a test for not trying to copy a null CFURLResponse. 5718 5719 * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added. 5720 (TestWebKitAPI::TEST): 5721 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 5722 57232011-03-08 Hayato Ito <hayato@chromium.org> 5724 5725 Reviewed by Ojan Vafai. 5726 5727 [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class. 5728 5729 FailureWithType is a confusing naming because we have removed test_type/* classes in r79840. 5730 5731 https://bugs.webkit.org/show_bug.cgi?id=55450 5732 5733 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: 5734 57352011-03-08 Carlos Garcia Campos <cgarcia@igalia.com> 5736 5737 Reviewed by Martin Robinson. 5738 5739 [GTK] Add layoutTestController.setValueForUser() after r80412 5740 https://bugs.webkit.org/show_bug.cgi?id=55862 5741 5742 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 5743 (LayoutTestController::setValueForUser): Implement setValueForUser() 5744 57452011-03-08 Patrick Gansterer <paroga@webkit.org> 5746 5747 Reviewed by Adam Barth. 5748 5749 Add script_shell_command to WebKitPort 5750 https://bugs.webkit.org/show_bug.cgi?id=55925 5751 5752 Add a central place where we generate the shell command from the script name. 5753 This function will be used later to detect the correct script interpreter on Win32. 5754 5755 * Scripts/webkitpy/common/config/ports.py: 5756 * Scripts/webkitpy/layout_tests/port/base.py: 5757 * Scripts/webkitpy/tool/steps/abstractstep.py: 5758 * Scripts/webkitpy/tool/steps/preparechangelog.py: 5759 57602011-03-07 Ojan Vafai <ojan@chromium.org> 5761 5762 Reviewed by Adam Barth. 5763 5764 add webkit-patch attach-to-bug for posting to bugzilla from the commandline 5765 https://bugs.webkit.org/show_bug.cgi?id=55749 5766 5767 * Scripts/webkitpy/tool/commands/upload.py: 5768 * Scripts/webkitpy/tool/commands/upload_unittest.py: 5769 * Scripts/webkitpy/tool/steps/__init__.py: 5770 * Scripts/webkitpy/tool/steps/attachtobug.py: Added. 5771 * Scripts/webkitpy/tool/steps/options.py: 5772 57732011-03-07 Daniel Cheng <dcheng@chromium.org> 5774 5775 Reviewed by David Levin. 5776 5777 Add support for DataTransferItems 5778 https://bugs.webkit.org/show_bug.cgi?id=55115 5779 5780 Enable data transfer items in DRT. 5781 5782 * DumpRenderTree/chromium/TestShell.cpp: 5783 (TestShell::TestShell): 5784 57852011-03-06 Ojan Vafai <ojan@chromium.org> 5786 5787 Reviewed by Tony Chang. 5788 5789 [test dashboard] pull treemap files 5790 https://bugs.webkit.org/show_bug.cgi?id=55852 5791 5792 * TestResultServer/handlers/dashboardhandler.py: 5793 57942011-03-03 Hayato Ito <hayato@chromium.org> 5795 5796 Reviewed by Mihai Parparita. 5797 5798 [NRWT] Clear output image file used by DumpRenderTree to make sure the 5799 previous image should not be used in the ChromiumDriver. 5800 5801 Also make sure that output image from the ChromiumDriver should be '' 5802 (empty string) if a test crashes for consistency with the WebKitDriver 5803 implementation. 5804 5805 https://bugs.webkit.org/show_bug.cgi?id=55746 5806 5807 * Scripts/webkitpy/layout_tests/port/chromium.py: 5808 58092011-03-07 Zan Dobersek <zandobersek@gmail.com> 5810 5811 Reviewed by Martin Robinson. 5812 5813 [Gtk] fast/js/navigator-language.html fails locally 5814 https://bugs.webkit.org/show_bug.cgi?id=55880 5815 5816 Add LANG variable to the clean environment when running 5817 old-run-webkit-tests script. 5818 5819 * Scripts/old-run-webkit-tests: 5820 58212011-03-07 Tony Chang <tony@chromium.org> 5822 5823 Reviewed by Mihai Parparita. 5824 5825 [Chromium] Find .checksum files without .pngs and vice-versa 5826 https://bugs.webkit.org/show_bug.cgi?id=55236 5827 5828 * Scripts/find-mismatched-layout-test-results: Added. A script for finding 5829 mismatched results. 5830 58312011-03-07 Chris Fleizach <cfleizach@apple.com> 5832 5833 Reviewed by Beth Dakin. 5834 5835 AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element. 5836 https://bugs.webkit.org/show_bug.cgi?id=55706 5837 5838 The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject. 5839 5840 * DumpRenderTree/mac/AccessibilityControllerMac.mm: 5841 (AccessibilityController::focusedElement): 5842 Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 5843 because it could change at any time. 5844 (AccessibilityController::rootElement): 5845 58462011-03-07 Sam Weinig <sam@webkit.org> 5847 5848 Reviewed by Anders Carlsson. 5849 5850 Add unableToImplementPolicy callback for WebKit2 policy client 5851 <rdar://problem/9071902> 5852 https://bugs.webkit.org/show_bug.cgi?id=55884 5853 5854 * MiniBrowser/mac/BrowserWindowController.m: 5855 (-[BrowserWindowController awakeFromNib]): 5856 Update policy client initialization struct for new member. 5857 58582011-03-07 Sam Weinig <sam@webkit.org> 5859 5860 Reviewed by Anders Carlsson. 5861 5862 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse 5863 https://bugs.webkit.org/show_bug.cgi?id=55827 5864 5865 * MiniBrowser/mac/BrowserWindowController.m: 5866 (decidePolicyForResponse): 5867 (-[BrowserWindowController awakeFromNib]): 5868 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: 5869 (TestWebKitAPI::decidePolicyForResponse): 5870 (TestWebKitAPI::TEST): 5871 Update tools for new name. 5872 58732011-03-06 Daniel Bates <dbates@rim.com> 5874 5875 Reviewed by Eric Seidel and David Kilzer. 5876 5877 Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations 5878 https://bugs.webkit.org/show_bug.cgi?id=55503 5879 5880 Fix misspelled word "Dowloads" [sic] in the message printed to standard output 5881 in checkForJavaSDK(). 5882 5883 Also, remove extraneous space in function prototype for unlinkZeroFiles. 5884 5885 * Scripts/build-webkit: 5886 58872011-03-05 Brian Weinstein <bweinstein@apple.com> 5888 5889 Reviewed by Sam Weinig. 5890 5891 Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919. 5892 5893 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 5894 (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned 5895 by willSendRequestForFrame. The API expects a retained reference to the URL request. 5896 58972011-03-05 Ilya Sherman <isherman@chromium.org> 5898 5899 Reviewed by Darin Adler. 5900 5901 HTMLInputElement::setValue() should schedule change event when the element is focused 5902 In service of https://code.google.com/p/chromium/issues/detail?id=42716 5903 https://bugs.webkit.org/show_bug.cgi?id=53160 5904 5905 * DumpRenderTree/LayoutTestController.cpp: 5906 (setValueForUserCallback): 5907 (LayoutTestController::staticFunctions): 5908 * DumpRenderTree/LayoutTestController.h: 5909 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 5910 (LayoutTestController::setValueForUser): Stubbed out; need real implementation. 5911 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 5912 (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests 5913 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 5914 (LayoutTestController::setValueForUser): Stubbed out; need real implementation. 5915 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 5916 (LayoutTestController::setValueForUser): Stubbed out; need real implementation. 5917 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 5918 (LayoutTestController::setValueForUser): Stubbed out; need real implementation. 5919 59202011-03-04 Mark Rowe <mrowe@apple.com> 5921 5922 Reviewed by Alexey Proskuryakov. 5923 5924 <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc 5925 5926 GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only. 5927 5928 * DumpRenderTree/mac/CheckedMalloc.cpp: 5929 (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address. 5930 (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable, 5931 and then restore the initial protection flags when we're done. 5932 59332011-03-04 Evan Martin <evan@chromium.org> 5934 5935 Reviewed by Tony Chang. 5936 5937 [gdb] pretty-print KURL in gdb 5938 https://bugs.webkit.org/show_bug.cgi?id=55788 5939 5940 * gdb/webkit.py: extend the pretty-printers to print WTF::CString 5941 and KURLGooglePrivate. As always, "p/r" can be used to sidestep 5942 pretty-printing. 5943 59442011-03-03 Timothy Hatcher <timothy@apple.com> 5945 5946 Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef. 5947 5948 Reviewed by Darin Adler. 5949 5950 * TestWebKitAPI/JavaScriptTest.cpp: 5951 (TestWebKitAPI::javaScriptCallback): 5952 * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: 5953 (TestWebKitAPI::didRunJavaScript): 5954 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: 5955 (TestWebKitAPI::nullJavaScriptCallback): 5956 * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: 5957 (TestWebKitAPI::didRunJavaScript): 5958 59592011-03-03 Timothy Hatcher <timothy@apple.com> 5960 5961 Make run-api-tests show failed if a test fails. 5962 5963 https://webkit.org/b/55725 5964 5965 Reviewed by Sam Weinig. 5966 5967 * Scripts/run-api-tests: 5968 (runTest): Remove "my" from the nested $result assignment so the 5969 check outside the condition sees the real result. 5970 59712011-03-02 MORITA Hajime <morrita@google.com> 5972 5973 Reviewed by Kent Tamura. 5974 5975 [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor 5976 https://bugs.webkit.org/show_bug.cgi?id=55434 5977 5978 Changed WebTask to be a subclass of webkit_support::TaskAdaptor 5979 and passed the object webkit_support::PostDelayedTask directly. 5980 5981 Note that the change keeps postTask() as is because it has a 5982 semantics taht webkit_support::PostDelayedTask() has; It jumps to 5983 the main thread. 5984 5985 * DumpRenderTree/chromium/Task.cpp: 5986 (postDelayedTask): 5987 * DumpRenderTree/chromium/Task.h: 5988 (WebTask::Run): 5989 59902011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 5991 5992 Reviewed by Kenneth Rohde Christiansen. 5993 5994 [QT] Implement mock client-based geolocation for layout testing 5995 https://bugs.webkit.org/show_bug.cgi?id=54334 5996 5997 Implement testing for Client-Based geolocation for QtWebkit. 5998 5999 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 6000 (WebCore::DumpRenderTree::DumpRenderTree): 6001 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 6002 (LayoutTestController::reset): 6003 (LayoutTestController::setGeolocationPermission): 6004 (LayoutTestController::setMockGeolocationError): 6005 (LayoutTestController::setMockGeolocationPosition): 6006 60072011-03-03 Sheriff Bot <webkit.review.bot@gmail.com> 6008 6009 Unreviewed, rolling out r80237. 6010 http://trac.webkit.org/changeset/80237 6011 https://bugs.webkit.org/show_bug.cgi?id=55714 6012 6013 Windows bots aren't ready to be core (Requested by aroben on 6014 #webkit). 6015 6016 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 6017 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 6018 60192011-03-03 Mihai Parparita <mihaip@chromium.org> 6020 6021 Reviewed by Tony Chang. 6022 6023 NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers' 6024 https://bugs.webkit.org/show_bug.cgi?id=55694 6025 6026 Fixes for interruptions in NRWT: 6027 - Make TestRunInterruptedException be pickleable correctly (the base 6028 Exception class defines a __reduce__ that does not include the reason) 6029 - Fix ordering of returned arguments from TestRunner2._run_tests 6030 (interrupted and keyboard_interrupted were reversed) 6031 - Fix cancel_workers callsites (was using old name). 6032 - In handle_exception re-raise actual exception instance that was thrown 6033 6034 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 6035 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 6036 * Scripts/webkitpy/layout_tests/layout_package/worker.py: 6037 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 6038 60392011-03-03 Qi Zhang <qi.2.zhang@nokia.com> 6040 6041 Unreviewed. 6042 6043 Adding myself as a committer. 6044 6045 * Scripts/webkitpy/common/config/committers.py: 6046 60472011-03-03 Tony Gentilcore <tonyg@chromium.org> 6048 6049 Reviewed by Mihai Parparita. 6050 6051 Teach sheriffbot to answer whois commands 6052 https://bugs.webkit.org/show_bug.cgi?id=55687 6053 6054 * Scripts/webkitpy/tool/bot/irc_command.py: 6055 * Scripts/webkitpy/tool/bot/irc_command_unittest.py: 6056 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: 6057 60582011-03-03 Victoria Kirst <vrk@google.com> 6059 6060 Reviewed by Eric Carlson. 6061 6062 Enable media tests in chromium-gpu/test_expectations 6063 https://bugs.webkit.org/show_bug.cgi?id=53608 6064 6065 Add media folder to the list of GPU test paths. 6066 6067 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 6068 60692011-03-03 Adam Roben <aroben@apple.com> 6070 6071 Work around a bug in KURL's parsing of Windows-style absolute file: URLs 6072 6073 Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to 6074 incorrect parsing of absolute Windows-style file: URLs 6075 6076 Reviewed by Tim Hatcher. 6077 6078 * WebKitTestRunner/TestInvocation.cpp: 6079 (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around 6080 <http://webkit.org/b/55683>. 6081 60822011-03-03 Tony Chang <tony@chromium.org> 6083 6084 Reviewed by Dimitri Glazkov. 6085 6086 [chromium] Run kill-old-processes on the chromium-win bot too 6087 https://bugs.webkit.org/show_bug.cgi?id=55630 6088 6089 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 6090 * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list. 6091 60922011-03-03 Carlos Garcia Campos <cgarcia@igalia.com> 6093 6094 Reviewed by Martin Robinson. 6095 6096 [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick 6097 https://bugs.webkit.org/show_bug.cgi?id=53960 6098 6099 * DumpRenderTree/gtk/EventSender.cpp: 6100 (sendClick): 6101 (scheduleAsynchronousClickCallback): 6102 61032011-03-03 Adam Roben <aroben@apple.com> 6104 6105 Look for Windows-style paths when checking whether a test is an Inspector test 6106 6107 WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time 6108 out or crash on Windows 7 Release (WebKit2 Tests) 6109 6110 Reviewed by Darin Adler. 6111 6112 * WebKitTestRunner/TestInvocation.cpp: 6113 (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on 6114 Windows. 6115 61162011-03-03 Adam Roben <aroben@apple.com> 6117 6118 Make Windows 7 Release (Tests) a core builder 6119 6120 We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably 6121 give it a few more days of greenness first. 6122 6123 Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder 6124 6125 Reviewed by Andreas Kling. 6126 6127 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 6128 (BuildBot): Added a regexp to match Windows 7 Release (Tests). 6129 6130 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 6131 (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org. 6132 Updated the core regexps to match the buildbot module. Updated the expected results to match 6133 the current set of core builders. 6134 61352011-03-03 Benjamin Poulain <benjamin.poulain@nokia.com> 6136 6137 Reviewed by Andreas Kling. 6138 6139 Adding myself as a reviewer. 6140 6141 * Scripts/webkitpy/common/config/committers.py: 6142 61432011-03-03 Lukasz Slachciak <l.slachciak@samsung.com> 6144 6145 Reviewed by Xan Lopez. 6146 6147 [GTK] Extended application cache database API and added unit tests file. 6148 https://bugs.webkit.org/show_bug.cgi?id=55335 6149 6150 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration 6151 of webkit_application_cache_set_maximum_size due to API exposal. 6152 61532011-03-02 Ojan Vafai <ojan@chromium.org> 6154 6155 Reviewed by Adam Barth. 6156 6157 make webkit-patch upload work for security bugs 6158 https://bugs.webkit.org/show_bug.cgi?id=55655 6159 6160 The problem is that we shell out to prepare-ChangeLog, 6161 which does not authenticate with bugzilla. All it needs from 6162 bugzilla is the bug title though. We just pass it through from 6163 webkit-patch instead. 6164 6165 * Scripts/prepare-ChangeLog: 6166 * Scripts/webkitpy/common/net/bugzilla/bug.py: 6167 * Scripts/webkitpy/tool/steps/preparechangelog.py: 6168 61692011-03-01 Ojan Vafai <ojan@chromium.org> 6170 6171 Reviewed by Tony Chang. 6172 6173 [test-dashboard] make gtest JSON match layout-tests JSON 6174 https://bugs.webkit.org/show_bug.cgi?id=55556 6175 6176 http://trac.webkit.org/changeset/80090 stopped converting time_ms to t. 6177 Make this code match. 6178 6179 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 6180 61812011-03-02 Dirk Pranke <dpranke@chromium.org> 6182 6183 Reviewed by Tony Chang. 6184 6185 NRWT - implement Linux Hardy 64-bit port support. This involves 6186 adding support for non-'x86' architectures and updating the 6187 "deduplicate_tests" script to correctly understand that 6188 port.name() is not always equal to basename(port.baseline_path()). 6189 6190 This change introduces two new port names: 'chromium-linux-x86' 6191 and 'chromium-linux-x86_64'. Using the prior 'chromium-linux' 6192 flag will cause the code to determine which one to use at 6193 runtime, just like we currently do with 'chromium-win'. 6194 6195 https://bugs.webkit.org/show_bug.cgi?id=55535 6196 6197 * Scripts/webkitpy/common/system/executive_mock.py: 6198 Handle 'return_stderr' keyword arg to run_command() 6199 * Scripts/webkitpy/layout_tests/deduplicate_tests.py: 6200 * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: 6201 * Scripts/webkitpy/layout_tests/port/base.py: 6202 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 6203 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: 6204 * Scripts/webkitpy/layout_tests/port/factory.py: 6205 * Scripts/webkitpy/layout_tests/port/google_chrome.py: 6206 62072011-03-02 Kevin Ollivier <kevino@theolliviers.com> 6208 6209 [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and 6210 update symlinks accordingly. 6211 6212 * wx/packaging/build-mac-installer.py: 6213 62142011-03-02 Sheriff Bot <webkit.review.bot@gmail.com> 6215 6216 Unreviewed, rolling out r80139. 6217 http://trac.webkit.org/changeset/80139 6218 https://bugs.webkit.org/show_bug.cgi?id=55620 6219 6220 failing and crashing tests on Snow Leopard bot (Requested by 6221 mihaip1 on #webkit). 6222 6223 * DumpRenderTree/LayoutTestController.cpp: 6224 (LayoutTestController::staticFunctions): 6225 * DumpRenderTree/LayoutTestController.h: 6226 * DumpRenderTree/chromium/LayoutTestController.cpp: 6227 (LayoutTestController::LayoutTestController): 6228 * DumpRenderTree/chromium/LayoutTestController.h: 6229 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 6230 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 6231 * DumpRenderTree/mac/UIDelegate.h: 6232 * DumpRenderTree/mac/UIDelegate.mm: 6233 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 6234 * DumpRenderTree/qt/LayoutTestControllerQt.h: 6235 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 6236 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 6237 62382011-03-02 Adam Roben <aroben@apple.com> 6239 6240 Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output 6241 6242 This matches DumpRenderTree on Windows. 6243 6244 Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of 6245 dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas 6246 in WebKit2 6247 6248 Reviewed by Beth Dakin. 6249 6250 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 6251 (WTR::InjectedBundlePage::dump): Moved code to force a paint here... 6252 (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here. 6253 62542011-03-02 Daniel Cheng <dcheng@chromium.org> 6255 6256 Reviewed by David Levin. 6257 6258 Add feature define for data transfer items 6259 https://bugs.webkit.org/show_bug.cgi?id=55510 6260 6261 * Scripts/build-webkit: 6262 62632011-03-02 Adam Roben <aroben@apple.com> 6264 6265 Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer 6266 6267 ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to 6268 ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in 6269 the former location, but was getting lucky on some SnowLeopard machines because symlinks 6270 were being created there pointing into DiagnosticReports. For machines without these 6271 symlinks, crash logs were not getting captured. 6272 6273 Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some 6274 SnowLeopard machines 6275 6276 Reviewed by Eric Seidel. 6277 6278 * Scripts/old-run-webkit-tests: 6279 (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer. 6280 62812011-03-02 Adam Roben <aroben@apple.com> 6282 6283 Don't try to capture crash logs on platforms that haven't implemented that feature 6284 6285 Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at 6286 Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash 6287 6288 Reviewed by Joseph Pecoraro. 6289 6290 * Scripts/old-run-webkit-tests: 6291 (captureSavedCrashLog): Bail if we don't have a crash log glob. 6292 (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't 6293 strictly required to fix bug 55504, but seems worthwhile. 6294 62952011-01-26 John Knottenbelt <jknotten@chromium.org> 6296 6297 Reviewed by Dmitry Titov. 6298 6299 Detach Geolocation from Frame when Page destroyed. 6300 https://bugs.webkit.org/show_bug.cgi?id=52877 6301 6302 Extend the layout test controller to expose the number of pending 6303 geolocation requests, so that we can test that the requests have 6304 been cancelled on page close. 6305 6306 * DumpRenderTree/LayoutTestController.cpp: 6307 (numberOfPendingGeolocationPermissionRequestsCallback): 6308 (LayoutTestController::staticFunctions): 6309 * DumpRenderTree/LayoutTestController.h: 6310 * DumpRenderTree/chromium/LayoutTestController.cpp: 6311 (LayoutTestController::LayoutTestController): 6312 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 6313 * DumpRenderTree/chromium/LayoutTestController.h: 6314 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 6315 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 6316 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 6317 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 6318 * DumpRenderTree/mac/UIDelegate.h: 6319 * DumpRenderTree/mac/UIDelegate.mm: 6320 (-[UIDelegate numberOfPendingGeolocationPermissionRequests]): 6321 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 6322 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 6323 * DumpRenderTree/qt/LayoutTestControllerQt.h: 6324 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 6325 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 6326 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 6327 (LayoutTestController::numberOfPendingGeolocationPermissionRequests): 6328 6329 63302011-03-01 Kent Tamura <tkent@chromium.org> 6331 6332 Reviewed by Dimitri Glazkov. 6333 6334 Assertion fails when a form validation bubble appears 6335 https://bugs.webkit.org/show_bug.cgi?id=55550 6336 6337 Test: fast/forms/interactive-validation-attach-assertion.html 6338 6339 * DumpRenderTree/chromium/WebPreferences.cpp: 6340 (WebPreferences::applyTo): Enable the interactive validation feature by 6341 default. This matches to Chromium browser. 6342 63432011-03-01 Gyuyoung Kim <gyuyoung.kim@samsung.com> 6344 6345 Reviewed by Kent Tamura. 6346 6347 Remove efl port style exception of Webcore/JavaScriptCore 6348 https://bugs.webkit.org/show_bug.cgi?id=55549 6349 6350 WebCore and JavaScriptCore need to adhere WebKit coding style. 6351 6352 * Scripts/webkitpy/style/checker.py: 6353 63542011-03-01 Tony Chang <tony@chromium.org> 6355 6356 Reviewed by Ojan Vafai. 6357 6358 [chromium] clean up temp files on chromium-mac builder too 6359 https://bugs.webkit.org/show_bug.cgi?id=55525 6360 6361 * BuildSlaveSupport/chromium/remove-crash-logs: 6362 63632011-02-28 Ojan Vafai <ojan@chromium.org> 6364 6365 Reviewed by Tony Chang. 6366 6367 wrap json in a function call to afford cross-domain loading 6368 https://bugs.webkit.org/show_bug.cgi?id=55353 6369 6370 Also delete the code that compacts the JSON. It turns out this 6371 breaks the rebaseline tool and is probably a premature optimization anyways. 6372 6373 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 6374 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 6375 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6376 * Scripts/webkitpy/tool/commands/rebaselineserver.py: 6377 63782011-03-01 Sheriff Bot <webkit.review.bot@gmail.com> 6379 6380 Unreviewed, rolling out r80079. 6381 http://trac.webkit.org/changeset/80079 6382 https://bugs.webkit.org/show_bug.cgi?id=55547 6383 6384 "Broke the Win debug build?" (Requested by dcheng on #webkit). 6385 6386 * Scripts/build-webkit: 6387 63882011-03-01 Mark Rowe <mrowe@apple.com> 6389 6390 Reviewed by Sam Weinig. 6391 6392 Update verification scripts to handle WebKit2. 6393 6394 * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker. 6395 * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for 6396 WebKit2. 6397 63982011-03-01 Daniel Cheng <dcheng@chromium.org> 6399 6400 Reviewed by David Levin. 6401 6402 Add feature define for data transfer items 6403 https://bugs.webkit.org/show_bug.cgi?id=55510 6404 6405 * Scripts/build-webkit: 6406 64072011-02-23 Joseph Pecoraro <joepeck@webkit.org> 6408 6409 Reviewed by Timothy Hatcher. 6410 6411 All Console Messages should be passed to ChromeClients. 6412 https://bugs.webkit.org/show_bug.cgi?id=54926 6413 6414 Update DumpRenderTree's UIDelegate to use the new console message delegate. 6415 6416 * DumpRenderTree/mac/UIDelegate.mm: 6417 (-[UIDelegate webView:addMessageToConsole:withSource:]): 6418 64192011-03-01 Dirk Pranke <dpranke@chromium.org> 6420 6421 Reviewed by Adam Barth. 6422 6423 Tragically, we stopped running the python unit tests 6424 on Chromium Win just as I was getting them to be green. 6425 This patch turns them back on. 6426 6427 https://bugs.webkit.org/show_bug.cgi?id=55521 6428 6429 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 6430 64312011-03-01 Dirk Pranke <dpranke@chromium.org> 6432 6433 Reviewed by Adam Roben. 6434 6435 Disable 6436 webkitpy.common.system.executive_unittest.ExecutiveTest.\ 6437 test_kill_all fails on win until it can be properly triaged. 6438 6439 https://bugs.webkit.org/show_bug.cgi?id=54790 6440 6441 * Scripts/webkitpy/common/system/executive_unittest.py: 6442 6443 2011-03-01 Helder Correia <helder@sencha.com> 6444 6445 Unreviewed. Add myself to committers.py. 6446 6447 * Scripts/webkitpy/common/config/committers.py: 6448 64492011-03-01 Adam Roben <aroben@apple.com> 6450 6451 Give up if a crash log for the web process is taking too long to be saved on Windows 6452 6453 This should keep the bots from getting stuck while waiting for a crash log, if writing a 6454 crash log ever hangs or the UI process for some reason doesn't notice it's finished. 6455 6456 Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log 6457 to be saved for the web process 6458 6459 Reviewed by Steve Falkenburg. 6460 6461 * WebKitTestRunner/win/TestControllerWin.cpp: 6462 (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil. 6463 Generalized the code slightly to handle the optional object to wait on. 6464 (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use 6465 it (with a timeout) when waiting for a crash log for the web process to be saved. This will 6466 prevent us from waiting forever. 6467 64682011-03-01 Adam Roben <aroben@apple.com> 6469 6470 Give WebKitLauncherWin's PDB file a name different from WebKit's 6471 6472 WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were 6473 fighting over the same PDB file, meaning that one of them was going to lose and not have 6474 symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb. 6475 6476 Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test 6477 runs (due to missing symbols) 6478 6479 Reviewed by David Kilzer. 6480 6481 * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name, 6482 "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file. 6483 64842011-03-01 Adam Roben <aroben@apple.com> 6485 6486 Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit 6487 6488 Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the 6489 --exit-after-n-crashes-or-timeouts limit 6490 6491 Reviewed by David Kilzer. 6492 6493 * Scripts/old-run-webkit-tests: 6494 (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print 6495 the number of tests that caused the web process to crash when exiting early. 6496 64972011-03-01 Adam Roben <aroben@apple.com> 6498 6499 Save a crash log when the web process crashes 6500 6501 On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit 6502 until it has finished crashing, which guarantees that the crash log will have had time to be 6503 saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash 6504 log, so all we have to do is choose the right crash log out of the CrashReporter directory. 6505 6506 Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and 6507 a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive 6508 6509 Reviewed by Sam Weinig. 6510 6511 * Scripts/old-run-webkit-tests: 6512 (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will 6513 kill itself. On Windows, this will cause us to wait until the crash log has been saved. On 6514 Mac, it should have no effect. Capture saved crash logs for web process crashes, too. 6515 (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for 6516 WebProces_*.crash files when the web process crashes. 6517 6518 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 6519 (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for 6520 initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData 6521 along to platformInitialize. 6522 6523 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above. 6524 6525 * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: 6526 (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle. 6527 6528 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: 6529 (WTR::InjectedBundle::platformInitialize): 6530 * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: 6531 (WTR::InjectedBundle::platformInitialize): 6532 Updated function signature. 6533 6534 * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: 6535 (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the 6536 webProcessCrashingEvent, then lets the crash continue as normal. 6537 6538 (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the 6539 event we should use to tell the UI process we're crashing from the initializationUserData, 6540 and get a handle to that event. 6541 6542 * WebKitTestRunner/TestController.cpp: 6543 (WTR::TestController::TestController): Initialize new members. 6544 (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to 6545 only print the "#CRASHED - WebProcess" message once, since this can be called more than once 6546 when a crash log is being saved on Windows. Exit right away if specified. (This is the 6547 default.) 6548 6549 * WebKitTestRunner/TestController.h: Added new members. 6550 6551 * WebKitTestRunner/win/TestControllerWin.cpp: 6552 (WTR::TestController::platformInitialize): Set up the event the web process will use to tell 6553 us it's crashing. 6554 (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to 6555 ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by 6556 ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent 6557 has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away 6558 so the test harness will know the web process has crashed and not try to kill us, then wait 6559 for the web process to finish crashing so a crash log will have time to be saved. 6560 (WTR::toWK): Simple hepler function. 6561 (WTR::TestController::platformInitializeContext): Pass along the name of the event the web 6562 process should use to tell us it is crashing in the context's initialization user data. 6563 65642011-03-01 Dimitri Glazkov <dglazkov@chromium.org> 6565 6566 Reviewed by Tony Gentilcore. 6567 6568 Move the checks to exclude Python/Perl tests for Chromium Win build to the right place. 6569 https://bugs.webkit.org/show_bug.cgi?id=55476 6570 6571 Chromium Win uses BuildAndTestFactory, not TestFactory. 6572 6573 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place. 6574 65752011-03-01 Adam Roben <aroben@apple.com> 6576 6577 Test that the WebKit2 responsiveness timer doesn't fire too early 6578 6579 Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too 6580 early on Windows 6581 6582 Reviewed by Anders Carlsson. 6583 6584 * TestWebKitAPI/PlatformUtilities.h: Added sleep(). 6585 6586 * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added. 6587 (TestWebKitAPI::didReceiveMessageFromInjectedBundle): 6588 (TestWebKitAPI::didFinishLoadForFrame): 6589 (TestWebKitAPI::processDidBecomeUnresponsive): 6590 (TestWebKitAPI::setInjectedBundleClient): 6591 (TestWebKitAPI::setPageLoaderClient): 6592 Simple helper functions. 6593 6594 (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then 6595 tell the web process to pause and press the spacebar key. The spacebar keypress should cause 6596 the responsiveness timer to start, but the web process should unpause before it has a chance 6597 to fire. Run until the web process has unpaused, and assert that the timer didn't fire. 6598 6599 * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added. 6600 (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest): 6601 Call up to the base class. 6602 (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to 6603 pause, sleep for 0.5 seconds, then send back a message saying we paused. 6604 6605 * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: 6606 (TestWebKitAPI::Util::sleep): Added. Calls through to usleep. 6607 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: 6608 (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep. 6609 6610 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 6611 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 6612 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: 6613 Added new files. 6614 66152011-03-01 Andras Becsi <abecsi@webkit.org> 6616 6617 Reviewed by Csaba Osztrogonác. 6618 6619 [Qt] Clean up the project files and move common options to WebKit.pri. 6620 6621 * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate. 6622 6623 66242011-03-01 Adam Roben <aroben@apple.com> 6625 6626 Skip another multiprocessing test on Windows 6627 6628 It is sometimes failing (and may be leaving child Python processes around). 6629 <http://webkit.org/b/55087> tracks the failure. 6630 6631 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: 6632 (FuncitonTests.test_get__processes): Skip this test on Windows. 6633 66342011-03-01 Ilya Tikhonovsky <loislo@chromium.org> 6635 6636 Reviewed by Pavel Feldman. 6637 6638 Web Inspector: reduce inspector tests flakiness. 6639 https://bugs.webkit.org/show_bug.cgi?id=55401 6640 6641 * DumpRenderTree/chromium/TestShell.cpp: 6642 (TestShell::runFileTest): 6643 * DumpRenderTree/chromium/WebPreferences.cpp: 6644 (WebPreferences::reset): 6645 66462011-02-28 Mihai Parparita <mihaip@chromium.org> 6647 6648 Reviewed by James Robinson. 6649 6650 NRWT should still upload results when it exits early due to too many failures 6651 https://bugs.webkit.org/show_bug.cgi?id=55432 6652 6653 Only keyboard interrupts should prevent results from being uploaded. 6654 6655 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 6656 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 6657 66582011-02-28 Alice Liu <alice.liu@apple.com> 6659 6660 Reviewed by Adam Roben and Gavin Barraclough. 6661 6662 Test for https://bugs.webkit.org/show_bug.cgi?id=54898 6663 InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle. 6664 6665 * TestWebKitAPI/InjectedBundleController.h: 6666 (TestWebKitAPI::InjectedBundleController::bundle): 6667 * TestWebKitAPI/PlatformWebView.h: 6668 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added. 6669 (TestWebKitAPI::didFinishLoadForFrame): 6670 (TestWebKitAPI::didReceiveMessageFromInjectedBundle): 6671 (TestWebKitAPI::setPageLoaderClient): 6672 (TestWebKitAPI::TEST): 6673 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added. 6674 (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest): 6675 (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu): 6676 (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage): 6677 * TestWebKitAPI/mac/PlatformWebViewMac.mm: 6678 (TestWebKitAPI::PlatformWebView::simulateRightClick): 6679 * TestWebKitAPI/win/PlatformWebViewWin.cpp: 6680 (TestWebKitAPI::PlatformWebView::simulateRightClick): 6681 6682 Added files to: 6683 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: 6684 * TestWebKitAPI/win/TestWebKitAPI.vcproj: 6685 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: 6686 66872011-02-28 Adam Roben <aroben@apple.com> 6688 6689 Start running InjectedBundle API tests on Windows 6690 6691 A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL. 6692 6693 Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows 6694 6695 Reviewed by Darin Adler. 6696 6697 * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added. 6698 * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added. 6699 * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added. 6700 * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added. 6701 * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added. 6702 These are just extracted from TestWebKitAPI.vcproj. 6703 6704 * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets 6705 up the DLL's filename. 6706 6707 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name. 6708 (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of 6709 0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string. 6710 6711 * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus 6712 "all" configuration. 6713 6714 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added 6715 injected bundle tests. Let VS resort things. 6716 6717 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj. 6718 67192011-02-28 Adam Roben <aroben@apple.com> 6720 6721 Add a test for the paint rect passed via WM_PAINT to windowless plugins 6722 6723 Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2: 6724 Large portions of pages with plugins paint black 6725 6726 Reviewed by Anders Carlsson. 6727 6728 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 6729 (PluginTest::NPP_HandleEvent): 6730 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 6731 Added NPP_HandleEvent. Just returns 0 at this level. 6732 6733 * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added. 6734 (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class. 6735 (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless. 6736 (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via 6737 WM_PAINT has the expected coordinates. 6738 6739 * DumpRenderTree/TestNetscapePlugIn/main.cpp: 6740 (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything 6741 else. 6742 6743 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS 6744 resort things. 6745 6746 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 6747 (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint. 6748 This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate 6749 webView:didFinishLoadForFrame:] in DumpRenderTree. 6750 6751 * WebKitTestRunner/win/PlatformWebViewWin.cpp: 6752 (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins 6753 can start running. 6754 67552011-02-28 Adam Roben <aroben@apple.com> 6756 6757 Tell MiniBrowser's WKViews that they're in a window 6758 6759 Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows 6760 6761 Reviewed by Anders Carlsson. 6762 6763 * MiniBrowser/win/BrowserView.cpp: 6764 (BrowserView::create): Call WKViewSetIsInWindow after creating the view. 6765 67662011-02-28 Alexis Menard <alexis.menard@openbossa.org> 6767 6768 Reviewed by Csaba Osztrogonác. 6769 6770 The new QML tests require QML_IMPORT_PATH variable to be set in order to 6771 load the proper plugin. 6772 6773 * Scripts/run-qtwebkit-tests: 6774 67752011-02-28 Joone Hur <joone.hur@collabora.co.uk> 6776 6777 Unreviewed, fix spelling mistake. 6778 6779 hardware-accelated => hardware-accelerated. 6780 6781 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 6782 67832011-02-28 Kristian Amlie <kristian.amlie@nokia.com> 6784 6785 Reviewed by Andreas Kling. 6786 6787 Made sure that the build-webkit --qmake argument is always respected. 6788 6789 Previously, it would be respected during the build, but not during 6790 the early feature detection. The build would also fail if qmake was 6791 not in your path, even if you specified --qmake with a valid qmake 6792 binary. 6793 6794 [Qt] WebKit patches required to work with a modularized version of Qt 6795 https://bugs.webkit.org/show_bug.cgi?id=53916 6796 6797 * Scripts/build-webkit: 6798 * Scripts/webkitdirs.pm: 6799 68002011-02-27 Ojan Vafai <ojan@chromium.org> 6801 6802 Fix failing tests from http://trac.webkit.org/changeset/79837. 6803 6804 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 6805 This was just a mistake that would break if someone tried printing with this configuration. 6806 * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: 6807 Method signature changed. Didn't notice that this method was being calling in a unittest. 6808 68092011-02-24 Hayato Ito <hayato@chromium.org> 6810 6811 Reviewed by Eric Seidel. 6812 6813 [NRWT] Remove test_types/* classes. 6814 6815 This is the last patch in the series of efforts which tried to remove test_types classes. 6816 A single_test_runner module will take over responsibilities of test_type classes. 6817 6818 From this patch, we won't display statistics per test_type even if a '--verbose' option is given. 6819 6820 https://bugs.webkit.org/show_bug.cgi?id=55123 6821 6822 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 6823 * Scripts/webkitpy/layout_tests/layout_package/test_results.py: 6824 * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py: 6825 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 6826 * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: 6827 * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed. 6828 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed. 6829 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed. 6830 * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed. 6831 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed. 6832 68332011-02-25 Ojan Vafai <ojan@chromium.org> 6834 6835 Reviewed by Tony Chang. 6836 6837 Change results.json format to the one used by unexpected_results.json 6838 https://bugs.webkit.org/show_bug.cgi?id=52267 6839 6840 Also add runtimes in milliseconds to the JSON and make the output format more compact. 6841 Named the file full_results.json to avoid conflicting with the results.json 6842 file the test-results server currently serves up. 6843 6844 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: 6845 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: 6846 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: 6847 * Scripts/webkitpy/layout_tests/layout_package/printing.py: 6848 * Scripts/webkitpy/layout_tests/layout_package/result_summary.py: 6849 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: 6850 68512011-02-27 Adam Roben <aroben@apple.com> 6852 6853 Followup fix to r79827 6854 6855 * DumpRenderTree/win/UIDelegate.cpp: 6856 (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with 6857 lastPathComponent. This matches what we did here before r79827, and matches Mac. 6858 68592011-02-27 Dan Bernstein <mitz@apple.com> 6860 6861 Reviewed by Adam Roben. 6862 6863 Make bisect-builds print a trac link for the regression range 6864 https://bugs.webkit.org/show_bug.cgi?id=55331 6865 6866 * Scripts/bisect-builds: 6867 68682011-02-27 Adam Roben <aroben@apple.com> 6869 6870 Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate 6871 6872 Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath 6873 EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or 6874 fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled 6875 6876 Reviewed by Anders Carlsson. 6877 6878 * DumpRenderTree/win/EditingDelegate.cpp: 6879 (indexOfFirstWordCharacter): 6880 (wordLength): 6881 Use iswalpha instead of isalpha, since TCHAR is really just wchar_t. 6882 68832011-02-27 Adam Roben <aroben@apple.com> 6884 6885 Make ResourceLoadDelegate print URLs relative to the main resource on Windows 6886 6887 This matches Mac. (In fact, the code was ported from Mac!) 6888 6889 Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't 6890 match Mac 6891 6892 Reviewed by Anders Carlsson. 6893 6894 * DumpRenderTree/win/DumpRenderTree.cpp: 6895 (substringFromIndex): Added. Emulates -[NSString substringFromIndex:]. 6896 (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras) 6897 _drt_descriptionSuitableForTestResult]. 6898 (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp. 6899 6900 * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString. 6901 6902 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to 6903 DumpRenderTree.cpp. 6904 69052011-02-27 Adam Roben <aroben@apple.com> 6906 6907 Change the order of Chang Shu's email addresses so the first one is their Bugzilla username 6908 6909 This makes Bugzilla autocompletion work correctly. 6910 6911 * Scripts/webkitpy/common/config/committers.py: 6912 69132011-02-27 Patrick Gansterer <paroga@webkit.org> 6914 6915 Reviewed by Andreas Kling. 6916 6917 [Qt] fast/loader/user-stylesheet-fast-path.html fails 6918 https://bugs.webkit.org/show_bug.cgi?id=50911 6919 6920 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 6921 (LayoutTestController::setUserStyleSheetLocation): 6922 Use QUrl::fromEncoded since the passed string is already encoded. 6923 69242011-02-27 Adam Roben <aroben@apple.com> 6925 6926 Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving 6927 6928 Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that 6929 is different from old-run-webkit-test's. Because of this, the path to the crash log file 6930 (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more 6931 details. 6932 6933 Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative 6934 --results-directory path is used (like on the test slaves) 6935 6936 Reviewed by Dan Bernstein. 6937 6938 * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've 6939 made $testResultsDirectory an absolute path. 6940 69412011-02-26 Dominic Mazzoni <dmazzoni@google.com> 6942 6943 Reviewed by Adam Barth. 6944 6945 m_dumpAccessibilityNotifications should be initialized. 6946 https://bugs.webkit.org/show_bug.cgi?id=54874 6947 6948 * DumpRenderTree/chromium/AccessibilityController.cpp: 6949 (AccessibilityController::AccessibilityController): 6950 69512011-02-26 Vsevolod Vlasov <vsevik@chromium.org> 6952 6953 Reviewed by Pavel Feldman. 6954 6955 DumpRenderTree should reset frame opener between tests. 6956 https://bugs.webkit.org/show_bug.cgi?id=54874 6957 6958 Added clearOpener() calls between tests. 6959 Some tests are using window.open() to change current window location. 6960 This changes window.opener property whose nullity is checked before 6961 showing xml viewer. 6962 6963 * DumpRenderTree/chromium/TestShell.cpp: 6964 (TestShell::resetTestController): 6965 * DumpRenderTree/gtk/DumpRenderTree.cpp: 6966 (resetDefaultsToConsistentValues): 6967 * DumpRenderTree/mac/DumpRenderTree.mm: 6968 (resetWebViewToConsistentStateBeforeTesting): 6969 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 6970 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 6971 * DumpRenderTree/win/DumpRenderTree.cpp: 6972 (resetWebViewToConsistentStateBeforeTesting): 6973 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 6974 (WTR::InjectedBundlePage::reset): 6975 69762011-02-26 Yael Aharon <yael.aharon@nokia.com> 6977 6978 Reviewed by Andreas Kling. 6979 6980 [Qt] Fix the focus in MiniBrowser. 6981 https://bugs.webkit.org/show_bug.cgi?id=55288 6982 6983 Give focus to the web view when a load starts. 6984 6985 * MiniBrowser/qt/BrowserWindow.cpp: 6986 (BrowserWindow::urlChanged): 6987 69882011-02-26 Gyuyoung Kim <gyuyoung.kim@samsung.com> 6989 6990 Reviewed by Adam Barth. 6991 6992 [EFL] Add coding style exceptions for EFL port 6993 https://bugs.webkit.org/show_bug.cgi?id=54733 6994 6995 The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased, 6996 underscore-sparated values. But, style checking rule have found parameter_name errors 6997 in efl directories so far. 6998 6999 * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories. 7000 70012011-02-26 David Levin <levin@chromium.org> 7002 7003 Reviewed by Darin Adler. 7004 7005 check-webkit-style should check for spaces after periods in comments 7006 https://bugs.webkit.org/show_bug.cgi?id=55253 7007 7008 * Scripts/webkitpy/style/checkers/cpp.py: Added the check. 7009 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests 7010 and fixed the name of one related test. 7011 70122011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org> 7013 7014 Reviewed by Andreas Kling. 7015 7016 Make it possible to test the targetdensity-dpi support 7017 https://bugs.webkit.org/show_bug.cgi?id=55142 7018 7019 Test the viewport meta tag feature targetdensity-dpi by 7020 adding extra arguments to dumpConfigurationForViewport 7021 7022 Add the new arguments to the shared header and all 7023 implementation. 7024 7025 * DumpRenderTree/LayoutTestController.cpp: 7026 (dumpConfigurationForViewportCallback): 7027 * DumpRenderTree/LayoutTestController.h: 7028 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7029 (LayoutTestController::dumpConfigurationForViewport): 7030 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 7031 (LayoutTestController::dumpConfigurationForViewport): 7032 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 7033 (LayoutTestController::dumpConfigurationForViewport): 7034 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 7035 (LayoutTestController::dumpConfigurationForViewport): 7036 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 7037 (LayoutTestController::dumpConfigurationForViewport): 7038 * DumpRenderTree/qt/LayoutTestControllerQt.h: 7039 70402011-02-26 Sheriff Bot <webkit.review.bot@gmail.com> 7041 7042 Unreviewed, rolling out r79764. 7043 http://trac.webkit.org/changeset/79764 7044 https://bugs.webkit.org/show_bug.cgi?id=55295 7045 7046 "broke Chromium builds" (Requested by rniwa on #webkit). 7047 7048 * DumpRenderTree/chromium/TestShell.cpp: 7049 (TestShell::resetTestController): 7050 * DumpRenderTree/gtk/DumpRenderTree.cpp: 7051 (resetDefaultsToConsistentValues): 7052 * DumpRenderTree/mac/DumpRenderTree.mm: 7053 (resetWebViewToConsistentStateBeforeTesting): 7054 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7055 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 7056 * DumpRenderTree/win/DumpRenderTree.cpp: 7057 (resetWebViewToConsistentStateBeforeTesting): 7058 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 7059 (WTR::InjectedBundlePage::reset): 7060 70612011-02-26 Yongjun Zhang <yongjun_zhang@apple.com> 7062 7063 Reviewed by David Kilzer. 7064 7065 https://bugs.webkit.org/show_bug.cgi?id=48781 7066 7067 Add a resource load delegate method to query if WebCore should paint the default broken image for failed images. 7068 7069 Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore 7070 should paint the default broken image when an image fails to load or decode. 7071 7072 * DumpRenderTree/LayoutTestController.cpp: 7073 (LayoutTestController::LayoutTestController): 7074 (setShouldPaintBrokenImageCallback): 7075 (LayoutTestController::staticFunctions): 7076 (LayoutTestController::setShouldPaintBrokenImage): 7077 * DumpRenderTree/LayoutTestController.h: 7078 (LayoutTestController::shouldPaintBrokenImage): 7079 * DumpRenderTree/mac/ResourceLoadDelegate.mm: 7080 (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]): 7081 70822011-02-26 Vsevolod Vlasov <vsevik@chromium.org> 7083 7084 Reviewed by Pavel Feldman. 7085 7086 DumpRenderTree should reset frame opener between tests. 7087 https://bugs.webkit.org/show_bug.cgi?id=54874 7088 7089 Added clearOpener() calls between tests. 7090 Some tests are using window.open() to change current window location. 7091 This changes window.opener property whose nullity is checked before 7092 showing xml viewer. 7093 7094 * DumpRenderTree/chromium/TestShell.cpp: 7095 (TestShell::resetTestController): 7096 * DumpRenderTree/gtk/DumpRenderTree.cpp: 7097 (resetDefaultsToConsistentValues): 7098 * DumpRenderTree/mac/DumpRenderTree.mm: 7099 (resetWebViewToConsistentStateBeforeTesting): 7100 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7101 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 7102 * DumpRenderTree/win/DumpRenderTree.cpp: 7103 (resetWebViewToConsistentStateBeforeTesting): 7104 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 7105 (WTR::InjectedBundlePage::reset): 7106 71072011-02-25 Lukasz Slachciak <l.slachciak@samsung.com> 7108 7109 Reviewed by Kenneth Rohde Christiansen. 7110 7111 [EFL] Added EWebLauncher command line option to turn on/off frame flattening 7112 https://bugs.webkit.org/show_bug.cgi?id=54809 7113 7114 * EWebLauncher/main.c: Handling -f option added. 7115 (on_key_down): 7116 (browserCreate): 7117 (main): 7118 71192011-02-25 Sheriff Bot <webkit.review.bot@gmail.com> 7120 7121 Unreviewed, rolling out r79324. 7122 http://trac.webkit.org/changeset/79324 7123 https://bugs.webkit.org/show_bug.cgi?id=55260 7124 7125 Leopard Debug is once again running out of address space while 7126 linking (Requested by aroben on #webkit). 7127 7128 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 7129 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 7130 71312011-02-25 Tony Chang <tony@chromium.org> 7132 7133 Reviewed by James Robinson. 7134 7135 Clean up temp files left by crashing DRTs on chromium-win 7136 https://bugs.webkit.org/show_bug.cgi?id=55182 7137 7138 * BuildSlaveSupport/build.webkit.org-config/master.cfg: 7139 * BuildSlaveSupport/chromium/remove-crash-logs: Added. 7140 71412011-02-25 Adam Roben <aroben@apple.com> 7142 7143 Double-check that modifying the registry worked 7144 7145 On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will 7146 still return a successful exit code. So we double-check here that the value we tried to 7147 write to the registry was really written. 7148 7149 Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash 7150 logs on Windows Vista/7 7151 7152 Reviewed by Darin Adler. 7153 7154 * Scripts/old-run-webkit-tests: 7155 (writeRegistryString): After trying to write the string value, check that it was really 7156 written. 7157 71582011-02-25 Adam Roben <aroben@apple.com> 7159 7160 Set the 32-bit post-mortem debugger on 64-bit OSes 7161 7162 The post-mortem debugger is controlled by some registry values in 7163 HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either 7164 set the values in that key, which will be used for 64-bit apps, or in the equivalent key 7165 under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and 7166 WebKitTestRunner are 32-bit, we want to use the latter location. 7167 7168 Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for 7169 64-bit apps, but should set it for 32-bit apps instead 7170 7171 Reviewed by Darin Adler. 7172 7173 * Scripts/old-run-webkit-tests: 7174 (readRegistryString): 7175 (writeRegistryString): 7176 Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where 7177 Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS. 7178 Passing --wow32 on a 32-bit OS will not have any effect. 7179 71802011-02-25 Adam Roben <aroben@apple.com> 7181 7182 Clean up code to set up crash log saving on Windows 7183 7184 Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly 7185 7186 Reviewed by David Kilzer. 7187 7188 * Scripts/old-run-webkit-tests: 7189 (readRegistryString): 7190 (writeRegistryString): 7191 Moved code to read strings from and write strings to the registry here... 7192 7193 (setUpWindowsCrashLogSaving): ...from here. 7194 71952011-02-25 Adam Roben <aroben@apple.com> 7196 7197 Work around Cygwin's crash-suppression behavior 7198 7199 Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will 7200 inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be 7201 invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode 7202 when our test apps launch to work around Cygwin's behavior. 7203 7204 Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem 7205 debugger) when launched from Cygwin 1.7 7206 7207 Reviewed by Darin Adler. 7208 7209 * DumpRenderTree/win/DumpRenderTree.cpp: 7210 (main): 7211 * TestWebKitAPI/win/main.cpp: 7212 (main): 7213 * WebKitAPITest/main.cpp: 7214 (main): 7215 * WebKitTestRunner/win/TestControllerWin.cpp: 7216 (WTR::TestController::platformInitialize): 7217 Call ::SetErrorMode(0) to undo Cygwin's folly. 7218 72192011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 7220 7221 Reviewed by Andreas Kling. 7222 7223 [Qt] Revert the support for QNAM affined to a different thread. 7224 https://bugs.webkit.org/show_bug.cgi?id=55149 7225 7226 Qt 4.8 will have QNAM use its own thread internally by default, 7227 no need to keep this complexity in WebKit. 7228 7229 This mainly reverts: 7230 http://trac.webkit.org/changeset/73710 7231 http://trac.webkit.org/changeset/73712 7232 7233 * QtTestBrowser/launcherwindow.cpp: 7234 (LauncherWindow::~LauncherWindow): 7235 (LauncherWindow::initializeView): 7236 (LauncherWindow::createChrome): 7237 * QtTestBrowser/launcherwindow.h: 7238 (WindowOptions::WindowOptions): 7239 * QtTestBrowser/webpage.cpp: 7240 (WebPage::WebPage): 7241 * QtTestBrowser/webpage.h: 7242 72432011-02-24 Adam Barth <abarth@webkit.org> 7244 7245 Reviewed by Eric Seidel. 7246 7247 Add a script for creating gypi files 7248 https://bugs.webkit.org/show_bug.cgi?id=55113 7249 7250 This is a trivial script to create gypi files from the source code in 7251 the current directory. 7252 7253 * Scripts/make-gypi: Added. 7254 72552011-02-24 Sheriff Bot <webkit.review.bot@gmail.com> 7256 7257 Unreviewed, rolling out r79628. 7258 http://trac.webkit.org/changeset/79628 7259 https://bugs.webkit.org/show_bug.cgi?id=55195 7260 7261 "broke chromium win tests" (Requested by dpranke on #webkit). 7262 7263 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 7264 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 7265 72662011-02-24 Dirk Pranke <dpranke@chromium.org> 7267 7268 Reviewed by Mihai Parparita. 7269 7270 rebaseline-chromium-webkit-tests can't handle GPU variants 7271 https://bugs.webkit.org/show_bug.cgi?id=55002 7272 7273 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 7274 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 7275 72762011-02-24 Dirk Pranke <dpranke@chromium.org> 7277 7278 Reviewed by Mihai Parparita. 7279 7280 nrwt: log command used to start web server to --verbose 7281 7282 https://bugs.webkit.org/show_bug.cgi?id=55188 7283 7284 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 7285 * Scripts/webkitpy/layout_tests/port/http_server.py: 7286 72872011-02-24 Victoria Kirst <vrk@google.com> 7288 7289 Reviewed by Mihai Parparita. 7290 7291 [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests 7292 https://bugs.webkit.org/show_bug.cgi?id=55089 7293 7294 This adds an alias into the media/ directory so that http/tests/media 7295 tests can access the media resources when running in an httpd process. 7296 7297 * Scripts/webkitperl/httpd.pm: 7298 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 7299 * Scripts/webkitpy/layout_tests/port/http_server.py: 7300 73012011-02-24 Dirk Pranke <dpranke@chromium.org> 7302 7303 Reviewed by Mihai Parparita. 7304 7305 nrwt: enable multiple processes by default on Chromium Win. 7306 7307 https://bugs.webkit.org/show_bug.cgi?id=55163 7308 7309 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 7310 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 7311 73122011-02-24 Sam Weinig <sam@webkit.org> 7313 7314 Attempt to fix Qt. 7315 7316 * WebKitTestRunner/TestInvocation.cpp: 7317 73182011-02-24 James Robinson <jamesr@chromium.org> 7319 7320 Unreviewed, rolling out r79598. 7321 http://trac.webkit.org/changeset/79598 7322 https://bugs.webkit.org/show_bug.cgi?id=55089 7323 7324 Appears to be causing trouble with httpd on windows 7325 7326 * Scripts/webkitperl/httpd.pm: 7327 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 7328 * Scripts/webkitpy/layout_tests/port/http_server.py: 7329 73302011-02-24 Sam Weinig <sam@webkit.org> 7331 7332 Reviewed by Darin Adler. 7333 7334 Add basic pixel testing support to WebKitTestRunner 7335 https://bugs.webkit.org/show_bug.cgi?id=55161 7336 7337 * Scripts/old-run-webkit-tests: 7338 Don't print color space information when using WebKitTestRunner since 7339 we don't need to change the screen. 7340 7341 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: 7342 (WTR::InjectedBundle::initialize): 7343 Add call to initializePlatformDefaults. 7344 7345 (WTR::InjectedBundle::done): 7346 Return a dictionary on completion with both the text output and pixel dump override. 7347 7348 * WebKitTestRunner/InjectedBundle/InjectedBundle.h: 7349 Add declaration for initializePlatformDefaults. 7350 7351 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 7352 (WTR::LayoutTestController::LayoutTestController): 7353 (WTR::LayoutTestController::dumpAsText): 7354 * WebKitTestRunner/InjectedBundle/LayoutTestController.h: 7355 (WTR::LayoutTestController::shouldDumpPixels): 7356 Make setting dumpAsText override the dump pixels preference. 7357 7358 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added. 7359 (WTR::InjectedBundle::initializePlatformDefaults): 7360 Set platform defaults matching DumpRenderTree. 7361 7362 * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added. 7363 (WTR::InjectedBundle::initializePlatformDefaults): 7364 * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added. 7365 (WTR::InjectedBundle::initializePlatformDefaults): 7366 Add stubs for initializePlatformDefaults. 7367 7368 * WebKitTestRunner/TestController.cpp: 7369 (WTR::TestController::runTest): 7370 (WTR::TestController::runTestingServerLoop): 7371 (WTR::TestController::run): 7372 Parse expected pixel results out of stdin and setup the invocation with it. 7373 7374 * WebKitTestRunner/TestInvocation.cpp: 7375 (WTR::TestInvocation::TestInvocation): 7376 Initialize new members. 7377 7378 (WTR::TestInvocation::~TestInvocation): 7379 (WTR::TestInvocation::setIsPixelTest): 7380 (WTR::sizeWebViewForCurrentTest): 7381 (WTR::TestInvocation::invoke): 7382 (WTR::TestInvocation::dump): 7383 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): 7384 * WebKitTestRunner/TestInvocation.h: 7385 Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected. 7386 7387 * WebKitTestRunner/mac/PlatformWebViewMac.mm: 7388 (WTR::PlatformWebView::PlatformWebView): 7389 Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space. 7390 7391 * WebKitTestRunner/mac/TestInvocationMac.mm: Added. 7392 (WTR::createCGContextFromPlatformView): 7393 (WTR::computeMD5HashStringForContext): 7394 (WTR::dumpBitmap): 7395 (WTR::forceRepaintFunction): 7396 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): 7397 Add mac specific pixel dumping support. Right now, we always pull pixels 7398 from the window server. 7399 7400 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: 7401 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 7402 * WebKitTestRunner/qt/WebKitTestRunner.pro: 7403 * WebKitTestRunner/win/InjectedBundle.vcproj: 7404 * WebKitTestRunner/win/WebKitTestRunner.vcproj: 7405 Add new files. 7406 74072011-02-24 Chang Shu <cshu@webkit.org> 7408 7409 Reviewed by Kenneth Rohde Christiansen. 7410 7411 [Qt] Launch MiniBrowser if the test run is WebKit2. 7412 https://bugs.webkit.org/show_bug.cgi?id=55145 7413 7414 * Scripts/old-run-webkit-tests: 7415 * Scripts/run-launcher: 7416 * Scripts/webkitdirs.pm: 7417 74182011-02-24 Victoria Kirst <vrk@google.com> 7419 7420 Reviewed by Mihai Parparita. 7421 7422 [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests 7423 https://bugs.webkit.org/show_bug.cgi?id=55089 7424 7425 This adds an alias into the media/ directory so that http/tests/media 7426 tests can access the media resources when running in an httpd process. 7427 7428 * Scripts/webkitperl/httpd.pm: 7429 * Scripts/webkitpy/layout_tests/port/apache_http_server.py: 7430 * Scripts/webkitpy/layout_tests/port/http_server.py: 7431 74322011-02-24 Andrew Wilson <atwilson@chromium.org> 7433 7434 Unreviewed, rolling out r79570. 7435 http://trac.webkit.org/changeset/79570 7436 https://bugs.webkit.org/show_bug.cgi?id=54874 7437 7438 Breaks chromium build because glue/mocks/mock_web_frame.h/cc 7439 was not updated 7440 7441 * DumpRenderTree/chromium/TestShell.cpp: 7442 (TestShell::resetTestController): 7443 * DumpRenderTree/gtk/DumpRenderTree.cpp: 7444 (resetDefaultsToConsistentValues): 7445 * DumpRenderTree/mac/DumpRenderTree.mm: 7446 (resetWebViewToConsistentStateBeforeTesting): 7447 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7448 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 7449 * DumpRenderTree/win/DumpRenderTree.cpp: 7450 (resetWebViewToConsistentStateBeforeTesting): 7451 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 7452 (WTR::InjectedBundlePage::reset): 7453 74542011-02-24 Mahesh Kulkarni <mahesh.kulkarni@nokia.com> 7455 7456 Reviewed by Laszlo Gombos. 7457 7458 [Qt] add android 2.2 user agent to QtTestBrowser 7459 https://bugs.webkit.org/show_bug.cgi?id=55085 7460 7461 Credit to Forrest Hodgkins to find right user-agent which works for youtube. 7462 * QtTestBrowser/useragentlist.txt: 7463 74642011-02-24 Adam Roben <aroben@apple.com> 7465 7466 Change FrameLoadDelegate to support any number of delegates with delayed work to process 7467 7468 This makes our behavior match Mac more closely, and allows us to remove an incorrect 7469 assertion that was firing during some tests. (The assertion was claiming that there was 7470 never more than one delegate with delayed work to process, but that was not the case.) 7471 7472 Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone 7473 when running http/tests/navigation/back-twice-without-commit.html 7474 7475 Reviewed by Eric Carlson. 7476 7477 * DumpRenderTree/win/FrameLoadDelegate.cpp: 7478 (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to 7479 process. A single delegate may appear in this Vector more than once (just as, on Mac, a 7480 single delegate may have multiple performSelector requests). 7481 (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an 7482 assertion that the timer firing is the shared process work timer. Instead of using the 7483 single, global "delegate waiting for timer" delegate, give all delegates that have delayed 7484 work to process a chance to process their work. 7485 (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for 7486 processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork 7487 Vector so our processWork function will be called when the timer fires. 7488 74892011-02-24 Vsevolod Vlasov <vsevik@chromium.org> 7490 7491 Reviewed by Alexey Proskuryakov. 7492 7493 DumpRenderTree should reset frame opener between tests. 7494 https://bugs.webkit.org/show_bug.cgi?id=54874 7495 7496 Added clearOpener() calls between tests. 7497 Some tests are using window.open() to change current window location. 7498 This changes window.opener property whose nullity is checked before 7499 showing xml viewer. 7500 7501 * DumpRenderTree/chromium/TestShell.cpp: 7502 (TestShell::resetTestController): 7503 * DumpRenderTree/gtk/DumpRenderTree.cpp: 7504 (resetDefaultsToConsistentValues): 7505 * DumpRenderTree/mac/DumpRenderTree.mm: 7506 (resetWebViewToConsistentStateBeforeTesting): 7507 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7508 (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 7509 * DumpRenderTree/win/DumpRenderTree.cpp: 7510 (resetWebViewToConsistentStateBeforeTesting): 7511 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 7512 (WTR::InjectedBundlePage::reset): 7513 75142011-02-24 Adam Roben <aroben@apple.com> 7515 7516 Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am 7517 7518 Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440, 7519 but did 7520 7521 Reviewed by Anders Carlsson. 7522 7523 * Scripts/webkitpy/common/config/build.py: 7524 (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the 7525 top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in. 7526 7527 * Scripts/webkitpy/common/config/build_unittest.py: 7528 (ShouldBuildTest): Added some more tests. 7529 75302011-02-24 Andras Becsi <abecsi@webkit.org> 7531 7532 Reviewed by Laszlo Gombos. 7533 7534 [Qt] MinGW build fails to link 7535 https://bugs.webkit.org/show_bug.cgi?id=55050 7536 7537 Prepend the libraries of subcomponents instead of appending them 7538 to fix the library order according to the dependency of the libraries 7539 7540 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: 7541 * WebKitTestRunner/qt/WebKitTestRunner.pro: 7542 75432011-02-24 Gabor Loki <loki@webkit.org> 7544 7545 Reviewed by Csaba Osztrogonác. 7546 7547 [Qt] Remove ARMv5 Release buildbot. 7548 7549 Remove ARMv5 Release buildbot, because there is very little difference 7550 between ARMv5 and ARMv7 Release bots, and there is also very little 7551 interest in ARMv5 build slave (compared to ARMv7). 7552 7553 * BuildSlaveSupport/build.webkit.org-config/config.json: 7554 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 7555 75562011-02-22 Ojan Vafai <ojan@chromium.org> 7557 7558 Reviewed by Tony Chang. 7559 7560 fix revision number finding when creating git patches 7561 https://bugs.webkit.org/show_bug.cgi?id=55024 7562 7563 HEAD~n does not walk merge commits correctly. git log however does. 7564 7565 * Scripts/webkitpy/common/checkout/scm.py: 7566 * Scripts/webkitpy/common/checkout/scm_unittest.py: 7567 75682011-02-23 Kenneth Russell <kbr@google.com> 7569 7570 Unreviewed, rolling out r79387. 7571 https://bugs.webkit.org/show_bug.cgi?id=54885 7572 7573 Reapply the code changes from r79038 since they weren't the root 7574 cause of the test timeouts. 7575 7576 * DumpRenderTree/chromium/WebViewHost.cpp: 7577 (WebViewHost::reset): 7578 75792011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com> 7580 7581 Reviewed by Laszlo Gombos. 7582 7583 [Qt] Make sure Symbian binary UIDs are unique 7584 7585 * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with 7586 QtTestBrowser.pro by changing the UID. 7587 75882011-02-23 Patrick Gansterer <paroga@webkit.org> 7589 7590 Reviewed by Darin Adler. 7591 7592 Rename PLATFORM(CF) to USE(CF) 7593 https://bugs.webkit.org/show_bug.cgi?id=53540 7594 7595 * DumpRenderTree/config.h: 7596 75972011-02-23 Dirk Pranke <dpranke@chromium.org> 7598 7599 Reviewed by Ojan Vafai. 7600 7601 nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults 7602 https://bugs.webkit.org/show_bug.cgi?id=55016 7603 7604 * Scripts/webkitpy/layout_tests/port/base.py: 7605 * Scripts/webkitpy/layout_tests/port/chromium_linux.py: 7606 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added. 7607 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 7608 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: 7609 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 7610 * Scripts/webkitpy/layout_tests/port/mac.py: 7611 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 7612 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 7613 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 7614 76152011-02-23 Tony Chang <tony@chromium.org> 7616 7617 Reviewed by Kent Tamura. 7618 7619 [chromium] DumpRenderTree --check-layout-test-sys-deps leaks 4 temp dirs 7620 https://bugs.webkit.org/show_bug.cgi?id=55004 7621 7622 * DumpRenderTree/chromium/DumpRenderTree.cpp: 7623 (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment): 7624 (WebKitSupportTestEnvironment::~WebKitSupportTestEnvironment): 7625 (main): Use a C++ object to ensure that TearDownTestEnvironment 7626 gets called when --check-layout-test-sys-deps is called 7627 76282011-02-23 Gopal Raghavan <gopal.1.raghavan@nokia.com> 7629 7630 Reviewed by Anders Carlsson. 7631 7632 [Qt] [Qt] check webkit style fails in qt/tests 7633 https://bugs.webkit.org/show_bug.cgi?id=54998 7634 7635 check-webkit-style was complaining about missing config.h in WebKit/qt/test/qdeclarativewebview. This patch was originally part of 50222. Reviewer suggested to split and create a separate patch for checker. 7636 7637 * Scripts/webkitpy/style/checker.py: 7638 76392011-02-22 Vsevolod Vlasov <vsevik@chromium.org> 7640 7641 Reviewed by Pavel Feldman. 7642 7643 DumpRenderTree should dump as text if test path contains "dumpAsText/" 7644 https://bugs.webkit.org/show_bug.cgi?id=54873 7645 7646 * DumpRenderTree/chromium/LayoutTestController.h: 7647 (LayoutTestController::setShouldDumpAsText): 7648 (LayoutTestController::setShouldGeneratePixelResults): 7649 * DumpRenderTree/chromium/TestShell.cpp: 7650 (TestShell::runFileTest): 7651 * DumpRenderTree/gtk/DumpRenderTree.cpp: 7652 (shouldDumpAsText): 7653 (dump): 7654 (runTest): 7655 * DumpRenderTree/mac/DumpRenderTree.mm: 7656 (shouldDumpAsText): 7657 (runTest): 7658 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: 7659 (WebCore::isDumpAsTextTest): 7660 (WebCore::DumpRenderTree::open): 7661 * DumpRenderTree/win/DumpRenderTree.cpp: 7662 (shouldDumpAsText): 7663 (runTest): 7664 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: 7665 (WTR::InjectedBundlePage::dump): 7666 76672011-02-22 Kenneth Russell <kbr@google.com> 7668 7669 Reviewed by James Robinson. 7670 7671 Many tests started timing out on the chrome mac canaries around r79035 7672 https://bugs.webkit.org/show_bug.cgi?id=54885 7673 7674 Revert the code changes, but not the Chromium DEPS roll, from 7675 r79038 to see whether this clears up the timing-out tests. Was not 7676 able to reproduce the timeouts locally with a Release mode build 7677 of DRT (on Snow Leopard). 7678 7679 * DumpRenderTree/chromium/WebViewHost.cpp: 7680 (WebViewHost::reset): 7681 76822011-02-22 Dirk Pranke <dpranke@chromium.org> 7683 7684 Reviewed by James Robinson. 7685 7686 nrwt: --platform chromium-gpu doesn't work with --worker-model=processes 7687 https://bugs.webkit.org/show_bug.cgi?id=55009 7688 7689 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: 7690 76912011-02-18 Mihai Parparita <mihaip@chromium.org> 7692 7693 Reviewed by Ojan Vafai. 7694 7695 Default to 500 for --exit-after-n-failures 7696 https://bugs.webkit.org/show_bug.cgi?id=54773 7697 7698 Make 500 the default value for --exit-after-n-failures (ORWT bots 7699 already default to this as of r75726). Similarly, change the default for 7700 --exit-after-n-crashes-or-timeouts to 20. 7701 7702 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 7703 77042011-02-02 Martin Robinson <mrobinson@igalia.com> 7705 7706 Reviewed by Xan Lopez. 7707 7708 [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace 7709 https://bugs.webkit.org/show_bug.cgi?id=53603 7710 7711 Add support for LayoutTestController.setSelectTrailingWhitespace by calling through 7712 to DumpRenderTreeSupportGtk for this functionality. 7713 7714 * DumpRenderTree/gtk/DumpRenderTree.cpp: 7715 (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to 7716 false when reseting values between tests. 7717 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 7718 (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace 7719 with the appropriate value. 7720 77212011-02-22 Adam Roben <aroben@apple.com> 7722 7723 Don't trigger a Windows build when the top-level ChangeLog changes 7724 7725 r79320 is an example of a change that shouldn't have built on Windows, but did, because of 7726 this bug. 7727 7728 Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but 7729 shouldn't 7730 7731 Reviewed by Anders Carlsson. 7732 7733 * Scripts/webkitpy/common/config/build.py: 7734 (_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level 7735 ChangeLog, and re-sorted it in the list. 7736 7737 * Scripts/webkitpy/common/config/build_unittest.py: 7738 (ShouldBuildTest): Added a test that ChangeLogs don't trigger builds. 7739 77402011-02-22 Sheriff Bot <webkit.review.bot@gmail.com> 7741 7742 Unreviewed, rolling out r78691. 7743 http://trac.webkit.org/changeset/78691 7744 https://bugs.webkit.org/show_bug.cgi?id=54956 7745 7746 Leopard Debug is successfully building again (Requested by 7747 aroben on #webkit). 7748 7749 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 7750 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 7751 77522011-02-22 Ilya Tikhonovsky <loislo@chromium.org> 7753 7754 Reviewed by Pavel Feldman. 7755 7756 Web Inspector: flakyness of inspector tests. 7757 https://bugs.webkit.org/show_bug.cgi?id=54729 7758 7759 As far as we have the protocol with sequence numbers we can simplify test harness support 7760 and drop out chomium specific methods. 7761 7762 * DumpRenderTree/DumpRenderTree.gypi: 7763 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: 7764 (DRTDevToolsAgent::sendMessageToInspectorFrontend): 7765 (DRTDevToolsAgent::runtimePropertyChanged): 7766 (DRTDevToolsAgent::asyncCall): 7767 (DRTDevToolsAgent::call): 7768 * DumpRenderTree/chromium/DRTDevToolsAgent.h: 7769 * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed. 7770 * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed. 7771 * DumpRenderTree/chromium/DRTDevToolsClient.cpp: 7772 (DRTDevToolsClient::sendMessageToBackend): 7773 (DRTDevToolsClient::asyncCall): 7774 (DRTDevToolsClient::call): 7775 * DumpRenderTree/chromium/DRTDevToolsClient.h: 7776 77772011-02-22 Andras Becsi <abecsi@webkit.org> 7778 7779 Reviewed by Laszlo Gombos. 7780 7781 [Qt] Redesign the build system 7782 https://bugs.webkit.org/show_bug.cgi?id=51339 7783 7784 Part 2. 7785 7786 Build WebCore as a static library, compile the WebKit API and WebKit2 API 7787 in a final step and link to WebKit2, WebCore and JSC libraries to fix 7788 linking issues resulting from stripped away symbols. 7789 7790 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths. 7791 77922011-02-21 Lukasz Slachciak <l.slachciak@samsung.com> 7793 7794 Reviewed by Antonio Gomes. 7795 7796 [EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed 7797 https://bugs.webkit.org/show_bug.cgi?id=54806 7798 7799 * EWebLauncher/main.c: 7800 (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added. 7801 78022011-02-21 Dirk Pranke <dpranke@chromium.org> 7803 7804 Reviewed by Kent Tamura. 7805 7806 nrwt: revert behavior on 10.5 to "old-threads". It's possible 7807 that r79062 has introduced a bunch of flakiness, although I 7808 can't explain why right now. This change should restore the 7809 old behavior, and then we can look at the build logs to see 7810 if the tests stop timing out or being flaky. 7811 7812 https://bugs.webkit.org/show_bug.cgi?id=54925 7813 7814 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 7815 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: 7816 * Scripts/webkitpy/layout_tests/port/mac.py: 7817 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 7818 78192011-02-21 Dirk Pranke <dpranke@chromium.org> 7820 7821 Reviewed by Dimitri Glazkov. 7822 7823 nrwt: fix typo causing us to try and repeatedly shut down the servers 7824 https://bugs.webkit.org/show_bug.cgi?id=54904 7825 7826 * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: 7827 78282011-02-21 Alejandro G. Castro <alex@igalia.com> 7829 7830 Reviewed by Csaba Osztrogonác. 7831 7832 REGRESSION(r79157): 7833 plugins/get-url-with-javascript-destroying-plugin.html make the 7834 next test crash 7835 https://bugs.webkit.org/show_bug.cgi?id=54863 7836 7837 * GNUmakefile.am: 7838 78392011-02-20 Dirk Pranke <dpranke@chromium.org> 7840 7841 Reviewed by Ojan Vafai. 7842 7843 test-webkitpy: stop skipping a bunch of tests on win32 7844 https://bugs.webkit.org/show_bug.cgi?id=54788 7845 7846 * Scripts/webkitpy/common/net/testoutputset_unittest.py: 7847 * Scripts/webkitpy/test/main.py: 7848 78492011-02-20 Dirk Pranke <dpranke@chromium.org> 7850 7851 Reviewed by Ojan Vafai. 7852 7853 Fix various bugs related to handling of dir separators and real 7854 vs. fake filesystems that were causing test-webkitpy to fail 7855 tests on win32. These bugs have a variety of causes but are 7856 lumped together because they should be easy to review. 7857 7858 https://bugs.webkit.org/show_bug.cgi?id=54700 7859 7860 * Scripts/webkitpy/common/net/testoutput.py: 7861 Here we were using os.path.sep but not escaping it prior to 7862 using in a regexp, which caused bad things on win32. 7863 * Scripts/webkitpy/common/net/testoutput_unittest.py: 7864 Same here. 7865 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: 7866 Here we were using the native filesystem instead of the mock 7867 filesystem, making some tests unnecessarily platform dependent. 7868 Also we weren't setting the default configuration for the 7869 TestChromiumWinPort. 7870 * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: 7871 Here we *shouldn't* use os.path.join(), just so the code becomes 7872 less platform dependent. 7873 * Scripts/webkitpy/style/checker.py: 7874 Here we should be using os.path.sep instead of "/"; the tests 7875 require the native filesystem. 7876 * Scripts/webkitpy/style/checkers/cpp_unittest.py: 7877 Here the underlying code is using os.path.sep, so we probably 7878 should as well. 7879 * Scripts/webkitpy/style/test_expectations_unittest.py: 7880 Here we should be using the filesystem hanging of the port 7881 object (which is the mocked filesystem) rather than the native 7882 one. 7883 78842011-02-20 Anders Carlsson <andersca@apple.com> 7885 7886 Reviewed by Maciej Stachowiak. 7887 7888 Crash when a plug-in requests a javascript: url that destroys the plug-in 7889 https://bugs.webkit.org/show_bug.cgi?id=54837 7890 <rdar://problem/9005475> 7891 7892 Add new plug-in test. 7893 7894 * DumpRenderTree/DumpRenderTree.gypi: 7895 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 7896 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: 7897 (PluginTest::NPN_GetURL): 7898 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: 7899 * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added. 7900 (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin): 7901 (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New): 7902 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: 7903 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 7904 79052011-02-19 Patrick Gansterer <paroga@webkit.org> 7906 7907 Reviewed by Andreas Kling. 7908 7909 Make WinCE a core builder 7910 https://bugs.webkit.org/show_bug.cgi?id=54801 7911 7912 * Scripts/webkitpy/common/net/buildbot/buildbot.py: 7913 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: 7914 79152011-02-19 Lukasz Slachciak <l.slachciak@samsung.com> 7916 7917 Reviewed by Andreas Kling. 7918 7919 Fixed problem with launching EWebLauncher with "run-launcher --efl". Incorrect path referring to non-existing .libs directory ws set. 7920 https://webkit.org/b/54778 7921 7922 * Scripts/webkitdirs.pm: 7923 79242011-02-18 David Levin <levin@chromium.org> 7925 7926 Reviewed by Eric Seidel. 7927 7928 check-webkit-style: Misses brace style error when the line with the { has a } in it. 7929 https://bugs.webkit.org/show_bug.cgi?id=54769 7930 7931 * Scripts/webkitpy/style/checkers/cpp.py: Fixed the check for the close brace 7932 to only look after the last open brace, so that the open brace in this line 7933 "} else {" will still be able to trigger the error. 7934 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added related unit tests. 7935 79362011-02-18 Zan Dobersek <zandobersek@gmail.com> 7937 7938 Reviewed by Martin Robinson. 7939 7940 [Gtk] Re-enable meter tag support 7941 https://bugs.webkit.org/show_bug.cgi?id=54762 7942 7943 Meter tag is supported on the Gtk port, enable it by default. 7944 7945 * Scripts/build-webkit: 7946 79472011-02-18 David Levin <levin@chromium.org> 7948 7949 Reviewed by Eric Seidel. 7950 7951 check-webkit-style falsely complains about WebKitGTK+ public headers 7952 https://bugs.webkit.org/show_bug.cgi?id=54650 7953 7954 * Scripts/webkitpy/style/checker.py: Add some exceptions for the gtk files. 7955 * Scripts/webkitpy/style/checkers/cpp.py: Restrict the checks for WEBKIT_API 7956 to the chromium directory (and improved the checks slightly). 7957 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added corresponding tests. 7958 79592011-02-18 Dirk Pranke <dpranke@chromium.org> 7960 7961 Reviewed by James Robinson. 7962 7963 new-run-webkit-tests: enable multiple processes by default on 7964 mac. This change removes the artificial restrictions we placed 7965 on the # of child processes we used with the old threading 7966 model, and switches to the new message-based model and multiple 7967 processes, where available. If multiple processes are not 7968 available (Leopard / Python 2.5), then we use the 'inline' model 7969 instead of the 'old-threads' model on the 'mac' port or one 7970 process on the 'chromium-mac' port. We need additional testing 7971 to see if the new 'threads' model works reliably and is worth 7972 supporting, or if we should just live with things being slightly 7973 slow. 7974 7975 https://bugs.webkit.org/show_bug.cgi?id=54596 7976 7977 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 7978 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: 7979 * Scripts/webkitpy/layout_tests/port/mac.py: 7980 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 7981 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 7982 79832011-02-18 Andrew Wilson <atwilson@chromium.org> 7984 7985 Unreviewed, rolling out r79047. 7986 http://trac.webkit.org/changeset/79047 7987 https://bugs.webkit.org/show_bug.cgi?id=54596 7988 7989 Broke canary bots - please watch the canaries the next time 7990 you land this 7991 7992 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 7993 * Scripts/webkitpy/layout_tests/port/mac.py: 7994 79952011-02-18 Emil A Eklund <eae@chromium.org> 7996 7997 Reviewed by Darin Adler. 7998 7999 Crash in EventHandler::sendContextMenuEventForKey 8000 https://bugs.webkit.org/show_bug.cgi?id=54495 8001 8002 Add support for the context menu key (VK_APPS) to EventSender for 8003 platforms that support the key. 8004 8005 * DumpRenderTree/chromium/EventSender.cpp: 8006 (EventSender::keyDown): 8007 * DumpRenderTree/gtk/EventSender.cpp: 8008 (keyDownCallback): 8009 * DumpRenderTree/qt/EventSenderQt.cpp: 8010 (EventSender::keyDown): 8011 * DumpRenderTree/win/EventSender.cpp: 8012 (keyDownCallback): 8013 80142011-02-18 Dirk Pranke <dpranke@chromium.org> 8015 8016 Reviewed by Ojan Vafai. 8017 8018 new-run-webkit-tests: enable multiple processes by default on mac 8019 https://bugs.webkit.org/show_bug.cgi?id=54596 8020 8021 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 8022 * Scripts/webkitpy/layout_tests/port/mac.py: 8023 80242011-02-18 Dirk Pranke <dpranke@chromium.org> 8025 8026 Reviewed by Adam Roben. 8027 8028 Skip pretty patch unit tests if ruby isn't installed. 8029 8030 https://bugs.webkit.org/show_bug.cgi?id=54699 8031 8032 * Scripts/webkitpy/common/prettypatch_unittest.py: 8033 80342011-02-18 Dirk Pranke <dpranke@chromium.org> 8035 8036 Reviewed by Adam Roben. 8037 8038 Skip mac.test_skipped_file_paths() when running on win32; the 8039 test has hardcoded '/' directory separators and since it's a 8040 port-specific test and we have coverage on other ports it's not 8041 worth it to make the test more generic. 8042 8043 https://bugs.webkit.org/show_bug.cgi?id=54698 8044 8045 * Scripts/webkitpy/layout_tests/port/mac_unittest.py: 8046 80472011-02-18 Dirk Pranke <dpranke@chromium.org> 8048 8049 Reviewed by Adam Roben. 8050 8051 Fix webkitpy.layout_tests.port.config_unittest to work on Win32. 8052 8053 https://bugs.webkit.org/show_bug.cgi?id=54703 8054 8055 * Scripts/webkitpy/layout_tests/port/config_unittest.py: 8056 80572011-02-18 Dirk Pranke <dpranke@chromium.org> 8058 8059 Reviewed by Adam Roben. 8060 8061 Change the default port we're mocking out on win32 when we 8062 run mock_drt_unittest. Normally we'd default to the 8063 port-specific default, but that would be "win", which doesn't 8064 currently work. 8065 8066 https://bugs.webkit.org/show_bug.cgi?id=54708 8067 8068 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: 8069 80702011-02-18 Kenneth Russell <kbr@google.com> 8071 8072 Reviewed by James Robinson. 8073 8074 [chromium] Clean up initialization of minimum timer interval 8075 https://bugs.webkit.org/show_bug.cgi?id=54772 8076 8077 Use new GetForegroundTabTimerInterval function in webkit_support 8078 to reset the minimum timer interval before each test. 8079 8080 * DumpRenderTree/chromium/WebViewHost.cpp: 8081 (WebViewHost::reset): 8082 80832011-02-18 Dirk Pranke <dpranke@chromium.org> 8084 8085 Reviewed by Adam Roben. 8086 8087 r78494 fixed the chromium_win unittest failing under win32, 8088 but not cygwin. This fixes cygwin as well. 8089 8090 https://bugs.webkit.org/show_bug.cgi?id=54652 8091 8092 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 8093 80942011-02-18 Dirk Pranke <dpranke@chromium.org> 8095 8096 Reviewed by Ojan Vafai, Mihai Parparita. 8097 8098 new-run-webkit-tests: r78522 made it impossible to create a 8099 'chromium-win' or 'chromium-mac' port; they would always get the 8100 version tacked on to the end. It turns out that we actually need 8101 to be able to create these ports in order for 8102 rebaseline-chromium-webkit-tests to work correctly given the 8103 broken coverage of our layout bots. As soon as we get SL and 8104 Win 7 bots running reliably on the canaries, we can get rid of 8105 this change. Note that we only need to change the chromium_mac 8106 and win ports because linux doesn't yet use versions and that 8107 script doesn't work with non-chromium ports. 8108 8109 Also, this change fixes a bug where we were using 8110 "platform/chromium-win-win7" and 8111 "platform/chromium-mac-snowleopard" as the baseline dirs for 8112 Win 7 and SL; we should've been using the generic directories 8113 instead since they are the newest versions of the os's. 8114 8115 https://bugs.webkit.org/show_bug.cgi?id=54691 8116 8117 * Scripts/webkitpy/layout_tests/port/chromium_mac.py: 8118 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: 8119 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 8120 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 8121 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: 8122 81232011-02-16 MORITA Hajime <morrita@google.com> 8124 8125 Reviewed by Kent Tamura. 8126 8127 [Chromium][DRT] some PostDelayedTask() accesses possibly dangling this pointer. 8128 http://webkit.org/b/53899 8129 8130 Replaced static invocation wrappers with MethodTask objects, 8131 which are removed on WebViewHost destructor. 8132 8133 * DumpRenderTree/chromium/WebViewHost.cpp: 8134 (WebViewHost::requestCheckingOfText): 8135 (WebViewHost::scheduleAnimation): 8136 (WebViewHost::closeWidgetSoon): 8137 * DumpRenderTree/chromium/WebViewHost.h: 8138 (WebViewHost::HostMethodTask::HostMethodTask): 8139 (WebViewHost::HostMethodTask::runIfValid): 8140 (WebViewHost::taskList): 8141 81422011-02-07 Hayato Ito <hayato@chromium.org> 8143 8144 Reviewed by Ojan Vafai. 8145 8146 Get rid of code which writes test results from test_type's 8147 compare_output() method. 8148 Writing test results now happens in single_test_runner, using 8149 newly introduced test_result_writer module. 8150 8151 Subsequent patches will eliminate test_type/* classes. 8152 8153 https://bugs.webkit.org/show_bug.cgi?id=53908 8154 8155 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: 8156 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added. 8157 * Scripts/webkitpy/layout_tests/test_types/image_diff.py: 8158 * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: 8159 * Scripts/webkitpy/layout_tests/test_types/text_diff.py: 8160 81612011-02-17 Dirk Pranke <dpranke@chromium.org> 8162 8163 Reviewed by Adam Roben. 8164 8165 Add blacklist of remaining webkitpy/* modules that fail on 8166 Win32, so that test-webkitpy will at least run cleanly. 8167 8168 https://bugs.webkit.org/show_bug.cgi?id=54709 8169 8170 * Scripts/webkitpy/layout_tests/test/main.py: 8171 81722011-02-17 Simon Fraser <simon.fraser@apple.com> 8173 8174 Reviewed by Sam Weinig. 8175 8176 Set a preference to ensure that scrollbars are in a predictable 8177 state for DRT. 8178 8179 * DumpRenderTree/mac/DumpRenderTree.mm: 8180 (resetDefaultsToConsistentValues): 8181 81822011-02-17 Dirk Pranke <dpranke@chromium.org> 8183 8184 Reviewed by Adam Roben. 8185 8186 test-webkitpy doesn't work with the multiprocessing module on win32 8187 or cygwin, so we skip it for now. 8188 8189 https://bugs.webkit.org/show_bug.cgi?id=54520 8190 8191 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: 8192 * Scripts/webkitpy/layout_tests/layout_package/run_webkit_tests_unittest.py: 8193 81942011-02-17 Dirk Pranke <dpranke@chromium.org> 8195 8196 Reviewed by Adam Roben. 8197 8198 Fix version, baseline_search_path for chromium-win-win7. Also 8199 fix chromium_win_unittests, and fix port_testcase.make_port() 8200 to correctly use the options passed into it and only set 8201 results_directory() if necessary. 8202 8203 https://bugs.webkit.org/show_bug.cgi?id=54652 8204 8205 * Scripts/webkitpy/layout_tests/port/chromium_win.py: 8206 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: 8207 * Scripts/webkitpy/layout_tests/port/port_testcase.py: 8208 82092011-02-17 Dirk Pranke <dpranke@chromium.org> 8210 8211 Reviewed by Ojan Vafai. 8212 8213 Fix a hang in new-run-webkit-tests when run with 8214 --dry-run --worker-model=processes 8215 8216 https://bugs.webkit.org/show_bug.cgi?id=54595 8217 8218 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: 8219 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: 8220 82212011-02-17 Kevin Ollivier <kevino@theolliviers.com> 8222 8223 [wx] Build fixes after recent changes. 8224 8225 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 8226 (LayoutTestController::setMinimumTimerInterval): 8227 * wx/build/settings.py: 8228 82292011-02-17 Csaba Osztrogonác <ossy@webkit.org> 8230 8231 Reviewed by Andreas Kling. 8232 8233 [Qt] ImageDiff sometimes hangs 8234 https://bugs.webkit.org/show_bug.cgi?id=54641 8235 8236 * DumpRenderTree/qt/ImageDiff.cpp: Clear actualImage and baselineImage after all comparison. 8237 (main): 8238 82392011-02-17 Peter Varga <pvarga@webkit.org> 8240 8241 Reviewed by Csaba Osztrogonác. 8242 8243 The run-sunspider --v8-suite doesn't work 8244 https://bugs.webkit.org/show_bug.cgi?id=54660 8245 8246 * Scripts/run-sunspider: 8247 82482011-02-17 Gabor Rapcsanyi <rgabor@webkit.org> 8249 8250 Reviewed by Csaba Osztrogonác. 8251 8252 [NRWT] Fix environment setup on Qt port. 8253 https://bugs.webkit.org/show_bug.cgi?id=54549 8254 8255 * Scripts/webkitpy/layout_tests/port/qt.py: 8256 82572011-02-16 Yael Aharon <yael.aharon@nokia.com> 8258 8259 Reviewed by Andreas Kling. 8260 8261 [Qt] Enable tiled backing store by default in MiniBrowser. 8262 https://bugs.webkit.org/show_bug.cgi?id=54581 8263 8264 Instead of a flag to turn it on, a new flag is defined to turn 8265 tiled backing store off. 8266 8267 * MiniBrowser/qt/MiniBrowserApplication.cpp: 8268 (MiniBrowserApplication::handleUserOptions): 8269 * MiniBrowser/qt/MiniBrowserApplication.h: 8270 (WindowOptions::WindowOptions): 8271 82722011-02-16 Eric Seidel <eric@webkit.org> 8273 8274 Reviewed by Mihai Parparita. 8275 8276 flaky test archive uploads are always 22 bytes long 8277 https://bugs.webkit.org/show_bug.cgi?id=54593 8278 8279 Speculative fix for the 22-bytes bug. 8280 8281 * Scripts/webkitpy/tool/bot/flakytestreporter.py: 8282 82832011-02-16 Anna Cavender <annacc@chromium.org> 8284 8285 Reviewed by Mihai Parparita. 8286 8287 http/tests/media should be served over HTTP (not from local file) 8288 https://bugs.webkit.org/show_bug.cgi?id=54028 8289 8290 Removed special file:// treatment of http/tests/media 8291 8292 * Scripts/old-run-webkit-tests: 8293 * Scripts/webkitpy/layout_tests/port/base.py: 8294 82952011-02-16 Mihai Parparita <mihaip@chromium.org> 8296 8297 Reviewed by Ojan Vafai. 8298 8299 ChangeLog.parse_latest_entry_from_file does not handle rolled over ChangeLogs 8300 https://bugs.webkit.org/show_bug.cgi?id=54609 8301 8302 r78737 rolled over ChangeLogs, and webkit-patch complains when landing 8303 patches such as this one that are the first to add an entry to the 8304 ChangeLog (since they don't see a second date line to know where the 8305 entry ends). 8306 8307 * Scripts/webkitpy/common/checkout/changelog.py: 8308 * Scripts/webkitpy/common/checkout/changelog_unittest.py: 8309 8310== Rolled over to ChangeLog-2011-02-16 == 8311
